Brian Coca
19038a71bf
Merge pull request #9419 from willthames/aws_frankfurt
...
There are still a couple of modules that use their own lists, but that should not prevent this merge, those should be adapted to use this list in subsequent patch
11 years ago
Jonathan Davila
a93db1948e
expanded facts
11 years ago
Brian Coca
e0f72d5861
fixed json encoding issue with redis
11 years ago
Brian Coca
ed380136bc
removed uneeded and posibly error producing json import
...
now uses utils.jsonify which does proper utf8 encoding
11 years ago
Michael Scherer
d4bf3127ec
Add a explicit error when fact_caching_connection is not set
...
By default, jsonfile is not documented, and the error message
when fact_caching_connection is not set is a bit puzzling, so
a error message would be beeter ( documentation too ). While redis
is faster for bigger setup, jsonfile is fine for a small setup
and is easier to deploy.
The module will then stop ansible-playbook, as this match better
the philosophy of Ansible being a fail-fast system.
11 years ago
Toshio Kuratomi
64c256b356
git module now with clone parameter and update=no reverted
11 years ago
Nathan Cahill
6d785ca081
support variables with dashes - fixes #9786
11 years ago
Toshio Kuratomi
2664de55fb
Fix math filters
11 years ago
Toshio Kuratomi
fa6e587654
Pull in some new fixes to core modules
11 years ago
Toshio Kuratomi
c808c8a22a
Fix some of the new math filters
11 years ago
Toshio Kuratomi
7ab1e52575
Merge pull request #9832 from bcoca/math_filters
...
math filters!
11 years ago
Brian Coca
b07ce8b942
removed redundant math functions as jinja2 provides abs() and round()
...
already
11 years ago
Brian Coca
7a43d40050
math filters!
11 years ago
Toshio Kuratomi
dc8207177e
Merge pull request #9830 from nathancahill/vars_prompt-no-value
...
Fix vars_prompt no/false default values
11 years ago
Toshio Kuratomi
d09b64884f
Merge pull request #9810 from mscherer/fix_7732
...
Do not use the variable name as a key for the result of the module
11 years ago
Toshio Kuratomi
828adbf788
Merge pull request #9807 from swimlappy/noproxy
...
Request: Honor the "no_proxy" environment variable in Ansible
11 years ago
Nathan Cahill
cc5a5978ef
fix vars_prompt no/false values
11 years ago
Toshio Kuratomi
d1e27fe819
Merge pull request #9805 from mscherer/fix_9395
...
Strip the line to filter lines composed of only whitespaces
11 years ago
Toshio Kuratomi
735c8d3c4b
Update core so docs build
11 years ago
Toshio Kuratomi
07e483b0c0
Update core modules
11 years ago
Jon Hawkesworth
e37b63386c
Revised following comments from Chris Church.
...
Now uses sha1 checksums following merge of 9688.
Also I undid the changes I made to fetch.py
win_template.py now uses conn.shell.has_trailing_slash and
conn.shell.join_path
updated integration tests.
11 years ago
root
bf916fb58a
Adding first pass at win_copy, win_file and win_template modules.
11 years ago
Jonathan Mainguy
8278626dd0
Added distribution facts for OpenSuse
11 years ago
Michael Scherer
9b8a55032d
Do not use the variable name as a key for the result of the module
...
Using the variable name can interfere with various systems
used to communicate between modules and ansible ( as
reported in #7732 , where ansible_facts is a reserved key for
updating the fact cache, for example ).
11 years ago
Jason Holland
eedc51f213
Add support for SSL protocol version configuration option. Also fix 2 places where the SSL version was not being set properly.
11 years ago
Jason Holland
38dbce1527
Allow Ansible to honor the "no_proxy" environment varaible.
11 years ago
Michael Scherer
b84fba4439
Strip the line to filter lines composed of only whitespaces
...
Fix #9395
11 years ago
Toshio Kuratomi
12968acd5f
Update the core modules to pull in some fixes
11 years ago
Brian Coca
215359084b
Merge pull request #9375 from mantiz/fix-osfamily-and-distribution-on-archlinux
...
Fix os_family and distribution on archlinux
11 years ago
Nicolas Rémond
3cf0c09ce9
Variables lookup in a template should handle properly the undefined case
11 years ago
Michael Scherer
7bffc1a29e
add a default path in ~/.ansible to place plugins, so ansible is a bit
...
more usable out of the box as simple user
11 years ago
jszwedko
462471209e
Allow retries to be templatable
...
Fixes #5865
11 years ago
Toshio Kuratomi
2d266ce401
Update core submodule for docs fix
11 years ago
Brian Coca
21bb12ee84
updated refs to module repos
11 years ago
Toshio Kuratomi
c16b83af14
Updat ecore to pull in new git module fixes
11 years ago
Toshio Kuratomi
35cfeefdc1
Update core modules
11 years ago
Toshio Kuratomi
55cb55d67a
Update the extras submodules to latest
11 years ago
Brian Coca
c725aa5e47
updated submodule refs
11 years ago
Michael DeHaan
d4da58e102
Merge pull request #9720 from vlajos/typofixes-vlajos-20141204
...
typofixes - https://github.com/vlajos/misspell_fixer
11 years ago
Toshio Kuratomi
3a5aec9743
file does not exist is not an error when checksumming for the template modules
11 years ago
Toshio Kuratomi
f2d2f425ae
Fix comment
11 years ago
Toshio Kuratomi
3269a349f3
Fix remote_checksum with delegate_to and add tests for several ways that delegate_to works
11 years ago
Toshio Kuratomi
2a288141d3
Fix template module to fail if remote checksumming failed
11 years ago
Toshio Kuratomi
b042fcc349
Fix for delegate_to with hosts that aren't in inventory
11 years ago
Veres Lajos
bf5d8ee678
typofixes - https://github.com/vlajos/misspell_fixer
11 years ago
Toshio Kuratomi
3b80f63e22
Have known_hosts function use the url parameter instead of getting a specific attribute out of the module dict.
...
This makes the function useful in more places
11 years ago
Brian Coca
97408fe5b2
Revert "Make listify respect the global setting for undefined variables."
...
This 'mostly' reverts commit 2769098fe7 .
Conflicts:
lib/ansible/utils/__init__.py
test/units/TestUtils.py
11 years ago
Brian Coca
e938f554b7
better exception handling for unexpected exceptions
11 years ago
Toshio Kuratomi
ae17b993d9
Update modules to allow USAGE as a valid grant option for postgres
11 years ago
Toshio Kuratomi
a2b2e54992
Fix checksum code to work with delegate_to/local_action
...
Fixes #9704
11 years ago
James Keener
4dfd86d847
Issue-9704 Better handling of missing python
...
When they python interpreter is set incorrectly for the machine the file
is being checked for (e.g. for the local or the remote), the error
manifests as a readability or directory missing error which can be very
misleading.
11 years ago
Brian Coca
1c5f625295
corrected exception name
11 years ago
Toshio Kuratomi
1ec8b6e3c5
Have remote_expanduser honor sudo and su users.
...
Fixes #9663
11 years ago
James Cammarata
f1386bb114
Use more variable sources when templating the play ds
...
Fixes #9699
11 years ago
Toshio Kuratomi
eeec4f73e7
Pull in doc fixes for modules
11 years ago
Toshio Kuratomi
05435f380b
Update to newer core and extras modules
11 years ago
Brian Coca
61a30e5f49
better exception handling with delegated hosts
11 years ago
Devin Christensen
8130ed8de0
Allow .gitkeep in the jsonfile fact cache dir
11 years ago
Chris Church
2bf269568b
Merge pull request #9688 from cchurch/fix_win_fetch
...
Fixes for fetch module when connecting to Windows hosts
11 years ago
Brian Coca
84bcc6a123
Merge pull request #9685 from bcoca/plugin_load_precedence
...
changed plugin load priority to be path based, not suffix based.
11 years ago
James Cammarata
29d41bb789
Revise patch from earlier using even more variable sources for HostVars
...
Superceeds e61e8a3
Fixes #9684
11 years ago
Chris Church
de267b5655
Fix PowerShell plugin issues affecting fetch module when used against Windows hosts.
11 years ago
Brian Coca
f2b853f7a0
changed plugin load priority to be path based, not suffix based.
11 years ago
James Cammarata
6570a6c6de
Use additional vars when templating included file names
...
Fixes #9669
11 years ago
Toshio Kuratomi
86b21a1b8d
Integration tests for https://github.com/ansible/ansible-modules-core/issues/416
11 years ago
James Cammarata
e61e8a37f5
Use extra vars when creating HostVars
...
Fixes #9667
11 years ago
Justin Wyer
8146d1fff3
/sys/block/sdX/queue/physical_block_size does not correlate with /sys/block/sdX/size for advanced drives larger than 2TB, /sys/block/sdX/queue/logical_block_size correlates with both see #9549
11 years ago
Thomas Quinot
23d959db71
Report location (filename and line number) for inventory syntax errors
...
When AnsibleError is raised for a syntax error in an inventory file,
report filename and line number to help pinpointing the error.
11 years ago
Brian Coca
60b51ef6c3
Merge pull request #9646 from bcoca/listify_template_fixes
...
fine tuned lookup/templating errors
11 years ago
Brian Coca
9a5cbf747a
fine tuned lookup/templating errors
11 years ago
Toshio Kuratomi
ae054dbc40
Pull in a fix for specifying a single role attribute for postgresql users
11 years ago
Toshio Kuratomi
0752549f02
Merge pull request #9640 from hkariti/premature_template_playbook_vars
...
Don't template play vars by themselves, it's too early
11 years ago
Toshio Kuratomi
4afa7ca1b1
Refresh the core modules to pull in mysql fix
11 years ago
Hagai Kariti
bc505050b0
Don't template play vars by themselves, it's too early
11 years ago
Baptiste Mathus
a1adff4ff0
Setting LC_MESSAGES: prevent unparseable messages
...
This locale variable defines how tools should display their messages.
This is for example gonna change the yum message from "Nothing to do" to
"Rien a faire" in my case (french).
As the yum module parses that string in err, if the message is not
enforced in english this is gonna fail.
So this commits just enriches a bit more the code that's already written
for that enforcement.
This commit fixes issue #9635 .
11 years ago
Toshio Kuratomi
704f7d7b40
Fix for a traceback in the git module
11 years ago
Toshio Kuratomi
b992a18378
Really update to a newer core module version :-)
11 years ago
James Cammarata
75d05168e6
Bumping files for 1.9
11 years ago
Brian Coca
90a6c82d55
Merge pull request #9626 from bcoca/minor_template_fixes
...
fixes to template function
11 years ago
Brian Coca
db145a368d
now only flattened ignores failonundefined cause of it's special need
11 years ago
James Cammarata
968c56d765
Expand playbook_dir in time for loading tasks
...
Fixes #9618
11 years ago
Brian Coca
e3feb104c3
fixes issues with listyfing failing too often
11 years ago
Brian Coca
7d2937b1cc
minor fixes to template function
...
- make sure it calls itself correctly, now passes same params as it recieves
- vars is reserved, changed for templatevars to avoid confustion
- forcing mustaches again since the removal broke 'listification' as per #9622
- fixes incorrectly successful tests using undefined var, now it is defined
- now returns empty list if items is None to avoid errors
11 years ago
Toshio Kuratomi
9a77aefc33
Special case the lone asterisk fragment in mysql
11 years ago
Toshio Kuratomi
199d6c0b8b
Fix some problems with the generic quote char
11 years ago
Toshio Kuratomi
8e7447962e
Update the modules to pull in mysql identifier escaping
11 years ago
Toshio Kuratomi
fcf0975c90
Fix a few mysql related typos
11 years ago
Toshio Kuratomi
0287e9a23d
Normalize the identifier quoting so we can reuse the functions for mysql
11 years ago
Toshio Kuratomi
19606afe5f
Update postgresql modules so that we get all the quoting of identifier
...
fixes
11 years ago
Toshio Kuratomi
64a8ad9a21
Remove debugging code
11 years ago
Toshio Kuratomi
067112b5ee
Code for modules to perform more robust quoting of database identifiers
11 years ago
Marc Abramowitz
e8716fcbc8
Display more info when SSH errors occur
11 years ago
Chris Church
e9b6aaf5d8
Update PowerShell command line processing to handle parameters passed via splatting.
11 years ago
Chris Church
de2746ae86
Set delegate on connection prior to calling connect.
11 years ago
Kishin Yagami
ac4dc1f739
enable environment keyword at play level
11 years ago
Brian Coca
5e33db3b7e
Merge pull request #9573 from bcoca/jsonfile_cache
...
a cache plugin that stores facts persistently in local json dumps
11 years ago
Toshio Kuratomi
f6f02c93e7
Update to HEAD of hte modules
11 years ago
James Cammarata
4b6b58ab11
Fix role parameter precedence after 9a0f8f0
...
Fixes #9497
11 years ago
Brian Coca
0edaa6f790
Merge pull request #9270 from bcoca/do_the_shuffle
...
added new 'shuffle' filter
11 years ago
Toshio Kuratomi
11b634104f
Small fix to hardlink handling in file module
11 years ago
Toshio Kuratomi
554858f3af
Update core modules to pull in a git module fix
11 years ago
Toshio Kuratomi
c4c3cc315d
Transform both values of a task name into a byte str prior to comparing
...
Fixes #9571
11 years ago
Michael DeHaan
36401fdb97
Update git submodules.
11 years ago
Michael DeHaan
f8ca975c75
The Guru program has been folded in with Ansible Tower. Have
...
questions or interested in Ansible support? We'd love to hear from you.
Email us at info@ansible.com .
11 years ago
Toshio Kuratomi
0defe19c4b
Update core modules for apt fix
11 years ago
Brian Coca
91b0149c52
a cache plugin that stores facts persistently in local json dumps
11 years ago
Toshio Kuratomi
25607e5cf4
When run in FIPS mode, allow vault to fail only when using legacy format
11 years ago
James Cammarata
9a0f8f0158
Split out various vars-related things to avoid merging too early
...
Fixes #9498
11 years ago
Michael DeHaan
2c520655ae
Merge pull request #9452 from erjohnso/google_endpoint_provider
...
Google: allow for different libcloud provider to support upcoming DNS mo...
11 years ago
Toshio Kuratomi
c3c6a07e65
Update apt test for newer version of test package and pull in an apt module fix
11 years ago
Toshio Kuratomi
b95475c1f9
Unittest the get_split_image_tag function in the docker module
11 years ago
Brian Coca
dd60036fb9
added changed status to return when new early create check is triggered,
...
added skipped check to test on create existing
11 years ago
Toshio Kuratomi
11e79d9627
Update core modules to pull in latest apt fixes
11 years ago
Brian Coca
e79acf3f88
Merge pull request #9261 from jonhadfield/skip-unarchive3
...
Fix issue whereby file will be transferred before checking the creates argument
11 years ago
Brian Coca
504995bda2
allow fact objects to be instantiated w/o triggering all fact collection
...
this opens the ability to do specific facts at much lower cost.
11 years ago
Jon Hadfield
697582fdde
Fix issue whereby file will be transferred before checking the creates argument.
11 years ago
Brian Coca
0990a71ab5
Merge pull request #9516 from 0x44/new-regions
...
Support new AWS regions: cn-north-1, eu-central-1.
11 years ago
Toshio Kuratomi
b828b25784
Add a fips fact and use it for integration tests
11 years ago
James Cammarata
5bc81f9ae7
Add ability to detect prompts in stdout from run_command
11 years ago
Brian Coca
395952329a
Merge pull request #9529 from sivel/env-nested-modules
...
Support nested modules with ANSIBLE_LIBRARY env var
11 years ago
Toshio Kuratomi
9a7eb57718
Some changes to FIPS compat since SLES implements it differently
11 years ago
Toshio Kuratomi
d4d23b1b1f
Add error when checksumming will fail because python is not present on the remote.
...
Comments for how the remote checksumming works.
Make the checksumming marginally more robust.
11 years ago
Toshio Kuratomi
565e5bbdfc
Fix up the new expand_user method.
...
quoting anywhere in the user_home_path interferes with shell expansion
so we have to check it for validity ourselves.
11 years ago
Toshio Kuratomi
bc4272d2a2
Expand tilde remotely in action plugins
11 years ago
Toshio Kuratomi
6a85f3ebc7
Add comments/docstrings not to use md5 unless forced to by forces outside our control.
11 years ago
Toshio Kuratomi
3ccb0b8243
Revert expanding hte tilde in shell plugin until we determine why it's forcing fetch down an alternate path
11 years ago
Toshio Kuratomi
cfe9f1c32f
Expand tilde in path names
11 years ago
Toshio Kuratomi
30c50020a1
Better way to get the python_interpreter inventory variable
11 years ago
Matt Martz
4c2d06d2fe
Support nested modules with ANSIBLE_LIBRARY env var
11 years ago
Ding Deng
b63ca685df
Support new AWS regions: cn-north-1, eu-central-1.
11 years ago
Toshio Kuratomi
f1267c0b05
Move from md5 to sha1 to work on fips-140 enabled systems
11 years ago
Matt Martz
047dffdd01
Fix rax_find_loadbalancer issues
...
* Loadbalancer IDs are not UUIDs
* Ensure found list exists before using it
11 years ago
Brian Coca
22ef830814
fixed ssh fix, bad test case but it should work now
11 years ago
Brian Coca
a2ba0c03e4
added error handling on private key stat in case it is saved in agent
...
but not in filesystem
11 years ago
Michael DeHaan
cbad867f24
Submodule update for docs reorg of module subcategories.
11 years ago
Brian Coca
7ac52bb601
updated to latest core module, another init/packing issue, should be
...
last
11 years ago
Brian Coca
96a97e9414
updated ref to core with updated cloud sublcases with __init__.py
11 years ago
Michael DeHaan
d3da2edfe3
Update submodule pointers for new docs org.
11 years ago
Brian Coca
afd8cca345
Merge pull request #9451 from bcoca/load_aliases
...
Load aliases
11 years ago
James Cammarata
9ae0fb5bdf
Make OSX fallback to paramiko more selective
...
Only fallback to paramiko now when the ssh password has been set,
either through inventory or via a prompt.
Fixes #9470
11 years ago
James Cammarata
4168a3e858
Merge pull request #9462 from tkinz27/paramiko_keepalive
...
Setting keepalive option before opening session
11 years ago
akinsley
3e992b5824
Setting keepalive option before opening session
...
Setting the keepalive option before opening up the paramiko session
in order to avoid the slim chance that the connection is stalled
in the short time between opening the session and setting up the
keepalive. I described the issue I am solving at
https://groups.google.com/forum/#!topic/ansible-project/rkwvz3vyvLk
11 years ago
Will Thames
2397926b94
Handle case where boto needs an upgrade to recognise a new region
...
Raise an exception if boto does not yet know about a region.
11 years ago
Stuart Henderson
419872373e
set CPU architecture correctly for OpenBSD (powerpc not macppc, etc.)
11 years ago
Eric Johnson
a2498bdadd
Google: allow for different libcloud provider to support upcoming DNS module
11 years ago
Jure Triglav
2f869a6309
Add the default Homebrew path for OpenSSL certs on OS X
11 years ago
Toshio Kuratomi
82e8d677d9
Test the git changes for the git module's recursive flag
11 years ago
Toshio Kuratomi
b502cb8f5d
Pull in git submodule tracking
11 years ago
Landry Breuil
792d8d1808
Ignore swap or altroot entries
11 years ago
Brian Coca
b3b356480d
added the ability to keep aliased and deprecated modules prefixed with
...
'_', they will be loaded after non prefixed modules are checked they can
be full modules or symlinks to existing ones (alias)
also updated ansible doc to ignore these, will eventually add selective
display
11 years ago
Landry Breuil
d68eb7272e
parse /etc/fstab on OpenBSD to get mount facts
11 years ago
Monty Taylor
61ae3c732f
Add required_if to AnsibleModule
...
There is a common pattern in modules where some parameters are required
only if another parameter is present AND set to a particular value. For
instance, if a cloud server state is "present" it's important to
indicate the image to be used, but if it's "absent", the image that was
used to launch it is not necessary. Provide a check that takes as an
input a list of 3-element tuples containing parameter to depend on, the
value it should be set to, and a list of parameters which are required
if the required parameter is set to the required value.
11 years ago
Will Thames
5ceb07c65a
Add Frankfurt AWS region
11 years ago
Toshio Kuratomi
c86851be2c
Quote ControlPath ssh parameter
...
Fixes #9316
11 years ago
Maykel Moya
c15b47fb7b
Configure retry file usage and location
...
Adds new settings for managing retry files:
* retry_files_enabled, defaults to True
* retry_files_save_path, defaults to ~/.ansible-retry
This change was adapted from PR #5515 .
11 years ago
Toshio Kuratomi
34129a223d
update core submodules for systemd service fix
11 years ago
James Cammarata
76a43d4b38
Updating submodule pointer for core modules
11 years ago
James Cammarata
9ee3cd14ee
Fix typo in vault edit helper code
...
Fixes #9399
11 years ago
James Cammarata
b4f9631e4c
Revert "remove complex_args_hack as it was only needed for Baby JSON"
...
This reverts commit a6029264b8 .
Fixes #9400
11 years ago
James Cammarata
4c47c2273a
Use convert_bare instead of string formatting for raw vars in debug action plugin
11 years ago
James Cammarata
987f7750ec
Merge pull request #9388 from mwarkentin/patch-2
...
Add host to polling message
11 years ago
Toshio Kuratomi
3d135f98d1
Small python3 compat in vault to keep code in sync with v2
11 years ago
Toshio Kuratomi
da9d87b1d4
Make vault file creation use a tempfile
11 years ago
Toshio Kuratomi
694e0420ab
Update the modules to pull in the files module needed for the updated
...
integration tests
11 years ago
Toshio Kuratomi
feb9ed1de8
Fix template module incorrectly handling mode when dest is a directory
...
Fixes #9350
11 years ago
Michael Warkentin
18a9282e0d
Add host to polling message
...
The message for when an async task has finished has the hostname in it. This adds it to the polling message as well:
```
<job 390794962174.18311> finished on 107.6.24.140
<job 390794962174.31779> finished on 69.90.50.171
<job 390794962174.12328> polling on 69.90.50.172, 6840s remaining
```
11 years ago
James Cammarata
b61a78532c
Catch template syntax errors specifically when templating strings
...
Fixes #9333
11 years ago
James Cammarata
28fd4df787
Merge pull request #9382 from gquintard/WIP/newdockerdetection
...
Detect docker as virtualization_type
11 years ago
James Cammarata
efb40969b3
Merge pull request #9381 from debfx/facts_virt_kvm
...
Detect kvm guests through sys_vendor.
11 years ago
Guillaume Quintard
895da79d87
Detect docker as virtualization_type
...
New docker versions use "docker" in /proc/1/cgroup, which disturbs the
virtualization_type detection. So, grep for docker, in addition of
"lxc".
11 years ago
Felix Geyer
ee5f5ee00d
Detect kvm guests through sys_vendor.
...
The two detection methods currently implemented do not cover all cases.
For example qemu guests invoked like this:
qemu -machine pc-i440fx-1.4,accel=kvm -cpu SandyBridge
return this information:
product_name: Standard PC (i440FX + PIIX, 1996)
cpuinfo: model name : Intel Xeon E312xx (Sandy Bridge)
11 years ago
Christian Hammerl
5efc4efca7
Fix os_family and distribution on archlinux
...
Fixes #8732 , ansible/ansible-modules-core#34
11 years ago
Toshio Kuratomi
938b2108d0
Move the v2 tests under the v2 tree
11 years ago
Toshio Kuratomi
139e4767e4
Merge pull request #9329 from mcodd/devel
...
python2.4 compatibility issue with urlparse
11 years ago
Marcin Praczko
1917906dd6
Fix detecting distribution release on OpenSuSE
...
Ansible raised exception during parsering /etc/SuSE-release file.
Regular expresion should use string instead of list.
Fix tested on OpenSuse 13.1
11 years ago
Matt Coddington
10113e6a67
python2.4 compatibility issue with urlparse
11 years ago
Michael DeHaan
ccd559137f
add missing headers, rm the subtree of ansible/inventory as we wish to overhaul it.
11 years ago
James Cammarata
2eda9a3a47
Fixing item loop when undefined variable errors occur because of missing attributes
...
Fixes a case where the variable 'foo' may exist, but the with_items loop
was used on something like 'foo.results', where 'results' was not a valid
attribute of 'foo'. Prior to this patch, conditionals were not evaluated
until later, meaning there was no opportunity to allow a test to skip the
task or item based on it being undefined.
11 years ago
Toshio Kuratomi
b4f84c5d9a
Update the core and extras submodules
11 years ago
Toshio Kuratomi
2b9e235ffd
Rework distribution fact checking to be a little less heinous and add
...
support for Mandriva.
Fixes #9282
11 years ago
James Cammarata
d19fe8d95d
Fetch vars for host directly when calculating the delegated user
...
This fixes the case in which the delegated to host may not be in the
specified hosts list, in which cases facts/vars for the host were
not available in the injected hostvars.
This also fixes the inventory variable fetching function, so that an
unknown host raises a proper error as opposed to a NoneType exception.
Fixes #8224
11 years ago
James Cammarata
2a0d18b092
Insert newlines correctly when splitting literal blocks
...
Fixes #9274
11 years ago
James Cammarata
383a44a462
Updating submodule pointer for core
11 years ago
Toshio Kuratomi
48a308a87c
Allow both old-style and new-style role dependencies to be valid.
...
Fixes #9173
11 years ago
Toshio Kuratomi
c75aeca435
Merge removal of complex_args_hack
11 years ago
Toshio Kuratomi
a10d10f647
Workaround more python-2.6 shlex not being able to handle unicode strings
11 years ago
Toshio Kuratomi
a6029264b8
remove complex_args_hack as it was only needed for Baby JSON
11 years ago
Brian Coca
b592d7653d
unchained list coercion as it removed the randomization
11 years ago
Chris Church
8fb88be41b
Simpler fix for module suffixes than c02e8d8c8.
11 years ago
Brian Coca
7a94d566e5
tried to ensure input is always a list but will now be a noop for non
...
listable items
11 years ago
Rob Howard
2769098fe7
Make listify respect the global setting for undefined variables.
...
(Fixes #9008.)
With credit to jimi-c for the initial pass in this commit:
b18bd6b98e
11 years ago
James Cammarata
f3714c88a6
Revert "atfork import warning should be suppressed when system_warnings = False"
...
This reverts commit a175168686 .
11 years ago
James Cammarata
12d5b75a43
Template play vars after reading them
...
Fixes #9242
11 years ago
Brian Coca
3534bdf953
added new 'shuffle' filter
11 years ago
James Cammarata
05644686de
Fix bug in plugin path caching
...
Fixes #9263
11 years ago
Bruce Pennypacker
a175168686
atfork import warning should be suppressed when system_warnings = False
...
Fixes #9247
11 years ago
Michael DeHaan
b02afa2268
Update submodule reference
11 years ago
Michael DeHaan
335221d79e
This is an exceedingly rough sketch of what attributes might look like - metaclass implementations NOT complete.
11 years ago
James Cammarata
0c40c6c23c
Fix order of resolving dependent role variables from vars files
...
Also adds a new class to the test_var_precedence test to check for
this type of error in the future.
Fixes #9178
11 years ago
Michael DeHaan
402d0c37b8
Submodule update
11 years ago
Michael DeHaan
b4657234d2
Refresh submodule pointers.
11 years ago
Michael DeHaan
4e4308b8e1
Merge branch 'refactor_pass' into devel
11 years ago
Michael DeHaan
ff87ac08a7
An attempt at modularization prior to moving things towards BaseObject and considering Attributes.
11 years ago
Toshio Kuratomi
cef2a8795f
Make dynamic inventory return byte str, not unicode
11 years ago
Michael DeHaan
da01eef4db
Move v2 out of the package tree so it does not yet appear.
11 years ago
Michael DeHaan
afe1409a6e
Have a parallel development and test tree.
11 years ago
Michael DeHaan
7fb55c7a9b
Some restructuring.
11 years ago
Michael DeHaan
7ebf246ff1
Some signature related things, prior to starting test scaffolding
11 years ago
Michael DeHaan
b8e4e59d6b
Signatures
11 years ago
James Cammarata
daab8e7ad4
Creating initial framework for refactoring core codebase
11 years ago
James Cammarata
d99e4f15c8
Merge pull request #9220 from jlaska/devel
...
Resolve issue where repo_path contains multiple '.git' strings
11 years ago
James Cammarata
313f26f866
Fix issue with vars precedence from roles
...
Fixes #9219
11 years ago
Toshio Kuratomi
0af750e3e5
Merge pull request #9182 from bbasleeper/feature_sudo_exe_from_inventory
...
Add a new inventory parameter (ansible_sudo_exe) to specify sudo command...
11 years ago
James Cammarata
05994cd900
Don't clear paths when adding a new directory path in PluginLoader
11 years ago
James Laska
684352926b
Resolve issue where repo_path contains multiple '.git' strings
...
If the repo_path contained multiple '.git' strings, the _git_repo_info()
call resulted in a traceback. This change removes the trailing '.git'
and resolves the traceback.
11 years ago
Toshio Kuratomi
cf548baeab
Fix missing strip() in a1809a371a
11 years ago
Toshio Kuratomi
a1809a371a
Target unnecessary templating warning at lines consisting of a single variable
...
Fixes #6407
11 years ago
Michael DeHaan
459722899d
Update core link
11 years ago
Michael DeHaan
c02e8d8c80
Don't search powershell modules unless using the winrm connection.
11 years ago
Michael DeHaan
3908d50b03
Tolerate no module search path.
11 years ago
Michael DeHaan
1d17881960
Add module search path to --version output.
11 years ago
Michael DeHaan
91c5890247
Add some helpful detection if core modules are not found for those running on the development branch.
11 years ago
Michael DeHaan
21c3784a43
If submodules are not found, don't error out.
11 years ago
Will Thames
952a36920c
Cater for uninitialized submodules
...
Output a useful message if `git submodule update --init --recursive` not
yet performed
```
$ ansible --version
ansible 1.8 (submodule_ansible_version 59ae596484) last updated 2014/09/28 13:20:51 (GMT +1000)
lib/ansible/modules/core: (detached HEAD 617a52b20d ) last updated 2014/09/28 13:15:25 (GMT +1000)
lib/ansible/modules/extras: not found - use git submodule update --init lib/ansible/modules/extras
```
11 years ago
Will Thames
d1476aeb01
Updated version info to include submodule information
...
`ansible --version` etc. now include information about submodules
```
ansible 1.8 (submodule_ansible_version ffee9a8fe0 ) last updated 2014/09/28 11:03:14 (GMT +1000)
lib/ansible/modules/core: (ec2_snapshot_remove 3a77c31ecb) last updated 2014/09/27 18:23:31 (GMT +1000)
lib/ansible/modules/extras: (detached HEAD 110250d344 ) last updated 2014/09/27 14:33:42 (GMT +1000)
```
Also improved handling of detached HEAD when printing out version
information.
11 years ago
Bruno BAILLUET
a25da4af05
Add a new inventory parameter (ansible_sudo_exe) to specify sudo command path.
11 years ago
Michael DeHaan
bceb0026a5
Updating the module formatter to deal with the new repo structure.
11 years ago
Michael DeHaan
e5116d2f9b
changes for package loading of modules
11 years ago
Michael DeHaan
25cc79e2db
Modules is a package.
11 years ago
Michael DeHaan
9249d1db28
Add submodules for new core and extras subdirectories of modules, not yet live.
11 years ago
James Cammarata
6af5455edc
Default 'smart' connection to paramiko for OSX platforms
...
Due to the long-standing bug in sshpass, which can crash OSX.
Fixes #5007
11 years ago
James Cammarata
128c10b311
Don't template 'vars' dictionary during templating
...
Fixes #9132
11 years ago
James Cammarata
19703617b8
Fix action_plugins for modules not respecting check mode
...
Fixes #9140
11 years ago
Marc Abramowitz
e0015395de
Expose more facts about user on host system
...
Adds:
- `user_uid`
- `user_gid`
- `user_gecos`
- `user_dir`
- `user_shell`
11 years ago
James Cammarata
c4f1785217
Use split_args instead of shlex to split include params
...
Fixes #8947
11 years ago
James Cammarata
4e9c061b35
Also make sure the dest param is expanded locally before recalculating
11 years ago
James Cammarata
e47f6137e5
Push the expanduser call on the source down to slurp rather than fetch
...
Also moves the calculation of the destination file name until after
the slurp of the file contents, since the source as returned by slurp
may now be different, so we want to use that expanded path locally.
Fixes #8942
11 years ago
James Cammarata
889dfc4374
Merge pull request #8959 from willthames/galaxy_ssh_clone
...
Allow fairly common ssh repo clone path to work
11 years ago
Jakub Roztocil
0073d2dd92
Remove unreachable code.
11 years ago
Toshio Kuratomi
f16e107b72
Merge pull request #9014 from willthames/paramiko_sudo_no_prompt
...
Allow _remote_md5 to work with passwordless sudo even if password is supplied
11 years ago
James Cammarata
9d45f3a65e
Before decrypting check if vault password is set or error early
...
Fixes #8926
11 years ago
James Cammarata
da5de725d7
Allow with_first_files to search relative to templates and vars in roles
...
Fixes #8879
11 years ago
James Cammarata
c3612e08f9
Move delegate_to out of runner module_vars to prevent bleeding across runs
...
Previously, the delegate_to value was stored in the module_vars of runner,
which could lead to bleeding that value across runs and incorrect hosts
being delegated to. This patch moves the value to a local variable in
the Runner class with some related refactoring of _compute_delegate() in
Runner (since the value is no longer required to be a parameter).
Fixes #8705
11 years ago
James Cammarata
ed3c9c40ca
Redoing patch for hostvars fix, since the previous one broke other tests
11 years ago
James Cammarata
3180a37457
Revert "Revert to using just the combined_cache for HostVars"
...
This reverts commit e9229cfeaa .
11 years ago
James Cammarata
e9229cfeaa
Revert to using just the combined_cache for HostVars
11 years ago
James Cammarata
4a9cf3f3f2
Allow hostvars variables to be templated
...
Fixes #7844
11 years ago
James Cammarata
b376e208c7
Adding "follow" param for file/copy options
...
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.
Fixes #8998
11 years ago
Will Thames
2303044ffc
Applied fix for sudo with no prompt to paramiko
...
Effectively reproduces @sivel's work from #8900 but for
the paramiko connection. Fixes #8418 when using paramiko
This allows `_remote_md5` to work if a sudo password is
passed in when no sudo password is required.
11 years ago
Matt Martz
de77f33796
Don't throw away useful stdout and stderr. Fixes #8418
...
When supplying a sudo password to a server that uses passwordless sudo,
we should not throw away useful stdout and stderr. This is particularly
important for modules that perform md5 checks as part of the pre module
execution.
11 years ago
James Cammarata
cdf938f2c2
Ensure remote files are chmod'd properly for su/su_user too
...
Fixes #8594
11 years ago
James Cammarata
0c4a7492bf
Ensure checkmode is honored for templates that haven't changed
...
Fixes #8998
11 years ago
Michael DeHaan
fb13e2bf2e
Merge pull request #8853 from kvar/devel
...
zypper: handle lists of packages efficiently
11 years ago
James Cammarata
503f7afbd8
Merge branch 'hfinucane-gh-7432' into devel
11 years ago
James Cammarata
61c76245da
Don't printout async callbacks when the task is skipped
11 years ago
James Cammarata
178075489b
Merge branch 'gh-7432' of https://github.com/hfinucane/ansible into hfinucane-gh-7432
11 years ago
Michael DeHaan
d6e6d2a6ca
Remove regex related to baby-JSON parsing only.
11 years ago
Michael DeHaan
d9e0a5ed22
Use correct keyword for this function.
11 years ago
Michael DeHaan
26cdddaebf
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
11 years ago
James Cammarata
e54178f904
Catch additional errors in fetch_url
...
Fixes #8971
11 years ago
James Cammarata
dacb6b8561
Use utils.merge_hash() instead of update for cache merging
...
Fixes #8968
11 years ago
James Cammarata
317ab06bc6
Fixing multiline parsing to preserve newlines
...
Fixes #8813
11 years ago
James Cammarata
a571fd4efe
Convert boolean strings from set_fact to proper boolean values
...
Also adds integration tests for booleanification of strings
Fixes #8629
11 years ago
James Cammarata
8708a00cbd
Fix typo in redis cache change from 10afaee1
11 years ago
Michael DeHaan
2064d26085
Add documentation about bin_ansible_callbacks setting. Standardization and cleanup.
11 years ago
Will Thames
d6a725659e
Allow github style ssh repo names
11 years ago
Will Thames
537472f42c
Make ansible-galaxy work as expected
...
This change fixes hg galaxy roles
Roles also get installed if roles path is missing, which
the tests currently require (fixes #8950 )
11 years ago
James Cammarata
10afaee108
Fixing new caching related issue with host vars
...
The vars_cache was not being properly merged with the setup_cache
for all hosts, which was previously not noticed when registered
variables were stored in the setup_cache.
Fixes #8944
11 years ago
Serge van Ginderachter
69740b86e8
Allow InventoryScript JSON with childgroups only
...
and without hosts and vars
Without this patch, the simplified syntax is triggered when a group
is defined like this:
"platforms": {
"children": [
"cloudstack"
]
}
Which results in a group 'platforms' with 1 host 'platforms'.
modified: lib/ansible/inventory/script.py
11 years ago
James Cammarata
dc1f233e8d
Merge pull request #8923 from nfelger/devel
...
Fixing issue with symlinked vaults
11 years ago
James Cammarata
c610783f90
Merge pull request #8911 from bbasleeper/devel
...
Adding a new 'load_callback_plugins' config option, defaults to False
11 years ago
Niko Felger
fa74a5c806
Fixing issue with symlinked vaults
11 years ago
James Cammarata
1711df3b75
Allow complex_args to be None
11 years ago
Bruno BAILLUET
16108e4a99
Adding a new 'load_callback_plugins' config option, defaults to False
...
This option, when set to True, allows "ansible" command to load callback plugins
11 years ago
James Cammarata
8cc3543918
Re-allow templating of complex_args, but count params to prevent injection
...
Fixes #8810
11 years ago
James Cammarata
8bafc646cb
Disable custom https handler for fetch_url on older pythons
...
Fixes #8898
11 years ago
Toshio Kuratomi
8233522a7a
Reduce commenting as basic.py is copied to the remote host with every module transfer.
...
Move some comments to the unittest as we might look at that if we decide
to refactor the code.
11 years ago
Toshio Kuratomi
1afc8161a1
New password obfuscation in syslog messages that:
...
* makes speed acceptable for some datasets
* obfuscates multiple detected passwords
* obfuscates more characters to account for some corner cases when
trying to detect passwords.
Fixes #8364
11 years ago
Toshio Kuratomi
4f55bcc298
Standardize on bytes internally to _log_invocation
11 years ago
Michael Scherer
53830123fd
Make ssh debug easier to read and paste
...
Currently, ansible -vvvv show the following:
hostname EXEC ['ssh', '-C', '-vvv', '-o', 'ControlMaster=auto',
This is not good if someone want to cut and paste it to see if something
is wrong with the command line, so join the dictionnary strings with spaces
to have 1 string in the output.
11 years ago
James Cammarata
cd99821f8a
Fix py26 difference in ssl socket connect call from 99ba9d6
11 years ago
James Cammarata
14b8e2cf01
Make sure set_fact variables go into VARS_CACHE
...
Fixes #8758
11 years ago
James Cammarata
893f15b30b
Merge pull request #8856 from sivel/memcached-factcache-improvements
...
Memcached factcache improvements
11 years ago
Matt Martz
9bc9145abd
Compress all data inserted into memcached to avoid memcached size limits
11 years ago
Matt Martz
2a4079eeb6
Update format fields to work with python2.6
11 years ago
James Cammarata
b827f791e1
Merge pull request #8832 from sivel/rax-validate-regions
...
rax modules: Perform region validation early
11 years ago
James Cammarata
f44957de5c
Merge pull request #8818 from Erethon/devel
...
Handle exceptions during config file parsing
11 years ago
James Cammarata
35dfbff2e1
Merge pull request #8817 from meatballhat/support-sunos-certs-location
...
Supporting SSL cert location on SunOS (SmartOS, really)
11 years ago
Matt Martz
55ed4489e3
Perform region validation early to be more explicit about invalid region failures
11 years ago
Kristofor Varhus
acd37c87a9
zypper: handle lists of packages efficiently
11 years ago
Henry Finucane
36632c9529
Ensure ansible_job_id exists even for not-started jobs
11 years ago
Dionysis Grigoropoulos
f948b4f293
Handle exceptions during config file parsing
...
Handle uncaught exceptions during config file parsing
11 years ago
Dan Buch
290f2759e1
Supporting SSL cert location on SunOS (SmartOS, really)
11 years ago
Trond Hindenes
72760f5999
All changes referenced in PRs #8767 , #8768 , #8769 :
...
This changes the get-attr function slightly, and lets the module specify whether a param is needed and auto-fails if it is not present. A module can now verify params like so::
$params = Parse-Args $args;
$result = New-Object psobject;
Set-Attr $result "changed" $false;
$path = Get-Attr -obj $params -name path -failifempty $true -resultobj $result
or
$params = Parse-Args $args;
$result = New-Object psobject;
Set-Attr $result "changed" $false;
$path = Get-Attr -obj $params -name path -failifempty $true -emptyattributefailmessage "Oh man. You forgot the main part!" -resultobj $result
slight tweak in how the powershell module converts to json in order to support nested objects (allows for more complex facts, among others)
This script gathers some extended facts on windows hosts in a json array attribute called "ansible_interfaces". This info is needed for some network-related modules I'm working on. Required the update to powershell.ps1 to return deeply nested json objects.
11 years ago
James Cammarata
dbc980eaf4
Merge branch 'mischapeters-devel' into devel
11 years ago
Chris Church
2ddab7affc
Merge pull request #8793 from cchurch/powershell3_compat
...
Replace Get-FileHash with MD5 code that works on PowerShell 3.
11 years ago
James Cammarata
70ff6d35aa
A10 module improvements
...
* moved common code to an module_util snippet
* rewrote logic to make each module idempotent
* added new capabilities like the write_config option
11 years ago
Michael DeHaan
b7082677de
Merge pull request #8790 from sivel/issue/8784
...
Don't use ternary if statements. Fixes #8784
11 years ago
James Cammarata
7fbdbcdec7
Default fetch_url to use TLSv1 instead of SSLv2/3
11 years ago
James Cammarata
ab495d1916
Set the shell variable on the ssh connection type for accelerated mode
...
Fixes #8799
11 years ago
James Cammarata
99ba9d6e24
Default fetch_url to use TLSv1 instead of SSLv2/3
11 years ago
Chris Church
0d1197a995
Replace Get-FileHash with MD5 code that works on PowerShell 3.
11 years ago
Brian Coca
88daac4971
ternary filter
11 years ago
Matt Martz
2b307985bc
Don't use ternary if statements. Fixes #8784
11 years ago
James Cammarata
a6ad374668
Use split_args directly to check for omitted params
11 years ago
James Cammarata
04da466c7b
Fixing up serialize_args utility function
11 years ago
James Cammarata
e99db078b4
Additional fixes for the new omit parameter variable
11 years ago
Victor Lin
fe88ba7c8d
Undo changes to filter module
11 years ago
Victor Lin
559c04f324
Implement omit for module args, also add tests for it
11 years ago
Victor Lin
bce6642ab6
Implement default omit correctly
11 years ago
Victor Lin
0b4d7f1574
Implement default omit filter
11 years ago
James Cammarata
ed34cee36f
Atomically move known hosts file into place for paramiko connections
...
Redo of original patch, which adds an additional check to ensure the
known_hosts file isn't trampled when host_key_checking is disabled.
Fixes #8169
11 years ago
James Cammarata
811ff49f78
Updating CHANGELOG for new symbolic mode feature and updating file docs
11 years ago
James Cammarata
c21c66c740
Merge branch 'file_symbolic_mode' of https://github.com/pbitty/ansible into pbitty-file_symbolic_mode
11 years ago
y_nk
affdadda25
handling case of space in path (given would start with single quote)
11 years ago
Chris Church
57dee4545b
Make sure cmd is UTF8 encoded before splitting. Fixes regression introduced by 80df2135e9.
11 years ago
Michael DeHaan
a419ffdf41
Make command warnings off by default to minimize surprises.
12 years ago
Michael DeHaan
b44e22aa68
Merge pull request #8722 from cmbaughman/devel
...
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
12 years ago
Michael DeHaan
fcb610dec4
Slightly trim down the warnings list based on some things being pretty common
...
for local usage.
12 years ago
Will Thames
ab8490d003
Added warnings to command module
...
Generate warnings when users are shelling out to commands
rather than using modules
Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.
Print out warnings using the standard playbook callbacks.
Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
12 years ago
Chris Baughman
07f12539ee
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
12 years ago
Michael DeHaan
8a0045baad
Update tests for ansible-galaxy CLI additions.
12 years ago
Michael DeHaan
d87830e1cc
Merge branch 'galaxy_github_archive' of git://github.com/willthames/ansible into devel
...
Conflicts:
lib/ansible/utils/__init__.py
12 years ago
James Cammarata
d01188033f
Checking for localized versions of the su password prompt
...
Fixes #8681
12 years ago
Michael DeHaan
0286c31e85
Assume master branch for downloads if not specified.
12 years ago
Michael DeHaan
0cd40fc372
Remove debug
12 years ago
Will Thames
850963790d
Allow roles to be installed from archives on github
...
Ensure that the automated scm determination for github.com
repos still copes with .tar.gz archive files.
Handling .zip archives is left as an exercise for the interested reader
12 years ago
James Cammarata
3b19b83806
Add GovCloud region to list of regions for AWS
...
Fixes #8604
12 years ago
Michael DeHaan
bcb44276fe
Assume github.com URLs are git protocol if not specified.
12 years ago
Michael DeHaan
68e21aa4b0
Add comments about what these new functions do.
12 years ago
Will Thames
6e9abefc11
Corrected bug where role_path was wrong for roles in subdirectories
...
Fixed role name for
- { role: 'lives/in/a/subdirectory' }
Should be 'lives/in/a/subdirectory', not just 'subdirectory'
12 years ago
Will Thames
ada9074276
Allow installation of roles from yaml roles file
...
Added docs
Added more tests
Improved how roles are returned from the parsers
12 years ago
Will Thames
46b59b02ed
Friendly Role Names and roles from URLs
...
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
12 years ago
Will Thames
4803e923ff
Improved handling of role_version in repo_url_to_role_name
12 years ago
Will Thames
1803976a40
Ensured that role version can be specified in role dependencies
12 years ago
Will Thames
c2fe33f9f4
Tidied up a little, added tests
...
Moved repo_url_to_role_name to common method in ansible.utils
Added unit test for repo_url_to_role_name
Added integration tests for galaxy
12 years ago
Will Thames
b550cb9bc3
Need to take URLs into account when running playbooks too
...
Ensure that if meta/main.yml has dependencies containing URLs
these are correctly resolved at playbook runtime.
Update role_name during run time so that output of e.g. task names
look sensible
12 years ago
James Cammarata
bae73e5793
Merge branch 'alozovskoy-alozovskoy-debug-ascii-patch' into devel
12 years ago
James Cammarata
4fafd3baa8
Add error checking around json.dumps when not forcing ascii mode
12 years ago
James Cammarata
ea5db1818d
Merge branch 'role_path_var' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-role_path_var
12 years ago
James Cammarata
24c4277479
Remove tabs added from 677de07
12 years ago
James Cammarata
5e240fec71
Merge branch 'devel' of https://github.com/l1k/ansible into l1k-devel
...
Conflicts:
test/integration/roles/test_copy/tasks/main.yml
12 years ago
James Cammarata
b81e77cfec
Tweak error language in dict validation
12 years ago
Serge van Ginderachter
3a228b9d55
InventoryScript: better syntax checking for json stream
12 years ago
Serge van Ginderachter
b8d057296a
variable merging: detect if both vars are really dicts when combining/merging dicts
12 years ago
Serge van Ginderachter
7051cdeb57
roles: make role_path (path of current role) available as variable to the task
12 years ago
James Cammarata
8a1fbed5d6
Correct variable blending from vars_files with hostvars in them
...
Fixes #8638
12 years ago
Serge van Ginderachter
a1f09bd89f
Merge variables for hosts instead of updating in get_variables()
12 years ago
James Cammarata
cecfede85f
Merge remote-tracking branch 'svg/issue_8621_8664' into svg_issue_8621_8664
12 years ago
James Cammarata
d4ff0d125a
Make sure password files from lookups are created with restrictive permissions
...
Also adds checks for the lookup integration test for passwords.
Fixes #8652
12 years ago
James Cammarata
3a7aca6066
Fix no_log value for content in common file args settings
...
Also adds a test to ensure the content value is not logged.
Related to #8647
12 years ago
James Cammarata
8a5675ca9f
Fixing no_log for the playbook level use
...
Fixes #8647
12 years ago
Serge van Ginderachter
0ab721d51e
better logic for all-group variables for implicit localhost
12 years ago
Serge van Ginderachter
3c06833302
group_by: make sure new group has bigger priority than all group
12 years ago
Serge van Ginderachter
a2cfe8770b
Inventory: fix logic mistake in loading/retrieving variables for groups
12 years ago
James Cammarata
ca6db40cb4
When serializing inventory, pop from the start of the hosts list
...
Fixes #8646
12 years ago
James Cammarata
c8494cdc39
Set prompt encoding to a sane value when sys.stdout.encoding is None
...
Fixes #8644
12 years ago
James Cammarata
379e31883c
Fix check mode issues with copy module
...
Fixes #8639
12 years ago
James Cammarata
542f07128e
Correct check for role library/ existence
...
Fixes #8633
12 years ago
James Cammarata
e3895840d1
Make sure group_vars/all is loaded for ungrouped hosts
...
Fixes #6563
12 years ago
Lukas Wunner
677de07f44
Try optimistic chown, do not error out if not permitted to chown
...
Add unit test
12 years ago
James Cammarata
8dafacd4e9
Make env param a dict type instead of list
...
Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.
Fixes #8199
12 years ago
Michael DeHaan
3035f2dcc8
Merge pull request #8367 from msabramo/make_pip_install_editable_work
...
Make `pip install -e` work
12 years ago
James Cammarata
54cbe3dcf9
Disallow args: to be specified as a string
12 years ago
James Cammarata
600a4657b4
Catch error in atomic_move when creating temporary file
...
Fixes #8480
12 years ago
James Cammarata
ee18c557ec
Load group_vars for new groups loaded via add_host
...
Fixes #8605
12 years ago
James Cammarata
b4476c238f
Use match() instead of search() for pattern matching
...
Also related to f48fa3, fix for #8614
12 years ago
James Cammarata
f48fa3759a
Fix host pattern matching and enhance error detection
...
Fixes #8614
12 years ago
James Cammarata
a01d97f12b
Fixing variable name bug introduced in ac8950f
...
Fixes #8617
12 years ago
James Cammarata
bea0845322
Fix vault_password positional args error
12 years ago
Lukas Wunner
f4053fcf3a
Only chown on atomic move if invoked as root
...
Linux and BSD derivatives do not allow unprivileged users to
"give away" files to others for security reasons. (System V
derivatives allow that but they're rare nowadays.)
12 years ago
Cristian Ciupitu
b6261d05b0
Fix typo: & -> and
...
`and` is the boolean operator for AND in [Python][1].
`&` is the bitwise operator for AND in [Python][2].
[1]: https://docs.python.org/2/reference/expressions.html#boolean-operations
[2]: https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations
12 years ago
Michael DeHaan
99c39b1ff3
By popular request, make the no_log attribute also censor tasks from callbacks.
12 years ago
James Cammarata
fc7859f445
Make sure playbook_dir variable is an absolute path
...
Fixes #8317
12 years ago
James Cammarata
4940a7ad77
Merge pull request #8458 from Jmainguy/runner_8404
...
Fixes 8362, returns stderr if No space left on device
12 years ago
James Cammarata
ac8950fd36
Set special vars in play.vars rather than load_vars
...
Also refactors playbook loading code relating to vars in playbooks
to a sub-function.
Fixes #8534
12 years ago
Jakub Paweł Głazik
99a339fa7b
Fix comments and error message
12 years ago
Jakub Paweł Głazik
58feee0f45
ansible-vault view - new command
12 years ago
James Cammarata
783a1e3dfc
Fixing broken patch 20957a1
...
Also adds integration tests for nested includes with conditionals
12 years ago
Michael DeHaan
02b0e102e6
Rename some INI keys for fact caching defaults
12 years ago
James Cammarata
20957a1b85
Remove duplicate compiling of task when: statements
...
Fixes #8538
12 years ago
James Cammarata
83fa9a8cde
Make sure we only use unquote on quoted lines in lineinfile when needed
12 years ago
Michael DeHaan
542aaa6ffe
Use JSON instead of pickles for compatibility.
12 years ago
Michael DeHaan
2629cd3fce
Fix some copyrights, fix a misc test.
12 years ago
Michael DeHaan
533fb21586
Add copyright header, let me know if corrections are needed.
12 years ago
Michael DeHaan
bdee1ff24e
Standardize exception handling
12 years ago
Josh Drake
a620ef414e
Implement connection pooling for memcached cache plugin.
12 years ago
Josh Drake
3031247492
Use cPickle in redis fact caching backend.
12 years ago
Josh Drake
917e868f65
Implement fact cache flushing alongside a command-line argument to invoke it.
12 years ago
Josh Drake
aa419044c4
WIP on the re-implementation of fact caching and various backends.
12 years ago
Michael DeHaan
fb5a1403dd
Merge
12 years ago
Michael DeHaan
56f9328f93
Merge
12 years ago
James Cammarata
25e9d1197e
Merge branch 'optimise_utils_clean_data' of https://github.com/leth/ansible into leth-optimise_utils_clean_data
12 years ago
James Cammarata
a650421e39
Catch task parameter splitting errors nicely
...
Fixes #8481
12 years ago
James Cammarata
9f34ea54f5
Correct parser to ignore escaped quotes when not in quotes already
...
Related to #8481
12 years ago
Marcus Cobden
c47d1f5265
Pre-load whole string and use seek to alter tags
12 years ago
Marcus Cobden
c8bfd157f8
Switch cStringIO to StringIO for unicode support
...
The performance difference isn't too bad
12 years ago
Marcus Cobden
84114e5c0b
Fix copy/paste error
12 years ago
Marcus Cobden
ef65d3dbf6
Optimise string handling in ansible.utils._clean_data
12 years ago
Michael DeHaan
e01d5f9d84
Revert "Added cross-platform uptime fact" since causing failures on Ubuntu.
...
This reverts commit 14a9966984 .
Conflicts:
lib/ansible/module_utils/facts.py
12 years ago
Michael DeHaan
ea53576759
Merge pull request #6777 from GuiGui2/devel
...
Setup module: Additional facts when using ansible with Linux on System z
12 years ago
Michael DeHaan
5d05049ee1
Merge pull request #7670 from dagwieers/patch-3
...
Added cross-platform uptime fact
12 years ago
Michael DeHaan
c56ce4c913
Merge pull request #8334 from veeti/cfg-vars
...
Expand variables in configuration files, take two
12 years ago
Michael DeHaan
a48328fa12
Merge pull request #7725 from slapers/network-secondaries-issue
...
fix incorrect secondary ip handling, fixes #7724
12 years ago
hoettle
4243ce61b3
Correct placement of right parenthesis.
...
(serial_pct)/100.0 is a typo - the parentheses should be around the entire percentage calculation, which makes much more sense when multiplying by the number of hosts (luckily BODMAS prevailed).
12 years ago
Howard Oettle
cbf0bd6baf
playbook: permit the serial attribute to be a pecentage string as well as well as a straight integer
12 years ago
James Cammarata
63bf2f6d9a
Preserve all line breaks in literal blocks
...
Fixes #8512
12 years ago
Michael DeHaan
d0205b2878
Merge pull request #8500 from sivel/rax-de-dupe
...
rax: Move additional shared code into module utils
12 years ago
Michael DeHaan
03d150de35
Merge pull request #8020 from msabramo/error_when_private_key_file_permissions_incorrect
...
Error if private_key_file is group/world readable
12 years ago
Michael DeHaan
8c4161d4a1
Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
...
Conflicts:
lib/ansible/inventory/vars_plugins/group_vars.py
plugins/callbacks/mail.py
12 years ago
Michael Peters
3ba516ac25
adding min() and max() filters for use in Jinja templates
12 years ago
Michael DeHaan
48a0236ec6
Merge pull request #6619 from sergevanginderachter/ansible_version_var
...
Introduce an ansible_version dict as runner variable
12 years ago
Michael DeHaan
66eddfd491
Merge branch 'nova-compute-enhancements' of git://github.com/emonty/ansible into devel
...
Conflicts:
lib/ansible/module_utils/openstack.py
library/cloud/nova_compute
12 years ago
Michael DeHaan
b413a7d7f3
Merge pull request #8449 from emonty/feature/openstack-auth-handling
...
Handle auth arguments across openstack modules consistently
12 years ago
Michael DeHaan
2f7d405fd9
Merge pull request #8510 from sergevanginderachter/inventorydir_yacc
...
InventoryDir: fixing yet another corner case
12 years ago
Serge van Ginderachter
7c96f1d803
InventoryDir: fixing yet another corner case
12 years ago
James Cammarata
d4cedfc7f1
Fix missing variable initialization for async jid
...
Fixes #8491
12 years ago
Michael DeHaan
fc40e6be81
Merge pull request #8488 from bekimb/docstring_basic_module
...
Keep docstring up to date with the code in basic module
12 years ago
James Cammarata
e19ed3424d
Make sure default vars are used in template calls for tasks
...
Fixes #8499
12 years ago
James Cammarata
4a157a72a0
Catch auth errors in winrm and properly raise errors
...
Fixes #7875
12 years ago
Bekim Berisha
5272e1099d
Keep docstring up to date with the code in basic module
12 years ago
Matt Martz
7d0eba19ab
Dedupe PTR record related code in rax_dns_record
12 years ago
Matt Martz
88acb48753
Add ANSIBLE_VERSION to module_utils/basic.py and manipulate the pyrax user-agent
12 years ago
Matt Martz
585fd5a138
Move additional rackspace common code into module_utils/rax.py
12 years ago
James Cammarata
ba4693051b
Removing leftover import of atomic_move
12 years ago
James Cammarata
efbad90ef8
Revert "Atomically move known hosts file into place when edited by paramiko connections"
...
This reverts commit bd49a835b4 .
12 years ago
James Cammarata
a45c3b84f3
Avoid templating raw lookup strings
12 years ago
James Cammarata
d134b8a83c
Version bump for 1.8
12 years ago
Alexander Lozovskoy
5165dfa2df
Issue with printing unicode non-english characters #8425 patch
12 years ago
Michael DeHaan
1c6398dd3b
Resolve option conflict differently.
12 years ago
Michael DeHaan
b4b115cd13
File common arguments should not be used in all docs pages.
12 years ago
Michael DeHaan
4312391e0a
(A) Fix a bug in the doc generator that was clobbering the force parameter for the copy module.
...
(B) This is a work in progress but the idea is to have text snippets where we can respond to tickets with a bit more helpful info.
Not active just yet.
12 years ago
James Cammarata
dc69510bff
Merge branch 'callback_template_delegate' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-callback_template_delegate
12 years ago
James Cammarata
eeec459f8a
Merge branch 'sets_v2' of https://github.com/bcoca/ansible into bcoca-sets_v2
12 years ago
Jonathan Mainguy
535ebc4c56
Fixes 8362, returns stderr if No space left on device
12 years ago
Serge van Ginderachter
8f39c114d8
template Runner.module_vars['delegate_to'] to accommodate callbacks
12 years ago
Monty Taylor
4012272fa2
Add common auth handling across openstack modules
...
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
12 years ago
James Cammarata
5d0bb33ede
Make run_command process communication smarter
...
The run_command module function will now poll stdout/stderr for
data rather than using the builtin command communicate(), which can
hang under certain circumstances.
Fixes #7452
Fixes #7748
Fixes #8163
12 years ago
James Cammarata
74cbeb1292
Default interface type to ipv4 when checking flags for Solaris
...
Fixes #8330
12 years ago
James Cammarata
bd49a835b4
Atomically move known hosts file into place when edited by paramiko connections
...
Fixes #8169
12 years ago
Michael DeHaan
7ff63ab754
Revert "Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C"
...
This reverts commit 642b183fb6 .
12 years ago
James Cammarata
af0d8cda7b
Fix literal block multiline parsing
...
Fixes #8394
12 years ago
James Cammarata
6d94ae64ec
Remove unnecessary unicode conversions from parse_kv
...
Fixes #8425
12 years ago
Michael DeHaan
642b183fb6
Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C
...
during file operations.
12 years ago
Michael DeHaan
a7d2e729f8
Add some whitespace to make paramiko_ssh more browseable
12 years ago
Michael DeHaan
24f6f656cc
Merge branch 'bug8392' of git://github.com/gnosek/ansible into devel
12 years ago
Monty Taylor
a05804bf8d
Update the nova inventory plugin with new ip code
...
The provisioning module knows more about how nova deals with IP
addresses now. Ensure that the inventory module is similarly as smart
by separating out the logic into the openstack/module_utils.
12 years ago
Monty Taylor
d17a1b5c19
Add common auth handling across openstack modules
...
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
12 years ago
Luke Sneeringer
a4fce4818e
Add support for environment variables in GCE module.
12 years ago
Grzegorz Nosek
7f33580eba
Fix exponential regex performance issue
...
filter_leading_non_json_lines effectively does
re.match(".*\w+=\w+.*", line)
for every line of output. This has abysmal performance in case of large
Base64-encoded data (which ultimately does not match the regex but does
match the .*\w+= part) as returned e.g. by the template module (diffs).
Replacing the match with
re.search("\w=\w", line)
drops the complexity back to linear, and actually usable with large
diffs from the template module (a 150 KB Base64 diff kept Ansible
spinning at 100% cpu for minutes).
Also, check the easy cases (line.startswith) first while we're here.
Closes : #8932
12 years ago
James Cammarata
9c1a89ff4e
Merge branch 'patch-1' of https://github.com/debfx/ansible into debfx-patch-1
12 years ago
Marc Abramowitz
44b9f5e752
Make `pip install -e` work
...
This allows `pip install -e` and `python setup.py develop` to work
without having to do the stuff in
http://docs.ansible.com/intro_installation.html#running-from-source so
it's a tad nicer for Python programmers who are accustomed to installing
packages as editable/in development mode.
Fixes GH-8355 (https://github.com/ansible/ansible/issues/8355 )
12 years ago
James Cammarata
7a5076c8b8
Catching shlex splitting error in fact gathering get_cmdline call
...
Fixes #8352
12 years ago
James Cammarata
80df2135e9
Fix parsing of tasks with variable module names
...
Also adding an integration test for same.
12 years ago
James Cammarata
189824dd76
Remove whitespace around args
...
Fixes #8343
12 years ago
James Cammarata
e6fa50a306
Move splitter to module_utils so modules can use it and fix command arg splitting
...
Fixes #8338
12 years ago
Veeti Paananen
5780f3a8b4
Expand variables in configuration files, take two
...
e.g. $HOME.
12 years ago
Veeti Paananen
e6bd049892
Don't expand remote_tmp path locally
12 years ago
James Cammarata
a9f0f8e975
Revert "template.py: Handle purposely raised exceptions in lookup()"
...
This reverts commit 2fda9bc743 .
12 years ago
James Cammarata
aee940aaca
Reworking _clean_data() to be smarter about replaces
...
Fixes #8228
12 years ago
James Cammarata
6e814566de
Unquote params passed to an include statement
...
Fixes #8315
12 years ago
Michael DeHaan
106f4ccc01
Revert "Expand variables in configuration files" - I feel I've been here before.
...
Breaks some test runs.
This reverts commit a9eef029b6 .
12 years ago
Michael DeHaan
97fa9502aa
Merge pull request #8309 from veeti/cfg-vars
...
Expand variables in configuration files
12 years ago
Michael DeHaan
645ab7baff
Merge pull request #7950 from mesk41in/devel
...
Fix unsupported regexp parameter in assemble
12 years ago
Michael DeHaan
fb60e767a7
Taking alternate approach.
...
Revert "Fix hostname when get_distribution_version() returns a string."
This reverts commit 08f97c0b9d .
12 years ago
Michael DeHaan
628d828876
Merge pull request #8087 from neersighted/string_version
...
Fix hostname when get_distribution_version() returns a string.
12 years ago
Michael DeHaan
30e6a659ae
Merge pull request #8171 from jbenden/osx-10.10
...
Support for OS X 10.10 DP3.
12 years ago
Michael DeHaan
20f65f2c79
Merge pull request #8262 from icoloma/patch-1
...
Bugfix: bulletproof unexpected_error_msg at gce.py
12 years ago
Veeti Paananen
a9eef029b6
Expand variables in configuration files
...
e.g. $HOME. Fixes #6373 .
12 years ago
Nacho Coloma
979824eedc
Moved import to the top
12 years ago
James Cammarata
6eac47e519
Use split_args instead of shlex.split for included params
...
Fixes #8296
12 years ago
James Cammarata
7344baeffa
Make sure empty non-quoted tokens are not added to the arg params list
12 years ago
James Cammarata
3714c0742f
Split args on single spaces only
12 years ago
James Cammarata
57f89b85eb
Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
...
fix an issue that copying directory will fail when trying to change file attributes
12 years ago
James Cammarata
63bcbd0af2
Fix for unicode decoding error in new splitting code
...
Also adds a new unicode integration test
12 years ago
James Cammarata
10a850c70f
Merge branch 'new_arg_splitting' into devel
12 years ago
Michael DeHaan
8d42f5cbfa
Smush ds removal
12 years ago
James Cammarata
b8a4ba26f0
Refactoring split_args into sub-functions
12 years ago
Michael DeHaan
630f080cf0
Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far).
12 years ago
Michael DeHaan
b5d64fdb36
Some notes/comment upgrades on split_args.
12 years ago
James Cammarata
43154e5101
Using custom splitting function for module param counting
12 years ago
Michael DeHaan
e143d7dab7
Merge pull request #7543 from yangliping/fix_local_facts_file_checking_portability
...
Fix portability issue when checking local facts file permission.
12 years ago
Michael DeHaan
635bea645c
Merge pull request #7992 from dehylton/devel
...
fix swap translation on 4.x openbsd with 2.5.4 python
12 years ago
James Cammarata
b21875d5a9
Make sure 'item' variable is set when using first_available_file
...
Fixes #8220
12 years ago
someda
1b1d5d0d3d
fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
...
- the issue was introduced by the commit 84759faa09
12 years ago
James Cammarata
2cc602beea
Fixes for module param counting and additional shell quoting issues
12 years ago
Benno Joy
ac85d8444b
fix for unarchive 8257
12 years ago
Nacho Coloma
57428c48a2
Bugfix: bulletproof unexpected_error_msg at gce.py
...
This method was still failing for me with a "missing http_code" message. After applying this change, the error message is:
```
msg: Unexpected response: {'value': 'PyCrypto library required for Service Account Authentication.'}
```
I wanted to contribute a rock-solid `unexpected_error_msg` implementation.
12 years ago
James Cammarata
84759faa09
Security fixes:
...
* Strip lookup calls out of inventory variables and clean unsafe data
returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
duplicate params from superseding previous params (CVE-2014-4967)
12 years ago
James Cammarata
00e089e503
Revert "Explicitly set the user option for ssh connections"
...
This reverts commit 0f91add86f .
Fixes #8216
12 years ago
Joseph Benden
da5e32b316
Needs additional divisor.
12 years ago
Michael DeHaan
0fad9575e9
Refine error message about invalid ops since people forget to indent tasks fairly often.
12 years ago
James Cammarata
0e5b0a2e97
Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
...
This reverts commit 7a8eb0b670 .
12 years ago
Joseph Benden
b55791ef43
Support for OS X 10.10 DP3.
12 years ago
James Cammarata
62e9cf63b7
Merge pull request #8170 from sergevanginderachter/issue_8159
...
Load existing group_vars file for new group_by group
12 years ago
Serge van Ginderachter
4e9a253bef
Load existing group_vars file for new group_by group
...
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.
fixes #8159
12 years ago
James Cammarata
42b5294820
Merge branch 'devel' of https://github.com/leverich/ansible into leverich-devel
12 years ago
Felix Geyer
0ebd19e97b
Fix regression: Sanitize sudo success_key from stdout
...
Commit 7e3dd10 caused a regression with sanitizing the sudo success_key from stdout.
There is no newline in front of SUDO-SUCCESS when using sudo.
This change adapts the regex to make the line break optional.
Tested on Ubuntu 14.04.
12 years ago
Ruggero Marchei
909955f2e2
fix get_distribution_version() on amazon linux
12 years ago
Jacob Leverich
7a8eb0b670
Set Jinja2's keep_trailing_newline=True in template_from_string.
...
Without this setting, the newline idempotence of scalar strings changes depending on whether
or not they contain any Jinja2 template blocks.
12 years ago
James Cammarata
e74853300a
Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass
12 years ago
James Cammarata
cdb9f13559
Merge pull request #7605 from sivel/delegate-callback-hint
...
Show delegate_to hint in callback output
12 years ago
James Cammarata
4fc8d4b6fe
Merge pull request #7649 from sivel/vault-password-script
...
Allow --vault-password-file to work with a script as well as a flat file
12 years ago
Serge van Ginderachter
e8b45a9ef7
Invalidate host/group variables cache when loading
...
extra varsiables based on playbook basedir.
12 years ago
Serge van Ginderachter
d39ff55688
Fix logic bug when loading vars for a new playbook basedir.
12 years ago
James Cammarata
db96344966
Re-fixing ability to have empty json files after inventory refactoring
12 years ago
James Cammarata
4e5eb7559e
Merge branch 'svg_and_inventory_refactor' into devel
12 years ago
Bjorn Neergaard
08f97c0b9d
Fix hostname when get_distribution_version() returns a string.
...
The distro version is a string ('jessie/sid') on Debian unstable and testing.
Because load_platform_subclass() evaluations every subclass as it loops,
comparing numbers when get_distribution_version() does not return a number will
break.
This patch fixes that by returning a number (`0`) when we have an invalid
version, instead of returning `None` or a string.
12 years ago
Dan Slimmon
307a3e8a9c
Fixed regex square-bracket bug.
...
Regexes were being parsed like ordinary ansible host patterns, so
square-bracket groups were getting interpolated wrongly.
12 years ago
James Cammarata
b8ac094eaa
Tweak to only show msg on assert failure if set
12 years ago
James Cammarata
16332b8488
Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg
12 years ago
James Cammarata
aa261bdd14
Optimizing groups_for_host() lookup in inventory
12 years ago
James Cammarata
fe892fccb1
Merge remote-tracking branch 'svg/varsplugins_refactor' into svg_and_inventory_refactor
12 years ago
James Cammarata
11a5fc85f4
Merge branch 'inventory_refactoring' into svg_and_inventory_refactor
12 years ago
James Cammarata
bcf83cbc24
Merge branch 'sergevanginderachter-inventorytree' into svg_and_inventory_refactor
12 years ago
Serge van Ginderachter
ff4119adc0
Performance optimization in resolving host patterns
...
Avoid resolving a pattern that is a plain host. When matching a hostname in the
hosts_cache, just use the host object from there.
When running a task on say 750 hosts, this yields a huge improvement.
12 years ago
Matt Martz
6591dd560d
Show delegate_to hint in callbacks
12 years ago
Leonid Evdokimov
d94395f48c
assert: add optional `msg` argument
...
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
register: output
- assert:
msg: '{{ output.json | to_nice_json }}'
that:
- output.json.foo != "bar"
- output.json.boo == 42
```
12 years ago
James Cammarata
7f8de3a265
Merge pull request #8024 from kcghost/7941
...
removed port from domain name qualification, fixes #7941
12 years ago
James Cammarata
ff04b2b532
Allow empty yaml vars files
...
Fixes #7843
12 years ago
Michael DeHaan
51e014d915
Merge pull request #8012 from cchurch/callback_cleanup
...
Callback plugin cleanup
12 years ago
Michael DeHaan
c2ac8fda1e
Data from inventory scripts should be able to use nested Jinja2 expressions.
12 years ago
Henry Finucane
de64bbdc5f
Support a whitelisted subset of jinja2 template options
12 years ago
Casey Fitzpatrick
7115cb1f37
removed port from domain name qualification, fixes 7941
12 years ago
Marc Abramowitz
5b783e0bc6
Error if private_key_file is group/world readable
...
Currently, if you have this, ansible fails with a generic error and
suggests running again with `-vvvv`. This isn't bad but pinpointing the
specific problem immediately is even more user-friendly.
```
$ ls -l devops.pem
-rw-r--r--+ 1 marca staff 1679 Jul 2 11:25 devops.pem
$ ansible -m ping --private-key=devops.pem mt3-pyweb01
mt3-pyweb01 | FAILED => private_key_file (devops.pem) is group-readable or world-readable and thus insecure - you will probably get an SSH failure
```
12 years ago
James Cammarata
81f35323e9
Revert "Fix get_distribution() for platforms that may have spaces"
...
This reverts commit 2493020d9f .
12 years ago
Chris Church
955dadf743
Remove runner_on_error callback that is never used.
12 years ago
Chris Church
4e98e3785a
Reset play attribute on callback plugins when a play fails.
12 years ago
Chris Church
30fae95efe
Change variable from pattern to name to correctly indicate what is being passed to the callback.
12 years ago
James Cammarata
8ed6350e65
When parsing json from untrusted sources, remove templating tags
12 years ago
James Cammarata
eeb597360e
Further safe_eval fixes
12 years ago
dewey hylton
379e1a49cb
fix swap translation on 4.x openbsd with 2.5.4 python
12 years ago
Michael Scherer
f0a7139290
Fix exec_command prototype for the plugin
12 years ago
mesk41in
488aec3936
Fix unsupported regexp parameter in assemble
12 years ago
James Cammarata
539426f612
Performance tuning inventory functions for large inventories
12 years ago
James Cammarata
35368e531b
Additional fixes for safe_eval
12 years ago
James Cammarata
5429b85b9f
Change safe_eval to a strict white list
12 years ago
James Cammarata
d8a7b49b59
Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree
12 years ago
Matt Martz
19f5ce2c9c
Allow --vault-password-file to work with a script as well as a flat file
12 years ago
James Cammarata
1adb6dfa05
Remove redundant 'self.user or' added by 0f91add
12 years ago
Thomas Mangin
0f91add86f
Explicitly set the user option for ssh connections
...
Fixes #7170
12 years ago
Paul Sokolovsky
f8bf9cdeec
Handle TemplateNotFound to render more helpful error message.
...
At the point the exception is handled, it is likely due to error loading
a sub-template included from main template. Besides file not found, it
can be caused also by include path failing Jinja2 checks. Now, when
rendering the exception from Jinja, it will include exception name. This
will give basic context or *what* the error is.
Fixes #7103
Fixes #7105
12 years ago
James Cammarata
5d65c1c4a4
Merge branch 'Mbosco-patch-1' into devel
12 years ago
James Cammarata
6bd0621037
Merge branch 'devel' of https://github.com/ansible/ansible into devel
12 years ago
James Cammarata
1702c2fd50
Merge branch 'patch-1' of https://github.com/Mbosco/ansible into Mbosco-patch-1
12 years ago
James Cammarata
9564818e1e
Merge branch 'fix_lineinfile_newlines' into devel
12 years ago
James Cammarata
59c5d6292b
Merge pull request #7902 from jirutka/filter-relpath
...
Add os relpath filter
12 years ago
James Cammarata
ce41b02300
Merge pull request #7887 from s0x/funtoo-gathering-facts
...
Check for empty os-release file, fixes #7885
12 years ago
Jakub Jirutka
726a61eb43
Add os relpath filter
12 years ago
Chris Church
6aaad5dc9b
Fix missing arg for _remote_chmod method.
12 years ago
Ivo Senner
f4fd9d366b
Check for empty os-release file, fixes #7885
12 years ago
Chris Hoffman
cf997beb07
Shell expand DEFAULT_ROLES_PATH fixes #4897
12 years ago
James Cammarata
94963290b9
Merge pull request #6981 from aliles/fix-localhost-executable-with-flags
...
Fix localhost tasks with complex executables
12 years ago
James Cammarata
3c3c710a58
Merge branch 'module_safe_eval' into fix_lineinfile_newlines
12 years ago
James Cammarata
d8bb116c1a
Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel
12 years ago
Michael DeHaan
5156794738
Merge pull request #7861 from cchurch/devel
...
Windows Remote Support
12 years ago
Chris Church
615f70e3f4
Fix missing space in script action plugin.
12 years ago
Chris Church
dd3f7c2dab
Fix trailing slash on returned temp path.
12 years ago
Chris Church
8a121fd6ae
Squeeze a few more bytes out of put_file script.
12 years ago
Chris Church
4e738e6fa9
Optimize buffer size for put_file.
12 years ago
Matt Martz
09dd535296
Make helper functions more robust against undefined powershell objects
12 years ago
Chris Church
43a7a5a990
Collapse extra whitespace in encoded powershell scripts.
12 years ago
Matt Martz
df8866b8bd
Add examples for how to use powershell common functions
12 years ago
Matt Martz
e4e610565c
Add convenience function (Get-Attr) for getting an attribute/member from a powershell psobject
12 years ago
Matt Martz
90c98ada7c
Add ConvertTo-Bool filter function in powershell common code
12 years ago
Chris Church
61c236be9e
Fix for creating temp dir with older powershell versions.
12 years ago
Chris Church
243cd877ae
Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules.
12 years ago
Chris Church
a8ca579761
Fix host parameter to vvvvv.
12 years ago
Matt Martz
97f4f56286
Add Exit-Json and Fail-Json powershell helper functions
12 years ago
Chris Church
74c43c94cf
Allow specifying remote powershell version via environment variable.
12 years ago
Chris Church
8f762a7d15
Update logging based on verbosity, add vvvvv support to show details of put/fetch file.
12 years ago
Chris Church
21ba529fbe
Fixes/notes related to slashes in remote paths.
12 years ago
Chris Church
7e8cc65829
Refactor common args used for building PowerShell commands.
12 years ago
Matt Martz
e7e95721b9
powershell modules will have a .ps1 extension
12 years ago
Matt Martz
a25c441300
Add shared functions to module_utils/powershell.ps1 and refactor powershell modules to utilize the common powershell code
12 years ago
Michael DeHaan
bafa63b424
Revise documentation on powershell module replacer code.
12 years ago
Chris Church
f7af29680b
Add default license boilerplate, refactor common powershell code, fixes for raw/script modules.
12 years ago
Michael DeHaan
35a7c93c76
Added comment about implementation line.
12 years ago
Michael DeHaan
3ac86e57f4
FIXME comment cleanup
12 years ago
Michael DeHaan
80499346d1
Remove stray FIXME
12 years ago
Chris Church
5dcaa30476
Add shell_plugins to abstract shell-specific functions out of runner, add winrm connection plugin, add initial Windows modules.
12 years ago
James Cammarata
360d8b0fc2
Don't try to scan SSH signatures for non-ssh urls
...
Fixes #7812
12 years ago
James Cammarata
2493020d9f
Fix get_distribution() for platforms that may have spaces
...
The new CentOS 7 beta lists the distribution as "CentOS Linux", which
breaks the distribution detection and class loading. This patch fixes
that by taking just the first entry in the string when a space is
detected.
12 years ago
James Cammarata
3529b1cb33
Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763
12 years ago
Michael DeHaan
627ff30a6f
Add module replacer capability for powershell files.
12 years ago
Ruggero Marchei
e3f5af377f
move get_distribution_version() to basic.py
12 years ago
James Cammarata
cb13b30362
Use file documentation fragement for the copy module
12 years ago
James Cammarata
9b17e8a555
Merge pull request #7771 from jkramarz/issue-5761
...
Added missing fallback to hw_sector_size
12 years ago
James Cammarata
6d9cc64e0f
Add role_names to valid keys entry for plays
...
Prevents a "not a legal parameter" error for play ds structures that
may be passed into the Play() constructor, which really is mainly a
concern during tests.
12 years ago
Matt Bray
578e881142
fix for urls like ssh://git@github.com/ansible/ansible.git
12 years ago
Jakub Kramarz
df3188cef0
Added missing fallback from physical_block_size to hw_sector_size in sectorsize fact discovery for kernels older than May 2009.
...
References #5761
12 years ago
James Cammarata
3fb3e7e6dc
Properly parse urls for ssh-keyscan use
...
Previously, the get_fqdn() function in known_hosts.py only worked
with urls that started with git@, and ignored any urls that started
with a normal schema type (ie. http:// or ssh://). This patch corrects
that by using urlparse to parse the hostname portion out of urls that
have a proper schema.
Fixes #7474
12 years ago
James Cammarata
395192ffbc
Merge pull request #7740 from jkramarz/issue-5761
...
changed sector size fact source
12 years ago
James Cammarata
b4d130d086
Add a new password pattern to the run_command filter
12 years ago
Jakub Kramarz
4e4c9235e8
changed sector size fact source from hw_sector_size to physical_block_size, fixes issue 5761
12 years ago
Stefan Lapers
78f4842982
fix incorrect secondary ip handling, fixes #7724
12 years ago
Eri Bastos
a65fd06338
Added quotes around key path - Issue 7713
12 years ago
James Cammarata
e5ef0eca03
Merge pull request #6507 from brdo/patch-1
...
Set keepalive to 5 seconds in paramiko_ssh.py
12 years ago
smoothify
e3530dcbc2
Add environmentfilter to random filter, to ensure the result doesn't get cached. Mirrors default jinja filter.
12 years ago
Dag Wieers
fd6f0cb4b4
Update facts.py
12 years ago
Dag Wieers
14a9966984
Added cross-platform uptime fact
...
Having an uptime fact allows you to check after a reboot whether the system was effectively rebooted.
```yaml
- name: Safeguard - Was system properly rebooted ?
action: fail msg="System was not properly rebooted"
when: ansible_uptime > 900
```
This patch has been tested on Linux, Solaris and HP-UX.
12 years ago
James Cammarata
ad97c618cf
Add support for relative paths in the file lookup plugin for roles
...
Fixes #7628
12 years ago
James Cammarata
82a784931e
Fix error passing play vars to an included playbook with empty vars
...
Fixes #7658
12 years ago
James Cammarata
d9df607972
Fix order of merging variables for the combined cache
...
Fixes #7598
12 years ago
James Cammarata
74f20ebf79
Removing cruft leftover from the deprecation of include+with_items
...
Also cleaning up integration tests that had checks for the empty item
attribute in certain results.
Fixes #7535
12 years ago
James Cammarata
0fa5100a2c
Merge branch 'fix-7596' of https://github.com/kilburn/ansible into kilburn-fix-7596
12 years ago
James Cammarata
849b0f87ce
Fix error when using os.getlogin() without a tty
12 years ago
Brian Coca
ce8c8ab146
now unique actually works, all operations also now use it to return
...
unique lists.
12 years ago
Michael DeHaan
959af67fe3
Merge pull request #7608 from jjneely/lookup-function
...
template.py: Handle purposely raised exceptions in lookup()
12 years ago
James Cammarata
b94bde9711
Merge pull request #7609 from jimi-c/issue_7553_su_copy
...
Support checking for su user to atomic_move
12 years ago
Jack Neely
2fda9bc743
template.py: Handle purposely raised exceptions in lookup()
...
If a lookup plugin is run by the lookup() template method it should pass
along any AnsibleError (or child exception classes) rather than just eat
them. These exceptions are purposely raised by the plugin.
12 years ago
Marc Pujol
d0f82e94e8
Ensure there are no duplicates in the merged/intersected lists
12 years ago
Marc Pujol
f892cc798c
Merge and intersect lists without using sets.
...
Using sets for these operations is dangerous because sets cannot contain
certain object types (such as lists) and their iteration order is
undefined.
Fixes #7596
12 years ago
James Cammarata
188ab7b952
Check groupnames for None as well as an empty string in add_host
...
Fixes #7585
12 years ago
James Cammarata
feafc4cd8a
Merge branch 'fix_mutable_inventory_vars' of https://github.com/banterchat/ansible into banterchat-fix_mutable_inventory_vars
12 years ago
Isao Jonas
72524e1f3b
dont mutate inventory vars
12 years ago
James Cammarata
061911c9c2
Merge pull request #7558 from dermute/pkg_mgr
...
added solaris fact detection for ansible_pkg_mgr
12 years ago
James Cammarata
e99df21647
Support checking for su user to atomic_move
...
Fixes #7553
12 years ago
James Cammarata
fa86eef9f9
Make sure value in regex_replace is a string
...
Fixes #7551
12 years ago
James Cammarata
ca734fde8b
Merge pull request #7544 from rik2803/patch-2
...
Differentiate machinfo output key/val separator
12 years ago
James Cammarata
cfd8c685d1
Correct issue of handlers running on all hosts incorrectly
...
Also adds an integration test to catch this bug in the future.
Fixes #7559
12 years ago
Alexander Winkler
4980e76a3a
added solaris fact detection for ansible_pkg_mgr
12 years ago
Brian Coca
8f58ae3305
changed exception handling for hashable test
12 years ago
rik2803
cfcbc954f5
Differentiate machinfo output key/val separator
...
get_hw_facts for HP-UX: machinfo in HP-UX B.11.23 uses '=' as separator between key and value, while B.11.31 uses ':'.
12 years ago
Yang Liping
aedf134fc4
Fix portability issue when checking local facts file permission.
12 years ago
James Cammarata
92f16b3d6f
Merge pull request #7539 from jimi-c/issue_7503_freebsd_su_fixes
...
Fixes for su on freebsd
12 years ago
Brian Coca
0dce5dae26
set theory v2, now can handle non hashable items like dicts
12 years ago
James Cammarata
e0c4c51c1f
Merge pull request #7517 from amenonsen/double-error
...
Don't double (or triple) up common error messages
12 years ago
James Cammarata
d77a6965b3
Merge module_vars into inject during template instead of updating
...
This way we won't overwrite values that are stored in the inject
with module_vars that should be lower precedence.
Fixes #7510
12 years ago
Abhijit Menon-Sen
f6792b724a
Don't double (or triple) up common error messages
...
process_common_errors() was called thrice, each time appending to the
existing error message, and leading to confusing repetition in the
message that was finally displayed.
Fixes #7498
12 years ago
James Cammarata
1e672a0fec
Fixes for su on freebsd
...
Addresses multiple issues when using su on freebsd including
* su prompt differs between platforms, so turned that check into a
regex comparison instead of a simple string comparison
* not using '-c' after su causes problems, so added that for all
platforms
* fixed quoting issues due to multiple uses of '-c' introduced by
the above fix
Fixes #7503
Fixes #7507
12 years ago
Nick Irvine
6b70ee23ab
Clean non-printable chars from stdout instead of dropping the whole thing
12 years ago
James Cammarata
32628eef85
Merge pull request #7481 from jimi-c/issue_7396_env_lookup
...
Don't use listify_ function, when all we want to do is template variable...
12 years ago
WAKAYAMA shirou
56880b76bb
fix UnicodeEncode error when using pause module with unicode prompt.
12 years ago
WAKAYAMA shirou
346bb611c7
fix UnicodeEncodeError when prompt is unicode.
12 years ago
James Cammarata
e36a8d466e
Don't re-query inventory when trimming failed/dark hosts
...
Since the filter list contains hosts, passing that back to list_hosts()
in the inventoy causes issues when the hostname is an IPv6 address
(with :'s interpreted as group unions). Since we already have the list
of hosts, we should not need to pass that back through inventory a
second time.
Fixes #7446
12 years ago
James Cammarata
365bfd732e
Don't use listify_ function, when all we want to do is template variables
...
This was causing a bug in the env module, due to the fact that we now
pass variables for the module through the templating engine combined
with the fact that we split-up the hostvars and setup variables. As a
result, if a variable in the env lookup had the same name as the variable
in Ansible, it would try and template itself over and over again until
the recursion limit would be hit, at which time an empty string was
returned.
Fixes #7396
12 years ago
James Cammarata
0ac74aaf59
Also set the environment variables when resetting the locale to C
12 years ago
James Cammarata
1f0be3753d
Merge pull request #7412 from bellkev/fix_skip_dir_inventory_extensions
...
Fix skip dir inventory extensions
12 years ago
James Cammarata
d44ed533b3
Default use_proxy to True for fetch_url()
...
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.
Fixes #7322
12 years ago
James Cammarata
08406c0ee2
Adding the capability to proxy the ssl cert check
...
The ssl cert check will now respect the http and https proxy
environment settings. The url may also have the username/password
embedded, in which case basic auth will be used to connect to the
proxy server.
Fixes #7413
12 years ago
Matt Martz
0e953c2863
Add run_once task key
...
This caused the task to act like bypass host loop plugin and
execute only on a single host. Can be used with delegate_to
12 years ago
James Cammarata
285d9878ae
Reset locale to 'C' if the specified one is invalid
...
Fixes #7448
12 years ago
Kevin Bell
92bd755b47
Fixed extension filtering in InventoryDirectory
12 years ago
James Cammarata
df877f2e79
Check module_path permissions when creating ssh_wrapper for git
...
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.
Fixes #7375
12 years ago
Michael DeHaan
3b8a35d65e
Merge pull request #7406 from specnazzz/fix-python24
...
Fix known_hosts.py to work on older versions of python
12 years ago
James Cammarata
79731ce491
Evaluate changed_when only if task is not skipped
...
Fixes #7405
12 years ago
Michal Mach
60451c20ab
Fix known_hosts.py to work on older versions of python
12 years ago
James Cammarata
7faecd54b0
Merge pull request #7388 from jimi-c/issue_7384_vars_files_include
...
Pass vars_files on to included playbooks too
12 years ago
James Cammarata
a9311a5dcb
Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms
12 years ago
James Cammarata
56515a38d5
Only chown on atomic move if the uid/gid don't match the src/tmp file
...
This is a corner case for remote file systems that don't support
chown() and where the source and destination for the atomic_move
are on that remote file system.
Fixes #7372
12 years ago
James Cammarata
525e7339ed
Merge branch 'pass-basedir-to-runner-on-setup' of https://github.com/ByteInternet/ansible into ByteInternet-pass-basedir-to-runner-on-setup
12 years ago
James Cammarata
85bd6810bb
Pass vars_files on to included playbooks too
...
Fixes #7384
12 years ago
Allard Hoeve
c5833f9869
Add missing basedir to Runner in _do_setup_step
12 years ago
James Cammarata
360ffc4dfd
Properly merge role conditionals in with pre-existing conditionals
...
Fixes #7387
12 years ago
James Cammarata
187619c7fe
Use utils.combine_vars on vars_files data
...
Fixes #7345
12 years ago
James Cammarata
809b931640
Merge pull request #7382 from jimi-c/issue_7366_synchronize_inventory_dir
...
Do not base synchronize source on the inventory directory
12 years ago
Marco Re
712f4a631c
Update ssh.py
...
Convert to string to fix runtime error due to string concat in self.common_args += ["-o", "User="+self.user] when ansible_ssh_user is numeric
12 years ago
Chris Church
d725636469
Correctly initialize combined_cache for hosts if setup is skipped
...
Fixes #7364
12 years ago
James Cammarata
38c2c60849
Do not base synchronize source on the inventory directory
...
Fixes #7366
12 years ago
James Cammarata
fd27afdc0d
Adding ansible_shell_type and basic environment construction on it
...
Previously we assumed the shell on the target systems were 'sh'-
compliant when formatting environment variables preceding command
strings. This patch corrects that by basing the target shell type
on the DEFAULT_EXECUTABLE setting, which can be overridden on a
per-host basis using the inventory variable 'ansible_shell_type'.
Fixes #7352
12 years ago
James Cammarata
9b9b4d50fe
Merge pull request #7058 from jkleckner/fix-vars_prompt-when-default-False
...
Fix #7057 missing False default for vars_prompt
12 years ago
James Cammarata
51ef28b0d2
Merge branch 'warn_wrong_sudo_password' of https://github.com/tyll/ansible into tyll-warn_wrong_sudo_password
12 years ago
James Cammarata
2e2e5d5321
Use the existing module_vars during the templating of module_vars
...
Since some of the vars contained in there may be used in the templating
of other variables. This also reverts e83a494 which originally fixed
issue #6979 but broke some other variable related things.
Fixes #6979
Fixes #7321
Fixes #7332
12 years ago
James Cammarata
77a47dbb2d
Merge pull request #7304 from jimi-c/issue_7296_synchronize_relative_path
...
Make sure dwim'd relative path ends in a "/" if the original does
12 years ago
James Cammarata
393124e462
Add pyc/pyo to ignore list for inventory directories
...
Fixes #7308
12 years ago
Brian Coca
8a84b22d76
bumped to 1.7
12 years ago
Chris Church
f9c74d6e57
Add integration tests for group_by module. Fixed bug introduced by ansible/ansible#7273 while also fixing issue described in ansible/ansible#6953
12 years ago
James Cammarata
4d118d1c72
Make sure dwim'd relative path ends in a "/" if the original does
...
Fixes #7296
12 years ago
James Cammarata
56d070afa8
Version bump for 1.7
12 years ago
James Cammarata
fd03cc04e6
Merge branch 'devel' of https://github.com/denisphillips/ansible into denisphillips-devel
12 years ago
Veeti Paananen
d6f4d9b76d
Fix error handling on missing dest with unarchive
...
fixes #7107
12 years ago
Denis Phillips
cd0134d290
Used module_args passed to function instead of from runner
12 years ago
Christian Berendt
6676720ce5
fixed typos found by RETF rules in PY files
...
rules are avaialble at https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Typos
12 years ago
James Cammarata
deb532c367
Remove OrderedDict references from runner
...
Fixes #7256
12 years ago
James Cammarata
54b1f820fb
Modify the way we set the localization environment
...
Previously, we set the LANG (and LC_CTYPE) environment variables
directly in the module code and applied them with os.environ().
Instead, we are now pre-pending those variables to the environment
string used to execute the command which allows the user to
override the localization values by setting the environment values
directly (even on a per-task basis):
- subversion: repo=file:///path/to/repos/svn_über dest=/tmp/svntest
environment:
LANG: "C"
LC_CTYPE: "en_US.UTF-8"
So if a user wishes to default their LANG back to C, they can still
avoid unicode issues by doing the above.
Fixes #7060
12 years ago
James Cammarata
40a7a306f5
Merge pull request #7236 from jcassee/robust-ssl-cert-concat
...
Make concatenating certs robust in urls.py
12 years ago
James Cammarata
8e45fa9b63
Moving display-related functions to new module in utils
12 years ago
Joost Cassee
978e6d2cd6
Make concatenating certs robust in urls.py
...
Add a newline after each certificate file explicitly to avoid problems
with files that do not end with a newline themselves.
12 years ago
James Cammarata
6069ff6e9e
Adding a new system_warnings config option to supress warnings
12 years ago
James Cammarata
30e4759055
Merge pull request #7208 from jf/copy-module
...
Fix "no_log=True" option for copy module (fixes #7193 )
12 years ago
James Cammarata
be4e6d359f
Merge branch 'delegate_to_honor_ssh_private_key_file' of https://github.com/renard/ansible into renard-delegate_to_honor_ssh_private_key_file
12 years ago
James Cammarata
4cadcccc48
Catch pycrypto warning about gmp and show a nice warning on stderr
12 years ago
Jeffrey 'jf' Lim
0bf1a27393
Fix "no_log=True" option for copy module ( fixes #7193 )
12 years ago
Jiri Barton
9da06274a8
Set proper file permisions when a file is created with atomic_move
...
Fixes #7196
12 years ago
Michael DeHaan
9a6998aa17
While this code is unused, this remote module copy of this function should not be carried around in the source code.
12 years ago
Logos01
424ee36e05
Enable facts module on older SuSE systems
...
Modified logic of distribution_release for SuSE to retain the last discovered key/value pair's value in /etc/SuSE-release that contains a '=' character.
12 years ago
James Cammarata
1576e8d611
Adding missing options to the file documentation fragment
12 years ago
Brian Coca
c5d5481ebb
added doc noting the change in behaviour
12 years ago
Cédric RICARD
b8b0865ec0
Missing 'base64' import
12 years ago
Michael DeHaan
ad04b455d3
add missing license header
12 years ago
James Cammarata
117952cf6c
Fixing a bug in the new fetch_url username/password logic
12 years ago
James Cammarata
b9d8b3b911
Merge pull request #7132 from jimi-c/issue_6601_hide_vault_yaml
...
Hide YAML content on syntax errors when a vault password is specified
12 years ago
James Cammarata
89fa9b7305
Add parameters to get_url for the url username/password
...
Fixes #6928
12 years ago
James Cammarata
e9d8f0639f
Merge pull request #7143 from sivel/ansible-sudo-from-root-fix
...
Allow sudo to another user from root with the ansible command
12 years ago
James Cammarata
460794d697
Merge pull request #7140 from jimi-c/issue_6962_traceback_callbacks_unicode
...
Fix handling of non-JSON lines in responses
12 years ago
Matt Martz
eb8759176f
Allow sudo to another user from root
12 years ago
James Cammarata
5e598c5337
Fix handling of non-JSON lines in responses
...
Garbage lines with ' = ' in them were causing parsing errors,
where key=val lines should not have spaces around the equals.
Fixes #6962
12 years ago
James Cammarata
38b49476f8
Merge branch 'raw-script-su-support' of https://github.com/sivel/ansible into sivel-raw-script-su-support
12 years ago
James Cammarata
93b5769d94
Hide YAML content on syntax errors when a vault password is specified
...
Fixes #6601
12 years ago
Michael Scherer
0f0f5ff1ce
Give more information when a task is empty
...
I made a typo in a playbook and was great by:
ERROR: expecting dict; got: None
The issue was a single - on the last line of a playbook.
With the name of the file, I was able to see right away where the
error was.
12 years ago
James Cammarata
e83a494e41
Make sure VARS_CACHE for hosts are updated with the play vars too
...
Fixes #6979
12 years ago
James Cammarata
a6068b09ac
Fix collision in random filter name by merging functionality
...
Merges the functionality of the original jinja2 random filter with
the one we provide.
Fixes #7113
12 years ago
James Cammarata
c115c34a1f
Set the default LANG to en_US.UTF-8 and also set LC_CTYPE
...
Fixes #6737
12 years ago
Brian Coca
c3e559b914
should now work with versions older than 8.4
12 years ago
faust64
78b9a11ccf
Update facts.py
...
Fixes #7093 --devel
12 years ago
James Cammarata
68c30548e0
Properly catch and decode unicode strings in module _log_invocation()
...
Fixes #7084
12 years ago
James Cammarata
4f673b9497
Merge pull request #7083 from mscherer/better_message_multiple_action
...
Improve error message when multiple action are given
12 years ago
James Cammarata
39c6141b4a
Merge pull request #7082 from bcoca/freebsd_mtu_fix
...
fixed issue with FreeBSD network facts
12 years ago
James Cammarata
086b877719
Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
...
Clean a bit more the ssh_args configuration
12 years ago
James Cammarata
54f86099e4
Merge pull request #7078 from mscherer/fix_error_message_controlpersist
...
Enhance error message about missing ControlPersist
12 years ago
Michael Scherer
1e34e95ba0
Improve error message when multiple action are given
...
This can be illustrated using this playbook:
- command: id
delegate_to: "{{ remote_server }}"
user: "{{ remote_user }}"
The error is to use 'user' instead of 'remote_user', but the error message
do not really mention it, so it can be a bit hard to spot.
12 years ago
Brian Coca
e5f297697a
ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
...
versions and it now works
12 years ago
Brian Coca
bc23926f42
fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
...
gathering
12 years ago
Michael Scherer
c87afc1109
Clean a bit more the ssh_args configuration
...
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :
<server.example.org> ESTABLISH CONNECTION FOR USER: misc
<server.example.org> REMOTE_MODULE ping
<server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
'-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
'-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
&& chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
command using -vvvv, which will enable SSH debugging output to help diagnose the issue
The root cause is the empty string between -q and -o, who kinda break mkdir.
12 years ago
Michael Scherer
3a09c99811
Enhance error message about missing ControlPersist
...
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
12 years ago
James Cammarata
ae29e43f93
Merge branch 'issue_7009_nfs_selinux' into devel
12 years ago
James Cammarata
a32dd34359
Make sure HostVars object is instantiated before assigning it
...
Fixes #7006
12 years ago
Jim Kleckner
46ec238613
Fix #7057 missing False default for vars_prompt
...
The test for default should be "is not None" since a boolean value of
False is a valid value.
See discussion at:
https://groups.google.com/forum/#!topic/ansible-project/oc1_zE-FnyI
12 years ago
James Cammarata
75e0b7a5cf
Make sure umask is set restrictively before creating any vault files
12 years ago
James Cammarata
3715482d7c
Determine selinux context for NFS mount points correctly
...
Fixes #7009
12 years ago
Sébastien Gross
22d6572270
Honor ansible_private_key_file for delegated hosts
...
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.
This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
12 years ago
Wim
6ed4ca97a8
hint to install python-ssl on redhat systems
12 years ago
smoothify
48bf7a000d
Try to pass in item to on_skippped callback.
12 years ago
James Cammarata
d240d073eb
Changing SSL cert detection method to allow for auto-negotiation of SSL protocols
...
Fixes #6904
12 years ago
James Cammarata
23c5f4524d
Make sure args in run_command are encoded for shlex.split calls on py2.6
12 years ago
James Cammarata
d494a163f9
Merge pull request #6900 from jimi-c/issue_6891_cifs_mount_hang
...
Add a timeout decorator for timing out functions that may hang
12 years ago
James Cammarata
ba1a6c2e11
Removing .orig file merged in accidentally
12 years ago
James Tanner
aad128bac7
Use combined cache for templating module vars
...
Fixes #6901
12 years ago
James Cammarata
40b958e348
Don't turn complex args back into a k=v string for the synchronize module
...
Fixes #6951
12 years ago
James Cammarata
2cc4ac2e75
Catch traceback caused by permissions errors during a local md5 sum
...
Fixes #6948
12 years ago
Aaron Iles
a5507275cb
Fix localhost tasks with complex executables
...
Enable the use of executable commands that use command line options with
the localhost command runner. These commands require parsing out the
base executable from the command string to pass to subprocess.
12 years ago
jctanner
bfb25f4f89
Merge pull request #6917 from bcoca/random_filter_clean
...
simple random filter
12 years ago
jctanner
af99abc81c
Merge pull request #6913 from willthames/aws_module_doc_fragments
...
Use common module document fragments for AWS modules
12 years ago
James Tanner
4eb626825b
Refactor play._update_vars_files_for_host to make common functions and easier debugging
...
Fixes #4883
12 years ago
Brian Coca
80cd217eb7
simple random filter
12 years ago
willthames
509561f658
Moved AWS modules over to common module fragments
...
Created common module doc fragment, and applied to all
modules that use ec2_connect or connect_to_aws as
they definitely share the common doc fragments
12 years ago
James Cammarata
5ce6c86595
Merge branch 'sudo_pass_typo' of https://github.com/tyll/ansible into tyll-sudo_pass_typo
12 years ago
James Cammarata
eebc72ab9b
Add a timeout decorator for timing out functions that may hang
...
Fixes #6891
12 years ago
James Tanner
2d33cd1b5d
Fixes #6894 add missing file and remove debug line
12 years ago
James Tanner
68cd7258b6
Fixes #6894 create docs fragment for files
12 years ago
Serge van Ginderachter
d240e2b9fb
Introduce an ansible_version dict as runner variable
...
Given the version:
"1.6 (ansible_version_var 14499e8bf3 ) last updated 2014/03/21 17:07:50 (GMT +200)"
We get the special variable:
"ansible_version": {
"full": "1.6",
"major": 1,
"minor": 6,
"revision": 0,
"string": "1.6 (ansible_version_var 14499e8bf3 ) last updated 2014/03/21 17:07:50 (GMT +200)"
}
modified: lib/ansible/playbook/__init__.py
modified: lib/ansible/runner/__init__.py
modified: lib/ansible/utils/__init__.py
12 years ago
James Cammarata
9ca8c3262c
Switch module safe_eval to ast.literal_eval
12 years ago
James Tanner
318e752b6f
Fixes #6845 evaluate changed_when only if task is not skipped
12 years ago
Michael DeHaan
ccdd91f9c2
Merge pull request #6861 from ericlake/devel
...
add distribution_major_version to fact gathering
12 years ago
James Tanner
5a65dc3b6a
Fixes #6820 fix erroneous missing vault password error when using the template module
12 years ago
Eric Lake
7f9736198a
add distribution_major_version to fact gathering
12 years ago
Serge van Ginderachter
e36e2d38fe
InventoryDir: another fix for the host.groups list
...
In some cases, where a host is mentioned in multiple groups, and those
groups are referenced in multiple ini files, a group could still contain
multiple instances of a group in its host,groups list, where only one of them
is the right group, that exists in the inventory.
12 years ago
James Cammarata
82b24c162e
Adding delimiter fixes to action_plugin + fixing local assembling with a delimiter
...
Also added a new integration test for assemble using local assembly
with a delimiter.
12 years ago
Michael DeHaan
2c7275e8a9
Merge pull request #6835 from sivel/version-compare-filter
...
Add version_compare filter
12 years ago
Michael DeHaan
0a574af270
Merge pull request #5555 from sivel/expose-playbook-to-callback
...
Expose the playbook to callback plugins
12 years ago
Michael DeHaan
1fa19e29e8
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
12 years ago
Matt Martz
7b5f89ec7c
Use PluginLoader for module docs fragments
12 years ago
Matt Martz
bb6f7a267a
Add support for shared module documentation fragments
12 years ago
James Cammarata
ee0a0b492b
Allow isprintable() util function to work with unicode
...
Fixes #6842
12 years ago
James Tanner
cdc0819939
Fixes #6088 turn off sudo and su if the connection is local the sudo user matches the current user
12 years ago
jctanner
2a9fcdd87c
Merge pull request #6711 from j2sol/raw-unreachable
...
Treat 255 errors from raw as dark host
12 years ago
jctanner
f6db60cbce
Merge pull request #6787 from tyll/pull_ssh_prompt
...
ssh: propagate prompt to _communicate()
12 years ago
Matt Martz
5770428e91
Add version_compare filter
12 years ago
James Cammarata
317c2f4bc0
Fixes to variable issues introduced by recent changes
...
Fixes #6801
Fixes #6832
12 years ago
Harlan Lieberman-Berg
876b8085aa
Add directory_mode to common file parameters to prevent errors.
12 years ago
Michael DeHaan
904f331210
Merge pull request #6788 from tyll/pull_ssh_verbose_comments
...
ssh connection plugin: Make comments more verbose
12 years ago
James Cammarata
a6a4680e5c
Fix variable naming issue in _load_tasks()
...
Fixes #6800
12 years ago
James Cammarata
6f34a6336f
Differentiate decryption failures from empty data files in ansible-vault
...
Fixes #6822
12 years ago
BoscoMW
39fcbd1f10
Update ssh.py
12 years ago
BoscoMW
165406cf35
Catch permissions errors related to opening a known_hosts file
...
Catch permissions errors related to opening a known_hosts file
12 years ago
James Cammarata
e2d86e4f43
Splitting SETUP_CACHE into two caches, one for host vars and one for setup facts
12 years ago
James Cammarata
a4df906fc9
Fixes to safe_eval
12 years ago
Tim G
c307a73e28
Check for errors from adb, may not work on all systems.
12 years ago
Tim G
285d4f3fa6
If memory not available in syslog.log, catch error, attempt to find it with adb
12 years ago
Till Maas
e6cb32f284
ssh connection plugin: Make comments more verbose
...
Explain _communicate() more.
12 years ago
Till Maas
1da69309e5
ssh connection plugin: Report missing sudo password
...
If no password is provided, sudo hangs at the prompt. Identify this and
report that the password is missing as an error.
12 years ago
Till Maas
2cae7472ad
ssh: propagate prompt to _communicate()
...
_communicate() uses the prompt variable to detect wrong passwords early,
therefore it needs to be passed to it from exec_command().
12 years ago
James Cammarata
612a1a64f0
Apply extra vars after all other vars have been merged in a play
...
Fixes #6677
12 years ago
James Cammarata
b9c044b8c9
Making the exception caught during os.dup of stdin explicit
...
Related to f23bb34
12 years ago
James Cammarata
f23bb344aa
Catch errors when duping stdin
...
Fixes #6657
12 years ago
James Cammarata
4f140be711
Merge branch 'devel' of https://github.com/Synforge/ansible into Synforge-devel
12 years ago
James Tanner
efba8b4771
Merge branch 'regexreplace' of git://github.com/jacobweber/ansible into jacobweber-regexreplace
12 years ago
James Tanner
2492c2714a
Fixes #5307 set relative paths to the files dir for roles and the inventory dir for non-role tasks
12 years ago
Till Maas
b07113f358
ssh: Properly check for wrong su password
12 years ago
GuiGui2
b9613665dd
Setup module: Additional facts when using ansible with Linux on System z
...
- Improved parsing of /proc/cpuinfo to take the specifics of Linux on
System z. ansible_processor and ansible_processor_cores are now
completed.
- Also improved virtualization facts in the same environment, parsing
the output of /usr/bin/lscpu to populate virtualization_type and
virtualization_role more precisely. If lscpu is not available, then
stick to the previous behavior.
12 years ago
James Cammarata
b698f7a44b
Add option to create host_key directory if it doesn't exist
...
Fixes #6731
12 years ago
Matt Martz
7e3dd1066c
Allow raw and script to support su
12 years ago
Michael DeHaan
a6b25e8657
Allow type=list module arguments to accept integers and floats.
12 years ago
Michael DeHaan
9921f804f9
Merge pull request #6643 from herbygillot/fact-full-hostname
...
Add a fact providing the full hostname, without the domain portion
12 years ago
Cristian Ciupitu
96ff1444f0
Micro-optimization: replace s.find(x)==0 with s.startswith(x)
...
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
12 years ago
Cristian Ciupitu
1eaf85b89f
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
12 years ago
Paul Oyston
1942a69ed2
Added template call to _executor_internal to allow the passing of arbitrary data to modules.
12 years ago
Jesse Keating
3315ba0b99
Treat 255 errors from raw as dark host
...
Any other module is able to detect a dark host, but raw was treating 255
as a return code from the module execution, rather from the connection
attempt. This change allows 255 to be treated as a connection failure
when using the raw module.
12 years ago
James Cammarata
78bdb078fe
Fix for bug related to async jid polling change plus a new test
12 years ago
James Tanner
88462729aa
Addresses #6708 fill in missing keywords for ssh.py _communicate
12 years ago
jctanner
7dc3dc5279
Merge pull request #6708 from sivel/put-file-control-master
...
Share p.communicate alternative logic between exec_command and put_file
12 years ago
James Cammarata
e09313120c
Make async jid's unique per host
...
The jid will now also contain the PID of the async_wrapper process,
and can each unique jid from each host is tracked rather than just
relying on one global jid per task.
Fixes #5582
12 years ago
James Tanner
38de8cc87e
Addresses #6705 Only set the role_uuid inside the role vars
12 years ago
Matt Martz
b8cb23d309
Share p.communicate alternative logic between exec_command and put_file
12 years ago
James Tanner
8991e403e8
Fixes #6705 Give each role a unique uuid and apply tags only to tasks matching the uuid
12 years ago
James Cammarata
9ede6f7f49
Convert gather_facts to a boolean value if it is not None
...
Fixes #5618
12 years ago
James Tanner
2a976ac313
Fixes #5059 Ignore lookup failures when templating a task name
12 years ago
Serge van Ginderachter
b0ff1ea425
performance optimisation in hash merge logic
...
rewrite deepcopy in util.merge_hash and just iterate
on an inventory with 500 groups and 800 hosts this brings back the
inventory initialisation from 13s to 3s (with hash_behaviour=merge)
12 years ago
Serge van Ginderachter
d4634983f0
Move group/host_vars parsing into core inventory
...
modified: lib/ansible/inventory/__init__.py
deleted: lib/ansible/inventory/vars_plugins/group_vars.py
modified: lib/ansible/utils/__init__.py
12 years ago
James Cammarata
7a3fa63db5
Fix for unicode environment variable handling
...
Fixes #5395
12 years ago
Serge van Ginderachter
f8ea93c732
Move inventory.set_playbook_basedir from ansible-playbook to playbook constructor
12 years ago
Serge van Ginderachter
cc28fd891b
Introduce noop vars plugin.
...
In preparation to move the group_vars plugin code into core.
new file: lib/ansible/inventory/vars_plugins/noop.py
12 years ago
Serge van Ginderachter
f6a55a3552
Refactor vars_plugins (host/group_vars)
...
Split out parsing of vars files to per host and per group
parsing, instead of reparsing all groups for each host. This enhances
performance.
Extend vars_plugins' API with two new methods:
* get host variables: only parses host_vars
* get group variables: only parses group_vars for specific group
The initial run method is still used for backward compatibility.
Parse all vars_plugins at inventory initialisation, instead of
per host when touched first by runner. Here we can also loop through
all groups once easily, then parse them.
This also centralizes all parsing in the inventory constructor.
modified: bin/ansible
modified: bin/ansible-playbook
modified: lib/ansible/inventory/__init__.py
modified: lib/ansible/inventory/vars_plugins/group_vars.py
12 years ago
James Tanner
3194fbd365
Fixes #6655 catch unicode encoding errors before sending to syslog
12 years ago
jctanner
7b8d1c0ffd
Merge pull request #6580 from ramondelafuente/fix-vault-editor-call
...
Changed call to EDITOR to allow for parameters
12 years ago
Ramon de la Fuente
c79c001bfb
Changed call to EDITOR to allow for parameters
...
The EDITOR environment variable is used to create and edit files in the vault.
But if the EDITOR variable contains parameters, subprocess.call() breaks.
This fixes the EDITOR environment variable to be safely split into a list.
It adds a dependency on shlex.
12 years ago
James Cammarata
c9bf7eb9bb
Don't run {failed|changed}_when checks until async_status is done
...
Fixes #5117
12 years ago
James Cammarata
4ea12c1b86
Make sure stat of dest is available in atomic_move
...
Fixes #6682
12 years ago
James Tanner
f9018a6f1d
Ensure handlers run when meta tasks are defined and add handler integration tests
...
Fixes #6678
Fixes #6670
12 years ago
Michael DeHaan
3eecc039b9
Merge pull request #6656 from Jmainguy/setup
...
Added ansible_date_time.weekday as a fact. This returns Monday,Tuesday,W...
12 years ago
James Cammarata
8c7828d469
Tweaking error message resulting from undefined template variables
...
Fixes #5114
12 years ago
James Cammarata
846933dd53
Make inventory parsing error detection smarter
...
If something is executable but doesn't look like it should be, or if
something is NOT executable and DOES looks like it should, show a
more apropos error with a hint on correcting the problem
Fixes #5113
12 years ago
Michael DeHaan
a062912a1f
Merge pull request #6658 from pilou-/fix_fix
...
'changed' key is not defined when task fails
12 years ago
Michael DeHaan
9be732d8f2
Merge pull request #6679 from renard/fix-simplejson-module
...
Fix TypeError when using old simplejson lib.
12 years ago
Herby Gillot
94297950a0
Name platform.node() fact as "nodename"
12 years ago
James Tanner
ebd1f70c5d
Typo in setting task_errors variable
12 years ago
Sébastien Gross
ef6b437d0d
Fix TypeError when using old simplejson lib.
...
On some very old simplejson does not support the 'encoding' and give
following exception:
TypeError: __init__() got an unexpected keyword argument 'encoding'
This fix runs json.dump with no encoding key (such as before #a023cb) on
TypeError exception only.
12 years ago
Serge van Ginderachter
d3eaa1b79e
InventoryDir: refactor logic
...
Make sure all hosts and groups are unique objects
and that those are referenced uniquely everywhere.
Also fixes test_dir_inventory unit tests which were broken after previous
patches.
modified: lib/ansible/inventory/dir.py
12 years ago
Serge van Ginderachter
188375171e
Inventory: raise error when adding a group that already exists.
...
The parsers check if a group already exists.
12 years ago
Serge van Ginderachter
be58808fe4
inventory script parser: do not add all the groups to *all* group
12 years ago
Serge van Ginderachter
0ceefbbf29
inventory ini parser: do not add all the groups to *all* group
...
but only those with lowest depth, so we keep a proper tree structure
12 years ago
Serge van Ginderachter
cc8efb4aab
inventory groups: make sure group.depth is updated on all grandchildren
12 years ago
Serge van Ginderachter
1c86909875
inventory group: add groups to parent_groups only once
12 years ago
Serge van Ginderachter
36f55d3549
inventory directory parser: add host to group only once
12 years ago
Serge van Ginderachter
8b215149d4
inventory directory parser: add groups to parent_groups non-recursively
12 years ago
Serge van Ginderachter
262ba0460a
inventory directory parser: add hosts to group non-recursively
12 years ago
James Tanner
605156c904
Fixes premature handler execution after adding force-handlers
12 years ago
James Cammarata
bc93732b1d
Catch permissions errors related to opening a known_hosts file in modules
...
Fixes #6644
12 years ago
James Cammarata
dc658eaa1c
Check to make sure the host is in the inventory vars cache before clearing it
...
Fixes #6660
12 years ago
James Cammarata
db345391e3
Fixing ownership when atomic_move is creating a file while sudo'ing
...
Fixes #6647
12 years ago
Pierre-Louis Bonicoli
c76501b8a3
'changed' key is not defined when task fails
...
fix KeyError introduced by fix of #6591 .
12 years ago
Jonathan Mainguy
b17b5ad85b
Added ansible_date_time.weekday as a fact. This returns Monday,Tuesday,Wednesday,Thursday,Friday,Saturday, or Sunday depending on the remote servers time. Useful for backups the way I use it
12 years ago
James Cammarata
bb723bedee
Merge branch 'atomic_move_restore_owner_group_rebase' of https://github.com/tyll/ansible into tyll-atomic_move_restore_owner_group_rebase
12 years ago
James Tanner
9169a11088
Fixes #4777 add --force-handlers option to run handlers even if tasks fail
12 years ago
Herby Gillot
c0886a5f3a
Add a fact providing the full hostname, without the domain portion
...
truncated.
12 years ago
Michael DeHaan
fba2f1f9a9
Merge pull request #6639 from fvieira/devel
...
Add missing sha1 import on known_hosts.py
12 years ago
Michael DeHaan
a24d3f78d9
Merge pull request #6634 from pilou-/fix
...
Remove print statements
12 years ago
James Cammarata
31628d86a1
Adding in a configurable option for the accelerate daemon timeout
...
This was apparently an oversite, as it has never been configurable
despite having a module parameter for the timeout.
12 years ago
James Cammarata
3ea5d573aa
Acclerate improvements
...
* Added capability to support multiple keys, so clients from different
machines can connect to a single daemon instance
* Any activity on the daemon will cause the timeout to extend, so that the
daemon must be idle for the full number of minutes before it will auto-
shutdown
* Various other small fixes to remove some redundancy
Fixes #5171
12 years ago
Francisco José Marques Vieira
e9d7476c28
Add missing sha1 import on known_hosts.py
12 years ago
Pierre-Louis Bonicoli
d3a470db0c
Remove print statements
...
"print item" raises an exception when type of item is
jinja2.runtime.StrictUndefined
12 years ago
James Tanner
5b3b9ba267
Addresses #4407 Caculate failed percentage based on serial and number of hosts in play
12 years ago
Michael DeHaan
d0cbb51170
Merge pull request #6615 from 8191/devel
...
Addresses #6591 Hide diff for lineinfile if file did not change.
12 years ago
Manuel Faux
b8158f5f6a
Addresses #6591 Hide diff for lineinfile if file did not change.
12 years ago
Joshua Conner
1c504eff68
etcd lookup: use $ANSIBLE_ETCD_URL if it exists in the env
12 years ago
James Tanner
14499e8bf3
Fixes #4325 allow async and poll parameters to be templated vars
12 years ago
James Tanner
ea5186ca63
Fixes #6590 add set_remote_user parameter to synchronize
...
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
12 years ago
James Tanner
95c79ad483
Fixes #4239 merge injects with new vars loaded from files
12 years ago
James Tanner
d327e3d11a
Fixes #5622 included tasks in roles now inherit tags from the role
12 years ago
Till Maas
898a38b074
module_utils/atomic_move(): Use tempfile module
...
Fix a potential race condition by using the tempfile module.
12 years ago
Till Maas
8f778a83df
module_utils/atomic_move(): Restore owner/group
...
Manually restore owner and group if both src and dest are on a separate
file system.
12 years ago
Michael DeHaan
e639b5382b
Change default gathering policy, add to docs.
12 years ago
Brian Coca
18adf07fc6
changed setting values and updated docs
12 years ago
Brian Coca
4dfa40f18e
added gathering control to ansible, defaults to 'smart'
12 years ago
Michael DeHaan
c42dbf80a2
Merge pull request #6586 from sivel/probline-logic-fix
...
Fix logic in process_common_errors for unbalanced quotes
12 years ago
James Tanner
b8f627d1d5
Prevent rewriting the encrypted file if decryption fails
12 years ago
James Tanner
e71857fbdf
Addresses #6579 Only strip vault passwords if given
12 years ago
James Tanner
8c2e1e2baa
Addresses #6579 Disallow vault passwords with newline characters by stripping them in utils
12 years ago
James Cammarata
a9000e7f3a
Making the error messages for bad key/dir permissions more understandable
...
Fixes #6254
12 years ago
Matt Martz
2aaecc5afa
Fix logic in process_common_errors for unbalanced quotes
12 years ago
James Cammarata
4880cfb5ea
Merge pull request #6568 from sivel/ssl-cert-validation-osx
...
Make SSL verification on Mac OS X work out of the box
12 years ago
James Tanner
67517e96d3
Fixes #6567 put the git wrapper script in the module temp dir
12 years ago
Matt Martz
1d3d73a0b6
Only write the DUMMY_CA_CERT on OS X
12 years ago
Matt Martz
3b5aa8bd30
Provide a dummy ca to allow OS X to do it's OpenSSL keychain magic
12 years ago
James Cammarata
eb7717aa02
Make sure all tags are in a list before merging for role deps
...
Fixes #6557
12 years ago
James Cammarata
c9fcbf7bdd
Change print message to vvv for missing known hosts in ssh.py
12 years ago
James Tanner
49807877fa
Fixes #6550 Use shell for pipe lookup subprocess.popen calls
12 years ago
James Cammarata
3f5440f7df
Make modules set a valid working directory
...
Fixes #6546
12 years ago
James Cammarata
84908a57fc
Don't filter role deps on tags
...
Also, fixed a bug where the tags were being merged into the wrong
data structure (passed_vars) in _build_role_dependencies()
Fixes #6439
Fixes #5709
12 years ago
Michael DeHaan
9da26da335
Merge branch 'ini_vars' of git://github.com/dmage/ansible into devel
12 years ago
Michael DeHaan
13f69dad05
Merge pull request #6527 from patrickheeney/hosts-bug
...
Fix for hostkey directory
12 years ago
Michael DeHaan
94e3350b38
Catch a unquoted line error. Fixes #6532
12 years ago
jctanner
b8d5ba42f5
Merge pull request #6523 from sergevanginderachter/vault-in-subdirs
...
Pass through vault_password when parsing host/group vars as directories.
12 years ago
James Cammarata
c4f1c3c6b0
Merge branch 'bcoca-file_fixes_clean' into devel
12 years ago
James Tanner
ad70e9bcd6
Fixes #6227 skip non-unicode strings and catch decode errors silently in template_from_string
12 years ago
James Tanner
20262b6c15
Remove unused variable in _executor_internal
12 years ago
James Cammarata
5d8c9d3f0f
Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean
12 years ago
James Cammarata
7edee91aba
Fixing a bug in role tag handling where only the first tag was used
...
Fixes #6517
12 years ago
James Tanner
ebb6b8442b
Catch unicode unescape failures in copy action plugin
12 years ago
patrickheeney
a9aab23f11
Fix for hostkey directory
12 years ago
James Tanner
b14c658532
Fix concatenation for with_file
12 years ago
Serge van Ginderachter
280498a7e5
Pass through vault_password when parsing host/group vars as directories.
...
Fixes a bug where vault_password parameter was not passed through in
_load_vars_from_folder()
modified: lib/ansible/inventory/vars_plugins/group_vars.py
12 years ago
Greg Dallavalle
77229553a3
fetch_url: Avoid credential stripping for FTP-scheme URLs
12 years ago
Michael DeHaan
fe696e4720
Merge commit.
12 years ago
Michael DeHaan
b41541c62a
Merge conflict.
12 years ago
Michael DeHaan
fd0ff6f174
Merge pull request #5711 from sivel/plugin-realpath
...
Use realpath for plugin directories instead of abspath
12 years ago
Michael DeHaan
6144c5e1e2
Merge pull request #5714 from eggsby/patch-2
...
Allow templates in ansible_sudo_pass inventory var
12 years ago
Michael DeHaan
b0dbc61d63
Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
...
license -- so usage of facts code in modules will be limited to GPLv3 modules.
12 years ago
Michael DeHaan
b8f1e4f765
Merge pull request #6134 from veeti/include_with_items_path
...
Show the offending file name with the include + with_items error
12 years ago
Michael DeHaan
4a06954a13
Merge pull request #6390 from sergevanginderachter/group-varsdirs-svn
...
group_vars plugin: do not parse hidden files in subfolders
12 years ago
Michael DeHaan
9cdbc53741
Merge pull request #6420 from bcoca/role_names
...
added new role_names variable that exposes current roles list
12 years ago
Michael DeHaan
26efc7ace8
Revert "Populate module_setup from the setup module rather than special code elsewhere"
...
This reverts commit 58eec2e4c2 .
12 years ago
Oleg Bulatov
f6a4c20cc0
Make parsing variables for hosts and groups more consistent
...
This commit allows to specify arrays in [group:vars] block.
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
12 years ago
Michael DeHaan
a9896afc66
Merge pull request #6418 from bcoca/template_itnore_errors
...
templates ignore_errors
12 years ago
Michael DeHaan
d5856bd475
Merge pull request #6391 from sergevanginderachter/hashmerge_inventoryscripts
...
Allow hash_behaviour=merge to be respected in core inventory
12 years ago
Dag Wieers
58eec2e4c2
Populate module_setup from the setup module rather than special code elsewhere
...
This small change allows for individual setup actions to populate the SETUP_CACHE and not cause a subsequent facts-gathering when not needed. This follows the standard of other facts modules as laid out in #1206 and implemented in fedfd18774 . It allows to test of the setup module has already been run even when gather_facts was explicitely disabled.
12 years ago
Michael DeHaan
3d44f7cd51
Merge pull request #6217 from ashokrajar/patch-1
...
pause plugin doesn't flush raw_input prompt
12 years ago
Cristian Ciupitu
0749112286
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
12 years ago
Cristian Ciupitu
a7da5d8702
Micro-optimization of inventory.expand_hosts.detect_range
12 years ago
brdo
3963a64a4f
Set keepalive to 5 seconds in paramiko_ssh.py
...
This update resolves https://github.com/ansible/ansible/issues/6476 .
12 years ago
Brian Coca
2d25577e11
Fixes and cleanup to file functions and module
...
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
12 years ago
James Cammarata
a0cb974575
Be sure to return to the old directory if cwd is set in run_command
12 years ago
James Tanner
a348f67238
Reset the current directory after running subprocess.Popen
12 years ago
James Cammarata
677008bef7
Rejoin args list into a string for run_command when using an unsafe shell
...
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
12 years ago
James Cammarata
5233d4bc31
Fix typo in run_command when sending data that is not binary
12 years ago
James Cammarata
b1a37dcc08
Revert "Rejoin args list into a string for run_command when using an unsafe shell"
...
This reverts commit 4273cb2d8e .
12 years ago
James Cammarata
4273cb2d8e
Rejoin args list into a string for run_command when using an unsafe shell
...
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
12 years ago
Michael DeHaan
d1753046e0
Revert "Correctly catch template errors without returning invalid data"
...
This reverts commit 3cd7d47b7e .
12 years ago
James Cammarata
303e085f8b
Only use cwd in run_command kwargs if the directory exists
12 years ago
James Cammarata
60a7f57300
Make sure the cwd exists in run_command before trying to use it
12 years ago
Dan Koch
bbf320fd22
Work around for cwd stat problems with run_command and sudo
...
This fixes issue #6443
12 years ago
James Cammarata
2c7d58abe0
Compile ca certs into a temp file to reduce number of attempts
...
For those who may have a large number of certs found, this can reduce
the number of ssl connections attempted.
12 years ago
Michael DeHaan
d37f0c6d12
Use same implementation as ssh.py for "is in host file" checks in module code, prevents git module from adding keys more than once.
12 years ago
Michael DeHaan
6d841d120e
Don't process shell commands as arrays.
12 years ago
James Cammarata
86d2ee4b97
Don't append tags from roles to the plays tags list
...
Fixes #6393
12 years ago
James Cammarata
a9017af2bb
Adding validate_certs to all modules that use fetch_url
12 years ago
Michael DeHaan
cfabc2e28a
module.run_command is intended to bypass the shell here, so can't do ">>"
12 years ago
James Cammarata
7f38cff989
Remove unused code from get_ca_certs() function
12 years ago
James Cammarata
804e4166c8
Rewriting ssl validation to try multiple certs found in paths
...
Previously, the function checked only for a single CA root cert, however
some distributions may have multiple certs in a directory. This will now
try any .crt or .pem file contained within several common paths for
each platform.
Fixes #6412
12 years ago
Michael DeHaan
0b0ca95731
Expand environment variables and tildes passed to commands generically across the board.
12 years ago
James Tanner
0e38f5dfdc
Check for hash availability during vault operations
12 years ago
Brian Coca
906e59d8a8
added new role_names variable that exposes current roles list
12 years ago
Brian Coca
7778aca966
templates ignore_errors
12 years ago
James Cammarata
6c25e78299
Merge branch 'devel' of https://github.com/dparalen/ansible into dparalen-devel
12 years ago
James Tanner
e4e64a9699
Rename lxc to libvirt_lxc
12 years ago
James Cammarata
bca6adc812
Merge pull request #4064 from mscherer/lxc
...
Add a plugin that permit to use ansible for lxc system, using libvirt
12 years ago
James Cammarata
430cce9df3
Merge branch 'ec2_security_token' of https://github.com/willthames/ansible into willthames-ec2_security_token
12 years ago
Serge van Ginderachter
6b1cb22fc3
Allow hash_behaviour=merge to be respected in core inventory
...
(For now, this means, enable it also for inventory scripts)
12 years ago
Serge van Ginderachter
29c60bdaff
group_vars plugin: do not parse hidden files in subfolders, e.g. avoid .svn/
12 years ago
James Tanner
6740a1f342
Wrap crypto.hash imports with try/except
12 years ago
Michael DeHaan
411bcb7161
Merge remote branch 'real/devel' into devel
12 years ago
Michael DeHaan
2fa6110961
Update the message about pycrypto to include that python-devel must be installed.
12 years ago
James Tanner
0d6f6ad282
Implement new default cipher class AES256
12 years ago
Michael DeHaan
20f0157152
Merge pull request #6378 from franckcuny/headers-gce-utils
...
Add BSD license to module_utils/gce.py
12 years ago
James Tanner
ba0fec4f42
Force command action to not be executed by the shell unless specifically enabled
12 years ago
James Cammarata
9730157525
Validate SSL certs accessed through urllib*
...
* Adds another module utility file which generalizes the
access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.
Fixes #6211
12 years ago
James Cammarata
6577ff5f85
Add tags from handlers to tag availability calculation
12 years ago
Richard Isaacson
4993cb57f4
Merge pull request #6283 from magicrobotmonkey/upstream
...
fix missing stdin in _parallel_runner
Tested with GIST https://gist.github.com/risaacson/7290d30a612e0c70ea1b .
Passes "make tests"
Passes non_destructive tests.
12 years ago
Franck Cuny
82f99bfa3d
Add BSD license to module_utils/gce.py
12 years ago
Matt Martz
4b400ca5e9
Only used stripped data for testing if the file is json, but used unstripped when actually parsing. Fixes #6348
12 years ago
Seth Woodworth
1d5db30067
Updates loop warning, removes unnecessary c
12 years ago
James Cammarata
04a6dc6d12
Check for skipped tags in passed role variables before adding to them
...
Fixes #6330
12 years ago
Michael DeHaan
d2cb35f898
Merge pull request #6320 from angstwad/instance-redo
...
Use isinstance() rather than a check using type()
12 years ago
James Cammarata
4753804ab4
Merge pull request #6332 from jimi-c/issue_6329_space_in_var
...
Correctly catch template errors without returning invalid data
12 years ago
James Cammarata
e3b887f770
Fix range issue in inventory and add additional error checking
...
Fixes #6331
12 years ago
James Cammarata
3cd7d47b7e
Correctly catch template errors without returning invalid data
...
Fixes #6329
12 years ago
James Cammarata
f80d02d841
Properly wrap logical elements together for su/sudo detection
12 years ago
James Cammarata
b6056044b7
Partial revert of 73c883c due to issues with handlers in roles
...
Fixes #6322
12 years ago
Michael DeHaan
e486dbab04
Use the loaded variable since we have it assigned, not just for error detection.
12 years ago
Michael DeHaan
3f07ec3d73
Fixup JSON error reporting in previous commits.
12 years ago
Michael DeHaan
a4d01b0891
Also search .json filenames
12 years ago
Michael DeHaan
79799f6819
Allow any file that can be in YAML to also be in JSON. This is primarily done to support non-visual editors better.
12 years ago
James Cammarata
a0f939581d
Merge branch 'aresch-devel' into devel
12 years ago
Paul Durivage
3cce3650e5
Use isinstance() rather than a check using type()
12 years ago
Richard Isaacson
119434d079
Merge pull request #6319 from risaacson/fix_test_dir_inventory
...
Fix TestInventory Unit Tests
Tested clean.
12 years ago
James Cammarata
9b79591f23
Merge branch 'devel' of https://github.com/aresch/ansible into aresch-devel
12 years ago
James Cammarata
2a0028e687
Sanitize run_command argument output
...
Fixes #6316
12 years ago
Andrew Resch
4d80019ac8
Fix logic checking for both sudo and su, and their respective users
12 years ago
Richard C Isaacson
16fe09eef8
Fixes related to uncommenting test_dir_inventory in TestInventory.
...
0. Uncomment the test.
1. Test fails.
2. Make vars unique per file in test inventory files.
3. Modify token addition to not ast.literal_eval(v) a variable containing a hash.
4. Modify vars to have an escape in test inventory file.
5. Catch exceptions explicitly. Any unknown exceptions should be a bug.
6. Test passes.
12 years ago
James Cammarata
9f2999df79
Un-escape newlines in delimiters for assemble module
12 years ago
Brian Coca
79809b67dc
fixed another line with same issues
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Brian Coca
d3d5680d8f
tags lists are properly uniqued and joined now, also avoids type issues when passed as list/set or strings
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Will Thames
b9a7352e0a
Work to allow security tokens and profiles to work with Ansible
...
Allow security tokens and profiles to be used as arguments
to the 'common' ec2 modules
Mostly refactoring to provide two new methods,
`get_aws_connection_info`, which results in a dict that can be
passed through to the boto `connect_to_region` calls, and
`connect_to_aws` that can pass that dict through to the
`connect_to_region` method of the appropriate module.
Tidied up some variable names
Works around boto/boto#2100
profiles don't work with boto < 2.24, but this detects for that
and fails with an appropriate message. It is designed to work
if profile is not passed but boto < 2.24 is installed.
Modifications to allow empty aws auth variables to be passed
(this is useful if wanting to have the keys as an optional
parameter in ec2 calls - if set, use this value, if not set,
use boto config or env variables)
Reworked validate_certs improvements to work with refactoring
Added documentation for profile and security_token to affected modules
12 years ago
James Cammarata
0e98496e12
Merge pull request #6299 from jimi-c/issue_4656_role_deps_across_plays
...
Keep track of role dependencies across plays
12 years ago
Michael DeHaan
94a7fb60fe
Allow escaped comments in inventory files.
12 years ago
aresch
23a0468a4b
Fix respecting remote_tmp when sudo is used
12 years ago
James Tanner
4e8ed92130
Fixes #6077 decode escaped newline characters in content for the copy module
12 years ago
Richard C Isaacson
b41d8106ff
Revert "Merge pull request #6287 from risaacson/fix_hash_in_var"
...
This reverts commit a808287451 , reversing
changes made to 6129ea7566 .
12 years ago
James Cammarata
73c883c122
Keep track of role dependencies across plays
...
Also fixes a bug in which tags specified on top-level roles were
not being passed down to dependent roles.
Fixes #4656
12 years ago
Richard Isaacson
a808287451
Merge pull request #6287 from risaacson/fix_hash_in_var
...
Fix inventory for test_dir_inventory, merge PRs from GH-5749, cleanup some formatting.
12 years ago
James Tanner
6129ea7566
Fixes #6298 and adds a sudo unit test for synchronize
12 years ago
Richard C Isaacson
38abd5e20e
Break this out into a reusable function and document regex shortcomings.
12 years ago
Luca Berruti
7cf363910a
fixes #6244
12 years ago
jctanner
40ee030790
Merge pull request #6265 from franckcuny/gce-fixes
...
Add credential parameters to the GCE modules.
12 years ago
Franck Cuny
6294264dc4
Add credential parameters to the GCE modules.
...
In order to simplify the workflow with the GCE modules, it's now
possible to add the parameters and project name as arguments to the
various GCE modules.
The inventory plugin also returns the IP of the host in
`ansible_ssh_host` so that you don't have to specify IPs into the
inventory file.
Some update to the documentation are also added.
Closes #5583 .
12 years ago
Richard C Isaacson
49bd8b0b35
Fix inventory for test_dir_inventory
...
It came up that fixing this unit test may relate to another ticket that is open. This work allows us to uncomment this unit test by fixing how we pars variables allowing a quoted variable to contain a '#'.
Work also went into cleaning up some of the test data to clarify what was working.
Lastly work went into cleaning up formatting so that the code is easily read.
12 years ago
Aaron Bassett
5c589af191
fix missing stdin in _parallel_runner
12 years ago
Richard Isaacson
92aacb198c
Merge pull request #6156 from iiordanov/devel
...
Add support for checking host against global known host files.
The effect of this is that before this fix if files are spread across the known_hosts file but not in the ~/known_hosts file the hosts will execute sequentially. This PR augments the functionality so that all of the knowns hosts will execute in parallel.
12 years ago
Richard Isaacson
e79d859dfb
Merge pull request #6213 from sergevanginderachter/fix-delegate-templating
...
Fixes templating of ansible_ssh_host for delegates.
Tested that this works. Confirmed.
12 years ago
Michael DeHaan
435104065e
Merge pull request #6248 from hkariti/fix_list_copy
...
Fix incorrect use of copy() on list, causing a traceback
12 years ago
Jesse Keating
0c2c37a47a
Avoid range selection on empty groups
...
This prevents a traceback when the group is empty.
Fixes #6258
12 years ago
James Tanner
623cd9ac50
Revert "Merge pull request #6250 from dagwieers/gather_facts-once"
...
This reverts commit b769b4181a , reversing
changes made to 1e01fb856d .
12 years ago
Dag Wieers
0da06eff5c
Fix regression causing setup to run for every play
...
This patch makes sure setup only runs once, unless it is enforced on a play.
12 years ago
Hagai
0e4b38ed5a
Fix incorrect use of copy on list
12 years ago
Tefnet
c652802d29
missing import in assert module
...
Fixed missing ansible.errors import in assert module
12 years ago
Michael DeHaan
16d3be03af
Remove a few extra legacy variable feature references.
12 years ago
Michael DeHaan
46ec8759d5
Remove the legacy templating code, which was guarded by deprecation warnings in the previous two releases, and undocumented for a long time. use {{ foo }} to access variables instead of ${foo} or $foo.
12 years ago
Michael DeHaan
9d01d88a57
Bump versions on the devel branch (devel branch version is 1.6)
12 years ago
Michael DeHaan
5443ddec75
Trim references to fireball as we want folks using accelerate or pipelining options. Fireball is pretty well deprecated at this point, but will still be part of the release.
12 years ago
James Cammarata
79645535c0
Handle empty results from failed connections in _remote_md5()
...
Fixes #5800
12 years ago
Gilles Cornu
04f6367172
Fully clean 'ssh_old' and 'paramiko_alt' options
...
These transports have been removed in 33857855ad
12 years ago
Ashok Raja R
cb3c6417dd
pause plugin doesn't flush raw_input prompt
...
##### Issue Type:
Bugfix Pull Request
##### Ansible Version:
ansible 1.4.3
##### Environment:
N/A
##### Summary:
We are using a wrapper python script to run ansible-playbook. We use subprocess to execute and print the stdout as and when its written. Problem is when we use pause it doesn't display the prompt string as raw_input does not flush stdout before reading from stdin.
It looks like a dirty fix to add "\n" to the prompt string but i don't see any other way to over come this. If anyone else have a better fix please do propose/suggest.
##### Steps To Reproduce:
```yaml
#File: test_play.yml
- name: Test
hosts: $nodes
gather_facts: false
tasks:
- name: Waiting for User
local_action: pause prompt="Do you want to continue (yes/no)? "
```
```python
#!/usr/bin/env python
#File: test.py
import shlex, subprocess
def run_process(process):
process = process.encode("utf-8")
command = shlex.split(process)
p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
for line in iter(p.stdout.readline, b''):
print line,
cmd = "/usr/bin/python -u /usr/bin/ansible-playbook -i hosts.txt test_play.yml -e 'nodes=local'"
run_process(cmd)
```
```
shell $ python test.py
```
##### Expected Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
Do you want to continue (yes/no)? :
```
##### Actual Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
```
12 years ago
James Cammarata
df9de6ea71
Expand the source path in the action plugin when not using a remote source
...
Fixes #6209
12 years ago
Serge van Ginderachter
9833263417
Fixes templating of ansible_ssh_host for delegates
12 years ago
James Cammarata
c11e2100e0
Save the original transport in runner after detecting the smart transport
...
Fixes #6192
12 years ago
Michael DeHaan
cd7d7eb1bc
Merge pull request #6202 from muffl0n/unarchive_destdir
...
unarchive: output dest in error-message
12 years ago
muffl0n
17946b23d5
output dest in error-message
12 years ago
Richard C Isaacson
9c8bbe2904
column must always be less than len(probline)
...
Fixes related to GH-5773.
12 years ago
James Cammarata
14ba10393b
Minor tweak to region config in boto configuration file
12 years ago
James Cammarata
88acb48e61
Merge branch 'ec2_boto_config_region' of https://github.com/willthames/ansible into willthames-ec2_boto_config_region
12 years ago
James Cammarata
2a383786dd
And remove the expanduser calls from the action_plugin
12 years ago
Richard C Isaacson
585766201d
When looking for double colon len(line) is longer then 1.
...
Addresses GH-5116.
It comes up that when parsing json that if you are missing the last double quote on the last variable and the next line is just '}' we will get an out of range error. In this instance we will also then make sure that the line is long enough to have two colons.
12 years ago
James Cammarata
b758ed9417
Merge pull request #6150 from hkariti/fix_join_bug
...
Fix incorrect use of .join on list causing a traceback
12 years ago
James Cammarata
96f1c3ce2e
Move where the expanduser call is made, to avoid issues with None
12 years ago
James Cammarata
e659d55d62
Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel
12 years ago
James Cammarata
5ff20c1ae7
Merge branch 'scottanderson42-ec2-params' into devel
12 years ago
James Tanner
baed7a0ed9
Fixes #6187 Add unit tests for VaultLib
12 years ago
Michael DeHaan
33857855ad
removing some unusued files. Paramiko alt was an experiment to attempt pipeline for paramiko, ssh_old is the non-pipelining-supported earlier
...
version of the OpenSSH transport, which is configurable now and unified.
12 years ago
James Tanner
35def422a3
Addresses #6188 Add --vault-password-file to bin/ansible and bin/ansible-playbook
12 years ago
James Cammarata
8a7c68dc18
Merge branch 'ec2-params' of https://github.com/scottanderson42/ansible into scottanderson42-ec2-params
...
Conflicts:
lib/ansible/module_utils/ec2.py
library/cloud/ec2
12 years ago
Richard C Isaacson
af616fe15e
Rename flatten funciton.
...
flatten(x) is used a lot in the various lookup plugins where in each it is slightly different. This is to make this name slightly more unique.
12 years ago
Kent R. Spillner
1fcc9ff666
lookup_plugins: loop over hashes
...
Create a lookup plugin named dict that can be used to loop over hashes.
It converts a dict into a list of key-value pairs, with attributes named
"key" and "value." Also adds a brief explanation and simple example to
the docs.
Signed-off-by: Kent R. Spillner <kspillner@acm.org>
12 years ago
James Tanner
876035c0b1
Fixes #6161 Get the delegate host info properly from the hostvars object
12 years ago
James Tanner
9209581565
Fixes #6155 Inject checkmode into synchronize module args
12 years ago
James Cammarata
a18f811b2d
Merge branch 'jimi-c-issue_4620' into devel
12 years ago
James Cammarata
f23ccebbdc
Merge branch 'issue_4620' of https://github.com/jimi-c/ansible into jimi-c-issue_4620
12 years ago
James Tanner
0f95a905d9
Fixes #5965 Ensure the inject for each item in a loop is un-altered
12 years ago
Iordan Iordanov
a1854bb762
Add support for checking host against global known host files.
12 years ago
James Cammarata
3b2d409906
Fixing several bugs in assemble and updating tests
...
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
resulting in it never being used by the module as the default behavior
was remote_src=True (issue #5581 )
* the remote_src param was not listed in the generic file params, leading
to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
fragments do not run together on one line
Fixes #5581
12 years ago
jctanner
8a253bf576
Merge pull request #6151 from jctanner/vault_rewrite
...
Vault rewrite, pass 1
12 years ago
jctanner
93c746db9c
Merge pull request #5651 from nikut/sshfix
...
allow ansible_ssh_private_key_file to be templated (thanks to benno)
12 years ago
James Tanner
9c9f15acb7
Fix decryption error
12 years ago
James Tanner
52a8efefba
Vault rewrite, pass 1
12 years ago
Hagai
ae9c0d87a9
Fix incorrect use of .join on list
12 years ago
Richard C Isaacson
8be8dbc9ed
Formatting cleanup.
12 years ago
Richard C Isaacson
aaf0a182e1
Merge remote-tracking branch 'jeromew/ansible_script_creates' into issues_4986
12 years ago
Veeti Paananen
dd6f2e6bfa
Show the offending file name with the include + with_items error
12 years ago
Michael DeHaan
9686695170
Assume empty files are unencrypted.
12 years ago
James Tanner
4af1d6098b
Fixes #5939 Allow for delegate hosts that are not in inventory
12 years ago
James Cammarata
fa1ab231c9
Fixing bug in which playbook vars were not merged properly
...
This occurred when a hash would be passed in via extra args and the
hash variable behavior was set to 'merge', which resulted in the
variable from extra args replacing the playbook variable.
12 years ago
Michael DeHaan
bc65956798
Add tests that leverage most of our custom filters. A few more to add.
12 years ago
James Cammarata
f5505425f9
Adding 'expanduser' filter to the core filters list
...
Example usage: {{ my_path | expanduser }} # my_path: "~/path/to/file"
12 years ago
James Cammarata
ef2df8157a
Fixup result dictionary when copy module calls file module
12 years ago
muffl0n
b0f00cc097
already call expanduser in action_plugin
12 years ago
muffl0n
5f0e882d01
call expanduser for src and dest
12 years ago
root
0df166e7c0
Copy tests WIP, fix bug in assert module upgrades where the wrong value was being checked.
12 years ago
James Cammarata
54117ab28f
Modified assert module to take tests as an array
12 years ago
James Tanner
bee089d5e1
Remove entropy comment
12 years ago
James Tanner
86b9f84fb9
Change entropy message for vault
12 years ago
Richard Isaacson
dc403eb21e
Merge pull request #6058 from jctanner/vault_squashed_2
...
Ansible vault: a framework for encrypting any playbook or var file.
12 years ago
James Tanner
3a965a1392
Remove intermediate string on decrypt
12 years ago
James Tanner
286ca505bd
Remove breakpoint
12 years ago
James Tanner
84467a8f12
Change retype to confirm
12 years ago
James Tanner
aa46ab1d86
Fix function name
12 years ago
James Tanner
3fc87e011b
Fix all other calls to yaml
12 years ago
James Cammarata
b6222abee6
Fix unicode decode error in syslog for modules
...
Fixes #6056
12 years ago
James Tanner
427b8dc78d
Ansible vault: a framework for encrypting any playbook or var file.
12 years ago
Richard C Isaacson
1ac19cb981
Copy action_plugin: encode content when dict.
...
When content is processed and found to be valid JSON it is decoded into a dict. To write it out to a file we need to encode it back into a string.
Addresses GH-5914.
12 years ago
James Cammarata
f29ce80d12
Default port to 22 for paramiko when it is unset
12 years ago
James Cammarata
92cbfff904
Merge branch 'sshdefault' of https://github.com/craigtracey/ansible into craigtracey-sshdefault
12 years ago
jeromew
7a14cb61c4
Add creates= and removes= to the script: action
12 years ago
Niku Toivola
6cc9b16f06
allow templating of ansible_ssh_private_key_file also in the synchronize module
12 years ago
Niku Toivola
2faaff78ee
removed comment
12 years ago
Niku Toivola
68a3e8163e
allow ansible_ssh_private_key_file to be templated (thanks to benno)
12 years ago
Martin Thorsen Ranang
7e23ed345f
Avoid breaking on unicode input when logging to syslog in modules
...
After commit 254f87e , non-ascii input broke logging to syslog.
12 years ago
James Cammarata
0cfaabf9cb
Make sure unicode params don't break logging in modules
12 years ago
James Cammarata
788ac51185
Sanitize sudo success_key from stdout for raw/script modules
...
Fixes #5533
Closes #5605
Closes #5606
Closes #5607
12 years ago
Richard C Isaacson
80ddd1ca75
Config resoution order correction and documentation.
12 years ago
James Cammarata
4012f4bb95
Merge branch 'allow-equals-in-ini-vars' of https://github.com/worklez/ansible into worklez-allow-equals-in-ini-vars
12 years ago
James Cammarata
faa645c834
Merge pull request #6001 from jimi-c/issue_4087_sanitize_output
...
Filter out messages that match the pattern username:password@host
12 years ago
Ilya Kuznetsov
0658847ea6
Allow equal sign in single-line ini variables
12 years ago
Michael DeHaan
c91ceddfac
Add the start of an integration test structure using Ansible playbooks, also added an assert action plugin to make writing those easier.
12 years ago
Chris Hoffman
affed67ebd
Small fix for ec2 validate_certs option
12 years ago
James Cammarata
b8646991db
Filter out messages that match the pattern username:password@host
...
This filtering is done in both the module invocation logging and in
the regular verbose() logging output.
Fixes #4087
12 years ago
James Cammarata
056d54ebd3
Adding 'validate_certs' option to EC2 modules
...
When disabled, the boto connection will be instantiated without validating
the SSL certificate from the target endpoint. This allows the modules to connect
to Eucalyptus instances running with self-signed certs without errors.
Fixes #3978
12 years ago
Brian Coca
31b5728618
directory detection should now work on BSDs, added AIX alternate path
12 years ago
James Cammarata
254f87e7dd
Fix log handling of unicode output to syslog in modules
12 years ago
Richard Isaacson
eb4a730933
Merge pull request #5969 from risaacson/pull_5136
...
Updates for the unarchive module and action_plugin.
12 years ago
Richard C Isaacson
598b9c6b7c
Cleanup per notes.
...
Some small changes to per notes from @mpdehann.
12 years ago
Richard C Isaacson
cb7c2b7524
Updates for the unarchive module and action_plugin.
...
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.
PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!
Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.
Tests were added via a playbook with archive files to verify functionality.
All tests fire clean including custom playbooks across multiple linux and solaris systems.
12 years ago
Jacob Weber
35742fe008
Add regex_replace jinja2 filter
12 years ago
Richard C Isaacson
e6c9705058
Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136
12 years ago
James Cammarata
a023cbce14
When using jsonify in modules, try several unicode encoding for dumps()
...
Fixes #4821
12 years ago
James Tanner
9ce46e5f41
Refactor the synchronize action plugin and add unit tests
12 years ago
James Cammarata
3f90020d62
Open LOG_LOCK file with FD_CLOEXEC to prevent file descriptor leakage
...
Fixes #5399
12 years ago
James Cammarata
bbda98a3ee
Merge branch 'issue_4812' into devel
12 years ago
James Cammarata
bb79b16d59
Specify mode in the makedirs call for fireball/accelerate keys
12 years ago
James Cammarata
65cb79a5c1
Merge branch 'devel' of https://github.com/xyrix/ansible into xyrix-devel
12 years ago
Scott Anderson
baf508a379
Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key.
12 years ago
Richard C Isaacson
786e3d2fd2
Refining the fix made in #5885 .
...
It turns out that some of the assumptions in #5885 were slightly off. The previous fix relied on a call to the module to creat a tmp_path. This is insufficent as there are few cases that we need to have the tmp directory before we make the module call. If we don't have a tmp_path before we do a recursive call or when we find a file that does not match the remote md5 hash we need to create a tmp directory. Also we are not more percise when we will need to clean up the remote tmp_path.
12 years ago
Michael DeHaan
1609dfbca4
Revert "Revert "Revert "Add the fork manager code (related to previous patch)."""
...
This reverts commit 60d3611b70 .
12 years ago
Michael DeHaan
633d685bb7
Revert "Revert "Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks"""
...
This reverts commit 73ca1a173c .
12 years ago
Michael DeHaan
ad8c275887
Revert "While the previous work on the foon class can't be quite recycled, it's still a nice abstraction."
...
This reverts commit caab52aee2 .
12 years ago
Michael DeHaan
caab52aee2
While the previous work on the foon class can't be quite recycled, it's still a nice abstraction.
12 years ago
Michael DeHaan
73ca1a173c
Revert "Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks""
...
This reverts commit 6685b4989e .
12 years ago
Michael DeHaan
60d3611b70
Revert "Revert "Add the fork manager code (related to previous patch).""
...
This reverts commit c53538dc77 .
12 years ago
Michael DeHaan
6685b4989e
Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks"
...
This reverts commit 85d66b9a0c .
12 years ago
Michael DeHaan
c53538dc77
Revert "Add the fork manager code (related to previous patch)."
...
This reverts commit adb1719fe8 .
12 years ago
Michael DeHaan
adb1719fe8
Add the fork manager code (related to previous patch).
12 years ago
Michael DeHaan
85d66b9a0c
This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks
...
between tasks in a playbook is avoided. The fork pool will be regenerated when a second play comes along and needs more hosts.
12 years ago
Richard Isaacson
2d88246c9d
Merge pull request #5885 from risaacson/issue5739_4
...
Addresses #5739 and cleans up copy.py
12 years ago
James Tanner
b3ab7e7885
Check mutually_exclusive parameters before applying defaults
12 years ago
Will Thames
d5c309e20d
Pick up default EC2 region from boto.config
...
This doesn't account for boto configs where e.g. RDS has one
default region and EC2 another - all will default to `ec2_region_name`.
However, this is just handy to allow an easy site wide default
region if existing configuration already relies on it.
Modules can be improved to mention this in the documentation and
turn off required=True where needed. But it works with `ec2`
and `ec2_vol` without change.
12 years ago
jctanner
0bc0315171
Merge pull request #5880 from willthames/ec2_modules_refactor
...
Create a common EC2 connection argument spec for EC2 modules
12 years ago
xyrix
20d97416e5
fixed thinkoes
12 years ago
xyrix
0af40374ed
fixed file perms checking
12 years ago
xyrix
1de45bf687
made accelerate keys directory configurable, and permissions for the file and dir configurable, and gave them a safe default
12 years ago
James Cammarata
a72dc2ec34
Use finalize method in jinja2 to convert None values to empty strings
...
Fixes #4812
12 years ago
Will Thames
7600c664fe
Create a common EC2 connection argument spec for EC2 modules
...
Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
12 years ago
jctanner
28933de84d
Merge pull request #5771 from bcoca/play_hosts2
...
added new play_hosts var
12 years ago
James Cammarata
959a156195
Properly count newlines appearing at the end of templates after rendering
...
Fixes #4633
12 years ago
James Cammarata
ca0ec800d8
Revising method for parsing ranges from --limit subsets
...
Also added a new test (test_subset_range) for future validation.
Fixes #4620
12 years ago
Richard C Isaacson
ac0a5c8ad5
Dug into the remaining FIXME and replaced with comments to document the expected behavior.
12 years ago
Luca Berruti
75b7a1d9c7
Fix slow ssh
...
We break the read while loop after waiting "the end of the process" and
the pipes are empty, otherwise we do another select that waits all the
timeout.
12 years ago
jctanner
a0f91f2aaa
Merge pull request #5576 from xyrix/symlink-bug-fix
...
fixed bug causing symlinks to fail in the host_vars, group_vars etc dire...
12 years ago
jctanner
253fe7be50
Merge pull request #5662 from RSpiertz/update_playbook_error
...
PlayBook: better error message
12 years ago
Richard C Isaacson
a3261500dd
Addresses #5739 and cleans up copy.py
...
The copy action_plugin is not easy to read. Part of this commit is taking that file, restructuring it, and adding comments. No functionality changed in how it interacts with the world.
The fix for #5739 ends up being the assumption that there is a cleanup 'rm -rf' that happens at the end of the copy loop. This was not the fact before and we made a bunch of tmp directories that we hoped would end up being cleaned up. Now we just use the tmp directory that the runner provides and cleanup inline if it is a single file to be coppied or after the loop if it is a recursive copy.
As a part of this we did end up having to change runner to provide a flag so that we could short the inline tmp directory removal. This flag defaults to True so it will not change the behavior of other modules that are being called.
12 years ago
James Tanner
5fafc61008
Fixes 5870 Template delegate hostname earlier in the process
12 years ago
James Tanner
d355d3c698
Fixes #5818 Default to all known connection information for the delegate host
12 years ago
Timur Batyrshin
658c15930e
reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 ( #5852 )
12 years ago
James Cammarata
2d0e9cd75d
Revert "Fix for issue 5739. The copy module does not delete directories it will only unlinks symlinks."
...
This reverts commit b20dc4f578 .
12 years ago
James Cammarata
ae9843fccd
Fix issue with handler notifications being sent out incorrectly
...
This is a partial revert of e8ad36c , which introduced the bug.
Fixes #5848
12 years ago
James Cammarata
9ff99acaff
Merge branch 'issue5739_3' of https://github.com/risaacson/ansible into risaacson-issue5739_3
12 years ago
Brian Coca
ff024b65b2
now with_items also accepts sets
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Richard C Isaacson
b20dc4f578
Fix for issue 5739. The copy module does not delete directories it will only unlinks symlinks.
12 years ago
James Cammarata
75e3b59bbd
Adding no_log: capability for tasks
...
Fixes #4088
12 years ago
James Tanner
e6aeb191d5
Revert "Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh"
...
This reverts commit fe091ec00d , reversing
changes made to aed2194b1d .
12 years ago
James Cammarata
9574f89471
Detect remote_user change in accelerate daemon and allow a restart
...
Fixes #5812
12 years ago
jctanner
6c25ea1b91
Merge pull request #5527 from sergevanginderachter/basedirdwim
...
path_dwim: fix when basedir not set
12 years ago
James Cammarata
f955d9db6a
Handle implicit localhost when using '-i host,' syntax
...
Fixes #5820
12 years ago
jctanner
360f06b41d
Merge pull request #5806 from sivel/rax-mod-utils-improvements
...
Rax mod utils improvements
12 years ago
James Cammarata
5cc354696d
Build variable dictionary on included plays without using dict()
...
Using dict(k=v) means the key was always named 'k', as the variable
is not interpreted there.
Fixes #5801
12 years ago
Michael DeHaan
d07a3b5e9b
AnsibleWorks -> Ansible
12 years ago
Heikki Hokkanen
b6875b3b87
Fix .ssh/known_hosts path expansion.
...
In particular, do not rely on the $USER environment variable always existing.
tmux for example seems to clear it, causing lots of invalid messages:
"previous known host file not found"
This broke in commit 80fd22dc , but instead of reverting that commit, we now
fall back to expanding just ~ when $USER is not set.
12 years ago
Matt Martz
ac666e63e0
Support providing a tenant_name also
12 years ago
Matt Martz
aa709012ba
Make sure to also include the region when using keyring_auth
12 years ago
Matt Martz
021b926235
Only specify to USE_KEYRING as the api_key/password when we actually got a keyring_username from ~/.pyrax.cfg
12 years ago
Matt Martz
1ac7dffd55
Support using ~/.pyrax.cfg and multi environments
12 years ago
Matt Martz
139e905e98
identity_type is set dynamically above
12 years ago
Matt Martz
bc473c5be3
Support additional attributes that would allow the rax modules to work with other OpenStack clouds
12 years ago
Matt Martz
d7597414b8
Support keyring for the api_key
12 years ago
James Tanner
fe091ec00d
Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh
12 years ago
Adam Heath
aed2194b1d
self.su_user is done earlier in the code path, and is auto-vivified from
...
su_user_var. My last PR was only half merged, and when the bug fix for
the su/su_pass typo was merged, the removed line in this commit was
mistakenly reintroduced.
12 years ago
James Tanner
3ec043ec17
Fixes #5750 Fail on missing ~/.ssh and ignore accept_hostkey if stricthoskeychecking is off
12 years ago
James Cammarata
88e2595a90
Fixing bug relating to su without an su_pass
12 years ago
Adam Heath
fac7c6d3fe
Allow su_user to be templated, same as sudo_user.
12 years ago
James Cammarata
3fddd78ec5
Fixing traceback caused by incorrect argument passing to json.dumps
...
Fixes #5756
12 years ago
Brian Coca
59d5892fa3
added new play_hosts var
...
this variable has the 'current host list' to be executed over in the
play. Useful when using --limit to not iterate over hosts not included
in play in templates or with_items.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
jctanner
b2d594d24e
Merge pull request #5724 from angstwad/su-tasks-fix
...
Fix bug where playbook tasks do not escalate privs with 'su'
12 years ago
jctanner
19e8742005
Merge pull request #5713 from angstwad/su-fix
...
Disallow su and sudo params in same play/task
12 years ago
Craig Tracey
8c6b3baf6f
Make default ANSIBLE_REMOTE_PORT None
...
The ansible remote port should be None, not 22. Having a default value
of 22 means that '-o Port 22' will be appended to the ssh connection
all of the time. This is incorrect as when one would like to use
something like an ssh configuration file (-F) that sets the port to
something other than 22.
Part of this change requires that we check that, in get_config, the
value is not None before trying to cast it into an integer or float.
12 years ago
Paul Durivage
e875089eba
Fix bug where self.su was being set by the sudo param in play tasks
12 years ago
Paul Durivage
01d1bd61e7
Disallow su and sudo params in same play/task
12 years ago
James Cammarata
ff8eb5f454
Merge pull request #5722 from jeromew/pipelining_default
...
Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean
12 years ago
jeromew
ef69d23715
Bug: chmod should be called only if the tmp dir was created in the first place
12 years ago
jeromew
3f23483022
Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean
12 years ago
Thomas Omans
9343db69b4
Fixing whitespace
12 years ago
Thomas Omans
ce0b5d16b3
Allow templates in ansible_sudo_pass inventory var
...
Template ansible_sudo_pass the same way we template ansible_ssh_pass.
12 years ago
Matt Martz
5ba6739603
Use realpath for plugin directories instead of abspath
12 years ago
James Tanner
61d283e2ad
Fix merge conflicts from #5519
12 years ago
jctanner
da136dbe7c
Merge pull request #5694 from angstwad/add-su-support-revert
...
Add su support
12 years ago
Rob Smith
761fe8cc04
Fix an issue where git-pull fails with AttributeError
...
As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull
```
Starting ansible-pull at 2014-01-20 23:09:57
Traceback (most recent call last):
File "/tmp/ansible/bin/ansible", line 157, in <module>
(runner, results) = cli.run(options, args)
File "/tmp/ansible/bin/ansible", line 82, in run
hosts = inventory_manager.list_hosts(pattern)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts
result = [ h.name for h in self.get_hosts(pattern) ]
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts
subset = self._get_hosts(self._subset)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts
that = self.__get_hosts(p)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts
hpat = self._hosts_in_unenumerated_pattern(name)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern
ungrouped.add_host(new_host)
AttributeError: 'NoneType' object has no attribute 'add_host'
```
The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.
12 years ago
Rob Smith
953dc6b345
When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code.
12 years ago
Paul Durivage
f72f5a20df
Revert "Revert "Merge pull request #5325 from angstwad/add-su-support""
...
This reverts commit c17d0e0357 .
Conflicts:
lib/ansible/runner/connection_plugins/paramiko_ssh.py
12 years ago
Paul Durivage
4c84ba74b0
Resolve su bug in paramiko libs
12 years ago
Jesse Keating
6013f0738e
Store the list of hosts to run on in runner object
...
This reduces the number of times inventory.list_hosts is called, which
can be costly. When coming from a playbook that data is already known.
12 years ago
Jesse Keating
e8ad36c8d4
Store hosts for a play as a play attribute
...
Operate on that play attribute to make things faster for larger
inventories. Instead of making a round trip through inventory.list_hosts
and working through some lengthy list comprehensions over and over
again, calculate the potenital hosts for a play once, then reduce from
it the unavailable hosts when necessary.
Also moves how the %fail is done. The host count is a play level count
of available hosts, which then is compared after each task to the
current number of available hosts for the play. This used to get a new
count every task which was also time expensive.
12 years ago
James Tanner
94f3b9bfab
Fixes #3129 Do not require localhost to be in inventory
12 years ago
James Tanner
c17d0e0357
Revert "Merge pull request #5325 from angstwad/add-su-support"
...
This reverts commit 6f4bfa2cff , reversing
changes made to c91ba3a7c7 .
12 years ago
Paul Durivage
8cf071f697
Hostvars support for su
12 years ago
Paul Durivage
dec9131735
Ensure playbook support for su params
12 years ago
Paul Durivage
d21281ff43
Resolve rebase conflicts
12 years ago
Paul Durivage
ab6ee1a282
Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins
12 years ago
Paul Durivage
4088243deb
Proposing fix for Issue #4324 ; adding support for su in connection plugins ssh, ssh_alt
...
Fixes for ssh_alt support, adding in references to in_data where appropriate
12 years ago
Michael Scherer
5c5c8fd7ce
Make synchronize module work better with local transport, fix #5668
12 years ago
Rutger Spiertz
dec6345fe6
PlayBook: better error message
...
When a PlayBook has missing arguments the error message now shows which ones are missing.
12 years ago
James Tanner
559e89036b
Fixes #5631 Return a unique list of hosts when joining groups
12 years ago
James Cammarata
02ce5af6df
Added ANSIBLE_SSH_PIPELINING option to enable/disable pipelining support
...
Pipelining will be disabled by default, since it requires users remove
the 'requiretty' option from the servers sudoers configuration.
12 years ago
James Cammarata
233aae5861
Reverting paramiko_ssh/alt changes from yesterday
12 years ago
Matt Martz
d46037d64c
Do not log the rax api_key argument in module invocation
12 years ago
James Cammarata
36e6709771
Don't use pipelining when ANSIBLE_KEEP_REMOTE_FILES is enabled
12 years ago
James Cammarata
df13b19fe1
Moving {ssh,paramiko}_alt connection types to be the defaults
...
The previous implementations will be kept for now as _old
12 years ago
James Cammarata
c27db84e41
Adding paramiko_alt - pipelining support for paramiko connections
12 years ago
jctanner
91c5c9da08
Merge pull request #5465 from deonbredenhann/false_mandatory_variable
...
Treat a False mandatory variable as defined.
12 years ago
jctanner
59d99c17b3
Merge pull request #5337 from bob-smith/bugfixFQDNParsing
...
Fix inventory parsing so that FQDN can be parsed without throwing ssh port error
12 years ago
jctanner
a6bc63512e
Merge pull request #5308 from zecrazytux/fix/hash_merge_dynamic_inventory
...
Let merge hash_bahaviour work with dynamic inventory
12 years ago
jctanner
671b0454c6
Merge pull request #4987 from jpmens/lookup-csvfile
...
New lookup plugin csvreader
12 years ago
willthames
31f5ecea60
Allow float as an argument type in AnsibleModule
12 years ago
Rob Smith
c15cffabdd
This fixes bugs added as a part of 8665b0638a
...
1. if accept_hostkey is false, no matter if the host key is known or not, it will fail.
2. We don't check for the host key in /etc/ssh/ssh_known_hosts
This fixes both of those issues.
12 years ago
James Tanner
3719f3f496
Do not fetch or add keys for http based git urls
12 years ago
James Tanner
eeee1e1c5a
Set accept_hostkey to False by default in the git module and fail
...
early if the key is unknown
12 years ago
James Tanner
8665b0638a
Add an "accept_hostkey" parameter to the git module to help automatically
...
accept hostkeys for git repos and prevent task hangs when the key is unknown
12 years ago
James Tanner
09e0d052ca
Ensure sys.stdout has an istty method
12 years ago
James Tanner
d7c8cf6ca7
Fixes #4958 Truncate printed stdout if it contains non-printable characters
12 years ago
jay
e1f5b801cf
fixed bug causing symlinks to fail in the host_vars, group_vars etc directories
12 years ago
James Tanner
78ec7c736f
Fixes #3973 Second Revision of live ansible-pull output
12 years ago
Luca Berruti
ae543eecab
Simplified p.poll handling
12 years ago
James Tanner
c408bcea31
Update sshpass hostkey error message
12 years ago
James Tanner
0b64408f5a
Fixes #5531 Give the user a better error message when sshpass does not know the remote hostkey
12 years ago
Matt Martz
f99500d65c
Expose the playbook to callback plugins
12 years ago
jeromew
69febcefde
remove useless create/delete remote tmp dir roundtrip in copy module
12 years ago
Serge van Ginderachter
836fb4143c
path_dwim: fix when basedir not set
12 years ago
jeromew
c9b01febb3
Make sure 'tmp' is in the remote tmp dirname to ensure correct cleanup
12 years ago
jctanner
21b4212ff5
Merge pull request #5517 from lichesser/fix_set_depreciation_warning
...
Fixes #5513 . set is built-in since 2.4 and deprecated since 2.6
12 years ago
jctanner
83dec044ab
Merge pull request #5504 from smoothify/synchronize-sudo
...
Synchronize Module: Improved sudo override behaviour.
12 years ago
jctanner
9a69b1b0ec
Merge pull request #5311 from willthames/ec2_refactor
...
ec2 modules: Move more responsibility to common EC2 module
12 years ago
James Tanner
d6b78e9dd6
Fixes #5238 Improve error messaging about unquoted variable references in playbooks
12 years ago
James Tanner
ab51bd23a2
Fixes #5196 return a unique list of hostnames for a single host pattern
12 years ago
smoothify
93a55e8dff
Don't override sudo if transport is set to local.
...
https://github.com/ansible/ansible/pull/5251
12 years ago
Michael DeHaan
c039e276a2
Fact gathering on a second play against the same hosts should not be implicitly off since this is an undocumented beheavior and potentially
...
rather unwanted when a play could change a fact.
gather_facts: True/False can still be explicitly used per play.
Reverts 564a212b3c
12 years ago
Michael DeHaan
87258f6d42
Resolve merge commit
12 years ago
Michael DeHaan
1c632af2c9
Merge pull request #5468 from jeromew/ansible_ssh_alt
...
fix issue #5372 on ssh_alt: accept -K option for a user with NOPASSWD
12 years ago
Michael DeHaan
a3d90e8a87
Merge pull request #5498 from j2sol/exit_setup_early
...
Return early from setup step when possible
12 years ago
Michael DeHaan
227e8e31c9
Merge branch 'use_comps' of git://github.com/j2sol/ansible into devel
12 years ago
Michael DeHaan
10350d1639
Update various copyrights. Not complete, but sufficient.
12 years ago
Jesse Keating
23720ff19d
Use list comprehensions for efficiency
...
For loops can be inefficient, particularly when doing a dot command with
them. https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops and
https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Avoiding_dots ...
This patch makes use of list comprehensions to be as efficient as
possible while still retaining order. Efficiency was lost a bit when
switching away from sets() but this gains some of it back.
12 years ago
Jesse Keating
35328ed503
Return early from setup step when possible
...
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
12 years ago
Michael DeHaan
c41a23a35a
Complete removal/refactoring of conditional deprecations.
12 years ago
Michael DeHaan
8e5b7d3095
Remove code underlying when_* and only_if, which are deprecated features slated for removal in the 1.5 release.
12 years ago
Michael DeHaan
28b9fd4e30
We have had only_if, when_foo, etc, deprecated for a while and said they would be removed in 1.5. Now they are, with friendly error messages still.
...
Users of these features should use "when:" as documented at docs.ansible.com.
Similarly, include + with_items has been removed. The solution is to loop
inside the task files, see with_nested / with_together, etc.
12 years ago
James Tanner
21fdb2bbc7
Fixes #5200 Handle template contents with unicode strings better
12 years ago
James Tanner
fc473b3246
Fixes #5146 Handle missing stdin when running under celery with rabbitmq or redis
12 years ago
Michael DeHaan
de2ffc1276
Don't need to document these guys.
12 years ago
James Tanner
cb2214d6f8
Fixes #4935 Synchronize module: set destination to an fqdn if connection is not local, and abide by ansible_remote_user
12 years ago
jctanner
99560e3902
Merge pull request #5047 from sergevanginderachter/synch_template_ansiblesshhost
...
synchronize: allow ansible_ssh_host to be templated
12 years ago
jeromew
b2cd4a62de
fix issue #5372 on ssh_alt: accept -K option even for a user with NOPASSWD
12 years ago
Deon Bredenhann
c85aac8b17
Treat a False mandatory variable as defined.
12 years ago
Deon Bredenhann
4f1f13b100
Remove trailing space
12 years ago
Levi Gross
dc6a26123b
Fixed syntax error and removed unused imports
12 years ago
Michael DeHaan
643690ffec
Remove depedency of lookup plugin on setting in ansible.cfg
12 years ago
Michael DeHaan
5b3c796641
Update constants.py
...
Lookup plugins for optional web services do not warrant advertising in ansible.cfg.
12 years ago
Stephen Fromm
833e1f6e2a
Make sure action plugin copy cleans up tmp dir
...
The copy action plugin creates its own tmp dir for each file that it
copies to the target machine. However, it does not clean up the
original tmp path it was given when run() is called. This cleans up the
tmp path before it begins looping on source files.
12 years ago
dparalen
6bf5d664dc
allow per-host sudo operation
12 years ago
James Tanner
993e0f057e
Allow for no role dependencies in role metadata
12 years ago
James Tanner
1ef9930b80
Addresses #5341 Expand home directories when searching for roles in ansible-playbook
12 years ago
James Tanner
5d022182fe
Fixes #5341 Use constants.py to set the roles directory
12 years ago
John Barker
4bf9f714d0
Fix inventory parsing so that FQDN can be parsed without throwing ssh
...
port parsing errors
Fixes problesm introduced by 948d019fef
Adds testcases to defend
12 years ago
jctanner
ea8cd62b19
Merge pull request #5259 from mvo5/bugfix/improve-error-on-invalid-vars-file
...
improve error on invalid vars file (if its a list instead of a dict)
12 years ago
jeromew
e4a3f49fa2
ssh_alt - only trigger 'fatal' when returncode == 255 (interpreted as 'could no connect')
12 years ago
willthames
12005a1cd0
Move more responsibility to common EC2 module
...
Moved `AWS_REGIONS` into `ec2` module
Created `ec2_connect` method in `ec2` module
Updated modules able to use `ec2_connect` and `AWS_REGIONS`
12 years ago
jctanner
cd3144af5d
Merge pull request #5178 from cavassin/devel
...
Prevents UnicodeEncodeError
12 years ago
James Tanner
f3a4705a9c
Revert "Merge pull request #4874 from leth/editable_install"
...
This reverts commit 15b89b45e1 , reversing
changes made to 3d836a1ab7 .
12 years ago
jctanner
15b89b45e1
Merge pull request #4874 from leth/editable_install
...
Fix setup.py to work with 'pip install -e .'
12 years ago
Sébastien Bocahu
c8d5846ab9
Let merge hash_bahaviour work with dynamic inventory
12 years ago
jctanner
3d836a1ab7
Merge pull request #5247 from jeromew/ansible_ssh_alt
...
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jeromew
5c965a75f0
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jctanner
1679d83637
Merge pull request #5131 from janeznemanic/devel
...
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
12 years ago
jctanner
301a1189dd
Merge pull request #5122 from willthames/openlog_str
...
Make first argument to syslog.openlog be a string
12 years ago
Ferenc Grecu
56642f9b04
Remove unused parameter from _get_config
12 years ago
Michael Vogt
bef5ee2c3b
improve error on invalid vars file (if its a list instead of a dict)
12 years ago
Jesse Keating
8cef210aea
Make sure ssh pipes are empty before moving on
...
Resolves issue #5082
Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.
The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.
Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
12 years ago
Michael DeHaan
929f8a5c93
Had to revert commits due to async.
12 years ago
Michael DeHaan
74e4ccb59b
Revert "ssh_alt.py / decrease # of ssh roundtrips"
...
This reverts commit 7f8863f96d .
12 years ago
jeromew
7f8863f96d
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jeromew
db182ba498
copy ssh.py to ssh_alt.py
12 years ago
Paulo Bittencourt
fc3597af5d
files/file: add support for symbolic permission modes
12 years ago
Steve Smith
5b81f88c8f
Cast the retrieved `retries` var to an int before incrementing as it may be in string form.
...
For example, the following method of calculating the value will result in a type error:
appstatus_waitfor: 4 # Minutes
appstatus_delay: 5 # seconds
appstatus_retries: "{{ mins * 60 / delay }}"
12 years ago
Wanderlei Antonio Cavassin
6ba93817a9
Avoid UnicodeDecodeError exception when passing module args
12 years ago
James Tanner
bf78d8cf73
Addresses #5090 setup module was using path.is_file instead of path.isfile
12 years ago
cavassin
10f5af82f9
Prevent UnicodeEncodeError
...
Prevents UnicodeEncodeError: 'ascii' codec can't encode character, while printing shell commands output
12 years ago
jctanner
7aa35d64c2
Merge pull request #5091 from EspadaV8/5089_assemble_fix
...
#5089 hack-fix assemble module
12 years ago
Paul Bonser
58acd8cce1
If there is no tmp_src, don't modify the args
12 years ago
Paul Bonser
4afcd50487
properly convert arg into boolean
12 years ago
Michael DeHaan
801ca96a8b
Merge pull request #5152 from sivel/too-many-ps
...
The word skipped only has 2 p's not 3
12 years ago
Matt Martz
5f0f3566a6
Skipped only has 2 p's not 3
12 years ago
Matt Martz
8873c3675b
Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148
12 years ago
jctanner
2670529671
Merge pull request #5090 from dragon3/hostname_support_amazon_linux
...
hostname module: add support for Amazon Linux
12 years ago
James Tanner
d227614529
Fixes #5109 synchronize module ssh port
...
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
12 years ago
Paul Bonser
5626efba7e
Optionally unarchive a file already on the remote machine
12 years ago
jctanner
93159cb9cd
Merge pull request #4996 from sivel/rax-module-utils
...
Implement ansible.module_utils.rax
12 years ago
Janez Nemanic
8752ae6909
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
12 years ago
Will Thames
76aca4d547
Make first argument to syslog.openlog be a string
...
syslog.openlog expects its first argument to be a string.
Without this change running under ipython fails.
12 years ago
James Cammarata
9101c2af98
Fix traceback in template error detection code
...
Fixes #5081
12 years ago
Andrew Smith
eed32ea70c
dest_contents isn’t always defined, so don’t pass it around
...
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
12 years ago
Andrew Smith
e2d03173d2
The file module doesn’t have it’s module_args reset
...
I believe that this should be reset in the same way that the copy module
does
12 years ago
Andrew Smith
7b01c83159
Passing in complex_args throws ‘unsupported parameter for module’ errors
...
When using assemble only params (e.g. remote_src) the copy (and I’m
guessing file) modules throw an error that the param isn’t supported.
Simply removing the complex_args param fixes it for me, but I’m not sure
that’s the correct thing to do
12 years ago
Andrew Smith
da44a7f0cb
I think that resultant is meant to be the contents of the combined file
...
It is used for the transfer and as a diff param but isn’t actually
defined anywhere before it’s used. This seemed like the least bad place
to set it.
12 years ago
Andrew Smith
4503413baa
ReturnData is used throughout but not actually imported
12 years ago
dragon3
d39e6fda92
hostname module: add support for Amazon Linux
12 years ago
Andrew Smith
7d007cac16
Correct the invocation of ‘_assemble_from_fragments’
12 years ago
jctanner
920bc6e75b
Merge pull request #5086 from j2sol/fix-accelerate_inventory
...
Avoid a traceback when using accelerate
12 years ago
James Tanner
b6879ca2bd
Fixes #5030 compare connection user and sudo user and disable sudo if identical
12 years ago
Jesse Keating
5522d489e3
Avoid a traceback when using accelerate
...
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
12 years ago
James Tanner
12ed39ef7b
Fixes #5056 Append new hosts to the groups cache
12 years ago
James Cammarata
1f80aa768a
Fix bug in error detection code, where a zero-length string was causing a traceback
...
Fixes #5064
12 years ago
Brian Coca
65885feeeb
fixed typo for assemble function
12 years ago
James Tanner
b8146e3bc7
Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin
12 years ago
James Tanner
903c4cae7b
Fixes #5031 Template the delay value and cast to float for loops
12 years ago
Serge van Ginderachter
2f9470ec1d
synchronize: allow ansible_ssh_host to be templated
...
This is already enabled in the runner also.
12 years ago
Antonio Zanardo
8dbd91b5ad
fix typo in deprecation warning
12 years ago
James Tanner
bca2634d54
Fix missing eval for string search in ssh controlpersist
12 years ago
James Tanner
a16fe923ed
Addresses #5011 check for proper string in smartos ssh error output
12 years ago
jctanner
5c84d7e445
Merge pull request #5002 from ovcharenko/devel
...
Allow to specify ansible_ssh_private_key_file location related to user home directory
12 years ago
James Tanner
512ebdb971
Revert "Merge pull request #5001 from ovcharenko/devel"
...
This reverts commit d6c3103a00 , reversing
changes made to b11f96eaa4 .
12 years ago
Aleksey Ovcharenko
9af44b1b42
Update to 4 space indent
12 years ago
Aleksey Ovcharenko
30678e04ac
Make tests happy
12 years ago
Aleksey Ovcharenko
2222f6df58
Allow to specify ansible_ssh_private_key_file location related to user home directory
12 years ago
Matt Martz
3f2cbb7583
Add ansible.module_utils.rax
12 years ago
James Tanner
9b991b9154
Version bump for 1.5
12 years ago
Jan-Piet Mens
252a51be91
New lookup plugin csvreader
12 years ago
James Tanner
b815a09529
Fix pep8 error in password lookup
12 years ago
James Tanner
e81c976636
Fix pep8 errors in unarchive module
12 years ago
jctanner
68afd9da9f
Merge pull request #4866 from sergevanginderachter/known_hosts_sudo
...
Check real user's known_hosts when sudo ansible...
12 years ago
Brian Coca
34c33f7ea1
now correctly spell symmetric
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca
460bbfaec1
added union filter
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca
afe30a6633
added difference and symetric difference filters
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan
fc909b453f
Make the legacy template detection system not hit a false positive when
...
replacing a \$ with $.
12 years ago
jctanner
93223510af
Merge pull request #4936 from stoned/group-get_hosts-perf2
...
Improve Group.get_hosts() performance.
12 years ago
Matt Haggard
389602b8dd
Merge pull request #4920 from iffy/ansible
...
Collect all stdout over ssh transport before returning data
12 years ago
Michael DeHaan
f18acee779
Merge pull request #4937 from skyl/synchronize-keyerror
...
KeyError: 'delegate_to' lookup in sync module needs to be checked to see if defined for ad hoc
12 years ago
James Tanner
e8b54dd073
Fixes #4852 properly evaluate log_path writability
12 years ago
Skylar Saveland
7bc64581d7
KeyError: 'delegate_to' no more
12 years ago
Stoned Elipot
b00bf02129
Improve Group.get_hosts() performance.
...
- reduce hosts group list to unique elements faster
- add a cache of already computed hosts group list
12 years ago
jctanner
009fdbf96a
Merge pull request #4896 from mjschultz/aws-access-keys
...
Check for AWS keys using boto names
12 years ago
jctanner
04847191b4
Merge pull request #4879 from bcoca/unique_intersect
...
added unique and intersect filters for dealing with lists
12 years ago
jctanner
0f0a89b34e
Merge pull request #4758 from alanfairless/group-host-var-dirs
...
Support organizing group and host variables across multiple files in a directory
12 years ago
jctanner
77affdefbc
Merge pull request #4585 from mscherer/connec_func
...
connection plugin to reuse the func/certmaster interface instead of ssh
12 years ago
jctanner
be67a6f815
Merge pull request #4625 from pileofrogs/devel
...
unarchive module & action plugin
12 years ago
jctanner
e4494be8c6
Merge pull request #4803 from dragon3/devel
...
Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM rol...
12 years ago
Michael J. Schultz
5f9485499c
Check for AWS keys using boto names
...
- see https://github.com/boto/boto#getting-started-with-boto
12 years ago
James Tanner
33242cacf3
Merge pull request #4375 from pfalcon/ansible
...
copy: Implement recursive copying if src is a directory.
12 years ago
jctanner
9a7765daf7
Merge pull request #4351 from 2m/leading-range-fix
...
Allow leading ranges in the inventory host entries.
12 years ago
jctanner
6dd81f25d9
Merge pull request #4856 from akuznecov/devel
...
Resolves #4855 issue with synchronize module failing on multiple items
12 years ago
James Tanner
f31cb7c6e8
Merge pull request #4664 from jpmens/ansible
...
Lookup plugin for etcd
with support for configurable etcd URL in ansible.cfg (and environment)
12 years ago
James Tanner
dc41bb8085
Merge pull request #4207 from ashorin/ansible
...
Fail playbook when serial is set and hadlers fail on set.
12 years ago
jctanner
2cf335969f
Merge pull request #4738 from bcoca/assemble_action_plugin
...
assemble can now use src from master/origin
12 years ago
Brian Coca
efd87534eb
added unique and intersect filters for dealing with lists
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
James Tanner
6e49ee6cfc
Remove commented code block
12 years ago
James Tanner
288c33e286
Merge pull request #4078 from mkaluza/ansible
...
add 'chars' parameter to password plugin to allow custom character set
12 years ago
jctanner
0c29807ba3
Merge pull request #3993 from stoned/inventory-script-all-group-fix
...
Avoid duplicates of the 'all' group when using inventory script.
12 years ago
Marcus Cobden
8d98a55df1
Fix setup.py to work with 'pip install -e .'
12 years ago
Serge van Ginderachter
80fd22dce6
Check real user's known_hosts when sudo ansible...
...
closes #4834
12 years ago
James Tanner
74e7eba528
Fixes #4506 test length of context before checking invalid indexes
12 years ago
Alexander Kuznecov
9d2f9bf93c
resolves #4855
12 years ago
jctanner
8e8c8efc8f
Merge pull request #4769 from alanfairless/more-password-entropy-revised
...
Revised patch for more password entropy
12 years ago
jctanner
f51b8ffde9
Merge pull request #4836 from dekked/devel
...
Bug fix: support running handlers parametrized by name
12 years ago
James Tanner
898de833b0
Merge pull request #4413 from jerm/ansible
...
Add capability to pass in a PATH prefix to run_command and allow pip module
to utilize that to make virtualenv bin/ available in pip installs
12 years ago
Alan Descoins
bb6f02d0e8
Support running handler parametrized by name.
12 years ago
jctanner
8d9b53b445
Merge pull request #4733 from sivel/4323-sudo-pass
...
Add ansible_sudo_pass hostvar support. Fixes #4323
12 years ago
James Tanner
d93780bc8a
Addresses #4635 add list instead of join
12 years ago
James Tanner
2b5005687a
Fixes #4635 pass role conditionals to dependent roles
12 years ago
James Tanner
91aa7b51df
Remove invalid ipv6 parameter from setup execution
12 years ago
James Tanner
c1ed47933b
Fixes #4485 add an ipv6 parameter to accelerate so that the daemon will bind to an ipv6 port instead of ipv4
12 years ago
dragon3
ff5bd7fe06
Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM role.
12 years ago
willthames
76c810afe3
AWS_ACCESS_KEY misspelt in shared EC2 connection library
12 years ago
Michael DeHaan
eab6737209
Clarify a warning message.
12 years ago
Michael DeHaan
70c9028e1e
include_vars plugin should look in vars/ path for a role.
12 years ago
Michael DeHaan
99687749a3
Merge pull request #4775 from steverweber/fix-4640
...
dont sudo if sudo_user is the same as the connection user
12 years ago
Steve Weber
5bd52796ec
dont sudo if sudo_user is the same as the active user
12 years ago
James Tanner
afa5988391
Fixes #4540 Use shared module snippet to evaluate ec2 credentials
12 years ago
Alan Fairless
0824f004d9
Revised patch for more password entropy
12 years ago
James Tanner
dc4d589ce0
Fixes #4767 detect hard links and set state in add_file_info
12 years ago
Michael DeHaan
b1b5280075
Reapply pep8 changes from previous revert.
12 years ago
Michael DeHaan
51fbc6d20a
Further simplify the debug: var=foo action plugin code.
12 years ago
Michael DeHaan
bbf212a268
Simplify the way the debug: var=varname plugin works.
12 years ago
Michael DeHaan
7f125567cb
Some simplification of include_vars and renamed include_files to include_vars.
12 years ago
Michael DeHaan
b69ab89eb1
Merge branch 'include_files' of git://github.com/bennojoy/ansible into devel
12 years ago
Michael DeHaan
465f3b1c91
This allows type=dict in a module to allow passing in a real dict or JSON.
12 years ago
Michael DeHaan
8b2cd6413b
When inside an apt or yum task account for multiple conditionals. Fixes 4745.
12 years ago
Michael DeHaan
d34a26e307
Undo an inadvertant revert from template changes so we still allow pythonic imports in module land.
12 years ago
Alan Fairless
65e5331079
Allow organizing host/group vars in a directory
...
So instead of having:
group_vars/production.yml
A user could chose to reorganize to:
group_vars/production/staff.yml
group_vars/production/networks.yml
group_vars/production/dns.yml
(Backwards compatible.)
12 years ago
Alan Fairless
babde9a84c
refactor to catch edge cases, remove repeated code
...
- Move all the supported YAML file extensions into a constant
- Use helper functions to avoid duplicate code for group/host vars
- Catch and disallow some confusing situations, such as the presence of
multiple group/host vars files for the same group/host, but with
different extensions. For example having both group_vars/all.yml and
group_vars/all.yaml.
- Catch and report file system permission issues, symlink errors,
unexpected file system objects
- Trivial performance improvement from making fewer stat system calls
- Restructuring that makes it easy for a following patch to support
directory recursion
12 years ago
Brian Coca
ac40d15120
now assemble module is also action plugin and can use local source for
...
files
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan
7b331ef6ed
Fix code typo. I'll blame jet lag for now :)
12 years ago
Michael DeHaan
90cce35919
This allows variable references in playbooks in a different way.
12 years ago
Michael DeHaan
b5c9d5a59b
Inventory directory should always be absolute. Fixes #4535 .
12 years ago
Michael DeHaan
7201a6ffad
Evaluate the conditional for each item for modules that normally try to group with_items results
...
like yum and apt.
12 years ago
James Tanner
078aaa95a2
Revert 1f6edf7d76 and re-enable passing lists to yum and apt
12 years ago
Matt Martz
ea2ec6237a
Add ansible_sudo_pass hostvar support
12 years ago
James Tanner
d154bf8781
Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754
12 years ago
James Tanner
0faecdf7d1
Fixes #4653 Set dest on results for copy module even if using file module
12 years ago
James Tanner
9249cf578d
Fixes #4572 Run until loop if until is set, ignoring result failures
12 years ago
Michael DeHaan
73dbab702f
Don't run lookup plugins while trying to simplify the input datastructure.
12 years ago
Michael DeHaan
6d0da41a55
No need to template modules with Jinja2 as this can confuse some docstring comments.
12 years ago
bennojoy
b53e7353f9
include files
12 years ago
Michael DeHaan
603db60828
Merge pull request #4288 from sivel/3725-regex
...
Add regex (search, match, regex) jinja2 filters. Fixes #3725
12 years ago
Michael DeHaan
4587528b99
Fix typo in comment.
12 years ago
Michael DeHaan
d409352c85
Remove some interior imports in the code. Not really needed but nice to have them gone.
12 years ago
Michael DeHaan
e6c28658b4
Add in some code to pre-template datastructures prior to template usage. This prevents a certain class of error
...
where filter evaluations can happen too early due to the template engine recursion being a bit limited.
Addresses #4662
12 years ago
Michael DeHaan
f05a3a81f9
Add missing file.
12 years ago
Michael DeHaan
54c902f102
Identation + misc PEP8 fixes.
12 years ago
Michael DeHaan
bbb359870e
Add package file.
12 years ago
Michael DeHaan
9858b1f2f3
Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
...
to be reused between modules. See library/system/service and library/system/ping for initial examples. Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
12 years ago
jctanner
43f48a2e02
Merge pull request #4167 from tima/rsync3
...
synchronization module take 3
12 years ago
James Tanner
40886c42b5
Fixes #4561 Compare task name without role prefix for start-at-task
12 years ago
James Tanner
1f6edf7d76
Fixes #4665 and #4666 If task is conditional do not flatten items list for packaging modules
12 years ago
James Tanner
9b1fe455c6
Fixes #4549 Do not call lookup plugins when templating a task's name
12 years ago
Serge van Ginderachter
6277e770a1
include basedir as 'playbook_dir' variable
...
closes #4246
12 years ago
Jan-Piet Mens
bd5cd8e652
Lookup plugin for etcd
...
with support for configurable etcd URL in ansible.cfg (and environment)
12 years ago
James Tanner
b803aac6ec
Fixes #4500 change ec2 module params to type=bool
...
Revert 4833c2fdf0
12 years ago
James Cammarata
b9dd514713
Minor fix for putting 0-length files over accelerated connections
...
Fixes #4652
12 years ago
James Tanner
4833c2fdf0
Fixes #4500 python bools return uppercase True and False, so allow those for BOOLEANS in module common
12 years ago
James Tanner
214b0b052c
Fixes #4608 add lookup to template globals to make plugins work again
12 years ago
Dylan Martin
2c28e1daea
unarchive module & action_plugin added
12 years ago
James Tanner
4f13967386
Fixes #4536 Get the remote_user from multiple sources in a preferred order
12 years ago
Timothy Appnel
cbae9c913e
synchronize module src and dest handles template markers.
12 years ago
Michael DeHaan
60944b81f0
Provide warning about "with_items: '{{ loop }}'" being redundant only when {{ starts the expression value. Fixes #4582 .
12 years ago
Michael DeHaan
2bd8cb5790
Make the deprecation detector in templates more accurate. Fixes #4514 .
12 years ago
Michael DeHaan
4125b05bf3
Allow a defaults file to solely define a role. Some typo fixes.
12 years ago
Michael DeHaan
64bbeb9d24
Suggest fixing unbalanced quotes in a bit less cases. Fixes #4501
12 years ago
Michael DeHaan
7f9504d14d
Fix a typo.
12 years ago
Michael DeHaan
8d3db80370
Some misc cleanup and removal of unused imports.
12 years ago
Michael DeHaan
21d4400c96
Misc pep8 fixes
12 years ago
Michael DeHaan
c933a4c59a
Fix indentation depth.
12 years ago
Michael DeHaan
5031104c3a
Finishing touches on template cleanup.
12 years ago
Michael DeHaan
1e85c7544b
Further WIP on template cleanup.
12 years ago
Michael DeHaan
35cb9dc22f
Work in progress about cleaning up template code.
12 years ago
Michael Scherer
af796d6556
connection plugin to reuse the func/certmaster interface instead of ssh
...
This plugin permit to use func to run playbook and ansible command instead
of ssh. It can be used for a smooth transition from func/taboot to ansible by
letting people use ansible without having to change their network architecture.
12 years ago
Brian Coca
c476ed93ca
now correctly changes script permission in all cases
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
James Tanner
8478e82647
Fixes #4583 enforce that vars_files is a list
12 years ago
Michael DeHaan
b0f6e77f66
Merge pull request #4571 from tgerla/whitespace
...
add_group module: strip trailing/leading whitespace from comma-separated group names
12 years ago
Tim Gerla
51a1709253
add_group module: strip trailing/leading whitespace from comma-separated group names
12 years ago
James Tanner
242f20c297
Fixes #4402 wrong order for isinstance parameters in dnstxt.py
12 years ago
Martynas Mickevicius
7ecb5fbc9c
Handle comment on inventory group line.
12 years ago
Martynas Mickevicius
44279ce34f
Allow leading ranges in the inventory host entries.
12 years ago
jctanner
6480945184
Merge pull request #4541 from Kami/improve_template_render_error_messages
...
Make errors which get thrown during template rendering more user-friendly
12 years ago
Stoned Elipot
4430d0f5a6
when searching for a plugin only look for a regular file
12 years ago
Tomaz Muraus
922f61899e
Throw a more user-friendly exception during template rendering process.
12 years ago
Gabe Mulley
84a57b7545
ensure non-root users can read arguments file when using sudo_user
...
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600. This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.
This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
12 years ago
Brian Coca
bd9acedb57
fixed name colision between warnings dict and module
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Paul Sokolovsky
2e668f14f7
copy: Handle "no copy/propagate attrs only" for recursive mode well.
...
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
12 years ago
Paul Sokolovsky
ce88df3cf4
copy: Handle dest path variations for recursive mode.
12 years ago
Paul Sokolovsky
6cf3975e2e
copy: Set suitable default result for check mode.
12 years ago
Paul Sokolovsky
612b446856
copy: Don't modify input module_args in a recursive file handling loop.
12 years ago
Paul Sokolovsky
b3b4f9885f
copy: Implement recursive copying if src is a directory.
...
If src param to copy is a directory, all files under it are collected
and pushed one by one to target. Source dir path handled in a way
simalar to rsync: if it ends with slash, only inside contents of
directory are copied to destination, otherwise the dir itself is
copied (with all contents of course). Original idea and implementation
by https://github.com/ansible/ansible/pull/1809 . Rewritten to address
review comments and simplify/correct logic.
12 years ago
jctanner
69fa5954fd
Merge pull request #3932 from jocelynj/devel
...
Add option remote_user to task level, to specify the ssh login user
12 years ago
Michael DeHaan
e131de4de0
Added "debug: var=variableName" capability.
12 years ago
egghead
ca7e2d283c
Adding os realpath filter.
...
This is particularly useful when wanting to get the absolute path of filepaths found by the 'fileglob' filter.
This also lets you provide absolute paths to roles, which search for files in different areas unless absolutely pathed.
12 years ago
Michael DeHaan
c90a82fd52
Handle possible scenario where conditional might be an integer (whoa!) down the error path. Super rare but fixes #4483 .
12 years ago
Michael DeHaan
9ea54fcaaf
Fixes a dev branch glitch where a conditional could be applied to multiple tasks. Also improves the errors on parsing bad conditionals to make them less confusing to users.
12 years ago
Thomas Omans
632232259a
Adding config flag role_path for common/global roles
...
Using ANSIBLE_ROLE_PATH environment variable or role_path in ansible.cfg
can configure paths where roles will be searched for
extra paths will only be used as a backup once regular locations are exhausted
12 years ago
Michael DeHaan
43df00550d
Merge pull request #3827 from mscherer/disable_callbacks
...
add a way for callback to disable itself
12 years ago
Michael DeHaan
1b2d4c328c
Cache patterns a bit higher up to make things a little more efficient. See #4469 .
12 years ago
Michael DeHaan
d168c709d5
Fix an issue where the ordering of an include statement is processed ahead of the conditional in the included statement,
...
which required a redundant check to see if a variable was defined rather than short circuiting.
Fixes #4469
12 years ago
Michael DeHaan
add45d2ca9
Fixup legacy var detector.
12 years ago
Michael DeHaan
709ffda3d1
Tweak only_if deprecation detector.
12 years ago
Michael DeHaan
a45494a896
Add warnings feature.
12 years ago
Michael DeHaan
9637f620d7
Deprecation warnings of several flavors, nice and purple and can be disabled
...
in ansible.cfg.
12 years ago
Michael DeHaan
a017a69bb3
Have the parser explain another type of YAML gotcha to reduce the need for users to ask how to resolve it.
12 years ago
Michael DeHaan
861f076df5
Tweak the syntax-detector-warning-suggester-message (SDWSM) a little.
12 years ago
Michael DeHaan
41aaad69aa
Make add_host clear the inventory pattern cache, add some more aliases. Fixes #4442 .
12 years ago
jctanner
65ef6a62dc
Merge pull request #4425 from jeromew/ansible_sudo_user_with_items
...
Template sudo_user via with_items
12 years ago
James Cammarata
d73a5da9e5
Merge pull request #4453 from pschwartz/fix_cfg_load_order_to_match_docs
...
GH-4452 Corrected config load order to match docs
12 years ago
Philip Schwartz
65c8c691f7
GH-4452 Corrected config load order to match docs with
...
cwd > ~ > /etc
Signed-off-by: Philip Schwartz <philip.schwartz@rackspace.com>
12 years ago
Matt Martz
61525a97df
Add regex (search, match, regex) jinja2 filters. Fixes #3725
12 years ago
Serge van Ginderachter
c4d20094b4
make changed filter understand results lists
12 years ago
Serge van Ginderachter
e5d45311f9
Implement a |changed filter plugin
12 years ago
Serge van Ginderachter
c2e5f783da
Add caching to pattern enumeration
...
Inventory._hosts_in_unenumerated_pattern()
Was TODO: cache this logic so if called a second time the result is not
recalculated
12 years ago
jeromew
dec364ae80
Template sudo_user via with_items
12 years ago
Michael DeHaan
3f968ff46a
Check one more skipped scenario in with_subelements.
12 years ago
James Cammarata
9124ebb4f1
Clear out complex_args before running async_status
...
When using complex args with an async task, the subsequent runs of
async_status would inherit them, causing a module error (invalid params).
Fixes #3150
12 years ago
Michael DeHaan
2078518735
Allow subelements to work right with skipped results.
12 years ago
Jeremy Price
9da5043f18
Adding path_prefix to run_command so that one can pass in a path to the run environment if you nees something in a non-default path.
12 years ago
James Cammarata
948d019fef
Detect IPv6 addresses in INI inventory
...
Prevents parts of the IPv6 address from being interpreted as a port
(for example, :80).
Fixes #3888
12 years ago
Michael DeHaan
6febc97104
Add a warning about include + with_items so nobody uses it.
12 years ago
James Cammarata
98f6bc1f63
Apply tags to dependent roles correctly
...
Fixes #4339
12 years ago
Michael DeHaan
c69e19c6a6
Enhance references to logging functionality. Fixes #3431 .
12 years ago
Michael DeHaan
f081c68a65
Prevent duplicately loaded handlers from running more than once.
...
Fixes #3863
12 years ago
Michael DeHaan
5ed28efe45
Script module should return changed attribute so handlers always fire, unless "changed_when" is specified.
...
Fixes #4053
12 years ago
Michael DeHaan
a7adc8ef4d
Allow doing things like "groups.groupname" in with_nested.
...
Fixes #3858
12 years ago
Michael DeHaan
5e30cd999c
Make it possible to say:
...
tags: 42
And have the tag be a string, not an int, so --tags matches.
Fixes #4110
12 years ago
Michael DeHaan
8fc46a3a5a
Return inventory objects in the order they are presented. Additionally, fix host slicing such that it works on Python terms with
...
zero indexed lists and a non-inclusive final element.
12 years ago
Michael DeHaan
19386c43a7
Merge
12 years ago
James Cammarata
d10582225b
Merge branch 'issue_4215_fetch_expanduser' into devel
12 years ago
Andrey Shorin
35457b67f5
Pass host to runner_on_file_diff callback
12 years ago
Stoned Elipot
e7957b6d58
Fix group_by: do not group a host for which a condition is false
12 years ago
Michael DeHaan
44e391fd8b
Merge pull request #4255 from mcodd/legacy_vars_fix
...
Fix for legacy_playbook_variables (should fix issue #4254 )
12 years ago
Michael DeHaan
65178290e7
Merge branch 'devel' of git://github.com/nextus/ansible into devel
...
Conflicts:
lib/ansible/constants.py
12 years ago
Michael DeHaan
ea73151757
Add automatic advice when folks hit one of two common but minor YAML gotchas, so they can be more easily correct them on their own.
12 years ago
Michael DeHaan
4987c73bb6
Proper check for raw as module options versus raw being in the string.
12 years ago
James Tanner
52aea868df
Allow for updating host vars in add_host
12 years ago
James Cammarata
d21714a37f
Fix for network byte order issues in accelerate
12 years ago
James Cammarata
912e3a7b0b
Merge branch 'accelerate_improvements' into devel
...
Conflicts:
library/utilities/accelerate
12 years ago
James Cammarata
fa80a17aa3
Make recv_data less greedy so it doesn't eat other packets
12 years ago
James Cammarata
8923a5b0d9
Drop default config value for accelerate timeout to 30 seconds
12 years ago
James Cammarata
12f6957596
Cleaning up some vvvv log messages in accelerate
12 years ago
James Cammarata
8c17711247
Removing accelerate_timeout as a playbook option
...
This will remain in ansible.cfg only.
12 years ago
James Cammarata
d317103371
Added in an accelerate connection timeout setting
12 years ago
James Cammarata
59a5ce23d9
Adding an accelerate_timeout parameter for plays
...
This setting makes the timeout for each play configurable, rather than
hard-coding it at 300 seconds (now the default if left unspecified)
Fixes #4162
12 years ago
James Cammarata
f9c87868ac
Added keepalive packets to accelerate mode
...
Commands will now be started up in a separate task from the main
handler thread, so that it can be monitored for completeness while
sending a keepalive packet back to the controller to avoid a socket
receive timeout.
12 years ago
James Cammarata
8a3f8b757b
Make sure yaml data loaded for role is valid before using it
...
Fixes #4322
12 years ago
James Cammarata
bff47df5ff
Fix issue with ast evaluation of strings
12 years ago
James Cammarata
5b205ae8bd
Merge branch 'fixes/subprocess' of https://github.com/ferringb/ansible into ferringb-fixes/subprocess
12 years ago
James Cammarata
d89ce6ac61
Merge branch 'patch-1' of https://github.com/ustun/ansible into ustun-patch-1
12 years ago
James Cammarata
12a21d94b7
Merge branch 'allow_types_in_ini' of https://github.com/bcoca/ansible into bcoca-allow_types_in_ini
12 years ago
jctanner
32a1dd422c
Merge pull request #4269 from jphalip/issue-4256
...
In the script action: Get around a Python bug.
12 years ago
James Cammarata
7aad576f5f
Minor change to add a space around role name/task delimiter
12 years ago
James Cammarata
1cc1e7058b
Merge branch 'role_report_fix1' of https://github.com/bennojoy/ansible into bennojoy-role_report_fix1
12 years ago
James Cammarata
8ed343cc36
Merge branch 'jsmartin-hide_skipped_hosts' into devel
12 years ago
James Cammarata
6cd8aacc81
Merge branch 'hide_skipped_hosts' of https://github.com/jsmartin/ansible into jsmartin-hide_skipped_hosts
12 years ago
James Cammarata
52a42bf607
Add more verbose debugging options for accelerate
12 years ago
Michael DeHaan
ac0a7d965a
Merge pull request #4306 from sivel/3563-glob
...
Add fileglob Jinja2 filter. Fixes #3563
12 years ago
Matt Martz
535ce97067
Add fileglob Jinja2 filter. Fixes #3563
12 years ago
Brian Harring
d0ad6c581b
For defaults that are integers, enforce it for config supplied values.
...
If a user supplies a string in the config (rather than an int), the code
should fix that- or blow up immediately- rather than allowing that value to
work it's way down and break w/in the connection object; when that happens,
the actual error is opaque and requires pdb.set_trace() to run down.
12 years ago
Brian Harring
2174230315
USE subprocess.Popen API correctly.
...
When collecting stdout/stderr *and* feeding data into a Popen instance,
communicate() must be used to avoid a known deadlocking scenario
when data sizes cross PIPE_BUF (which can be as small as 512, although should
be much larger in practice on linux).
12 years ago
Ustun Ozgur
977b31249a
Update cache check in find_plugin
...
I am not familiar with the internals, but this line looked suspicious.
12 years ago
Julien Phalip
44aeea7afc
In the script action: Get around a bug in that's been fixed in Python 2.7 but not Python 2.6.
...
See: http://bugs.python.org/issue6988
Fixes #4256 .
12 years ago
James Cammarata
039d4c95d9
Merge pull request #4221 from ashorin/unicode-md5
...
Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in pos...
12 years ago
Brian Coca
771435deb4
now ini vars are typed
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
James Martin
d5f20e6b21
Optionally display Skipping [host] messages.
12 years ago
bennojoy
482cb72128
role report fix
12 years ago
Matt Coddington
7f7116de3b
commit 9db4f7a made a change that also needed to include this to retain correct legacy_playbook_variables behavior
12 years ago
Preston Marshall
3ee7b177e8
Allow storing input from user in a pause prompt
12 years ago
James Cammarata
1c97831288
Merge branch 'empty_inventory' of https://github.com/spil-jasper/ansible into spil-jasper-empty_inventory
12 years ago
James Cammarata
994dfb84fc
Minor pep8 cleanup and CHANGELOG update for do-until
12 years ago
James Cammarata
202c4f5294
Merge branch 'do_until_14' of https://github.com/bennojoy/ansible into bennojoy-do_until_14
12 years ago
James Cammarata
478c400817
Minor pep8 cleanup in the new jail connection plugin
12 years ago
James Cammarata
0e0595bdb2
Merge branch 'jail' of https://github.com/mscherer/ansible into mscherer-jail
12 years ago
bennojoy
70a9a797fa
Fix for accelerate when ansible_ssh_user is specified
12 years ago
Jasper Capel
d4dec5f577
Allow creating empty inventory
...
Instantiating the Inventory class with host_list=None now results in an
empty inventory instead of an error.
12 years ago
nextus
ca96d74572
#4227 in upstream repo
12 years ago
Andrey Shorin
fd101dd2d6
Encode to utf-8 only when needed
12 years ago
Andrey Shorin
21f5bc4242
Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in position ...: ordinal not in range(128)
12 years ago
bennojoy
0e749611ac
doc update and add attempts
12 years ago
bennojoy
21529de82e
dountil feature commit 2
12 years ago
bennojoy
53e48b63a9
dountil feature commit 1
12 years ago
James Cammarata
2f39d37a97
Expand destination path in the fetch action
...
Fixes #4215
12 years ago
Michael DeHaan
319a0f9523
Merge pull request #4154 from mplonka/AIX_MD5
...
using AIX 'csum' command for generating MD5 checksums
12 years ago
Michael DeHaan
7f8126a6c9
Merge pull request #4168 from nigelm/md5_filter
...
Added md5 as a jinja filter - returns hex digest of input
12 years ago
Andrey Shorin
cb4b964070
Allow for dynamic accelerate_port: and port: in plays
12 years ago
James Cammarata
1f674c4a50
Merge branch 'fix_selinux_debian' of https://github.com/mscherer/ansible into mscherer-fix_selinux_debian
12 years ago
Alek Storm
3569a2ffee
Handle AnsibleUndefinedVariable's raised from lookup plugins like jinja2 UndefinedError's
12 years ago
James Cammarata
47b9cc6311
Merge branch 'meta-roles' of https://github.com/eggsby/ansible into eggsby-meta-roles
...
Conflicts:
lib/ansible/playbook/play.py
12 years ago
James Cammarata
27e8675277
Make the role_name in the task its own field for use in the callback
12 years ago
James Cammarata
98cfcec5e2
Correct role name detection
12 years ago
James Cammarata
8dcf386def
Don't set the role name on handlers as this breaks notifications
12 years ago
James Cammarata
a5ee6ff1e5
Display parent role name of tasks in the name line
...
Fixes #4076
12 years ago
James Cammarata
c840cbaad9
Merge branch 'fork_fixes' of https://github.com/akerl/ansible into akerl-fork_fixes
12 years ago
James Cammarata
69cfcf7ed0
Minor change to -vvvv mode to only show debugging info for ssh conns
...
Also added this feature to the CHANGELOG
12 years ago
James Cammarata
d5b96abd80
Added support for -vvvv to enable ssh connection debugging
...
This patch also checks specifically for a return code of 255, which
indicates an unknown SSH error of some kind. When that happens, ansible
will now recommend running with -vvvv (if not enabled) or show the
output from 'ssh -vvv' (when it is enabled)
12 years ago
Nigel Metheringham
f0cc2d6efe
Added md5 as a jinja filter - returns hex digest of input
12 years ago
Timothy Appnel
d8cd3d603e
Straightened out the logic for delegate handling in synchronize action module
12 years ago
Timothy Appnel
61e726fe82
Fix to local delegate_to override and proper sudo handling from @smoothify
12 years ago
Timothy Appnel
32ae6fdd43
Return of sychronize module code for take 3
12 years ago
Thomas Omans
91a4ba2248
allowing a roles to do be made out of dependencies alone
12 years ago
James Cammarata
503f062521
Merge branch 'ferringb-fixes/configurable-ControlPath' into devel
12 years ago
Michael DeHaan
20708e31b1
Merge pull request #4133 from skyl/DIST_MODULE_PATH
...
DEFAULT_MODULE_PATH in setup.py
12 years ago
Marcin Płonka
d0c78bdc83
using AIX 'csum' command for generating MD5 checksums
12 years ago
Brian Harring
5b1b831cc7
Make ssh's ControlPath configurable via ansible.cfg
...
This shouldn't generally be needed unless you're working in an environment
that uses rediculously long FQDNs; if the name is too long, you wind up
hitting unix domain socket filepath limits enforced by ssh.
12 years ago
Stephen Fromm
27b5c2e28c
Fix how module_common handles selevel (issue #4142 )
...
Two fixes:
* parameter name is selevel, not serange.
* Fix split on selinux context to limit to max of 4 since the selevel
may contain ':' characters. This was fixed in
selinux_default_context() and selinux_context().
12 years ago
Skylar Saveland
50bd14faa9
use DEFAULT_MODULE_PATH in setup.py so that there is a chance to override with ANSIBLE_LIBRARY env variable
12 years ago
Les Aker
98bf473cb2
fixes for PTY handling
12 years ago
James Cammarata
458f71b53c
Merge branch 'issue_4129_role_defaults_empty_yaml' into devel
...
Conflicts:
lib/ansible/playbook/play.py
12 years ago
James Cammarata
091a90ee8b
Allow includes to follow the standard format
...
Previously, includes had to receive variables via a special 'vars'
field. With this patch, the include syntax becomes a more natural
datastructure without special fields and is more akin to the way
role includes/dependencies work.
Tested with the following playbook:
---
- hosts: localhost
connection: local
tasks:
- { include: inc1.yml, a: 1 }
- include: inc2.yml
b: 2
- include: inc3.yml
with_items:
- x
- y
- z
Fixes #3481
12 years ago
Skylar Saveland
8dc31f3093
ANSIBLE_DIST_MODULE_PATH environment variable
12 years ago
James Cammarata
c5bb1394b9
Check to make sure default_vars in the datastructure isn't empty
...
Fixes #4129
12 years ago
James Cammarata
5b15010099
Merge branch 'issue_3312_role_links' into devel
12 years ago
James Cammarata
3b801dec72
Merge branch 'failed_when' of https://github.com/hnakamur/ansible into hnakamur-failed_when
12 years ago
James Cammarata
fcc18fa105
Merge branch 'subelements' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-subelements
12 years ago
James Cammarata
aac3090909
Merge branch 'play_remote_user' of https://github.com/bcoca/ansible into bcoca-play_remote_user
12 years ago
James Cammarata
3848e02959
Merge branch 'issue4022' of https://github.com/sfromm/ansible into sfromm-issue4022
...
Conflicts:
lib/ansible/runner/connection_plugins/accelerate.py
12 years ago
James Cammarata
d9cf1dfefb
Merge branch 'fetch' of https://github.com/bpennypacker/ansible into bpennypacker-fetch
12 years ago
James Cammarata
f4b3defcbf
Set sudo in accelerate commands correctly
...
Fixes #4111
12 years ago
Michael DeHaan
5c0dd958e5
Merge pull request #4028 from willthames/lineinfile_userdir
...
Expand tilde in paths in file module
12 years ago
Michael Scherer
5e1828a524
add jail module, based on lxc and chroot connexion plugin
12 years ago
Michael DeHaan
1f0eb32846
Update 1.4 specfile -- no need for node fireball package, release dates
12 years ago
James Cammarata
35d138a0d6
When checking conditionals, don't dereference when the variable contains dashes
...
Fixes #4104
12 years ago
James Cammarata
d0236f6ada
Check for link in path in utils.path_dwim_relative()
...
This allows an included path to be relative to a directory, if the
basedir of the original path is a symlink. In that case, the path
is normalized and the file is searched for in the normalized path.
Fixes #3312
12 years ago
Marcin Kałuża
6786773797
filter out qoutes since they cause random errors
12 years ago
Marcin Kałuża
aab445a28f
add 'chars' parameter to password plugin to allow custom character set
...
It accepts comma separated list of names that are
either string module attributes (ascii_letters,digits, etc)
or are used literally
To enter comma use two commas ',,' somewhere - preferably at the end
Qoutes and double qoutes are not supported
12 years ago
Hiroaki Nakamura
2357194b39
Add failed_when module variable.
...
Implementation note: Ternery operator trick for python prior to 2.5 is used.
(test and [when_true_value] or [when_false_value])[0]
http://stackoverflow.com/questions/394809/ternary-conditional-operator-in-python#comment1466794_394887
12 years ago
Serge van Ginderachter
4f9af7efad
subelements lookup plugin
12 years ago
James Cammarata
75a9357e5e
Fixing role variable precedence for top-level roles
...
Fixes #4026
Fixes #3989
12 years ago
James Cammarata
294451d002
Correctly handle variable issues when evaluating jinja2 when statements
...
Fixes #4025
12 years ago
James Cammarata
bcc2a4b513
Minor fix so the any_errors_fatal value is checked properly
12 years ago
James Cammarata
4025695c00
Merge branch 'devel' of https://github.com/kavink/ansible into kavink-devel
12 years ago
Michael Scherer
dfb9d8c2fb
Add a plugin that permit to use ansible for lxc system, using libvirt
...
Using -c lxc and the domain name as hostname, this permit to manage a whole
range of container, provided they are managed and created by libvirtd.
12 years ago
Brian Coca
d47c48e30a
Added remote_user to plays
...
Still compatible with user: but deprecating it so we can have
a matching remote_user: in tasks, cannot be user: because of the
module of the same name. #3932
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Kavin Kankeshwar
c24f6f438b
Avoid ugly formatting due to a long if statement
12 years ago
James Cammarata
6e9fa5019f
Reverting HostVars change from a mapping back to a dictionary
12 years ago
James Laska
546788a1b6
The required package for selinux is libselinux-python
12 years ago
James Cammarata
4e9dee6093
Use StringIO to feed md5 calculation to prevent unicode issues
...
Fixes #4014
12 years ago
James Cammarata
2a47f72139
Merge pull request #4049 from mscherer/fix_no_kerberos
...
Fix no kerberos
12 years ago
Michael Scherer
f489702973
Also add back gssapi-keyex
...
While this is not currently implemented in openssh as far as I know,
there is patch floating around on the web and this may land one day
upstream.
12 years ago
Keiichi Mori
17c39b94a3
support GSSAPIAuth back
...
GSSAPIAuthentication has not been supported
due to PreferredAuthentications trick ( 2bdba17a85 )
12 years ago
James Cammarata
ae9e38daf8
Change hostvars to a mutable mapping to more closely resemble a dict
...
Fixes #4030
12 years ago
James Cammarata
2cbf28385a
Move check for accelerate mode deeper to account for ansible_connection
...
Fixes #4045
12 years ago
James Cammarata
20b0dc4abd
Check for an empty executable passed into the accelerate plugin
...
This was breaking at least the script module, so it would seem best
to check for it and set it to the default executable value
12 years ago
James Cammarata
4bf506f683
Always run the accelerate module as the user specified in the play
...
Currently, the accelerate daemon will be run as the sudo_user if
specified, which is incorrect.
12 years ago
Scott Sturdivant
68bffb1233
Don't force accelerate connection for local actions.
12 years ago
James Cammarata
f6e1bdabea
Ensure ports are set correctly in accelerate module
12 years ago
willthames
fe70ed94e3
Expand tilde in paths in file module
12 years ago
guersam
64db327411
Fix: raise correct error in accelerate mode
12 years ago
kavink
a075ec9831
Bug fix for a crash, when any_errors_fatal is true
...
Reported by Rumen:
TASK: [fail FAIL] *************************************************************
skipping: [hostname.com]
failed: [hostname.com] => {"failed": true}
msg: Failed as requested from task
Traceback (most recent call last):
File "/usr/local/bin/ansible-playbook", line 268, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/local/bin/ansible-playbook", line 208, in main
pb.run()
File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 262, in run
if not self._run_play(play):
File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 580, in _run_play
if (hosts_count - len(host_list)) > int((play.max_fail_pct)/100.0 * hosts_count):
TypeError: object of type 'NoneType' has no len()
12 years ago
Stephen Fromm
d704b55860
Support using paramiko to set up accelerate connection
...
Adds original_transport attribute to Runner to track what the original
transport was before it is changed to 'accelerate'.
If using paramiko in original_transport, uses ParamikoConnection. If
not, falls back to SSHConnection like before.
12 years ago
James Cammarata
fff497a1ae
Make sure the accelerated port is set to a sane value
12 years ago
James Cammarata
cc21e5c90c
Adding hostvars to injected variables in accelerate ssh runner
...
Also some minor cleanup of some fb* variables and functions, which
were remnants of the old fireball2 name
Fixes #4021
12 years ago
James Cammarata
7b13b1e03e
Minor fix to dependency dupe patch
12 years ago
James Cammarata
16258edd7a
Merge branch 'devel-duplicates2' of https://github.com/smoothify/ansible into smoothify-devel-duplicates2
12 years ago
James Cammarata
a202adcae1
Merge branch 'doublecallback' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-doublecallback
12 years ago
smoothify
5337397abd
Second Attempt: Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file.
12 years ago
James Cammarata
c0fecf87d1
Increase default socket timeout to 5 minutes
12 years ago
smoothify
0411ea2867
Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file.
12 years ago
James Cammarata
2e49d2003d
Fix bug where accelerate keyword was not checked for boolean value
...
The play was just checking for the presence of the keyword in the
YAML datastructure, and not the value of the field, so doing something
like variable substitution was always causing the play to be accelerated
12 years ago
James Cammarata
2696135b3b
Display error during launch of accelerated daemon
...
* also minor tweak to the # of retries in the connection attempt
Fixes #4012
12 years ago
James Cammarata
7c1c9b3d10
Fix message in utils related to python-keyczar and fireball/acc mode
12 years ago
James Cammarata
53c2f4c1bb
Fix race condition on creating the temp directory for ControlPersist
...
Fixes #3943
12 years ago
James Cammarata
d05c61d1f0
Merge branch 'devel' into fireball2
...
Conflicts:
lib/ansible/playbook/__init__.py
lib/ansible/playbook/play.py
12 years ago
James Cammarata
50f54f6bda
Making variable names more descriptive for the default variables work
12 years ago
James Cammarata
02b7b79d7e
Re-adding capability of tasks to see a unique view of their own defaults
12 years ago
Stoned Elipot
6cbd94dfae
Avoid duplicates of the 'all' group when using inventory script.
...
Do not recreate an 'all' group when it is in the inventory script's
output, but use the one created upfront.
12 years ago
James Cammarata
266d2008d8
Reverting the role default variables change
...
Loading the default variables in _build_role_dependencies() lead to
a side-effect where those variables were over-riding inventory variables.
12 years ago
James Cammarata
47a89a57fa
Fixing bug in playbook use of default variables in roles
12 years ago
James Cammarata
e0df5b5888
A couple more tweaks to role default variables/dependencies
...
* Default variables are now fed directly into roles, just like the
other variables, so that roles see their unique values rather
than those set at the global level.
* Role dependency duplicates are now determined by checking the params used
when specifying them as dependencies rather than just on the name of the
role. For example, the following would be included twice without having
to specify "allow_duplicates: true":
dependencies:
- { role: foo, x: 1 }
- { role: foo, x: 2 }
12 years ago
James Cammarata
d69d5c294f
Renaming fireball2 as 'accelerate' and removing old references
12 years ago
James Cammarata
736c8b19d3
Added ability to limit role dependencies to just one inclusion
12 years ago
James Cammarata
6f6efa268b
Merge branch 'smoothify-defaults' into devel
12 years ago
James Cammarata
25e3eed519
Fixing a bug in variable precedence for roles and dependencies
12 years ago
James Cammarata
637d3070dc
Allow default variables to be overridden by inventory variables
12 years ago
James Cammarata
9806f89a04
Revert "Construct the multiprocessing manager only once."
...
This reverts commit 1d13ec2da3 .
12 years ago
James Cammarata
7d3ae9fc75
Fixing a few bugs related to fireball2
...
* ssh port not being picked up, always uses default of 22
* forgot to 'import time' in the fireball2 connection plugin
12 years ago
James Cammarata
f66683863e
Merge branch 'defaults' of https://github.com/smoothify/ansible into smoothify-defaults
12 years ago
James Cammarata
faf82bf841
Fix bug with fetch when using sudo: true
...
Fixes #3111
12 years ago
James Cammarata
af1dd7075f
Adding chunked file transfers to fireball2
12 years ago
James Cammarata
959138d00d
Added accelerate_port to plays, and made it configurable
12 years ago
James Cammarata
167f185092
Initial support for running gather_facts through fireball2
12 years ago
James Cammarata
b45342923c
Initial support for sudoable commands over fireball2
...
Caveats:
* requiretty must be disabled in the sudoers config
* asking for a password doesn't work yet, so any sudoers users must
be configured with NOPASSWD
* if not starting the daemon as root, the user running the daemon
must have sudoers entries to allow them to run the command as the
target sudo_user
12 years ago
James Cammarata
4b552457e7
Bail out correctly if socket.recv gets nothing (indicating a closed socket)
12 years ago
James Cammarata
86f01965cd
Fireball2 module will now launch in a proper tmp path
12 years ago
James Cammarata
521e14a3ad
Fireball2 mode working!
12 years ago
James Cammarata
acc5d09351
Initial commit for the "fireball2" connection plugin
...
Still needs:
* chunked file transfer/receive
* should probably move all send/recv operations to separate
functions to reduce code duplication
* initial connection setup over ssh? or do we handle that in runner?
12 years ago
James Cammarata
fd2aabaa27
Initial work for the AES cipher class
...
This is based somewhat loosely on how Keyczar does things. Their
implementation does things in a much more generic way to allow for more
variance in how the cipher is created, but since we're only using one
key type most of our values are hard-coded. They also add a header to
their messages, which I am not doing (don't see the need for it
currently).
12 years ago
Bruce Pennypacker
cf6a76c814
changed ignore_md5_mismatch to validate_md5
12 years ago
Bruce Pennypacker
41c474d129
added optional ignore_md5_mismatch parameter
12 years ago
Michael DeHaan
cce7f485b8
Merge pull request #3946 from wincent/spelling-fix
...
Fix minor typo in playbook error message
13 years ago
Wincent Colaiuta
fc4307a9c4
Fix minor typo in playbook error message
13 years ago
James Cammarata
88966e6558
Use AnsibleError instead of exit for errors in utils
13 years ago
Jocelyn Jaubert
4cee6a5435
Add option remote_user to task level, to specify the ssh login user
13 years ago
James Cammarata
8262f7bfac
Merge branch 'with_items_and_complex_args' of https://github.com/lberruti/ansible into lberruti-with_items_and_complex_args
13 years ago
James Cammarata
e11bb0cad4
Merge branch 'plugins-work' of https://github.com/ferringb/ansible into ferringb-plugins-work
13 years ago
James Cammarata
462cd4f728
Merge branch 'pulls/fix-hostvars-inconsistancy' of https://github.com/ferringb/ansible into ferringb-pulls/fix-hostvars-inconsistancy
13 years ago
James Cammarata
e6ad3b7792
Merge pull request #3895 from mscherer/fix_option_new_ssh
...
make sure ssh do not ask password
13 years ago
James Cammarata
157b697a83
Merge branch 'always_run-6' of https://github.com/stoned/ansible into stoned-always_run-6
13 years ago
James Cammarata
af4f0bd008
Fix for "argument must be an int, or have a fileno() method" error
...
The issue was that, when forks == 1, the _executor() function was
being called with None for the value of new_stdin.
Fixes #3841 , #3902
13 years ago
James Cammarata
978af89175
Disallow running async tasks with lookup plugins
...
Fixes #2897
13 years ago
James Cammarata
ed3e4aff84
Place retry file in the user's home dir instead of /var/lib/tmp
...
Addresses CVE-2013-4260: predictable filename used for failed results
in world writable directory.
13 years ago
James Cammarata
6bf5d19506
SSH connection plugin creates ControlPersist socket files in a secure directory
...
Files were being created in /tmp, but will now be created in $HOME/.ansible/cp/
Addresses CVE-2013-4259: ansible uses a socket with predictable filename in /tmp
13 years ago
Stoned Elipot
f0743fc32a
Introduce the 'always_run' task clause.
...
The 'always_run' task clause allows one to execute a task even in
check mode.
While here implement Runner.noop_on_check() to check if a runner
really should execute its task, with respect to check mode option
and 'always_run' clause.
Also add the optional 'jinja2' argument to check_conditional() :
it allows to give this function a jinja2 expression without exposing
the 'jinja2_compare' implementation mechanism.
13 years ago
Michael Scherer
2bdba17a85
make sure ssh do not ask password
...
For some reason, ssh seems to ask for password even when
PasswordAuthentication is set to no, adding PreferredAuthentications
with the 2 options removed do the trick.
13 years ago
Kavin Kankeshwar
7ac3bbc198
resolved #3609 Change max_fail_pct to max_fail_percentage as recommended
13 years ago
Kavin Kankeshwar
3f247fcbe3
fixes ansible/ansible#3609 Add max_fail_pct to playbook parameter, to complement serial option, So if total number of failures execeed max_fail_pct * total number of hosts, do not go to the next serial batch
13 years ago
smoothify
494043947d
Add support for role defaults. These are variables on a per role basis with lowest precedence.
13 years ago
Petr Svoboda
e3adfbf5f8
Add tests for undefined variable detection
...
Tests `test_playbook_undefined_varsX_fail` check if ansible detects
undefined variables when `error_on_undefined_vars` is enabled. These
tests fail without "Improve behavior with error_on_undefined_vars
enabled" patch.
Tests `test_playbook_undefined_varsX_ignore` check if ansible ignores
undefined variables when `error_on_undefined_vars` is disabled.
Also modify PlayBook._run_task_internal() so error_on_undefined_vars is
testable.
13 years ago
Petr Svoboda
fff4f1da33
Improve behavior with error_on_undefined_vars enabled
...
Pass fail_on_undefined flag to recursive calls to `template` function,
so more undefined variables are detected.
Works only for Jinja style variables. Undefined legacy variables are
never detected.
13 years ago
Brian Harring
31061213fa
Fix inconsistency in hostvars access.
...
Previously, hostvars would only expose a keys() list of hosts that had
been seen yet- however you could explicitly access the host if you knew
the name, and get the content that way. This precludes template code
from being able to safely access information about other hosts if any
limiters/tags were in use.
Additionally, the object was inconsistent for hostvars['myhost'] access
and [x[1] for x in hostvars.items() if x[0] == 'myhost'] access; this is
due to the original derivation from the dict object. .items() would be
handled by dict.items(), using the passed in setup_cache values without
using the actual lookup content.
This patch rebases the class implementation to a py2.6 dictmixin, fixing
those issues and restoring behaviour to match what the docs claim.
13 years ago
Brian Harring
902183ac0e
Enforce alphanumeric ordering for plugins grabbed via glob.
...
If this isn't done, it's left to directory ordering which can result
in indeterminent behaviour.
13 years ago
James Cammarata
39628d012d
Minor fix to ipv6 detection for inventory with -i
...
For link-local addresses, it is sometimes necessary to append the
interface to use for the ipv6 address. This patch extends the ipv6
regex to allow for '%ifnameX' at the end.
See https://bugzilla.redhat.com/show_bug.cgi?id=136852 for more info
13 years ago
Michael Scherer
3aac187387
fix ssh connection plugin to work with ipv6 address
...
Due to various inconsistencies of ssh and sftp regarding ipv6 and
ipv4 handling, some special arguments must be passed, and the
ipv6 must be passed in a specific format.
13 years ago
Michael Scherer
c9d28e10ad
add support for using a ipv6 in -i
...
testing with a ipv6 :
ansible -u misc -i '[2002::c23e]:22,' '*' -m ping
fail due to parsing of ':' as a separator of port/ip with ipv4.
This commit add support for properly parsing 2002::c23 and the
bracket notation [2002::ce]:2222
13 years ago
Matt Saunders
9fd1b174f5
Fixed tiny bug with _meta handling in external inventory scripts
13 years ago
James Cammarata
5847720746
Fixing a small bug with the new role dependency feature
...
The block that added the original list of roles was indented too far,
and was only being reached if a role had dependencies. This resulted
in roles without dependencies from being added to the list of roles.
Credit goes to looped for reporting and diagnosing the issue.
13 years ago
Michael DeHaan
42648e2f0a
Merge branch 'role_dependencies' of git://github.com/jimi1283/ansible into jimi1283-role_dependencies
13 years ago
Michael DeHaan
dacd311474
Removing synchronize momentarily as it looks like this won't make 1.3 dates
13 years ago
James Cammarata
d8a7a2d1b2
Adding evaluation of role vars as the dep tree is built
...
This allows variables to be inserted into the role scope specifically
while also being inserted into the global scope.
13 years ago
James Cammarata
e12b99dba6
Small cleanup, no need to call _get_role_path a second time
13 years ago
James Cammarata
9a401e73a6
Adding support for role dependencies.
...
Fixes #3686
Dependencies are enabled by adding a new directory/file named
meta/main.yml to the role. The format of the dependencies are:
dependencies:
- { role: foo, x: 1, y: 2 }
- { role: bar, x: 3, y: 4 }
...
Dependencies inherit variables as they are seen at the time of the
dependency inclusion. For example, if foo(x=1, y=2) has a dependency
on bar(x=3,z=4), then bar will have variables (x=3,y=2,z=4).
Different roles can have dependencies on the same role, and this
variable inheritence allows for the reuse of generic roles quite easily.
For example:
Role 'car' has the following dependencies:
dependencies:
- { role: wheel, n: 1 }
- { role: wheel, n: 2 }
- { role: wheel, n: 3 }
- { role: wheel, n: 4 }
Role 'wheel' has the following dependencies:
dependencies:
- { role: tire }
- { role: brake }
The role 'car' is then used as follows:
- { role: car, type: honda }
And tasks/main.yml in each role simply contains the following:
- name: {{ type }} whatever {{ n }}
command: echo ''
TASK: [honda tire 1]
TASK: [honda brake 1]
TASK: [honda wheel 1]
TASK: [honda tire 2]
TASK: [honda brake 2]
TASK: [honda wheel 2]
TASK: [honda tire 3]
TASK: [honda brake 3]
TASK: [honda wheel 3]
TASK: [honda tire 4]
TASK: [honda brake 4]
TASK: [honda wheel 4]
TASK: [I'm a honda] <- (this is in roles/car/tasks/main.yml)
13 years ago
James Cammarata
ad595eadea
Enable error_on_undefined_vars by default
13 years ago
Michael Scherer
12bf9a8b69
add a way for callback to disable itself
...
The idea is that some plugin would not be called in some
specific case, and the callback should decide by itself.
Having a way to globally disable it is much cleaner than
disabling every method one by one on the plugin side.
My use case is for fedora-infrastructure that cannot be run
from git checkout since it try to connect to the message bus,
but another case would be to bootstrap infrastructure, or to
run the code on a test servers without having all the callback
infrastructure setup.
13 years ago
Luca Berruti
eee278e02b
fix
13 years ago
Luca Berruti
5048218ab5
Fix: with_items and complex_args
13 years ago
Serge van Ginderachter
173586b871
Ensure plugin_loader.all() only loads one instance
...
by ensuring all basedirs, plugin paths and extra
paths are handled as absolute paths and are checked
to not add any doubles.
This fixes the corner case where e.g. the user has
an additional plugin path configured to a dir
relative to his playbooks or inventory location,
which also matches the _plugin subdir relative to
one of the basedirs in the play.
For most plugins this doesn't show as an obvious issue
except for callback_plugins, which might fire more
than once. Other plugins (inventory and template
plugins) might unnecessarily be ran twice.
e.g. ansible.cfg has
callback_plugins = ./plays/callback_plugins
and plays/ contains a playbook file:
.
├── ansible.cfg
├── inventory
└── plays
├── callback_plugins
│ └── timestamp.py
└── site.yml
modified: lib/ansible/utils/plugins.py
13 years ago
Michael DeHaan
bc02e20503
Merge branch 'rsynctake2' into devel
...
Conflicts:
CHANGELOG.md
13 years ago
Michael DeHaan
17aa0d12de
Merge pull request #3814 from ftao/inventory_dir_abs
...
fix inventory.basedir is not absolute path when hostfile is startswith "./"
13 years ago
Abhijit Menon-Sen
1a90d01ba9
Fix some typos discovered during casual reading
13 years ago
ftao
51a180b150
fix inventory.basedir is not absolute path when hostfile is startswith "./"
13 years ago
Michael DeHaan
f8c97d6e79
Style/docs cleanup, and also improve an error message.
13 years ago
Michael DeHaan
aeb8649da5
Merge branch 'ansible-rsync-take2' of git://github.com/tima/ansible into rsynctake2
13 years ago
Michael DeHaan
4d1f447908
Merge pull request #3650 from bcoca/forking_optimizations
...
forking least possible
13 years ago
Michael DeHaan
baffa8df72
These fields are booleans.
13 years ago
Michael DeHaan
633abca916
Merge branch 'nocolor' of git://github.com/amenonsen/ansible into devel
13 years ago
Michael DeHaan
ee11d69697
Merge branch 'better_ini_errors2' of git://github.com/bcoca/ansible into devel
13 years ago
Michael Vogt
89bc43cab0
support i18n on sudo failure
13 years ago
Serge van Ginderachter
9991a530ab
fix an encoding bug in copy content = lookup plugin
...
closes #3518
13 years ago
Michael DeHaan
66b29b6813
Merge branch 'feature/gh-3789-inventory-file' of https://github.com/resmo/ansible into devel
13 years ago
Michael DeHaan
1d13ec2da3
Construct the multiprocessing manager only once.
13 years ago
René Moser
e8272e365d
implemented 'inventory_file' variable. Closes GH-3789.
13 years ago
Timothy Appnel
2288a11b6a
Implemented setup method in rsync action module.
13 years ago
Timothy Appnel
4a9635e04e
Straighten out local-remote-delegate logic in rsync action module. Force set delegate to local if one is not defined.
13 years ago
Timothy Appnel
adbca9d251
Fixed identity key logic.
13 years ago
Timothy Appnel
9f170f579a
Introduced ansible-rsync to core.
13 years ago
James Cammarata
ceff3b6ba3
Minor modification to set_fact with_items patch
...
Previous patch was reverted due to the fact that there was an issue
with the results not always being a dictionary (they're sometimes
a unicode string, ie. when the with_items is used with yum). This
minor change corrects that by checking for a dict object.
13 years ago
James Cammarata
8be2fc745b
Revert "Check for ansible_facts in results for with_ tasks"
...
This reverts commit 1a4e6e415e .
13 years ago
Serge van Ginderachter
1a4e6e415e
Check for ansible_facts in results for with_ tasks
...
that loop over a lookup plugin. Fixes #3704 and #3735
13 years ago
Serge van Ginderachter
40e60c947d
Host specifiers should be sorted
...
to ensure consistent behavior, hosts should look like this:
hosts: webservers:&boston:!rack42
So when applying the host selectors, run those without the "&" first,
then the &s, then the !s.
Closes #3500
13 years ago
Abhijit Menon-Sen
0c96d8af6e
Add a nocolor setting to ansible.cfg
13 years ago
Brian Coca
a937a6a66d
now bad ini entries will throw friendlier error
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
4cbfe3be57
Merge pull request #3773 from cchurch/devel
...
Update callbacks used for async tasks
13 years ago
Michael DeHaan
ff44c981e9
Merge pull request #3770 from rishid/devel
...
Add support for INI comments that begin with '#' or ';'
13 years ago
Michael DeHaan
99775176ff
Merge pull request #3623 from ralph-tice/fix_3567_2
...
changed role path template to read all vars instead of just extra_vars
13 years ago
Chris Church
6ba4331161
Correctly check for failed status from an async task. Use runner_on_async_failed callback (instead of runner_on_failed) when an async task times out. Add runner_on_async_ok callback when a task is started in fire and forget mode.
13 years ago
rishid
d18c90ed8f
Add support for INI comments that begin with '#' or ';'
...
Ini file format does not have a standard but ';' is used more often than '#' for comments
13 years ago
Michael Scherer
3fb2da6359
use lgetfilecon_raw instead of lgetfilecon to not depend on local level translation
...
If SELinux is enabled and mcstrans is running, daemons are restarted on each
run. After further debugging, it turn out that ansible compare the untranslated
level 's0' with the translated level 'SystemLow' due to mcstrans being running,
which trigger a handler since this is considered as a change.
13 years ago
Michael DeHaan
56a00e0667
Remove dead code.
13 years ago
Michael DeHaan
8955ac1eda
If the result of a dynamic inventory script contains a "_meta" hash at top level
...
and the _meta hash contains a "hostvars", don't call --host hostname for any elements
and just serve them directly for performance enhancements with the external inventory
script and a large number of hosts.
13 years ago
Michael DeHaan
1c6b81233c
Merge pull request #3692 from tima/action-init
...
Added support of an optional init method for action modules like rsync that need to alter the connection and other inject data before it's established.
13 years ago
Michael DeHaan
dec43f7a2b
PEP8 indent fix.
13 years ago
Michael DeHaan
3dbe65def2
PEP8 indent fix
13 years ago
Michael DeHaan
76fd769704
Merge pull request #3685 from mspaulding06/indexed_items
...
Indexed items lookup plugin
13 years ago
Michael DeHaan
c0ab417ef9
Don't iterate across strings in with_nested.
13 years ago
James Cammarata
82c806979b
Only use LOG_LOCK in log_flock if a runner is not specified
...
Fixes issue #3466 - When ansible can't authenticate against a host,
and your answer is no, ansible crash.
13 years ago
James Cammarata
ba38d6bc16
Adding support for hashed known_hosts entries
...
Fixes Issue #3716 - SSH known host checking needs to understand
hashed known hosts
13 years ago
Brian Coca
581a0c9f59
now correctly 'types' value pairs that are passed as options to jinja
...
override
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
0335d05f43
Check against None around playbook basedir
13 years ago
Michael DeHaan
bdef7f1774
Merge pull request #3711 from ashorin/devel
...
Allow --diff on UTF-8 encoded files and templates
13 years ago
Michael DeHaan
44d060628e
Merge pull request #3706 from lorin/sudo_user_breakage
...
Fix sudo_user copy error
13 years ago
Michael DeHaan
daf5ecc7c9
Merge pull request #3684 from stoned/fix-3668
...
Add extra module path early during playbook parsing.
13 years ago
Michael DeHaan
83481b32cc
Merge pull request #3657 from zqad/devel
...
Fix playbook-local host_vars when running from .
13 years ago
Michael DeHaan
3ebbb56479
Merge pull request #3654 from MaxIV-KitsControls/devel
...
Fix nested loop for more than 3 elements
13 years ago
Michael DeHaan
7813290969
Merge pull request #3645 from stoned/stringify-conditional-2
...
stringify conditional before handing it to Jinja2 for evaluation.
13 years ago
Andrey Shorin
664215eb02
Allow --diff on UTF-8 encoded files and templates
13 years ago
Lorin Hochstein
a303fca193
Fix sudo_user copy regression
...
Treat errno 13 (permission denied) as one of the special cases in
atomic_move.
This type of error can occur because of sudo'ing to non-root user.
Fixes #3705
13 years ago
Timothy Appnel
11beb38c66
Added support of an optional setup method for action modules like rsync that need to alter the connection and other inject data before it's established.
13 years ago
Matt Spaulding
5d15515bbf
Add indexed_items lookup plugin
13 years ago
Stoned Elipot
841093921b
Add extra module path early during playbook parsing.
...
This should fix issue #3668
Also prevent an extra module path to be added multiple times.
13 years ago
Jonas Eriksson
16efb45735
Fix playbook-local host_vars when running from .
...
Since ansible 1.2, it became possible to place a host_vars
directory in the same directory as a playbook, making it possible
to keep host_vars local to that playbook there. However, due to
python's os.path.dirname, a action such as:
$ ansible-playbook pb.yml
..would not pick up the host_vars as os.path.dirname("pb.yml")
returns "", unlike the unix command dirname that would return
".". Substituting "pb.yml" on the command line with "./pb.yml"
would do the trick, but is not always intuitive. This patch
solves the problem until python solves issue18547 [1].
[1] http://bugs.python.org/issue18547
13 years ago
Vincent Hardion
09ef7751e1
Fix nested loop for more than 3 elements
...
- combine flatten list for each nested level instead once at the end
13 years ago
Brian Coca
576962d335
now if you set fork to 0 or a number higher than the number of hosts, it
...
will be readjusted to the number of hosts runner is going to deal with.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Stoned Elipot
a1503c4d59
stringify conditional before handing it to Jinja2 for evaluation.
...
This should fix simple conditionals like:
when: ansible_selinux
While here add tests for ansible.utils.check_conditional() in
"jinja2_compare mode".
13 years ago
WAKAYAMA Shirou
0ce99e391f
fix: if a path is symlink and trying to chmod, OSError Exception will be raised.
13 years ago
Michael DeHaan
f0eafff1b4
Merge pull request #3621 from sergevanginderachter/rename2flattened
...
also rename plugin name in error message
13 years ago
Ralph Tice
2383a8205c
changed role path template to read all vars instead of just extra_vars
13 years ago
Serge van Ginderachter
b40295910d
also rename plugin name in error message
13 years ago
Michael DeHaan
2fe25f19dc
Fix to group_by module as a result of previous conditional upgrades.
13 years ago
Michael DeHaan
e3f213e030
Fixup error reporting.
13 years ago
Michael DeHaan
c07dd07767
Add raw copy support (raw=yes), tweak tempfile error message string.
13 years ago
Michael DeHaan
0cf5e5cec3
Merge branch 'devel' of git://github.com/bradleyy/ansible into together
13 years ago
Michael DeHaan
0756aa406a
Change conditional operation workflow.
...
Conflicts:
lib/ansible/utils/__init__.py
13 years ago
Michael DeHaan
7f462a346a
Work in progress on merging changed_when.
13 years ago
Michael DeHaan
88720516a1
Merge branch 'changed_when' of git://github.com/stoned/ansible into changed_when
13 years ago
Michael DeHaan
f592340f7f
Merge branch 'playbook-skip-tags' of git://github.com/dekked/ansible into skip_tags
13 years ago
Michael DeHaan
3baa55a314
Merge branch 'devel' of git://github.com/sjmudd/ansible into sjmudd_ranges
13 years ago
Michael DeHaan
62b39d3de5
Fix for saving conditionals in variable expressions.
13 years ago
Michael DeHaan
bf70dfc1a0
When a role/include has a conditional, add that conditional ahead of any on the task, not behind, so it can short circuit.
13 years ago
Michael DeHaan
419661542b
Added some pipes.quote ops to make sure paths with spaces in them are ok.
13 years ago
Michael DeHaan
192d9f8b89
Merge pull request #3607 from stoned/use-AnsibleFilterError
...
Use AnsibleFilterError exception
13 years ago
Stoned Elipot
667ad2480e
Use AnsibleFilterError exception
13 years ago
Stoned Elipot
e7a733a6be
Quote pathnames of roles' tasks and handlers files so that _load_tasks() can tokenize them properly
...
With the help of AlejandroTrev's eagle eyes. Thanks !
13 years ago
Michael DeHaan
0f26439234
Remove variable per pyflakes
13 years ago
Michael DeHaan
e1167d6977
tweak indentation for 'make pep8'
13 years ago
Michael DeHaan
0f4229f6c4
Merge pull request #3462 from stoned/filtererror
...
Introduce exception AnsibleFilterError and use it in Jinja filters. Ign...
13 years ago
Brian Coca
dafbcf87d3
changed atomic_move to be more 'optimistic' which helps deal with corner
...
cases and avoid usless work.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
c10c2cae4e
Merge branch 'ansible_sudo_at_role_level' of git://github.com/jeromew/ansible into sudo_role
13 years ago
Michael DeHaan
f7dec4f8f4
Rename plugin.
13 years ago
Michael DeHaan
9dec701728
Merge pull request #3559 from sergevanginderachter/flat_list
...
Introduce flat_list lookup plugin
13 years ago
Michael DeHaan
7d2585caf7
Merge pull request #3577 from Tinche/extra-vars-in-playbook-includes
...
Enabled the use of extra vars in playbook file paths when including play...
13 years ago
Brian Coca
c8d6e5be0b
missing self in self method usages
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael Vogt
9caef884e1
fail early on the wrong sudo password instead of waiting until the timeout happens
13 years ago
Michael DeHaan
c98b20b2cf
Slight style preferences.
13 years ago
Sharif Olorin
5fcbfa984d
More informative error message on failure to resolve tmpdir
13 years ago
Sharif Olorin
1a7a779e88
Handle SSH failures when creating remote tmpdir
...
Bail out if the SSH command fails rather than continuing with an
empty tmp variable.
13 years ago
Michael DeHaan
8a3ea0774a
Update error message since user may have specified connection type via non command line or by default.
13 years ago
Michael DeHaan
5eea4b56fa
Merge pull request #3591 from cocoy/fix_3567
...
Allow roles to be interpolated from --extra-vars
13 years ago
Michael DeHaan
7965bc729b
Merge pull request #3588 from Atte/devel
...
Check for existence of isatty on stdout before calling it
13 years ago
Rodney Quillo
a4e829c874
Allow roles to be interpolated from --extra-vars
13 years ago
Atte Virtanen
511c7c858d
Check for existence of isatty on stdout before calling it
13 years ago
Brian Coca
f6c99a69db
switched from sestatus to selinuxenabled as per recommendation
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca
98cc29f9fd
now returns fatal error if operation on selinux enabled target is
...
attempted w/o selinux python bindings
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
jeromew
de0bc96b70
Implement sudo/sudo_user at the include and role levels
13 years ago
Tin Tvrtkovic
4a732c1e9f
Enabled the use of extra vars in playbook file paths when including playbooks from other playbooks.
13 years ago
Serge van Ginderachter
730b368259
Introduce flat_list lookup plugin
...
- hosts: localhost
gather_facts: False
tasks:
- debug: msg="{{item}}"
with_flat_list:
- a
- - b
- c
- d
- - e
- f
- - g
- h
- i
- j
- - k
- l
# note: main list or list (sub)items can also be set as a variable
TASK: [debug msg="{{item}}"] **************************************************
ok: [localhost] => (item=a) => {"item": "a", "msg": "a"}
ok: [localhost] => (item=b) => {"item": "b", "msg": "b"}
ok: [localhost] => (item=c) => {"item": "c", "msg": "c"}
ok: [localhost] => (item=d) => {"item": "d", "msg": "d"}
ok: [localhost] => (item=e) => {"item": "e", "msg": "e"}
ok: [localhost] => (item=f) => {"item": "f", "msg": "f"}
ok: [localhost] => (item=g) => {"item": "g", "msg": "g"}
ok: [localhost] => (item=h) => {"item": "h", "msg": "h"}
ok: [localhost] => (item=i) => {"item": "i", "msg": "i"}
ok: [localhost] => (item=j) => {"item": "j", "msg": "j"}
ok: [localhost] => (item=k) => {"item": "k", "msg": "k"}
ok: [localhost] => (item=l) => {"item": "l", "msg": "l"}
13 years ago
Alan Descoins
04349ec362
Added --skip-tags option to ansible-playbook.
13 years ago
Antti Rasinen
b12cc909a9
Fix pretty_bytes for exa- and zettabytes
13 years ago
Brian Coca
18cb155bd5
now ANSIBLE_KEEP_REMOTE_FILE acts as boolean
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Bradley Young
23557b6e5a
change the name from transpose to "together". Change to use itertools.izip_longest() rather than method cribbed from nested.py
13 years ago
Stoned Elipot
eb45f07ae3
Introduce 'changed_when' keyword to override a task's changed status with the evaluation of a Jinja2 expression
13 years ago
Bradley Young
ea93a36b10
Adding transpose lookup method. This will matrix transpose arrays that are passed in, and then work like items over the resulting list of lists. e.g.:
...
Transpose a list of arrays:
[1, 2, 3], [4, 5, 6] -> [1, 4], [2, 5], [3, 6]
Replace any empty spots in 2nd array with "":
[1, 2], [3] -> [1, 3], [2, ""]
13 years ago
Michael DeHaan
fba1f7ef42
Revert "expand vars like $HOME used in config values too" -- breaks remote_tmp if set.
...
This reverts commit e5ff35bbdb .
13 years ago
Michael DeHaan
afcd869487
Merge pull request #3451 from sergevanginderachter/template_ansible_ssh_host
...
allow ansible_ssh_host to be templated
13 years ago
Michael DeHaan
90dfc115d6
Merge pull request #3463 from stoned/filterskipped
...
Add Jinja2 filter 'skipped' to test for a registered variable from a ski...
13 years ago
Michael DeHaan
279247dfac
Merge pull request #3464 from stoned/filterquote
...
Add Jinja2 filter 'quote' to quote string for shell usage
13 years ago
Andreas Piesk
e5ff35bbdb
expand vars like $HOME used in config values too
13 years ago
Lasse Borchard
8c8b4d56fc
Fixed indention of vv() output
13 years ago
Stoned Elipot
247322bb16
Add Jinja2 filter 'quote' to quote string for shell usage
13 years ago
Stoned Elipot
906746b1f0
Add Jinja2 filter 'skipped' to test for a registered variable from a skipped task
13 years ago
Stoned Elipot
2d88c70cd5
Introduce exception AnsibleFilterError and use it in Jinja filters. Ignore this exception when trying to find the name of a task for display (callback) purpose.
13 years ago
Michael DeHaan
cf6e1f8db9
Make it possible to tell paramiko to not record new host keys, which can be slow with a large number of hosts.
...
-c ssh is preferred in most cases if you have ControlPersist available, otherwise if you are comfortable you
can turn off recording while leaving host key checking on, etc.
13 years ago
Michael DeHaan
14818af446
Merge pull request #3450 from tonk/sudo
...
Repair issue #3447
13 years ago
Michael DeHaan
aa9385411d
Merge pull request #3443 from ajsalminen/arg_unicode_fix
...
Use .encode() instead of str() to support unicode arguments.
13 years ago
Ton Kersten
37ee361be1
Repair issue #3447
13 years ago
Serge van Ginderachter
129c7522d9
allow ansible_ssh_host to be templated
...
Use case: e.g. dual homed hosts on production en management network
The inventory_hostname is the regular host name and matches the
dns name on the production network; ansible connects to the host
through a management network; the dns name on the management network
is standardized and equals ${inventory_hostname}-mgt.mynetwork.com
Now this can be configured as the default in group_vars/all:
ansible_ssh_host: {{ inventory_hostname + '-mgt.mynetwork.com' }}
13 years ago
Michael DeHaan
2cb7c30834
Improve interlaced output prevention when asking for host key approval.
13 years ago
Michael DeHaan
c55adc9ac9
Default to 'smart' transport, which will use OpenSSH if it can support ControlPersist.
13 years ago
Antti Salminen
d7c6cf10c2
Use .encode() instead of str() to support unicode arguments.
...
str() throws an UnicodeEncodeError for code points that cannot be
represented in 7-bit ASCII. This makes it impossible to use any
non-ASCII characters in module arguments. Using encode('utf-8')
gives the desired result.
13 years ago
Michael DeHaan
1683d44d2e
Lock around SSH connectivity to new hosts in host checking mode such that prompts for host approval
...
messages do not get interlaced.
13 years ago
Michael DeHaan
cb26945d54
Close the named temporary file.
13 years ago
Michael DeHaan
3b1aa092f8
Closing stdin too early.
13 years ago
Michael DeHaan
ffadbc520a
Enable paramiko to ask whether to add keys to known hosts.
13 years ago
Michael DeHaan
9db4f7a9a6
Makes host key checking the default behavior but can be disabled in ansible.cfg or by environment variable.
13 years ago
Stoned Elipot
0b3483cf03
Add Jinja2 filter |bool : return boolean interpretation of the value
...
'yes', 'on', '1', 'true', insensitively, and 1 are true,
everything else is false
13 years ago
Michael DeHaan
6ba72854ee
Merge pull request #3296 from ninetythirty/devel
...
Added flexible filename handling for main files
13 years ago
Michael DeHaan
c2988dfdb0
Merge branch 'option-updates' of git://github.com/jlund/ansible into devel
...
Conflicts:
bin/ansible-pull
13 years ago
Michael DeHaan
2bbad5dae3
Merge pull request #3275 from madduck/implicit-negations
...
Enable negated patterns
13 years ago
Michael DeHaan
f2fc185651
Styling: indentation
13 years ago
Michael DeHaan
c265c761d0
Slight message tweak.
13 years ago
Michael DeHaan
e6adc2f066
Merge branch 'devel' of git://github.com/arturaz/ansible into devel
13 years ago
Michael DeHaan
146455fd0a
Merge pull request #3375 from jhoekx/mandatory-filter
...
Add a mandatory jinja2 filter for use in templates.
13 years ago
Michael DeHaan
98e7eaf07a
Merge pull request #3316 from dsedivec/devel
...
expanduser on each component of plug-in paths
13 years ago
Stoned Elipot
b7f89837bb
Remove redundant call to _get_path() in PluginLoader.find_plugin()
13 years ago
Jeroen Hoekx
a37f55d32e
Add a mandatory jinja2 filter for use in templates.
13 years ago
Joshua Lund
dc984d94ac
Updates to Ansible command options
...
* Moved the --list-hosts option that is common to both `ansible` and
`ansible-playbook` into utils/__init__.py (corrects a FIXME)
* Wrote new help text for the --list-hosts option that makes sense
for both of the commands that it applies to
* Changed the usage argument in `ansible-playbook` so that it is
setup in the base_parser method the same way that it is in
the `ansible` executable
* Updated the help text for several options to correct typos,
clarify meaning, improve readability, or fix grammatical errors.
In the case of `ansible-pull`, I changed the help text so that
it adheres to the same standards as the other executables.
13 years ago
Jesse Keating
e1dd83f2b6
add_host should not be a changed action
...
The action doesn't actually change anything on a system, so setting
the status to changed is wrong. add_host is much like set_fact in that
regard.
Since changed is False by default, there is no need to explicity set
it, so just create an empty dict for result and add to it from there.
13 years ago
Arturas Slajus
9be93d6ac7
Better error for fireball + sudo mode.
13 years ago
Dale Sedivec
b32131c867
expanduser on each component of plug-in paths
...
ansible.constants was calling expanduser (by way of shell_expand_path)
on the entire configured value for the library and *_plugins
configuration values, but these values have always been interpreted as
multiple directories separated by os.pathsep. Thus, if you supplied
multiple directories for one of these values, typically only the first
(at least on *nix) would have e.g. "~" expanded to HOME.
Now PluginLoader does expansion on each individual path in each of
these variables.
13 years ago
Ninety Thirty
7b1e87b62d
Added flexible filename handling for main files
...
tasks, handlers, and vars main files can now be any of main, main.yml, or main.yaml
13 years ago
martin f. krafft
fd02443d42
Enable negated patterns
...
A host pattern of the form '!foo' by itself does not work, but
'all:!foo' does. If the first pattern is a negation, this commit
automatically prepends 'all'.
Signed-off-by: martin f. krafft <madduck@madduck.net>
13 years ago
Michael DeHaan
010440dc47
Merge pull request #3114 from laggyluke/roles_combine_vars
...
Added basic support for hash_behaviour=merge in roles
13 years ago
Michael DeHaan
fc45470162
Merge branch 'with_inventory_hostnames' of git://github.com/sdossett/ansible into inv_hostnames
13 years ago
Michael DeHaan
0ce7996bb6
Merge pull request #3266 from trbs/20130619_first_found
...
enable use of multiple terms in first_found
13 years ago
Michael DeHaan
d2721526de
Small tweak, don't merge conditionals, just evaluate each in turn.
13 years ago
Michael DeHaan
d9c0a5c37d
Revert "now modules can implement with_items list globbing w/o updating"
...
This reverts commit 4942a06bc2 .
Conflicts:
lib/ansible/runner/__init__.py
13 years ago
trbs
87c7fa9138
enable use of multiple terms in first_found
13 years ago
George Miroshnykov
c642ba77ae
Added basic support for hash_behaviour=merge in roles
...
Dict vars passed to roles are now properly merged
instead of simply overriding dict vars that are
coming from vars_files.
13 years ago
Jesse Keating
1074896105
make name the parameter, with hostname as alias
...
name is used throughout Ansible, it's the "standard". This change
applies that standard to the add_host routine and updates the docs to
reflect that. Related to https://github.com/ansible/ansible/pull/3254
13 years ago
Michael DeHaan
fc2d25eb82
Merge pull request #3127 from bennojoy/devel
...
bug fix for #3077 , environment settings for script
13 years ago
Michael DeHaan
132c89e681
Merge branch 'callbackinit' of git://github.com/sergevanginderachter/ansible into devel
13 years ago
Michael DeHaan
7193ff5fbf
Merge pull request #3250 from gildegoma/more_magical_ansible_ssh_user
...
Make 'ansible_ssh_user' available in templates
13 years ago
Michael DeHaan
2123507315
Merge branch 'sha256' of git://github.com/jlund/ansible into devel
...
Conflicts:
library/network/get_url
13 years ago
Michael DeHaan
92754065bf
Remove debug statement.
13 years ago
Michael DeHaan
5a504e3a3b
Tweak error messages for undefined variables feature.
13 years ago
Michael DeHaan
637983cf31
cleanup example config file + Squashed commit of the following:
...
commit c36b66dc952dfff91043ecbca56cf3f1f8f00703
Merge: 240d7bf f4cf934
Author: Michael DeHaan <michael@ansibleworks.com>
Date: Tue Jun 18 13:04:51 2013 -0400
Merge branch 'unevaluated-vars' of git://github.com/lorin/ansible into lorin_undefined
Conflicts:
lib/ansible/runner/__init__.py
commit f4cf934367
Merge: 2531440 07a1365
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Thu Jun 6 11:07:41 2013 -0400
Merge branch 'devel' into unevaluated-vars
commit 253144045c
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Thu Jun 6 11:06:37 2013 -0400
Fail template from file on undefined vars
If config option is set, raise an exception if templating from a
file and a variable is undefined.
commit aecb71d8b7
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Wed Jun 5 17:12:12 2013 -0400
Add fail_on_undefined flag
Add a fail_on_undefined flag to the template and template_from_string methods.
If this flag is true, then re-raise the ninja2.excpetions.UndefinedError instead of
swallowing it.
commit cbb1808f05
Merge: d4bbf49 41425fb
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Wed Jun 5 16:14:12 2013 -0400
Merge branch 'devel' into unevaluated-vars
commit d4bbf492b0
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Mon Jun 3 19:46:13 2013 -0400
template: Raise UndefinedError exception
In template_from_string, raise an undefined error if it occurs.
Have the caller catch it and throw an AnsibleUndefinedVariable
commit c947802805
Merge: 8d919d6 be33bcf
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Mon Jun 3 10:09:43 2013 -0400
Merge branch 'devel' into unevaluated-vars
commit 8d919d6c97
Merge: 0f68ad8 b8630d2
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Thu May 30 16:27:48 2013 -0400
Merge branch 'devel' into unevaluated-vars
commit 0f68ad8193
Author: Lorin Hochstein <lorin@nimbisservices.com>
Date: Thu May 30 14:32:03 2013 -0400
Optionally fail task on undefined variables
This patch introduces a new configuration option called
error_on_undefined_vars, which defaults to false.
If this option is set to true, then a task which has unevaluated
variables in its arguments will fail instead of running. Output looks
like this:
TASK: [set rabbitmq password] *************************************************
fatal: [10.20.0.7] => Undefined variables: rabbitmq_user, rabbitmq_password
13 years ago
Gilles Cornu
48fe7ac19d
Enlarge scope of 'ansible_ssh_user' magic variable
...
Allow to use ansible_ssh_user variable in `sudo_user` or `when` clauses
13 years ago
Scott Sturdivant
b10b676158
Print the default value if one is provided.
13 years ago
Michael DeHaan
e128e8b563
Merge pull request #3162 from strawlab/apt-key-binary-fix
...
allow apt-key module to work with binary key
13 years ago
Michael DeHaan
aa340c1508
Merge pull request #3169 from Debilski/fix-duplicate-host-reads
...
Allow inventory to be read from a pipe
13 years ago
Michael DeHaan
70a9be27f6
Merge pull request #3217 from dagolden/topic/late-sudo_user
...
Expand sudo_user after variable merging
13 years ago
Michael DeHaan
d9f91be34a
Merge pull request #3227 from bcoca/modules_wantlist
...
implementing with_items list globbing made easier for modules
13 years ago
trbs
a4223e119d
fixed x-bits in git
13 years ago
Brian Coca
4942a06bc2
now modules can implement with_items list globbing w/o updating
...
hardcoded lists in ansible code, just add WITH_ITEMS_USES_LIST in a
comment anywhere, and of course, support recieving params as list.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
David Golden
d65f45f0b2
Expand sudo_user after variable merging
...
Previous commit c3659741 expanded sudo_user during task construction,
but this is too early as it does not pick up variables set during
the play.
This commit moves sudo_user expansion to the runner after variables
have been merged.
13 years ago
Serge van Ginderachter
2a7f9df109
add support for callback_plugins/ relative to playbook
13 years ago
Michael DeHaan
404b082d82
Version bump and assorted things to start new development version.
13 years ago
Michael DeHaan
3d21dab705
Small fix so template plugins can see inject variables.
13 years ago
Rike-Benjamin Schuppner
71afb9e432
Use with guard for file reads.
13 years ago
Rike-Benjamin Schuppner
deaf499ba1
Remove duplicate host file reads by removing a legacy check.
...
This allows using a form such as
ansible -i <( arbitrary command ) all -m ping
13 years ago
Andrew Straw
94e66ef558
allow apt-key module to work with binary key
13 years ago
Chris Church
d1de7839d7
Renamed on_no_hosts_matched/on_no_hosts_remaining to correct names in noop callback, added methods to callback plugin examples.
13 years ago
Chris Church
3f17a39238
Set current play/task to None for callback context when finished running the current play/task.
13 years ago
Simon J Mudd
25822330a2
Add support for multiple ranges in a host
...
e.g. db[01:10:3]node-[01:10]
- to do this we split off at the first [...] set, getting the list
of hosts and then repeat until none left.
- also add an optional third parameter which contains the step. (Default: 1)
so range can be [01:10:2] -> 01 03 05 07 09
13 years ago
bennojoy
017e7f24ed
bug fix for #3077 , environment settings for script
13 years ago
Joshua Lund
2ce7f136b2
* Added a sha256 method to module_common
...
* Added a sha256sum parameter to the get_url module to enable
cryptographic verification of downloaded files
* Fixed a few typos in the documentation
13 years ago
Chris Jacobs
588d4080df
don't want to ignore explicit cwd
13 years ago
Chris Jacobs
69db160e2f
Skip dotfile in hosts dirs
13 years ago
Serge van Ginderachter
f1cf81b086
optimization when adding child groups
13 years ago
Peter Hudec
e8ff3c43ad
fixed first_available_file and roles support
...
for copy and template action
13 years ago
Steven Dossett
e0a15d0c50
Updated to support inventory options from command line
13 years ago
Michael DeHaan
c52abd40b0
Fix for the directory inventory source where depth information on the group was being discarded
...
due to initial copy. New model will reuse the first object and copy attributes on the second.
13 years ago
Michael DeHaan
be33bcf16f
Merge pull request #3105 from shirou/devel
...
fix utf-8 named task failed with --step.
13 years ago
Michael DeHaan
3783dc42d4
normalize path
13 years ago
WAKAYAMA Shirou
66247042a5
fix utf-8 named task failed with --step.
13 years ago
Darryl Stoflet
c0baf10845
Support for all:vars in script inventories
13 years ago
Michael DeHaan
3b77d17a26
Spelling fix.
13 years ago
Michael DeHaan
1f7c197a9d
os.path.dirname returns '' not None in some cases, handle this so inventory can be specified with ./
13 years ago
Michael DeHaan
4a93c247bd
Another lookup plugin relative path tweak.
13 years ago
Michael DeHaan
b8a66ce5bb
Lookup plugins in included files now look in paths relative to their files, allowing role usage.
13 years ago
Michael DeHaan
c4a125e6d9
Add ability to use |success and |failed as Jinja2 filters.
...
Example:
when: registered_variable|failed
13 years ago
Michael DeHaan
4840e59b90
Allow cowsay to be removed mid playbook run.
13 years ago
Steven Dossett
1ff93e6b08
Plugin with_inventory_hostnames - loops generated from groups or
...
hosts in inventory
13 years ago
Michael DeHaan
6cd3ba5b06
Allow the group_vars and host_vars directories to be stored alongside the playbook as well as inventory.
13 years ago
node
a58baae2c4
Make the actual user used for executing play available as 'ansible_ssh_user' variable
13 years ago
Pol Llovet
4432c01ceb
Handle '#' in var strings by splitting on ' #'
...
If someone has a " #" in a quoted var string, it
will interpret that as a comment and refuse to
load the inventory file due to an unbalanced
quote. Noisy failure > unexpected behavior.
13 years ago
Pol Llovet
ba78360c52
Remove inline comments from inventory tokenizing.
13 years ago
Michael DeHaan
fd77804bff
Merge pull request #3017 from sergevanginderachter/roles-script
...
Add roles support for the script module
13 years ago
Michael DeHaan
44e32cc45e
Some formatting fixes so docs will build, etc.
13 years ago
Michael DeHaan
a9fcea5893
Merge branch 'escape' of git://github.com/ngrilly/ansible into repr
13 years ago
Jeremiah Heller
7de718cd51
Fix copy when force=no and update _remote_md5 docs.
...
Previously setting force=no caused copy to subversively
fail when target did not exist on remote host.
Caused by Runner._remote_md5 returning 1
when files don't exist, rather than 0.
13 years ago
Kavin Kankeshwar
8217e0706f
Avoid crash in module_common when the file cannot be moved/copy
13 years ago
Serge van Ginderachter
0c0d6c0b4e
performance optimization in inventory.groups_list()
...
don't calculate all hosts for every parent group of every group
when that parent group was already in the cache
13 years ago
Serge van Ginderachter
dd9919342b
hide magic variables used bin/ansible output
...
'verbose_override' and 'verbose_always'
13 years ago
Serge van Ginderachter
5859af7285
script support for roles: use the files/ directory
...
instead of an additional scripts/ directory
13 years ago
Michael DeHaan
3a635d2d26
Lots of formatting fixes
13 years ago
Michael DeHaan
11792a9daa
Merge pull request #2987 from kentfrazier/sudo_user
...
Fix bug with include-level vars and sudo_user.
13 years ago
Michael DeHaan
84623441e1
Merge pull request #2945 from jsmartin/new_fetch
...
Fetch destination path can now be overriden.
13 years ago
Michael DeHaan
4fc6be8579
Merge pull request #2993 from SirScott/pkgng
...
Make pkgng and with_items result in a single module call.
13 years ago
Michael DeHaan
4b988dbd43
Merge pull request #2978 from bryanlarsen/basename
...
add basename and dirname to the core jinja2 filters
13 years ago
Michael DeHaan
27236cf598
Merge pull request #2998 from SirScott/runner-permissions
...
Ensure the tmp_path is sufficiently open.
13 years ago
Michael DeHaan
159ba7d68a
Merge pull request #2956 from akerl/unicodefix
...
ignore unicode errors in stdout
13 years ago
Michael DeHaan
98a4331107
Merge pull request #2999 from ngrilly/python
...
Python
13 years ago
Michael DeHaan
5fdca267ac
Merge pull request #3018 from dsedivec/devel
...
Plug-ins loaded from top-level plug-in directory
13 years ago
Serge van Ginderachter
94028852d9
Make debug module always verbose in playbooks
...
Created a new flag 'verbose_always' handled by
on_ok callback, similar to the 'verbose_override'
flag used by the setup module.
13 years ago
Dale Sedivec
611d56dc4c
Plug-ins loaded from top-level plug-in directory
...
PluginLoader._get_paths, as of 391fb98e , was only finding plug-ins that
were in a subdirectory of one of the basedirs (i.e. in a category
directory). For example, action_plugins/foo.py would never be loaded,
but action_plugins/bar/foo.py would work.
This makes it so that "uncategorized" plug-ins in the top level of a
directory such as action_plugins will be loaded, though plug-ins in a
"category" subdirectory will still be preferred. For example,
action_plugins/bar/foo.py would be preferred over action_plugins/foo.py.
13 years ago
Serge van Ginderachter
4c9ebe8522
Add roles support for the script module
...
allows to put scripts directly in a dir within the
role:
roles/<role>/scripts/..
Same as the copy and template module.
As requested in and closes #2969
13 years ago
Nicolas Grilly
75ceb80572
Escape args injected in new style modules
13 years ago
Scott Sturdivant
5516ece859
Ensure the tmp_path is sufficiently open.
13 years ago
Nicolas Grilly
7aee588918
Idiomatic Python: use in operator instead of method find
13 years ago
Nicolas Grilly
7babd30cf7
Idiomatic Python: use isinstance instead of type
13 years ago
James Martin
3c131dbd2b
Initial Commit.
13 years ago
Scott Sturdivant
d91bc1692e
Make pkgng and with_items result in a single module call.
13 years ago
Kent Frazier
4c6583bd00
Fix bug with include-level vars and sudo_user.
...
If a variable was provided for an include, in either of these ways:
---
- hosts: all
tasks:
- include: included.yml param=www-data
- include: included.yml
vars:
param: www-data
and then that param was used as the value of sudo_user in the included
tasks:
---
- name: do something as a parameterized sudo_user
command: whoami
sudo: yes
sudo_user: $param
you would receive a "failed to parse: usage: sudo" error back and the
command would not execute.
This seemed to be due to a missing call to template.template somewhere,
because the final value being passed through ssh was still `$param`.
After some digging, the issue seems to instead have been a problem with
providing the wrong context to the template for expansion. Inside the
`Task` logic, it was passing `play.vars` as the context, where
`module_vars` seemed more appropriate. After replacing it, my test case
above ran without issue. There was a comment above suggesting that the
template call might be unnecessary, but removing it made the original
error return, since it is not getting escaped later down the line. I
removed the comment since it was inaccurate.
I tried to actually incorporate my test case above into the test suite
as a regression test, but was unable to figure out how to structure it.
The existing test infrastructure seemed to only be testing for correct
number of counts in things (ok vs. changed, etc.), without regard for
whether the content generated by the command is correct. If there is an
example of a test similar to this one (where I would want to check the
JSON generated to make sure sudo_user had been converted), please let me
know and I will be happy to submit an additional patch.
13 years ago
Bryan Larsen
f629baef11
add basename and dirname to the core jinja2 filters
13 years ago
Michael DeHaan
753ebea186
Prefer categorized modules to uncategorized, such that if someone does an install on top of old content
...
the categorized modules will win over the 1.1 uncategorized modules, as the packages may not automatically
clean up the old content.
13 years ago
Michael DeHaan
cd57d59913
If ansible is configured to use a log file but cannot write to it, exit, but don't traceback.
13 years ago
Michael DeHaan
496f06c3c9
Pass variables to lookup function for those that want to use them.
13 years ago
Michael DeHaan
16709ecd76
Replace tab with spaces.
13 years ago
Dimos Alevizos
e96bc981ce
Set paramiko's logging level
...
Excplicity set paramiko's logging level to WARNING.
By default it inherits ansible's DEBUG logging level (set in
callbacks.py) and fills the log file with useless debug messages.
Obviously it only applies if log_path is set in ansible.cfg
13 years ago
Les Aker
1179d1bbd8
corrected indentation
13 years ago
Les Aker
2adc335481
ignore unicode errors in stdout
13 years ago
Maykel Moya
60f24bb077
Remove unused modules
13 years ago
Maykel Moya
f52e3dee70
Don't hardcode chroot executable path
13 years ago
Ben Ritcey
0938d4d89a
Allow the remote MD5 checks to be run via sudo
13 years ago
Michael DeHaan
8475a92dec
Merge pull request #2939 from mmoya/lookup-crypted-passwds
...
Add support for crypted passwords to password lookup
13 years ago
Stoned Elipot
94ba0f740a
Fix for issue #2916 : for each host promote the host variables as globally scoped variables for the sake of the groups determination
13 years ago
Maykel Moya
45f5447f9f
Fix name in copyright
13 years ago
Maykel Moya
96afc3f462
Add support for crypted passwords to password lookup
...
Added new parameter 'encrypt' with same semantics from that of
vars_prompt. When encryption is requested a random salt will be
generated and stored along the password in the form:
'<password> salt=<salt>'.
Also store passwords with an ending '\n' for easier looking at files
with console tools. File content was being already rstripped so this
is harmless.
13 years ago
Brian Coca
8dd72d2828
changed lockfile to be opened in write mode (solaris for one doesn't like
...
exclusive locks on read)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
f2a8c0d612
Fix listification inside of with_items so it runs more intelligently.
13 years ago
Michael DeHaan
161f3e3670
Merge pull request #2899 from sergevanginderachter/host-group-vars-no-subdirs
...
don't parse subdirs in host/group_vars
13 years ago
Michael DeHaan
ff3625b0c9
Merge pull request #2902 from timhabermaas/fix-grammatical-error
...
Fix grammatical error in error message
13 years ago
Serge van Ginderachter
7eeab168bc
bug fix in first_found search path assembly
13 years ago
Tim Habermaas
4d24faeeb1
Fix grammatical error in error message
13 years ago
Serge van Ginderachter
a6b827ca07
don't parse subdirs in host/group_vars
...
as those are not supported in
core vars_plugins/group_vars.py
but might be used by other vars_plugins
13 years ago
Michael DeHaan
2a091a3505
Remove duplicate import.
13 years ago
Michael DeHaan
a78edbb45c
More pep8
13 years ago
Michael DeHaan
50586928b2
No need for trailing semicolon.
13 years ago
Michael DeHaan
ea8302e68d
Indentation.
13 years ago
Michael DeHaan
9f47d13306
Misc identation.
13 years ago
Michael DeHaan
0a1657080b
Indentation fix
13 years ago
Michael DeHaan
3fdf15fa8a
template code fixes for 'make pep8'
13 years ago
Michael DeHaan
3afa8b373e
Improve check mode reporting for directories and file modes.
13 years ago
Michael DeHaan
05a4513a03
Merge branch 'group-by-global' of git://github.com/stoned/ansible into devel
...
Conflicts:
lib/ansible/runner/action_plugins/group_by.py
13 years ago
Michael DeHaan
11176c0711
Merge pull request #2878 from DavidMikeSimon/devel
...
Dealing with invalid symlinks and symlink permissions
13 years ago
Michael DeHaan
e4e6616169
Merge pull request #2872 from tima/fuzzy-match-localhost-127
...
Adds fuzzy matching of localhost to 127.0.0.1 host entries and vice versa
13 years ago
Michael DeHaan
344a30938c
Merge pull request #2871 from tima/inv-host-entry-fix
...
Fixed bug where a host entry in the inventory represented as a dict w/o ...
13 years ago
Matt Coddington
542eeeb5d6
add option to ignore $legacy variable style substitution
13 years ago
Michael DeHaan
ad777f6538
Fix contrib link.
13 years ago
Stoned Elipot
75100201a2
Allow globally scoped variables with group_by module's conditionals and key argument
13 years ago
David Simon
190ce16bab
Dealing with invalid symlinks and symlink permissions
13 years ago
Timothy Appnel
20bf5f130d
Adds fuzzy matching of localhost to 127.0.0.1 host entries and vice versa.
13 years ago
Timothy Appnel
b15cc3e2b4
Fixed bug where a host entry in the inventory represented as a dict w/o a hosts or vars key was treated as a group and its vars essentially ignored.
13 years ago
Michael DeHaan
d1d3f4b4d2
Merge pull request #2842 from bcoca/cleanup
...
generalized cleanup and removed atomic_move return
13 years ago
Brian Coca
3ac6c45499
generalized cleanup function, in case modules want to use
...
removed return code as it doesn't make sense anymore
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
f87ac5ce29
Merge pull request #2841 from jimi1283/issue_2820
...
BUGFIX - --start-at-task= works only with --step
13 years ago
Michael DeHaan
9ed177e25e
Merge pull request #2840 from toshywoshy/devel
...
Patch so that delegate_to also uses ansible_ssh_private_key_file
13 years ago
James Cammarata
2440861b1b
BUGFIX - --start-at-task= works only with --step
...
From issue #2820 , --start-at-task does not actually run tasks
unless --step is specified. This appears to be because skip_task
is being evaluated as True in PlayBook._run_task(). This patch
ensures skip_task is set to False in the callback.
13 years ago
Toshaan Bharvani
62b53f4d2c
changed the delegate_to to also use ansible_ssh_private_key_file from the inventory file
13 years ago
Gilles Cornu
68f7ea6099
Apply Gilles's patch to atomic_move based on github comment. (Email address not supplied
...
since wasn't from a pull request)
13 years ago
Brian Coca
bdeb370d79
fixed case in which move fails after remote user copies file and sudo to non root does the move
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
c3547a2308
Moar SELinux.
13 years ago
Michael DeHaan
fb7bfa61a9
Fix SELinux context on atomic_move
13 years ago
Michael DeHaan
4ecc7ea2e0
Merge pull request #2817 from sfromm/issue2810
...
Set selinux context on file after shutil.move in atomic_move()
13 years ago
Serge van Ginderachter
53a7ab74c8
use os.path.join instead of hardcoded unix separator in first_found lookup plugin
13 years ago
Stephen Fromm
50e94e4a2f
Set selinux context on file after shutil.move in atomic_move()
...
This is intended to fix #2810 . It sets the context of the tmp_dest file
after shutil.move() operation and before os.rename(). This should
retain the selinux context of the file across moves.
13 years ago
Michael DeHaan
7117ca5395
Allow modules in a "./library" directory to be referenced by their shortforms "modulename:" instead of just "action: modulename"
13 years ago
Michael DeHaan
e90023281d
Slightly refine log output to include username in addition to pid.
13 years ago
Michael DeHaan
ba8f2fca26
Merge branch 'add_pid_to_logging' of git://github.com/mcodd/ansible into devel
13 years ago
Stoned Elipot
df3c4849e9
Also load Jinja2 extensions when processing template from string
13 years ago
Michael DeHaan
4bea9a612f
Don't use "finally" here as it's not 2.4 compliant.
13 years ago
Michael DeHaan
68f711d5ae
teach plugin loader to find modules in subdirectories
13 years ago
Michael DeHaan
391fb98ee2
Allow modules to be categorized, and also sort them when generating the documentation.
13 years ago
Michael DeHaan
a81089231e
Register skipped tasks so we can at least check their changed/not-changed status.
13 years ago
Kahlil (Kal) Hodgson
9f90f0e856
fix arguments to isinstance() in env lookup
13 years ago
Matt Coddington
3b8f69bac8
add pid to log
13 years ago
Stoned Elipot
75b51f79b4
Add module path library/ if it exists in role directory
13 years ago
Michael DeHaan
75cf5c985b
Allow playbook tags to be comma seperated strings as well as lists
13 years ago
Michael DeHaan
bcac289667
Cows don't need to display brackets around strings.
13 years ago
Michael DeHaan
016b04dff1
Merge branch 'roles_dir_search_order' of git://github.com/mcodd/ansible into devel
13 years ago
Brian Coca
caf6bd6ce5
Changed atomic_replace to atomic_move, now ti DOES move atomically in the last
...
step
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
b8fdcff524
Merge branch 'nocows' of git://github.com/jpmens/ansible into devel
...
Conflicts:
lib/ansible/callbacks.py
lib/ansible/constants.py
13 years ago
Michael DeHaan
553751aee1
Merge branch 'numeric_ids_refactor' of git://github.com/insom/ansible into testing_427
13 years ago
Michael DeHaan
aa55268514
Adds a logfile for ansible playbooks that can be set by the environment or configuration file.
13 years ago
Michael DeHaan
515fbd5a17
Restructure output to prevent rare cases of interlaced I/O in multiprocessing paths.
13 years ago
Matt Coddington
c164609dd6
typo fix
13 years ago
Matt Coddington
c83c534a7d
Search for roles in the roles subdir first. Throw an error when no role .yml files are found.
13 years ago
Michael DeHaan
5af271911b
Fix duplicate handler notification issue in 1.2 devel
13 years ago
Michael DeHaan
224e20ca60
complex_arg templating should be smarter. Make it so!
13 years ago
Aaron Brady
bd226eb826
Refactor user_and_group so it works off of numbers
...
There are various cases where a UID to username to UID mapping breaks
down. One UID can be used by two usernames, or no username. If we
always use UIDs internally, then these ambiguous cases won't be a
problem.
13 years ago
Aaron Brady
d2e457f81f
Accept numeric user and group parameters
13 years ago
Jeroen Hoekx
ac7a632711
Remove leftover debug statement in template code.
13 years ago
Michael DeHaan
21fe750cef
Flush handlers before pre and post task sections change, but not between task and roles, as this seems
...
to be confusing to people (and not usually neccessary)
13 years ago
Michael DeHaan
6fdfbb1a34
Improve variable smushing so it only has to be done in one place. This is related to shlex.split being called
...
on untemplated variables in some rare cases.
13 years ago
Michael DeHaan
af2fb56a10
Changes to allow WANT_JSON to allow JSON to non-Python modules
13 years ago
Stephen Fromm
189b210f5a
Catch exception when logging to systemd journal fails
...
systemd journal will throw IOError exception when journal.sendv() fails.
This catches that and falls back to syslog. See issue #2773 .
13 years ago
Jan-Piet Mens
dfd885a012
Make ANSIBLE_NOCOWS configurable
...
nocows = 1 in ansible.cfg
or old environment variable ANSIBLE_NOCOWS=1
add to ansible.cfg example
13 years ago
Michael DeHaan
bd0c22868e
With fileglob should return full paths as in 1.1
13 years ago
Michael DeHaan
35e61d8f16
Merge pull request #2688 from dagwieers/module-global
...
New module 'set_fact' to define host facts
13 years ago
Michael DeHaan
be947e5266
Resolve merge conflict
13 years ago
Michael DeHaan
9871707998
If sudoing and the sudo user is not root, the original file is saved as you, therefore delete that file as you.
13 years ago
Michael DeHaan
e12f91799c
Allow args: var to be used to pass a variable in bare, and also templated versions should also DWIM.
13 years ago
Michael DeHaan
6c778acd91
Smush the braces in various places (hey, that rhymes) to avoid undo key=value splitting surprises
...
in new template system.
13 years ago
Michael DeHaan
5cced79cf3
Allow variables to be used raw in with_nested
13 years ago
Michael DeHaan
fbea88b9d9
Allow the environment string to be referenced by a bare variable name like:
...
environment: foo
13 years ago
Michael DeHaan
f9f1d5ee42
Merge pull request #2745 from sfromm/issue2742
...
Fix test so that it is /bin/sh compliant (issue #2742 )
13 years ago
Stephen Fromm
ab3cb4912e
Fix test so that it is /bin/sh compliant (issue #2742 )
...
The old test used syntax that appeared to be bash-specific and did not
work on platforms where /bin/sh did not point to bash. See issue #2742
where copy to solaris hosts failed with the error:
output: {'stdout': '', 'stderr': '/bin/sh: test: argument expected\n',
'rc': 1}
13 years ago
Michael DeHaan
3e0c33c1fa
Empty plays should still gather facts
13 years ago
Michael DeHaan
b08181e9b4
Merge pull request #2731 from stoned/flush_handlers-cleanup
...
handlers must be run once
13 years ago
Michael DeHaan
08324cb5d7
Allow play tagging in context of new meta-tasks.
13 years ago
Stoned Elipot
747c7f0dff
handlers must be run once
...
so remove all occurences of each host from the handlers notified by
lists
13 years ago
Michael DeHaan
32fb6c807c
Allow handlers to run in between pre_tasks, roles, tasks, and post_tasks.
13 years ago
Michael DeHaan
37789a852a
Rename set_up and tear_down to pre_tasks and post_tasks
13 years ago
Michael DeHaan
d7623d1f91
Added a 'set_up' and 'tear_down' which are like tasks, but execute before and after roles.
13 years ago
Michael DeHaan
e6bf01a6b0
Make plugin loader path operations more efficient.
13 years ago
Michael DeHaan
5a8dff5bce
Instantiate inventory plugins only once for efficiency reasons.
13 years ago
Michael DeHaan
817b0cdc80
Instantiate filter plugins only once to save some efficiency.
13 years ago
Michael DeHaan
6e1514e975
Merge pull request #2727 from dsedivec/devel
...
Don't send unicode instances to the selinux module
13 years ago
Michael DeHaan
5b44c3d52c
Merge commit '53ac0bb' into devel
13 years ago
Michael DeHaan
87788b1d17
Ignore inventory config files when using an inventory directory.
13 years ago
Michael DeHaan
53ac0bbec2
Instantiate callback plugins only once so we can set play/task objects on them and they'll stick.
13 years ago
Dale Sedivec
c8f4a56cad
Don't send unicode instances to the selinux module
...
This fixes #2632 . Briefly: specifying things like paths using complex
args in a playbook will make the objects unicode instances. The selinux
module does not accept unicode instances for its char * arguments; it
wants str instances.
Per mpdehaan's comment on #2632 I just went ahead and converted all
paths to UTF-8. I don't know if it would be better to do something like
converting to locale.getpreferredencoding(), but I factored all the
conversions out into new method _to_filesystem_str, so there's only one
place that needs to be changed in the future.
13 years ago
Michael DeHaan
df93d7dd97
Ignore inventory config files when using an inventory directory.
13 years ago
Michael DeHaan
8e7dc3c79c
Remove an extra space in the module execution line if no environment was set.
13 years ago
Dag Wieers
b13beb3689
New module 'set_fact' to define host facts
...
This module allows you to set host facts (or export play variables to the playbook scope if you fancy that).
The module also accepts complex arguments.
```yaml
- action: set_fact fact="something" global_fact="${local_var}"'
- action: set_fact
args:
fact: something
global_fact: ${local_var}
```
13 years ago
Seth Vidal
7b8cec3f59
clean up first_found to fix a few issues:
...
- add a skip option so it won't raise an exception if you don't match anything
- make it work as a drop-in replacement for first_available_file
- document in the module comments all of the above cases
13 years ago
Michael DeHaan
5f1e2afc34
Revert "make atomic_replace use shutil.copy2 instead of os.rename() so it will work across filesystems".
...
AR function was leaving some tmp files behind, want to revert, will have better implementation soon, this is the old way now.
This reverts commit f74a1fa4f0 .
13 years ago
Michael DeHaan
d8bf87b008
(A) include errors in inventory scripts should they occur.
...
(B) allow registration with ignore_errors: True
13 years ago
Bernhard Weitzhofer
fb0a99e5d8
Fix if-statement that always evaluates True
13 years ago
C. Morgan Hamill
88eb5516eb
Fix 'sequence' plugin error.
...
If 'terms' is a string, replace it with a single item list.
13 years ago
C. Morgan Hamill
663d37b537
Fix errors in lookup plugins.
...
Lookup plugins 'sequence' and 'template' now import 'ansible.utils'
appropriately in order to use the 'listify_lookup_plugin_terms'
function.
Also, 'dnstxt' and 'env' now check to see if 'terms' is a string;
without this calls like '{{ lookup('env', 'HOME') }}' fail.
13 years ago
Dale Sedivec
515fd9e915
copy action plug-in check mode respects force=no
...
The copy action accepts force=no, which tells it not to replace an
existing file even if it differs from the source. The copy action
plug-in wasn't respecting this option when operated in check mode, so it
would report that changes are necessary in check mode even though copy
would make no changes when run normally.
Runner._remote_md5 was changed to make the logic for setting rc perhaps
a little more clear, and to make sure that rc=0 when the file does not
exist.
13 years ago
Michael DeHaan
7c6341718e
Merge branch 'combine_vars' of git://github.com/laggyluke/ansible into exp
...
Conflicts:
lib/ansible/inventory/vars_plugins/group_vars.py
lib/ansible/runner/__init__.py
lib/ansible/utils/__init__.py
test/TestPlayBook.py
13 years ago
C. Morgan Hamill
863cb50530
Allow '.yml'/'.yaml' extension on group_vars files.
...
Look for a file with the base name of the group/host, first without
a file extension, then with a '.yml' extension, and, finally, with
a '.yaml' extension, loading vars from only the first one found.
13 years ago
Michael DeHaan
b54e955595
Remove a debug statement.
13 years ago
Michael DeHaan
86d47bce5f
Make more lookup plugins tolerant of new variable system, with a little better 'do what I mean' logic to resolving
...
what happens if you get a string back as a template result.
13 years ago
Michael DeHaan
c0f8af5202
Make more lookup plugins happy with newstyle variables. Not quite done, but this fixes up with_items/with_nested/file/fileglob.
13 years ago
Seth Vidal
f74a1fa4f0
make atomic_replace use shutil.copy2 instead of os.rename() so it will
...
work across filesystems
13 years ago
Michael DeHaan
0944e7d56a
Make less template calls on playbook objects.
13 years ago
Michael DeHaan
44a9352338
Also template handlers only at the end.
13 years ago
Michael DeHaan
e7f5186dec
Merge pull request #2623 from willthames/when_set_bug
...
Prevent premature variable substitution in tasks
13 years ago
Michael DeHaan
3ab0ed5fd4
Allow 'when' and 'with_items' to be applied to roles.
13 years ago
Michael DeHaan
7a2d493e67
Teach lookup plugins that if they can't evaluate something they can wait and do it later.
13 years ago
Michael DeHaan
3f3b2a9448
Smush Jinja2 braces in playbooks so unresolved variables get parsed nicely
13 years ago
Michael DeHaan
7037023aa8
Make debug print things nicer if {{ foo }} didn't interpolate
13 years ago
Michael DeHaan
793a3d3f76
More 1.2 templating development; for legacy when_string constructs don't quote the 'in' operator
13 years ago
Michael DeHaan
85099be48f
Merge pull request #2656 from dstoflet/first_available_file_fix
...
Quick fix for first_available_file and role support
13 years ago
Michael DeHaan
b8c5a58b7f
Avoid running through the legacy template code if no dollar signs are in strings.
13 years ago
Michael DeHaan
251f19263c
Remove unneeded import.
13 years ago
Michael DeHaan
8457cf433d
Update pause module to not use utils.template
13 years ago
Darryl Stoflet
c63207bf75
Quick fix for first_available_file and roles
13 years ago
willthames
377bc31311
Prevent premature substitution of variables into tasks
...
As documented in #2623 , early variable substitution causes when_
tests to fail and possibly other side effects.
I can see the reason for this early substitution, likely introduced
in 1dfe60a6 , to allow many playbook parameters to be templated.
This is a valid goal, but the recursive nature of the utils.template
function means that it goes too far.
At this point removing tasks from the list of parameters to be
substituted seems sufficient to make my tests pass. It may be the
case that other parameters should be excluded, but I suspect not.
Adding a test case. I would prefer to analyse not just the aggregate
statistics but also whether the results are as expected - I can't
see an easy way to do that with the available callbacks at present.
13 years ago
Michael DeHaan
a05361f515
This is a fix on top of the 'airplane variable upgrade' commits that fixes legacy when_string so it evaluates correctly in the new eval construct.
13 years ago
Michael DeHaan
3e736eaf00
Merge pull request #2622 from skvidal/playbook-start-at-task
...
implement --start-at-task option to hop to a specific task before starti...
13 years ago
Michael DeHaan
4e79bd0872
Remove unneccessary construction of Jinja2 environment object.
13 years ago
Michael DeHaan
2f5c1d3788
Merge pull request #2629 from stoned/fix-jinja2-filters-init
...
Fix Jinja2 filter plugins initialization
13 years ago
Michael DeHaan
11a819cc4b
Merge pull request #2631 from stoned/templates-filters-base64
...
Add base64 encode and decode filters to templates
13 years ago
Michael DeHaan
a6777f7e7c
Fix template call in group_by module.
13 years ago
Michael DeHaan
7931597a6a
Fix template call.
13 years ago
Michael DeHaan
695acc2de0
Make lookup plugins accessible in templates
13 years ago
Michael DeHaan
5b2035edd9
Changes for 'make pep8'
13 years ago
Michael DeHaan
81a926547c
Some continued work on new-style templates and associated test code changes. Legacy template functions
...
are marked with "legacy_" for possible future removal.
13 years ago
Michael DeHaan
f0b21dcc0f
allow references to names of variables in with_items without needing to surround them with Jinja2 '{{' delimeters
13 years ago
Michael DeHaan
9ac25bb8f6
Minor formatting
13 years ago
Michael DeHaan
d7206d84bb
Allows Jinja2 that starts a YAML line to not cause a syntax error.
...
Technically this isn't quite valid YAML when this happens, so we make it valid. This means that if a future commander
API allows save/load it should make sure it does similar processing.
13 years ago
Michael DeHaan
b09ef21ec9
Add code to flag legacy templating like $foo.{bar} as deprecated in favor of Jinja2 {{ foo.bar }} so we
...
can remove the legacy system at a later date.
13 years ago
Michael DeHaan
804056a563
Use Jinja2 strict undefined in string templating to allow the default filter to be used.
13 years ago
Michael DeHaan
998230a84a
Allow $foo and {{ bar }} to be used on the same line in playbooks.
13 years ago
Michael DeHaan
29209c4913
Style fixes so "make pep8" is clean.
13 years ago
Michael DeHaan
0113951580
Enable usage of when_set within new eval system.
13 years ago
Michael DeHaan
a83e10d77d
Use safe_eval vs eval.
13 years ago
Michael DeHaan
fecfbf9226
Allow jinja2 evals that produce lists to be used in with_items. Ideally want something a bit less heavy
...
than the eval here.
13 years ago
Michael DeHaan
c5d9823467
Fix some items related to playbook includes and indentation.
13 years ago
Stoned Elipot
0893562605
Add base64 encode and decode filters to templates
13 years ago
Michael DeHaan
290780d13f
Playbook + with_items was an undocumented feature that was causing problems because it would
...
evaluate and replace '$item' with ''. Really it doesn't make sense to include multiple playbooks
via a loop variable, as you can do this with task + with_items already (and it's a simpler code
path). Given this is undocumented, this removes that feature, and we'll consider next how to
also add 'with_items' support directly to roles.
13 years ago
Michael DeHaan
c64f19dc5f
Don't set the item variable as eager template replacement will over-replace the variable as an empty string.
13 years ago
Stoned Elipot
154f58f82d
Fix Jinja2 filter plugins initialization
...
_get_filter_plugins() checks FILTER_PLUGINS against None hence
the latter should be initialized to None.
13 years ago
Seth Vidal
690738ea32
implement --start-at-task option to hop to a specific task before starting running them
13 years ago
willthames
9d87733f98
Test case and fix for shlex.split unicode bug
...
When operating on a unicode string in python 2.6, shlex.split returns
a result that does not work with the file constructor.
To reproduce this requires a task include that is templated (this is
because the templated string is a unicode result, whereas a non-
templated string is a non-unicode string)
[will@centos6.3] $ python
Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23)
[GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import shlex
>>> shlex.split(u'abc')
['a\x00\x00\x00b\x00\x00\x00c\x00\x00\x00']
[will@fedora17] $ python
Python 2.7.3 (default, Jul 24 2012, 10:05:38)
[GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import shlex
>>> shlex.split(u'abc')
['abc']
The proposed fix (coercing the include parameters to string before the
shlex.split) may not be ideal but it does fix the bug for my test case.
13 years ago
Michael DeHaan
61f2668b0a
Don't include the '.yml' in the path to the retry files.
13 years ago
Michael DeHaan
0d530f3bf0
Change the retry logic to write a limit file, able to source limit from files by indicating with @filename
13 years ago
Michael DeHaan
c695aa2d6a
When playbooks fail, attempt to create an inventory file in the inventory directory that allows rerunning
...
of the playbook against only the hosts that failed.
13 years ago
Michael DeHaan
5fef2ffb9d
Merge pull request #2592 from stoned/include-task-when
...
when: condition support for tasks include
13 years ago
Michael DeHaan
00252353b9
Decided I liked the asterisks
13 years ago
Michael DeHaan
bc0be456da
Modify output banners to have constant length and use dashes instead
...
of "-" to be less visually heavy (unless cowsay is installed of course)
13 years ago
Stoned Elipot
1ed54b9b3a
when: condition support for tasks include
13 years ago
Michael DeHaan
e9d11173cd
Remove obsolete comment
13 years ago
Michael DeHaan
fffb1a0a9d
Loose tasks not in roles get executed after roles.
13 years ago
Michael DeHaan
f044fc344b
When using roles, or other includes, the path to DWIM inside is the path of the task include
...
file.
13 years ago
Sébastien Bocahu
b94bf051d5
Makes $PIPE and $FILE macros accept utf-8 input
13 years ago
Michael DeHaan
5c4ed72571
Demo of parameterized roles!
13 years ago
Michael DeHaan
f308194b9a
Added examples of how roles work!
13 years ago
Michael DeHaan
892484812e
Much requested feature -- allows relative imports of content within roles or relative to any task or handler include (../templates for template ../files for copy)
13 years ago
Michael DeHaan
95f30f0def
Complete streamlining of vars handling in playbooks and how those are templated to avoid
...
repeat template calls at playbook intialization time.
13 years ago
Michael DeHaan
1dfe60a6ea
Allow any parameter in a play to be set by --extra-vars through cleaner use of data structure
...
templating.
13 years ago
Michael DeHaan
4cd69e81b9
Catch recursive templating errors and display what string caused them.
13 years ago
George Miroshnykov
6826aa7360
Tweaked merge_hash to also affect Runner behavior
13 years ago
Blair Zajac
36b3fc3acf
Fix for inventory scripts with no path prefix that are in CWD.
...
Without this, using '-i ec2.py' will not work if '.' is not in PATH.
13 years ago
Michael DeHaan
f585c4cde7
Upgraded variable support met with upgraded conditional support, see examples/playbooks/upgraded_vars.yml
...
for details!
13 years ago
Michael DeHaan
38c2b14339
Undefined Jinja2 statements are returned as they originally are so you can tell there are things to
...
correct.
13 years ago
Michael DeHaan
49d28b9a44
This SELinux commit is too strict and we should only fail if trying to read/tweak SELinux attributes else
...
python-selinux can't be installed w/ the yum module when missing.
Revert "Added an extra check for target nodes with selinux but without libselinux-python package installed"
This reverts commit 550986b6a1 .
13 years ago
Michael DeHaan
2c881e2b3d
Merge pull request #2578 from arrfab/selinux-fix-2
...
Added an extra check for target nodes with selinux but without libselinux-python package installed
13 years ago
Michael DeHaan
9073aa17ab
Chroot also needs args/kwargs.
13 years ago
Michael DeHaan
3d25b4a7c0
Standardize args/kwargs on connection plugins.
13 years ago
Dag Wieers
d5d26bab9b
Make private key customizable per host using ansible_ssh_private_key_file configurable as variable
...
This fixes issue #1026 for @toshywoshy together with ansible_ssh_user and ansible_ssh_port.
13 years ago
Fabian Arrotin
550986b6a1
Added an extra check for target nodes with selinux but without libselinux-python package installed
13 years ago
Michael DeHaan
8c859f6f61
Merge pull request #2570 from skvidal/devel
...
simple fix for issue 2564
13 years ago
Michael DeHaan
550bf47636
Merge pull request #2565 from willthames/default_exec
...
Added DEFAULT_EXECUTABLE as a constant
13 years ago
Michael DeHaan
f37da4fdd7
Merge branch 'ssh_config_user_overrides' of git://github.com/bcoca/ansible into devel
13 years ago
Michael DeHaan
b67cd6bbda
Merge branch 'any-errors-fatal' of git://github.com/junegunn/ansible into devel
13 years ago
Seth Vidal
2796b5ee2a
simple fix for issue 2564
...
when we encounter a group we've not seen before - we need
to make sure we make it a subgroup of 'all', no matter what
13 years ago
willthames
e55e123c01
Added DEFAULT_EXECUTABLE as a constant
...
Use DEFAULT_EXECUTABLE when no executable is passed to
_low_level_command_exec
Works as a standard constant - can be overridden in all the normal ways
and defaults to /bin/sh
Motiviation is for a user that only has /bin/bash in /etc/sudoers
13 years ago
Michael DeHaan
cdaa2085ee
Preliminary ability to use Jinja2 {{ }} to replace ${foo.bar} in playbooks. Can't use both at the same time per line.
13 years ago
Michael DeHaan
aa4ad80bda
Update release version.
13 years ago
Junegunn Choi
b874027b36
compare the number of available hosts before and after running each task
13 years ago
Junegunn Choi
20a48c6bdf
terminate immediately on a failure
13 years ago
Brian Coca
82c3b4e685
now ssh connection plugin will only pass user as an option to ssh if it is
...
differnt from the current user. This should enable overrides for user in
.ssh/config w/o breaking any current functionality.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
42b0e51223
Upgrade callbacks further, now '.play', '.task', and so on are also available!
13 years ago
Michael DeHaan
0d11f53eff
Let the callbacks see the playbook and (current) runner objects.
13 years ago
Michael DeHaan
783a12cc0e
Resolve merge commit.
13 years ago
Michael DeHaan
3c5890f42b
Ensure that when transferring a file to a directory the name of the file is the correct basename and not 'source'.
13 years ago
Michael DeHaan
7044e53e07
Allow conditionals on BYPASS_HOST_LOOP plugins like add_host
13 years ago
Michael DeHaan
9be44c201a
Merge pull request #2455 from robparrott/debuggin-help
...
inject a dictionary of avaiable variables and the environment into executor
13 years ago
Michael DeHaan
fe2f506514
Merge pull request #2462 from sfromm/issue2461
...
Make logging to journal match what goes to syslog on non-systemd hosts
13 years ago
Stoned Elipot
86995d7786
Fix pathnames in comments
13 years ago
Stephen Fromm
cdb7f8ecf0
Make logging to journal match what goes to syslog on non-systemd hosts
...
This makes the log message the same, whether it is sent to systemd's
journal or to syslog. It retains the extra fields that are passed to
journal, such as MOUDLE=<name> and additional arguments. Since journal
will reflect messages to syslog, this keeps what goes to syslog
informative instead of the terse 'Ansible module invoked'.
See issue #2461 .
13 years ago
Rob Parrott
149f1f9f3c
invalidate group cache so that a group added by the add_host module will be relfected in the groups variable in later plays.
13 years ago
Rob Parrott
81e2d871aa
inject a dictionary of avaiable variables and the environment into the executor, so that templates can be used to debug playbooks by dumping more of the available context.
13 years ago
David Hughes
c365974117
Added variable expansion to task sudo_user parameter
13 years ago
Michael DeHaan
6f25885c1a
Merge pull request #2397 from dparalen/play_task_type_check
...
check type of task explicitly
13 years ago
milan
80dbab3cf0
check type of task explicitly
13 years ago
Daniel Hokka Zakrisson
27978ed9c1
Don't override argument specs with FILE_COMMON_ARGUMENTS
...
Doing so will remove aliases, types, etc, leading to #2388 and other
issues.
13 years ago
Michael DeHaan
d0332a6c6d
Merge branch 'playbook-step' of git://github.com/skvidal/ansible into devel
13 years ago
Michael DeHaan
0c80c76833
Fixes #2380 - argument checking in file accepts chained arguments from copy
13 years ago
Michael DeHaan
77198b09e9
Add content to the list of file common arguments.
13 years ago
Stoned Elipot
8edda38c61
exception safe list/tuple replacing for non-str values
13 years ago
Michael DeHaan
e241bb5801
Merge pull request #2367 from bcoca/catch_mismatched_json
...
now cleanly catches traceback when conflicting versions of simplejson and python are installed
13 years ago
Michael DeHaan
a22009806e
Nested iteration would make more sense in this order.
13 years ago
Michael DeHaan
edc04d61f3
Added 'with_nested' lookup plugin that can easily do nested loops.
13 years ago
Michael DeHaan
298d64aa1d
Quote remote md5 operations. Fixes #2368
13 years ago
Michael DeHaan
e304cc3d8e
Simple fix for spaces in filenames with the template module.
13 years ago
Michael DeHaan
6e2ea327d1
A very simple fix to enable spaces in the files sent via the copy module.
13 years ago
Brian Coca
95a977cfc9
now cleanly catches traceback that occurs when running newer simplejson with
...
older python interpreter.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Seth Vidal
a7a083d882
when --step isn't specified make sure to print the banner
13 years ago
Seth Vidal
7687c2caf8
add --step option to ansible-playbooks to let people step through a playbook
...
one by one - asking for confirmation along the way.
also allows to 'continue' after a certain point
13 years ago
Michael DeHaan
2962073bcf
Merge branch 'fix-module-encoding' of git://github.com/andreparames/ansible into devel
13 years ago
Michael DeHaan
f2c8df2a93
Clarify an error message
13 years ago
Patrick Pelletier
c7c7a63ee5
Add support to directly set content in copy module
13 years ago
Michael DeHaan
c53653dc0d
Merge pull request #2348 from candeira/password-plugin
...
password lookup plugin, with working tests and documentation
13 years ago
Michael DeHaan
b2c8ed9cc2
Merge pull request #2279 from dorfsmay/fetch-fail_on_missing
...
Added a fail_on_missing option to fetch.
13 years ago
Michael DeHaan
aae88baf4a
Merge pull request #2260 from skvidal/path_lookup
...
first_found lookup_plugin - replaces first_available_file
13 years ago
Michael DeHaan
bb696e88b4
Merge pull request #2286 from gavares/url_timeout
...
Add socket timeout to uri module.
13 years ago
Javier Candeira
ca6c36e1ac
password lookup plugin, with working tests and documentation
13 years ago
André Paramés
9bb8435ec9
Fixes #2346
13 years ago
Daniel Hokka Zakrisson
76f3351b02
Move complex_args templating to be with module_args
...
Keeps every action plugin from having to do the same thing.
13 years ago
Michael DeHaan
ffbd4b5a2c
Template options sooner on complex args copy
13 years ago
Michael DeHaan
2bb305f6d5
Fix args templating for complex args with the copy module.
13 years ago
Michael DeHaan
969edabdbb
Merge pull request #2322 from bcoca/remote_tmp_override
...
added check for starting $HOME for remote_tmp so as to non root sudo override
13 years ago
Michael DeHaan
44e44cf295
Merge pull request #2320 from jkleckner/minor-spelling-fixes
...
Minor spelling fixes
13 years ago
Michael DeHaan
fe8547cac0
Ensure template arguments if complex are still properly templated
13 years ago
Brian Coca
76f709286e
added check for starting $HOME for remote_tmp so as to non root sudo override
...
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
13 years ago
Jim Kleckner
92844d3dcd
Minor spelling fixes
13 years ago
Maykel Moya
e898f30f78
Fix copyright
13 years ago
Daniel Hokka Zakrisson
3d49f74df6
Make apt upgrade=dist work and make its argument handling more idiomatic
...
Fixes #2287 .
13 years ago
Daniel Hokka Zakrisson
1784fd80cc
When a host list is used, no parser is present
13 years ago
Grant Gavares
cd51c7f234
Add socket timeout to uri module.
...
The uri module can be configured to abort after a specified timeout if
it cannot connect to the configured uri. This prevents a uri action from
hanging indefinitely when the remote endpoint cannot be reached because
it is unavailable, there is a firewall in place etc. The default behavior
is left unchanged: timeout=None
This change also introduces a new type for module_parameters: int
Code was added to perform conversion from string -> int type in
module_common.py.
The new type was required in order to play nice with httplib2 which
refuses to accept (and convert) anything other than a numeric type for
the timeout value.
13 years ago
Yves Dorfsman
e45a0fd61d
Added a fail_on_missing option to fetch.
13 years ago
Michael DeHaan
6ad390a92b
Revert "Revert "for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups""
...
This reverts commit dc0515a88a .
We didn't need to revert this :)
13 years ago
Daniel Hokka Zakrisson
5d82b4b1b7
group_by needs the untemplated module_args
13 years ago
Michael DeHaan
dc0515a88a
Revert "for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups"
...
This reverts commit 2d86671aa5 .
13 years ago
Daniel Hokka Zakrisson
43ce2caa4f
Fix parse_kv invocation in group_by to use imported name
...
Fixes #2277 .
13 years ago
Daniel Hokka Zakrisson
2ff2f05a0f
host.get_variables includes too many variables, use host.vars instead
...
Not quite as attractive, but allows variable precedence and lazy
resolution to work as intended, rather than resolving them on a
per-inventory basis.
13 years ago
Michael DeHaan
0b4ad2749a
Increase error handling in the unlikely case of failing to establish a connection.
13 years ago
Michael DeHaan
5fd807ac64
Merge pull request #2262 from bcoca/json_nice_error
...
now ansible shows nice message about missing json instead of traceback
13 years ago
Brian Coca
46c913f7a6
now ansible shows nice message about missing json instead of traceback
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan
7ac5e462ef
Fixed a small buglet, if using with_items with yum and so on, only optimize the package list if the package list is all strings
13 years ago
Seth Vidal
804b130288
check if the term is a dict so we can take a simple list of files (like first_available_file) takes
13 years ago
Michael DeHaan
b6f7a22de5
Merge pull request #2261 from bcoca/groupby_2186
...
now group by module invalidates host cached variables
13 years ago
Brian Coca
2d86671aa5
for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups
...
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
13 years ago
Seth Vidal
dfad94078b
first_found lookup_plugin - replaces first_available_file
...
- useful in tasks/playbook inclusion
- task-specific inclusion
allows searching paths and files
13 years ago
Daniel Hokka Zakrisson
f1eb195ff5
vars_loader should get the path to the inventory + vars_plugins
13 years ago
Daniel Hokka Zakrisson
ad08995989
Make inventory basedir for directory based inventory be the directory
...
This puts host_vars and group_vars inside of the directory, allowing you
to target a single inventory but still have access to the variables.
13 years ago
Daniel Hokka Zakrisson
d9c6b60b24
Allow inventory to be a directory containing other inventories
13 years ago
Daniel Hokka Zakrisson
647cd0141c
Move all inventory script code into the script parser
13 years ago
Michael DeHaan
fb26f059c5
Merge pull request #2232 from dhozac/module-args-dict
...
Allow specifying args directly to actions using module: syntax
13 years ago
Michael DeHaan
e83819599a
Merge pull request #2234 from akvadrako/nice-yaml-and-json
...
add to_nice_yaml|json filters
13 years ago
Michael DeHaan
c92bfb7234
Merge branch 'madcow2' of git://github.com/bcoca/ansible into devel
13 years ago
Jimmy Tang
81a34c2d1d
Cowsay on OSX macports
13 years ago
Devin Bayer
fca1167a0e
add to_nice_yaml|json filters
13 years ago
Daniel Hokka Zakrisson
ae8d6ac303
Ensure complex_args is considered in all action_plugins
13 years ago
Daniel Hokka Zakrisson
297259725a
Allow (local_)action: to be a dict
...
Use the key module: to set which module to invoke.
13 years ago
Daniel Hokka Zakrisson
c04d5ba739
Allow specifying args directly to actions using module: syntax
...
Makes things like
- name: do complex things with complex module
complex:
setting_a: true
setting_b:
- foo
- bar
possible.
Fixes #2228 .
13 years ago
Daniel Hokka Zakrisson
4807fbc8b7
Use regular strings to allow tests to work
13 years ago
Michael DeHaan
323ed27106
Merge pull request #2221 from sfromm/fix-ansible-cli-check-mode
...
Fix CliRunnerCallbacks.on_file_diff in callbacks.py
13 years ago
Stephen Fromm
fa07604d43
Fix CliRunnerCallbacks.on_file_diff in callbacks.py
...
When running ansible -C, I get a traceback that ends with
AttributeError: Values instance has no attribute 'diff'
This fixes on_file_diff to behave similar to
PlaybookRunnerCallbacks.on_file_diff().
13 years ago
Daniel Hokka Zakrisson
cedfec763a
jsonify needs to return a string of {}, rather than a dict
13 years ago
Daniel Hokka Zakrisson
e4b72c0fd5
Revert to just escaping \ for JSON-args
13 years ago
Daniel Hokka Zakrisson
1601f0b4d7
Use repr to transfer JSON-arguments, so Python doesn't eat things
...
Fixes transferring newlines in args:, as well as """.
13 years ago
Daniel Hokka Zakrisson
bcf7a2c53a
Catch all exceptions coming from lookup plugins
...
Fixes using $TEMPLATE() and hostvars in a task without a name, among
other things.
13 years ago
Brian Coca
e9907e9c8a
added random cow pick through ANSIBLE_COW_SELECTION env var
...
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
13 years ago
Michael DeHaan
1366c663eb
Merge branch 'copy-diff-take2' of git://github.com/stoned/ansible into better_diff
...
Conflicts:
library/file
13 years ago
Daniel Hokka Zakrisson
93f02d614b
Merge pull request #2187 from dhozac/argument-type-check
...
Add type checking for module arguments, converting as much as possible
13 years ago
Stoned Elipot
8816dc7ca7
Make diff header lines more explicit about what the diff is about
...
This gives a more readable output when producing diff for a task
with multiple items (with_items).
13 years ago
Stoned Elipot
1b8c9bab35
Fix diff when template destination is absent
13 years ago
Daniel Hokka Zakrisson
22e40b6a61
Merge pull request #2198 from skvidal/nolog-params
...
No_log params
13 years ago
Stoned Elipot
10e9f1fc1e
Implement --diff for the copy module.
13 years ago
Seth Vidal
f02ea15f0c
command: make sure that all _handle_aliases() calls returns {}
...
module_common: also work if there are no aliases (shell, command, etc) modules
13 years ago
Seth Vidal
c95848ae59
- add an aliases attribute as a lookup of aliasname to canonical name
...
of parameters
- add support for no_log attribute per-parameter which will not log
that information to syslog
13 years ago
Daniel Hokka Zakrisson
e32fbd312f
Shell-quote environment contents
13 years ago
Daniel Hokka Zakrisson
27f3ba53f9
Remove debug print for environment
13 years ago
Daniel Hokka Zakrisson
1df56c07d3
If expand_lists is true, make lookup plugin result into a string
...
Fixes #2196 .
13 years ago
Daniel Hokka Zakrisson
7e0ee6809c
Don't template delegate_to too early, not all vars are available
...
Fixes using delegate_to: $item within a playbook include.
13 years ago
Daniel Hokka Zakrisson
f03e845920
Allow hyphens in complex variables
...
Primarily to support ${hostvars.hostname-with-hyphens.<var>}.
13 years ago
Shaun Zinck
e7719e4e46
pass in int() args to get_pty
...
If LINES or COLUMNS was set, get_pty was failing because it was
expecting an int value to be passed in.
13 years ago
Michael DeHaan
294e43ba2f
Removing pipe once since it has some issues about evaluating more than once :)
13 years ago
Daniel Hokka Zakrisson
9076f8eb31
Add type checking for module arguments, converting as much as possible
...
Converts to list from comma-separated strings, and to dicts from
comma-separated, key=value strings.
Fixes #2126 .
13 years ago
Michael DeHaan
b75b9681a8
more places to use yaml.safe_load
13 years ago
Michael DeHaan
a9ea3136cf
Use yaml.safe_load as we are just using basic data structures
13 years ago
Michael DeHaan
5b31feb73b
Merge pull request #2179 from skinp/host_connection
...
Add support for connection type in ansible_hosts file
13 years ago
Patrick Pelletier
2b4ddfb0a2
Handle delegate_to case for local connections in hosts file
13 years ago
Michael DeHaan
e51707711c
Merge pull request #2120 from jpmens/doc_ex1
...
Add support for additional EXAMPLES string in Ansible modules
13 years ago
Michael DeHaan
f7fb681bb2
Fix comment in chroot connection type
13 years ago
Michael DeHaan
5a1aef5372
Merge branch 'local-chroot-support-v2' of git://github.com/mmoya/ansible into testing
13 years ago
Michael DeHaan
93f73739d3
Merge branch 'paramiko-termcap' of git://github.com/madduck/ansible into testing
13 years ago
Patrick Pelletier
4c0e6722c4
Add support for connection type in ansible_hosts file
13 years ago
Maykel Moya
9a493ef388
Add support for running modules chrooted in a local dir
...
Adds 'chroot' connection for executing modules chrooted to
a local dir. Requires running ansible as root.
chroot dirs should be specified in the inventory like any
other host.
You can do things like:
$ sudo -E ansible -vvv -f 1 "./chroot1,./chroot2" -c chroot \
all -m setup
$ sudo -E ansible-playbook -vvv -f 1 -i "./chroot1,./chroot2" \
-c chroot some-playbook.yml
some-playbook.yml:
---
- hosts: all
tasks:
- name: echo something
shell: echo "Yaaay!" >/tmp/foobar.txt
- name: install less
apt: pkg=less state=latest
13 years ago
Stoned Elipot
9f2bba01ba
Fix diff output vertical spacing
13 years ago
Michael DeHaan
6d604469d8
Always adjust file attributes with the template module.
13 years ago
Jan-Piet Mens
396a07bcc7
Add support for additional EXAMPLES string in Ansible modules
...
return DOC and EXAMPLES as a list
add moduledev explanation
more
13 years ago
Michael DeHaan
ab389d8908
For consistency, add host should take a key named 'name' in addition to 'hostname'.
13 years ago
Michael DeHaan
c4779d95b8
Removing unused import, 'make pyflakes' is now clean.
13 years ago
Michael DeHaan
9cf66f4376
Fixes from 'make pep8'. Partial, more to come.
13 years ago
Michael DeHaan
11e7ede4d9
Merge pull request #2112 from kavink/devel
...
Fixing syntax error
13 years ago
Michael DeHaan
61d01f549f
Show a nicer message when attempting to diff unicode files.
13 years ago
Kavin Kankeshwar
359ac9a495
Fixing syntax error
...
running install_lib
byte-compiling /usr/lib/python2.6/site-packages/ansible/runner/action_plugins/add_host.py to add_host.pyc
SyntaxError: ('invalid syntax', ('/usr/lib/python2.6/site-packages/ansible/runner/action_plugins/add_host.py', 37, 92, ' def run(self, conn, tmp, module_name, module_args, inject, complex_args=None, **kwargs)\n'))
13 years ago
Daniel Hokka Zakrisson
43d22b0c42
Flatten argument to with_items
...
Fixes #1711 .
13 years ago
Michael DeHaan
f02b9987fc
We all agreed on the list that the ansible module common module snippet, since it's dynamically embedded in modules on the fly, should
...
be a BSD licensed snippet so that it's ok to write proprietary modules. The actual license of Ansible (GPLv3) or any modules
written for ansible (any) do not change.
13 years ago
Michael DeHaan
1ecf4a6943
Working on complex argument support.
13 years ago
Michael DeHaan
cd32597af0
Make the file module work as expected in check mode
13 years ago
Michael DeHaan
fa21b41357
Fixup the pipe_once plugin
13 years ago
Michael DeHaan
0af83317a1
Added a $PIPE_ONCE lookup plugin, that caches the result so it is only evaluated one time.
13 years ago
Michael DeHaan
b365e04616
Allow add_host to add hosts to multiple groups, groups is now an alias for groupname.
13 years ago
Rob Parrott
ef17fc9f20
add the ability to take variables in the add_host module, and be willing to parse a host:port hostname handed to add_host
13 years ago
Michael DeHaan
c8878998d1
update some of many copyright dates but we can just do this when editing each file, not super high priority
13 years ago
James Martin
7129a9e355
Using "OtherLinux" in module_commons, cleander detection in setup.
13 years ago
James Martin
5646bc278b
Support for amazon linux distribution facts.
13 years ago
Michel Blanc
0cd0a7fda3
Fixes jina typos
...
Moved *jina* to *jinja2*
13 years ago
Michel Blanc
1c22f2146e
Adds configurable jinja2 extension loading
...
Jinja extensions adds features to the jinja2 templating engine. This
patch allows module loading for the templating engine vian an
ansible.cfg configuration key (jinja_extensions).
The default behaviour doesn't change (no module loading).
Requested modules can be added coma separated in ansible.cfg
Adds whitespace handling in jinja_extension config
Added whitespace handling in jinja_extension configuration directive, so
things stay safe if user adds spaces around comas in the directives
list.
Adds config example for jinja_extensions
Added config example with multiple extentions for jinja_extensions
13 years ago
Blair Zajac
fa8e653011
Simplify and correct comparisons with None.
13 years ago
martin f. krafft
ab39909260
Initialise PTY from calling environment
...
If we need to acquire a PTY for sudo's use, then it should really
inherit the capabilities of the calling environment. This is what
OpenSSH does, and so it makes sense to copy this behaviour for the
paramiko connection type.
Closes : #2065
Signed-off-by: martin f. krafft <madduck@madduck.net>
13 years ago
martin f. krafft
1cf43e9afe
Only allocate a PTY when sudo is used
...
Postpone the paramiko.Channel.get_pty until we know sudo is used. If
sudo is not used, then we do not need a PTY. In fact, the paramiko docs
explicitly state that it's not desirable to allocate a PTY for a simple
exec_command.
Signed-off-by: martin f. krafft <madduck@madduck.net>
13 years ago
Nigel Metheringham
c0e28762f0
Allow end of line comments in inventory file
...
See github issue 2702
https://github.com/ansible/ansible/issues/2072
13 years ago
Daniel Hokka Zakrisson
7e2999ed2d
Add directory detection to _remote_md5 and use this in copy
...
If it is a directory, change the destination path by appending the
basename of the source file, like is done if the destination ends with a
/, and try to get the MD5 of the new path.
13 years ago
Daniel Hokka Zakrisson
d632210941
Allow using other users' home directories as well
13 years ago
Daniel Hokka Zakrisson
89e73c123f
Fix tilde expansion for fileglob
...
Use common suffix to determine what part of original term to keep and
how much of the full path to combine to get a usable filename.
13 years ago
Daniel Hokka Zakrisson
57e51f7fdf
Clean up some extra_vars redundancy
13 years ago
Chris Hoffman
9057f72881
Removing duplicate import, adding missing import
13 years ago
Daniel Hokka Zakrisson
a1e00c93e5
Add ansible_ssh_user/pass to enable inventory-defined users
13 years ago
Daniel Hokka Zakrisson
c83e428a7e
Default expand_lists to True and set it to False for only_if
...
Fixes #2026 and #2027 .
13 years ago
Michael DeHaan
f7497e75e5
Able to use "environment: " on any task to pass proxy details and other useful settings. Can be a variable
...
or a dictionary.
13 years ago
Michael DeHaan
72a05ae2a0
Move diff code more into runner code.
13 years ago
Michael DeHaan
0ad6ac4086
Fix group depth for nested groups
13 years ago
Michael DeHaan
828119d823
Allow the remote username to come from a variable set in vars_files or vars
13 years ago
Michael DeHaan
e6ead2ca74
make things like $FILE(/etc/path/foo.conf) and $ENV(HOME) work without having to use brackets to index them
13 years ago
Michael DeHaan
c692de6b80
Cleanup YAML parse error warning code a tiny amount.
13 years ago
Steve Frank
36027ddbba
Squashed commit of the following:
...
Changed ami_tags to instance_tags to better follow naming convention
Add support for creating tags on the new instances
13 years ago
Michael DeHaan
a894791767
Slightly friendlier error on missing hosts file, slightly friendlier error on inventory script returning invalid syntax
...
(or if inventory is non-script and accidentally executable).
13 years ago
Brian Coca
ca5f52b825
now missing hosts file gives nice message and no traceback
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca
0e8627b7e8
added block device info gathering, full for linux, partial for freebsd added prettyfing byte function Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
...
moved moutns out of devices Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Matt Cordial
2ccfc8d2b6
Fix Issue #2025 where templates were not being transfered.
13 years ago
Michael DeHaan
a9162a86f2
Very basic --diff option for showing what happens when templates change.
...
Probably output is not useful if not used with --limit
Works well with --check mode
13 years ago
Daniel Hokka Zakrisson
f3305564e2
Add stderr contents to parse errors
13 years ago
Daniel Hokka Zakrisson
19f3cf45f4
Merge pull request #1982 from dex4er/feature_j2_filter_safe_yaml
...
Use yaml.safe_dump rather than yaml.dump. No more "!!python/unicode".
13 years ago
Daniel Hokka Zakrisson
dddfeac9c4
Allow using ${hostvars.<node>} for nodes not in SETUP_CACHE
...
This allows accessing inventory data from nodes that have not been
talked to (yet).
13 years ago
Daniel Hokka Zakrisson
ffd4ae11b8
Merge pull request #1993 from fdavis/timeout_ssh
...
Add ConnectTimeout=DEFAULT_TIMEOUT to ssh args
13 years ago
Daniel Hokka Zakrisson
70d5dad726
Also catch NameErrors which would indicate missing quotes
13 years ago
Daniel Hokka Zakrisson
bc709e7b67
expand_lists should default to False
13 years ago
fdavis
21a5c55921
Add ConnectTimeout=DEFAULT_TIMEOUT to ssh args
13 years ago
Daniel Hokka Zakrisson
98f0a9210e
Raise an error when multiple when_* statements are provided
...
Fixes #1994 .
13 years ago
Daniel Hokka Zakrisson
d5e63332fe
Raise an error if an action doesn't have a string type
...
Happens with e.g. "command: true" that YAML helpfully converts to a
bool.
13 years ago
Rune Kaagaard
7a8b27f716
Fixing bug with unicode templates.
...
The utils.md5s() function would break when calculating checksums
for non-ascii characters. Convert to utf-8 first.
13 years ago
Daniel Hokka Zakrisson
c1b63d1500
Fix for when conditional is a simple bool already
...
Fixes #1983 .
13 years ago
Piotr Roszatycki
8cf268441e
Use yaml.safe_dump rather than yaml.dump. No more "!!python/unicode".
13 years ago
Daniel Hokka Zakrisson
1becc665b2
Fix missing ) in add_host
...
Fixes #1980 .
13 years ago
Michael DeHaan
fed82c2188
This implements a basic --check mode which for now is only implemented on template & copy operations. More detail will be shared with the list
...
shortly.
13 years ago
Daniel Hokka Zakrisson
d8d1f2cd7a
Split PATH on os.pathsep, that is what it's there for
13 years ago
Daniel Hokka Zakrisson
a025cfcb33
Add on_import_for_host callback from non-list case
13 years ago
Daniel Hokka Zakrisson
a79373f6b2
Make template_ds the only templater
...
Instead of having to remember when to use which one, rename template_ds
to template and move the last bit of code from template to varReplace
(which gets used for all string replacements, in the end).
This means that you can template any data type without worrying about
whether it's a string or not, and the right thing will happen.
13 years ago
Michael DeHaan
f7aaa5ccc5
Fix copyright, unused imports
13 years ago
Michael DeHaan
857ccf7f6c
Add random choice plugin (with_random_choice)
13 years ago
Michael DeHaan
318e3302fb
Fix up some version related things on the devel branch.
13 years ago
Daniel Hokka Zakrisson
f7e286cf34
Fix error format for invalid vars_files
13 years ago
Seth Vidal
83b9654c63
stop updating SETUP_CACHE in run_play as per comment on pr 1945
13 years ago
Seth Vidal
f649777072
- make extra-vars override all other vars and facts in playbooks
13 years ago
Daniel Hokka Zakrisson
b79960e13b
If failed lookups are fatal, re-raise the exception
...
Fixes #1938 .
13 years ago
Daniel Hokka Zakrisson
e166f71fcc
Get output before receiving return code
...
Fixes hangs observed with large amounts of output, as it would get into
a dead-lock.
13 years ago
Michael DeHaan
4d8f3b0924
This standardizes the apt_key module some
...
* improves error handling and reporting
* uses run_command to reduce code
* fails quicker on errors as opposed to return codes and tracebacks
* can now also specify the key as data versus needing to wget it from a file
13 years ago
Daniel Hokka Zakrisson
5268d49bad
Add sudo_flags configuration option to alter sudo behaviour
...
Default to -H to set $HOME appropriately.
13 years ago
Les Aker
f4eed3710b
fixed check for required_together
13 years ago
Michael DeHaan
0030a2bd09
Allow handler files to be empty lists.
13 years ago
Michael DeHaan
0c2f67ef66
Merge pull request #1923 from fdavis/ans_env_addition
...
add env vars for plugins action,callback,connection,lookup,vars,filter
13 years ago
Michael DeHaan
36066d8664
Fixup ec2_facts docs parsing
13 years ago
fdavis
925c1a4611
add env vars for plugins action,callback,connection,lookup,vars,filter
13 years ago
Daniel Hokka Zakrisson
4d71b31f7e
Ensure destination and source are available before mangling them
...
Fixes #1918 .
13 years ago
Daniel Hokka Zakrisson
6f9099c51d
Merge pull request #1898 from silviud/fix_inventory_list_groups
...
Inventory class - lambda fails on attribute access - g.name is a string not the group obje...
13 years ago
Daniel Hokka Zakrisson
53fd85e2c4
Merge pull request #1903 from leucos/mergeable-hash-vars
...
Adds user-selectable hash merging support in vars
13 years ago
Daniel Hokka Zakrisson
864b75e54b
Override Jinja2 Template class to make {% include %} work again
...
Fixes #1908 .
13 years ago
Michel Blanc
8eb7d740b0
Fixes hash merging
...
No need for deep copy (vars are essentially immutable once loaded, there
should not be any modifications)
13 years ago
Michel Blanc
e28e538c6e
Adds user-selectable hash merging support in vars
...
Hash variables are currently overriden if they are redefined. This
doesn't let the user refine hash entries or overriding selected keys,
which can, for some, be a desirable feature.
This patch let the user force hash merging by setting the
hash_behaviour value to "merge" (without the quotes) in ansible.cfg
However, by default, ansible behaves like it always did and if any value
besides "merge" is used ("replace" is suggested in the example ansible.cfg
file), it will also behave as always.
13 years ago
Bowe Strickland
2b3d6d4545
protect PluginLoader._extra_dirs from appending None
...
PluginLoader.add_directory() can receive None from, for example,
Inventory.add_directory(self.basedir()) if host_list is a custom list.
None has no reasonable interpretation other than ignore it.
13 years ago
Silviu Dicu
f7694ac433
lambda fails on attribute access - g.name is a string not the group object
13 years ago
Daniel Hokka Zakrisson
94a1c221bc
Update variable precedence section with current rules
13 years ago
Daniel Hokka Zakrisson
a16ddb57c1
Default module search path is included already
...
Adding it to runner's module_path makes it override local modules.
13 years ago
Daniel Hokka Zakrisson
35b58955d6
Fix paramiko for when no private key is specified
13 years ago
Michael DeHaan
ef38e9f0e6
Merge pull request #1875 from cocoy/vars_prompt_default
...
Adding default on vars_prompt
13 years ago
Tim Gerla
4c64d0d6be
Expand ~ shell shortcuts for the --private-key argument
13 years ago
Michael DeHaan
35c7ebf7a4
Revert "Update lib/ansible/utils/__init__.py"
...
Reported hanging of no-password sudo in some cases. Need to explore.
This reverts commit 87f6739e20 .
Conflicts:
lib/ansible/utils/__init__.py
13 years ago
ron1
280660b8a7
Support sudo alternatives that offer sudo-compatible interfaces
13 years ago
Rodney Quillo
395093e0bf
Move default arguments to the end of the function call.
13 years ago
Michael DeHaan
c8fc353bc3
Merge pull request #1811 from fdavis/devel
...
add when_{failed,changed}, and extended when_{set,unset}
13 years ago
Michel Blanc
87f6739e20
Update lib/ansible/utils/__init__.py
...
Adds -i to make_sudo_cmd so target user's environment gets loaded when configurationslike this are used :
- hosts: ubuntu
name: Install ruby for the configured ruby user
sudo: True
sudo_user: rubyuser
# should be ${ruby_user}, but can't for now because of #1665
tasks:
- name: Gets current ruby version
action: shell rbenv version
register: ruby_current_version
13 years ago
Rodney Quillo
7ae100611c
Adding default on vars_prompt
13 years ago
Stephen Fromm
4eaee3df0a
Various cleanup to run_command
...
* Rename fail_on_rc_non_zero to check_rc, much more succinct.
* Simplify method defintion
* Fix command module and drop shell=shell option; whether to use
shell is determined by if args is a list.
13 years ago
Stephen Fromm
300531507b
Add method run_command to module_common.py
...
This adds a helper method that modules can call to execute a command via
subproces. It takes two arguments: the command to run and
keyword options that control how the process is executed. Supported
options are: fail_on_rc_non_zero, close_fds, and executable.
fail_on_rc_non_zero will call fail_json if the command fails. If
args is a list, the command will be run with shell=False; otherwise, if
a string, it will be run with shell=True. Otherwise, run_command() returns
the returncode, stdout, and stderr.
13 years ago
Daniel Hokka Zakrisson
d11262af4d
Fix raw (no executable) support on -c local
13 years ago
Daniel Hokka Zakrisson
5231be5d4b
Add sudo password support for local
13 years ago
Daniel Hokka Zakrisson
7ecab22302
Move sudo command making to one common function
13 years ago
Sergey Popov
e41f89d507
Fix distribution detection - return string instead of functions
13 years ago
Jayson Vantuyl
13ddd39db9
add with_sequence lookup plugin
...
Plugin allows you to do easy counts for items.
13 years ago
Dag Wieers
fb802beee7
In PR #1804 the use of C in script was moved to _low_level_execute_command()
...
So we cannot get rid of this one now.
13 years ago
Daniel Hokka Zakrisson
7782923ea2
Revert #1818 but avoid double-dwim, fixing relative fileglob
13 years ago
Daniel Hokka Zakrisson
891b1e371a
Default to not using an executable
...
For compatibility with older releases as well as avoiding things like
action: raw executable= show status
to communicate with devices that don't have sh.
13 years ago
Daniel Hokka Zakrisson
92ad206b84
Use re instead of shlex.split to find executable
...
shlex.split will strip quotes and it might not even be sh at this point.
13 years ago
Michael DeHaan
910667152c
Merge pull request #1843 from dagwieers/import-cleanup
...
Clean up imports (taken from PR #1804 )
13 years ago
Dag Wieers
b781438480
Clean up imports (taken from PR #1804 )
13 years ago
Daniel Hokka Zakrisson
87b2378e22
Resolve variable references inside variables
...
Fixes the case where variable x is '$y' and y is a dict(foo='bar') and
an attempt to access ${x.foo} is made.
13 years ago
fdavis
fe310dcff1
add when_failed, when_changed, and extended when_set/unset
...
This commit extends the 'when_' conditions to failed and changed
json results
Additionally it makes when_{set,unset,failed,changed,int,str,flt}
behave more similiarily in that they all except and/or/not logic
13 years ago
Daniel Hokka Zakrisson
1b5d039bf4
Extend executable= support in raw to include no execuable
...
Useful for managing not-UNIX things.
13 years ago
Daniel Hokka Zakrisson
4955587d8c
Merge pull request #1798 from dagwieers/raw-executable
...
Allow to change executable (shell/interpreter) when using raw
13 years ago
Daniel Hokka Zakrisson
c23eda82c2
Allow pattern[0] to address a single node
...
Replaces erroring out on it and requiring the abysmal pattern[0-0]
instead.
13 years ago
Michael DeHaan
03ab074d0d
Merge pull request #1821 from leucos/path-expand-fix
...
Expands path on file operations
13 years ago
willthames
4e50478a05
Fix behaviour when file handles a path with tilde
...
Two problems here
* unchecked exception handling and erroneous assumption as to why
an exception might fire
* although the file module expands the path, when using file_args
the unexpanded path is passed.
Expected result: ~/path/to/file should work fine
Actual result: exception is because it doesn't find file with a message
about not being able to get the selinux context
13 years ago
Daniel Hokka Zakrisson
4d48daff80
Actually allow using connection: on a task
13 years ago
Daniel Hokka Zakrisson
637370089a
Skip polling when all hosts were skipped
...
Fixes #1823 .
13 years ago
Daniel Hokka Zakrisson
947ec34116
Merge pull request #1807 from willthames/openlog_unicode_fix
...
syslog.openlog does not cope with unicode first argument
13 years ago
Michel Blanc
7d7e7fb8bc
Adds path expansion to two other methods
...
set_owner_if_different and set_group_if_different seems to need path
expansion too
13 years ago
willthames
411b2bf7d9
Added additional template variables
...
Added two additional template variables
* template_fullpath - absolute path to the template
* template_run_date - date that the template was rendered
Documented these additional variables in the module documentation
13 years ago
Daniel Hokka Zakrisson
caee51e90e
Allow only_if/when_* on task includes and apply it on all tasks within
13 years ago
Daniel Hokka Zakrisson
07b215d4fa
Check for non-accepted arguments combined with task includes
...
Throw an appropriate error for it.
13 years ago
Daniel Hokka Zakrisson
68f736e8d7
Make inventory variables available to vars_files
13 years ago
Daniel Hokka Zakrisson
a1877b2213
Allow infinite depth task includes
13 years ago
Daniel Hokka Zakrisson
4555cdc49c
Allow using connection: on the task level
...
This is the name of the setting on the play level, and the options.
Should be consistent.
13 years ago
Michel Blanc
0037a19389
Expands path on file operations
...
Path might have to be expanded on some operations. It seems that path
containing '~' are not.
Using os.path.expanduser in appropriate places solves the problem, but
this might be required in many other places.
13 years ago
Stephen Fromm
2100a35663
Update path_dwim() to return absolute path
...
If path_dwim() is provided a relative path to a file, it will now return an
absolute path of the playbook directory + the relative file path.
13 years ago
willthames
5ef077e58c
syslog.openlog does not cope with unicode first argument
...
It seems that os.path.basename(__file__) can return a unicode
string. In this case syslog.openlog fails. Forcing the result
to a string causes the resulting error to go away.
13 years ago
Dag Wieers
eb36ff45b9
Make script module use raw module so it does not require python
13 years ago
Dag Wieers
846161a1a4
Allow to change executable (shell/interpreter) when using raw
...
This patch adds an optional 'executable=' option to the raw command line to override the default shell (/bin/sh), much like the shell module does.
13 years ago
Dag Wieers
988db558b3
Add return code and error output to raw module
...
Since we use 'raw' heavily on equipment where 'command' and 'shell' are not (yet) working (and python may need to be installed first using raw) these improvements are necessary in order to write more complex scripts (with return code handling and separated stdout/stderr).
This change includes the following changes:
- exec_command() now returns the return code of the command
- _low_level_exec_command() now returns a dict, including 'rc', 'stdout' and 'stderr'
- all users of the above interfaces have been improved to make use of the above changes
- all connection plugins have been modified to return rc and stderr
- fix the newline problem (stdout and stderr would have excess newlines)
In a future commit I intend to add assertions or error handling code to verify the return code in those places where it wasn't done. Since only the output was available, the return code was ignored, even though we expect them to be 0.
13 years ago
Daniel Hokka Zakrisson
d4c63e3300
Ensure each basedir is only added to the search path once
...
Fixes #1790 .
13 years ago
Daniel Hokka Zakrisson
3a36c024da
Make lookups being fatal up to the caller
...
Fixes #1769 .
13 years ago
Daniel Hokka Zakrisson
97cc384ccf
Set basedir to . if there isn't one
...
This avoids special-casing '' = '.' everywhere the basedir gets used.
Fixes #1729 .
13 years ago
Daniel Hokka Zakrisson
0f1706220b
Add support for using the Jinja2 built-ins such as range
13 years ago
Michael DeHaan
d34e320e12
Merge pull request #1733 from dhozac/lookup-list
...
Make all lookup plugins accept lists as arguments
13 years ago
Michael DeHaan
04195e202d
Merge pull request #1747 from njharman/alpharange
...
Alphabetic inventory hostname patterns.
13 years ago
Michael DeHaan
4bcdd24688
Merge pull request #1776 from junegunn/inventory-group-var-ws
...
Allows whitespaces around assignment operators when defining group variables
13 years ago
Junegunn Choi
8896486606
Adds comments on handling quoted group vars
13 years ago
Daniel Hokka Zakrisson
c2792a936d
Allow parameterized playbook includes to define complex variables
...
To be used like:
- include: playbook.yml
vars:
mylistvar:
- item1
- item2
13 years ago
Daniel Hokka Zakrisson
b73016b881
Make all lookup plugins work with lists
...
Lookup plugins should accept a string or a list, and always return
a list, even if it is just one item.
13 years ago
Michael DeHaan
6350dedd7a
Merge pull request #1765 from dagwieers/skip-when-no-matches
...
Change message when a play matches no hosts
13 years ago
Michael DeHaan
ad2ab6a5dd
Merge pull request #1772 from fdavis/devel
...
change error message on check_conditional when variable does not exist
13 years ago
Michael DeHaan
29611bdedf
Merge pull request #1777 from dominis/devel
...
fixes #1767 parsing serial from extra_vars
13 years ago
Junegunn Choi
7fbb7e079a
Fix hostname expansion bug in inventory parser
13 years ago
Nandor Sivok
f31fbdff1f
moving int() conversion to the play init
13 years ago
Nandor Sivok
e91db5fcdc
fixes #1767 parsing serial from extra_vars
13 years ago
Junegunn Choi
daf797804b
Allows whitespaces around assignment operators
...
when defining group variables
13 years ago
fdavis
7347e54b70
change error message on check_conditional when variable does not exist
13 years ago
Stephen Fromm
ccca5fcd1c
Ensure files created by authorized_key have correct selinux context
...
Three changes:
* Add set_default_selinux_context() to module_common that sets
a file's context according to the defaults in the policy
* In atomic_replace(), set the default context for the file if
selinux is enabled and the destination file does not exist.
* In authorized_key, set the default context when creating
$HOME/.ssh and $HOME/.ssh/authorized_keys. If these already
exist, this won't touch them.
13 years ago
Dag Wieers
cd930d2e34
Change message when a play matches no hosts
...
I guess my previous pull request was confusing, by changing the message to something we already do for tasks, it makes it more clear.
Just like we say:
TASK: [foo bar]
skipping: [system01]
The message now is more clear:
PLAY [wagawaga] *******************************
skipping: no hosts matched
It makes it clear that we are skipping the play, just as is done for a task when a condition is not met.
13 years ago
Michael DeHaan
70bb7d1e54
Merge pull request #1696 from gregorg/enhance_limit
...
Allow regex to be used to select hosts in addition to fnmatch pattern
13 years ago
Daniel Hokka Zakrisson
54b45e9bd4
Allow intersecting host patterns by using &
...
This allows patterns such as webservers:!debian:&datacenter1 to target
hosts in the webservers group, that are not in the debian group, but are
in the datacenter1 group. It also parses patterns left to right.
13 years ago
Norman J. Harman Jr
6603737e4d
Alphabetic inventory hostname patterns.
...
- Code, docs, tests.
- Also added test of large range 000-142 to verify alpha range did not
break this.
13 years ago
Dag Wieers
dd4ac46397
Import errno to avoid 'NameError: global name 'errno' is not defined'
...
I hit the following exception because errno is referenced but not imported.
```
fatal: [system01] => failed to parse: Traceback (most recent call last):
File "/root/.ansible/tmp/ansible-1354644532.37-246102819320352/copy", line 782, in <module>
main()
File "/root/.ansible/tmp/ansible-1354644532.37-246102819320352/copy", line 117, in main
module.atomic_replace(dest_tmp, dest)
File "/root/.ansible/tmp/ansible-1354644532.37-246102819320352/copy", line 772, in atomic_replace
if e.errno != errno.EPERM:
NameError: global name 'errno' is not defined
```
13 years ago
Michael DeHaan
dbf5a57a5a
Merge pull request #1683 from bcoca/template_override
...
Template override
13 years ago
Daniel Hokka Zakrisson
e54b4b1c9a
Ignore arguments when checking for interpreter, and re-add before use
13 years ago
Daniel Hokka Zakrisson
d5a456fbcf
Merge pull request #1697 from bcoca/mint
...
Implements multiple interpreter overrides
13 years ago
Daniel Hokka Zakrisson
ffac7ce2f9
Merge pull request #1687 from dhozac/allow-grouping-in-external-inventory
...
Allow inventory scripts to define groups of groups and group vars
13 years ago
Dag Wieers
c65c00cb34
Updated ansible version to align with RPM package
13 years ago
Michael DeHaan
5890a2a9da
Release stuff
13 years ago
Michael DeHaan
9afb7c1ed0
Get ready to release 0.9
13 years ago
Jan-Piet Mens
17f31a2a79
CLI: ansible-doc shows lists of modules & module docs on command-line
...
check path is directory
added manpage & setup
small cleanup
shut up module_formatter in utils to avoid trace print on crud files in library
13 years ago
Daniel Hokka Zakrisson
8d309e0fa3
Allow inventory scripts to define groups of groups and group vars
13 years ago
Daniel Hokka Zakrisson
b8d6dec5ad
Reset notified_by list per serialized batch
...
Fixes the case where a handler attempts to run for every batch after any
batch has notified it, regardless of whether the current batch did.
13 years ago
Daniel Hokka Zakrisson
a56e1f31fa
Properly restrict hosts after 9070875
13 years ago
Daniel Hokka Zakrisson
f6245e17c1
Skip evaluating only_if for BYPASS_HOST_LOOP plugins
13 years ago
Daniel Hokka Zakrisson
bda08c8a1b
Avoid creating temporary directory for some action plugins
...
This ensures we don't litter remote systems with temporary directories
that don't get cleaned up, as well as speeds things up from not having
to touch every node.
13 years ago
Daniel Hokka Zakrisson
f6e7381a71
Evaluate only_if in group_by
13 years ago
Daniel Hokka Zakrisson
9070875a6f
Move available hosts gathering to a common function
13 years ago
Daniel Hokka Zakrisson
5065103017
Skip already failed hosts
...
Fixes #1699 .
13 years ago
Daniel Hokka Zakrisson
c948c65bcd
Template the name of the task
...
Broken by 1e0295c . Fixes #1698 .
13 years ago
Brian Coca
2f2bd87b06
multiple _interpreter overrides with ansible_<bin>_interpreter variables, not
...
just for python anymore
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Gregory Duchatelet
dde01dabc3
Squashed commit of the following:
...
commit 48069adf0f
Author: Gregory Duchatelet <skygreg@gmail.com>
Date: Tue Nov 27 10:13:08 2012 +0100
Removing this plugin from this branch.
commit 15400fffe6
Author: Gregory Duchatelet <skygreg@gmail.com>
Date: Tue Nov 27 09:53:16 2012 +0100
Enhance _match function in inventory with regex.
--limit ~regex could be used to filter hosts or group with a regex.
Tested on cli and ansible-playbook.
commit 63c1b2e17e
Author: Gregory Duchatelet <skygreg@gmail.com>
Date: Tue Nov 27 09:03:41 2012 +0100
Revert pull request #1684
commit 7c2c6fee3a
Merge: f023a2f dd5a847
Author: Gregory Duchatelet <skygreg@gmail.com>
Date: Tue Nov 27 08:52:53 2012 +0100
Merge remote branch 'upstream/devel' into devel
commit f023a2f3df
Author: Gregory Duchatelet <skygreg@gmail.com>
Date: Mon Nov 26 20:52:27 2012 +0100
Add an inventory plugin to fetch groups and host from our CMDB.
commit c64193b4c6
Author: Gregory Duchatelet <skygreg@gmail.com>
Date: Mon Nov 26 20:43:30 2012 +0100
Added possibility to filter hosts from a group, with a regex, separating
groupname and regex with a ~
Usage in group pattern: group~filterpattern
Samples:
ansible group~server-0[1236] -m ping
ansible web~proxy -m ping
ansible web~(proxy|frontend) -m ping
13 years ago
Daniel Hokka Zakrisson
900790af41
Reuse inventory object created by ansible-playbook in playbook
...
This reduces the amount of times an inventory script has to be invoked.
13 years ago
Daniel Hokka Zakrisson
d703f92077
Disable authentication methods that weren't specified
13 years ago
Stephen Fromm
6a68d3813f
Set LANG in module_common.py
...
Add constant DEFAULT_MODULE_LANG that defaults to C. Can be set via
environment variable ANSIBLE_MODULE_LANG or configuration variable
module_lang. Updated test-module to have same behavior.
13 years ago
Michael DeHaan
da90c5f75e
Document 'when' and tweak the code to be a little more comprehensive on what is false.
13 years ago
Daniel Hokka Zakrisson
43bdec8b20
Throw an error if multiple actions have been specified
13 years ago
Daniel Hokka Zakrisson
1e0295c7e2
Template handlers late
...
This allows overriding variables in name, and removes templating from
parsing.
13 years ago
Daniel Hokka Zakrisson
ebd31af940
Don't prompt for vars in extra-vars
...
Fixes #1622 .
13 years ago
Daniel Hokka Zakrisson
94fc3006e9
Make variables local to the play
...
Fixes #1677 .
13 years ago
Brian Coca
d7f38d07b3
fixed bug for string size mismatch, now substring depends on size of match string Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca
6a1e2aaff5
moved override matching string to variable changed test template to match Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca
68f5d69365
added ability to override jinja enviornment from first line of template Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Daniel Hokka Zakrisson
0c70abfaa9
Make sure any existing groups gets reused
13 years ago
Daniel Hokka Zakrisson
5504f13c68
Create groups in the first run through the file
...
Fixes #1208 .
13 years ago
Daniel Hokka Zakrisson
2bfb7deec0
Set all in the returned dict
...
Otherwise the group is lost, and group_vars/all isn't used.
13 years ago
Michael DeHaan
33196ec131
Merge pull request #1669 from dagwieers/ssh-tcgetattr2
...
Use proper pseudo-tty's instead of pipes when using subprocess
13 years ago
Dag Wieers
7192eb3047
Use proper pseudo-tty's instead of pipes when using subprocess
...
This change avoids the "tcgetattr: Invalid argument" error by making sure the ssh we start does have a proper pseudo-tty.
We could also check whether our current terminal is a proper terminal (by doing a tcgetattr ourselves) but I don't think this adds anything.
This closes #1662 (if all use-cases have been tested: sudo, passwd)
13 years ago
Daniel Hokka Zakrisson
db1a65342a
Set -c local cwd to . if basedir is empty
13 years ago
Daniel Hokka Zakrisson
715d875dcb
Group should only return its own variables
...
Otherwise, a host in two groups, A and B, using a variable defined
in group A and all will get the value of all, as B's variables will
include the all variable.
Partially fixes #1647 .
13 years ago
Daniel Hokka Zakrisson
e44b85daba
Remove special-casing for all group
...
global_vars has higher precedence than inventory. Putting the all
group's variables into it overrides all other groups and hosts.
Partially fixes #1647 .
13 years ago
Daniel Hokka Zakrisson
bd7e02d629
Get all groups' variables in order of depth
...
Fixes all not being processed, as well as the order of the variable
precedence
13 years ago
Daniel Hokka Zakrisson
d5dd89a8f7
Allow specifying when: ...
13 years ago
Daniel Hokka Zakrisson
fd732f8d3b
Add when_boolean
...
Fixes #1567 .
13 years ago
Daniel Hokka Zakrisson
ddef608c94
Wrap all remote commands in sh
13 years ago
Daniel Hokka Zakrisson
047d089cea
Restore git output on --version
...
Broken by the move from utils.py to utils/__init__.py
13 years ago
Daniel Hokka Zakrisson
ef357ed1f2
Use the play's vars for the setup step
...
Allows using -e ansible_ssh_port=foo and have it apply to all actions.
13 years ago
Daniel Hokka Zakrisson
d1c285b70b
Port may be an integer when parsed from the play
13 years ago
Michael DeHaan
82f4aef959
Merge pull request #1648 from dhozac/local-cwd-basedir
...
Use runner's basedir as cwd for -c local
13 years ago
Michael DeHaan
41af2fce64
Merge pull request #1650 from dagwieers/port-not-integer-exception
...
Provide a proper error when the remote_port is not an integer
13 years ago
Daniel Hokka Zakrisson
3ce63d845e
remote_port is None by default
13 years ago
Daniel Hokka Zakrisson
6b69b37eb0
Merge pull request #1649 from dagwieers/template-port
...
Allow the remote port to be templated per play
13 years ago
Dag Wieers
85bba04a1c
Provide a proper error when the provided port is not an integer
...
As reported on the mailinglist, the user received a ValueError when the port number was not templated (fixed in #1649 ) and therefore it was not an integer. This change will catch the exception and provide a proper error so it is more clear.
13 years ago
Dag Wieers
8458f53014
Allow the remote port to be templated
...
This was requested on the mailinglist and seems useful.
13 years ago
Daniel Hokka Zakrisson
48898993b9
Fix removing of temporary files
13 years ago
Daniel Hokka Zakrisson
0ebf4b2d5a
Add destination path to fetch result
13 years ago
Daniel Hokka Zakrisson
bdf05ec9a0
Use runner's basedir as cwd for -c local
13 years ago
Daniel Hokka Zakrisson
f89f07871d
Fix typo in first_available_file error path
13 years ago
Daniel Hokka Zakrisson
f95fefd8c5
Use plugin system to find modules
13 years ago
Daniel Hokka Zakrisson
5dd2ec2cae
Add a way to add directories to just one type of loader
13 years ago
Daniel Hokka Zakrisson
d2abfb9ff8
Ensure runner adds its basedir, so ansible can benefit from plugins
13 years ago
Daniel Hokka Zakrisson
5183417de8
Reinstate ANSIBLE_KEEP_REMOTE_FILES
...
Fixes #1395 .
13 years ago
Daniel Hokka Zakrisson
11175781b8
Use slurp for fetch is sudo is enabled and needed
...
Fixes #1020 .
13 years ago
Daniel Hokka Zakrisson
11afd84d32
Drop dwim prefix from returned items in fileglob
...
Fixes #1618 .
13 years ago
Michael DeHaan
1b78dabcd4
Merge pull request #1632 from dhozac/use-ssh-conn-section-for-scp
...
Use the ssh_connection section for scp_if_ssh
13 years ago
Michael DeHaan
3bc0adacbf
Merge pull request #1634 from dhozac/ssh-password
...
Add password support to -c ssh via sshpass
13 years ago
Daniel Hokka Zakrisson
e6fed9f216
Add password support to -c ssh via sshpass
13 years ago
Daniel Hokka Zakrisson
021172f78d
Use the configured remote_tmp even for root
13 years ago
Daniel Hokka Zakrisson
c906f44d90
Use the ssh_connection section for scp_if_ssh
13 years ago
Michael DeHaan
ab5c0dfe7e
__new__ does not take arguments, remove deprecation warning
13 years ago
Michael DeHaan
096607eea4
Allow fireball to transfer binary files, fixup fireball docs, make fetch work with fireball.
13 years ago
Michael DeHaan
d500398e76
Merge pull request #1616 from dagwieers/skip-register
...
Do not register variable if host has been skipped
13 years ago
Michael DeHaan
52e2654faf
Merge pull request #1621 from dhozac/lookup-with-vars
...
Lookup plugin arguments need to be templated
13 years ago
Daniel Hokka Zakrisson
17e4ce97a4
Create a set of all the hosts in a group to prevent duplicates
...
Fixes #1516 .
13 years ago
Daniel Hokka Zakrisson
e74ffd6764
Lookup plugin arguments need to be templated
13 years ago
Dag Wieers
302eeae65d
Do not register variable if host has been skipped
...
Executive summary: skipping a host corrupts a variable (when it is registered)
We have a play existing out of multiple tasks that check a condition, if one of these tasks fails we want to skip all next tasks in the playbook. I noticed that if we skip a task because a certain condition is met, and this task has a register-attribute, I loose the value in the variable. Which means we cannot use that variable in subsequent tasks to evaluate because it was skipped:
```
- action: command test -d /some/directory
register: task
- action: command test -f /some/directory/file
register: task
only_if: '${task.rc} == 0'
- action: do something else
only_if: '${task.rc} == 0'
```
In the above example, if the second task is skipped (because the first failed), the third action will end with a "SyntaxError: invalid syntax" complaining about the unsubstituted ${task.rc} (even though it was set by the first task and used for skipping the second).
The following play demonstrates the problem:
```
- name: Test register on ignored tasks
hosts: all
gather_facts: no
vars:
skip: true
task: { 'rc': 666 }
tasks:
- action: debug msg='skip = ${skip}, task.rc = ${task.rc}'
- name: Skip this task, just to test if task has changed
action: command ls
register: task
only_if: '${skip} != True'
- action: debug msg='skip = ${skip}, task.rc = ${task.rc}'
- name: Now use task value
action: command echo 'Works !'
only_if: '${task.rc} == 0'
```
And the enclosed fix, fixes the above problem.
13 years ago
Michael DeHaan
44af1408ee
Merge pull request #1611 from dhozac/no-hostvars-templating
...
Keep hostvars from being templated
13 years ago
Michael DeHaan
6793bcbe4d
Merge pull request #1613 from dhozac/use-all-vars-for-hosts-template
...
Use all available vars for hosts:, user: and sudo_user:
13 years ago
Michael DeHaan
2303f65a1a
Merge pull request #1614 from dagwieers/missing-action-error
...
Print the task name (if any) when complaining
13 years ago
Dag Wieers
b96877e5aa
Print the task name (if any) when complaining
...
After spending 10 minutes to find which playbook had an action/local_action missing, I changed the error to include the task name (if set). The error eventually was caused because I added a name to a task, but the dash before the existing action was not removed.
13 years ago
Daniel Hokka Zakrisson
0be1f11ed5
Use all available vars for hosts:, user: and sudo_user:
13 years ago
Daniel Hokka Zakrisson
eebbbd3f0e
Make parameterized playbook includes work with vars as a list
...
Fixes #1610 .
13 years ago
Daniel Hokka Zakrisson
c200c26ced
Keep hostvars from being templated
13 years ago
Michael DeHaan
e3f7f86ac4
Merge pull request #1608 from dhozac/when_set-non-string
...
Try to ensure the entire value is quoted
13 years ago
Michael DeHaan
d5be13c3f0
Merge pull request #1605 from romeotheriault/add-md5-support-to-fetch-module
...
add bsd md5 support to fetch module
13 years ago
Daniel Hokka Zakrisson
0ca1775bda
Try to ensure the entire value is quoted
13 years ago
Daniel Hokka Zakrisson
25a8787e95
Template all variables before returning them to Jinja2
13 years ago
Daniel Hokka Zakrisson
d2dce1d63f
Make lookup plugin replacements part of the main variable logic
13 years ago
Daniel Hokka Zakrisson
a2bb3a09d2
Completely ignore stray $ in input
...
Previously, "a $ string $var" would not have gotten replaced at all.
13 years ago
Daniel Hokka Zakrisson
24b536d7ed
Add some comments to templating system
13 years ago
Romeo Theriault
4cd133ed8f
add bsd md5 support to fetch module
13 years ago
Daniel Hokka Zakrisson
233a36b9e8
Template using module_vars early
...
Since no basedir is available at that time, avoid invoking
lookup plugins since they assume it is present.
13 years ago
Michael DeHaan
c890ae18e7
Merge pull request #1575 from dhozac/parameterized-playbook-include
...
Add parameterized playbook includes
13 years ago
Michael DeHaan
3e855a5fcd
Merge pull request #1593 from dhozac/lookup_generic
...
Add support for generic $XXX() to call $LOOKUP()
13 years ago
Michael DeHaan
451f05fa3d
Merge pull request #1594 from sfromm/issue1342
...
Add ability to specify syslog facility for modules
13 years ago
Romeo Theriault
54b7f59416
remove verbose option on digest call
13 years ago
Stephen Fromm
06e54c0b97
Add ability to specify syslog facility for modules
...
Update constants.py so that one can specify environmental variable
ANSIBLE_SYSLOG_FACILITY or syslog_facility in ansible.cfg to define
the syslog facility to use. Alternatively, you can specify
ansible_syslog_facility in inventory. Runner now replaces
the syslog facility in the openlog() call with the default or
the injected variables ansible_syslog_facility.
This also updates hacking/test-module to behave similarly.
13 years ago
Daniel Hokka Zakrisson
9924555623
Add support for generic $XXX() to call $LOOKUP()
13 years ago
Michael DeHaan
40e49b6a5a
Merge pull request #1592 from jpmens/lookup_dnstxt3
...
$LOOKUP(dnstxt): handle exceptions
13 years ago
Jan-Piet Mens
bd55899a60
$LOOKUP(dnstxt): handle exceptions
...
de-spaced
13 years ago
Michael DeHaan
db3e8c0803
Merge pull request #1579 from jpmens/lookup_env
...
Add environment $LOOKUP plugin
13 years ago
Michael DeHaan
35679e0093
Merge pull request #1578 from jpmens/lookup_redis
...
Add Redis GET $LOOKUP plugin
13 years ago
Jan-Piet Mens
6efc98e8a3
Add environment $LOOKUP plugin
...
remove support for multiple vars
13 years ago
Jan-Piet Mens
e3e545418d
Add Redis GET $LOOKUP plugin
...
renamed
13 years ago
Jan-Piet Mens
e32f4a0564
Move get_docstring from module_formatter into ansible/utils
13 years ago
Daniel Hokka Zakrisson
9c095b72b9
Add parameterized playbook includes
...
Also makes with_* work with them.
Fixes #1162 .
13 years ago
Daniel Hokka Zakrisson
383dc30560
Rename varReplaceWithItems to template_ds
13 years ago
Michael DeHaan
325025a5b6
Merge pull request #1574 from dhozac/ssh-moar-data
...
Make sure we get all data
13 years ago
Michael DeHaan
fa17540a06
Merge pull request #1570 from skvidal/addhost
...
Addhost module
13 years ago
Daniel Hokka Zakrisson
e97a22603f
Make sure we get all data
13 years ago
Jan-Piet Mens
38d9dc8bff
Add DNS TXT record LOOKUP plugin
13 years ago
Seth Vidal
70d61fe7e8
need to use the variabled results
13 years ago
Seth Vidal
e147ad4213
add add_host action plugin - add hosts to inventory during a playbook
...
run - lets act on those hosts in the next play
13 years ago
Michael DeHaan
03591e0fc8
Merge pull request #1551 from dagwieers/local_action-fail
...
Turn 'fail' and 'debug' modules into action_plugins
13 years ago
Michael DeHaan
a31ca213a5
Merge pull request #1562 from dagwieers/oneline-fix
...
Make --oneline return one line (except with multiline output)
13 years ago
Michael DeHaan
03f4b0f923
Merge pull request #1560 from dagwieers/module-output-consistency
...
Make module output more consistent wrt. changed/failed
13 years ago
Michael DeHaan
3dc31a049f
Merge pull request #1527 from fdavis/devel
...
Support scp in an ssh connection
13 years ago
Dag Wieers
d42eb2563b
Make --oneline return one line (except with multiline output)
...
Currently the message prepared for --oneline mode adds a newline to the msg-string, which is then printed (adding another newline). This change removes the added newline so that successes and failures do not differ in output (except if the output is multiline).
13 years ago
Dag Wieers
fe0c70fe9d
Make module output more consistent wrt. changed/failed
...
- Make sure exit_json() always returns a changed= value
- Modify the yum module to not return failed=False
- Modify install() and latest() similar to remove() in yum module
- Changed exit_json(failed=True, **res) into a fail_json(**res)
- Make sure yum rc= value reflects loop (similar to how we fixed remove())
13 years ago
Dag Wieers
dd07011a65
Only print 'Invoked with' if there are arguments to the module
...
This closes #1519
13 years ago
Dag Wieers
d8459425a0
Turn 'fail' and 'debug' modules into action_plugins
...
This makes more sense as there is no purpose in running these remotely.
13 years ago
Daniel Hokka Zakrisson
47082a9171
Add $LOOKUP(<lookup plugin>,<data>) as a templating option
...
Also moves file and pipe to lookup_plugins.
13 years ago
Michael DeHaan
a1f7334634
Merge pull request #1525 from jhoekx/custom-filter-plugins
...
Support custom jinja2 filters.
13 years ago
Michael DeHaan
c9ae19c44c
Merge pull request #1547 from dagwieers/action-boolean
...
Bail out if an action is not a string
13 years ago
Dag Wieers
c9e62d7061
Fix for an exception when for whatever reason the inventory script fails
...
This avoids a traceback that gave no clue as to what was happening.
This is in line with the change from #1535
13 years ago
Dag Wieers
dfa1e8b0dc
Bail out if an action is not a string
...
Since YAML allows anything, we should enforce that actions are strings.
This closes #1419 .
13 years ago
Michael DeHaan
75d3b77454
Merge pull request #1535 from dagwieers/inventory-exception
...
Fix for an exception when for whatever reason the inventory script fails
13 years ago
Daniel Hokka Zakrisson
00aa584c57
Don't double dwim first_available_file in template
13 years ago
Dag Wieers
89206a6b68
Fix for an exception when for whatever reason the inventory script fails
...
This avoids a traceback that gave no clue as to what was happening.
13 years ago
fdavis
b1dbeec66c
Allows use of scp instead of sftp in
...
Added a boolean constant scp_if_ssh to the config
Added scp support for the ssh connection plugin
Refers to #1279
13 years ago
Jeroen Hoekx
8ffed6df75
Support custom jinja2 filters.
...
This uses the plugin framework to add filter plugins.
The previously hardcoded core filters are defined using the plugin
framework now.
13 years ago
Michael DeHaan
6f938c9f4c
Merge branch 'playbook_ssh_ask_pass' of git://github.com/clatour/ansible into devel
...
Conflicts:
examples/ansible.cfg
+ doc tweak
13 years ago
Michael DeHaan
908c43ad7f
Merge branch 'devel' of git://github.com/skorokithakis/ansible into devel
13 years ago
Michael DeHaan
05de2152a0
Merge branch 'sudo_ask_pass_config' of git://github.com/bcoca/ansible into devel
13 years ago
Michael DeHaan
154a00e612
Merge branch 'plugin-sanity' of git://github.com/dhozac/ansible into try_new_plugins
13 years ago
Michael DeHaan
c96f2c968e
Merge branch 'nigelm_freebsd' of git://github.com/nigelm/ansible into merge-service
...
Make things more reusable, correct some errors along the SSH key path
Conflicts:
library/user
13 years ago
Seth Vidal
e19c81977d
if a module returns failed in the results, don't fail unless failed is not false.
13 years ago
Chandler Latour
f436a8c88b
Added config option for default ask for ssh_pass
13 years ago
Daniel Hokka Zakrisson
e05e514861
Create a plugin loader system
13 years ago
Daniel Hokka Zakrisson
000d3832cc
Make ansible.utils a package
13 years ago
Stavros Korokithakis
3616dffb68
Detect whether we're running in a virtualenv.
13 years ago
Michael DeHaan
4c156e4df8
Merge pull request #1502 from dhozac/improved-lookup-plugins
...
Improved lookup plugins
13 years ago
Michael DeHaan
025402c0bf
Merge pull request #1507 from lorin/pretty-print-msg
...
Pretty-print "msg" when task fails
13 years ago
Stavros Korokithakis
d9a377cbb1
Fix installing to virtualenvs.
13 years ago
Daniel Hokka Zakrisson
07ba7e2013
Return original string for non-matched vars
13 years ago
Lorin Hochstein
1c5ac5cac8
Pretty-print "msg" when task fails
...
Several modules (e.g., pip) return stdout and stderr together in a "msg" variable (and the module development docs seem to suggest that the standard practice is to return status in this variable).
This change ensures that it is printed out with correct formatting (most importantly, with newlines appearing as newlines instead of \n).
13 years ago
Daniel Hokka Zakrisson
fbda2d4628
Use default port if ansible_ssh_port is not set for the delegated node
...
Also add testcase for it.
13 years ago
Daniel Hokka Zakrisson
c519d5dac0
Add a template lookup plugin
...
Requires that inject be passed to run
13 years ago
Daniel Hokka Zakrisson
37d9acc097
Make lookup API extensible and allow basedir to be passed
...
This allows using with_fileglob in play context, e.g.
- include: $item
with_fileglob: tasks/*.yml
as well as prepares for other data to be passed.
13 years ago
Daniel Hokka Zakrisson
2c77cf1a49
Skip tasks with a with_* that is empty
13 years ago
Brian Coca
604bf9f58a
Added config option to control default of asking or not for sudo password
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
13 years ago
Michael DeHaan
be300b562a
pyflakes fixes (mostly unused imports, unused vars)
13 years ago
Michael DeHaan
c0747b7baa
pep8 fixes
13 years ago
Michael DeHaan
0853ece810
Merge pull request #1474 from jhoekx/group-by-plugin-template
...
Add a group_by action plugin.
13 years ago
Michael DeHaan
f9a6265fb2
Merge branch 'vars_files-list-no-default' of git://github.com/dhozac/ansible into devel
13 years ago
Michael DeHaan
6dceef3a5f
Merge branch 'fix-var-in-var' of git://github.com/dhozac/ansible into devel
13 years ago
Daniel Hokka Zakrisson
efe83daf19
Fix ${var.$other_var} and add test cases for it
13 years ago
Michael DeHaan
9a12873166
Merge pull request #1477 from skvidal/devel
...
add check that vars plugins are not handing back None
13 years ago
Seth Vidal
3fcc591f18
add check that vars plugins are not handing back None
13 years ago
Dag Wieers
3728b2f459
Missing errors-import causes traceback
13 years ago
Jeroen Hoekx
b336d40101
Add a group_by action plugin.
13 years ago
Jeroen Hoekx
f963db6c2a
Fix output of pause plugin.
13 years ago
Jeroen Hoekx
77162e95e4
Send a host to runner executor instead of a letter.
...
Discovered in #1463 .
13 years ago
Daniel Hokka Zakrisson
e72fdccd87
Allow vars_files sequences without a default
13 years ago
Daniel Hokka Zakrisson
55a1473d50
Don't add file module arguments by default
...
This allows the postgresql_db module to work properly, as it uses
an argument named owner that conflicts with the file module.
13 years ago
Michael DeHaan
21258dcc66
Added 'when' as a shortcut around only_if.
13 years ago
Michael DeHaan
a768e9a9ff
Fix for sudo defaults if sudo is passed in via --extra-vars
13 years ago
Michael DeHaan
6ba30170dd
Make group_vars and host_vars available to usr/bin/ansible, and make vars_plugins exist
13 years ago
Michael DeHaan
e04dab904a
Use previous proven multiprocessing logic as the simplification didn't have the same Ctrl-C handling and may
...
be subject to race issues, though still don't pass Runner to each. Still seems performant.
13 years ago
Daniel Hokka Zakrisson
1052dd9c8f
Initialize sftp variable to fix error on transferless session
13 years ago
Michael DeHaan
5e2c2564bc
Explicitly execute /bin/sh versus $SHELL because some folks have very incompatible/weird shells. We do not
...
execute modules through the shell, this is only for basic ops, so should be sufficient.
13 years ago
Michael DeHaan
ff787146d1
stray debug
13 years ago
Michael DeHaan
24416b9e49
Remove stray debug message
13 years ago
Michael DeHaan
3257c5b61f
Some caching improvements to paramiko which are still not yet fully leveraged
...
in playbook mode, since the Runner still closes abstract host connections completely
and does not have a LRU.
13 years ago
Michael DeHaan
4c83c274e0
Don't close paramiko SFTP multiple times in the same runner pass. Noticeable performance increase.
13 years ago
Michael DeHaan
8b50ad7e85
Fix for atomic_replace patch if file does not yet exist
13 years ago
Daniel Hokka Zakrisson
7a8009f979
When atomically replacing files, copy attributes
13 years ago
Michael DeHaan
19a5f86c2e
Merge pull request #1452 from dhozac/with_items-as-plugin
...
Make with_items a lookup plugin
13 years ago
Michael DeHaan
9a141160a4
Merge pull request #1449 from dhozac/localhost-interpreters
...
Use the delegated host's interpreters
13 years ago
Michael DeHaan
347b0260c3
Merge varReplace cleanup and move code into new file 'template.py' so it's easier to keep template
...
code all together.
13 years ago
Michael DeHaan
f8e946b71d
Merge branch 'varfind-cleanups' of git://github.com/dhozac/ansible into devel
13 years ago
Daniel Hokka Zakrisson
2f05e95d8a
Use lookup plugins for task include with_*
13 years ago
Daniel Hokka Zakrisson
026e251b94
Make with_items a lookup plugin
13 years ago
Michael DeHaan
ffca0283b0
Closing pool explicitly may cause some exceptions on certain Pythons, disable for now.
13 years ago
Daniel Hokka Zakrisson
13a422261b
Use the delegated host's interpreters
13 years ago
Michael DeHaan
bbe66e7610
Merge pull request #1437 from lorin/sudo-nonroot-bugfix
...
Fix chmod occurring as wrong user when sudo as non-root
13 years ago
Michael DeHaan
9fca4eb241
Merge pull request #1441 from dhozac/better-error-missing-template
...
Improve the error message for missing files
13 years ago
Daniel Hokka Zakrisson
b1200c16df
path_dwim the path given to with_fileglob
13 years ago
Daniel Hokka Zakrisson
e216116807
Improve the error message for missing files
13 years ago
Lorin Hochstein
38fdc24966
Fix chmod occurring as wrong user when sudo as non-root
...
If you sudo to a non-root user, you get a permission denied error.
Here's an example:
$ ansible myserver.example.com -m postgresql_db -a "db=mydatabase" -u ubuntu -s -U postgres
myserver.example.com | FAILED >> {
"failed": true,
"msg": "chmod: changing permissions of `/tmp/ansible-
1351092257.96-157699143369671/postgresql_db': Operation not
permitted\n/usr/bin/python: can't open file '/tmp/ansible-
1351092257.96-157699143369671/postgresql_db': [Errno 13]
Permission denied\n",
"parsed": false
}
The problem is that ansible is doing the chmod as the sudo user
when it should be doing it as the remote user.
13 years ago
Michael DeHaan
f1f44843c3
close the pool.
13 years ago
Michael DeHaan
92ce8a0517
Refine new keyboard interrupt handling. Output still a bit gross.
13 years ago
Michael DeHaan
47b1315ac7
Reinstate Ctrl+C handling
13 years ago
Michael DeHaan
a4af4a7049
Since we are not needing to pass runner through the multiprocessing queue, just use
...
multiprocessing.pool. Pushing so it can get wider testing.
13 years ago
Michael DeHaan
856dd5a9aa
Don't pass runner instance through the mulitprocessing queue, fix temp dir removal
13 years ago
Seth Vidal
d63fa6f026
make --limit take a , as a separator as well as ; or :
13 years ago
Michael DeHaan
109632e3bc
Revert "Vars specified via CLI have the highest priority."
...
Reverting as this as reported allows some variables to clobber each other.
We'll work on a different fix.
This reverts commit c5469f6367 .
13 years ago
Daniel Hokka Zakrisson
1449c8ac67
Fix ansible_ssh_host again
...
This time with unit tests to ensure it keeps working.
13 years ago
Daniel Hokka Zakrisson
c9c5fc1456
Merge varFind and varLookup
13 years ago
Michael DeHaan
3c6d9972fe
clarify message about name of configuration parameter
13 years ago
Michael DeHaan
cbc12f0dba
Various performance streamlining and making the file features usable in all modules without daisy chaining.
13 years ago
Michael DeHaan
4104478abd
Added 'script', a module that can push and insantly run a remote script. Replaces the need to copy+command.
...
This is a bit of a rough draft, some error handling still needs to be added.
13 years ago
Michael DeHaan
019f775a93
DWIM the paths for first_available_file
13 years ago
Michael DeHaan
6fa1a49037
Fix the basic templating system such that when the template ends in '$', life continues as normal.
13 years ago
Michael DeHaan
ed9f5eed09
Merge pull request #1338 from alopropoz/extra_vars_override
...
Vars specified via CLI have the highest priority.
13 years ago