Correct placement of right parenthesis.

(serial_pct)/100.0 is a typo - the parentheses should be around the entire percentage calculation, which makes much more sense when multiplying by the number of hosts (luckily BODMAS prevailed).
11 years ago · 4243ce61b3
parent cbf0bd6baf
commit 4243ce61b3
1 changed files with 1 additions and 1 deletions
--- a/lib/ansible/playbook/init.py
+++ b/lib/ansible/playbook/init.py
@ -642,7 +642,7 @@ class PlayBook(object):
            # This is a percentage, so calculate it based on the
            # number of hosts
            serial_pct = int(play.serial.replace("%",""))
-            serial = int((serial_pct)/100.0 * len(all_hosts))
+            serial = int((serial_pct/100.0) * len(all_hosts))

            # Ensure that no matter how small the percentage, serial
            # can never fall below 1, so that things actually happen