Commit Graph

7313 Commits (51a9dd631f85b6e8ca1f83176d7a4679fdcbcca8)

Author SHA1 Message Date
Aleksander Machniak cf51aead63 Larry: Fix regression where menu actions didn't work with keyboard (#6740)
For Elastic remove Space/Enter key handler on menus, so we use
default browser behaviour. Triggering a onclick programatically
causes popup window warning sometimes.
6 years ago
Aleksander Machniak 3719ce0653 Don't use :has selector 6 years ago
Aleksander Machniak 2c38460b09 Make sure an event triggered by Enter key press on a link is treated as a keyboard event 6 years ago
Aleksander Machniak 8c471478f7 Merge branch 'dev/elastic' 6 years ago
Aleksander Machniak f76d9e0c09 Small fix 6 years ago
Aleksander Machniak 67f9f504a3 key ring -> keyring
...for consistence with other places
6 years ago
Aleksander Machniak f3c9699817 Fix so advanced search dialog is not automatically displayed on searchonly addressbooks (#6679) 6 years ago
Aleksander Machniak 45a6ad1ba7 Fix so an error is logged when more than one attachment plugin has been enabled, initialize the first one (#6735) 6 years ago
Aleksander Machniak 593188559a Fix regression where non-terminating errors were sent to the browser 6 years ago
Aleksander Machniak e67765b863 Fix bug where flag change could have been passed to a preview frame when not expected 6 years ago
Aleksander Machniak 55cca61134 Workaround more invalid HTML cases parsed incorrectly by Mastermind/HTML5 (#6713) 6 years ago
Aleksander Machniak 00ef5d05ef Merge branch 'master' into dev/elastic 6 years ago
Aleksander Machniak ce9c52e65a Merge branch 'master' into dev/elastic 6 years ago
Aleksander Machniak 00f94a47bb Rephrase cookiesmismatch text 6 years ago
Aleksander Machniak 850d414443 Don't allow dragging .custom-control elements on folders list 6 years ago
Aleksander Machniak 187b51fd82 Fix bug where parent entry could be selected when clicking on a virtual entry 6 years ago
Aleksander Machniak 70a0976be1 Remove redundant error message 6 years ago
Aleksander Machniak fbb5a5bc4f Small code simplification in raise_error() 6 years ago
Aleksander Machniak 02dc6ce41c Don't init the session in CLI mode
This prevents from PHP warnings when using CLI scripts e.g. installto.sh.
6 years ago
Aleksander Machniak 72ad567db6 Add new line at the end of error message in CLI mode 6 years ago
Aleksander Machniak 00173a7622 Update some code documentation 6 years ago
Aleksander Machniak d8470c6c2b Remove useless "..." suffix 6 years ago
Aleksander Machniak 9c4e2eacab Don't log full session identifiers in userlogins log (#6625)
Log only 16-char prefix.
6 years ago
Aleksander Machniak 32612f0b8f Log some more info with session_debug 6 years ago
Aleksander Machniak c87ac075ae Renamed 'log_session' option to 'session_debug' 6 years ago
Aleksander Machniak f1a83f923d Added cookie mismatch detection, display an error message informing the user to clear cookies 6 years ago
Aleksander Machniak 5218b0193a Clarified 'address_book_type' option behavior (#6680) 6 years ago
Aleksander Machniak 57c67db029 Remove year(s) from copyright headers + some cleanup 6 years ago
Aleksander Machniak 69080457b1 Code simplification 6 years ago
Aleksander Machniak 92ed0154d5 Followup fix on handling HTML content w/o html/head/body tag (#6713) 6 years ago
Aleksander Machniak 03d56926d8 Fix bug in HTML parser that could cause missing text fragments when there was no head/body tag (#6713) 6 years ago
Aleksander Machniak 711e46a018 Force HIGHESTMODSEQ use on dovecot
This may fix some messages cache issues. Dovecot does not return
HIGHESTMODSEQ nor NOMODSEQ metadata on SELECT until it is "forced"
to switch to "permanent mod-seq mode". It can be done either by
ENABLE QRESYNC/CONDSTORE or by requesting the metadata explicitely
on SELECT/STATUS. We'll use STATUS for that.
6 years ago
Aleksander Machniak f0811f6f50 DOn't use deprecated (and slow) selectors 6 years ago
Aleksander Machniak 8036bfafab Fix setting button state when registering it after onload
Also get rid of uibutton support, it's not used anymore.
6 years ago
Aleksander Machniak 6f479096d5 Merge branch 'wash-xml-namespace' of https://github.com/dsoares/roundcubemail into dsoares-wash-xml-namespace 6 years ago
Aleksander Machniak b304782cbc Elastic: Various cross-browser fixes and improvements 6 years ago
Aleksander Machniak a35699637d Fix PHP error when using Net_LDAP3 from master
get_entry() method signature has changed. We don't really needed
that override in rcube_ldap_generic, so it's now removed.
6 years ago
dsoares 00cc13a1b9 Fix bug where HTML messages with a xml:namespace tag were not rendered. 6 years ago
Aleksander Machniak f1e911ec03 Elastic: Toolbar/menus/layout refactoring
Refactoring for better consistency and simplicity.

5KB less in size of (minified) styles.css file.

Layout changes:
- body > #layout > .menu       -> #layout-menu
- body > #layout > .list       -> #layout-list
- body > #layout > .sidebar    -> #layout-sidebar
- body > #layout > .content    -> #layout-content

Toolbar/menu changes:
- .toolbar           -> .toolbar.menu
- .toolbarmenu       -> .menu.listing
- .menu-button       -> .task-menu-button
- .pagenav.toolbar   -> .pagenav.menu
- #taskmenu          -> #taskmenu.menu.toolbar
- .image-tools .menu -> .image-tools .menu.toolbar
- required .disabled class to de-activate menu items
- .button class is not required on .menu children
- merge toolbar.less and taskmenu.less into menu.less
- @color-toolbarmenu-hover            -> @color-menu-hover
- @color-toolbarmenu-hover-background -> @color-menu-hover-background

Also cleaned/removed some code in spellchecker.js. Made .googie_list a list not table.
6 years ago
Aleksander Machniak dbf6e0a81d Improve display_message() for sophisticated 'loading' messages
So it's possible to display more than one message of type 'loading'
at a time and define custom timeout.
6 years ago
Aleksander Machniak f1c40c8aa9 Fix bug where attachment preview didn't work with x_frame_options=deny (#6688) 6 years ago
Aleksander Machniak 27408182b9 Expect skin thumbnails to be in assets 6 years ago
Aleksander Machniak ab7eeb3daa CS fixes 6 years ago
Aleksander Machniak d8488aae32 Disable spellcheker (hide button) if the list of languages is empty
Better handling of uninitialized (not installed) spellchecker engine.
Also prevent from PHP fatal error if enchant ext is not installed.
6 years ago
Aleksander Machniak c827925051 Fix so "Open in new window" consistently displays "external window" interface (#6659)
Both 'show' and 'extwin' will use _extwin=1 argument.
6 years ago
Aleksander Machniak 982919582c Add zh_MO and zh_HK as aliases of zh_TW (#6666)
with CS fixes
6 years ago
Aleksander Machniak 53c37a1321 WS and CS fixes 6 years ago
Boris Rybalkin 2d85dad0cc Support ROUNDCUBE_CONFIG_DIR env variable (#6112) 6 years ago
Aleksander Machniak ab28c4ae26 Fix bug where external content (e.g. mail body) was passed to templates parsing code (#6640)
It should have been part of "Fix so templating system does not mess with external (e.g. email)
content (#5499)" (d02e6ea45e), but it wasn't.
6 years ago
Aleksander Machniak b232886488 Properly cleanup on drag end in treelist widget 6 years ago
Aleksander Machniak 743794f1d8 Treelist: Add possibility to not reset selection on reset() 6 years ago
Aleksander Machniak 5058d36581 Fix bug where next row wasn't selected after deleting a collapsed thread (#6655) 6 years ago
Aleksander Machniak e3e9573391 Fix small issue when quota object does not specify 'title' 6 years ago
Aleksander Machniak cc20de329d Elastic: Use Bootstrap's custom file input
... with localization and some js logic to display selected file(s) in the input.
6 years ago
Aleksander Machniak bca1397927 Fix links to Identities/Responses 6 years ago
Aleksander Machniak e7816ccd36 Elastic: Keep original line wrapping in Message headers dialog 6 years ago
Aleksander Machniak 9b553aa2e0 Elastic: Improve "Mark all as read" dialog style (use .proplist) 6 years ago
Aleksander Machniak 147a2c8611 Elastic: Use appropriate icon for Mark button in "Mark all as read" dialog 6 years ago
Aleksander Machniak 26bce22bff Fix bug when aborting dragging with ESC key didn't stop the move action (#6623)
+ small code improvements
+ focus the list on drag start to make sure it's focused state is up-to-date
  which is needed for proper keypress handling (e.g. ESC key on drag action)
6 years ago
Aleksander Machniak 2373aea95c Elastic: Add style for .part-notice elements (like e.g. .boxwarning) 6 years ago
Aleksander Machniak 7a4aed8320 Move common code to a function 6 years ago
Mario Harjac 136175e445 Fix missing CSRF token in message download (#6621) 6 years ago
Aleksander Machniak 641a67fe75 Elastic: Fix unintentional layout preference overwrite (#6613)
This is actually skin-independent mechanism that prevents overwriting
of skin-specific preferences by ajax requests (that until now were
not aware of skin config).
6 years ago
Aleksander Machniak 43499432a5 Elastic: Fix height of select elements inside of composite fields
also make them pretty when added programatically.
6 years ago
Aleksander Machniak 9d51e40f9e Code cleanup 6 years ago
Aleksander Machniak 0492b1f6e5
HTML5 Upload Progress (#6177) (#6583)
Replaced all old upload progress code in favour of ajax upload progress.
Instead of posting a hidden iframe, we now use AJAX (as we did for drag-n-drop).
Removed code for old browsers. Now we support IE >= 10, Firefox > 4.
Upload progress may not work in some more, but support is quite good.
6 years ago
johndoh 8f62aed866 Create new meta and links template objects, replace favicon (#6611) 6 years ago
Aleksander Machniak fbdaab714b Merge branch 'master' of github.com:roundcube/roundcubemail 6 years ago
Aleksander Machniak c66199ffd2 Add cache busters also to images used by templates (#6610) 6 years ago
Aleksander Machniak 6e74498656 Fix so mime_content_type check in Installer uses files that should always be available (i.e. from program/resources) (#6599) 6 years ago
johndoh fa754c4ebc Elastic: remove hover effect on dropbuttons when primary action is disabled (#6597) 6 years ago
Aleksander Machniak 82974289b9 Fix typo 6 years ago
Aleksander Machniak 6dce805221 Improve last fix so it also remove temp file if Mail_Mime returned an error 6 years ago
Aleksander Machniak 1767b256e4 Fix bug where big messages could not be saved to imap folder in low memory mode 6 years ago
Aleksander Machniak fe5b4fd81d fputs() -> fwrite() 6 years ago
Aleksander Machniak 82c495e6b4 PR cleanup 6 years ago
PhilW e5f5e6576d add some selection options to contacts list 6 years ago
Aleksander Machniak 99ad249f6d Elastic: Add title with full folder name on folders list elements
if displayed folder name is truncated because of overflow.
6 years ago
Aleksander Machniak e876e7b861 Add no-bs class to search form inputs
... so they don't get form-control assigned by Elastic logic
6 years ago
Aleksander Machniak 61eb78ad64 Fix so ANY record is not used for email domain validation, use A, MX, CNAME, AAAA instead (#6581) 6 years ago
Aleksander Machniak e69d1e7f04 Fix so max_message_size limit is checked also when forwarding messages as attachments (#6580) 6 years ago
Aleksander Machniak d7b510978e Fix regressions in attachment rename and attachment title attribute setting 6 years ago
Aleksander Machniak 829395ed13 Improvements in contact import dialog
- Fix Import button state on import errors
- Focus Cancel button on form submission
- Don't reload contacts list when import failed
6 years ago
Thomas Bruederli 2f9ea5e078 Update localizations from Transifex 6 years ago
Thomas Bruederli 3b779a64be Update copyright year 6 years ago
Aleksander Machniak 5693b4f31c Fix bug in parsing some IMAP command responses that include unsolicited replies (#6577) 6 years ago
Aleksander Machniak a7df28093f Make rcube_session::unserialize() public method 6 years ago
Aleksander Machniak 881b344fba Fix regression in vcard parser 6 years ago
Aleksander Machniak 35e2bffb90 Support simple field labels (e.g. LetterHub examples) in csv imports (#6541) 6 years ago
Aleksander Machniak 32a0ad6778 Force session.gc_probability=1 when using custom session handlers (#6560) 6 years ago
Aleksander Machniak 58fd5bc060 Fix get_skin_path() so it always returns main skin path not plugin's 6 years ago
Aleksander Machniak 96c769143a Get rid of (localized) units for memory stats 6 years ago
Aleksander Machniak 8a04d3f993 Fix so performance stats are logged to the main console log also when per_user_logging=true 6 years ago
Aleksander Machniak d3c65d752b Remove useless "return null;" at the end of function block 6 years ago
Stuart Henderson 98349c19f6 Fix typo LOG_EMERGE (#6566) 6 years ago
Aleksander Machniak 7a49b48dc1 Fix handling of empty entries in vCard import (#6564) 6 years ago
Aleksander Machniak 01faf9060c Update localization 6 years ago
Aleksander Machniak b0c83111de Fix rcube_imap_cache in mode set to MESSAGE only 6 years ago
Aleksander Machniak aa7e2febd1 Add 'required' to the list of boolean attributes 6 years ago
Aleksander Machniak 36485dfc34 Prevent from using deprecated timezone names from jsTimezoneDetect
For better interoperability of plugins such as Calendar, for example
issue see: https://git.kolab.org/T2666.
6 years ago
Aleksander Machniak 45618273e0 Fix dummy Message-Id when resuming a draft without Message-Id header (#6548) 6 years ago
Aleksander Machniak 708ceb2ba0 Elastic: Add style for HTML editor content (use embed.css for this) 6 years ago
Aleksander Machniak 943de28d2a Log IMAP/SMTP connection time in debug mode 6 years ago
Aleksander Machniak 4a896b46a7 When requesting a plugin template ignore global skin path(s) 6 years ago
Aleksander Machniak e4b5dc6a41 Remove old fallback to the 'default' skin 6 years ago
Aleksander Machniak c1aa2169f6 Plugin API: Added 'ldap_connected' hook 6 years ago
Aleksander Machniak 394dacc1ae Merge branch 'master' of github.com:roundcube/roundcubemail 6 years ago
Aleksander Machniak cf05a924de Fix inconsistent offset for various time zones - always display Standard Time offset (#6531) 6 years ago
Aleksander Machniak edd9c31d6c Skip registering session handlers when session already exists
.. for a specific use case when I want to create additional rcube_session object
for discrete operations on another session.
6 years ago
Aleksander Machniak 07c5e178de Add some localization files 6 years ago
Aleksander Machniak cb4b1443c8 Update localization 6 years ago
Aleksander Machniak 70657e34b0 Remove unused 'login' command 6 years ago
Aleksander Machniak 0048be10a9 Ignore 'Sender' header on Reply-All action (#6506) 6 years ago
Aleksander Machniak cec626a12f Use 'thumb' prefix, instead of '.thumb' suffix, for consistency 6 years ago
Aleksander Machniak afc68aae63 FIx temp_filename() regressions, update changelog, add note in UPGRADING 6 years ago
PhilW e024f133fa give all temp files a constant prefix 6 years ago
Aleksander Machniak 802ed0dc6d
Create autocomplete popup in a parent window when invoked from an iframe (#6503) 6 years ago
Aleksander Machniak 619ddfed3d CS fixes and consistence, update changelog 6 years ago
Aleksander Machniak 999845d3b2 Merge branch 'limit-skins' of https://github.com/dhoffend/roundcubemail into dhoffend-limit-skins 6 years ago
Aleksander Machniak 42cb98149c Close autocomplete list on scroll event 6 years ago
Aleksander Machniak daf46075d0 Merge branch 'menu_buttons' of https://github.com/johndoh/roundcubemail into johndoh-menu_buttons 6 years ago
PhilW d2c2ddb9a0 code improvement, avoid empty menu_button array entries 6 years ago
PhilW f028ff0c48 remove redundant var 6 years ago
PhilW 99fc4cd387 support multiple buttons for the same menu 6 years ago
Aleksander Machniak 2935b3a66a Fix malformed message saved into Sent folder when using big attachments and low memory limit (#6498) 6 years ago
PhilW 30fb7fc552 store menu buttos by menu id 6 years ago
Aleksander Machniak 7b203cbc52 Fix bug where a message/rfc822 part without a filename wasn't listed on the attachments list (#6494) 6 years ago
Aleksander Machniak c93d11b473 Merge branch 'master' of github.com:roundcube/roundcubemail 6 years ago
Aleksander Machniak ab6b651ac9 - Make menu button inactive if all subactions are inactive (#6444)
Elastic skin only (for now)
6 years ago
Aleksander Machniak 3dad8c5908 Fix incorrect IMAP SASL GSSAPI negotiation (#6308) 6 years ago
Aleksander Machniak c4916a8fe3 Simplify code that uses setError() followed by return 6 years ago
Aleksander Machniak a86d9cd5aa Fix so unicode in local part of the email address is also supported in recipient inputs (#6490)
Relax javascript email address checker.
6 years ago
Aleksander Machniak 186f21c4c1 Avoid Referer leaking by using Referrer-Policy:same-origin header (#6385)
Added 'common_headers' hook
6 years ago
Aleksander Machniak cf7e4f12b2 Stop adding some localization to ajax responses 6 years ago
Aleksander Machniak bec67c29b4 Display storage errors on refresh/check-recent action (#6474) 6 years ago
Aleksander Machniak 0fa9ad11d6 Remove useless href=# on menu items 6 years ago
Daniel Hoffend 8b2e466c00 limit skins available/shown in the settings section 6 years ago
Aleksander Machniak a4ebec90d6 Merge branch 'dev/elastic' 6 years ago
Aleksander Machniak f28971c95c The localization label can also contain underscore char 6 years ago
Aleksander Machniak ccff7c8313 Support returning jqXHR object from request* event handler 6 years ago
Aleksander Machniak c8d133a6a0 Merge branch 'master' into dev/elastic 6 years ago
Aleksander Machniak b126941846 Fix session issue on long running requests (#6470) 6 years ago
Stefanos Petrakis 8ab1e4fbc3 Fix multiple VCard field search (#6466) 6 years ago
Aleksander Machniak 15c6a1754d Elastic: Shift+Tab on mail compose editor scrolls the page to the top (#6413) 6 years ago
Aleksander Machniak 91b5bffd3c Fix bug where autocomplete list could be displayed out of screen (#6469) 6 years ago
Aleksander Machniak 0a0ac045fe Fix bug where valid content between HTML comments could have been skipped in some cases (#6464) 6 years ago
Aleksander Machniak 6dfb475a26 Elastic: Redesign mail compose page - use recipient selection dialog (#6413) 6 years ago
Aleksander Machniak 255638cc44 Update changelog, require Net_SMTP 1.8.1 for GSSAPI support 6 years ago
urusha 75f37f8b0f SMTP GSSAPI support (#6417)
* krb_authentication support for smtp_connect
* smtp GSSAPI support
6 years ago
Aleksander Machniak 2dcf50019c Merge branch 'master' into dev/elastic 6 years ago
Aleksander Machniak e38b477b99 Fix including plugin scripts (regression) 6 years ago
Aleksander Machniak 2c12274d38 Fix style/navigation on error page depending on authentication state (#6362) 6 years ago
Aleksander Machniak e5c6c4f3f3 Elastic: Improved folder name input for special folders 6 years ago
Aleksander Machniak 2bf80b180c Update changelog 6 years ago
Aleksander Machniak 4310046993 Remove redundant trim() 6 years ago
Aleksander Machniak a8542e9c08 Elastic: Add title to taskmenu entries with too long labels (#6392) 6 years ago
Aleksander Machniak c28242f63c Log errors caused by low pcre.backtrack_limit when sending a mail message (#6433) 6 years ago
Aleksander Machniak 03fef0d6ca New_user_identity: Fix %fu/%u vars substitution in user specific LDAP params (#6419) 6 years ago
Aleksander Machniak 796e5a17e6 Removed referer_check option (#6440) 6 years ago
Aleksander Machniak d868297a0a Elastic: Improved UX of search dialogs (#6416)
No onchange event handlers on selects, start searching only on Search button click.
6 years ago
Aleksander Machniak fe420a4e9e Update to TinyMCE 4.8.2 6 years ago
Aleksander Machniak eaa81a5b61 Fix so invalid smtp_helo_host is never used, fallback to localhost (#6408) 6 years ago
Allan Klaus 6a49ba5aa2 Added exec_hook to send error to an external error tracking tool (#6198) 6 years ago
Aleksander Machniak 5cdb54221f Fix listing the same attachment multiple times on forwarded messages 6 years ago
Thomas Bruederli 728c186943 Deprecate debug_level config option 6 years ago
Aleksander Machniak adcac3b9de Fix CSS issue in handling invalid style tag content (#6410) 6 years ago
Aleksander Machniak 5643b6315e Small improvements 6 years ago
Aleksander Machniak 75fd0a73cb Register 'uploading' label globally 6 years ago
Aleksander Machniak 24e3977d74 Fix invalid regular expressions that throw warnings on PHP 7.3 (#6398) 6 years ago
Aleksander Machniak 19332495b0 Fix so fallback from BINARY to BODY FETCH is used also on [PARSE] errors in dovecot 2.3 (#6383) 6 years ago
Aleksander Machniak 988ed7e565 Fix PHP warnings on dummy QUOTA responses in Courier-IMAP 4.17.1 (#6374) 6 years ago
Aleksander Machniak 22ad707b8c Make 'messageerror' template optional, remove it for Elastic 6 years ago
Aleksander Machniak be675bb4a5 Make copyright and license notice a template objects 6 years ago
Aleksander Machniak 93965fa79c Get rid of outdated supported browsers list in the error page
We anyway check only for javascript and xmlhttprequest support
6 years ago
Aleksander Machniak eefbbb6749 Fix detecting the opener window (#6319) 6 years ago
Aleksander Machniak 4f2b795cd2 Fix doc for 3rd argument of rcube::deliver_message() (#6353) 6 years ago
Aleksander Machniak 70ffc252bf Merge branch 'dev/elastic' 6 years ago
Aleksander Machniak cba1605949 Add http_only argument to rcube_utils::setcookie() 6 years ago
Aleksander Machniak 7e8299cd53 Remove debug code 7 years ago
Aleksander Machniak 631ae17ee3 Allow plugins to set class attribute for preferences section 7 years ago
Aleksander Machniak 9eba51e23b Merge branch 'master' into dev/elastic 7 years ago
Aleksander Machniak 086e781b8f Fix bug where some HTML comments could have been malformed by HTML parser (#6333) 7 years ago
johndoh 4ea790ba37 Extend skin_logo allowing per skin logos (#6273) 7 years ago
Aleksander Machniak c826fd502d Fix focus on the editor when switching modes 7 years ago
Aleksander Machniak 338486348e Fix adding uploaded images to image selector list 7 years ago
Aleksander Machniak 8ed053ccb7 Merge branch 'master' into dev/elastic 7 years ago
Aleksander Machniak e57582baf0 Fix image upload dialog for signatures 7 years ago
Aleksander Machniak 006fed33d3 Elastic: Completed TinyMCE styling 7 years ago
Aleksander Machniak 00acb46411 Update to TinyMCE 4.7.13, refactor image selector dialog, add style for Elastic skin 7 years ago
Aleksander Machniak 44d0824585 Merge branch 'master' into dev/elastic
Conflicts:
	skins/elastic/styles/widgets/mail.less
7 years ago
Aleksander Machniak fd7d7faabd Improve checking folder delete rights according to RFC 4314 7 years ago
Aleksander Machniak 58e514970e Add option to hide folders in share/other-user namespace or outside of the personal namespace root (#5073) 7 years ago
Aleksander Machniak 5e3868eb10 Fix so attachment without Content-ID is not an inline attachment (#5905) 7 years ago
Aleksander Machniak 5fd1b52f01 Update de_DE localization 7 years ago
Aleksander Machniak e9d38e847c Re-add setting error_log=syslog when log_driver=syslog 7 years ago
Aleksander Machniak 4d47fb6f0b Replace Save with Import button in messages import form 7 years ago
Aleksander Machniak c611ace9a2 Update German localization 7 years ago
Aleksander Machniak 6d0b30d456 Fix bug where messages list was not updated after moving ALL messages (#6310) 7 years ago
Aleksander Machniak 3d0b2cd3ce Pass PEAR errors to rcube::raise_error(), small CS improvements 7 years ago
Aleksander Machniak 12b1b54792 Fix bug where after "mark all folders as read" action message counters were not reset (#6307)
also fixed one PHP 7.2 warning
7 years ago