Renamed 'log_session' option to 'session_debug'

CHANGELOG

@@ -4,6 +4,7 @@ CHANGELOG Roundcube Webmail
 - Update to jQuery 3.4.0
 - Clarified 'address_book_type' option behavior (#6680)
 - Added cookie mismatch detection, display an error message informing the user to clear cookies
+- Renamed 'log_session' option to 'session_debug'
 - Password: Added ldap_exop driver (#4992)
 - Elastic: Add Prev/Next buttons on message page toolbar (#6648)
 - Elastic: Close search options on Enter key press in quick-search input (#6660)

config/defaults.inc.php

@@ -98,8 +98,8 @@ $config['smtp_log'] = true;
 // Log successful/failed logins to <log_dir>/userlogins or to syslog
 $config['log_logins'] = false;
 
-// Log session authentication errors to <log_dir>/session or to syslog
-$config['log_session'] = false;
+// Log session debug information/authentication errors to <log_dir>/session or to syslog
+$config['session_debug'] = false;
 
 // Log SQL queries to <log_dir>/sql or to syslog
 $config['sql_debug'] = false;

program/lib/Roundcube/rcube_config.php

@@ -50,6 +50,7 @@ class rcube_config
         'min_refresh_interval' => 'min_keep_alive',
         'messages_cache_ttl'   => 'message_cache_lifetime',
         'mail_read_time'       => 'preview_pane_mark_read',
+        'session_debug'        => 'log_session',
         'redundant_attachments_cache_ttl' => 'redundant_attachments_memcache_ttl',
     );
 

program/lib/Roundcube/rcube_session.php

@@ -83,6 +83,8 @@ abstract class rcube_session
     }
 
     /**
+     * Object constructor
+     *
      * @param Object $config
      */
     public function __construct($config)
@@ -93,8 +95,8 @@ abstract class rcube_session
         $this->set_ip_check($this->config->get('ip_check'));
 
         // set cookie name
-        if ($this->config->get('session_auth_name')) {
-            $this->set_cookiename($this->config->get('session_auth_name'));
+        if ($name = $this->config->get('session_auth_name')) {
+            $this->set_cookiename($name);
         }
     }
 
@@ -128,7 +130,7 @@ abstract class rcube_session
     {
         $this->start   = microtime(true);
         $this->ip      = rcube_utils::remote_addr();
-        $this->logging = $this->config->get('log_session', false);
+        $this->logging = $this->config->get('session_debug', false);
 
         $lifetime = $this->config->get('session_lifetime', 1) * 60;
         $this->set_lifetime($lifetime);