Remove useless href=# on menu items

6 years ago · 0fa9ad11d6
parent 0551b0f9c4
commit 0fa9ad11d6
1 changed files with 4 additions and 2 deletions
--- a/program/include/rcmail_output_html.php
+++ b/program/include/rcmail_output_html.php
@ -1590,12 +1590,14 @@ EOF;
        }

        // overwrite attributes
-        if (!$attrib['href']) {
+        if (!$attrib['href'] && !$menuitem) {
            $attrib['href'] = '#';
        }
+
        if ($attrib['task']) {
-            if ($attrib['classact'])
+            if ($attrib['classact']) {
                $attrib['class'] = $attrib['classact'];
+            }
        }
        else if ($command && !$attrib['onclick']) {
            $attrib['onclick'] = sprintf(