Don't log full session identifiers in userlogins log (#6625)

Log only 16-char prefix.
pull/6724/head
Aleksander Machniak 5 years ago
parent 32612f0b8f
commit 9c4e2eacab

@ -6,6 +6,7 @@ CHANGELOG Roundcube Webmail
- Added cookie mismatch detection, display an error message informing the user to clear cookies
- Renamed 'log_session' option to 'session_debug'
- Password: Added ldap_exop driver (#4992)
- Don't log full session identifiers in userlogins log (#6625)
- Elastic: Add Prev/Next buttons on message page toolbar (#6648)
- Elastic: Close search options on Enter key press in quick-search input (#6660)
- Elastic: Changed read/unread icons (#6636)

@ -1145,6 +1145,9 @@ class rcmail extends rcube
return;
}
$session_id = session_id();
$session_id = $session_id ? (substr($session_id, 0, 16) . '...') : 'no-session';
// failed login
if ($failed_login) {
// don't fill the log with complete input, which could
@ -1154,7 +1157,7 @@ class rcmail extends rcube
}
$message = sprintf('Failed login for %s from %s in session %s (error: %d)',
$user, rcube_utils::remote_ip(), session_id(), $error_code);
$user, rcube_utils::remote_ip(), $session_id, $error_code);
}
// successful login
else {
@ -1166,7 +1169,7 @@ class rcmail extends rcube
}
$message = sprintf('Successful login for %s (ID: %d) from %s in session %s',
$user_name, $user_id, rcube_utils::remote_ip(), session_id());
$user_name, $user_id, rcube_utils::remote_ip(), $session_id);
}
// log login

Loading…
Cancel
Save