Michael DeHaan
fb13e2bf2e
Merge pull request #8853 from kvar/devel
...
zypper: handle lists of packages efficiently
11 years ago
James Cammarata
503f7afbd8
Merge branch 'hfinucane-gh-7432' into devel
11 years ago
James Cammarata
61c76245da
Don't printout async callbacks when the task is skipped
11 years ago
James Cammarata
178075489b
Merge branch 'gh-7432' of https://github.com/hfinucane/ansible into hfinucane-gh-7432
11 years ago
Michael DeHaan
d6e6d2a6ca
Remove regex related to baby-JSON parsing only.
11 years ago
Michael DeHaan
d9e0a5ed22
Use correct keyword for this function.
11 years ago
Michael DeHaan
26cdddaebf
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
11 years ago
James Cammarata
e54178f904
Catch additional errors in fetch_url
...
Fixes #8971
11 years ago
James Cammarata
dacb6b8561
Use utils.merge_hash() instead of update for cache merging
...
Fixes #8968
11 years ago
James Cammarata
317ab06bc6
Fixing multiline parsing to preserve newlines
...
Fixes #8813
11 years ago
James Cammarata
a571fd4efe
Convert boolean strings from set_fact to proper boolean values
...
Also adds integration tests for booleanification of strings
Fixes #8629
11 years ago
James Cammarata
8708a00cbd
Fix typo in redis cache change from 10afaee1
11 years ago
Michael DeHaan
2064d26085
Add documentation about bin_ansible_callbacks setting. Standardization and cleanup.
11 years ago
Will Thames
d6a725659e
Allow github style ssh repo names
11 years ago
Will Thames
537472f42c
Make ansible-galaxy work as expected
...
This change fixes hg galaxy roles
Roles also get installed if roles path is missing, which
the tests currently require (fixes #8950 )
11 years ago
James Cammarata
10afaee108
Fixing new caching related issue with host vars
...
The vars_cache was not being properly merged with the setup_cache
for all hosts, which was previously not noticed when registered
variables were stored in the setup_cache.
Fixes #8944
11 years ago
Serge van Ginderachter
69740b86e8
Allow InventoryScript JSON with childgroups only
...
and without hosts and vars
Without this patch, the simplified syntax is triggered when a group
is defined like this:
"platforms": {
"children": [
"cloudstack"
]
}
Which results in a group 'platforms' with 1 host 'platforms'.
modified: lib/ansible/inventory/script.py
11 years ago
James Cammarata
dc1f233e8d
Merge pull request #8923 from nfelger/devel
...
Fixing issue with symlinked vaults
11 years ago
James Cammarata
c610783f90
Merge pull request #8911 from bbasleeper/devel
...
Adding a new 'load_callback_plugins' config option, defaults to False
11 years ago
Niko Felger
fa74a5c806
Fixing issue with symlinked vaults
11 years ago
James Cammarata
1711df3b75
Allow complex_args to be None
11 years ago
Bruno BAILLUET
16108e4a99
Adding a new 'load_callback_plugins' config option, defaults to False
...
This option, when set to True, allows "ansible" command to load callback plugins
11 years ago
James Cammarata
8cc3543918
Re-allow templating of complex_args, but count params to prevent injection
...
Fixes #8810
11 years ago
James Cammarata
8bafc646cb
Disable custom https handler for fetch_url on older pythons
...
Fixes #8898
11 years ago
Toshio Kuratomi
8233522a7a
Reduce commenting as basic.py is copied to the remote host with every module transfer.
...
Move some comments to the unittest as we might look at that if we decide
to refactor the code.
11 years ago
Toshio Kuratomi
1afc8161a1
New password obfuscation in syslog messages that:
...
* makes speed acceptable for some datasets
* obfuscates multiple detected passwords
* obfuscates more characters to account for some corner cases when
trying to detect passwords.
Fixes #8364
11 years ago
Toshio Kuratomi
4f55bcc298
Standardize on bytes internally to _log_invocation
11 years ago
Michael Scherer
53830123fd
Make ssh debug easier to read and paste
...
Currently, ansible -vvvv show the following:
hostname EXEC ['ssh', '-C', '-vvv', '-o', 'ControlMaster=auto',
This is not good if someone want to cut and paste it to see if something
is wrong with the command line, so join the dictionnary strings with spaces
to have 1 string in the output.
11 years ago
James Cammarata
cd99821f8a
Fix py26 difference in ssl socket connect call from 99ba9d6
11 years ago
James Cammarata
14b8e2cf01
Make sure set_fact variables go into VARS_CACHE
...
Fixes #8758
11 years ago
James Cammarata
893f15b30b
Merge pull request #8856 from sivel/memcached-factcache-improvements
...
Memcached factcache improvements
11 years ago
Matt Martz
9bc9145abd
Compress all data inserted into memcached to avoid memcached size limits
11 years ago
Matt Martz
2a4079eeb6
Update format fields to work with python2.6
11 years ago
James Cammarata
b827f791e1
Merge pull request #8832 from sivel/rax-validate-regions
...
rax modules: Perform region validation early
11 years ago
James Cammarata
f44957de5c
Merge pull request #8818 from Erethon/devel
...
Handle exceptions during config file parsing
11 years ago
James Cammarata
35dfbff2e1
Merge pull request #8817 from meatballhat/support-sunos-certs-location
...
Supporting SSL cert location on SunOS (SmartOS, really)
11 years ago
Matt Martz
55ed4489e3
Perform region validation early to be more explicit about invalid region failures
11 years ago
Kristofor Varhus
acd37c87a9
zypper: handle lists of packages efficiently
11 years ago
Henry Finucane
36632c9529
Ensure ansible_job_id exists even for not-started jobs
11 years ago
Dionysis Grigoropoulos
f948b4f293
Handle exceptions during config file parsing
...
Handle uncaught exceptions during config file parsing
11 years ago
Dan Buch
290f2759e1
Supporting SSL cert location on SunOS (SmartOS, really)
11 years ago
Trond Hindenes
72760f5999
All changes referenced in PRs #8767 , #8768 , #8769 :
...
This changes the get-attr function slightly, and lets the module specify whether a param is needed and auto-fails if it is not present. A module can now verify params like so::
$params = Parse-Args $args;
$result = New-Object psobject;
Set-Attr $result "changed" $false;
$path = Get-Attr -obj $params -name path -failifempty $true -resultobj $result
or
$params = Parse-Args $args;
$result = New-Object psobject;
Set-Attr $result "changed" $false;
$path = Get-Attr -obj $params -name path -failifempty $true -emptyattributefailmessage "Oh man. You forgot the main part!" -resultobj $result
slight tweak in how the powershell module converts to json in order to support nested objects (allows for more complex facts, among others)
This script gathers some extended facts on windows hosts in a json array attribute called "ansible_interfaces". This info is needed for some network-related modules I'm working on. Required the update to powershell.ps1 to return deeply nested json objects.
11 years ago
James Cammarata
dbc980eaf4
Merge branch 'mischapeters-devel' into devel
11 years ago
Chris Church
2ddab7affc
Merge pull request #8793 from cchurch/powershell3_compat
...
Replace Get-FileHash with MD5 code that works on PowerShell 3.
11 years ago
James Cammarata
70ff6d35aa
A10 module improvements
...
* moved common code to an module_util snippet
* rewrote logic to make each module idempotent
* added new capabilities like the write_config option
11 years ago
Michael DeHaan
b7082677de
Merge pull request #8790 from sivel/issue/8784
...
Don't use ternary if statements. Fixes #8784
11 years ago
James Cammarata
7fbdbcdec7
Default fetch_url to use TLSv1 instead of SSLv2/3
11 years ago
James Cammarata
ab495d1916
Set the shell variable on the ssh connection type for accelerated mode
...
Fixes #8799
11 years ago
James Cammarata
99ba9d6e24
Default fetch_url to use TLSv1 instead of SSLv2/3
11 years ago
Chris Church
0d1197a995
Replace Get-FileHash with MD5 code that works on PowerShell 3.
11 years ago
Brian Coca
88daac4971
ternary filter
11 years ago
Matt Martz
2b307985bc
Don't use ternary if statements. Fixes #8784
11 years ago
James Cammarata
a6ad374668
Use split_args directly to check for omitted params
11 years ago
James Cammarata
04da466c7b
Fixing up serialize_args utility function
11 years ago
James Cammarata
e99db078b4
Additional fixes for the new omit parameter variable
11 years ago
Victor Lin
fe88ba7c8d
Undo changes to filter module
11 years ago
Victor Lin
559c04f324
Implement omit for module args, also add tests for it
11 years ago
Victor Lin
bce6642ab6
Implement default omit correctly
11 years ago
Victor Lin
0b4d7f1574
Implement default omit filter
11 years ago
James Cammarata
ed34cee36f
Atomically move known hosts file into place for paramiko connections
...
Redo of original patch, which adds an additional check to ensure the
known_hosts file isn't trampled when host_key_checking is disabled.
Fixes #8169
11 years ago
James Cammarata
811ff49f78
Updating CHANGELOG for new symbolic mode feature and updating file docs
11 years ago
James Cammarata
c21c66c740
Merge branch 'file_symbolic_mode' of https://github.com/pbitty/ansible into pbitty-file_symbolic_mode
11 years ago
y_nk
affdadda25
handling case of space in path (given would start with single quote)
11 years ago
Chris Church
57dee4545b
Make sure cmd is UTF8 encoded before splitting. Fixes regression introduced by 80df2135e9.
11 years ago
Michael DeHaan
a419ffdf41
Make command warnings off by default to minimize surprises.
11 years ago
Michael DeHaan
b44e22aa68
Merge pull request #8722 from cmbaughman/devel
...
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
11 years ago
Michael DeHaan
fcb610dec4
Slightly trim down the warnings list based on some things being pretty common
...
for local usage.
11 years ago
Will Thames
ab8490d003
Added warnings to command module
...
Generate warnings when users are shelling out to commands
rather than using modules
Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.
Print out warnings using the standard playbook callbacks.
Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
11 years ago
Chris Baughman
07f12539ee
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
11 years ago
Michael DeHaan
8a0045baad
Update tests for ansible-galaxy CLI additions.
11 years ago
Michael DeHaan
d87830e1cc
Merge branch 'galaxy_github_archive' of git://github.com/willthames/ansible into devel
...
Conflicts:
lib/ansible/utils/__init__.py
11 years ago
James Cammarata
d01188033f
Checking for localized versions of the su password prompt
...
Fixes #8681
11 years ago
Michael DeHaan
0286c31e85
Assume master branch for downloads if not specified.
11 years ago
Michael DeHaan
0cd40fc372
Remove debug
11 years ago
Will Thames
850963790d
Allow roles to be installed from archives on github
...
Ensure that the automated scm determination for github.com
repos still copes with .tar.gz archive files.
Handling .zip archives is left as an exercise for the interested reader
11 years ago
James Cammarata
3b19b83806
Add GovCloud region to list of regions for AWS
...
Fixes #8604
11 years ago
Michael DeHaan
bcb44276fe
Assume github.com URLs are git protocol if not specified.
11 years ago
Michael DeHaan
68e21aa4b0
Add comments about what these new functions do.
11 years ago
Will Thames
6e9abefc11
Corrected bug where role_path was wrong for roles in subdirectories
...
Fixed role name for
- { role: 'lives/in/a/subdirectory' }
Should be 'lives/in/a/subdirectory', not just 'subdirectory'
11 years ago
Will Thames
ada9074276
Allow installation of roles from yaml roles file
...
Added docs
Added more tests
Improved how roles are returned from the parsers
11 years ago
Will Thames
46b59b02ed
Friendly Role Names and roles from URLs
...
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
11 years ago
Will Thames
4803e923ff
Improved handling of role_version in repo_url_to_role_name
11 years ago
Will Thames
1803976a40
Ensured that role version can be specified in role dependencies
11 years ago
Will Thames
c2fe33f9f4
Tidied up a little, added tests
...
Moved repo_url_to_role_name to common method in ansible.utils
Added unit test for repo_url_to_role_name
Added integration tests for galaxy
11 years ago
Will Thames
b550cb9bc3
Need to take URLs into account when running playbooks too
...
Ensure that if meta/main.yml has dependencies containing URLs
these are correctly resolved at playbook runtime.
Update role_name during run time so that output of e.g. task names
look sensible
11 years ago
James Cammarata
bae73e5793
Merge branch 'alozovskoy-alozovskoy-debug-ascii-patch' into devel
11 years ago
James Cammarata
4fafd3baa8
Add error checking around json.dumps when not forcing ascii mode
11 years ago
James Cammarata
ea5db1818d
Merge branch 'role_path_var' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-role_path_var
11 years ago
James Cammarata
24c4277479
Remove tabs added from 677de07
11 years ago
James Cammarata
5e240fec71
Merge branch 'devel' of https://github.com/l1k/ansible into l1k-devel
...
Conflicts:
test/integration/roles/test_copy/tasks/main.yml
11 years ago
James Cammarata
b81e77cfec
Tweak error language in dict validation
11 years ago
Serge van Ginderachter
3a228b9d55
InventoryScript: better syntax checking for json stream
11 years ago
Serge van Ginderachter
b8d057296a
variable merging: detect if both vars are really dicts when combining/merging dicts
11 years ago
Serge van Ginderachter
7051cdeb57
roles: make role_path (path of current role) available as variable to the task
11 years ago
James Cammarata
8a1fbed5d6
Correct variable blending from vars_files with hostvars in them
...
Fixes #8638
11 years ago
Serge van Ginderachter
a1f09bd89f
Merge variables for hosts instead of updating in get_variables()
11 years ago
James Cammarata
cecfede85f
Merge remote-tracking branch 'svg/issue_8621_8664' into svg_issue_8621_8664
12 years ago
James Cammarata
d4ff0d125a
Make sure password files from lookups are created with restrictive permissions
...
Also adds checks for the lookup integration test for passwords.
Fixes #8652
12 years ago
James Cammarata
3a7aca6066
Fix no_log value for content in common file args settings
...
Also adds a test to ensure the content value is not logged.
Related to #8647
12 years ago
James Cammarata
8a5675ca9f
Fixing no_log for the playbook level use
...
Fixes #8647
12 years ago
Serge van Ginderachter
0ab721d51e
better logic for all-group variables for implicit localhost
12 years ago
Serge van Ginderachter
3c06833302
group_by: make sure new group has bigger priority than all group
12 years ago
Serge van Ginderachter
a2cfe8770b
Inventory: fix logic mistake in loading/retrieving variables for groups
12 years ago
James Cammarata
ca6db40cb4
When serializing inventory, pop from the start of the hosts list
...
Fixes #8646
12 years ago
James Cammarata
c8494cdc39
Set prompt encoding to a sane value when sys.stdout.encoding is None
...
Fixes #8644
12 years ago
James Cammarata
379e31883c
Fix check mode issues with copy module
...
Fixes #8639
12 years ago
James Cammarata
542f07128e
Correct check for role library/ existence
...
Fixes #8633
12 years ago
James Cammarata
e3895840d1
Make sure group_vars/all is loaded for ungrouped hosts
...
Fixes #6563
12 years ago
Lukas Wunner
677de07f44
Try optimistic chown, do not error out if not permitted to chown
...
Add unit test
12 years ago
James Cammarata
8dafacd4e9
Make env param a dict type instead of list
...
Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.
Fixes #8199
12 years ago
Michael DeHaan
3035f2dcc8
Merge pull request #8367 from msabramo/make_pip_install_editable_work
...
Make `pip install -e` work
12 years ago
James Cammarata
54cbe3dcf9
Disallow args: to be specified as a string
12 years ago
James Cammarata
600a4657b4
Catch error in atomic_move when creating temporary file
...
Fixes #8480
12 years ago
James Cammarata
ee18c557ec
Load group_vars for new groups loaded via add_host
...
Fixes #8605
12 years ago
James Cammarata
b4476c238f
Use match() instead of search() for pattern matching
...
Also related to f48fa3, fix for #8614
12 years ago
James Cammarata
f48fa3759a
Fix host pattern matching and enhance error detection
...
Fixes #8614
12 years ago
James Cammarata
a01d97f12b
Fixing variable name bug introduced in ac8950f
...
Fixes #8617
12 years ago
James Cammarata
bea0845322
Fix vault_password positional args error
12 years ago
Lukas Wunner
f4053fcf3a
Only chown on atomic move if invoked as root
...
Linux and BSD derivatives do not allow unprivileged users to
"give away" files to others for security reasons. (System V
derivatives allow that but they're rare nowadays.)
12 years ago
Cristian Ciupitu
b6261d05b0
Fix typo: & -> and
...
`and` is the boolean operator for AND in [Python][1].
`&` is the bitwise operator for AND in [Python][2].
[1]: https://docs.python.org/2/reference/expressions.html#boolean-operations
[2]: https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations
12 years ago
Michael DeHaan
99c39b1ff3
By popular request, make the no_log attribute also censor tasks from callbacks.
12 years ago
James Cammarata
fc7859f445
Make sure playbook_dir variable is an absolute path
...
Fixes #8317
12 years ago
James Cammarata
4940a7ad77
Merge pull request #8458 from Jmainguy/runner_8404
...
Fixes 8362, returns stderr if No space left on device
12 years ago
James Cammarata
ac8950fd36
Set special vars in play.vars rather than load_vars
...
Also refactors playbook loading code relating to vars in playbooks
to a sub-function.
Fixes #8534
12 years ago
Jakub Paweł Głazik
99a339fa7b
Fix comments and error message
12 years ago
Jakub Paweł Głazik
58feee0f45
ansible-vault view - new command
12 years ago
James Cammarata
783a1e3dfc
Fixing broken patch 20957a1
...
Also adds integration tests for nested includes with conditionals
12 years ago
Michael DeHaan
02b0e102e6
Rename some INI keys for fact caching defaults
12 years ago
James Cammarata
20957a1b85
Remove duplicate compiling of task when: statements
...
Fixes #8538
12 years ago
James Cammarata
83fa9a8cde
Make sure we only use unquote on quoted lines in lineinfile when needed
12 years ago
Michael DeHaan
542aaa6ffe
Use JSON instead of pickles for compatibility.
12 years ago
Michael DeHaan
2629cd3fce
Fix some copyrights, fix a misc test.
12 years ago
Michael DeHaan
533fb21586
Add copyright header, let me know if corrections are needed.
12 years ago
Michael DeHaan
bdee1ff24e
Standardize exception handling
12 years ago
Josh Drake
a620ef414e
Implement connection pooling for memcached cache plugin.
12 years ago
Josh Drake
3031247492
Use cPickle in redis fact caching backend.
12 years ago
Josh Drake
917e868f65
Implement fact cache flushing alongside a command-line argument to invoke it.
12 years ago
Josh Drake
aa419044c4
WIP on the re-implementation of fact caching and various backends.
12 years ago
Michael DeHaan
fb5a1403dd
Merge
12 years ago
Michael DeHaan
56f9328f93
Merge
12 years ago
James Cammarata
25e9d1197e
Merge branch 'optimise_utils_clean_data' of https://github.com/leth/ansible into leth-optimise_utils_clean_data
12 years ago
James Cammarata
a650421e39
Catch task parameter splitting errors nicely
...
Fixes #8481
12 years ago
James Cammarata
9f34ea54f5
Correct parser to ignore escaped quotes when not in quotes already
...
Related to #8481
12 years ago
Marcus Cobden
c47d1f5265
Pre-load whole string and use seek to alter tags
12 years ago
Marcus Cobden
c8bfd157f8
Switch cStringIO to StringIO for unicode support
...
The performance difference isn't too bad
12 years ago
Marcus Cobden
84114e5c0b
Fix copy/paste error
12 years ago
Marcus Cobden
ef65d3dbf6
Optimise string handling in ansible.utils._clean_data
12 years ago
Michael DeHaan
e01d5f9d84
Revert "Added cross-platform uptime fact" since causing failures on Ubuntu.
...
This reverts commit 14a9966984 .
Conflicts:
lib/ansible/module_utils/facts.py
12 years ago
Michael DeHaan
ea53576759
Merge pull request #6777 from GuiGui2/devel
...
Setup module: Additional facts when using ansible with Linux on System z
12 years ago
Michael DeHaan
5d05049ee1
Merge pull request #7670 from dagwieers/patch-3
...
Added cross-platform uptime fact
12 years ago
Michael DeHaan
c56ce4c913
Merge pull request #8334 from veeti/cfg-vars
...
Expand variables in configuration files, take two
12 years ago
Michael DeHaan
a48328fa12
Merge pull request #7725 from slapers/network-secondaries-issue
...
fix incorrect secondary ip handling, fixes #7724
12 years ago
hoettle
4243ce61b3
Correct placement of right parenthesis.
...
(serial_pct)/100.0 is a typo - the parentheses should be around the entire percentage calculation, which makes much more sense when multiplying by the number of hosts (luckily BODMAS prevailed).
12 years ago
Howard Oettle
cbf0bd6baf
playbook: permit the serial attribute to be a pecentage string as well as well as a straight integer
12 years ago
James Cammarata
63bf2f6d9a
Preserve all line breaks in literal blocks
...
Fixes #8512
12 years ago
Michael DeHaan
d0205b2878
Merge pull request #8500 from sivel/rax-de-dupe
...
rax: Move additional shared code into module utils
12 years ago
Michael DeHaan
03d150de35
Merge pull request #8020 from msabramo/error_when_private_key_file_permissions_incorrect
...
Error if private_key_file is group/world readable
12 years ago
Michael DeHaan
8c4161d4a1
Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
...
Conflicts:
lib/ansible/inventory/vars_plugins/group_vars.py
plugins/callbacks/mail.py
12 years ago
Michael Peters
3ba516ac25
adding min() and max() filters for use in Jinja templates
12 years ago
Michael DeHaan
48a0236ec6
Merge pull request #6619 from sergevanginderachter/ansible_version_var
...
Introduce an ansible_version dict as runner variable
12 years ago
Michael DeHaan
66eddfd491
Merge branch 'nova-compute-enhancements' of git://github.com/emonty/ansible into devel
...
Conflicts:
lib/ansible/module_utils/openstack.py
library/cloud/nova_compute
12 years ago
Michael DeHaan
b413a7d7f3
Merge pull request #8449 from emonty/feature/openstack-auth-handling
...
Handle auth arguments across openstack modules consistently
12 years ago
Michael DeHaan
2f7d405fd9
Merge pull request #8510 from sergevanginderachter/inventorydir_yacc
...
InventoryDir: fixing yet another corner case
12 years ago
Serge van Ginderachter
7c96f1d803
InventoryDir: fixing yet another corner case
12 years ago
James Cammarata
d4cedfc7f1
Fix missing variable initialization for async jid
...
Fixes #8491
12 years ago
Michael DeHaan
fc40e6be81
Merge pull request #8488 from bekimb/docstring_basic_module
...
Keep docstring up to date with the code in basic module
12 years ago
James Cammarata
e19ed3424d
Make sure default vars are used in template calls for tasks
...
Fixes #8499
12 years ago
James Cammarata
4a157a72a0
Catch auth errors in winrm and properly raise errors
...
Fixes #7875
12 years ago
Bekim Berisha
5272e1099d
Keep docstring up to date with the code in basic module
12 years ago
Matt Martz
7d0eba19ab
Dedupe PTR record related code in rax_dns_record
12 years ago
Matt Martz
88acb48753
Add ANSIBLE_VERSION to module_utils/basic.py and manipulate the pyrax user-agent
12 years ago
Matt Martz
585fd5a138
Move additional rackspace common code into module_utils/rax.py
12 years ago
James Cammarata
ba4693051b
Removing leftover import of atomic_move
12 years ago
James Cammarata
efbad90ef8
Revert "Atomically move known hosts file into place when edited by paramiko connections"
...
This reverts commit bd49a835b4 .
12 years ago
James Cammarata
a45c3b84f3
Avoid templating raw lookup strings
12 years ago
James Cammarata
d134b8a83c
Version bump for 1.8
12 years ago
Alexander Lozovskoy
5165dfa2df
Issue with printing unicode non-english characters #8425 patch
12 years ago
Michael DeHaan
1c6398dd3b
Resolve option conflict differently.
12 years ago
Michael DeHaan
b4b115cd13
File common arguments should not be used in all docs pages.
12 years ago
Michael DeHaan
4312391e0a
(A) Fix a bug in the doc generator that was clobbering the force parameter for the copy module.
...
(B) This is a work in progress but the idea is to have text snippets where we can respond to tickets with a bit more helpful info.
Not active just yet.
12 years ago
James Cammarata
dc69510bff
Merge branch 'callback_template_delegate' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-callback_template_delegate
12 years ago
James Cammarata
eeec459f8a
Merge branch 'sets_v2' of https://github.com/bcoca/ansible into bcoca-sets_v2
12 years ago
Jonathan Mainguy
535ebc4c56
Fixes 8362, returns stderr if No space left on device
12 years ago
Serge van Ginderachter
8f39c114d8
template Runner.module_vars['delegate_to'] to accommodate callbacks
12 years ago
Monty Taylor
4012272fa2
Add common auth handling across openstack modules
...
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
12 years ago
James Cammarata
5d0bb33ede
Make run_command process communication smarter
...
The run_command module function will now poll stdout/stderr for
data rather than using the builtin command communicate(), which can
hang under certain circumstances.
Fixes #7452
Fixes #7748
Fixes #8163
12 years ago
James Cammarata
74cbeb1292
Default interface type to ipv4 when checking flags for Solaris
...
Fixes #8330
12 years ago
James Cammarata
bd49a835b4
Atomically move known hosts file into place when edited by paramiko connections
...
Fixes #8169
12 years ago
Michael DeHaan
7ff63ab754
Revert "Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C"
...
This reverts commit 642b183fb6 .
12 years ago
James Cammarata
af0d8cda7b
Fix literal block multiline parsing
...
Fixes #8394
12 years ago
James Cammarata
6d94ae64ec
Remove unnecessary unicode conversions from parse_kv
...
Fixes #8425
12 years ago
Michael DeHaan
642b183fb6
Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C
...
during file operations.
12 years ago
Michael DeHaan
a7d2e729f8
Add some whitespace to make paramiko_ssh more browseable
12 years ago
Michael DeHaan
24f6f656cc
Merge branch 'bug8392' of git://github.com/gnosek/ansible into devel
12 years ago
Monty Taylor
a05804bf8d
Update the nova inventory plugin with new ip code
...
The provisioning module knows more about how nova deals with IP
addresses now. Ensure that the inventory module is similarly as smart
by separating out the logic into the openstack/module_utils.
12 years ago
Monty Taylor
d17a1b5c19
Add common auth handling across openstack modules
...
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
12 years ago
Luke Sneeringer
a4fce4818e
Add support for environment variables in GCE module.
12 years ago
Grzegorz Nosek
7f33580eba
Fix exponential regex performance issue
...
filter_leading_non_json_lines effectively does
re.match(".*\w+=\w+.*", line)
for every line of output. This has abysmal performance in case of large
Base64-encoded data (which ultimately does not match the regex but does
match the .*\w+= part) as returned e.g. by the template module (diffs).
Replacing the match with
re.search("\w=\w", line)
drops the complexity back to linear, and actually usable with large
diffs from the template module (a 150 KB Base64 diff kept Ansible
spinning at 100% cpu for minutes).
Also, check the easy cases (line.startswith) first while we're here.
Closes : #8932
12 years ago
James Cammarata
9c1a89ff4e
Merge branch 'patch-1' of https://github.com/debfx/ansible into debfx-patch-1
12 years ago
Marc Abramowitz
44b9f5e752
Make `pip install -e` work
...
This allows `pip install -e` and `python setup.py develop` to work
without having to do the stuff in
http://docs.ansible.com/intro_installation.html#running-from-source so
it's a tad nicer for Python programmers who are accustomed to installing
packages as editable/in development mode.
Fixes GH-8355 (https://github.com/ansible/ansible/issues/8355 )
12 years ago
James Cammarata
7a5076c8b8
Catching shlex splitting error in fact gathering get_cmdline call
...
Fixes #8352
12 years ago
James Cammarata
80df2135e9
Fix parsing of tasks with variable module names
...
Also adding an integration test for same.
12 years ago
James Cammarata
189824dd76
Remove whitespace around args
...
Fixes #8343
12 years ago
James Cammarata
e6fa50a306
Move splitter to module_utils so modules can use it and fix command arg splitting
...
Fixes #8338
12 years ago
Veeti Paananen
5780f3a8b4
Expand variables in configuration files, take two
...
e.g. $HOME.
12 years ago
Veeti Paananen
e6bd049892
Don't expand remote_tmp path locally
12 years ago
James Cammarata
a9f0f8e975
Revert "template.py: Handle purposely raised exceptions in lookup()"
...
This reverts commit 2fda9bc743 .
12 years ago
James Cammarata
aee940aaca
Reworking _clean_data() to be smarter about replaces
...
Fixes #8228
12 years ago
James Cammarata
6e814566de
Unquote params passed to an include statement
...
Fixes #8315
12 years ago
Michael DeHaan
106f4ccc01
Revert "Expand variables in configuration files" - I feel I've been here before.
...
Breaks some test runs.
This reverts commit a9eef029b6 .
12 years ago
Michael DeHaan
97fa9502aa
Merge pull request #8309 from veeti/cfg-vars
...
Expand variables in configuration files
12 years ago
Michael DeHaan
645ab7baff
Merge pull request #7950 from mesk41in/devel
...
Fix unsupported regexp parameter in assemble
12 years ago
Michael DeHaan
fb60e767a7
Taking alternate approach.
...
Revert "Fix hostname when get_distribution_version() returns a string."
This reverts commit 08f97c0b9d .
12 years ago
Michael DeHaan
628d828876
Merge pull request #8087 from neersighted/string_version
...
Fix hostname when get_distribution_version() returns a string.
12 years ago
Michael DeHaan
30e6a659ae
Merge pull request #8171 from jbenden/osx-10.10
...
Support for OS X 10.10 DP3.
12 years ago
Michael DeHaan
20f65f2c79
Merge pull request #8262 from icoloma/patch-1
...
Bugfix: bulletproof unexpected_error_msg at gce.py
12 years ago
Veeti Paananen
a9eef029b6
Expand variables in configuration files
...
e.g. $HOME. Fixes #6373 .
12 years ago
Nacho Coloma
979824eedc
Moved import to the top
12 years ago
James Cammarata
6eac47e519
Use split_args instead of shlex.split for included params
...
Fixes #8296
12 years ago
James Cammarata
7344baeffa
Make sure empty non-quoted tokens are not added to the arg params list
12 years ago
James Cammarata
3714c0742f
Split args on single spaces only
12 years ago
James Cammarata
57f89b85eb
Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
...
fix an issue that copying directory will fail when trying to change file attributes
12 years ago
James Cammarata
63bcbd0af2
Fix for unicode decoding error in new splitting code
...
Also adds a new unicode integration test
12 years ago
James Cammarata
10a850c70f
Merge branch 'new_arg_splitting' into devel
12 years ago
Michael DeHaan
8d42f5cbfa
Smush ds removal
12 years ago
James Cammarata
b8a4ba26f0
Refactoring split_args into sub-functions
12 years ago
Michael DeHaan
630f080cf0
Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far).
12 years ago
Michael DeHaan
b5d64fdb36
Some notes/comment upgrades on split_args.
12 years ago
James Cammarata
43154e5101
Using custom splitting function for module param counting
12 years ago
Michael DeHaan
e143d7dab7
Merge pull request #7543 from yangliping/fix_local_facts_file_checking_portability
...
Fix portability issue when checking local facts file permission.
12 years ago
Michael DeHaan
635bea645c
Merge pull request #7992 from dehylton/devel
...
fix swap translation on 4.x openbsd with 2.5.4 python
12 years ago
James Cammarata
b21875d5a9
Make sure 'item' variable is set when using first_available_file
...
Fixes #8220
12 years ago
someda
1b1d5d0d3d
fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
...
- the issue was introduced by the commit 84759faa09
12 years ago
James Cammarata
2cc602beea
Fixes for module param counting and additional shell quoting issues
12 years ago
Benno Joy
ac85d8444b
fix for unarchive 8257
12 years ago
Nacho Coloma
57428c48a2
Bugfix: bulletproof unexpected_error_msg at gce.py
...
This method was still failing for me with a "missing http_code" message. After applying this change, the error message is:
```
msg: Unexpected response: {'value': 'PyCrypto library required for Service Account Authentication.'}
```
I wanted to contribute a rock-solid `unexpected_error_msg` implementation.
12 years ago
James Cammarata
84759faa09
Security fixes:
...
* Strip lookup calls out of inventory variables and clean unsafe data
returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
duplicate params from superseding previous params (CVE-2014-4967)
12 years ago
James Cammarata
00e089e503
Revert "Explicitly set the user option for ssh connections"
...
This reverts commit 0f91add86f .
Fixes #8216
12 years ago
Joseph Benden
da5e32b316
Needs additional divisor.
12 years ago
Michael DeHaan
0fad9575e9
Refine error message about invalid ops since people forget to indent tasks fairly often.
12 years ago
James Cammarata
0e5b0a2e97
Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
...
This reverts commit 7a8eb0b670 .
12 years ago
Joseph Benden
b55791ef43
Support for OS X 10.10 DP3.
12 years ago
James Cammarata
62e9cf63b7
Merge pull request #8170 from sergevanginderachter/issue_8159
...
Load existing group_vars file for new group_by group
12 years ago
Serge van Ginderachter
4e9a253bef
Load existing group_vars file for new group_by group
...
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.
fixes #8159
12 years ago
James Cammarata
42b5294820
Merge branch 'devel' of https://github.com/leverich/ansible into leverich-devel
12 years ago
Felix Geyer
0ebd19e97b
Fix regression: Sanitize sudo success_key from stdout
...
Commit 7e3dd10 caused a regression with sanitizing the sudo success_key from stdout.
There is no newline in front of SUDO-SUCCESS when using sudo.
This change adapts the regex to make the line break optional.
Tested on Ubuntu 14.04.
12 years ago
Ruggero Marchei
909955f2e2
fix get_distribution_version() on amazon linux
12 years ago
Jacob Leverich
7a8eb0b670
Set Jinja2's keep_trailing_newline=True in template_from_string.
...
Without this setting, the newline idempotence of scalar strings changes depending on whether
or not they contain any Jinja2 template blocks.
12 years ago
James Cammarata
e74853300a
Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass
12 years ago
James Cammarata
cdb9f13559
Merge pull request #7605 from sivel/delegate-callback-hint
...
Show delegate_to hint in callback output
12 years ago
James Cammarata
4fc8d4b6fe
Merge pull request #7649 from sivel/vault-password-script
...
Allow --vault-password-file to work with a script as well as a flat file
12 years ago
Serge van Ginderachter
e8b45a9ef7
Invalidate host/group variables cache when loading
...
extra varsiables based on playbook basedir.
12 years ago
Serge van Ginderachter
d39ff55688
Fix logic bug when loading vars for a new playbook basedir.
12 years ago
James Cammarata
db96344966
Re-fixing ability to have empty json files after inventory refactoring
12 years ago
James Cammarata
4e5eb7559e
Merge branch 'svg_and_inventory_refactor' into devel
12 years ago
Bjorn Neergaard
08f97c0b9d
Fix hostname when get_distribution_version() returns a string.
...
The distro version is a string ('jessie/sid') on Debian unstable and testing.
Because load_platform_subclass() evaluations every subclass as it loops,
comparing numbers when get_distribution_version() does not return a number will
break.
This patch fixes that by returning a number (`0`) when we have an invalid
version, instead of returning `None` or a string.
12 years ago
Dan Slimmon
307a3e8a9c
Fixed regex square-bracket bug.
...
Regexes were being parsed like ordinary ansible host patterns, so
square-bracket groups were getting interpolated wrongly.
12 years ago
James Cammarata
b8ac094eaa
Tweak to only show msg on assert failure if set
12 years ago
James Cammarata
16332b8488
Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg
12 years ago
James Cammarata
aa261bdd14
Optimizing groups_for_host() lookup in inventory
12 years ago
James Cammarata
fe892fccb1
Merge remote-tracking branch 'svg/varsplugins_refactor' into svg_and_inventory_refactor
12 years ago
James Cammarata
11a5fc85f4
Merge branch 'inventory_refactoring' into svg_and_inventory_refactor
12 years ago
James Cammarata
bcf83cbc24
Merge branch 'sergevanginderachter-inventorytree' into svg_and_inventory_refactor
12 years ago
Serge van Ginderachter
ff4119adc0
Performance optimization in resolving host patterns
...
Avoid resolving a pattern that is a plain host. When matching a hostname in the
hosts_cache, just use the host object from there.
When running a task on say 750 hosts, this yields a huge improvement.
12 years ago
Matt Martz
6591dd560d
Show delegate_to hint in callbacks
12 years ago
Leonid Evdokimov
d94395f48c
assert: add optional `msg` argument
...
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
register: output
- assert:
msg: '{{ output.json | to_nice_json }}'
that:
- output.json.foo != "bar"
- output.json.boo == 42
```
12 years ago
James Cammarata
7f8de3a265
Merge pull request #8024 from kcghost/7941
...
removed port from domain name qualification, fixes #7941
12 years ago
James Cammarata
ff04b2b532
Allow empty yaml vars files
...
Fixes #7843
12 years ago
Michael DeHaan
51e014d915
Merge pull request #8012 from cchurch/callback_cleanup
...
Callback plugin cleanup
12 years ago
Michael DeHaan
c2ac8fda1e
Data from inventory scripts should be able to use nested Jinja2 expressions.
12 years ago
Henry Finucane
de64bbdc5f
Support a whitelisted subset of jinja2 template options
12 years ago
Casey Fitzpatrick
7115cb1f37
removed port from domain name qualification, fixes 7941
12 years ago
Marc Abramowitz
5b783e0bc6
Error if private_key_file is group/world readable
...
Currently, if you have this, ansible fails with a generic error and
suggests running again with `-vvvv`. This isn't bad but pinpointing the
specific problem immediately is even more user-friendly.
```
$ ls -l devops.pem
-rw-r--r--+ 1 marca staff 1679 Jul 2 11:25 devops.pem
$ ansible -m ping --private-key=devops.pem mt3-pyweb01
mt3-pyweb01 | FAILED => private_key_file (devops.pem) is group-readable or world-readable and thus insecure - you will probably get an SSH failure
```
12 years ago
James Cammarata
81f35323e9
Revert "Fix get_distribution() for platforms that may have spaces"
...
This reverts commit 2493020d9f .
12 years ago
Chris Church
955dadf743
Remove runner_on_error callback that is never used.
12 years ago
Chris Church
4e98e3785a
Reset play attribute on callback plugins when a play fails.
12 years ago
Chris Church
30fae95efe
Change variable from pattern to name to correctly indicate what is being passed to the callback.
12 years ago
James Cammarata
8ed6350e65
When parsing json from untrusted sources, remove templating tags
12 years ago
James Cammarata
eeb597360e
Further safe_eval fixes
12 years ago
dewey hylton
379e1a49cb
fix swap translation on 4.x openbsd with 2.5.4 python
12 years ago
Michael Scherer
f0a7139290
Fix exec_command prototype for the plugin
12 years ago
mesk41in
488aec3936
Fix unsupported regexp parameter in assemble
12 years ago
James Cammarata
539426f612
Performance tuning inventory functions for large inventories
12 years ago
James Cammarata
35368e531b
Additional fixes for safe_eval
12 years ago
James Cammarata
5429b85b9f
Change safe_eval to a strict white list
12 years ago
James Cammarata
d8a7b49b59
Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree
12 years ago
Matt Martz
19f5ce2c9c
Allow --vault-password-file to work with a script as well as a flat file
12 years ago
James Cammarata
1adb6dfa05
Remove redundant 'self.user or' added by 0f91add
12 years ago
Thomas Mangin
0f91add86f
Explicitly set the user option for ssh connections
...
Fixes #7170
12 years ago
Paul Sokolovsky
f8bf9cdeec
Handle TemplateNotFound to render more helpful error message.
...
At the point the exception is handled, it is likely due to error loading
a sub-template included from main template. Besides file not found, it
can be caused also by include path failing Jinja2 checks. Now, when
rendering the exception from Jinja, it will include exception name. This
will give basic context or *what* the error is.
Fixes #7103
Fixes #7105
12 years ago
James Cammarata
5d65c1c4a4
Merge branch 'Mbosco-patch-1' into devel
12 years ago
James Cammarata
6bd0621037
Merge branch 'devel' of https://github.com/ansible/ansible into devel
12 years ago
James Cammarata
1702c2fd50
Merge branch 'patch-1' of https://github.com/Mbosco/ansible into Mbosco-patch-1
12 years ago
James Cammarata
9564818e1e
Merge branch 'fix_lineinfile_newlines' into devel
12 years ago
James Cammarata
59c5d6292b
Merge pull request #7902 from jirutka/filter-relpath
...
Add os relpath filter
12 years ago
James Cammarata
ce41b02300
Merge pull request #7887 from s0x/funtoo-gathering-facts
...
Check for empty os-release file, fixes #7885
12 years ago
Jakub Jirutka
726a61eb43
Add os relpath filter
12 years ago
Chris Church
6aaad5dc9b
Fix missing arg for _remote_chmod method.
12 years ago
Ivo Senner
f4fd9d366b
Check for empty os-release file, fixes #7885
12 years ago
Chris Hoffman
cf997beb07
Shell expand DEFAULT_ROLES_PATH fixes #4897
12 years ago
James Cammarata
94963290b9
Merge pull request #6981 from aliles/fix-localhost-executable-with-flags
...
Fix localhost tasks with complex executables
12 years ago
James Cammarata
3c3c710a58
Merge branch 'module_safe_eval' into fix_lineinfile_newlines
12 years ago
James Cammarata
d8bb116c1a
Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel
12 years ago
Michael DeHaan
5156794738
Merge pull request #7861 from cchurch/devel
...
Windows Remote Support
12 years ago
Chris Church
615f70e3f4
Fix missing space in script action plugin.
12 years ago
Chris Church
dd3f7c2dab
Fix trailing slash on returned temp path.
12 years ago
Chris Church
8a121fd6ae
Squeeze a few more bytes out of put_file script.
12 years ago
Chris Church
4e738e6fa9
Optimize buffer size for put_file.
12 years ago
Matt Martz
09dd535296
Make helper functions more robust against undefined powershell objects
12 years ago
Chris Church
43a7a5a990
Collapse extra whitespace in encoded powershell scripts.
12 years ago
Matt Martz
df8866b8bd
Add examples for how to use powershell common functions
12 years ago
Matt Martz
e4e610565c
Add convenience function (Get-Attr) for getting an attribute/member from a powershell psobject
12 years ago
Matt Martz
90c98ada7c
Add ConvertTo-Bool filter function in powershell common code
12 years ago
Chris Church
61c236be9e
Fix for creating temp dir with older powershell versions.
12 years ago
Chris Church
243cd877ae
Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules.
12 years ago
Chris Church
a8ca579761
Fix host parameter to vvvvv.
12 years ago
Matt Martz
97f4f56286
Add Exit-Json and Fail-Json powershell helper functions
12 years ago
Chris Church
74c43c94cf
Allow specifying remote powershell version via environment variable.
12 years ago
Chris Church
8f762a7d15
Update logging based on verbosity, add vvvvv support to show details of put/fetch file.
12 years ago
Chris Church
21ba529fbe
Fixes/notes related to slashes in remote paths.
12 years ago
Chris Church
7e8cc65829
Refactor common args used for building PowerShell commands.
12 years ago
Matt Martz
e7e95721b9
powershell modules will have a .ps1 extension
12 years ago
Matt Martz
a25c441300
Add shared functions to module_utils/powershell.ps1 and refactor powershell modules to utilize the common powershell code
12 years ago
Michael DeHaan
bafa63b424
Revise documentation on powershell module replacer code.
12 years ago
Chris Church
f7af29680b
Add default license boilerplate, refactor common powershell code, fixes for raw/script modules.
12 years ago
Michael DeHaan
35a7c93c76
Added comment about implementation line.
12 years ago
Michael DeHaan
3ac86e57f4
FIXME comment cleanup
12 years ago
Michael DeHaan
80499346d1
Remove stray FIXME
12 years ago
Chris Church
5dcaa30476
Add shell_plugins to abstract shell-specific functions out of runner, add winrm connection plugin, add initial Windows modules.
12 years ago
James Cammarata
360d8b0fc2
Don't try to scan SSH signatures for non-ssh urls
...
Fixes #7812
12 years ago
James Cammarata
2493020d9f
Fix get_distribution() for platforms that may have spaces
...
The new CentOS 7 beta lists the distribution as "CentOS Linux", which
breaks the distribution detection and class loading. This patch fixes
that by taking just the first entry in the string when a space is
detected.
12 years ago
James Cammarata
3529b1cb33
Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763
12 years ago
Michael DeHaan
627ff30a6f
Add module replacer capability for powershell files.
12 years ago
Ruggero Marchei
e3f5af377f
move get_distribution_version() to basic.py
12 years ago
James Cammarata
cb13b30362
Use file documentation fragement for the copy module
12 years ago
James Cammarata
9b17e8a555
Merge pull request #7771 from jkramarz/issue-5761
...
Added missing fallback to hw_sector_size
12 years ago
James Cammarata
6d9cc64e0f
Add role_names to valid keys entry for plays
...
Prevents a "not a legal parameter" error for play ds structures that
may be passed into the Play() constructor, which really is mainly a
concern during tests.
12 years ago
Matt Bray
578e881142
fix for urls like ssh://git@github.com/ansible/ansible.git
12 years ago
Jakub Kramarz
df3188cef0
Added missing fallback from physical_block_size to hw_sector_size in sectorsize fact discovery for kernels older than May 2009.
...
References #5761
12 years ago
James Cammarata
3fb3e7e6dc
Properly parse urls for ssh-keyscan use
...
Previously, the get_fqdn() function in known_hosts.py only worked
with urls that started with git@, and ignored any urls that started
with a normal schema type (ie. http:// or ssh://). This patch corrects
that by using urlparse to parse the hostname portion out of urls that
have a proper schema.
Fixes #7474
12 years ago
James Cammarata
395192ffbc
Merge pull request #7740 from jkramarz/issue-5761
...
changed sector size fact source
12 years ago
James Cammarata
b4d130d086
Add a new password pattern to the run_command filter
12 years ago
Jakub Kramarz
4e4c9235e8
changed sector size fact source from hw_sector_size to physical_block_size, fixes issue 5761
12 years ago
Stefan Lapers
78f4842982
fix incorrect secondary ip handling, fixes #7724
12 years ago
Eri Bastos
a65fd06338
Added quotes around key path - Issue 7713
12 years ago
James Cammarata
e5ef0eca03
Merge pull request #6507 from brdo/patch-1
...
Set keepalive to 5 seconds in paramiko_ssh.py
12 years ago
smoothify
e3530dcbc2
Add environmentfilter to random filter, to ensure the result doesn't get cached. Mirrors default jinja filter.
12 years ago
Dag Wieers
fd6f0cb4b4
Update facts.py
12 years ago
Dag Wieers
14a9966984
Added cross-platform uptime fact
...
Having an uptime fact allows you to check after a reboot whether the system was effectively rebooted.
```yaml
- name: Safeguard - Was system properly rebooted ?
action: fail msg="System was not properly rebooted"
when: ansible_uptime > 900
```
This patch has been tested on Linux, Solaris and HP-UX.
12 years ago
James Cammarata
ad97c618cf
Add support for relative paths in the file lookup plugin for roles
...
Fixes #7628
12 years ago
James Cammarata
82a784931e
Fix error passing play vars to an included playbook with empty vars
...
Fixes #7658
12 years ago
James Cammarata
d9df607972
Fix order of merging variables for the combined cache
...
Fixes #7598
12 years ago
James Cammarata
74f20ebf79
Removing cruft leftover from the deprecation of include+with_items
...
Also cleaning up integration tests that had checks for the empty item
attribute in certain results.
Fixes #7535
12 years ago
James Cammarata
0fa5100a2c
Merge branch 'fix-7596' of https://github.com/kilburn/ansible into kilburn-fix-7596
12 years ago
James Cammarata
849b0f87ce
Fix error when using os.getlogin() without a tty
12 years ago
Brian Coca
ce8c8ab146
now unique actually works, all operations also now use it to return
...
unique lists.
12 years ago
Michael DeHaan
959af67fe3
Merge pull request #7608 from jjneely/lookup-function
...
template.py: Handle purposely raised exceptions in lookup()
12 years ago
James Cammarata
b94bde9711
Merge pull request #7609 from jimi-c/issue_7553_su_copy
...
Support checking for su user to atomic_move
12 years ago
Jack Neely
2fda9bc743
template.py: Handle purposely raised exceptions in lookup()
...
If a lookup plugin is run by the lookup() template method it should pass
along any AnsibleError (or child exception classes) rather than just eat
them. These exceptions are purposely raised by the plugin.
12 years ago
Marc Pujol
d0f82e94e8
Ensure there are no duplicates in the merged/intersected lists
12 years ago
Marc Pujol
f892cc798c
Merge and intersect lists without using sets.
...
Using sets for these operations is dangerous because sets cannot contain
certain object types (such as lists) and their iteration order is
undefined.
Fixes #7596
12 years ago
James Cammarata
188ab7b952
Check groupnames for None as well as an empty string in add_host
...
Fixes #7585
12 years ago
James Cammarata
feafc4cd8a
Merge branch 'fix_mutable_inventory_vars' of https://github.com/banterchat/ansible into banterchat-fix_mutable_inventory_vars
12 years ago
Isao Jonas
72524e1f3b
dont mutate inventory vars
12 years ago
James Cammarata
061911c9c2
Merge pull request #7558 from dermute/pkg_mgr
...
added solaris fact detection for ansible_pkg_mgr
12 years ago
James Cammarata
e99df21647
Support checking for su user to atomic_move
...
Fixes #7553
12 years ago
James Cammarata
fa86eef9f9
Make sure value in regex_replace is a string
...
Fixes #7551
12 years ago
James Cammarata
ca734fde8b
Merge pull request #7544 from rik2803/patch-2
...
Differentiate machinfo output key/val separator
12 years ago
James Cammarata
cfd8c685d1
Correct issue of handlers running on all hosts incorrectly
...
Also adds an integration test to catch this bug in the future.
Fixes #7559
12 years ago
Alexander Winkler
4980e76a3a
added solaris fact detection for ansible_pkg_mgr
12 years ago
Brian Coca
8f58ae3305
changed exception handling for hashable test
12 years ago
rik2803
cfcbc954f5
Differentiate machinfo output key/val separator
...
get_hw_facts for HP-UX: machinfo in HP-UX B.11.23 uses '=' as separator between key and value, while B.11.31 uses ':'.
12 years ago
Yang Liping
aedf134fc4
Fix portability issue when checking local facts file permission.
12 years ago
James Cammarata
92f16b3d6f
Merge pull request #7539 from jimi-c/issue_7503_freebsd_su_fixes
...
Fixes for su on freebsd
12 years ago
Brian Coca
0dce5dae26
set theory v2, now can handle non hashable items like dicts
12 years ago
James Cammarata
e0c4c51c1f
Merge pull request #7517 from amenonsen/double-error
...
Don't double (or triple) up common error messages
12 years ago
James Cammarata
d77a6965b3
Merge module_vars into inject during template instead of updating
...
This way we won't overwrite values that are stored in the inject
with module_vars that should be lower precedence.
Fixes #7510
12 years ago
Abhijit Menon-Sen
f6792b724a
Don't double (or triple) up common error messages
...
process_common_errors() was called thrice, each time appending to the
existing error message, and leading to confusing repetition in the
message that was finally displayed.
Fixes #7498
12 years ago
James Cammarata
1e672a0fec
Fixes for su on freebsd
...
Addresses multiple issues when using su on freebsd including
* su prompt differs between platforms, so turned that check into a
regex comparison instead of a simple string comparison
* not using '-c' after su causes problems, so added that for all
platforms
* fixed quoting issues due to multiple uses of '-c' introduced by
the above fix
Fixes #7503
Fixes #7507
12 years ago
Nick Irvine
6b70ee23ab
Clean non-printable chars from stdout instead of dropping the whole thing
12 years ago
James Cammarata
32628eef85
Merge pull request #7481 from jimi-c/issue_7396_env_lookup
...
Don't use listify_ function, when all we want to do is template variable...
12 years ago
WAKAYAMA shirou
56880b76bb
fix UnicodeEncode error when using pause module with unicode prompt.
12 years ago
WAKAYAMA shirou
346bb611c7
fix UnicodeEncodeError when prompt is unicode.
12 years ago
James Cammarata
e36a8d466e
Don't re-query inventory when trimming failed/dark hosts
...
Since the filter list contains hosts, passing that back to list_hosts()
in the inventoy causes issues when the hostname is an IPv6 address
(with :'s interpreted as group unions). Since we already have the list
of hosts, we should not need to pass that back through inventory a
second time.
Fixes #7446
12 years ago
James Cammarata
365bfd732e
Don't use listify_ function, when all we want to do is template variables
...
This was causing a bug in the env module, due to the fact that we now
pass variables for the module through the templating engine combined
with the fact that we split-up the hostvars and setup variables. As a
result, if a variable in the env lookup had the same name as the variable
in Ansible, it would try and template itself over and over again until
the recursion limit would be hit, at which time an empty string was
returned.
Fixes #7396
12 years ago
James Cammarata
0ac74aaf59
Also set the environment variables when resetting the locale to C
12 years ago
James Cammarata
1f0be3753d
Merge pull request #7412 from bellkev/fix_skip_dir_inventory_extensions
...
Fix skip dir inventory extensions
12 years ago
James Cammarata
d44ed533b3
Default use_proxy to True for fetch_url()
...
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.
Fixes #7322
12 years ago
James Cammarata
08406c0ee2
Adding the capability to proxy the ssl cert check
...
The ssl cert check will now respect the http and https proxy
environment settings. The url may also have the username/password
embedded, in which case basic auth will be used to connect to the
proxy server.
Fixes #7413
12 years ago
Matt Martz
0e953c2863
Add run_once task key
...
This caused the task to act like bypass host loop plugin and
execute only on a single host. Can be used with delegate_to
12 years ago
James Cammarata
285d9878ae
Reset locale to 'C' if the specified one is invalid
...
Fixes #7448
12 years ago
Kevin Bell
92bd755b47
Fixed extension filtering in InventoryDirectory
12 years ago
James Cammarata
df877f2e79
Check module_path permissions when creating ssh_wrapper for git
...
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.
Fixes #7375
12 years ago
Michael DeHaan
3b8a35d65e
Merge pull request #7406 from specnazzz/fix-python24
...
Fix known_hosts.py to work on older versions of python
12 years ago
James Cammarata
79731ce491
Evaluate changed_when only if task is not skipped
...
Fixes #7405
12 years ago
Michal Mach
60451c20ab
Fix known_hosts.py to work on older versions of python
12 years ago
James Cammarata
7faecd54b0
Merge pull request #7388 from jimi-c/issue_7384_vars_files_include
...
Pass vars_files on to included playbooks too
12 years ago
James Cammarata
a9311a5dcb
Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms
12 years ago
James Cammarata
56515a38d5
Only chown on atomic move if the uid/gid don't match the src/tmp file
...
This is a corner case for remote file systems that don't support
chown() and where the source and destination for the atomic_move
are on that remote file system.
Fixes #7372
12 years ago
James Cammarata
525e7339ed
Merge branch 'pass-basedir-to-runner-on-setup' of https://github.com/ByteInternet/ansible into ByteInternet-pass-basedir-to-runner-on-setup
12 years ago
James Cammarata
85bd6810bb
Pass vars_files on to included playbooks too
...
Fixes #7384
12 years ago
Allard Hoeve
c5833f9869
Add missing basedir to Runner in _do_setup_step
12 years ago
James Cammarata
360ffc4dfd
Properly merge role conditionals in with pre-existing conditionals
...
Fixes #7387
12 years ago
James Cammarata
187619c7fe
Use utils.combine_vars on vars_files data
...
Fixes #7345
12 years ago
James Cammarata
809b931640
Merge pull request #7382 from jimi-c/issue_7366_synchronize_inventory_dir
...
Do not base synchronize source on the inventory directory
12 years ago
Marco Re
712f4a631c
Update ssh.py
...
Convert to string to fix runtime error due to string concat in self.common_args += ["-o", "User="+self.user] when ansible_ssh_user is numeric
12 years ago
Chris Church
d725636469
Correctly initialize combined_cache for hosts if setup is skipped
...
Fixes #7364
12 years ago
James Cammarata
38c2c60849
Do not base synchronize source on the inventory directory
...
Fixes #7366
12 years ago
James Cammarata
fd27afdc0d
Adding ansible_shell_type and basic environment construction on it
...
Previously we assumed the shell on the target systems were 'sh'-
compliant when formatting environment variables preceding command
strings. This patch corrects that by basing the target shell type
on the DEFAULT_EXECUTABLE setting, which can be overridden on a
per-host basis using the inventory variable 'ansible_shell_type'.
Fixes #7352
12 years ago
James Cammarata
9b9b4d50fe
Merge pull request #7058 from jkleckner/fix-vars_prompt-when-default-False
...
Fix #7057 missing False default for vars_prompt
12 years ago
James Cammarata
51ef28b0d2
Merge branch 'warn_wrong_sudo_password' of https://github.com/tyll/ansible into tyll-warn_wrong_sudo_password
12 years ago
James Cammarata
2e2e5d5321
Use the existing module_vars during the templating of module_vars
...
Since some of the vars contained in there may be used in the templating
of other variables. This also reverts e83a494 which originally fixed
issue #6979 but broke some other variable related things.
Fixes #6979
Fixes #7321
Fixes #7332
12 years ago
James Cammarata
77a47dbb2d
Merge pull request #7304 from jimi-c/issue_7296_synchronize_relative_path
...
Make sure dwim'd relative path ends in a "/" if the original does
12 years ago
James Cammarata
393124e462
Add pyc/pyo to ignore list for inventory directories
...
Fixes #7308
12 years ago
Brian Coca
8a84b22d76
bumped to 1.7
12 years ago
Chris Church
f9c74d6e57
Add integration tests for group_by module. Fixed bug introduced by ansible/ansible#7273 while also fixing issue described in ansible/ansible#6953
12 years ago
James Cammarata
4d118d1c72
Make sure dwim'd relative path ends in a "/" if the original does
...
Fixes #7296
12 years ago
James Cammarata
56d070afa8
Version bump for 1.7
12 years ago
James Cammarata
fd03cc04e6
Merge branch 'devel' of https://github.com/denisphillips/ansible into denisphillips-devel
12 years ago
Veeti Paananen
d6f4d9b76d
Fix error handling on missing dest with unarchive
...
fixes #7107
12 years ago
Denis Phillips
cd0134d290
Used module_args passed to function instead of from runner
12 years ago
Christian Berendt
6676720ce5
fixed typos found by RETF rules in PY files
...
rules are avaialble at https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Typos
12 years ago
James Cammarata
deb532c367
Remove OrderedDict references from runner
...
Fixes #7256
12 years ago
James Cammarata
54b1f820fb
Modify the way we set the localization environment
...
Previously, we set the LANG (and LC_CTYPE) environment variables
directly in the module code and applied them with os.environ().
Instead, we are now pre-pending those variables to the environment
string used to execute the command which allows the user to
override the localization values by setting the environment values
directly (even on a per-task basis):
- subversion: repo=file:///path/to/repos/svn_über dest=/tmp/svntest
environment:
LANG: "C"
LC_CTYPE: "en_US.UTF-8"
So if a user wishes to default their LANG back to C, they can still
avoid unicode issues by doing the above.
Fixes #7060
12 years ago
James Cammarata
40a7a306f5
Merge pull request #7236 from jcassee/robust-ssl-cert-concat
...
Make concatenating certs robust in urls.py
12 years ago
James Cammarata
8e45fa9b63
Moving display-related functions to new module in utils
12 years ago
Joost Cassee
978e6d2cd6
Make concatenating certs robust in urls.py
...
Add a newline after each certificate file explicitly to avoid problems
with files that do not end with a newline themselves.
12 years ago
James Cammarata
6069ff6e9e
Adding a new system_warnings config option to supress warnings
12 years ago
James Cammarata
30e4759055
Merge pull request #7208 from jf/copy-module
...
Fix "no_log=True" option for copy module (fixes #7193 )
12 years ago
James Cammarata
be4e6d359f
Merge branch 'delegate_to_honor_ssh_private_key_file' of https://github.com/renard/ansible into renard-delegate_to_honor_ssh_private_key_file
12 years ago
James Cammarata
4cadcccc48
Catch pycrypto warning about gmp and show a nice warning on stderr
12 years ago
Jeffrey 'jf' Lim
0bf1a27393
Fix "no_log=True" option for copy module ( fixes #7193 )
12 years ago
Jiri Barton
9da06274a8
Set proper file permisions when a file is created with atomic_move
...
Fixes #7196
12 years ago
Michael DeHaan
9a6998aa17
While this code is unused, this remote module copy of this function should not be carried around in the source code.
12 years ago
Logos01
424ee36e05
Enable facts module on older SuSE systems
...
Modified logic of distribution_release for SuSE to retain the last discovered key/value pair's value in /etc/SuSE-release that contains a '=' character.
12 years ago
James Cammarata
1576e8d611
Adding missing options to the file documentation fragment
12 years ago
Brian Coca
c5d5481ebb
added doc noting the change in behaviour
12 years ago
Cédric RICARD
b8b0865ec0
Missing 'base64' import
12 years ago
Michael DeHaan
ad04b455d3
add missing license header
12 years ago
James Cammarata
117952cf6c
Fixing a bug in the new fetch_url username/password logic
12 years ago
James Cammarata
b9d8b3b911
Merge pull request #7132 from jimi-c/issue_6601_hide_vault_yaml
...
Hide YAML content on syntax errors when a vault password is specified
12 years ago
James Cammarata
89fa9b7305
Add parameters to get_url for the url username/password
...
Fixes #6928
12 years ago
James Cammarata
e9d8f0639f
Merge pull request #7143 from sivel/ansible-sudo-from-root-fix
...
Allow sudo to another user from root with the ansible command
12 years ago
James Cammarata
460794d697
Merge pull request #7140 from jimi-c/issue_6962_traceback_callbacks_unicode
...
Fix handling of non-JSON lines in responses
12 years ago
Matt Martz
eb8759176f
Allow sudo to another user from root
12 years ago
James Cammarata
5e598c5337
Fix handling of non-JSON lines in responses
...
Garbage lines with ' = ' in them were causing parsing errors,
where key=val lines should not have spaces around the equals.
Fixes #6962
12 years ago
James Cammarata
38b49476f8
Merge branch 'raw-script-su-support' of https://github.com/sivel/ansible into sivel-raw-script-su-support
12 years ago
James Cammarata
93b5769d94
Hide YAML content on syntax errors when a vault password is specified
...
Fixes #6601
12 years ago
Michael Scherer
0f0f5ff1ce
Give more information when a task is empty
...
I made a typo in a playbook and was great by:
ERROR: expecting dict; got: None
The issue was a single - on the last line of a playbook.
With the name of the file, I was able to see right away where the
error was.
12 years ago
James Cammarata
e83a494e41
Make sure VARS_CACHE for hosts are updated with the play vars too
...
Fixes #6979
12 years ago
James Cammarata
a6068b09ac
Fix collision in random filter name by merging functionality
...
Merges the functionality of the original jinja2 random filter with
the one we provide.
Fixes #7113
12 years ago
James Cammarata
c115c34a1f
Set the default LANG to en_US.UTF-8 and also set LC_CTYPE
...
Fixes #6737
12 years ago
Brian Coca
c3e559b914
should now work with versions older than 8.4
12 years ago
faust64
78b9a11ccf
Update facts.py
...
Fixes #7093 --devel
12 years ago
James Cammarata
68c30548e0
Properly catch and decode unicode strings in module _log_invocation()
...
Fixes #7084
12 years ago
James Cammarata
4f673b9497
Merge pull request #7083 from mscherer/better_message_multiple_action
...
Improve error message when multiple action are given
12 years ago
James Cammarata
39c6141b4a
Merge pull request #7082 from bcoca/freebsd_mtu_fix
...
fixed issue with FreeBSD network facts
12 years ago
James Cammarata
086b877719
Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
...
Clean a bit more the ssh_args configuration
12 years ago
James Cammarata
54f86099e4
Merge pull request #7078 from mscherer/fix_error_message_controlpersist
...
Enhance error message about missing ControlPersist
12 years ago
Michael Scherer
1e34e95ba0
Improve error message when multiple action are given
...
This can be illustrated using this playbook:
- command: id
delegate_to: "{{ remote_server }}"
user: "{{ remote_user }}"
The error is to use 'user' instead of 'remote_user', but the error message
do not really mention it, so it can be a bit hard to spot.
12 years ago
Brian Coca
e5f297697a
ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
...
versions and it now works
12 years ago
Brian Coca
bc23926f42
fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
...
gathering
12 years ago
Michael Scherer
c87afc1109
Clean a bit more the ssh_args configuration
...
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :
<server.example.org> ESTABLISH CONNECTION FOR USER: misc
<server.example.org> REMOTE_MODULE ping
<server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
'-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
'-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
&& chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
command using -vvvv, which will enable SSH debugging output to help diagnose the issue
The root cause is the empty string between -q and -o, who kinda break mkdir.
12 years ago
Michael Scherer
3a09c99811
Enhance error message about missing ControlPersist
...
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
12 years ago
James Cammarata
ae29e43f93
Merge branch 'issue_7009_nfs_selinux' into devel
12 years ago
James Cammarata
a32dd34359
Make sure HostVars object is instantiated before assigning it
...
Fixes #7006
12 years ago
Jim Kleckner
46ec238613
Fix #7057 missing False default for vars_prompt
...
The test for default should be "is not None" since a boolean value of
False is a valid value.
See discussion at:
https://groups.google.com/forum/#!topic/ansible-project/oc1_zE-FnyI
12 years ago
James Cammarata
75e0b7a5cf
Make sure umask is set restrictively before creating any vault files
12 years ago
James Cammarata
3715482d7c
Determine selinux context for NFS mount points correctly
...
Fixes #7009
12 years ago
Sébastien Gross
22d6572270
Honor ansible_private_key_file for delegated hosts
...
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.
This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
12 years ago
Wim
6ed4ca97a8
hint to install python-ssl on redhat systems
12 years ago
smoothify
48bf7a000d
Try to pass in item to on_skippped callback.
12 years ago
James Cammarata
d240d073eb
Changing SSL cert detection method to allow for auto-negotiation of SSL protocols
...
Fixes #6904
12 years ago
James Cammarata
23c5f4524d
Make sure args in run_command are encoded for shlex.split calls on py2.6
12 years ago
James Cammarata
d494a163f9
Merge pull request #6900 from jimi-c/issue_6891_cifs_mount_hang
...
Add a timeout decorator for timing out functions that may hang
12 years ago
James Cammarata
ba1a6c2e11
Removing .orig file merged in accidentally
12 years ago
James Tanner
aad128bac7
Use combined cache for templating module vars
...
Fixes #6901
12 years ago
James Cammarata
40b958e348
Don't turn complex args back into a k=v string for the synchronize module
...
Fixes #6951
12 years ago
James Cammarata
2cc4ac2e75
Catch traceback caused by permissions errors during a local md5 sum
...
Fixes #6948
12 years ago
Aaron Iles
a5507275cb
Fix localhost tasks with complex executables
...
Enable the use of executable commands that use command line options with
the localhost command runner. These commands require parsing out the
base executable from the command string to pass to subprocess.
12 years ago
jctanner
bfb25f4f89
Merge pull request #6917 from bcoca/random_filter_clean
...
simple random filter
12 years ago
jctanner
af99abc81c
Merge pull request #6913 from willthames/aws_module_doc_fragments
...
Use common module document fragments for AWS modules
12 years ago
James Tanner
4eb626825b
Refactor play._update_vars_files_for_host to make common functions and easier debugging
...
Fixes #4883
12 years ago
Brian Coca
80cd217eb7
simple random filter
12 years ago
willthames
509561f658
Moved AWS modules over to common module fragments
...
Created common module doc fragment, and applied to all
modules that use ec2_connect or connect_to_aws as
they definitely share the common doc fragments
12 years ago
James Cammarata
5ce6c86595
Merge branch 'sudo_pass_typo' of https://github.com/tyll/ansible into tyll-sudo_pass_typo
12 years ago
James Cammarata
eebc72ab9b
Add a timeout decorator for timing out functions that may hang
...
Fixes #6891
12 years ago
James Tanner
2d33cd1b5d
Fixes #6894 add missing file and remove debug line
12 years ago
James Tanner
68cd7258b6
Fixes #6894 create docs fragment for files
12 years ago
Serge van Ginderachter
d240e2b9fb
Introduce an ansible_version dict as runner variable
...
Given the version:
"1.6 (ansible_version_var 14499e8bf3 ) last updated 2014/03/21 17:07:50 (GMT +200)"
We get the special variable:
"ansible_version": {
"full": "1.6",
"major": 1,
"minor": 6,
"revision": 0,
"string": "1.6 (ansible_version_var 14499e8bf3 ) last updated 2014/03/21 17:07:50 (GMT +200)"
}
modified: lib/ansible/playbook/__init__.py
modified: lib/ansible/runner/__init__.py
modified: lib/ansible/utils/__init__.py
12 years ago
James Cammarata
9ca8c3262c
Switch module safe_eval to ast.literal_eval
12 years ago
James Tanner
318e752b6f
Fixes #6845 evaluate changed_when only if task is not skipped
12 years ago
Michael DeHaan
ccdd91f9c2
Merge pull request #6861 from ericlake/devel
...
add distribution_major_version to fact gathering
12 years ago
James Tanner
5a65dc3b6a
Fixes #6820 fix erroneous missing vault password error when using the template module
12 years ago
Eric Lake
7f9736198a
add distribution_major_version to fact gathering
12 years ago
Serge van Ginderachter
e36e2d38fe
InventoryDir: another fix for the host.groups list
...
In some cases, where a host is mentioned in multiple groups, and those
groups are referenced in multiple ini files, a group could still contain
multiple instances of a group in its host,groups list, where only one of them
is the right group, that exists in the inventory.
12 years ago
James Cammarata
82b24c162e
Adding delimiter fixes to action_plugin + fixing local assembling with a delimiter
...
Also added a new integration test for assemble using local assembly
with a delimiter.
12 years ago
Michael DeHaan
2c7275e8a9
Merge pull request #6835 from sivel/version-compare-filter
...
Add version_compare filter
12 years ago
Michael DeHaan
0a574af270
Merge pull request #5555 from sivel/expose-playbook-to-callback
...
Expose the playbook to callback plugins
12 years ago
Michael DeHaan
1fa19e29e8
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
12 years ago
Matt Martz
7b5f89ec7c
Use PluginLoader for module docs fragments
12 years ago
Matt Martz
bb6f7a267a
Add support for shared module documentation fragments
12 years ago
James Cammarata
ee0a0b492b
Allow isprintable() util function to work with unicode
...
Fixes #6842
12 years ago
James Tanner
cdc0819939
Fixes #6088 turn off sudo and su if the connection is local the sudo user matches the current user
12 years ago
jctanner
2a9fcdd87c
Merge pull request #6711 from j2sol/raw-unreachable
...
Treat 255 errors from raw as dark host
12 years ago
jctanner
f6db60cbce
Merge pull request #6787 from tyll/pull_ssh_prompt
...
ssh: propagate prompt to _communicate()
12 years ago
Matt Martz
5770428e91
Add version_compare filter
12 years ago
James Cammarata
317c2f4bc0
Fixes to variable issues introduced by recent changes
...
Fixes #6801
Fixes #6832
12 years ago
Harlan Lieberman-Berg
876b8085aa
Add directory_mode to common file parameters to prevent errors.
12 years ago
Michael DeHaan
904f331210
Merge pull request #6788 from tyll/pull_ssh_verbose_comments
...
ssh connection plugin: Make comments more verbose
12 years ago
James Cammarata
a6a4680e5c
Fix variable naming issue in _load_tasks()
...
Fixes #6800
12 years ago
James Cammarata
6f34a6336f
Differentiate decryption failures from empty data files in ansible-vault
...
Fixes #6822
12 years ago
BoscoMW
39fcbd1f10
Update ssh.py
12 years ago
BoscoMW
165406cf35
Catch permissions errors related to opening a known_hosts file
...
Catch permissions errors related to opening a known_hosts file
12 years ago
James Cammarata
e2d86e4f43
Splitting SETUP_CACHE into two caches, one for host vars and one for setup facts
12 years ago
James Cammarata
a4df906fc9
Fixes to safe_eval
12 years ago
Tim G
c307a73e28
Check for errors from adb, may not work on all systems.
12 years ago
Tim G
285d4f3fa6
If memory not available in syslog.log, catch error, attempt to find it with adb
12 years ago
Till Maas
e6cb32f284
ssh connection plugin: Make comments more verbose
...
Explain _communicate() more.
12 years ago
Till Maas
1da69309e5
ssh connection plugin: Report missing sudo password
...
If no password is provided, sudo hangs at the prompt. Identify this and
report that the password is missing as an error.
12 years ago
Till Maas
2cae7472ad
ssh: propagate prompt to _communicate()
...
_communicate() uses the prompt variable to detect wrong passwords early,
therefore it needs to be passed to it from exec_command().
12 years ago
James Cammarata
612a1a64f0
Apply extra vars after all other vars have been merged in a play
...
Fixes #6677
12 years ago
James Cammarata
b9c044b8c9
Making the exception caught during os.dup of stdin explicit
...
Related to f23bb34
12 years ago
James Cammarata
f23bb344aa
Catch errors when duping stdin
...
Fixes #6657
12 years ago
James Cammarata
4f140be711
Merge branch 'devel' of https://github.com/Synforge/ansible into Synforge-devel
12 years ago
James Tanner
efba8b4771
Merge branch 'regexreplace' of git://github.com/jacobweber/ansible into jacobweber-regexreplace
12 years ago
James Tanner
2492c2714a
Fixes #5307 set relative paths to the files dir for roles and the inventory dir for non-role tasks
12 years ago
Till Maas
b07113f358
ssh: Properly check for wrong su password
12 years ago
GuiGui2
b9613665dd
Setup module: Additional facts when using ansible with Linux on System z
...
- Improved parsing of /proc/cpuinfo to take the specifics of Linux on
System z. ansible_processor and ansible_processor_cores are now
completed.
- Also improved virtualization facts in the same environment, parsing
the output of /usr/bin/lscpu to populate virtualization_type and
virtualization_role more precisely. If lscpu is not available, then
stick to the previous behavior.
12 years ago
James Cammarata
b698f7a44b
Add option to create host_key directory if it doesn't exist
...
Fixes #6731
12 years ago
Matt Martz
7e3dd1066c
Allow raw and script to support su
12 years ago
Michael DeHaan
a6b25e8657
Allow type=list module arguments to accept integers and floats.
12 years ago
Michael DeHaan
9921f804f9
Merge pull request #6643 from herbygillot/fact-full-hostname
...
Add a fact providing the full hostname, without the domain portion
12 years ago
Cristian Ciupitu
96ff1444f0
Micro-optimization: replace s.find(x)==0 with s.startswith(x)
...
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
12 years ago
Cristian Ciupitu
1eaf85b89f
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
12 years ago
Paul Oyston
1942a69ed2
Added template call to _executor_internal to allow the passing of arbitrary data to modules.
12 years ago
Jesse Keating
3315ba0b99
Treat 255 errors from raw as dark host
...
Any other module is able to detect a dark host, but raw was treating 255
as a return code from the module execution, rather from the connection
attempt. This change allows 255 to be treated as a connection failure
when using the raw module.
12 years ago
James Cammarata
78bdb078fe
Fix for bug related to async jid polling change plus a new test
12 years ago
James Tanner
88462729aa
Addresses #6708 fill in missing keywords for ssh.py _communicate
12 years ago
jctanner
7dc3dc5279
Merge pull request #6708 from sivel/put-file-control-master
...
Share p.communicate alternative logic between exec_command and put_file
12 years ago
James Cammarata
e09313120c
Make async jid's unique per host
...
The jid will now also contain the PID of the async_wrapper process,
and can each unique jid from each host is tracked rather than just
relying on one global jid per task.
Fixes #5582
12 years ago
James Tanner
38de8cc87e
Addresses #6705 Only set the role_uuid inside the role vars
12 years ago
Matt Martz
b8cb23d309
Share p.communicate alternative logic between exec_command and put_file
12 years ago
James Tanner
8991e403e8
Fixes #6705 Give each role a unique uuid and apply tags only to tasks matching the uuid
12 years ago
James Cammarata
9ede6f7f49
Convert gather_facts to a boolean value if it is not None
...
Fixes #5618
12 years ago
James Tanner
2a976ac313
Fixes #5059 Ignore lookup failures when templating a task name
12 years ago
Serge van Ginderachter
b0ff1ea425
performance optimisation in hash merge logic
...
rewrite deepcopy in util.merge_hash and just iterate
on an inventory with 500 groups and 800 hosts this brings back the
inventory initialisation from 13s to 3s (with hash_behaviour=merge)
12 years ago
Serge van Ginderachter
d4634983f0
Move group/host_vars parsing into core inventory
...
modified: lib/ansible/inventory/__init__.py
deleted: lib/ansible/inventory/vars_plugins/group_vars.py
modified: lib/ansible/utils/__init__.py
12 years ago
James Cammarata
7a3fa63db5
Fix for unicode environment variable handling
...
Fixes #5395
12 years ago
Serge van Ginderachter
f8ea93c732
Move inventory.set_playbook_basedir from ansible-playbook to playbook constructor
12 years ago
Serge van Ginderachter
cc28fd891b
Introduce noop vars plugin.
...
In preparation to move the group_vars plugin code into core.
new file: lib/ansible/inventory/vars_plugins/noop.py
12 years ago
Serge van Ginderachter
f6a55a3552
Refactor vars_plugins (host/group_vars)
...
Split out parsing of vars files to per host and per group
parsing, instead of reparsing all groups for each host. This enhances
performance.
Extend vars_plugins' API with two new methods:
* get host variables: only parses host_vars
* get group variables: only parses group_vars for specific group
The initial run method is still used for backward compatibility.
Parse all vars_plugins at inventory initialisation, instead of
per host when touched first by runner. Here we can also loop through
all groups once easily, then parse them.
This also centralizes all parsing in the inventory constructor.
modified: bin/ansible
modified: bin/ansible-playbook
modified: lib/ansible/inventory/__init__.py
modified: lib/ansible/inventory/vars_plugins/group_vars.py
12 years ago
James Tanner
3194fbd365
Fixes #6655 catch unicode encoding errors before sending to syslog
12 years ago
jctanner
7b8d1c0ffd
Merge pull request #6580 from ramondelafuente/fix-vault-editor-call
...
Changed call to EDITOR to allow for parameters
12 years ago
Ramon de la Fuente
c79c001bfb
Changed call to EDITOR to allow for parameters
...
The EDITOR environment variable is used to create and edit files in the vault.
But if the EDITOR variable contains parameters, subprocess.call() breaks.
This fixes the EDITOR environment variable to be safely split into a list.
It adds a dependency on shlex.
12 years ago
James Cammarata
c9bf7eb9bb
Don't run {failed|changed}_when checks until async_status is done
...
Fixes #5117
12 years ago
James Cammarata
4ea12c1b86
Make sure stat of dest is available in atomic_move
...
Fixes #6682
12 years ago
James Tanner
f9018a6f1d
Ensure handlers run when meta tasks are defined and add handler integration tests
...
Fixes #6678
Fixes #6670
12 years ago
Michael DeHaan
3eecc039b9
Merge pull request #6656 from Jmainguy/setup
...
Added ansible_date_time.weekday as a fact. This returns Monday,Tuesday,W...
12 years ago
James Cammarata
8c7828d469
Tweaking error message resulting from undefined template variables
...
Fixes #5114
12 years ago
James Cammarata
846933dd53
Make inventory parsing error detection smarter
...
If something is executable but doesn't look like it should be, or if
something is NOT executable and DOES looks like it should, show a
more apropos error with a hint on correcting the problem
Fixes #5113
12 years ago
Michael DeHaan
a062912a1f
Merge pull request #6658 from pilou-/fix_fix
...
'changed' key is not defined when task fails
12 years ago
Michael DeHaan
9be732d8f2
Merge pull request #6679 from renard/fix-simplejson-module
...
Fix TypeError when using old simplejson lib.
12 years ago
Herby Gillot
94297950a0
Name platform.node() fact as "nodename"
12 years ago
James Tanner
ebd1f70c5d
Typo in setting task_errors variable
12 years ago
Sébastien Gross
ef6b437d0d
Fix TypeError when using old simplejson lib.
...
On some very old simplejson does not support the 'encoding' and give
following exception:
TypeError: __init__() got an unexpected keyword argument 'encoding'
This fix runs json.dump with no encoding key (such as before #a023cb) on
TypeError exception only.
12 years ago
Serge van Ginderachter
d3eaa1b79e
InventoryDir: refactor logic
...
Make sure all hosts and groups are unique objects
and that those are referenced uniquely everywhere.
Also fixes test_dir_inventory unit tests which were broken after previous
patches.
modified: lib/ansible/inventory/dir.py
12 years ago
Serge van Ginderachter
188375171e
Inventory: raise error when adding a group that already exists.
...
The parsers check if a group already exists.
12 years ago
Serge van Ginderachter
be58808fe4
inventory script parser: do not add all the groups to *all* group
12 years ago
Serge van Ginderachter
0ceefbbf29
inventory ini parser: do not add all the groups to *all* group
...
but only those with lowest depth, so we keep a proper tree structure
12 years ago
Serge van Ginderachter
cc8efb4aab
inventory groups: make sure group.depth is updated on all grandchildren
12 years ago
Serge van Ginderachter
1c86909875
inventory group: add groups to parent_groups only once
12 years ago
Serge van Ginderachter
36f55d3549
inventory directory parser: add host to group only once
12 years ago
Serge van Ginderachter
8b215149d4
inventory directory parser: add groups to parent_groups non-recursively
12 years ago
Serge van Ginderachter
262ba0460a
inventory directory parser: add hosts to group non-recursively
12 years ago
James Tanner
605156c904
Fixes premature handler execution after adding force-handlers
12 years ago
James Cammarata
bc93732b1d
Catch permissions errors related to opening a known_hosts file in modules
...
Fixes #6644
12 years ago
James Cammarata
dc658eaa1c
Check to make sure the host is in the inventory vars cache before clearing it
...
Fixes #6660
12 years ago
James Cammarata
db345391e3
Fixing ownership when atomic_move is creating a file while sudo'ing
...
Fixes #6647
12 years ago
Pierre-Louis Bonicoli
c76501b8a3
'changed' key is not defined when task fails
...
fix KeyError introduced by fix of #6591 .
12 years ago
Jonathan Mainguy
b17b5ad85b
Added ansible_date_time.weekday as a fact. This returns Monday,Tuesday,Wednesday,Thursday,Friday,Saturday, or Sunday depending on the remote servers time. Useful for backups the way I use it
12 years ago
James Cammarata
bb723bedee
Merge branch 'atomic_move_restore_owner_group_rebase' of https://github.com/tyll/ansible into tyll-atomic_move_restore_owner_group_rebase
12 years ago
James Tanner
9169a11088
Fixes #4777 add --force-handlers option to run handlers even if tasks fail
12 years ago
Herby Gillot
c0886a5f3a
Add a fact providing the full hostname, without the domain portion
...
truncated.
12 years ago
Michael DeHaan
fba2f1f9a9
Merge pull request #6639 from fvieira/devel
...
Add missing sha1 import on known_hosts.py
12 years ago
Michael DeHaan
a24d3f78d9
Merge pull request #6634 from pilou-/fix
...
Remove print statements
12 years ago
James Cammarata
31628d86a1
Adding in a configurable option for the accelerate daemon timeout
...
This was apparently an oversite, as it has never been configurable
despite having a module parameter for the timeout.
12 years ago
James Cammarata
3ea5d573aa
Acclerate improvements
...
* Added capability to support multiple keys, so clients from different
machines can connect to a single daemon instance
* Any activity on the daemon will cause the timeout to extend, so that the
daemon must be idle for the full number of minutes before it will auto-
shutdown
* Various other small fixes to remove some redundancy
Fixes #5171
12 years ago
Francisco José Marques Vieira
e9d7476c28
Add missing sha1 import on known_hosts.py
12 years ago
Pierre-Louis Bonicoli
d3a470db0c
Remove print statements
...
"print item" raises an exception when type of item is
jinja2.runtime.StrictUndefined
12 years ago
James Tanner
5b3b9ba267
Addresses #4407 Caculate failed percentage based on serial and number of hosts in play
12 years ago
Michael DeHaan
d0cbb51170
Merge pull request #6615 from 8191/devel
...
Addresses #6591 Hide diff for lineinfile if file did not change.
12 years ago
Manuel Faux
b8158f5f6a
Addresses #6591 Hide diff for lineinfile if file did not change.
12 years ago
Joshua Conner
1c504eff68
etcd lookup: use $ANSIBLE_ETCD_URL if it exists in the env
12 years ago
James Tanner
14499e8bf3
Fixes #4325 allow async and poll parameters to be templated vars
12 years ago
James Tanner
ea5186ca63
Fixes #6590 add set_remote_user parameter to synchronize
...
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
12 years ago
James Tanner
95c79ad483
Fixes #4239 merge injects with new vars loaded from files
12 years ago
James Tanner
d327e3d11a
Fixes #5622 included tasks in roles now inherit tags from the role
12 years ago
Till Maas
898a38b074
module_utils/atomic_move(): Use tempfile module
...
Fix a potential race condition by using the tempfile module.
12 years ago
Till Maas
8f778a83df
module_utils/atomic_move(): Restore owner/group
...
Manually restore owner and group if both src and dest are on a separate
file system.
12 years ago
Michael DeHaan
e639b5382b
Change default gathering policy, add to docs.
12 years ago
Brian Coca
18adf07fc6
changed setting values and updated docs
12 years ago
Brian Coca
4dfa40f18e
added gathering control to ansible, defaults to 'smart'
12 years ago
Michael DeHaan
c42dbf80a2
Merge pull request #6586 from sivel/probline-logic-fix
...
Fix logic in process_common_errors for unbalanced quotes
12 years ago
James Tanner
b8f627d1d5
Prevent rewriting the encrypted file if decryption fails
12 years ago
James Tanner
e71857fbdf
Addresses #6579 Only strip vault passwords if given
12 years ago
James Tanner
8c2e1e2baa
Addresses #6579 Disallow vault passwords with newline characters by stripping them in utils
12 years ago
James Cammarata
a9000e7f3a
Making the error messages for bad key/dir permissions more understandable
...
Fixes #6254
12 years ago
Matt Martz
2aaecc5afa
Fix logic in process_common_errors for unbalanced quotes
12 years ago
James Cammarata
4880cfb5ea
Merge pull request #6568 from sivel/ssl-cert-validation-osx
...
Make SSL verification on Mac OS X work out of the box
12 years ago
James Tanner
67517e96d3
Fixes #6567 put the git wrapper script in the module temp dir
12 years ago
Matt Martz
1d3d73a0b6
Only write the DUMMY_CA_CERT on OS X
12 years ago
Matt Martz
3b5aa8bd30
Provide a dummy ca to allow OS X to do it's OpenSSL keychain magic
12 years ago
James Cammarata
eb7717aa02
Make sure all tags are in a list before merging for role deps
...
Fixes #6557
12 years ago
James Cammarata
c9fcbf7bdd
Change print message to vvv for missing known hosts in ssh.py
12 years ago
James Tanner
49807877fa
Fixes #6550 Use shell for pipe lookup subprocess.popen calls
12 years ago
James Cammarata
3f5440f7df
Make modules set a valid working directory
...
Fixes #6546
12 years ago
James Cammarata
84908a57fc
Don't filter role deps on tags
...
Also, fixed a bug where the tags were being merged into the wrong
data structure (passed_vars) in _build_role_dependencies()
Fixes #6439
Fixes #5709
12 years ago
Michael DeHaan
9da26da335
Merge branch 'ini_vars' of git://github.com/dmage/ansible into devel
12 years ago
Michael DeHaan
13f69dad05
Merge pull request #6527 from patrickheeney/hosts-bug
...
Fix for hostkey directory
12 years ago
Michael DeHaan
94e3350b38
Catch a unquoted line error. Fixes #6532
12 years ago
jctanner
b8d5ba42f5
Merge pull request #6523 from sergevanginderachter/vault-in-subdirs
...
Pass through vault_password when parsing host/group vars as directories.
12 years ago
James Cammarata
c4f1c3c6b0
Merge branch 'bcoca-file_fixes_clean' into devel
12 years ago
James Tanner
ad70e9bcd6
Fixes #6227 skip non-unicode strings and catch decode errors silently in template_from_string
12 years ago
James Tanner
20262b6c15
Remove unused variable in _executor_internal
12 years ago
James Cammarata
5d8c9d3f0f
Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean
12 years ago
James Cammarata
7edee91aba
Fixing a bug in role tag handling where only the first tag was used
...
Fixes #6517
12 years ago
James Tanner
ebb6b8442b
Catch unicode unescape failures in copy action plugin
12 years ago
patrickheeney
a9aab23f11
Fix for hostkey directory
12 years ago
James Tanner
b14c658532
Fix concatenation for with_file
12 years ago
Serge van Ginderachter
280498a7e5
Pass through vault_password when parsing host/group vars as directories.
...
Fixes a bug where vault_password parameter was not passed through in
_load_vars_from_folder()
modified: lib/ansible/inventory/vars_plugins/group_vars.py
12 years ago
Greg Dallavalle
77229553a3
fetch_url: Avoid credential stripping for FTP-scheme URLs
12 years ago
Michael DeHaan
fe696e4720
Merge commit.
12 years ago
Michael DeHaan
b41541c62a
Merge conflict.
12 years ago
Michael DeHaan
fd0ff6f174
Merge pull request #5711 from sivel/plugin-realpath
...
Use realpath for plugin directories instead of abspath
12 years ago
Michael DeHaan
6144c5e1e2
Merge pull request #5714 from eggsby/patch-2
...
Allow templates in ansible_sudo_pass inventory var
12 years ago
Michael DeHaan
b0dbc61d63
Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
...
license -- so usage of facts code in modules will be limited to GPLv3 modules.
12 years ago
Michael DeHaan
b8f1e4f765
Merge pull request #6134 from veeti/include_with_items_path
...
Show the offending file name with the include + with_items error
12 years ago
Michael DeHaan
4a06954a13
Merge pull request #6390 from sergevanginderachter/group-varsdirs-svn
...
group_vars plugin: do not parse hidden files in subfolders
12 years ago
Michael DeHaan
9cdbc53741
Merge pull request #6420 from bcoca/role_names
...
added new role_names variable that exposes current roles list
12 years ago
Michael DeHaan
26efc7ace8
Revert "Populate module_setup from the setup module rather than special code elsewhere"
...
This reverts commit 58eec2e4c2 .
12 years ago
Oleg Bulatov
f6a4c20cc0
Make parsing variables for hosts and groups more consistent
...
This commit allows to specify arrays in [group:vars] block.
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
12 years ago
Michael DeHaan
a9896afc66
Merge pull request #6418 from bcoca/template_itnore_errors
...
templates ignore_errors
12 years ago
Michael DeHaan
d5856bd475
Merge pull request #6391 from sergevanginderachter/hashmerge_inventoryscripts
...
Allow hash_behaviour=merge to be respected in core inventory
12 years ago
Dag Wieers
58eec2e4c2
Populate module_setup from the setup module rather than special code elsewhere
...
This small change allows for individual setup actions to populate the SETUP_CACHE and not cause a subsequent facts-gathering when not needed. This follows the standard of other facts modules as laid out in #1206 and implemented in fedfd18774 . It allows to test of the setup module has already been run even when gather_facts was explicitely disabled.
12 years ago
Michael DeHaan
3d44f7cd51
Merge pull request #6217 from ashokrajar/patch-1
...
pause plugin doesn't flush raw_input prompt
12 years ago
Cristian Ciupitu
0749112286
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
12 years ago
Cristian Ciupitu
a7da5d8702
Micro-optimization of inventory.expand_hosts.detect_range
12 years ago
brdo
3963a64a4f
Set keepalive to 5 seconds in paramiko_ssh.py
...
This update resolves https://github.com/ansible/ansible/issues/6476 .
12 years ago
Brian Coca
2d25577e11
Fixes and cleanup to file functions and module
...
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
12 years ago
James Cammarata
a0cb974575
Be sure to return to the old directory if cwd is set in run_command
12 years ago
James Tanner
a348f67238
Reset the current directory after running subprocess.Popen
12 years ago
James Cammarata
677008bef7
Rejoin args list into a string for run_command when using an unsafe shell
...
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
12 years ago
James Cammarata
5233d4bc31
Fix typo in run_command when sending data that is not binary
12 years ago
James Cammarata
b1a37dcc08
Revert "Rejoin args list into a string for run_command when using an unsafe shell"
...
This reverts commit 4273cb2d8e .
12 years ago
James Cammarata
4273cb2d8e
Rejoin args list into a string for run_command when using an unsafe shell
...
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
12 years ago
Michael DeHaan
d1753046e0
Revert "Correctly catch template errors without returning invalid data"
...
This reverts commit 3cd7d47b7e .
12 years ago
James Cammarata
303e085f8b
Only use cwd in run_command kwargs if the directory exists
12 years ago
James Cammarata
60a7f57300
Make sure the cwd exists in run_command before trying to use it
12 years ago
Dan Koch
bbf320fd22
Work around for cwd stat problems with run_command and sudo
...
This fixes issue #6443
12 years ago
James Cammarata
2c7d58abe0
Compile ca certs into a temp file to reduce number of attempts
...
For those who may have a large number of certs found, this can reduce
the number of ssl connections attempted.
12 years ago
Michael DeHaan
d37f0c6d12
Use same implementation as ssh.py for "is in host file" checks in module code, prevents git module from adding keys more than once.
12 years ago
Michael DeHaan
6d841d120e
Don't process shell commands as arrays.
12 years ago
James Cammarata
86d2ee4b97
Don't append tags from roles to the plays tags list
...
Fixes #6393
12 years ago
James Cammarata
a9017af2bb
Adding validate_certs to all modules that use fetch_url
12 years ago
Michael DeHaan
cfabc2e28a
module.run_command is intended to bypass the shell here, so can't do ">>"
12 years ago
James Cammarata
7f38cff989
Remove unused code from get_ca_certs() function
12 years ago
James Cammarata
804e4166c8
Rewriting ssl validation to try multiple certs found in paths
...
Previously, the function checked only for a single CA root cert, however
some distributions may have multiple certs in a directory. This will now
try any .crt or .pem file contained within several common paths for
each platform.
Fixes #6412
12 years ago
Michael DeHaan
0b0ca95731
Expand environment variables and tildes passed to commands generically across the board.
12 years ago
James Tanner
0e38f5dfdc
Check for hash availability during vault operations
12 years ago
Brian Coca
906e59d8a8
added new role_names variable that exposes current roles list
12 years ago
Brian Coca
7778aca966
templates ignore_errors
12 years ago
James Cammarata
6c25e78299
Merge branch 'devel' of https://github.com/dparalen/ansible into dparalen-devel
12 years ago
James Tanner
e4e64a9699
Rename lxc to libvirt_lxc
12 years ago
James Cammarata
bca6adc812
Merge pull request #4064 from mscherer/lxc
...
Add a plugin that permit to use ansible for lxc system, using libvirt
12 years ago
James Cammarata
430cce9df3
Merge branch 'ec2_security_token' of https://github.com/willthames/ansible into willthames-ec2_security_token
12 years ago
Serge van Ginderachter
6b1cb22fc3
Allow hash_behaviour=merge to be respected in core inventory
...
(For now, this means, enable it also for inventory scripts)
12 years ago
Serge van Ginderachter
29c60bdaff
group_vars plugin: do not parse hidden files in subfolders, e.g. avoid .svn/
12 years ago
James Tanner
6740a1f342
Wrap crypto.hash imports with try/except
12 years ago
Michael DeHaan
411bcb7161
Merge remote branch 'real/devel' into devel
12 years ago
Michael DeHaan
2fa6110961
Update the message about pycrypto to include that python-devel must be installed.
12 years ago
James Tanner
0d6f6ad282
Implement new default cipher class AES256
12 years ago
Michael DeHaan
20f0157152
Merge pull request #6378 from franckcuny/headers-gce-utils
...
Add BSD license to module_utils/gce.py
12 years ago
James Tanner
ba0fec4f42
Force command action to not be executed by the shell unless specifically enabled
12 years ago
James Cammarata
9730157525
Validate SSL certs accessed through urllib*
...
* Adds another module utility file which generalizes the
access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.
Fixes #6211
12 years ago
James Cammarata
6577ff5f85
Add tags from handlers to tag availability calculation
12 years ago
Richard Isaacson
4993cb57f4
Merge pull request #6283 from magicrobotmonkey/upstream
...
fix missing stdin in _parallel_runner
Tested with GIST https://gist.github.com/risaacson/7290d30a612e0c70ea1b .
Passes "make tests"
Passes non_destructive tests.
12 years ago
Franck Cuny
82f99bfa3d
Add BSD license to module_utils/gce.py
12 years ago
Matt Martz
4b400ca5e9
Only used stripped data for testing if the file is json, but used unstripped when actually parsing. Fixes #6348
12 years ago
Seth Woodworth
1d5db30067
Updates loop warning, removes unnecessary c
12 years ago
James Cammarata
04a6dc6d12
Check for skipped tags in passed role variables before adding to them
...
Fixes #6330
12 years ago
Michael DeHaan
d2cb35f898
Merge pull request #6320 from angstwad/instance-redo
...
Use isinstance() rather than a check using type()
12 years ago
James Cammarata
4753804ab4
Merge pull request #6332 from jimi-c/issue_6329_space_in_var
...
Correctly catch template errors without returning invalid data
12 years ago
James Cammarata
e3b887f770
Fix range issue in inventory and add additional error checking
...
Fixes #6331
12 years ago
James Cammarata
3cd7d47b7e
Correctly catch template errors without returning invalid data
...
Fixes #6329
12 years ago
James Cammarata
f80d02d841
Properly wrap logical elements together for su/sudo detection
12 years ago
James Cammarata
b6056044b7
Partial revert of 73c883c due to issues with handlers in roles
...
Fixes #6322
12 years ago
Michael DeHaan
e486dbab04
Use the loaded variable since we have it assigned, not just for error detection.
12 years ago
Michael DeHaan
3f07ec3d73
Fixup JSON error reporting in previous commits.
12 years ago
Michael DeHaan
a4d01b0891
Also search .json filenames
12 years ago
Michael DeHaan
79799f6819
Allow any file that can be in YAML to also be in JSON. This is primarily done to support non-visual editors better.
12 years ago
James Cammarata
a0f939581d
Merge branch 'aresch-devel' into devel
12 years ago
Paul Durivage
3cce3650e5
Use isinstance() rather than a check using type()
12 years ago
Richard Isaacson
119434d079
Merge pull request #6319 from risaacson/fix_test_dir_inventory
...
Fix TestInventory Unit Tests
Tested clean.
12 years ago
James Cammarata
9b79591f23
Merge branch 'devel' of https://github.com/aresch/ansible into aresch-devel
12 years ago
James Cammarata
2a0028e687
Sanitize run_command argument output
...
Fixes #6316
12 years ago
Andrew Resch
4d80019ac8
Fix logic checking for both sudo and su, and their respective users
12 years ago
Richard C Isaacson
16fe09eef8
Fixes related to uncommenting test_dir_inventory in TestInventory.
...
0. Uncomment the test.
1. Test fails.
2. Make vars unique per file in test inventory files.
3. Modify token addition to not ast.literal_eval(v) a variable containing a hash.
4. Modify vars to have an escape in test inventory file.
5. Catch exceptions explicitly. Any unknown exceptions should be a bug.
6. Test passes.
12 years ago
James Cammarata
9f2999df79
Un-escape newlines in delimiters for assemble module
12 years ago
Brian Coca
79809b67dc
fixed another line with same issues
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Brian Coca
d3d5680d8f
tags lists are properly uniqued and joined now, also avoids type issues when passed as list/set or strings
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Will Thames
b9a7352e0a
Work to allow security tokens and profiles to work with Ansible
...
Allow security tokens and profiles to be used as arguments
to the 'common' ec2 modules
Mostly refactoring to provide two new methods,
`get_aws_connection_info`, which results in a dict that can be
passed through to the boto `connect_to_region` calls, and
`connect_to_aws` that can pass that dict through to the
`connect_to_region` method of the appropriate module.
Tidied up some variable names
Works around boto/boto#2100
profiles don't work with boto < 2.24, but this detects for that
and fails with an appropriate message. It is designed to work
if profile is not passed but boto < 2.24 is installed.
Modifications to allow empty aws auth variables to be passed
(this is useful if wanting to have the keys as an optional
parameter in ec2 calls - if set, use this value, if not set,
use boto config or env variables)
Reworked validate_certs improvements to work with refactoring
Added documentation for profile and security_token to affected modules
12 years ago
James Cammarata
0e98496e12
Merge pull request #6299 from jimi-c/issue_4656_role_deps_across_plays
...
Keep track of role dependencies across plays
12 years ago
Michael DeHaan
94a7fb60fe
Allow escaped comments in inventory files.
12 years ago
aresch
23a0468a4b
Fix respecting remote_tmp when sudo is used
12 years ago
James Tanner
4e8ed92130
Fixes #6077 decode escaped newline characters in content for the copy module
12 years ago
Richard C Isaacson
b41d8106ff
Revert "Merge pull request #6287 from risaacson/fix_hash_in_var"
...
This reverts commit a808287451 , reversing
changes made to 6129ea7566 .
12 years ago
James Cammarata
73c883c122
Keep track of role dependencies across plays
...
Also fixes a bug in which tags specified on top-level roles were
not being passed down to dependent roles.
Fixes #4656
12 years ago
Richard Isaacson
a808287451
Merge pull request #6287 from risaacson/fix_hash_in_var
...
Fix inventory for test_dir_inventory, merge PRs from GH-5749, cleanup some formatting.
12 years ago
James Tanner
6129ea7566
Fixes #6298 and adds a sudo unit test for synchronize
12 years ago
Richard C Isaacson
38abd5e20e
Break this out into a reusable function and document regex shortcomings.
12 years ago
Luca Berruti
7cf363910a
fixes #6244
12 years ago
jctanner
40ee030790
Merge pull request #6265 from franckcuny/gce-fixes
...
Add credential parameters to the GCE modules.
12 years ago
Franck Cuny
6294264dc4
Add credential parameters to the GCE modules.
...
In order to simplify the workflow with the GCE modules, it's now
possible to add the parameters and project name as arguments to the
various GCE modules.
The inventory plugin also returns the IP of the host in
`ansible_ssh_host` so that you don't have to specify IPs into the
inventory file.
Some update to the documentation are also added.
Closes #5583 .
12 years ago
Richard C Isaacson
49bd8b0b35
Fix inventory for test_dir_inventory
...
It came up that fixing this unit test may relate to another ticket that is open. This work allows us to uncomment this unit test by fixing how we pars variables allowing a quoted variable to contain a '#'.
Work also went into cleaning up some of the test data to clarify what was working.
Lastly work went into cleaning up formatting so that the code is easily read.
12 years ago
Aaron Bassett
5c589af191
fix missing stdin in _parallel_runner
12 years ago
Richard Isaacson
92aacb198c
Merge pull request #6156 from iiordanov/devel
...
Add support for checking host against global known host files.
The effect of this is that before this fix if files are spread across the known_hosts file but not in the ~/known_hosts file the hosts will execute sequentially. This PR augments the functionality so that all of the knowns hosts will execute in parallel.
12 years ago
Richard Isaacson
e79d859dfb
Merge pull request #6213 from sergevanginderachter/fix-delegate-templating
...
Fixes templating of ansible_ssh_host for delegates.
Tested that this works. Confirmed.
12 years ago
Michael DeHaan
435104065e
Merge pull request #6248 from hkariti/fix_list_copy
...
Fix incorrect use of copy() on list, causing a traceback
12 years ago
Jesse Keating
0c2c37a47a
Avoid range selection on empty groups
...
This prevents a traceback when the group is empty.
Fixes #6258
12 years ago
James Tanner
623cd9ac50
Revert "Merge pull request #6250 from dagwieers/gather_facts-once"
...
This reverts commit b769b4181a , reversing
changes made to 1e01fb856d .
12 years ago
Dag Wieers
0da06eff5c
Fix regression causing setup to run for every play
...
This patch makes sure setup only runs once, unless it is enforced on a play.
12 years ago
Hagai
0e4b38ed5a
Fix incorrect use of copy on list
12 years ago
Tefnet
c652802d29
missing import in assert module
...
Fixed missing ansible.errors import in assert module
12 years ago
Michael DeHaan
16d3be03af
Remove a few extra legacy variable feature references.
12 years ago
Michael DeHaan
46ec8759d5
Remove the legacy templating code, which was guarded by deprecation warnings in the previous two releases, and undocumented for a long time. use {{ foo }} to access variables instead of ${foo} or $foo.
12 years ago
Michael DeHaan
9d01d88a57
Bump versions on the devel branch (devel branch version is 1.6)
12 years ago
Michael DeHaan
5443ddec75
Trim references to fireball as we want folks using accelerate or pipelining options. Fireball is pretty well deprecated at this point, but will still be part of the release.
12 years ago
James Cammarata
79645535c0
Handle empty results from failed connections in _remote_md5()
...
Fixes #5800
12 years ago
Gilles Cornu
04f6367172
Fully clean 'ssh_old' and 'paramiko_alt' options
...
These transports have been removed in 33857855ad
12 years ago
Ashok Raja R
cb3c6417dd
pause plugin doesn't flush raw_input prompt
...
##### Issue Type:
Bugfix Pull Request
##### Ansible Version:
ansible 1.4.3
##### Environment:
N/A
##### Summary:
We are using a wrapper python script to run ansible-playbook. We use subprocess to execute and print the stdout as and when its written. Problem is when we use pause it doesn't display the prompt string as raw_input does not flush stdout before reading from stdin.
It looks like a dirty fix to add "\n" to the prompt string but i don't see any other way to over come this. If anyone else have a better fix please do propose/suggest.
##### Steps To Reproduce:
```yaml
#File: test_play.yml
- name: Test
hosts: $nodes
gather_facts: false
tasks:
- name: Waiting for User
local_action: pause prompt="Do you want to continue (yes/no)? "
```
```python
#!/usr/bin/env python
#File: test.py
import shlex, subprocess
def run_process(process):
process = process.encode("utf-8")
command = shlex.split(process)
p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
for line in iter(p.stdout.readline, b''):
print line,
cmd = "/usr/bin/python -u /usr/bin/ansible-playbook -i hosts.txt test_play.yml -e 'nodes=local'"
run_process(cmd)
```
```
shell $ python test.py
```
##### Expected Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
Do you want to continue (yes/no)? :
```
##### Actual Results:
```
PLAY [Test] *******************************************************************
TASK: [Waiting for User] ******************************************************
[localhost]
```
12 years ago
James Cammarata
df9de6ea71
Expand the source path in the action plugin when not using a remote source
...
Fixes #6209
12 years ago
Serge van Ginderachter
9833263417
Fixes templating of ansible_ssh_host for delegates
12 years ago
James Cammarata
c11e2100e0
Save the original transport in runner after detecting the smart transport
...
Fixes #6192
12 years ago
Michael DeHaan
cd7d7eb1bc
Merge pull request #6202 from muffl0n/unarchive_destdir
...
unarchive: output dest in error-message
12 years ago
muffl0n
17946b23d5
output dest in error-message
12 years ago
Richard C Isaacson
9c8bbe2904
column must always be less than len(probline)
...
Fixes related to GH-5773.
12 years ago
James Cammarata
14ba10393b
Minor tweak to region config in boto configuration file
12 years ago
James Cammarata
88acb48e61
Merge branch 'ec2_boto_config_region' of https://github.com/willthames/ansible into willthames-ec2_boto_config_region
12 years ago
James Cammarata
2a383786dd
And remove the expanduser calls from the action_plugin
12 years ago
Richard C Isaacson
585766201d
When looking for double colon len(line) is longer then 1.
...
Addresses GH-5116.
It comes up that when parsing json that if you are missing the last double quote on the last variable and the next line is just '}' we will get an out of range error. In this instance we will also then make sure that the line is long enough to have two colons.
12 years ago
James Cammarata
b758ed9417
Merge pull request #6150 from hkariti/fix_join_bug
...
Fix incorrect use of .join on list causing a traceback
12 years ago
James Cammarata
96f1c3ce2e
Move where the expanduser call is made, to avoid issues with None
12 years ago
James Cammarata
e659d55d62
Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel
12 years ago
James Cammarata
5ff20c1ae7
Merge branch 'scottanderson42-ec2-params' into devel
12 years ago
James Tanner
baed7a0ed9
Fixes #6187 Add unit tests for VaultLib
12 years ago
Michael DeHaan
33857855ad
removing some unusued files. Paramiko alt was an experiment to attempt pipeline for paramiko, ssh_old is the non-pipelining-supported earlier
...
version of the OpenSSH transport, which is configurable now and unified.
12 years ago
James Tanner
35def422a3
Addresses #6188 Add --vault-password-file to bin/ansible and bin/ansible-playbook
12 years ago
James Cammarata
8a7c68dc18
Merge branch 'ec2-params' of https://github.com/scottanderson42/ansible into scottanderson42-ec2-params
...
Conflicts:
lib/ansible/module_utils/ec2.py
library/cloud/ec2
12 years ago
Richard C Isaacson
af616fe15e
Rename flatten funciton.
...
flatten(x) is used a lot in the various lookup plugins where in each it is slightly different. This is to make this name slightly more unique.
12 years ago
Kent R. Spillner
1fcc9ff666
lookup_plugins: loop over hashes
...
Create a lookup plugin named dict that can be used to loop over hashes.
It converts a dict into a list of key-value pairs, with attributes named
"key" and "value." Also adds a brief explanation and simple example to
the docs.
Signed-off-by: Kent R. Spillner <kspillner@acm.org>
12 years ago
James Tanner
876035c0b1
Fixes #6161 Get the delegate host info properly from the hostvars object
12 years ago
James Tanner
9209581565
Fixes #6155 Inject checkmode into synchronize module args
12 years ago
James Cammarata
a18f811b2d
Merge branch 'jimi-c-issue_4620' into devel
12 years ago
James Cammarata
f23ccebbdc
Merge branch 'issue_4620' of https://github.com/jimi-c/ansible into jimi-c-issue_4620
12 years ago
James Tanner
0f95a905d9
Fixes #5965 Ensure the inject for each item in a loop is un-altered
12 years ago
Iordan Iordanov
a1854bb762
Add support for checking host against global known host files.
12 years ago
James Cammarata
3b2d409906
Fixing several bugs in assemble and updating tests
...
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
resulting in it never being used by the module as the default behavior
was remote_src=True (issue #5581 )
* the remote_src param was not listed in the generic file params, leading
to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
fragments do not run together on one line
Fixes #5581
12 years ago
jctanner
8a253bf576
Merge pull request #6151 from jctanner/vault_rewrite
...
Vault rewrite, pass 1
12 years ago
jctanner
93c746db9c
Merge pull request #5651 from nikut/sshfix
...
allow ansible_ssh_private_key_file to be templated (thanks to benno)
12 years ago
James Tanner
9c9f15acb7
Fix decryption error
12 years ago
James Tanner
52a8efefba
Vault rewrite, pass 1
12 years ago
Hagai
ae9c0d87a9
Fix incorrect use of .join on list
12 years ago
Richard C Isaacson
8be8dbc9ed
Formatting cleanup.
12 years ago
Richard C Isaacson
aaf0a182e1
Merge remote-tracking branch 'jeromew/ansible_script_creates' into issues_4986
12 years ago
Veeti Paananen
dd6f2e6bfa
Show the offending file name with the include + with_items error
12 years ago
Michael DeHaan
9686695170
Assume empty files are unencrypted.
12 years ago
James Tanner
4af1d6098b
Fixes #5939 Allow for delegate hosts that are not in inventory
12 years ago
James Cammarata
fa1ab231c9
Fixing bug in which playbook vars were not merged properly
...
This occurred when a hash would be passed in via extra args and the
hash variable behavior was set to 'merge', which resulted in the
variable from extra args replacing the playbook variable.
12 years ago
Michael DeHaan
bc65956798
Add tests that leverage most of our custom filters. A few more to add.
12 years ago
James Cammarata
f5505425f9
Adding 'expanduser' filter to the core filters list
...
Example usage: {{ my_path | expanduser }} # my_path: "~/path/to/file"
12 years ago
James Cammarata
ef2df8157a
Fixup result dictionary when copy module calls file module
12 years ago
muffl0n
b0f00cc097
already call expanduser in action_plugin
12 years ago
muffl0n
5f0e882d01
call expanduser for src and dest
12 years ago
root
0df166e7c0
Copy tests WIP, fix bug in assert module upgrades where the wrong value was being checked.
12 years ago
James Cammarata
54117ab28f
Modified assert module to take tests as an array
12 years ago
James Tanner
bee089d5e1
Remove entropy comment
12 years ago
James Tanner
86b9f84fb9
Change entropy message for vault
12 years ago
Richard Isaacson
dc403eb21e
Merge pull request #6058 from jctanner/vault_squashed_2
...
Ansible vault: a framework for encrypting any playbook or var file.
12 years ago
James Tanner
3a965a1392
Remove intermediate string on decrypt
12 years ago
James Tanner
286ca505bd
Remove breakpoint
12 years ago
James Tanner
84467a8f12
Change retype to confirm
12 years ago
James Tanner
aa46ab1d86
Fix function name
12 years ago
James Tanner
3fc87e011b
Fix all other calls to yaml
12 years ago
James Cammarata
b6222abee6
Fix unicode decode error in syslog for modules
...
Fixes #6056
12 years ago
James Tanner
427b8dc78d
Ansible vault: a framework for encrypting any playbook or var file.
12 years ago
Richard C Isaacson
1ac19cb981
Copy action_plugin: encode content when dict.
...
When content is processed and found to be valid JSON it is decoded into a dict. To write it out to a file we need to encode it back into a string.
Addresses GH-5914.
12 years ago
James Cammarata
f29ce80d12
Default port to 22 for paramiko when it is unset
12 years ago
James Cammarata
92cbfff904
Merge branch 'sshdefault' of https://github.com/craigtracey/ansible into craigtracey-sshdefault
12 years ago
jeromew
7a14cb61c4
Add creates= and removes= to the script: action
12 years ago
Niku Toivola
6cc9b16f06
allow templating of ansible_ssh_private_key_file also in the synchronize module
12 years ago
Niku Toivola
2faaff78ee
removed comment
12 years ago
Niku Toivola
68a3e8163e
allow ansible_ssh_private_key_file to be templated (thanks to benno)
12 years ago
Martin Thorsen Ranang
7e23ed345f
Avoid breaking on unicode input when logging to syslog in modules
...
After commit 254f87e , non-ascii input broke logging to syslog.
12 years ago
James Cammarata
0cfaabf9cb
Make sure unicode params don't break logging in modules
12 years ago
James Cammarata
788ac51185
Sanitize sudo success_key from stdout for raw/script modules
...
Fixes #5533
Closes #5605
Closes #5606
Closes #5607
12 years ago
Richard C Isaacson
80ddd1ca75
Config resoution order correction and documentation.
12 years ago
James Cammarata
4012f4bb95
Merge branch 'allow-equals-in-ini-vars' of https://github.com/worklez/ansible into worklez-allow-equals-in-ini-vars
12 years ago
James Cammarata
faa645c834
Merge pull request #6001 from jimi-c/issue_4087_sanitize_output
...
Filter out messages that match the pattern username:password@host
12 years ago
Ilya Kuznetsov
0658847ea6
Allow equal sign in single-line ini variables
12 years ago
Michael DeHaan
c91ceddfac
Add the start of an integration test structure using Ansible playbooks, also added an assert action plugin to make writing those easier.
12 years ago
Chris Hoffman
affed67ebd
Small fix for ec2 validate_certs option
12 years ago
James Cammarata
b8646991db
Filter out messages that match the pattern username:password@host
...
This filtering is done in both the module invocation logging and in
the regular verbose() logging output.
Fixes #4087
12 years ago
James Cammarata
056d54ebd3
Adding 'validate_certs' option to EC2 modules
...
When disabled, the boto connection will be instantiated without validating
the SSL certificate from the target endpoint. This allows the modules to connect
to Eucalyptus instances running with self-signed certs without errors.
Fixes #3978
12 years ago
Brian Coca
31b5728618
directory detection should now work on BSDs, added AIX alternate path
12 years ago
James Cammarata
254f87e7dd
Fix log handling of unicode output to syslog in modules
12 years ago
Richard Isaacson
eb4a730933
Merge pull request #5969 from risaacson/pull_5136
...
Updates for the unarchive module and action_plugin.
12 years ago
Richard C Isaacson
598b9c6b7c
Cleanup per notes.
...
Some small changes to per notes from @mpdehann.
12 years ago
Richard C Isaacson
cb7c2b7524
Updates for the unarchive module and action_plugin.
...
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.
PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!
Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.
Tests were added via a playbook with archive files to verify functionality.
All tests fire clean including custom playbooks across multiple linux and solaris systems.
12 years ago
Jacob Weber
35742fe008
Add regex_replace jinja2 filter
12 years ago
Richard C Isaacson
e6c9705058
Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136
12 years ago
James Cammarata
a023cbce14
When using jsonify in modules, try several unicode encoding for dumps()
...
Fixes #4821
12 years ago
James Tanner
9ce46e5f41
Refactor the synchronize action plugin and add unit tests
12 years ago
James Cammarata
3f90020d62
Open LOG_LOCK file with FD_CLOEXEC to prevent file descriptor leakage
...
Fixes #5399
12 years ago
James Cammarata
bbda98a3ee
Merge branch 'issue_4812' into devel
12 years ago
James Cammarata
bb79b16d59
Specify mode in the makedirs call for fireball/accelerate keys
12 years ago
James Cammarata
65cb79a5c1
Merge branch 'devel' of https://github.com/xyrix/ansible into xyrix-devel
12 years ago
Scott Anderson
baf508a379
Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key.
12 years ago
Richard C Isaacson
786e3d2fd2
Refining the fix made in #5885 .
...
It turns out that some of the assumptions in #5885 were slightly off. The previous fix relied on a call to the module to creat a tmp_path. This is insufficent as there are few cases that we need to have the tmp directory before we make the module call. If we don't have a tmp_path before we do a recursive call or when we find a file that does not match the remote md5 hash we need to create a tmp directory. Also we are not more percise when we will need to clean up the remote tmp_path.
12 years ago
Michael DeHaan
1609dfbca4
Revert "Revert "Revert "Add the fork manager code (related to previous patch)."""
...
This reverts commit 60d3611b70 .
12 years ago
Michael DeHaan
633d685bb7
Revert "Revert "Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks"""
...
This reverts commit 73ca1a173c .
12 years ago
Michael DeHaan
ad8c275887
Revert "While the previous work on the foon class can't be quite recycled, it's still a nice abstraction."
...
This reverts commit caab52aee2 .
12 years ago
Michael DeHaan
caab52aee2
While the previous work on the foon class can't be quite recycled, it's still a nice abstraction.
12 years ago
Michael DeHaan
73ca1a173c
Revert "Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks""
...
This reverts commit 6685b4989e .
12 years ago
Michael DeHaan
60d3611b70
Revert "Revert "Add the fork manager code (related to previous patch).""
...
This reverts commit c53538dc77 .
12 years ago
Michael DeHaan
6685b4989e
Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks"
...
This reverts commit 85d66b9a0c .
12 years ago
Michael DeHaan
c53538dc77
Revert "Add the fork manager code (related to previous patch)."
...
This reverts commit adb1719fe8 .
12 years ago
Michael DeHaan
adb1719fe8
Add the fork manager code (related to previous patch).
12 years ago
Michael DeHaan
85d66b9a0c
This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks
...
between tasks in a playbook is avoided. The fork pool will be regenerated when a second play comes along and needs more hosts.
12 years ago
Richard Isaacson
2d88246c9d
Merge pull request #5885 from risaacson/issue5739_4
...
Addresses #5739 and cleans up copy.py
12 years ago
James Tanner
b3ab7e7885
Check mutually_exclusive parameters before applying defaults
12 years ago
Will Thames
d5c309e20d
Pick up default EC2 region from boto.config
...
This doesn't account for boto configs where e.g. RDS has one
default region and EC2 another - all will default to `ec2_region_name`.
However, this is just handy to allow an easy site wide default
region if existing configuration already relies on it.
Modules can be improved to mention this in the documentation and
turn off required=True where needed. But it works with `ec2`
and `ec2_vol` without change.
12 years ago
jctanner
0bc0315171
Merge pull request #5880 from willthames/ec2_modules_refactor
...
Create a common EC2 connection argument spec for EC2 modules
12 years ago
xyrix
20d97416e5
fixed thinkoes
12 years ago
xyrix
0af40374ed
fixed file perms checking
12 years ago
xyrix
1de45bf687
made accelerate keys directory configurable, and permissions for the file and dir configurable, and gave them a safe default
12 years ago
James Cammarata
a72dc2ec34
Use finalize method in jinja2 to convert None values to empty strings
...
Fixes #4812
12 years ago
Will Thames
7600c664fe
Create a common EC2 connection argument spec for EC2 modules
...
Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
12 years ago
jctanner
28933de84d
Merge pull request #5771 from bcoca/play_hosts2
...
added new play_hosts var
12 years ago
James Cammarata
959a156195
Properly count newlines appearing at the end of templates after rendering
...
Fixes #4633
12 years ago
James Cammarata
ca0ec800d8
Revising method for parsing ranges from --limit subsets
...
Also added a new test (test_subset_range) for future validation.
Fixes #4620
12 years ago
Richard C Isaacson
ac0a5c8ad5
Dug into the remaining FIXME and replaced with comments to document the expected behavior.
12 years ago
Luca Berruti
75b7a1d9c7
Fix slow ssh
...
We break the read while loop after waiting "the end of the process" and
the pipes are empty, otherwise we do another select that waits all the
timeout.
12 years ago
jctanner
a0f91f2aaa
Merge pull request #5576 from xyrix/symlink-bug-fix
...
fixed bug causing symlinks to fail in the host_vars, group_vars etc dire...
12 years ago
jctanner
253fe7be50
Merge pull request #5662 from RSpiertz/update_playbook_error
...
PlayBook: better error message
12 years ago
Richard C Isaacson
a3261500dd
Addresses #5739 and cleans up copy.py
...
The copy action_plugin is not easy to read. Part of this commit is taking that file, restructuring it, and adding comments. No functionality changed in how it interacts with the world.
The fix for #5739 ends up being the assumption that there is a cleanup 'rm -rf' that happens at the end of the copy loop. This was not the fact before and we made a bunch of tmp directories that we hoped would end up being cleaned up. Now we just use the tmp directory that the runner provides and cleanup inline if it is a single file to be coppied or after the loop if it is a recursive copy.
As a part of this we did end up having to change runner to provide a flag so that we could short the inline tmp directory removal. This flag defaults to True so it will not change the behavior of other modules that are being called.
12 years ago
James Tanner
5fafc61008
Fixes 5870 Template delegate hostname earlier in the process
12 years ago
James Tanner
d355d3c698
Fixes #5818 Default to all known connection information for the delegate host
12 years ago
Timur Batyrshin
658c15930e
reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 ( #5852 )
12 years ago
James Cammarata
2d0e9cd75d
Revert "Fix for issue 5739. The copy module does not delete directories it will only unlinks symlinks."
...
This reverts commit b20dc4f578 .
12 years ago
James Cammarata
ae9843fccd
Fix issue with handler notifications being sent out incorrectly
...
This is a partial revert of e8ad36c , which introduced the bug.
Fixes #5848
12 years ago
James Cammarata
9ff99acaff
Merge branch 'issue5739_3' of https://github.com/risaacson/ansible into risaacson-issue5739_3
12 years ago
Brian Coca
ff024b65b2
now with_items also accepts sets
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Richard C Isaacson
b20dc4f578
Fix for issue 5739. The copy module does not delete directories it will only unlinks symlinks.
12 years ago
James Cammarata
75e3b59bbd
Adding no_log: capability for tasks
...
Fixes #4088
12 years ago
James Tanner
e6aeb191d5
Revert "Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh"
...
This reverts commit fe091ec00d , reversing
changes made to aed2194b1d .
12 years ago
James Cammarata
9574f89471
Detect remote_user change in accelerate daemon and allow a restart
...
Fixes #5812
12 years ago
jctanner
6c25ea1b91
Merge pull request #5527 from sergevanginderachter/basedirdwim
...
path_dwim: fix when basedir not set
12 years ago
James Cammarata
f955d9db6a
Handle implicit localhost when using '-i host,' syntax
...
Fixes #5820
12 years ago
jctanner
360f06b41d
Merge pull request #5806 from sivel/rax-mod-utils-improvements
...
Rax mod utils improvements
12 years ago
James Cammarata
5cc354696d
Build variable dictionary on included plays without using dict()
...
Using dict(k=v) means the key was always named 'k', as the variable
is not interpreted there.
Fixes #5801
12 years ago
Michael DeHaan
d07a3b5e9b
AnsibleWorks -> Ansible
12 years ago
Heikki Hokkanen
b6875b3b87
Fix .ssh/known_hosts path expansion.
...
In particular, do not rely on the $USER environment variable always existing.
tmux for example seems to clear it, causing lots of invalid messages:
"previous known host file not found"
This broke in commit 80fd22dc , but instead of reverting that commit, we now
fall back to expanding just ~ when $USER is not set.
12 years ago
Matt Martz
ac666e63e0
Support providing a tenant_name also
12 years ago
Matt Martz
aa709012ba
Make sure to also include the region when using keyring_auth
12 years ago
Matt Martz
021b926235
Only specify to USE_KEYRING as the api_key/password when we actually got a keyring_username from ~/.pyrax.cfg
12 years ago
Matt Martz
1ac7dffd55
Support using ~/.pyrax.cfg and multi environments
12 years ago
Matt Martz
139e905e98
identity_type is set dynamically above
12 years ago
Matt Martz
bc473c5be3
Support additional attributes that would allow the rax modules to work with other OpenStack clouds
12 years ago
Matt Martz
d7597414b8
Support keyring for the api_key
12 years ago
James Tanner
fe091ec00d
Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh
12 years ago
Adam Heath
aed2194b1d
self.su_user is done earlier in the code path, and is auto-vivified from
...
su_user_var. My last PR was only half merged, and when the bug fix for
the su/su_pass typo was merged, the removed line in this commit was
mistakenly reintroduced.
12 years ago
James Tanner
3ec043ec17
Fixes #5750 Fail on missing ~/.ssh and ignore accept_hostkey if stricthoskeychecking is off
12 years ago
James Cammarata
88e2595a90
Fixing bug relating to su without an su_pass
12 years ago
Adam Heath
fac7c6d3fe
Allow su_user to be templated, same as sudo_user.
12 years ago
James Cammarata
3fddd78ec5
Fixing traceback caused by incorrect argument passing to json.dumps
...
Fixes #5756
12 years ago
Brian Coca
59d5892fa3
added new play_hosts var
...
this variable has the 'current host list' to be executed over in the
play. Useful when using --limit to not iterate over hosts not included
in play in templates or with_items.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
jctanner
b2d594d24e
Merge pull request #5724 from angstwad/su-tasks-fix
...
Fix bug where playbook tasks do not escalate privs with 'su'
12 years ago
jctanner
19e8742005
Merge pull request #5713 from angstwad/su-fix
...
Disallow su and sudo params in same play/task
12 years ago
Craig Tracey
8c6b3baf6f
Make default ANSIBLE_REMOTE_PORT None
...
The ansible remote port should be None, not 22. Having a default value
of 22 means that '-o Port 22' will be appended to the ssh connection
all of the time. This is incorrect as when one would like to use
something like an ssh configuration file (-F) that sets the port to
something other than 22.
Part of this change requires that we check that, in get_config, the
value is not None before trying to cast it into an integer or float.
12 years ago
Paul Durivage
e875089eba
Fix bug where self.su was being set by the sudo param in play tasks
12 years ago
Paul Durivage
01d1bd61e7
Disallow su and sudo params in same play/task
12 years ago
James Cammarata
ff8eb5f454
Merge pull request #5722 from jeromew/pipelining_default
...
Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean
12 years ago
jeromew
ef69d23715
Bug: chmod should be called only if the tmp dir was created in the first place
12 years ago
jeromew
3f23483022
Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean
12 years ago
Thomas Omans
9343db69b4
Fixing whitespace
12 years ago
Thomas Omans
ce0b5d16b3
Allow templates in ansible_sudo_pass inventory var
...
Template ansible_sudo_pass the same way we template ansible_ssh_pass.
12 years ago
Matt Martz
5ba6739603
Use realpath for plugin directories instead of abspath
12 years ago
James Tanner
61d283e2ad
Fix merge conflicts from #5519
12 years ago
jctanner
da136dbe7c
Merge pull request #5694 from angstwad/add-su-support-revert
...
Add su support
12 years ago
Rob Smith
761fe8cc04
Fix an issue where git-pull fails with AttributeError
...
As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull
```
Starting ansible-pull at 2014-01-20 23:09:57
Traceback (most recent call last):
File "/tmp/ansible/bin/ansible", line 157, in <module>
(runner, results) = cli.run(options, args)
File "/tmp/ansible/bin/ansible", line 82, in run
hosts = inventory_manager.list_hosts(pattern)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts
result = [ h.name for h in self.get_hosts(pattern) ]
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts
subset = self._get_hosts(self._subset)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts
that = self.__get_hosts(p)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts
hpat = self._hosts_in_unenumerated_pattern(name)
File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern
ungrouped.add_host(new_host)
AttributeError: 'NoneType' object has no attribute 'add_host'
```
The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.
12 years ago
Rob Smith
953dc6b345
When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code.
12 years ago
Paul Durivage
f72f5a20df
Revert "Revert "Merge pull request #5325 from angstwad/add-su-support""
...
This reverts commit c17d0e0357 .
Conflicts:
lib/ansible/runner/connection_plugins/paramiko_ssh.py
12 years ago
Paul Durivage
4c84ba74b0
Resolve su bug in paramiko libs
12 years ago
Jesse Keating
6013f0738e
Store the list of hosts to run on in runner object
...
This reduces the number of times inventory.list_hosts is called, which
can be costly. When coming from a playbook that data is already known.
12 years ago
Jesse Keating
e8ad36c8d4
Store hosts for a play as a play attribute
...
Operate on that play attribute to make things faster for larger
inventories. Instead of making a round trip through inventory.list_hosts
and working through some lengthy list comprehensions over and over
again, calculate the potenital hosts for a play once, then reduce from
it the unavailable hosts when necessary.
Also moves how the %fail is done. The host count is a play level count
of available hosts, which then is compared after each task to the
current number of available hosts for the play. This used to get a new
count every task which was also time expensive.
12 years ago
James Tanner
94f3b9bfab
Fixes #3129 Do not require localhost to be in inventory
12 years ago
James Tanner
c17d0e0357
Revert "Merge pull request #5325 from angstwad/add-su-support"
...
This reverts commit 6f4bfa2cff , reversing
changes made to c91ba3a7c7 .
12 years ago
Paul Durivage
8cf071f697
Hostvars support for su
12 years ago
Paul Durivage
dec9131735
Ensure playbook support for su params
12 years ago
Paul Durivage
d21281ff43
Resolve rebase conflicts
12 years ago
Paul Durivage
ab6ee1a282
Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins
12 years ago
Paul Durivage
4088243deb
Proposing fix for Issue #4324 ; adding support for su in connection plugins ssh, ssh_alt
...
Fixes for ssh_alt support, adding in references to in_data where appropriate
12 years ago
Michael Scherer
5c5c8fd7ce
Make synchronize module work better with local transport, fix #5668
12 years ago
Rutger Spiertz
dec6345fe6
PlayBook: better error message
...
When a PlayBook has missing arguments the error message now shows which ones are missing.
12 years ago
James Tanner
559e89036b
Fixes #5631 Return a unique list of hosts when joining groups
12 years ago
James Cammarata
02ce5af6df
Added ANSIBLE_SSH_PIPELINING option to enable/disable pipelining support
...
Pipelining will be disabled by default, since it requires users remove
the 'requiretty' option from the servers sudoers configuration.
12 years ago
James Cammarata
233aae5861
Reverting paramiko_ssh/alt changes from yesterday
12 years ago
Matt Martz
d46037d64c
Do not log the rax api_key argument in module invocation
12 years ago
James Cammarata
36e6709771
Don't use pipelining when ANSIBLE_KEEP_REMOTE_FILES is enabled
12 years ago
James Cammarata
df13b19fe1
Moving {ssh,paramiko}_alt connection types to be the defaults
...
The previous implementations will be kept for now as _old
12 years ago
James Cammarata
c27db84e41
Adding paramiko_alt - pipelining support for paramiko connections
12 years ago
jctanner
91c5c9da08
Merge pull request #5465 from deonbredenhann/false_mandatory_variable
...
Treat a False mandatory variable as defined.
12 years ago
jctanner
59d99c17b3
Merge pull request #5337 from bob-smith/bugfixFQDNParsing
...
Fix inventory parsing so that FQDN can be parsed without throwing ssh port error
12 years ago
jctanner
a6bc63512e
Merge pull request #5308 from zecrazytux/fix/hash_merge_dynamic_inventory
...
Let merge hash_bahaviour work with dynamic inventory
12 years ago
jctanner
671b0454c6
Merge pull request #4987 from jpmens/lookup-csvfile
...
New lookup plugin csvreader
12 years ago
willthames
31f5ecea60
Allow float as an argument type in AnsibleModule
12 years ago
Rob Smith
c15cffabdd
This fixes bugs added as a part of 8665b0638a
...
1. if accept_hostkey is false, no matter if the host key is known or not, it will fail.
2. We don't check for the host key in /etc/ssh/ssh_known_hosts
This fixes both of those issues.
12 years ago
James Tanner
3719f3f496
Do not fetch or add keys for http based git urls
12 years ago
James Tanner
eeee1e1c5a
Set accept_hostkey to False by default in the git module and fail
...
early if the key is unknown
12 years ago
James Tanner
8665b0638a
Add an "accept_hostkey" parameter to the git module to help automatically
...
accept hostkeys for git repos and prevent task hangs when the key is unknown
12 years ago
James Tanner
09e0d052ca
Ensure sys.stdout has an istty method
12 years ago
James Tanner
d7c8cf6ca7
Fixes #4958 Truncate printed stdout if it contains non-printable characters
12 years ago
jay
e1f5b801cf
fixed bug causing symlinks to fail in the host_vars, group_vars etc directories
12 years ago
James Tanner
78ec7c736f
Fixes #3973 Second Revision of live ansible-pull output
12 years ago
Luca Berruti
ae543eecab
Simplified p.poll handling
12 years ago
James Tanner
c408bcea31
Update sshpass hostkey error message
12 years ago
James Tanner
0b64408f5a
Fixes #5531 Give the user a better error message when sshpass does not know the remote hostkey
12 years ago
Matt Martz
f99500d65c
Expose the playbook to callback plugins
12 years ago
jeromew
69febcefde
remove useless create/delete remote tmp dir roundtrip in copy module
12 years ago
Serge van Ginderachter
836fb4143c
path_dwim: fix when basedir not set
12 years ago
jeromew
c9b01febb3
Make sure 'tmp' is in the remote tmp dirname to ensure correct cleanup
12 years ago
jctanner
21b4212ff5
Merge pull request #5517 from lichesser/fix_set_depreciation_warning
...
Fixes #5513 . set is built-in since 2.4 and deprecated since 2.6
12 years ago
jctanner
83dec044ab
Merge pull request #5504 from smoothify/synchronize-sudo
...
Synchronize Module: Improved sudo override behaviour.
12 years ago
jctanner
9a69b1b0ec
Merge pull request #5311 from willthames/ec2_refactor
...
ec2 modules: Move more responsibility to common EC2 module
12 years ago
James Tanner
d6b78e9dd6
Fixes #5238 Improve error messaging about unquoted variable references in playbooks
12 years ago
James Tanner
ab51bd23a2
Fixes #5196 return a unique list of hostnames for a single host pattern
12 years ago
smoothify
93a55e8dff
Don't override sudo if transport is set to local.
...
https://github.com/ansible/ansible/pull/5251
12 years ago
Michael DeHaan
c039e276a2
Fact gathering on a second play against the same hosts should not be implicitly off since this is an undocumented beheavior and potentially
...
rather unwanted when a play could change a fact.
gather_facts: True/False can still be explicitly used per play.
Reverts 564a212b3c
12 years ago
Michael DeHaan
87258f6d42
Resolve merge commit
12 years ago
Michael DeHaan
1c632af2c9
Merge pull request #5468 from jeromew/ansible_ssh_alt
...
fix issue #5372 on ssh_alt: accept -K option for a user with NOPASSWD
12 years ago
Michael DeHaan
a3d90e8a87
Merge pull request #5498 from j2sol/exit_setup_early
...
Return early from setup step when possible
12 years ago
Michael DeHaan
227e8e31c9
Merge branch 'use_comps' of git://github.com/j2sol/ansible into devel
12 years ago
Michael DeHaan
10350d1639
Update various copyrights. Not complete, but sufficient.
12 years ago
Jesse Keating
23720ff19d
Use list comprehensions for efficiency
...
For loops can be inefficient, particularly when doing a dot command with
them. https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops and
https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Avoiding_dots ...
This patch makes use of list comprehensions to be as efficient as
possible while still retaining order. Efficiency was lost a bit when
switching away from sets() but this gains some of it back.
12 years ago
Jesse Keating
35328ed503
Return early from setup step when possible
...
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
12 years ago
Michael DeHaan
c41a23a35a
Complete removal/refactoring of conditional deprecations.
12 years ago
Michael DeHaan
8e5b7d3095
Remove code underlying when_* and only_if, which are deprecated features slated for removal in the 1.5 release.
12 years ago
Michael DeHaan
28b9fd4e30
We have had only_if, when_foo, etc, deprecated for a while and said they would be removed in 1.5. Now they are, with friendly error messages still.
...
Users of these features should use "when:" as documented at docs.ansible.com.
Similarly, include + with_items has been removed. The solution is to loop
inside the task files, see with_nested / with_together, etc.
12 years ago
James Tanner
21fdb2bbc7
Fixes #5200 Handle template contents with unicode strings better
12 years ago
James Tanner
fc473b3246
Fixes #5146 Handle missing stdin when running under celery with rabbitmq or redis
12 years ago
Michael DeHaan
de2ffc1276
Don't need to document these guys.
12 years ago
James Tanner
cb2214d6f8
Fixes #4935 Synchronize module: set destination to an fqdn if connection is not local, and abide by ansible_remote_user
12 years ago
jctanner
99560e3902
Merge pull request #5047 from sergevanginderachter/synch_template_ansiblesshhost
...
synchronize: allow ansible_ssh_host to be templated
12 years ago
jeromew
b2cd4a62de
fix issue #5372 on ssh_alt: accept -K option even for a user with NOPASSWD
12 years ago
Deon Bredenhann
c85aac8b17
Treat a False mandatory variable as defined.
12 years ago
Deon Bredenhann
4f1f13b100
Remove trailing space
12 years ago
Levi Gross
dc6a26123b
Fixed syntax error and removed unused imports
12 years ago
Michael DeHaan
643690ffec
Remove depedency of lookup plugin on setting in ansible.cfg
12 years ago
Michael DeHaan
5b3c796641
Update constants.py
...
Lookup plugins for optional web services do not warrant advertising in ansible.cfg.
12 years ago
Stephen Fromm
833e1f6e2a
Make sure action plugin copy cleans up tmp dir
...
The copy action plugin creates its own tmp dir for each file that it
copies to the target machine. However, it does not clean up the
original tmp path it was given when run() is called. This cleans up the
tmp path before it begins looping on source files.
12 years ago
dparalen
6bf5d664dc
allow per-host sudo operation
12 years ago
James Tanner
993e0f057e
Allow for no role dependencies in role metadata
12 years ago
James Tanner
1ef9930b80
Addresses #5341 Expand home directories when searching for roles in ansible-playbook
12 years ago
James Tanner
5d022182fe
Fixes #5341 Use constants.py to set the roles directory
12 years ago
John Barker
4bf9f714d0
Fix inventory parsing so that FQDN can be parsed without throwing ssh
...
port parsing errors
Fixes problesm introduced by 948d019fef
Adds testcases to defend
12 years ago
jctanner
ea8cd62b19
Merge pull request #5259 from mvo5/bugfix/improve-error-on-invalid-vars-file
...
improve error on invalid vars file (if its a list instead of a dict)
12 years ago
jeromew
e4a3f49fa2
ssh_alt - only trigger 'fatal' when returncode == 255 (interpreted as 'could no connect')
12 years ago
willthames
12005a1cd0
Move more responsibility to common EC2 module
...
Moved `AWS_REGIONS` into `ec2` module
Created `ec2_connect` method in `ec2` module
Updated modules able to use `ec2_connect` and `AWS_REGIONS`
12 years ago
jctanner
cd3144af5d
Merge pull request #5178 from cavassin/devel
...
Prevents UnicodeEncodeError
12 years ago
James Tanner
f3a4705a9c
Revert "Merge pull request #4874 from leth/editable_install"
...
This reverts commit 15b89b45e1 , reversing
changes made to 3d836a1ab7 .
12 years ago
jctanner
15b89b45e1
Merge pull request #4874 from leth/editable_install
...
Fix setup.py to work with 'pip install -e .'
12 years ago
Sébastien Bocahu
c8d5846ab9
Let merge hash_bahaviour work with dynamic inventory
12 years ago
jctanner
3d836a1ab7
Merge pull request #5247 from jeromew/ansible_ssh_alt
...
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jeromew
5c965a75f0
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jctanner
1679d83637
Merge pull request #5131 from janeznemanic/devel
...
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
12 years ago
jctanner
301a1189dd
Merge pull request #5122 from willthames/openlog_str
...
Make first argument to syslog.openlog be a string
12 years ago
Ferenc Grecu
56642f9b04
Remove unused parameter from _get_config
12 years ago
Michael Vogt
bef5ee2c3b
improve error on invalid vars file (if its a list instead of a dict)
12 years ago
Jesse Keating
8cef210aea
Make sure ssh pipes are empty before moving on
...
Resolves issue #5082
Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.
The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.
Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
12 years ago
Michael DeHaan
929f8a5c93
Had to revert commits due to async.
12 years ago
Michael DeHaan
74e4ccb59b
Revert "ssh_alt.py / decrease # of ssh roundtrips"
...
This reverts commit 7f8863f96d .
12 years ago
jeromew
7f8863f96d
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jeromew
db182ba498
copy ssh.py to ssh_alt.py
12 years ago
Paulo Bittencourt
fc3597af5d
files/file: add support for symbolic permission modes
12 years ago
Steve Smith
5b81f88c8f
Cast the retrieved `retries` var to an int before incrementing as it may be in string form.
...
For example, the following method of calculating the value will result in a type error:
appstatus_waitfor: 4 # Minutes
appstatus_delay: 5 # seconds
appstatus_retries: "{{ mins * 60 / delay }}"
12 years ago
Wanderlei Antonio Cavassin
6ba93817a9
Avoid UnicodeDecodeError exception when passing module args
12 years ago
James Tanner
bf78d8cf73
Addresses #5090 setup module was using path.is_file instead of path.isfile
12 years ago
cavassin
10f5af82f9
Prevent UnicodeEncodeError
...
Prevents UnicodeEncodeError: 'ascii' codec can't encode character, while printing shell commands output
12 years ago
jctanner
7aa35d64c2
Merge pull request #5091 from EspadaV8/5089_assemble_fix
...
#5089 hack-fix assemble module
12 years ago
Paul Bonser
58acd8cce1
If there is no tmp_src, don't modify the args
12 years ago
Paul Bonser
4afcd50487
properly convert arg into boolean
12 years ago
Michael DeHaan
801ca96a8b
Merge pull request #5152 from sivel/too-many-ps
...
The word skipped only has 2 p's not 3
12 years ago
Matt Martz
5f0f3566a6
Skipped only has 2 p's not 3
12 years ago
Matt Martz
8873c3675b
Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148
12 years ago
jctanner
2670529671
Merge pull request #5090 from dragon3/hostname_support_amazon_linux
...
hostname module: add support for Amazon Linux
12 years ago
James Tanner
d227614529
Fixes #5109 synchronize module ssh port
...
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
12 years ago
Paul Bonser
5626efba7e
Optionally unarchive a file already on the remote machine
12 years ago
jctanner
93159cb9cd
Merge pull request #4996 from sivel/rax-module-utils
...
Implement ansible.module_utils.rax
12 years ago
Janez Nemanic
8752ae6909
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
12 years ago
Will Thames
76aca4d547
Make first argument to syslog.openlog be a string
...
syslog.openlog expects its first argument to be a string.
Without this change running under ipython fails.
12 years ago
James Cammarata
9101c2af98
Fix traceback in template error detection code
...
Fixes #5081
12 years ago
Andrew Smith
eed32ea70c
dest_contents isn’t always defined, so don’t pass it around
...
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
12 years ago
Andrew Smith
e2d03173d2
The file module doesn’t have it’s module_args reset
...
I believe that this should be reset in the same way that the copy module
does
12 years ago
Andrew Smith
7b01c83159
Passing in complex_args throws ‘unsupported parameter for module’ errors
...
When using assemble only params (e.g. remote_src) the copy (and I’m
guessing file) modules throw an error that the param isn’t supported.
Simply removing the complex_args param fixes it for me, but I’m not sure
that’s the correct thing to do
12 years ago
Andrew Smith
da44a7f0cb
I think that resultant is meant to be the contents of the combined file
...
It is used for the transfer and as a diff param but isn’t actually
defined anywhere before it’s used. This seemed like the least bad place
to set it.
12 years ago
Andrew Smith
4503413baa
ReturnData is used throughout but not actually imported
12 years ago
dragon3
d39e6fda92
hostname module: add support for Amazon Linux
12 years ago
Andrew Smith
7d007cac16
Correct the invocation of ‘_assemble_from_fragments’
12 years ago
jctanner
920bc6e75b
Merge pull request #5086 from j2sol/fix-accelerate_inventory
...
Avoid a traceback when using accelerate
12 years ago
James Tanner
b6879ca2bd
Fixes #5030 compare connection user and sudo user and disable sudo if identical
12 years ago
Jesse Keating
5522d489e3
Avoid a traceback when using accelerate
...
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
12 years ago
James Tanner
12ed39ef7b
Fixes #5056 Append new hosts to the groups cache
12 years ago
James Cammarata
1f80aa768a
Fix bug in error detection code, where a zero-length string was causing a traceback
...
Fixes #5064
12 years ago
Brian Coca
65885feeeb
fixed typo for assemble function
12 years ago
James Tanner
b8146e3bc7
Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin
12 years ago
James Tanner
903c4cae7b
Fixes #5031 Template the delay value and cast to float for loops
12 years ago
Serge van Ginderachter
2f9470ec1d
synchronize: allow ansible_ssh_host to be templated
...
This is already enabled in the runner also.
12 years ago
Antonio Zanardo
8dbd91b5ad
fix typo in deprecation warning
12 years ago
James Tanner
bca2634d54
Fix missing eval for string search in ssh controlpersist
12 years ago
James Tanner
a16fe923ed
Addresses #5011 check for proper string in smartos ssh error output
12 years ago
jctanner
5c84d7e445
Merge pull request #5002 from ovcharenko/devel
...
Allow to specify ansible_ssh_private_key_file location related to user home directory
12 years ago
James Tanner
512ebdb971
Revert "Merge pull request #5001 from ovcharenko/devel"
...
This reverts commit d6c3103a00 , reversing
changes made to b11f96eaa4 .
12 years ago
Aleksey Ovcharenko
9af44b1b42
Update to 4 space indent
12 years ago
Aleksey Ovcharenko
30678e04ac
Make tests happy
12 years ago
Aleksey Ovcharenko
2222f6df58
Allow to specify ansible_ssh_private_key_file location related to user home directory
12 years ago
Matt Martz
3f2cbb7583
Add ansible.module_utils.rax
12 years ago
James Tanner
9b991b9154
Version bump for 1.5
12 years ago
Jan-Piet Mens
252a51be91
New lookup plugin csvreader
12 years ago
James Tanner
b815a09529
Fix pep8 error in password lookup
12 years ago
James Tanner
e81c976636
Fix pep8 errors in unarchive module
12 years ago
jctanner
68afd9da9f
Merge pull request #4866 from sergevanginderachter/known_hosts_sudo
...
Check real user's known_hosts when sudo ansible...
12 years ago
Brian Coca
34c33f7ea1
now correctly spell symmetric
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca
460bbfaec1
added union filter
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca
afe30a6633
added difference and symetric difference filters
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan
fc909b453f
Make the legacy template detection system not hit a false positive when
...
replacing a \$ with $.
12 years ago
jctanner
93223510af
Merge pull request #4936 from stoned/group-get_hosts-perf2
...
Improve Group.get_hosts() performance.
12 years ago
Matt Haggard
389602b8dd
Merge pull request #4920 from iffy/ansible
...
Collect all stdout over ssh transport before returning data
12 years ago
Michael DeHaan
f18acee779
Merge pull request #4937 from skyl/synchronize-keyerror
...
KeyError: 'delegate_to' lookup in sync module needs to be checked to see if defined for ad hoc
12 years ago
James Tanner
e8b54dd073
Fixes #4852 properly evaluate log_path writability
12 years ago
Skylar Saveland
7bc64581d7
KeyError: 'delegate_to' no more
12 years ago
Stoned Elipot
b00bf02129
Improve Group.get_hosts() performance.
...
- reduce hosts group list to unique elements faster
- add a cache of already computed hosts group list
12 years ago
jctanner
009fdbf96a
Merge pull request #4896 from mjschultz/aws-access-keys
...
Check for AWS keys using boto names
12 years ago
jctanner
04847191b4
Merge pull request #4879 from bcoca/unique_intersect
...
added unique and intersect filters for dealing with lists
12 years ago
jctanner
0f0a89b34e
Merge pull request #4758 from alanfairless/group-host-var-dirs
...
Support organizing group and host variables across multiple files in a directory
12 years ago
jctanner
77affdefbc
Merge pull request #4585 from mscherer/connec_func
...
connection plugin to reuse the func/certmaster interface instead of ssh
12 years ago
jctanner
be67a6f815
Merge pull request #4625 from pileofrogs/devel
...
unarchive module & action plugin
12 years ago
jctanner
e4494be8c6
Merge pull request #4803 from dragon3/devel
...
Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM rol...
12 years ago
Michael J. Schultz
5f9485499c
Check for AWS keys using boto names
...
- see https://github.com/boto/boto#getting-started-with-boto
12 years ago
James Tanner
33242cacf3
Merge pull request #4375 from pfalcon/ansible
...
copy: Implement recursive copying if src is a directory.
12 years ago
jctanner
9a7765daf7
Merge pull request #4351 from 2m/leading-range-fix
...
Allow leading ranges in the inventory host entries.
12 years ago
jctanner
6dd81f25d9
Merge pull request #4856 from akuznecov/devel
...
Resolves #4855 issue with synchronize module failing on multiple items
12 years ago
James Tanner
f31cb7c6e8
Merge pull request #4664 from jpmens/ansible
...
Lookup plugin for etcd
with support for configurable etcd URL in ansible.cfg (and environment)
12 years ago
James Tanner
dc41bb8085
Merge pull request #4207 from ashorin/ansible
...
Fail playbook when serial is set and hadlers fail on set.
12 years ago
jctanner
2cf335969f
Merge pull request #4738 from bcoca/assemble_action_plugin
...
assemble can now use src from master/origin
12 years ago
Brian Coca
efd87534eb
added unique and intersect filters for dealing with lists
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
James Tanner
6e49ee6cfc
Remove commented code block
12 years ago
James Tanner
288c33e286
Merge pull request #4078 from mkaluza/ansible
...
add 'chars' parameter to password plugin to allow custom character set
12 years ago
jctanner
0c29807ba3
Merge pull request #3993 from stoned/inventory-script-all-group-fix
...
Avoid duplicates of the 'all' group when using inventory script.
12 years ago
Marcus Cobden
8d98a55df1
Fix setup.py to work with 'pip install -e .'
12 years ago
Serge van Ginderachter
80fd22dce6
Check real user's known_hosts when sudo ansible...
...
closes #4834
12 years ago
James Tanner
74e7eba528
Fixes #4506 test length of context before checking invalid indexes
12 years ago
Alexander Kuznecov
9d2f9bf93c
resolves #4855
12 years ago
jctanner
8e8c8efc8f
Merge pull request #4769 from alanfairless/more-password-entropy-revised
...
Revised patch for more password entropy
12 years ago
jctanner
f51b8ffde9
Merge pull request #4836 from dekked/devel
...
Bug fix: support running handlers parametrized by name
12 years ago
James Tanner
898de833b0
Merge pull request #4413 from jerm/ansible
...
Add capability to pass in a PATH prefix to run_command and allow pip module
to utilize that to make virtualenv bin/ available in pip installs
12 years ago
Alan Descoins
bb6f02d0e8
Support running handler parametrized by name.
12 years ago
jctanner
8d9b53b445
Merge pull request #4733 from sivel/4323-sudo-pass
...
Add ansible_sudo_pass hostvar support. Fixes #4323
12 years ago
James Tanner
d93780bc8a
Addresses #4635 add list instead of join
12 years ago
James Tanner
2b5005687a
Fixes #4635 pass role conditionals to dependent roles
12 years ago
James Tanner
91aa7b51df
Remove invalid ipv6 parameter from setup execution
12 years ago
James Tanner
c1ed47933b
Fixes #4485 add an ipv6 parameter to accelerate so that the daemon will bind to an ipv6 port instead of ipv4
12 years ago
dragon3
ff5bd7fe06
Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM role.
12 years ago
willthames
76c810afe3
AWS_ACCESS_KEY misspelt in shared EC2 connection library
12 years ago
Michael DeHaan
eab6737209
Clarify a warning message.
12 years ago
Michael DeHaan
70c9028e1e
include_vars plugin should look in vars/ path for a role.
12 years ago
Michael DeHaan
99687749a3
Merge pull request #4775 from steverweber/fix-4640
...
dont sudo if sudo_user is the same as the connection user
12 years ago
Steve Weber
5bd52796ec
dont sudo if sudo_user is the same as the active user
12 years ago
James Tanner
afa5988391
Fixes #4540 Use shared module snippet to evaluate ec2 credentials
12 years ago
Alan Fairless
0824f004d9
Revised patch for more password entropy
12 years ago
James Tanner
dc4d589ce0
Fixes #4767 detect hard links and set state in add_file_info
12 years ago
Michael DeHaan
b1b5280075
Reapply pep8 changes from previous revert.
12 years ago
Michael DeHaan
51fbc6d20a
Further simplify the debug: var=foo action plugin code.
12 years ago
Michael DeHaan
bbf212a268
Simplify the way the debug: var=varname plugin works.
12 years ago
Michael DeHaan
7f125567cb
Some simplification of include_vars and renamed include_files to include_vars.
12 years ago
Michael DeHaan
b69ab89eb1
Merge branch 'include_files' of git://github.com/bennojoy/ansible into devel
12 years ago
Michael DeHaan
465f3b1c91
This allows type=dict in a module to allow passing in a real dict or JSON.
12 years ago
Michael DeHaan
8b2cd6413b
When inside an apt or yum task account for multiple conditionals. Fixes 4745.
12 years ago
Michael DeHaan
d34a26e307
Undo an inadvertant revert from template changes so we still allow pythonic imports in module land.
12 years ago
Alan Fairless
65e5331079
Allow organizing host/group vars in a directory
...
So instead of having:
group_vars/production.yml
A user could chose to reorganize to:
group_vars/production/staff.yml
group_vars/production/networks.yml
group_vars/production/dns.yml
(Backwards compatible.)
12 years ago
Alan Fairless
babde9a84c
refactor to catch edge cases, remove repeated code
...
- Move all the supported YAML file extensions into a constant
- Use helper functions to avoid duplicate code for group/host vars
- Catch and disallow some confusing situations, such as the presence of
multiple group/host vars files for the same group/host, but with
different extensions. For example having both group_vars/all.yml and
group_vars/all.yaml.
- Catch and report file system permission issues, symlink errors,
unexpected file system objects
- Trivial performance improvement from making fewer stat system calls
- Restructuring that makes it easy for a following patch to support
directory recursion
12 years ago
Brian Coca
ac40d15120
now assemble module is also action plugin and can use local source for
...
files
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan
7b331ef6ed
Fix code typo. I'll blame jet lag for now :)
12 years ago
Michael DeHaan
90cce35919
This allows variable references in playbooks in a different way.
12 years ago
Michael DeHaan
b5c9d5a59b
Inventory directory should always be absolute. Fixes #4535 .
12 years ago
Michael DeHaan
7201a6ffad
Evaluate the conditional for each item for modules that normally try to group with_items results
...
like yum and apt.
12 years ago
James Tanner
078aaa95a2
Revert 1f6edf7d76 and re-enable passing lists to yum and apt
12 years ago
Matt Martz
ea2ec6237a
Add ansible_sudo_pass hostvar support
12 years ago
James Tanner
d154bf8781
Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754
12 years ago
James Tanner
0faecdf7d1
Fixes #4653 Set dest on results for copy module even if using file module
12 years ago
James Tanner
9249cf578d
Fixes #4572 Run until loop if until is set, ignoring result failures
12 years ago
Michael DeHaan
73dbab702f
Don't run lookup plugins while trying to simplify the input datastructure.
12 years ago
Michael DeHaan
6d0da41a55
No need to template modules with Jinja2 as this can confuse some docstring comments.
12 years ago
bennojoy
b53e7353f9
include files
12 years ago
Michael DeHaan
603db60828
Merge pull request #4288 from sivel/3725-regex
...
Add regex (search, match, regex) jinja2 filters. Fixes #3725
12 years ago
Michael DeHaan
4587528b99
Fix typo in comment.
12 years ago
Michael DeHaan
d409352c85
Remove some interior imports in the code. Not really needed but nice to have them gone.
12 years ago
Michael DeHaan
e6c28658b4
Add in some code to pre-template datastructures prior to template usage. This prevents a certain class of error
...
where filter evaluations can happen too early due to the template engine recursion being a bit limited.
Addresses #4662
12 years ago
Michael DeHaan
f05a3a81f9
Add missing file.
12 years ago
Michael DeHaan
54c902f102
Identation + misc PEP8 fixes.
12 years ago
Michael DeHaan
bbb359870e
Add package file.
12 years ago
Michael DeHaan
9858b1f2f3
Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
...
to be reused between modules. See library/system/service and library/system/ping for initial examples. Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
12 years ago
jctanner
43f48a2e02
Merge pull request #4167 from tima/rsync3
...
synchronization module take 3
12 years ago
James Tanner
40886c42b5
Fixes #4561 Compare task name without role prefix for start-at-task
12 years ago
James Tanner
1f6edf7d76
Fixes #4665 and #4666 If task is conditional do not flatten items list for packaging modules
12 years ago
James Tanner
9b1fe455c6
Fixes #4549 Do not call lookup plugins when templating a task's name
12 years ago
Serge van Ginderachter
6277e770a1
include basedir as 'playbook_dir' variable
...
closes #4246
12 years ago
Jan-Piet Mens
bd5cd8e652
Lookup plugin for etcd
...
with support for configurable etcd URL in ansible.cfg (and environment)
12 years ago
James Tanner
b803aac6ec
Fixes #4500 change ec2 module params to type=bool
...
Revert 4833c2fdf0
12 years ago
James Cammarata
b9dd514713
Minor fix for putting 0-length files over accelerated connections
...
Fixes #4652
12 years ago
James Tanner
4833c2fdf0
Fixes #4500 python bools return uppercase True and False, so allow those for BOOLEANS in module common
12 years ago
James Tanner
214b0b052c
Fixes #4608 add lookup to template globals to make plugins work again
12 years ago
Dylan Martin
2c28e1daea
unarchive module & action_plugin added
12 years ago
James Tanner
4f13967386
Fixes #4536 Get the remote_user from multiple sources in a preferred order
12 years ago
Timothy Appnel
cbae9c913e
synchronize module src and dest handles template markers.
12 years ago
Michael DeHaan
60944b81f0
Provide warning about "with_items: '{{ loop }}'" being redundant only when {{ starts the expression value. Fixes #4582 .
12 years ago
Michael DeHaan
2bd8cb5790
Make the deprecation detector in templates more accurate. Fixes #4514 .
12 years ago
Michael DeHaan
4125b05bf3
Allow a defaults file to solely define a role. Some typo fixes.
12 years ago
Michael DeHaan
64bbeb9d24
Suggest fixing unbalanced quotes in a bit less cases. Fixes #4501
12 years ago
Michael DeHaan
7f9504d14d
Fix a typo.
12 years ago
Michael DeHaan
8d3db80370
Some misc cleanup and removal of unused imports.
12 years ago
Michael DeHaan
21d4400c96
Misc pep8 fixes
12 years ago
Michael DeHaan
c933a4c59a
Fix indentation depth.
12 years ago
Michael DeHaan
5031104c3a
Finishing touches on template cleanup.
12 years ago
Michael DeHaan
1e85c7544b
Further WIP on template cleanup.
12 years ago
Michael DeHaan
35cb9dc22f
Work in progress about cleaning up template code.
12 years ago
Michael Scherer
af796d6556
connection plugin to reuse the func/certmaster interface instead of ssh
...
This plugin permit to use func to run playbook and ansible command instead
of ssh. It can be used for a smooth transition from func/taboot to ansible by
letting people use ansible without having to change their network architecture.
12 years ago
Brian Coca
c476ed93ca
now correctly changes script permission in all cases
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
James Tanner
8478e82647
Fixes #4583 enforce that vars_files is a list
12 years ago
Michael DeHaan
b0f6e77f66
Merge pull request #4571 from tgerla/whitespace
...
add_group module: strip trailing/leading whitespace from comma-separated group names
12 years ago
Tim Gerla
51a1709253
add_group module: strip trailing/leading whitespace from comma-separated group names
12 years ago
James Tanner
242f20c297
Fixes #4402 wrong order for isinstance parameters in dnstxt.py
12 years ago
Martynas Mickevicius
7ecb5fbc9c
Handle comment on inventory group line.
12 years ago
Martynas Mickevicius
44279ce34f
Allow leading ranges in the inventory host entries.
12 years ago
jctanner
6480945184
Merge pull request #4541 from Kami/improve_template_render_error_messages
...
Make errors which get thrown during template rendering more user-friendly
12 years ago
Stoned Elipot
4430d0f5a6
when searching for a plugin only look for a regular file
12 years ago
Tomaz Muraus
922f61899e
Throw a more user-friendly exception during template rendering process.
12 years ago
Gabe Mulley
84a57b7545
ensure non-root users can read arguments file when using sudo_user
...
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600. This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.
This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
12 years ago
Brian Coca
bd9acedb57
fixed name colision between warnings dict and module
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Paul Sokolovsky
2e668f14f7
copy: Handle "no copy/propagate attrs only" for recursive mode well.
...
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
12 years ago
Paul Sokolovsky
ce88df3cf4
copy: Handle dest path variations for recursive mode.
12 years ago
Paul Sokolovsky
6cf3975e2e
copy: Set suitable default result for check mode.
12 years ago
Paul Sokolovsky
612b446856
copy: Don't modify input module_args in a recursive file handling loop.
12 years ago
Paul Sokolovsky
b3b4f9885f
copy: Implement recursive copying if src is a directory.
...
If src param to copy is a directory, all files under it are collected
and pushed one by one to target. Source dir path handled in a way
simalar to rsync: if it ends with slash, only inside contents of
directory are copied to destination, otherwise the dir itself is
copied (with all contents of course). Original idea and implementation
by https://github.com/ansible/ansible/pull/1809 . Rewritten to address
review comments and simplify/correct logic.
12 years ago
jctanner
69fa5954fd
Merge pull request #3932 from jocelynj/devel
...
Add option remote_user to task level, to specify the ssh login user
12 years ago
Michael DeHaan
e131de4de0
Added "debug: var=variableName" capability.
12 years ago
egghead
ca7e2d283c
Adding os realpath filter.
...
This is particularly useful when wanting to get the absolute path of filepaths found by the 'fileglob' filter.
This also lets you provide absolute paths to roles, which search for files in different areas unless absolutely pathed.
12 years ago
Michael DeHaan
c90a82fd52
Handle possible scenario where conditional might be an integer (whoa!) down the error path. Super rare but fixes #4483 .
12 years ago
Michael DeHaan
9ea54fcaaf
Fixes a dev branch glitch where a conditional could be applied to multiple tasks. Also improves the errors on parsing bad conditionals to make them less confusing to users.
12 years ago
Thomas Omans
632232259a
Adding config flag role_path for common/global roles
...
Using ANSIBLE_ROLE_PATH environment variable or role_path in ansible.cfg
can configure paths where roles will be searched for
extra paths will only be used as a backup once regular locations are exhausted
12 years ago
Michael DeHaan
43df00550d
Merge pull request #3827 from mscherer/disable_callbacks
...
add a way for callback to disable itself
12 years ago
Michael DeHaan
1b2d4c328c
Cache patterns a bit higher up to make things a little more efficient. See #4469 .
12 years ago
Michael DeHaan
d168c709d5
Fix an issue where the ordering of an include statement is processed ahead of the conditional in the included statement,
...
which required a redundant check to see if a variable was defined rather than short circuiting.
Fixes #4469
12 years ago
Michael DeHaan
add45d2ca9
Fixup legacy var detector.
12 years ago
Michael DeHaan
709ffda3d1
Tweak only_if deprecation detector.
12 years ago
Michael DeHaan
a45494a896
Add warnings feature.
12 years ago
Michael DeHaan
9637f620d7
Deprecation warnings of several flavors, nice and purple and can be disabled
...
in ansible.cfg.
12 years ago
Michael DeHaan
a017a69bb3
Have the parser explain another type of YAML gotcha to reduce the need for users to ask how to resolve it.
12 years ago
Michael DeHaan
861f076df5
Tweak the syntax-detector-warning-suggester-message (SDWSM) a little.
12 years ago
Michael DeHaan
41aaad69aa
Make add_host clear the inventory pattern cache, add some more aliases. Fixes #4442 .
12 years ago
jctanner
65ef6a62dc
Merge pull request #4425 from jeromew/ansible_sudo_user_with_items
...
Template sudo_user via with_items
12 years ago
James Cammarata
d73a5da9e5
Merge pull request #4453 from pschwartz/fix_cfg_load_order_to_match_docs
...
GH-4452 Corrected config load order to match docs
12 years ago
Philip Schwartz
65c8c691f7
GH-4452 Corrected config load order to match docs with
...
cwd > ~ > /etc
Signed-off-by: Philip Schwartz <philip.schwartz@rackspace.com>
12 years ago
Matt Martz
61525a97df
Add regex (search, match, regex) jinja2 filters. Fixes #3725
12 years ago
Serge van Ginderachter
c4d20094b4
make changed filter understand results lists
12 years ago
Serge van Ginderachter
e5d45311f9
Implement a |changed filter plugin
12 years ago
Serge van Ginderachter
c2e5f783da
Add caching to pattern enumeration
...
Inventory._hosts_in_unenumerated_pattern()
Was TODO: cache this logic so if called a second time the result is not
recalculated
12 years ago
jeromew
dec364ae80
Template sudo_user via with_items
12 years ago
Michael DeHaan
3f968ff46a
Check one more skipped scenario in with_subelements.
12 years ago
James Cammarata
9124ebb4f1
Clear out complex_args before running async_status
...
When using complex args with an async task, the subsequent runs of
async_status would inherit them, causing a module error (invalid params).
Fixes #3150
12 years ago
Michael DeHaan
2078518735
Allow subelements to work right with skipped results.
12 years ago
Jeremy Price
9da5043f18
Adding path_prefix to run_command so that one can pass in a path to the run environment if you nees something in a non-default path.
12 years ago
James Cammarata
948d019fef
Detect IPv6 addresses in INI inventory
...
Prevents parts of the IPv6 address from being interpreted as a port
(for example, :80).
Fixes #3888
12 years ago
Michael DeHaan
6febc97104
Add a warning about include + with_items so nobody uses it.
12 years ago
James Cammarata
98f6bc1f63
Apply tags to dependent roles correctly
...
Fixes #4339
12 years ago
Michael DeHaan
c69e19c6a6
Enhance references to logging functionality. Fixes #3431 .
12 years ago
Michael DeHaan
f081c68a65
Prevent duplicately loaded handlers from running more than once.
...
Fixes #3863
12 years ago
Michael DeHaan
5ed28efe45
Script module should return changed attribute so handlers always fire, unless "changed_when" is specified.
...
Fixes #4053
12 years ago
Michael DeHaan
a7adc8ef4d
Allow doing things like "groups.groupname" in with_nested.
...
Fixes #3858
12 years ago
Michael DeHaan
5e30cd999c
Make it possible to say:
...
tags: 42
And have the tag be a string, not an int, so --tags matches.
Fixes #4110
12 years ago
Michael DeHaan
8fc46a3a5a
Return inventory objects in the order they are presented. Additionally, fix host slicing such that it works on Python terms with
...
zero indexed lists and a non-inclusive final element.
12 years ago
Michael DeHaan
19386c43a7
Merge
12 years ago
James Cammarata
d10582225b
Merge branch 'issue_4215_fetch_expanduser' into devel
12 years ago
Andrey Shorin
35457b67f5
Pass host to runner_on_file_diff callback
12 years ago
Stoned Elipot
e7957b6d58
Fix group_by: do not group a host for which a condition is false
12 years ago
Michael DeHaan
44e391fd8b
Merge pull request #4255 from mcodd/legacy_vars_fix
...
Fix for legacy_playbook_variables (should fix issue #4254 )
12 years ago
Michael DeHaan
65178290e7
Merge branch 'devel' of git://github.com/nextus/ansible into devel
...
Conflicts:
lib/ansible/constants.py
12 years ago
Michael DeHaan
ea73151757
Add automatic advice when folks hit one of two common but minor YAML gotchas, so they can be more easily correct them on their own.
12 years ago
Michael DeHaan
4987c73bb6
Proper check for raw as module options versus raw being in the string.
12 years ago
James Tanner
52aea868df
Allow for updating host vars in add_host
12 years ago
James Cammarata
d21714a37f
Fix for network byte order issues in accelerate
12 years ago
James Cammarata
912e3a7b0b
Merge branch 'accelerate_improvements' into devel
...
Conflicts:
library/utilities/accelerate
12 years ago
James Cammarata
fa80a17aa3
Make recv_data less greedy so it doesn't eat other packets
12 years ago
James Cammarata
8923a5b0d9
Drop default config value for accelerate timeout to 30 seconds
12 years ago
James Cammarata
12f6957596
Cleaning up some vvvv log messages in accelerate
12 years ago
James Cammarata
8c17711247
Removing accelerate_timeout as a playbook option
...
This will remain in ansible.cfg only.
12 years ago
James Cammarata
d317103371
Added in an accelerate connection timeout setting
12 years ago
James Cammarata
59a5ce23d9
Adding an accelerate_timeout parameter for plays
...
This setting makes the timeout for each play configurable, rather than
hard-coding it at 300 seconds (now the default if left unspecified)
Fixes #4162
12 years ago
James Cammarata
f9c87868ac
Added keepalive packets to accelerate mode
...
Commands will now be started up in a separate task from the main
handler thread, so that it can be monitored for completeness while
sending a keepalive packet back to the controller to avoid a socket
receive timeout.
12 years ago
James Cammarata
8a3f8b757b
Make sure yaml data loaded for role is valid before using it
...
Fixes #4322
12 years ago
James Cammarata
bff47df5ff
Fix issue with ast evaluation of strings
12 years ago
James Cammarata
5b205ae8bd
Merge branch 'fixes/subprocess' of https://github.com/ferringb/ansible into ferringb-fixes/subprocess
12 years ago
James Cammarata
d89ce6ac61
Merge branch 'patch-1' of https://github.com/ustun/ansible into ustun-patch-1
12 years ago
James Cammarata
12a21d94b7
Merge branch 'allow_types_in_ini' of https://github.com/bcoca/ansible into bcoca-allow_types_in_ini
12 years ago
jctanner
32a1dd422c
Merge pull request #4269 from jphalip/issue-4256
...
In the script action: Get around a Python bug.
12 years ago
James Cammarata
7aad576f5f
Minor change to add a space around role name/task delimiter
12 years ago
James Cammarata
1cc1e7058b
Merge branch 'role_report_fix1' of https://github.com/bennojoy/ansible into bennojoy-role_report_fix1
12 years ago
James Cammarata
8ed343cc36
Merge branch 'jsmartin-hide_skipped_hosts' into devel
12 years ago
James Cammarata
6cd8aacc81
Merge branch 'hide_skipped_hosts' of https://github.com/jsmartin/ansible into jsmartin-hide_skipped_hosts
12 years ago
James Cammarata
52a42bf607
Add more verbose debugging options for accelerate
12 years ago
Michael DeHaan
ac0a7d965a
Merge pull request #4306 from sivel/3563-glob
...
Add fileglob Jinja2 filter. Fixes #3563
12 years ago
Matt Martz
535ce97067
Add fileglob Jinja2 filter. Fixes #3563
12 years ago
Brian Harring
d0ad6c581b
For defaults that are integers, enforce it for config supplied values.
...
If a user supplies a string in the config (rather than an int), the code
should fix that- or blow up immediately- rather than allowing that value to
work it's way down and break w/in the connection object; when that happens,
the actual error is opaque and requires pdb.set_trace() to run down.
12 years ago
Brian Harring
2174230315
USE subprocess.Popen API correctly.
...
When collecting stdout/stderr *and* feeding data into a Popen instance,
communicate() must be used to avoid a known deadlocking scenario
when data sizes cross PIPE_BUF (which can be as small as 512, although should
be much larger in practice on linux).
12 years ago
Ustun Ozgur
977b31249a
Update cache check in find_plugin
...
I am not familiar with the internals, but this line looked suspicious.
12 years ago
Julien Phalip
44aeea7afc
In the script action: Get around a bug in that's been fixed in Python 2.7 but not Python 2.6.
...
See: http://bugs.python.org/issue6988
Fixes #4256 .
12 years ago
James Cammarata
039d4c95d9
Merge pull request #4221 from ashorin/unicode-md5
...
Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in pos...
12 years ago
Brian Coca
771435deb4
now ini vars are typed
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
James Martin
d5f20e6b21
Optionally display Skipping [host] messages.
12 years ago
bennojoy
482cb72128
role report fix
12 years ago
Matt Coddington
7f7116de3b
commit 9db4f7a made a change that also needed to include this to retain correct legacy_playbook_variables behavior
12 years ago
Preston Marshall
3ee7b177e8
Allow storing input from user in a pause prompt
12 years ago
James Cammarata
1c97831288
Merge branch 'empty_inventory' of https://github.com/spil-jasper/ansible into spil-jasper-empty_inventory
12 years ago
James Cammarata
994dfb84fc
Minor pep8 cleanup and CHANGELOG update for do-until
12 years ago
James Cammarata
202c4f5294
Merge branch 'do_until_14' of https://github.com/bennojoy/ansible into bennojoy-do_until_14
12 years ago
James Cammarata
478c400817
Minor pep8 cleanup in the new jail connection plugin
12 years ago
James Cammarata
0e0595bdb2
Merge branch 'jail' of https://github.com/mscherer/ansible into mscherer-jail
12 years ago
bennojoy
70a9a797fa
Fix for accelerate when ansible_ssh_user is specified
12 years ago
Jasper Capel
d4dec5f577
Allow creating empty inventory
...
Instantiating the Inventory class with host_list=None now results in an
empty inventory instead of an error.
12 years ago
nextus
ca96d74572
#4227 in upstream repo
12 years ago