Commit Graph

2922 Commits (e8b45a9ef715d04713e49c5dc54d2a2ec87b3514)

Author SHA1 Message Date
Jacob Weber 35742fe008 Add regex_replace jinja2 filter 12 years ago
Richard C Isaacson e6c9705058 Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136 12 years ago
James Cammarata a023cbce14 When using jsonify in modules, try several unicode encoding for dumps()
Fixes #4821
12 years ago
James Tanner 9ce46e5f41 Refactor the synchronize action plugin and add unit tests 12 years ago
James Cammarata 3f90020d62 Open LOG_LOCK file with FD_CLOEXEC to prevent file descriptor leakage
Fixes #5399
12 years ago
James Cammarata bbda98a3ee Merge branch 'issue_4812' into devel 12 years ago
James Cammarata bb79b16d59 Specify mode in the makedirs call for fireball/accelerate keys 12 years ago
James Cammarata 65cb79a5c1 Merge branch 'devel' of https://github.com/xyrix/ansible into xyrix-devel 12 years ago
Scott Anderson baf508a379 Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key. 12 years ago
Richard C Isaacson 786e3d2fd2 Refining the fix made in #5885.
It turns out that some of the assumptions in #5885 were slightly off. The previous fix relied on a call to the module to creat a tmp_path. This is insufficent as there are few cases that we need to have the tmp directory before we make the module call. If we don't have a tmp_path before we do a recursive call or when we find a file that does not match the remote md5 hash we need to create a tmp directory. Also we are not more percise when we will need to clean up the remote tmp_path.
12 years ago
Michael DeHaan 1609dfbca4 Revert "Revert "Revert "Add the fork manager code (related to previous patch)."""
This reverts commit 60d3611b70.
12 years ago
Michael DeHaan 633d685bb7 Revert "Revert "Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks"""
This reverts commit 73ca1a173c.
12 years ago
Michael DeHaan ad8c275887 Revert "While the previous work on the foon class can't be quite recycled, it's still a nice abstraction."
This reverts commit caab52aee2.
12 years ago
Michael DeHaan caab52aee2 While the previous work on the foon class can't be quite recycled, it's still a nice abstraction. 12 years ago
Michael DeHaan 73ca1a173c Revert "Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks""
This reverts commit 6685b4989e.
12 years ago
Michael DeHaan 60d3611b70 Revert "Revert "Add the fork manager code (related to previous patch).""
This reverts commit c53538dc77.
12 years ago
Michael DeHaan 6685b4989e Revert "This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks"
This reverts commit 85d66b9a0c.
12 years ago
Michael DeHaan c53538dc77 Revert "Add the fork manager code (related to previous patch)."
This reverts commit adb1719fe8.
12 years ago
Michael DeHaan adb1719fe8 Add the fork manager code (related to previous patch). 12 years ago
Michael DeHaan 85d66b9a0c This patch makes Ansible reuse fork allocation between seperate instantations of the runner API, therefore the overhead of recreating forks
between tasks in a playbook is avoided.  The fork pool will be regenerated when a second play comes along and needs more hosts.
12 years ago
Richard Isaacson 2d88246c9d Merge pull request #5885 from risaacson/issue5739_4
Addresses #5739 and cleans up copy.py
12 years ago
James Tanner b3ab7e7885 Check mutually_exclusive parameters before applying defaults 12 years ago
Will Thames d5c309e20d Pick up default EC2 region from boto.config
This doesn't account for boto configs where e.g. RDS has one
default region and EC2 another - all will default to `ec2_region_name`.

However, this is just handy to allow an easy site wide default
region if existing configuration already relies on it.

Modules can be improved to mention this in the documentation and
turn off required=True where needed. But it works with `ec2`
and `ec2_vol` without change.
12 years ago
jctanner 0bc0315171 Merge pull request #5880 from willthames/ec2_modules_refactor
Create a common EC2 connection argument spec for EC2 modules
12 years ago
xyrix 20d97416e5 fixed thinkoes 12 years ago
xyrix 0af40374ed fixed file perms checking 12 years ago
xyrix 1de45bf687 made accelerate keys directory configurable, and permissions for the file and dir configurable, and gave them a safe default 12 years ago
James Cammarata a72dc2ec34 Use finalize method in jinja2 to convert None values to empty strings
Fixes #4812
12 years ago
Will Thames 7600c664fe Create a common EC2 connection argument spec for EC2 modules
Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
12 years ago
jctanner 28933de84d Merge pull request #5771 from bcoca/play_hosts2
added new play_hosts var
12 years ago
James Cammarata 959a156195 Properly count newlines appearing at the end of templates after rendering
Fixes #4633
12 years ago
James Cammarata ca0ec800d8 Revising method for parsing ranges from --limit subsets
Also added a new test (test_subset_range) for future validation.

Fixes #4620
12 years ago
Richard C Isaacson ac0a5c8ad5 Dug into the remaining FIXME and replaced with comments to document the expected behavior. 12 years ago
Luca Berruti 75b7a1d9c7 Fix slow ssh
We break the read while loop after waiting "the end of the process" and
the pipes are empty, otherwise we do another select that waits all the
timeout.
12 years ago
jctanner a0f91f2aaa Merge pull request #5576 from xyrix/symlink-bug-fix
fixed bug causing symlinks to fail in the host_vars, group_vars etc dire...
12 years ago
jctanner 253fe7be50 Merge pull request #5662 from RSpiertz/update_playbook_error
PlayBook: better error message
12 years ago
Richard C Isaacson a3261500dd Addresses #5739 and cleans up copy.py
The copy action_plugin is not easy to read. Part of this commit is taking that file, restructuring it, and adding comments. No functionality changed in how it interacts with the world.

The fix for #5739 ends up being the assumption that there is a cleanup 'rm -rf' that happens at the end of the copy loop. This was not the fact before and we made a bunch of tmp directories that we hoped would end up being cleaned up. Now we just use the tmp directory that the runner provides and cleanup inline if it is a single file to be coppied or after the loop if it is a recursive copy.

As a part of this we did end up having to change runner to provide a flag so that we could short the inline tmp directory removal. This flag defaults to True so it will not change the behavior of other modules that are being called.
12 years ago
James Tanner 5fafc61008 Fixes 5870 Template delegate hostname earlier in the process 12 years ago
James Tanner d355d3c698 Fixes #5818 Default to all known connection information for the delegate host 12 years ago
Timur Batyrshin 658c15930e reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 12 years ago
James Cammarata 2d0e9cd75d Revert "Fix for issue 5739. The copy module does not delete directories it will only unlinks symlinks."
This reverts commit b20dc4f578.
12 years ago
James Cammarata ae9843fccd Fix issue with handler notifications being sent out incorrectly
This is a partial revert of e8ad36c, which introduced the bug.

Fixes #5848
12 years ago
James Cammarata 9ff99acaff Merge branch 'issue5739_3' of https://github.com/risaacson/ansible into risaacson-issue5739_3 12 years ago
Brian Coca ff024b65b2 now with_items also accepts sets
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Richard C Isaacson b20dc4f578 Fix for issue 5739. The copy module does not delete directories it will only unlinks symlinks. 12 years ago
James Cammarata 75e3b59bbd Adding no_log: capability for tasks
Fixes #4088
12 years ago
James Tanner e6aeb191d5 Revert "Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh"
This reverts commit fe091ec00d, reversing
changes made to aed2194b1d.
12 years ago
James Cammarata 9574f89471 Detect remote_user change in accelerate daemon and allow a restart
Fixes #5812
12 years ago
jctanner 6c25ea1b91 Merge pull request #5527 from sergevanginderachter/basedirdwim
path_dwim: fix when basedir not set
12 years ago
James Cammarata f955d9db6a Handle implicit localhost when using '-i host,' syntax
Fixes #5820
12 years ago
jctanner 360f06b41d Merge pull request #5806 from sivel/rax-mod-utils-improvements
Rax mod utils improvements
12 years ago
James Cammarata 5cc354696d Build variable dictionary on included plays without using dict()
Using dict(k=v) means the key was always named 'k', as the variable
is not interpreted there.

Fixes #5801
12 years ago
Michael DeHaan d07a3b5e9b AnsibleWorks -> Ansible 12 years ago
Heikki Hokkanen b6875b3b87 Fix .ssh/known_hosts path expansion.
In particular, do not rely on the $USER environment variable always existing.
tmux for example seems to clear it, causing lots of invalid messages:
"previous known host file not found"

This broke in commit 80fd22dc, but instead of reverting that commit, we now
fall back to expanding just ~ when $USER is not set.
12 years ago
Matt Martz ac666e63e0 Support providing a tenant_name also 12 years ago
Matt Martz aa709012ba Make sure to also include the region when using keyring_auth 12 years ago
Matt Martz 021b926235 Only specify to USE_KEYRING as the api_key/password when we actually got a keyring_username from ~/.pyrax.cfg 12 years ago
Matt Martz 1ac7dffd55 Support using ~/.pyrax.cfg and multi environments 12 years ago
Matt Martz 139e905e98 identity_type is set dynamically above 12 years ago
Matt Martz bc473c5be3 Support additional attributes that would allow the rax modules to work with other OpenStack clouds 12 years ago
Matt Martz d7597414b8 Support keyring for the api_key 12 years ago
James Tanner fe091ec00d Merge branch 'slow_ssh' of git://github.com/lberruti/ansible into lberruti-slow_ssh 12 years ago
Adam Heath aed2194b1d self.su_user is done earlier in the code path, and is auto-vivified from
su_user_var.  My last PR was only half merged, and when the bug fix for
the su/su_pass typo was merged, the removed line in this commit was
mistakenly reintroduced.
12 years ago
James Tanner 3ec043ec17 Fixes #5750 Fail on missing ~/.ssh and ignore accept_hostkey if stricthoskeychecking is off 12 years ago
James Cammarata 88e2595a90 Fixing bug relating to su without an su_pass 12 years ago
Adam Heath fac7c6d3fe Allow su_user to be templated, same as sudo_user. 12 years ago
James Cammarata 3fddd78ec5 Fixing traceback caused by incorrect argument passing to json.dumps
Fixes #5756
12 years ago
Brian Coca 59d5892fa3 added new play_hosts var
this variable has the 'current host list' to be executed over in the
play. Useful when using --limit to not iterate over hosts not included
in play in templates or with_items.

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
jctanner b2d594d24e Merge pull request #5724 from angstwad/su-tasks-fix
Fix bug where playbook tasks do not escalate privs with 'su'
12 years ago
jctanner 19e8742005 Merge pull request #5713 from angstwad/su-fix
Disallow su and sudo params in same play/task
12 years ago
Craig Tracey 8c6b3baf6f Make default ANSIBLE_REMOTE_PORT None
The ansible remote port should be None, not 22. Having a default value
of 22 means that '-o Port 22' will be appended to the ssh connection
all of the time. This is incorrect as when one would like to use
something like an ssh configuration file (-F) that sets the port to
something other than 22.

Part of this change requires that we check that, in get_config, the
value is not None before trying to cast it into an integer or float.
12 years ago
Paul Durivage e875089eba Fix bug where self.su was being set by the sudo param in play tasks 12 years ago
Paul Durivage 01d1bd61e7 Disallow su and sudo params in same play/task 12 years ago
James Cammarata ff8eb5f454 Merge pull request #5722 from jeromew/pipelining_default
Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean
12 years ago
jeromew ef69d23715 Bug: chmod should be called only if the tmp dir was created in the first place 12 years ago
jeromew 3f23483022 Bug in constants.py, ANSIBLE_SSH_PIPELINING should be coerced to boolean 12 years ago
Thomas Omans 9343db69b4 Fixing whitespace 12 years ago
Thomas Omans ce0b5d16b3 Allow templates in ansible_sudo_pass inventory var
Template ansible_sudo_pass the same way we template ansible_ssh_pass.
12 years ago
Matt Martz 5ba6739603 Use realpath for plugin directories instead of abspath 12 years ago
James Tanner 61d283e2ad Fix merge conflicts from #5519 12 years ago
jctanner da136dbe7c Merge pull request #5694 from angstwad/add-su-support-revert
Add su support
12 years ago
Rob Smith 761fe8cc04 Fix an issue where git-pull fails with AttributeError
As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull

```
Starting ansible-pull at 2014-01-20 23:09:57
Traceback (most recent call last):
  File "/tmp/ansible/bin/ansible", line 157, in <module>
    (runner, results) = cli.run(options, args)
  File "/tmp/ansible/bin/ansible", line 82, in run
    hosts = inventory_manager.list_hosts(pattern)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts
    result = [ h.name for h in self.get_hosts(pattern) ]
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts
    subset = self._get_hosts(self._subset)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts
    that = self.__get_hosts(p)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts
    hpat = self._hosts_in_unenumerated_pattern(name)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern
    ungrouped.add_host(new_host)
AttributeError: 'NoneType' object has no attribute 'add_host'
```

The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.
12 years ago
Rob Smith 953dc6b345 When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code. 12 years ago
Paul Durivage f72f5a20df Revert "Revert "Merge pull request #5325 from angstwad/add-su-support""
This reverts commit c17d0e0357.

Conflicts:
	lib/ansible/runner/connection_plugins/paramiko_ssh.py
12 years ago
Paul Durivage 4c84ba74b0 Resolve su bug in paramiko libs 12 years ago
Jesse Keating 6013f0738e Store the list of hosts to run on in runner object
This reduces the number of times inventory.list_hosts is called, which
can be costly. When coming from a playbook that data is already known.
12 years ago
Jesse Keating e8ad36c8d4 Store hosts for a play as a play attribute
Operate on that play attribute to make things faster for larger
inventories. Instead of making a round trip through inventory.list_hosts
and working through some lengthy list comprehensions over and over
again, calculate the potenital hosts for a play once, then reduce from
it the unavailable hosts when necessary.

Also moves how the %fail is done. The host count is a play level count
of available hosts, which then is compared after each task to the
current number of available hosts for the play. This used to get a new
count every task which was also time expensive.
12 years ago
James Tanner 94f3b9bfab Fixes #3129 Do not require localhost to be in inventory 12 years ago
James Tanner c17d0e0357 Revert "Merge pull request #5325 from angstwad/add-su-support"
This reverts commit 6f4bfa2cff, reversing
changes made to c91ba3a7c7.
12 years ago
Paul Durivage 8cf071f697 Hostvars support for su 12 years ago
Paul Durivage dec9131735 Ensure playbook support for su params 12 years ago
Paul Durivage d21281ff43 Resolve rebase conflicts 12 years ago
Paul Durivage ab6ee1a282 Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins 12 years ago
Paul Durivage 4088243deb Proposing fix for Issue #4324; adding support for su in connection plugins ssh, ssh_alt
Fixes for ssh_alt support, adding in references to in_data where appropriate
12 years ago
Michael Scherer 5c5c8fd7ce Make synchronize module work better with local transport, fix #5668 12 years ago
Rutger Spiertz dec6345fe6 PlayBook: better error message
When a PlayBook has missing arguments the error message now shows which ones are missing.
12 years ago
James Tanner 559e89036b Fixes #5631 Return a unique list of hosts when joining groups 12 years ago
James Cammarata 02ce5af6df Added ANSIBLE_SSH_PIPELINING option to enable/disable pipelining support
Pipelining will be disabled by default, since it requires users remove
the 'requiretty' option from the servers sudoers configuration.
12 years ago
James Cammarata 233aae5861 Reverting paramiko_ssh/alt changes from yesterday 12 years ago
Matt Martz d46037d64c Do not log the rax api_key argument in module invocation 12 years ago
James Cammarata 36e6709771 Don't use pipelining when ANSIBLE_KEEP_REMOTE_FILES is enabled 12 years ago
James Cammarata df13b19fe1 Moving {ssh,paramiko}_alt connection types to be the defaults
The previous implementations will be kept for now as _old
12 years ago
James Cammarata c27db84e41 Adding paramiko_alt - pipelining support for paramiko connections 12 years ago
jctanner 91c5c9da08 Merge pull request #5465 from deonbredenhann/false_mandatory_variable
Treat a False mandatory variable as defined.
12 years ago
jctanner 59d99c17b3 Merge pull request #5337 from bob-smith/bugfixFQDNParsing
Fix inventory parsing so that FQDN can be parsed without throwing ssh port error
12 years ago
jctanner a6bc63512e Merge pull request #5308 from zecrazytux/fix/hash_merge_dynamic_inventory
Let merge hash_bahaviour work with dynamic inventory
12 years ago
jctanner 671b0454c6 Merge pull request #4987 from jpmens/lookup-csvfile
New lookup plugin csvreader
12 years ago
willthames 31f5ecea60 Allow float as an argument type in AnsibleModule 12 years ago
Rob Smith c15cffabdd This fixes bugs added as a part of 8665b0638a
1. if accept_hostkey is false, no matter if the host key is known or not, it will fail.

2. We don't check for the host key in /etc/ssh/ssh_known_hosts

This fixes both of those issues.
12 years ago
James Tanner 3719f3f496 Do not fetch or add keys for http based git urls 12 years ago
James Tanner eeee1e1c5a Set accept_hostkey to False by default in the git module and fail
early if the key is unknown
12 years ago
James Tanner 8665b0638a Add an "accept_hostkey" parameter to the git module to help automatically
accept hostkeys for git repos and prevent task hangs when the key is unknown
12 years ago
James Tanner 09e0d052ca Ensure sys.stdout has an istty method 12 years ago
James Tanner d7c8cf6ca7 Fixes #4958 Truncate printed stdout if it contains non-printable characters 12 years ago
jay e1f5b801cf fixed bug causing symlinks to fail in the host_vars, group_vars etc directories 12 years ago
James Tanner 78ec7c736f Fixes #3973 Second Revision of live ansible-pull output 12 years ago
Luca Berruti ae543eecab Simplified p.poll handling 12 years ago
James Tanner c408bcea31 Update sshpass hostkey error message 12 years ago
James Tanner 0b64408f5a Fixes #5531 Give the user a better error message when sshpass does not know the remote hostkey 12 years ago
Matt Martz f99500d65c Expose the playbook to callback plugins 12 years ago
jeromew 69febcefde remove useless create/delete remote tmp dir roundtrip in copy module 12 years ago
Serge van Ginderachter 836fb4143c path_dwim: fix when basedir not set 12 years ago
jeromew c9b01febb3 Make sure 'tmp' is in the remote tmp dirname to ensure correct cleanup 12 years ago
jctanner 21b4212ff5 Merge pull request #5517 from lichesser/fix_set_depreciation_warning
Fixes #5513. set is built-in since 2.4 and deprecated since 2.6
12 years ago
jctanner 83dec044ab Merge pull request #5504 from smoothify/synchronize-sudo
Synchronize Module: Improved sudo override behaviour.
12 years ago
jctanner 9a69b1b0ec Merge pull request #5311 from willthames/ec2_refactor
ec2 modules: Move more responsibility to common EC2 module
12 years ago
James Tanner d6b78e9dd6 Fixes #5238 Improve error messaging about unquoted variable references in playbooks 12 years ago
James Tanner ab51bd23a2 Fixes #5196 return a unique list of hostnames for a single host pattern 12 years ago
smoothify 93a55e8dff Don't override sudo if transport is set to local.
https://github.com/ansible/ansible/pull/5251
12 years ago
Michael DeHaan c039e276a2 Fact gathering on a second play against the same hosts should not be implicitly off since this is an undocumented beheavior and potentially
rather unwanted when a play could change a fact.

gather_facts: True/False can still be explicitly used per play.

Reverts 564a212b3c
12 years ago
Michael DeHaan 87258f6d42 Resolve merge commit 12 years ago
Michael DeHaan 1c632af2c9 Merge pull request #5468 from jeromew/ansible_ssh_alt
fix issue #5372 on ssh_alt: accept -K option for a user with NOPASSWD
12 years ago
Michael DeHaan a3d90e8a87 Merge pull request #5498 from j2sol/exit_setup_early
Return early from setup step when possible
12 years ago
Michael DeHaan 227e8e31c9 Merge branch 'use_comps' of git://github.com/j2sol/ansible into devel 12 years ago
Michael DeHaan 10350d1639 Update various copyrights. Not complete, but sufficient. 12 years ago
Jesse Keating 23720ff19d Use list comprehensions for efficiency
For loops can be inefficient, particularly when doing a dot command with
them. https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops and
https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Avoiding_dots...

This patch makes use of list comprehensions to be as efficient as
possible while still retaining order. Efficiency was lost a bit when
switching away from sets() but this gains some of it back.
12 years ago
Jesse Keating 35328ed503 Return early from setup step when possible
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
12 years ago
Michael DeHaan c41a23a35a Complete removal/refactoring of conditional deprecations. 12 years ago
Michael DeHaan 8e5b7d3095 Remove code underlying when_* and only_if, which are deprecated features slated for removal in the 1.5 release. 12 years ago
Michael DeHaan 28b9fd4e30 We have had only_if, when_foo, etc, deprecated for a while and said they would be removed in 1.5. Now they are, with friendly error messages still.
Users of these features should use "when:" as documented at docs.ansible.com.

Similarly, include + with_items has been removed.  The solution is to loop
inside the task files, see with_nested / with_together, etc.
12 years ago
James Tanner 21fdb2bbc7 Fixes #5200 Handle template contents with unicode strings better 12 years ago
James Tanner fc473b3246 Fixes #5146 Handle missing stdin when running under celery with rabbitmq or redis 12 years ago
Michael DeHaan de2ffc1276 Don't need to document these guys. 12 years ago
James Tanner cb2214d6f8 Fixes #4935 Synchronize module: set destination to an fqdn if connection is not local, and abide by ansible_remote_user 12 years ago
jctanner 99560e3902 Merge pull request #5047 from sergevanginderachter/synch_template_ansiblesshhost
synchronize: allow ansible_ssh_host to be templated
12 years ago
jeromew b2cd4a62de fix issue #5372 on ssh_alt: accept -K option even for a user with NOPASSWD 12 years ago
Deon Bredenhann c85aac8b17 Treat a False mandatory variable as defined. 12 years ago
Deon Bredenhann 4f1f13b100 Remove trailing space 12 years ago
Levi Gross dc6a26123b
Fixed syntax error and removed unused imports 12 years ago
Michael DeHaan 643690ffec Remove depedency of lookup plugin on setting in ansible.cfg 12 years ago
Michael DeHaan 5b3c796641 Update constants.py
Lookup plugins for optional web services do not warrant advertising in ansible.cfg.
12 years ago
Stephen Fromm 833e1f6e2a Make sure action plugin copy cleans up tmp dir
The copy action plugin creates its own tmp dir for each file that it
copies to the target machine.  However, it does not clean up the
original tmp path it was given when run() is called.  This cleans up the
tmp path before it begins looping on source files.
12 years ago
dparalen 6bf5d664dc allow per-host sudo operation 12 years ago
James Tanner 993e0f057e Allow for no role dependencies in role metadata 12 years ago
James Tanner 1ef9930b80 Addresses #5341 Expand home directories when searching for roles in ansible-playbook 12 years ago
James Tanner 5d022182fe Fixes #5341 Use constants.py to set the roles directory 12 years ago
John Barker 4bf9f714d0 Fix inventory parsing so that FQDN can be parsed without throwing ssh
port parsing errors
Fixes problesm introduced by 948d019fef
Adds testcases to defend
12 years ago
jctanner ea8cd62b19 Merge pull request #5259 from mvo5/bugfix/improve-error-on-invalid-vars-file
improve error on invalid vars file (if its a list instead of a dict)
12 years ago
jeromew e4a3f49fa2 ssh_alt - only trigger 'fatal' when returncode == 255 (interpreted as 'could no connect') 12 years ago
willthames 12005a1cd0 Move more responsibility to common EC2 module
Moved `AWS_REGIONS` into `ec2` module
Created `ec2_connect` method in `ec2` module
Updated modules able to use `ec2_connect` and `AWS_REGIONS`
12 years ago
jctanner cd3144af5d Merge pull request #5178 from cavassin/devel
Prevents UnicodeEncodeError
12 years ago
James Tanner f3a4705a9c Revert "Merge pull request #4874 from leth/editable_install"
This reverts commit 15b89b45e1, reversing
changes made to 3d836a1ab7.
12 years ago
jctanner 15b89b45e1 Merge pull request #4874 from leth/editable_install
Fix setup.py to work with 'pip install -e .'
12 years ago
Sébastien Bocahu c8d5846ab9 Let merge hash_bahaviour work with dynamic inventory 12 years ago
jctanner 3d836a1ab7 Merge pull request #5247 from jeromew/ansible_ssh_alt
ssh_alt.py / decrease # of ssh roundtrips
12 years ago
jeromew 5c965a75f0 ssh_alt.py / decrease # of ssh roundtrips 12 years ago
jctanner 1679d83637 Merge pull request #5131 from janeznemanic/devel
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
12 years ago
jctanner 301a1189dd Merge pull request #5122 from willthames/openlog_str
Make first argument to syslog.openlog be a string
12 years ago
Ferenc Grecu 56642f9b04 Remove unused parameter from _get_config 12 years ago
Michael Vogt bef5ee2c3b improve error on invalid vars file (if its a list instead of a dict) 12 years ago
Jesse Keating 8cef210aea Make sure ssh pipes are empty before moving on
Resolves issue #5082

Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.

The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.

Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
12 years ago
Michael DeHaan 929f8a5c93 Had to revert commits due to async. 12 years ago
Michael DeHaan 74e4ccb59b Revert "ssh_alt.py / decrease # of ssh roundtrips"
This reverts commit 7f8863f96d.
12 years ago
jeromew 7f8863f96d ssh_alt.py / decrease # of ssh roundtrips 12 years ago
jeromew db182ba498 copy ssh.py to ssh_alt.py 12 years ago
Steve Smith 5b81f88c8f Cast the retrieved `retries` var to an int before incrementing as it may be in string form.
For example, the following method of calculating the value will result in a type error:

    appstatus_waitfor: 4  # Minutes
    appstatus_delay: 5 # seconds
    appstatus_retries: "{{ mins * 60 / delay }}"
12 years ago
Wanderlei Antonio Cavassin 6ba93817a9 Avoid UnicodeDecodeError exception when passing module args 12 years ago
James Tanner bf78d8cf73 Addresses #5090 setup module was using path.is_file instead of path.isfile 12 years ago
cavassin 10f5af82f9 Prevent UnicodeEncodeError
Prevents UnicodeEncodeError: 'ascii' codec can't encode character, while printing shell commands output
12 years ago
jctanner 7aa35d64c2 Merge pull request #5091 from EspadaV8/5089_assemble_fix
#5089 hack-fix assemble module
12 years ago
Paul Bonser 58acd8cce1 If there is no tmp_src, don't modify the args 12 years ago
Paul Bonser 4afcd50487 properly convert arg into boolean 12 years ago
Michael DeHaan 801ca96a8b Merge pull request #5152 from sivel/too-many-ps
The word skipped only has 2 p's not 3
12 years ago
Matt Martz 5f0f3566a6 Skipped only has 2 p's not 3 12 years ago
Matt Martz 8873c3675b Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148 12 years ago
jctanner 2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
12 years ago
James Tanner d227614529 Fixes #5109 synchronize module ssh port
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
12 years ago
Paul Bonser 5626efba7e Optionally unarchive a file already on the remote machine 12 years ago
jctanner 93159cb9cd Merge pull request #4996 from sivel/rax-module-utils
Implement ansible.module_utils.rax
12 years ago
Janez Nemanic 8752ae6909 Fix for issue #4730 - stacktrace when deferenencing a non-existent group 12 years ago
Will Thames 76aca4d547 Make first argument to syslog.openlog be a string
syslog.openlog expects its first argument to be a string.
Without this change running under ipython fails.
12 years ago
James Cammarata 9101c2af98 Fix traceback in template error detection code
Fixes #5081
12 years ago
Andrew Smith eed32ea70c dest_contents isn’t always defined, so don’t pass it around
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
12 years ago
Andrew Smith e2d03173d2 The file module doesn’t have it’s module_args reset
I believe that this should be reset in the same way that the copy module
does
12 years ago
Andrew Smith 7b01c83159 Passing in complex_args throws ‘unsupported parameter for module’ errors
When using assemble only params (e.g. remote_src) the copy (and I’m
guessing file) modules throw an error that the param isn’t supported.
Simply removing the complex_args param fixes it for me, but I’m not sure
that’s the correct thing to do
12 years ago
Andrew Smith da44a7f0cb I think that resultant is meant to be the contents of the combined file
It is used for the transfer and as a diff param but isn’t actually
defined anywhere before it’s used. This seemed like the least bad place
to set it.
12 years ago
Andrew Smith 4503413baa ReturnData is used throughout but not actually imported 12 years ago
dragon3 d39e6fda92 hostname module: add support for Amazon Linux 12 years ago
Andrew Smith 7d007cac16 Correct the invocation of ‘_assemble_from_fragments’ 12 years ago
jctanner 920bc6e75b Merge pull request #5086 from j2sol/fix-accelerate_inventory
Avoid a traceback when using accelerate
12 years ago
James Tanner b6879ca2bd Fixes #5030 compare connection user and sudo user and disable sudo if identical 12 years ago
Jesse Keating 5522d489e3 Avoid a traceback when using accelerate
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
12 years ago
James Tanner 12ed39ef7b Fixes #5056 Append new hosts to the groups cache 12 years ago
James Cammarata 1f80aa768a Fix bug in error detection code, where a zero-length string was causing a traceback
Fixes #5064
12 years ago
Brian Coca 65885feeeb fixed typo for assemble function 12 years ago
James Tanner b8146e3bc7 Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin 12 years ago
James Tanner 903c4cae7b Fixes #5031 Template the delay value and cast to float for loops 12 years ago
Serge van Ginderachter 2f9470ec1d synchronize: allow ansible_ssh_host to be templated
This is already enabled in the runner also.
12 years ago
Antonio Zanardo 8dbd91b5ad fix typo in deprecation warning 12 years ago
James Tanner bca2634d54 Fix missing eval for string search in ssh controlpersist 12 years ago
James Tanner a16fe923ed Addresses #5011 check for proper string in smartos ssh error output 12 years ago
jctanner 5c84d7e445 Merge pull request #5002 from ovcharenko/devel
Allow to specify ansible_ssh_private_key_file location related to user home directory
12 years ago
James Tanner 512ebdb971 Revert "Merge pull request #5001 from ovcharenko/devel"
This reverts commit d6c3103a00, reversing
changes made to b11f96eaa4.
12 years ago
Aleksey Ovcharenko 9af44b1b42 Update to 4 space indent 12 years ago
Aleksey Ovcharenko 30678e04ac Make tests happy 12 years ago
Aleksey Ovcharenko 2222f6df58 Allow to specify ansible_ssh_private_key_file location related to user home directory 12 years ago
Matt Martz 3f2cbb7583 Add ansible.module_utils.rax 12 years ago
James Tanner 9b991b9154 Version bump for 1.5 12 years ago
Jan-Piet Mens 252a51be91 New lookup plugin csvreader 12 years ago
James Tanner b815a09529 Fix pep8 error in password lookup 12 years ago
James Tanner e81c976636 Fix pep8 errors in unarchive module 12 years ago
jctanner 68afd9da9f Merge pull request #4866 from sergevanginderachter/known_hosts_sudo
Check real user's known_hosts when sudo ansible...
12 years ago
Brian Coca 34c33f7ea1 now correctly spell symmetric
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca 460bbfaec1 added union filter
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca afe30a6633 added difference and symetric difference filters
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan fc909b453f Make the legacy template detection system not hit a false positive when
replacing a \$ with $.
12 years ago
jctanner 93223510af Merge pull request #4936 from stoned/group-get_hosts-perf2
Improve Group.get_hosts() performance.
12 years ago
Matt Haggard 389602b8dd Merge pull request #4920 from iffy/ansible
Collect all stdout over ssh transport before returning data
12 years ago
Michael DeHaan f18acee779 Merge pull request #4937 from skyl/synchronize-keyerror
KeyError: 'delegate_to' lookup in sync module needs to be checked to see if defined for ad hoc
12 years ago
James Tanner e8b54dd073 Fixes #4852 properly evaluate log_path writability 12 years ago
Skylar Saveland 7bc64581d7 KeyError: 'delegate_to' no more 12 years ago
Stoned Elipot b00bf02129 Improve Group.get_hosts() performance.
- reduce hosts group list to unique elements faster
- add a cache of already computed hosts group list
12 years ago
jctanner 009fdbf96a Merge pull request #4896 from mjschultz/aws-access-keys
Check for AWS keys using boto names
12 years ago
jctanner 04847191b4 Merge pull request #4879 from bcoca/unique_intersect
added unique and intersect filters for dealing with lists
12 years ago
jctanner 0f0a89b34e Merge pull request #4758 from alanfairless/group-host-var-dirs
Support organizing group and host variables across multiple files in a directory
12 years ago
jctanner 77affdefbc Merge pull request #4585 from mscherer/connec_func
connection plugin to reuse the func/certmaster interface instead of ssh
12 years ago
jctanner be67a6f815 Merge pull request #4625 from pileofrogs/devel
unarchive module & action plugin
12 years ago
jctanner e4494be8c6 Merge pull request #4803 from dragon3/devel
Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM rol...
12 years ago
Michael J. Schultz 5f9485499c Check for AWS keys using boto names
- see https://github.com/boto/boto#getting-started-with-boto
12 years ago
James Tanner 33242cacf3 Merge pull request #4375 from pfalcon/ansible
copy: Implement recursive copying if src is a directory.
12 years ago
jctanner 9a7765daf7 Merge pull request #4351 from 2m/leading-range-fix
Allow leading ranges in the inventory host entries.
12 years ago
jctanner 6dd81f25d9 Merge pull request #4856 from akuznecov/devel
Resolves #4855 issue with synchronize module failing on multiple items
12 years ago
James Tanner f31cb7c6e8 Merge pull request #4664 from jpmens/ansible
Lookup plugin for etcd

with support for configurable etcd URL in ansible.cfg (and environment)
12 years ago
James Tanner dc41bb8085 Merge pull request #4207 from ashorin/ansible
Fail playbook when serial is set and hadlers fail on set.
12 years ago
jctanner 2cf335969f Merge pull request #4738 from bcoca/assemble_action_plugin
assemble can now use src from master/origin
12 years ago
Brian Coca efd87534eb added unique and intersect filters for dealing with lists
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
James Tanner 6e49ee6cfc Remove commented code block 12 years ago
James Tanner 288c33e286 Merge pull request #4078 from mkaluza/ansible
add 'chars' parameter to password plugin to allow custom character set
12 years ago
jctanner 0c29807ba3 Merge pull request #3993 from stoned/inventory-script-all-group-fix
Avoid duplicates of the 'all' group when using inventory script.
12 years ago
Marcus Cobden 8d98a55df1 Fix setup.py to work with 'pip install -e .' 12 years ago
Serge van Ginderachter 80fd22dce6 Check real user's known_hosts when sudo ansible...
closes #4834
12 years ago
James Tanner 74e7eba528 Fixes #4506 test length of context before checking invalid indexes 12 years ago
Alexander Kuznecov 9d2f9bf93c resolves #4855 12 years ago
jctanner 8e8c8efc8f Merge pull request #4769 from alanfairless/more-password-entropy-revised
Revised patch for more password entropy
12 years ago
jctanner f51b8ffde9 Merge pull request #4836 from dekked/devel
Bug fix: support running handlers parametrized by name
12 years ago
James Tanner 898de833b0 Merge pull request #4413 from jerm/ansible
Add capability to pass in a PATH prefix to run_command and allow pip module
to utilize that to make virtualenv bin/ available in pip installs
12 years ago
Alan Descoins bb6f02d0e8 Support running handler parametrized by name. 12 years ago
jctanner 8d9b53b445 Merge pull request #4733 from sivel/4323-sudo-pass
Add ansible_sudo_pass hostvar support. Fixes #4323
12 years ago
James Tanner d93780bc8a Addresses #4635 add list instead of join 12 years ago
James Tanner 2b5005687a Fixes #4635 pass role conditionals to dependent roles 12 years ago
James Tanner 91aa7b51df Remove invalid ipv6 parameter from setup execution 12 years ago
James Tanner c1ed47933b Fixes #4485 add an ipv6 parameter to accelerate so that the daemon will bind to an ipv6 port instead of ipv4 12 years ago
dragon3 ff5bd7fe06 Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM role. 12 years ago
willthames 76c810afe3 AWS_ACCESS_KEY misspelt in shared EC2 connection library 12 years ago
Michael DeHaan eab6737209 Clarify a warning message. 12 years ago
Michael DeHaan 70c9028e1e include_vars plugin should look in vars/ path for a role. 12 years ago
Michael DeHaan 99687749a3 Merge pull request #4775 from steverweber/fix-4640
dont sudo if sudo_user is the same as the connection user
12 years ago
Steve Weber 5bd52796ec dont sudo if sudo_user is the same as the active user 12 years ago
James Tanner afa5988391 Fixes #4540 Use shared module snippet to evaluate ec2 credentials 12 years ago
Alan Fairless 0824f004d9 Revised patch for more password entropy 12 years ago
James Tanner dc4d589ce0 Fixes #4767 detect hard links and set state in add_file_info 12 years ago
Michael DeHaan b1b5280075 Reapply pep8 changes from previous revert. 12 years ago
Michael DeHaan 51fbc6d20a Further simplify the debug: var=foo action plugin code. 12 years ago
Michael DeHaan bbf212a268 Simplify the way the debug: var=varname plugin works. 12 years ago
Michael DeHaan 7f125567cb Some simplification of include_vars and renamed include_files to include_vars. 12 years ago
Michael DeHaan b69ab89eb1 Merge branch 'include_files' of git://github.com/bennojoy/ansible into devel 12 years ago
Michael DeHaan 465f3b1c91 This allows type=dict in a module to allow passing in a real dict or JSON. 12 years ago
Michael DeHaan 8b2cd6413b When inside an apt or yum task account for multiple conditionals. Fixes 4745. 12 years ago
Michael DeHaan d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 12 years ago
Alan Fairless 65e5331079 Allow organizing host/group vars in a directory
So instead of having:
 group_vars/production.yml

A user could chose to reorganize to:
 group_vars/production/staff.yml
 group_vars/production/networks.yml
 group_vars/production/dns.yml

(Backwards compatible.)
12 years ago
Alan Fairless babde9a84c refactor to catch edge cases, remove repeated code
- Move all the supported YAML file extensions into a constant
- Use helper functions to avoid duplicate code for group/host vars
- Catch and disallow some confusing situations, such as the presence of
  multiple group/host vars files for the same group/host, but with
  different extensions.  For example having both group_vars/all.yml and
  group_vars/all.yaml.
- Catch and report file system permission issues, symlink errors,
  unexpected file system objects
- Trivial performance improvement from making fewer stat system calls
- Restructuring that makes it easy for a following patch to support
  directory recursion
12 years ago
Brian Coca ac40d15120 now assemble module is also action plugin and can use local source for
files
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 7b331ef6ed Fix code typo. I'll blame jet lag for now :) 12 years ago
Michael DeHaan 90cce35919 This allows variable references in playbooks in a different way. 12 years ago
Michael DeHaan b5c9d5a59b Inventory directory should always be absolute. Fixes #4535. 12 years ago
Michael DeHaan 7201a6ffad Evaluate the conditional for each item for modules that normally try to group with_items results
like yum and apt.
12 years ago
James Tanner 078aaa95a2 Revert 1f6edf7d76 and re-enable passing lists to yum and apt 12 years ago
Matt Martz ea2ec6237a Add ansible_sudo_pass hostvar support 12 years ago
James Tanner d154bf8781 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 12 years ago
James Tanner 0faecdf7d1 Fixes #4653 Set dest on results for copy module even if using file module 12 years ago
James Tanner 9249cf578d Fixes #4572 Run until loop if until is set, ignoring result failures 12 years ago
Michael DeHaan 73dbab702f Don't run lookup plugins while trying to simplify the input datastructure. 12 years ago
Michael DeHaan 6d0da41a55 No need to template modules with Jinja2 as this can confuse some docstring comments. 12 years ago
bennojoy b53e7353f9 include files 12 years ago
Michael DeHaan 603db60828 Merge pull request #4288 from sivel/3725-regex
Add regex (search, match, regex) jinja2 filters. Fixes #3725
12 years ago
Michael DeHaan 4587528b99 Fix typo in comment. 12 years ago
Michael DeHaan d409352c85 Remove some interior imports in the code. Not really needed but nice to have them gone. 12 years ago
Michael DeHaan e6c28658b4 Add in some code to pre-template datastructures prior to template usage. This prevents a certain class of error
where filter evaluations can happen too early due to the template engine recursion being a bit limited.

Addresses #4662
12 years ago
Michael DeHaan f05a3a81f9 Add missing file. 12 years ago
Michael DeHaan 54c902f102 Identation + misc PEP8 fixes. 12 years ago
Michael DeHaan bbb359870e Add package file. 12 years ago
Michael DeHaan 9858b1f2f3 Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
12 years ago
jctanner 43f48a2e02 Merge pull request #4167 from tima/rsync3
synchronization module take 3
12 years ago
James Tanner 40886c42b5 Fixes #4561 Compare task name without role prefix for start-at-task 12 years ago
James Tanner 1f6edf7d76 Fixes #4665 and #4666 If task is conditional do not flatten items list for packaging modules 12 years ago
James Tanner 9b1fe455c6 Fixes #4549 Do not call lookup plugins when templating a task's name 12 years ago
Serge van Ginderachter 6277e770a1 include basedir as 'playbook_dir' variable
closes #4246
12 years ago
Jan-Piet Mens bd5cd8e652 Lookup plugin for etcd
with support for configurable etcd URL in ansible.cfg (and environment)
12 years ago
James Tanner b803aac6ec Fixes #4500 change ec2 module params to type=bool
Revert 4833c2fdf0
12 years ago
James Cammarata b9dd514713 Minor fix for putting 0-length files over accelerated connections
Fixes #4652
12 years ago
James Tanner 4833c2fdf0 Fixes #4500 python bools return uppercase True and False, so allow those for BOOLEANS in module common 12 years ago
James Tanner 214b0b052c Fixes #4608 add lookup to template globals to make plugins work again 12 years ago
Dylan Martin 2c28e1daea unarchive module & action_plugin added 12 years ago
James Tanner 4f13967386 Fixes #4536 Get the remote_user from multiple sources in a preferred order 12 years ago
Timothy Appnel cbae9c913e synchronize module src and dest handles template markers. 12 years ago
Michael DeHaan 60944b81f0 Provide warning about "with_items: '{{ loop }}'" being redundant only when {{ starts the expression value. Fixes #4582. 12 years ago
Michael DeHaan 2bd8cb5790 Make the deprecation detector in templates more accurate. Fixes #4514. 12 years ago
Michael DeHaan 4125b05bf3 Allow a defaults file to solely define a role. Some typo fixes. 12 years ago
Michael DeHaan 64bbeb9d24 Suggest fixing unbalanced quotes in a bit less cases. Fixes #4501 12 years ago
Michael DeHaan 7f9504d14d Fix a typo. 12 years ago
Michael DeHaan 8d3db80370 Some misc cleanup and removal of unused imports. 12 years ago
Michael DeHaan 21d4400c96 Misc pep8 fixes 12 years ago
Michael DeHaan c933a4c59a Fix indentation depth. 12 years ago
Michael DeHaan 5031104c3a Finishing touches on template cleanup. 12 years ago
Michael DeHaan 1e85c7544b Further WIP on template cleanup. 12 years ago
Michael DeHaan 35cb9dc22f Work in progress about cleaning up template code. 12 years ago
Michael Scherer af796d6556 connection plugin to reuse the func/certmaster interface instead of ssh
This plugin permit to use func to run playbook and ansible command instead
of ssh. It can be used for a smooth transition from func/taboot to ansible by
letting people use ansible without having to change their network architecture.
12 years ago
Brian Coca c476ed93ca now correctly changes script permission in all cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
James Tanner 8478e82647 Fixes #4583 enforce that vars_files is a list 12 years ago
Michael DeHaan b0f6e77f66 Merge pull request #4571 from tgerla/whitespace
add_group module: strip trailing/leading whitespace from comma-separated group names
12 years ago
Tim Gerla 51a1709253 add_group module: strip trailing/leading whitespace from comma-separated group names 12 years ago
James Tanner 242f20c297 Fixes #4402 wrong order for isinstance parameters in dnstxt.py 12 years ago
Martynas Mickevicius 7ecb5fbc9c Handle comment on inventory group line. 12 years ago
Martynas Mickevicius 44279ce34f Allow leading ranges in the inventory host entries. 12 years ago
jctanner 6480945184 Merge pull request #4541 from Kami/improve_template_render_error_messages
Make errors which get thrown during template rendering more user-friendly
12 years ago
Stoned Elipot 4430d0f5a6 when searching for a plugin only look for a regular file 12 years ago
Tomaz Muraus 922f61899e Throw a more user-friendly exception during template rendering process. 12 years ago
Gabe Mulley 84a57b7545 ensure non-root users can read arguments file when using sudo_user
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600.  This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.

This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
12 years ago
Brian Coca bd9acedb57 fixed name colision between warnings dict and module
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Paul Sokolovsky 2e668f14f7 copy: Handle "no copy/propagate attrs only" for recursive mode well.
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
12 years ago
Paul Sokolovsky ce88df3cf4 copy: Handle dest path variations for recursive mode. 12 years ago
Paul Sokolovsky 6cf3975e2e copy: Set suitable default result for check mode. 12 years ago
Paul Sokolovsky 612b446856 copy: Don't modify input module_args in a recursive file handling loop. 12 years ago
Paul Sokolovsky b3b4f9885f copy: Implement recursive copying if src is a directory.
If src param to copy is a directory, all files under it are collected
and pushed one by one to target. Source dir path handled in a way
simalar to rsync: if it ends with slash, only inside contents of
directory are copied to destination, otherwise the dir itself is
copied (with all contents of course). Original idea and implementation
by https://github.com/ansible/ansible/pull/1809 . Rewritten to address
review comments and simplify/correct logic.
12 years ago
jctanner 69fa5954fd Merge pull request #3932 from jocelynj/devel
Add option remote_user to task level, to specify the ssh login user
12 years ago
Michael DeHaan e131de4de0 Added "debug: var=variableName" capability. 12 years ago
egghead ca7e2d283c Adding os realpath filter.
This is particularly useful when wanting to get the absolute path of filepaths found by the 'fileglob' filter.
This also lets you provide absolute paths to roles, which search for files in different areas unless absolutely pathed.
12 years ago
Michael DeHaan c90a82fd52 Handle possible scenario where conditional might be an integer (whoa!) down the error path. Super rare but fixes #4483. 12 years ago
Michael DeHaan 9ea54fcaaf Fixes a dev branch glitch where a conditional could be applied to multiple tasks. Also improves the errors on parsing bad conditionals to make them less confusing to users. 12 years ago
Thomas Omans 632232259a Adding config flag role_path for common/global roles
Using ANSIBLE_ROLE_PATH environment variable or role_path in ansible.cfg
can configure paths where roles will be searched for
extra paths will only be used as a backup once regular locations are exhausted
12 years ago
Michael DeHaan 43df00550d Merge pull request #3827 from mscherer/disable_callbacks
add a way for callback to disable itself
12 years ago
Michael DeHaan 1b2d4c328c Cache patterns a bit higher up to make things a little more efficient. See #4469. 12 years ago
Michael DeHaan d168c709d5 Fix an issue where the ordering of an include statement is processed ahead of the conditional in the included statement,
which required a redundant check to see if a variable was defined rather than short circuiting.

Fixes #4469
12 years ago
Michael DeHaan add45d2ca9 Fixup legacy var detector. 12 years ago
Michael DeHaan 709ffda3d1 Tweak only_if deprecation detector. 12 years ago
Michael DeHaan a45494a896 Add warnings feature. 12 years ago
Michael DeHaan 9637f620d7 Deprecation warnings of several flavors, nice and purple and can be disabled
in ansible.cfg.
12 years ago
Michael DeHaan a017a69bb3 Have the parser explain another type of YAML gotcha to reduce the need for users to ask how to resolve it. 12 years ago
Michael DeHaan 861f076df5 Tweak the syntax-detector-warning-suggester-message (SDWSM) a little. 12 years ago
Michael DeHaan 41aaad69aa Make add_host clear the inventory pattern cache, add some more aliases. Fixes #4442. 12 years ago
jctanner 65ef6a62dc Merge pull request #4425 from jeromew/ansible_sudo_user_with_items
Template sudo_user via with_items
12 years ago
James Cammarata d73a5da9e5 Merge pull request #4453 from pschwartz/fix_cfg_load_order_to_match_docs
GH-4452 Corrected config load order to match docs
12 years ago
Philip Schwartz 65c8c691f7 GH-4452 Corrected config load order to match docs with
cwd > ~ > /etc

Signed-off-by: Philip Schwartz <philip.schwartz@rackspace.com>
12 years ago
Matt Martz 61525a97df Add regex (search, match, regex) jinja2 filters. Fixes #3725 12 years ago
Serge van Ginderachter c4d20094b4 make changed filter understand results lists 12 years ago
Serge van Ginderachter e5d45311f9 Implement a |changed filter plugin 12 years ago
Serge van Ginderachter c2e5f783da Add caching to pattern enumeration
Inventory._hosts_in_unenumerated_pattern()

Was TODO: cache this logic so if called a second time the result is not
recalculated
12 years ago
jeromew dec364ae80 Template sudo_user via with_items 12 years ago
Michael DeHaan 3f968ff46a Check one more skipped scenario in with_subelements. 12 years ago
James Cammarata 9124ebb4f1 Clear out complex_args before running async_status
When using complex args with an async task, the subsequent runs of
async_status would inherit them, causing a module error (invalid params).

Fixes #3150
12 years ago
Michael DeHaan 2078518735 Allow subelements to work right with skipped results. 12 years ago
Jeremy Price 9da5043f18 Adding path_prefix to run_command so that one can pass in a path to the run environment if you nees something in a non-default path. 12 years ago
James Cammarata 948d019fef Detect IPv6 addresses in INI inventory
Prevents parts of the IPv6 address from being interpreted as a port
(for example, :80).

Fixes #3888
12 years ago
Michael DeHaan 6febc97104 Add a warning about include + with_items so nobody uses it. 12 years ago
James Cammarata 98f6bc1f63 Apply tags to dependent roles correctly
Fixes #4339
12 years ago
Michael DeHaan c69e19c6a6 Enhance references to logging functionality. Fixes #3431. 12 years ago
Michael DeHaan f081c68a65 Prevent duplicately loaded handlers from running more than once.
Fixes #3863
12 years ago
Michael DeHaan 5ed28efe45 Script module should return changed attribute so handlers always fire, unless "changed_when" is specified.
Fixes #4053
12 years ago
Michael DeHaan a7adc8ef4d Allow doing things like "groups.groupname" in with_nested.
Fixes #3858
12 years ago
Michael DeHaan 5e30cd999c Make it possible to say:
tags: 42

And have the tag be a string, not an int, so --tags matches.

Fixes #4110
12 years ago
Michael DeHaan 8fc46a3a5a Return inventory objects in the order they are presented. Additionally, fix host slicing such that it works on Python terms with
zero indexed lists and a non-inclusive final element.
12 years ago
Michael DeHaan 19386c43a7 Merge 12 years ago
James Cammarata d10582225b Merge branch 'issue_4215_fetch_expanduser' into devel 12 years ago
Andrey Shorin 35457b67f5 Pass host to runner_on_file_diff callback 12 years ago
Stoned Elipot e7957b6d58 Fix group_by: do not group a host for which a condition is false 12 years ago
Michael DeHaan 44e391fd8b Merge pull request #4255 from mcodd/legacy_vars_fix
Fix for legacy_playbook_variables (should fix issue #4254)
12 years ago
Michael DeHaan 65178290e7 Merge branch 'devel' of git://github.com/nextus/ansible into devel
Conflicts:
	lib/ansible/constants.py
12 years ago
Michael DeHaan ea73151757 Add automatic advice when folks hit one of two common but minor YAML gotchas, so they can be more easily correct them on their own. 12 years ago
Michael DeHaan 4987c73bb6 Proper check for raw as module options versus raw being in the string. 12 years ago
James Tanner 52aea868df Allow for updating host vars in add_host 12 years ago
James Cammarata d21714a37f Fix for network byte order issues in accelerate 12 years ago
James Cammarata 912e3a7b0b Merge branch 'accelerate_improvements' into devel
Conflicts:
	library/utilities/accelerate
12 years ago
James Cammarata fa80a17aa3 Make recv_data less greedy so it doesn't eat other packets 12 years ago
James Cammarata 8923a5b0d9 Drop default config value for accelerate timeout to 30 seconds 12 years ago
James Cammarata 12f6957596 Cleaning up some vvvv log messages in accelerate 12 years ago
James Cammarata 8c17711247 Removing accelerate_timeout as a playbook option
This will remain in ansible.cfg only.
12 years ago
James Cammarata d317103371 Added in an accelerate connection timeout setting 12 years ago
James Cammarata 59a5ce23d9 Adding an accelerate_timeout parameter for plays
This setting makes the timeout for each play configurable, rather than
hard-coding it at 300 seconds (now the default if left unspecified)

Fixes #4162
12 years ago
James Cammarata f9c87868ac Added keepalive packets to accelerate mode
Commands will now be started up in a separate task from the main
handler thread, so that it can be monitored for completeness while
sending a keepalive packet back to the controller to avoid a socket
receive timeout.
12 years ago
James Cammarata 8a3f8b757b Make sure yaml data loaded for role is valid before using it
Fixes #4322
12 years ago
James Cammarata bff47df5ff Fix issue with ast evaluation of strings 12 years ago
James Cammarata 5b205ae8bd Merge branch 'fixes/subprocess' of https://github.com/ferringb/ansible into ferringb-fixes/subprocess 12 years ago
James Cammarata d89ce6ac61 Merge branch 'patch-1' of https://github.com/ustun/ansible into ustun-patch-1 12 years ago
James Cammarata 12a21d94b7 Merge branch 'allow_types_in_ini' of https://github.com/bcoca/ansible into bcoca-allow_types_in_ini 12 years ago
jctanner 32a1dd422c Merge pull request #4269 from jphalip/issue-4256
In the script action: Get around a Python bug.
12 years ago
James Cammarata 7aad576f5f Minor change to add a space around role name/task delimiter 12 years ago
James Cammarata 1cc1e7058b Merge branch 'role_report_fix1' of https://github.com/bennojoy/ansible into bennojoy-role_report_fix1 12 years ago
James Cammarata 8ed343cc36 Merge branch 'jsmartin-hide_skipped_hosts' into devel 12 years ago
James Cammarata 6cd8aacc81 Merge branch 'hide_skipped_hosts' of https://github.com/jsmartin/ansible into jsmartin-hide_skipped_hosts 12 years ago
James Cammarata 52a42bf607 Add more verbose debugging options for accelerate 12 years ago
Michael DeHaan ac0a7d965a Merge pull request #4306 from sivel/3563-glob
Add fileglob Jinja2 filter. Fixes #3563
12 years ago
Matt Martz 535ce97067 Add fileglob Jinja2 filter. Fixes #3563 12 years ago
Brian Harring d0ad6c581b For defaults that are integers, enforce it for config supplied values.
If a user supplies a string in the config (rather than an int), the code
should fix that- or blow up immediately- rather than allowing that value to
work it's way down and break w/in the connection object; when that happens,
the actual error is opaque and requires pdb.set_trace() to run down.
12 years ago
Brian Harring 2174230315 USE subprocess.Popen API correctly.
When collecting stdout/stderr *and* feeding data into a Popen instance,
communicate() must be used to avoid a known deadlocking scenario
when data sizes cross PIPE_BUF (which can be as small as 512, although should
be much larger in practice on linux).
12 years ago
Ustun Ozgur 977b31249a Update cache check in find_plugin
I am not familiar with the internals, but this line looked suspicious.
12 years ago
Julien Phalip 44aeea7afc In the script action: Get around a bug in that's been fixed in Python 2.7 but not Python 2.6.
See: http://bugs.python.org/issue6988
Fixes #4256.
12 years ago
James Cammarata 039d4c95d9 Merge pull request #4221 from ashorin/unicode-md5
Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in pos...
12 years ago
Brian Coca 771435deb4 now ini vars are typed
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
James Martin d5f20e6b21 Optionally display Skipping [host] messages. 12 years ago
bennojoy 482cb72128 role report fix 12 years ago
Matt Coddington 7f7116de3b commit 9db4f7a made a change that also needed to include this to retain correct legacy_playbook_variables behavior 12 years ago
Preston Marshall 3ee7b177e8 Allow storing input from user in a pause prompt 12 years ago
James Cammarata 1c97831288 Merge branch 'empty_inventory' of https://github.com/spil-jasper/ansible into spil-jasper-empty_inventory 12 years ago
James Cammarata 994dfb84fc Minor pep8 cleanup and CHANGELOG update for do-until 12 years ago
James Cammarata 202c4f5294 Merge branch 'do_until_14' of https://github.com/bennojoy/ansible into bennojoy-do_until_14 12 years ago
James Cammarata 478c400817 Minor pep8 cleanup in the new jail connection plugin 12 years ago
James Cammarata 0e0595bdb2 Merge branch 'jail' of https://github.com/mscherer/ansible into mscherer-jail 12 years ago
bennojoy 70a9a797fa Fix for accelerate when ansible_ssh_user is specified 12 years ago
Jasper Capel d4dec5f577 Allow creating empty inventory
Instantiating the Inventory class with host_list=None now results in an
empty inventory instead of an error.
12 years ago
nextus ca96d74572 #4227 in upstream repo 12 years ago
Andrey Shorin fd101dd2d6 Encode to utf-8 only when needed 12 years ago
Andrey Shorin 21f5bc4242 Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in position ...: ordinal not in range(128) 12 years ago
bennojoy 0e749611ac doc update and add attempts 12 years ago
bennojoy 21529de82e dountil feature commit 2 12 years ago
bennojoy 53e48b63a9 dountil feature commit 1 12 years ago
James Cammarata 2f39d37a97 Expand destination path in the fetch action
Fixes #4215
12 years ago
Michael DeHaan 319a0f9523 Merge pull request #4154 from mplonka/AIX_MD5
using AIX 'csum' command for generating MD5 checksums
12 years ago
Michael DeHaan 7f8126a6c9 Merge pull request #4168 from nigelm/md5_filter
Added md5 as a jinja filter - returns hex digest of input
12 years ago
Andrey Shorin cb4b964070 Allow for dynamic accelerate_port: and port: in plays 12 years ago
James Cammarata 1f674c4a50 Merge branch 'fix_selinux_debian' of https://github.com/mscherer/ansible into mscherer-fix_selinux_debian 12 years ago
Alek Storm 3569a2ffee Handle AnsibleUndefinedVariable's raised from lookup plugins like jinja2 UndefinedError's 12 years ago
James Cammarata 47b9cc6311 Merge branch 'meta-roles' of https://github.com/eggsby/ansible into eggsby-meta-roles
Conflicts:
	lib/ansible/playbook/play.py
12 years ago
James Cammarata 27e8675277 Make the role_name in the task its own field for use in the callback 12 years ago
James Cammarata 98cfcec5e2 Correct role name detection 12 years ago
James Cammarata 8dcf386def Don't set the role name on handlers as this breaks notifications 12 years ago
James Cammarata a5ee6ff1e5 Display parent role name of tasks in the name line
Fixes #4076
12 years ago
James Cammarata c840cbaad9 Merge branch 'fork_fixes' of https://github.com/akerl/ansible into akerl-fork_fixes 12 years ago
James Cammarata 69cfcf7ed0 Minor change to -vvvv mode to only show debugging info for ssh conns
Also added this feature to the CHANGELOG
12 years ago
James Cammarata d5b96abd80 Added support for -vvvv to enable ssh connection debugging
This patch also checks specifically for a return code of 255, which
indicates an unknown SSH error of some kind. When that happens, ansible
will now recommend running with -vvvv (if not enabled) or show the
output from 'ssh -vvv' (when it is enabled)
12 years ago
Nigel Metheringham f0cc2d6efe Added md5 as a jinja filter - returns hex digest of input 12 years ago
Timothy Appnel d8cd3d603e Straightened out the logic for delegate handling in synchronize action module 12 years ago
Timothy Appnel 61e726fe82 Fix to local delegate_to override and proper sudo handling from @smoothify 12 years ago
Timothy Appnel 32ae6fdd43 Return of sychronize module code for take 3 12 years ago
Thomas Omans 91a4ba2248 allowing a roles to do be made out of dependencies alone 12 years ago
James Cammarata 503f062521 Merge branch 'ferringb-fixes/configurable-ControlPath' into devel 12 years ago
Michael DeHaan 20708e31b1 Merge pull request #4133 from skyl/DIST_MODULE_PATH
DEFAULT_MODULE_PATH in setup.py
12 years ago
Marcin Płonka d0c78bdc83 using AIX 'csum' command for generating MD5 checksums 12 years ago
Brian Harring 5b1b831cc7 Make ssh's ControlPath configurable via ansible.cfg
This shouldn't generally be needed unless you're working in an environment
that uses rediculously long FQDNs; if the name is too long, you wind up
hitting unix domain socket filepath limits enforced by ssh.
12 years ago
Stephen Fromm 27b5c2e28c Fix how module_common handles selevel (issue #4142)
Two fixes:

* parameter name is selevel, not serange.
* Fix split on selinux context to limit to max of 4 since the selevel
  may contain ':' characters.  This was fixed in
  selinux_default_context() and selinux_context().
12 years ago
Skylar Saveland 50bd14faa9 use DEFAULT_MODULE_PATH in setup.py so that there is a chance to override with ANSIBLE_LIBRARY env variable 12 years ago
Les Aker 98bf473cb2 fixes for PTY handling 12 years ago
James Cammarata 458f71b53c Merge branch 'issue_4129_role_defaults_empty_yaml' into devel
Conflicts:
	lib/ansible/playbook/play.py
12 years ago
James Cammarata 091a90ee8b Allow includes to follow the standard format
Previously, includes had to receive variables via a special 'vars'
field. With this patch, the include syntax becomes a more natural
datastructure without special fields and is more akin to the way
role includes/dependencies work.

Tested with the following playbook:
---
- hosts: localhost
  connection: local
  tasks:
  - { include: inc1.yml, a: 1 }
  - include: inc2.yml
    b: 2
  - include: inc3.yml
    with_items:
    - x
    - y
    - z

Fixes #3481
12 years ago
Skylar Saveland 8dc31f3093 ANSIBLE_DIST_MODULE_PATH environment variable 12 years ago
James Cammarata c5bb1394b9 Check to make sure default_vars in the datastructure isn't empty
Fixes #4129
12 years ago
James Cammarata 5b15010099 Merge branch 'issue_3312_role_links' into devel 12 years ago
James Cammarata 3b801dec72 Merge branch 'failed_when' of https://github.com/hnakamur/ansible into hnakamur-failed_when 12 years ago
James Cammarata fcc18fa105 Merge branch 'subelements' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-subelements 12 years ago
James Cammarata aac3090909 Merge branch 'play_remote_user' of https://github.com/bcoca/ansible into bcoca-play_remote_user 12 years ago
James Cammarata 3848e02959 Merge branch 'issue4022' of https://github.com/sfromm/ansible into sfromm-issue4022
Conflicts:
	lib/ansible/runner/connection_plugins/accelerate.py
12 years ago
James Cammarata d9cf1dfefb Merge branch 'fetch' of https://github.com/bpennypacker/ansible into bpennypacker-fetch 12 years ago
James Cammarata f4b3defcbf Set sudo in accelerate commands correctly
Fixes #4111
12 years ago
Michael DeHaan 5c0dd958e5 Merge pull request #4028 from willthames/lineinfile_userdir
Expand tilde in paths in file module
12 years ago
Michael Scherer 5e1828a524 add jail module, based on lxc and chroot connexion plugin 12 years ago
Michael DeHaan 1f0eb32846 Update 1.4 specfile -- no need for node fireball package, release dates 12 years ago
James Cammarata 35d138a0d6 When checking conditionals, don't dereference when the variable contains dashes
Fixes #4104
12 years ago
James Cammarata d0236f6ada Check for link in path in utils.path_dwim_relative()
This allows an included path to be relative to a directory, if the
basedir of the original path is a symlink. In that case, the path
is normalized and the file is searched for in the normalized path.

Fixes #3312
12 years ago
Marcin Kałuża 6786773797 filter out qoutes since they cause random errors 12 years ago
Marcin Kałuża aab445a28f add 'chars' parameter to password plugin to allow custom character set
It accepts comma separated list of names that are
either string module attributes (ascii_letters,digits, etc)
or are used literally

To enter comma use two commas ',,' somewhere - preferably at the end
Qoutes and double qoutes are not supported
12 years ago
Hiroaki Nakamura 2357194b39 Add failed_when module variable.
Implementation note: Ternery operator trick for python prior to 2.5 is used.
(test and [when_true_value] or [when_false_value])[0]
http://stackoverflow.com/questions/394809/ternary-conditional-operator-in-python#comment1466794_394887
12 years ago
Serge van Ginderachter 4f9af7efad subelements lookup plugin 12 years ago
James Cammarata 75a9357e5e Fixing role variable precedence for top-level roles
Fixes #4026
Fixes #3989
12 years ago
James Cammarata 294451d002 Correctly handle variable issues when evaluating jinja2 when statements
Fixes #4025
12 years ago
James Cammarata bcc2a4b513 Minor fix so the any_errors_fatal value is checked properly 12 years ago
James Cammarata 4025695c00 Merge branch 'devel' of https://github.com/kavink/ansible into kavink-devel 12 years ago
Michael Scherer dfb9d8c2fb Add a plugin that permit to use ansible for lxc system, using libvirt
Using -c lxc and the domain name as hostname, this permit to manage a whole
range of container, provided they are managed and created by libvirtd.
12 years ago
Brian Coca d47c48e30a Added remote_user to plays
Still compatible with user: but deprecating it so we can have
a matching remote_user: in tasks, cannot be user: because of the
module of the same name. #3932

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Kavin Kankeshwar c24f6f438b Avoid ugly formatting due to a long if statement 12 years ago
James Cammarata 6e9fa5019f Reverting HostVars change from a mapping back to a dictionary 12 years ago
James Laska 546788a1b6 The required package for selinux is libselinux-python 12 years ago
James Cammarata 4e9dee6093 Use StringIO to feed md5 calculation to prevent unicode issues
Fixes #4014
12 years ago
James Cammarata 2a47f72139 Merge pull request #4049 from mscherer/fix_no_kerberos
Fix no kerberos
12 years ago
Michael Scherer f489702973 Also add back gssapi-keyex
While this is not currently implemented in openssh as far as I know,
there is patch floating around on the web and this may land one day
upstream.
12 years ago
Keiichi Mori 17c39b94a3 support GSSAPIAuth back
GSSAPIAuthentication has not been supported
due to PreferredAuthentications trick ( 2bdba17a85 )
12 years ago
James Cammarata ae9e38daf8 Change hostvars to a mutable mapping to more closely resemble a dict
Fixes #4030
12 years ago
James Cammarata 2cbf28385a Move check for accelerate mode deeper to account for ansible_connection
Fixes #4045
12 years ago
James Cammarata 20b0dc4abd Check for an empty executable passed into the accelerate plugin
This was breaking at least the script module, so it would seem best
to check for it and set it to the default executable value
12 years ago
James Cammarata 4bf506f683 Always run the accelerate module as the user specified in the play
Currently, the accelerate daemon will be run as the sudo_user if
specified, which is incorrect.
12 years ago
Scott Sturdivant 68bffb1233 Don't force accelerate connection for local actions. 12 years ago
James Cammarata f6e1bdabea Ensure ports are set correctly in accelerate module 12 years ago
willthames fe70ed94e3 Expand tilde in paths in file module 12 years ago
guersam 64db327411 Fix: raise correct error in accelerate mode 12 years ago
kavink a075ec9831 Bug fix for a crash, when any_errors_fatal is true
Reported by Rumen:

TASK: [fail FAIL] *************************************************************
skipping: [hostname.com]
failed: [hostname.com] => {"failed": true}
msg: Failed as requested from task
Traceback (most recent call last):
  File "/usr/local/bin/ansible-playbook", line 268, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/bin/ansible-playbook", line 208, in main
    pb.run()
  File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 262, in run
    if not self._run_play(play):
  File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 580, in _run_play
    if (hosts_count - len(host_list)) > int((play.max_fail_pct)/100.0 * hosts_count):
TypeError: object of type 'NoneType' has no len()
12 years ago
Stephen Fromm d704b55860 Support using paramiko to set up accelerate connection
Adds original_transport attribute to Runner to track what the original
transport was before it is changed to 'accelerate'.
If using paramiko in original_transport, uses ParamikoConnection.  If
not, falls back to SSHConnection like before.
12 years ago
James Cammarata fff497a1ae Make sure the accelerated port is set to a sane value 12 years ago
James Cammarata cc21e5c90c Adding hostvars to injected variables in accelerate ssh runner
Also some minor cleanup of some fb* variables and functions, which
were remnants of the old fireball2 name

Fixes #4021
12 years ago
James Cammarata 7b13b1e03e Minor fix to dependency dupe patch 12 years ago
James Cammarata 16258edd7a Merge branch 'devel-duplicates2' of https://github.com/smoothify/ansible into smoothify-devel-duplicates2 12 years ago
James Cammarata a202adcae1 Merge branch 'doublecallback' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-doublecallback 12 years ago
smoothify 5337397abd Second Attempt: Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file. 12 years ago
James Cammarata c0fecf87d1 Increase default socket timeout to 5 minutes 12 years ago
smoothify 0411ea2867 Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file. 12 years ago
James Cammarata 2e49d2003d Fix bug where accelerate keyword was not checked for boolean value
The play was just checking for the presence of the keyword in the
YAML datastructure, and not the value of the field, so doing something
like variable substitution was always causing the play to be accelerated
12 years ago
James Cammarata 2696135b3b Display error during launch of accelerated daemon
* also minor tweak to the # of retries in the connection attempt

Fixes #4012
12 years ago
James Cammarata 7c1c9b3d10 Fix message in utils related to python-keyczar and fireball/acc mode 12 years ago
James Cammarata 53c2f4c1bb Fix race condition on creating the temp directory for ControlPersist
Fixes #3943
12 years ago
James Cammarata d05c61d1f0 Merge branch 'devel' into fireball2
Conflicts:
	lib/ansible/playbook/__init__.py
	lib/ansible/playbook/play.py
12 years ago
James Cammarata 50f54f6bda Making variable names more descriptive for the default variables work 12 years ago
James Cammarata 02b7b79d7e Re-adding capability of tasks to see a unique view of their own defaults 12 years ago
Stoned Elipot 6cbd94dfae Avoid duplicates of the 'all' group when using inventory script.
Do not recreate an 'all' group when it is in the inventory script's
output, but use the one created upfront.
12 years ago
James Cammarata 266d2008d8 Reverting the role default variables change
Loading the default variables in _build_role_dependencies() lead to
a side-effect where those variables were over-riding inventory variables.
12 years ago
James Cammarata 47a89a57fa Fixing bug in playbook use of default variables in roles 12 years ago
James Cammarata e0df5b5888 A couple more tweaks to role default variables/dependencies
* Default variables are now fed directly into roles, just like the
  other variables, so that roles see their unique values rather
  than those set at the global level.

* Role dependency duplicates are now determined by checking the params used
  when specifying them as dependencies rather than just on the name of the
  role. For example, the following would be included twice without having
  to specify "allow_duplicates: true":

  dependencies:
  - { role: foo, x: 1 }
  - { role: foo, x: 2 }
12 years ago
James Cammarata d69d5c294f Renaming fireball2 as 'accelerate' and removing old references 12 years ago
James Cammarata 736c8b19d3 Added ability to limit role dependencies to just one inclusion 12 years ago
James Cammarata 6f6efa268b Merge branch 'smoothify-defaults' into devel 12 years ago
James Cammarata 25e3eed519 Fixing a bug in variable precedence for roles and dependencies 12 years ago
James Cammarata 637d3070dc Allow default variables to be overridden by inventory variables 12 years ago
James Cammarata 9806f89a04 Revert "Construct the multiprocessing manager only once."
This reverts commit 1d13ec2da3.
12 years ago
James Cammarata 7d3ae9fc75 Fixing a few bugs related to fireball2
* ssh port not being picked up, always uses default of 22
* forgot to 'import time' in the fireball2 connection plugin
12 years ago
James Cammarata f66683863e Merge branch 'defaults' of https://github.com/smoothify/ansible into smoothify-defaults 12 years ago
James Cammarata faf82bf841 Fix bug with fetch when using sudo: true
Fixes #3111
12 years ago
James Cammarata af1dd7075f Adding chunked file transfers to fireball2 12 years ago
James Cammarata 959138d00d Added accelerate_port to plays, and made it configurable 12 years ago
James Cammarata 167f185092 Initial support for running gather_facts through fireball2 12 years ago
James Cammarata b45342923c Initial support for sudoable commands over fireball2
Caveats:
* requiretty must be disabled in the sudoers config
* asking for a password doesn't work yet, so any sudoers users must
  be configured with NOPASSWD
* if not starting the daemon as root, the user running the daemon
  must have sudoers entries to allow them to run the command as the
  target sudo_user
12 years ago
James Cammarata 4b552457e7 Bail out correctly if socket.recv gets nothing (indicating a closed socket) 12 years ago
James Cammarata 86f01965cd Fireball2 module will now launch in a proper tmp path 12 years ago
James Cammarata 521e14a3ad Fireball2 mode working! 12 years ago
James Cammarata acc5d09351 Initial commit for the "fireball2" connection plugin
Still needs:
* chunked file transfer/receive
* should probably move all send/recv operations to separate
  functions to reduce code duplication
* initial connection setup over ssh? or do we handle that in runner?
12 years ago
James Cammarata fd2aabaa27 Initial work for the AES cipher class
This is based somewhat loosely on how Keyczar does things. Their
implementation does things in a much more generic way to allow for more
variance in how the cipher is created, but since we're only using one
key type most of our values are hard-coded. They also add a header to
their messages, which I am not doing (don't see the need for it
currently).
12 years ago
Bruce Pennypacker cf6a76c814 changed ignore_md5_mismatch to validate_md5 12 years ago
Bruce Pennypacker 41c474d129 added optional ignore_md5_mismatch parameter 12 years ago
Michael DeHaan cce7f485b8 Merge pull request #3946 from wincent/spelling-fix
Fix minor typo in playbook error message
12 years ago
Wincent Colaiuta fc4307a9c4 Fix minor typo in playbook error message 12 years ago
James Cammarata 88966e6558 Use AnsibleError instead of exit for errors in utils 12 years ago
Jocelyn Jaubert 4cee6a5435 Add option remote_user to task level, to specify the ssh login user 13 years ago
James Cammarata 8262f7bfac Merge branch 'with_items_and_complex_args' of https://github.com/lberruti/ansible into lberruti-with_items_and_complex_args 13 years ago
James Cammarata e11bb0cad4 Merge branch 'plugins-work' of https://github.com/ferringb/ansible into ferringb-plugins-work 13 years ago
James Cammarata 462cd4f728 Merge branch 'pulls/fix-hostvars-inconsistancy' of https://github.com/ferringb/ansible into ferringb-pulls/fix-hostvars-inconsistancy 13 years ago
James Cammarata e6ad3b7792 Merge pull request #3895 from mscherer/fix_option_new_ssh
make sure ssh do not ask password
13 years ago
James Cammarata 157b697a83 Merge branch 'always_run-6' of https://github.com/stoned/ansible into stoned-always_run-6 13 years ago
James Cammarata af4f0bd008 Fix for "argument must be an int, or have a fileno() method" error
The issue was that, when forks == 1, the _executor() function was
being called with None for the value of new_stdin.

Fixes #3841, #3902
13 years ago
James Cammarata 978af89175 Disallow running async tasks with lookup plugins
Fixes #2897
13 years ago
James Cammarata ed3e4aff84 Place retry file in the user's home dir instead of /var/lib/tmp
Addresses CVE-2013-4260: predictable filename used for failed results
in world writable directory.
13 years ago
James Cammarata 6bf5d19506 SSH connection plugin creates ControlPersist socket files in a secure directory
Files were being created in /tmp, but will now be created in $HOME/.ansible/cp/
Addresses CVE-2013-4259: ansible uses a socket with predictable filename in /tmp
13 years ago
Stoned Elipot f0743fc32a Introduce the 'always_run' task clause.
The 'always_run' task clause allows one to execute a task even in
check mode.

While here implement Runner.noop_on_check() to check if a runner
really should execute its task, with respect to check mode option
and 'always_run' clause.

Also add the optional 'jinja2' argument to check_conditional() :
it allows to give this function a jinja2 expression without exposing
the 'jinja2_compare' implementation mechanism.
13 years ago
Michael Scherer 2bdba17a85 make sure ssh do not ask password
For some reason, ssh seems to ask for password even when
PasswordAuthentication is set to no, adding PreferredAuthentications
with the 2 options removed do the trick.
13 years ago
Kavin Kankeshwar 7ac3bbc198 resolved #3609 Change max_fail_pct to max_fail_percentage as recommended 13 years ago
Kavin Kankeshwar 3f247fcbe3 fixes ansible/ansible#3609 Add max_fail_pct to playbook parameter, to complement serial option, So if total number of failures execeed max_fail_pct * total number of hosts, do not go to the next serial batch 13 years ago
smoothify 494043947d Add support for role defaults. These are variables on a per role basis with lowest precedence. 13 years ago
Petr Svoboda e3adfbf5f8 Add tests for undefined variable detection
Tests `test_playbook_undefined_varsX_fail` check if ansible detects
undefined variables when `error_on_undefined_vars` is enabled. These
tests fail without "Improve behavior with error_on_undefined_vars
enabled" patch.

Tests `test_playbook_undefined_varsX_ignore` check if ansible ignores
undefined variables when `error_on_undefined_vars` is disabled.

Also modify PlayBook._run_task_internal() so error_on_undefined_vars is
testable.
13 years ago
Petr Svoboda fff4f1da33 Improve behavior with error_on_undefined_vars enabled
Pass fail_on_undefined flag to recursive calls to `template` function,
so more undefined variables are detected.

Works only for Jinja style variables. Undefined legacy variables are
never detected.
13 years ago
Brian Harring 31061213fa Fix inconsistency in hostvars access.
Previously, hostvars would only expose a keys() list of hosts that had
been seen yet- however you could explicitly access the host if you knew
the name, and get the content that way.  This precludes template code
from being able to safely access information about other hosts if any
limiters/tags were in use.

Additionally, the object was inconsistent for hostvars['myhost'] access
and [x[1] for x in hostvars.items() if x[0] == 'myhost'] access; this is
due to the original derivation from the dict object.  .items() would be
handled by dict.items(), using the passed in setup_cache values without
using the actual lookup content.

This patch rebases the class implementation to a py2.6 dictmixin, fixing
those issues and restoring behaviour to match what the docs claim.
13 years ago
Brian Harring 902183ac0e Enforce alphanumeric ordering for plugins grabbed via glob.
If this isn't done, it's left to directory ordering which can result
in indeterminent behaviour.
13 years ago
James Cammarata 39628d012d Minor fix to ipv6 detection for inventory with -i
For link-local addresses, it is sometimes necessary to append the
interface to use for the ipv6 address. This patch extends the ipv6
regex to allow for '%ifnameX' at the end.

See https://bugzilla.redhat.com/show_bug.cgi?id=136852 for more info
13 years ago
Michael Scherer 3aac187387 fix ssh connection plugin to work with ipv6 address
Due to various inconsistencies of ssh and sftp regarding ipv6 and
ipv4 handling, some special arguments must be passed, and the
ipv6 must be passed in a specific format.
13 years ago
Michael Scherer c9d28e10ad add support for using a ipv6 in -i
testing with a ipv6 :
  ansible -u misc -i  '[2002::c23e]:22,' '*' -m ping

fail due to parsing of ':' as a separator of port/ip with ipv4.
This commit add support for properly parsing 2002::c23 and the
bracket notation [2002::ce]:2222
13 years ago
Matt Saunders 9fd1b174f5 Fixed tiny bug with _meta handling in external inventory scripts 13 years ago
James Cammarata 5847720746 Fixing a small bug with the new role dependency feature
The block that added the original list of roles was indented too far,
and was only being reached if a role had dependencies. This resulted
in roles without dependencies from being added to the list of roles.

Credit goes to looped for reporting and diagnosing the issue.
13 years ago
Michael DeHaan 42648e2f0a Merge branch 'role_dependencies' of git://github.com/jimi1283/ansible into jimi1283-role_dependencies 13 years ago
Michael DeHaan dacd311474 Removing synchronize momentarily as it looks like this won't make 1.3 dates 13 years ago
James Cammarata d8a7a2d1b2 Adding evaluation of role vars as the dep tree is built
This allows variables to be inserted into the role scope specifically
while also being inserted into the global scope.
13 years ago
James Cammarata e12b99dba6 Small cleanup, no need to call _get_role_path a second time 13 years ago
James Cammarata 9a401e73a6 Adding support for role dependencies.
Fixes #3686

Dependencies are enabled by adding a new directory/file named
meta/main.yml to the role. The format of the dependencies are:

dependencies:
- { role: foo, x: 1, y: 2 }
- { role: bar, x: 3, y: 4 }
...

Dependencies inherit variables as they are seen at the time of the
dependency inclusion. For example, if foo(x=1, y=2) has a dependency
on bar(x=3,z=4), then bar will have variables (x=3,y=2,z=4).

Different roles can have dependencies on the same role, and this
variable inheritence allows for the reuse of generic roles quite easily.
For example:

Role 'car' has the following dependencies:
dependencies:
  - { role: wheel, n: 1 }
  - { role: wheel, n: 2 }
  - { role: wheel, n: 3 }
  - { role: wheel, n: 4 }

Role 'wheel' has the following dependencies:
dependencies:
- { role: tire }
- { role: brake }

The role 'car' is then used as follows:
- { role: car, type: honda }

And tasks/main.yml in each role simply contains the following:
- name: {{ type }} whatever {{ n }}
  command: echo ''

TASK: [honda tire 1]
TASK: [honda brake 1]
TASK: [honda wheel 1]
TASK: [honda tire 2]
TASK: [honda brake 2]
TASK: [honda wheel 2]
TASK: [honda tire 3]
TASK: [honda brake 3]
TASK: [honda wheel 3]
TASK: [honda tire 4]
TASK: [honda brake 4]
TASK: [honda wheel 4]
TASK: [I'm a honda]  <- (this is in roles/car/tasks/main.yml)
13 years ago
James Cammarata ad595eadea Enable error_on_undefined_vars by default 13 years ago
Michael Scherer 12bf9a8b69 add a way for callback to disable itself
The idea is that some plugin would not be called in some
specific case, and the callback should decide by itself.

Having a way to globally disable it is much cleaner than
disabling every method one by one on the plugin side.

My use case is for fedora-infrastructure that cannot be run
from git checkout since it try to connect to the message bus,
but another case would be to bootstrap infrastructure, or to
run the code on a test servers without having all the callback
infrastructure setup.
13 years ago
Luca Berruti eee278e02b fix 13 years ago
Luca Berruti 5048218ab5 Fix: with_items and complex_args 13 years ago
Serge van Ginderachter 173586b871 Ensure plugin_loader.all() only loads one instance
by ensuring all basedirs, plugin paths and extra
paths are handled as absolute paths and are checked
to not add any doubles.

This fixes the corner case where e.g. the user has
an additional plugin path configured to a dir
relative to his playbooks or inventory location,
which also matches the  _plugin subdir relative to
one of the basedirs in the play.

For most plugins this doesn't show as an obvious issue
except for callback_plugins, which might fire more
than once. Other plugins (inventory and template
plugins) might unnecessarily be ran twice.

e.g. ansible.cfg has
callback_plugins   = ./plays/callback_plugins
and plays/ contains a playbook file:
.
├── ansible.cfg
├── inventory
└── plays
    ├── callback_plugins
    │   └── timestamp.py
    └── site.yml

modified:   lib/ansible/utils/plugins.py
13 years ago
Michael DeHaan bc02e20503 Merge branch 'rsynctake2' into devel
Conflicts:
	CHANGELOG.md
13 years ago
Michael DeHaan 17aa0d12de Merge pull request #3814 from ftao/inventory_dir_abs
fix inventory.basedir is not absolute path when hostfile is startswith "./"
13 years ago
Abhijit Menon-Sen 1a90d01ba9 Fix some typos discovered during casual reading 13 years ago
ftao 51a180b150 fix inventory.basedir is not absolute path when hostfile is startswith "./" 13 years ago
Michael DeHaan f8c97d6e79 Style/docs cleanup, and also improve an error message. 13 years ago
Michael DeHaan aeb8649da5 Merge branch 'ansible-rsync-take2' of git://github.com/tima/ansible into rsynctake2 13 years ago
Michael DeHaan 4d1f447908 Merge pull request #3650 from bcoca/forking_optimizations
forking least possible
13 years ago
Michael DeHaan baffa8df72 These fields are booleans. 13 years ago
Michael DeHaan 633abca916 Merge branch 'nocolor' of git://github.com/amenonsen/ansible into devel 13 years ago
Michael DeHaan ee11d69697 Merge branch 'better_ini_errors2' of git://github.com/bcoca/ansible into devel 13 years ago
Michael Vogt 89bc43cab0 support i18n on sudo failure 13 years ago
Serge van Ginderachter 9991a530ab fix an encoding bug in copy content = lookup plugin
closes #3518
13 years ago
Michael DeHaan 66b29b6813 Merge branch 'feature/gh-3789-inventory-file' of https://github.com/resmo/ansible into devel 13 years ago
Michael DeHaan 1d13ec2da3 Construct the multiprocessing manager only once. 13 years ago
René Moser e8272e365d
implemented 'inventory_file' variable. Closes GH-3789. 13 years ago
Timothy Appnel 2288a11b6a Implemented setup method in rsync action module. 13 years ago
Timothy Appnel 4a9635e04e Straighten out local-remote-delegate logic in rsync action module. Force set delegate to local if one is not defined. 13 years ago
Timothy Appnel adbca9d251 Fixed identity key logic. 13 years ago
Timothy Appnel 9f170f579a Introduced ansible-rsync to core. 13 years ago
James Cammarata ceff3b6ba3 Minor modification to set_fact with_items patch
Previous patch was reverted due to the fact that there was an issue
with the results not always being a dictionary (they're sometimes
a unicode string, ie. when the with_items is used with yum). This
minor change corrects that by checking for a dict object.
13 years ago