Commit Graph

6120 Commits (50001f15c0825ee3e06eca3f9a383455d62d3230)

Author SHA1 Message Date
Brian Coca cd0812a187 adhoc now respects limit when listing hosts
also removed cruft about localhost as if used it is specified inline
fixes #13848
9 years ago
Brian Coca 864c67cec5 ensure stdout callback alwasy is loaded first
it is now called for every event prior to any other callbacks
fixes #14114
9 years ago
Brian Coca 7fe91e1848 better error when host inventory script isnt dict 9 years ago
James Cammarata 0c250f2b07 Use templated handler name during callback
Fixes #14082
9 years ago
nitzmahone a516f883ac convert winrm put_file script template to Unicode string literal
Fixes traceback on homedirs with non-ascii chars
9 years ago
Brian Coca 95f7aa2b53 corrected submodule ref 9 years ago
James Cammarata da4a9d6da0 Fix bug with any_errors_fatal where task was not available 9 years ago
Alexey Shabalin d18cc79873 add detect Altlinux distributive 9 years ago
James Cammarata 2b3cd2577a Disallow setting state on template tasks
Fixes #14056
9 years ago
James Cammarata 50bb0d08f1 Template the run_once value in the linear strategy as we use it there
This is pre-post_validation, so we have to template it on the fly
as we use it to determine if we bypass the host loop.

Fixes #11876
9 years ago
James Cammarata 391420d88f Re-add cache clearing call to Inventory init
This prevents a bug where the existing cache outside of the class
is not cleared when creating a new Inventory object. This only really
affects people using the API directly right now, but wanted to fix it
to prevent weird errors from popping up.
9 years ago
James Cammarata 4627b3efbb Standardize removal of BECOME-SUCCESS method and use it for async too
Fixes #13965
Fixes #13971
9 years ago
Selivanov Pavel 7d8794daa6 plugins/strategy: added significant details to parser error message.
See discussion at
https://github.com/ansible/ansible/issues/13753
9 years ago
James Cammarata 2021362386 Fix incorrect handling of any_errors_fatal in the linear strategy
Instead of bombing out of the strategy, we now properly mark hosts failed
so that the play iterator can handle block rescue/always properly.

Fixes #14024
9 years ago
James Cammarata bb564075b5 Forward conditionals onto included plays when conditional eval errors
When using a playbook-level include, we now catch any errors raised during
the conditional evaluation step and set a flag to indicate we need to pass
those conditionals on to the included play (most likely because they contain
inventory variables for evaluation).

Fixes #14003
9 years ago
James Cammarata 09b26b6373 Don't assign both parent blocks and task includes to blocks
This causes problems when fetching parent attributes, as the include
was being skipped because the parent block would fetch the attribute
from the parent play first.

Fixes #13872
9 years ago
Brian Coca 8647fdc7f2 go back to defaulting wrapping commands in shell
this was taken out in an effort to default to the user's shell but creates issues as this is not known ahead of time
and its painful to set executable and shell_type for all servers, it should only be needed for those that restrict the user
to specific shells and when /bin/sh is not available. raw and command may still bypass this by explicitly passing None.
fixes #13882

still conditional
9 years ago
James Cammarata 7fe0bfd4f9 Revert "Properly look for parent become attribute"
This reverts commit 1b46a422aa.
9 years ago
James Cammarata 2b5caa23fb Properly look for parent become attribute
Corrects inheritence of the boolean value, which needs some special
consideration from other (string/int) values.

Fixes #13872
9 years ago
James Cammarata 0d2a9d3f53 Relocate use of ERROR to display class, to avoid doubling up 9 years ago
James Cammarata 34e3a8e6cb Catch INI section parsing misses and raise an appropriate error
Fixes #13917
9 years ago
James Cammarata 1fc35117d3 Fix role hashing failure/traceback when params contain lists
Fixes #13857
9 years ago
James Cammarata fb81447581 Don't clear start at task flag until all hosts are advanced
Clearing the flag after the first host was advanced caused all other
hosts to not advance at all.

Fixes #13864
9 years ago
James Cammarata 2dfcb218dc Fix with loop + delegate issues
* Don't re-use the existing connection if the remote_addr field of
  the play context has changed
* When overriding variables in PlayContext (from task/variables),
  don't set the same attribute based on a different variable name
  if we had already previously set it from another variable name

Fixes #13880
9 years ago
James Cammarata 44ab6db535 Fix any_errors_fatal incorrect implementation in 2.0
Also adds that flag to blocks.

Fixes #13744
9 years ago
Toshio Kuratomi d9f03cf014 Update submodule refs to pull in doc fixes 9 years ago
Tobias Wolf c5e46efbd9 Avoid recursively checking JSON inventory for Unicode
by moving to en-bloc unicode conversion to act on scripts stdout

Both python-json and simplejson always return unicode strings when using
their loads() method on unicode strings. This is true at least since
2009. This makes checking each substring unnecessary, because we do not
need to recursively check the strings contained in the inventory dict
later one-by-one

This commit makes parsing of large dynamic inventory at least 2 seconds
faster.

cf: https://github.com/towolf/ansible-large-inventory-testcase
9 years ago
Brian Coca 92579eb48f avoid shredding empty files, also x/0
also cleaned up unused import and exception var
9 years ago
Brian Coca d56e2fb80e corrected host/group match in inventory_hostnames
now the lookup works when using ! and & operators
fixes #13997
9 years ago
Toshio Kuratomi 1f930f098f Update core submodule to bring in yum fix 9 years ago
Toshio Kuratomi 63404821da rework run_command's env setting to not change os.environ for the rest of the module.
New param to run_command to modify the environment for just this invocation.
Documentation and comment adjustments.
9 years ago
Brian Coca cf75521bc8 updated submodule refs 9 years ago
Toshio Kuratomi 089f17bfc8 Don't tracback trying to retore settings
Can occur if we exit the timeout before the settings were changed
9 years ago
Toshio Kuratomi 27bf701260 Set decoding of path to unicode to raise an exception if non-utf8
Letting it pass would just cause an error later on (no such file found)
so it's better to catch it here and know that we have users dealing with
non-utf8 pathnames than to have to track it down from later on.
9 years ago
Toshio Kuratomi 299e42bc28 Make all parts of messages and pathnames into unicode so that we don't get UnicodeError tracebacks.
Note that the fix for display normalizing to unicode is correct but the
fix for pathnames is probably not.  Changing pathnames to unicode type
means that we will handle utf8 pathnames fine but pathnames can be any
sequence of bytes that do not contain null.  We do not handle sequences
of bytes that are not valid utf8 here.  To do that we need to revamp the
handling of basedir and paths to transform to bytes instead of unicode.
Didn't want to do that in 2.0.x as it will potentially introduce other
bugs as we find all the places that we combine basedir with other path
elements.  Since no one has raised that as an issue thus far so it's not
something we need to handle yet.  But it's something to keep in mind for
the future.

To test utf8 handling, create a utf8 directory and run a playbook from
within there.

To test non-utf8 handling (currently doesn't work as stated above), create
a directory with non-utf8 chars an run a playbook from there.  In bash,
create that directory like this: mkdir $'\377'

Fixes #13937
9 years ago
Brian Coca 2ec31c2c79 fixed exception handling to be 2.4 compatible
previous 'fix' broke on 2.4
9 years ago
Brian Coca 93781e0b05 be consistent about conversion to_str 9 years ago
Brian Coca edff4a9219 updated submodule refs 9 years ago
Toshio Kuratomi 69b8a48ed1 Turn results that come from traceback messages into unicode, not str.
Fixes #13964
Fixes #13967
9 years ago
Toshio Kuratomi 8f45660398 Update submodule refs 9 years ago
Toshio Kuratomi c8ffe94bf4 Fix proposed by @Yannig to fix become success detection when the output is multiline
See the Bug report for a specific error case with local connection,
sudo, and the raw module

Fixes #13728
9 years ago
Brian Coca c06b2e4622 correctly deals with non serializable type
combine_vars shoudl really be data types, but some just get in
in test, add dict to mock and avoid combine_vars using object
9 years ago
James Cammarata 1394cdf6b9 Fix set_fact + run_once to assign variables to all hosts in the list
Fixes #13921
9 years ago
James Cammarata 38a272b004 Allow module args as k=v pairs when using the module: option with local_action
This task format is valid in 1.x, but was broken in 2.x:
  - local_action:
     module: shell echo "hello world"
9 years ago
James Cammarata 97a5804a2c Minor cleanup when reassigning play context to reused connections
* Relocate the assignment of the host address to the remote_addr field
  in the play context, which was only done when the connection was created
  (it's now done after the post_validate() is called on the play context)
* Make the assignment of the play context to the connection an else, since
  it's not required if the connection is not reused
9 years ago
Karthik T 8436a88b5d Fixes #13763 Update connections _play_context on every iteration
If this isnt updated, the _connection is reused, and thus has an outdated _play_context
This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop
Refer to the issue #13763 for more debugging and details
9 years ago
Toshio Kuratomi 0bf20fab84 Fix erroneous fetch fail when fail_on_missing is set to False
Fixes #13832
9 years ago
Brian Coca 7d8afbd83d fix issue with add_hosts overwriting existing vars
fixes github.com/ansible/ansible-modules-core/issues/2799 and is alternative to #13841
9 years ago
nitzmahone f11e54bcff update core submodule ref 9 years ago
Toshio Kuratomi 46a3a6a03e Non-newstyle modules can't use pipelining
This is because we pass arguments to non-newstyle modules via an
external file.  If we pipeline, then the interpreter thinks it has to
run the arguments as the script instead of what is piped in via stdin.
9 years ago
Brian Coca e29ae99b50 overwrite/merge not remove prev inventory data 9 years ago
Yannig Perré 363b74e498 Allow Ansible to return error with unicode within it.
Fix for https://github.com/ansible/ansible/issues/13899
9 years ago
James Cammarata 17b60f4fbf Fix typo in 0b86aa6 9 years ago
James Cammarata b89f211ed4 Hack to work around callback API change for v2_playbook_on_start 9 years ago
James Cammarata cde5d8444d When setting fail state skip RESCUE/ALWAYS if cur_block doesn't have them
Fixes #13749
9 years ago
James Cammarata 6cf0386a52 Tweak how strategies evaluate failed hosts via the iterator and bug fixes
* Added additional methods to the iterator code to assess host failures
  while also taking into account the block rescue/always states
* Fixed bugs in the free strategy, where results were not always being
  processed after being collected
* Added some prettier printing to the state output from iterator

Fixes #13699
9 years ago
Brian Coca b09f756195 now combine vars errors dump vars
very hard to debug w/o knowing what vars were being merged at the time of the error
9 years ago
Brian Coca 27f9b9dc43 md5 now uses smaller salt
fixes #13891
9 years ago
Brian Coca 31a951c4f7 only send event if tqm exists
fixes #13843
9 years ago
Toshio Kuratomi fe55e87ab4 Prevent traceback.
https://github.com/ansible/ansible/issues/13743#issuecomment-171520585

In some circumstance, the file fails to open.  When that occurs, we
can't try to close it in the finally clause.  Using a context manager is
the cleanest way to change the code to account for that case.
9 years ago
Toshio Kuratomi be087575cc Fix circular import 9 years ago
Toshio Kuratomi 79931041e2 do_encrypt import needed to move as well
Fixes #13861
9 years ago
Toshio Kuratomi 832a739331 use integer division instead of floating point division.
Fixes #13855
9 years ago
nitzmahone 419bd389d8 move core submodule ref for win_msi fix 9 years ago
Brian Coca e497e2b5c0 made loading of galaxy data files lazy 9 years ago
Brian Coca e4b701c00a added module name to missing interpreter error
fixes #13816
9 years ago
Emil Lind 21c22a2416 Allow InventoryScript JSON with childgroups only
and without hosts and vars

Without this patch, the simplified syntax is triggered when a group
is defined like this:

    "platforms": {
        "children": [
            "cloudstack"
        ]
    }

Which results in a group 'platforms' with 1 host 'platforms'.

more details in https://github.com/ansible/ansible/issues/13655
9 years ago
Toshio Kuratomi 4e98cc351c Update submodule refs so that new integration tests will pass 9 years ago
Rene Moser 1cae019c79 cloudstack: fix case insensitivity
cloudstack: fix has_change reports changed for case insensitivity values
9 years ago
Eric Feliksik f3470c1062 cleaner implementation and random chunk length. 9 years ago
Eric Feliksik 21a4c1380c use unix shred if possible, otherwise fast custom impl; do not shred encrypted file 9 years ago
Eric Feliksik 4811504a6e add docs, remove unnecessary int() cast 9 years ago
Eric Feliksik 08fee9bfc5 add os.fsync() so that the shredding data (hopefully) hits the drive 9 years ago
Eric Feliksik 2cb2994371 shred ansible-vault tmp_file. Also when editor is interruped. 9 years ago
James Cammarata 2eb59bedcf New release v2.0.0.0-1 9 years ago
James Cammarata 14bf6b016c Split up comma-separated tags properly
Fixes #13795
9 years ago
Peter Sprygada 28fecc9ce1 bugfix in nxos shared module for including defaults 9 years ago
Peter Sprygada 2c647f18e5 bugfix in ios shared module for including defaults 9 years ago
Peter Sprygada 4e087bb14f bugfix in eos shared module for including defaults 9 years ago
Peter Sprygada 0681c2fd8f deletes nxapi from shared modules
The nxapi module has been superseded by the nxos shared module and is not longer needed. This commit removes (deletes) nxapi from module_utils.  All custom modules that have used nxapi should be using nxos instead.
9 years ago
Peter Sprygada 4a6235e320 adds network config file parser to shared modules
This commit adds a new shared module that parses network device configuration
files.  It is used to build modules that work with the various supported
network device operating systems
9 years ago
Peter Sprygada 94f13c7271 adds shared module shell for creating cli based transports
This commit add a new shared module shell that is used to build connections
to network devices that operate in a CLI environment.  This commit supercedes
the issh.py and cli.py commits and removes them from module_utils.
9 years ago
Peter Sprygada 93eb60161c initial add of openswitch shared module
This commit adds a new shared module openswitch for building modules that
work with OpenSwitch.  This shared module supports connectivity to
OpenSwitch devices over SSH, CLI or REST.  It also adds an openswitch
documentation fragment for use in modules
9 years ago
Peter Sprygada 2f1fc85002 adds shared module nxos for building cisco nxos modules
This commit refactors the nxapi into a new shared module nxos that supports
connectivity over both ssh (cli) and nxapi.  It supercedes the nxapi shared
module and removes it from module_utils.  This commit also adds a
documentation fragement supporting the nxos shared module
9 years ago
Peter Sprygada 91f35363a2 adds new iosxr shared module for developing modules that work with IOS XR devices
This commit adds a new shared module for working with Cisco IOS XR devices over
CLI (SSH).  It also provides a documentation fragement for the commmon arguments
provided by the iosxr module.
9 years ago
Peter Sprygada f76633b347 updates the ios shared module with new shell
This update refactor the ios shared module to use the new shell shared
library instead of issh and cli.  It also adds the ios documentation
fragment to be used when building ios based modules.
9 years ago
Peter Sprygada 9c9bfb962e initial add of eos shared module
This adds a shared module for communicating with Arista EOS devices over
SSH (cli) or JSON-RPC (eapi).  This modules replaces the eapi.py module
previously added to module_utils.  This commit includes a documentation
fragment that describes the eos common arguments
9 years ago
Brian Coca 0e27fa4540 restructure vars_prompt and fix regression
pushed it to use the existing propmpt from display and moved the vars prompt code there also for uniformity
changed vars_prompt to check extra vars vs the empty play.vars to restore 1.9 behaviour
sipmlified the code as it didn't need to check for syntax again (tqm is made none prior based on that)
fixes #13770
9 years ago
Matt Martz 3a972c9170 Restore ability for a module to specify WANT_JSON 9 years ago
James Cammarata 502ad88506 New release v2.0.0-0.9.rc4 9 years ago
Toshio Kuratomi 80f0380312 Fix typo 9 years ago
Toshio Kuratomi a8f160d2fd More fixes for unicode handling in the connection plugins.
Tested that ssh, docker, local, lxc-libvirt, chroot all work with the
updated unicode integration test.
9 years ago
Brian Coca 6be48dd14c Revert "Show version without supplying a dummy action"
This reverts commit 21775d7866.
Parsing before action will fail if one of the action specific options is used
As per issue #13743
9 years ago
James Cammarata fcd074d40f Merge branch 'ktosiek-fix-playbook-hanging' into stable-2.0 9 years ago
muffl0n 21775d7866 Show version without supplying a dummy action
fixes #12004
parsing x2 does not seem to break anything
9 years ago
Abhijit Menon-Sen ab536c8aa8 Strip string terms before templating
The earlier code did call terms.strip(), but ignored the return value
instead of passing that in to templar.template(). Clearly an oversight.
9 years ago
James Cammarata 93f37f5969 Don't drop noops from task counting code in linear strategy 9 years ago
Tomasz Kontusz ec3b7b7de8 linear strategy: don't look at tasks from the next block 9 years ago
Toshio Kuratomi 7a4914aa9b Fix exception catching to be importable on python3 9 years ago
Brian Coca 9ca5da82ff move hostvars.vars to vars
this fixes duplication under hostvars and exposes all vars in the vars dict
which makes dynamic reference possible on 'non hostvars'
9 years ago
Brian Coca 3d608ef9fa simplified diff handling in callback
no need for the copy or other complexity
9 years ago
Brian Coca c14e099dd7 now handles 'non file diffs'
this allows modules to pass back a 'diff' dict and it will still show using the file interface
9 years ago
Toshio Kuratomi 7e318e8398 Update extras submodule ref 9 years ago
Toshio Kuratomi add2e9cbd1 Fix problems with non-ascii values passed as part of the command to connection plugins
@drybjed discovered this with non-ascii environment variables and
command line arguments to script and raw module.
9 years ago
Abhijit Menon-Sen 9f93c9c84b Clean up debug logging around _low_level_execute_command
We were logging the command to be executed many times, which made debug
logs very hard to read. Now we do it only once.

Also makes the logged ssh command line cut-and-paste-able (the lack of
which has confused a number of people by now; the problem being that we
pass the command as a single argument to execve(), so it doesn't need an
extra level of quoting as it does when you try to run it by hand).
9 years ago
nitzmahone b4e0b5503c move core submodule pointer 9 years ago
Michael Scherer 5536ddd118 Do not set 'changed' to True when using group_by
Since group_by is not changing in any way to the remote
system, there is no change. This also make things more consistent
with the set_fact plugin.
9 years ago
Yannig Perré 021ed1aa8b Replace to_string by to_unicode.
Fix https://github.com/ansible/ansible/issues/13707
9 years ago
Brian Coca a703f3a6d2 added newer vars to 'reset_vars'
these vars pass back info to the task about the connection
moved to their own block at start at file for readability and
added the newer standard vars
9 years ago
Toshio Kuratomi 6142736946 Oops, core needs to stay on stable-2.0 9 years ago
Toshio Kuratomi 25fc4217df Update submodule refs 9 years ago
Toshio Kuratomi d71e8fb870 bigip changes as requested by bcoca and abadger:
* Fix to error if validate_cert is True and python doesn't support it.
* Only globally disable certificate checking if really needed.  Use
  bigip verify parameter if available instead.
* Remove public disable certificate function to make it less likely
  people will attempt to reuse that
9 years ago
Toshio Kuratomi ebd3b35d02 Update submodule refs 9 years ago
Toshio Kuratomi 82df9041e7 Going to do this in the connection plugin
Revert "Transform the command we pass to subprocess into a byte string in _low_level-exec_command"

This reverts commit 6d76cb40c5.
9 years ago
Toshio Kuratomi 9af054addf Going to do this in the connection plugin
Revert "Convert to bytes later so that make_become_command can jsut operate on text type."

This reverts commit bfc082fb07.
9 years ago
Brian Coca 7f29cb9dc6 corrected role path search order
the unfraking was matching roles in current dir as it always returns a full path,
pushed to the bottom as match of last resort
fixes #13645
9 years ago
Brian Coca 43331d8c31 better module error handling
* now module errors clearly state msg=MODULE FAILURE
* module's stdout and stderr go into module_stdout and module_stderr keys
which only appear during parsing failure
* invocation module_args are deleted from results provided by action
plugin as errors can keep us from overwriting and then disclosing info that
was meant to be kept hidden due to no_log
* fixed invocation module_args set by basic.py as it was creating different
keys as the invocation in action plugin base.
* results now merge
9 years ago
Brian Coca 579a2ff739 fix no_log disclosure when using aliases 9 years ago
Toshio Kuratomi bfc082fb07 Convert to bytes later so that make_become_command can jsut operate on text type.
Conflicts:
	lib/ansible/plugins/action/__init__.py
9 years ago
Monty Taylor 8216a659fa Also convert ints to bool for type=bool 9 years ago
James Cammarata a2120a3d63 Version bump for 2.0.0-0.8.rc3 9 years ago
Toshio Kuratomi 6d76cb40c5 Transform the command we pass to subprocess into a byte string in _low_level-exec_command 9 years ago
Toshio Kuratomi 6a0d2116b8 Delete new_inventory from stable-2.0 as it isn't used there.
leaving in devel for now as some people are planning on using it as
a starting place to update inventory in 2.1
9 years ago
Yannig Perré 1d18964daa Merge role params into variables separately from other variables
Fixes #13617
9 years ago
Brian Coca c605cd37f6 allow for non standard hostnames
* Changed parse_addresses to throw exceptions instead of passing None
* Switched callers to trap and pass through the original values.
* Added very verbose notice
* Look at deprecating this and possibly validate at plugin instead
fixes #13608
9 years ago
James Cammarata d512717cd2 Fix logic in PlayIterator when inserting tasks during rescue/always
Because the fail_state is potentially non-zero in these block sections,
the prior logic led to included tasks not being inserted at all.

Related issue: #13605
9 years ago
James Cammarata 9cfa2d7e28 Fixing bugs in conditional testing with until and some integration runner tweaks 9 years ago
Toshio Kuratomi ba0b4afb6b Revert "removed invocation info as it is not no_log aware"
This reverts commit 6127a8585e.
9 years ago
Toshio Kuratomi 76507bd567 Make return invocation information so that our sanitized copy will take precedence over what the executor knows. 9 years ago
Brian Coca 3840fb267c corrected service detection in docker versions
now if 1 == bash it falls back into tool detection
9 years ago
Toshio Kuratomi fbccfc8b61 Add package module to squash list 9 years ago
Toshio Kuratomi 2d179b376b Remove args from get_name() as we can't tell if any of the args are no_log 9 years ago
Toshio Kuratomi a0add9dda5 Comment to explain why we strip _ansible_notify specially 9 years ago
Brian Coca df08ba37fe removed invocation info as it is not no_log aware
This was added in 1.9 and 2.0 tried to copy, but since it cannot
obey no_log restrictions I commented it out. I did not remove as
it is still very useful for module invocation debugging.
9 years ago
Toshio Kuratomi 6dc42e376f update submodule refs 9 years ago
James Cammarata c9cf07e3b5 Fixing bugs with {changed,failed}_when and until with registered vars
* Saving of the registered variable was occuring after the tests for
  changed/failed_when.
* Each of the above fields and until were being post_validated too early,
  so variables which were not defined at that time were causing task
  failures.

Fixes #13591
9 years ago
Toshio Kuratomi 0a319a28f2 Update submodule for mysql_user fix 9 years ago
James Cammarata 17fe156016 Fixing a mistake from tweaking list stuff too much
Use the action only if the task name is not set
9 years ago
James Cammarata 5824a6d9bb Further tweaks to the output format of list tasks/tags 9 years ago
James Cammarata 59cac03d3b Make --list-tasks respect tags
Also makes the output closer to the appearance of v1

Fixes #13260
9 years ago
Toshio Kuratomi cc2e0c1e3d Update submodule to pull in mysqldump fix 9 years ago
Toshio Kuratomi 64737c80f9 Update submodule refs 9 years ago
James Cammarata 1f7ed5d8ee Fix handling of environment inheritence, and template each inherited env
Environments were not being templated individually, so a variable environment
value was causing the exception regarding dicts to be hit. Also, environments
as inherited were coming through with the tasks listed first, followed by the
parents, so they were being merged backwards. Reversing the list of environments
fixed this.
9 years ago
James Cammarata f41dd578b3 Make sure we're using the original host when processing include results
Also fixes a bug where we were passing an incorrect number of parameters to
_do_handler_run() when processing an include file in a handler task/block.

Fixes #13560
9 years ago
James Cammarata 407d76b8d5 Fixing template integration test for python 2.6 versions
No longer immediately fallback to to_json if simplejson is not installed
9 years ago
Toshio Kuratomi d2c43c421f Update core module ref for mysql_user fix 9 years ago
James Cammarata bf9f6ce09c All variables in complex args again
Also updates the CHANGELOG to note the slight change, where bare variables
in args are no longer allowed to be bare variables

Fixes #13518
9 years ago
Brian Coca 84a6b543a9 ensure additional args are a dict
They should already be templated before hitting this point?
otherwise the class needs the task variables passed into it.
relates to #13518 and  https://groups.google.com/forum/#!msg/ansible-project/esoBcphHwHs/Ghgi_M-MCQAJ
9 years ago
chouseknecht abec9331d8 Fixed documentation typos and bits that needed clarification. Fixed missing spaces in VALID_ACTIONS. 9 years ago
chouseknecht 1e605d727c Define and handle ignore_certs correctly. Preserve search term order. Tweak to Galaxy docsite. 9 years ago