Commit Graph

29866 Commits (3959597f7de04ead8fbec07d4cb48540bb3b67b2)
 

Author SHA1 Message Date
René Moser 3959597f7d exoscale: fix TXT type records handling (#23956) 7 years ago
Trishna Guha f354bd1eab Set terminal width for network *_command modules to avoid paging (#23728)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Trishna Guha 47edac6ebd Remove repetition of code nxos (#23908)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Indrajit Raychaudhuri 45252b79be pacman: Fail fast when 'rc != 0'
We fail-fast and display 'stderr' in case 'pacman' returns with 'rc != 0'.
There is no point computing 'module._diff' in such case anyway.

Fixes #23910

(cherry picked from commit 8c6a2a848c)
7 years ago
Brian Coca 72a4e1cf0d fixed code to actually check the parameter not key
also made rest conditional on unit being provided, previouslly it changed from being always required

fixes #23810 alternate to #23907
7 years ago
Kai cb13aea88b Fix systemd in chroot (#23904)
* Fix systemd in chroot

The 'request ignored' message is in stderr, not stdout.

* Check both stdout and stderr for systemd message

Some versions of systemd report to stderr, others to stdout. Also check
whether output could be a valid normal response to avoid false positives.
7 years ago
Sloane Hertel d021d8f16b efs: include name in results (#23931) 7 years ago
Sloane Hertel 380ac577c6 [cloud] ec2_facts: make ec2_facts python3 compatible - fixes #23595 (#23872)
* make ec2_facts python3 compatible

* remove parentheses and use pop() instead of del
7 years ago
Brian Coca a108f0fcd3 avoid hosts 'pre templated warnings' (#23878)
* avoid hosts 'pre templated warnings'

fixed is_template failing on undefined
fixes #23057

* py3 compat
7 years ago
Strahinja Kustudic 74e385e43a Move include_vars to host scope (#23868)
* Move include_vars to host scope

Module include_vars actually sets variables on a host level, and not the play level.

* Expand vars entires
7 years ago
Adrian Likins e0a7105c2d Use sys.stdout.buffer to write vault bytes to stdout on py3 (#23760)
* Use sys.stdout.buffer to write vault bytes to stdout on py3

We need sys.stdout.buffer on py3 so we can write bytes to it since the plaintext
of the vaulted object could be anything/binary/etc

Before, attempting to write bytes to stdout on py3 would cause:

  TypeError: write() argument must be str, not bytes
7 years ago
Ondra Machacek 80327d9d47 cloud: ovirt: import VM from external source (#22450) 7 years ago
David Mahler 09b247dd34 Minor grammatical corrections and improvements (#23886) 7 years ago
Sloane Hertel 00ebd0c89d make lineinfile docs clearer and make module pep8 (#23857) 7 years ago
Brian Coca 35e03cb140 p8p 7 years ago
Brian Coca 27185f44b0 fix environment populated detection
fixes #23764
7 years ago
Ondra Machacek 13c2c292f2 cloud: ovirt: add note that modules works with RHV as well (#23808) 7 years ago
Brian Coca 4594bee65a keep unsafe .. unsafe (#23742)
* keep unsafe .. unsafe

fixes #23734, which was broken in previous fix that allowed non string types to be templated
use new 'is_template' function vs bastardizing others
refactored clean_data to allow for arbitrary data structures to clean
fixed/removed some tests

* deal with complex data for is_template

* typos
7 years ago
Brian Coca 3358abcf49 Add a new filter: strftime. Use the well known function to format a date output. (#23832)
(cherry picked from commit 3f5b304fc2)
rebased for @yannig
7 years ago
Ricardo Carrillo Cruz 8517fbf936 Remove catch-all regex on IOS terminal plugin (#23858)
We have a list of specific messages that we scree-scrape and flag
them as legit errors.
However, we also have a catch-all regex that matches everything
starting with %.
That can cause issues on commands that return lines with that
character, like for example the 'crypto key generate'.

Fixes #23770
7 years ago
Ganesh Nalawade 04ae977f39 Fix display argument defualt value (#23859) 7 years ago
Ganesh Nalawade 1cdfcf0bb9 Add junos_command module unit test (#23819)
* Add junos_command module unit test
7 years ago
Michael Scherer 78836ec0b9 Fix --force for unversionned requirements (#23391)
In current stable (2.2), ansible galaxy install --force do erase
a role, even if the version is not set. This commit should restore
that specific behavior, in accordance to people reports:
  https://github.com/ansible/ansible/issues/11266#issuecomment-273801480

It was also the behavior planned in the initial discussion:
"if you're not fixing versions in your roles file, then it's fine
to expect that the role will be reinstalled each time you run
ansible-galaxy install.", cf https://github.com/ansible/ansible/pull/12904
7 years ago
Ricardo Carrillo Cruz 60de93c31d Add assertion on test_iosxr_facts (#23852)
We hit bug #23737 due to bad coverage on test_iosxr_facts, we
were not checking memory facts at all.
7 years ago
Ricardo Carrillo Cruz d0fd8cefaa Fix the iosxr_facts mem gathering (#23850)
We were not calling match.group, plus we were lacking a ':' from
the expected output of 'show memory summary'.

Fixes #23737
7 years ago
Trishna Guha 8ec4882ba0 Add eos_user module to users parameter (#23847)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Ganesh Nalawade 01afe12cba Add doc for display argument of junos_command (#23804) 7 years ago
Guillaume Coré c7f4c97b18 async+script: add integration test (#23818)
see #23729
7 years ago
Matt Davis 02ed223d49 template hostvars for set_host_overrides (#23839)
* fixes #23586
* temporary solution until connection-specific vars are handled by play_context
7 years ago
Brian Coca 79b9c585ea less code
(cherry picked from commit 20d9f79a5250e764ffeddb046aeb82b7824ed952)
7 years ago
Brian Coca eb887b8062 Revert "fixes play context connection user (#21776)" (#23830)
* Revert "fixes play context connection user (#21776)"

This reverts commit 58ee661437.
fixes #23530

* preserve original in copy

updated comment to clarify wtf is going on here
7 years ago
Abhijeet Kasurde 527a7762e1 Use regex variable in eos_user.py (#23797)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Sloane Hertel 91644167c9 improve exception handling (#23722)
make pep8
7 years ago
Sloane Hertel 11c292bac2 route53_facts: add example for how to use next_marker option - fixes #23625 (#23802)
* Add example for using route53 next_marker option

* make route53_facts pep8 and remove from legacy files
7 years ago
Nathaniel Case 0c2a0c7bce Eos port default values (#23829)
* Hook port back up for eos cli transport

* The default values have moved

* Why not have conditional defaults?
7 years ago
Brian Coca b4b96143fe also skip polling when async failed 7 years ago
Nathaniel Case 9bcc3f298f EOS default transport (#23824)
* Give a default to eos transport
7 years ago
Matt Babineau 4914164717 Typo (#23778)
Missed that D...
7 years ago
Eric Anderson 6aab341248 changed code block formatting to match format (#23615) 7 years ago
Adam Johnson f1c4b434cd Tidy example inventories in "Developing Dynamic Inventory Sources" (#18758)
Thanks @adamchainz!
7 years ago
Brian Coca fe9af903f3 script fails on async 7 years ago
Brian Coca 602a2bca1b fix vars file selection
fixes #17382
alternate to #22979

deal with cases in which group/host have . in name
updated as per feedbck
only be strict about extension when doing dirs
also avoid ~ endings
7 years ago
Brian Coca 3965689328 finer grained failed/skipped on async for actions
fixes #23729
7 years ago
Logan Attwood 5bbf0d9cb6 Use isfile check on package manager paths 7 years ago
Brian Coca 631a10745d fix hashing when path is symlink 7 years ago
Tomáš Karásek 0b585ec4fd Add guide for Packet host (#21346)
* Add guide for Packet host

* incorporate feedback from Packet

* Format headings according to Python doc guide

* fixed rstcheck issues in packet guide
7 years ago
Ricardo Carrillo Cruz 0bbfd3d4e0 Add missing aliases file to ios_system integration target (#23795) 7 years ago
Ricardo Carrillo Cruz 82fd038998 Add missing aliases file to iosxr integration tests targets (#23796) 7 years ago
Trishna Guha b2129a7d3a Add eos_banner as module to banner param (#23789)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Loïc Blot 504a768636 Show UUID instead of name when using UUID to select snapshot (#23787) 7 years ago