013aaeb895
CS improvements/fixes
9 years ago
05c7d49a37
Autocomplete search: add id and source (addressbook) into resulting contact data array
...
Two reasons:
- provide it to plugin backend functions that use 'contacts_autocomplete_after' hook
- provide it to frontend
Why to frontend?
If plugin JS adds an 'autocomplete_insert' hook we need to provide it with exact
autocomplete data. Providing it with name and email address only, without pinpointing
exact origin of this autocomplete result, will severely limit learning capabilities of
potential future autocomplete implementations.
9 years ago
a15b2d5998
Autocomplete refactoring: replace variable name '$id' with '$abook_id'
...
Reason:
Having genericly named variable $id in nested loops makes code unreadable.
Replacing generic name '$id' with '$ENTITIY_id' format removes all ambiguity.
9 years ago
ed55af4aa9
Autocomplete: trigger "contacts_autocomplete_after" hook processing
...
Provide existing list of contact suggestions as an argument - it might be unclear
now what logic plugin developers decide to implement, but data for that logic
should be provided upfront, and that includes list of suggestions that RC
itself comes up with.
Plugin logic might then replace the list entirely, or just rearrange its entries, or use
part of the list when it runs out of own ideas, or do something entirely different.
9 years ago
865230e420
Autocomplete: fix undefined variable notice if no addressbook is configured for autocomplete
9 years ago
4fdcd8c9d1
Remove redundant code
9 years ago
6f2c007d1b
CS fixes: Replace use of "bool ? true : false" with just "bool"
9 years ago
46f7b70964
Enable reply/reply-all/forward buttons also in preview frame of message/rfc822
9 years ago
e8b6e726f6
Add message menu with viewsource and edit actions in message/rfc822 preview
9 years ago
d125f864ea
Message/rfc822 previewer compatibility with Enigma
9 years ago
ce3105c58f
Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview
9 years ago
323fa20bc8
Message/rfc822 attachment preview ( #5054 )
9 years ago
4a408843b0
Protect download urls against CSRF using unique request tokens ( #1490642 )
...
Send X-Frame-Options headers with every HTTP response
9 years ago
b0a8e36930
Fix handling of body parameter in mail compose request
9 years ago
d686b57c72
Fix bug where contacts widget in compose could be incorrectly initialized with treelist widget (T998)
...
Fix typo in command name (list-adresses -> list-addresses)
9 years ago
22a018d082
Merge branch 'dev-svg'
9 years ago
558a6db27e
Fix headers encoding when using 'valueof' mode
9 years ago
9aaeb23d9d
Fix HTML entities encoding in message headers output
9 years ago
a1fdb205f8
Extend rcube_washtml with SVG support
9 years ago
40d7342dd9
Fix XSS issue in SVG images handling ( #1490625 )
9 years ago
3b36bcfb68
Cleanup
9 years ago
0d9fa7f3dc
Remove redundant code
9 years ago
cd219a45dd
Fix regression where some message attachments could be missing on edit/forward ( #1490608 )
9 years ago
be346095a0
Fix handling of message/rfc822 attachments on replies and forwards ( #1490607 )
9 years ago
bb6002f1a8
Fix also charset encoding of message/rfc822 part bodies ( #1490606 )
9 years ago
6463b662ca
Fix regression in displaying contents of message/rfc822 parts ( #1490606 )
9 years ago
8271597836
Use ternary operator where applicable
9 years ago
3b0318ca3e
Fix race-condition in setting current page between list and getunread requests
9 years ago
92bcb940d4
Fix bug where HTML messages with invalid/excessive css styles couldn't be displayed ( #1490539 )
...
Technically speaking we remove the whole CSS content when it has more than 5k lines.
9 years ago
bb1ed2740d
Display attachment size in compose ( #1484774 )
9 years ago
d560916065
Added possibility to drag-n-drop attachments from mail preview to compose window
9 years ago
5802e08e48
Mail messages searching with predefined date interval (T103)
9 years ago
82dcbb7488
Fix various issues in Mailvelope integration ( #1490533 )
9 years ago
4cd087ea2e
Fixed mailvelope-generated messages structure (required Mail_Mime-1.10.0)
9 years ago
e250f00d90
Fix PHP warnings when sending mailvelope-encrypted mail
9 years ago
8716fca0d0
Small improvements
9 years ago
f7f75ff7d1
Unify detection of pgp/mime message part
9 years ago
f189d72943
Merged branch 'dev-mailvelope'
9 years ago
77be69fa25
Fix issue where Content-Length of some attachments could be set to wrong value causing browser errors ( #1490482 )
9 years ago
63e7937d02
Change so rcube_message class does not depend on $_GET parameters
9 years ago
c49234bd78
Fix bug where clicking date column with 'arrival' sorting would switch to sorting by 'date' ( #1490126 )
9 years ago
fdbb1c95ea
Fix missing HTTP_X_FORWARDED_FOR address in generated Received header
9 years ago
91018f38d4
Fix so In-Reply-To header is set also for MDN receipts ( #1490523 )
9 years ago
399a2d68b6
Make optional adding of standard signature separator - sig_separator ( #1487768 )
9 years ago
c4daf3f14f
Fix regression in converting signatures to text, fixed PHP warning in html2text() call
9 years ago
6ca1e6add1
Add option to enable HTML editor always, except when replying to plain text messages ( #1489365 )
9 years ago
a63f14ec40
Emoticons-related code refactoring
...
- Emoticons: All emoticons-related functionality is handled by the plugin now
- Emoticons: Added option to switch on/off emoticons in compose editor (#1485732 )
- Emoticons: Added option to switch on/off emoticons in plain text messages
- Plugin API: Added disabled_plugins an disabled_buttons options in html_editor hook
- Plugin API: Added html2text hook
9 years ago
8297ea1dcf
Fix handling of plus character in mailto: links ( #1490510 )
9 years ago
bd82e9551f
Fix so css of one html part does not apply to other text parts on message display ( #1490505 )
9 years ago
60ab554003
Remove common subject prefixes Re:, Re[x]:, Re-x: on reply ( #1490497 )
9 years ago
92649075ec
CS fixes
9 years ago
08bb20f261
Don't use deprecated functions/constants (from bc.inc)
9 years ago
d5f6d655da
Workaround TinyMCE issue with <p> </p> sequence ( #1490463 )
9 years ago
2965a981b7
Allow to search and import missing PGP pubkeys from keyservers using Publickey.js
9 years ago
4b72a1f498
Fix error when using back button after sending an email ( #1490009 )
9 years ago
8b0d817919
Fix draft removal after a message is sent and storing sent message is disabled ( #1490467 )
9 years ago
8bed5e0151
Fix regression where compose editor mode was set incorrectly
10 years ago
19246792c6
Fix so *-request@ addresses in Sender: header are also ignored on reply-all ( #1490452 )
10 years ago
56a4e1512c
Fix a mistake in last small refactoring which broke identity selection
10 years ago
1414e3b6f8
Small refactoring to make some code testable
10 years ago
a567d85bf9
Fix self-reply detection issues ( #1490439 )
10 years ago
8e4dc03867
Fix unintentional messages list page change on page switch in compose addressbook ( #1490427 )
10 years ago
a958748947
CS fixes
10 years ago
3167e58ff9
Pass encrypted draft and reply messages to Mailvelope editor; add toolbar icon for encryption mode toggeling
10 years ago
40d152cfdc
Make encrypted pgp/mime message composition work
10 years ago
7b8a0af1c8
Add toolbar button to switch to Mailvelope encryption editor
10 years ago
1cd3762b0d
Start integrating the Mailvelope browser extension via its API.
...
- Embed Mailvelope message container for encrypted message text and full pgp-mime messages
- Prepare to embed the Mailvelope editor for composing encrypted messages (with attachments)
10 years ago
03aa84f784
Fix bug where some files could have "executable" extension when stored in temp folder ( #1490377 )
10 years ago
1aa0c8ad66
Fix bug where preview_pane setting wasn't always saved into user preferences ( #1490362 )
10 years ago
09225a41ec
Add option to place signature at bottom of the quoted text even in top-posting mode [sig_below]
10 years ago
aa38c512fb
Fix lack of signature separator for plain text signatures in html mode ( #1490352 )
10 years ago
0a4e0921d3
Plugin API: Added message_ready hook - the last chance to modify Mail_Mime object before saving or sending the message
10 years ago
1a7e668977
Fix handling of %-encoded entities in mailto: URLs ( #1490346 )
10 years ago
b1d13e8bd5
Fix redirct URL for attachments loaded in an iframe ( #1490191 )
10 years ago
10934dcd2a
Fix rows count when messages search fails ( #1490266 )
10 years ago
1ec105c685
Fix so search filter, scope and fields are reset on folder change
10 years ago
7ff227eb3e
get_part_content() -> get_part_body()
10 years ago
f02fe3c344
Remove redundant encoding of message subject with mb_encode_mimeheader() ( #1490295 )
10 years ago
7981575a61
Fix so localized folder name is displayed in multi-folder search result ( #1490243 )
10 years ago
b59b72cc30
Fix "Non-static method PEAR::isError() should not be called statically" errors ( #1490281 )
10 years ago
e1c8fe5c4a
Fix duplicate entries supression in autocomplete result ( #1490290 )
10 years ago
97ee4c40c1
Don't sent the message again in saveonly mode
10 years ago
c5c8e73351
Improved handling of storage errors after message is sent
...
After sending a message it is stored in Sent folder, this operation
may fail, e.g. because of "over quota" error. In such a case we'll
not close the compose window, but display the error and, if user clicks
Send/Save button, we'll display a dialog informing about the situation and
providing an option to try the save operation again.
10 years ago
216b31dd99
Fix so "over quota" errors are displayed also in message compose page
...
This also fixes over quota responses on cyrus imap which uses "Over quota" string and no error identifier.
10 years ago
45256e8293
Really fix unwanted warning on BMP attachments ( #1490269 )
10 years ago
4a2a62de30
Fix needless security warning on BMP attachments display ( #1490282 )
10 years ago
d67071f228
Fix saving/sending emoticon images when assets_dir is set (Kolab #4608 )
10 years ago
9ed6d46df7
Fix refreshing of drafts list when sending a message which was saved in meantime ( #1490238 )
10 years ago
556d288754
Fix false warning when opening attached text/plain files ( #1490241 )
10 years ago
5d42a9353b
Fix bug where drafts list wasn't refreshed after draft message was sent from another window ( #1490238 )
10 years ago
38dbd8022b
Fix bug where Reply-To address was ignored on reply to messages sent by self ( #1490233 )
10 years ago
ef29153a32
Improve display of pgp/mime and s/mime messges. Reverts commit f4154d91
10 years ago
f4154d9108
Fall back to $part->body when no mime_id is set for the message part
10 years ago
c6efcf5e6d
Fix blocked.gif image usage with assets_dir set
10 years ago
f6502176f8
Hide MDN and DSN options in compose if disabled by admin ( #1490221 )
10 years ago
10f133bae8
Fix bug where sent message was saved in Sent folder even if disabled by user ( #1490208 )
10 years ago
1881a8a152
Display "real" attachment size also on attachments list
10 years ago
cc5e4452db
Read page and page_size before check_recent hook is executed
...
- some plugins may change them to invalid values (in mail context)
10 years ago
8ccfc271d7
Fix skin inheritance for some icons ( #149017 )
10 years ago
681ba6fc3c
Improve system security by using optional special URL with security token
...
Allows to define separate server/path for image/js/css files
Fix bugs where CSRF attacks were still possible on some requests
10 years ago
fa424e54d2
Set compose mode in session when needed - skip one session update when composing new message
10 years ago
a4cdb601b7
Remove redundant code
10 years ago
07a641c79f
Code cleanup - unused variables
10 years ago
6a2bc7d833
fix for bug 1490153
10 years ago
cc6c7e83b5
Fix possible race-condition in using current folder
10 years ago
a16cf3bb7c
Replace all attachment-image URIs with CID URIs, not only src and poster attributes ( #1490132 )
10 years ago
f513432a35
Don't trust get_folder(), use mailbox environment variable when appropriate
10 years ago
0d96720f25
Fixed typo
10 years ago
c839403c19
More get_folder() -> $MESSAGE->folder
10 years ago
cd4e5057fc
Don't trust get_folder(), use $MESSAGE->folder if available
10 years ago
968601f1f5
Give higher priority to the 'subject' parameter from request or plugin
10 years ago
0b96b1cd81
Fix reply scrolling issue with text mode and start message below the quote ( #1490114 )
10 years ago
d165d11012
Fix so attachment charset is set in headers of forward/draft message ( #1490109 )
10 years ago
48ba4414b3
Fix download of attachments that are part of TNEF message ( #1490091 )
...
Rcube_message_part::body content should never be modified by code out of the rcube_message.
Added convenient rcube_message::get_part_body() method, making rcube_message::get_part_content() deprecated.
10 years ago
0fb7a485a3
Remove obsolete code which is executed in rcmail_output_html::frame()
10 years ago
02f7628314
Fix page title when using search filter ( #1490023 )
10 years ago
9cc5a522df
Fix so rcube_text2html class does not depend on rcmail_string_replacer
10 years ago
44b47dfb35
Add config/preference option to disable saving messages in localStorage ( #1489979 )
10 years ago
96f084e9cf
Don't expand recipient groups if they have an email address
10 years ago
6459944860
Don't read attachment contents from cache when downloading. Cache might have line endings converted
10 years ago
371f7ca443
Remove folder column after disabling multifolder scope ( #1490022 )
10 years ago
e1b8f44e3f
Fix invalid Content-Type header when send_format_flowed=false ( #1489992 )
10 years ago
d01f9fc7f5
Add option (disabled_actions) to disable UI elements/actions ( #1489638 )
10 years ago
04638fb7e5
Add fileuploaderror label, fixing not resolved error label of failed import uploads
10 years ago
fcb7d4fc03
Fix various iCloud vCard issues, added fallback for external photos ( #1489993 )
10 years ago
d4783319a0
Set 'compose_extwin' env property on every step; accept a list of URL parameters for the 'compose' command
10 years ago
43e9fc9499
Skip redundant get_group() call for better performance of listing groups in compose addressbook
11 years ago
36d004e3d0
Added 'contact_search_name' option to define autocompletion entry format
11 years ago
4104233555
Typo fix
...
Missing $ added in get_uids call
11 years ago
b8bcca7033
Display quota information for current folder not INBOX only ( #1487993 )
11 years ago
3cc1afa1c2
Support images in HTML signatures ( #1488676 )
...
This enables image button and file browser in html editor for signatures
11 years ago
2c3c5884e3
Fix incorrect label translation in return receipt ( #1489963 )
11 years ago
cd01dc027b
Add option to set default message list mode - default_list_mode ( #1487312 )
11 years ago
10bf6b58ce
Fix so address format errors are ignored when saving a draft ( #1489954 )
11 years ago
9240c96339
Improve accessibility on attachments list: use custom tabindex attribute + add aria-label for meaningful voice output on delete icons
11 years ago
6eb08dff7c
Use the right label for response dialog after renaming them
11 years ago
386e3ad424
Fix malformed recipient name when composing a message by clicking on mailto link ( #1489942 )
11 years ago
64f7d6758f
Select/scroll to previously selected message when returning from message page ( #1489023 )
11 years ago
7fafb4d0d2
Remove leftover from merge; set alt text for contact photo
11 years ago
99cdca46b7
Merge branch 'dev-accessibility'
...
Conflicts:
program/include/rcmail_output_html.php
program/js/app.js
program/js/treelist.js
program/lib/Roundcube/html.php
skins/larry/styles.css
skins/larry/templates/compose.html
11 years ago
c5bfe69e21
Improved video support, all tinymce related resources moved to program/js/tinymce/roundcube dir
11 years ago
f25be2b863
Render localized texts for icon-style messagelist headers
11 years ago
72afe3153c
Use <th> tags for table headers as suggested by the WCAG 2.0 Guidelines
11 years ago
d28daec918
Fix so message list and counters are updated when a message is opened in new window ( #1489919 )
11 years ago
d58c39126f
Some more improvemements on content structure, text representation and keyboard navigation within the mail view
11 years ago
5c1bbffd72
CS fixes
11 years ago
646b64107a
Implemented Text Editor widget that integrates all operations on
...
textareas including HTML editor and spellchecking
11 years ago
3dbfb53f2b
Remove (was: ...) from message subject on reply ( #1489375 )
11 years ago
b4446aa7a9
Add message status labels to client
11 years ago
731d190fec
Merge branch 'tinymce4'
...
Conflicts:
program/js/app.js
program/js/editor.js
program/js/tiny_mce/tiny_mce.js
program/steps/utils/spell_html.inc
11 years ago
f56e70bd04
TinyMCE4: Fix spellchecker resume
11 years ago
b21f8bd3ef
Implemented image selector dialog for TinyMCE, css fixes in classic skin for TinyMCE4
11 years ago
a3e01c0517
Plugin API: Add folder and uid arguments to message_headers_output hook
11 years ago
bb57fca320
Fix so current page is reset on list-mode change ( #1489907 )
11 years ago
59b765d839
Don't remove links when html signature is converted to text ( #1489621 )
...
Fix so when switching editor mode original version of signature is used (#1488849 )
11 years ago
efc470f0ac
Merge branch 'dev-text2html'
...
Conflicts:
program/js/app.js
Fix handling magic_quotes in rcube_text2html and rcube_html2text - move
stripslashes from these classes to action files
11 years ago
f0992426d9
Bring back the old behaviour where text messages without format=flowed are auto-wrapped.
...
Make it the default in text2html class.
11 years ago
b3db98dd1e
Fix some typos and skip some function calls irrelevant in multi-folder mode
11 years ago
2b72ec46a7
Bypass cache when counting EXISTS messages
11 years ago
eda92ed4c0
Improved display of plain text messages and text to HTML conversion ( #1488937 )
...
Now instead of <pre> we use <div class="pre"> styled with monospace
font. We replace whitespace characters with non-breaking spaces where
needed. I.e. plain text is always unwrappable, until it uses format=flowed,
in such a case only flowed paragraphs are wrappable.
Also conversion of text to HTML in compose editor was modified in the same way.
11 years ago
b2992dd228
Further accessibility improvements regarding keyboard navigation and document structure
11 years ago
8968f9543f
Support image operations with Imagick extension ( #1489734 )
11 years ago
89d6ce6846
Update to TinyMCE 4.x
11 years ago
65ac8302e4
Fix missing Mail-Followup-To header in sent mail ( #1489829 )
11 years ago
7d213af1bd
Fix saving of search settings in 'all folders' mode
11 years ago
fc2b025081
Remove debug output
11 years ago
31aa080609
Further refine cross-folder searching:
...
- Store incomplete search results in session and re-send search requests
to the server if returned before complete (this should avoid hitting request timeouts).
- Display full folder path on mouseover in message list
- Remove pthreads implementation stuff as this wasn't really working
11 years ago
3b55b2f92b
Fix so browser capabilities check is done really only once a session
11 years ago
26b5200322
Consider search scope (and changes) for filter searches + disable folder operation commands in multi-folder search mode ( #1485234 )
11 years ago
c0b295f04b
Support messages import from zip archives
11 years ago
5515dbb970
Remove IE<7 specific code
11 years ago
2e10259992
Fixed mbox files import
11 years ago
24e63e2218
Fix deleting/moving folders from folders with name "0", "00", etc.
11 years ago
a594999135
Use POST for refresh/check-recent request
11 years ago
cb29c97bf6
Fix lack of translation of special folders in some configurations ( #1489799 )
11 years ago
6b6d49313d
Merge branch 'master' of github.com:roundcube/roundcubemail
11 years ago
8d34b9dce3
Refactored storage properties setting
11 years ago
8ed382f1ec
Append group parameter to attachments set by plugins if not present
11 years ago
188247894f
Make multi-folder message identifiers work with folders containing commas
11 years ago
f50a66c616
Enable listmode switch if listing is not multi-folder
11 years ago
aafbe8efdc
Fix forwarding all ('*') messages of a search set
11 years ago
1e9a59ab89
Don't remove messages from list when moving to another folder in multi-folder search mode, just update the list
11 years ago
1d1fdcbf8c
Fix splitting message identifiers into UID and folder values
11 years ago
1883048720
Optimize header fetching of multi-folder searches with natural (UID) sorting
11 years ago
f0c94a3dc3
Don't display error when moving a message to the same folder it already resides
11 years ago
0f48e6e660
Fix message UID extraction for _uid=*; update unread count for all affected mailboxes
11 years ago
0ccef59cfa
Fix bug where "With attachment" option in search filter wasn't selected after return from mail view ( #1489774 )
11 years ago
0456f728ee
Make UID extraction function globally availbale (for plugins)
11 years ago
6dc1a66451
Fix page title and folder selection in search mode
11 years ago
e8cb51669a
More fixes for multi-folder search ( #1485234 )
11 years ago
c83535876c
Small refactoring of message list column configuration; fixes table column resorting issues with hidden 'folder' column
11 years ago
b95033e45a
Save list columns as array in session
11 years ago
66536974fe
Merge branch 'dev-multi-folder-search'
11 years ago
d0cb327af7
Bring back $COMPOSE['reply_uid'] lost in commit 73076d7e
11 years ago
73076d7ea6
Set In-Reply-To and References for forwarded messages ( #1489593 )
11 years ago
a8a50de4e3
Improve mbox format import: don't expect empty lines after each message
11 years ago
08da302af0
Don't hide upload dialog if no file was selected. Display an alert message for all empty file uploads ( #1489685 )
11 years ago
a930815871
Trim search filter to prevent from creating invalid search criteria when skip_deleted = true.
11 years ago
a36369c383
Fix message import dialog ( #1489685 ):
...
- Display alert if no file is chosen
- Unlock the UI if form is not submitted
- Avoid duplicate error messages
- Fix javascript error due to missing attachments list widget
11 years ago
532c10669b
Support structured data for autocompletion results; map 'type' attribute to CSS class for autocomplete list items
11 years ago
Aleksander Machniak