Fix regression where some message attachments could be missing on edit/forward (#1490608)

CHANGELOG

@@ -1,6 +1,7 @@
 CHANGELOG Roundcube Webmail
 ===========================
 
+- Fix regression where some message attachments could be missing on edit/forward (#1490608)
 - Fix regression in displaying contents of message/rfc822 parts (#1490606)
 - Fix handling of message/rfc822 attachments on replies and forwards (#1490607)
 - Fix PDF support detection in Firefox > 19 (#1490610)

program/lib/Roundcube/rcube_session.php

@@ -293,6 +293,8 @@ abstract class rcube_session
     /**
      * Append the given value to the certain node in the session data array
      *
+     * Warning: Do not use if you already modified $_SESSION in the same request (#1490608)
+     *
      * @param string Path denoting the session variable where to append the value
      * @param string Key name under which to append the new value (use null for appending to an indexed list)
      * @param mixed  Value to append to the session data array
@@ -319,8 +321,9 @@ abstract class rcube_session
         $this->appends[] = $path;
 
         // when overwriting a previously unset variable
-        if ($this->unsets[$path])
+        if ($this->unsets[$path]) {
             unset($this->unsets[$path]);
+        }
     }
 
     /**
@@ -398,7 +401,6 @@ abstract class rcube_session
                 }
             }
         }
-
     }
 
     /**

program/steps/mail/func.inc

@@ -2203,6 +2203,8 @@ function rcmail_compose_contact_groups($abook, $source_id, $search = null, $sear
 
 function rcmail_save_attachment($message, $pid, $compose_id, $params = array())
 {
+    global $COMPOSE;
+
     $rcmail  = rcmail::get_instance();
     $storage = $rcmail->get_storage();
 
@@ -2265,7 +2267,26 @@ function rcmail_save_attachment($message, $pid, $compose_id, $params = array())
 
     if ($attachment['status']) {
         unset($attachment['data'], $attachment['status'], $attachment['content_id'], $attachment['abort']);
-        $rcmail->session->append('compose_data_' . $compose_id . '.attachments', $attachment['id'], $attachment);
+
+        $session_key = 'compose_data_' . $compose_id;
+
+        // rcube_session::append() replaces current session data with the old values
+        // (in rcube_session::reload()). This is a problem in 'compose' action, because before
+        // the first append() use we set some important data in the session.
+        // It also overwrites attachments list. Fixing reload() is not so simple if possible
+        // as we don't really know what has been added and what removed in meantime.
+        // So, for now we'll do not use append() on 'compose' action (#1490608).
+
+        if ($rcmail->action == 'compose') {
+            $_SESSION[$session_key]['attachments'][$attachment['id']] = $attachment;
+        }
+        else {
+            $rcmail->session->append($session_key . '.attachments', $attachment['id'], $attachment);
+        }
+
+        // Fix reference to compose session data after rcube_session::append()
+        $COMPOSE =& $_SESSION[$session_key];
+
         return $attachment;
     }
     else if ($path) {