Commit Graph

1523 Commits (cdd616744a025b8a354bc703d51bb7ce506e0b07)

Author SHA1 Message Date
Bostjan Skufca a15b2d5998 Autocomplete refactoring: replace variable name '$id' with '$abook_id'
Reason:
Having genericly named variable $id in nested loops makes code unreadable.
Replacing generic name '$id' with '$ENTITIY_id' format removes all ambiguity.
9 years ago
Bostjan Skufca ed55af4aa9 Autocomplete: trigger "contacts_autocomplete_after" hook processing
Provide existing list of contact suggestions as an argument - it might be unclear
now what logic plugin developers decide to implement, but data for that logic
should be provided upfront, and that includes list of suggestions that RC
itself comes up with.

Plugin logic might then replace the list entirely, or just rearrange its entries, or use
part of the list when it runs out of own ideas, or do something entirely different.
9 years ago
Bostjan Skufca 865230e420 Autocomplete: fix undefined variable notice if no addressbook is configured for autocomplete 9 years ago
Aleksander Machniak 4fdcd8c9d1 Remove redundant code 9 years ago
Aleksander Machniak 6f2c007d1b CS fixes: Replace use of "bool ? true : false" with just "bool" 9 years ago
Aleksander Machniak 46f7b70964 Enable reply/reply-all/forward buttons also in preview frame of message/rfc822 9 years ago
Aleksander Machniak e8b6e726f6 Add message menu with viewsource and edit actions in message/rfc822 preview 9 years ago
Aleksander Machniak d125f864ea Message/rfc822 previewer compatibility with Enigma 9 years ago
Aleksander Machniak ce3105c58f Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview 9 years ago
Aleksander Machniak 323fa20bc8 Message/rfc822 attachment preview (#5054) 9 years ago
Thomas Bruederli 4a408843b0 Protect download urls against CSRF using unique request tokens (#1490642)
Send X-Frame-Options headers with every HTTP response
9 years ago
Aleksander Machniak b0a8e36930 Fix handling of body parameter in mail compose request 9 years ago
Aleksander Machniak d686b57c72 Fix bug where contacts widget in compose could be incorrectly initialized with treelist widget (T998)
Fix typo in command name (list-adresses -> list-addresses)
9 years ago
Aleksander Machniak 22a018d082 Merge branch 'dev-svg' 9 years ago
Aleksander Machniak 558a6db27e Fix headers encoding when using 'valueof' mode 9 years ago
Aleksander Machniak 9aaeb23d9d Fix HTML entities encoding in message headers output 9 years ago
Aleksander Machniak a1fdb205f8 Extend rcube_washtml with SVG support 9 years ago
Aleksander Machniak 40d7342dd9 Fix XSS issue in SVG images handling (#1490625) 9 years ago
Aleksander Machniak 3b36bcfb68 Cleanup 9 years ago
Aleksander Machniak 0d9fa7f3dc Remove redundant code 9 years ago
Aleksander Machniak cd219a45dd Fix regression where some message attachments could be missing on edit/forward (#1490608) 9 years ago
Aleksander Machniak be346095a0 Fix handling of message/rfc822 attachments on replies and forwards (#1490607) 9 years ago
Aleksander Machniak bb6002f1a8 Fix also charset encoding of message/rfc822 part bodies (#1490606) 9 years ago
Aleksander Machniak 6463b662ca Fix regression in displaying contents of message/rfc822 parts (#1490606) 9 years ago
Aleksander Machniak 8271597836 Use ternary operator where applicable 9 years ago
Aleksander Machniak 3b0318ca3e Fix race-condition in setting current page between list and getunread requests 9 years ago
Aleksander Machniak 92bcb940d4 Fix bug where HTML messages with invalid/excessive css styles couldn't be displayed (#1490539)
Technically speaking we remove the whole CSS content when it has more than 5k lines.
9 years ago
Aleksander Machniak bb1ed2740d Display attachment size in compose (#1484774) 9 years ago
Aleksander Machniak d560916065 Added possibility to drag-n-drop attachments from mail preview to compose window 9 years ago
Aleksander Machniak 5802e08e48 Mail messages searching with predefined date interval (T103) 9 years ago
Aleksander Machniak 82dcbb7488 Fix various issues in Mailvelope integration (#1490533) 9 years ago
Aleksander Machniak 4cd087ea2e Fixed mailvelope-generated messages structure (required Mail_Mime-1.10.0) 9 years ago
Aleksander Machniak e250f00d90 Fix PHP warnings when sending mailvelope-encrypted mail 9 years ago
Aleksander Machniak 8716fca0d0 Small improvements 9 years ago
Thomas Bruederli f7f75ff7d1 Unify detection of pgp/mime message part 9 years ago
Thomas Bruederli f189d72943 Merged branch 'dev-mailvelope' 9 years ago
Aleksander Machniak 77be69fa25 Fix issue where Content-Length of some attachments could be set to wrong value causing browser errors (#1490482) 9 years ago
Aleksander Machniak 63e7937d02 Change so rcube_message class does not depend on $_GET parameters 9 years ago
Aleksander Machniak c49234bd78 Fix bug where clicking date column with 'arrival' sorting would switch to sorting by 'date' (#1490126) 9 years ago
Aleksander Machniak fdbb1c95ea Fix missing HTTP_X_FORWARDED_FOR address in generated Received header 9 years ago
Aleksander Machniak 91018f38d4 Fix so In-Reply-To header is set also for MDN receipts (#1490523) 9 years ago
Aleksander Machniak 399a2d68b6 Make optional adding of standard signature separator - sig_separator (#1487768) 9 years ago
Aleksander Machniak c4daf3f14f Fix regression in converting signatures to text, fixed PHP warning in html2text() call 9 years ago
Aleksander Machniak 6ca1e6add1 Add option to enable HTML editor always, except when replying to plain text messages (#1489365) 9 years ago
Aleksander Machniak a63f14ec40 Emoticons-related code refactoring
- Emoticons: All emoticons-related functionality is handled by the plugin now
- Emoticons: Added option to switch on/off emoticons in compose editor (#1485732)
- Emoticons: Added option to switch on/off emoticons in plain text messages
- Plugin API: Added disabled_plugins an disabled_buttons options in html_editor hook
- Plugin API: Added html2text hook
9 years ago
Aleksander Machniak 8297ea1dcf Fix handling of plus character in mailto: links (#1490510) 9 years ago
Aleksander Machniak bd82e9551f Fix so css of one html part does not apply to other text parts on message display (#1490505) 9 years ago
Aleksander Machniak 60ab554003 Remove common subject prefixes Re:, Re[x]:, Re-x: on reply (#1490497) 9 years ago
Aleksander Machniak 92649075ec CS fixes 9 years ago
Aleksander Machniak 08bb20f261 Don't use deprecated functions/constants (from bc.inc) 9 years ago
Aleksander Machniak d5f6d655da Workaround TinyMCE issue with <p>&nbsp;</p> sequence (#1490463) 9 years ago
Thomas Bruederli 2965a981b7 Allow to search and import missing PGP pubkeys from keyservers using Publickey.js 9 years ago
Aleksander Machniak 4b72a1f498 Fix error when using back button after sending an email (#1490009) 9 years ago
Aleksander Machniak 8b0d817919 Fix draft removal after a message is sent and storing sent message is disabled (#1490467) 9 years ago
Aleksander Machniak 8bed5e0151 Fix regression where compose editor mode was set incorrectly 9 years ago
Aleksander Machniak 19246792c6 Fix so *-request@ addresses in Sender: header are also ignored on reply-all (#1490452) 9 years ago
Aleksander Machniak 56a4e1512c Fix a mistake in last small refactoring which broke identity selection 10 years ago
Aleksander Machniak 1414e3b6f8 Small refactoring to make some code testable 10 years ago
Aleksander Machniak a567d85bf9 Fix self-reply detection issues (#1490439) 10 years ago
Aleksander Machniak 8e4dc03867 Fix unintentional messages list page change on page switch in compose addressbook (#1490427) 10 years ago
Aleksander Machniak a958748947 CS fixes 10 years ago
Thomas Bruederli 3167e58ff9 Pass encrypted draft and reply messages to Mailvelope editor; add toolbar icon for encryption mode toggeling 10 years ago
Thomas Bruederli 40d152cfdc Make encrypted pgp/mime message composition work 10 years ago
Thomas Bruederli 7b8a0af1c8 Add toolbar button to switch to Mailvelope encryption editor 10 years ago
Thomas Bruederli 1cd3762b0d Start integrating the Mailvelope browser extension via its API.
- Embed Mailvelope message container for encrypted message text and full pgp-mime messages
- Prepare to embed the Mailvelope editor for composing encrypted messages (with attachments)
10 years ago
Aleksander Machniak 03aa84f784 Fix bug where some files could have "executable" extension when stored in temp folder (#1490377) 10 years ago
Aleksander Machniak 1aa0c8ad66 Fix bug where preview_pane setting wasn't always saved into user preferences (#1490362) 10 years ago
Aleksander Machniak 09225a41ec Add option to place signature at bottom of the quoted text even in top-posting mode [sig_below] 10 years ago
Aleksander Machniak aa38c512fb Fix lack of signature separator for plain text signatures in html mode (#1490352) 10 years ago
Aleksander Machniak 0a4e0921d3 Plugin API: Added message_ready hook - the last chance to modify Mail_Mime object before saving or sending the message 10 years ago
Aleksander Machniak 1a7e668977 Fix handling of %-encoded entities in mailto: URLs (#1490346) 10 years ago
Thomas Bruederli b1d13e8bd5 Fix redirct URL for attachments loaded in an iframe (#1490191) 10 years ago
Aleksander Machniak 10934dcd2a Fix rows count when messages search fails (#1490266) 10 years ago
Aleksander Machniak 1ec105c685 Fix so search filter, scope and fields are reset on folder change 10 years ago
Aleksander Machniak 7ff227eb3e get_part_content() -> get_part_body() 10 years ago
Aleksander Machniak f02fe3c344 Remove redundant encoding of message subject with mb_encode_mimeheader() (#1490295) 10 years ago
Aleksander Machniak 7981575a61 Fix so localized folder name is displayed in multi-folder search result (#1490243) 10 years ago
Aleksander Machniak b59b72cc30 Fix "Non-static method PEAR::isError() should not be called statically" errors (#1490281) 10 years ago
Aleksander Machniak e1c8fe5c4a Fix duplicate entries supression in autocomplete result (#1490290) 10 years ago
Aleksander Machniak 97ee4c40c1 Don't sent the message again in saveonly mode 10 years ago
Aleksander Machniak c5c8e73351 Improved handling of storage errors after message is sent
After sending a message it is stored in Sent folder, this operation
may fail, e.g. because of "over quota" error. In such a case we'll
not close the compose window, but display the error and, if user clicks
Send/Save button, we'll display a dialog informing about the situation and
providing an option to try the save operation again.
10 years ago
Aleksander Machniak 216b31dd99 Fix so "over quota" errors are displayed also in message compose page
This also fixes over quota responses on cyrus imap which uses "Over quota" string and no error identifier.
10 years ago
Aleksander Machniak 45256e8293 Really fix unwanted warning on BMP attachments (#1490269) 10 years ago
Aleksander Machniak 4a2a62de30 Fix needless security warning on BMP attachments display (#1490282) 10 years ago
Aleksander Machniak d67071f228 Fix saving/sending emoticon images when assets_dir is set (Kolab #4608) 10 years ago
Aleksander Machniak 9ed6d46df7 Fix refreshing of drafts list when sending a message which was saved in meantime (#1490238) 10 years ago
Aleksander Machniak 556d288754 Fix false warning when opening attached text/plain files (#1490241) 10 years ago
Aleksander Machniak 5d42a9353b Fix bug where drafts list wasn't refreshed after draft message was sent from another window (#1490238) 10 years ago
Aleksander Machniak 38dbd8022b Fix bug where Reply-To address was ignored on reply to messages sent by self (#1490233) 10 years ago
Thomas Bruederli ef29153a32 Improve display of pgp/mime and s/mime messges. Reverts commit f4154d91 10 years ago
Thomas Bruederli f4154d9108 Fall back to $part->body when no mime_id is set for the message part 10 years ago
Aleksander Machniak c6efcf5e6d Fix blocked.gif image usage with assets_dir set 10 years ago
Aleksander Machniak f6502176f8 Hide MDN and DSN options in compose if disabled by admin (#1490221) 10 years ago
Aleksander Machniak 10f133bae8 Fix bug where sent message was saved in Sent folder even if disabled by user (#1490208) 10 years ago
Aleksander Machniak 1881a8a152 Display "real" attachment size also on attachments list 10 years ago
Aleksander Machniak cc5e4452db Read page and page_size before check_recent hook is executed
- some plugins may change them to invalid values (in mail context)
10 years ago
Aleksander Machniak 8ccfc271d7 Fix skin inheritance for some icons (#149017) 10 years ago
Aleksander Machniak 681ba6fc3c Improve system security by using optional special URL with security token
Allows to define separate server/path for image/js/css files
Fix bugs where CSRF attacks were still possible on some requests
10 years ago
Aleksander Machniak fa424e54d2 Set compose mode in session when needed - skip one session update when composing new message 10 years ago
Aleksander Machniak a4cdb601b7 Remove redundant code 10 years ago
Aleksander Machniak 07a641c79f Code cleanup - unused variables 10 years ago
brendan braybrook 6a2bc7d833 fix for bug 1490153 10 years ago
Aleksander Machniak cc6c7e83b5 Fix possible race-condition in using current folder 10 years ago
Aleksander Machniak a16cf3bb7c Replace all attachment-image URIs with CID URIs, not only src and poster attributes (#1490132) 10 years ago
Aleksander Machniak f513432a35 Don't trust get_folder(), use mailbox environment variable when appropriate 10 years ago
Aleksander Machniak 0d96720f25 Fixed typo 10 years ago
Aleksander Machniak c839403c19 More get_folder() -> $MESSAGE->folder 10 years ago
Aleksander Machniak cd4e5057fc Don't trust get_folder(), use $MESSAGE->folder if available 10 years ago
Aleksander Machniak 968601f1f5 Give higher priority to the 'subject' parameter from request or plugin 10 years ago
Aleksander Machniak 0b96b1cd81 Fix reply scrolling issue with text mode and start message below the quote (#1490114) 10 years ago
Aleksander Machniak d165d11012 Fix so attachment charset is set in headers of forward/draft message (#1490109) 10 years ago
Aleksander Machniak 48ba4414b3 Fix download of attachments that are part of TNEF message (#1490091)
Rcube_message_part::body content should never be modified by code out of the rcube_message.
Added convenient rcube_message::get_part_body() method, making rcube_message::get_part_content() deprecated.
10 years ago
Thomas Bruederli 0fb7a485a3 Remove obsolete code which is executed in rcmail_output_html::frame() 10 years ago
Aleksander Machniak 02f7628314 Fix page title when using search filter (#1490023) 10 years ago
Aleksander Machniak 9cc5a522df Fix so rcube_text2html class does not depend on rcmail_string_replacer 10 years ago
Thomas Bruederli 44b47dfb35 Add config/preference option to disable saving messages in localStorage (#1489979) 10 years ago
Thomas Bruederli 96f084e9cf Don't expand recipient groups if they have an email address 10 years ago
Thomas Bruederli 6459944860 Don't read attachment contents from cache when downloading. Cache might have line endings converted 10 years ago
Aleksander Machniak 371f7ca443 Remove folder column after disabling multifolder scope (#1490022) 10 years ago
Aleksander Machniak e1b8f44e3f Fix invalid Content-Type header when send_format_flowed=false (#1489992) 10 years ago
Aleksander Machniak d01f9fc7f5 Add option (disabled_actions) to disable UI elements/actions (#1489638) 10 years ago
Aleksander Machniak 04638fb7e5 Add fileuploaderror label, fixing not resolved error label of failed import uploads 10 years ago
Aleksander Machniak fcb7d4fc03 Fix various iCloud vCard issues, added fallback for external photos (#1489993) 10 years ago
Thomas Bruederli d4783319a0 Set 'compose_extwin' env property on every step; accept a list of URL parameters for the 'compose' command 10 years ago
Aleksander Machniak 43e9fc9499 Skip redundant get_group() call for better performance of listing groups in compose addressbook 11 years ago
Aleksander Machniak 36d004e3d0 Added 'contact_search_name' option to define autocompletion entry format 11 years ago
Takika 4104233555 Typo fix
Missing $ added in get_uids call
11 years ago
Aleksander Machniak b8bcca7033 Display quota information for current folder not INBOX only (#1487993) 11 years ago
Aleksander Machniak 3cc1afa1c2 Support images in HTML signatures (#1488676)
This enables image button and file browser in html editor for signatures
11 years ago
Aleksander Machniak 2c3c5884e3 Fix incorrect label translation in return receipt (#1489963) 11 years ago
Aleksander Machniak cd01dc027b Add option to set default message list mode - default_list_mode (#1487312) 11 years ago
Aleksander Machniak 10bf6b58ce Fix so address format errors are ignored when saving a draft (#1489954) 11 years ago
Thomas Bruederli 9240c96339 Improve accessibility on attachments list: use custom tabindex attribute + add aria-label for meaningful voice output on delete icons 11 years ago
Thomas Bruederli 6eb08dff7c Use the right label for response dialog after renaming them 11 years ago
Aleksander Machniak 386e3ad424 Fix malformed recipient name when composing a message by clicking on mailto link (#1489942) 11 years ago
Aleksander Machniak 64f7d6758f Select/scroll to previously selected message when returning from message page (#1489023) 11 years ago
Thomas Bruederli 7fafb4d0d2 Remove leftover from merge; set alt text for contact photo 11 years ago
Thomas Bruederli 99cdca46b7 Merge branch 'dev-accessibility'
Conflicts:
	program/include/rcmail_output_html.php
	program/js/app.js
	program/js/treelist.js
	program/lib/Roundcube/html.php
	skins/larry/styles.css
	skins/larry/templates/compose.html
11 years ago
Aleksander Machniak c5bfe69e21 Improved video support, all tinymce related resources moved to program/js/tinymce/roundcube dir 11 years ago
Thomas Bruederli f25be2b863 Render localized texts for icon-style messagelist headers 11 years ago
Thomas Bruederli 72afe3153c Use <th> tags for table headers as suggested by the WCAG 2.0 Guidelines 11 years ago
Aleksander Machniak d28daec918 Fix so message list and counters are updated when a message is opened in new window (#1489919) 11 years ago
Thomas Bruederli d58c39126f Some more improvemements on content structure, text representation and keyboard navigation within the mail view 11 years ago
Aleksander Machniak 5c1bbffd72 CS fixes 11 years ago
Aleksander Machniak 646b64107a Implemented Text Editor widget that integrates all operations on
textareas including HTML editor and spellchecking
11 years ago
Aleksander Machniak 3dbfb53f2b Remove (was: ...) from message subject on reply (#1489375) 11 years ago
Thomas Bruederli b4446aa7a9 Add message status labels to client 11 years ago
Aleksander Machniak 731d190fec Merge branch 'tinymce4'
Conflicts:
	program/js/app.js
	program/js/editor.js
	program/js/tiny_mce/tiny_mce.js
	program/steps/utils/spell_html.inc
11 years ago
Aleksander Machniak f56e70bd04 TinyMCE4: Fix spellchecker resume 11 years ago
Aleksander Machniak b21f8bd3ef Implemented image selector dialog for TinyMCE, css fixes in classic skin for TinyMCE4 11 years ago