Commit Graph

1243 Commits (0efa899d6ca3ddd1feb78bf8332d1f73841d2154)

Author SHA1 Message Date
Aleksander Machniak e7ebff56df PHPDoc fixes 5 years ago
Aleksander Machniak 17296b39cb Fix infinite loading message on iframe loading errors
The loading message was not stopped on "hard" errors, i.e. when
the page was blank, e.g. on 500 error.
5 years ago
Aleksander Machniak c6de97c5a8 Redis: Improve error handling and phpredis 5.X support (#6888) 5 years ago
Aleksander Machniak de4a6068e6 Mention Masterminds/HTML5 in INSTALL/README 5 years ago
Aleksander Machniak b10a0dbb7e Reset internal $skins property is set_skin() 5 years ago
Aleksander Machniak bdd1b94d78 Fix PHP 7.4 warning: "Creating default object from empty value" 5 years ago
Aleksander Machniak 27bfd0884e Drop rcube_browser::$lang property
You should use Accept-Language header instead, as we do in other place
5 years ago
Aleksander Machniak 1a10074b85 Add Edge browser detection 5 years ago
Aleksander Machniak f5d6a242a8 Remove useless properties from rcube_browser 5 years ago
Aleksander Machniak 21ebf3ff5a Fix bug where it was possible to bypass href URI check with data:application/xhtml+xml URIs (#6896) 5 years ago
Aleksander Machniak 63730cf842 Fix security issue where it was possible to bypass the CSS jail in HTML messages using :root pseudo-class (#6897) 5 years ago
Aleksander Machniak 057fb69bb9 Fix bug where some strict remote URIs in url() style were unintentionally blocked (#6899) 5 years ago
Aleksander Machniak 7bf868767e Fix security issue where it was possible to bypass the position:fixed CSS check in received messages (#6898) 5 years ago
Aleksander Machniak 3b4d9f3fb5 PHPDoc updates 5 years ago
Aleksander Machniak 1afa46d28d PHPDoc and CS fixes 5 years ago
Aleksander Machniak f7832a1a26 Removed 'delete_always' option (#6782) 5 years ago
Aleksander Machniak 902c264cf0 PHPRedis 5 compat. fix in session handler 5 years ago
Jack Cherng 198585d8a0 Fix implode() wrong parameter order (#6866)
It has been deprecated in PHP 7.4.

Such as PHP deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/roundcubemail/program/lib/Roundcube/rcube_db.php on line 917

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
5 years ago
Sandor Takacs adcfa53532 Redis::delete() is deprecated in phpredis 5.0.0 (#6883)
Redis::delete() is deprecated in phpredis 5.0.0
5 years ago
Jack Cherng 17d8423299 Fix PHP 7.4 deprecation: array/string curly braces access (#6884)
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
5 years ago
Aleksander Machniak 9b88e9e5c2 Correct vendor string for GMail is 'gimap' 5 years ago
Aleksander Machniak a80c5569ab Added flag to disable server certificate validation via Mysql DSN argument (#6848) 5 years ago
Aleksander Machniak 786bde62f2 Fix wrong messages order after returning to a multi-folder search result (#6836) 5 years ago
Aleksander Machniak 44bdca4ab9 Enigma: Fix bug where signature verification could have been skipped for some message structures (#6838) 5 years ago
Aleksander Machniak 8f895cb17f Replace function alias: getallheaders() -> apache_request_headers() 5 years ago
Jack Cherng 20bf625733 Remove a unused variable in rcube_plugin::include_stylesheet() (#6832)
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
5 years ago
Aleksander Machniak b7b2ce7b91 Small code improvement 5 years ago
Aleksander Machniak 0869f02b7c Fix bug in converting multi-page Tiff images into Jpeg (#6824)
When using 'convert' binary we have to use -flatten argument (the same
as we do with thumbnails) otherwise it will produce multiple output files
with -0, -1, etc. suffix. This way we make sure to generate only one image
until we support multi-page Tiff properly.
5 years ago
Aleksander Machniak 0a0ad2c9b7 Switch to IDNA2008 variant (#6806)
After switching IDNA_NONTRANSITIONAL_TO_ASCII on, switch to
IDNA2008 variant in Net_LDAP2. Add test, update changelog.
5 years ago
Max Bosse f1d3f9ee44 Fix: Use IDNA_NONTRANSITIONAL_TO_UNICODE for idn_to_utf8 call 5 years ago
Max Boße 70c20740e7
Set 'IDNA_NONTRANSITIONAL_TO_ASCII' idn-option 5 years ago
Aleksander Machniak f6807bcc4c Added 'keyservers' option to define list of HKP servers for Enigma/Mailvelope (#6326) 5 years ago
Aleksander Machniak 8932abd2e7 CS fixes 5 years ago
Aleksander Machniak 24913e51d3 Mention Kolab/Net_LDAP3 as a dependency 5 years ago
Aleksander Machniak ed9da6cb7f Memcached: Don't add the same server to the pool many times when using persistent connections 5 years ago
Aleksander Machniak e0792c3287 Skip RSET after authentication failure and QUIT 5 years ago
Aleksander Machniak fdac30e544 Support PECL memcached extension as a session and cache storage driver (experimental) 5 years ago
Aleksander Machniak 4ef87fe856 Support $HasAttachment/$HasNoAttachment keywords (#6201)
We use these only to display the attachment icon on the messages list.
5 years ago
Aleksander Machniak 6e5027ba24 Fix so userlogins and sendmail logs are never put into the per_user_logging folder 5 years ago
Aleksander Machniak 2dccbf2879 Redis: Support connection to unix socket
Also handle exceptions thrown on connection and remove support for
specifying hosts with redis:// scheme.
5 years ago
Amir Caspi 6b5fa52ec1 Update rcube_utils::parse_host, fixes #6746
Updated regexps used in parse_host to ensure that %t, %d, %z do not cut off domain and return only tld when underlying host has no subdomain (i.e., is just domain.tld rather than mail.domain.tld).  Update fixes #6746, now returns nothing shorter than domain.tld.

Also removed backslash from character class, period does not need to be escaped within character class.
5 years ago
Aleksander Machniak 7c8ce07e8c Fix bug where bold/strong text was converted to upper-case on html-to-text conversion (6758) 5 years ago
Aleksander Machniak 0c4d78aa11 Remove language code from charset name as per the RFC2231.5 5 years ago
Aleksander Machniak fe90903fa1 Fix bug in parsing vCard data using PHP 7.3 due to an invalid regexp (#6744)
Looks like \R is not allowed in character class, but \r\n is fine.
On PHP 7.3.5 it throws warnings and empty result from preg_replace(),
though I couldn't reproduce.
5 years ago
Aleksander Machniak f3d16240f2 Fix bug where bmp images couldn't be displayed on some systems (#6728) 5 years ago
Aleksander Machniak e3014de2ce Simplify code around detected mimetype string 5 years ago
Aleksander Machniak 45a6ad1ba7 Fix so an error is logged when more than one attachment plugin has been enabled, initialize the first one (#6735) 5 years ago
Aleksander Machniak 593188559a Fix regression where non-terminating errors were sent to the browser 5 years ago
Aleksander Machniak 55cca61134 Workaround more invalid HTML cases parsed incorrectly by Mastermind/HTML5 (#6713) 5 years ago
Aleksander Machniak fbb5a5bc4f Small code simplification in raise_error() 5 years ago
Aleksander Machniak 02dc6ce41c Don't init the session in CLI mode
This prevents from PHP warnings when using CLI scripts e.g. installto.sh.
5 years ago
Aleksander Machniak 72ad567db6 Add new line at the end of error message in CLI mode 5 years ago
Aleksander Machniak 00173a7622 Update some code documentation 5 years ago
Aleksander Machniak 32612f0b8f Log some more info with session_debug 6 years ago
Aleksander Machniak c87ac075ae Renamed 'log_session' option to 'session_debug' 6 years ago
Aleksander Machniak 57c67db029 Remove year(s) from copyright headers + some cleanup 6 years ago
Aleksander Machniak 69080457b1 Code simplification 6 years ago
Aleksander Machniak 92ed0154d5 Followup fix on handling HTML content w/o html/head/body tag (#6713) 6 years ago
Aleksander Machniak 03d56926d8 Fix bug in HTML parser that could cause missing text fragments when there was no head/body tag (#6713) 6 years ago
Aleksander Machniak 711e46a018 Force HIGHESTMODSEQ use on dovecot
This may fix some messages cache issues. Dovecot does not return
HIGHESTMODSEQ nor NOMODSEQ metadata on SELECT until it is "forced"
to switch to "permanent mod-seq mode". It can be done either by
ENABLE QRESYNC/CONDSTORE or by requesting the metadata explicitely
on SELECT/STATUS. We'll use STATUS for that.
6 years ago
Aleksander Machniak 6f479096d5 Merge branch 'wash-xml-namespace' of https://github.com/dsoares/roundcubemail into dsoares-wash-xml-namespace 6 years ago
Aleksander Machniak a35699637d Fix PHP error when using Net_LDAP3 from master
get_entry() method signature has changed. We don't really needed
that override in rcube_ldap_generic, so it's now removed.
6 years ago
dsoares 00cc13a1b9 Fix bug where HTML messages with a xml:namespace tag were not rendered. 6 years ago
Aleksander Machniak ab7eeb3daa CS fixes 6 years ago
Aleksander Machniak d8488aae32 Disable spellcheker (hide button) if the list of languages is empty
Better handling of uninitialized (not installed) spellchecker engine.
Also prevent from PHP fatal error if enchant ext is not installed.
6 years ago
Aleksander Machniak 641a67fe75 Elastic: Fix unintentional layout preference overwrite (#6613)
This is actually skin-independent mechanism that prevents overwriting
of skin-specific preferences by ajax requests (that until now were
not aware of skin config).
6 years ago
Aleksander Machniak 82974289b9 Fix typo 6 years ago
Aleksander Machniak fe5b4fd81d fputs() -> fwrite() 6 years ago
Aleksander Machniak 61eb78ad64 Fix so ANY record is not used for email domain validation, use A, MX, CNAME, AAAA instead (#6581) 6 years ago
Aleksander Machniak 5693b4f31c Fix bug in parsing some IMAP command responses that include unsolicited replies (#6577) 6 years ago
Aleksander Machniak a7df28093f Make rcube_session::unserialize() public method 6 years ago
Aleksander Machniak 881b344fba Fix regression in vcard parser 6 years ago
Aleksander Machniak 35e2bffb90 Support simple field labels (e.g. LetterHub examples) in csv imports (#6541) 6 years ago
Aleksander Machniak 32a0ad6778 Force session.gc_probability=1 when using custom session handlers (#6560) 6 years ago
Aleksander Machniak d3c65d752b Remove useless "return null;" at the end of function block 6 years ago
Stuart Henderson 98349c19f6 Fix typo LOG_EMERGE (#6566) 6 years ago
Aleksander Machniak 7a49b48dc1 Fix handling of empty entries in vCard import (#6564) 6 years ago
Aleksander Machniak b0c83111de Fix rcube_imap_cache in mode set to MESSAGE only 6 years ago
Aleksander Machniak aa7e2febd1 Add 'required' to the list of boolean attributes 6 years ago
Aleksander Machniak 36485dfc34 Prevent from using deprecated timezone names from jsTimezoneDetect
For better interoperability of plugins such as Calendar, for example
issue see: https://git.kolab.org/T2666.
6 years ago
Aleksander Machniak 943de28d2a Log IMAP/SMTP connection time in debug mode 6 years ago
Aleksander Machniak c1aa2169f6 Plugin API: Added 'ldap_connected' hook 6 years ago
Aleksander Machniak edd9c31d6c Skip registering session handlers when session already exists
.. for a specific use case when I want to create additional rcube_session object
for discrete operations on another session.
6 years ago
Aleksander Machniak afc68aae63 FIx temp_filename() regressions, update changelog, add note in UPGRADING 6 years ago
PhilW e024f133fa give all temp files a constant prefix 6 years ago
Aleksander Machniak 2935b3a66a Fix malformed message saved into Sent folder when using big attachments and low memory limit (#6498) 6 years ago
Aleksander Machniak 7b203cbc52 Fix bug where a message/rfc822 part without a filename wasn't listed on the attachments list (#6494) 6 years ago
Aleksander Machniak 3dad8c5908 Fix incorrect IMAP SASL GSSAPI negotiation (#6308) 6 years ago
Aleksander Machniak c4916a8fe3 Simplify code that uses setError() followed by return 6 years ago
Aleksander Machniak 186f21c4c1 Avoid Referer leaking by using Referrer-Policy:same-origin header (#6385)
Added 'common_headers' hook
6 years ago
Aleksander Machniak c8d133a6a0 Merge branch 'master' into dev/elastic 6 years ago
Aleksander Machniak b126941846 Fix session issue on long running requests (#6470) 6 years ago
Stefanos Petrakis 8ab1e4fbc3 Fix multiple VCard field search (#6466) 6 years ago
Aleksander Machniak 0a0ac045fe Fix bug where valid content between HTML comments could have been skipped in some cases (#6464) 6 years ago
Aleksander Machniak 255638cc44 Update changelog, require Net_SMTP 1.8.1 for GSSAPI support 6 years ago
urusha 75f37f8b0f SMTP GSSAPI support (#6417)
* krb_authentication support for smtp_connect
* smtp GSSAPI support
6 years ago
Aleksander Machniak 2dcf50019c Merge branch 'master' into dev/elastic 6 years ago
Aleksander Machniak e38b477b99 Fix including plugin scripts (regression) 6 years ago
Aleksander Machniak 2c12274d38 Fix style/navigation on error page depending on authentication state (#6362) 6 years ago
Aleksander Machniak 4310046993 Remove redundant trim() 6 years ago