banananetwork
/
roundcubemail
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed index update when there are no cached messages for specified folder

Browse Source 
Improve performance of VANISHED messages handling - use one SQL query
pull/13/head
Aleksander Machniak 12 years ago
parent 7ab9c17752
commit e742744a53
1 changed files with 53 additions and 57 deletions
Show Stats Download Patch File Download Diff File

110
program/include/rcube_imap_cache.php
Unescape Escape View File

@ -516,7 +516,6 @@ class rcube_imap_cache
.($uids !== null ? " AND uid IN (".$this->db->array2list((array)$uids, 'integer').")" : ""), .($uids !== null ? " AND uid IN (".$this->db->array2list((array)$uids, 'integer').")" : ""),
$this->userid, $mailbox); $this->userid, $mailbox);
} }
} }
@ -951,8 +950,10 @@ class rcube_imap_cache
return; return;
} }
// Get known uids $uids = array();
$uids = array(); $removed = array();
// Get known UIDs
$sql_result = $this->db->query( $sql_result = $this->db->query(
"SELECT uid" "SELECT uid"
." FROM ".$this->db->table_name('cache_messages') ." FROM ".$this->db->table_name('cache_messages')
@ -961,74 +962,69 @@ class rcube_imap_cache
$this->userid, $mailbox); $this->userid, $mailbox);
while ($sql_arr = $this->db->fetch_assoc($sql_result)) { while ($sql_arr = $this->db->fetch_assoc($sql_result)) {
$uids[] = $sql_arr['uid']; $uids[] = $sql_arr['uid'];
} }
// No messages in database, nothing to sync // Synchronize messages data
if (empty($uids)) { if (!empty($uids)) {
return; // Get modified flags and vanished messages
} // UID FETCH 1:* (FLAGS) (CHANGEDSINCE 0123456789 VANISHED)
$result = $this->imap->conn->fetch($mailbox,
// Get modified flags and vanished messages $uids, true, array('FLAGS'), $index['modseq'], $qresync);
// UID FETCH 1:* (FLAGS) (CHANGEDSINCE 0123456789 VANISHED)
$result = $this->imap->conn->fetch($mailbox, if (!empty($result)) {
!empty($uids) ? $uids : '1:*', true, array('FLAGS'), foreach ($result as $id => $msg) {
$index['modseq'], $qresync); $uid = $msg->uid;
// Remove deleted message
$invalidated = false; if ($this->skip_deleted && !empty($msg->flags['DELETED'])) {
$removed[] = $uid;
if (!empty($result)) {
foreach ($result as $id => $msg) {
$uid = $msg->uid;
// Remove deleted message
if ($this->skip_deleted && !empty($msg->flags['DELETED'])) {
$this->remove_message($mailbox, $uid);
if (!$invalidated) {
$invalidated = true;
// Invalidate thread indexes (?)
$this->remove_thread($mailbox);
// Invalidate index // Invalidate index
$index['valid'] = false; $index['valid'] = false;
continue;
} }
continue;
}
$flags = 0; $flags = 0;
if (!empty($msg->flags)) { if (!empty($msg->flags)) {
foreach ($this->flags as $idx => $flag) foreach ($this->flags as $idx => $flag) {
if (!empty($msg->flags[$flag])) if (!empty($msg->flags[$flag])) {
$flags += $idx; $flags += $idx;
} }
}
}
$this->db->query( $this->db->query(
"UPDATE ".$this->db->table_name('cache_messages') "UPDATE ".$this->db->table_name('cache_messages')
." SET flags = ?, changed = ".$this->db->now() ." SET flags = ?, changed = ".$this->db->now()
." WHERE user_id = ?" ." WHERE user_id = ?"
." AND mailbox = ?" ." AND mailbox = ?"
." AND uid = ?" ." AND uid = ?"
." AND flags <> ?", ." AND flags <> ?",
$flags, $this->userid, $mailbox, $uid, $flags); $flags, $this->userid, $mailbox, $uid, $flags);
}
} }
}
// Get VANISHED // VANISHED found?
if ($qresync) { if ($qresync) {
$mbox_data = $this->imap->folder_data($mailbox); $mbox_data = $this->imap->folder_data($mailbox);
// Removed messages // Removed messages found
if (!empty($mbox_data['VANISHED'])) {
$uids = rcube_imap_generic::uncompressMessageSet($mbox_data['VANISHED']); $uids = rcube_imap_generic::uncompressMessageSet($mbox_data['VANISHED']);
if (!empty($uids)) { if (!empty($uids)) {
// remove messages from database $removed = array_merge($removed, $uids);
$this->remove_message($mailbox, $uids);
// Invalidate thread indexes (?)
$this->remove_thread($mailbox);
// Invalidate index // Invalidate index
$index['valid'] = false; $index['valid'] = false;
} }
} }
// remove messages from database
if (!empty($removed)) {
$this->remove_message($mailbox, $removed);
}
}
// Invalidate thread index (?)
if (!$index['valid']) {
$this->remove_thread($mailbox);
} }
$sort_field = $index['sort_field']; $sort_field = $index['sort_field'];

Write Preview
Loading…
Cancel
Save