Fixed index update when there are no cached messages for specified folder

Improve performance of VANISHED messages handling - use one SQL query

program/include/rcube_imap_cache.php

@@ -516,7 +516,6 @@ class rcube_imap_cache
                     .($uids !== null ? " AND uid IN (".$this->db->array2list((array)$uids, 'integer').")" : ""),
                 $this->userid, $mailbox);
         }
-
     }
 
 
@@ -951,8 +950,10 @@ class rcube_imap_cache
             return;
         }
 
-        // Get known uids
         $uids    = array();
+        $removed = array();
+
+        // Get known UIDs
         $sql_result = $this->db->query(
             "SELECT uid"
             ." FROM ".$this->db->table_name('cache_messages')
@@ -964,42 +965,32 @@ class rcube_imap_cache
             $uids[] = $sql_arr['uid'];
         }
 
-        // No messages in database, nothing to sync
+        // Synchronize messages data
-        if (empty($uids)) {
+        if (!empty($uids)) {
-            return;
-        }
-
             // Get modified flags and vanished messages
             // UID FETCH 1:* (FLAGS) (CHANGEDSINCE 0123456789 VANISHED)
             $result = $this->imap->conn->fetch($mailbox,
-            !empty($uids) ? $uids : '1:*', true, array('FLAGS'),
+                $uids, true, array('FLAGS'), $index['modseq'], $qresync);
-            $index['modseq'], $qresync);
-
-        $invalidated = false;
 
             if (!empty($result)) {
                 foreach ($result as $id => $msg) {
                     $uid = $msg->uid;
                     // Remove deleted message
                     if ($this->skip_deleted && !empty($msg->flags['DELETED'])) {
-                    $this->remove_message($mailbox, $uid);
+                        $removed[] = $uid;
-
-                    if (!$invalidated) {
-                        $invalidated = true;
-                        // Invalidate thread indexes (?)
-                        $this->remove_thread($mailbox);
                         // Invalidate index
                         $index['valid'] = false;
-                    }
                         continue;
                     }
 
                     $flags = 0;
                     if (!empty($msg->flags)) {
-                    foreach ($this->flags as $idx => $flag)
+                        foreach ($this->flags as $idx => $flag) {
-                        if (!empty($msg->flags[$flag]))
+                            if (!empty($msg->flags[$flag])) {
                                 $flags += $idx;
                             }
+                        }
+                    }
 
                     $this->db->query(
                         "UPDATE ".$this->db->table_name('cache_messages')
@@ -1012,23 +1003,28 @@ class rcube_imap_cache
                 }
             }
 
-        // Get VANISHED
+            // VANISHED found?
             if ($qresync) {
                 $mbox_data = $this->imap->folder_data($mailbox);
 
-            // Removed messages
+                // Removed messages found
-            if (!empty($mbox_data['VANISHED'])) {
                 $uids = rcube_imap_generic::uncompressMessageSet($mbox_data['VANISHED']);
                 if (!empty($uids)) {
-                    // remove messages from database
+                    $removed = array_merge($removed, $uids);
-                    $this->remove_message($mailbox, $uids);
-
-                    // Invalidate thread indexes (?)
-                    $this->remove_thread($mailbox);
                     // Invalidate index
                     $index['valid'] = false;
                 }
             }
+
+            // remove messages from database
+            if (!empty($removed)) {
+                $this->remove_message($mailbox, $removed);
+            }
+        }
+
+        // Invalidate thread index (?)
+        if (!$index['valid']) {
+            $this->remove_thread($mailbox);
         }
 
         $sort_field = $index['sort_field'];