Convert defaultValues to map

pull/618/head
Alex Baker 7 years ago
parent 279942600b
commit eed5efd7a5

@ -17,6 +17,7 @@ import com.todoroo.andlib.utility.AndroidUtilities;
import java.lang.reflect.Array; import java.lang.reflect.Array;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map;
import java.util.Map.Entry; import java.util.Map.Entry;
import timber.log.Timber; import timber.log.Timber;
@ -49,7 +50,7 @@ public abstract class AbstractModel implements Parcelable, Cloneable {
// --- abstract methods // --- abstract methods
/** Get the default values for this object */ /** Get the default values for this object */
abstract public ContentValues getDefaultValues(); abstract public Map<String, Object> getDefaultValues();
// --- data store variables and management // --- data store variables and management
@ -94,9 +95,8 @@ public abstract class AbstractModel implements Parcelable, Cloneable {
public ContentValues getMergedValues() { public ContentValues getMergedValues() {
ContentValues mergedValues = new ContentValues(); ContentValues mergedValues = new ContentValues();
ContentValues defaultValues = getDefaultValues(); for (Map.Entry<String, Object> entry : getDefaultValues().entrySet()) {
if(defaultValues != null) { AndroidUtilities.putInto(mergedValues, entry.getKey(), entry.getValue());
mergedValues.putAll(defaultValues);
} }
if(values != null) { if(values != null) {
mergedValues.putAll(values); mergedValues.putAll(values);

@ -26,6 +26,9 @@ import com.todoroo.andlib.utility.DateUtilities;
import org.tasks.time.DateTime; import org.tasks.time.DateTime;
import java.util.HashMap;
import java.util.Map;
import timber.log.Timber; import timber.log.Timber;
import static org.tasks.date.DateTimeUtils.newDateTime; import static org.tasks.date.DateTimeUtils.newDateTime;
@ -223,7 +226,7 @@ public class Task extends AbstractModel {
// --- defaults // --- defaults
/** Default values container */ /** Default values container */
private static final ContentValues defaultValues = new ContentValues(); private static final Map<String, Object> defaultValues = new HashMap<>();
static { static {
defaultValues.put(TITLE.name, ""); defaultValues.put(TITLE.name, "");
@ -247,7 +250,7 @@ public class Task extends AbstractModel {
} }
@Override @Override
public ContentValues getDefaultValues() { public Map<String, Object> getDefaultValues() {
return defaultValues; return defaultValues;
} }

Loading…
Cancel
Save