From eed5efd7a506aa1bc4ae57e8c54c0337bf97bd55 Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Tue, 23 Jan 2018 15:28:32 -0600
Subject: [PATCH] Convert defaultValues to map

---
 .../main/java/com/todoroo/andlib/data/AbstractModel.java  | 8 ++++----
 app/src/main/java/com/todoroo/astrid/data/Task.java       | 7 +++++--
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/app/src/main/java/com/todoroo/andlib/data/AbstractModel.java b/app/src/main/java/com/todoroo/andlib/data/AbstractModel.java
index 6da7011e9..62fe9fb1f 100644
--- a/app/src/main/java/com/todoroo/andlib/data/AbstractModel.java
+++ b/app/src/main/java/com/todoroo/andlib/data/AbstractModel.java
@@ -17,6 +17,7 @@ import com.todoroo.andlib.utility.AndroidUtilities;
 
 import java.lang.reflect.Array;
 import java.util.HashMap;
+import java.util.Map;
 import java.util.Map.Entry;
 
 import timber.log.Timber;
@@ -49,7 +50,7 @@ public abstract class AbstractModel implements Parcelable, Cloneable {
     // --- abstract methods
 
     /** Get the default values for this object */
-    abstract public ContentValues getDefaultValues();
+    abstract public Map<String, Object> getDefaultValues();
 
     // --- data store variables and management
 
@@ -94,9 +95,8 @@ public abstract class AbstractModel implements Parcelable, Cloneable {
     public ContentValues getMergedValues() {
         ContentValues mergedValues = new ContentValues();
 
-        ContentValues defaultValues = getDefaultValues();
-        if(defaultValues != null) {
-            mergedValues.putAll(defaultValues);
+        for (Map.Entry<String, Object> entry : getDefaultValues().entrySet()) {
+            AndroidUtilities.putInto(mergedValues, entry.getKey(), entry.getValue());
         }
         if(values != null) {
             mergedValues.putAll(values);
diff --git a/app/src/main/java/com/todoroo/astrid/data/Task.java b/app/src/main/java/com/todoroo/astrid/data/Task.java
index 97027e412..331103e47 100644
--- a/app/src/main/java/com/todoroo/astrid/data/Task.java
+++ b/app/src/main/java/com/todoroo/astrid/data/Task.java
@@ -26,6 +26,9 @@ import com.todoroo.andlib.utility.DateUtilities;
 
 import org.tasks.time.DateTime;
 
+import java.util.HashMap;
+import java.util.Map;
+
 import timber.log.Timber;
 
 import static org.tasks.date.DateTimeUtils.newDateTime;
@@ -223,7 +226,7 @@ public class Task extends AbstractModel {
     // --- defaults
 
     /** Default values container */
-    private static final ContentValues defaultValues = new ContentValues();
+    private static final Map<String, Object> defaultValues = new HashMap<>();
 
     static {
         defaultValues.put(TITLE.name, "");
@@ -247,7 +250,7 @@ public class Task extends AbstractModel {
     }
 
     @Override
-    public ContentValues getDefaultValues() {
+    public Map<String, Object> getDefaultValues() {
         return defaultValues;
     }