Fix quiet hours

src/main/java/org/tasks/preferences/Preferences.java

@@ -60,6 +60,14 @@ public class Preferences {
         return getBoolean(R.string.p_rmd_enable_quiet, false);
     }
 
+    public int getQuietHoursStart() {
+        return getMillisPerDayPref(R.string.p_rmd_quietStart, R.integer.default_quiet_hours_start);
+    }
+
+    public int getQuietHoursEnd() {
+        return getMillisPerDayPref(R.string.p_rmd_quietEnd, R.integer.default_quiet_hours_end);
+    }
+
     public int getDateShortcutMorning() {
         return getMillisPerDayPref(R.string.p_date_shortcut_morning, R.integer.default_morning);
     }
@@ -77,9 +85,11 @@ public class Preferences {
     }
 
     private int getMillisPerDayPref(int resId, int defResId) {
-        int defaultValue = context.getResources().getInteger(defResId);
+        int setting = getInt(resId, -1);
-        int setting = getInt(resId, defaultValue);
+        if (setting < 0 || setting > DateTime.MAX_MILLIS_PER_DAY) {
-        return setting < 0 || setting > DateTime.MAX_MILLIS_PER_DAY ? defaultValue : setting;
+            return context.getResources().getInteger(defResId);
+        }
+        return setting;
     }
 
     public boolean isDefaultCalendarSet() {

src/main/java/org/tasks/scheduling/AlarmManager.java

@@ -4,7 +4,6 @@ import android.annotation.SuppressLint;
 import android.app.PendingIntent;
 import android.content.Context;
 
-import org.tasks.R;
 import org.tasks.injection.ForApplication;
 import org.tasks.preferences.Preferences;
 import org.tasks.time.DateTime;
@@ -58,8 +57,8 @@ public class AlarmManager {
     long adjustForQuietHours(long time) {
         if (preferences.quietHoursEnabled()) {
             DateTime dateTime = new DateTime(time);
-            DateTime start = dateTime.withMillisOfDay(preferences.getInt(R.string.p_rmd_quietStart));
+            DateTime start = dateTime.withMillisOfDay(preferences.getQuietHoursStart());
-            DateTime end = dateTime.withMillisOfDay(preferences.getInt(R.string.p_rmd_quietEnd));
+            DateTime end = dateTime.withMillisOfDay(preferences.getQuietHoursEnd());
             if (start.isAfter(end)) {
                 if (dateTime.isBefore(end)) {
                     return end.getMillis();

src/main/java/org/tasks/ui/TimePreference.java

@@ -27,7 +27,7 @@ public class TimePreference extends Preference {
 
     @Override
     protected Object onGetDefaultValue(TypedArray a, int index) {
-        return a.getString(index);
+        return a.getInteger(index, -1);
     }
 
     @Override
@@ -36,7 +36,7 @@ public class TimePreference extends Preference {
             int noon = new DateTime().startOfDay().withHourOfDay(12).getMillisOfDay();
             millisOfDay = getPersistedInt(noon);
         } else {
-            millisOfDay = Integer.parseInt((String) defaultValue);
+            millisOfDay = (Integer) defaultValue;
         }
 
         setMillisOfDay(millisOfDay);