More static analysis

.idea/inspectionProfiles/Project_Default.xml

@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
+  <profile version="1.0">
+    <option name="myName" value="Project Default" />
+    <inspection_tool class="Convert2streamapi" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
+    <inspection_tool class="Guava" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="LoggerInitializedWithForeignClass" enabled="false" level="WARNING" enabled_by_default="false">
+      <option name="loggerClassName" value="org.apache.log4j.Logger,org.slf4j.LoggerFactory,org.apache.commons.logging.LogFactory,java.util.logging.Logger" />
+      <option name="loggerFactoryMethodName" value="getLogger,getLogger,getLog,getLogger" />
+    </inspection_tool>
+    <inspection_tool class="SpellCheckingInspection" enabled="false" level="TYPO" enabled_by_default="false">
+      <option name="processCode" value="true" />
+      <option name="processLiterals" value="true" />
+      <option name="processComments" value="true" />
+    </inspection_tool>
+    <inspection_tool class="StaticPseudoFunctionalStyleMethod" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="TryFinallyCanBeTryWithResources" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="TryWithIdenticalCatches" enabled="false" level="WARNING" enabled_by_default="false" />
+  </profile>
+</component>

lint.xml

@@ -2,6 +2,8 @@
 <lint>
     <issue id="InconsistentArrays" severity="error"/>
     <issue id="MissingTranslation" severity="ignore"/>
+    <issue id="VectorRaster" severity="ignore" />
+
     <issue id="MissingQuantity" severity="ignore"/>
     <issue id="ImpliedQuantity" severity="ignore"/>
 </lint>

src/generic/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+<manifest
     package="org.tasks">
 
     <application/>

src/googleplay/java/com/android/vending/billing/IabException.java

@@ -21,6 +21,7 @@ package com.android.vending.billing;
  * To get the IAB result that caused this exception to be thrown,
  * call {@link #getResult()}.
  */
+@SuppressWarnings("ALL")
 public class IabException extends Exception {
     IabResult mResult;
 

src/googleplay/java/com/android/vending/billing/IabHelper.java

@@ -30,8 +30,6 @@ import android.os.RemoteException;
 import android.text.TextUtils;
 import android.util.Log;
 
-import com.android.vending.billing.IInAppBillingService;
-
 import org.json.JSONException;
 
 import java.util.ArrayList;
@@ -69,6 +67,7 @@ import java.util.concurrent.Executor;
  * has not yet completed will result in an exception being thrown.
  *
  */
+@SuppressWarnings("ALL")
 public class IabHelper {
 
     private final Executor executor;

src/googleplay/java/com/android/vending/billing/IabResult.java

@@ -23,6 +23,7 @@ package com.android.vending.billing;
  * can also inquire whether a result is a success or a failure by
  * calling {@link #isSuccess()} and {@link #isFailure()}.
  */
+@SuppressWarnings("ALL")
 public class IabResult {
     int mResponse;
     String mMessage;

src/googleplay/java/com/android/vending/billing/Inventory.java

@@ -24,6 +24,7 @@ import java.util.Map;
  * Represents a block of information about in-app items.
  * An Inventory is returned by such methods as {@link IabHelper#queryInventory}.
  */
+@SuppressWarnings("ALL")
 public class Inventory {
     Map<String,SkuDetails> mSkuMap = new HashMap<String,SkuDetails>();
     Map<String,Purchase> mPurchaseMap = new HashMap<String,Purchase>();

src/googleplay/java/com/android/vending/billing/Purchase.java

@@ -21,6 +21,7 @@ import org.json.JSONObject;
 /**
  * Represents an in-app billing purchase.
  */
+@SuppressWarnings("ALL")
 public class Purchase {
     String mItemType;  // ITEM_TYPE_INAPP or ITEM_TYPE_SUBS
     String mOrderId;

src/googleplay/java/com/android/vending/billing/Security.java

@@ -37,6 +37,7 @@ import java.security.spec.X509EncodedKeySpec;
  * make it harder for an attacker to replace the code with stubs that treat all
  * purchases as verified.
  */
+@SuppressWarnings("ALL")
 public class Security {
     private static final String TAG = "IABUtil/Security";
 

src/googleplay/java/com/android/vending/billing/SkuDetails.java

@@ -21,6 +21,7 @@ import org.json.JSONObject;
 /**
  * Represents an in-app product's listing details.
  */
+@SuppressWarnings("ALL")
 public class SkuDetails {
     private final String mItemType;
     private final String mSku;

src/googleplay/java/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java

@@ -100,7 +100,7 @@ public class GtasksTaskListUpdater extends OrderedMetadataListUpdater<GtasksList
 
     public void correctOrderAndIndentForList(String listId) {
         orderAndIndentHelper(listId, new AtomicLong(0L), Task.NO_ID, 0,
-                new HashSet<Long>());
+                new HashSet<>());
     }
 
     private void orderAndIndentHelper(final String listId, final AtomicLong order, final long parent, final int indentLevel, final Set<Long> alreadyChecked) {

src/googleplay/java/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java

@@ -99,6 +99,7 @@ public class GtasksSyncService {
 
         @Override
         public void run() {
+            //noinspection InfiniteLoopStatement
             while (true) {
                 SyncOnSaveOperation op;
                 try {

src/main/java/com/todoroo/astrid/core/CustomFilterAdapter.java

@@ -125,7 +125,7 @@ public class CustomFilterAdapter extends ArrayAdapter<CriterionInstance> {
             editText.setText(item.selectedText);
             editText.setHint(textInCriterion.hint);
             frameLayout.addView(editText, new FrameLayout.LayoutParams(
-                    FrameLayout.LayoutParams.FILL_PARENT,
+                    FrameLayout.LayoutParams.MATCH_PARENT,
                     FrameLayout.LayoutParams.WRAP_CONTENT));
             dialog.setView(frameLayout).
                 setPositiveButton(android.R.string.ok, (dialogInterface, which) -> {

src/main/java/com/todoroo/astrid/ui/NNumberPickerDialog.java

@@ -59,10 +59,10 @@ public class NNumberPickerDialog extends AlertDialog implements OnClickListener
 
         setTitle(title);
         LayoutParams npLayout = new LayoutParams(LayoutParams.WRAP_CONTENT,
-                LayoutParams.FILL_PARENT);
+                LayoutParams.MATCH_PARENT);
         npLayout.gravity = 1;
         LayoutParams sepLayout = new LayoutParams(LayoutParams.WRAP_CONTENT,
-                LayoutParams.FILL_PARENT);
+                LayoutParams.MATCH_PARENT);
         for(int i = 0; i < incrementBy.length; i++) {
             NumberPicker np = new NumberPicker(context, null);
             np.setIncrementBy(incrementBy[i]);

src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java

@@ -23,12 +23,11 @@ import org.tasks.R;
  */
 public class RandomReminderControlSet {
 
-    private final Spinner periodSpinner;
     private int selectedIndex;
     private final int[] hours;
 
     public RandomReminderControlSet(Context context, View parentView, long reminderPeriod) {
-        periodSpinner = (Spinner) parentView.findViewById(R.id.reminder_random_interval);
+        Spinner periodSpinner = (Spinner) parentView.findViewById(R.id.reminder_random_interval);
         periodSpinner.setVisibility(View.VISIBLE);
         // create adapter
         ArrayAdapter<String> adapter = new ArrayAdapter<>(

src/main/java/org/tasks/filters/FilterCounter.java

@@ -33,7 +33,7 @@ public class FilterCounter {
 
     @Inject
     public FilterCounter(TaskDao taskDao) {
-        this(taskDao, new ThreadPoolExecutor(0, 1, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>()));
+        this(taskDao, new ThreadPoolExecutor(0, 1, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<>()));
     }
 
     FilterCounter(TaskDao taskDao, ExecutorService executorService) {

src/main/java/org/tasks/injection/InjectingPreferenceActivity.java

@@ -93,7 +93,7 @@ public abstract class InjectingPreferenceActivity extends AppCompatPreferenceAct
         }
     }
 
-    @SuppressWarnings("deprecation")
+    @SuppressWarnings({"deprecation", "EmptyMethod"})
     @Override
     public void addPreferencesFromResource(int preferencesResId) {
         super.addPreferencesFromResource(preferencesResId);

src/main/java/org/tasks/locale/Locale.java

@@ -1,10 +1,12 @@
 package org.tasks.locale;
 
 import android.annotation.SuppressLint;
+import android.annotation.TargetApi;
 import android.app.Dialog;
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.content.res.Configuration;
+import android.os.Build;
 import android.preference.PreferenceManager;
 import android.support.v4.text.TextUtilsCompat;
 import android.view.ContextThemeWrapper;
@@ -111,6 +113,7 @@ public class Locale {
                 : context;
     }
 
+    @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
     private Configuration getLocaleConfiguration() {
         Configuration configuration = new Configuration();
         configuration.locale = getLocale();

src/main/java/org/tasks/themes/ThemeColor.java

@@ -1,9 +1,11 @@
 package org.tasks.themes;
 
 import android.annotation.SuppressLint;
+import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.ActivityManager;
 import android.content.res.Resources;
+import android.os.Build;
 import android.support.v4.widget.DrawerLayout;
 import android.support.v7.widget.Toolbar;
 import android.view.View;
@@ -78,6 +80,7 @@ public class ThemeColor {
         }
     }
 
+    @TargetApi(Build.VERSION_CODES.M)
     private int applyLightStatusBarFlag(int flag) {
         return isDark
                 ? flag | View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR

src/main/java/org/tasks/ui/HiddenTopArrayAdapter.java

@@ -17,7 +17,7 @@ public class HiddenTopArrayAdapter<T> extends ArrayAdapter<T> {
     private List<String> hints;
 
     public HiddenTopArrayAdapter(Context context, int resources, List<T> objects) {
-        this(context, resources, objects, new ArrayList<String>());
+        this(context, resources, objects, new ArrayList<>());
     }
 
     public HiddenTopArrayAdapter(Context context, int resource, List<T> objects, List<String> hints) {

src/main/java/org/tasks/ui/ScrimInsetsFrameLayout.java

@@ -136,7 +136,7 @@ public class ScrimInsetsFrameLayout extends FrameLayout {
         mOnInsetsCallback = onInsetsCallback;
     }
 
-    public static interface OnInsetsCallback {
+    public interface OnInsetsCallback {
-        public void onInsetsChanged(Rect insets);
+        void onInsetsChanged(Rect insets);
     }
 }