diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
new file mode 100644
index 000000000..fd3f3fa52
--- /dev/null
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -0,0 +1,19 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/lint.xml b/lint.xml
index 65405bb9e..d03bdf1cb 100644
--- a/lint.xml
+++ b/lint.xml
@@ -2,6 +2,8 @@
+
+
diff --git a/src/generic/AndroidManifest.xml b/src/generic/AndroidManifest.xml
index 562d64975..aeb4d279e 100644
--- a/src/generic/AndroidManifest.xml
+++ b/src/generic/AndroidManifest.xml
@@ -1,5 +1,5 @@
-
diff --git a/src/googleplay/java/com/android/vending/billing/IabException.java b/src/googleplay/java/com/android/vending/billing/IabException.java
index 2732b93e8..2342b39b1 100644
--- a/src/googleplay/java/com/android/vending/billing/IabException.java
+++ b/src/googleplay/java/com/android/vending/billing/IabException.java
@@ -21,6 +21,7 @@ package com.android.vending.billing;
* To get the IAB result that caused this exception to be thrown,
* call {@link #getResult()}.
*/
+@SuppressWarnings("ALL")
public class IabException extends Exception {
IabResult mResult;
diff --git a/src/googleplay/java/com/android/vending/billing/IabHelper.java b/src/googleplay/java/com/android/vending/billing/IabHelper.java
index d73a73ce6..a39321103 100644
--- a/src/googleplay/java/com/android/vending/billing/IabHelper.java
+++ b/src/googleplay/java/com/android/vending/billing/IabHelper.java
@@ -30,8 +30,6 @@ import android.os.RemoteException;
import android.text.TextUtils;
import android.util.Log;
-import com.android.vending.billing.IInAppBillingService;
-
import org.json.JSONException;
import java.util.ArrayList;
@@ -69,6 +67,7 @@ import java.util.concurrent.Executor;
* has not yet completed will result in an exception being thrown.
*
*/
+@SuppressWarnings("ALL")
public class IabHelper {
private final Executor executor;
diff --git a/src/googleplay/java/com/android/vending/billing/IabResult.java b/src/googleplay/java/com/android/vending/billing/IabResult.java
index 0357575a5..94b9ba36b 100644
--- a/src/googleplay/java/com/android/vending/billing/IabResult.java
+++ b/src/googleplay/java/com/android/vending/billing/IabResult.java
@@ -23,6 +23,7 @@ package com.android.vending.billing;
* can also inquire whether a result is a success or a failure by
* calling {@link #isSuccess()} and {@link #isFailure()}.
*/
+@SuppressWarnings("ALL")
public class IabResult {
int mResponse;
String mMessage;
diff --git a/src/googleplay/java/com/android/vending/billing/Inventory.java b/src/googleplay/java/com/android/vending/billing/Inventory.java
index fbf06ed44..ec40a1a59 100644
--- a/src/googleplay/java/com/android/vending/billing/Inventory.java
+++ b/src/googleplay/java/com/android/vending/billing/Inventory.java
@@ -24,6 +24,7 @@ import java.util.Map;
* Represents a block of information about in-app items.
* An Inventory is returned by such methods as {@link IabHelper#queryInventory}.
*/
+@SuppressWarnings("ALL")
public class Inventory {
Map mSkuMap = new HashMap();
Map mPurchaseMap = new HashMap();
diff --git a/src/googleplay/java/com/android/vending/billing/Purchase.java b/src/googleplay/java/com/android/vending/billing/Purchase.java
index 553484a05..82a98ef9b 100644
--- a/src/googleplay/java/com/android/vending/billing/Purchase.java
+++ b/src/googleplay/java/com/android/vending/billing/Purchase.java
@@ -21,6 +21,7 @@ import org.json.JSONObject;
/**
* Represents an in-app billing purchase.
*/
+@SuppressWarnings("ALL")
public class Purchase {
String mItemType; // ITEM_TYPE_INAPP or ITEM_TYPE_SUBS
String mOrderId;
diff --git a/src/googleplay/java/com/android/vending/billing/Security.java b/src/googleplay/java/com/android/vending/billing/Security.java
index f5613c09b..88deb4585 100644
--- a/src/googleplay/java/com/android/vending/billing/Security.java
+++ b/src/googleplay/java/com/android/vending/billing/Security.java
@@ -37,6 +37,7 @@ import java.security.spec.X509EncodedKeySpec;
* make it harder for an attacker to replace the code with stubs that treat all
* purchases as verified.
*/
+@SuppressWarnings("ALL")
public class Security {
private static final String TAG = "IABUtil/Security";
diff --git a/src/googleplay/java/com/android/vending/billing/SkuDetails.java b/src/googleplay/java/com/android/vending/billing/SkuDetails.java
index df20529c6..5e1249f19 100644
--- a/src/googleplay/java/com/android/vending/billing/SkuDetails.java
+++ b/src/googleplay/java/com/android/vending/billing/SkuDetails.java
@@ -21,6 +21,7 @@ import org.json.JSONObject;
/**
* Represents an in-app product's listing details.
*/
+@SuppressWarnings("ALL")
public class SkuDetails {
private final String mItemType;
private final String mSku;
diff --git a/src/googleplay/java/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java b/src/googleplay/java/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java
index bd588f7d5..00be4232d 100644
--- a/src/googleplay/java/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java
+++ b/src/googleplay/java/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java
@@ -100,7 +100,7 @@ public class GtasksTaskListUpdater extends OrderedMetadataListUpdater());
+ new HashSet<>());
}
private void orderAndIndentHelper(final String listId, final AtomicLong order, final long parent, final int indentLevel, final Set alreadyChecked) {
diff --git a/src/googleplay/java/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java b/src/googleplay/java/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java
index 464732eab..036aad65c 100644
--- a/src/googleplay/java/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java
+++ b/src/googleplay/java/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java
@@ -99,6 +99,7 @@ public class GtasksSyncService {
@Override
public void run() {
+ //noinspection InfiniteLoopStatement
while (true) {
SyncOnSaveOperation op;
try {
diff --git a/src/main/java/com/todoroo/astrid/core/CustomFilterAdapter.java b/src/main/java/com/todoroo/astrid/core/CustomFilterAdapter.java
index b6efe9056..77bd0ff36 100644
--- a/src/main/java/com/todoroo/astrid/core/CustomFilterAdapter.java
+++ b/src/main/java/com/todoroo/astrid/core/CustomFilterAdapter.java
@@ -125,7 +125,7 @@ public class CustomFilterAdapter extends ArrayAdapter {
editText.setText(item.selectedText);
editText.setHint(textInCriterion.hint);
frameLayout.addView(editText, new FrameLayout.LayoutParams(
- FrameLayout.LayoutParams.FILL_PARENT,
+ FrameLayout.LayoutParams.MATCH_PARENT,
FrameLayout.LayoutParams.WRAP_CONTENT));
dialog.setView(frameLayout).
setPositiveButton(android.R.string.ok, (dialogInterface, which) -> {
diff --git a/src/main/java/com/todoroo/astrid/ui/NNumberPickerDialog.java b/src/main/java/com/todoroo/astrid/ui/NNumberPickerDialog.java
index b49af985a..679cc1cc5 100644
--- a/src/main/java/com/todoroo/astrid/ui/NNumberPickerDialog.java
+++ b/src/main/java/com/todoroo/astrid/ui/NNumberPickerDialog.java
@@ -59,10 +59,10 @@ public class NNumberPickerDialog extends AlertDialog implements OnClickListener
setTitle(title);
LayoutParams npLayout = new LayoutParams(LayoutParams.WRAP_CONTENT,
- LayoutParams.FILL_PARENT);
+ LayoutParams.MATCH_PARENT);
npLayout.gravity = 1;
LayoutParams sepLayout = new LayoutParams(LayoutParams.WRAP_CONTENT,
- LayoutParams.FILL_PARENT);
+ LayoutParams.MATCH_PARENT);
for(int i = 0; i < incrementBy.length; i++) {
NumberPicker np = new NumberPicker(context, null);
np.setIncrementBy(incrementBy[i]);
diff --git a/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java b/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java
index f704ebed7..6178bb67a 100644
--- a/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java
+++ b/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java
@@ -23,12 +23,11 @@ import org.tasks.R;
*/
public class RandomReminderControlSet {
- private final Spinner periodSpinner;
private int selectedIndex;
private final int[] hours;
public RandomReminderControlSet(Context context, View parentView, long reminderPeriod) {
- periodSpinner = (Spinner) parentView.findViewById(R.id.reminder_random_interval);
+ Spinner periodSpinner = (Spinner) parentView.findViewById(R.id.reminder_random_interval);
periodSpinner.setVisibility(View.VISIBLE);
// create adapter
ArrayAdapter adapter = new ArrayAdapter<>(
diff --git a/src/main/java/org/tasks/filters/FilterCounter.java b/src/main/java/org/tasks/filters/FilterCounter.java
index 2fc92610c..91c1ab3eb 100644
--- a/src/main/java/org/tasks/filters/FilterCounter.java
+++ b/src/main/java/org/tasks/filters/FilterCounter.java
@@ -33,7 +33,7 @@ public class FilterCounter {
@Inject
public FilterCounter(TaskDao taskDao) {
- this(taskDao, new ThreadPoolExecutor(0, 1, 1, TimeUnit.SECONDS, new LinkedBlockingQueue()));
+ this(taskDao, new ThreadPoolExecutor(0, 1, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<>()));
}
FilterCounter(TaskDao taskDao, ExecutorService executorService) {
diff --git a/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java b/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java
index c787ae69c..5dab206df 100644
--- a/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java
+++ b/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java
@@ -93,7 +93,7 @@ public abstract class InjectingPreferenceActivity extends AppCompatPreferenceAct
}
}
- @SuppressWarnings("deprecation")
+ @SuppressWarnings({"deprecation", "EmptyMethod"})
@Override
public void addPreferencesFromResource(int preferencesResId) {
super.addPreferencesFromResource(preferencesResId);
diff --git a/src/main/java/org/tasks/locale/Locale.java b/src/main/java/org/tasks/locale/Locale.java
index e5a5e36f5..a20d1f02b 100644
--- a/src/main/java/org/tasks/locale/Locale.java
+++ b/src/main/java/org/tasks/locale/Locale.java
@@ -1,10 +1,12 @@
package org.tasks.locale;
import android.annotation.SuppressLint;
+import android.annotation.TargetApi;
import android.app.Dialog;
import android.content.Context;
import android.content.SharedPreferences;
import android.content.res.Configuration;
+import android.os.Build;
import android.preference.PreferenceManager;
import android.support.v4.text.TextUtilsCompat;
import android.view.ContextThemeWrapper;
@@ -111,6 +113,7 @@ public class Locale {
: context;
}
+ @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
private Configuration getLocaleConfiguration() {
Configuration configuration = new Configuration();
configuration.locale = getLocale();
diff --git a/src/main/java/org/tasks/themes/ThemeColor.java b/src/main/java/org/tasks/themes/ThemeColor.java
index 5c65095db..648d8e69d 100644
--- a/src/main/java/org/tasks/themes/ThemeColor.java
+++ b/src/main/java/org/tasks/themes/ThemeColor.java
@@ -1,9 +1,11 @@
package org.tasks.themes;
import android.annotation.SuppressLint;
+import android.annotation.TargetApi;
import android.app.Activity;
import android.app.ActivityManager;
import android.content.res.Resources;
+import android.os.Build;
import android.support.v4.widget.DrawerLayout;
import android.support.v7.widget.Toolbar;
import android.view.View;
@@ -78,6 +80,7 @@ public class ThemeColor {
}
}
+ @TargetApi(Build.VERSION_CODES.M)
private int applyLightStatusBarFlag(int flag) {
return isDark
? flag | View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR
diff --git a/src/main/java/org/tasks/ui/HiddenTopArrayAdapter.java b/src/main/java/org/tasks/ui/HiddenTopArrayAdapter.java
index 09bf9802d..1b9a7aded 100644
--- a/src/main/java/org/tasks/ui/HiddenTopArrayAdapter.java
+++ b/src/main/java/org/tasks/ui/HiddenTopArrayAdapter.java
@@ -17,7 +17,7 @@ public class HiddenTopArrayAdapter extends ArrayAdapter {
private List hints;
public HiddenTopArrayAdapter(Context context, int resources, List objects) {
- this(context, resources, objects, new ArrayList());
+ this(context, resources, objects, new ArrayList<>());
}
public HiddenTopArrayAdapter(Context context, int resource, List objects, List hints) {
diff --git a/src/main/java/org/tasks/ui/ScrimInsetsFrameLayout.java b/src/main/java/org/tasks/ui/ScrimInsetsFrameLayout.java
index 1d06c22cd..c1d3b47df 100644
--- a/src/main/java/org/tasks/ui/ScrimInsetsFrameLayout.java
+++ b/src/main/java/org/tasks/ui/ScrimInsetsFrameLayout.java
@@ -136,7 +136,7 @@ public class ScrimInsetsFrameLayout extends FrameLayout {
mOnInsetsCallback = onInsetsCallback;
}
- public static interface OnInsetsCallback {
- public void onInsetsChanged(Rect insets);
+ public interface OnInsetsCallback {
+ void onInsetsChanged(Rect insets);
}
}
\ No newline at end of file