tailscale

Commit Graph

Author	SHA1	Message	Date
Denton Gentry	b771a1363b	logtail: start a local server for TestFastShutdown Right now TestFastShutdown tries to upload logs to localhost:1234, which will most likely respond with an error. However if one has an actual service running on port 1234, it would receive a connection attempting to POST every time the unit test runs. Start a local server and direct the upload there instead. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	2e9728023b	magicsock: test error case in sendDiscoMessage In sendDiscoMessage there is a check of whether the connection is closed, which is not being reliably exercised by other tests. This shows up in code coverage reports, the lines of code in sendDiscoMessage are alternately added and subtracted from code coverage. Add a test to specifically exercise and verify this code path. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	2c328da094	logtail: add a test to upload logs to local server Start an HTTP server to accept POST requests, and upload some logs to it. Check that uploaded logs were received. Code in logtail:drainPending was not being reliably exercised by other tests. This shows up in code coverage reports, as lines of code in drainPending are alternately added and subtracted from code coverage. This test will reliably exercise and verify this code. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	0aed59b691	portlist: add a test for SameInodes Exercise all cases. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	07e4009e15	portlist: fully exercise lessThan in tests All cases in lessThan are not reliably exercised by other tests. This shows up in code coverage metrics as lines in lessThan are alternately added and removed from coverage. Add a test case to systematically test all conditions. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	0aa55bffce	magicsock: test error case in derpWriteChanOfAddr In derpWriteChanOfAddr when we call derphttp.NewRegionClient(), there is a check of whether the connection is already errored and if so it returns before grabbing the lock. The lock might already be held and would be a deadlock. This corner case is not being reliably exercised by other tests. This shows up in code coverage reports, the lines of code in derpWriteChanOfAddr are alternately added and subtracted from code coverage. Add a test to specifically exercise this code path, and verify that it doesn't deadlock. This is the best tradeoff I could come up with: + the moment code calls Err() to check if there is an error, we grab the lock to make sure it would deadlock if it tries to grab the lock itself. + if a new call to Err() is added in this code path, only the first one will be covered and the rest will not be tested. + this test doesn't verify whether code is checking for Err() in the right place, which ideally I guess it would. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Brad Fitzpatrick	85e54af0d7	wgengine: on TCP connect fail/timeout, log some clues about why it failed So users can see why things aren't working. A start. More diagnostics coming. Updates #1094	4 years ago
Brad Fitzpatrick	5eeaea9ef9	net/packet: add TCPFlag type and some more constants Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ad3fb6125d	net/flowtrack: add Tuple.String method Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	d6e9fb1df0	all: adjust Unix permissions for those without umasks Fixes tailscale/corp#1165 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	6b08303b0f	Dockerfile: add big warning banner Updates #504	4 years ago
Brad Fitzpatrick	676b5b7946	net/netcheck: improve the preferred DERP hysteresis Users in Amsterdam (as one example) were flipping back and forth between equidistant London & Frankfurt relays too much. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Sonia Appasamy	024671406b	ipn: only send services in Hostinfo if Tailnet has opted-in to services collection (#1107 ) Signed-off-by: Sonia Appasamy <sonia@tailscale.com>	4 years ago
Brad Fitzpatrick	f85769b1ed	wgengine/magicsock: drop netaddr.IPPort cache netaddr.IP no longer allocates, so don't need a cache or all its associated code/complexity. This totally removes groupcache/lru from the deps. Also go mod tidy.	4 years ago
Brad Fitzpatrick	a80446c026	Update depaware (removes lru from wgengine/filter)	4 years ago
Brad Fitzpatrick	4d15e954bd	net/flowtrack: add new package to specialize groupcache/lru key type Reduces allocs. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Naman Sood	f69e46175d	wengine/netstack: bump gvisor to latest version * wengine/netstack: bump gvisor to latest version Signed-off-by: Naman Sood <naman@tailscale.com> * update dependencies Signed-off-by: Naman Sood <naman@tailscale.com> * Don't change hardcoded IP Signed-off-by: Naman Sood <naman@tailscale.com>	4 years ago
Brad Fitzpatrick	8b0112649a	wgengine/netstack: don't build netstack on 32-bit platforms See google/gvisor#5241	4 years ago
Brad Fitzpatrick	5aa5db89d6	cmd/tailscaled, wgengine/netstack: add start of gvisor userspace netstack work Not usefully functional yet (mostly a proof of concept), but getting it submitted for some work @namansood is going to do atop this. Updates #707 Updates #634 Updates #48 Updates #835	4 years ago
Brad Fitzpatrick	5efb0a8bca	cmd/tailscale: change formatting of "tailscale status" * show DNS name over hostname, removing domain's common MagicDNS suffix. only show hostname if there's no DNS name. but still show shared devices' MagicDNS FQDN. * remove nerdy low-level details by default: endpoints, DERP relay, public key. They're available in JSON mode still for those who need them. * only show endpoint or DERP relay when it's active with the goal of making debugging easier. (so it's easier for users to understand what's happening) The asterisks are gone. * remove Tx/Rx numbers by default for idle peers; only show them when there's traffic. * include peers' owner login names * add CLI option to not show peers (matching --self=true, --peers= also defaults to true) * sort by DNS/host name, not public key * reorder columns	4 years ago
Brad Fitzpatrick	c09d5a9e28	go.mod: bump wireguard-go to match our meta repo	4 years ago
Brad Fitzpatrick	b5b9866ba2	wgengine/magicsock: copy self DNS name to PeerStatus, re-fill OS The OS used to be sent back from the server but that has since been removed as being redundant.	4 years ago
Brad Fitzpatrick	a4cc31e7d8	go.sum: update	4 years ago
Josh Bleecher Snyder	1271e135cd	wgengine/tstun: initialize wireguard-go TUN parameters This will enable us to remove the corresponding code from our fork of wireguard-go. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	18471a8792	ipn: close logger at the end of TestLocalLogLines If any goroutine continues to use the logger in TestLocalLogLines after the test finishes, the test panics. The culprit for this was wireguard-go; the previous commit fixed that. This commit adds suspenders: When the test is done, make logging calls into no-ops. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	1e4604f60e	wgengine: quiet some wireguard-go logging The log lines that wireguard-go prints as it starts and stops its worker routines are mostly noise. They also happen after other work is completed, which causes failures in some of the log testing packages. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	c580d2eab1	go.mod: change wireguard-go version spelling Our toolchains disagree about the spelling. Sigh. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	53f9dcdf05	go.mod: update wireguard-go to fix windows build failure Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	80c33f4fa1	go.mod: update to latest wireguard-go	4 years ago
Josh Bleecher Snyder	e0c4ffa71f	wgengine/tsdns: respond with any available addrs for ALL queries This appears to have been the intent of the previous code, but in practice, it only returned A records. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Denton Gentry	fa3e8e1a28	Add names to test cases in ipn/local_test.go. There are so many now that just a number doesn't work well. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	67ebc7c0e7	Allow 2021 in LICENSE header. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	02c34881b5	Add more tests for Direct. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	df64b7abf8	Add IPv6 Reverse DNS Lookup test. To be honest I'm not fond of Golden Bytes tests like this, but not so much as to want to rewrite the whole test. The DNS byte format is essentially immutable at this point, the encoded bytes aren't going to change. The rest of the test assumptions about hostnames might, but we can fix that when it comes. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	414cb4a695	Add test for dnsMapsEqual. Exercises most cases in the function. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	b716c76df9	cover one more case in TestStatusEqual. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Brad Fitzpatrick	2f04f49376	control/controlclient: use lite map request handler to avoid aborting streams Previously, any change to endpoints or hostinfo (or hostinfo's netinfo) would result in the long-running map request HTTP stream being torn down and restarted, losing all compression context along with it. This change makes us instead send a lite map request (OmitPeers: true, Stream: false) that doesn't subscribe to anything, and then the coordination server knows to not close other streams for that node when it recives a lite request. Fixes tailscale/corp#797 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Denton Gentry	e692e3866b	Cache go modules. Apply Go actions cache, as described in https://markphelps.me/2019/11/speed-up-your-go-builds-with-actions-cache/ Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	d12add6e22	Adjust coverage options. + we don't need an exactly accurate count of the number of times each time ran. Remove -covermode, the default "set" will be fine to just track whether a given line ran at all. + add -benchtime=1x. We only need to run the benchmarks once. + -bench=. to match any character. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	332759ef73	Add coveralls.io support. We include -bench because some parts of the codebase, like smallzstd, do not have regular unit tests but do have very good benchmark tests that covers all functions. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Alex Brainman	9985b3f1ed	wgengine/monitor: close closeHandle `eccc167` introduced closeHandle which opened the handle, but never closed it. Windows handles should be closed. Updates #921 Signed-off-by: Alex Brainman <alex.brainman@gmail.com>	4 years ago
Frederik “Freso” S. Olesen	83fccf9fe5	tailscaled.service: Lock down clock and /dev (#1071 ) Research in issue #1063 uncovered why tailscaled would fail with ProtectClock enabled (it implicitly enabled DevicePolicy=closed). This knowledge in turn also opens the door for locking down /dev further, e.g. explicitly setting DevicePolicy=strict (instead of closed), and making /dev private for the unit. Additional possible future (or downstream) lockdown that can be done is setting `PrivateDevices=true` (with `BindPaths=/dev/net/`), however, systemd 233 or later is required for this, and tailscaled currently need to work for systemd down to version 215. Closes https://github.com/tailscale/tailscale/issues/1063 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>	4 years ago
Brad Fitzpatrick	b5129dadfd	ipn: fix buggy-looking format string in error log On shutdown, logs showed: wgengine status error: &errors.errorString{s:"engine closing; no status"}	4 years ago
Brad Fitzpatrick	66be052a70	net/dnscache: work on IPv6-only hosts (again) This fixes the regression where we had stopped working on IPv6-only hosts. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	560da4884f	tailcfg: add Node.Sharer field Updates #992 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christina Wen	d8a5b3f22f	API.md: revise documentation to be more consistent Signed-off-by: Christina Wen <christina@tailscale.com>	4 years ago
Christina Wen	3e3bd5f169	API.md: release API documentation Co-authored-by: Daniel Chung <daniel@tailscale.com> Signed-off-by: Christina Wen <christina@tailscale.com>	4 years ago
Brad Fitzpatrick	312646c516	tailcfg: add omitempty to FilterRule.SrcBits (#1089 ) It's not used by recent clients, so even more reason to omit it. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	e8ae355bb8	ipn: delete domainsForProxying, require explicit DNS search domains (mapver 9) (#1078 ) Previously the client had heuristics to calculate which DNS search domains to set, based on the peers' names. Unfortunately that prevented us from doing some things we wanted to do server-side related to node sharing. So, bump MapRequest.Version to 9 to signal that the client only uses the explicitly configured DNS search domains and doesn't augment it with its own list. Updates tailscale/corp#1026 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	1ccf997699	version: new version for a new year	4 years ago

1 2 3 4 5 ...

1581 Commits (b771a1363b90930619dcb85e6cf154566d286722) All Branches Search

1581 Commits (b771a1363b90930619dcb85e6cf154566d286722)

All Branches