Commit Graph

479 Commits (deb532c367f0beb41553e028a03def50f05a2ff9)

Author SHA1 Message Date
Michael DeHaan 5aef2f0687 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
11 years ago
Cristian Ciupitu 138b45e32f hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
11 years ago
Cristian Ciupitu 0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
James Tanner 9d6518de5a Fixes #6482 Check sysctl file path and catch read exceptions 11 years ago
Michael DeHaan 4e8b97ddeb More shell updates 11 years ago
Richard C Isaacson 154f123b7f setup module: Mark unsafe commands as use_unsafe_shell=True. 11 years ago
Ryan e4805fe411 add module param to Network & sub-classes
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
11 years ago
Michael DeHaan c8db3c2db9 Revert "Fix issue#6430 by instantiating Network() with expected arguments"
This reverts commit 2a723e908e.
11 years ago
James Laska 2a723e908e Fix issue#6430 by instantiating Network() with expected arguments 11 years ago
Richard C Isaacson a1c87e6deb Fix docstring issue. 11 years ago
Richard Isaacson 6e13c1ebe0 Merge pull request #6406 from risaacson/at_module2
This fixes what was merged in 1.5.0.
11 years ago
James Tanner c73cb77689 Fix name in locale_gen docstring 11 years ago
James Tanner 41b7badb13 Fix snippet imports and version_added in ufw module 11 years ago
James Cammarata 1d6750afec Merge pull request #5518 from pyykkis/ufw
UFW module (another take)
11 years ago
James Tanner 8ffb964f45 Set version_added for locale_gen 11 years ago
James Tanner da95310d86 Rename locale module to locale_gen 11 years ago
James Cammarata 74335b6e59 Merge pull request #5411 from AugustusKling/locale
locale module
11 years ago
Michael DeHaan fd9df5f429 Merge pull request #6372 from mriedelumab/devel
Returning 'NA' when no virtualization found
11 years ago
James Tanner ba0fec4f42 Force command action to not be executed by the shell unless specifically enabled 11 years ago
Matthew Riedel 5875d19f4d Returning 'NA' when no virtualization found 11 years ago
Richard C Isaacson c6fbb0059b Some cleanup. 11 years ago
Charles Duffy 18f53d9219 #6341: use shared function for parsing systemd status; check rc code 11 years ago
Charles Duffy d59973295d #6341: check systemd service status with show subcommand 11 years ago
Jarno Keskikangas 37ef39d0fa Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
11 years ago
Jarno Keskikangas 4d5340587e Insert rule to a specific num. 11 years ago
Jarno Keskikangas 0247708199 Fix typo: 'reseted' -> 'reset'. 11 years ago
Jarno Keskikangas 2613e6fb14 Add protocol options 'esp' and 'ah'. 11 years ago
Jarno Keskikangas f4e8a86c87 Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
11 years ago
Aleksey Ovcharenko 651c04a3ec New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
11 years ago
Richard C Isaacson aba86e3657 Cleaning up pep8 alerts. 11 years ago
Richard C Isaacson f3c1177265 Documentation cleanup. 11 years ago
Richard C Isaacson 7686204b43 Refactored a few things to be more inline with the Ansible way. Passing testing. 11 years ago
Charles Duffy 44ebd3f4f3 systemd template services must not discard template part 11 years ago
jctanner 6a615f18c5 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
11 years ago
Julien DAUPHANT 16bb6c88f5 Add version_added 1.6 for the params modprobe option 11 years ago
Julien DAUPHANT daa7416323 Add linux module parameters for the modprobe module 11 years ago
anatoly techtonik a48f0da9d8 setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 11 years ago
James Tanner 39e368b713 Fix debconf docstring indentation 11 years ago
James Tanner ff1ae57fbf Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 11 years ago
Brian Coca 400a1aa49a didnt make 1.5 ... lets see 11 years ago
Brian Coca 68510ecda8 added better gentoo/funtoo support 11 years ago
Michael DeHaan 9d3a344c06 Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
11 years ago
Laurens Van Houtven 80e2c597a8 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
11 years ago
James Cammarata 57486b268a Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
11 years ago
Dustin C. Hatch 467914e3c3 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
11 years ago
Chris Church 1d6bdd451b Fix setup module to gather facts from PowerPC Macs. 11 years ago
James Cammarata 6fe369fca0 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
11 years ago
Stefan J. Betz 789ae4697c Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
11 years ago
Richard C Isaacson bf30707670 If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
11 years ago
Matt Jeffery 8131feaade Normalise the module name when comparing against the module names in /proc/modules. 11 years ago
C. Morgan Hamill 5776c95497 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
11 years ago
Nils Pascal Illenseer 858004984b Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
11 years ago
Richard C Isaacson 7d670f8308 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 11 years ago
Peter Gehres c427a829a0 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
Sean Chittenden 5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
11 years ago
Brian Coca f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
11 years ago
Brian Coca a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
11 years ago
Brian Coca 0233584343 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca de956c57fe changes names to name in example 11 years ago
Brian Coca 453d473728 fixes as per feedback 11 years ago
Tom Dymond 486d14cb2d Reworked PR to avoid repeating the command 11 years ago
jctanner 5967b463c9 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Tom Dymond cf80f9b68b Add option to enable the sysctl -e option 11 years ago
kustodian a7839208c7 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Aaron Lindsay 59ac969d2b Add move_home option to user module 11 years ago
Richard C Isaacson 7a2df2733f Tested implementation adding action option for (add, delete, unique). 11 years ago
Richard C Isaacson c198217900 Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson cd871384de Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson b00939acff Change to dynamically pick up the command from the PATH. 11 years ago
Richard C Isaacson 9650c118cf Formating and syntax fixes that were pointed out during code review. 11 years ago
Richard C Isaacson ec04e30186 Added user option. 11 years ago
Richard C Isaacson 3a7e579bc2 First commit of the at module being very basic. 11 years ago
Brian Coca 46dfe07181 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Jakub Jirutka 8c9a63bcd0 sysctl: parse bool value as 0/1 and refactor a little bit 11 years ago
Thoai Nguyen 5c4bb5730e reorder usermod options 11 years ago
jctanner 7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Augustus Kling c3f182bc9b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 11 years ago
Augustus Kling 1fb830fba6 Merge remote-tracking branch 'upstream/devel' into locale 11 years ago
Augustus Kling 6b75e75161 Handle install/uninstall of locales for Ubuntu, too. 11 years ago
Simon Zimmermann 3db808c840 correctly compare the values, better func name 11 years ago
Simon Zimmermann 055b404f13 Correctly compare values as returned from 'sysctl -e -n' 11 years ago
Simon Zimmermann 7495095496 fix str format error due to missing '%' in sysctl module 11 years ago
James Tanner 3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 11 years ago
Michael DeHaan 2a46022bc7 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
11 years ago
jctanner 450bb37c8c Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
11 years ago
James Tanner 19cb22b6df Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
11 years ago
rishid 34f9349b5e Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
11 years ago
Scott Gilbert 0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner 2c39576e80 Remove unused variable from authorized_key 11 years ago
James Tanner e22af253bb Fixes #5486 Keep authorized key options in tact and ordered 11 years ago
James Tanner c627358c37 sysctl module: append newline character to lines in the file 11 years ago
Michael DeHaan 6f49642286 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
11 years ago
jctanner 332d3d6a0e Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
11 years ago
jctanner 6e39adb89e Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
11 years ago
James Tanner 17c50cc81e sysctl module: fail if reloading the file did not succeed 11 years ago
James Tanner ca05584495 Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
11 years ago
Tyler 2f813f7660 keep /usr/local/etc/rc.conf for backwards compatibility 11 years ago
Tyler 1a655b2dd7 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
11 years ago
Joshua Lund 3b4f3f8ca3 Improved the documentation for password generation 11 years ago
James Tanner dee960716b Fixes #5353 create etc/hostname file in debian if it does not exist 11 years ago