Commit Graph

7840 Commits (d0bdfc2abb43df0c5cd106b2ebf387bc64d93cbd)

Author SHA1 Message Date
Adrian Likins d0bdfc2abb Specify run_command decode error style as arg (#17886)
* Specify run_command decode error style as arg

Instead of getting the stdout/stderr text from
run_command, and then decoding to utf-8 with a
particular error scheme, use the 'errors' arg
to run_command so it does that itself.

* Use 'surrogate_or_replace' instead of 'replace'

For the text decoding error scheme in run_command calls.

* Let the local_facts run_command use default errors

* fix typo
9 years ago
Adrian Likins 2addc09050 cast/copy keys() to list to avoid py3 errors
In py3, dict.keys() is a view and not a copy of the
dicts keys, so attempting to delete items from the dict
while iterating over the keys results int

RuntimeError: dictionary changed size during iteration

Resolve by casting .keys() to a list() type.
9 years ago
Adrian Likins 9f673e0725 open anziballs payload 'wb' for py3 9 years ago
Toshio Kuratomi ddd20627a4 Make run_command return native strings
This changes the return value on python3   Return value on python2 was
already byte strings (which is the native str type there.)
9 years ago
Chris Houseknecht ab93d5aae4 Merge pull request #17873 from chouseknecht/fix_3964
Let docker-py decode pull response
9 years ago
James Cammarata 447ab0ab95 Bumping devel version to 2.3.0 9 years ago
Chris Houseknecht fa7e572a96
Let docker-py decode pull response 9 years ago
Matt Davis 64d9de6b25 bump core submodule ref 9 years ago
Brian Coca 49ce0c8bac only change dir to playdir if local
fixes #17869
fixes #17770
9 years ago
Toshio Kuratomi 5bc3cb278c Remove unicode escape (#17866)
* Remove unicode-escape which is not present on python3

Alternative fix for #17305

* Enable the assemble test on python3

* Fix other problems with assemble on python3
9 years ago
Toshio Kuratomi ddb3f91562 Update submodule refs 9 years ago
Guido Günther 14a9bd6a1c Add foreman callback plugin (#17141) 9 years ago
Toshio Kuratomi f72b123584 On python3, subprocess needs another arg to pass extra file descriptors 9 years ago
Toshio Kuratomi 64c446d9c0 Normalize text and byte type in the ssh plugin helper method that builds up an ssh command (#17860)
Mostly cleanups to make the code more efficient, more pythonic, and obey
the unicode sandwich strategy more but also Fixes #17832
9 years ago
Peter Sprygada b0cd624aef fixes issue with run_commands raising error (#17861)
The junos run_commands() method should raise an error when an RpcError is
returned but didn't when using display=text.  This fixes that error
9 years ago
Peter Sprygada 50c445c356 switches the kickstart arg from True to False for eos (#17858)
The kickstart kwarg should be set to False for eos based devices and
was set to True.  This change cleans up problems loading json output
from cli commands

All eos_command test cases are now passing successfully

fixes #17441
9 years ago
Peter Sprygada 512ef49c8a adds new exception for adding condition statements to Conditional (#17859)
When adding condition statements, the Conditional instance will now generate
an AddConditionError if is unable to map the condition to a function in the
instance
9 years ago
Matt Davis a4e5187661 bump core submodule ref for windows async_wrapper bugfix 9 years ago
Matt Davis aa0ad073b8 bugfixes to JSON junk filter, added unit/integration tests to exercise (#17834) 9 years ago
James Cammarata 657506cddd Ensure the "attempts" key is set in the final result for do/until loops
Fixes #17258
9 years ago
Senthil Kumar Ganesan 7e0074263d Remove the dellosX_template module (#17836) 9 years ago
Matt Davis 60b322e3ca bump core submodule ref for async_wrapper fixes 9 years ago
Indrajit Raychaudhuri becb4765c3 Add homebrew in squash_actions list (#16966)
`homebrew`, like other package modules in the existing `squash_actions` list can
benefit from `with_items` loops optimization.
9 years ago
Brian Coca dfff608ceb dzdo prompt fix
fixed tests
dzdo has 2 paths now, with and w/o password
fixes #17838
9 years ago
Brian Coca 6008fbd5cf fix fact gathering flag 9 years ago
Brian Coca 24e81ddd1c add ssh error message to failure 9 years ago
James Cammarata e4ee9de3f4 Fixing parentage of include_role objects for param inheritance
Fixes #17686
9 years ago
Peter Sprygada 6be2f0bded fixes unicode conversation from junos get_config() method (#17841)
The junos config should convert the returning configuration to unicode
not str.  This fixes that issue.
9 years ago
Peter Sprygada 5b4f3b1eda adds better error handling when conditional fails (#17839)
When the conditional cannot extract a value from the result string,
an unhandled exception would be raised.  This fix now gracefully handles
the exception
9 years ago
Peter Sprygada 9faf56a345 fixes issue when calling save_config() and transport is nxapi (#17835)
An unhandled exeception is raised with using nxapi transport and setting
the save argument to true.  This fix will allow the configuration to be
saved regardless of the transport.

fixes ansible/ansible-modules-core#5094
9 years ago
Trond Hindenes 35fba5718d Bugfix: fixes new-alias bug when debugging powershell (#17816) 9 years ago
Makc c6fa701ab1 jabber callback (#16981)
* jabber callback

* delete empty lines

* grammar fix

* fix: do not print error when jabber callback disabled

* change callback version 1 -> 2
9 years ago
Chris Houseknecht e6eed3c3db Merge pull request #17818 from chouseknecht/devel
Parse role dependencies consistently
9 years ago
Chris Houseknecht 8300e67cbe Use new YAML syntax in role dependencies. 9 years ago
jctanner fff161f2f6 Smart mode for sftp+scp (#17813)
If the sftp fails, roll over to scp by default. This saves users
from having to know about the scp_if_ssh method when sftp is broken
on the remote host.
9 years ago
Toshio Kuratomi 458990084e Update submodule refs 9 years ago
Peter Sprygada c534f8f9fc fixes conditional processing with junos and xml data structures (#17801)
The conditional processing was failing due for two reasons:

1) The xml to json conversion string was not happening before the runner
   was processing the results
2) The Conditional instance was not parsing conditionals encoded with []

This fix address both issues.
9 years ago
cinerama70 fb50698da3 Graceful error handling when delegate_to host null (#17453) (#17783)
Currently, if the host specified in delegate_to for a task is null,
Ansible will crash with a stack trace. Add a check for this state
and handle the error appropriately.
9 years ago
Brian Coca 3c42651fc7 fixed typo 9 years ago
Gilles Gagniard da5b0c39c9 fixes #16865 : we should properly determine connection type for delegated task first, before overriding remote user for local connections (#17723) 9 years ago
Peter Sprygada 9854644431 adds overwrite kwarg to load_config in junos (#17798)
The junos load_config() method supports operations of overwrite, replace
and merge.  This adds the missing overwrite keyword arg to load_config()
so that action in junos_template can be procesed correctly.
9 years ago
Toshio Kuratomi 17c0f52c96 Update submodules refs 9 years ago
Brian Coca 368497fd14 better handling of host lists (#17781)
* better handling of host lists

fixes #17762

* corrected message

* fixed extras space
9 years ago
Brian Coca 86ea21a73d ansible_play_batch (#17779)
* ansible_play_batch

* added version added
9 years ago
Peter Sprygada 605152e61b raises ValueError exception if conditional is not parsable (#17788)
The Conditional class now raises a ValueError with message if it cannot
correclty parse the passed in conditional.  This makes it easier to
detect issues in modules that specify conditionals.
9 years ago
Matt Clay 670536f685 Revert "Clear the plugin path cache when adding new directories" (#17785)
This reverts commit 5a57313dd7.
9 years ago
James Cammarata 5a57313dd7 Clear the plugin path cache when adding new directories 9 years ago
Matt Clay dce94ec3c6 Update submodule refs. 9 years ago
Matt Davis e7819609ce swallow errors during async polling (#17760)
also use connection reset on exceptions if available (eg, prevent reuse of "stuck" WinRM connections due to reboot/NIC bounce/etc)
9 years ago
Brian Coca cf7822e201 remove bare vars and undefined from lookup lists (#17647)
https://docs.ansible.com/ansible/porting_guide_2.0.html#deprecated
9 years ago