Commit Graph

1913 Commits (a5ee6ff1e56ff3abdcb42a9b2ac4518a0eeead13)

Author SHA1 Message Date
Michael DeHaan b09ef21ec9 Add code to flag legacy templating like $foo.{bar} as deprecated in favor of Jinja2 {{ foo.bar }} so we
can remove the legacy system at a later date.
13 years ago
Michael DeHaan 804056a563 Use Jinja2 strict undefined in string templating to allow the default filter to be used. 13 years ago
Michael DeHaan 998230a84a Allow $foo and {{ bar }} to be used on the same line in playbooks. 13 years ago
Michael DeHaan 29209c4913 Style fixes so "make pep8" is clean. 13 years ago
Michael DeHaan 0113951580 Enable usage of when_set within new eval system. 13 years ago
Michael DeHaan a83e10d77d Use safe_eval vs eval. 13 years ago
Michael DeHaan fecfbf9226 Allow jinja2 evals that produce lists to be used in with_items. Ideally want something a bit less heavy
than the eval here.
13 years ago
Michael DeHaan c5d9823467 Fix some items related to playbook includes and indentation. 13 years ago
Stoned Elipot 0893562605 Add base64 encode and decode filters to templates 13 years ago
Michael DeHaan 290780d13f Playbook + with_items was an undocumented feature that was causing problems because it would
evaluate and replace '$item' with ''.  Really it doesn't make sense to include multiple playbooks
via a loop variable, as you can do this with task + with_items already (and it's a simpler code
path).  Given this is undocumented, this removes that feature, and we'll consider next how to
also add 'with_items' support directly to roles.
13 years ago
Michael DeHaan c64f19dc5f Don't set the item variable as eager template replacement will over-replace the variable as an empty string. 13 years ago
Stoned Elipot 154f58f82d Fix Jinja2 filter plugins initialization
_get_filter_plugins() checks FILTER_PLUGINS against None hence
the latter should be initialized to None.
13 years ago
Seth Vidal 690738ea32 implement --start-at-task option to hop to a specific task before starting running them 13 years ago
willthames 9d87733f98 Test case and fix for shlex.split unicode bug
When operating on a unicode string in python 2.6, shlex.split returns
a result that does not work with the file constructor.

To reproduce this requires a task include that is templated (this is
because the templated string is a unicode result, whereas a non-
templated string is a non-unicode string)

    [will@centos6.3] $ python
    Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23)
    [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import shlex
    >>> shlex.split(u'abc')
    ['a\x00\x00\x00b\x00\x00\x00c\x00\x00\x00']

    [will@fedora17] $ python
    Python 2.7.3 (default, Jul 24 2012, 10:05:38)
    [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2
    Type "help", "copyright", "credits" or "license" for more information.
    >>> import shlex
    >>> shlex.split(u'abc')
    ['abc']

The proposed fix (coercing the include parameters to string before the
shlex.split) may not be ideal but it does fix the bug for my test case.
13 years ago
Michael DeHaan 61f2668b0a Don't include the '.yml' in the path to the retry files. 13 years ago
Michael DeHaan 0d530f3bf0 Change the retry logic to write a limit file, able to source limit from files by indicating with @filename 13 years ago
Michael DeHaan c695aa2d6a When playbooks fail, attempt to create an inventory file in the inventory directory that allows rerunning
of the playbook against only the hosts that failed.
13 years ago
Michael DeHaan 5fef2ffb9d Merge pull request #2592 from stoned/include-task-when
when: condition support for tasks include
13 years ago
Michael DeHaan 00252353b9 Decided I liked the asterisks 13 years ago
Michael DeHaan bc0be456da Modify output banners to have constant length and use dashes instead
of "-" to be less visually heavy (unless cowsay is installed of course)
13 years ago
Stoned Elipot 1ed54b9b3a when: condition support for tasks include 13 years ago
Michael DeHaan e9d11173cd Remove obsolete comment 13 years ago
Michael DeHaan fffb1a0a9d Loose tasks not in roles get executed after roles. 13 years ago
Michael DeHaan f044fc344b When using roles, or other includes, the path to DWIM inside is the path of the task include
file.
13 years ago
Sébastien Bocahu b94bf051d5 Makes $PIPE and $FILE macros accept utf-8 input 13 years ago
Michael DeHaan 5c4ed72571 Demo of parameterized roles! 13 years ago
Michael DeHaan f308194b9a Added examples of how roles work! 13 years ago
Michael DeHaan 892484812e Much requested feature -- allows relative imports of content within roles or relative to any task or handler include (../templates for template ../files for copy) 13 years ago
Michael DeHaan 95f30f0def Complete streamlining of vars handling in playbooks and how those are templated to avoid
repeat template calls at playbook intialization time.
13 years ago
Michael DeHaan 1dfe60a6ea Allow any parameter in a play to be set by --extra-vars through cleaner use of data structure
templating.
13 years ago
Michael DeHaan 4cd69e81b9 Catch recursive templating errors and display what string caused them. 13 years ago
George Miroshnykov 6826aa7360 Tweaked merge_hash to also affect Runner behavior 13 years ago
Blair Zajac 36b3fc3acf Fix for inventory scripts with no path prefix that are in CWD.
Without this, using '-i ec2.py' will not work if '.' is not in PATH.
13 years ago
Michael DeHaan f585c4cde7 Upgraded variable support met with upgraded conditional support, see examples/playbooks/upgraded_vars.yml
for details!
13 years ago
Michael DeHaan 38c2b14339 Undefined Jinja2 statements are returned as they originally are so you can tell there are things to
correct.
13 years ago
Michael DeHaan 49d28b9a44 This SELinux commit is too strict and we should only fail if trying to read/tweak SELinux attributes else
python-selinux can't be installed w/ the yum module when missing.

Revert "Added an extra check for target nodes with selinux but without libselinux-python package installed"

This reverts commit 550986b6a1.
13 years ago
Michael DeHaan 2c881e2b3d Merge pull request #2578 from arrfab/selinux-fix-2
Added an extra check for target nodes with selinux but without libselinux-python package installed
13 years ago
Michael DeHaan 9073aa17ab Chroot also needs args/kwargs. 13 years ago
Michael DeHaan 3d25b4a7c0 Standardize args/kwargs on connection plugins. 13 years ago
Dag Wieers d5d26bab9b Make private key customizable per host using ansible_ssh_private_key_file configurable as variable
This fixes issue #1026 for @toshywoshy together with ansible_ssh_user and ansible_ssh_port.
13 years ago
Fabian Arrotin 550986b6a1 Added an extra check for target nodes with selinux but without libselinux-python package installed 13 years ago
Michael DeHaan 8c859f6f61 Merge pull request #2570 from skvidal/devel
simple fix for issue 2564
13 years ago
Michael DeHaan 550bf47636 Merge pull request #2565 from willthames/default_exec
Added DEFAULT_EXECUTABLE as a constant
13 years ago
Michael DeHaan f37da4fdd7 Merge branch 'ssh_config_user_overrides' of git://github.com/bcoca/ansible into devel 13 years ago
Michael DeHaan b67cd6bbda Merge branch 'any-errors-fatal' of git://github.com/junegunn/ansible into devel 13 years ago
Seth Vidal 2796b5ee2a simple fix for issue 2564
when we encounter a group we've not seen before - we need
to make sure we make it a subgroup of 'all', no matter what
13 years ago
willthames e55e123c01 Added DEFAULT_EXECUTABLE as a constant
Use DEFAULT_EXECUTABLE when no executable is passed to
_low_level_command_exec

Works as a standard constant - can be overridden in all the normal ways
and defaults to /bin/sh

Motiviation is for a user that only has /bin/bash in /etc/sudoers
13 years ago
Michael DeHaan cdaa2085ee Preliminary ability to use Jinja2 {{ }} to replace ${foo.bar} in playbooks. Can't use both at the same time per line. 13 years ago
Michael DeHaan aa4ad80bda Update release version. 13 years ago
Junegunn Choi b874027b36 compare the number of available hosts before and after running each task 13 years ago
Junegunn Choi 20a48c6bdf terminate immediately on a failure 13 years ago
Brian Coca 82c3b4e685 now ssh connection plugin will only pass user as an option to ssh if it is
differnt from the current user. This should enable overrides for user in
.ssh/config w/o breaking any current functionality.

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan 42b0e51223 Upgrade callbacks further, now '.play', '.task', and so on are also available! 13 years ago
Michael DeHaan 0d11f53eff Let the callbacks see the playbook and (current) runner objects. 13 years ago
Michael DeHaan 783a12cc0e Resolve merge commit. 13 years ago
Michael DeHaan 3c5890f42b Ensure that when transferring a file to a directory the name of the file is the correct basename and not 'source'. 13 years ago
Michael DeHaan 7044e53e07 Allow conditionals on BYPASS_HOST_LOOP plugins like add_host 13 years ago
Michael DeHaan 9be44c201a Merge pull request #2455 from robparrott/debuggin-help
inject a dictionary of avaiable variables and the environment into executor
13 years ago
Michael DeHaan fe2f506514 Merge pull request #2462 from sfromm/issue2461
Make logging to journal match what goes to syslog on non-systemd hosts
13 years ago
Stoned Elipot 86995d7786 Fix pathnames in comments 13 years ago
Stephen Fromm cdb7f8ecf0 Make logging to journal match what goes to syslog on non-systemd hosts
This makes the log message the same, whether it is sent to systemd's
journal or to syslog.  It retains the extra fields that are passed to
journal, such as MOUDLE=<name> and additional arguments.  Since journal
will reflect messages to syslog, this keeps what goes to syslog
informative instead of the terse 'Ansible module invoked'.

See issue #2461.
13 years ago
Rob Parrott 149f1f9f3c invalidate group cache so that a group added by the add_host module will be relfected in the groups variable in later plays. 13 years ago
Rob Parrott 81e2d871aa inject a dictionary of avaiable variables and the environment into the executor, so that templates can be used to debug playbooks by dumping more of the available context. 13 years ago
David Hughes c365974117 Added variable expansion to task sudo_user parameter 13 years ago
Michael DeHaan 6f25885c1a Merge pull request #2397 from dparalen/play_task_type_check
check type of task explicitly
13 years ago
milan 80dbab3cf0 check type of task explicitly 13 years ago
Daniel Hokka Zakrisson 27978ed9c1 Don't override argument specs with FILE_COMMON_ARGUMENTS
Doing so will remove aliases, types, etc, leading to #2388 and other
issues.
13 years ago
Michael DeHaan d0332a6c6d Merge branch 'playbook-step' of git://github.com/skvidal/ansible into devel 13 years ago
Michael DeHaan 0c80c76833 Fixes #2380 - argument checking in file accepts chained arguments from copy 13 years ago
Michael DeHaan 77198b09e9 Add content to the list of file common arguments. 13 years ago
Stoned Elipot 8edda38c61 exception safe list/tuple replacing for non-str values 13 years ago
Michael DeHaan e241bb5801 Merge pull request #2367 from bcoca/catch_mismatched_json
now cleanly catches traceback when conflicting versions of simplejson and python are installed
13 years ago
Michael DeHaan a22009806e Nested iteration would make more sense in this order. 13 years ago
Michael DeHaan edc04d61f3 Added 'with_nested' lookup plugin that can easily do nested loops. 13 years ago
Michael DeHaan 298d64aa1d Quote remote md5 operations. Fixes #2368 13 years ago
Michael DeHaan e304cc3d8e Simple fix for spaces in filenames with the template module. 13 years ago
Michael DeHaan 6e2ea327d1 A very simple fix to enable spaces in the files sent via the copy module. 13 years ago
Brian Coca 95a977cfc9 now cleanly catches traceback that occurs when running newer simplejson with
older python interpreter.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Seth Vidal a7a083d882 when --step isn't specified make sure to print the banner 13 years ago
Seth Vidal 7687c2caf8 add --step option to ansible-playbooks to let people step through a playbook
one by one - asking for confirmation along the way.

also allows to 'continue' after a certain point
13 years ago
Michael DeHaan 2962073bcf Merge branch 'fix-module-encoding' of git://github.com/andreparames/ansible into devel 13 years ago
Michael DeHaan f2c8df2a93 Clarify an error message 13 years ago
Patrick Pelletier c7c7a63ee5 Add support to directly set content in copy module 13 years ago
Michael DeHaan c53653dc0d Merge pull request #2348 from candeira/password-plugin
password lookup plugin, with working tests and documentation
13 years ago
Michael DeHaan b2c8ed9cc2 Merge pull request #2279 from dorfsmay/fetch-fail_on_missing
Added a fail_on_missing option to fetch.
13 years ago
Michael DeHaan aae88baf4a Merge pull request #2260 from skvidal/path_lookup
first_found lookup_plugin - replaces first_available_file
13 years ago
Michael DeHaan bb696e88b4 Merge pull request #2286 from gavares/url_timeout
Add socket timeout to uri module.
13 years ago
Javier Candeira ca6c36e1ac password lookup plugin, with working tests and documentation 13 years ago
André Paramés 9bb8435ec9 Fixes #2346 13 years ago
Daniel Hokka Zakrisson 76f3351b02 Move complex_args templating to be with module_args
Keeps every action plugin from having to do the same thing.
13 years ago
Michael DeHaan ffbd4b5a2c Template options sooner on complex args copy 13 years ago
Michael DeHaan 2bb305f6d5 Fix args templating for complex args with the copy module. 13 years ago
Michael DeHaan 969edabdbb Merge pull request #2322 from bcoca/remote_tmp_override
added check for starting $HOME for remote_tmp so as to non root sudo override
13 years ago
Michael DeHaan 44e44cf295 Merge pull request #2320 from jkleckner/minor-spelling-fixes
Minor spelling fixes
13 years ago
Michael DeHaan fe8547cac0 Ensure template arguments if complex are still properly templated 13 years ago
Brian Coca 76f709286e added check for starting $HOME for remote_tmp so as to non root sudo override
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
13 years ago
Jim Kleckner 92844d3dcd Minor spelling fixes 13 years ago
Maykel Moya e898f30f78 Fix copyright 13 years ago
Daniel Hokka Zakrisson 3d49f74df6 Make apt upgrade=dist work and make its argument handling more idiomatic
Fixes #2287.
13 years ago
Daniel Hokka Zakrisson 1784fd80cc When a host list is used, no parser is present 13 years ago
Grant Gavares cd51c7f234 Add socket timeout to uri module.
The uri module can be configured to abort after a specified timeout if
it cannot connect to the configured uri. This prevents a uri action from
hanging indefinitely when the remote endpoint cannot be reached because
it is unavailable, there is a firewall in place etc. The default behavior
is left unchanged: timeout=None

This change also introduces a new type for module_parameters: int
Code was added to perform conversion from string -> int type in
module_common.py.

The new type was required in order to play nice with httplib2 which
refuses to accept (and convert) anything other than a numeric type for
the timeout value.
13 years ago
Yves Dorfsman e45a0fd61d Added a fail_on_missing option to fetch. 13 years ago
Michael DeHaan 6ad390a92b Revert "Revert "for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups""
This reverts commit dc0515a88a.

We didn't need to revert this :)
13 years ago
Daniel Hokka Zakrisson 5d82b4b1b7 group_by needs the untemplated module_args 13 years ago
Michael DeHaan dc0515a88a Revert "for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups"
This reverts commit 2d86671aa5.
13 years ago
Daniel Hokka Zakrisson 43ce2caa4f Fix parse_kv invocation in group_by to use imported name
Fixes #2277.
13 years ago
Daniel Hokka Zakrisson 2ff2f05a0f host.get_variables includes too many variables, use host.vars instead
Not quite as attractive, but allows variable precedence and lazy
resolution to work as intended, rather than resolving them on a
per-inventory basis.
13 years ago
Michael DeHaan 0b4ad2749a Increase error handling in the unlikely case of failing to establish a connection. 13 years ago
Michael DeHaan 5fd807ac64 Merge pull request #2262 from bcoca/json_nice_error
now ansible shows nice message about missing json instead of traceback
13 years ago
Brian Coca 46c913f7a6 now ansible shows nice message about missing json instead of traceback
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan 7ac5e462ef Fixed a small buglet, if using with_items with yum and so on, only optimize the package list if the package list is all strings 13 years ago
Seth Vidal 804b130288 check if the term is a dict so we can take a simple list of files (like first_available_file) takes 13 years ago
Michael DeHaan b6f7a22de5 Merge pull request #2261 from bcoca/groupby_2186
now group by module invalidates host cached variables
13 years ago
Brian Coca 2d86671aa5 for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
13 years ago
Seth Vidal dfad94078b first_found lookup_plugin - replaces first_available_file
- useful in tasks/playbook inclusion
- task-specific inclusion

allows searching paths and files
13 years ago
Daniel Hokka Zakrisson f1eb195ff5 vars_loader should get the path to the inventory + vars_plugins 13 years ago
Daniel Hokka Zakrisson ad08995989 Make inventory basedir for directory based inventory be the directory
This puts host_vars and group_vars inside of the directory, allowing you
to target a single inventory but still have access to the variables.
13 years ago
Daniel Hokka Zakrisson d9c6b60b24 Allow inventory to be a directory containing other inventories 13 years ago
Daniel Hokka Zakrisson 647cd0141c Move all inventory script code into the script parser 13 years ago
Michael DeHaan fb26f059c5 Merge pull request #2232 from dhozac/module-args-dict
Allow specifying args directly to actions using module: syntax
13 years ago
Michael DeHaan e83819599a Merge pull request #2234 from akvadrako/nice-yaml-and-json
add to_nice_yaml|json filters
13 years ago
Michael DeHaan c92bfb7234 Merge branch 'madcow2' of git://github.com/bcoca/ansible into devel 13 years ago
Jimmy Tang 81a34c2d1d Cowsay on OSX macports 13 years ago
Devin Bayer fca1167a0e add to_nice_yaml|json filters 13 years ago
Daniel Hokka Zakrisson ae8d6ac303 Ensure complex_args is considered in all action_plugins 13 years ago
Daniel Hokka Zakrisson 297259725a Allow (local_)action: to be a dict
Use the key module: to set which module to invoke.
13 years ago
Daniel Hokka Zakrisson c04d5ba739 Allow specifying args directly to actions using module: syntax
Makes things like
- name: do complex things with complex module
  complex:
    setting_a: true
    setting_b:
    - foo
    - bar
possible.

Fixes #2228.
13 years ago
Daniel Hokka Zakrisson 4807fbc8b7 Use regular strings to allow tests to work 13 years ago
Michael DeHaan 323ed27106 Merge pull request #2221 from sfromm/fix-ansible-cli-check-mode
Fix CliRunnerCallbacks.on_file_diff in callbacks.py
13 years ago
Stephen Fromm fa07604d43 Fix CliRunnerCallbacks.on_file_diff in callbacks.py
When running ansible -C, I get a traceback that ends with
    AttributeError: Values instance has no attribute 'diff'
This fixes on_file_diff to behave similar to
PlaybookRunnerCallbacks.on_file_diff().
13 years ago
Daniel Hokka Zakrisson cedfec763a jsonify needs to return a string of {}, rather than a dict 13 years ago
Daniel Hokka Zakrisson e4b72c0fd5 Revert to just escaping \ for JSON-args 13 years ago
Daniel Hokka Zakrisson 1601f0b4d7 Use repr to transfer JSON-arguments, so Python doesn't eat things
Fixes transferring newlines in args:, as well as """.
13 years ago
Daniel Hokka Zakrisson bcf7a2c53a Catch all exceptions coming from lookup plugins
Fixes using $TEMPLATE() and hostvars in a task without a name, among
other things.
13 years ago
Brian Coca e9907e9c8a added random cow pick through ANSIBLE_COW_SELECTION env var
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
13 years ago
Michael DeHaan 1366c663eb Merge branch 'copy-diff-take2' of git://github.com/stoned/ansible into better_diff
Conflicts:
	library/file
13 years ago
Daniel Hokka Zakrisson 93f02d614b Merge pull request #2187 from dhozac/argument-type-check
Add type checking for module arguments, converting as much as possible
13 years ago
Stoned Elipot 8816dc7ca7 Make diff header lines more explicit about what the diff is about
This gives a more readable output when producing diff for a task
with multiple items (with_items).
13 years ago
Stoned Elipot 1b8c9bab35 Fix diff when template destination is absent 13 years ago
Daniel Hokka Zakrisson 22e40b6a61 Merge pull request #2198 from skvidal/nolog-params
No_log params
13 years ago
Stoned Elipot 10e9f1fc1e Implement --diff for the copy module. 13 years ago
Seth Vidal f02ea15f0c command: make sure that all _handle_aliases() calls returns {}
module_common: also work if there are no aliases (shell, command, etc) modules
13 years ago
Seth Vidal c95848ae59 - add an aliases attribute as a lookup of aliasname to canonical name
of parameters
- add support for no_log attribute per-parameter which will not log
  that information to syslog
13 years ago
Daniel Hokka Zakrisson e32fbd312f Shell-quote environment contents 13 years ago
Daniel Hokka Zakrisson 27f3ba53f9 Remove debug print for environment 13 years ago
Daniel Hokka Zakrisson 1df56c07d3 If expand_lists is true, make lookup plugin result into a string
Fixes #2196.
13 years ago
Daniel Hokka Zakrisson 7e0ee6809c Don't template delegate_to too early, not all vars are available
Fixes using delegate_to: $item within a playbook include.
13 years ago
Daniel Hokka Zakrisson f03e845920 Allow hyphens in complex variables
Primarily to support ${hostvars.hostname-with-hyphens.<var>}.
13 years ago
Shaun Zinck e7719e4e46 pass in int() args to get_pty
If LINES or COLUMNS was set, get_pty was failing because it was
expecting an int value to be passed in.
13 years ago
Michael DeHaan 294e43ba2f Removing pipe once since it has some issues about evaluating more than once :) 13 years ago
Daniel Hokka Zakrisson 9076f8eb31 Add type checking for module arguments, converting as much as possible
Converts to list from comma-separated strings, and to dicts from
comma-separated, key=value strings.

Fixes #2126.
13 years ago
Michael DeHaan b75b9681a8 more places to use yaml.safe_load 13 years ago
Michael DeHaan a9ea3136cf Use yaml.safe_load as we are just using basic data structures 13 years ago
Michael DeHaan 5b31feb73b Merge pull request #2179 from skinp/host_connection
Add support for connection type in ansible_hosts file
13 years ago
Patrick Pelletier 2b4ddfb0a2 Handle delegate_to case for local connections in hosts file 13 years ago
Michael DeHaan e51707711c Merge pull request #2120 from jpmens/doc_ex1
Add support for additional EXAMPLES string in Ansible modules
13 years ago
Michael DeHaan f7fb681bb2 Fix comment in chroot connection type 13 years ago
Michael DeHaan 5a1aef5372 Merge branch 'local-chroot-support-v2' of git://github.com/mmoya/ansible into testing 13 years ago
Michael DeHaan 93f73739d3 Merge branch 'paramiko-termcap' of git://github.com/madduck/ansible into testing 13 years ago
Patrick Pelletier 4c0e6722c4 Add support for connection type in ansible_hosts file 13 years ago
Maykel Moya 9a493ef388 Add support for running modules chrooted in a local dir
Adds 'chroot' connection for executing modules chrooted to
a local dir. Requires running ansible as root.

chroot dirs should be specified in the inventory like any
other host.

You can do things like:

$ sudo -E ansible -vvv -f 1 "./chroot1,./chroot2" -c chroot \
  all -m setup
$ sudo -E ansible-playbook -vvv -f 1 -i "./chroot1,./chroot2" \
  -c chroot some-playbook.yml

some-playbook.yml:
---
- hosts: all
  tasks:
    - name: echo something
      shell: echo "Yaaay!" >/tmp/foobar.txt
    - name: install less
      apt: pkg=less state=latest
13 years ago
Stoned Elipot 9f2bba01ba Fix diff output vertical spacing 13 years ago
Michael DeHaan 6d604469d8 Always adjust file attributes with the template module. 13 years ago
Jan-Piet Mens 396a07bcc7 Add support for additional EXAMPLES string in Ansible modules
return DOC and EXAMPLES as a list
add moduledev explanation
more
13 years ago
Michael DeHaan ab389d8908 For consistency, add host should take a key named 'name' in addition to 'hostname'. 13 years ago
Michael DeHaan c4779d95b8 Removing unused import, 'make pyflakes' is now clean. 13 years ago
Michael DeHaan 9cf66f4376 Fixes from 'make pep8'. Partial, more to come. 13 years ago
Michael DeHaan 11e7ede4d9 Merge pull request #2112 from kavink/devel
Fixing syntax error
13 years ago
Michael DeHaan 61d01f549f Show a nicer message when attempting to diff unicode files. 13 years ago
Kavin Kankeshwar 359ac9a495 Fixing syntax error
running install_lib
byte-compiling /usr/lib/python2.6/site-packages/ansible/runner/action_plugins/add_host.py to add_host.pyc
SyntaxError: ('invalid syntax', ('/usr/lib/python2.6/site-packages/ansible/runner/action_plugins/add_host.py', 37, 92, '    def run(self, conn, tmp, module_name, module_args, inject, complex_args=None, **kwargs)\n'))
13 years ago
Daniel Hokka Zakrisson 43d22b0c42 Flatten argument to with_items
Fixes #1711.
13 years ago
Michael DeHaan f02b9987fc We all agreed on the list that the ansible module common module snippet, since it's dynamically embedded in modules on the fly, should
be a BSD licensed snippet so that it's ok to write proprietary modules.  The actual license of Ansible (GPLv3) or any modules
written for ansible (any) do not change.
13 years ago
Michael DeHaan 1ecf4a6943 Working on complex argument support. 13 years ago
Michael DeHaan cd32597af0 Make the file module work as expected in check mode 13 years ago
Michael DeHaan fa21b41357 Fixup the pipe_once plugin 13 years ago
Michael DeHaan 0af83317a1 Added a $PIPE_ONCE lookup plugin, that caches the result so it is only evaluated one time. 13 years ago
Michael DeHaan b365e04616 Allow add_host to add hosts to multiple groups, groups is now an alias for groupname. 13 years ago
Rob Parrott ef17fc9f20 add the ability to take variables in the add_host module, and be willing to parse a host:port hostname handed to add_host 13 years ago
Michael DeHaan c8878998d1 update some of many copyright dates but we can just do this when editing each file, not super high priority 13 years ago
James Martin 7129a9e355 Using "OtherLinux" in module_commons, cleander detection in setup. 13 years ago
James Martin 5646bc278b Support for amazon linux distribution facts. 13 years ago
Michel Blanc 0cd0a7fda3 Fixes jina typos
Moved *jina* to *jinja2*
13 years ago
Michel Blanc 1c22f2146e Adds configurable jinja2 extension loading
Jinja extensions adds features to the jinja2 templating engine. This
patch allows module loading for the templating engine vian an
ansible.cfg configuration key (jinja_extensions).
The default behaviour doesn't change (no module loading).
Requested modules can be added coma separated in ansible.cfg

Adds whitespace handling in jinja_extension config

Added whitespace handling in jinja_extension configuration directive, so
things stay safe if user adds spaces around comas in the directives
list.

Adds config example for jinja_extensions

Added config example with multiple extentions for jinja_extensions
13 years ago
Blair Zajac fa8e653011 Simplify and correct comparisons with None. 13 years ago
martin f. krafft ab39909260 Initialise PTY from calling environment
If we need to acquire a PTY for sudo's use, then it should really
inherit the capabilities of the calling environment. This is what
OpenSSH does, and so it makes sense to copy this behaviour for the
paramiko connection type.

Closes: #2065
Signed-off-by: martin f. krafft <madduck@madduck.net>
13 years ago
martin f. krafft 1cf43e9afe Only allocate a PTY when sudo is used
Postpone the paramiko.Channel.get_pty until we know sudo is used. If
sudo is not used, then we do not need a PTY. In fact, the paramiko docs
explicitly state that it's not desirable to allocate a PTY for a simple
exec_command.

Signed-off-by: martin f. krafft <madduck@madduck.net>
13 years ago
Nigel Metheringham c0e28762f0 Allow end of line comments in inventory file
See github issue 2702
https://github.com/ansible/ansible/issues/2072
13 years ago
Daniel Hokka Zakrisson 7e2999ed2d Add directory detection to _remote_md5 and use this in copy
If it is a directory, change the destination path by appending the
basename of the source file, like is done if the destination ends with a
/, and try to get the MD5 of the new path.
13 years ago
Daniel Hokka Zakrisson d632210941 Allow using other users' home directories as well 13 years ago
Daniel Hokka Zakrisson 89e73c123f Fix tilde expansion for fileglob
Use common suffix to determine what part of original term to keep and
how much of the full path to combine to get a usable filename.
13 years ago
Daniel Hokka Zakrisson 57e51f7fdf Clean up some extra_vars redundancy 13 years ago
Chris Hoffman 9057f72881 Removing duplicate import, adding missing import 13 years ago
Daniel Hokka Zakrisson a1e00c93e5 Add ansible_ssh_user/pass to enable inventory-defined users 13 years ago
Daniel Hokka Zakrisson c83e428a7e Default expand_lists to True and set it to False for only_if
Fixes #2026 and #2027.
13 years ago
Michael DeHaan f7497e75e5 Able to use "environment: " on any task to pass proxy details and other useful settings. Can be a variable
or a dictionary.
13 years ago
Michael DeHaan 72a05ae2a0 Move diff code more into runner code. 13 years ago
Michael DeHaan 0ad6ac4086 Fix group depth for nested groups 13 years ago
Michael DeHaan 828119d823 Allow the remote username to come from a variable set in vars_files or vars 13 years ago
Michael DeHaan e6ead2ca74 make things like $FILE(/etc/path/foo.conf) and $ENV(HOME) work without having to use brackets to index them 13 years ago
Michael DeHaan c692de6b80 Cleanup YAML parse error warning code a tiny amount. 13 years ago
Steve Frank 36027ddbba Squashed commit of the following:
Changed ami_tags to instance_tags to better follow naming convention
    Add support for creating tags on the new instances
13 years ago
Michael DeHaan a894791767 Slightly friendlier error on missing hosts file, slightly friendlier error on inventory script returning invalid syntax
(or if inventory is non-script and accidentally executable).
13 years ago
Brian Coca ca5f52b825 now missing hosts file gives nice message and no traceback
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca 0e8627b7e8 added block device info gathering, full for linux, partial for freebsd added prettyfing byte function Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
moved moutns out of devices Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Matt Cordial 2ccfc8d2b6 Fix Issue #2025 where templates were not being transfered. 13 years ago
Michael DeHaan a9162a86f2 Very basic --diff option for showing what happens when templates change.
Probably output is not useful if not used with --limit

Works well with --check mode
13 years ago
Daniel Hokka Zakrisson f3305564e2 Add stderr contents to parse errors 13 years ago
Daniel Hokka Zakrisson 19f3cf45f4 Merge pull request #1982 from dex4er/feature_j2_filter_safe_yaml
Use yaml.safe_dump rather than yaml.dump. No more "!!python/unicode".
13 years ago
Daniel Hokka Zakrisson dddfeac9c4 Allow using ${hostvars.<node>} for nodes not in SETUP_CACHE
This allows accessing inventory data from nodes that have not been
talked to (yet).
13 years ago
Daniel Hokka Zakrisson ffd4ae11b8 Merge pull request #1993 from fdavis/timeout_ssh
Add ConnectTimeout=DEFAULT_TIMEOUT to ssh args
13 years ago
Daniel Hokka Zakrisson 70d5dad726 Also catch NameErrors which would indicate missing quotes 13 years ago
Daniel Hokka Zakrisson bc709e7b67 expand_lists should default to False 13 years ago
fdavis 21a5c55921 Add ConnectTimeout=DEFAULT_TIMEOUT to ssh args 13 years ago
Daniel Hokka Zakrisson 98f0a9210e Raise an error when multiple when_* statements are provided
Fixes #1994.
13 years ago
Daniel Hokka Zakrisson d5e63332fe Raise an error if an action doesn't have a string type
Happens with e.g. "command: true" that YAML helpfully converts to a
bool.
13 years ago
Rune Kaagaard 7a8b27f716 Fixing bug with unicode templates.
The utils.md5s() function would break when calculating checksums
for non-ascii characters. Convert to utf-8 first.
13 years ago
Daniel Hokka Zakrisson c1b63d1500 Fix for when conditional is a simple bool already
Fixes #1983.
13 years ago
Piotr Roszatycki 8cf268441e Use yaml.safe_dump rather than yaml.dump. No more "!!python/unicode". 13 years ago
Daniel Hokka Zakrisson 1becc665b2 Fix missing ) in add_host
Fixes #1980.
13 years ago
Michael DeHaan fed82c2188 This implements a basic --check mode which for now is only implemented on template & copy operations. More detail will be shared with the list
shortly.
13 years ago
Daniel Hokka Zakrisson d8d1f2cd7a Split PATH on os.pathsep, that is what it's there for 13 years ago
Daniel Hokka Zakrisson a025cfcb33 Add on_import_for_host callback from non-list case 13 years ago
Daniel Hokka Zakrisson a79373f6b2 Make template_ds the only templater
Instead of having to remember when to use which one, rename template_ds
to template and move the last bit of code from template to varReplace
(which gets used for all string replacements, in the end).

This means that you can template any data type without worrying about
whether it's a string or not, and the right thing will happen.
13 years ago
Michael DeHaan f7aaa5ccc5 Fix copyright, unused imports 13 years ago
Michael DeHaan 857ccf7f6c Add random choice plugin (with_random_choice) 13 years ago
Michael DeHaan 318e3302fb Fix up some version related things on the devel branch. 13 years ago
Daniel Hokka Zakrisson f7e286cf34 Fix error format for invalid vars_files 13 years ago
Seth Vidal 83b9654c63 stop updating SETUP_CACHE in run_play as per comment on pr 1945 13 years ago
Seth Vidal f649777072 - make extra-vars override all other vars and facts in playbooks 13 years ago
Daniel Hokka Zakrisson b79960e13b If failed lookups are fatal, re-raise the exception
Fixes #1938.
13 years ago
Daniel Hokka Zakrisson e166f71fcc Get output before receiving return code
Fixes hangs observed with large amounts of output, as it would get into
a dead-lock.
13 years ago
Michael DeHaan 4d8f3b0924 This standardizes the apt_key module some
* improves error handling and reporting
* uses run_command to reduce code
* fails quicker on errors as opposed to return codes and tracebacks
* can now also specify the key as data versus needing to wget it from a file
13 years ago
Daniel Hokka Zakrisson 5268d49bad Add sudo_flags configuration option to alter sudo behaviour
Default to -H to set $HOME appropriately.
13 years ago
Les Aker f4eed3710b fixed check for required_together 13 years ago
Michael DeHaan 0030a2bd09 Allow handler files to be empty lists. 13 years ago
Michael DeHaan 0c2f67ef66 Merge pull request #1923 from fdavis/ans_env_addition
add env vars for plugins action,callback,connection,lookup,vars,filter
13 years ago
Michael DeHaan 36066d8664 Fixup ec2_facts docs parsing 13 years ago
fdavis 925c1a4611 add env vars for plugins action,callback,connection,lookup,vars,filter 13 years ago
Daniel Hokka Zakrisson 4d71b31f7e Ensure destination and source are available before mangling them
Fixes #1918.
13 years ago
Daniel Hokka Zakrisson 6f9099c51d Merge pull request #1898 from silviud/fix_inventory_list_groups
Inventory class - lambda fails on attribute access - g.name is a string not the group obje...
13 years ago
Daniel Hokka Zakrisson 53fd85e2c4 Merge pull request #1903 from leucos/mergeable-hash-vars
Adds user-selectable hash merging support in vars
13 years ago
Daniel Hokka Zakrisson 864b75e54b Override Jinja2 Template class to make {% include %} work again
Fixes #1908.
13 years ago
Michel Blanc 8eb7d740b0 Fixes hash merging
No need for deep copy (vars are essentially immutable once loaded, there
should not be any modifications)
13 years ago
Michel Blanc e28e538c6e Adds user-selectable hash merging support in vars
Hash variables are currently overriden if they are redefined. This
doesn't let the user refine hash entries or overriding selected keys,
which can, for some, be a desirable feature.
This patch let the user force hash merging by setting the
hash_behaviour value to "merge" (without the quotes) in ansible.cfg

However, by default, ansible behaves like it always did and if any value
besides "merge" is used ("replace" is suggested in the example ansible.cfg
file), it will also behave as always.
13 years ago
Bowe Strickland 2b3d6d4545 protect PluginLoader._extra_dirs from appending None
PluginLoader.add_directory() can receive None from, for example, 
Inventory.add_directory(self.basedir()) if host_list is a custom list.
None has no reasonable interpretation other than ignore it.
13 years ago
Silviu Dicu f7694ac433 lambda fails on attribute access - g.name is a string not the group object 13 years ago
Daniel Hokka Zakrisson 94a1c221bc Update variable precedence section with current rules 13 years ago
Daniel Hokka Zakrisson a16ddb57c1 Default module search path is included already
Adding it to runner's module_path makes it override local modules.
13 years ago
Daniel Hokka Zakrisson 35b58955d6 Fix paramiko for when no private key is specified 13 years ago
Michael DeHaan ef38e9f0e6 Merge pull request #1875 from cocoy/vars_prompt_default
Adding default on vars_prompt
13 years ago
Tim Gerla 4c64d0d6be Expand ~ shell shortcuts for the --private-key argument 13 years ago
Michael DeHaan 35c7ebf7a4 Revert "Update lib/ansible/utils/__init__.py"
Reported hanging of no-password sudo in some cases.  Need to explore.

This reverts commit 87f6739e20.

Conflicts:

	lib/ansible/utils/__init__.py
13 years ago
ron1 280660b8a7 Support sudo alternatives that offer sudo-compatible interfaces 13 years ago
Rodney Quillo 395093e0bf Move default arguments to the end of the function call. 13 years ago
Michael DeHaan c8fc353bc3 Merge pull request #1811 from fdavis/devel
add when_{failed,changed}, and extended when_{set,unset}
13 years ago
Michel Blanc 87f6739e20 Update lib/ansible/utils/__init__.py
Adds -i to  make_sudo_cmd so target user's environment gets loaded when configurationslike this are used :


    - hosts: ubuntu 
      name: Install ruby for the configured ruby user 
      sudo: True 
      sudo_user: rubyuser 
      # should be ${ruby_user}, but can't for now because of #1665 
      tasks: 
      - name: Gets current ruby version 
        action: shell rbenv version 
        register: ruby_current_version
13 years ago
Rodney Quillo 7ae100611c Adding default on vars_prompt 13 years ago
Stephen Fromm 4eaee3df0a Various cleanup to run_command
* Rename fail_on_rc_non_zero to check_rc, much more succinct.
* Simplify method defintion
* Fix command module and drop shell=shell option; whether to use
  shell is determined by if args is a list.
13 years ago
Stephen Fromm 300531507b Add method run_command to module_common.py
This adds a helper method that modules can call to execute a command via
subproces.  It takes two arguments: the command to run and
keyword options that control how the process is executed.  Supported
options are: fail_on_rc_non_zero, close_fds, and executable.
fail_on_rc_non_zero will call fail_json if the command fails.  If
args is a list, the command will be run with shell=False; otherwise, if
a string, it will be run with shell=True.  Otherwise, run_command() returns
the returncode, stdout, and stderr.
13 years ago
Daniel Hokka Zakrisson d11262af4d Fix raw (no executable) support on -c local 13 years ago
Daniel Hokka Zakrisson 5231be5d4b Add sudo password support for local 13 years ago
Daniel Hokka Zakrisson 7ecab22302 Move sudo command making to one common function 13 years ago
Sergey Popov e41f89d507 Fix distribution detection - return string instead of functions 13 years ago
Jayson Vantuyl 13ddd39db9 add with_sequence lookup plugin
Plugin allows you to do easy counts for items.
13 years ago
Dag Wieers fb802beee7 In PR #1804 the use of C in script was moved to _low_level_execute_command()
So we cannot get rid of this one now.
13 years ago
Daniel Hokka Zakrisson 7782923ea2 Revert #1818 but avoid double-dwim, fixing relative fileglob 13 years ago
Daniel Hokka Zakrisson 891b1e371a Default to not using an executable
For compatibility with older releases as well as avoiding things like
action: raw executable= show status
to communicate with devices that don't have sh.
13 years ago
Daniel Hokka Zakrisson 92ad206b84 Use re instead of shlex.split to find executable
shlex.split will strip quotes and it might not even be sh at this point.
13 years ago
Michael DeHaan 910667152c Merge pull request #1843 from dagwieers/import-cleanup
Clean up imports (taken from PR #1804)
13 years ago
Dag Wieers b781438480 Clean up imports (taken from PR #1804) 13 years ago
Daniel Hokka Zakrisson 87b2378e22 Resolve variable references inside variables
Fixes the case where variable x is '$y' and y is a dict(foo='bar') and
an attempt to access ${x.foo} is made.
13 years ago
fdavis fe310dcff1 add when_failed, when_changed, and extended when_set/unset
This commit extends the 'when_' conditions to failed and changed
json results

Additionally it makes when_{set,unset,failed,changed,int,str,flt}
behave more similiarily in that they all except and/or/not logic
13 years ago
Daniel Hokka Zakrisson 1b5d039bf4 Extend executable= support in raw to include no execuable
Useful for managing not-UNIX things.
13 years ago
Daniel Hokka Zakrisson 4955587d8c Merge pull request #1798 from dagwieers/raw-executable
Allow to change executable (shell/interpreter) when using raw
13 years ago
Daniel Hokka Zakrisson c23eda82c2 Allow pattern[0] to address a single node
Replaces erroring out on it and requiring the abysmal pattern[0-0]
instead.
13 years ago
Michael DeHaan 03ab074d0d Merge pull request #1821 from leucos/path-expand-fix
Expands path on file operations
13 years ago
willthames 4e50478a05 Fix behaviour when file handles a path with tilde
Two problems here
* unchecked exception handling and erroneous assumption as to why
  an exception might fire
* although the file module expands the path, when using file_args
  the unexpanded path is passed.

Expected result: ~/path/to/file should work fine
Actual result: exception is because it doesn't find file with a message
about not being able to get the selinux context
13 years ago
Daniel Hokka Zakrisson 4d48daff80 Actually allow using connection: on a task 13 years ago
Daniel Hokka Zakrisson 637370089a Skip polling when all hosts were skipped
Fixes #1823.
13 years ago
Daniel Hokka Zakrisson 947ec34116 Merge pull request #1807 from willthames/openlog_unicode_fix
syslog.openlog does not cope with unicode first argument
13 years ago
Michel Blanc 7d7e7fb8bc Adds path expansion to two other methods
set_owner_if_different and set_group_if_different seems to need path
expansion too
13 years ago
willthames 411b2bf7d9 Added additional template variables
Added two additional template variables
* template_fullpath - absolute path to the template
* template_run_date - date that the template was rendered
Documented these additional variables in the module documentation
13 years ago
Daniel Hokka Zakrisson caee51e90e Allow only_if/when_* on task includes and apply it on all tasks within 13 years ago
Daniel Hokka Zakrisson 07b215d4fa Check for non-accepted arguments combined with task includes
Throw an appropriate error for it.
13 years ago
Daniel Hokka Zakrisson 68f736e8d7 Make inventory variables available to vars_files 13 years ago
Daniel Hokka Zakrisson a1877b2213 Allow infinite depth task includes 13 years ago
Daniel Hokka Zakrisson 4555cdc49c Allow using connection: on the task level
This is the name of the setting on the play level, and the options.
Should be consistent.
13 years ago
Michel Blanc 0037a19389 Expands path on file operations
Path might have to be expanded on some operations. It seems that path
containing '~' are not.
Using os.path.expanduser in appropriate places solves the problem, but
this might be required in many other places.
13 years ago
Stephen Fromm 2100a35663 Update path_dwim() to return absolute path
If path_dwim() is provided a relative path to a file, it will now return an
absolute path of the playbook directory + the relative file path.
13 years ago
willthames 5ef077e58c syslog.openlog does not cope with unicode first argument
It seems that os.path.basename(__file__) can return a unicode
string. In this case syslog.openlog fails. Forcing the result
to a string causes the resulting error to go away.
13 years ago
Dag Wieers eb36ff45b9 Make script module use raw module so it does not require python 13 years ago
Dag Wieers 846161a1a4 Allow to change executable (shell/interpreter) when using raw
This patch adds an optional 'executable=' option to the raw command line to override the default shell (/bin/sh), much like the shell module does.
13 years ago
Dag Wieers 988db558b3 Add return code and error output to raw module
Since we use 'raw' heavily on equipment where 'command' and 'shell' are not (yet) working (and python may need to be installed first using raw) these improvements are necessary in order to write more complex scripts (with return code handling and separated stdout/stderr).

This change includes the following changes:

 - exec_command() now returns the return code of the command
 - _low_level_exec_command() now returns a dict, including 'rc', 'stdout' and 'stderr'
 - all users of the above interfaces have been improved to make use of the above changes
 - all connection plugins have been modified to return rc and stderr
 - fix the newline problem (stdout and stderr would have excess newlines)

In a future commit I intend to add assertions or error handling code to verify the return code in those places where it wasn't done. Since only the output was available, the return code was ignored, even though we expect them to be 0.
13 years ago
Daniel Hokka Zakrisson d4c63e3300 Ensure each basedir is only added to the search path once
Fixes #1790.
13 years ago
Daniel Hokka Zakrisson 3a36c024da Make lookups being fatal up to the caller
Fixes #1769.
13 years ago
Daniel Hokka Zakrisson 97cc384ccf Set basedir to . if there isn't one
This avoids special-casing '' = '.' everywhere the basedir gets used.
Fixes #1729.
13 years ago
Daniel Hokka Zakrisson 0f1706220b Add support for using the Jinja2 built-ins such as range 13 years ago
Michael DeHaan d34e320e12 Merge pull request #1733 from dhozac/lookup-list
Make all lookup plugins accept lists as arguments
13 years ago
Michael DeHaan 04195e202d Merge pull request #1747 from njharman/alpharange
Alphabetic inventory hostname patterns.
13 years ago
Michael DeHaan 4bcdd24688 Merge pull request #1776 from junegunn/inventory-group-var-ws
Allows whitespaces around assignment operators when defining group variables
13 years ago
Junegunn Choi 8896486606 Adds comments on handling quoted group vars 13 years ago
Daniel Hokka Zakrisson c2792a936d Allow parameterized playbook includes to define complex variables
To be used like:
- include: playbook.yml
  vars:
    mylistvar:
    - item1
    - item2
13 years ago
Daniel Hokka Zakrisson b73016b881 Make all lookup plugins work with lists
Lookup plugins should accept a string or a list, and always return
a list, even if it is just one item.
13 years ago
Michael DeHaan 6350dedd7a Merge pull request #1765 from dagwieers/skip-when-no-matches
Change message when a play matches no hosts
13 years ago
Michael DeHaan ad2ab6a5dd Merge pull request #1772 from fdavis/devel
change error message on check_conditional when variable does not exist
13 years ago
Michael DeHaan 29611bdedf Merge pull request #1777 from dominis/devel
fixes #1767 parsing serial from extra_vars
13 years ago
Junegunn Choi 7fbb7e079a Fix hostname expansion bug in inventory parser 13 years ago
Nandor Sivok f31fbdff1f moving int() conversion to the play init 13 years ago
Nandor Sivok e91db5fcdc fixes #1767 parsing serial from extra_vars 13 years ago
Junegunn Choi daf797804b Allows whitespaces around assignment operators
when defining group variables
13 years ago
fdavis 7347e54b70 change error message on check_conditional when variable does not exist 13 years ago
Stephen Fromm ccca5fcd1c Ensure files created by authorized_key have correct selinux context
Three changes:
* Add set_default_selinux_context() to module_common that sets
  a file's context according to the defaults in the policy
* In atomic_replace(), set the default context for the file if
  selinux is enabled and the destination file does not exist.
* In authorized_key, set the default context when creating
  $HOME/.ssh and $HOME/.ssh/authorized_keys.  If these already
  exist, this won't touch them.
13 years ago
Dag Wieers cd930d2e34 Change message when a play matches no hosts
I guess my previous pull request was confusing, by changing the message to something we already do for tasks, it makes it more clear.

Just like we say:

    TASK: [foo bar]
    skipping: [system01]

The message now is more clear:

    PLAY [wagawaga] *******************************
    skipping: no hosts matched

It makes it clear that we are skipping the play, just as is done for a task when a condition is not met.
13 years ago
Michael DeHaan 70bb7d1e54 Merge pull request #1696 from gregorg/enhance_limit
Allow regex to be used to select hosts in addition to fnmatch pattern
13 years ago
Daniel Hokka Zakrisson 54b45e9bd4 Allow intersecting host patterns by using &
This allows patterns such as webservers:!debian:&datacenter1 to target
hosts in the webservers group, that are not in the debian group, but are
in the datacenter1 group. It also parses patterns left to right.
13 years ago
Norman J. Harman Jr 6603737e4d Alphabetic inventory hostname patterns.
- Code, docs, tests.
  - Also added test of large range 000-142 to verify alpha range did not
    break this.
13 years ago
Dag Wieers dd4ac46397 Import errno to avoid 'NameError: global name 'errno' is not defined'
I hit the following exception because errno is referenced but not imported.

```
fatal: [system01] => failed to parse: Traceback (most recent call last):
  File "/root/.ansible/tmp/ansible-1354644532.37-246102819320352/copy", line 782, in <module>
    main()
  File "/root/.ansible/tmp/ansible-1354644532.37-246102819320352/copy", line 117, in main
    module.atomic_replace(dest_tmp, dest)
  File "/root/.ansible/tmp/ansible-1354644532.37-246102819320352/copy", line 772, in atomic_replace
    if e.errno != errno.EPERM:
NameError: global name 'errno' is not defined
```
13 years ago
Michael DeHaan dbf5a57a5a Merge pull request #1683 from bcoca/template_override
Template override
13 years ago
Daniel Hokka Zakrisson e54b4b1c9a Ignore arguments when checking for interpreter, and re-add before use 13 years ago
Daniel Hokka Zakrisson d5a456fbcf Merge pull request #1697 from bcoca/mint
Implements multiple interpreter overrides
13 years ago
Daniel Hokka Zakrisson ffac7ce2f9 Merge pull request #1687 from dhozac/allow-grouping-in-external-inventory
Allow inventory scripts to define groups of groups and group vars
13 years ago
Dag Wieers c65c00cb34 Updated ansible version to align with RPM package 13 years ago
Michael DeHaan 5890a2a9da Release stuff 13 years ago
Michael DeHaan 9afb7c1ed0 Get ready to release 0.9 13 years ago
Jan-Piet Mens 17f31a2a79 CLI: ansible-doc shows lists of modules & module docs on command-line
check path is directory
added manpage & setup
small cleanup
shut up module_formatter in utils to avoid trace print on crud files in library
13 years ago
Daniel Hokka Zakrisson 8d309e0fa3 Allow inventory scripts to define groups of groups and group vars 13 years ago
Daniel Hokka Zakrisson b8d6dec5ad Reset notified_by list per serialized batch
Fixes the case where a handler attempts to run for every batch after any
batch has notified it, regardless of whether the current batch did.
13 years ago
Daniel Hokka Zakrisson a56e1f31fa Properly restrict hosts after 9070875 13 years ago
Daniel Hokka Zakrisson f6245e17c1 Skip evaluating only_if for BYPASS_HOST_LOOP plugins 13 years ago
Daniel Hokka Zakrisson bda08c8a1b Avoid creating temporary directory for some action plugins
This ensures we don't litter remote systems with temporary directories
that don't get cleaned up, as well as speeds things up from not having
to touch every node.
13 years ago
Daniel Hokka Zakrisson f6e7381a71 Evaluate only_if in group_by 13 years ago
Daniel Hokka Zakrisson 9070875a6f Move available hosts gathering to a common function 13 years ago
Daniel Hokka Zakrisson 5065103017 Skip already failed hosts
Fixes #1699.
13 years ago
Daniel Hokka Zakrisson c948c65bcd Template the name of the task
Broken by 1e0295c. Fixes #1698.
13 years ago
Brian Coca 2f2bd87b06 multiple _interpreter overrides with ansible_<bin>_interpreter variables, not
just for python anymore
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Gregory Duchatelet dde01dabc3 Squashed commit of the following:
commit 48069adf0f
Author: Gregory Duchatelet <skygreg@gmail.com>
Date:   Tue Nov 27 10:13:08 2012 +0100

    Removing this plugin from this branch.

commit 15400fffe6
Author: Gregory Duchatelet <skygreg@gmail.com>
Date:   Tue Nov 27 09:53:16 2012 +0100

    Enhance _match function in inventory with regex.
    --limit ~regex could be used to filter hosts or group with a regex.
    Tested on cli and ansible-playbook.

commit 63c1b2e17e
Author: Gregory Duchatelet <skygreg@gmail.com>
Date:   Tue Nov 27 09:03:41 2012 +0100

    Revert pull request #1684

commit 7c2c6fee3a
Merge: f023a2f dd5a847
Author: Gregory Duchatelet <skygreg@gmail.com>
Date:   Tue Nov 27 08:52:53 2012 +0100

    Merge remote branch 'upstream/devel' into devel

commit f023a2f3df
Author: Gregory Duchatelet <skygreg@gmail.com>
Date:   Mon Nov 26 20:52:27 2012 +0100

    Add an inventory plugin to fetch groups and host from our CMDB.

commit c64193b4c6
Author: Gregory Duchatelet <skygreg@gmail.com>
Date:   Mon Nov 26 20:43:30 2012 +0100

    Added possibility to filter hosts from a group, with a regex, separating
    groupname and regex with a ~
    Usage in group pattern: group~filterpattern
    Samples:
    ansible group~server-0[1236] -m ping
    ansible web~proxy -m ping
    ansible web~(proxy|frontend) -m ping
13 years ago
Daniel Hokka Zakrisson 900790af41 Reuse inventory object created by ansible-playbook in playbook
This reduces the amount of times an inventory script has to be invoked.
13 years ago
Daniel Hokka Zakrisson d703f92077 Disable authentication methods that weren't specified 13 years ago
Stephen Fromm 6a68d3813f Set LANG in module_common.py
Add constant DEFAULT_MODULE_LANG that defaults to C.  Can be set via
environment variable ANSIBLE_MODULE_LANG or configuration variable
module_lang.  Updated test-module to have same behavior.
13 years ago
Michael DeHaan da90c5f75e Document 'when' and tweak the code to be a little more comprehensive on what is false. 13 years ago
Daniel Hokka Zakrisson 43bdec8b20 Throw an error if multiple actions have been specified 13 years ago
Daniel Hokka Zakrisson 1e0295c7e2 Template handlers late
This allows overriding variables in name, and removes templating from
parsing.
13 years ago
Daniel Hokka Zakrisson ebd31af940 Don't prompt for vars in extra-vars
Fixes #1622.
13 years ago
Daniel Hokka Zakrisson 94fc3006e9 Make variables local to the play
Fixes #1677.
13 years ago
Brian Coca d7f38d07b3 fixed bug for string size mismatch, now substring depends on size of match string Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca 6a1e2aaff5 moved override matching string to variable changed test template to match Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Brian Coca 68f5d69365 added ability to override jinja enviornment from first line of template Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Daniel Hokka Zakrisson 0c70abfaa9 Make sure any existing groups gets reused 13 years ago
Daniel Hokka Zakrisson 5504f13c68 Create groups in the first run through the file
Fixes #1208.
13 years ago
Daniel Hokka Zakrisson 2bfb7deec0 Set all in the returned dict
Otherwise the group is lost, and group_vars/all isn't used.
13 years ago
Michael DeHaan 33196ec131 Merge pull request #1669 from dagwieers/ssh-tcgetattr2
Use proper pseudo-tty's instead of pipes when using subprocess
13 years ago
Dag Wieers 7192eb3047 Use proper pseudo-tty's instead of pipes when using subprocess
This change avoids the "tcgetattr: Invalid argument" error by making sure the ssh we start does have a proper pseudo-tty.

We could also check whether our current terminal is a proper terminal (by doing a tcgetattr ourselves) but I don't think this adds anything.

This closes #1662 (if all use-cases have been tested: sudo, passwd)
13 years ago
Daniel Hokka Zakrisson db1a65342a Set -c local cwd to . if basedir is empty 13 years ago
Daniel Hokka Zakrisson 715d875dcb Group should only return its own variables
Otherwise, a host in two groups, A and B, using a variable defined
in group A and all will get the value of all, as B's variables will
include the all variable.

Partially fixes #1647.
13 years ago
Daniel Hokka Zakrisson e44b85daba Remove special-casing for all group
global_vars has higher precedence than inventory. Putting the all
group's variables into it overrides all other groups and hosts.

Partially fixes #1647.
13 years ago
Daniel Hokka Zakrisson bd7e02d629 Get all groups' variables in order of depth
Fixes all not being processed, as well as the order of the variable
precedence
13 years ago
Daniel Hokka Zakrisson d5dd89a8f7 Allow specifying when: ... 13 years ago
Daniel Hokka Zakrisson fd732f8d3b Add when_boolean
Fixes #1567.
13 years ago
Daniel Hokka Zakrisson ddef608c94 Wrap all remote commands in sh 13 years ago
Daniel Hokka Zakrisson 047d089cea Restore git output on --version
Broken by the move from utils.py to utils/__init__.py
13 years ago
Daniel Hokka Zakrisson ef357ed1f2 Use the play's vars for the setup step
Allows using -e ansible_ssh_port=foo and have it apply to all actions.
13 years ago
Daniel Hokka Zakrisson d1c285b70b Port may be an integer when parsed from the play 13 years ago
Michael DeHaan 82f4aef959 Merge pull request #1648 from dhozac/local-cwd-basedir
Use runner's basedir as cwd for -c local
13 years ago
Michael DeHaan 41af2fce64 Merge pull request #1650 from dagwieers/port-not-integer-exception
Provide a proper error when the remote_port is not an integer
13 years ago
Daniel Hokka Zakrisson 3ce63d845e remote_port is None by default 13 years ago
Daniel Hokka Zakrisson 6b69b37eb0 Merge pull request #1649 from dagwieers/template-port
Allow the remote port to be templated per play
13 years ago
Dag Wieers 85bba04a1c Provide a proper error when the provided port is not an integer
As reported on the mailinglist, the user received a ValueError when the port number was not templated (fixed in #1649) and therefore it was not an integer. This change will catch the exception and provide a proper error so it is more clear.
13 years ago
Dag Wieers 8458f53014 Allow the remote port to be templated
This was requested on the mailinglist and seems useful.
13 years ago
Daniel Hokka Zakrisson 48898993b9 Fix removing of temporary files 13 years ago
Daniel Hokka Zakrisson 0ebf4b2d5a Add destination path to fetch result 13 years ago
Daniel Hokka Zakrisson bdf05ec9a0 Use runner's basedir as cwd for -c local 13 years ago
Daniel Hokka Zakrisson f89f07871d Fix typo in first_available_file error path 13 years ago
Daniel Hokka Zakrisson f95fefd8c5 Use plugin system to find modules 13 years ago
Daniel Hokka Zakrisson 5dd2ec2cae Add a way to add directories to just one type of loader 13 years ago
Daniel Hokka Zakrisson d2abfb9ff8 Ensure runner adds its basedir, so ansible can benefit from plugins 13 years ago
Daniel Hokka Zakrisson 5183417de8 Reinstate ANSIBLE_KEEP_REMOTE_FILES
Fixes #1395.
13 years ago
Daniel Hokka Zakrisson 11175781b8 Use slurp for fetch is sudo is enabled and needed
Fixes #1020.
13 years ago
Daniel Hokka Zakrisson 11afd84d32 Drop dwim prefix from returned items in fileglob
Fixes #1618.
13 years ago
Michael DeHaan 1b78dabcd4 Merge pull request #1632 from dhozac/use-ssh-conn-section-for-scp
Use the ssh_connection section for scp_if_ssh
13 years ago
Michael DeHaan 3bc0adacbf Merge pull request #1634 from dhozac/ssh-password
Add password support to -c ssh via sshpass
13 years ago
Daniel Hokka Zakrisson e6fed9f216 Add password support to -c ssh via sshpass 13 years ago
Daniel Hokka Zakrisson 021172f78d Use the configured remote_tmp even for root 13 years ago
Daniel Hokka Zakrisson c906f44d90 Use the ssh_connection section for scp_if_ssh 13 years ago
Michael DeHaan ab5c0dfe7e __new__ does not take arguments, remove deprecation warning 13 years ago
Michael DeHaan 096607eea4 Allow fireball to transfer binary files, fixup fireball docs, make fetch work with fireball. 13 years ago
Michael DeHaan d500398e76 Merge pull request #1616 from dagwieers/skip-register
Do not register variable if host has been skipped
13 years ago
Michael DeHaan 52e2654faf Merge pull request #1621 from dhozac/lookup-with-vars
Lookup plugin arguments need to be templated
13 years ago
Daniel Hokka Zakrisson 17e4ce97a4 Create a set of all the hosts in a group to prevent duplicates
Fixes #1516.
13 years ago
Daniel Hokka Zakrisson e74ffd6764 Lookup plugin arguments need to be templated 13 years ago
Dag Wieers 302eeae65d Do not register variable if host has been skipped
Executive summary: skipping a host corrupts a variable (when it is registered)

We have a play existing out of multiple tasks that check a condition, if one of these tasks fails we want to skip all next tasks in the playbook. I noticed that if we skip a task because a certain condition is met, and this task has a register-attribute, I loose the value in the variable. Which means we cannot use that variable in subsequent tasks to evaluate because it was skipped:

```
- action: command test -d /some/directory
  register: task

- action: command test -f /some/directory/file
  register: task
  only_if: '${task.rc} == 0'

- action: do something else
  only_if: '${task.rc} == 0'
```

In the above example, if the second task is skipped (because the first failed), the third action will end with a "SyntaxError: invalid syntax" complaining about the unsubstituted ${task.rc} (even though it was set by the first task and used for skipping the second).

The following play demonstrates the problem:

```
- name: Test register on ignored tasks
  hosts: all
  gather_facts: no

  vars:
    skip: true
    task: { 'rc': 666 }

  tasks:
  - action: debug msg='skip = ${skip}, task.rc = ${task.rc}'

  - name: Skip this task, just to test if task has changed
    action: command ls
    register: task
    only_if: '${skip} != True'

  - action: debug msg='skip = ${skip}, task.rc = ${task.rc}'

  - name: Now use task value
    action: command echo 'Works !'
    only_if: '${task.rc} == 0'
```

And the enclosed fix, fixes the above problem.
13 years ago
Michael DeHaan 44af1408ee Merge pull request #1611 from dhozac/no-hostvars-templating
Keep hostvars from being templated
13 years ago
Michael DeHaan 6793bcbe4d Merge pull request #1613 from dhozac/use-all-vars-for-hosts-template
Use all available vars for hosts:, user: and sudo_user:
13 years ago
Michael DeHaan 2303f65a1a Merge pull request #1614 from dagwieers/missing-action-error
Print the task name (if any) when complaining
13 years ago
Dag Wieers b96877e5aa Print the task name (if any) when complaining
After spending 10 minutes to find which playbook had an action/local_action missing, I changed the error to include the task name (if set). The error eventually was caused because I added a name to a task, but the dash before the existing action was not removed.
13 years ago
Daniel Hokka Zakrisson 0be1f11ed5 Use all available vars for hosts:, user: and sudo_user: 13 years ago
Daniel Hokka Zakrisson eebbbd3f0e Make parameterized playbook includes work with vars as a list
Fixes #1610.
13 years ago
Daniel Hokka Zakrisson c200c26ced Keep hostvars from being templated 13 years ago
Michael DeHaan e3f7f86ac4 Merge pull request #1608 from dhozac/when_set-non-string
Try to ensure the entire value is quoted
13 years ago
Michael DeHaan d5be13c3f0 Merge pull request #1605 from romeotheriault/add-md5-support-to-fetch-module
add bsd md5 support to fetch module
13 years ago
Daniel Hokka Zakrisson 0ca1775bda Try to ensure the entire value is quoted 13 years ago
Daniel Hokka Zakrisson 25a8787e95 Template all variables before returning them to Jinja2 13 years ago
Daniel Hokka Zakrisson d2dce1d63f Make lookup plugin replacements part of the main variable logic 13 years ago
Daniel Hokka Zakrisson a2bb3a09d2 Completely ignore stray $ in input
Previously, "a $ string $var" would not have gotten replaced at all.
13 years ago
Daniel Hokka Zakrisson 24b536d7ed Add some comments to templating system 13 years ago
Romeo Theriault 4cd133ed8f add bsd md5 support to fetch module 13 years ago
Daniel Hokka Zakrisson 233a36b9e8 Template using module_vars early
Since no basedir is available at that time, avoid invoking
lookup plugins since they assume it is present.
13 years ago
Michael DeHaan c890ae18e7 Merge pull request #1575 from dhozac/parameterized-playbook-include
Add parameterized playbook includes
13 years ago
Michael DeHaan 3e855a5fcd Merge pull request #1593 from dhozac/lookup_generic
Add support for generic $XXX() to call $LOOKUP()
13 years ago
Michael DeHaan 451f05fa3d Merge pull request #1594 from sfromm/issue1342
Add ability to specify syslog facility for modules
13 years ago
Romeo Theriault 54b7f59416 remove verbose option on digest call 13 years ago
Stephen Fromm 06e54c0b97 Add ability to specify syslog facility for modules
Update constants.py so that one can specify environmental variable
ANSIBLE_SYSLOG_FACILITY or syslog_facility in ansible.cfg to define
the syslog facility to use.  Alternatively, you can specify
ansible_syslog_facility in inventory.  Runner now replaces
the syslog facility in the openlog() call with the default or
the injected variables ansible_syslog_facility.

This also updates hacking/test-module to behave similarly.
13 years ago
Daniel Hokka Zakrisson 9924555623 Add support for generic $XXX() to call $LOOKUP() 13 years ago
Michael DeHaan 40e49b6a5a Merge pull request #1592 from jpmens/lookup_dnstxt3
$LOOKUP(dnstxt): handle exceptions
13 years ago
Jan-Piet Mens bd55899a60 $LOOKUP(dnstxt): handle exceptions
de-spaced
13 years ago
Michael DeHaan db3e8c0803 Merge pull request #1579 from jpmens/lookup_env
Add environment $LOOKUP plugin
13 years ago
Michael DeHaan 35679e0093 Merge pull request #1578 from jpmens/lookup_redis
Add Redis GET $LOOKUP plugin
13 years ago
Jan-Piet Mens 6efc98e8a3 Add environment $LOOKUP plugin
remove support for multiple vars
13 years ago
Jan-Piet Mens e3e545418d Add Redis GET $LOOKUP plugin
renamed
13 years ago
Jan-Piet Mens e32f4a0564 Move get_docstring from module_formatter into ansible/utils 13 years ago
Daniel Hokka Zakrisson 9c095b72b9 Add parameterized playbook includes
Also makes with_* work with them.

Fixes #1162.
13 years ago
Daniel Hokka Zakrisson 383dc30560 Rename varReplaceWithItems to template_ds 13 years ago
Michael DeHaan 325025a5b6 Merge pull request #1574 from dhozac/ssh-moar-data
Make sure we get all data
13 years ago
Michael DeHaan fa17540a06 Merge pull request #1570 from skvidal/addhost
Addhost module
13 years ago
Daniel Hokka Zakrisson e97a22603f Make sure we get all data 13 years ago
Jan-Piet Mens 38d9dc8bff Add DNS TXT record LOOKUP plugin 13 years ago
Seth Vidal 70d61fe7e8 need to use the variabled results 13 years ago
Seth Vidal e147ad4213 add add_host action plugin - add hosts to inventory during a playbook
run - lets act on those hosts in the next play
13 years ago
Michael DeHaan 03591e0fc8 Merge pull request #1551 from dagwieers/local_action-fail
Turn 'fail' and 'debug' modules into action_plugins
13 years ago
Michael DeHaan a31ca213a5 Merge pull request #1562 from dagwieers/oneline-fix
Make --oneline return one line (except with multiline output)
13 years ago
Michael DeHaan 03f4b0f923 Merge pull request #1560 from dagwieers/module-output-consistency
Make module output more consistent wrt. changed/failed
13 years ago
Michael DeHaan 3dc31a049f Merge pull request #1527 from fdavis/devel
Support scp in an ssh connection
13 years ago
Dag Wieers d42eb2563b Make --oneline return one line (except with multiline output)
Currently the message prepared for --oneline mode adds a newline to the msg-string, which is then printed (adding another newline). This change removes the added newline so that successes and failures do not differ in output (except if the output is multiline).
13 years ago
Dag Wieers fe0c70fe9d Make module output more consistent wrt. changed/failed
- Make sure exit_json() always returns a changed= value
- Modify the yum module to not return failed=False
- Modify install() and latest() similar to remove() in yum module
- Changed exit_json(failed=True, **res) into a fail_json(**res)
- Make sure yum rc= value reflects loop (similar to how we fixed remove())
13 years ago
Dag Wieers dd07011a65 Only print 'Invoked with' if there are arguments to the module
This closes #1519
13 years ago
Dag Wieers d8459425a0 Turn 'fail' and 'debug' modules into action_plugins
This makes more sense as there is no purpose in running these remotely.
13 years ago
Daniel Hokka Zakrisson 47082a9171 Add $LOOKUP(<lookup plugin>,<data>) as a templating option
Also moves file and pipe to lookup_plugins.
13 years ago
Michael DeHaan a1f7334634 Merge pull request #1525 from jhoekx/custom-filter-plugins
Support custom jinja2 filters.
13 years ago
Michael DeHaan c9ae19c44c Merge pull request #1547 from dagwieers/action-boolean
Bail out if an action is not a string
13 years ago
Dag Wieers c9e62d7061 Fix for an exception when for whatever reason the inventory script fails
This avoids a traceback that gave no clue as to what was happening.

This is in line with the change from #1535
13 years ago
Dag Wieers dfa1e8b0dc Bail out if an action is not a string
Since YAML allows anything, we should enforce that actions are strings.

This closes #1419.
13 years ago
Michael DeHaan 75d3b77454 Merge pull request #1535 from dagwieers/inventory-exception
Fix for an exception when for whatever reason the inventory script fails
13 years ago
Daniel Hokka Zakrisson 00aa584c57 Don't double dwim first_available_file in template 13 years ago
Dag Wieers 89206a6b68 Fix for an exception when for whatever reason the inventory script fails
This avoids a traceback that gave no clue as to what was happening.
13 years ago
fdavis b1dbeec66c Allows use of scp instead of sftp in
Added a boolean constant scp_if_ssh to the config
Added scp support for the ssh connection plugin
Refers to #1279
13 years ago
Jeroen Hoekx 8ffed6df75 Support custom jinja2 filters.
This uses the plugin framework to add filter plugins.
The previously hardcoded core filters are defined using the plugin
framework now.
13 years ago
Michael DeHaan 6f938c9f4c Merge branch 'playbook_ssh_ask_pass' of git://github.com/clatour/ansible into devel
Conflicts:
	examples/ansible.cfg

+ doc tweak
13 years ago
Michael DeHaan 908c43ad7f Merge branch 'devel' of git://github.com/skorokithakis/ansible into devel 13 years ago
Michael DeHaan 05de2152a0 Merge branch 'sudo_ask_pass_config' of git://github.com/bcoca/ansible into devel 13 years ago
Michael DeHaan 154a00e612 Merge branch 'plugin-sanity' of git://github.com/dhozac/ansible into try_new_plugins 13 years ago
Michael DeHaan c96f2c968e Merge branch 'nigelm_freebsd' of git://github.com/nigelm/ansible into merge-service
Make things more reusable, correct some errors along the SSH key path

Conflicts:
	library/user
13 years ago
Seth Vidal e19c81977d if a module returns failed in the results, don't fail unless failed is not false. 13 years ago
Chandler Latour f436a8c88b Added config option for default ask for ssh_pass 13 years ago
Daniel Hokka Zakrisson e05e514861 Create a plugin loader system 13 years ago
Daniel Hokka Zakrisson 000d3832cc Make ansible.utils a package 13 years ago
Stavros Korokithakis 3616dffb68 Detect whether we're running in a virtualenv. 13 years ago
Michael DeHaan 4c156e4df8 Merge pull request #1502 from dhozac/improved-lookup-plugins
Improved lookup plugins
13 years ago
Michael DeHaan 025402c0bf Merge pull request #1507 from lorin/pretty-print-msg
Pretty-print "msg" when task fails
13 years ago
Stavros Korokithakis d9a377cbb1 Fix installing to virtualenvs. 13 years ago
Daniel Hokka Zakrisson 07ba7e2013 Return original string for non-matched vars 13 years ago
Lorin Hochstein 1c5ac5cac8 Pretty-print "msg" when task fails
Several modules (e.g., pip) return stdout and stderr together in a "msg" variable (and the module development docs seem to suggest that the standard practice is to return status in this variable).

This change ensures that it is printed out with correct formatting (most importantly, with newlines appearing as newlines instead of \n).
13 years ago
Daniel Hokka Zakrisson fbda2d4628 Use default port if ansible_ssh_port is not set for the delegated node
Also add testcase for it.
13 years ago
Daniel Hokka Zakrisson c519d5dac0 Add a template lookup plugin
Requires that inject be passed to run
13 years ago
Daniel Hokka Zakrisson 37d9acc097 Make lookup API extensible and allow basedir to be passed
This allows using with_fileglob in play context, e.g.
- include: $item
  with_fileglob: tasks/*.yml
as well as prepares for other data to be passed.
13 years ago
Daniel Hokka Zakrisson 2c77cf1a49 Skip tasks with a with_* that is empty 13 years ago
Brian Coca 604bf9f58a Added config option to control default of asking or not for sudo password
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
13 years ago
Michael DeHaan be300b562a pyflakes fixes (mostly unused imports, unused vars) 13 years ago
Michael DeHaan c0747b7baa pep8 fixes 13 years ago
Michael DeHaan 0853ece810 Merge pull request #1474 from jhoekx/group-by-plugin-template
Add a group_by action plugin.
13 years ago
Michael DeHaan f9a6265fb2 Merge branch 'vars_files-list-no-default' of git://github.com/dhozac/ansible into devel 13 years ago
Michael DeHaan 6dceef3a5f Merge branch 'fix-var-in-var' of git://github.com/dhozac/ansible into devel 13 years ago
Daniel Hokka Zakrisson efe83daf19 Fix ${var.$other_var} and add test cases for it 13 years ago
Michael DeHaan 9a12873166 Merge pull request #1477 from skvidal/devel
add check that vars plugins are not handing back None
13 years ago
Seth Vidal 3fcc591f18 add check that vars plugins are not handing back None 13 years ago
Dag Wieers 3728b2f459 Missing errors-import causes traceback 13 years ago
Jeroen Hoekx b336d40101 Add a group_by action plugin. 13 years ago
Jeroen Hoekx f963db6c2a Fix output of pause plugin. 13 years ago
Jeroen Hoekx 77162e95e4 Send a host to runner executor instead of a letter.
Discovered in #1463 .
13 years ago
Daniel Hokka Zakrisson e72fdccd87 Allow vars_files sequences without a default 13 years ago
Daniel Hokka Zakrisson 55a1473d50 Don't add file module arguments by default
This allows the postgresql_db module to work properly, as it uses
an argument named owner that conflicts with the file module.
13 years ago
Michael DeHaan 21258dcc66 Added 'when' as a shortcut around only_if. 13 years ago
Michael DeHaan a768e9a9ff Fix for sudo defaults if sudo is passed in via --extra-vars 13 years ago
Michael DeHaan 6ba30170dd Make group_vars and host_vars available to usr/bin/ansible, and make vars_plugins exist 13 years ago
Michael DeHaan e04dab904a Use previous proven multiprocessing logic as the simplification didn't have the same Ctrl-C handling and may
be subject to race issues, though still don't pass Runner to each.  Still seems performant.
13 years ago
Daniel Hokka Zakrisson 1052dd9c8f Initialize sftp variable to fix error on transferless session 13 years ago
Michael DeHaan 5e2c2564bc Explicitly execute /bin/sh versus $SHELL because some folks have very incompatible/weird shells. We do not
execute modules through the shell, this is only for basic ops, so should be sufficient.
13 years ago
Michael DeHaan ff787146d1 stray debug 13 years ago
Michael DeHaan 24416b9e49 Remove stray debug message 13 years ago
Michael DeHaan 3257c5b61f Some caching improvements to paramiko which are still not yet fully leveraged
in playbook mode, since the Runner still closes abstract host connections completely
and does not have a LRU.
13 years ago
Michael DeHaan 4c83c274e0 Don't close paramiko SFTP multiple times in the same runner pass. Noticeable performance increase. 13 years ago
Michael DeHaan 8b50ad7e85 Fix for atomic_replace patch if file does not yet exist 13 years ago
Daniel Hokka Zakrisson 7a8009f979 When atomically replacing files, copy attributes 13 years ago
Michael DeHaan 19a5f86c2e Merge pull request #1452 from dhozac/with_items-as-plugin
Make with_items a lookup plugin
13 years ago
Michael DeHaan 9a141160a4 Merge pull request #1449 from dhozac/localhost-interpreters
Use the delegated host's interpreters
13 years ago
Michael DeHaan 347b0260c3 Merge varReplace cleanup and move code into new file 'template.py' so it's easier to keep template
code all together.
13 years ago
Michael DeHaan f8e946b71d Merge branch 'varfind-cleanups' of git://github.com/dhozac/ansible into devel 13 years ago
Daniel Hokka Zakrisson 2f05e95d8a Use lookup plugins for task include with_* 13 years ago
Daniel Hokka Zakrisson 026e251b94 Make with_items a lookup plugin 13 years ago
Michael DeHaan ffca0283b0 Closing pool explicitly may cause some exceptions on certain Pythons, disable for now. 13 years ago
Daniel Hokka Zakrisson 13a422261b Use the delegated host's interpreters 13 years ago
Michael DeHaan bbe66e7610 Merge pull request #1437 from lorin/sudo-nonroot-bugfix
Fix chmod occurring as wrong user when sudo as non-root
13 years ago
Michael DeHaan 9fca4eb241 Merge pull request #1441 from dhozac/better-error-missing-template
Improve the error message for missing files
13 years ago
Daniel Hokka Zakrisson b1200c16df path_dwim the path given to with_fileglob 13 years ago
Daniel Hokka Zakrisson e216116807 Improve the error message for missing files 13 years ago
Lorin Hochstein 38fdc24966 Fix chmod occurring as wrong user when sudo as non-root
If you sudo to a non-root user, you get a permission denied error.
Here's an example:

    $ ansible myserver.example.com -m postgresql_db -a "db=mydatabase" -u ubuntu -s -U postgres
    myserver.example.com | FAILED >> {
        "failed": true,
        "msg": "chmod: changing permissions of `/tmp/ansible-
        1351092257.96-157699143369671/postgresql_db': Operation not
        permitted\n/usr/bin/python: can't open file '/tmp/ansible-
        1351092257.96-157699143369671/postgresql_db': [Errno 13]
        Permission denied\n",
        "parsed": false
    }

The problem is that ansible is doing the chmod as the sudo user
when it should be doing it as the remote user.
13 years ago
Michael DeHaan f1f44843c3 close the pool. 13 years ago
Michael DeHaan 92ce8a0517 Refine new keyboard interrupt handling. Output still a bit gross. 13 years ago
Michael DeHaan 47b1315ac7 Reinstate Ctrl+C handling 13 years ago
Michael DeHaan a4af4a7049 Since we are not needing to pass runner through the multiprocessing queue, just use
multiprocessing.pool.  Pushing so it can get wider testing.
13 years ago
Michael DeHaan 856dd5a9aa Don't pass runner instance through the mulitprocessing queue, fix temp dir removal 13 years ago
Seth Vidal d63fa6f026 make --limit take a , as a separator as well as ; or : 13 years ago
Michael DeHaan 109632e3bc Revert "Vars specified via CLI have the highest priority."
Reverting as this as reported allows some variables to clobber each other.
We'll work on a different fix.

This reverts commit c5469f6367.
13 years ago
Daniel Hokka Zakrisson 1449c8ac67 Fix ansible_ssh_host again
This time with unit tests to ensure it keeps working.
13 years ago
Daniel Hokka Zakrisson c9c5fc1456 Merge varFind and varLookup 13 years ago
Michael DeHaan 3c6d9972fe clarify message about name of configuration parameter 13 years ago
Michael DeHaan cbc12f0dba Various performance streamlining and making the file features usable in all modules without daisy chaining. 13 years ago
Michael DeHaan 4104478abd Added 'script', a module that can push and insantly run a remote script. Replaces the need to copy+command.
This is a bit of a rough draft, some error handling still needs to be added.
13 years ago
Michael DeHaan 019f775a93 DWIM the paths for first_available_file 13 years ago
Michael DeHaan 6fa1a49037 Fix the basic templating system such that when the template ends in '$', life continues as normal. 13 years ago
Michael DeHaan ed9f5eed09 Merge pull request #1338 from alopropoz/extra_vars_override
Vars specified via CLI have the highest priority.
13 years ago
Michael DeHaan 5bdc16338e Release version bump for 0.9 (development branch) 13 years ago
Michael DeHaan cde377bddb Merge pull request #1385 from dhozac/raise-error-for-scripts-too
Raise error for missing hosts in inventory scripts as well
13 years ago
Daniel Hokka Zakrisson b8021f12e0 Raise error for missing hosts in inventory scripts as well 13 years ago
Daniel Hokka Zakrisson e3d18048d4 None is unfortunately not an integer 13 years ago
Michael DeHaan d509dfc969 delete extra else clause 13 years ago
Michael DeHaan 452668ce83 Merge branch 'devel' of git://github.com/willthames/ansible into devel 13 years ago
Michael DeHaan 31b45479e8 When using delegation, local_action should always use the local connection type. 13 years ago
Daniel Hokka Zakrisson 979999b886 Port should be an integer 13 years ago
Daniel Hokka Zakrisson 19797e1a29 Accessing a node that doesn't exist throws an exception 13 years ago
willthames 5a769a5a4d Fixed tests to reflect desired configuration behaviour
Test for when environment variable and configuration file
variable both set now tests that the environment variable takes
precedence

Removed logic that would never be triggered from
lib/ansible/constants.py
13 years ago
Michael DeHaan 556799a7c4 add error message if keyczar is not installed and the user tries to use fireball mode 13 years ago
Michael DeHaan d5db8e937e Fix port overrides such that with fireball mode you don't have to specify an explicit port. 13 years ago
Michael DeHaan fd6a26239c Env var vs config priority fixing 13 years ago
Michael DeHaan 0837a29e51 Only expand lists in templating inside of module action lines, to avoid breaking usage with with_items and "in" statements, etc 13 years ago
Michael DeHaan acf2c23808 Various tweaking of the delegate_to loop code. 13 years ago
Daniel Hokka Zakrisson 37b91c7b81 Fix ansible_ssh_host after 339c05bb 13 years ago
Daniel Hokka Zakrisson 519a1f3f23 Remove debug print statements 13 years ago
Michael DeHaan 22e3e7f323 Allow use of variables in delegate_to 13 years ago
Michael DeHaan a69e59ab2b Allows delegate_to to use inventory host/port info. 13 years ago
Michael DeHaan 8c3abe7e52 Fix cowsay! Moo. 13 years ago
Michael DeHaan 63100c9bc0 Docs + fix variable precedence of environment variables (ok, ok, I give in!) 13 years ago
Michael DeHaan f3407dec0e Merge branch 'basedir-plugins' of git://github.com/dhozac/ansible into devel 13 years ago
Aleksej Romanov c5469f6367 Vars specified via CLI have the highest priority. 13 years ago
Brian Coca e98153d26d cowsay for BSD!
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
13 years ago
Daniel Hokka Zakrisson ab44a4abba Load additional plugins from path specified in configuration 13 years ago
Daniel Hokka Zakrisson 1aaf86069a Look for plugins in the playbook's basedir 13 years ago
Michael DeHaan c5d2f6b0d3 implement lookup plugins for arbitrary enumeration over arbitrary things. See the mailing list for some cool examples. 13 years ago
Michael DeHaan 271db7bddb Merge pull request #1308 from abondis/named_action
named actions + modules list in utils.py
13 years ago
Aurélien Bondis 6d183959ba #1303: add sudo option to tasks 13 years ago
Aurélien Bondis 2063e10c00 named actions + modules list in utils.py 13 years ago
Michael DeHaan 5849ab3162 Merge pull request #1300 from tbielawa/fix_module_path
Add DIST_MODULE_PATH so setup.py and ansible.spec can live in harmony
13 years ago