Commit Graph

4946 Commits (9e1bc434c768dab26468220de4bc57490f5666cd)

Author SHA1 Message Date
Brian Coca 74079db8d2 ported dig lookup from v1 9 years ago
Brian Coca 9bb95b5235 Merge pull request #12031 from amenonsen/deadcode
Remove unused (copied) _before_comment method
9 years ago
Brian Coca f6b6ed530b added file tests 9 years ago
Brian Coca cd4a0c70b0 isnotanumber is not needed as jinja2 has builtin number test 9 years ago
Brian Coca fe06577ac2 fixed mandatory test 9 years ago
Abhijit Menon-Sen 599ad9cb51 Remove unused (copied) _before_comment method
This was copied from inventory/ini.py, but the rewritten version doesn't
use it, and shows that it isn't needed.
9 years ago
Toshio Kuratomi b5a078a385 update submodule refs 9 years ago
Abhijit Menon-Sen 745ecd4845 Sanitize IPv6 hostname/port handling
Now we accept IPv6 addresses _with port numbers_ only in the standard
[xxx]:NN notation (though bare IPv6 addresses may be given, as before,
and non-IPv6 addresses may also be placed in square brackets), and any
other host identifiers (IPv4/hostname/host pattern) as before, with an
optional :NN suffix.
9 years ago
Abhijit Menon-Sen 74aab6f726 Use a self._raise_error helper and avoid passing the lineno around
Based on a patch by @Richard2ndQuadrant.
9 years ago
Abhijit Menon-Sen 9133cd409c Make _parse take an array of input lines as an argument
(There's no compelling reason to do this right now, but should be parser
need to be called multiple times in future, this makes it easier.)
9 years ago
Abhijit Menon-Sen 98a1905796 Rename 'section' to 'groupname' to better reflect its purpose 9 years ago
Abhijit Menon-Sen 1284c49bd7 Rewrite the INI InventoryParser
The new code parses INI-format inventory files in a single pass using a
well-documented state machine that reports precise errors and eliminates
the duplications and inconsistencies and outright errors in the earlier
three-phase parsing code (e.g. three ways to skip comments). It is also
much easier now to follow what decisions are being taken on the basis of
the parsed data. The comments point out various potential improvements,
particularly in the area of consistent IPv6 handling.

On the ornate marble tombstone of the old code, the following
inscription is one last baffling memento from a bygone age:

-    def _before_comment(self, msg):
-        ''' what's the part of a string before a comment? '''
-        msg = msg.replace("\#","**NOT_A_COMMENT**")
-        msg = msg.split("#")[0]
-        msg = msg.replace("**NOT_A_COMMENT**","#")
-        return msg
9 years ago
Jon Hawkesworth a46b500851 Add win_splitdrive filter for windows users 9 years ago
Toshio Kuratomi 4f32a61504 Merge pull request #10957 from feanil/feanil/retain_nonetypes
Don't convert nulls to strings.
9 years ago
Brian Coca e8b86f448d fix issue with improper connection override in delegation 9 years ago
Feanil Patel 892e230514 Don't convert nulls to strings.
This change is similar to https://github.com/ansible/ansible/pull/10465

It extends the logic there to also support none types.  Right now if you have
a '!!null' in yaml, and that var gets passed around, it will get converted to
a string.

eg. defaults/main.yml
```
ENABLE_AWESOME_FEATURE: !!null # Yaml Null
OTHER_CONFIG:
  secret1: "so_secret"
  secret2: "even_more_secret"

CONFIG:
  hostname: "some_hostname"
  features:
    awesame_feature: "{{ ENABLE_AWESOME_FEATURE}}"
  secrets: "{{ OTHER_CONFIG }}"
```

If you output `CONFIG` to json or yaml, the feature flag would get represented in the output
as a string instead of as a null, but secrets would get represented as a dictionary.  This is
a mis-match in behaviour where some "types" are retained and others are not.  This change
should fix the issue.

I also updated the template test to test for this and made the changes to v2.

Added a changelog entry specifically for the change from empty string to null as the default.

Made the null representation configurable.

It still defaults to the python NoneType but can be overriden to be an emptystring by updating
the DEFAULT_NULL_REPRESENTATION config.
9 years ago
Brian Coca 22a69e2498 fixes to delegation code 9 years ago
Brian Coca 36cbd771a4 changed fixme to deprecated 9 years ago
Brian Coca 961bee00d5 centralized the definition of 'localhost' 9 years ago
Rene Moser d16429b59c cloudstack: rename returns for consistency 9 years ago
Abhijit Menon-Sen 2641f70e47 Reset self._groups_cache in refresh_inventory 9 years ago
Harald Laabs 73d6da757f Make get_group run in O(n*log(n)) instead of O(n^2) by using a cache 9 years ago
Brian Coca 1b810e3101 Merge pull request #12000 from bcoca/local_action_connect
changed local_action to alias to connection=local vs delegate_to=locahost
9 years ago
Will West b8865314ec improve ansible start up time for very large inventory
first off, we add an oddly slow basic test of 10k item inventory

Before:
```
Ran 229 tests in 13.214s

OK

real    0m13.403s
user    0m12.106s
sys 0m1.155s
```

After:
```
Ran 230 tests in 21.328s

OK

real    0m21.516s
user    0m20.099s
sys 0m1.275s
```

since that seems like a bit long for the test to add to runtime, lets profile

`python -m cProfile -s time ./bin/ansible all -i test/units/inventory_test_data/huge_range --list-hosts`

Before:
```
         1272607 function calls (1259689 primitive calls) in 8.497 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    4.393    0.000    4.396    0.000 __init__.py:395(_get_host)
    20000    2.695    0.000    2.697    0.000 __init__.py:341(__append_host_to_results)
    40369    0.113    0.000    0.113    0.000 {posix.lstat}
    50006    0.102    0.000    0.153    0.000 __init__.py:1490(combine_vars)
    40008    0.089    0.000    0.202    0.000 __init__.py:1546(_load_vars_from_path)
    20195    0.088    0.000    0.088    0.000 {posix.stat}
    10011    0.087    0.000    0.087    0.000 {posix.getcwd}
```

The top two lines are promising optimization targets

- populate Inventory's host cache more in _get_host, as we are looping
  over all the groups anyways.

- eliminate duplicate check of whether we've already included a host
  in the construction around __append_host_to_results we can infer
  presence of a host in the results list implies the presence of its
  name in the hostnames set, allowing us to only to the less expensive
  of the two checks

After:
```
         1252610 function calls (1239692 primitive calls) in 1.320 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    40369    0.105    0.000    0.105    0.000 {posix.lstat}
    50006    0.094    0.000    0.141    0.000 __init__.py:1490(combine_vars)
    40008    0.081    0.000    0.184    0.000 __init__.py:1546(_load_vars_from_path)
    10011    0.080    0.000    0.080    0.000 {posix.getcwd}
    20195    0.074    0.000    0.074    0.000 {posix.stat}
    10002    0.069    0.000    0.261    0.000 __init__.py:1517(load_vars)
```
9 years ago
Brian Coca 7a4a156d91 changed local_action to alias to connection=local vs delegate_to=localhost
fixes #11998, but still leaves issue of delegate_to: localhost not working
9 years ago
Brian Coca f2c6785897 Merge pull request #11989 from bcoca/osx_queue_fix
changed check to avoid OS X broken sem_getvalue()
9 years ago
Brian Coca 26ed50ecdf fixed indent 9 years ago
Brian Coca 2198f48f54 changed check to avoid OS X broken sem_getvalue()
fixes #11988
9 years ago
Brian Coca e081a73aa1 make new inventory config take precedence over old hostfile config
fixes #11907
9 years ago
Brian Coca 17b4b1f85c added ability to limit in ansilbe pull
refactored the options a bit, new inventory_opts made sense to always group
fixes #7917
9 years ago
Brian Coca 1acb29ff9b sequence will now run once for start=end, added test to suite
fixes #11979
9 years ago
Brian Coca ee21ebaffc Merge pull request #11975 from mutemule/become_doas
Add become support for OpenBSD doas
9 years ago
Damian Gerow 1c5611100e Add become support for OpenBSD doas 9 years ago
Alphadelta14 77b60a1a67 Support any Mapping for with_dict lookup.
This resolves 3939348286 breaking `with_dict: hostvars`.
9 years ago
Brian Coca c419cacb04 check if host task is none before continuing
fixes #11982
9 years ago
James Cammarata e7b2308b66 Performance improvements
* Speed up serialization of hostvars by simply using the internal
  dictionary used for cached lookups
* Use blocking gets/puts on queues instead of spin locking
* Merge sequential implicitly created blocks
9 years ago
Brian Coca 4068598c15 Merge pull request #11977 from resmo/for-ansible
cloudstack: add more common returns
9 years ago
Rene Moser 2913d2b44d cloudstack: add more common returns 9 years ago
Brian Coca 6058eaa92f removed unused poller 9 years ago
Brian Coca 9b61cf5840 implemented async tasks in adhoc v2 9 years ago
Brian Coca ee2e31b37a now passes the test of skipping list when dict attribute is undefined, added deprecation warning as this seems like bad behaviour 9 years ago
Brian Coca 950622cebd made sure they all look in files/vars/template dirs also when executed in play and not only from task 9 years ago
Brian Coca 861fdfc5ba updated callbacks to properly test diff no matter if dict or list 9 years ago
Brian Coca 79ea6d3a1e copy now passes a list of diffs 9 years ago
Brian Coca c3372936aa diff can now be a list 9 years ago
Brian Coca 13c91ef9d4 actually use the read source contents for the diff 9 years ago
Brian Coca 45cebd283f added remote_src to copy, now allows copying to be done on the target server 9 years ago
Brian Coca 1b7369cc8d added diff to assemble for remote_src=false 9 years ago
Brian Coca f048aca5f6 runas placeholder 9 years ago
Brian Coca 49eb95e2d1 some fixes to become/sudo
* now it uses -n to get immediate error if no password is supplied and one is needed,
   this should fix the issue with sudo hanging waiting for input.
 * made -k configurable, this can break changing become_users in play if left out,
   but opens up the possiblity of OTP support.
9 years ago
James Cammarata 4836641683 Use ansible_python_interpreter value for remote checksums
Fixes #11968
Fixes #11969
9 years ago
Brian Coca 7a51836530 check for failure in fact gathering 9 years ago
Brian Coca 1edae51e05 added generic service module, step #1 to separating services to their own modules
falls back to current service module and requries service mgr facts and new service modules
9 years ago
Brian Coca 172e0c328c fixed adhoc fact gathering 9 years ago
Brian Coca 0381923333 fixed call to setup module 9 years ago
Brian Coca 92e2f54228 fixed issues with utf-8 encoding in docs, moved pager to use display class instad of bare prints 9 years ago
Brian Coca 245e0dd4b7 made returns from next task consistent to avoid typeerrors, also linear now checks for none
fixes #11965
9 years ago
Brian Coca 9f5e4c0ef6 lookup plugin that does no flattening 9 years ago
Abhijit Menon-Sen 8f231ec469 Tweak deprecation warning, and apply it to --limit also 9 years ago
James Cammarata 4714cbeec8 Override post validation of environment to allow bare variables
Also prints a deprecated warning if a bare variable is detected, so
that we can remove this in a future version.

Fixes #11912
9 years ago
James Cammarata 4dba30ccd0 Cleanup missed merge conflict sections 9 years ago
Abhijit Menon-Sen d41db8edd6 Don't accept undocumented "p1;p2" patterns; note in changelog
The correct (and now only) way to say p1 OR p2 is "p1:p2".
9 years ago
Abhijit Menon-Sen 1437b8e120 Introduce _split_pattern to parse an "x:y:z" pattern
This function takes a string like 'foo:bar[1:2]:baz[x:y]-quux' and
returns a list of patterns ['foo', 'bar[1:2]', 'baz[x:y]-quux'], i.e.
splits the string on colons that are not part of a range specification.
9 years ago
James Cammarata 32034feec5 Add deprecation warning regarding host patterns 9 years ago
Abhijit Menon-Sen 6bf6b9fdbb Rename some internal functions, clarify what they do
get_hosts → used externally, not changed
_get_hosts → _evaluate_patterns (takes a list, evaluates ! and &)
__get_hosts → _match_one_pattern (takes one pattern only, ignores !&)
9 years ago
Abhijit Menon-Sen eff33bac49 Don't accept undocumented "p1;p2" patterns; note in changelog
The correct (and now only) way to say p1 OR p2 is "p1:p2".
9 years ago
Abhijit Menon-Sen 8aaa06dd50 Introduce _split_pattern to parse an "x:y:z" pattern
This function takes a string like 'foo:bar[1:2]:baz[x:y]-quux' and
returns a list of patterns ['foo', 'bar[1:2]', 'baz[x:y]-quux'], i.e.
splits the string on colons that are not part of a range specification.
9 years ago
Abhijit Menon-Sen baf637b9ae Remove dead code: Inventory.also_restrict_to/lift_also_restriction
This was used earlier to implement serial, but that's now done using
restrict_to_hosts() (whose docstring is also suitably adjusted here)
and there are no more callers.
9 years ago
James Cammarata 6c036c3633 Template parent include file paths
Fixes #11955
9 years ago
Brian Coca b905f51341 fixed typo 9 years ago
Brian Coca 8af0ff4a58 Merge pull request #11567 from lekum/shelvefile_lookup
Add shelvefile lookup plugin
9 years ago
Brian Coca fbc7224066 Merge pull request #11643 from bcoca/meta_inventory_and_fixes
Meta inventory and fixes
9 years ago
James Cammarata eb381bd522 Add one more search path to path_dwim_relative 9 years ago
Brian Coca c6733cc1a7 Merge pull request #9225 from qvicksilver/aix_unprivileged
AIX unprivileged facts collection
9 years ago
Brian Coca 5027f66562 Merge pull request #11864 from jhawkesworth/win_path_filters
add win_basename and win_dirname filters
9 years ago
James Cammarata a498876bec Make sure playbook includes use unique var dictionaries before modification 9 years ago
Brian Coca 5fec11f513 capture parsing exceptions and give nice error and location 9 years ago
Brian Coca 621b18c6ef fixed source path discovery for unarchive in roles
fixes #11943
9 years ago
Brian Coca 70d024ffce show errors when missing vars file or when there is syntax issue in the file
fixes #11945
9 years ago
Brian Coca 3d9875773b Merge pull request #11947 from resmo/for-ansible
cloudstack: refactor get_result()
9 years ago
Brian Coca 2c34a5bdbd pass list correctly to lookup 9 years ago
James Cammarata dd67b1e4d6 Adjust relative include searches when roles are involved
Fixes #11895
9 years ago
Rene Moser 4f3c863b42 cloudstack: refactor get_result()
* A commen dict of keys has been defined, which we look in results returned from the API.
* self.returns dict can be use in subclass to extend this dict.
* Optionally the key name can be replaced with a new key name, often used to make the return keys identical to the arguments passed.
* Use new style class
9 years ago
James Cammarata d9833f227f Make sure cached data from file loads isn't impacted by modifications
Fixes #11893
9 years ago
Brian Coca 6bceee9a93 now lvs/vg facts are only attempted if binary found 9 years ago
James Cammarata c7dde72aa0 Default listify to converting bare variables again
Since we explicitly set convert_bare=False in the template lookup
code, but still want individual looks that call listify directly to
convert bare variables if needed.
9 years ago
James Cammarata ac66e4001c Fix for variable precedence with tasks/includes
Fixes #11881
9 years ago
Brian Coca 2688edb32b Merge pull request #11940 from alxgu/fix_lvm_facts
bugfix: missing path for lvm facts
9 years ago
Brian Coca 39f81a8fa5 removed unused imports 9 years ago
Brian Coca c27978fa93 minor fixes to pull 9 years ago
Brian Coca 9f29e39dea give more matching options for ansible-pull 9 years ago
Brian Coca e46b1e8d2b adjusted tree to work more like v1, also now skips when dir not supplied 9 years ago
Alexander Gubin 1ea1b9fb13 bugfix: missing path for lvm facts 9 years ago
Brian Coca 49d88cef9c meta: refresh_inventory and several inventory fixes 9 years ago
Brian Coca 8e30e3791e Merge pull request #11811 from amenonsen/fixme-range
FIXME in host range parsing
9 years ago
Brian Coca ae9d264b86 Merge pull request #11762 from amenonsen/9795-rebase
Add LVM facts to setup module
9 years ago
James Cammarata 829a88b906 Disable undefined error failures during conditional templating
This allows us to properly catch the 'is defined' and 'is undefined'
checks and return the correct boolean result.

Fixes #11892
9 years ago
James Cammarata e0b074000e Merge pull request #11764 from lpirl/devel_v2
fixes remote code execution for su/sudo with strict remote umasks
9 years ago
James Cammarata 38eb53de1d Fix bug in vars using correct temp value for vars
Fixes #11877
9 years ago
Brian Coca 4d853a5d3c implemented for v2, missing --tree option for adhoc 9 years ago
Brian Coca 79a1bca010 avoid circular import 9 years ago
Brian Coca a83b8220ef added import back 9 years ago
Brian Coca 6e825e8c22 fixed listify for lookups, made sure convert_bare is only on with_ 9 years ago
James Cammarata adb9d7e461 Track role execution per-host, not overall in the role
Fixes #11863
Fixes #11878
9 years ago
Rene Moser e62fbf5fba cloudstack: add get_result() in utils to return common results 9 years ago
James Cammarata f904acbd14 Fixing bug related to listify changes 9 years ago
James Cammarata 169d316704 Fixing bugs in include + loops
Fixes #11872
9 years ago
Brian Coca 7666bde666 updated hashi_vault to new listify, added to changelog 9 years ago
Brian Coca 4399ddc7da Merge pull request #11674 from defionscode/hashi_vault_lookup
Hashicorp Vault lookup Plugin
9 years ago
Jonathan Davila 175068fdae Hashicorp Vault lookup Plugin 9 years ago
Brian Coca 7e7b546c34 reinstated listify 9 years ago
Brian Coca 3e5dbd045f fixed ref to removed var 9 years ago
Brian Coca 5c1d850fbb now fixed to actually work 9 years ago
Brian Coca ee365c881f fixed typo 9 years ago
Brian Coca c08305a31f set script command itself to be sudable and not use the chmod sudoable settings as it can
ignore sudo settings for script when become_user is not root
fixes #11902
9 years ago
Toshio Kuratomi d35b956900 listify lookup plugin terms when they're specified as "{{ lookup(terms) }}"
Before this, they were not listified there but they were listified when
specified like this:

with_lookup: terms
9 years ago
Brian Coca dbab703265 fine tuned password handling as we were getting false positives, probably caused by other changes up the stack that now call these functions in more cases. 9 years ago
Brian Coca 6fcfebd21d made sure we need becoem before we format the command, added debug entry also 9 years ago
Brian Coca df768e0db4 fixed debug statement 9 years ago
Brian Coca 177499476b fixed warning 9 years ago
Toshio Kuratomi 3ef49844db Update core submodule ref 9 years ago
Brian Coca 8f106c9a58 Merge pull request #11078 from Yannig/devel
New lookup plugin : ini
9 years ago
Yannig Perré 07fcb50b9b Porting ini lookup plugin against ansible v2. 9 years ago
Toshio Kuratomi f1144752c4 Pull in docs fix from core modules 9 years ago
James Cammarata e7d0c9f820 Re-add vars to Base and standardize var processing
Fixes #11779
9 years ago
Brian Coca dbe7a9fe2f Merge pull request #11857 from quinot/bug/playbook-init-comment
Minor comment fix
9 years ago
Brian Coca 3c57018a10 Merge pull request #11778 from Ensighten/add_credstash_plugin
add credstash lookup plugin
9 years ago
Brian Coca d47d0b1d7f now continue/abort mode allows ignoring other input 9 years ago
Brian Coca a555a0652e allow for vars_prompt and pause prompt to be skipped in non interactive settings
ansible-pull users rejoice
9 years ago
Toshio Kuratomi ce52fdebe8 Pull in get_url checksum change 9 years ago
Brian Coca 29cd72b7d8 even simpler condition tree for pause 9 years ago
Brian Coca dc80bc8929 now pause behaves like v1 pause 9 years ago
Brian Coca f7707d8850 brought user_input back to pause 9 years ago
Toshio Kuratomi 00b1a2c865 Restore ValueError in md5 method and change finding the available hash algorithms so we only have to do it once 9 years ago
Brian Coca 15a20e814b added tags back to ansible-pull 9 years ago
Brian Coca 5f0359c119 keep banners at 79 9 years ago
Brian Coca 25e67bb716 text wrap now adapts to terminal 9 years ago
Toshio Kuratomi 80cb69214b Merge pull request #11840 from muffl0n/module_utils_hash_algorithms
Add get_available_hash_algorithms()
9 years ago
James Cammarata d44daf53cc Allow wrapped text in deprecated messages 9 years ago
James Cammarata 5eb092b331 Handle top-level vars for include tasks to match v1 syntax
The "streamlined" syntax will be deprecated at some point in the future.

Fixes #11882
9 years ago
Toshio Kuratomi e16b24c01e Update submodule ref 9 years ago
Toshio Kuratomi e8452c864e Restore the relative path handling portion of #11865 9 years ago
James Cammarata 26d5a17b59 Make sure inventory loads files with non-relative paths
This is a slightly different fix than we originally committed, but fixes
the problem in a less invasive way (and I believe it's generally better
that we don't deal with relative paths internally past this point)

Fixes #11789
9 years ago
Brian Coca b9433650d1 Revert "Path of group_vars and host_vars were getting the basedir added twice."
in view of simpler solution incomming from james
This reverts commit bae7a02be5.
9 years ago
Brian Coca 9f156e5550 updated submodule refs 9 years ago
Brian Coca 7bea04141b Merge pull request #11865 from ansible/fix-group_vars_path
Path of group_vars and host_vars were getting the basedir added twice.
9 years ago
Brian Coca 08e6c1d82b avoid possible errors with new broadcast handling in linux 9 years ago
Brian Coca cb2cfaebda started porting chroot to v2 9 years ago
Brian Coca 262c75c253 Merge pull request #10971 from mightydok/debbraoadcastfix
Add missed broadcast address to linux network facts.
9 years ago
Scott Cunningham 87ef53c962 credstash lookup plugin: python 2.6-compatible string.format() 9 years ago
Scott Cunningham c4629b72e0 credstash lookup plugin: error out in run function when credstash not installed, not at module scope 9 years ago
Toshio Kuratomi bae7a02be5 Path of group_vars and host_vars were getting the basedir added twice.
Fix inventory so this won't happen and fix DataLoader so that it will
test relative paths relative to self._basedir

Fixes #11789
9 years ago
Toshio Kuratomi e7b5cb8782 Fix synchronize source path with roles and local connection
Fixes #8261
9 years ago
Toshio Kuratomi dd7fa07038 Update submodule refs so synchronize plugin works 9 years ago
Toshio Kuratomi 308bf80055 Cleanups to synchronize including:
* Better comments
* Reorganize code so related settings are close to each other
* Add ::1 to the "localhost" patterns we look for
* Make the dest_port parameter override the ansible_ssh_port setting
* Fix dest_port (wasn't being set)
* more complete detection of delegate_to
* Fix set_remote_user (wasn't being looked for in parameters)
* Instead of removing mode here, have the ansible module accept it
  (better documents the parameters doing it htat way)
9 years ago
James Cammarata 37e38924de Allow field attributes to have priorities
So that roles are loaded ahead of all other play fields, meaning any
plugins contained within the roles are loaded first before tasks.

Fixes #11858
9 years ago
Jon Hawkesworth f69da544f7 add win_basename and win_dirname filters 9 years ago
James Cammarata fad44862a5 Implementing includes in the free strategy 9 years ago
Brian Coca 2b9b3a08a1 make sure you only update pci data if there is a match 9 years ago
Yannig Perré 09d257e637 Porting ini lookup plugin against ansible v2. 9 years ago
Thomas Quinot 5d3cb636ad Minor comment fix 9 years ago
Yannig Perré 47db352725 Merge remote-tracking branch 'ansible/devel' into devel 9 years ago
Yannig Perré 733d40a77c When value does not exist, return default value instead of stopping ansible with an exception. 9 years ago
James Cammarata faf4c3bb6c Merge pull request #11816 from amenonsen/ssh-ipv6
Fix ssh connections to IPv6 addresses
9 years ago
James Cammarata dbd755e0f4 Fix jinja2 template search pathing
Fixes #9933
9 years ago
Scott Cunningham 934ce86d35 update credstash lookup plugin to use Python 2.4-compatible exception catching 9 years ago
James Cammarata 61e76fd707 Allow conditionals on PlaybookInclude statements
Fixes #11852
9 years ago
James Cammarata b6c3e5d797 Validate variable names given in set_fact
Fixes #11851
9 years ago
James Cammarata 5266679964 Use templar all the way down
Fixes bugs related to creating Templar() objects on the fly, where
the shared loader objects (serialized to TaskExecutor) aren't used
so information loaded into plugin loaders after forking is lost.

Fixes #11815
9 years ago
muffl0n 8d6d711a5c move get_available_hash_algorithms() from get_url 9 years ago
James Cammarata c3ce140dd2 Exclude loop_args from post_validation for tasks
This field is templated specially during the TaskExecutor's loop
calculation, so there's no need to post validate it again.

Fixes #11481
9 years ago
Brian Coca 015b922c1f fix quoting for become commands
fixes #11808
9 years ago
Toshio Kuratomi ca941ec632 style cleanup because -ECANNOTUNDERSTAND without it 9 years ago
Toshio Kuratomi f86245dcb0 Add a warning about python3 in the synchronize plugin 9 years ago
Toshio Kuratomi f0431eaea9 Make ansible_python_interpreter work with synchronize
Fixes #11836
9 years ago
James Cammarata 8279557e8f Allow role names to be templated
Fixes #10858
9 years ago
James Cammarata ed603f7030 Fix free strategy only running first play in a multi-play playbook
Fixes #11839
9 years ago
James Cammarata c2435fab7e Inject the play context vars into the variables used for loop item templating 9 years ago
James Cammarata bcbcfc79be Fix relative paths for included files
Also modifies the Play class to not include become* fields in the
post-validation step.

Fixes #11353
9 years ago
James Cammarata 2673eb0afb Add option to fail on undefined variables to listify
And use it in the call to get the loop items for a task.
9 years ago
James Cammarata a586c74967 Merge pull request #11838 from cchurch/stringify_powershell_unquote_value
Fix for PowerShell unquote method when passed None.
9 years ago
James Cammarata f6d1b5e233 Merge pull request #11835 from cchurch/raw_is_not_raw_enough
Raw is not raw enough
9 years ago
James Cammarata 7b9aee7077 Merge pull request #11832 from amenonsen/zeroforks
Disallow --forks 0
9 years ago
Chris Church cafc35fd5b Fix for PowerShell unquote method when passed None. 9 years ago
Abhijit Menon-Sen 7d9689c1c5 Slice ascii_letters directly instead of using 'for x in range()' 9 years ago
Abhijit Menon-Sen bfe708a189 Make host range parsing errors issue better messages
Now we always say "host range must …specific thing…"
9 years ago
Abhijit Menon-Sen 1413496292 Implement step for alphabetic ranges: [a:e:2] => a,c,e 9 years ago
Abhijit Menon-Sen 72715c6add Fix ssh connections to IPv6 addresses
We can unconditionally wrap remote_addr in square brackets for scp and
sftp (both of which require them for IPv6 addresses), but not wrap them
at all for ssh (which doesn't accept them). This way, we don't have to
detect and treat IPv6 addresses specially. This works for hostnames,
IPv4 addresses, and IPv6 addresses.

The earlier code seemed to intend to wrap all IPv6 addresses in square
brackets, which would have broken ssh, but it actually made no attempt
to detect IPv6 addresses at all (so it broke only with IPv6 addresses
for scp and sftp).

Based on a review of PR #11677 by @JuiceBoxSingularity
9 years ago
Chris Church 6969b5ac8b Make sure raw doesn't eat key=value arguments. 9 years ago
Abhijit Menon-Sen 861da614cc Make 'pause: prompt=…' print the prompt
In stable-1.9, the prompt string is passed to raw_input(), which prints
it without an extra \n. Here we're just print()ing it, so the \n would
be doubled.
9 years ago
James Cammarata 9936c5f9f6 Fixing the pause module for devel 9 years ago
Abhijit Menon-Sen 8de70fa657 Disallow --forks 0
Without at least one worker process, things break:

Traceback (most recent call last):
  File "/home/ams/extern/ansible/ansible/lib/ansible/executor/process/result.py", line 103, in run
    result = self._read_worker_result()
  File "/home/ams/extern/ansible/ansible/lib/ansible/executor/process/result.py", line 69, in _read_worker_result
    (worker_prc, main_q, rslt_q) = self._workers[self._cur_worker]
IndexError: list index out of range
9 years ago
Toshio Kuratomi cf35bdbdf9 Merge pull request #11827 from amenonsen/trivial-fixmes
Remove TODO: the play already overrides options
9 years ago
Abhijit Menon-Sen a9b020d6de Remove TODO: the play already overrides options 9 years ago
Abhijit Menon-Sen 1f2adb5e14 Show a better message when ansible.cfg is not found
Earlier we would say «Using  as config file» if we didn't find one.
9 years ago
Abhijit Menon-Sen 2cb7cd8379 Remove outdated FIXME; _compute_delegate is called below 9 years ago
Abhijit Menon-Sen 7b3cb2126c Remove outdated FIXME; ROLE_CACHE is already implemented below 9 years ago
Toshio Kuratomi 91a77b8603 Fix potential bug in parameter passing 9 years ago
James Cammarata 13b8a57d3d Undo previous travis/tox fixes and fix underlying issue 9 years ago
Toshio Kuratomi 0d72be3953 become protection for local connections no longer needed 9 years ago