Commit Graph

4946 Commits (9e1bc434c768dab26468220de4bc57490f5666cd)

Author SHA1 Message Date
James Cammarata 9e1bc434c7 Further cleanup from locking changes 9 years ago
James Cammarata b93f27e260 Move the lockfile back to tqm to make sure it stays unique 9 years ago
James Cammarata b9afbf0ee4 Reorganizing the way the connection lockfile is created 9 years ago
James Cammarata 7034bbef30 Merge branch 'connection-locking' of https://github.com/amenonsen/ansible into amenonsen-connection-locking 9 years ago
Abhijit Menon-Sen 9378c8e2da Make the paramiko plugin use locking 9 years ago
Abhijit Menon-Sen 5887e96b27 Introduce a connection locking infrastructure
The lock file is (a temporary file) opened in the parent process, whose
open fd is inherited by the workers after fork, and passed down through
the PlayContext. Connection grows lock/unlock methods which can be used
by individual connection plugins.
9 years ago
Abhijit Menon-Sen 12d8f9132e Make lock_host_keys a real noop, instead of half-a-noop
Right now, we don't do any locking, but we still scan known_hosts files
twice per connection. That's completely unnecessary, and the proposed
solutions to the locking problem wouldn't need known_hosts scanning
anyway, so this code can go away.
9 years ago
Brian Coca a006e85947 removed printing module args as it violates no_log settings 9 years ago
Toshio Kuratomi 1998eddf8d Keep newlines by default now.
In v1, a trailing newline was kept if the parameter was passed as key=value.  If
the parameter was passed as yaml dict the trailing newline was
discarded.  Since key-value and yaml dict were unified in v2 we have to
make a choice as to which behaviour we want.  Decided that keeping trailing
newlines by default made the most sense.

Fixes #12200
Fixes #12199
9 years ago
Toshio Kuratomi 41da8de094 Speedup for counting newlines 9 years ago
James Cammarata 843138e7d9 Merge pull request #12202 from mgedmin/py3k
Use rich comparisons for Attribute and FieldAttribute
9 years ago
James Cammarata 5434ed973b Make sure locals in safe_eval is a plain dict when running eval
Fixes #12206
9 years ago
Toshio Kuratomi 417bf1c805 Unittest the _count_trailing_newlines function 9 years ago
Toshio Kuratomi 7ed746ad45 Fix preserve_trailing_newlines (broken by 7f5080f64a )
Fix for one half of hte bug reported in #12198
9 years ago
Brian Coca a7231c2203 actually implemented flags correctly for all priv escalation methods 9 years ago
Brian Coca b9642585bd added missing become_exe from config 9 years ago
Brian Coca e156d9b677 fixed and generalized privilege escalation exe settings 9 years ago
Marius Gedminas 33a374edde Use rich comparisons for Attribute and FieldAttribute
Because __cmp__ is not supported on Python 3.
9 years ago
Marius Gedminas ca908f2e12 Fix indentation to be a multiple of 4 9 years ago
Abhijit Menon-Sen 147b04b682 Remove duplicated function definition (fallout from earlier repeated merge) 9 years ago
James Cammarata f162990cb3 Properly assign the searchpath for templates to the environment loader
dbd755e0 previously assigned the value to self._templar.environment.searchpath,
which is incorrect - it needs to be assigned to the environment.loader.searchpath
value instead.

Fixes #11931
9 years ago
James Cammarata 2761df232e Small tweak to 7551b75 to correct the ordering of tests 9 years ago
James Cammarata 7551b75e61 Add ispath type for constants and make sure all local paths are ispath=True
Fixes #12180
9 years ago
Toshio Kuratomi aeff960d02 Cleanup combine_vars
* Dedupe combine_vars() code (removed from VariableManager)
* Fix merge_hash algorithm to preserve the type
* unittest combine_vars and merge_hash
9 years ago
James Cammarata 7fe495d619 Merge pull request #12187 from caphrim007/add-utf-8-encoding-to-f5-module-utils
Adds utf-8 encoding to f5 module_utils
9 years ago
James Cammarata d00c445d2c Merge pull request #12188 from amenonsen/easy-debug
Show module name and args with -vvv
9 years ago
Abhijit Menon-Sen d6d523bcae Show module name and args with -vvv
This information was earlier shown only with ANSIBLE_DEBUG, but it's
extremely useful in a user context, especially with module invocations
with deeply nested args like the ec2_vpc/ec2 modules.

Closes #11680
9 years ago
James Cammarata 3e1a774ba5 Don't use iteritems() in templar to avoid (hostvars) dict size change errors 9 years ago
James Cammarata 974b69d236 looped includes need unique references to prevent information bleeding
Fixes #12155
9 years ago
James Cammarata a341a8a093 Make sure tasks from a role see their defaults above all others
Fixes #12081
9 years ago
Tim Rupp 6f41a72158 Adds utf-8 encoding to f5 module_utils
The contributor's name on line 10 (originally line 7) includes a character
that the default Python encoding (ASCII) raises an error on when interpreting
the file.

Specifying the utf-8 encoding, as is done in other modules, resolves
the error.

The error being raised is

SyntaxError: Non-ASCII character '\xc3' in file /.../lib/ansible/module_utils/f5.py
on line 7, but no encoding declared; see http://www.python.org/peps/pep-0263.html
for details
9 years ago
James Cammarata a7da25d48b Submodule update 9 years ago
James Cammarata 3d282cd1b0 Also always post_validate Handler class as well
Fixes #12154
9 years ago
Toshio Kuratomi 12edbfeb0b Merge pull request #12177 from mgedmin/py3k
Make combine_vars() compatible with Python 3
9 years ago
Brian Coca 66e2eb2231 removed as it does not fool setup.py to include data and it must be specified in setup.py 9 years ago
Marius Gedminas 54dbfba8f8 Make combine_vars() compatible with Python 3
Fixes

  TypeError: unsupported operand type(s) for +: 'dict_items' and 'dict_items'

on Python 3.
9 years ago
James Cammarata 5adcd7054b Allow setup to run when using --start-at-task
Fixes #12147
9 years ago
Brian Coca 7458331539 package and service now check that module exists before trying to execute it 9 years ago
Toshio Kuratomi 9d193d8fb4 Merge pull request #12173 from ansible/pr/10204
Rebase of 10204 - Add host key for ssh url only.
9 years ago
James Cammarata fca27c29f4 Properly fail if slurp fails during fetch 9 years ago
Desmond O. Chang 58c3539196 Add host key for ssh url only.
Rewrite function `get_fqdn`.  It returns fqdn for all kinds of urls now.

`add_git_host_key` determines whether a url is ssh and whether its host
key should be added.
9 years ago
James Cammarata 66a2f2923e Look for proper values in slurp result during fetch with become enabled 9 years ago
Toshio Kuratomi 7f5080f64a Fix backslash escaping inside of jinja2 expressions
Fixes #11891
9 years ago
Toshio Kuratomi 5ae300a084 Update module refs 9 years ago
Brian Coca 6b73cac35a corrected skipped_hosts constant usage, thanks @benjixx 9 years ago
Brian Coca 5a65dce6fb fix issues with csh redirection 9 years ago
Brian Coca b525eedb8e less misleading message for when someone looks up vars for a host not in inventory 9 years ago
Brian Coca 6154ed1dda Merge pull request #12146 from thekarlbrown/patch-1
Fixed Spelling Error on Line 67
9 years ago
James Cammarata f0257683b0 Fixed missing constants import in default callback
Fixes #12145
9 years ago
James Cammarata 057712c129 Also move action/connection plugins to shared plugin loader code
Fixes #12099
9 years ago