Commit Graph

3444 Commits (5f8d63dd5788e0efa77192775c188ff46359b646)

Author SHA1 Message Date
James Cammarata d4ff0d125a Make sure password files from lookups are created with restrictive permissions
Also adds checks for the lookup integration test for passwords.

Fixes #8652
10 years ago
James Cammarata 3a7aca6066 Fix no_log value for content in common file args settings
Also adds a test to ensure the content value is not logged.

Related to #8647
10 years ago
James Cammarata 8a5675ca9f Fixing no_log for the playbook level use
Fixes #8647
10 years ago
Serge van Ginderachter 0ab721d51e better logic for all-group variables for implicit localhost 10 years ago
Serge van Ginderachter 3c06833302 group_by: make sure new group has bigger priority than all group 10 years ago
Serge van Ginderachter a2cfe8770b Inventory: fix logic mistake in loading/retrieving variables for groups 10 years ago
James Cammarata ca6db40cb4 When serializing inventory, pop from the start of the hosts list
Fixes #8646
10 years ago
James Cammarata c8494cdc39 Set prompt encoding to a sane value when sys.stdout.encoding is None
Fixes #8644
10 years ago
James Cammarata 379e31883c Fix check mode issues with copy module
Fixes #8639
10 years ago
James Cammarata 542f07128e Correct check for role library/ existence
Fixes #8633
10 years ago
James Cammarata e3895840d1 Make sure group_vars/all is loaded for ungrouped hosts
Fixes #6563
10 years ago
Lukas Wunner 677de07f44 Try optimistic chown, do not error out if not permitted to chown
Add unit test
10 years ago
James Cammarata 8dafacd4e9 Make env param a dict type instead of list
Also modifies param type checking code to remove whitespace from
around params before splitting them into k=v pairs.

Fixes #8199
10 years ago
Michael DeHaan 3035f2dcc8 Merge pull request #8367 from msabramo/make_pip_install_editable_work
Make `pip install -e` work
10 years ago
James Cammarata 54cbe3dcf9 Disallow args: to be specified as a string 10 years ago
James Cammarata 600a4657b4 Catch error in atomic_move when creating temporary file
Fixes #8480
10 years ago
James Cammarata ee18c557ec Load group_vars for new groups loaded via add_host
Fixes #8605
10 years ago
James Cammarata b4476c238f Use match() instead of search() for pattern matching
Also related to f48fa3, fix for #8614
10 years ago
James Cammarata f48fa3759a Fix host pattern matching and enhance error detection
Fixes #8614
10 years ago
James Cammarata a01d97f12b Fixing variable name bug introduced in ac8950f
Fixes #8617
10 years ago
James Cammarata bea0845322 Fix vault_password positional args error 10 years ago
Lukas Wunner f4053fcf3a Only chown on atomic move if invoked as root
Linux and BSD derivatives do not allow unprivileged users to
"give away" files to others for security reasons. (System V
derivatives allow that but they're rare nowadays.)
10 years ago
Cristian Ciupitu b6261d05b0 Fix typo: & -> and
`and` is the boolean operator for AND in [Python][1].
`&` is the bitwise operator for AND in [Python][2].

[1]: https://docs.python.org/2/reference/expressions.html#boolean-operations
[2]: https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations
10 years ago
Michael DeHaan 99c39b1ff3 By popular request, make the no_log attribute also censor tasks from callbacks. 10 years ago
James Cammarata fc7859f445 Make sure playbook_dir variable is an absolute path
Fixes #8317
10 years ago
James Cammarata 4940a7ad77 Merge pull request #8458 from Jmainguy/runner_8404
Fixes 8362, returns stderr if No space left on device
10 years ago
James Cammarata ac8950fd36 Set special vars in play.vars rather than load_vars
Also refactors playbook loading code relating to vars in playbooks
to a sub-function.

Fixes #8534
10 years ago
Jakub Paweł Głazik 99a339fa7b Fix comments and error message 10 years ago
Jakub Paweł Głazik 58feee0f45 ansible-vault view - new command 10 years ago
James Cammarata 783a1e3dfc Fixing broken patch 20957a1
Also adds integration tests for nested includes with conditionals
10 years ago
Michael DeHaan 02b0e102e6 Rename some INI keys for fact caching defaults 10 years ago
James Cammarata 20957a1b85 Remove duplicate compiling of task when: statements
Fixes #8538
10 years ago
James Cammarata 83fa9a8cde Make sure we only use unquote on quoted lines in lineinfile when needed 10 years ago
Michael DeHaan 542aaa6ffe Use JSON instead of pickles for compatibility. 10 years ago
Michael DeHaan 2629cd3fce Fix some copyrights, fix a misc test. 10 years ago
Michael DeHaan 533fb21586 Add copyright header, let me know if corrections are needed. 10 years ago
Michael DeHaan bdee1ff24e Standardize exception handling 10 years ago
Josh Drake a620ef414e Implement connection pooling for memcached cache plugin. 10 years ago
Josh Drake 3031247492 Use cPickle in redis fact caching backend. 10 years ago
Josh Drake 917e868f65 Implement fact cache flushing alongside a command-line argument to invoke it. 10 years ago
Josh Drake aa419044c4 WIP on the re-implementation of fact caching and various backends. 10 years ago
Michael DeHaan fb5a1403dd Merge 10 years ago
Michael DeHaan 56f9328f93 Merge 10 years ago
James Cammarata 25e9d1197e Merge branch 'optimise_utils_clean_data' of https://github.com/leth/ansible into leth-optimise_utils_clean_data 10 years ago
James Cammarata a650421e39 Catch task parameter splitting errors nicely
Fixes #8481
10 years ago
James Cammarata 9f34ea54f5 Correct parser to ignore escaped quotes when not in quotes already
Related to #8481
10 years ago
Marcus Cobden c47d1f5265 Pre-load whole string and use seek to alter tags 10 years ago
Marcus Cobden c8bfd157f8 Switch cStringIO to StringIO for unicode support
The performance difference isn't too bad
10 years ago
Marcus Cobden 84114e5c0b Fix copy/paste error 10 years ago
Marcus Cobden ef65d3dbf6 Optimise string handling in ansible.utils._clean_data 10 years ago
Michael DeHaan e01d5f9d84 Revert "Added cross-platform uptime fact" since causing failures on Ubuntu.
This reverts commit 14a9966984.

Conflicts:

	lib/ansible/module_utils/facts.py
10 years ago
Michael DeHaan ea53576759 Merge pull request #6777 from GuiGui2/devel
Setup module: Additional facts when using ansible with Linux on System z
10 years ago
Michael DeHaan 5d05049ee1 Merge pull request #7670 from dagwieers/patch-3
Added cross-platform uptime fact
10 years ago
Michael DeHaan c56ce4c913 Merge pull request #8334 from veeti/cfg-vars
Expand variables in configuration files, take two
10 years ago
Michael DeHaan a48328fa12 Merge pull request #7725 from slapers/network-secondaries-issue
fix incorrect secondary ip handling, fixes #7724
10 years ago
hoettle 4243ce61b3 Correct placement of right parenthesis.
(serial_pct)/100.0 is a typo - the parentheses should be around the entire percentage calculation, which makes much more sense when multiplying by the number of hosts (luckily BODMAS prevailed).
10 years ago
Howard Oettle cbf0bd6baf playbook: permit the serial attribute to be a pecentage string as well as well as a straight integer 10 years ago
James Cammarata 63bf2f6d9a Preserve all line breaks in literal blocks
Fixes #8512
10 years ago
Michael DeHaan d0205b2878 Merge pull request #8500 from sivel/rax-de-dupe
rax: Move additional shared code into module utils
10 years ago
Michael DeHaan 03d150de35 Merge pull request #8020 from msabramo/error_when_private_key_file_permissions_incorrect
Error if private_key_file is group/world readable
10 years ago
Michael DeHaan 8c4161d4a1 Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
Conflicts:
	lib/ansible/inventory/vars_plugins/group_vars.py
	plugins/callbacks/mail.py
10 years ago
Michael Peters 3ba516ac25 adding min() and max() filters for use in Jinja templates 10 years ago
Michael DeHaan 48a0236ec6 Merge pull request #6619 from sergevanginderachter/ansible_version_var
Introduce an ansible_version dict as runner variable
10 years ago
Michael DeHaan 66eddfd491 Merge branch 'nova-compute-enhancements' of git://github.com/emonty/ansible into devel
Conflicts:
	lib/ansible/module_utils/openstack.py
	library/cloud/nova_compute
10 years ago
Michael DeHaan b413a7d7f3 Merge pull request #8449 from emonty/feature/openstack-auth-handling
Handle auth arguments across openstack modules consistently
10 years ago
Michael DeHaan 2f7d405fd9 Merge pull request #8510 from sergevanginderachter/inventorydir_yacc
InventoryDir: fixing yet another corner case
10 years ago
Serge van Ginderachter 7c96f1d803 InventoryDir: fixing yet another corner case 10 years ago
James Cammarata d4cedfc7f1 Fix missing variable initialization for async jid
Fixes #8491
10 years ago
Michael DeHaan fc40e6be81 Merge pull request #8488 from bekimb/docstring_basic_module
Keep docstring up to date with the code in basic module
10 years ago
James Cammarata e19ed3424d Make sure default vars are used in template calls for tasks
Fixes #8499
10 years ago
James Cammarata 4a157a72a0 Catch auth errors in winrm and properly raise errors
Fixes #7875
10 years ago
Bekim Berisha 5272e1099d Keep docstring up to date with the code in basic module 10 years ago
Matt Martz 7d0eba19ab Dedupe PTR record related code in rax_dns_record 10 years ago
Matt Martz 88acb48753 Add ANSIBLE_VERSION to module_utils/basic.py and manipulate the pyrax user-agent 10 years ago
Matt Martz 585fd5a138 Move additional rackspace common code into module_utils/rax.py 10 years ago
James Cammarata ba4693051b Removing leftover import of atomic_move 10 years ago
James Cammarata efbad90ef8 Revert "Atomically move known hosts file into place when edited by paramiko connections"
This reverts commit bd49a835b4.
10 years ago
James Cammarata a45c3b84f3 Avoid templating raw lookup strings 10 years ago
James Cammarata d134b8a83c Version bump for 1.8 10 years ago
Alexander Lozovskoy 5165dfa2df Issue with printing unicode non-english characters #8425 patch 10 years ago
Michael DeHaan 1c6398dd3b Resolve option conflict differently. 10 years ago
Michael DeHaan b4b115cd13 File common arguments should not be used in all docs pages. 10 years ago
Michael DeHaan 4312391e0a (A) Fix a bug in the doc generator that was clobbering the force parameter for the copy module.
(B) This is a work in progress but the idea is to have text snippets where we can respond to tickets with a bit more helpful info.
Not active just yet.
10 years ago
James Cammarata dc69510bff Merge branch 'callback_template_delegate' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-callback_template_delegate 10 years ago
James Cammarata eeec459f8a Merge branch 'sets_v2' of https://github.com/bcoca/ansible into bcoca-sets_v2 10 years ago
Jonathan Mainguy 535ebc4c56 Fixes 8362, returns stderr if No space left on device 10 years ago
Serge van Ginderachter 8f39c114d8 template Runner.module_vars['delegate_to'] to accommodate callbacks 10 years ago
Monty Taylor 4012272fa2 Add common auth handling across openstack modules
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
10 years ago
James Cammarata 5d0bb33ede Make run_command process communication smarter
The run_command module function will now poll stdout/stderr for
data rather than using the builtin command communicate(), which can
hang under certain circumstances.

Fixes #7452
Fixes #7748
Fixes #8163
10 years ago
James Cammarata 74cbeb1292 Default interface type to ipv4 when checking flags for Solaris
Fixes #8330
10 years ago
James Cammarata bd49a835b4 Atomically move known hosts file into place when edited by paramiko connections
Fixes #8169
10 years ago
Michael DeHaan 7ff63ab754 Revert "Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C"
This reverts commit 642b183fb6.
10 years ago
James Cammarata af0d8cda7b Fix literal block multiline parsing
Fixes #8394
10 years ago
James Cammarata 6d94ae64ec Remove unnecessary unicode conversions from parse_kv
Fixes #8425
10 years ago
Michael DeHaan 642b183fb6 Use atomic move function on known host file in paramiko to prevent rare occurance of Control-C
during file operations.
10 years ago
Michael DeHaan a7d2e729f8 Add some whitespace to make paramiko_ssh more browseable 10 years ago
Michael DeHaan 24f6f656cc Merge branch 'bug8392' of git://github.com/gnosek/ansible into devel 10 years ago
Monty Taylor a05804bf8d Update the nova inventory plugin with new ip code
The provisioning module knows more about how nova deals with IP
addresses now. Ensure that the inventory module is similarly as smart
by separating out the logic into the openstack/module_utils.
10 years ago
Monty Taylor d17a1b5c19 Add common auth handling across openstack modules
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
10 years ago
Luke Sneeringer a4fce4818e Add support for environment variables in GCE module. 10 years ago
Grzegorz Nosek 7f33580eba Fix exponential regex performance issue
filter_leading_non_json_lines effectively does

re.match(".*\w+=\w+.*", line)

for every line of output. This has abysmal performance in case of large
Base64-encoded data (which ultimately does not match the regex but does
match the .*\w+= part) as returned e.g. by the template module (diffs).

Replacing the match with

re.search("\w=\w", line)

drops the complexity back to linear, and actually usable with large
diffs from the template module (a 150 KB Base64 diff kept Ansible
spinning at 100% cpu for minutes).

Also, check the easy cases (line.startswith) first while we're here.

Closes: #8932
10 years ago
James Cammarata 9c1a89ff4e Merge branch 'patch-1' of https://github.com/debfx/ansible into debfx-patch-1 10 years ago
Marc Abramowitz 44b9f5e752 Make `pip install -e` work
This allows `pip install -e` and `python setup.py develop` to work
without having to do the stuff in
http://docs.ansible.com/intro_installation.html#running-from-source so
it's a tad nicer for Python programmers who are accustomed to installing
packages as editable/in development mode.

Fixes GH-8355 (https://github.com/ansible/ansible/issues/8355)
10 years ago
James Cammarata 7a5076c8b8 Catching shlex splitting error in fact gathering get_cmdline call
Fixes #8352
10 years ago
James Cammarata 80df2135e9 Fix parsing of tasks with variable module names
Also adding an integration test for same.
10 years ago
James Cammarata 189824dd76 Remove whitespace around args
Fixes #8343
10 years ago
James Cammarata e6fa50a306 Move splitter to module_utils so modules can use it and fix command arg splitting
Fixes #8338
10 years ago
Veeti Paananen 5780f3a8b4 Expand variables in configuration files, take two
e.g. $HOME.
10 years ago
Veeti Paananen e6bd049892 Don't expand remote_tmp path locally 10 years ago
James Cammarata a9f0f8e975 Revert "template.py: Handle purposely raised exceptions in lookup()"
This reverts commit 2fda9bc743.
10 years ago
James Cammarata aee940aaca Reworking _clean_data() to be smarter about replaces
Fixes #8228
10 years ago
James Cammarata 6e814566de Unquote params passed to an include statement
Fixes #8315
10 years ago
Michael DeHaan 106f4ccc01 Revert "Expand variables in configuration files" - I feel I've been here before.
Breaks some test runs.

This reverts commit a9eef029b6.
10 years ago
Michael DeHaan 97fa9502aa Merge pull request #8309 from veeti/cfg-vars
Expand variables in configuration files
10 years ago
Michael DeHaan 645ab7baff Merge pull request #7950 from mesk41in/devel
Fix unsupported regexp parameter in assemble
10 years ago
Michael DeHaan fb60e767a7 Taking alternate approach.
Revert "Fix hostname when get_distribution_version() returns a string."

This reverts commit 08f97c0b9d.
10 years ago
Michael DeHaan 628d828876 Merge pull request #8087 from neersighted/string_version
Fix hostname when get_distribution_version() returns a string.
10 years ago
Michael DeHaan 30e6a659ae Merge pull request #8171 from jbenden/osx-10.10
Support for OS X 10.10 DP3.
10 years ago
Michael DeHaan 20f65f2c79 Merge pull request #8262 from icoloma/patch-1
Bugfix: bulletproof unexpected_error_msg at gce.py
10 years ago
Veeti Paananen a9eef029b6 Expand variables in configuration files
e.g. $HOME. Fixes #6373.
10 years ago
Nacho Coloma 979824eedc Moved import to the top 10 years ago
James Cammarata 6eac47e519 Use split_args instead of shlex.split for included params
Fixes #8296
10 years ago
James Cammarata 7344baeffa Make sure empty non-quoted tokens are not added to the arg params list 10 years ago
James Cammarata 3714c0742f Split args on single spaces only 10 years ago
James Cammarata 57f89b85eb Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
fix an issue that copying directory will fail when trying to change file attributes
10 years ago
James Cammarata 63bcbd0af2 Fix for unicode decoding error in new splitting code
Also adds a new unicode integration test
10 years ago
James Cammarata 10a850c70f Merge branch 'new_arg_splitting' into devel 10 years ago
Michael DeHaan 8d42f5cbfa Smush ds removal 10 years ago
James Cammarata b8a4ba26f0 Refactoring split_args into sub-functions 10 years ago
Michael DeHaan 630f080cf0 Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far). 10 years ago
Michael DeHaan b5d64fdb36 Some notes/comment upgrades on split_args. 10 years ago
James Cammarata 43154e5101 Using custom splitting function for module param counting 10 years ago
Michael DeHaan e143d7dab7 Merge pull request #7543 from yangliping/fix_local_facts_file_checking_portability
Fix portability issue when checking local facts file permission.
10 years ago
Michael DeHaan 635bea645c Merge pull request #7992 from dehylton/devel
fix swap translation on 4.x openbsd with 2.5.4 python
10 years ago
James Cammarata b21875d5a9 Make sure 'item' variable is set when using first_available_file
Fixes #8220
10 years ago
someda 1b1d5d0d3d fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
- the issue was introduced by the commit 84759faa09
10 years ago
James Cammarata 2cc602beea Fixes for module param counting and additional shell quoting issues 10 years ago
Benno Joy ac85d8444b fix for unarchive 8257 10 years ago
Nacho Coloma 57428c48a2 Bugfix: bulletproof unexpected_error_msg at gce.py
This method was still failing for me with a "missing http_code" message. After applying this change, the error message is:

```
msg: Unexpected response: {'value': 'PyCrypto library required for Service Account Authentication.'}
```

I wanted to contribute a rock-solid `unexpected_error_msg` implementation.
10 years ago
James Cammarata 84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
10 years ago
James Cammarata 00e089e503 Revert "Explicitly set the user option for ssh connections"
This reverts commit 0f91add86f.

Fixes #8216
10 years ago
Joseph Benden da5e32b316 Needs additional divisor. 11 years ago
Michael DeHaan 0fad9575e9 Refine error message about invalid ops since people forget to indent tasks fairly often. 11 years ago
James Cammarata 0e5b0a2e97 Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
This reverts commit 7a8eb0b670.
11 years ago
Joseph Benden b55791ef43 Support for OS X 10.10 DP3. 11 years ago
James Cammarata 62e9cf63b7 Merge pull request #8170 from sergevanginderachter/issue_8159
Load existing group_vars file for new group_by group
11 years ago
Serge van Ginderachter 4e9a253bef Load existing group_vars file for new group_by group
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.

fixes #8159
11 years ago
James Cammarata 42b5294820 Merge branch 'devel' of https://github.com/leverich/ansible into leverich-devel 11 years ago
Felix Geyer 0ebd19e97b Fix regression: Sanitize sudo success_key from stdout
Commit 7e3dd10 caused a regression with sanitizing the sudo success_key from stdout.
There is no newline in front of SUDO-SUCCESS when using sudo.
This change adapts the regex to make the line break optional.

Tested on Ubuntu 14.04.
11 years ago
Ruggero Marchei 909955f2e2 fix get_distribution_version() on amazon linux 11 years ago
Jacob Leverich 7a8eb0b670 Set Jinja2's keep_trailing_newline=True in template_from_string.
Without this setting, the newline idempotence of scalar strings changes depending on whether
or not they contain any Jinja2 template blocks.
11 years ago
James Cammarata e74853300a Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass 11 years ago
James Cammarata cdb9f13559 Merge pull request #7605 from sivel/delegate-callback-hint
Show delegate_to hint in callback output
11 years ago
James Cammarata 4fc8d4b6fe Merge pull request #7649 from sivel/vault-password-script
Allow --vault-password-file to work with a script as well as a flat file
11 years ago
Serge van Ginderachter e8b45a9ef7 Invalidate host/group variables cache when loading
extra varsiables based on playbook basedir.
11 years ago
Serge van Ginderachter d39ff55688 Fix logic bug when loading vars for a new playbook basedir. 11 years ago
James Cammarata db96344966 Re-fixing ability to have empty json files after inventory refactoring 11 years ago
James Cammarata 4e5eb7559e Merge branch 'svg_and_inventory_refactor' into devel 11 years ago
Bjorn Neergaard 08f97c0b9d Fix hostname when get_distribution_version() returns a string.
The distro version is a string ('jessie/sid') on Debian unstable and testing.
Because load_platform_subclass() evaluations every subclass as it loops,
comparing numbers when get_distribution_version() does not return a number will
break.

This patch fixes that by returning a number (`0`) when we have an invalid
version, instead of returning `None` or a string.
11 years ago
Dan Slimmon 307a3e8a9c Fixed regex square-bracket bug.
Regexes were being parsed like ordinary ansible host patterns, so
square-bracket groups were getting interpolated wrongly.
11 years ago
James Cammarata b8ac094eaa Tweak to only show msg on assert failure if set 11 years ago
James Cammarata 16332b8488 Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg 11 years ago
James Cammarata aa261bdd14 Optimizing groups_for_host() lookup in inventory 11 years ago
James Cammarata fe892fccb1 Merge remote-tracking branch 'svg/varsplugins_refactor' into svg_and_inventory_refactor 11 years ago
James Cammarata 11a5fc85f4 Merge branch 'inventory_refactoring' into svg_and_inventory_refactor 11 years ago
James Cammarata bcf83cbc24 Merge branch 'sergevanginderachter-inventorytree' into svg_and_inventory_refactor 11 years ago
Serge van Ginderachter ff4119adc0 Performance optimization in resolving host patterns
Avoid resolving a pattern that is a plain host. When matching a hostname in the
hosts_cache, just use the host object from there.

When running a task on say 750 hosts, this yields a huge improvement.
11 years ago
Matt Martz 6591dd560d Show delegate_to hint in callbacks 11 years ago
Leonid Evdokimov d94395f48c assert: add optional `msg` argument
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
  register: output
- assert:
    msg: '{{ output.json | to_nice_json }}'
    that:
      - output.json.foo != "bar"
      - output.json.boo == 42
```
11 years ago
James Cammarata 7f8de3a265 Merge pull request #8024 from kcghost/7941
removed port from domain name qualification, fixes #7941
11 years ago
James Cammarata ff04b2b532 Allow empty yaml vars files
Fixes #7843
11 years ago
Michael DeHaan 51e014d915 Merge pull request #8012 from cchurch/callback_cleanup
Callback plugin cleanup
11 years ago
Michael DeHaan c2ac8fda1e Data from inventory scripts should be able to use nested Jinja2 expressions. 11 years ago
Henry Finucane de64bbdc5f Support a whitelisted subset of jinja2 template options 11 years ago
Casey Fitzpatrick 7115cb1f37 removed port from domain name qualification, fixes 7941 11 years ago
Marc Abramowitz 5b783e0bc6 Error if private_key_file is group/world readable
Currently, if you have this, ansible fails with a generic error and
suggests running again with `-vvvv`. This isn't bad but pinpointing the
specific problem immediately is even more user-friendly.

```
$ ls -l devops.pem
-rw-r--r--+ 1 marca  staff  1679 Jul  2 11:25 devops.pem

$ ansible -m ping --private-key=devops.pem mt3-pyweb01
mt3-pyweb01 | FAILED => private_key_file (devops.pem) is group-readable or world-readable and thus insecure - you will probably get an SSH failure
```
11 years ago
James Cammarata 81f35323e9 Revert "Fix get_distribution() for platforms that may have spaces"
This reverts commit 2493020d9f.
11 years ago
Chris Church 955dadf743 Remove runner_on_error callback that is never used. 11 years ago
Chris Church 4e98e3785a Reset play attribute on callback plugins when a play fails. 11 years ago
Chris Church 30fae95efe Change variable from pattern to name to correctly indicate what is being passed to the callback. 11 years ago
James Cammarata 8ed6350e65 When parsing json from untrusted sources, remove templating tags 11 years ago
James Cammarata eeb597360e Further safe_eval fixes 11 years ago
dewey hylton 379e1a49cb fix swap translation on 4.x openbsd with 2.5.4 python 11 years ago
Michael Scherer f0a7139290 Fix exec_command prototype for the plugin 11 years ago
mesk41in 488aec3936 Fix unsupported regexp parameter in assemble 11 years ago
James Cammarata 539426f612 Performance tuning inventory functions for large inventories 11 years ago
James Cammarata 35368e531b Additional fixes for safe_eval 11 years ago
James Cammarata 5429b85b9f Change safe_eval to a strict white list 11 years ago
James Cammarata d8a7b49b59 Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree 11 years ago
Matt Martz 19f5ce2c9c Allow --vault-password-file to work with a script as well as a flat file 11 years ago
James Cammarata 1adb6dfa05 Remove redundant 'self.user or' added by 0f91add 11 years ago
Thomas Mangin 0f91add86f Explicitly set the user option for ssh connections
Fixes #7170
11 years ago
Paul Sokolovsky f8bf9cdeec Handle TemplateNotFound to render more helpful error message.
At the point the exception is handled, it is likely due to error loading
a sub-template included from main template. Besides file not found, it
can be caused also by include path failing Jinja2 checks. Now, when
rendering the exception from Jinja, it will include exception name. This
will give basic context or *what* the error is.

Fixes #7103
Fixes #7105
11 years ago
James Cammarata 5d65c1c4a4 Merge branch 'Mbosco-patch-1' into devel 11 years ago
James Cammarata 6bd0621037 Merge branch 'devel' of https://github.com/ansible/ansible into devel 11 years ago
James Cammarata 1702c2fd50 Merge branch 'patch-1' of https://github.com/Mbosco/ansible into Mbosco-patch-1 11 years ago
James Cammarata 9564818e1e Merge branch 'fix_lineinfile_newlines' into devel 11 years ago
James Cammarata 59c5d6292b Merge pull request #7902 from jirutka/filter-relpath
Add os relpath filter
11 years ago
James Cammarata ce41b02300 Merge pull request #7887 from s0x/funtoo-gathering-facts
Check for empty os-release file, fixes #7885
11 years ago
Jakub Jirutka 726a61eb43 Add os relpath filter 11 years ago
Chris Church 6aaad5dc9b Fix missing arg for _remote_chmod method. 11 years ago
Ivo Senner f4fd9d366b Check for empty os-release file, fixes #7885 11 years ago
Chris Hoffman cf997beb07 Shell expand DEFAULT_ROLES_PATH fixes #4897 11 years ago
James Cammarata 94963290b9 Merge pull request #6981 from aliles/fix-localhost-executable-with-flags
Fix localhost tasks with complex executables
11 years ago
James Cammarata 3c3c710a58 Merge branch 'module_safe_eval' into fix_lineinfile_newlines 11 years ago
James Cammarata d8bb116c1a Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 11 years ago
Michael DeHaan 5156794738 Merge pull request #7861 from cchurch/devel
Windows Remote Support
11 years ago
Chris Church 615f70e3f4 Fix missing space in script action plugin. 11 years ago
Chris Church dd3f7c2dab Fix trailing slash on returned temp path. 11 years ago
Chris Church 8a121fd6ae Squeeze a few more bytes out of put_file script. 11 years ago
Chris Church 4e738e6fa9 Optimize buffer size for put_file. 11 years ago
Matt Martz 09dd535296 Make helper functions more robust against undefined powershell objects 11 years ago
Chris Church 43a7a5a990 Collapse extra whitespace in encoded powershell scripts. 11 years ago
Matt Martz df8866b8bd Add examples for how to use powershell common functions 11 years ago
Matt Martz e4e610565c Add convenience function (Get-Attr) for getting an attribute/member from a powershell psobject 11 years ago
Matt Martz 90c98ada7c Add ConvertTo-Bool filter function in powershell common code 11 years ago
Chris Church 61c236be9e Fix for creating temp dir with older powershell versions. 11 years ago
Chris Church 243cd877ae Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules. 11 years ago
Chris Church a8ca579761 Fix host parameter to vvvvv. 11 years ago
Matt Martz 97f4f56286 Add Exit-Json and Fail-Json powershell helper functions 11 years ago
Chris Church 74c43c94cf Allow specifying remote powershell version via environment variable. 11 years ago
Chris Church 8f762a7d15 Update logging based on verbosity, add vvvvv support to show details of put/fetch file. 11 years ago
Chris Church 21ba529fbe Fixes/notes related to slashes in remote paths. 11 years ago
Chris Church 7e8cc65829 Refactor common args used for building PowerShell commands. 11 years ago
Matt Martz e7e95721b9 powershell modules will have a .ps1 extension 11 years ago
Matt Martz a25c441300 Add shared functions to module_utils/powershell.ps1 and refactor powershell modules to utilize the common powershell code 11 years ago
Michael DeHaan bafa63b424 Revise documentation on powershell module replacer code. 11 years ago
Chris Church f7af29680b Add default license boilerplate, refactor common powershell code, fixes for raw/script modules. 11 years ago
Michael DeHaan 35a7c93c76 Added comment about implementation line. 11 years ago
Michael DeHaan 3ac86e57f4 FIXME comment cleanup 11 years ago
Michael DeHaan 80499346d1 Remove stray FIXME 11 years ago
Chris Church 5dcaa30476 Add shell_plugins to abstract shell-specific functions out of runner, add winrm connection plugin, add initial Windows modules. 11 years ago
James Cammarata 360d8b0fc2 Don't try to scan SSH signatures for non-ssh urls
Fixes #7812
11 years ago
James Cammarata 2493020d9f Fix get_distribution() for platforms that may have spaces
The new CentOS 7 beta lists the distribution as "CentOS Linux", which
breaks the distribution detection and class loading. This patch fixes
that by taking just the first entry in the string when a space is
detected.
11 years ago
James Cammarata 3529b1cb33 Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763 11 years ago
Michael DeHaan 627ff30a6f Add module replacer capability for powershell files. 11 years ago
Ruggero Marchei e3f5af377f move get_distribution_version() to basic.py 11 years ago
James Cammarata cb13b30362 Use file documentation fragement for the copy module 11 years ago
James Cammarata 9b17e8a555 Merge pull request #7771 from jkramarz/issue-5761
Added missing fallback to hw_sector_size
11 years ago
James Cammarata 6d9cc64e0f Add role_names to valid keys entry for plays
Prevents a "not a legal parameter" error for play ds structures that
may be passed into the Play() constructor, which really is mainly a
concern during tests.
11 years ago
Matt Bray 578e881142 fix for urls like ssh://git@github.com/ansible/ansible.git 11 years ago
Jakub Kramarz df3188cef0 Added missing fallback from physical_block_size to hw_sector_size in sectorsize fact discovery for kernels older than May 2009.
References #5761
11 years ago
James Cammarata 3fb3e7e6dc Properly parse urls for ssh-keyscan use
Previously, the get_fqdn() function in known_hosts.py only worked
with urls that started with git@, and ignored any urls that started
with a normal schema type (ie. http:// or ssh://). This patch corrects
that by using urlparse to parse the hostname portion out of urls that
have a proper schema.

Fixes #7474
11 years ago
James Cammarata 395192ffbc Merge pull request #7740 from jkramarz/issue-5761
changed sector size fact source
11 years ago
James Cammarata b4d130d086 Add a new password pattern to the run_command filter 11 years ago
Jakub Kramarz 4e4c9235e8 changed sector size fact source from hw_sector_size to physical_block_size, fixes issue 5761 11 years ago
Stefan Lapers 78f4842982 fix incorrect secondary ip handling, fixes #7724 11 years ago
Eri Bastos a65fd06338 Added quotes around key path - Issue 7713 11 years ago
James Cammarata e5ef0eca03 Merge pull request #6507 from brdo/patch-1
Set keepalive to 5 seconds in paramiko_ssh.py
11 years ago
smoothify e3530dcbc2 Add environmentfilter to random filter, to ensure the result doesn't get cached. Mirrors default jinja filter. 11 years ago
Dag Wieers fd6f0cb4b4 Update facts.py 11 years ago
Dag Wieers 14a9966984 Added cross-platform uptime fact
Having an uptime fact allows you to check after a reboot whether the system was effectively rebooted.

```yaml
  - name: Safeguard - Was system properly rebooted ?
    action: fail msg="System was not properly rebooted"
    when: ansible_uptime > 900
```

This patch has been tested on Linux, Solaris and HP-UX.
11 years ago
James Cammarata ad97c618cf Add support for relative paths in the file lookup plugin for roles
Fixes #7628
11 years ago
James Cammarata 82a784931e Fix error passing play vars to an included playbook with empty vars
Fixes #7658
11 years ago
James Cammarata d9df607972 Fix order of merging variables for the combined cache
Fixes #7598
11 years ago
James Cammarata 74f20ebf79 Removing cruft leftover from the deprecation of include+with_items
Also cleaning up integration tests that had checks for the empty item
attribute in certain results.

Fixes #7535
11 years ago
James Cammarata 0fa5100a2c Merge branch 'fix-7596' of https://github.com/kilburn/ansible into kilburn-fix-7596 11 years ago
James Cammarata 849b0f87ce Fix error when using os.getlogin() without a tty 11 years ago
Brian Coca ce8c8ab146 now unique actually works, all operations also now use it to return
unique lists.
11 years ago
Michael DeHaan 959af67fe3 Merge pull request #7608 from jjneely/lookup-function
template.py: Handle purposely raised exceptions in lookup()
11 years ago
James Cammarata b94bde9711 Merge pull request #7609 from jimi-c/issue_7553_su_copy
Support checking for su user to atomic_move
11 years ago
Jack Neely 2fda9bc743 template.py: Handle purposely raised exceptions in lookup()
If a lookup plugin is run by the lookup() template method it should pass
along any AnsibleError (or child exception classes) rather than just eat
them.  These exceptions are purposely raised by the plugin.
11 years ago
Marc Pujol d0f82e94e8 Ensure there are no duplicates in the merged/intersected lists 11 years ago
Marc Pujol f892cc798c Merge and intersect lists without using sets.
Using sets for these operations is dangerous because sets cannot contain
certain object types (such as lists) and their iteration order is
undefined.

Fixes #7596
11 years ago
James Cammarata 188ab7b952 Check groupnames for None as well as an empty string in add_host
Fixes #7585
11 years ago
James Cammarata feafc4cd8a Merge branch 'fix_mutable_inventory_vars' of https://github.com/banterchat/ansible into banterchat-fix_mutable_inventory_vars 11 years ago
Isao Jonas 72524e1f3b dont mutate inventory vars 11 years ago
James Cammarata 061911c9c2 Merge pull request #7558 from dermute/pkg_mgr
added solaris fact detection for ansible_pkg_mgr
11 years ago
James Cammarata e99df21647 Support checking for su user to atomic_move
Fixes #7553
11 years ago
James Cammarata fa86eef9f9 Make sure value in regex_replace is a string
Fixes #7551
11 years ago
James Cammarata ca734fde8b Merge pull request #7544 from rik2803/patch-2
Differentiate machinfo output key/val separator
11 years ago
James Cammarata cfd8c685d1 Correct issue of handlers running on all hosts incorrectly
Also adds an integration test to catch this bug in the future.

Fixes #7559
11 years ago
Alexander Winkler 4980e76a3a added solaris fact detection for ansible_pkg_mgr 11 years ago
Brian Coca 8f58ae3305 changed exception handling for hashable test 11 years ago
rik2803 cfcbc954f5 Differentiate machinfo output key/val separator
get_hw_facts for HP-UX: machinfo in HP-UX B.11.23 uses '=' as separator between key and value, while B.11.31 uses ':'.
11 years ago
Yang Liping aedf134fc4 Fix portability issue when checking local facts file permission. 11 years ago
James Cammarata 92f16b3d6f Merge pull request #7539 from jimi-c/issue_7503_freebsd_su_fixes
Fixes for su on freebsd
11 years ago
Brian Coca 0dce5dae26 set theory v2, now can handle non hashable items like dicts 11 years ago
James Cammarata e0c4c51c1f Merge pull request #7517 from amenonsen/double-error
Don't double (or triple) up common error messages
11 years ago
James Cammarata d77a6965b3 Merge module_vars into inject during template instead of updating
This way we won't overwrite values that are stored in the inject
with module_vars that should be lower precedence.

Fixes #7510
11 years ago
Abhijit Menon-Sen f6792b724a Don't double (or triple) up common error messages
process_common_errors() was called thrice, each time appending to the
existing error message, and leading to confusing repetition in the
message that was finally displayed.

Fixes #7498
11 years ago
James Cammarata 1e672a0fec Fixes for su on freebsd
Addresses multiple issues when using su on freebsd including
* su prompt differs between platforms, so turned that check into a
  regex comparison instead of a simple string comparison
* not using '-c' after su causes problems, so added that for all
  platforms
* fixed quoting issues due to multiple uses of '-c' introduced by
  the above fix

Fixes #7503
Fixes #7507
11 years ago
James Cammarata 32628eef85 Merge pull request #7481 from jimi-c/issue_7396_env_lookup
Don't use listify_ function, when all we want to do is template variable...
11 years ago
WAKAYAMA shirou 56880b76bb fix UnicodeEncode error when using pause module with unicode prompt. 11 years ago
WAKAYAMA shirou 346bb611c7 fix UnicodeEncodeError when prompt is unicode. 11 years ago
James Cammarata e36a8d466e Don't re-query inventory when trimming failed/dark hosts
Since the filter list contains hosts, passing that back to list_hosts()
in the inventoy causes issues when the hostname is an IPv6 address
(with :'s interpreted as group unions). Since we already have the list
of hosts, we should not need to pass that back through inventory a
second time.

Fixes #7446
11 years ago
James Cammarata 365bfd732e Don't use listify_ function, when all we want to do is template variables
This was causing a bug in the env module, due to the fact that we now
pass variables for the module through the templating engine combined
with the fact that we split-up the hostvars and setup variables. As a
result, if a variable in the env lookup had the same name as the variable
in Ansible, it would try and template itself over and over again until
the recursion limit would be hit, at which time an empty string was
returned.

Fixes #7396
11 years ago
James Cammarata 0ac74aaf59 Also set the environment variables when resetting the locale to C 11 years ago
James Cammarata 1f0be3753d Merge pull request #7412 from bellkev/fix_skip_dir_inventory_extensions
Fix skip dir inventory extensions
11 years ago
James Cammarata d44ed533b3 Default use_proxy to True for fetch_url()
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.

Fixes #7322
11 years ago
James Cammarata 08406c0ee2 Adding the capability to proxy the ssl cert check
The ssl cert check will now respect the http and https proxy
environment settings. The url may also have the username/password
embedded, in which case basic auth will be used to connect to the
proxy server.

Fixes #7413
11 years ago
Matt Martz 0e953c2863 Add run_once task key
This caused the task to act like  bypass host loop plugin and
execute only on a single host. Can be used with delegate_to
11 years ago
James Cammarata 285d9878ae Reset locale to 'C' if the specified one is invalid
Fixes #7448
11 years ago
Kevin Bell 92bd755b47 Fixed extension filtering in InventoryDirectory 11 years ago
James Cammarata df877f2e79 Check module_path permissions when creating ssh_wrapper for git
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.

Fixes #7375
11 years ago
Michael DeHaan 3b8a35d65e Merge pull request #7406 from specnazzz/fix-python24
Fix known_hosts.py to work on older versions of python
11 years ago
James Cammarata 79731ce491 Evaluate changed_when only if task is not skipped
Fixes #7405
11 years ago
Michal Mach 60451c20ab Fix known_hosts.py to work on older versions of python 11 years ago
James Cammarata 7faecd54b0 Merge pull request #7388 from jimi-c/issue_7384_vars_files_include
Pass vars_files on to included playbooks too
11 years ago
James Cammarata a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 11 years ago
James Cammarata 56515a38d5 Only chown on atomic move if the uid/gid don't match the src/tmp file
This is a corner case for remote file systems that don't support
chown() and where the source and destination for the atomic_move
are on that remote file system.

Fixes #7372
11 years ago
James Cammarata 525e7339ed Merge branch 'pass-basedir-to-runner-on-setup' of https://github.com/ByteInternet/ansible into ByteInternet-pass-basedir-to-runner-on-setup 11 years ago
James Cammarata 85bd6810bb Pass vars_files on to included playbooks too
Fixes #7384
11 years ago
Allard Hoeve c5833f9869 Add missing basedir to Runner in _do_setup_step 11 years ago
James Cammarata 360ffc4dfd Properly merge role conditionals in with pre-existing conditionals
Fixes #7387
11 years ago
James Cammarata 187619c7fe Use utils.combine_vars on vars_files data
Fixes #7345
11 years ago
James Cammarata 809b931640 Merge pull request #7382 from jimi-c/issue_7366_synchronize_inventory_dir
Do not base synchronize source on the inventory directory
11 years ago
Marco Re 712f4a631c Update ssh.py
Convert to string to fix runtime error due to string concat in self.common_args += ["-o", "User="+self.user] when ansible_ssh_user is numeric
11 years ago
Chris Church d725636469 Correctly initialize combined_cache for hosts if setup is skipped
Fixes #7364
11 years ago
James Cammarata 38c2c60849 Do not base synchronize source on the inventory directory
Fixes #7366
11 years ago
James Cammarata fd27afdc0d Adding ansible_shell_type and basic environment construction on it
Previously we assumed the shell on the target systems were 'sh'-
compliant when formatting environment variables preceding command
strings. This patch corrects that by basing the target shell type
on the DEFAULT_EXECUTABLE setting, which can be overridden on a
per-host basis using the inventory variable 'ansible_shell_type'.

Fixes #7352
11 years ago
James Cammarata 9b9b4d50fe Merge pull request #7058 from jkleckner/fix-vars_prompt-when-default-False
Fix #7057 missing False default for vars_prompt
11 years ago
James Cammarata 51ef28b0d2 Merge branch 'warn_wrong_sudo_password' of https://github.com/tyll/ansible into tyll-warn_wrong_sudo_password 11 years ago
James Cammarata 2e2e5d5321 Use the existing module_vars during the templating of module_vars
Since some of the vars contained in there may be used in the templating
of other variables. This also reverts e83a494 which originally fixed
issue #6979 but broke some other variable related things.

Fixes #6979
Fixes #7321
Fixes #7332
11 years ago
James Cammarata 77a47dbb2d Merge pull request #7304 from jimi-c/issue_7296_synchronize_relative_path
Make sure dwim'd relative path ends in a "/" if the original does
11 years ago
James Cammarata 393124e462 Add pyc/pyo to ignore list for inventory directories
Fixes #7308
11 years ago
Brian Coca 8a84b22d76 bumped to 1.7 11 years ago
Chris Church f9c74d6e57 Add integration tests for group_by module. Fixed bug introduced by ansible/ansible#7273 while also fixing issue described in ansible/ansible#6953 11 years ago
James Cammarata 4d118d1c72 Make sure dwim'd relative path ends in a "/" if the original does
Fixes #7296
11 years ago
James Cammarata 56d070afa8 Version bump for 1.7 11 years ago
James Cammarata fd03cc04e6 Merge branch 'devel' of https://github.com/denisphillips/ansible into denisphillips-devel 11 years ago
Veeti Paananen d6f4d9b76d Fix error handling on missing dest with unarchive
fixes #7107
11 years ago
Denis Phillips cd0134d290 Used module_args passed to function instead of from runner 11 years ago
Christian Berendt 6676720ce5 fixed typos found by RETF rules in PY files
rules are avaialble at https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Typos
11 years ago
James Cammarata deb532c367 Remove OrderedDict references from runner
Fixes #7256
11 years ago
James Cammarata 54b1f820fb Modify the way we set the localization environment
Previously, we set the LANG (and LC_CTYPE) environment variables
directly in the module code and applied them with os.environ().
Instead, we are now pre-pending those variables to the environment
string used to execute the command which allows the user to
override the localization values by setting the environment values
directly (even on a per-task basis):

  - subversion: repo=file:///path/to/repos/svn_über dest=/tmp/svntest
    environment:
      LANG: "C"
      LC_CTYPE: "en_US.UTF-8"

So if a user wishes to default their LANG back to C, they can still
avoid unicode issues by doing the above.

Fixes #7060
11 years ago
James Cammarata 40a7a306f5 Merge pull request #7236 from jcassee/robust-ssl-cert-concat
Make concatenating certs robust in urls.py
11 years ago
James Cammarata 8e45fa9b63 Moving display-related functions to new module in utils 11 years ago
Joost Cassee 978e6d2cd6 Make concatenating certs robust in urls.py
Add a newline after each certificate file explicitly to avoid problems
with files that do not end with a newline themselves.
11 years ago
James Cammarata 6069ff6e9e Adding a new system_warnings config option to supress warnings 11 years ago
James Cammarata 30e4759055 Merge pull request #7208 from jf/copy-module
Fix "no_log=True" option for copy module (fixes #7193)
11 years ago
James Cammarata be4e6d359f Merge branch 'delegate_to_honor_ssh_private_key_file' of https://github.com/renard/ansible into renard-delegate_to_honor_ssh_private_key_file 11 years ago
James Cammarata 4cadcccc48 Catch pycrypto warning about gmp and show a nice warning on stderr 11 years ago
Jeffrey 'jf' Lim 0bf1a27393 Fix "no_log=True" option for copy module (fixes #7193) 11 years ago
Jiri Barton 9da06274a8 Set proper file permisions when a file is created with atomic_move
Fixes #7196
11 years ago
Michael DeHaan 9a6998aa17 While this code is unused, this remote module copy of this function should not be carried around in the source code. 11 years ago
Logos01 424ee36e05 Enable facts module on older SuSE systems
Modified logic of distribution_release for SuSE to retain the last discovered key/value pair's value in /etc/SuSE-release that contains a '=' character.
11 years ago
James Cammarata 1576e8d611 Adding missing options to the file documentation fragment 11 years ago
Brian Coca c5d5481ebb added doc noting the change in behaviour 11 years ago
Cédric RICARD b8b0865ec0 Missing 'base64' import 11 years ago
Michael DeHaan ad04b455d3 add missing license header 11 years ago
James Cammarata 117952cf6c Fixing a bug in the new fetch_url username/password logic 11 years ago
James Cammarata b9d8b3b911 Merge pull request #7132 from jimi-c/issue_6601_hide_vault_yaml
Hide YAML content on syntax errors when a vault password is specified
11 years ago
James Cammarata 89fa9b7305 Add parameters to get_url for the url username/password
Fixes #6928
11 years ago
James Cammarata e9d8f0639f Merge pull request #7143 from sivel/ansible-sudo-from-root-fix
Allow sudo to another user from root with the ansible command
11 years ago
James Cammarata 460794d697 Merge pull request #7140 from jimi-c/issue_6962_traceback_callbacks_unicode
Fix handling of non-JSON lines in responses
11 years ago
Matt Martz eb8759176f Allow sudo to another user from root 11 years ago
James Cammarata 5e598c5337 Fix handling of non-JSON lines in responses
Garbage lines with ' = ' in them were causing parsing errors,
where key=val lines should not have spaces around the equals.

Fixes #6962
11 years ago
James Cammarata 38b49476f8 Merge branch 'raw-script-su-support' of https://github.com/sivel/ansible into sivel-raw-script-su-support 11 years ago
James Cammarata 93b5769d94 Hide YAML content on syntax errors when a vault password is specified
Fixes #6601
11 years ago
Michael Scherer 0f0f5ff1ce Give more information when a task is empty
I made a typo in a playbook and was great by:

    ERROR: expecting dict; got: None

The issue was a single - on the last line of a playbook.
With the name of the file, I was able to see right away where the
error was.
11 years ago
James Cammarata e83a494e41 Make sure VARS_CACHE for hosts are updated with the play vars too
Fixes #6979
11 years ago
James Cammarata a6068b09ac Fix collision in random filter name by merging functionality
Merges the functionality of the original jinja2 random filter with
the one we provide.

Fixes #7113
11 years ago
James Cammarata c115c34a1f Set the default LANG to en_US.UTF-8 and also set LC_CTYPE
Fixes #6737
11 years ago
Brian Coca c3e559b914 should now work with versions older than 8.4 11 years ago
faust64 78b9a11ccf Update facts.py
Fixes #7093 --devel
11 years ago
James Cammarata 68c30548e0 Properly catch and decode unicode strings in module _log_invocation()
Fixes #7084
11 years ago
James Cammarata 4f673b9497 Merge pull request #7083 from mscherer/better_message_multiple_action
Improve error message when multiple action are given
11 years ago
James Cammarata 39c6141b4a Merge pull request #7082 from bcoca/freebsd_mtu_fix
fixed issue with FreeBSD network facts
11 years ago
James Cammarata 086b877719 Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
Clean a bit more the ssh_args configuration
11 years ago
James Cammarata 54f86099e4 Merge pull request #7078 from mscherer/fix_error_message_controlpersist
Enhance error message about missing ControlPersist
11 years ago
Michael Scherer 1e34e95ba0 Improve error message when multiple action are given
This can be illustrated using this playbook:

    - command: id
      delegate_to: "{{ remote_server }}"
      user: "{{ remote_user }}"

The error is to use 'user' instead of 'remote_user', but the error message
do not really mention it, so it can be a bit hard to spot.
11 years ago
Brian Coca e5f297697a ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
versions and it now works
11 years ago
Brian Coca bc23926f42 fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
gathering
11 years ago
Michael Scherer c87afc1109 Clean a bit more the ssh_args configuration
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :

    <server.example.org> ESTABLISH CONNECTION FOR USER: misc
    <server.example.org> REMOTE_MODULE ping
    <server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
    '-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
    '-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
    && chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
    server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
    command using -vvvv, which will enable SSH debugging output to help diagnose the issue

The root cause is the empty string between -q and -o, who kinda break mkdir.
11 years ago
Michael Scherer 3a09c99811 Enhance error message about missing ControlPersist
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
11 years ago
James Cammarata ae29e43f93 Merge branch 'issue_7009_nfs_selinux' into devel 11 years ago
James Cammarata a32dd34359 Make sure HostVars object is instantiated before assigning it
Fixes #7006
11 years ago
Jim Kleckner 46ec238613 Fix #7057 missing False default for vars_prompt
The test for default should be "is not None" since a boolean value of
False is a valid value.

See discussion at:
  https://groups.google.com/forum/#!topic/ansible-project/oc1_zE-FnyI
11 years ago
James Cammarata 75e0b7a5cf Make sure umask is set restrictively before creating any vault files 11 years ago
James Cammarata 3715482d7c Determine selinux context for NFS mount points correctly
Fixes #7009
11 years ago
Sébastien Gross 22d6572270 Honor ansible_private_key_file for delegated hosts
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.

This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
11 years ago
Wim 6ed4ca97a8 hint to install python-ssl on redhat systems 11 years ago
smoothify 48bf7a000d Try to pass in item to on_skippped callback. 11 years ago
James Cammarata d240d073eb Changing SSL cert detection method to allow for auto-negotiation of SSL protocols
Fixes #6904
11 years ago
James Cammarata 23c5f4524d Make sure args in run_command are encoded for shlex.split calls on py2.6 11 years ago
James Cammarata d494a163f9 Merge pull request #6900 from jimi-c/issue_6891_cifs_mount_hang
Add a timeout decorator for timing out functions that may hang
11 years ago
James Cammarata ba1a6c2e11 Removing .orig file merged in accidentally 11 years ago
James Tanner aad128bac7 Use combined cache for templating module vars
Fixes #6901
11 years ago
James Cammarata 40b958e348 Don't turn complex args back into a k=v string for the synchronize module
Fixes #6951
11 years ago
James Cammarata 2cc4ac2e75 Catch traceback caused by permissions errors during a local md5 sum
Fixes #6948
11 years ago
Aaron Iles a5507275cb Fix localhost tasks with complex executables
Enable the use of executable commands that use command line options with
the localhost command runner. These commands require parsing out the
base executable from the command string to pass to subprocess.
11 years ago
jctanner bfb25f4f89 Merge pull request #6917 from bcoca/random_filter_clean
simple random filter
11 years ago
jctanner af99abc81c Merge pull request #6913 from willthames/aws_module_doc_fragments
Use common module document fragments for AWS modules
11 years ago
James Tanner 4eb626825b Refactor play._update_vars_files_for_host to make common functions and easier debugging
Fixes #4883
11 years ago
Brian Coca 80cd217eb7 simple random filter 11 years ago
willthames 509561f658 Moved AWS modules over to common module fragments
Created common module doc fragment, and applied to all
modules that use ec2_connect or connect_to_aws as
they definitely share the common doc fragments
11 years ago
James Cammarata 5ce6c86595 Merge branch 'sudo_pass_typo' of https://github.com/tyll/ansible into tyll-sudo_pass_typo 11 years ago
James Cammarata eebc72ab9b Add a timeout decorator for timing out functions that may hang
Fixes #6891
11 years ago
James Tanner 2d33cd1b5d Fixes #6894 add missing file and remove debug line 11 years ago
James Tanner 68cd7258b6 Fixes #6894 create docs fragment for files 11 years ago
Serge van Ginderachter d240e2b9fb Introduce an ansible_version dict as runner variable
Given the version:
    "1.6 (ansible_version_var 14499e8bf3) last updated 2014/03/21 17:07:50 (GMT +200)"

  We get the special variable:
    "ansible_version": {
        "full": "1.6",
        "major": 1,
        "minor": 6,
        "revision": 0,
        "string": "1.6 (ansible_version_var 14499e8bf3) last updated 2014/03/21 17:07:50 (GMT +200)"
       }

	modified:   lib/ansible/playbook/__init__.py
	modified:   lib/ansible/runner/__init__.py
	modified:   lib/ansible/utils/__init__.py
11 years ago
James Cammarata 9ca8c3262c Switch module safe_eval to ast.literal_eval 11 years ago
James Tanner 318e752b6f Fixes #6845 evaluate changed_when only if task is not skipped 11 years ago
Michael DeHaan ccdd91f9c2 Merge pull request #6861 from ericlake/devel
add distribution_major_version to fact gathering
11 years ago
James Tanner 5a65dc3b6a Fixes #6820 fix erroneous missing vault password error when using the template module 11 years ago
Eric Lake 7f9736198a add distribution_major_version to fact gathering 11 years ago
Serge van Ginderachter e36e2d38fe InventoryDir: another fix for the host.groups list
In some cases, where a host is mentioned in multiple groups, and those
groups are referenced in multiple ini files, a group could still contain
multiple instances of a group in its host,groups list, where only one of them
is the right group, that exists in the inventory.
11 years ago
James Cammarata 82b24c162e Adding delimiter fixes to action_plugin + fixing local assembling with a delimiter
Also added a new integration test for assemble using local assembly
with a delimiter.
11 years ago
Michael DeHaan 2c7275e8a9 Merge pull request #6835 from sivel/version-compare-filter
Add version_compare filter
11 years ago