James Cammarata
6a252a3f77
Preserve the cumulative path for checking includes which have parents
...
Otherwise, each relative include path is checked on its own, rather
than in relation to the (possibly relative) path of its parent, meaning
includes multiple level deep may fail to find the correct (or any) file.
Fixes #13472
10 years ago
Toshio Kuratomi
0095d04af9
Update submodule refs
10 years ago
Toshio Kuratomi
7d519127fe
Merge pull request #13573 from ansible/ssl-context-with-proxy
...
Fix a few problems with url handling.
10 years ago
Toshio Kuratomi
33863eb653
Conditionally create the CustomHTTPSConnection class only if we have the required baseclasses.
...
Fixes #11918
10 years ago
Toshio Kuratomi
72a0654b81
Fixes for proxy on RHEL5
10 years ago
Toshio Kuratomi
73ead4fbba
First attempt to fix https certificate errors through a proxy with python-2.7.9+
...
Fixes #12549
10 years ago
Brian Coca
97275110d7
Merge pull request #13533 from bcoca/debug_fixes
...
debug now validates its params
10 years ago
James Cammarata
fcc9258b74
Use the original host rather than the serialized one when processing results
...
Fixes #13526
Fixes #13564
Fixes #13566
10 years ago
Toshio Kuratomi
d203438a2c
Merge pull request #13554 from Yannig/devel_fix_python3_tests
...
Use six lib to import urlparse properly.
10 years ago
Brian Coca
be5488cb60
clean debug output to match prev versions
10 years ago
Brian Coca
a0842781a6
renamed ssh.py shared module file to clarify
10 years ago
Yannig Perré
be4d1f9ee3
Fix a part of python 3 tests (make tests-py3, see https://github.com/ansible/ansible/issues/13553 for more details).
10 years ago
Peter Sprygada
27cd7668c1
the ssh shared module will try to use keys if the password is not supplied
...
The current ssh shared module forces only password based authentication. This
change will allow the ssh module to use keys if a password is not provided.
10 years ago
Toshio Kuratomi
8d16638fec
Fix for template module not creating a file that was not present when force=false
10 years ago
Michael Scherer
a7ac98262d
Make module_utils.known_hosts.get_fqdn work on ipv6
10 years ago
Toshio Kuratomi
c9eb41109f
Update submodule refs
10 years ago
James Cammarata
80d23d639c
Use an octal representation that works from 2.4->3+ for known_hosts
10 years ago
James Cammarata
6312e38133
Fixing up some non-py3 things for unit tests
10 years ago
Brian Coca
2a37f11738
Merge pull request #13542 from h0nIg/devel_default_ask
...
ansible vault, ask pass: use default settings from ansible.cfg
10 years ago
Hans-Joachim Kliemeck
f5f9b2fd35
use default settings from ansible.cfg
10 years ago
James Cammarata
f8ff63f8c8
A few tweaks to improve new forking code
10 years ago
Brian Coca
175c2d6510
Merge pull request #13502 from robinro/patch-3
...
use shallow clones by default in ansible-pull
10 years ago
Toshio Kuratomi
2bc3683d41
Restore comment about for-else since it is an uncommon idiom
10 years ago
chouseknecht
06dde0d332
Fixed documentation typos and bits that needed clarification. Fixed missing spaces in VALID_ACTIONS.
10 years ago
chouseknecht
342dee0023
Define and handle ignore_certs correctly. Preserve search term order. Tweak to Galaxy docsite.
10 years ago
chouseknecht
bc73920090
Updated ansible-galaxy man page. Removed -b option for import.
10 years ago
chouseknecht
d8e6bc98a2
Fix overloaded options. Show an error when no action given. Don't show a helpful list of commands and descriptions.
10 years ago
Robin Roth
1bd8d97093
fix whitespace
10 years ago
Robin Roth
1b2ebe8def
make shallow clone the default for ansibel-pull
10 years ago
Brian Coca
d73562902b
debug now validates its params
...
simplified var handling
made default message the same as in pre 2.0
fixes #13532
10 years ago
Brian Coca
f3bedbae29
simplified skippy
...
thanks agaffney!
10 years ago
Brian Coca
99e46440bd
changed shell delimiters for csh
...
fixes #13459
10 years ago
Brian Coca
8e445c551a
removed unused imports in galaxy/cli
10 years ago
James Cammarata
120b9a7ac6
Changing the way workers are forked
10 years ago
Brian Coca
ae988ed753
avoid set to unique hosts to preserver order
...
swiched to using a list comp and set to still unique but keep expected order
fixes #13522
10 years ago
Brian Coca
de71171fc2
removed merge conflict
10 years ago
James Cammarata
7f7e730dea
Don't mark hosts failed if they've moved to a rescue portion of a block
...
Fixes #13521
10 years ago
Brian Coca
d9e510b192
narrow down exception catching in block builds
...
this was obscuring other errors and should have always been narrow scope
10 years ago
Chrrrles Paul
e56efa49c4
Merge pull request #13509 from chrrrles/vca_default_host
...
fix default host for non vcd service types
10 years ago
Abhijit Menon-Sen
37c4e9aee3
Clean up debug logging around _low_level_execute_command
...
We were logging the command to be executed many times, which made debug
logs very hard to read. Now we do it only once.
Also makes the logged ssh command line cut-and-paste-able (the lack of
which has confused a number of people by now; the problem being that we
pass the command as a single argument to execve(), so it doesn't need an
extra level of quoting as it does when you try to run it by hand).
10 years ago
Charles Paul
a6a58d6947
fix default host for non vcd service types
10 years ago
Toshio Kuratomi
bd9582d072
Update submodule refs
10 years ago
Toshio Kuratomi
1dda8158ff
become_pass needs to be bytes when it is passed to ssh.
...
Fixes #13240
10 years ago
Charles Paul
6680cc7052
allow custom callbacks with adhoc cli for scripting
...
missing import of CallbackBase
10 years ago
Robin Roth
c20c1a6d49
add depth option to ansible-pull
...
Allows shallow checkouts in ansible-pull by adding `--depth 1` (or higher number)
10 years ago
James Cammarata
2b36343451
Missed one place we were appending the incorrectly escaped item to raw params
10 years ago
Toshio Kuratomi
62cbc03af6
Revert "Remove the funcd connection plugin"
...
This reverts commit c0d79cf7e1 .
We may still port the funcd connection plugin, just not in time for
2.0.0
10 years ago
James Cammarata
30b6dd8bcd
Merge pull request #13495 from Yannig/devel_debug_null_error
...
Do not fail when variable is not correct in debug action.
10 years ago
Yannig Perré
18ac12aee6
Do not fail when variable is not correct in debug action.
...
See https://github.com/ansible/ansible/issues/13484 for more information.
10 years ago
Toshio Kuratomi
c0d79cf7e1
Remove the funcd connection plugin
10 years ago
Brian Coca
64864829c4
changed deprecation to removal warning
10 years ago
Toshio Kuratomi
61dc4a7e67
Update module refs
10 years ago
James Cammarata
14e19c239d
Make on_file_diff callback item-aware
10 years ago
Brian Coca
04d74fd680
reenabled --tree for ansible adhoc command
...
previous fix to avoid callbacks now conflicted with tree optoin
which is implemented as a callback in 2.0
10 years ago
Brian Coca
7936a4687e
adhoc avoids callbacks by default as it did before
...
Previous emptying of whitelist only affected callbacks that were
constructed for need whitelist. This now works for all callbacks.
10 years ago
Brian Coca
ae2447df91
attribute defaults that are containers are a copy
...
This is simpler way to prevent persistent containers across instances
of classes that use field attributes
10 years ago
Brian Coca
2bfb13bfb3
removed unused 'pattern' from ansible.cfg
...
also moved the config param to a 'deprecated' list in constants.py
added TODO for producing a deprecation warning for such vars
10 years ago
Brian Coca
2820b4c243
removed default from hosts to make it requried
...
prevents writing a play w/o a hosts entry which would default to
all/empty
10 years ago
Brian Coca
c64298de02
Revert "avoid persistent containers in attribute defaults"
...
This reverts commit 87969868d4 .
found better way to do it
10 years ago
James Cammarata
332a008273
Merge pull request #13489 from chouseknecht/galaxy-2.0
...
Galaxy 2.0
10 years ago
chouseknecht
4f84769a17
Galaxy 2.0
10 years ago
Brian Coca
87969868d4
avoid persistent containers in attribute defaults
...
moved from the field attribute declaration and created a placeholder
which then is resolved in the field attribute class.
this is to avoid unwanted persistent of the defaults across objects which introduces
stealth bugs when multiple objects of the same kind are used in succession while
not overriding the default values.
10 years ago
Brian Coca
0719eb3e2d
clarified warning from tree callback
10 years ago
Brian Coca
d82d65ee7b
keep string type filters as strings
...
now we don't try to convert types if using a filter that outputs a specifically formated string
made list of filters configurable
10 years ago
James Cammarata
1799de8528
Preserve original token when appending to _raw_params in parse_kv
...
Fixes #13311
10 years ago
Brian Coca
795fac917e
fixed typo in tree callback, added default dir
...
this would allow it to work with playbooks also
10 years ago
James Cammarata
398f6bbb89
Fix typo from 5ae850c
10 years ago
James Cammarata
de690445bc
Make fact delegating configurable, defaulting to 1.x behavior
10 years ago
Brian Coca
7ffd578a9d
Revert "Fix always_run support in the action plugin for template when copying"
...
This reverts commit 9c4eae5253 .
10 years ago
Brian Coca
d4ccb0be59
have always_run override check mode for a task
...
Fixes #13418
10 years ago
James Cammarata
9c4eae5253
Fix always_run support in the action plugin for template when copying
...
Fixes #13418
10 years ago
David L Ballenger
cdc3c88018
Merge remote-tracking branch 'ansible/devel' into issue_13438
10 years ago
Peter Sprygada
2d5b4b1799
Merge pull request #13273 from privateip/nxapi
...
adds new device argument to nxapi command arguments
10 years ago
David L Ballenger
970d7cadb7
Add ssh_host support for MacOSX El Capitan.
...
OS X El Capitan moved the /etc/ssh_* files into /etc/ssh/. This fix
adds a distribution version check for Darwin to set the keydir
appropriately on El Capitan and later.
10 years ago
Brian Coca
9ae1dede03
adhoc does not load plugins by default
...
reimplemented feature from 1.x which kept additional callbacks from
poluting adhoc unless specifically asked for through configuration.
10 years ago
Brian Coca
17b334d4a5
Merge pull request #13450 from privateip/feature_ios_shared_module
...
bugfix for ios.py shared module argument creation
10 years ago
James Cammarata
540cbe0f64
Merge pull request #13445 from n-st/tasks-string-repr
...
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
10 years ago
James Cammarata
2884ff3932
Merge pull request #13455 from Yannig/devel_fix_debug_var_when_content_same_as_name
...
Fix issue when var name is the same as content.
10 years ago
Yannig Perré
2c8eee956f
Fix issue when var name is the same as content.
...
See https://github.com/ansible/ansible/issues/13453 for more details.
10 years ago
Toshio Kuratomi
4d637e5780
Use self.args when we parse arguments that way the arguments can be constructed manually
10 years ago
Toshio Kuratomi
a8e015cc22
Add representers so we can output yaml for all the types we read in from yaml
10 years ago
Peter Sprygada
41773630ed
adds new device argument to nxapi command arguments
...
The device argument allows a dict of nxapi parameters to be passed to
the module to simplify passing the nxapi parameters
10 years ago
Brian Coca
8607aa527d
Merge pull request #13446 from lberruti/no_target_syslog
...
Make no_target_syslog consistent.
10 years ago
Brian Coca
955710267c
only set become defaults at last possible moment
...
tasks were overriding commandline with their defaults, not with the
explicit setting, removed the setting of defaults from task init and
pushed down to play context at last possible moment.
fixes #13362
10 years ago
Luca Berruti
8ea45e8608
Make no_target_syslog consistent.
...
no_target_syslog = False --> do log on target
10 years ago
Brian Coca
f89f906f87
simplified get_hosts code to have 1 retrun point
10 years ago
Nils Steinger
a1f6d17e37
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
10 years ago
Nils Steinger
0129fb0a44
Remove duplicates from host list *before* caching it
...
Ansible previously added hosts to the host list multiple times for commands
like `ansible -i 'localhost,' -c local -m ping 'localhost,localhost'
--list-hosts`.
8d5f36a fixed the obvious error, but still added the un-deduplicated list to a
cache, so all future invocations of get_hosts() would retrieve a
non-deduplicated list.
This caused problems down the line: For some reason, Ansible only ever
schedules "flush_handlers" tasks (instead of scheduling any actual tasks from
the playbook) for hosts that are contained in the host lists multiple times.
This probably happens because the host states are stored in a dictionary
indexed by the hostnames, so duplicate hostname would cause the state to be
overwritten by subsequent invocations of … something.
10 years ago
Toshio Kuratomi
c8fd599e14
Merge pull request #13373 from no2a/boolean
...
BOOLEAN should contain boolean literals
10 years ago
Toshio Kuratomi
0434644d12
Transform exceptions into ansible messages via to_unicode instead of str to avoid tracebacks.
...
Fixes #13385
10 years ago
James Cammarata
84507aedd4
Adding a uuid field so we can track host equality across serialization too
10 years ago
James Cammarata
750adbaa27
Changing up how host (in)equality is checked
...
Fixes #13397
10 years ago
Toshio Kuratomi
e385c91fa5
Update submodule refs#
10 years ago
Brian Coca
d5446f9804
fixed ansible-pull broken options
...
* sudo was not working, now it supports full become
* now default checkout dir works, not only when specifying
* paths for checkout dir get expanded
* fixed limit options for playbook
* added verbose and debug info
10 years ago
Brian Coca
e1c62fb5af
reverted to previous pull checkout dir behaviour
...
This fixes bugs with not finding plays when not specifying checkout dir
Also makes it backwards compatible
10 years ago
Brian Coca
8d5f36a6c2
return unique list of hosts
10 years ago
Thomas Steinbach
349fb42f54
Allow setup of docker remote connections
10 years ago
Brian Coca
a1f516824e
corrected playbook path, reformated options help
...
the last just to make the help consistent and readable
10 years ago
Brian Coca
26520442bd
Now and/or shell expressions depend on shell plugin
...
This should fix issues with fish shell users as && and || are
not valid syntax, fish uses actual 'and' and 'or' programs.
Also updated to allow for fish backticks pushed quotes to subshell,
fish seems to handle spaces w/o them.
Lastly, removed encompassing subshell () for fish compatibility.
fixes #13199
10 years ago
James Cammarata
f467f1770f
Properly compare object references for Hosts when adding new ones
...
Fixes #13397
10 years ago
James Cammarata
4426b7f6e0
fix sorting of groups for host vars
...
Fixes #13371
10 years ago
Brian Coca
7d073bdd17
Merge pull request #13345 from amenonsen/extract
...
Add an 'extract' filter
10 years ago
Peter Sprygada
29f5c5db71
bugfix for ios.py shared module argument creation
...
This patch fixes a bug in module_utils/ios.py where the the wrong shared
module arguments are being generated. This bug prevented the shared module
from operating correctly. This patch should be generally applied.
10 years ago
James Cammarata
5f83a6aeda
Properly default remote_user for delegated-to hosts
...
Fixes #13323
10 years ago
Toshio Kuratomi
e201a255d1
Revert "Make sudo+requiretty and ANSIBLE_PIPELINING work together"
...
This reverts commit f488de8599 .
Reverting for now due to hard to pin down bugs: #13410 #13411
10 years ago
Toshio Kuratomi
9b81c35d06
Don't compare or merge str with unicode
...
Fixes #13387
10 years ago
James Cammarata
a183972477
Don't use play vars in HostVars
...
Fixes #13398
10 years ago
James Cammarata
8ff67e0494
Default msg param to AnsibleError to avoid serialization problems
10 years ago
James Cammarata
5f1f2acfea
Merge pull request #13405 from sivel/v2-playbook-on-start
...
Get v2_playbook_on_start working
10 years ago
Matt Martz
384b2e0234
Get v2_playbook_on_start working
...
* Move self._tqm.load_callbacks() earlier to ensure that v2_on_playbook_start can fire
* Pass the playbook instance to v2_on_playbook_start
* Add a _file_name instance attribute to the playbook
10 years ago
Brian Coca
7708661270
Merge pull request #13402 from amenonsen/expandpath
...
Use CLI.expand_tilde also for the vault --output file
10 years ago
Brian Coca
94d2958e1f
Merge pull request #13403 from amenonsen/module-lang
...
Make module_lang default to whatever LANG is set to on the control node
10 years ago
Abhijit Menon-Sen
0d16d16ab8
Make module_lang default to whatever LANG is set to on the control node
10 years ago
Abhijit Menon-Sen
fac7626230
Use CLI.expand_tilde also for the vault --output file
10 years ago
Matt Martz
ce54a59cdc
Catch additional assertion errors for load_list_of_blocks
10 years ago
Brian Coca
53cd802251
better error on invalid task lists
10 years ago
James Cammarata
f7dc5a9515
Minor tweak and comment addition to 974a0ce3
10 years ago
James Cammarata
f1d53a87e5
Merge pull request #13394 from Christoph-D/issue-13370
...
Fix #13370
10 years ago
Abhijit Menon-Sen
8cf1815867
Add an 'extract' filter
...
At its most basic, this is nothing more than an array or hash lookup,
but when used in conjunction with map, it is very useful. For example,
while constructing an "ssh-keyscan …" command to update known_hosts on
all hosts in a group, one can get a list of IP addresses with:
groups['x']|map('extract', hostvars, 'ec2_ip_address')|list
This returns hostvars[a].ec2_ip_address, hostvars[b].ec2_ip_address, and
so on. You can even specify an array of keys for a recursive lookup, and
mix string and integer keys depending on what you're looking up:
['localhost']|map('extract', hostvars, ['vars','group_names',0])|first
== hostvars['localhost']['vars']['group_names'][0]
== 'ungrouped'
Includes documentation and tests.
10 years ago
Abhijit Menon-Sen
22381be253
Bump version in devel now that stable-2.0 has been branched
10 years ago
Christoph Dittmann
267199fdd5
Update debug messages and comments
...
The comment was taken literally from lib/plugins/strategy/linear.py and
makes no sense in free.py where we have no noop tasks.
Also update the debug messages.
10 years ago
Christoph Dittmann
c6e400fbea
Fix issue #13370
...
all_blocks is referenced after the loop over included_files, so it needs
to be initialized before this loop, not inside.
10 years ago
Christoph Dittmann
9a6ae1d62a
Let PlayIterator.add_tasks accept empty task lists
...
PlayIterator.add_tasks raised an error when trying to add an empty task
list. This was the root cause of ansible issue #13370 .
10 years ago
Brian Coca
b92cb93539
unconditionally set vars on init to avoid issues with var precedence
10 years ago
Peter Sprygada
2491afc8b6
fixes a syntax issue with module_utils/eapi.py
...
This patch fixes an issue with the common args dict in the eapi shared
module. This patch is required for the eapi shared module to be properly
imported and is therefore should be applied to all instances.
10 years ago
Brian Coca
8c630406c9
Merge pull request #13357 from privateip/feature_ssh_shared_module
...
initial add of ssh shared module.
10 years ago
Brian Coca
923b5467e3
Merge pull request #13354 from privateip/feature_eapi
...
adds device common argument to shared module
10 years ago
Brian Coca
574d7be8d5
Merge pull request #13358 from privateip/feature_ios_shared_module
...
Feature ios shared module
10 years ago
Peter Sprygada
93cd7a2a5f
adds module create function for eapi.py shared module
...
This commit changes the way modules create an instance of AnsibleModule to
now use a common function, eapi_module. This function will now automatically
append the common argument spec to the module argument_spec. Module
arguments can override common module arguments
10 years ago
Peter Sprygada
8638e0ccf8
initial add of the ios shared module
...
This adds shared module support for building modules that connect to Cisco
IOS devices. It builds on the module_utils/ssh.py shared module.
10 years ago
Brian Coca
3e01516783
fixed signature for init on callbacks
...
also removed passing display to base class which already handles this
10 years ago
nitzmahone
c94509f273
allow shell plugin to affect remote module filename
...
Fix for 13368, added get_remote_filename to shell plugins, powershell version appends .ps1 if necessary, base shell plugin no-ops
10 years ago
Abhijit Menon-Sen
f488de8599
Make sudo+requiretty and ANSIBLE_PIPELINING work together
...
Pipelining is a *significant* performance benefit, because each task can
be completed with a single SSH connection (vs. one ssh connection at the
start to mkdir, plus one sftp and one ssh per task).
Pipelining is disabled by default in Ansible because it conflicts with
the use of sudo if 'Defaults requiretty' is set in /etc/sudoers (as it
is on Red Hat) and su (which always requires a tty).
We can (and already do) make sudo/su happy by using "ssh -t" to allocate
a tty, but then the python interpreter goes into interactive mode and is
unhappy with module source being written to its stdin, per the following
comment from connections/ssh.py:
# we can only use tty when we are not pipelining the modules.
# piping data into /usr/bin/python inside a tty automatically
# invokes the python interactive-mode but the modules are not
# compatible with the interactive-mode ("unexpected indent"
# mainly because of empty lines)
Instead of the (current) drastic solution of turning off pipelining when
we use a tty, we can instead use a tty but suppress the behaviour of the
Python interpreter to switch to interactive mode. The easiest way to do
this is to make its stdin *not* be a tty, e.g. with cat|python.
This works, but there's a problem: ssh will ignore -t if its input isn't
really a tty. So we could open a pseudo-tty and use that as ssh's stdin,
but if we then write Python source into it, it's all echoed back to us
(because we're a tty). So we have to use -tt to force tty allocation; in
that case, however, ssh puts the tty into "raw" mode (~ICANON), so there
is no good way for the process on the other end to detect EOF on stdin.
So if we do:
echo -e "print('hello world')\n"|ssh -tt someho.st "cat|python"
…it hangs forever, because cat keeps on reading input even after we've
closed our pipe into ssh's stdin. We can get around this by writing a
special __EOF__ marker after writing in_data, and doing this:
echo -e "print('hello world')\n__EOF__\n"|ssh -tt someho.st "sed -ne '/__EOF__/q' -e p|python"
This works fine, but in fact I use a clever python one-liner by mgedmin
to achieve the same effect without depending on sed (at the expense of a
much longer command line, alas; Python really isn't one-liner-friendly).
We also enable pipelining by default as a consequence.
10 years ago
Toshio Kuratomi
50553bc2ba
_connect no longer takes a port argument
10 years ago
Brian Coca
f1fcab4610
ignore password flags in become conflict check
...
since all the --ask pass options end up triggering the same code
and are functionally equivalent, ignore them when it comes to checking
privilege escalation conflicts. This allows using -K when --become-method=su
and so on.
10 years ago
Brian Coca
a6f6a80caa
avoid inheritance issues with default=dict declaration at class level
...
this should avoid the issue of subsequent plays not prompting for a var
prompted for in a previous play.
10 years ago
Toshio Kuratomi
30094912eb
boto is expecting that we pass it unicode strings.
...
The secret_key parameter especially can contain non-ascii characters and
will throw an error if such a string is passed as a byte str.
Potential fix for #13303
10 years ago
Arata Notsu
6d6d4f0c8e
BOOLEAN should contain boolean literals
...
It is natural that an argument_spec with choises=BOOLEAN accepts
boolean literal (True, False) though the current implementation
allows only string or int.
10 years ago
Toshio Kuratomi
ba4e571029
Update submodule refs to go along with the StandardError change in ec2 moudles
10 years ago
Toshio Kuratomi
19d5759771
raise AnsibleAWSError instead of StandardError.
...
* StandardError doesn't exist in python3
* because it is the root of builtin expections, we can't catch it
separate from the builtin exceptions
* It doesn't tell us anything about the error being thrown as it's too
generic
10 years ago
James Cammarata
dc0fae1af7
Also make sure remote_user is defaulted correctly for delegated hosts
...
Fixes #13323
10 years ago
Toshio Kuratomi
e2ddc2f6ab
Call the function :-)
...
Fixes #13330
10 years ago
James Cammarata
cc36eedf76
Ensure port is (re)set for delegated-to hosts
...
Fixes #13265
10 years ago
Brian Coca
b5f2c3def2
fixed typo
10 years ago
Brian Coca
eefb4931dd
allow for bad stdout return from make temp dir command
...
fixes #13359
10 years ago
Brian Coca
005b17afec
corrected become_methods class variable in winrm
...
This should now correctly react when using become with winrm
fixes #13331
10 years ago
James Cammarata
80db6bacc4
Make sure run_once tasks properly set variables for all active hosts
...
Fixes #13267
10 years ago
James Cammarata
fbc9553bd4
Use text_type instead of unicode
10 years ago
James Cammarata
c6a30f7000
Make sure the uuid in vars is string
10 years ago
James Cammarata
f926e81782
Re-implement lookup wantlist
...
Fixes #13285
10 years ago
James Cammarata
dfa576b037
Merge pull request #13307 from Yannig/devel_fix_big_include_vars
...
Fix for https://github.com/ansible/ansible/issues/13221
10 years ago
Peter Sprygada
c087160652
initial add of ssh shared module.
...
This ssh shared module is used for building modules that require an
interactive shell environment such as those required for connecting
to network devices
10 years ago
James Cammarata
6671d78f95
Tweak location of stats callback execution and properly relocate stats output code
10 years ago
James Cammarata
ea23159be4
Merge pull request #13348 from emonty/bug/iterate-on-none
...
Put in trap for args being None
10 years ago
Monty Taylor
d20e67d708
Put in trap for args being None
...
_normalize_old_style_args can return None. If it does, the loop
"for args in args" blows up.
10 years ago
James Cammarata
800811a15f
Trigger on_stats just once, not once for each play
...
Fixes #13271
10 years ago
James Cammarata
a7f7f8bd29
Merge pull request #13297 from amenonsen/ssh-escalation
...
Explicitly accept become_success in awaiting_prompt state
10 years ago
James Cammarata
5b6162a166
Re-adding role_name/role_uuid variables
10 years ago
James Cammarata
8d9835c40b
Merge pull request #13342 from Yannig/devel_fix_bomb_shell
...
Devel fix bomb shell
10 years ago
Yannig Perré
5227c6bb52
Do not copy variable_manager each time. Instead, keep host and local variable_manager sync.
...
Fix https://github.com/ansible/ansible/issues/13221
10 years ago
Yannig Perré
2fc7c8b460
More restrictive test against variable name to allow setting variable starting with _.
10 years ago
Brian Coca
fa358d9d61
avoids prompting for vars during syntax check
...
fixes #13319
10 years ago
Yannig Perré
2c54fb1339
Switch parameters validation after parsing in order to be more consistent between old and new style.
10 years ago
Abhijit Menon-Sen
f20e2630b0
Explicitly accept become_success in awaiting_prompt state
...
If we request escalation with a password, we start in expecting_prompt
state. If the escalation then succeeds without the password, i.e., the
become_success response arrives, we must explicitly move into the next
state (awaiting_escalation, which immediately goes into ready_to_send),
so that we no longer try to apply the timeout.
Otherwise, we would leak the success notification and eventually
timeout. But if the module response did arrive before the timeout
expired, the "process has already exited" test would do the right
thing by accident (which is why it didn't fail more often).
Fixes #13289
10 years ago
Toshio Kuratomi
1b743436b9
Do not double transform to unicode
10 years ago
Chrrrles Paul
157230c3e8
Merge pull request #13257 from chrrrles/utf8
...
fixing error with using non-ascii values for ask-sudo-password
10 years ago
Charles Paul
1e5a205389
fixing errors with utf-8 values
...
removing utf-8 stanza
changing cast to binary_type instead
using to_unicode
10 years ago
Brian Coca
71fe49ee3a
Merge pull request #13247 from bcoca/fetch_fixes
...
fixes to fetch action module
10 years ago
Brian Coca
7244b5ae49
added missing :
10 years ago
Brian Coca
0ec60ac09b
added missing events to base class
10 years ago
James Cammarata
70de8bc96f
Fix ssh state issues by simply assuming it's never connected
10 years ago
James Cammarata
65747285a4
Properly check for prompting state when re-using ssh connection
...
Fixes #13278
10 years ago
James Cammarata
96fcfe45d0
Merge pull request #13264 from Yannig/devel_debug_var_list_or_dict
...
Allow debug var parameter to accept a list or dict.
10 years ago
Yannig Perré
5fa49a9ad8
Use to_unicode instead of str()
10 years ago
James Cammarata
679488fdb5
Merge pull request #13239 from sysreq0/devel
...
We should give pipes.quote() a string every time
10 years ago
James Cammarata
53e86f3130
Merge pull request #13261 from cchurch/with_items_reuse_connection
...
Modify task executor to reuse connections inside a loop.
10 years ago
James Cammarata
e06b107d2d
Template (and include vars) PlaybookInclude paths
...
Fixes #13249
10 years ago
Chris Church
272778f732
Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items.
10 years ago
Toshio Kuratomi
adf2d53fa2
Update submodule refs
10 years ago
Yannig Perré
0480b44f50
Allow debug var parameter to accept a list or dict. Fix https://github.com/ansible/ansible/issues/13252
10 years ago
Brian Coca
478c6c756a
marked spot that should send per item reulsts
10 years ago
Brian Coca
fb96748d7c
fixes to fetch action module
...
* now only runs remote checksum when needed (fixes #12290 )
* unified return points to simplify program flow
10 years ago
Toshio Kuratomi
2631a8e6e4
Update extras to fix docs build
10 years ago
Toshio Kuratomi
8fd15ae2a3
Merge pull request #13217 from ansible/more-strict-plugin-lookup
...
Fix non-module plugins picking up files that did not end in .py.
10 years ago
Toshio Kuratomi
77c83fd520
Commit submodule refs to the devel HEAD
10 years ago
Toshio Kuratomi
664c7980a2
Update submodule refs
10 years ago
Sebastien Couture
087dbc1ed5
We should give pipes.quote() a string every time
10 years ago
Toshio Kuratomi
591c81e95f
Docker cp sets file ownership to root:root so we can't use it.
...
Fixes #13219
10 years ago
Toshio Kuratomi
d75e707af5
Simplify code a little
10 years ago
Toshio Kuratomi
72558f7ecd
Merge pull request #13074 from joernheissler/patch-13073
...
Use ansible_host in synchronize module
10 years ago
Toshio Kuratomi
c86120cea6
Fix non-module plugins picking up files that did not end in .py.
...
This was caused by accessing the cache using the passed in mod_type
rather than the suffix that we calculate with knowledge of whether this
is a module or non-module plugin.
10 years ago
James Cammarata
c97c101bd3
Merge pull request #13209 from nitzmahone/winrm_put_file
...
fast winrm put_file without size restrictions
10 years ago
James Cammarata
8a0d2e0ef2
Submodule pointer update
10 years ago
James Cammarata
91500f8f5f
Fix include param precedence in variable manager
10 years ago
James Cammarata
78e4f176e6
Return skipped/failed async results directly
...
Fixes #13205
10 years ago
James Cammarata
3b16ad973c
Merge pull request #13201 from ma82/patch-1
...
Fix DataLoader's docstring
10 years ago
Marius Gedminas
66347c9449
Fix NameError when using loops
...
vars_copy disappeared in 3d1255d190 .
Fixes #13213 .
10 years ago
nitzmahone
db83c0e7cd
winrm error handling tweaks
10 years ago
James Cammarata
3d1255d190
Don't update job vars too early when getting loop items in TaskExecutor
...
Fixes #13113
10 years ago
Brian Coca
f8ed99e5e4
Revert "success should not include skipped"
...
This reverts commit 300ee227a2 .
10 years ago
nitzmahone
549163170f
fast winrm put_file without size restrictions
10 years ago
Mick Bass
9761250a4b
Allow tree-ish to be used for galaxy role version
...
Ensure that ansible-galaxy version can be a branch, a tag, or any tree-ish
supported by git including specific commit IDs. For git scm roles, adds an
explicit git checkout of the specified role_version prior to the git archive.
This means that we'll always archive from HEAD of whatever role_version is
checked out. role_version can be a branch, a tag, or any <tree-ish> supported
by git including specific commit IDs. These changes also ensure
ansible-galaxy works for scm clones when specified version differs from
repository default branch.
10 years ago
Matteo Acerbi
0127d32652
Fix DataLoader's docstring
...
DataLoader.__init__ doesn't take an argument named vault_password
10 years ago
James Cammarata
9b9fb51d9d
Template the final_environment value in _compute_environment_string()
...
Fixes #13123
10 years ago
Toshio Kuratomi
782aa9a7fd
Update submodule refs
10 years ago
James Cammarata
180159b01d
Adding vars back in and trying to add a little more speed by avoiding copies
10 years ago
James Cammarata
25807f5404
Don't modify things we've put on the queue
...
Fixes #12937
10 years ago
Brian Coca
d35f615af8
added more debug info for command results
10 years ago
Brian Coca
aa55db69fe
Merge pull request #12687 from nitzmahone/pywinrm_arg_passthru
...
Force SSL transport for pywinrm updates, get host+group vars
10 years ago
James Cammarata
f10d2c57c8
Restoring templating of hostvars returned by __getitem__
10 years ago
James Cammarata
9f31c073fe
Fixing a few bugs in the HostVars performance areas
...
* Also refresh inventory in the HostVars manager process when things
are changed via add_host/group_by
* Raise j2undefined rather than return it
10 years ago
James Cammarata
984729016e
Fix tag filtering on included files and add more debugging
...
Previously, we were filtering the task list on tags for each host
that was including the file, based on the idea that the variables
had to include the host information. However, the top level task
filtering is play-context only, which should also apply to the
included tasks. Tags cannot and should not be based on hostvars.
10 years ago
James Cammarata
5cbeab5a3c
Performance improvements for HostVars and some bugfixes
10 years ago
Dann Bohn
7f2cae5405
add REPLACER_SELINUX back into module_common
10 years ago
Brian Coca
355fa4797a
Merge pull request #13186 from nitzmahone/add_host_cache_fix
...
fix for dynamic (add_host) hosts not available in hostvars
10 years ago
Brian Coca
6a2559be02
Merge pull request #13184 from nitzmahone/hostvars_undefined_fix
...
hostvars should return j2 undefined as instance, not type
10 years ago
Toshio Kuratomi
fc7e2912f2
zone connection plugin bugfixes and pipelining and sudo become methods enabled!
...
Thanks to peinheber for helping test and debug this!
10 years ago
nitzmahone
349e072a74
fix for dynamic (add_host) hosts not available in hostvars
...
Looks like there are two pattern caches that need to be cleared for this to work- added the second one.
Added integration tests for add_host to prevent future regressions.
10 years ago
nitzmahone
3bb1f7a561
hostvars should return j2 undefined as instance, not type
...
Looks like someone forgot to create an instance of undefined here- we were returning the undefined type object, which broke all the undefined checks.
Added an integration test around add_host that will catch this (separate PR to follow)
10 years ago
Brian Coca
db27541a0e
Merge pull request #13053 from Etherdaemon/fix_13010_boto3_aws_profile
...
Fixes #13010 by updating boto3 methods
10 years ago
Brian Coca
89646d4253
no need to be executable
10 years ago
Jonathan Davila
1b76a9cef2
Patch to remove dependency on boto when only using boto3
...
Updated with explicit check for HAS_BOTO3
10 years ago
Brian Coca
2083a2dffa
Merge pull request #13174 from sebi-hgdata/sebi/consul_kv_issue
...
Consul kv lookup super invocation fix
10 years ago
Brian Coca
83f7942dcf
removed print entries, corrected display calls to match latest devel
10 years ago
Brian Coca
78be81b96d
Merge pull request #12510 from jcftang/devel
...
Initial add of logentries callback plugin
10 years ago
Brian Coca
f1db99caa7
updated with latest changes to default
10 years ago
Brian Coca
eeedaf2cbc
fixed var name typo
10 years ago
Brian Coca
e174247734
evaluate includes for skipped tags
...
cannot evaluate for include tags as underlying tasks might have them, but skips override so this should be a performance boost
10 years ago
Sebi Calbaza
1f052d5ce6
fixed super invocation
10 years ago
Brian Coca
300ee227a2
success should not include skipped
...
fixes #13161
10 years ago
Jimmy Tang
19ba54c9fd
Don't be fatal on import errors so plays don't fail if plugin doesn't have required dependencies
10 years ago
Jimmy Tang
125370ab48
Run when whitelisted
10 years ago
Jimmy Tang
5f2f5e2b59
Add boilerplate and fix initialisation to match what 2.0 expects
10 years ago
Jimmy Tang
c02ceb8f12
Remove threading and queues. Added license information and cleaned up callback.
10 years ago
Jimmy Tang
85277c8aae
Initial add of logentries callback plugin
...
This callback plugin will generate json objects to be sent to the
logentries service for auditing/debugging purposes.
To use:
Add this to your ansible.cfg file in the defaults block
[defaults]
callback_plugins = ./callback_plugins
callback_stdout = logentries
callback_whitelist = logentries
Copy the callback plugin into the callback_plugings directory
Either set the environment variables
export LOGENTRIES_API=data.logentries.com
export LOGENTRIES_PORT=10000
export LOGENTRIES_ANSIBLE_TOKEN=dd21fc88-f00a-43ff-b977-e3a4233c53af
Or create a logentries.ini config file that sites next to the plugin with the following contents
[logentries]
api = data.logentries.com
port = 10000
tls_port = 20000
use_tls = no
token = dd21fc88-f00a-43ff-b977-e3a4233c53af
10 years ago
James Cammarata
07b588f6c0
Version bump for new beta 2.0.0-0.5.beta3
10 years ago
James Cammarata
2b25b7974c
Remove unnecessary sleep from result process
10 years ago
Brian Coca
634e10e5b8
Merge pull request #13156 from amenonsen/broken-timeout
...
If ssh died, it's an error, not a timeout
10 years ago
Abhijit Menon-Sen
26ea9c4351
If ssh died, it's an error, not a timeout
10 years ago
David M. Lee
5bd096208c
Increase the escalation prompt timeout
...
It was set to match the SSH connect timeout. Unfortunately, they would
race when ssh fails to connect, and the connect timeout usually failed.
This led to some misleading error messages.
Fixes #12916
10 years ago
James Cammarata
31b1abf580
Merge pull request #13146 from nitzmahone/gce_error_messaging
...
fix gce module error reporting
10 years ago
nitzmahone
4163655099
fix gce module error reporting
...
Error reporting was broken for GCE modules- pprint didn't work with exceptions, so you'd always get "Unexpected response: {}" instead of the real error.
10 years ago
Toshio Kuratomi
958fb29b78
Merge pull request #12881 from Scypho/devel
...
fix for issue #11885 - allowing json in lookup template calls
10 years ago
James Cammarata
13750f68ee
Reduce spinning while waiting on queues
10 years ago
Daniel Menet
0918416b83
substitute tilde and env vars before storing C.CACHE_PLUGIN_CONNECTION as instance attribute
10 years ago
Toshio Kuratomi
7fd8b86a10
Fix documentation build problems
10 years ago
Toshio Kuratomi
d38ac6a394
Update submodule ref for another new module
10 years ago
Toshio Kuratomi
7807e99bca
A bunch of shipit's merged
10 years ago
Toshio Kuratomi
8aa2cbd647
Fix traceback because we're using display from another object that no
...
longer has it.
10 years ago
James Cammarata
b2b0fa8d13
Changed do/until failed color
...
Fixes #13130
10 years ago
James Cammarata
94c20c9ac6
Cleanup failed/changed logic in TaskExecutor
...
Fixes #12980
10 years ago
Toshio Kuratomi
62979efa14
Finish up plugin porting to global display
...
Also remove display = display which does nothing
10 years ago
Toshio Kuratomi
2bd695ed42
Port cache plugins to global display
10 years ago
Toshio Kuratomi
b05d0b8c9c
Port lookup plugins to global display.
10 years ago
Toshio Kuratomi
4c7128da17
Port action plugins to global display
10 years ago
Toshio Kuratomi
186e034515
Move the rest of executor code to global display
10 years ago
Toshio Kuratomi
7ecfa072da
Move the rest of the playbook code to use global display
10 years ago
Toshio Kuratomi
aa4f213cb5
Move connection plugins to using global display
10 years ago
Toshio Kuratomi
318bfbb207
Migrate cli and dependencies to use global display
10 years ago
Brian Coca
1b7d3f2898
updated submodule refs
10 years ago
Brian Coca
99f45f2e19
pass task args without filtering, copy module needs to explcitly support
...
remote_src or it will remove the src file
10 years ago
Toshio Kuratomi
c7b69127ec
Remove dead code
10 years ago
Toshio Kuratomi
e45ce871a7
Fix for traceback when neither name nor pkg are in the module params
10 years ago
Toshio Kuratomi
4737305837
Remove dead code as this was moved to another class
10 years ago
Brian Coca
be22a670e5
addes deprecated information to ansible-doc display
...
fixes #13118
10 years ago
Brian Coca
1b349fdf34
Merge pull request #13112 from privateip/eapi
...
add initial support for Arista eAPI
10 years ago
James Cammarata
566144461f
Remove internal use of display and use the top-level import
10 years ago
James Cammarata
0fc187893d
Catch import warnings in a common location for both get() and all()
...
Potential solution for #12979
10 years ago
James Cammarata
9f0c2cfda5
Merge pull request #13114 from mgedmin/fix-plugin-loader
...
Check sys.modules before loading modules
10 years ago
Marius Gedminas
54eae4a793
Check sys.modules before loading modules
...
Code for a plugin is usually loaded by a PluginLoader(), and henceforth
available from self._module_cache, which prevents duplicate loading.
However there are situations (e.g. where one action plugin imports code
from another one) where the plugin module might be already imported (and
resident in sys.modules), but not present in the PluginLoader's
_module_cache, which causes imp.load_source() to effectively reload the
module, overwriting global class declarations and causing subtle latent
bugs.
Fixes #13110 .
Fixes #12979 .
10 years ago
James Cammarata
a99f2fd52f
Save delegated vars in result for use in callback methods
...
Fixes #13014
10 years ago
Peter Sprygada
2e98f7f429
add initial support for Arista eAPI
...
This commit adds the shared module support for Arisat EOS devices
running eAPI. The shared module builds on top of module_utils/urls.py.
10 years ago
James Cammarata
e56fd9e95d
Make sure pattern cache components are converted to unicode
10 years ago
James Cammarata
0b999c602a
Properly figure subset and restrictions into host cache pattern
...
Fixes #13111
10 years ago
James Cammarata
d8fb5efa90
Merge pull request #13102 from Yannig/devel_cache_enhancement
...
New method template_no_cache for template object.
10 years ago
Yannig Perré
0c360d17cb
New parameter for template method.
...
We do not compute hash when we know that the result does not need to be cached (like with_items loop).
It also result in a small speed improvement.
10 years ago
Etherdaemon
27398131cf
Fixes #13010 by updating boto3 methods to update boto3_conn to check for profile_name and if detected, remove from params and set a new variable of profile which is passed into Session separately
10 years ago
James Cammarata
09994c18f3
Correct logic around determining environment variable existence
...
Fixes #13105
10 years ago
James Cammarata
c753ae6e22
Fixing up host pattern caching to avoid bugs
...
* Always cache and return unique list objects, so that if the list
is changed later it does not impact the cached results
* Take additional parameters and the type of the pattern into account
when building the hash string
10 years ago
James Cammarata
e8f83dcba3
Revert "Temporarily disable template caching"
...
This reverts commit 4d1757ce64 .
10 years ago
James Cammarata
4d1757ce64
Temporarily disable template caching
10 years ago
Toshio Kuratomi
995db275f8
Update submodule refs
10 years ago
Toshio Kuratomi
db5d3f03a9
Fix first_found not finding files in roles (only templates)
10 years ago
James Cammarata
ccbcfcddfc
Move where we add environment and make it conditional on not existing
...
Also displays a warning now, because users should not be using that variable
name as it causes a collision with the internal variable of the same name.
10 years ago
Brian Coca
37ae243587
made get_file_lines rely on get_file_content which deals with many error
...
conditions that the former did not.
10 years ago
ghislainbourgeois
eb850d7e5b
Fix get_dns_facts on inexistent resolv.conf
10 years ago
James Cammarata
e36b4e2a13
Merge pull request #13072 from Yannig/devel_cache_optimization
...
Cache optimization
10 years ago
James Cammarata
76ae577519
Ensure environment is inherited properly (task->block/include->play)
10 years ago
James Cammarata
937584cd52
Ensure 'environment' is set in the magic variables
...
Fixes #13033
10 years ago
James Cammarata
7e04947599
Be more selective about what variables we cache during templating
...
Fixes #13087
10 years ago
Toshio Kuratomi
1a04f354f3
For with_first_found loops, set undefined variables to fall through rather than failing the task
10 years ago
Brian Coca
240acb1924
Merge pull request #13092 from privateip/nxapi
...
initial shared module support for nxapi
10 years ago
Peter Sprygada
f88273eb87
changes the nxapi argument spec to require url_password
10 years ago
Peter Sprygada
d3d36eb766
fixes conditional statement for py24 compatibility
10 years ago
Peter Sprygada
64e139adb1
add initial support for Cisco NXAPI
...
This commit adds the shared module support for Cisco NXAPI. The shared
module builds on top of the urls shared module. The urls module provides
the http/s transport. This module only supports the JSON request message
format.
10 years ago
Rene Moser
1d59caed07
cloudstack: change order of tags handling, fixes update of tag value does not work
10 years ago
Rene Moser
3410a855b0
cloudstack: use jop polling in tag handling, fixes outdated tags returned.
...
In some cases the async job did not finish fast enough, causing returning an unexpeded result.
10 years ago
Joern Heissler
647b92a79b
Use ansible_host in synchronize module
...
Fixes #13073
10 years ago
Yannig Perré
12a6fb9633
Small speed improvement with huge inventory (100+ hosts).
10 years ago
James Cammarata
dd4ca66e1e
Make sure hostvars cache is recreated during serialization
10 years ago
James Cammarata
5040abaaf2
Merge branch 'devel_cache_for_do_template_call' of https://github.com/Yannig/ansible into Yannig-devel_cache_for_do_template_call
10 years ago
Brian Coca
9a25e16140
set corrected force default
10 years ago
Toshio Kuratomi
47f187b221
Update submodule refs
10 years ago
James Cammarata
59b67a2f68
Reset workers list when recreating processes
...
Also renames some things to be more accurate
10 years ago
Brian Coca
5b84bd6b5d
Merge pull request #13056 from alxgu/sles_sap_family
...
Add SLES_SAP as a Suse family
10 years ago
Brian Coca
226c7f4c7b
Revert "added setting of ansible_ssh_user to current user as backwards compatibilty issue"
...
scope was wrong, this var should not be 'reset' here.
This reverts commit c271c0eb04 .
10 years ago
Brian Coca
9c24f88eca
updated forks comment
10 years ago
Rene Moser
768f2fe6d4
template: fix regression bug in template in case force=false
...
Fixes regression bug, previously reported in #12844 fixed with
4b20884719 re-introduced with
c64ac90560
10 years ago
Alexander Gubin
215fc12234
Add SLES_SAP as a Suse family
10 years ago
Brian Coca
5c7d717f31
made ansibledoc more consistent with term sizes, it now uses display class column calculations
...
cleared up snippet display
10 years ago
James Cammarata
1027abd596
Cleaning up bugs related to perf improvement changes
10 years ago
James Cammarata
f10022dbd2
Fix use of add_tqm_variables
10 years ago
James Cammarata
efbc6054a4
Add variable compression option
10 years ago
James Cammarata
63c47fb271
Fixing up performance
10 years ago
Brian Coca
c64ac90560
fixed check mode change response in template
...
fixes #13049
10 years ago
Brian Coca
483c25a609
Revert "switched host patterns to use sets, simplified logic which now uses buitins"
...
need this to be lists, for order and other considerations
This reverts commit 8e2f0b3f2c .
10 years ago
Brian Coca
88ba46aee0
Revert "fixed append to add"
...
good change on top of bad
This reverts commit 699f344e17 .
10 years ago
Brian Coca
699f344e17
fixed append to add
10 years ago
Brian Coca
8e2f0b3f2c
switched host patterns to use sets, simplified logic which now uses buitins
10 years ago
Brian Coca
883f451158
fixed snippet display, short_desc is a string, not a list
10 years ago
Brian Coca
95604573ee
improved the message when there is no module path override
10 years ago
Brian Coca
f4912dd88a
added callback fallback to v1 methods for backwards compat with existing callbacks
10 years ago
Brian Coca
e2c56efca6
Merge pull request #12867 from bcoca/callback_whitelist_tweak
...
make callbacks declare needing whitelisting
10 years ago
Toshio Kuratomi
4f6d4c6bf6
Set task_action when the action does not need to be templated
...
Fixes #13042
10 years ago
Brian Coca
9753de35a7
Merge pull request #13038 from bcoca/min_forks_to_play
...
use minimal number of forks
10 years ago
Toshio Kuratomi
586cbb9fda
Update core submodule ref
10 years ago
Toshio Kuratomi
483491ddfb
template the task_action before checking whether to optimize with_item loops for it.
...
Fixes the second problem discovered in #12976
10 years ago
Toshio Kuratomi
9e758d3d97
Do not optimize with_items loop if the items are not strings
...
The code isn't sophisticated enough to understand lists and dicts yet.
This mirrors how 1.9.x handled non-string items so its not a regression.
One portion of a fix for #12976
10 years ago
Brian Coca
931eb16e55
clearer selection of min value
...
cleanup workers at each run to avoid stragglers
10 years ago
Yannig Perre
ccbdd6229a
Use static vars when computing host vars known to be static (inventory_hostname, inventory_dir etc.).
10 years ago
Yannig Perre
e0aa3ff232
Cache against hosts pattern (fix a part of problem describe in https://github.com/ansible/ansible/issues/13023 ).
10 years ago
Brian Coca
b44f1428d0
use minimal number of forks taking serial, forks and play patterns into account
10 years ago
Brian Coca
3c35655b52
removed serial as it is not avialable for fork control
...
fixes #13037
10 years ago
Brian Coca
0abeff4511
better limiting of forks to lowest actual restriction
10 years ago
nitzmahone
113c4350e3
Force SSL transport for pywinrm updates, get host+group vars
...
I PR'd a change to pywinrm to allow server certs to be ignored; but it's only on the SSL transport (which we were previously ignoring). For this to work more generally, we're also now pulling the named ansible_winrm_* args from the merged set of host/group vars, not just host_vars.
10 years ago
Lars Larsson
3289670a04
treat forks config parameter as max value instead of always creating that number of workers
10 years ago
Will Thames
91b6004149
Allow blank lines and comments/spaces in galaxy spec files
...
Fixes #10641 again. (Regression)
Added test to discourage future such regression.
10 years ago
Toshio Kuratomi
07d0d2720c
Update submodule refs
10 years ago
Toshio Kuratomi
9ce3adbeb1
remove assigned but unused variables in module_utils.
...
These were mostly saving exceptions but not using them. Getting rid of
those will help with eventually running modules via either python2.4 or
python3.x.
10 years ago
Toshio Kuratomi
c08648999d
Remove some more unused stdlib deps.
10 years ago
Toshio Kuratomi
658ea053ea
Cleanup timer callback plugin's overwriting of modules it imported
10 years ago
Eric Johnson
dfad7c64fb
Allow PATCH to list of valid HTTP methods
10 years ago
Brian Coca
8d3da20302
fixed bsd service_mgr_facts using removed check_init fucntion
10 years ago
Yannig Perré
30f827d92d
Fix python3 test.
10 years ago
Abhijit Menon-Sen
7caefa5cd9
Fix typo
10 years ago
Toshio Kuratomi
a7d1a39b81
Update core submodule ref
10 years ago
Toshio Kuratomi
2df0022a3e
Update submodule refs
10 years ago
Brian Coca
eb04650ffb
Merge pull request #12162 from bcoca/service_mgr_facts
...
fact gathering service_mgr info
10 years ago
Brian Coca
a1a5dadef6
remove uneeded module
10 years ago
Yannig Perré
130139dc80
Fix unicode issue introduced by previous commit.
10 years ago
Toshio Kuratomi
3219744d32
One more stdlib import in module_utils
10 years ago
Brian Coca
d194e2c788
check_systemd is not inline but a private fact function now
10 years ago
Brian Coca
e9efd008ed
moved distutils import to mac, darn solaris would complain in certain cases
10 years ago
Brian Coca
99d775a0c1
fact gathering service_mgr info
...
also added dragonfly facts support
10 years ago
Yannig Perré
4a8d1703d4
New patch against hostvars.py. With this patch, Ansible run lose 50% of time.
...
Little rewrite of previous patch to use sha1 signature.
Use fail_on_undefined to compute sha1 signature.
10 years ago
Toshio Kuratomi
1bc75374dc
Add imports for stdlib modules that are used.
...
This is cleanup that will aid us when we get ziploader implemented for 2.1
10 years ago
Toshio Kuratomi
107d025d8a
Update extras submodule ref for doc fixes
10 years ago
Toshio Kuratomi
99561e88d4
Update submodule refs
10 years ago
Brian Coca
79bf66336b
switched clean_data from hardcoded delimiters to actual currently set jinja2 environment delimiters
10 years ago
Yannig Perré
805f768dab
Clear cache when updating template variables.
10 years ago
Brian Coca
467c29e3db
show task path on 2 vs
10 years ago
Yannig Perré
87a9485b2f
Cache for _do_template call. May result in nice speed improvement (4-5 times faster).
10 years ago
Rene Moser
c09a34bb10
cloudstack: clean up unneeded ";"
10 years ago
Brian Coca
f528ad1848
added xbps pkg mgr to facts
10 years ago
Brian Coca
13bf62d0e6
remove deprecation for :, add ; functionality (its deprecated but it should work)
10 years ago
Brian Coca
d341ba14a5
fixed rekey password handling
10 years ago
Brian Coca
00bc74404a
vault noe preserves permissions on edit and rekey and sets a restricitve default umask for all other cases
10 years ago
Brian Coca
7368030651
removed action plugin as service facts and separate modules don't work yet and this forces gathering facts
10 years ago
Brian Coca
f5b095f6c8
properly sanitize registered vars
10 years ago
Brian Coca
b6c92dacb5
removed key striping as they are read up the chain
10 years ago
Brian Coca
57d3245d0d
remove commented out prints
10 years ago
Brian Coca
7ba4f5ee12
removed no_log redundant code
10 years ago
Brian Coca
b97887ba41
simplified invocation removal, added no_log awareness
10 years ago
James Cammarata
c61499168e
Merge pull request #12962 from bcoca/pull_fixes
...
fixes options for ansible pull
10 years ago
James Cammarata
56e5e72aaa
Make handlers obey run_once (or BYPASS_HOST_LOOP)
...
Fixes #12972
10 years ago
James Cammarata
a5bd92ca4b
Merge branch 'devel_fix_debug_var' of https://github.com/Yannig/ansible into Yannig-devel_fix_debug_var
10 years ago
Brian Coca
237f8c9df7
removed debug print
10 years ago
James Cammarata
479cbfc63c
Don't immediately fail on PlayContext setup
...
As we may end up skipping the task due to conditionals.
Fixes #12774
10 years ago
Brian Coca
9f148fc046
removed requirement of destination and set documented default
10 years ago
Brian Coca
40d22be2ef
fixes options for ansible pull
...
* remove requirement for host patterns, use the defaults
* require destination directory (None in cwd is not a good default)
* fixed usage messages
* updated default inventory to use , and not deprecated :
10 years ago
Brian Coca
b73941b95f
updated submodule refs
10 years ago
Toshio Kuratomi
508bffef02
Update extras submodule ref
10 years ago
Brian Coca
b8bc15fe02
switched to backticks to allow for non bourne shells to work
10 years ago
Yannig Perré
1febf7cb88
Fix for issue #12952 : this code interfere with debug+var and seems to be unnecessary.
10 years ago
James Cammarata
5d92b00d9c
Cleanup some include logic
...
* Properly mark hosts with failures in includes as failed
* Don't send callbacks until we're sure we're done, and also fix how
we increment stats so failures don't show up as ok's
* Fix a bug in the include file logic where a failed include could lead
to an infinite loop in the task iteration logic
Fixes #12933
10 years ago
Toshio Kuratomi
56b310b18d
Update submodule refs
10 years ago
James Cammarata
299054852a
Allow tags to be specified in included file params
...
Fixes #12940
10 years ago
Brian Coca
b2fc5142eb
moved sudo -S and -n into configurable flags as they might be absent in much older systems
...
if password is supplied exsiting -n would get remove from flags
10 years ago
Toshio Kuratomi
e3e2db1119
Improve the warning message about duplicate yaml dict keys
10 years ago
James Cammarata
87269599a0
Also consider the full role name when searching for --start-at-task
10 years ago
Toshio Kuratomi
acbea65b1d
Update core submodule ref to fix doc build
10 years ago
Toshio Kuratomi
2c5da0923a
Update submodule refs
10 years ago
Toshio Kuratomi
7334389de6
Merge pull request #12930 from ansible/dict-key-overwrite-warning
...
Break apart a looped dependency to show a warning when parsing playbooks
10 years ago
Toshio Kuratomi
4203850d1a
Break apart a looped dependency to show a warning when parsing playbooks
...
Display a warning when a dict key is overwritten by pyyaml
Fixes #12888
10 years ago
James Cammarata
3fc2209ca0
Fixing retry/until logic and default value for retries
...
Fixes #12928
Fixes #12929
10 years ago
James Cammarata
57fe0d6aed
Merge pull request #12911 from bcoca/manpage_fixes
...
Manpage fixes
10 years ago
James Cammarata
1dc23ea779
Merge pull request #12866 from bcoca/more_inheritence
...
More inheritence
10 years ago
James Cammarata
cace91df56
Allow hostvars cache to be invalidated so hostvars contain all hosts after add_host
...
Fixes #12925
10 years ago
James Cammarata
2825c188bd
Merge pull request #12901 from bcoca/sanitize_results
...
sanatize results
10 years ago
Jason O'Donnell
9dfa3719be
Fixing typo
10 years ago
Jason O'Donnell
ac9b35cc2b
Found another typo
10 years ago
Jason O'Donnell
80433c2a2d
Fxing typo
10 years ago
Toshio Kuratomi
de54f26376
Update submodule refs
10 years ago
Brian Coca
c271c0eb04
added setting of ansible_ssh_user to current user as backwards compatibilty issue
10 years ago
Brian Coca
4486e136ea
Merge pull request #12899 from bcoca/vault_fixes
...
simplified vault password functions
10 years ago
Brian Coca
5b33b0ddfd
Merge pull request #12896 from bcoca/ssh_current_user_config
...
don't set user to current user
10 years ago
James Cammarata
677a2f95e5
Make sure Base attributes are copied cleanly
...
Fixes #12882
10 years ago
Toshio Kuratomi
8f77dd1cf2
Update submodule refs
10 years ago
Brian Coca
f3a0adcfa5
added info about using -i 'hostname,' to usage/help
10 years ago
Bernhard Lichtinger
00ccd2ee6e
Fix for SLES 11.4, which has now also an /etc/os-release file.
10 years ago
Brian Coca
7ebfe72015
added missing string_types
10 years ago
Brian Coca
8ce864db6f
sanatize results
10 years ago
Brian Coca
368f4448dc
simplified vault password functions
...
also fixes #12864
10 years ago
Toshio Kuratomi
92dd563a75
Fix invocation from bad merge and note where it would need to go to keep
...
it out of registered vars as well.
10 years ago
Brian Coca
f78c82b9ee
don't set user to current user
...
also remove condition to bypass setting user if user matches current user
this enables forcing user when set to the same user as current user and ignoring .ssh/config
while keeping .ssh/config with current user if nothing is specified.
10 years ago
Brian Coca
25e3fe04a8
finalized changed to use abridtged_result instead of result
...
removed no longer defined no_log
10 years ago
Toshio Kuratomi
b109b83809
Update submodule refs
10 years ago
Toshio Kuratomi
ca32d5bacc
Potential fix for #12816
10 years ago
James Cammarata
3eea4e23d5
Manually add plugin directories when running the adhoc command
...
Fixes #12891
10 years ago
Toshio Kuratomi
3812ec8d1d
Implement invocation hiding for all callbacks if the verbosity is low
10 years ago
Brian Coca
275764d4a5
avoid showing invokation when no_log is set or verbosity is low
10 years ago
James Cammarata
63ea614b4c
Version bump for 2.0.0-0.4.beta2
10 years ago
Toshio Kuratomi
99c6f77e59
Fix callback
10 years ago
Jens Peter Schroer
ecae636160
allowing json in lookup template calls
10 years ago
James Cammarata
4fd4f3374a
Merge pull request #12879 from larsks/bug/12876
...
allow include: directive to work during exception processing
10 years ago
Lars Kellogg-Stedman
914f68f9af
allow include: directive to work during exception processing
...
prior to this commit, an attempt to use the `include:` directive would
fail in a `rescue:` or `always:` block if there were failures in the
main block task list.
Resolves #12876 .
10 years ago
Toshio Kuratomi
ce2b18174e
Merge pull request #12878 from ansible/invocation-fix
...
Invocation fix
10 years ago
Toshio Kuratomi
2e87c1f74e
Two fixes to action plugins
...
* Fix the task_vars parameter to not default to a mutable type (dict)
* Implement invocation in the base class's run() method have each action
module call the run() method's implemention in the base class.
* Return values from the action plugins' run() method takes the return
value from the base class run() method into account so that invocation
makes its way to the output.
Fixes #12869
10 years ago
Brian Coca
5017a96948
Revert "make callbacks declare needing whitelisting"
...
another premature merge
This reverts commit df8ff85787 .
10 years ago
James Cammarata
86de1429e5
Cleaning up FIXMEs
10 years ago
Toshio Kuratomi
1e50d31cdc
Update submodule refs
10 years ago
Brian Coca
df8ff85787
make callbacks declare needing whitelisting
...
this will allow for custom or v1 callbacks locally loaded to automatically be triggered as they were in 1.x
10 years ago
Toshio Kuratomi
75cff7129c
Fix for invocation not being added to output.
...
We want invocation to be omitted when we are running async, not when we
aren't running async.
10 years ago
Toshio Kuratomi
6b6d03290a
Restore the automatic addition of invocation to the output
...
Revert "Remove auto-added invocation return value as it is not used by v2 and could leak sensitive data."
This reverts commit 6ce6b20268 .
Remove the note that invocation was removed as we've now restored it.
Revert "keyword not in ubuntu 14.04"
This reverts commit 5c01622457 .
Revert "remove invocation keyword check"
This reverts commit 5177cb3f74 .
10 years ago
James Cammarata
498c27d09a
Re-adding role_names magic variable
...
Fixes #12863
10 years ago
Brian Coca
c267c23020
make callbacks declare needing whitelisting
...
this will allow for custom or v1 callbacks locally loaded to automatically be triggered as they were in 1.x
10 years ago
Brian Coca
54e821ca94
added deprecation warning to comma separated role spec
10 years ago
Brian Coca
09899b7c43
Merge pull request #12783 from larsks/bug/12782
...
correct value of remote_user for local connections
10 years ago
Brian Coca
9886829e40
Merge pull request #12861 from willthames/galaxy_spec_in_meta_main_fix
...
Allow meta/main.yml to include roles through spec file
10 years ago
Brian Coca
d861e7dd5d
moved several directives so they are not settable at play, block, role and task levels
10 years ago
Brian Coca
fc3a44485b
skip errors on conditional if task is include
...
fixes #12843
10 years ago
Will Thames
002972c6cf
Allow meta/main.yml to include roles through spec file
...
ansible-playbook now works when run with a playbook
that includes a role that includes another role
specified using csv format
Updated one of the roles used in the tests to fix
broken tests - `make test_galaxy` now works
Fixes #11486 . Also addresses the problem alluded to in #10620 .
10 years ago
Brian Coca
08c9e70307
made display part of variable manager and corrected reference to it
...
fixes #12859
10 years ago
James Cammarata
2b3c5aa41e
Support cmd param in Tasks by assigning it to _raw_params
...
Fixes #12856
10 years ago
James Cammarata
0e447e3f41
Merge branch 'devel' of https://github.com/mathieumd/ansible into mathieumd-devel
10 years ago
James Cammarata
4b20884719
Return correct changed flag when using check mode with template and force=no
...
Fixes #12844
10 years ago
Brian Coca
04aa7701d1
fix prompt, static methods don't get 'self'
...
fixes #12833
10 years ago
Toshio Kuratomi
42ce3de8d0
Merge pull request #12853 from ansible/winrm-return-bytes
...
In v2, exec_command should return bytes and the caller will take responsibility for converting to unicode
10 years ago
Toshio Kuratomi
3d57a202b5
And another fix for docs
10 years ago
Toshio Kuratomi
9dc9a606f6
Correct docs build
10 years ago
Toshio Kuratomi
632d356d22
Update submodule refs
10 years ago
Toshio Kuratomi
6e5055e786
Update the use of no_log values to cover everything that heuristic_log_sanitize does.
...
Fixes #12792
10 years ago
James Cammarata
ec56b29ba4
Fix setting of interpreter values for delegated hosts
...
Fixes #12772
10 years ago
Toshio Kuratomi
c845181dc1
In v2, exec_command should return bytes and the caller will take responsibility for converting to unicode
10 years ago
gduke
744679601f
Remove mutable default arguments.
10 years ago
Toshio Kuratomi
10e2fc6f60
Update submodule ref
10 years ago
Toshio Kuratomi
1126ce34e3
Merge pull request #12846 from ansible/nolog-for-return-value
...
Hide values in json returns which were given in parameters marked no_log.
10 years ago
Toshio Kuratomi
c2d188baff
Hide values in json returns which were given in parameters marked no_log.
10 years ago
James Cammarata
3ddda2f460
Merge pull request #12842 from mcsalgado/include_with_items
...
Revert back to copying self._task.args
10 years ago
Brian Coca
1ecad5aed2
now galaxy correctly detects empty requirements file
...
also allow for 'scm' and 'src' not to be populated in requirements entries
10 years ago
Victor Salgado
c5c5f3bf7a
Revert back to copying self._task.args
10 years ago
Victor Salgado
0e671baa33
Fix typo
10 years ago
James Cammarata
b46ce47a84
Don't use local transport for delegated hosts if the inventory_hostname isn't local
...
For some situations like Vagrant, the remote_addr may be a localhost addr, but ssh
is still desired. This corrects the assumption that any localhost remote_addr should
be using the local connection by checking the inventory_hostname value as well.
Fixes #12817
10 years ago
Toshio Kuratomi
99e7bb35c1
Simplify UnsafeProxy as we don't need to use it for byte strings, only text
10 years ago
James Cammarata
3c87c44af5
Fixing bug in includes caused by 892d9b8
...
Fixes #12837
10 years ago
Toshio Kuratomi
31ebafcbdd
Update submodule refs
10 years ago
Toshio Kuratomi
f34b55ac2b
Add python3-compat boilerplate to all .py files in lib/ansible
10 years ago
Brian Coca
de3ca57a33
avoid relative shlex import
...
fixes #12777
10 years ago
James Cammarata
e5b6d802bf
Removing some cruft related to _local_action value on Task, which was removed
...
Fixes #12819
10 years ago
Mathieu
260a3e5ce7
Fixes #11055 - Set locale via LC_ALL
10 years ago
Toshio Kuratomi
923fc9fb15
Cleanup pyflakes warning (real error)
10 years ago
Toshio Kuratomi
7aa9f6754a
Cleanup more pyflakes warnings (2 real problems)
10 years ago
James Cammarata
1fa975d81a
Simplify group_by by removing BYPASS_HOST_LOOP from the action
...
Fixes #12825
10 years ago
Toshio Kuratomi
0888d78b84
Cleanup some pyflakes warning (1 real error)
10 years ago
Toshio Kuratomi
c6d44738ad
Clean up some more pyflakes warnings
10 years ago
Toshio Kuratomi
3da8bab3ff
Cleanup pyflakes warning (real error)
10 years ago
Toshio Kuratomi
a526eae543
Clean up a few more pyflakes warnings
10 years ago
Toshio Kuratomi
a17ae6f07e
Clean up pyflakes warnings in inventory
10 years ago
James Cammarata
892d9b8dfb
Move post_validate for tasks after checking for an include
...
Simplifies logic and prevents us from accidentally post_validating
an include that would otherwise be skipped due to tags causing a
problem because of potentially missing variables.
Fixes #12793
10 years ago
James Cammarata
1cfd941179
Adding a v2 callback for task includes
10 years ago
Toshio Kuratomi
dc33d30c6d
Update submodule refs
10 years ago
Toshio Kuratomi
b67e51ea06
Information on when to use to_str() and what a native string is
10 years ago
Toshio Kuratomi
39d9bc3564
Update submodule refs
10 years ago
Toshio Kuratomi
6ce6b20268
Remove auto-added invocation return value as it is not used by v2 and could leak sensitive data.
10 years ago
Brian Coca
1280e2296c
changed warning to debug and expanded info on what is really happening, it was a bit misleading
10 years ago
Brian Coca
2d1d21228a
updated skippy to match default output
10 years ago
James Cammarata
0bbe9d5bd0
Make hostvars json/yaml serializable in filters
...
Fixes #12615
10 years ago
James Cammarata
a88c59f451
Reset basedir for plays that are not from a PlaybookInclude
...
Fixes #12524 (again)
10 years ago
James Cammarata
0aa018337a
Fixing logic in json cache plugin get()
...
Fixes #12722
10 years ago
James Cammarata
5f617c601b
Remove obsolute tag evaluation in free strategy
...
Fixes #12784
10 years ago
Brian Coca
6c8cf8acb7
now profile_tasks callback handles handlers correctly
...
fixes #12762
10 years ago
James Cammarata
1ab0e0e228
Disable RuntimeWarnings during all() plugin loading
...
Fixes #12778
10 years ago
Brian Coca
71ffb86c30
don't let cowsay issues stop execution
...
fixes #12773
10 years ago
Brian Coca
6d87bd405d
Merge pull request #12765 from bcoca/lookup_inventory_hostname
...
implemented inventory_hostname lookup in v2
10 years ago
Toshio Kuratomi
a567f28657
Update submodules for docs fixes# Please enter the commit message for your changes. Lines starting
10 years ago
Toshio Kuratomi
5d8ab9b01b
Update module refs
10 years ago
Toshio Kuratomi
b23a083776
Make vault use a mapping of cipher name to classes instead of formatting the name for safety.
10 years ago
Toshio Kuratomi
baa309309d
Bundle a new version of python-six for compatibility along with some code to make it easy for distributions to override the bunndled copy if they have a new enough version.
10 years ago
Lars Kellogg-Stedman
aa0b7536c9
correct value of remote_user for local connections
...
When using 'local' connections, privilege escalation would fail if
ansible_ssh_user was in the current context to the same value as
become_user.
This commit ensures that for 'local' connections we reset remote_user to
the local username.
This fixes #12782 .
10 years ago
Toshio Kuratomi
28c933ce5e
properly fail_json when we don't have ssl on a non-redhat distro
10 years ago
Marius Gedminas
98958ec990
Simplify join expression
10 years ago
Marius Gedminas
56184a3d8c
Python 3: avoid %-formatting of byte strings
...
This is needed for Python 3.4 compatibility; Python 3.5 can use
`b'%s\n' bytestring` again.
10 years ago
Brian Coca
9b088a1e40
implemented inventory_hostname lookup in v2
10 years ago
Brian Coca
aee6de5a76
group_names should not include implied 'all', fixes #12763
10 years ago
James Cammarata
dce58a78c9
Make random cowsay truly random
...
Also adds a cowsay whitelist config option, because there are some
truly NSFW stencils that come with cowsay by default.
10 years ago
Marius Gedminas
4fb6f62f1b
Fix Unexpected Exception: global name 'os' is not defined
...
I inadvertently introduced it in
ca826508d9 and didn't notice, because
there are no unit tests for playbook_executor.py. Sorry!
(The "from ansible.errors import *" was used *only* to get the 'os'
module, which makes go "what?")
10 years ago
Marius Gedminas
ab569cea22
Move to_str alias into ansible.utils.unicode
...
@abadger suggested on IRC that it's useful enough to go into
ansible.utils.unicode.
10 years ago
Marius Gedminas
ca826508d9
Python 3: fix AnsibleError formatting
...
If you convert the error string to bytes and embed it inside another
error string, you get
Prefix:
b'Embedded\nerror\nstring'
which is not what we want.
But we also don't want Unicode in error messages causing unexpected
UnicodeEncodeErrors when on Python 2.
So let's convert the error message into the native string type (bytes on
Python 2, unicode on Python 3).
10 years ago
Toshio Kuratomi
5617f6aad4
Update synchronize to use the correct host when delegating
...
Fixes #12752
10 years ago
Toshio Kuratomi
85abd61001
Add some more info to docstring
10 years ago
James Cammarata
d923d05a33
Reworking the way all() works in plugin_loader
...
* Don't throw away the full path of the module code being loaded,
as this can cause conflicts when files of the same name are being
instantiated
* Generalize the module loading code
Fixes #12738
10 years ago
James Cammarata
45b803efb4
Properly use test_loader from SharedPluginLoaderObj
10 years ago
Toshio Kuratomi
c8ad55103e
Update extras modules ref to fix docs
10 years ago
Toshio Kuratomi
e00eeba9c3
Update submodule refs
10 years ago
James Cammarata
91b0b4d40c
Check is_directory() before not is_file() in inventory basedir
...
Fixes #12742
10 years ago
Brian Coca
c57200925f
made syslog import optional as intel's edison custom compiles python w/o it
10 years ago
James Cammarata
ee559e03f7
Merge pull request #12725 from mgedmin/py3k
...
Python 3: there's no basestring
10 years ago
James Cammarata
e6d3c6745f
Revert to using local file/dir tests in inventory instead of loader's
...
Fixes #12719
10 years ago
Brian Coca
c637d60a8d
fixed deprecation message
10 years ago
Brian Coca
f5227d494b
added missing cachefile and changed str(e) to to_bytes(e)
10 years ago
Marius Gedminas
9ba6c087d3
Python 3: there's no basestring
10 years ago
Marius Gedminas
f03da5be42
Python 3: there's no iteritems()
10 years ago
James Cammarata
2d77c643e4
Merge pull request #12723 from mgedmin/py3k
...
Make ansible.vars.unsafe_proxy Python 3 friendly
10 years ago
Marius Gedminas
e511d6d458
Make UnsafeProxy work on Python 3
...
Instead of str and unicode we have to deal with bytes and str.
10 years ago
Marius Gedminas
af6a316d9b
Remove unused import
...
Fixes ImportError: No module named '__builtin__' on Python 3.
10 years ago
James Cammarata
426187489f
Add variable for format parameter
10 years ago
Toshio Kuratomi
8277747a04
Fix password lookup when password file exists and the password is not encrypted
10 years ago
James Cammarata
cd2cb178ae
Totally rework the way UnsafeProxy does things
10 years ago
Toshio Kuratomi
15d7f53846
AnsibleModules.log() fix for python3
...
Also add unittests for AnsibleModules.log()
Fixes #12586
10 years ago
Toshio Kuratomi
b49e0995cb
Fix typo
10 years ago
Toshio Kuratomi
b58d7470d4
Cleanup logic and be more paranoid about passwords with spaces
10 years ago
James Cammarata
5c5806d669
Fixing bugs related to jfonfile cache plugin
...
* corrupt/invalid file causes tracebacks
* incorrect initialization of display/_display in BaseCacheModule class
* tweaking the way errors in get() on jsonfile caches work, to raise
a proper AnsibleError in that situation so the playbook/task is stopped
Fixes #12708
10 years ago
Toshio Kuratomi
b441bcb678
Fix display when run through a testing framework that overrides stderr/stdout
10 years ago
James Cammarata
d15fcf05f0
Fix bug in the way temp vars were created for templating vars_files
...
Fixes #12711
10 years ago
Brian Coca
f5f3bf06e4
Merge pull request #12550 from redrampage/remove-pw-salt-deletion
...
Removed deletion of salt by 'password' lookup
10 years ago
James Cammarata
73661d1761
Merge branch 'devel' of https://github.com/ansible/ansible into devel
10 years ago
Charles Paul
3d533cb423
fixing calls to fail_json
10 years ago
Brian Coca
50372eecc9
Merge pull request #12455 from privateip/devel
...
added methods for retrieving vapp and vm
10 years ago
James Cammarata
82e76e42e5
Tweak to the way serial percentages are handled
10 years ago
James Cammarata
63e288354e
Fix bug in way omitted values were set
10 years ago
James Cammarata
4c85ae0712
Merge branch 'serial_should_be_string' of https://github.com/klshxsh/ansible into klshxsh-serial_should_be_string
10 years ago
klshxsh
ac00c9ced7
changed 'string' to 'percent' for _serial
...
Note that this allows both integers (e.g. 3) and percentages (e.g. "30%")
Also changed default back to 0 rather than '0'
10 years ago
James Cammarata
eb60ce1b6e
Merge pull request #12703 from keitwb/inventory_file_var
...
Adding the inventory_file var back
10 years ago
James Cammarata
71a1a3c903
Submodule pointer update
10 years ago
Ben Keith
1f82971283
Adding the inventory_file var back
10 years ago
Toshio Kuratomi
45a161b0a1
Merge pull request #12429 from edmstudio/devel
...
Update synchronize module plugin to work on OS X
10 years ago
Petr Mifek
6e035a3e94
Move nested function test for ipv6 to top level in synchronize module.
10 years ago
Brian Coca
45788fbfad
<homer>doh!</homer>
10 years ago
Brian Coca
d24532757c
remove fix for local_action/connection local that is now not needed
10 years ago
klshxsh
4a5e52b2d2
The serial keyword can be specified as a percentage, e.g '30%' or a number e.g. '3'; therefore it needs to be a string to allow both types
10 years ago
Brian Coca
b9d54e9a01
corrects previous fix to deal with missing item key in results dict
10 years ago
Brian Coca
abf2e13955
Revert "Track local_action internally to prevent it from being overridden"
...
This reverts commit 49ca0eb797 .
10 years ago
Brian Coca
101c8785ec
removed changes to make local action equate connection=local and brought it back to equate delegate_to=localhost
10 years ago
Brian Coca
bcb173996b
Merge pull request #12695 from matburt/fix_cache_plugins_for_v2
...
Fix an issue where cache plugins weren't updated in certain scenarios
10 years ago
Brian Coca
fbf4cafab5
on skipped you 'might' not have an item, changed to getattr to avoid keyerror
...
fixes #12683
10 years ago
Matthew Jones
7da478a4f4
Fix an issue where cache plugins weren't updated
...
The first call to persisting facts would work due to the assignment of a
MutableMapping calling __setitem__ but subsequent module fact data would
not be propogated to the fact cache plugins because update() doesn't
invoke __setitem__. This changes the behavior a little bit and ensures
set() is called on cache plugins.
10 years ago
Brian Coca
ec02b255c3
Merge pull request #12689 from soarpenguin/bugfix
...
Remove some warning of undefined name and fix classmethod syntax error.
10 years ago
James Cammarata
770032648a
Show -> localhost for local_action tasks
10 years ago
James Cammarata
f415d39dfd
Merge pull request #12690 from stelligent/devel
...
Use AWS_DEFAULT_REGION env var if none specified
10 years ago
James Cammarata
cfa62e7a2a
Submodule pointer update
10 years ago
James Cammarata
868819f9fa
Make sure shlex split is returning properly encoded strings
...
Fixes #12676
10 years ago
Shayne Clausson
55b3f9e4e5
Use AWS_DEFAULT_REGION env var if none specified
10 years ago
soarpenguin
b11ea17385
fix classmethod syntax error.
10 years ago
soarpenguin
5efa4d29e3
fix some warning of undefined name.
10 years ago
James Cammarata
59d655c543
Double echo temp directory name to handle spaces and ~ expansion both
...
Fixes #12667
10 years ago
Toshio Kuratomi
d1b98ec776
Correct typo
10 years ago
Toshio Kuratomi
2f5e817007
Do not mix byte str with unicode type
10 years ago
Toshio Kuratomi
01ba2e94c0
Wait until later to convert to byte strings for output
...
Also some pre-emptive python3 compat and a code simplification
10 years ago
Brian Coca
76feba00c4
avoid callbacks during syntax check and listing
...
fixes #12682
10 years ago
Brian Coca
4463ced8ba
simpler safe output
10 years ago
James Cammarata
de792ba3c2
Improve handling of unicode errors
...
Fixes #12669
10 years ago
James Cammarata
5a0f5f1254
Load vars for localhost when created implicitly
...
Fixes #12666
10 years ago
Brian Coca
d8769c93c7
updated ec2 region description to add missing other env var
10 years ago
Brian Coca
c77733e64e
added docs for commonly used region parameter in some ec2 modules
10 years ago
Brian Coca
638bc14566
now deps is always a list
10 years ago
George Sudarkoff
fa332e1342
Fail if the vault password script returns non-zero.
10 years ago
Brian Coca
dac3684fd1
changed task color to dark gray to keep it from being confused with ignore/skip
10 years ago
Brian Coca
c459dd4e18
Merge pull request #12663 from Juraci/task-path
...
Displays the absolute path of a given task when verbosity is above level 3
10 years ago
James Cammarata
dbae110f6f
Merge pull request #12660 from apollo13/fix_galaxy_init
...
Show a nice error if the role name is missing.
10 years ago
Juraci
e52950a939
Displaying task_path on task start when verbosity is more than 3
10 years ago
Juraci
254d6be520
Adding get_path method to Task class
10 years ago
Florian Apolloner
354383874f
Show a nice error if the role name is missing.
10 years ago
=
345ce424c6
Explictly set the version of strict mode to use for powershell modules.
10 years ago
James Cammarata
9e364c2eb5
Don't modify results in callbacks
...
Fixes #12654
10 years ago
James Cammarata
8107c4efc7
Fixing a bug in galaxy parsing of text spec file lines
10 years ago
James Cammarata
7a815b7296
Force connection to local when localhost is delegated to
10 years ago
Toshio Kuratomi
97e8d25eb4
Fix for encoding errors when a command returns non-utf8 encoded values
10 years ago
Toshio Kuratomi
4f6f2c21e8
range vs xrange doesn't matter here and six.moves.range isn't available in six-1.3.0 (rhel7)
10 years ago
James Cammarata
5ae74f7d38
Version bump for 2.0.0-0.3.beta1
10 years ago
James Cammarata
d9b79b1bbc
Also template the role name when loading roles
...
Fixes #12602
10 years ago
James Cammarata
9c9897805f
More ansible-galaxy fixes for the old spec file format
10 years ago
James Cammarata
fb822a4305
Merge pull request #12637 from rcleere/rekey_fix
...
Fix ansible-vault rekey
10 years ago
James Cammarata
3b8eaf6128
Cleaning up some ansible-galaxy stuff
10 years ago
Ryan Cleere
0400ab8c0f
Fix ansible-vault rekey
10 years ago
James Cammarata
d91b3c6b9d
Make sure magic variables are available when templating vars_files
...
Also does some reorganization/cleanup on the magic vars/delegated
variable generation portions of VariableManager to make the above
possible.
Fixes #12633
10 years ago
James Cammarata
284bd118a0
Properly switch to the default transport when delegating from localhost
10 years ago
Brian Coca
6f88f79de9
removed dupe install code, now trap errors forom role.install
10 years ago
Brian Coca
f73329401b
galaxy updates
...
better error reporting on fetching errors
use scm if it exists over src
unified functions in requirements
simplified logic
added verbose to tests
cleanup code refs, unused options and dead code
moved get_opt to base class
fixes #11920
fixes #12612
fixes #10454
10 years ago
Brian Coca
a3ed9fc131
updated to 'fixed' get_url so docs build again
10 years ago
Brian Coca
f3d0468726
updated submodule refs
10 years ago
James Cammarata
323012be2e
Pop tags out of playbook include params
...
Fixes #12605
10 years ago
Toshio Kuratomi
10a4a4e986
Quote any file paths that we have to use with dd to copy.
...
This is because we pass the whole dd command string into the shell
that's running on the contained environment rather than running it
directly from python via subprocess without a shell.
10 years ago
Toshio Kuratomi
b83988d9fb
Port libvirt_lxc connection plugin to v2
10 years ago
Toshio Kuratomi
567deb5ac2
Add explicit substitution of relative paths on the remote host just in case the connection programs do something unexpected.
10 years ago
Brian Coca
8528b20702
fixed usage text
10 years ago
Brian Coca
04a2b221b9
removed conflicting short options
10 years ago
James Cammarata
38528c8ef3
Show more info in the minimal callback for unreachable hosts
...
Fixes #12621
10 years ago
Toshio Kuratomi
613e87db6c
FIx typo arg_path (not plural)
10 years ago
Brian Coca
4ba5ebd1c8
Merge pull request #12538 from yesbox/url_lookup_plugin_httperror_fix
...
Fix url lookup plugin HTTPError message not being reachable
10 years ago
Peter Sprygada
ab3239ecd7
added methods for retrieving vapp and vm
10 years ago
Toshio Kuratomi
10750214ea
Since Connection.execute_command() returns bytes, deal with the repurcussions here.
10 years ago
Brian Coca
e2ae3215f6
corrected no_log for items and skipped tasks
...
corrected output from default callback
added new tests for no_log loops
updated makefile test to check for both positive and negative occurrences of no_log
10 years ago
James Cammarata
c28758d2a8
Merge branch 'ssh-args' of https://github.com/amenonsen/ansible into amenonsen-ssh-args
10 years ago
James Cammarata
82faba619e
Also add args_path param to powershell shell plugin
10 years ago
James Cammarata
30d481ac57
Fix old-style (non-python) module support
10 years ago
Toshio Kuratomi
e40e08d799
Update core sumodule ref to fix docs
10 years ago
Abhijit Menon-Sen
b127221f50
Pass default None to getattr, remove repeated call
10 years ago
Abhijit Menon-Sen
96c4dc273a
Set explicit default for ANSIBLE_SSH_ARGS
...
The earlier code behaved exactly as though this default had been set,
but it was actually handled as a(n unnecessary) special case inside the
connection plugin, rather than set as an explicit default.
If the default is overriden either in ansible.cfg or the environment,
the new code will continue to work (in fact, it won't know or care,
since it just uses the value set in the PlayContext).
This is submitted as a separate commit for easier review to address
backwards-compatibility concerns.
10 years ago
Abhijit Menon-Sen
1981bf2b95
Aggregate ssh arguments in PlayContext instead of the connection plugin
...
Using set_host_overrides() in the connection plugin to access the ssh
argument variables from the inventory didn't see group_vars/host_vars
settings, as noted earlier. Instead, we can set the correct values in
the PlayContext, which has access to all command-line options, task
settings, and variables.
The only downside of doing so is that the source of the settings is no
longer available in ssh.py, and therefore can't be logged. But the code
is simpler, and it actually works.
This change was suggested by @jimi-c in response to the FIXME in the
earlier commit.
10 years ago
Abhijit Menon-Sen
3ad9b4cba6
Rework additional ssh argument handling
...
Now we have the following ways to set additional arguments:
1. [ssh_connection]ssh_args in ansible.cfg: global setting, prepended to
every command line for ssh/scp/sftp. Overrides default ControlPersist
settings.
2. ansible_ssh_common_args inventory variable. Appended to every command
line for ssh/scp/sftp. Used in addition to ssh_args, if set above, or
the default settings.
3. ansible_{sftp,scp,ssh}_extra_args inventory variables. Appended to
every command line for the relevant binary only. Used in addition to
#1 and #2 , if set above, or the default settings.
3. Using the --ssh-common-args or --{sftp,scp,ssh}-extra-args command
line options (which are overriden by #2 and #3 above).
This preserves backwards compatibility (for ssh_args in ansible.cfg),
but also permits global settings (e.g. ProxyCommand via _common_args) or
ssh-specific options (e.g. -R via ssh_extra_args).
Fixes #12576
10 years ago
Toshio Kuratomi
f13d5201b8
Update module refs
10 years ago
Brian Coca
4c9f58a152
added no_log censoring to item output
...
should be last commit that fixes #12214
10 years ago
Brian Coca
ba4afcbbb6
added no_log to results
...
normalized outputs to use display class
cleaned up unused imports
10 years ago
Brian Coca
c27bd4fab0
{sudo,su}_user does not imply become
10 years ago
James Cammarata
57372906aa
Pull host/group vars when adding hosts/groups
...
Fixes #12582
10 years ago
James Cammarata
aa3687d736
Fix syntax error for octal in encrypt methods
10 years ago
James Cammarata
538568305a
Submodule pointer update for accelerate module fixes
10 years ago
James Cammarata
8ef78b1cf8
Fixing accelerated connection plugin
10 years ago
Brian Coca
3705d54485
fixed error reporting on splitter
10 years ago
Brian Coca
de2f62bd9e
fixed error reporting for unkown become user
10 years ago
Brian Coca
6d6bfbc3d2
added missing import for pwd, was being obscured by exception catching and fallback
10 years ago
Brian Coca
a680ef66dd
fixed vault password file script execution
10 years ago
Brian Coca
6b842d9c49
fixed incorrect data passing on certain events
10 years ago
Brian Coca
2463922306
fixed error reporting when missing redis import
10 years ago
Brian Coca
6e96188085
added missing entry for dealing with bcc
10 years ago
Brian Coca
6ec5abf1c3
fixed some pyflakes
10 years ago
Abhijit Menon-Sen
49b35ad5dd
Remove mysterious old cruft
...
The two lines were added in 2673eb0a and modified in 60e1a1f8 , but foo
is completely unused. Removing it doesn't break anything: out it goes!
10 years ago
Brian Coca
fe0e4f27ad
Merge pull request #12584 from amenonsen/fixups
...
Remove an unwanted FIXME annotation
ok, confirmed we don't want to support it
10 years ago
Brian Coca
6c190aa8a4
updated ansible-doc to ignore more stuff that has been added to the module repos
10 years ago
Brian Coca
1a56a5c442
created debug method, renamed debug attribute to _debug
10 years ago
James Cammarata
deff045aa9
Fix bug caused by options not having start_at_task when used through adhoc
...
Fixes #12590
10 years ago
Toshio Kuratomi
a0920c06e1
Pull submodule refs to fix docs builds
10 years ago
Toshio Kuratomi
4dae7eeca1
Update submodule refs
10 years ago
Toshio Kuratomi
56fa9a5098
Port to v2 API
10 years ago
Toshio Kuratomi
d35c9a30fb
Minor refactorings
10 years ago
Toshio Kuratomi
888bcd65a8
Create error messages instead of tracebacks.
10 years ago
Abhijit Menon-Sen
93515468c4
Remove an unwanted FIXME annotation
...
<crab> jimi|ansible: do you think it should be possible to add both
foo:22 and foo:23 to the inventory?
<jimi|ansible> no
…so we don't want an invitation to FIXME.
10 years ago
Toshio Kuratomi
4cfcf5d61b
Merge pull request #12568 from mgedmin/py3k
...
Python 3: fix most tests for ansible.module_utils.basic
10 years ago
Trond Hindenes
94cfbe7ee9
Get-AnsibleParam
10 years ago
James Cammarata
dcb8caf9e8
Remember if we already skipped tasks via --start-at-task
...
Fixes #12482
10 years ago
chouseknecht
57adf11262
Fix metadata description for galaxy_tags.
10 years ago
chouseknecht
f4690e3bfe
Changing tag to galaxy_tag.
10 years ago
chouseknecht
8360a1b3f2
Replace categories with tags.
...
Also added --ignore-certs option for use with install and search commands. Helpful when
overriding server and server has self signed cert.
10 years ago
Abhijit Menon-Sen
0bb34fd076
Make «ansible-vault view» not write plaintext to a tempfile
...
CLI already provides a pager() method that feeds $PAGER on stdin, so we
just feed that the plaintext from the vault file. We can also eliminate
the redundant and now-unused shell_pager_command method in VaultEditor.
10 years ago
Brian Coca
bf06e36382
updated async to pass along no_log setting
10 years ago
Marius Gedminas
cc1e1648f5
Tweak comment style
10 years ago
Marius Gedminas
213029a21e
Python 3: don't convert unicode to unicode
10 years ago
Marius Gedminas
c7be004c19
Python 3 has no dict.iteritems()
...
(Reminder: cannot use six here, module_utils get shipped to remote
machines that may not have six installed -- besides six doens't support
Python 2.4.)
10 years ago
Marius Gedminas
9f3e5ceb14
Make sure 'basestring', 'bytes' and 'unicode' are defined
...
Python 3 doesn't have 'basestring' and 'unicode'.
Python 2.4 doesn't have 'bytes'
10 years ago
Brian Coca
ddafed4403
Merge pull request #12528 from bcoca/task_logging
...
task logging revamp
10 years ago
Brian Coca
7b64126c9d
pushed up openvz detection for cases of 'stacked' virtualization
10 years ago
Linus Unnebäck
45f9800754
facts: correctly detect docker inside a xen host
10 years ago
James Cammarata
3bd71d0619
Use delegated_to field for play context remote_addr, if none other exists
...
Fixes #12527
10 years ago
James Cammarata
40bdf09998
Merge pull request #12561 from srvg/anotherdirpy
...
Inject existing groups at InventoryDir initialization
10 years ago
James Cammarata
6fcd292c5e
Merge pull request #12569 from amenonsen/fixes
...
Bring groups handling in ini.py up-to-date (trivial fix)
10 years ago
James Cammarata
dfa33d0f23
Tweak variable manager use in role includes to avoid test failures
10 years ago
Abhijit Menon-Sen
50d75f8d6d
Bring groups handling in ini.py up-to-date
...
Since c8f2483d , ini.py expects to always be passed in a pre-created list
of groups, and can no longer deal sensibly with an empty list; this just
makes that expectation clear.
10 years ago
James Cammarata
a89412ecb1
Fail all hosts if a run_once task fails
...
Fixes #12563
10 years ago
James Cammarata
7173f587ed
Allow delegate_to on a role again
...
Fixes #12560
10 years ago
James Cammarata
a3e913da62
Don't assume handlers exist in the same role (if any)
...
Fixes #12536
10 years ago
Serge van Ginderachter
7461ba9998
Inject existing groups at InventoryDir initialization
...
This fixes a corner case where ini files live in a subdir
of the main inventory directory.
Reproducing the original error:
mkdir -p inventory/ini
cat > inventory/ini/hosts << EOF
[www]
www1
EOF
$ ansible -i inventory/ all -m ping
ERROR! 'all'
(or without the [www] group, it would complain about 'ungrouped')
10 years ago
James Cammarata
79e364d98b
Properly template role dependency names
...
Fixes #12505
10 years ago
Marius Gedminas
5edd6d9be4
Python 3: there's no basestring
...
Fixes another failing test.
(I don't want to do a global search/replace for 'basestring' because I
want to have unit tests covering each occurrence. When I run out of
existing failing tests, I'll try to write new ones.)
10 years ago
Toshio Kuratomi
95ede22a1e
Add a comment about the docker connection and usage by non-root users
10 years ago
Toshio Kuratomi
0e110d23f8
Misc cleanups and some fixes for docker connection plugin
...
* Remove extraneous imports
* Fix some error handling
* Enable pipelining
* Disable su since it doesn't work
* Add error message when installed docker is not recent enough to
support this plugin
* Move nested functions to class level
* Make transport a class attribute
* Make exec_command, put_file and fetch_file more robust
10 years ago
Toshio Kuratomi
1d119a1f46
Cleanup some extraneous imports
10 years ago
James Cammarata
ffdba96668
Save the included directory for playbook includes for use as the basedir
...
Fixes #12524
10 years ago
Konstantin Manna
4226e49bc6
bugfix: statement had no effect => statement now has assumed effect
10 years ago
Konstantin Manna
1ccfeafa76
bugfix: use correct close calls
10 years ago
Brian Coca
c1ad96e5cf
removed fixme as it is already implemented below.
10 years ago
RedRampage
922b5c8109
Removed deletion of salt by 'password' lookup
...
Removed deletion of salt param from lookup file by 'password' lookup_filter.
Old behaviour leads to constant changed status when two tasks uses same lookup,
one with 'encrypt' parameter, and other without.
For example:
tasks:
- name: Create user
user:
password: "{{ lookup('password', inventory_dir + '/creds/user/pass' ncrypt=sha512_crypt) }}"
...
# Lookup file 'creds/user/pass' now contain password with salt
- name: Create htpasswd
htpasswd:
password: "{{ lookup('password', inventory_dir + '/creds/user/pass') }}"
...
# Salt gets deleted from lookup file 'creds/user/pass'
# Next run of "Create user" task will create it again and will have 'changed' status
10 years ago
Toshio Kuratomi
12a2585e84
chroot plugin minor touchups:
...
* Disable su as it's not currently working 100% (and was disabled in v1).
* Move BUFSIZE out of the class to match other conenction plugins
* _connect shouldn't return self.
10 years ago
Toshio Kuratomi
7a4266e9c5
One more try -- the error message should reference the become method
...
requested via play context
10 years ago
Toshio Kuratomi
696cf32d63
Correct name of variable
10 years ago
Brian Coca
8d024c3747
Merge pull request #12472 from resmo/for_ansible
...
cloudstack: improvements and tests
10 years ago
Toshio Kuratomi
0dfa1fb43a
Correct call to method typo
10 years ago
Toshio Kuratomi
d827325644
Re-order the methods in ssh.py so that methods needed for implementation are near and just above the relevant public methods.
...
Standard with the rest of the code base.
10 years ago
Toshio Kuratomi
37844a5c1b
Update submodule refs
10 years ago
Toshio Kuratomi
c811668a4d
Merge pull request #12546 from amenonsen/ssh-cleanups
...
A couple of ssh cleanups
10 years ago
Toshio Kuratomi
05af4c8e91
Merge pull request #12471 from amenonsen/pipelining
...
Make pipelining a connection variable
10 years ago
Abhijit Menon-Sen
38c7422da5
Move ControlPersist/Path checking into a separate method
...
This is also peripheral to what _build_command needs, can be improved
and tested independently, and so makes more sense in a separate method.
This commit doesn't change any functionality (and I've verified that it
works with the various combinations: control_path set in ansible.cfg,
ssh_args adding or not adding ControlMaster/ControlPersist, etc.).
10 years ago
Toshio Kuratomi
c3a05b1181
Update to fix one more doc error
10 years ago
Abhijit Menon-Sen
f33d541964
Move sshpass checking into a separate method
...
Checking for sshpass is peripheral to the calling code, so it's easier
to follow when the details are moved into a method.
10 years ago
Abhijit Menon-Sen
565c6f1ae7
Make ansible_pipelining a connection variable
...
SSH pipelining can be a significant performance improvement, but it will
not work if sudoers is configured to requiretty. With this change, one
could have pipelining enabled in ansible.cfg, but use sudo to turn off
requiretty in a separate play (or task) where pipelining is disabled:
- hosts: foo
vars:
ansible_pipelining: no
tasks:
- lineinfile: dest=/etc/sudoers line='Defaults requiretty' state=absent
sudo_user: root
(Note that sudoers has a complicated syntax, so the above lineinfile
invocation may be too simplistic for production use; but the point is
that a separate play can do something to disable requiretty.)
10 years ago
Toshio Kuratomi
fd267989fb
Fix docs build
10 years ago
Toshio Kuratomi
69ebb899a7
Update submodule refs
10 years ago
James Cammarata
c860775b5d
Another fix for --limit in adhoc
10 years ago
James Cammarata
babf47decb
Clean up some bugs related to --limit on adhoc commands
10 years ago
James Cammarata
621575681a
Merge pull request #12542 from amenonsen/qfix
...
Clarify why we add -q only for ssh
10 years ago
Abhijit Menon-Sen
2ce219b5af
Clarify why we add -q only for ssh
10 years ago
Marius Gedminas
9b39af8e9a
Python 3: the StringIO module is gone
...
Fixes 17 failing tests on Python 3.4, restoring the 8 failures we had
last Friday.
10 years ago
Jesper Geertsen Jonsson
353b549eb0
Fix HTTPError message not being reachable
10 years ago
James Cammarata
4cd810a674
Only append -q option for ssh if we're using ssh
10 years ago
James Cammarata
46984a067c
Don't wrap vars from include_vars with UnsafeProxy
10 years ago
James Cammarata
abfeb104df
Merge pull request #12529 from soarpenguin/bug-fix
...
fix no self pointer out of class.
10 years ago
Toshio Kuratomi
342bc97322
Port chroot conection plugin to the latest v2 connection API.
...
Also get pipelining working for people who look to chroot as an example
for their own connection plugins
Note: In the latest v2 API, action handles become but chroot doesn't
reliably handle become. Maybe we need to add a has_become attribute
that the action can display an appropriate error.
10 years ago
Toshio Kuratomi
056a020357
Do not fail if /proc/uptime is not present
...
This can happen in chroot environments that don't have all of /proc
available
10 years ago
Toshio Kuratomi
ae66d01a33
Document how a command is executed on the remote machine
...
Helps connection plugin implementors understand how to structure
exec_command()
10 years ago
James Cammarata
6dd38c2a10
Fix parent attribute lookup to be default
...
Fixes #12526
10 years ago
James Cammarata
a1c38a3fda
Adding delegate_to to Blocks
10 years ago
Brian Coca
bb6141ec41
renamed managed_syslog to no_target_syslog
10 years ago
Abhijit Menon-Sen
8251ab2e37
Update outdated comment
...
Since #12165 was merged, hostnames are properly validated.
10 years ago
Abhijit Menon-Sen
6ff4d40d74
Update outdated comment
...
We now use "sudo -n" instead of "sudo -k && sudo …"
10 years ago
soarpenguin
1ea66e234f
fix logic judgment error.
10 years ago
soarpenguin
2caa52a981
fix no self pointer out of class.
10 years ago
Brian Coca
37a918438b
task logging revamp
...
* allow global no_log setting, no need to set at play or task level, but can be overriden by them
* allow turning off syslog only on task execution from target host (manage_syslog), overlaps with no_log functionality
* created log function for task modules to use, now we can remove all syslog references, will use systemd journal if present
* added debug flag to modules, so they can make it call new log function conditionally
* added debug logging in module's run_command
10 years ago
James Cammarata
60e1a1f8eb
Fix bug in nested lookup where pop is called indiscriminately
10 years ago
Brian Coca
191ae0831d
fixed syntax error
10 years ago
Brian Coca
48412c13b2
fixed copy n paste typo on future code
10 years ago
James Cammarata
bb1101498d
Clean up typo from cdc6c52
10 years ago
James Cammarata
cdc6c5208e
Clean string data run through the template engine
...
Also strip UnsafeProxy off of low level srings and objects to ensure
they don't cause issues later down the road
Fixes #12513
10 years ago
James Cammarata
ae9b34b1d9
Fix for equality checking in Host to make sure things are like types
10 years ago
Toshio Kuratomi
fa9ea32a86
Fix test of whether a result has a failed host
10 years ago
Brian Coca
1c49e3b842
draft shared service code for modules, part of spliting service module
10 years ago
Toshio Kuratomi
41756be4d3
Update core module ref
10 years ago
Toshio Kuratomi
dcdcd9e9c5
Move is_executable to the toplevel of basic.py so we can utilize it from other code
10 years ago
James Cammarata
ccddda1ebc
Merge pull request #12502 from mgedmin/py3k
...
Python 3: make test_variable_manager_precedence pass
10 years ago
James Cammarata
eb8d7dcd14
Make sure formatted strings don't bomb on tuples
...
Fixes #12501
10 years ago
James Cammarata
31d5f88a1d
Use the task loop to calculate multiple delegated hosts
...
Due to the way we're now calculating delegate_to, if that value is based
on a loop variable ('item') we need to calculate all of the possible
delegated_to variables for that loop.
Fixes #12499
10 years ago
Toshio Kuratomi
a1428d6bed
Remove tmp as a parameter to the connection plugins
...
There doesn't appear to be anything that actually uses tmp_path in the
connection plugins so we don't need to pass that in to exec_command.
That change also means that we don't need to pass tmp_path around in
many places in the action plugins any more. there may be more cleanup
that can be done there as well (the action plugin's public run() method
takes tmp as a keyword arg but that may not be necessary).
As a sideeffect of this patch, some potential problems with chmod and
the patch, assemble, copy, and template modules has been fixed (those
modules called _remote_chmod() with the wrong order for their
parameters. Removing the tmp parameter fixed them.)
10 years ago
James Cammarata
95b371dd60
Use AnsibleFileNotFound instead of AnsibleParsingError when YAML files are not found
...
And update portions of code to expect the proper error.
Fixes #12512
10 years ago
Toshio Kuratomi
0250beb68a
Remove compress option from paramiko connection for now
...
It's not available on older versions of paramiko such as shipped in RHEL6
10 years ago
James Cammarata
12df9f2e31
Make hostvars more dynamic again to improve performance with large inventories
...
Fixes #12477
10 years ago
Abhijit Menon-Sen
82b33c381f
We don't need even a token timeout here; just poll once
...
The process is already gone, so there's not going to be any new data
showing up on its stderr; we only want to make sure that we haven't
missed something that was already written. So polling once is enough.
10 years ago
Abhijit Menon-Sen
6e82df451a
Clarify select() handling for ssh connections
...
This change is motivated by an ssh oddity: when ControlPersist is
enabled, the first (i.e. master) connection goes into the background; we
see EOF on its stdout and the process exits, but we never see EOF on its
stderr. So if we ran a command like this:
ANSIBLE_SSH_PIPELINING=1 ansible -T 30 -vvv somehost -u someuser -m command -a whoami
We would first do select([stdout,stderr], timeout) and read the command
module output, then select([stdout,stderr], timeout) again and read EOF
on stdout, then select([stderr], timeout) AGAIN (though the process has
exited), and select() would wait for the full timeout before returning
rfd=[], and then we would exit. The use of a very short timeout in the
code masked the underlying problem (that we don't see EOF on stderr).
It's always preferable to call select() with a long timeout so that the
process doesn't use any CPU until one of the events it's interested in
happens (and then select will return independent of elapsed time).
(A long timeout value means "if nothing happens, sleep for up to <x>";
omitting the timeout value means "if nothing happens, sleep forever";
specifying a zero timeout means "don't sleep at all", i.e. poll for
events and return immediately.)
This commit uses a long timeout, but explicitly detects the condition
where we've seen EOF on stdout and the process has exited, but we have
not seen EOF on stderr. If and only if that happens, it reruns select()
with a short timeout (in practice it could just exit at that point, but
I chose to be extra cautious). As a result, we end up calling select()
far less often, and use less CPU while waiting, but don't sleep for a
long time waiting for something that will never happen.
Note that we don't omit the timeout to select() altogether because if
we're waiting for an escalation prompt, we DO want to give up with an
error after some time. We also don't set exceptfds, because we're not
actually acting on any notifications of exceptional conditions.
10 years ago
Toshio Kuratomi
03127dcfae
remove the stdin return value from connection plugin exec_command() methods
...
The value was useless -- unused by the callers and always hardcoded to
the empty string.
10 years ago
James Cammarata
9d47eabfa4
Merge pull request #12506 from hyperized/devel
...
Add Weekday (0-6) as a number and add weeknumber (00-52)
10 years ago
Toshio Kuratomi
24b9e2e6d1
Update extras submodule ref
10 years ago
Gerben Geijteman
4c20964475
Add Weekday (0-6) as a number and add weeknumber (00-52)
10 years ago
Marius Gedminas
56f2a25bff
Python 3: there's no 'unicode'
10 years ago
Marius Gedminas
6d4618f46f
Python 3: there's no dict.iteritems()
10 years ago
Marius Gedminas
0624797375
Bugfix: if you define a custom __eq__, you must define a __hash__ too
...
Also, on Python 3 the stock object.__hash__ raises an error ("unhashable
type"), and we have code that uses Host instances as dict keys.
10 years ago
Marius Gedminas
a2bc6b4b26
Bugfix: if you define __eq__, you should define __ne__ too
10 years ago
Marius Gedminas
5d29a2eabd
Python 3: shlex.split() wants unicode
...
On Python 2, shlex.split() raises if you pass it a unicode object with
non-ASCII characters in it. The Ansible codebase copes by explicitly
converting the string using to_bytes() before passing it to
shlex.split().
On Python 3, shlex.split() raises ('bytes' object has no attribute 'read')
if you pass a bytes object. Oops.
This commit introduces a new wrapper function, shlex_split, that
transparently performs the to_bytes/to_unicode conversions only on
Python 2.
Currently I've only converted one call site (the one that was causing a
unit test to fail on Python 3). If this approach is deemed suitable,
I'll convert them all.
10 years ago
Toshio Kuratomi
5d3d9cfe0d
Convert to byte strings to avoid UnicodeErrors
...
Fixes #12488
10 years ago
Brian Coca
de18bcb95f
correct typo on error reporting
...
fixes #12495
10 years ago
Abhijit Menon-Sen
40f608a377
A bit more debugging output
...
We used to display input chunks earlier anyway, so this isn't making
things more verbose.
10 years ago
Abhijit Menon-Sen
9700d9c04f
Fix typo in checking select results
...
It's possible for more than one fd to be set, so 'elif' is obviously not
the right thing to use.
10 years ago
James Cammarata
1164e83477
Remove unnecessary calls to save inventory restrictions since 81bf88b
10 years ago
Toshio Kuratomi
89a78ba16e
Update submodule refs
10 years ago
James Cammarata
9e734df0ec
Conditionally poll longer if we're still waiting for an auth prompt
10 years ago
Toshio Kuratomi
5f0f5363b6
Merge pull request #12487 from mgedmin/py3k
...
Fix one more failing test on Python 3
10 years ago
James Cammarata
2898e000a0
Don't use the connection timeout for the select poll timeout
10 years ago
Abhijit Menon-Sen
587054db2a
Send initial data before calling select whenever possible
...
Without this, we could execute «ssh -q ...» and call select(), which
would timeout after the default 10s, and only then send initial data.
(This is a relic of the earlier change where we always ran ssh with
-vvv, so the situation where it would sit quietly never happened in
practice; but this would have been the right thing to do even then.)
10 years ago
James Cammarata
c9a004227e
Improve error catching from malformed playbook data
...
Fixes #12478
10 years ago
James Cammarata
e8e1d9f6fb
Apply --limit to inventory in adhoc commands
...
Fixes #12473
10 years ago
Marius Gedminas
95e655eb67
Python 3: there's no basestring
...
Fixes one failing test.
The long series of module_utils/basic.py fixes were all because
module_utils/basic is imported in ansible/inventory/script.py.
10 years ago
Marius Gedminas
2c4982b58d
Python 3: there's no itertools.imap
...
Because the builtin map() acts like an iterator already.
10 years ago
Marius Gedminas
6708d56a21
Python 3: avoid long integer literals
...
Even Python 2.4 automatically promotes int to long.
10 years ago
Marius Gedminas
f5d4935197
Python 3: treat python as a function in module_utils/basic.py
...
NB: we can't use 'from __future__ import print_function', but luckily
print(one_thing) works fine on both Python 2 and Python 3 without that.
10 years ago
Marius Gedminas
e71a986e16
Python 3: avoid octal constants in module_utils/basic.py
10 years ago
Marius Gedminas
d2bec7f81f
Python 3: avoid "except ..., e:" in module_utils/basic.py
...
Make the code compatible with Pythons 2.4 through 3.5 by using
sys.exc_info()[1] instead.
This is necessary but not sufficient for Python 3 compatibility.
10 years ago
James Cammarata
65630d2ce1
Fixing one more bug related to staticmethods in LookupBase
10 years ago
James Cammarata
cbbb270761
Cleanup bug from moving base lookup methods to staticmethods
10 years ago
Abhijit Menon-Sen
ac98fe9e89
Implement ssh connection handling as a state machine
...
The event loop (even after it was brought into one place in _run in the
previous commit) was hard to follow. The states and transitions weren't
clear or documented, and the privilege escalation code was non-blocking
while the rest was blocking.
Now we have a state machine with four states: awaiting_prompt,
awaiting_escalation, ready_to_send (initial data), and awaiting_exit.
The actions in each state and the transitions between then are clearly
documented.
The check_incorrect_password() method no longer checks for empty strings
(since they will always match), and check_become_success() uses equality
rather than a substring match to avoid thinking an echoed command is an
indication of successful escalation. Also adds a check_missing_password
connection method to detect the error from sudo -n/doas -n.
10 years ago
Abhijit Menon-Sen
840a32bc08
Reorganise ssh.py to cleanly separate responsibilities
...
The main exec_command/put_file/fetch_file methods now _build_command and
call _run to handle input from/output to the ssh process. The purpose is
to bring connection handling together in one place so that the locking
doesn't have to be split across functions.
Note that this doesn't change the privilege escalation and connection IO
code at all—just puts it all into one function.
Most of the changes are just moving code from one place to another (e.g.
from _connect to _build_command, from _exec_command and _communicate to
_run), but there are some other notable changes:
1. We test for the existence of sshpass the first time we need to use
password authentication, and remember the result.
2. We set _persistent in _build_command if we're using ControlPersist,
for later use in close(). (The detection could be smarter.)
3. Some apparently inadvertent inconsistencies between put_file and
fetch_file (e.g. argument quoting, sftp -b use) have been removed.
Also reorders functions into a logical sequence, removes unused imports
and functions, etc.
Aside: the high-level EXEC/PUT/FETCH description should really be logged
from ConnectionBase, while individual subclasses log transport-specific
details.
10 years ago
James Cammarata
95c6fe88e4
Fix handling of conditional vars_files which contain variables
...
Fixes #12484
10 years ago
Toshio Kuratomi
c83f51b7f2
Some LookupBase cleanups:
...
* Make LookupBase an abc with required methods (run()) marked as an
abstractmethod
* Mark methods that don't use self as @staticmethod
* Document how to implement the run method of a lookup plugin.
10 years ago
Toshio Kuratomi
049952fa50
Update submodule refs.
10 years ago
James Cammarata
1e7fd2196d
Fixing synchronize + delegate_to user bug
...
Fixes #12464
10 years ago
James Cammarata
3ffc2783c4
Don't bomb out on handlers with undefined variables in their names
10 years ago
Toshio Kuratomi
4b0d52d2cb
Merge pull request #12420 from ansible/win_prefix_modules
...
Fix for user defined modules not overriding modules from core.
10 years ago
James Cammarata
1076155d8d
When failing because of vars_files templating, try and bubble up the file/line info
10 years ago
Toshio Kuratomi
18e2ee16ef
Fix for user defined modules not overriding modules from core.
...
This fix takes into account that powershell modules are somewhat
different than regular modules and have to be kept separate.
10 years ago
Toshio Kuratomi
f61fb9787d
Update submodule refs
10 years ago
Rene Moser
b43939dfd6
cloudstack: make tags handling idempotence
...
Credits to @jeffersongirao, who provided the patch.
10 years ago
James Cammarata
c30e464388
Additional tweaks to callback output for delegate_to
10 years ago
James Cammarata
513619867a
Show delegated-to host in callback message
...
Fixes #12465
10 years ago
Rene Moser
efd122c2f0
cloudstack: add returns_to_int return handling into utils
...
It is not uncommon that the API returns string for int values e.g. ports in listFirewallRules or listPortForwardings,
10 years ago
Rene Moser
c9a3801a25
cloudstack: common argument_spec and requried_together to utils
10 years ago
James Cammarata
f563b22446
Merge pull request #12461 from mgedmin/py3k
...
Python 3: there's no basestring
10 years ago
James Cammarata
d2949f5449
Merge pull request #12463 from mgedmin/fix-ansible-doc
...
Fix option descriptions in ansible-doc output
10 years ago
James Cammarata
0fb4a6a67b
Tweak to the way new host variables are created for delegated hosts
10 years ago
Marius Gedminas
339790adc4
Fix option descriptions in ansible-doc output
...
Fixes #12462 .
10 years ago
James Cammarata
18adfc6d1a
Set some default vars on hosts created for delegate_to connections
10 years ago
James Cammarata
a22f7b883d
Restrict role param vars to tasks within that role
...
Fixes #12460
10 years ago
Marius Gedminas
fc0dcc3947
Python 3: there's no basestring
...
Fixes one failing test.
Now technically a filename can be a bytestring, even on Python 3. I
hope this is unlikely for Ansible.
10 years ago
James Cammarata
ecf7d8c9ee
Fix relative path bug in copy action
...
Without rebreaking #12055
Fixes #ansible-modules-core/2098
10 years ago
James Cammarata
53794b692c
Merge pull request #12457 from ansible/warn-if-core-modules-not-present
...
Detect if core modules aren't installed and warn if that is the case
10 years ago
Toshio Kuratomi
627f9d73ba
Detect if core modules aren't installed and warn if that is the case
...
Fixes #11206
10 years ago
Brian Coca
d27b73e7b5
fixed case in which boto3 is present but module is not using it yet
10 years ago
James Cammarata
cb7060c9fe
Allow undefined var errors to bubble up when templating vars_files in certain conditions
...
Follow up to 8769f03c , which allows the undefined var error to be raised
if we're getting vars with a full context (play/host/task) and the host
has already gathered facts. In this way, vars_files containing variables
that fail to be templated are not silently ignored.
10 years ago
Brian Coca
f96255f7fd
fixed typo
10 years ago
James Cammarata
86566e691a
Merge pull request #12447 from mgedmin/py3k
...
Python 3: there is no 'basestring'
10 years ago
James Cammarata
8769f03c16
Also catch AnsibleUndefinedVariable errors when templating vars_files names
...
Fixes #12449
10 years ago
Toshio Kuratomi
2a614c1c0f
Close module file once we're done reading from it
10 years ago
Marius Gedminas
9cdb6ebae3
Python 3: there is no 'basestring'
...
This fixes a failing unit test.
In actual use (which is still quite far), I'm not sure if bytes ->
unicode conversion should be done here (in which case the code will fail
with an AttributeError: 'bytes' object has no attribute 'readlines'), or
inside self._connection.exec_command() (in which case my change is
correct).
10 years ago
Victor Salgado
20bbd66e85
Use dict.get()
10 years ago
James Cammarata
65bf14cbb0
Merge pull request #12431 from hslee16/devel
...
Stops using _groups_list to check for host when using 'add_host'
10 years ago
James Cammarata
88e1aa94fa
Add play context vars to list of variables before post validation
...
Fixes #12437
10 years ago
James Cammarata
05f6e76407
Template handler names before checking to see if they need to run
...
Fixes #12427
10 years ago
James Cammarata
72769d1899
Merge pull request #12432 from mgedmin/py3k
...
Python 3: there's no xrange
10 years ago
James Cammarata
37f2cbc429
Merge pull request #12436 from amenonsen/ranges
...
Support «hosts: foo[1:]» and add tests for split/apply_subscript
10 years ago
James Cammarata
1f5584aa5b
Refactoring delegate_to code
...
Now, instead of relying on hostvars on the executor side, we compile
the vars for the delegated to host in a special internal variable and
have the PlayContext object look for things there when applying task/
var overrides, which is much cleaner and takes advantage of the code
already dealing with all of the magic variable variations.
Fixes #12127
Fixes #12079
10 years ago
James Cammarata
fa69e8ebb8
Fixing some bugs in _compute_delegate() in TaskExecutor
...
* Clearing interpreter settings from variables, so those set for the
original host aren't incorrectly applied to the delegated to host
* Fixed incorrect string for remote user in delegated hosts hostvars
* Properly looking for multiple possiblities in the delegated-to hosts
hostvars (ansible_ssh_host vs. ansible_host)
10 years ago
Peter Sprygada
e45b71d6cd
added new module object to vca
10 years ago
Abhijit Menon-Sen
2fcdb37e7b
Support «hosts: groupname[1:]» notation (~= 'the rest of the group')
10 years ago
Brian Coca
aca83b15e5
Merge pull request #12425 from privateip/devel
...
initial add of vca common module
10 years ago
Brian Coca
11707576a3
fix for AIX network facts
...
fixes #12434
10 years ago
Brian Coca
d7b61db6dc
made boto3 non mandatory
10 years ago
Toshio Kuratomi
fdb1c14004
Update the submodule pointers
10 years ago
Petr Mifek
27f779a7cc
Small clean up and refactor of the rsync target ipv6 observing formatter for synchronize action.
10 years ago
Marius Gedminas
baf9320369
Python 3: there's no xrange
...
Use six.moves.range instead (aliased to xrange on Python 2, aliased to
range on Python 3).
Also I couldn't resist replacing the elaborate chr/ord/randrange dance
with the simpler random.choice(string.ascii_lowercase) that was already
used elsewhere in the Ansible codebase.
10 years ago
Alex Lee
cf289191e5
return None if group does not exist in inventory groups
10 years ago
Petr Mifek
6f3f4dff7a
Change synchronize module plugin to be backwards compatible with RSync 2.6.9 with regard to handling IPv6 addresses.
10 years ago
James Cammarata
cc6627cdd6
Remove custom json encoder cleaner and strip proxy var stuff out before encoding
...
Fixes #12349
10 years ago
James Cammarata
c95d4ca05f
Properly assign search path to environment.loader in template lookup
...
Same fix as was applied in f162990c to the action plugin
Fixes #12355
10 years ago
James Cammarata
bde5ed9672
Catch worker errors that may be subclassed on others that lead to incorrect exits
10 years ago
Peter Sprygada
8f43d222c0
initial add of vca common module
10 years ago
James Cammarata
053c41e79d
Fix typo in ansible module_utils import from galaxy code
10 years ago
Chrrrles Paul
7b778d8a4b
Merge pull request #12424 from amenonsen/ipv6-ranges
...
Tested. Thanks for spotting and then fixing this -- Allow hexadecimal ranges in IPv6 addresses, not only 0-9
10 years ago
Abhijit Menon-Sen
2d420a9bb7
Allow hexadecimal ranges in IPv6 addresses, not only 0-9
10 years ago
James Cammarata
b386f0c64d
Merge pull request #12423 from amenonsen/split-fixup
...
Remove deprecation warning; now handled in _split_patterns
10 years ago
James Cammarata
a1fffff92c
Merge branch 'addresses' of https://github.com/amenonsen/ansible into amenonsen-addresses
10 years ago
Abhijit Menon-Sen
62ca6b5e35
Remove deprecation warning; now handled in _split_patterns
10 years ago
Abhijit Menon-Sen
575a8b8c77
Merge Host.ipv[46]_address into .address
...
The earlier distinction was never used; .ipv6_address was always a copy
of .ipv4_address, and the latter was always used to set the remote_addr
field in the PlayContext.
Also uses the canonical ansible_host/ansible_port names when setting the
address and port from variables.
10 years ago
James Cammarata
951128d7a6
Merge branch 'hostpatterns' of https://github.com/amenonsen/ansible into amenonsen-hostpatterns
10 years ago
Victor Salgado
14fefebaad
Modify _split_pattern to use map when working with list input
10 years ago
James Cammarata
46baed864f
Submodule update after correcting doc bug
10 years ago
James Cammarata
0beb37a121
Submodule update
10 years ago
James Cammarata
ba82e57445
Merge branch 'sudo_on_if_needed' of https://github.com/apollo13/ansible into apollo13-sudo_on_if_needed
10 years ago
Toshio Kuratomi
8532ddd5ed
typo in formatting the warning message
10 years ago
Toshio Kuratomi
4ae5512fb0
Restore python3 compat fix and fix AnsibleError undefined before use
10 years ago
James Cammarata
c881b1acae
Merge pull request #12407 from mgedmin/py3k
...
Python 3: basestring in play_context.py
10 years ago
James Cammarata
8acbc00853
Fixing groups variable structure to match v1
...
Fixes #12418
10 years ago
Abhijit Menon-Sen
349eec7855
Fix missing colon (typo) in IPv6 pattern
10 years ago
Abhijit Menon-Sen
2405861a9e
Use ',' instead of ':' or ';' to separate host patterns
...
The earlier-recommended "pat1:pat2:pat3[x:y]" notation doesn't work well
with IPv6 addresses, so we recommend ',' as a separator instead. We know
that commas can't occur within a pattern, so we can just split on it.
We still have to accept the "foo:bar" notation because it's so commonly
used, but we issue a deprecation warning for it.
Fixes #12296
Closes #12404
Closes #12329
10 years ago
Florian Apolloner
d9f873495e
Ported over #7158 to support SELinux context switches.
10 years ago
Brian Coca
ee840f3029
fixed function signature
10 years ago
Florian Apolloner
decd9e8710
Only use become if the target user difers from the current remote user.
10 years ago
Marius Gedminas
8243954dcd
Python 3: basestring in play_context.py
10 years ago
Toshio Kuratomi
3db8070aa3
Fix urlopen usage to use open_url instead
...
Add a travis test for urlopen usage
10 years ago
James Cammarata
e97d448838
Cleanup one more missed inventory bug
10 years ago
James Cammarata
5db9e38377
Merge pull request #12345 from mgedmin/py3k
...
Python 3: two more instances of 'basestring'
10 years ago
Chris Church
43b15ab9a4
Merge pull request #12385 from cchurch/winrm_put_empty_file
...
Enable winrm put_file to upload an empty file.
10 years ago
Chris Church
93af0b327f
Merge pull request #12384 from cchurch/powershell_strict_mode
...
Add PowerShell exception handling and turn on strict mode.
10 years ago
Chris Church
0325f92b6a
Merge pull request #12054 from cchurch/winrm_options
...
Support additional options for WinRM connections via inventory variables
10 years ago
Chris Church
c5409ab493
Remove ansible_winrm_ host/port/user/pass options, update exception handling around establishing a winrm connection.
10 years ago
Chris Church
056c6b77d0
Support additional options for WinRM connections via inventory variables.
10 years ago
James Cammarata
11c27078c0
Cleaning up inventory bugs from earlier group change
10 years ago
Chris Church
1d15e8f37a
Pass windows command as-is without splitting/rejoining parameters.
...
* Fixes extra spaces added between parameters from https://github.com/ansible/ansible-modules-core/issues/1929
* Correctly decode PowerShell command encoded as UTF-16-LE so that it displays correctly in debug messages, fixes the other issue from https://github.com/ansible/ansible-modules-core/issues/1929
* Add test to verify that script parameters are passed as-is, so $true is interpreted as a boolean, fixes https://github.com/ansible/ansible/issues/10947
10 years ago
Victor Salgado
54f1560d3e
Fix mutable default argument
10 years ago
James Cammarata
33e79203ce
Merge branch 'quinot-topic/crash_empty_inventory' into devel
10 years ago
James Cammarata
c8f2483d6d
Cleaning up default group creation in inventory parsers
10 years ago
Toshio Kuratomi
30552cf7e9
Fix problems with undefined references to self.display and remove method that's no longer called
10 years ago
James Cammarata
3f8e12d1f7
Merge pull request #12359 from cchurch/fetch_no_fail_on_missing
...
Fix fetch to not fail for missing file when fail_if_missing=False
10 years ago
James Cammarata
4429e7611b
Merge pull request #12382 from AxelDelmas/env_async
...
Added env_string in async_cmd
10 years ago
James Cammarata
e899b8e70d
Merge branch 'topic/crash_empty_inventory' of https://github.com/quinot/ansible into quinot-topic/crash_empty_inventory
10 years ago
James Cammarata
b2848bd25f
Merge pull request #12389 from amenonsen/minus-t
...
Set PlayContext.timeout from the value specified by -T on the command-line
10 years ago
James Cammarata
d91ff0db74
Fixing parent block serialization for blocks
...
Fixes #12395
10 years ago
Thomas Quinot
c005f75469
Always create 'all' group
...
Create 'all' even if host_list is empty, as this group needs to exist
when creating the implicit 'localhost' host.
Fixes #12391
10 years ago
Abhijit Menon-Sen
85bb508f26
Set PlayContext.timeout from the value specified by -T on the command-line
...
Fixes #12372
10 years ago
James Cammarata
2a50957ad8
Fix galaxy install dep failure
...
Also fixes issue where force does not force reinstall of deps
Fixes #10425
10 years ago
Toshio Kuratomi
1a39e32a13
Update core modules ref
10 years ago
Chris Church
6ab4cff7db
Enable winrm put_file to upload an empty file.
10 years ago
Chris Church
5c65ee7f0c
Add PowerShell exception handling and turn on strict mode.
...
* Add exception handling when running PowerShell modules to provide exception message and stack trace.
* Enable strict mode for all PowerShell modules and internal commands.
* Update common PowerShell code to fix strict mode errors.
* Fix an issue with Set-Attr where it would not replace an existing property if already set.
* Add tests for exception handling using modified win_ping modules.
10 years ago
James Cammarata
a1948dd1c1
Merge branch 'bcoca-normalize_plugin_paths' into devel
10 years ago
James Cammarata
a7e1113b26
Removing FIXME comment which is no longer required
10 years ago
James Cammarata
d818a72375
Merge branch 'normalize_plugin_paths' of https://github.com/bcoca/ansible into bcoca-normalize_plugin_paths
10 years ago
Axel Delmas
4802641de7
Added env_string in async_cmd
10 years ago
James Cammarata
60c139e482
Fix logic for changed/failed_when + retry/until loops
...
Fixes #11809
10 years ago
James Cammarata
8e664ad226
Fix delegate_to localhost vs. 127.0.0.1 (and ::1)
10 years ago
James Cammarata
38573c55bf
Tweak failure condition for field attributes expected to be strings
10 years ago
James Cammarata
cfdaec0c22
Make sure string attributes are strings from YAML to avoid bad type conversions
...
Fixes #12367
10 years ago
Brian Coca
b6d6c2e4db
corrected all missing paths changes
10 years ago
Brian Coca
4aea1f6568
normalized plugin paths and names and configs
10 years ago
Brian Coca
02372e9761
Merge pull request #12371 from apollo13/patch-1
...
Remove duplicate SU_PROMPT_LOCALIZATIONS
10 years ago
Florian Apolloner
9334046189
Remove duplicate SU_PROMPT_LOCALIZATIONS
10 years ago
gptech
1c6be7b9ba
Replace 'degug' with 'debug'
...
Tiny typo fix.
10 years ago
Andriy Yurchuk
af213241ab
Fix typo
10 years ago
Brian Coca
e7807c4f2d
Merge pull request #12339 from emonty/feature/openstack-no-log
...
Add no-log parameter to common openstack args
10 years ago
James Cammarata
4f30db8ca5
Check if path is /dev/null when checking if a file is in fact a file
10 years ago
Chris Church
260b9f648c
Fix fetch action plugin to not fail if file is missing and fail_if_missing=False (the default). Add tests to test_fetch role to verify it works as expected.
10 years ago
James Cammarata
feee4613cd
Merge pull request #12357 from apollo13/become_fix
...
Fixed #12356 -- Restored ansible 1.9.x become behavior.
10 years ago
James Cammarata
49ca0eb797
Track local_action internally to prevent it from being overridden
...
Fixes #12053
10 years ago
Florian Apolloner
8182eb3787
Fixed #12356 -- Restored ansible 1.9.x become behavior.
10 years ago
Marius Gedminas
9877a5c415
Python 3: two more instances of 'basestring'
...
Fixes two failing tests on Python 3.4.
10 years ago
Monty Taylor
3bdd6793ca
Add no-log parameter to common openstack args
...
These bad boys can contain secret data, so should be marked no-log.
10 years ago
James Cammarata
aa762bb432
Don't split args out unless we're parsing module args using the new style
...
Fixes #12331
10 years ago
James Cammarata
1cb4e0be1c
Fix bug in implicit block squashing where block is not reassigned
...
Fixes #12333
10 years ago
James Cammarata
7deb8bbd1c
Reworking how includes within handlers are run
...
Fixes #12238
10 years ago
Brian Coca
03758151e4
Merge pull request #12330 from cchurch/revert_find_plugin_changes
...
Revert "Fix order of loading of modules."
10 years ago
Brian Coca
9d4d7bd74d
fixed porting bugs in profile_tasks to v2
10 years ago
Chrrrles Paul
ba7734b78b
Merge pull request #12165 from amenonsen/address-parsing
...
Hi @amenonsen - thanks for fixing up the hunting down the unicode bug and expanding test_addresses. The code looks good, merging!-- Be systematic about parsing and validating hostnames and addresses
10 years ago
James Cammarata
4156bcedf5
Fix typo in 049a48f
10 years ago
Chris Church
ed3a9795d4
Revert "Fix order of loading of modules."
...
This reverts commit 4b895f04e3 .
10 years ago
James Cammarata
1243686b90
Submodule update
10 years ago
Abhijit Menon-Sen
049a48f3d3
Test state.tasks_child_state before dereferencing
...
I hit a traceback in the FAILED_TASKS case, but it seemed prudent to add
guards in the other similar branches.
10 years ago
James Cammarata
df89f03627
Fixing precedence order for new nonpersistent vars (set_fact/register)
...
These used to go in vars_cache, so merging them in after that as they
are "live" variables and the user would most likely want to see these
above anything else.
10 years ago
Abhijit Menon-Sen
7479ab47e0
Be stricter about parsing hostname labels
...
Labels must start with an alphanumeric character, may contain
alphanumeric characters or hyphens, but must not end with a hyphen.
We enforce those rules, but allow underscores wherever hyphens are
accepted, and allow alphanumeric ranges anywhere.
We relax the definition of "alphanumeric" to include Unicode characters
even though such inventory hostnames cannot be used in practice unless
an ansible_ssh_host is set for each of them.
We still don't enforce length restrictions—the fact that we have to
accept ranges makes it more complex, and it doesn't seem especially
worthwhile.
10 years ago
Abhijit Menon-Sen
065bb52109
Be systematic about parsing and validating hostnames and addresses
...
This adds a parse_address(pattern) utility function that returns
(host,port), and uses it wherever where we accept IPv4 and IPv6
addresses and hostnames (or host patterns): the inventory parser
the the add_host action plugin.
It also introduces a more extensive set of unit tests that supersedes
the old add_host unit tests (which didn't actually test add_host, but
only the parsing function).
10 years ago
James Cammarata
49803509b4
Make sure include paths are templated before dwim in case they're absolute
...
Fixes #12327
10 years ago
James Cammarata
4cdd9b2a82
Merge pull request #12318 from mgedmin/py3k
...
Python 3: make ansible.template.safe_eval() work
10 years ago
Brian Coca
52f587cac3
Merge pull request #12325 from quinot/topic/wrong_interp_test
...
Test for Python must be against basename of interpreter
10 years ago
James Cammarata
c2115c3715
Re-adding part of 926f127 which was actually fixing #12277
10 years ago
James Cammarata
083aef65ad
Revert "set_fact should put facts in the fact_cache, not vars_cache"
...
This reverts commit 926f127245 .
10 years ago
Thomas Quinot
0bc9223826
Test for Python must be against basename of interpreter
...
Followup on issue #12076
10 years ago
James Cammarata
441a8af671
Merge pull request #12267 from h-hirokawa/add_replacer_jsonargs
...
Add the new module replacer <<INCLUDE_ANSIBLE_MODULE_JSON_ARGS>>.
10 years ago
Marius Gedminas
f91b28ef23
Fix safe_eval() of set literals
...
There was code to support set literals (on Python 2.7 and newer), but it
was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place,
instead it returns a new set object that is then silently discarded.
I added a unit test and fixed the code. I also changed the version
check to use sys.version_tuple instead of a string comparison, for
consistency with the subsequent Python 3.4 version check that I added in
the previous commit.
10 years ago
Marius Gedminas
2b73002044
Python 3: make ansible.template.safe_eval() work
...
Two things changed in Python 3.4:
- 'basestring' is no longer defined, so use six.string_types
- True/False are now special AST node types (NamedConstant) rather than
just names
(Good thing we had tests, or I wouldn't have noticed the 2nd thing!)
I found only one place where safe_eval() is called inside the ansible
codebase: in lib/template/__init__.py. The call to safe_eval(result,
...) is protected by result.startswith('...'), which means result cannot
possibly be a byte string on Python 3 (or startswith() would raise, so
six.string_types (which excludes byte strings on Python 3) is fine here.
10 years ago
James Cammarata
0c5bbe3c32
Use the original (un-templated) args for include params
...
Fixes #12314
10 years ago
James Cammarata
292e2da4e1
Fix some bugs related to facts/nonpersistent-facts cache split
...
Fixes #12313
10 years ago
Brian Coca
91c9df2154
added verbosity to ansible-doc to make it easier to trace down issues
10 years ago
James Cammarata
b35529b09f
Submodule pointer update
10 years ago
James Cammarata
95a58d1178
Properly serialize UnsafeProxy objects
...
Required as part of fix for #12123
10 years ago
James Cammarata
a410bf26d3
Wrap registered variables in UnsafeProxy
...
Fixes #12123
10 years ago
Toshio Kuratomi
46bf3d1bc1
Remove plugin._basedirs as we now use different data structures to achieve that functionality.
10 years ago
Jiri tyr
174f805fb3
Resurrection of the comment filter
10 years ago
Marius Gedminas
b95e3d18a7
Python 3: use the right PyYAML SafeRepresenter for unicode
...
PyYAML has a SafeRepresenter in lib/... that defines
def represent_unicode(self, data):
return self.represent_scalar(u'tag:yaml.org,2002:str', data)
and a different SafeRepresenter in lib3/... that defines
def represent_str(self, data):
return self.represent_scalar('tag:yaml.org,2002:str', data)
so the right thing to do on Python 3 is to use represent_str.
(AnsibleUnicode is a subclass of six.text_type, i.e. 'str' on Python 3.)
10 years ago
Benno Joy
6de13c3062
Merge pull request #11818 from Java1Guy/module_utils_ec2_for_ecs
...
change ec2 util to create only requested objects
10 years ago
James Cammarata
ee7905c7e1
Compare include params against deprecated param names too
...
Fixes #12282
10 years ago
James Cammarata
950e067d2f
Merge pull request #12295 from napkindrawing/patch-3
...
Typo in comment: "bsaename" → "basename"
10 years ago
James Cammarata
f576e0f1af
Merge pull request #12300 from robusto/devel
...
Vault missing DataLoader for pwd file #12293
10 years ago
James Cammarata
22639a2a22
Fix mistake in fact setting to nonpersistent cache in VariableManager
...
Fixes #12301
10 years ago
James Cammarata
aa3b290efd
Fix indent on line in playbook executor
10 years ago
Toshio Kuratomi
4b895f04e3
Fix order of loading of modules.
...
Allows ANSIBLE_LIBRARY to overload core modules even if the module in
ANSIBLE_LIBRARY doesn't have a .py extension.
10 years ago
James Cammarata
e81947c3b4
Fix vars_prompt short form support (and mark deprecated)
10 years ago
Blake Atkinson
6062519986
Vault missing DataLoader for pwd file #12293
10 years ago
James Cammarata
be7bd392cb
Fix unreachable host detection and have plays continue after unreachable failures
...
Fixes #12284
10 years ago
Toshio Kuratomi
25c97fff69
Merge pull request #12294 from ansible/fix-password-lookup
...
Fix problem with "=" in the initial file path.
10 years ago
Brian Coca
0dbebfddaa
Revert "remove closing connections after every task, this goes against conneciton caching and was not expected behaviuor nor inhertited from v1"
...
needed for winrm, disabled closing connections in ssh to avoid issues with that persistance, need to normalize all this in future
This reverts commit 23a22397bf .
10 years ago
Brian Coca
3f0e14c2a0
disabled ssh closing connections
10 years ago
Toshio Kuratomi
e2c49b4ef4
Fix problem with "=" in the initial file path.
10 years ago
James Cammarata
56d7f3889d
Add new level of vars to deal with set_fact/register precedence rules
10 years ago
napkindrawing
172bbac97a
Typo in comment: "bsaename" → "basename"
10 years ago
James Cammarata
926f127245
set_fact should put facts in the fact_cache, not vars_cache
...
Also fixes a template path lookup issue when using an include
Fixes #12277
10 years ago
Toshio Kuratomi
e2e9319f06
Merge pull request #12287 from mgedmin/py3k
...
Python 3: use six.string_types instead of basestring
10 years ago
Toshio Kuratomi
fa2edfa1ef
* Make sure we don't sometimes get byte strings instead of unicode strings
...
* Turn strings into byte strings before passing to shlex and turn them
back into unicode strings after they are retyurned from there
Fixes #12257
10 years ago
Toshio Kuratomi
e67459df86
Fix docstring of parse_value() to be informative
10 years ago
Marius Gedminas
ba0cf42ce9
Python 3: use six.string_types instead of basestring
...
Reduces the number of failing tests from 35 to 17.
10 years ago
James Cammarata
30399edada
Use UnsafeProxy for lookup results too
...
Also fixes a couple of bugs that popped up when using the proxy class
10 years ago
Brian Coca
f1c72a55a5
Merge pull request #12261 from toshywoshy/12169
...
added Manjaro as an Archlinux family
10 years ago
Victor Costan
bd405169fb
Fix #12258 : don't wrap None in UnsafeProxy.
10 years ago
James Cammarata
ac6f61ec7f
Properly handle group/host_var files with dots in them
...
Fixes #12245
10 years ago
James Cammarata
1eb5b42705
Don't double proxy unsafe variables
...
Potential fix for #12260
10 years ago
Gaurav Jain
6c107258fa
Fix rsync connections to IPv6 addresses
...
Similar to https://github.com/ansible/ansible/pull/11816 we can unconditionally
wrap the host address in square brackets. This is required by rsync for IPv6
addresses.
10 years ago
h-hirokawa
cd478a76fc
Add the new module replacer <<INCLUDE_ANSIBLE_MODULE_JSON_ARGS>>.
...
Fixes #12266
10 years ago
Toshio Kuratomi
718812d945
update submodule refs for documentation formatting
10 years ago
Toshio Kuratomi
26e109aa13
Update module refs
10 years ago
Toshaan Bharvani
4702d2be09
added Manjaro as an Archlinux family
10 years ago
James Cammarata
ff9f5d7dc8
Starting to add additional unit tests for VariableManager
...
Required some rewiring in inventory code to make sure we're using
the DataLoader class for some data file operations, which makes mocking
them much easier.
Also identified two corner cases not currently handled by the code, related
to inventory variable sources and which one "wins". Also noticed we weren't
properly merging variables from multiple group/host_var file locations
(inventory directory vs. playbook directory locations) so fixed as well.
10 years ago
James Cammarata
87f75a50ad
Use proxy class to mark variables unsafe for templating
...
Fixes #12191
10 years ago
Toshio Kuratomi
2d251cba45
Merge pull request #12256 from ansible/password-lookup-fix
...
Use parse_kv to correctly parse parameters from password lookup
10 years ago
Toshio Kuratomi
c68e04c185
Use parse_kv to correctly parse parameters from password lookup
...
Fixes https://github.com/ansible/ansible-modules-core/issues/1968
10 years ago
Brian Coca
6e5f3db9de
updated submodule refs
10 years ago
Brian Coca
c17fbf2f12
simplify become testing and handling, we had drifted and were doulbe checking prompt, become and become_pass
...
fixed tests to conform to new signature and now tests both with and w/o password
now we are more explicit about self.prompt
10 years ago
Brian Coca
eb0e7e198b
remove closing connections after every task, this goes against conneciton caching and was not expected behaviuor nor inhertited from v1
10 years ago
Marius Gedminas
37be9539ff
Python 3: use six.text_type instead of unicode
...
Replace 'unicode' with six.text_type, everywhere but in module_utils.
10 years ago
James Cammarata
1840906f74
Merge pull request #12236 from amenonsen/ssh-cpdir
...
Go back to using ~/.ansible/cp as the ControlPath
10 years ago
Toshio Kuratomi
e218bf8da9
Do not escape backslashes when processing a template file.
...
Fixes #12198
Fixes #12241
10 years ago
Abhijit Menon-Sen
7aa6cd3f63
Go back to using ~/.ansible/cp as the ControlPath
...
This was commented out earlier because of the lack of interprocess
locking and prepare_writeable_dir in v2.
The locking was not needed: it could only protect against other siblings
of this process (since they were all locking a temporary file that was
opened in the parent), and those would be running as the same user and
with the same umask. Also, os.makedirs() tolerates intermediate paths
being created by other processes. For any other kind of error, both
locking and non-locking code paths would fail in the same way.
So all we really need to do is make sure we have write permissions.
(We also move the cp_dir handling code to where we actually set the
ControlPath ourselves; if the user has set it via ssh_*args already,
we don't need to bother.)
10 years ago
James Cammarata
4ac2bafc4b
Set hosts fact gathering flag based on fact cache entries
...
Fixes #12213
10 years ago
James Cammarata
6650ba7654
Squashed commit of the following:
...
commit 9921bb9d20
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Mon Aug 10 20:19:44 2015 +0530
Document --ssh-extra-args command-line option
commit 8b25595e7b
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Thu Aug 13 13:24:57 2015 +0530
Don't disable GSSAPI/Pubkey authentication when using --ask-pass
This commit is based on a bug report and PR by kolbyjack (#6846 ) which
was subsequently closed and rebased as #11690 . The original problem was:
«The password on the delegated host is different from the one I
provided on the command line, so it had to use the pubkey, and the
main host doesn't have a pubkey on it yet, so it had to use the
password.»
(This commit is revised and included here because #11690 would conflict
with the changes in #11908 otherwise.)
Closes #11690
commit 119d032389
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Thu Aug 13 11:16:42 2015 +0530
Be more explicit about why SSH arguments are added
This adds vvvvv log messages that spell out in detail where each SSH
command-line argument is obtained from.
Unfortunately, we can't be sure if, say, self._play_context.remote_user
is obtained from ANSIBLE_REMOTE_USER in the environment, remote_user in
ansible.cfg, -u on the command line, or an ansible_ssh_user setting in
the inventory or on a task or play. In some cases, e.g. timeout, we
can't even be sure if it was set by the user or just a default.
Nevertheless, on the theory that at five v's you can use all the hints
available, I've mentioned the possible sources in the log messages.
Note that this caveat applies only to the arguments that ssh.py adds by
itself. In the case of ssh_args and ssh_extra_args, we know where they
are from, and say so, though we can't say WHERE in the inventory they
may be set (e.g. in host_vars or group_vars etc.).
commit b605c285ba
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Tue Aug 11 15:19:43 2015 +0530
Add a FAQ entry about ansible_ssh_extra_args
commit 49f8edd035
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Mon Aug 10 20:48:50 2015 +0530
Allow ansible_ssh_args to be set as an inventory variable
Before this change, ssh_args could be set only in the [ssh_connection]
section of ansible.cfg, and was applied to all hosts. Now it's possible
to set ansible_ssh_args as an inventory variable (directly, or through
group_vars or host_vars) to selectively override the global setting.
Note that the default ControlPath settings are applied only if ssh_args
is not set, and this is true of ansible_ssh_args as well. So if you want
to override ssh_args but continue to set ControlPath, you'll need to
repeat the appropriate options when setting ansible_ssh_args.
(If you only need to add options to the default ssh_args, you may be
able to use the ansible_ssh_extra_args inventory variable instead.)
commit 37c1a5b679
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Mon Aug 10 19:42:30 2015 +0530
Allow overriding ansible_ssh_extra_args on the command-line
This patch makes it possible to do:
ansible somehost -m setup \
--ssh-extra-args '-o ProxyCommand="ssh -W %h:%p -q user@bouncer.example.com"'
This overrides the inventory setting, if any, of ansible_ssh_extra_args.
Based on a patch originally by @Richard2ndQuadrant.
commit b023ace8a8
Author: Abhijit Menon-Sen <ams@2ndQuadrant.com>
Date: Mon Aug 10 19:06:19 2015 +0530
Add an ansible_ssh_extra_args inventory variable
This can be used to configure a per-host or per-group ProxyCommand to
connect to hosts through a jumphost, e.g.:
inventory:
[gatewayed]
foo ansible_ssh_host=192.0.2.1
group_vars/gatewayed.yml:
ansible_ssh_extra_args: '-o ProxyCommand="ssh -W %h:%p -q bounceuser@gateway.example.com"'
Note that this variable is used in addition to any ssh_args configured
in the [ssh_connection] section of ansible.cfg (so you don't need to
repeat the ControlPath settings in ansible_ssh_extra_args).
10 years ago
James Cammarata
8774ff5f57
Make sure PlayContext is copied when iterating in a with_ loop
10 years ago
James Cammarata
c16961db60
Fix two PlayIterator bugs
...
* When iterating over a child state, a failure should be propagated
up so parent blocks don't continue iterating
* Make sure a child state exists before trying to search it
Fixes #12210
10 years ago
Marius Gedminas
38a96d7e8f
Python 3: avoid iteritems() in a template
...
I don't think six.iteritems is available here, but I also don't expect
there to be enough platforms to ever make the speed difference between
.items() and .iteritems() noticeable.
10 years ago
Toshio Kuratomi
364313c01f
Simplify and speed up _split_role_params() by moving an invariant outside of a loop.
10 years ago
Toshio Kuratomi
1ae28f606b
Refactor to replace filter and lambda with a generator expression
10 years ago
Marius Gedminas
a32bf1ec18
Simplify FactCache.copy()
...
Also fix the bug (missing from six import iteritems) I introduced in
823677b490 .
10 years ago
Marius Gedminas
823677b490
Replace .iteritems() with six.iteritems()
...
Replace .iteritems() with six.iteritems() everywhere except in
module_utils (because there's no 'six' on the remote host). And except
in lib/ansible/galaxy/data/metadata_template.j2, because I'm not sure
six is available there.
10 years ago
James Cammarata
9e1bc434c7
Further cleanup from locking changes
10 years ago
James Cammarata
b93f27e260
Move the lockfile back to tqm to make sure it stays unique
10 years ago
James Cammarata
b9afbf0ee4
Reorganizing the way the connection lockfile is created
10 years ago
James Cammarata
7034bbef30
Merge branch 'connection-locking' of https://github.com/amenonsen/ansible into amenonsen-connection-locking
10 years ago
Abhijit Menon-Sen
9378c8e2da
Make the paramiko plugin use locking
10 years ago
Abhijit Menon-Sen
5887e96b27
Introduce a connection locking infrastructure
...
The lock file is (a temporary file) opened in the parent process, whose
open fd is inherited by the workers after fork, and passed down through
the PlayContext. Connection grows lock/unlock methods which can be used
by individual connection plugins.
10 years ago
Abhijit Menon-Sen
12d8f9132e
Make lock_host_keys a real noop, instead of half-a-noop
...
Right now, we don't do any locking, but we still scan known_hosts files
twice per connection. That's completely unnecessary, and the proposed
solutions to the locking problem wouldn't need known_hosts scanning
anyway, so this code can go away.
10 years ago
Brian Coca
a006e85947
removed printing module args as it violates no_log settings
10 years ago
Toshio Kuratomi
1998eddf8d
Keep newlines by default now.
...
In v1, a trailing newline was kept if the parameter was passed as key=value. If
the parameter was passed as yaml dict the trailing newline was
discarded. Since key-value and yaml dict were unified in v2 we have to
make a choice as to which behaviour we want. Decided that keeping trailing
newlines by default made the most sense.
Fixes #12200
Fixes #12199
10 years ago
Toshio Kuratomi
41da8de094
Speedup for counting newlines
10 years ago
James Cammarata
843138e7d9
Merge pull request #12202 from mgedmin/py3k
...
Use rich comparisons for Attribute and FieldAttribute
10 years ago
James Cammarata
5434ed973b
Make sure locals in safe_eval is a plain dict when running eval
...
Fixes #12206
10 years ago
Toshio Kuratomi
417bf1c805
Unittest the _count_trailing_newlines function
10 years ago
Toshio Kuratomi
7ed746ad45
Fix preserve_trailing_newlines (broken by 7f5080f64a )
...
Fix for one half of hte bug reported in #12198
10 years ago
Brian Coca
a7231c2203
actually implemented flags correctly for all priv escalation methods
10 years ago
Brian Coca
b9642585bd
added missing become_exe from config
10 years ago
Brian Coca
e156d9b677
fixed and generalized privilege escalation exe settings
10 years ago
Marius Gedminas
33a374edde
Use rich comparisons for Attribute and FieldAttribute
...
Because __cmp__ is not supported on Python 3.
10 years ago
Marius Gedminas
ca908f2e12
Fix indentation to be a multiple of 4
10 years ago
Abhijit Menon-Sen
147b04b682
Remove duplicated function definition (fallout from earlier repeated merge)
10 years ago
James Cammarata
f162990cb3
Properly assign the searchpath for templates to the environment loader
...
dbd755e0 previously assigned the value to self._templar.environment.searchpath,
which is incorrect - it needs to be assigned to the environment.loader.searchpath
value instead.
Fixes #11931
10 years ago
James Cammarata
2761df232e
Small tweak to 7551b75 to correct the ordering of tests
10 years ago
James Cammarata
7551b75e61
Add ispath type for constants and make sure all local paths are ispath=True
...
Fixes #12180
10 years ago
Toshio Kuratomi
aeff960d02
Cleanup combine_vars
...
* Dedupe combine_vars() code (removed from VariableManager)
* Fix merge_hash algorithm to preserve the type
* unittest combine_vars and merge_hash
10 years ago
James Cammarata
7fe495d619
Merge pull request #12187 from caphrim007/add-utf-8-encoding-to-f5-module-utils
...
Adds utf-8 encoding to f5 module_utils
10 years ago
James Cammarata
d00c445d2c
Merge pull request #12188 from amenonsen/easy-debug
...
Show module name and args with -vvv
10 years ago
Abhijit Menon-Sen
d6d523bcae
Show module name and args with -vvv
...
This information was earlier shown only with ANSIBLE_DEBUG, but it's
extremely useful in a user context, especially with module invocations
with deeply nested args like the ec2_vpc/ec2 modules.
Closes #11680
10 years ago
James Cammarata
3e1a774ba5
Don't use iteritems() in templar to avoid (hostvars) dict size change errors
10 years ago
James Cammarata
974b69d236
looped includes need unique references to prevent information bleeding
...
Fixes #12155
10 years ago
James Cammarata
a341a8a093
Make sure tasks from a role see their defaults above all others
...
Fixes #12081
10 years ago
Tim Rupp
6f41a72158
Adds utf-8 encoding to f5 module_utils
...
The contributor's name on line 10 (originally line 7) includes a character
that the default Python encoding (ASCII) raises an error on when interpreting
the file.
Specifying the utf-8 encoding, as is done in other modules, resolves
the error.
The error being raised is
SyntaxError: Non-ASCII character '\xc3' in file /.../lib/ansible/module_utils/f5.py
on line 7, but no encoding declared; see http://www.python.org/peps/pep-0263.html
for details
10 years ago
James Cammarata
a7da25d48b
Submodule update
10 years ago
James Cammarata
3d282cd1b0
Also always post_validate Handler class as well
...
Fixes #12154
10 years ago
Toshio Kuratomi
12edbfeb0b
Merge pull request #12177 from mgedmin/py3k
...
Make combine_vars() compatible with Python 3
10 years ago
Brian Coca
66e2eb2231
removed as it does not fool setup.py to include data and it must be specified in setup.py
10 years ago
Marius Gedminas
54dbfba8f8
Make combine_vars() compatible with Python 3
...
Fixes
TypeError: unsupported operand type(s) for +: 'dict_items' and 'dict_items'
on Python 3.
10 years ago
James Cammarata
5adcd7054b
Allow setup to run when using --start-at-task
...
Fixes #12147
10 years ago
Brian Coca
7458331539
package and service now check that module exists before trying to execute it
10 years ago
Toshio Kuratomi
9d193d8fb4
Merge pull request #12173 from ansible/pr/10204
...
Rebase of 10204 - Add host key for ssh url only.
10 years ago
James Cammarata
fca27c29f4
Properly fail if slurp fails during fetch
10 years ago
Desmond O. Chang
58c3539196
Add host key for ssh url only.
...
Rewrite function `get_fqdn`. It returns fqdn for all kinds of urls now.
`add_git_host_key` determines whether a url is ssh and whether its host
key should be added.
10 years ago
James Cammarata
66a2f2923e
Look for proper values in slurp result during fetch with become enabled
10 years ago
Toshio Kuratomi
7f5080f64a
Fix backslash escaping inside of jinja2 expressions
...
Fixes #11891
10 years ago
Toshio Kuratomi
5ae300a084
Update module refs
10 years ago
Brian Coca
6b73cac35a
corrected skipped_hosts constant usage, thanks @benjixx
10 years ago
Brian Coca
5a65dce6fb
fix issues with csh redirection
10 years ago
Brian Coca
b525eedb8e
less misleading message for when someone looks up vars for a host not in inventory
10 years ago
Brian Coca
6154ed1dda
Merge pull request #12146 from thekarlbrown/patch-1
...
Fixed Spelling Error on Line 67
10 years ago
James Cammarata
f0257683b0
Fixed missing constants import in default callback
...
Fixes #12145
10 years ago
James Cammarata
057712c129
Also move action/connection plugins to shared plugin loader code
...
Fixes #12099
10 years ago
James Cammarata
0859ba7726
Adjust field loading order for vars and tweak post_validate exclusion logic
...
FieldAttributes will now by default not be post_validated unless a flag
is set on them in the class, as a large number of fields are really there
simply to be inherited by Task/PlayContext and shouldn't be templated too
early.
The other (unrelated to the base issue) in #12084 is also fixed here, where
the roles field is loaded before vars/vars_files, meaning there are no vars
yet loaded in the play when the templating occurs.
Fixes #12084
10 years ago
Karl Brown
9aae1d5810
Fixed Spelling Error on Line 67
...
Noticed while running Ansible from Tip.
Throws: NameError: global name 'tself' is not defined
10 years ago
James Cammarata
4c65306e73
Merge branch 'hostrange' of https://github.com/amenonsen/ansible into amenonsen-hostrange
11 years ago
Toshio Kuratomi
120243d36d
Fix python3.4 syntax
11 years ago
James Cammarata
2043fcd5db
Merge pull request #12083 from resmo/for-ansible
...
cloudstack: implement general api_region support, update docs
11 years ago
Brian Coca
b6c6ed91fe
implemented not showing skipped hosts config
11 years ago
Brian Coca
514fa73fcd
galaxy fixes
11 years ago
James Cammarata
66ed397360
Fix redis fact_caching_timeout=0 bug
...
Fixes #12018
11 years ago
James Cammarata
5a5b9f211b
Validate variable names when loading 'vars:' blocks
...
TODO: add this to VariableManager to validate vars loaded from files too
Fixes #12022
11 years ago
James Cammarata
266a069a73
Merge pull request #12107 from TravisPaul/devel
...
Update "smart" transport to handle Sun_SSH_1.5 on SmartOS
11 years ago
Brian Coca
48aa0dd1c7
now acknowledges ask_pass setting from ansible.cfg
...
fixes #12111
11 years ago
James Cammarata
399d215f5a
Merge pull request #12122 from maty0609/devel
...
Adding support for Archlinux and Slackware in fallback
11 years ago
Marius Gedminas
eb99aa8c68
Fix to_bytes(None) on Python 3
...
You cannot call bytes(obj) to get a simple representation of obj on
Python 3! E.g. bytes(42) returns a byte string with 42 NUL characters
instead of b'42'.
11 years ago
Marius Gedminas
df1b41d3d3
Avoid types.NoneType
...
types.NoneType was removed in Python 3.
None is a singleton in Python, so 'x is None' is equivalent to
'isinstance(x, NoneType)'.
11 years ago
Marius Gedminas
da1e611b26
Support print as a function
...
I neglected the __future__ import because
print(one_thing)
works the same way even when print is a statement.
11 years ago
Marius Gedminas
39196ec91e
Drop the L suffix on numerical constants
...
Python has had automatic int-to-long promotion for a long long time now.
Even Python 2.4 does that automatically.
Python 3 drops support for the L suffix altogether.
11 years ago
Marius Gedminas
0eb538df03
Use 0oNNN octal syntax
...
This syntax is valid in Python 2.6+ and 3.x.
11 years ago
Marius Gedminas
47b088504d
Don't mix tabs and spaces
...
It's not allowed in Python 3 and merely a bad idea in Python 2.
11 years ago
Marius Gedminas
0c6ce31f76
Use 'except ... as' syntax
...
This syntax works on Python 2.6 through 3.x. lib/ansible/module_utils
(and lib/ansible/modules) need to support Python 2.4, so I didn't touch
those.
11 years ago
Brian Coca
2ac931d6c9
ported module_docs to use display
11 years ago
Brian Coca
2b28cdc0dd
be more tolerant with non list descriptions
11 years ago
Toshio Kuratomi
86b2982005
Merge pull request #12112 from amenonsen/vault-stdio
...
Implement cat-like filtering behaviour for encrypt/decrypt
11 years ago
Toshio Kuratomi
db4a96a8d6
Merge pull request #12078 from amenonsen/hash_merge
...
Add hash_merge and hash_merge_recursive filters with documentation
11 years ago
Abhijit Menon-Sen
b328bc023d
Add a combine filter with documentation
...
This is based on some code from (closed) PR #7872 , but reworked based on
suggestions by @abadger and the other core team members.
Closes #7872 by @darkk (hash_merge/hash_replace filters)
Closes #11153 by @telbizov (merged_dicts lookup plugin)
11 years ago
James Cammarata
2df6513f8d
Version bump for v2.0.0-0.1.alpha1 and submodule updates
11 years ago
Brian Coca
6c9dc78d8c
Merge pull request #12126 from amenonsen/vault-aes-deprecate
...
Remove deprecated and unused VaultAES encryption code
11 years ago
James Cammarata
1170a453c8
Merge pull request #12114 from ilya-epifanov/devel
...
fixed hostvars access in conjunction with --limit usage
11 years ago
Abhijit Menon-Sen
090cfc9e03
More helpful prompts from ansible-vault encrypt/decrypt
...
Now we issue a "Reading … from stdin" prompt if our input isatty(), as
gpg does. We also suppress the "x successful" confirmation message at
the end if we're part of a pipeline.
(The latter requires that we not close sys.stdout in VaultEditor, and
for symmetry we do the same for sys.stdin, though it doesn't matter in
that case.)
11 years ago
Abhijit Menon-Sen
b6de6e69a6
Also support output to stdout with no arguments
...
This allows "cat plaintext|ansible-vault encrypt > ciphertext".
11 years ago
Abhijit Menon-Sen
e7eebb6954
Implement cat-like filtering behaviour for encrypt/decrypt
...
This allows the following invocations:
# Interactive use, like gpg
ansible-vault encrypt --output x
# Non-interactive, for scripting
echo plaintext|ansible-vault encrypt --output x
# Separate input and output files
ansible-vault encrypt input.yml --output output.yml
# Existing usage (in-place encryption) unchanged
ansible-vault encrypt inout.yml
…and the analogous cases for ansible-vault decrypt as well.
In all cases, the input and output files can be '-' to read from stdin
or write to stdout. This permits sensitive data to be encrypted and
decrypted without ever hitting disk.
11 years ago
Abhijit Menon-Sen
32b38d4e29
Fix add_option indentation for consistency before adding another option
11 years ago
Abhijit Menon-Sen
8fc8bf9439
Simplify VaultEditor methods
...
We don't need to keep creating VaultLibs everywhere, and we don't need
to keep checking for errors because VaultLib does it already.
11 years ago
Abhijit Menon-Sen
e99395f0c0
Don't create a VaultLib in each method; do it in __init__ instead
11 years ago
Abhijit Menon-Sen
159887a6c9
Remove deprecated and unused VaultAES encryption code
...
Now that VaultLib always decides to use AES256 to encrypt, we don't need
this broken code any more. We need to be able to decrypt this format for
a while longer, but encryption support can be safely dropped.
11 years ago
maty0609
52e94468c9
Merge remote-tracking branch 'ansible/devel' into devel
11 years ago
maty0609
6f24e6f994
Adding support for Archlinux and Slackware in fallback
...
In some cases Archlinux and Slackware is not detected by
platform.dist(). This should solve the issue.
11 years ago
Brian Coca
b2bfe3502b
make sure delimiter is basestring for cvsfile
...
fixes #12062
11 years ago
Ilya Epifanov
81bf88b6e0
fixed hostvars access in conjunction with --limit usage
11 years ago
James Cammarata
0441a7a217
Finishing off porting of chroot connection plugin
11 years ago
Toshio Kuratomi
017bd7b1cd
Fix synchronize lookup of localhost info
11 years ago
James Cammarata
50448d68e1
Implement max_fail_percentage and any_errors_fatal support
...
Fixes #11997
11 years ago
James Cammarata
af41ba929c
Add float and percent types for FieldAttributes
...
Also sets the max_fail_percentage value to the percent type.
11 years ago
Brian Coca
b2ae6945c4
always load vars plugins
...
fixes #12104
11 years ago
Travis Paul
604f825a8e
Update "smart" transport to handle Sun_SSH_1.5 on SmartOS
11 years ago
Toshio Kuratomi
111c0cc204
Merge pull request #12106 from amenonsen/vault-cleanups
...
Vault cleanups, pass #1
11 years ago
Abhijit Menon-Sen
b84053019a
Make the filename the first argument to rekey_file
11 years ago
Toshio Kuratomi
5df5a14edc
Merge pull request #12101 from tquenolle/devel
...
Synchronize fix error
11 years ago
Abhijit Menon-Sen
20fd9224bb
Pass the filename to the individual VaultEditor methods, not __init__
...
Now we don't have to recreate VaultEditor objects for each file, and so
on. It also paves the way towards specifying separate input and output
files later.
11 years ago
Brian Coca
82603bb2a0
avoids running abspath on None
11 years ago
Abhijit Menon-Sen
a27c5741a1
Remove inaccurate outdated comment
11 years ago
Abhijit Menon-Sen
f91ad3dabe
Don't pass the cipher around so much
...
It's unused and unnecessary; VaultLib can decide for itself what cipher
to use when encrypting. There's no need (and no provision) for the user
to override the cipher via options, so there's no need for code to see
if that has been done either.
11 years ago
Abhijit Menon-Sen
017566a2d9
Use AES256 if the cipher is not write-whitelisted
11 years ago
Abhijit Menon-Sen
47bcdf5952
Remove incorrect copy-pasted comment
11 years ago
Thomas Quenolle
c948af3b1e
Synchronize fix error
...
Fix the error:
"RuntimeError: dictionary changed size during iteration"
11 years ago
James Cammarata
601a1cc6d9
Multiple fixes for include statements and blocks in general
...
Fixes #11981
Fixes #11995
Fixes #12039
Fixes #12077
11 years ago
Brian Coca
154754ae50
pushed module_loader to task_queue_manager so all cli's can benefit from it
...
also normalized -M option across all cli
fixes #12016
11 years ago
Toshio Kuratomi
d2c948dd6a
Remove decrypted vault temp_file mistakenly left from patch making vault edit idempotent
...
This bug was introduced in commit f8bf2ba on July 27. Hasn't gone out
in a release yet.
11 years ago
Toshio Kuratomi
56ae3a032f
Merge pull request #12075 from ansible/fix-vault-unicode
...
Unicode and other fixes for vault
11 years ago
Toshio Kuratomi
a3fd4817ef
Unicode and other fixes for vault
11 years ago
Toshio Kuratomi
16e8a7dd67
Merge pull request #11767 from amenonsen/vault-new-password-file
...
add option to ansible-vault to read new password from file for rekey
11 years ago
Toshio Kuratomi
156feec264
Merge pull request #11650 from objectified/feature-docker-connection
...
allow ansible to connect to docker containers (without using ssh)
11 years ago
Abhijit Menon-Sen
8bf0dbb7a9
Use [x:y] host ranges instead of [x-y]
...
This commit deprecates the earlier groupname[x-y] syntax in favour of
the inclusive groupname[x:y] syntax. It also makes the subscripting
code simpler and adds explanatory comments.
One problem addressed by the cleanup is that _enumeration_info used to
be called twice, and its results discarded the first time because of the
convoluted control flow.
11 years ago
Abhijit Menon-Sen
73f10de386
Document the behaviour of _match_one_pattern in some detail
...
The possibilities are complicated enough that I didn't want to make
changes without having a complete description of what it actually
accepts/matches. Note that this text documents current behaviour, not
necessarily the behaviour we want. Some of this is undocumented and may
not be intended.
11 years ago
Abhijit Menon-Sen
fa6ffa1dbd
Remove & and ! pattern prefixes as early as possible
...
Now everything under _match_one_pattern can ignore them. This also means
that we can use the cache to return the same results for 'foo' and '!foo'.
11 years ago
Abhijit Menon-Sen
704c3815d3
Reorder functions into a logical sequence based on usage
...
There are no code changes; this is committed separately so as to make
the subsequent "real" diffs easier to read.
11 years ago
Richard Poole
3090a45891
add option to ansible-vault to read new password from file for rekey
...
The --new-vault-password-file option works the same as
--vault-password-file but applies only to rekeying (when
--vault-password-file sets the old password). Also update the manpage
to document these options more fully.
11 years ago
Brian Coca
ae91cdfc98
fixed environment inheritance
11 years ago
Brian Coca
8aa732e0a4
allow for lists, sets and dicts to default to None, now return empty type in post processing
...
remove defaults from inhertiable fieldattributes to allow for proper detection and override
11 years ago
Marius Gedminas
44c94328c8
Speed up execution
...
`if method in dir(self):` is very inefficient:
- it must construct a list object listing all the object attributes & methods
- it must then perform a O(N) linear scan of that list
Replace it with the idiomatic `if hasattr(self, method):`, which is a
O(1) expected time hash lookup.
Should fix #11981 .
11 years ago
Rene Moser
3db4039ad1
cloudstack: implement general api_region support, update docs
11 years ago
objectified
b1785a0361
replace compare_versions() with distutils.version
11 years ago
objectified
c39fb43ad9
added Maintainer comment header
11 years ago
Toshio Kuratomi
1f7b0fee0a
Fixes #12076
11 years ago
Brian Coca
17060f9849
remove +1 from size that was cutting off first char of copied files when a recursive dir
...
fixes #12055
11 years ago
Toshio Kuratomi
6e107d2f22
Comments pointing the way towards substituting cryptography for pycrypto
11 years ago
Brian Coca
16f3f8e244
now does not error out when notes are not included in module
11 years ago
objectified
d9723069c5
align exec_command() definition with local.py
11 years ago
objectified
3a5522a22c
fake being connected for logging purposes
11 years ago
objectified
8f2a6a9fae
use docker cp when docker >=1.8.0
11 years ago
objectified
2de773477f
allow ansible to connect to docker containers
11 years ago
James Cammarata
21e421ce53
Validate required list items are not None or empty strings
...
Fixes #12011
11 years ago
James Cammarata
db65503778
Revert "Add PowerShell exception handling and turn on strict mode."
11 years ago
Abhijit Menon-Sen
3aedc0bca9
Don't insist on ansible-vault taking only one filename parameter
...
Apart from ansible-vault create, every vault subcommand is happy to deal
with multiple filenames, so we can check that there's at least one, and
make create check separately that there aren't any extra.
11 years ago
Brian Coca
f1b8323b62
fixed host/group var loading when inventory is a directory
11 years ago
Brian Coca
af06a97f17
kept vars as alias to hostvars[inventory_hostname] and avoid subtrees into themselves
11 years ago
Brian Coca
3ccfebc9f7
Merge pull request #12047 from cchurch/powershell_common_cleanup
...
Add PowerShell exception handling and turn on strict mode.
11 years ago
Brian Coca
a4ffa09414
Merge pull request #11880 from bcoca/configurable_squash
...
made squashable with_ plugin list configurable
11 years ago
Abhijit Menon-Sen
09e4eac2e5
Use rsplit(':',1) for clarity; no functional changes
11 years ago
Ryan Petrello
1886307845
Fix a parsing bug that prevents IPv6 addresses from being used with `add_host`
...
Closes #8682
11 years ago
Chris Church
4b2cdadc98
Add PowerShell exception handling and turn on strict mode.
...
* Add exception handling when running PowerShell modules to provide exception message and stack trace.
* Enable strict mode for all PowerShell modules and internal commands.
* Update common PowerShell code to fix strict mode errors.
* Fix an issue with Set-Attr where it would not replace an existing property if already set.
* Add tests for exception handling using modified win_ping modules.
11 years ago
Brian Coca
47d9e7ca93
Merge pull request #11984 from Alphadelta14/devel
...
Support any Mapping for with_dict lookup.
11 years ago
James Cammarata
0958edfc7c
Submodule pointer update
11 years ago
Brian Coca
e8157eab19
now output works for both search and info
11 years ago
Brian Coca
a6c0661d21
made src more prominent
11 years ago
Brian Coca
6ffd9c3025
draft galaxy cli search
...
TODO: paging results
11 years ago
James Cammarata
e282309f6d
Make sure the inventory restriction is not None
11 years ago
James Cammarata
635fa0757b
Several var fixes
...
* Fixes hostvar serialization issue (#12005 )
* Fixes regression in include_vars from within a role (#9498 ), where
we had the precedence order for vars_cache (include_vars, set_fact)
incorrectly before role vars.
* Fixes another bug in which vars loaded from files in the format of
a list instead of dictionary would cause a failure.
Fixes #9498
Fixes #12005
11 years ago
Brian Coca
144da7e7d1
Merge pull request #11765 from ldx/vault_pbkdf2hmac
...
Use PBKDF2HMAC() from cryptography for vault keys.
11 years ago
Brian Coca
f150fe2c23
moved mandatory back to filters as it does not always return a boolean, it does an exception on failure
11 years ago
Brian Coca
2787b3acac
ported consul_kv lookup from v1
11 years ago
Brian Coca
74079db8d2
ported dig lookup from v1
11 years ago
Brian Coca
9bb95b5235
Merge pull request #12031 from amenonsen/deadcode
...
Remove unused (copied) _before_comment method
11 years ago
Brian Coca
f6b6ed530b
added file tests
11 years ago
Brian Coca
cd4a0c70b0
isnotanumber is not needed as jinja2 has builtin number test
11 years ago
Brian Coca
fe06577ac2
fixed mandatory test
11 years ago
Abhijit Menon-Sen
599ad9cb51
Remove unused (copied) _before_comment method
...
This was copied from inventory/ini.py, but the rewritten version doesn't
use it, and shows that it isn't needed.
11 years ago
Toshio Kuratomi
b5a078a385
update submodule refs
11 years ago
Abhijit Menon-Sen
745ecd4845
Sanitize IPv6 hostname/port handling
...
Now we accept IPv6 addresses _with port numbers_ only in the standard
[xxx]:NN notation (though bare IPv6 addresses may be given, as before,
and non-IPv6 addresses may also be placed in square brackets), and any
other host identifiers (IPv4/hostname/host pattern) as before, with an
optional :NN suffix.
11 years ago
Abhijit Menon-Sen
74aab6f726
Use a self._raise_error helper and avoid passing the lineno around
...
Based on a patch by @Richard2ndQuadrant.
11 years ago
Abhijit Menon-Sen
9133cd409c
Make _parse take an array of input lines as an argument
...
(There's no compelling reason to do this right now, but should be parser
need to be called multiple times in future, this makes it easier.)
11 years ago
Abhijit Menon-Sen
98a1905796
Rename 'section' to 'groupname' to better reflect its purpose
11 years ago
Abhijit Menon-Sen
1284c49bd7
Rewrite the INI InventoryParser
...
The new code parses INI-format inventory files in a single pass using a
well-documented state machine that reports precise errors and eliminates
the duplications and inconsistencies and outright errors in the earlier
three-phase parsing code (e.g. three ways to skip comments). It is also
much easier now to follow what decisions are being taken on the basis of
the parsed data. The comments point out various potential improvements,
particularly in the area of consistent IPv6 handling.
On the ornate marble tombstone of the old code, the following
inscription is one last baffling memento from a bygone age:
- def _before_comment(self, msg):
- ''' what's the part of a string before a comment? '''
- msg = msg.replace("\#","**NOT_A_COMMENT**")
- msg = msg.split("#")[0]
- msg = msg.replace("**NOT_A_COMMENT**","#")
- return msg
11 years ago
Jon Hawkesworth
a46b500851
Add win_splitdrive filter for windows users
11 years ago
Toshio Kuratomi
4f32a61504
Merge pull request #10957 from feanil/feanil/retain_nonetypes
...
Don't convert nulls to strings.
11 years ago
Brian Coca
e8b86f448d
fix issue with improper connection override in delegation
11 years ago
Feanil Patel
892e230514
Don't convert nulls to strings.
...
This change is similar to https://github.com/ansible/ansible/pull/10465
It extends the logic there to also support none types. Right now if you have
a '!!null' in yaml, and that var gets passed around, it will get converted to
a string.
eg. defaults/main.yml
```
ENABLE_AWESOME_FEATURE: !!null # Yaml Null
OTHER_CONFIG:
secret1: "so_secret"
secret2: "even_more_secret"
CONFIG:
hostname: "some_hostname"
features:
awesame_feature: "{{ ENABLE_AWESOME_FEATURE}}"
secrets: "{{ OTHER_CONFIG }}"
```
If you output `CONFIG` to json or yaml, the feature flag would get represented in the output
as a string instead of as a null, but secrets would get represented as a dictionary. This is
a mis-match in behaviour where some "types" are retained and others are not. This change
should fix the issue.
I also updated the template test to test for this and made the changes to v2.
Added a changelog entry specifically for the change from empty string to null as the default.
Made the null representation configurable.
It still defaults to the python NoneType but can be overriden to be an emptystring by updating
the DEFAULT_NULL_REPRESENTATION config.
11 years ago
Brian Coca
22a69e2498
fixes to delegation code
11 years ago
Brian Coca
36cbd771a4
changed fixme to deprecated
11 years ago
Brian Coca
961bee00d5
centralized the definition of 'localhost'
11 years ago
Rene Moser
d16429b59c
cloudstack: rename returns for consistency
11 years ago
Abhijit Menon-Sen
2641f70e47
Reset self._groups_cache in refresh_inventory
11 years ago
Harald Laabs
73d6da757f
Make get_group run in O(n*log(n)) instead of O(n^2) by using a cache
11 years ago
Brian Coca
1b810e3101
Merge pull request #12000 from bcoca/local_action_connect
...
changed local_action to alias to connection=local vs delegate_to=locahost
11 years ago
Will West
b8865314ec
improve ansible start up time for very large inventory
...
first off, we add an oddly slow basic test of 10k item inventory
Before:
```
Ran 229 tests in 13.214s
OK
real 0m13.403s
user 0m12.106s
sys 0m1.155s
```
After:
```
Ran 230 tests in 21.328s
OK
real 0m21.516s
user 0m20.099s
sys 0m1.275s
```
since that seems like a bit long for the test to add to runtime, lets profile
`python -m cProfile -s time ./bin/ansible all -i test/units/inventory_test_data/huge_range --list-hosts`
Before:
```
1272607 function calls (1259689 primitive calls) in 8.497 seconds
Ordered by: internal time
ncalls tottime percall cumtime percall filename:lineno(function)
10000 4.393 0.000 4.396 0.000 __init__.py:395(_get_host)
20000 2.695 0.000 2.697 0.000 __init__.py:341(__append_host_to_results)
40369 0.113 0.000 0.113 0.000 {posix.lstat}
50006 0.102 0.000 0.153 0.000 __init__.py:1490(combine_vars)
40008 0.089 0.000 0.202 0.000 __init__.py:1546(_load_vars_from_path)
20195 0.088 0.000 0.088 0.000 {posix.stat}
10011 0.087 0.000 0.087 0.000 {posix.getcwd}
```
The top two lines are promising optimization targets
- populate Inventory's host cache more in _get_host, as we are looping
over all the groups anyways.
- eliminate duplicate check of whether we've already included a host
in the construction around __append_host_to_results we can infer
presence of a host in the results list implies the presence of its
name in the hostnames set, allowing us to only to the less expensive
of the two checks
After:
```
1252610 function calls (1239692 primitive calls) in 1.320 seconds
Ordered by: internal time
ncalls tottime percall cumtime percall filename:lineno(function)
40369 0.105 0.000 0.105 0.000 {posix.lstat}
50006 0.094 0.000 0.141 0.000 __init__.py:1490(combine_vars)
40008 0.081 0.000 0.184 0.000 __init__.py:1546(_load_vars_from_path)
10011 0.080 0.000 0.080 0.000 {posix.getcwd}
20195 0.074 0.000 0.074 0.000 {posix.stat}
10002 0.069 0.000 0.261 0.000 __init__.py:1517(load_vars)
```
11 years ago
Brian Coca
7a4a156d91
changed local_action to alias to connection=local vs delegate_to=localhost
...
fixes #11998 , but still leaves issue of delegate_to: localhost not working
11 years ago
Brian Coca
f2c6785897
Merge pull request #11989 from bcoca/osx_queue_fix
...
changed check to avoid OS X broken sem_getvalue()
11 years ago
Brian Coca
26ed50ecdf
fixed indent
11 years ago
Brian Coca
2198f48f54
changed check to avoid OS X broken sem_getvalue()
...
fixes #11988
11 years ago
Brian Coca
e081a73aa1
make new inventory config take precedence over old hostfile config
...
fixes #11907
11 years ago
Brian Coca
17b4b1f85c
added ability to limit in ansilbe pull
...
refactored the options a bit, new inventory_opts made sense to always group
fixes #7917
11 years ago
Brian Coca
1acb29ff9b
sequence will now run once for start=end, added test to suite
...
fixes #11979
11 years ago
Brian Coca
ee21ebaffc
Merge pull request #11975 from mutemule/become_doas
...
Add become support for OpenBSD doas
11 years ago
Damian Gerow
1c5611100e
Add become support for OpenBSD doas
11 years ago
Alphadelta14
77b60a1a67
Support any Mapping for with_dict lookup.
...
This resolves 3939348286 breaking `with_dict: hostvars`.
11 years ago
Brian Coca
c419cacb04
check if host task is none before continuing
...
fixes #11982
11 years ago
James Cammarata
e7b2308b66
Performance improvements
...
* Speed up serialization of hostvars by simply using the internal
dictionary used for cached lookups
* Use blocking gets/puts on queues instead of spin locking
* Merge sequential implicitly created blocks
11 years ago
Brian Coca
4068598c15
Merge pull request #11977 from resmo/for-ansible
...
cloudstack: add more common returns
11 years ago
Rene Moser
2913d2b44d
cloudstack: add more common returns
11 years ago
Brian Coca
6058eaa92f
removed unused poller
11 years ago
Brian Coca
9b61cf5840
implemented async tasks in adhoc v2
11 years ago
Brian Coca
ee2e31b37a
now passes the test of skipping list when dict attribute is undefined, added deprecation warning as this seems like bad behaviour
11 years ago
Brian Coca
950622cebd
made sure they all look in files/vars/template dirs also when executed in play and not only from task
11 years ago
Brian Coca
861fdfc5ba
updated callbacks to properly test diff no matter if dict or list
11 years ago
Brian Coca
79ea6d3a1e
copy now passes a list of diffs
11 years ago
Brian Coca
c3372936aa
diff can now be a list
11 years ago
Brian Coca
13c91ef9d4
actually use the read source contents for the diff
11 years ago
Brian Coca
45cebd283f
added remote_src to copy, now allows copying to be done on the target server
11 years ago
Brian Coca
1b7369cc8d
added diff to assemble for remote_src=false
11 years ago
Brian Coca
f048aca5f6
runas placeholder
11 years ago
Brian Coca
49eb95e2d1
some fixes to become/sudo
...
* now it uses -n to get immediate error if no password is supplied and one is needed,
this should fix the issue with sudo hanging waiting for input.
* made -k configurable, this can break changing become_users in play if left out,
but opens up the possiblity of OTP support.
11 years ago
James Cammarata
4836641683
Use ansible_python_interpreter value for remote checksums
...
Fixes #11968
Fixes #11969
11 years ago
Brian Coca
7a51836530
check for failure in fact gathering
11 years ago
Brian Coca
1edae51e05
added generic service module, step #1 to separating services to their own modules
...
falls back to current service module and requries service mgr facts and new service modules
11 years ago
Brian Coca
172e0c328c
fixed adhoc fact gathering
11 years ago
Brian Coca
0381923333
fixed call to setup module
11 years ago
Brian Coca
92e2f54228
fixed issues with utf-8 encoding in docs, moved pager to use display class instad of bare prints
11 years ago
Brian Coca
245e0dd4b7
made returns from next task consistent to avoid typeerrors, also linear now checks for none
...
fixes #11965
11 years ago
Brian Coca
9f5e4c0ef6
lookup plugin that does no flattening
11 years ago
Abhijit Menon-Sen
8f231ec469
Tweak deprecation warning, and apply it to --limit also
11 years ago
James Cammarata
4714cbeec8
Override post validation of environment to allow bare variables
...
Also prints a deprecated warning if a bare variable is detected, so
that we can remove this in a future version.
Fixes #11912
11 years ago
James Cammarata
4dba30ccd0
Cleanup missed merge conflict sections
11 years ago
Abhijit Menon-Sen
d41db8edd6
Don't accept undocumented "p1;p2" patterns; note in changelog
...
The correct (and now only) way to say p1 OR p2 is "p1:p2".
11 years ago
Abhijit Menon-Sen
1437b8e120
Introduce _split_pattern to parse an "x:y:z" pattern
...
This function takes a string like 'foo:bar[1:2]:baz[x:y]-quux' and
returns a list of patterns ['foo', 'bar[1:2]', 'baz[x:y]-quux'], i.e.
splits the string on colons that are not part of a range specification.
11 years ago
James Cammarata
32034feec5
Add deprecation warning regarding host patterns
11 years ago
Abhijit Menon-Sen
6bf6b9fdbb
Rename some internal functions, clarify what they do
...
get_hosts → used externally, not changed
_get_hosts → _evaluate_patterns (takes a list, evaluates ! and &)
__get_hosts → _match_one_pattern (takes one pattern only, ignores !&)
11 years ago
Abhijit Menon-Sen
eff33bac49
Don't accept undocumented "p1;p2" patterns; note in changelog
...
The correct (and now only) way to say p1 OR p2 is "p1:p2".
11 years ago
Abhijit Menon-Sen
8aaa06dd50
Introduce _split_pattern to parse an "x:y:z" pattern
...
This function takes a string like 'foo:bar[1:2]:baz[x:y]-quux' and
returns a list of patterns ['foo', 'bar[1:2]', 'baz[x:y]-quux'], i.e.
splits the string on colons that are not part of a range specification.
11 years ago
Abhijit Menon-Sen
baf637b9ae
Remove dead code: Inventory.also_restrict_to/lift_also_restriction
...
This was used earlier to implement serial, but that's now done using
restrict_to_hosts() (whose docstring is also suitably adjusted here)
and there are no more callers.
11 years ago
James Cammarata
6c036c3633
Template parent include file paths
...
Fixes #11955
11 years ago
Brian Coca
b905f51341
fixed typo
11 years ago
Brian Coca
8af0ff4a58
Merge pull request #11567 from lekum/shelvefile_lookup
...
Add shelvefile lookup plugin
11 years ago
Brian Coca
fbc7224066
Merge pull request #11643 from bcoca/meta_inventory_and_fixes
...
Meta inventory and fixes
11 years ago
James Cammarata
eb381bd522
Add one more search path to path_dwim_relative
11 years ago
Brian Coca
c6733cc1a7
Merge pull request #9225 from qvicksilver/aix_unprivileged
...
AIX unprivileged facts collection
11 years ago
Brian Coca
5027f66562
Merge pull request #11864 from jhawkesworth/win_path_filters
...
add win_basename and win_dirname filters
11 years ago
James Cammarata
a498876bec
Make sure playbook includes use unique var dictionaries before modification
11 years ago
Brian Coca
5fec11f513
capture parsing exceptions and give nice error and location
11 years ago
Brian Coca
621b18c6ef
fixed source path discovery for unarchive in roles
...
fixes #11943
11 years ago
Brian Coca
70d024ffce
show errors when missing vars file or when there is syntax issue in the file
...
fixes #11945
11 years ago
Brian Coca
3d9875773b
Merge pull request #11947 from resmo/for-ansible
...
cloudstack: refactor get_result()
11 years ago
Brian Coca
2c34a5bdbd
pass list correctly to lookup
11 years ago
James Cammarata
dd67b1e4d6
Adjust relative include searches when roles are involved
...
Fixes #11895
11 years ago
Rene Moser
4f3c863b42
cloudstack: refactor get_result()
...
* A commen dict of keys has been defined, which we look in results returned from the API.
* self.returns dict can be use in subclass to extend this dict.
* Optionally the key name can be replaced with a new key name, often used to make the return keys identical to the arguments passed.
* Use new style class
11 years ago
James Cammarata
d9833f227f
Make sure cached data from file loads isn't impacted by modifications
...
Fixes #11893
11 years ago
Brian Coca
6bceee9a93
now lvs/vg facts are only attempted if binary found
11 years ago
James Cammarata
c7dde72aa0
Default listify to converting bare variables again
...
Since we explicitly set convert_bare=False in the template lookup
code, but still want individual looks that call listify directly to
convert bare variables if needed.
11 years ago
James Cammarata
ac66e4001c
Fix for variable precedence with tasks/includes
...
Fixes #11881
11 years ago
Brian Coca
2688edb32b
Merge pull request #11940 from alxgu/fix_lvm_facts
...
bugfix: missing path for lvm facts
11 years ago
Brian Coca
39f81a8fa5
removed unused imports
11 years ago
Brian Coca
c27978fa93
minor fixes to pull
11 years ago
Brian Coca
9f29e39dea
give more matching options for ansible-pull
11 years ago
Brian Coca
e46b1e8d2b
adjusted tree to work more like v1, also now skips when dir not supplied
11 years ago
Alexander Gubin
1ea1b9fb13
bugfix: missing path for lvm facts
11 years ago
Brian Coca
49d88cef9c
meta: refresh_inventory and several inventory fixes
11 years ago
Brian Coca
8e30e3791e
Merge pull request #11811 from amenonsen/fixme-range
...
FIXME in host range parsing
11 years ago
Brian Coca
ae9d264b86
Merge pull request #11762 from amenonsen/9795-rebase
...
Add LVM facts to setup module
11 years ago
James Cammarata
829a88b906
Disable undefined error failures during conditional templating
...
This allows us to properly catch the 'is defined' and 'is undefined'
checks and return the correct boolean result.
Fixes #11892
11 years ago
James Cammarata
e0b074000e
Merge pull request #11764 from lpirl/devel_v2
...
fixes remote code execution for su/sudo with strict remote umasks
11 years ago
James Cammarata
38eb53de1d
Fix bug in vars using correct temp value for vars
...
Fixes #11877
11 years ago
Brian Coca
4d853a5d3c
implemented for v2, missing --tree option for adhoc
11 years ago
Brian Coca
79a1bca010
avoid circular import
11 years ago
Brian Coca
a83b8220ef
added import back
11 years ago
Brian Coca
6e825e8c22
fixed listify for lookups, made sure convert_bare is only on with_
11 years ago
James Cammarata
adb9d7e461
Track role execution per-host, not overall in the role
...
Fixes #11863
Fixes #11878
11 years ago
Rene Moser
e62fbf5fba
cloudstack: add get_result() in utils to return common results
11 years ago
James Cammarata
f904acbd14
Fixing bug related to listify changes
11 years ago
James Cammarata
169d316704
Fixing bugs in include + loops
...
Fixes #11872
11 years ago
Brian Coca
7666bde666
updated hashi_vault to new listify, added to changelog
11 years ago
Brian Coca
4399ddc7da
Merge pull request #11674 from defionscode/hashi_vault_lookup
...
Hashicorp Vault lookup Plugin
11 years ago
Jonathan Davila
175068fdae
Hashicorp Vault lookup Plugin
11 years ago
Brian Coca
7e7b546c34
reinstated listify
11 years ago
Brian Coca
3e5dbd045f
fixed ref to removed var
11 years ago
Brian Coca
5c1d850fbb
now fixed to actually work
11 years ago
Brian Coca
ee365c881f
fixed typo
11 years ago
Brian Coca
c08305a31f
set script command itself to be sudable and not use the chmod sudoable settings as it can
...
ignore sudo settings for script when become_user is not root
fixes #11902
11 years ago
Toshio Kuratomi
d35b956900
listify lookup plugin terms when they're specified as "{{ lookup(terms) }}"
...
Before this, they were not listified there but they were listified when
specified like this:
with_lookup: terms
11 years ago
Brian Coca
dbab703265
fine tuned password handling as we were getting false positives, probably caused by other changes up the stack that now call these functions in more cases.
11 years ago
Brian Coca
6fcfebd21d
made sure we need becoem before we format the command, added debug entry also
11 years ago
Brian Coca
df768e0db4
fixed debug statement
11 years ago
Brian Coca
177499476b
fixed warning
11 years ago
Toshio Kuratomi
3ef49844db
Update core submodule ref
11 years ago
Brian Coca
8f106c9a58
Merge pull request #11078 from Yannig/devel
...
New lookup plugin : ini
11 years ago
Yannig Perré
07fcb50b9b
Porting ini lookup plugin against ansible v2.
11 years ago
Toshio Kuratomi
f1144752c4
Pull in docs fix from core modules
11 years ago
James Cammarata
e7d0c9f820
Re-add vars to Base and standardize var processing
...
Fixes #11779
11 years ago
Brian Coca
dbe7a9fe2f
Merge pull request #11857 from quinot/bug/playbook-init-comment
...
Minor comment fix
11 years ago
Brian Coca
3c57018a10
Merge pull request #11778 from Ensighten/add_credstash_plugin
...
add credstash lookup plugin
11 years ago
Brian Coca
d47d0b1d7f
now continue/abort mode allows ignoring other input
11 years ago
Brian Coca
a555a0652e
allow for vars_prompt and pause prompt to be skipped in non interactive settings
...
ansible-pull users rejoice
11 years ago
Toshio Kuratomi
ce52fdebe8
Pull in get_url checksum change
11 years ago
Brian Coca
29cd72b7d8
even simpler condition tree for pause
11 years ago
Brian Coca
dc80bc8929
now pause behaves like v1 pause
11 years ago
Brian Coca
f7707d8850
brought user_input back to pause
11 years ago
Toshio Kuratomi
00b1a2c865
Restore ValueError in md5 method and change finding the available hash algorithms so we only have to do it once
11 years ago
Brian Coca
15a20e814b
added tags back to ansible-pull
11 years ago
Brian Coca
5f0359c119
keep banners at 79
11 years ago
Brian Coca
25e67bb716
text wrap now adapts to terminal
11 years ago
Toshio Kuratomi
80cb69214b
Merge pull request #11840 from muffl0n/module_utils_hash_algorithms
...
Add get_available_hash_algorithms()
11 years ago
James Cammarata
d44daf53cc
Allow wrapped text in deprecated messages
11 years ago
James Cammarata
5eb092b331
Handle top-level vars for include tasks to match v1 syntax
...
The "streamlined" syntax will be deprecated at some point in the future.
Fixes #11882
11 years ago
Toshio Kuratomi
e16b24c01e
Update submodule ref
11 years ago
Toshio Kuratomi
e8452c864e
Restore the relative path handling portion of #11865
11 years ago
James Cammarata
26d5a17b59
Make sure inventory loads files with non-relative paths
...
This is a slightly different fix than we originally committed, but fixes
the problem in a less invasive way (and I believe it's generally better
that we don't deal with relative paths internally past this point)
Fixes #11789
11 years ago
Brian Coca
b9433650d1
Revert "Path of group_vars and host_vars were getting the basedir added twice."
...
in view of simpler solution incomming from james
This reverts commit bae7a02be5 .
11 years ago
Brian Coca
9f156e5550
updated submodule refs
11 years ago
Brian Coca
7bea04141b
Merge pull request #11865 from ansible/fix-group_vars_path
...
Path of group_vars and host_vars were getting the basedir added twice.
11 years ago
Brian Coca
08e6c1d82b
avoid possible errors with new broadcast handling in linux
11 years ago
Brian Coca
cb2cfaebda
started porting chroot to v2
11 years ago
Brian Coca
262c75c253
Merge pull request #10971 from mightydok/debbraoadcastfix
...
Add missed broadcast address to linux network facts.
11 years ago
Scott Cunningham
87ef53c962
credstash lookup plugin: python 2.6-compatible string.format()
11 years ago
Scott Cunningham
c4629b72e0
credstash lookup plugin: error out in run function when credstash not installed, not at module scope
11 years ago
Toshio Kuratomi
bae7a02be5
Path of group_vars and host_vars were getting the basedir added twice.
...
Fix inventory so this won't happen and fix DataLoader so that it will
test relative paths relative to self._basedir
Fixes #11789
11 years ago
Toshio Kuratomi
e7b5cb8782
Fix synchronize source path with roles and local connection
...
Fixes #8261
11 years ago
Toshio Kuratomi
dd7fa07038
Update submodule refs so synchronize plugin works
11 years ago
Toshio Kuratomi
308bf80055
Cleanups to synchronize including:
...
* Better comments
* Reorganize code so related settings are close to each other
* Add ::1 to the "localhost" patterns we look for
* Make the dest_port parameter override the ansible_ssh_port setting
* Fix dest_port (wasn't being set)
* more complete detection of delegate_to
* Fix set_remote_user (wasn't being looked for in parameters)
* Instead of removing mode here, have the ansible module accept it
(better documents the parameters doing it htat way)
11 years ago
James Cammarata
37e38924de
Allow field attributes to have priorities
...
So that roles are loaded ahead of all other play fields, meaning any
plugins contained within the roles are loaded first before tasks.
Fixes #11858
11 years ago
Jon Hawkesworth
f69da544f7
add win_basename and win_dirname filters
11 years ago
James Cammarata
fad44862a5
Implementing includes in the free strategy
11 years ago
Brian Coca
2b9b3a08a1
make sure you only update pci data if there is a match
11 years ago
Yannig Perré
09d257e637
Porting ini lookup plugin against ansible v2.
11 years ago
Thomas Quinot
5d3cb636ad
Minor comment fix
11 years ago
Yannig Perré
47db352725
Merge remote-tracking branch 'ansible/devel' into devel
11 years ago
Yannig Perré
733d40a77c
When value does not exist, return default value instead of stopping ansible with an exception.
11 years ago
James Cammarata
faf4c3bb6c
Merge pull request #11816 from amenonsen/ssh-ipv6
...
Fix ssh connections to IPv6 addresses
11 years ago
James Cammarata
dbd755e0f4
Fix jinja2 template search pathing
...
Fixes #9933
11 years ago
Scott Cunningham
934ce86d35
update credstash lookup plugin to use Python 2.4-compatible exception catching
11 years ago
James Cammarata
61e76fd707
Allow conditionals on PlaybookInclude statements
...
Fixes #11852
11 years ago
James Cammarata
b6c3e5d797
Validate variable names given in set_fact
...
Fixes #11851
11 years ago
James Cammarata
5266679964
Use templar all the way down
...
Fixes bugs related to creating Templar() objects on the fly, where
the shared loader objects (serialized to TaskExecutor) aren't used
so information loaded into plugin loaders after forking is lost.
Fixes #11815
11 years ago
muffl0n
8d6d711a5c
move get_available_hash_algorithms() from get_url
11 years ago
James Cammarata
c3ce140dd2
Exclude loop_args from post_validation for tasks
...
This field is templated specially during the TaskExecutor's loop
calculation, so there's no need to post validate it again.
Fixes #11481
11 years ago
Brian Coca
015b922c1f
fix quoting for become commands
...
fixes #11808
11 years ago
Toshio Kuratomi
ca941ec632
style cleanup because -ECANNOTUNDERSTAND without it
11 years ago
Toshio Kuratomi
f86245dcb0
Add a warning about python3 in the synchronize plugin
11 years ago
Toshio Kuratomi
f0431eaea9
Make ansible_python_interpreter work with synchronize
...
Fixes #11836
11 years ago
James Cammarata
8279557e8f
Allow role names to be templated
...
Fixes #10858
11 years ago
James Cammarata
ed603f7030
Fix free strategy only running first play in a multi-play playbook
...
Fixes #11839
11 years ago
James Cammarata
c2435fab7e
Inject the play context vars into the variables used for loop item templating
11 years ago
James Cammarata
bcbcfc79be
Fix relative paths for included files
...
Also modifies the Play class to not include become* fields in the
post-validation step.
Fixes #11353
11 years ago
James Cammarata
2673eb0afb
Add option to fail on undefined variables to listify
...
And use it in the call to get the loop items for a task.
11 years ago
James Cammarata
a586c74967
Merge pull request #11838 from cchurch/stringify_powershell_unquote_value
...
Fix for PowerShell unquote method when passed None.
11 years ago
James Cammarata
f6d1b5e233
Merge pull request #11835 from cchurch/raw_is_not_raw_enough
...
Raw is not raw enough
11 years ago
James Cammarata
7b9aee7077
Merge pull request #11832 from amenonsen/zeroforks
...
Disallow --forks 0
11 years ago
Chris Church
cafc35fd5b
Fix for PowerShell unquote method when passed None.
11 years ago
Abhijit Menon-Sen
7d9689c1c5
Slice ascii_letters directly instead of using 'for x in range()'
11 years ago
Abhijit Menon-Sen
bfe708a189
Make host range parsing errors issue better messages
...
Now we always say "host range must …specific thing…"
11 years ago
Abhijit Menon-Sen
1413496292
Implement step for alphabetic ranges: [a:e:2] => a,c,e
11 years ago
Abhijit Menon-Sen
72715c6add
Fix ssh connections to IPv6 addresses
...
We can unconditionally wrap remote_addr in square brackets for scp and
sftp (both of which require them for IPv6 addresses), but not wrap them
at all for ssh (which doesn't accept them). This way, we don't have to
detect and treat IPv6 addresses specially. This works for hostnames,
IPv4 addresses, and IPv6 addresses.
The earlier code seemed to intend to wrap all IPv6 addresses in square
brackets, which would have broken ssh, but it actually made no attempt
to detect IPv6 addresses at all (so it broke only with IPv6 addresses
for scp and sftp).
Based on a review of PR #11677 by @JuiceBoxSingularity
11 years ago
Chris Church
6969b5ac8b
Make sure raw doesn't eat key=value arguments.
11 years ago
Abhijit Menon-Sen
861da614cc
Make 'pause: prompt=…' print the prompt
...
In stable-1.9, the prompt string is passed to raw_input(), which prints
it without an extra \n. Here we're just print()ing it, so the \n would
be doubled.
11 years ago
James Cammarata
9936c5f9f6
Fixing the pause module for devel
11 years ago
Abhijit Menon-Sen
8de70fa657
Disallow --forks 0
...
Without at least one worker process, things break:
Traceback (most recent call last):
File "/home/ams/extern/ansible/ansible/lib/ansible/executor/process/result.py", line 103, in run
result = self._read_worker_result()
File "/home/ams/extern/ansible/ansible/lib/ansible/executor/process/result.py", line 69, in _read_worker_result
(worker_prc, main_q, rslt_q) = self._workers[self._cur_worker]
IndexError: list index out of range
11 years ago
Toshio Kuratomi
cf35bdbdf9
Merge pull request #11827 from amenonsen/trivial-fixmes
...
Remove TODO: the play already overrides options
11 years ago
Abhijit Menon-Sen
a9b020d6de
Remove TODO: the play already overrides options
11 years ago
Abhijit Menon-Sen
1f2adb5e14
Show a better message when ansible.cfg is not found
...
Earlier we would say «Using as config file» if we didn't find one.
11 years ago
Abhijit Menon-Sen
2cb7cd8379
Remove outdated FIXME; _compute_delegate is called below
11 years ago
Abhijit Menon-Sen
7b3cb2126c
Remove outdated FIXME; ROLE_CACHE is already implemented below
11 years ago
Toshio Kuratomi
91a77b8603
Fix potential bug in parameter passing
11 years ago
James Cammarata
13b8a57d3d
Undo previous travis/tox fixes and fix underlying issue
11 years ago
Toshio Kuratomi
0d72be3953
become protection for local connections no longer needed
11 years ago
Toshio Kuratomi
d1933accc3
Fixes for synchronize with delegate_to
11 years ago
Toshio Kuratomi
3939348286
Fix HostVars to support containment tests
11 years ago
Chris Church
74df17de29
Add an option for PowerShell modules to indicate support for check mode, skip running module if check mode is not supported.
11 years ago
Chris Church
e87cf4a3cc
Fixes for WinRM/PowerShell support in v2.
...
- Add support for inserting module args into PowerShell modules. Fixes #11661 .
- Support Windows paths containing spaces. Applies changes from #10727 to v2. Fixes #9999 . Should also fix ansible/ansible-modules-core#944 and ansible/ansible-modules-core#1007 .
- Change how execution policy is set for running remote scripts. Applies changes from #11092 to v2. Also fixes ansible/ansible-modules-core#1776 .
- Use codepage 65001 (UTF-8) for WinRM connection instead of default (CP437), convert command to UTF-8 and results from UTF-8. Replaces changes from #10024 . Fixes #11198 .
- Close WinRM connection when task completes.
- Use win_stat, win_file and win_copy modules instead of stat, file and copy when called from within other action plugins (only when using WinRM+PowerShell).
- Unquote Windows path arguments before passing to win_stat, win_file, win_copy and slurp modules (only when using WinRM/PowerShell).
- Check for win_ping module to determine if core modules are missing (only when using WinRM/PowerShell).
- Add stdout_lines to result from running low level commands (so stdout_lines is available when using raw/script).
- Update copy action plugin to use shell functions for joining paths and checking for trailing slash.
- Update fetch action plugin to unquote source path when using Windows paths.
- Add win_copy and win_template action plugins that inherit from copy and template.
- Support running .bat and .cmd scripts using default system encoding instead of UTF-8.
- Always send PowerShell commands as base64-encoded blobs to allow for running simple PowerShell commands via raw.
- Support running modules on Windows with interpreters other than PowerShell.
- Update integration tests to support above changes and test unicode fixes.
- Add test for win_user error from ansible/ansible-modules-core#1241 (fixed by ansible/ansible-modules-core#1774 ).
- Add test for additional win_stat output values (implemented by ansible/ansible-modules-core#1473 ).
- Add test for OS architecture and name from setup.ps1 (implemented by ansible/ansible-modules-core#1100 ).
All WinRM integration tests pass for me with these changes.
11 years ago
Brian Coca
fa8043c0ba
corrected typo
11 years ago
Brian Coca
f16b745f17
now properly uses default port if defined
11 years ago
Brian Coca
496186f5de
makes ssh plugin resilient against invalid entries in hosts file
...
fixes #10238
11 years ago
Mark Chance
437d4deffc
change ec2 util to create only requested objects
11 years ago
Toshio Kuratomi
e349004325
Update submodule ref to pull in apt_repo fixes
11 years ago
Jonathan Süssemilch Poulain
02294c52ce
Typo
11 years ago
Jonathan Süssemilch Poulain
4614a574ea
Allows network network interface facts collection as an unprivileged user and adds more facts
11 years ago
Jonathan Süssemilch Poulain
e181bcf62b
Allows to fetch machine architecture as an unprivileged user
11 years ago
Brian Coca
9aa4214417
fixed delegate_to ref in syncronize
11 years ago
Brian Coca
8a00dff989
updated submodule refs
11 years ago
Brian Coca
07e5e98cbf
removed jinaj2 override restrictions
11 years ago
Brian Coca
113f709eac
brought up to date with default
11 years ago
Brian Coca
51de207197
Merge pull request #11805 from amenonsen/trivial-fixmes
...
A series of trivial FIXMEs for devel
11 years ago
Scott Cunningham
193e857bc4
credstash lookup plugin: raise AnsibleError when credstash library not installed
11 years ago
James Cammarata
222f04e387
Submodule pointer update
11 years ago
Abhijit Menon-Sen
807079ec2f
Remove outdated FIXME; HostVars is imported and used below
11 years ago
Brian Coca
d05c4b82aa
Merge pull request #11803 from amenonsen/prompt_encrypt
...
Uncomment encrypt handling for vars_prompt
11 years ago
Abhijit Menon-Sen
845784b572
Remove outdated FIXMEs; all use combine_vars already
11 years ago
James Cammarata
efcad3aa6d
Re-allow vars on tasks, specifically for includes
11 years ago
James Cammarata
0ad52a403f
Merge pull request #11804 from amenonsen/fixme
...
Easy FIXMEs
11 years ago
Abhijit Menon-Sen
1541e331c9
Also fix UTF-8 handling in vars_prompt
11 years ago
James Cammarata
549c204051
Submodule pointer update
11 years ago
Abhijit Menon-Sen
694d2103b1
Remove outdated FIXME code
...
This is already handled in PlayContext.set_options.
11 years ago
Abhijit Menon-Sen
ff2d160fff
Correct invalid reference to global display
11 years ago
Abhijit Menon-Sen
10def3aa54
Uncomment encrypt handling for vars_prompt
11 years ago
Brian Coca
b2dc66c7ea
now check stderr also on become for ssh plugin for the cases where sudo or su do not want to prompt/echo on stdin
...
fixes #11796
11 years ago
Brian Coca
17f659a143
added some debug to galaxy
11 years ago
Brian Coca
29bc8f51d7
made tags display closer to v1
11 years ago
Brian Coca
b37be236d9
Merge pull request #11475 from nibalizer/cfacter_support
...
Use cfacter instead of facter if possible
11 years ago
Abhijit Menon-Sen
3d581e5306
Don't stat None
...
Fixes #11794 , regression introduced by #11010
11 years ago
Brian Coca
527ae360b0
Merge pull request #10652 from vodik/nspawn
...
Support querying systemd container information
11 years ago
Brian Coca
4b8e368039
Merge pull request #11010 from sillydong/devel
...
Add judgment to to fix path0 if ANSIBLE_CONFIG is set to a dir
11 years ago
Brian Coca
0e77871426
fixed non ignore errors path to actually interrupt
...
fixed cases where missing/inaccessible file gave exception, now you get nice error
11 years ago
Brian Coca
8153c34abf
now returns false on bad role_data
11 years ago
Brian Coca
e81ec32719
made galaxy more resilient with bad yaml files and comments/spaces in non yaml files
...
fixes #10641
11 years ago
Joseph Callen
2f5ced8856
Moving VMware Utilites module
...
Moved `vmware.py` from v1 to `lib/ansible/module_utils/vmware.py`.
No other changes has been made since these two PRs:
https://github.com/ansible/ansible/pull/10812
https://github.com/ansible/ansible/pull/10760
11 years ago
Brian Coca
ced93d35ca
adjusted list hosts across adhoc and playbook cli
11 years ago
James Cammarata
3a50c08c01
Merge branch 'pluggable_jinja_tests' of https://github.com/quixoten/ansible into quixoten-pluggable_jinja_tests
11 years ago
James Cammarata
782c2f75df
Make sure role deps inherit conditionals/tags specified via params
...
Fixes #7353
11 years ago
Brian Coca
bedfe00de8
Merge pull request #11336 from saada/patch-1
...
Update Vault rekey() in vault.py to validate files passed before input
11 years ago
Toshio Kuratomi
4f1d365a25
Merge pull request #11783 from ansible/synchronize-fix
...
Synchronize in wasn't running on localhost in the default case which …
11 years ago
Toshio Kuratomi
088682f518
Synchronize in wasn't running on localhost in the default case which meant that rsync was run on the wrong host.
...
Fixes #11649
11 years ago
Mahmoud Saada
ddd46f6599
Update rekey() in vault.py to validate files passed exist before prompting for password
11 years ago
Brian Coca
0784fa1765
removed import q
11 years ago
Brian Coca
96bcf50a94
implemented requirements file in v2
...
fixes #11179
11 years ago
James Cammarata
71867f9480
Remove vars attribute from base
...
Fixes #11779
11 years ago
Scott Cunningham
695e456cb0
add credstash lookup plugin
11 years ago
Brian Coca
132c14eb57
indented hosts
11 years ago
Brian Coca
c0c094c413
now all --list options are working!
11 years ago
Brian Coca
884435a1aa
minor cosmetic changes to list options
11 years ago
Brian Coca
056602c424
rearranged --list- options, now they are consolidated when used toghether, less loops, more concise output
...
list-hosts works
list-tasks works, but needs better task naming (missing role info)
list-tags only shows play tags
11 years ago
Brian Coca
cc85473c1e
show role search path when not finding a role
...
fixes #9770
11 years ago
James Cammarata
42cfacf83b
Switch up the task/host overrides for PlayContext to use the compiled vars dict
...
Fixes #11436
11 years ago
Brian Coca
a8b2b5b0c9
avoids printing blank diffs
...
fixes #10147 fixes #9471
11 years ago
James Cammarata
5cf2781528
A little more cleanup regarding _compute_environment_string
11 years ago
James Cammarata
467432bef5
Fix incorrect module path for AnsibleError in action plugin base
11 years ago
Brian Coca
f4a997db49
added back but stderr, which was the original itnention
11 years ago
Brian Coca
3b9282fb90
fixed dupe output in raw/command cases
11 years ago
Brian Coca
a78fdde32c
better handling for weird doc corner cases (abscense of options, bad text objects, etc)
...
also updated extras to get some docfixes on the module side
11 years ago
Brian Coca
17103dd4cc
update submodule refs
11 years ago
Brian Coca
6cdee94c33
added missing skipped item function to base
11 years ago
Brian Coca
6f93d228f6
made item output closer to v1
11 years ago
Brian Coca
4f9d719b14
removed debug
11 years ago
Brian Coca
d78c2fc212
now reports per task item
11 years ago
James Cammarata
2d90cbf78b
Properly fail results with rc != 0
...
Fixes #11769
11 years ago
Brian Coca
787a0c4e04
fixed indent issues
11 years ago
Vilmos Nebehaj
58cccce384
Use PBKDF2HMAC() from cryptography for vault keys.
...
When stretching the key for vault files, use PBKDF2HMAC() from the
cryptography package instead of pycrypto. This will speed up the opening
of vault files by ~10x.
The problem is here in lib/ansible/utils/vault.py:
hash_function = SHA256
# make two keys and one iv
pbkdf2_prf = lambda p, s: HMAC.new(p, s, hash_function).digest()
derivedkey = PBKDF2(password, salt, dkLen=(2 * keylength) + ivlength,
count=10000, prf=pbkdf2_prf)
`PBKDF2()` calls a Python callback function (`pbkdf2_pr()`) 10000 times.
If one has several vault files, this will cause excessive start times
with `ansible` or `ansible-playbook` (we experience ~15 second startup
times).
Testing the original implementation in 1.9.2 with a vault file:
In [2]: %timeit v.decrypt(encrypted_data)
1 loops, best of 3: 265 ms per loop
Having a recent OpenSSL version and using the vault.py changes in this commit:
In [2]: %timeit v.decrypt(encrypted_data)
10 loops, best of 3: 23.2 ms per loop
11 years ago
Brian Coca
77fc3ce759
removed unused import
11 years ago
Lukas Pirl
d9aa14feea
fixes remote code execution for su/sudo and strict remote umasks
...
* temporarily changes umask for creating temporary directories
* otherwise parent directories may not get chmod'ed and end up
unreadable
refs #9902
11 years ago
Brian Coca
80ecab5317
Merge pull request #11761 from amenonsen/9843-rebase
...
Add pciid to LinuxNetwork interface fact
11 years ago
Hugh Saunders
f344ec463f
Add LVM facts to setup module
...
This commit adds LinuxHardware.get_device_facts() and calls that from
.populate().
LVM facts are only gathered if the setup module is running as root and
the lvm utilities are available (tested by searching for 'vgs').
If the conditions are met, facts are set for each volume group and
logical volume.
Example:
Test LVM Data:
$ sudo vgs
VG #PV #LV #SN Attr VSize VFree
test 1 2 0 wz--n- 5.00g 2.00g
$ sudo lvs
LV VG Attr LSize Pool Origin Data% Move Log Copy% Convert
testlv test -wi-a---- 1.00g
testlv2 test -wi-a---- 2.00g
Facts Returned:
$ ansible localhost -i /tmp/inv -m setup -a 'filter=ansible_lvm'
localhost | success >> {
"ansible_facts": {
"ansible_lvm": {
"lvs": {
"testlv": {
"size_g": "1.00",
"vg": "test"
},
"testlv2": {
"size_g": "2.00",
"vg": "test"
}
},
"vgs": {
"test": {
"free_g": "2.00",
"num_lvs": "2",
"num_pvs": "1",
"size_g": "5.00"
}
}
}
},
"changed": false
}
Test as non-root:
$ ansible localhost -i /tmp/inv-user -m setup -a 'filter=ansible_lvm'
localhost | success >> {
"ansible_facts": {},
"changed": false
}
Test without lvm utilities available
$ sudo mv /sbin/vgs{,.bk}
$ ansible localhost -i /tmp/inv -m setup -a 'filter=ansible_lvm'
localhost | success >> {
"ansible_facts": {},
"changed": false
}
11 years ago
Brian Coca
5f8db9cd4b
changed verbose_override to the new _ansible_verbose_override to keep in line with previous changes
...
output now defaults back to having indent=4
11 years ago
Trapier Marshall
250620f2ab
Add pciid to LinuxNetwork interface fact
...
This commit adds pciid to the LinuxNetwork fact object.
pciid is gathered if the symlink /sys/class/net/*/device exists.
Example [>>>> emphasis <<<<]:
$ readlink /sys/class/net/eth0/device
../../../0000:01:00.0
$ ansible localhost --ask-pass -i /tmp/hosts -m setup -a "filter=ansible_eth0"
SSH password:
localhost | success >> {
"ansible_facts": {
"ansible_eth0": {
"active": false,
"device": "eth0",
"macaddress": "0c:d2:92:5d:6e:8e",
"module": "alx",
"mtu": 1500,
>>>> "pciid": "0000:01:00.0", <<<<
"promisc": true,
"type": "ether"
}
},
"changed": false
}
11 years ago
Brian Coca
8746e692c1
changed check to allow for powerpc
...
fixes #11528
11 years ago
Brian Coca
0c21196633
moved openvz inventory script to new home
11 years ago
Brian Coca
164092a835
optimized module docs
11 years ago
Brian Coca
2575e1540a
Merge pull request #11740 from amenonsen/8602-rebase
...
Encrypt the vault file after editing only if the contents changed
11 years ago
Toshio Kuratomi
d2346fd2e2
Python2.4 compat fix
11 years ago
James Cammarata
d6cafff2f9
Additional changes to fix fileglob relative path lookups
11 years ago
Toshio Kuratomi
6a68be4e28
Handle quoting of values in dict parameters
11 years ago
James Cammarata
cb262449c7
Reworking internal result flags and making sure include_vars hides vault data
...
Fixes #10194
11 years ago
James Cammarata
eebf437d87
Submodule pointer update
11 years ago
Brian Coca
b2b19a1dc4
Merge pull request #11751 from amenonsen/playwithoutbook
...
A better error message for «ansible playbook.yml»
11 years ago
James Cammarata
49a6601856
Further cleanup of internal use of ansible_ssh_host
11 years ago
James Cammarata
ee835ff7ad
Add a base-level get_basedir method for lookup plugins and fix relative lookups
...
Fixes #11746
11 years ago
Abhijit Menon-Sen
65d62090c2
A better error message for «ansible playbook.yml»
...
This is a very conservative change: we add the hint only if we're
definitely going to die already.
11 years ago
James Cammarata
3a4dd523d3
Fix bug where we calculated the relative path of recurisive copies wrong
...
Fixes #11470
11 years ago
James Cammarata
a1a8997e89
Merge pull request #11663 from whereismyjetpack/fix_ansible_ssh_host
...
only set ansible_ssh_host if not already set
11 years ago
Brian Coca
a56ff7ae54
now it really is oneline
11 years ago
Brian Coca
5d1d9f1505
fixed diff output to be as it was in 1.x, copy and template now use the same
...
functions to do difs.
11 years ago
James Cammarata
c56a304ad9
Merge pull request #9195 from reedloden/add-dns-facts
...
Add several DNS-related facts by parsing /etc/resolv.conf
11 years ago
James Cammarata
ccb7fb3b4c
Submodule pointer update
11 years ago
James Cammarata
034c766439
Fixing logic in template.py to not assume 'changed' is in the result
11 years ago
James Cammarata
a78ed39f93
Merge pull request #11743 from renard/regex_escape-filter
...
Regex escape filter
11 years ago
James Cammarata
db4b3544d7
Fix syntax error in action plugin template.py
11 years ago
Reed Loden
eb1fb41576
Add several DNS-related facts by parsing /etc/resolv.conf
...
Facts include nameservers, domain, search path, sortlist, and options.
11 years ago
Sébastien Gross
36534668f0
Change name from re_escape to regex_escape to fit existing function names.
11 years ago
Sébastien Gross
c1e4085251
Add regular expression escaping filter.
11 years ago
Brian Coca
0b6fadaad7
started implementing diff
...
diff now works with template
also fixed check mode for template and copy
11 years ago
Pablo Figue
f8bf2ba1bd
Encrypt the vault file after editing only if the contents changed
11 years ago
James Cammarata
73aa5686cc
Remove octal escapes from unicode escape handling
...
Fixes #11673
11 years ago
Brian Coca
5be384bab0
Merge pull request #11733 from amenonsen/csvfile
...
v2 breakage: lookupfile should lookup the given file=xxx
11 years ago
Brian Coca
b19eb0f4dc
minor improvements to display
11 years ago
Abhijit Menon-Sen
8737061a8f
lookupfile should lookup the given file=xxx
...
(Earlier it used to lookup the pre-split term.)
11 years ago
James Cammarata
eca88d4253
Merge pull request #11732 from amenonsen/9212-rebase
...
Forbid copy: content="" with a directory destination
11 years ago
Mario de Frutos
4ed664f4d0
Forbid copy: content="" with a directory destination
...
Fixes #9107 , closes PR #9212
11 years ago
Brian Coca
b9710b4a34
wrapped new system ssh key lookup in case file does not exist
11 years ago
Patrick Michaud
e4df8c3d36
Have paramiko use /etc/ssh_known_hosts
...
Fixes an issue with a confusing error: "paramiko: The authenticity of host '[host]' can't be established" when ssh on the command line doesn't complain
Closes PR #7730
11 years ago
Brian Coca
0858d97c44
also captures typeerrors for when not getting a proper string in output
11 years ago
Toshio Kuratomi
8ee3b7384d
Guard the PROTOCOL setting so that we work on older pythons
11 years ago
Toshio Kuratomi
36382face9
Add a warning about mode being octal
11 years ago
James Cammarata
eccfb7e0b5
Adding initial support for includes in handlers
...
Fixes #11694
11 years ago
Brian Coca
7215470c6f
implemented galaxy list in v2
11 years ago
Will Thames
9abd9a8f57
Make ansible-galaxy work with galaxy.ansible.com
...
Now works with role files that use Ansible Galaxy roles
Still work to do on making this work with internal roles
11 years ago
Brian Coca
cff77de917
added todo for future of feature
11 years ago
Brian Coca
0089eb8102
reimplemented logging based on log_path var
11 years ago
James Cammarata
ff49c5adac
Make sure we're actually looping before looking at 'results' in TaskResult
...
Fixes #11696
11 years ago
James Cammarata
0fcd53e887
Make sure the command is sudoable before checking for the become password
...
Fixes #11714
11 years ago
James Cammarata
e526743b4f
Allowing `args: "{{some_var}}"` for task params again
...
This is unsafe and we debated re-adding it to the v2/2.0 codebase,
however it is a common-enough feature that we will simply mark it
as deprecated for now and remove it at some point in the future.
Fixes #11718
11 years ago
Brian Coca
681eab1158
fix adhoc that broke with assuming step is always in options
11 years ago
Brian Coca
88e1ef8c9b
implemented --step in v2
11 years ago
Brian Coca
3bf1edfd96
Merge pull request #11591 from defionscode/boto3
...
Connection function for boto3
11 years ago
James Cammarata
7bc789ba64
Properly template task names
...
Also fixes in the correct way the bug in which the role name was
incorrectly showing up twice in the task name.
Fixes #10347
11 years ago
James Cammarata
698479a623
Add config file info to --version output
...
Fixes #10348
11 years ago
James Cammarata
37ed756d66
Make sure role names are strings
...
Fixes #10497
11 years ago
Toshio Kuratomi
f8e4aff4c1
Cleanups:
...
* Don't reference __class__ when we can use the instance itself
* use isdisjoint() as it can stop once a match is found
* Remove a condtional that was taken care of in the conditonal just above
11 years ago
Brian Coca
4e3f5e3be6
Merge pull request #11708 from bcoca/display_me
...
adding display to plugins and start moving debug to display
11 years ago
Brian Coca
78df37db8a
updated submodule refs
11 years ago
Brian Coca
a6ba149c49
implemented simplified output for adhoc adn command modules as in v1
11 years ago
James Cammarata
65ae9780fa
Merge pull request #11079 from amegianeg/fix_broad_except_in_inventory
...
Avoid too broad except in Inventory
11 years ago
Toshio Kuratomi
e7733a7d3a
Update submodule refs
11 years ago
Brian Coca
851ed45bbf
adding display to plugins and start moving debug to display
11 years ago
Toshio Kuratomi
b06353791c
Don't pass mode from synchronize action plugin to the ansible module
...
Fixes https://github.com/ansible/ansible-modules-core/issues/1783
11 years ago
Brian Coca
b678b9828c
simplified and normalized lookup search path behaviour
11 years ago
James Cammarata
857f584ebf
Merge pull request #11699 from ahamilton55/ah/delegate_variable
...
v2: Fixing delegate_to when using a variable
11 years ago
Brian Coca
b9050ecf18
fixed file lookup pathing in dwim functinos, now does specific paths and priorities and is commented
...
fixes #11672 as cwd is now not part of thos paths:
if full path is supplied, used that
11 years ago
Andrew Hamilton
7254b22bf4
Fixing delegate_to when using a variable
11 years ago
James Cammarata
d412bc72ef
Fall back to paramiko if the smart detection fails to run ssh
...
Fixes #11695
11 years ago
James Cammarata
dfcf6a2016
Skip hosts with no state while iterating tasks in the linear strategy
...
Fixes #11693
11 years ago
James Cammarata
206ef27268
Add flag to template() so data is not converted to a datastructure
...
Fixes #11641
11 years ago
James Cammarata
7a9916422a
Fixing up error handling for fetch_file ops in connection plugins
...
* enable batch mode (configurable with a config option, on by default)
for sftp transfers, so we can catch errors more easily
* general cleanup in the local connection plugin and fetch action plugin
Fixes #11612
11 years ago
James Cammarata
4b6525fb58
Fix handler flushing to match how v1 worked
...
Also adds meta tasks to the list of tasks excluded from tag filtering
Fixes #11574
11 years ago
Toshio Kuratomi
d0dcf73716
Update module refs
11 years ago
James Cammarata
135404738e
Fix a couple start-at-task issues
...
* added pattern matching to match v1 functionality
* check the task name, not the task+role name for matches
* make sure the input is unicode
Fixes #11692
11 years ago
James Cammarata
975172c1ef
Make sure role name doesn't end up in task name more than once
...
Fixes #11691
11 years ago
James Cammarata
b09f1f8e0b
Account for filters in bare variable conversion
...
Fixes #11530
11 years ago
Jeff Widman
52716c4dc7
Remove mention of 'apache example'
...
Removed explicit mention of 'apache'
11 years ago
ZviRackover
628925a77d
Fix: add missing import 'locale'
11 years ago
James Cammarata
4c733fe4b7
Fix issues with vars_prompt and vars_files
...
* Prompt had to be moved up, as it needed to be done before the first
templating of the play occurs, otherwise vars_files won't be templated
properly
* Fixed a bug related to an earlier fix of vars_files incorporating
extra vars to do the templating of the file name
Fixes #11404
11 years ago
Toshio Kuratomi
491a4f2a25
Update extras module pointer for docs fix
11 years ago
James Cammarata
adf1d4d9b9
Submodule pointer update
11 years ago
James Cammarata
66a8864ae9
Fix environment setting and inheritence
...
Fixes #11401
11 years ago
James Cammarata
91519d1696
Don't filter include tasks based on tags
...
Fixes #11320
11 years ago
James Cammarata
e64989beb4
Moving ConnectionInformation -> PlayContext
...
Also making PlayContext a child class of the Playbook Base class,
which gives it access to all of the FieldAttribute code to ensure
field values are correctly typed after post_validation
Fixes #11381
11 years ago
Brian Coca
827b0443c8
now dataloader checkis that you get at least a valid string as a file name
11 years ago
James Cammarata
7124504ccf
Incorporate extra vars when templating vars_files
...
Fixes #11377
11 years ago
James Cammarata
b8b206005c
Generalize extra variable parsing and loading
...
Fixes #11352
11 years ago
Dann Bohn
3e79bfa2d6
only set ansible_ssh_host if not already set
11 years ago
James Cammarata
3de6f264dd
Fix bug where spaces in the $HOME directory broke things
...
Fixes #11332
11 years ago
James Cammarata
91a4b866b0
Fix ssh pipelining
11 years ago
Toshio Kuratomi
ddec06ccfe
Detect the old python-json library
...
Fixes #11654
11 years ago
James Cammarata
5347db2952
Also check the play basedir for the role
...
Fixes #11328
11 years ago
James Cammarata
dca36c1d16
Reestablishing the use of tags/when for role duplication detection
...
Not figuring these in can cause problems with "diamond" pattern relationships,
even though this is still not quite optimal.
11 years ago
Toshio Kuratomi
a0a6d12b05
Merge pull request #11603 from ansible/get_url-tls-compat
...
Have openssl autonegotiate tls protocol on python < 2.7.9
11 years ago
Brian Coca
03d7c8d7ca
fixed new HPUX networking facts
11 years ago
Brian Coca
80eb7a20ca
Merge pull request #11469 from pilou-/local_variable
...
Fix pyflakes error: use 'msg' variable
11 years ago
Brian Coca
91f2acb029
Merge pull request #10203 from pdelared/devel
...
Add HP-UX network facts
11 years ago
Pierre-Louis Bonicoli
8c392a94b7
Play.get_name: remove prefix, return name only
11 years ago
Pierre-Louis Bonicoli
fda8fa77ab
Fix pyflakes error: use 'msg' variable
...
Error was: local variable 'msg' is assigned to but never used
11 years ago
Brian Coca
a09ce4bd87
added callback that skipts 'skipped'
11 years ago
Brian Coca
171c95672e
fixed gathering expression as it was triggering when gather_facts was no
11 years ago
Brian Coca
f66ba92745
now vault prompts for password if no password file was given, as in 1.x
11 years ago
Brian Coca
a8ba9cac3f
fixed ansible pull bad options ref, removed print in favor of display
11 years ago
Brian Coca
f8905013cd
now executes fact search when needed
11 years ago
James Cammarata
2c98b271c8
Make paramiko password detection logic match ssh connection
11 years ago
James Cammarata
3d77723e3d
Cleaning up some stuff related to the connection info/become/executable change
11 years ago
James Cammarata
1c185b68be
Rearranging some become stuff in relation to action/connection plugins
...
Moving the make_sudo_cmd() calls back up to the action level so that connection
plugins don't have to know about it at all, and moving some of the become data
(prompt and success_key) into the ConnectionInformation object so they don't
need to be passed around needlessly.
11 years ago
James Cammarata
7a9b5b6fe8
Remove unnecessary make_become_cmd from paramiko exec_command
...
Fixes #11611
11 years ago
Brian Coca
9dc5607730
Merge pull request #11519 from bcoca/human_readable
...
new human_readable filter to transform bits and bytes into cake
11 years ago
Brian Coca
115dce028d
Merge pull request #11604 from bcoca/faf_deprecated_fixes
...
fixed first_available_found for template
11 years ago
Brian Coca
4f98fac494
Merge pull request #10914 from bcoca/non_posix_file_copy_fix
...
hack to prevent tempalte/copy errors on vagrant synced folders
11 years ago
Indrajit Raychaudhuri
4553a41ab5
Add homebrew to package managers' list
11 years ago
James Cammarata
271a7f3281
Cleaning up some of the notify/facts logic added earlier to fix problems
11 years ago
Brian Coca
1aa4155266
generalized warning handling, added it to adhoc also
11 years ago
James Cammarata
d4ac73a1bc
Adding back capability to display warnings contained in results
...
Fixes #11255
11 years ago
James Cammarata
5abdd3b821
Handle notifications when coupled with a loop
...
Fixes #11606
11 years ago
Serge van Ginderachter
8d1549900c
fix AnsibleError object name in subelements plugin
...
fixes #11624
11 years ago
Brian Coca
bc5a7fce79
Merge pull request #11616 from halberom/ssh_port
...
fixes 11607, override ansible_ssh_port in group/host_vars
11 years ago
Gerard Lynch
a6c8d30f3e
callbacks require a version constant or the v2 code doesn't pass the display param and it gives an error
11 years ago
Brian Coca
6ba706f753
minor doc reformatting
...
now version_added < 1.3 does not get shown, up from 1.0
option's version_added is also now filterd against this threshold
module version_added is more prominent
exaples now uses pure rst instead of intermingled with html formatting
aliases now shown in description for options
bad version fields now throw warnings instead of exceptions
ansible-doc errors now show traceback in very very verbose mode, for easier debugging
11 years ago
Brian Coca
da890f9328
Merge pull request #11622 from amenonsen/gathering
...
devel breaks «gathering=explicit» setting in ansible.cfg
11 years ago
Brian Coca
a09f6236a5
adapated to v2
11 years ago
Brian Coca
10e5c2b46d
fixed var scope
11 years ago
Tom Paine
097ed1f17b
Add plugin that profiles playbook tasks
...
Resubmission of https://github.com/ansible/ansible/pull/11270 to
correct v2 file location.
[Description and console output
demonstration](https://github.com/aioue/ansible-plugin-profile/blob/mast
er/README.md#features).
Provides per-task timing, ongoing playbook elapsed time and ordered
list of top 20 longest running tasks at end.
11 years ago
Abhijit Menon-Sen
28e2eae902
Make gathering=explicit work again
...
There was a confusion between the valid values for defaults.gathering
(explicit/implicit/smart) and a play's gather_facts setting (boolean),
which resulted in gathering=explicit being ignored.
11 years ago
Gerard Lynch
d23ab261e1
fixes 11607, allows ansible_ssh_port to be overridden from group or host_vars
11 years ago
Brian Coca
978390693b
changed to default 'auto' as it better describes the use= option
11 years ago
James Cammarata
94fa741f96
Make sure files loaded by template action are decoded properly
...
Fixes #11247
11 years ago
Brian Coca
5ba9fe4748
now supports maintainers and author field for display as MAINTAINERS
11 years ago
Brian Coca
c603caca27
removed extra print now that items are getting passed to callback in result
11 years ago
James Cammarata
86a83c16b8
Remove some dead code from the base load_data method
...
Was causing an odd error which threw off the error detection code
when the datastructure was a string corresponding to a variable.
11 years ago
James Cammarata
d977dd507c
Merge pull request #11609 from ofpiyush/devel
...
Fix #11369 A result is skipped when all it's children are skipped. Th…
11 years ago
James Cammarata
052f3c2ece
Fixing allow_duplicate and variable resolution bugs
...
Fixes #11205
11 years ago
Piyush
f2bdd9af29
Fix #11369 A result is skipped when all it's children are skipped. This makes it fundamentally different from a result that was changed/failed/unreachable
11 years ago
Brian Coca
5a5b7ff561
fixed first_available_found for template, refactored into common function
...
added deprecation warning
fixed display.deprecated to make version optional (code already assumed this)
turned warning + 'deprecated' in plugin loader into actual call to deprecated()
11 years ago
Jonathan Davila
6ea772931f
Connection function for boto3
...
Boto3 conn
11 years ago
Toshio Kuratomi
3d3e1c82a2
Have openssl autonegotiate tls protocol on python < 2.7.9
...
This allows usage of tls-1.1 and tls-1.2 if the underlying openssl
library supports it. Unfortunately it also allows sslv2 and sslv3 if
the server is only configured to support those. In this day and age,
that's probably something that the server administrator should fix
anyhow.
11 years ago
James Cammarata
ba7243c5f9
Don't set changed for include tasks
...
Fixes #11197
11 years ago
James Cammarata
291f07242c
Properly return Jinja2 Undefined class for bad hostvars lookups
...
Fixes #11176
11 years ago
James Cammarata
9fe0f21f6a
Allow omit to be used on Playbook-level fields
...
Fixes #11173
11 years ago
James Cammarata
165fff8a1e
Fixing module arg parsing splitting when action is a variable
...
Fixes #11122
11 years ago
Brian Coca
b76cb8f655
now that invocation is only async again, no need to sanitize
11 years ago
James Cammarata
2d870b7112
Fix logic where invocation details are added to results
11 years ago
James Cammarata
0b035a4e35
Unicode in result debug statements caused a traceback
11 years ago
Brian Coca
ae6d9ebf28
added maintainers (from author field) to ansible-doc
11 years ago
Brian Coca
fbec8bfb90
updated ref to add docfixes
11 years ago
Brian Coca
0e1d771a33
updated submodule refs
11 years ago
Toshio Kuratomi
3e293f524a
Merge pull request #11589 from ansible/get_url-sni-tls-fix
...
Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper
11 years ago
Toshio Kuratomi
327b1676a8
Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper
...
Fixes #1716
Fixes #1695
11 years ago
James Cammarata
8d887d8dd3
Adding back --start-at-task feature
...
Also implemented framework for --step, though it's not used yet
11 years ago
Brian Coca
3c7faa8378
fixed missing self in self.action on rekey in vault
...
fixes #11584
11 years ago
Brian Coca
42e355f9a3
fragments can now be a list
11 years ago
Brian Coca
ea159ef9de
fixed backup and validate fragments
11 years ago
James Cammarata
4e94bb64d8
Fix group/host var loading relative to playbook basedir
11 years ago
James Cammarata
7dd5600839
Allow empty include files again
...
Fixes #11582
11 years ago
Brian Coca
8793308c39
made md5 into generic checksum function that uses sha now
11 years ago
James Cammarata
6971e92f39
Fixing up some output stuff
11 years ago
James Cammarata
9a586c3512
Properly catch AnsibleError and not all errors
11 years ago
Brian Coca
2b723c6130
added missing re import
11 years ago
Brian Coca
3102469b94
fixing become success string
11 years ago
Brian Coca
a09f44210e
now callback errors are not silent but warnings
11 years ago
Brian Coca
e0632cb9a4
Merge pull request #11577 from srvg/yaml_file_extensions
...
Use YAML_FILENAME_EXTENSIONS for vars files.
11 years ago
Brian Coca
5daa540bc0
Merge pull request #11576 from srvg/combine_empty_vars_file
...
Do not combine group_vars with an empty file
11 years ago
Serge van Ginderachter
d5fb11d89c
Use YAML_FILENAME_EXTENSIONS for vars files.
...
The v2 codebase didn't use this previously introduced constant yet.
C.YAML_FILENAME_EXTENSIONS
11 years ago
Serge van Ginderachter
9c8f0da327
Do not combine group_vars with an empty file
...
This addresses a specific case with multiple vars files
in a group_vars/${groupname}/ directory where one of those files
is empty, which returns None instead of an empty dict.
11 years ago
Brian Coca
24b830bbc8
fixed executable for raw module
11 years ago
Brian Coca
c4b6d91275
added skipped to oneline
11 years ago
Brian Coca
8ad52c2e4f
readded oneline output feature to adhoc
...
fixes #11573
11 years ago
Brian Coca
3a768b3b9f
removed unused methods, these now live in base class
11 years ago
James Cammarata
c18fdd0c18
Re-implement "conditional imports" for vars_files
11 years ago
James Cammarata
d977da5b41
Fixing up fact_cache use in VariableManager
11 years ago
James Cammarata
932d1e57f7
Removing stray debugging print
11 years ago
James Cammarata
91c9bb96e3
Moving jsonfile cache plugin over and fixing #10883
...
Fixes #10883
11 years ago
Brian Coca
d8abae71a4
now assemble skips during checkmode
...
TODO: actually make it check with checkmode
fixes http://github.com/ansible/ansible-modules-core/issues/661
11 years ago
Alejandro Guirao
587a6cb44c
Remove v1 code
11 years ago
Alejandro Guirao
6e99023c84
Changed to support Ansible v2
11 years ago
Alejandro Guirao
8efc42d993
Add shelvefile lookup plugin
11 years ago
James Cammarata
f40b66d841
Make sure the basedir is unicode
...
Fixes #10773
11 years ago
Brian Coca
ba92965670
fix for when invocation data is missing
11 years ago
James Cammarata
c5c1dc2f11
Removing tags/when from role param hash calculation
11 years ago
Brian Coca
4203b699a8
removed dict comprehension as 2.6 does not like
11 years ago
Brian Coca
032690a843
fix read_vault_password_file ref
11 years ago
Brian Coca
d993e7000c
added cyan back to ignoring message
11 years ago
Brian Coca
064a34689a
now actually continues play on ignore errors
11 years ago
Brian Coca
fe91f7b506
moved read_vault_file to CLI from utils and renamed to clearer read_vault_password_file
11 years ago
Brian Coca
e4097ed279
simplified ansible errors, moved md5 hash import with notes to be more prominent
11 years ago
Brian Coca
1274ce565d
added result sanitation to registered var and to callbacks
...
removed time display as it only is provided by command module
11 years ago
Brian Coca
fdea00880b
now default shows time taken when -vv or above
11 years ago
Brian Coca
7a1bce1b5d
added verbose option to show callback loaded info
...
also made mail module print nicer without all those 'u'
11 years ago
Brian Coca
4b9a79d42b
removed trailing newline
...
fix from #10973 by @retr0h
11 years ago
teh 4r9h
705018a417
Misspell in mail.py callback.
...
Looks like little misspell.
11 years ago
Brian Coca
e9a3a2912d
Merge pull request #9281 from woltage/devel
...
Enables 'force basic auth' -feature globally
11 years ago
James Cammarata
4608897c27
Submodule update
11 years ago
Carlos E. Garcia
657495d13f
minor spelling changes
11 years ago
Brian Coca
aaad33ccb6
fixed a couple of bugs
11 years ago
Brian Coca
d0c6d2ff1c
poreted log_plays, syslog_json and osx_say callbacks to v2
...
renamed plugins to contrib (they are not really plugins)
rewrote README.md to reflect new usage
added new dir to setup.py so it gets copied with installation, in views
of making using inventory scripts easier in teh future
11 years ago
Brian Coca
50d54b1be7
ported hipchat callback to v2 (needs testing)
11 years ago
Brian Coca
e92e15b5f6
moved unused functions to base object
11 years ago
Brian Coca
b47d7babe5
removed warning i was using for debug
11 years ago
Brian Coca
834b7a2857
ported context_demo to v2 callbacks
11 years ago
Brian Coca
ba0e5323d6
removed connection info to _verbosity, just needed callbacks to call correct display.verbosity
...
added v2 methods and made them call v1 when possible by tranforming the data
11 years ago
Brian Coca
a918a1bd16
now calls correct v2_on_any callback method
11 years ago
Brian Coca
f9d817e636
now looks at correct verbosity and removes the need to set a copy of it in _verbosity
11 years ago
James Cammarata
cf2a66ef30
Add ansible_version magic variable
...
Fixes #11545
11 years ago
James Cammarata
b0e6baf8c3
Fix bug where options may not have the force_handlers value from the cli
11 years ago
James Cammarata
f8ddf2eb04
Move role cache into the play to avoid roles crossing play boundaries
11 years ago
James Cammarata
b520d5bc60
Lots of fixes for integration test bugs
11 years ago
Iiro Uusitalo
4e7542af37
Merge upstream changes
11 years ago
Iiro Uusitalo
403f4881ee
Enables 'basic auth force' -feature globally
11 years ago
James Cammarata
a9712bb0fb
Fixing some delegate_to bugs
...
* Moving connection creation until after the task is post_validated,
to make sure all fields are properly templated (#11230 )
* Fixing problems related to the connection method and remote address
lookup on the delegated-to host
Fixes #11230
11 years ago
Brian Coca
3ba67dd2d0
added ignore_hidden to assemble
11 years ago
Brian Coca
b5f3e84014
now allows for empty vars sections, returns empty dict
...
fixes #11532
11 years ago
Brian Coca
55366bdc6d
ported mail callback plugin to work with v2
11 years ago
Brian Coca
897e098b27
minor fixes to constants
11 years ago
Toshio Kuratomi
dd058a1dc2
Fix required_if (needed to pass list to _count_terms)
11 years ago
James Cammarata
27fcf1a4b5
Fix bug in registered variables related to delegate_to changes
11 years ago
James Cammarata
64a1b1e043
Fix first_available_file: support for copy and template actions
11 years ago
Toshio Kuratomi
ddac6fa9f3
Update exception handling to be python3 compat
11 years ago
James Cammarata
8f0496d7ce
Fix usage of set_host_var when registering a result var
...
Fixes #11521
11 years ago
James Cammarata
2e5dfd57cc
Clear flag indicating role had run before each play is run
...
Fixes #11514
11 years ago
Brian Coca
a02555ad91
Merge pull request #11483 from pilou-/jinja2_header_overrides
...
implement jinja2 header overrides
11 years ago
James Cammarata
f67949e42c
Readd logic for ansible_managed to template action plugin
...
Fixes #11317
11 years ago
James Cammarata
da307c8bfd
Fix bug in logic introduced in 614c626
11 years ago
James Cammarata
293dd38d05
Correctly handle assigning results to the delegated to host
11 years ago
Brian Coca
688088547b
new human_readable filter to transform bits and bytes into cake (not really)
11 years ago
Toshio Kuratomi
49a148056c
Ensure that we're dealing with byte str when we print or log messages
11 years ago
James Cammarata
614c626ed0
Fix no hosts remaining logic in linear strategy
11 years ago
Toshio Kuratomi
135fa41e3a
Update submodules refs
11 years ago
Marc Abramowitz
314bae2a9e
Don't wrap text for AnsibleParserError
...
This allows not messing up the wonderful error reporting that is
carefully created. Instead of:
$ ansible-playbook foo.yml
[ERROR]: ERROR! 'foo' is not a valid attribute for a Task The error appears
to have been in '/Users/marca/dev/git-repos/ansible/foo.yml': line 4, column 7,
but may be elsewhere in the file depending on the exact syntax problem. The
offending line appears to be: tasks: - name: do something ^ here
we get:
$ ansible-playbook foo.yml
ERROR! 'foo' is not a valid attribute for a Task
The error appears to have been in '/Users/marca/dev/git-repos/ansible/foo.yml': line 4, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
tasks:
- name: do something
^ here
which is much nicer.
11 years ago
Brian Coca
50efeb13ba
made squashable with_ plugin list configurable
...
partially deals with #11383
11 years ago
Brian Coca
a6aedbcc51
now correctly picks up old become password host vars
11 years ago
Toshio Kuratomi
49e17b8ff6
Get rid of an unused import so that we don't have circular imports
11 years ago
Toshio Kuratomi
5b0b1f8da6
unquote strings in the ansible config file
11 years ago
Toshio Kuratomi
f44f9569e1
Test unquote works as expected and fix two bugs:
...
* escaped end quote
* a single quote character
11 years ago
James Cammarata
1d8ccfb99f
Fixing includes where the included file is "{{item}}"
11 years ago
James Cammarata
46b33152c8
Check for ansible_su*_pass as well as _password
...
Fixes #11500
11 years ago
Toshio Kuratomi
378c8fd549
Update submodule refs
11 years ago
Brian Coca
2c9d1257ba
put type checking before looking against choices array to always get type comparrison correctly
11 years ago
Brian Coca
22a0aa016f
pbrun not forced to use local daemon anymore
11 years ago
Brian Coca
2a0cc38922
Merge pull request #11494 from jonhadfield/add_iso8601_basic_datetime
...
Add facts for datetime 8601 basic and basic short.
11 years ago
Brian Coca
05be30168d
return empty string when config file is not used
11 years ago
Jon Hadfield
82e00b1022
add facts for datetime 8601 basic and basic short.
11 years ago
Brian Coca
51efd765be
Merge pull request #11415 from msabramo/remove_unnecessary_imports
...
Remove unnecessary imports
11 years ago
James Cammarata
9155af20e3
Make sure vars in debug tasks aren't templated too early
...
If the syntax var={{something}} is used, that can be templated too
early in the post_validation, leading the debug module to fail when it
tries to template the same value in turn.
11 years ago
James Cammarata
38cc54b717
Make 'vars' a copy to prevent recursion issues
11 years ago
James Cammarata
bddadc9565
Fix bug in relative path determination
11 years ago
James Cammarata
38c5da9d2a
Revert "Backing out vars magic variable due to failed tests"
...
This reverts commit 388e46a485 .
11 years ago
James Cammarata
388e46a485
Backing out vars magic variable due to failed tests
11 years ago
James Cammarata
76c5be3a31
Add 'vars' to magic variables
11 years ago
Marc Abramowitz
0676157897
Remove unnecessary imports
11 years ago
Brian Coca
552715f072
added validate and backup doc fragments
11 years ago
Spencer Krum
3887173c2c
Use cfacter instead of facter if possible
...
CFacter is the facter replacement written in C++. It is available from
the puppetlabs repo.
11 years ago
Brian Coca
5f791329ce
now verbose mode shows config file used
11 years ago
James Cammarata
67671e328a
Fix callback loading issue a slightly different way
11 years ago
James Cammarata
a51c165157
Revert "load callbacks on init again as they did not seem to load with new call from executor"
...
This reverts commit cf4ed9a556 .
11 years ago
James Cammarata
2ddd83360a
Revert "removed 2nd load_callbacks that was causeing dupe output"
...
This reverts commit de98dc2968 .
11 years ago
Brian Coca
4d35d8bd31
properly booleanify copy field
11 years ago
Pierre-Louis Bonicoli
720e184f88
implement jinja2 header overrides
11 years ago
Brian Coca
de98dc2968
removed 2nd load_callbacks that was causeing dupe output
11 years ago
Brian Coca
bdccfa71a8
Merge pull request #11482 from verm666/issue-1627
...
facts: add aliases to ansible_all_ipv4_addresses on OpenBSD
11 years ago
Brian Coca
5122455db8
ported missing sequence updates from 1.9
11 years ago
Brian Coca
cf4ed9a556
load callbacks on init again as they did not seem to load with new call from executor
11 years ago
Brian Coca
9e37402cb7
added ramfs to selinux ignored filesystems
...
as reported in #11442
11 years ago
James Cammarata
31239f44cd
Show failed result on a retry message
...
Fixes #10099
11 years ago
verm666
d91947ee96
facts: add aliases to ansible_all_ipv4_addresses on OpenBSD
11 years ago
James Cammarata
08ad05c83b
Make sure callbacks are loaded in the tqm a bit earlier
...
Fixes #11463
11 years ago
Brian Coca
1b74102ab3
Merge pull request #11435 from hfinucane/ipwrap-generator
...
Treat generators like lists and tuples
11 years ago
Toshio Kuratomi
71f72b655e
Merge pull request #11432 from sivel/splitext-filter
...
Add splitext filter
11 years ago
James Cammarata
9341148f04
Throw an error if with_first_found finds no files by default
...
Fixes #9976
11 years ago
Toshio Kuratomi
b11e69f3d0
Merge pull request #11452 from soarpenguin/devel
...
fix type error.
11 years ago
Brian Coca
13ac0ba1fe
now setuptools will pull the data dir with templates that are used by galaxy init
11 years ago
Brian Coca
08e981b9f4
corrected api permissions
11 years ago
James Cammarata
cf51d0a790
Fixing up some check-mode stuff
11 years ago
James Cammarata
ad53b6f36a
Merge pull request #11461 from pilou-/shell_removed
...
Fix "AttributeError: 'ActionModule' object has no attribute '_shell'"
11 years ago
James Cammarata
7fa37870c8
Merge pull request #9683 from justinwyer/logical-block-size-and-sectors-9549
...
Disk size for advanced drives over 2 TB is incorrect
11 years ago
James Cammarata
dcb9b5a69f
Make --module-path work and expand tilde's in paths
...
Fixes #9937
Fixes #9949
11 years ago
Toshio Kuratomi
fffb65d45f
Update submodule refs
11 years ago
James Cammarata
2e386deeae
Make undefined variables in debug var=foo more obvious
...
Fixes #9935
11 years ago
James Cammarata
b6c52ce115
Allow role variables to be optionally kept in a private scope
11 years ago
Pierre-Louis Bonicoli
4d4512940d
Fix "AttributeError: 'ActionModule' object has no attribute '_shell'"
...
'_shell' was removed with commit 2a5fbd8570
11 years ago
Brian Coca
dcb06ac7a8
Merge pull request #11445 from emonty/devel
...
Fix a tiny typo
11 years ago
Brian Coca
0a2a9557b8
now allows for users to use ^D to not input a password
...
fixes #11413
11 years ago
Benno Joy
4889d04fc6
fixes 11448 , yum with with_items
11 years ago
soarpenguin
c6ed1ff4ad
fix type error.
11 years ago
James Cammarata
7c1d569a26
Make sure tags are pulled out of playbook includes properly
...
Fixes #9862
11 years ago
Toshio Kuratomi
54e7c8a3f7
Add python requirement to the documentation for openstack modules requiring shade
11 years ago
Monty Taylor
e89f1186e7
Fix a tiny typo
11 years ago
James Cammarata
ec4d1b11df
Fix some more handler issues
...
* Only notify handlers when the task is changed
* Don't run handlers on hosts which have failed
11 years ago
James Cammarata
2576f480fd
Restoring a state check to play_iterator, which otherwise broke block functionality
11 years ago
Matt Martz
65fdcf8b9d
Check for name or pkg when templating squashed items. Fixes #11430
11 years ago
James Cammarata
0cfebb8760
Fixes a bug whereby tags are expected to be a set
...
Fixes #11424
Fixes #11429
11 years ago
Brian Coca
d149ea5222
ported timer.py callback to v2
11 years ago
Brian Coca
7416e00541
fixed condition for loading whitelisted callbacks
11 years ago
James Cammarata
9785e5397e
Fix typo in SharedObjectLoader field basedirs
11 years ago
James Cammarata
927072546b
Fixing up some issues with plugin loading
11 years ago
James Cammarata
2a5fbd8570
Winrm fixes for devel
...
* Include fixes for winrm connection plugin from v1 code
* Fixing shell plugin use
11 years ago
Henry Finucane
2d1cb7f328
Treat generators like lists and tuples
11 years ago
Toshio Kuratomi
8a76371a1c
Merge pull request #11394 from dlundquist/ipaddr-slaac-filter
...
IPv6 SLAAC address computation filter
11 years ago
Matt Martz
4059904a18
Add splitext filter
11 years ago
Toshio Kuratomi
be6db1a730
Refactor the argspec type checking and add path as a type
11 years ago
James Cammarata
21c14363fd
Allow callback plugins to be whitelisted
11 years ago
James Cammarata
24226646fc
When loading the play hosts list, enforce some consistency
...
Fixes #9580
11 years ago
James Cammarata
9d9cd0c42c
Handle getting the ds for Conditionals which may not be mixed in
11 years ago
James Cammarata
f433e709f2
Fix templating of hostvars values
...
Also adds play information into the hostvars creation, to assure the
variable manager used there has access to vars and vars_files
Fixes #9501
Fixes #8213
Fixes #7844
11 years ago
James Cammarata
8ef28253e3
Properly catch and report conditional test failures
11 years ago
James Cammarata
0eb1c880dd
Use itertools instead of set for tags, as the data may not hash well
...
The tags field may contain bad data before it is post_validated, however
some methods assumed it would be a simple list or string. Using itertools
gets us around the problem of the data potentially not being hashable
Fixes #9380
11 years ago
Brian Coca
af49944ab2
Merge pull request #11398 from resmo/for-ansible
...
cloudstack: fixes and updates
11 years ago
James Cammarata
bb8d87ceb6
Allow field attributes which are lists to validate the type of the list items
...
Starting to apply this for tags too, however it is not correcting things
as would be expected.
11 years ago
James Cammarata
f68223b9ed
Don't add module args into variables at all
...
Getting recursive errors otherwise, so this is probably not something
we want to do. This most likely only worked in v1 due to the fact that
module args were templated earlier than the point in Runner() when
they were fed into the templating engine.
11 years ago
Brian Coca
e153f76c95
now validate that we do get a vault password
11 years ago
Uli Martens
25fc0c7e1b
Fixing bug in failed_when results introduced by c3c398c
11 years ago
James Cammarata
b723f9a09a
Allow squashed loop items to use name=foo-{{item}}
...
Fixes #9235
Fixes #11184
11 years ago
Rene Moser
7952723530
cloudstack: fix domain name is not unique, use full path
11 years ago
Rene Moser
b9b1e294d7
cloudstack: add get_or_failback()
11 years ago
Dustin Lundquist
cf7744f2f1
IPv6 SLAAC address computation filter
...
Jinja2 filter to compute SLAAC address.
Usage:
{{ '2db8::/64' | slaac(ansible_eth0.macaddress) }}
11 years ago
Toshio Kuratomi
9911a947ed
Vendorize match_hostname code so that ansible can push it out to clients along with the code that uses it.
11 years ago
Toshio Kuratomi
00aed57295
Update submodule refs
11 years ago
Toshio Kuratomi
160e71e2cf
Some flake8 cleanup
11 years ago
James Cammarata
332ca927d9
Fix parent attribute lookup
...
Using 'value is None' instead of 'not value', in order to account
for boolean values which may be false
Fixes #11232
11 years ago
James Cammarata
256a323de5
Submodule update
11 years ago
Toshio Kuratomi
548a7288a9
Use BUFSIZE when putting file as well as fetching file.
11 years ago
Toshio Kuratomi
270be6a6f5
Fix exec_command to not use a shell
11 years ago
Toshio Kuratomi
a1a7d6c462
Fix forwarding the user-given params from fetch_url() to open_url()
11 years ago
Toshio Kuratomi
e461241d7b
Fix fetch_file() method
11 years ago
James Cammarata
d0d9be30d5
Correctly compile handler blocks for dependent roles
11 years ago
James Cammarata
0b16580567
Add in playbook_dir magic variable
11 years ago
James Cammarata
4c6adcf143
Submodule pointer update
11 years ago
Hugh Saunders
4246777759
Re-implement the ssh connection retry, originally added in 2df690
11 years ago
James Cammarata
006391eb83
Add the improved exception reporting to the minimal callback plugin
11 years ago
Toshio Kuratomi
6aae500a2c
Documentation fix
11 years ago
Toshio Kuratomi
125e6f49a1
Update submodule refs
11 years ago
James Cammarata
72d4b40a26
Don't allow empty (none) loop values
...
Fixes #8593
11 years ago
James Cammarata
24d2202591
Make sure role parsing can handle a few more types in includes/defs
11 years ago
James Cammarata
aa53212a9b
Don't use all task params for vars, just the module args
11 years ago
Toshio Kuratomi
952166f48e
Fix problem with chroot connection plugins and symlinks from within the chroot.
11 years ago
Toshio Kuratomi
61e367f549
Better error messages when the file to be transferred does not exist.
11 years ago
James Cammarata
7490044bbe
Implement play_hosts magic variable (and ansible_current_hosts)
...
Fixes #8073
11 years ago
James Cammarata
cb5f630f33
Don't post_validate vars and vars_files on Play objects
...
Fixes #11343
11 years ago
James Cammarata
ff251a0dcc
Catch runtime errors due to recursion when calculating group depth
...
Fixes #7708
11 years ago
James Cammarata
97954ff658
Minor tweak to potentially speed the linear strategy up
...
* Don't fetch vars for the task unless we're going to use them
11 years ago
Benno Joy
f17bdc4d61
Set the ansible_ssh_port variable instead of saving it internally for Host
...
Fixes #11330
11 years ago
Brian Coca
b34b606fcf
fixed and/or grouping
11 years ago
Brian Coca
68325dbfe2
fixed remote tmp creation when becoem user is not root and '~/' instead of $HOME is the default
11 years ago
Brian Coca
102de96ebf
avoid password handling when no password is supplied
11 years ago
Brian Coca
3bad03d57a
cleaned up and optimized become handling paths
11 years ago
Benno Joy
be81b650e8
fixes issue 11286 where role handlers are not run
11 years ago
James Cammarata
fc5be30c2f
Change the use of a mutable arg for a default value for locals
11 years ago
James Cammarata
0d92599d18
Make exception printing a bit smarter
11 years ago
Toshio Kuratomi
a77b58e351
Bumpt the BUFSIZE to 64k for better performance
11 years ago
Toshio Kuratomi
0777d02505
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
11 years ago
Toshio Kuratomi
ca2f2c4ebd
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
11 years ago
Toshio Kuratomi
f0777d9c4e
Update submodule refs
11 years ago
James Cammarata
18a9eff11f
Properly use local variables from templates including other templates
...
Fixes #6653
11 years ago
James Cammarata
c0dfa8d512
Make sure task names are templated before callbacks are sent
11 years ago
James Cammarata
98fee172ee
Fix bug in async action plugin
11 years ago
James Cammarata
270eb4274c
Make sure we safe_eval booleans too
...
Fixes #5779
11 years ago
Brian Coca
4d5a98d8d9
Merge pull request #11307 from dagwieers/patch-6
...
Change syslog (priority) level from LOG_NOTICE to LOG_INFO
11 years ago
Brian Coca
7bb2a7aa87
actually no password to handle, this should return false
11 years ago
Brian Coca
87a0ccc354
fixed typo
11 years ago
Brian Coca
aede9f08db
fixed case in which prompt was None
11 years ago
Dag Wieers
4ca4d36ae6
Change syslog (priority) level from LOG_NOTICE to LOG_INFO
...
If you look at the meaning of the different syslog levels, NOTICE means that the event may need someone to look at it. Whereas INFO is pure informational.
Since module invocations are in fact requested (deliberate) actions, they shouldn't need any additional post-processing, and therefore should not be logged as NOTICE.
This may seem like hairsplitting, but correctly categorizing system events helps weeding through the noise downhill.
According to Wikipedia: https://en.wikipedia.org/wiki/Syslog
5 Notice notice Events that are unusual but not error conditions .
6 Informational info Normal operational messages -no action required. Example an application has started, paused or ended successfully.
11 years ago
Brian Coca
7c65f3ddd7
partial become support for local connection plugin
11 years ago
Brian Coca
671118ba71
fixed become password handling with paramiko
11 years ago
Brian Coca
744ec2bbad
put hostkey locking into function (still needs fixing)
...
implemneted become handling here, cannot generalize well enough in base class
11 years ago
Brian Coca
d6672ad285
removed unused import
11 years ago
Brian Coca
5cfd0f82a0
moved away from generic function for become
11 years ago
Brian Coca
3fab516d3d
fixed detection of incorrect password
11 years ago
Brian Coca
faed1b2d05
better error reporting when doc parsing fails
11 years ago
James Cammarata
87ca475704
Exclude the all/ungrouped groups from pattern matching results
...
Fixes #5375
11 years ago
James Cammarata
90445ee67d
Add ::1 where we see 127.0.0.1, for better ipv6 support
...
Fixes #5764
11 years ago
James Cammarata
c3c398cffe
Cleaning up some task failure detection problems
...
* fixed a bug in which failures from a with_* loop were not being
caught correctly, leading to tasks continuing when they should stop
* when ignore_errors is enabled, the failure will no longer count
towards the number of failed tasks
11 years ago
Marc Abramowitz
a385744426
Add inventory file to "Unable to find" error msg
...
E.g.:
$ ansible gabriel -m ping -i ssh_config.py
ERROR! Unable to find an inventory file (ssh_config.py), specify one with -i ?
11 years ago
James Cammarata
daa319881f
Make sure registered variable message is sent before other messages
...
Avoids a race condition where previously the registered variable message
was being sent after the 'host_task_ok' message, meaning the next task
may be started before the var is registered, leading to an undefined
variable error
11 years ago
Benno Joy
0d5b7ae669
fixes 11296 where the groups does not have all the groups
11 years ago
James Cammarata
ff998b6022
Make sure the templar is using the right vars when evaluating conditionals
11 years ago
Brian Coca
d7fcd9456a
Merge pull request #11288 from kstrauser/aixfixes
...
Don't panic if AIX's uname doesn't support -W
11 years ago
Kirk Strauser
eb820837ac
Don't panic if AIX's uname doesn't support -W
...
The current code expects "uname -W" on AIX to always succeed. The AIX 5
instance I have doesn't support the -W flag and facts gathering always
crashes on it.
This skips some WPAR handling code if "uname -W" doesn't work.
11 years ago
Kirk Strauser
935da01068
Fixes for FreeBSD get_memory_facts
...
- swapinfo on FreeBSD 6 (maybe 7 too?) doesn't support the "-m" flag for
fetching amounts in megabytes. This patch fetches amounts in kilobytes
and divides by 1024 (and also returns the result as an int instead of
a string).
- When no swap is configured, swapinfo prints a header line and nothing
else:
$ swapinfo
Device 1K-blocks Used Avail Capacity
The old version unexpectedly parsed that header line and emitted
nonsense values like:
"ansible_swapfree_mb": "Avail"
"ansible_swaptotal_mb": "1K-blocks"
This version emits those items altogether.
11 years ago
Brian Coca
3b1b95b916
moved ipv6 handling to init
...
fixed become password handling
11 years ago
Brian Coca
bb7d33adbc
moved become password handlingn to base class
11 years ago
James Cammarata
4b28a51f25
Don't fail outright when a play has an empty hosts list
11 years ago
James Cammarata
30c1a2d861
Have group/host var file loading check for YAML extensions too
...
Fixes #11132
11 years ago
Brian Coca
423f1233c8
removed typo file
11 years ago
Brian Coca
c87591f76f
updated to new exec_command signature
11 years ago
Brian Coca
b76dbb01cc
generalized prereqs check
...
added vaultfile class for action and lookup plugin usage
11 years ago
Brian Coca
9116ff1c28
replaced removed pager_print for print
11 years ago
Brian Coca
98f5534d9c
adaptaed to new exec signature
...
should fix #11275
11 years ago
Brian Coca
6c884c9e39
Merge pull request #11271 from sivel/build-play-method
...
Allow AdHocCLI to be more flexible for overriding
11 years ago
Brian Coca
dcf81e3ffe
removed useless comments
11 years ago
Matt Martz
1d55e193c1
Expose the TaskQueueManager to self
11 years ago
Matt Martz
670894e2bd
Move building the play_ds into a method, that can be overridden
11 years ago
Brian Coca
8ae58f7ea3
fixed executable, correctly this time
11 years ago
Brian Coca
f576d29b6b
allow for any non string iterable in listify
11 years ago
Brian Coca
1ce1c52f6f
centralized bad password handling, fixed outputing of become method
11 years ago
Brian Coca
b89071e485
now detects incorrect password with sudo and su (at least in english)
11 years ago
Brian Coca
be8d797c23
fixed su prompt function reference
11 years ago
Brian Coca
872448e9e8
updated connection info update_vars to only update if data is not alreayd present
...
aslo added comment clarifying why we do this
11 years ago
Brian Coca
956937b110
made executable shell configurable again
11 years ago
Brian Coca
580993fef7
enabled initial support for password prompt on become
...
- moved check prompt/password functions to connection, make more senes there
- TODO: consider moving make_become to connection from connection_info
- removed executable param that was never overriden outside of connection info
11 years ago
Brian Coca
bac35ae773
set correct become mehotds for plugin
...
fixed mixup with remote password vs become_password
11 years ago
Brian Coca
ff443d4534
added note to figurte out correct var udpate on connection_info
11 years ago
Brian Coca
c3ccf26b70
added become check back to connections
11 years ago
Brian Coca
de82c953f2
added privilege escalation special var mapping
11 years ago
Brian Coca
a248678518
initial become support to ssh plugin
...
- password prompt detection and incorrect passwrod detection to connection info
- sudoable flag to avoid become on none pe'able commands
11 years ago
Brian Coca
a267f93c83
removed incorrect assumption on become user being set
11 years ago
Brian Coca
ff15f374ad
fixed new become settings, rearranged constants to find PE related vars easier
11 years ago
Brian Coca
e7abe06440
added first_found to template
11 years ago
Brian Coca
8ee4c7266c
corrected original_file code path to use actually use data from original file
11 years ago
Brian Coca
491761f880
added note to add faf deprecation
11 years ago
Brian Coca
a6ca133da8
got first_available working with copy
11 years ago
Brian Coca
aca125d03e
Merge pull request #11252 from sivel/deprecated-warning
...
Display a warning when using a deprecated module
11 years ago
Matt Martz
9ed3e2ef48
Display a warning when using a deprecated module
11 years ago
Toshio Kuratomi
d315f6e22c
Fix Etcd constructor
11 years ago
Toshio Kuratomi
77c76e632e
Switch etcd and url lookup plugins to verify ssl certificates
11 years ago
Toshio Kuratomi
4161d78a94
Split the fetch_url() function into fetch_url and open_url().
...
open_url() is suitable for use outside of a module environment. Will
let us use open_url to do SSL cert verification in other, non-module
code.
11 years ago
Brian Coca
e07dde1a3c
Merge pull request #11251 from sivel/issue/11244
...
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
i was almost done with my patch ... but I like yours better
11 years ago
Matt Martz
a4e2d1eb62
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
11 years ago
Brian Coca
aaab69cae9
brought back terms testing as with_ is not only way to call and we cannot guarantee terms is a list otherwise.
11 years ago
Toshio Kuratomi
c346788194
Slight optimization of how we squash loops. Add dnf to the list of modules for which we squash.
...
Fixes #11235
11 years ago
Brian Coca
aed429554d
better checks to ensure listify emits a non string iterable
11 years ago
Brian Coca
c8fde467b5
Merge pull request #11163 from sivel/ssh-private-key-fixme
...
Re-introduce ssh connection private key support
11 years ago
Brian Coca
f174682e19
facts should now not be overriten with NA option unless they are NA
...
this way we don't need a break per distro that matched already with
the python default functions
11 years ago
Brian Coca
4098e8283e
several fixes to template
...
- now obeys global undefined var setting and allows override (mostly for with_ )
- moved environment instanciation to init instead of each template call
- removed hardcoded template token matching and now use actually configured tokens, now it won't break if someone changes default configs in ansible.cfg
- made reenetrant template calls now pass the same data it got, dictionary and lists were loosing existing and new params
- moved fail_on_undeinfed parameter to template call, as it should only realky be set to false on specific templates and not globally
- added overrides, which will allow template to implement jinja2 header override features
- added filter list to overrides to disallow possibly insecure ones, TODO: check if this is still needed as facts should not be templated anymore
- TODO: actually implement jinja2 header overrides
11 years ago
Brian Coca
7291f9e965
removed cruft
...
made sure it does not fail on undefined
11 years ago
Brian Coca
f29c1c7452
respect undefined config setting
11 years ago
Brian Coca
40336b50af
removed redundant string check
...
added playbook path lookup
11 years ago
Brian Coca
7306a5397e
simplified function, always attempt to template, always check if string before return, should avoid most cases of strings being passed to lookups
11 years ago
Brian Coca
aa6e204b6e
Merge pull request #11115 from jhawkesworth/second_go_at_fixing_1404
...
Part fix for https://github.com/ansible/ansible-modules-core/issues/1404 (replaces #11086 )
11 years ago
Brian Coca
f2934eeb0a
Merge pull request #11226 from resmo/for-ansible
...
cloudstack: cleanup, remove unused parts
11 years ago
Brian Coca
d68111382d
updated with nagios doc fix
11 years ago
Brian Coca
39764ed7d8
updated submodule refs
11 years ago
Rene Moser
0b074c449b
cloudstack: methods renaming
11 years ago
Rene Moser
7b3dd55c3d
cloudstack: remove unused methods used for backward compatibility
11 years ago
Dionysis Grigoropoulos
6f11896303
ansible-pull: Add option to verify gpg signature of a commit
...
Add option '--verify-commit' to verify a GPG signature of the checked
out commit. As noted in the git module documentantion, this requires
git version >= 2.1.0
11 years ago
Brian Coca
757fb39a2e
now uses new module_loader
11 years ago
Brian Coca
24b7c353cc
readjusted limit opts, makes no sense in adhoc when you already specify selection
...
changed pull to reflect this
11 years ago
Brian Coca
845d564d89
removed debug, moved limit to runtask instead section
11 years ago
Brian Coca
fdeca37257
switched to argv[0] from __file__ as it is what we actually wanted
11 years ago
Brian Coca
5aec5e5eb0
fixed ansible pull, reorged validate function for cli to be function specific like parser
...
added missing cmd_functions with run_cmd, mostly for ansible pull
11 years ago
Brian Coca
19161dfd72
fixed typo in placeholder check
11 years ago
Rene Moser
fc3020c57a
cloudstack: prevent getting the wrong project.
...
Since we use domain and account data to filter the project, listall is not needed and can return the wrong identical named project of another account if root admin permissions are used.
Fixed projects names are not case insensitive.
11 years ago
Brian Coca
8e3213a91e
updated copyright as MPD does not deserve the blame for this one
11 years ago
Brian Coca
45f80328ae
updated submodule refs
11 years ago
Brian Coca
70b5c28694
initial implementation of the generic OS package module
11 years ago
Toshio Kuratomi
e88a9e943c
Use to_bytes to avoid tracebacks when passed a byte str instead of a unicode string
...
Fixes #11198
11 years ago
Brian Coca
97bc92d2df
minor cleanup, pushed ipv6 fixing to init
...
pushed up using host short var
made close conditional, started implementing close for controlmaster
11 years ago
Matt Martz
6a1c175991
Raise AnsibleParserError instead of AssertionError
11 years ago
Brian Coca
bdba807fd1
minor fixes to ssh error reporting
...
shoudl fix #11041
11 years ago
Edward J Kim
6a5a930c5a
Add missing import in vault.py
11 years ago
Toshio Kuratomi
65d982b186
Merge pull request #11186 from sivel/winrm-syntax-error
...
Fix syntax error in winrm
11 years ago
Brian Coca
d67c9858a9
removed become_pass as it should not be used
11 years ago
Brian Coca
46673cd620
Merge pull request #11183 from sivel/issue/11169-become-pass
...
Don't empty out become_pass. See #11169
11 years ago
Matt Martz
6f5ebb4489
Fix syntax error in winrm
11 years ago
Matt Martz
45b4ee9cfe
Don't allow setting become_pass in a play
11 years ago
Toshio Kuratomi
f9b56a5d7c
Fix raising AnsibleError
11 years ago
Matt Martz
6bc2ea1f2b
Don't empty out become_pass. See #11169
11 years ago