Commit Graph

12189 Commits (297312546dfde5b1856f1a4bea4b4d1259f44b51)

Author SHA1 Message Date
Stein Inge Morisbak 5b56faeed2 Fall back to simplejson if ImportError on json 9 years ago
Brian Coca 701a85e7fc revamp of gluster volume management also implemented deleting a volume 9 years ago
Michael Scherer 3dab019dca Add a new option immediate= to immediately apply a permanent change
Currently, either you apply the change in the configuration
of firewalld ( without permanent=True ), or you apply it live.
I most of the time want to do the 2 at the same time, ie open the
port ( so I can use the service ) and make sure it stay open on reboot.
9 years ago
Jeroen Thora 26ae02b2f5 Small typo fix 9 years ago
Brian Coca baf514957c moved version added 9 years ago
Brian Coca 3ef53f92eb minor cleanup, removing unused/redundant code, cleaned some comments, slight reformating in class to remove kwargs 9 years ago
Ravi Bhure 7e83da3480 Recorded the changes suggested by brian coca 9 years ago
Ravi Bhure e0f0cc4049 used ansible conventions to use trigered action ==> state, now only two states are available enabled/disabled_ get weight for backend server, is default behavior for both state, supports set weight while enable server in lb pool 9 years ago
Ravi Bhure a1c5149de3 Instead of action [enable_server,disable_server] we prefer to use state [enabled,disabled] [FIXED] misplaced the checkmode support (#L146) [FIXED] no need to check if host is not set as the argument spec (#L138), it should already complain about that [FIXED] 9 years ago
Ravi Bhure 6edde18f90 updated version 1.9 and moved haproxy module to network category 9 years ago
Ravi Bhure 594b5ce64b Added module haproxy, to handle enable/disable backend server with shutdown_sessions feature in haproxy. 9 years ago
Brian Coca 9057295065 changed to use ansible standard 'name' instead of 'package' 9 years ago
Brian Coca 766125d585 minor doc tweaks to snmp_facts 9 years ago
Toshio Kuratomi 79bd23da3e Fixes to documentation 9 years ago
ogenstad 61cf02b727 1.9 9 years ago
ogenstad 779614e9cf added_version -> 1.9 and file move 9 years ago
ogenstad ba456c0020 Snmp module for Ansible 9 years ago
nate-kingsley 854e086efc Adding Uptime Robot Module
Added uptime robot module. This currently has the ability to start or
pause existing monitors. The ability to create or delete is forthcoming.
9 years ago
Taneli Leppä 36fb7e0529 Added .py extension to glusterfs module. 9 years ago
Taneli Leppa 71172bd762 Added GlusterFS module. 9 years ago
Peter Mounce 71d2faab18 Windows package management with Chocolatey 9 years ago
Peter Mounce f408ac2d82 Add module to install windows updates
Supports specifying which category to install all updates from.
NEEDS: `choco install PSWindowsUpdate` beforehand - does not attempt to install it (or detect it's missing, yet)
PSWindowsUpdate: http://gallery.technet.microsoft.com/scriptcenter/2d191bcd-3308-4edd-9de2-88dff796b0bc#content
9 years ago
Cristian Van Ee e7146ed265 Fixed cachedir function 9 years ago
Cristian van Ee b0a1baa981 Created dnf package manager module, based on the yum package manager module. 9 years ago
Ben Mather 1e98302cb8 mark all actions as private 9 years ago
Ben Mather 1a30d3fcfd mark list as private instead of shadowing 9 years ago
Ben Mather eebde78ded make it possible to configure the content type of a github webhook 9 years ago
Ben Mather 06559cad3c rename list to list_ to avoid shadowing in github_hooks module
The definition was leaking into ansible.module_utils.basic and causing
type checking to fail when running module as script.  Not entirely clear
why this should be the case.
9 years ago
Aurélien Bompard 27afdc9566 Module alternatives: support RedHat-based OSes
RedHat-based OSes have a version of update-alternatives which comes from
the chkconfig package and does not support the --query parameter. Work
around that.
9 years ago
Aurélien Bompard 2d5c2dabe8 Module alternatives: support check mode 9 years ago
Michael Warkentin 7925c0a453 Add bower module 9 years ago
Steve 2cb1176bc2 New crypttab module for editing Linux /etc/crypttab file 9 years ago
René Moser cc666194ac zabbix_group: new module
Add or remove a host group to Zabbix.

Signed-off-by: René Moser <mail@renemoser.net>
9 years ago
Toshio Kuratomi cdb9c1b1c4 Use the python db api to quote mysql values 9 years ago
Brian Coca ff66d56d4a corrected and made better docs for getent 9 years ago
Joseph Tate 5faecb76ae Actually what we need is to import the urls utils 9 years ago
Joseph Tate b75c10d5ea If you're going to use urllib, you'd better import it 9 years ago
Toby Evans 7685d60c58 Update the webhook url
This change fixes the 404 seen with the current version.

fixes #100
9 years ago
Michael Warkentin 45f2a6734d Fix typo: `authenicate` -> `authenticate` 9 years ago
Artem Chernikov b4c6b81619 Fixing SuSE to SUSE as latter is the right one since some time 9 years ago
Toshio Kuratomi ae51f28420 Move from md5 to sha1 to work on fips-140 enabled systems 9 years ago
Filipe Niero Felisbino d740265e13 Replace dev_string to dev_list 9 years ago
Michael DeHaan cf622a7299 Categorize some modules. 9 years ago
Michael DeHaan 7d6ceb4f06 Reorganization. 9 years ago
Michael DeHaan ee87304fb8 Fix rename error. 9 years ago
Michael DeHaan 55b41340fc Module reorg 9 years ago
anatoly techtonik 2a67586432 README.md: Reference module development guide (fixes #10) 9 years ago
Sergei Antipov e60d6e413a Added missed importing 9 years ago
Eric Hanchrow aff36f5a97 Clarify doc for cpan module
... note that you can pass names that include a precise version number.
9 years ago
Chris West 4176c3b500 Enable "ufw default allow routed"
* The policy is shown in `status verbose`, so all the check mode stuff should keep working.
 * `--dry-run` works as expected.
 * No idea whether it's legal as an argument to `interface`
9 years ago
Boris Manojlovic b1ec3fd57e fixed zypper.py and zypper_repository.py for SLE10 platform 9 years ago
anatoly techtonik cb70fbc9d1 composer: Fix `changed` status that always returns False
re.match in has_changed function never worked properly, because match
requires searched sequence to be present exactly at a start of processed
string, which is not the case here.
9 years ago
Mikolaj Chwalisz 5e9f16b206 opkg: fix package state detection 9 years ago
Paul Nicholson 8875d45632 Add missing __init__.py files for find_package() to work 9 years ago
Baptiste Mispelon 7a60427749 Fixed typo in locale_gen documentation. 9 years ago
Philip Misiowiec 85c15e5303 Added version 9 years ago
Philip Misiowiec 7db849397c Ability to enable SSL when creating MongoDB users 9 years ago
jravetch 2a8fc63645 mkfs.xfs uses -f instead of -F flag
mkfs.xfs uses the -f instead of -F flag to force creating a filesystem on a devices that have an existing filesystem
9 years ago
kustodian e9f98c0efc mysql_replication should not connect to the 'mysql' database
All the actions by the mysql_replication plugin can be done by connecting to the NULL database. There is no need to connect to the 'mysql' db, since there are permissions problems when connecting to remote hosts, e.g. when you want to query "SHOW MASTER STATUS" on a remote host.
9 years ago
René Moser e9eb19a7f2 zabbix_maintenance: set state to be present by default
Signed-off-by: René Moser <mail@renemoser.net>
9 years ago
Patrik Lundin 66cb7f1a37 openbsd_pkg: revert "changed" simplification.
module.exit_json() does not like when the "changed" variable contains a
match object:

TypeError: <_sre.SRE_Match object at 0x81e2ae58> is not JSON serializable
9 years ago
Patrik Lundin 98dcb3a006 Simplify logic by using required=True. 9 years ago
James Cammarata e7405643e1 Refactor openbsd package upgrade change to work more like yum/apt 9 years ago
Patrik Lundin 6aaf5eb1d6 openbsd_pkg: add upgrade argument.
Running the module with the argument "upgrade=yes" invokes an upgrade of
all installed packages.

While here clean up some comments.

Functionality requested by @qbit.
9 years ago
Michael DeHaan d2110d7502 Update README.md 9 years ago
Michael DeHaan 7ba58f93a0 package files 9 years ago
Michael DeHaan 5879c503bb File extensions! 9 years ago
James Cammarata d4b117843a Copying snapshot of extras modules 9 years ago
James Cammarata 8afa090417 Resolving differences in core modules post-merge 9 years ago
James Cammarata 95d59b61eb Removing unnecessary files before repo merge 9 years ago
Toshio Kuratomi 7319104552 Refreshed metadata for core modules 9 years ago
Adam Chainz 46ca2b8bcd Cloudformation - remove dead invoke_with_throttling_retries function (#5690)
Unused since f040d63403.
9 years ago
Fabio Alessandro Locati 5edbbabe0b Call main in conditional way - packaging (#5826) 9 years ago
Fabio Alessandro Locati 17c80f6bbb Call main in conditional way - utilities (#5827) 9 years ago
Fabio Alessandro Locati 2e34bad425 Call main in conditional way - files (#5828) 9 years ago
Fabio Alessandro Locati 8855b3274c Call main in conditional way - databases 9 years ago
Fabio Alessandro Locati 21bd86ef1d Call main in conditional way - cloud/rackspace 9 years ago
Fabio Alessandro Locati c8fd24ee04 Call main in conditional way - cloud/amazon 9 years ago
Fabio Alessandro Locati 1c3aeb5cb7 Call main in conditional way - source_control 9 years ago
Fabio Alessandro Locati a6cd0272fb Call main in conditional way - system 9 years ago
Fabio Alessandro Locati 4d2a3229d3 Call main in conditional way - web_infrastructure 9 years ago
Toshio Kuratomi 42a5b1977f Do not use the fstab parameter on openbsd for mounting (#5805)
* Do not use the fstab parameter on openbsd for mounting

OpenBSD's mount command doesn't allow selecting which fstab file to use.
So if we're operating on the live filesystem (mount or remount) return
an error if the user specified an fstab file.

Fixes #5591

* Fix the logic inversion (thanks to @landryb)
9 years ago
Fabio Alessandro Locati a5a15acd55 Native YAML - files/file.py (#5799)
* Native YAML - files/file.py

* Rollaback part of the change as for request
9 years ago
Fabio Alessandro Locati 8b7db84e91 Native YAML - cloud/google/gce.py (#5800) 9 years ago
Fabio Alessandro Locati 2b0bdd45e8 Unquote urls in YAML - windows (#5798) 9 years ago
Fabio Alessandro Locati ca047c3881 Unquote urls in YAML - cloud (#5797) 9 years ago
Fabio Alessandro Locati eb54b80a92 Unquote urls in YAML - system (#5796) 9 years ago
Fabio Alessandro Locati 18d022d808 Unquote urls in YAML - source_control (#5795) 9 years ago
Fabio Alessandro Locati 013be6fa1c Unquote urls in YAML - web_infrastructure (#5794) 9 years ago
Fabio Alessandro Locati 8ae7d2dcc4 Unquote urls in YAML - packaging (#5793) 9 years ago
Fabio Alessandro Locati e49667d94c Unquote urls in YAML - network (#5792) 9 years ago
Evan Kaufman 580c74140a Fix for python 2.4 compatibility (#5693)
Fixes #5692
9 years ago
Asara dddf810a19 Fixed typo in docker_image.py docs (#5764) 9 years ago
Brian Coca e3a43c0d4b made fact_path actual path (#5789) 9 years ago
Ted Timmons 367f675420 use 'six' for urlparse compatability (#5777)
* use 'six' for urlparse compatability
9 years ago
John R Barker b05df29978 Missing space between key:value (#5785) 9 years ago
René Moser 507559dba5 doc: network: fix syntax errors in examples (#5780) 9 years ago
Rob White 3f81a65e53 Fail if specifying an ENI as device but in_vpc is not true 9 years ago
Dustin C. Hatch b49aa70c29 systemd: Start inactive units for reload/restart
The `service` module starts services that are not running when
`action=restarted` or `action=reloaded`, which is especially convenient
for initial deployments because it eliminates an extraneous operation
for when the service starts for the first time. This commit adjusts the
behavior of the `systemd` module to match.
9 years ago
Matt Davis ce0412aa85 Fix test failures in win_command/win_shell on Powershell 3
Switched to use Exit-Json to avoid JSON escaping bugs in ConvertTo-Json formatter without -Compress option.
9 years ago
Wouter Oosterveld 61060f4b5f mysql_user: fix user_mod on MySQL(-like) 5.7+ (Fixes #3003) (#5388) 9 years ago
ekultails 0358919db8 add correct SELinux file context for crontabs (#4511) (#4595) 9 years ago
David Wittman cc334a078b Set IdentitiesOnly=yes when using key_file (#5682)
Sets the SSH option `IdentitiesOnly=yes` in the SSH wrapper when a
`key_file` is provided to the git module. This option ensures that
the provided key is used. Otherwise, the system's ssh-agent could
provide undesired identities when connecting.

From ssh_config(5):

> Specifies that ssh(1) should only use the authentication identity and
> certificate files explicitly configured in the ssh_config files or
> passed on the ssh(1) command-line, even if ssh-agent(1) or a
> PKCS11Provider offers more identities. The argument to this keyword
> must be “yes” or “no”. This option is intended for situations where
> ssh-agent offers many different identities. The default is “no”.
9 years ago
Matt Clay 86d53db3e4 Update async_wrapper.py to remove own temp dir. (#5719) 9 years ago
jctanner d41b4e3802 Use the the new features of fail_if_missing for checkmode (#5750) 9 years ago
Brian Coca d2fec9d259 added docs for use option
(cherry picked from commit ad5cb0f0d7231ff74d7918faa26091ba710c4709)
9 years ago
Toshio Kuratomi b95f483b8d Force BSDs to use umount/mount instead of trying to use remount. (#5715)
* Force BSDs to use umount/mount instead of trying to use remount.

Fixes #5591

* Initialize out and err
9 years ago
Brian Coca da9adccb02 systemctl show rc changes across versions
to avoid different errors across versions, ignore rc in favor of
found/notfound

fixes #5710
9 years ago
Jiri Tyr b264f8c1cd Fall back if mountinfo reading failed (fixing #5603) 9 years ago
Matt Clay 82e74668a6 Support script interpreters in async_wrapper. (#5703) 9 years ago
Andrea Tartaglia 48d47a57d5 ported iterkeys to py3 syntax (#5657)
* ported iterkeys to py3 syntax

Addresses ansible/ansible#18507

* Use ansible.module_utils.six.moves iterkeys instead of dict.keys()

* Removed 'iterkeys'
9 years ago
Sam Doran c0c26f83a8 Examples syntax batch7 (#5624)
* Change example syntax on nxos_feature module

* Change example syntax on nxos_hsrp module

* Change example syntax on nxos_igmp module

* Change example syntax on nxos_interface module

* Change example syntax on nxos_interface_ospf module

* Change example syntax on nxos_ip_interface module

* Change example syntax on nxos_ping module

* Change example syntax on nxos_switchport module

* Change example syntax on nxos_vlan module

* Change example syntax on nxos_vrf module

* Change example syntax on nxos_vrf_interface module

* Change example syntax on nxos_vrrp module

* Change example syntax on meta module

* Change example syntax on set_fact module

* Change example syntax on win_copy module

* Change example syntax on win_file module

* Change example syntax on win_get_url module

Remove escaping of \ characeter in Windows paths since it's no longer required for single quoted or unquoted values when using multi-line YAML syntax.

* Change example syntax on win_lineinfile module

* Change example syntax on win_msi module

* Change example syntax on win_stat module

* Remove nxos_bgp example from nxos_igmp module

* Mark examples as regexp to avoid syntax error

* Cleanup win_copy.py examples

* Cleanup win_file.py examples

* Remove quotes in win_get_url.py examples

* Cleanup quotes and languare in win_lineinfile.py

* Cleanup examples in win_group.py

* Cleanup examples in win_service.py

* Don't use : in documentation because it breaks the YAML syntax check

* Cleanup win_copy.py examples

* Cleanup win_copy.py examples

* Minor change to fix test failure

* Use single quotes
9 years ago
Sam Doran bf184b1a92 vyos_command Document ANSIBLE_VYOS_TERMINAL_LENGTH (#5676)
* Update documentation for vyos_command

Add information on new environment variable added in #18546.
Add note on command that should not be run via Ansible.

* White space changes

Two spaces after period.
9 years ago
Kevin Kirsche 1fe0bd33f3 Remove set from junos_facts as it errors out (#5670)
Fix #5636 per @ganeshnalawade
9 years ago
Ganesh Nalawade d39ae36ab1 Fix 5646 junos_config issue if config format is text (#5658)
If 'src_format' is not mentioned in playbook
and config is in text format a list object is
passed to 'guess_format' function instead
of string, hence TypeError execption is seen.
Fix is to pass string object instead of list.
9 years ago
Brian Coca 2ba5967673 fix yaml format, clarify docs 9 years ago
Brian Coca b278fafec8 updated desc 9 years ago
Orion Poplawski ade7b47f28 Be able to find all contents of a directory (#3711) 9 years ago
tedder 78f8ef267c update formatted lines to use named identifiers 9 years ago
Dag Wieers c22e383836 Ensure proper error when fetch_url returns status -1
When using a file:// or ftp:// URL the normal provisions that a non-200 status code means error have been disabled.
But the common error status -1 from fetch_url is not properly returning an error message.
This fix ensures that if the status code returns -1, we return a proper error message.

This fixes #3563
9 years ago
Rob Cutmore 6a3969ca6b Git: indicate if remote url was changed or not (#5677) 9 years ago
jctanner 10f0d3ca95 Set b_src to abspath of b_path so that symlinks work again. (#5678)
Fixes #5653
9 years ago
John R Barker b1c6b9272f win_msi - Don't list choices twice (#5684)
* win_msi - Dont list choices twise

http://docs.ansible.com/ansible/win_msi_module.html shows

Choices:
True
True
False
False

As the yes/no are expanded to true/false by the docs generation

* Update win_msi.py
9 years ago
Toshio Kuratomi ef3699e277 Fix for call to umount() in remount() 9 years ago
Brian Coca 1d8be78963 try remount but fallback to unmount + mount (#2445)
* allow mount to try remount

falls back to unmount/mount

* fixed fstab handling and switched to ismount

custom function deals with bind mounts unlike built in

* un ** args

* last ** args
9 years ago
tedder c77f7af765 add .format indexes for 2.6 compatability
Fixes #5551; the "".format() style needs to have `{0}` instead of the implied `{}` version for compatability with 2.6.
9 years ago
zaiusdr 74b32d9ec0 Fix wait_for Module to handle socket response as string in Python3
In Python3 socket module returns responses as bytes type. So it's
necessary to convert it to string for the module work correctly.
9 years ago
Kevin Kirsche 4e95ee036e Update pull request template to provide context
This updates the pull request template to provide more context about why specific things may be needed. This helps to make it feel like it is being asked for to help the team rather than arbitrary questions that don't seem applicable, such as command output for a docs change.
9 years ago
Matt Davis 13a9b98565 Prevent handle inheritance from blocking Windows async_wrapper (#5666) 9 years ago
Brian Coca 44c07d7ca8 Several systemd fixes
Allow some operations on missing services
Better sysv handling
Rearranged error reporting
fixed load error catching and order logic
also minor doc/comment updates
added warnings
9 years ago
Peter Sprygada 7079fe41be Revert "ios_mods - added stdout to exception output. Removed to_lines()" (#5663) 9 years ago
Monty Taylor 509846e6d6 Add a few lines about testing (#5662) 9 years ago
Toshio Kuratomi 52698596bc Clarify the comment 9 years ago
Toshio Kuratomi 91d98bb1a6 Older versions of rhn-client-tools don't understand containment tests. 9 years ago
Dag Wieers 54fdff16db Performance improvement using in-operator on dicts
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
9 years ago
Dag Wieers c843eeabc2 Performance improvement using in-operator for hash lookups
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .has_key()
http://stackoverflow.com/questions/1323410/has-key-or-in
9 years ago
David Wittman 85f6c26dff Add 'link' file_type to find_module
- Adds the 'link' file_type for finding symbolic or hard links
 - Use `os.lstat` instead of `os.stat` to prevent the following
   of links when statting the file.
9 years ago
Sam Doran 895179929c Examples syntax batch6 (#5623)
* Change example syntax on os_auth module

* Change example syntax on os_client_config module

* Change example syntax on os_image_facts module

* Change example syntax on os_networks_facts module

* Change example syntax on os_nova_flavor module

* Change example syntax on os_object module

* Change example syntax on os_server module

* Change example syntax on os_subnet_facts module

* Change example syntax on rax_files module

* Change example syntax on rax_files_objects module

* Change example syntax on mysql_db module

* Change example syntax on file module

* Change example syntax on uri module

* Change example syntax on cl_bond module

* Change example syntax on cl_bridge module

* Change example syntax on cl_img_install module

* Change example syntax on cl_interface module

* Change example syntax on cl_license module

* Change example syntax on cl_ports module

* Remove trailing colon
9 years ago
Jesse Keating 4c3f8cbd92 Do not require password when deleting os_user (#5601)
I broke backwards compat with the addition to define when a password
should be updated. It was requiring that a password value be passed when
deleting a user, which seems silly.

This moves the argument logic out of the argument spec and into when it
would be needed, when state is present.
9 years ago
Luc Charpentier be7af0193d error in docker_container example (#5631) 9 years ago
Abdul Anshad A 480c364afd fixes issue #5517 (#5519) 9 years ago
Sam Doran 38c0769abb Examples syntax batch5 (#5622)
* Change example syntax on supervisorctl module

* Change example syntax or _ec2_ami_search module

* Change example syntax on cloudformation module

* Change example syntax on ec2 module

* Change example syntax on ec2_facts module

* Change example syntax on ec2_eip module

* Change example syntax on rds module

* Change example syntax on route53 module

* Change example syntax on s3 module

* Change example syntax on digital_ocean module

* Change example syntax on docker_service module

* Change example syntax on cloudformation module

* Change example syntax on gc_storage module

* Change example syntax on gce module

* Change example syntax on gce_mig module

* Change example syntax on _glance_image module

* Change example syntax on _keystone_user module

* Change example syntax on _nova_keypair module

* Change example syntax on _quantum_floating module

* Change example syntax on _quantum_floating_ip_associate module

* Change example syntax on _quantum_network module

* Change example syntax on _quantum_router module

* Change example syntax on _quantum_router_gateway module

* Change example syntax on _quantum_router_interface module

* Change example syntax on _quantum_subnet module

* SQUASH _quantum_subnet

* Add missing quotes
9 years ago
Sam Doran b56a9852ee Examples syntax batch4 (#5620)
* Change example syntax on authorized_key module

* Change example syntax on cron module

* Change example syntax on group module

* Change example syntax on hostname module

* Change example syntax on seboolean module

* Change example syntax on selinux module

* Change example syntax on service module

* Change example syntax on sysctl module

* Change example syntax on systemd module

* Change example syntax on user module

* Change example syntax on debug module

* Change example syntax on fail module

* Change example syntax on include module

* Change example syntax on include_role module

* Change example syntax on include_vars module

* Change example syntax on pause module

* Change example syntax on wait_for module

* Change example syntax on apache2_module module

* > Change example syntax on django_manage module

* Change example syntax on htpasswd module
9 years ago
Sam Doran ad6999e2eb Change example syntax on subversion module 9 years ago
Sam Doran 8a1caba407 Change example syntax on hg module 9 years ago
Sam Doran 1c801ac574 Change example syntax on git module 9 years ago
Sam Doran 2bb5ab9776 Change example syntax on pip module 9 years ago
Sam Doran d42f73f5e9 Change example syntax on gem module 9 years ago
Sam Doran 8a1bd4178a Change example syntax on easy_install module 9 years ago
Sam Doran 4c93d3edf0 Change example syntax on yum module 9 years ago
Sam Doran ea3c8ee406 Change example syntax on rpm_key module 9 years ago
Sam Doran 66c92d5623 Change example syntax on rhn_register module 9 years ago
Sam Doran 25af0652b9 Change example syntax on rhn_subscription module 9 years ago
Sam Doran 3208cf5abf Change example syntax on redhat_subscription module 9 years ago
Sam Doran 6c16ab6ca8 Change example syntax on package module 9 years ago
Sam Doran ca12f5acac Change example syntax on apt_rpm module 9 years ago
Sam Doran e4978ea98d Change example syntax on apt_repository module 9 years ago
Sam Doran b2ffded3a7 Change example syntax on apt_key module 9 years ago
Sam Doran f8ce66cbde Change example syntax on apt module 9 years ago
Sam Doran c773539359 Change example syntax on group_by module 9 years ago
Sam Doran a97964a22d Change example syntax on add_host module 9 years ago
Sam Doran 385d34a3d7 Change example syntax on xattr module 9 years ago
Sam Doran c5921612d1 Change example syntax on unarchive module 9 years ago
Rezart Qelibari d7e9fbe631 Update system/group.py module.
Add ability to add system groups with next free system gid (< 500) on macOS.
9 years ago
John R Barker 5945b19ad3 double quotes for consistency 9 years ago
John R Barker 1d00dd80f1 Need to quote if there is a `:` 9 years ago
Ben Tomasik 0de338824a Set suspend_processes version_added to 2.3 9 years ago
Ben Tomasik f2af5b8664 Add support for suspending scaling processes Ref: http://docs.aws.amazon.com/autoscaling/latest/userguide/as-suspend-resume-processes.html 9 years ago
Sam Doran f71134cb98 Change example syntax on template module 9 years ago
Sam Doran a1b945a23e > Change example syntax on synchronize module 9 years ago
Sam Doran 065749ee2a Change example syntax on stat module 9 years ago
Sam Doran d3e7d4f469 Change example syntax on replace module 9 years ago
Sam Doran 25f6f36a92 Change examples syntax on lineinfile module 9 years ago
Sam Doran 1923666b22 Change examples syntax on ini_file module 9 years ago
Sam Doran ba76df1af1 Change examples syntax on find module 9 years ago
Sam Doran 0c46813871 Change examples syntax on file module 9 years ago
Sam Doran 6ea87c583b Change examples syntax on fetch module 9 years ago
Sam Doran 532c77849a Change examples syntax on copy module 9 years ago
Sam Doran 8f097580ec Change examples syntax on assemble module 9 years ago
Sam Doran c694fe6ca4 Change examples syntax on acl module 9 years ago
Sam Doran 6d06f80097 Change examples syntax on postgresql_user module 9 years ago
Sam Doran 13c827a31c Change examples syntax on postgresql_privs module 9 years ago
Sam Doran 8edd2673b2 > Change examples syntax on postgresql_db module 9 years ago
Sam Doran e0cfe14901 Change examples syntax on mysql_variables module 9 years ago
Sam Doran db723af8aa Change examples syntax on mysql_user module 9 years ago
Sam Doran 119a767cd2 Change examples syntax on mysql_db module 9 years ago
Sam Doran 079bf05ec3 Change examples syntax on shell module 9 years ago
Sam Doran 60a92eadd7 Change examples syntax on script module 9 years ago
Brian Coca 847cc0a1ec Revert "stat: doc: add version for new returns" 9 years ago
Brian Coca 50c9a276d7 added file flags/attributes to stat (#5358)
depends on http://github.com/ansible/ansible/issue/18213
also documented return version of fields added in 2.2
added get_mime to keep consistency
changed default mime behaviour
9 years ago
Gyorgy Szombathelyi 33ef72b584 Ini_file: fix regression with the create option
The new create option with the default value 'no' changes the
behavior from the previous Ansible releases. Change the default to
'yes' to create missing ini files by default.

Fixes: #5488
9 years ago
René Moser c8da9b012b stat: doc: add version for new returns (#5594) 9 years ago
Fabio Alessandro Locati 2cacc3e787 Use native YAML (#5571) 9 years ago
einarc 22df46d168 Avoid `TypeError` when desired_capacity is not provided to `ec2_asg` module (#5501)
Moving the "check if min_size/max_size/desired_capacity..." code to execute BEFORE the desired_capacity code is used in the following operation:
num_new_inst_needed = desired_capacity - len(new_instances)

Otherwise the following exception occurs when desired_capacity is not specified and you're replacing instances:
    num_new_inst_needed = desired_capacity - len(new_instances)
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'

Stack Trace:

An exception occurred during task execution. The full traceback is:
Traceback (most recent call last):
  File "/var/lib/awx/.ansible/tmp/ansible-tmp-1478229985.74-62334493713074/ec2_asg", line 3044, in <module>
    main()
  File "/var/lib/awx/.ansible/tmp/ansible-tmp-1478229985.74-62334493713074/ec2_asg", line 3038, in main
    replace_changed, asg_properties=replace(connection, module)
  File "/var/lib/awx/.ansible/tmp/ansible-tmp-1478229985.74-62334493713074/ec2_asg", line 2778, in replace
    num_new_inst_needed = desired_capacity - len(new_instances)
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'

fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2_asg"}, "module_stderr": "Traceback (most recent call last):\n  File \"/var/lib/awx/.ansible/tmp/ansible-tmp-1478229985.74-62334493713074/ec2_asg\", line 3044, in <module>\n    main()\n  File \"/var/lib/awx/.ansible/tmp/ansible-tmp-1478229985.74-62334493713074/ec2_asg\", line 3038, in main\n    replace_changed, asg_properties=replace(connection, module)\n  File \"/var/lib/awx/.ansible/tmp/ansible-tmp-1478229985.74-62334493713074/ec2_asg\", line 2778, in replace\n    num_new_inst_needed = desired_capacity - len(new_instances)\nTypeError: unsupported operand type(s) for -: 'NoneType' and 'int'\n", "module_stdout": "", "msg": "MODULE FAILURE", "parsed": false}
	to retry, use: --limit @
9 years ago
Patrick F. Marques dc4cff7350 Remove duplicated option from examples 9 years ago
Zaius Dr d8c21b153d Improve `ec2` module Python3 Support (#5497)
Imported six module from ansible module_utils for backwards compatibility.
9 years ago
Lars Van Casteren 0a435058a5 Docs update for `os_security_group` (#5531)
The example used equal characters and not colon characters.
9 years ago
Andrew Gaffney 2ef59561ba Fix bare variable references in docs (#5554) 9 years ago
Ryan Brown e45e25c257 Fix `cloudformation` error when stack-rollback fails (#5550)
In cases where a CFN stack could not complete (due to lack of
permissions or similar) but also failed to roll back, the gathering of
stack resources would fail because successfully deleted items in the
rollback would no longer have a `PhysicalResourceId` property.

This PR fixes that by soft-failing when there's no physical ID
associated to a resource.
9 years ago
Ryan S. Brown bf9077bfad Fix doc examples for `ec2_elb_lb` module
The examples had the listeners as a list item for each param, when they
really need to be their own objects.
9 years ago
Ryan S. Brown 5dd9372ff8 Fail gracefully in `ec2_asg` module when there are no matching launch configurations 9 years ago
jctanner 06e1141106 replace type() with isinstance() (#5541)
Replace all use of type() with isintance()

Addresses https://github.com/ansible/ansible/issues/18310
9 years ago
Ryan S. Brown 2744fde7c9 Fix link in `cloudformation` module docs 9 years ago
Sean Summers 59b11be65d added requires for botocore with RoleARN support
Added a requires for the minimum botocore version required to support RoleARN
9 years ago
Sean Summers 67934ac7db add role_arn to support Service Role
Add `role_arn` to support [AWS CloudFormation Service Role](http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-iam-servicerole.html)
9 years ago
jctanner 019acfa9b0 Correct the handling of state=latest for yum groups. (#4141)
* Correct the handling up state=latest for yum groups.
* Use yum-deprecated when available

Fixes #4119
9 years ago
Jason Cormie 9baca6ef3d Addition of InstanceUUID to facts (#4424)
The Instance UUID(refered to as PersistenceUUID in the API) is a the ID
vcenter uses to idenify VMs.
My use case for this is that I configure Zabbix using ansible and its
vmware module relies on using these to identify VMs.
9 years ago
Yair Fried 7eeb3445a4 Expose internal_network in os_floating_ip (#5510)
* Expose internal_network in os_floating_ip

Shade project has finally exposed this argument so now this module
matches old quantum_floatingip module's capabilities.

Use "nat_destination" term instead of "internal_network" to match shade
terminology.

* Add (private|internal)_network aliases to os_floating_ip

* Fix typo in os_floating_ip
9 years ago
mrLarbi 3bee788b72 ios_config : Set multiline_delimiter version to 2.3 (#5525) 9 years ago
Peter Sprygada 7d374689ad roll up of more fixes for ios_config multiline banners (#5524)
* now works for any banner in the config
* provides a configurable delimiter

link #5318
9 years ago
bdowling ddd13bf53a ios_mods - added stdout to exception output. Removed to_lines() (#5428)
stdout lines are now available when certain exceptions occur
(Ref ansible/ansible#18241)

Also noticed that to_lines was essentially handled in
lib/ansible/plugins/action/__init__.py -- only difference was
it didn't handle a list.  to_lines() could be removed across
network modules now, but this commit is only for ios_command.

Also adds disconnect() to ios_command that was added
to ios_config in #5247
9 years ago
Michael Scherer 6806965bda Add no_log on password argument
Also do not use a wildcard import, for later refactoring
9 years ago
mickael-ange 23eba8fd97 Added aws and ec2 extends_documentation_fragment to cloud/amazon/rds module. (#3951) 9 years ago
Abel Boldú 6077028560 Add uplink provider type (#5282) 9 years ago
Michael Herold e5cc4a45d3 Removes outdated "requirement" and outdated "note" (#5332)
- 7f59773460 no longer uses `ConfigParser`
- 1d4c0abe29 removed the `import` statement
9 years ago
Eduard Iskandarov 8ec5757789 Fixes: #4516 add placement_group argument for ec2_asg module 9 years ago
René Moser 447842c524 apt: fix changed when cache updated but not pkg (#5487) 9 years ago
Matt Martz 08ce50c2b3 If fetch_url failed to download the URL fail early with a proper error message. Fixes #5474 (#5476) 9 years ago
Michael Scherer 352d280058 Make service work when the service is not present in rc.conf
After installing a package from the ports collection on a
fresh FreeBSD 11.0, Ansible was unable to enable it, failing with
"unable to get current rcvar value". Debugging showed that sysrc
didn't see the variable from /usr/local/etc/rc.d/myservice, but
adding the value was working.

So we will just fallback to the default value if we can't find it.
9 years ago
Tom Melendez b85bcb71c3 Support for named_ports in Managed Instance Groups. A libcloud guard has been implemented, as this feature will only be available in libcloud >= 1.3, or by using trunk. (#5167) 9 years ago
Jesse Keating 0ec56bb563 Add update_password argument to os_user (#5219)
There is a desire to not have this module always result in a change if a
password argument is supplied. The OpenStack API does not return a
password back when we get a user, so we've been assuming that if a
password argument was supplied, we should attempt to change the password
(even if nothing else is changing), and that results in a "changed"
state. Now we will only send along a password change attempt if the user
wants one (the default to match history).

Fixes #5217
9 years ago
Peter Sprygada f8bcf55289 fixes problem when trying load banner into ios device (#5494)
this fix will now handle loading a multiline banner on ios based
devices without hanging.  It separates the processing of banners
from the remainder of the config

link #5318
9 years ago
jctanner 1ccd4ae8b0 Re-add version_added to include_vars (#5493) 9 years ago
Peter Sprygada 8b70d17f61 ios_facts module will no longer error on missing command (#5491)
The module will error if it tries to use a cli command that is not available
on a given platform.  This fix will address that problem.  If the cli
command is not available, then the command is silently discarded and the
facts that the command output is based on is not returned.  Any failed
commands are provided in the module return under the failed_commands
key.  This fix also updates the Examples docstring to make it consistent
with other ios_* modules

fixes #5444
fixes #5372
9 years ago
Matt Robinson df70a58d72 apt_repository: Relax PPA checks and add basename (#5432)
Allow installation of PPA repositories on non-Ubuntu Debian derived
distribution targets (e.g. neon, Mint, Debian itself) by removing the
specific check for UbuntuDistribution before allowing PPA: format
sources. This fixes the addition of PPA repositories under KDE neon (as
the codenames match the base Ubuntu distribution).

To make the functionality also useful under Mint and Debian which have
different codenames to their Ubuntu upstream / downstream releases, add
a 'codename' option to override the default used in the PPA source
entry.
9 years ago
Matt Clay be48ea4389 Simplify compileall checks. Remove py3 skip list. 9 years ago
Chris Becker fabb63c43f Add more specific language to module description and examples
* Add 'on the remote server' to `file` parameter description
* Add example showing how to use the `file` parameter, with specific
  language about the file's location being on the 'remote server'
9 years ago
zuiurs eeecc3adcc fix the behavior that the dest is directory
This fixes the behavior that the dest is directory,
when we set the "force: no" argument.
To be join the dest and the src's basename,
before checking the "force" argument.
9 years ago
Ricardo Carrillo Cruz 33d7745794 Add rebuild support to os_server_actions (#4289)
Fixes #2714
9 years ago
Allen Sanabria c9960c00dc Updated documentation for PR http://github.com/ansible/ansible/pull/17207 9 years ago
Brian Coca 00fbd98f97 dont join when group is none 9 years ago
John R Barker 2a9e5687eb Correct typos in docs strings (#5233) 9 years ago
Jamie Dyer 4ac3b0c5d5 Make the RDS endpoint available if AWS returns it. Fixes #3865 (#4143) 9 years ago
jctanner 60dd2f1fff apt: update cache until corrupt package lists are fixed (#5448)
* apt: If the cache object fails to lost due to a corrupt file, try to update the cache until it is fixed.
* Append -q to the update parameters
* Remove unused variable
* Use a string that doesn't rely on internationalization
* Use py24 exception style
* Use get_exception

Fixes #2951
9 years ago
Brian Coca ba6bc5382d corrected version added 9 years ago
Brian Coca 20f2fe4e91 added logout to docker_login
also cleaned up 'actions' and minor doc issues
9 years ago
Brian Coca 9e931f89fb added ability to control sleep between attempts
the default was 1s but it makes sense to make this configurable
9 years ago
Brian Coca 97b23c0fb7 docit 9 years ago
Brian Coca 52332f5b78 allow groups to be passed as YAML list as well
keeps backwards copat with 'comma delimited string'
fixes #5163
9 years ago
Evan Kaufman 5d3e64b0d2 Identify existing unmanaged jobs by exact match, when no header comment is found
* updated `find_job` method to find by exact match of job, when no matching header comment is found
  * note this fallback injects a header comment for later calls to `update_job` or `remove_job`
* abstracted header comment building to `do_comment` method

Fixes #3256
9 years ago
Brian Coca 47ffb6d542 minor updates to include docs 9 years ago
Brian Coca d36bea766d make sure all svcadm operations are syncronous
fixes #5296
9 years ago
Toshio Kuratomi 0d74ae3368 Need to locate a pip inside a venv when venv is specified
Alternative to #5359

Fixes #5347
9 years ago
Matt Clay 24615e10e3 Removed tests migrated to ansible/ansible repo. (#5452) 9 years ago
Matt Davis 2c216cdf35 fix JSON junk in win_file state=directory case (#5427) 9 years ago
Charles Paul f6676f4957 add id: back to documentation 9 years ago
bencomp d25ba6a30a Make find return sample a YAML dict
In the description of the find module return value, the sample dict
has its key=value strings converted to key=value: None in the
web documentation. This commit updates the sample output to a 'real'
dict.

Minor additional edit in the description: "return list *of* files".
9 years ago
Matt Davis 8e97539e20 fix win_shell/win_command deadlock on large interleaved stdout/stderr (#5384)
fixes #5229
9 years ago
Fahri Cihan Demirci 1ecb63f0e0 Fix String Type for Python 3 Branch Comparison
* Use the `to_native` conversion method to convert a command output to the
  appropriate form when looking for branch names in the command output,
  therefore avoiding a `TypeError` in Python 3.
9 years ago
Hiroaki Nakamura c2d37f1db9 hostname: add support for alpine linux (#4837)
* Add update_current_and_permanent_hostname to the hostname module

* Add support for Alpine Linux to the hostname module
9 years ago
Evan Kaufman 42079bcc59 Exposed backup file path, simplified result args (#5364)
Fixes #245
9 years ago
Toshio Kuratomi 38b3c43c68 Fix uri for change in case in response
In python3, response fields are title cased whereas in python2 they were
not.  We return these fields to the module's caller so we need to
normalize all of them to be lower case.

This reverts the lowercase check from 454f741ef5
as that one was only targetted as a single field.
9 years ago
Matt Davis dfc2a29bdb fix win async tempdir deletion failure 9 years ago
Matt Davis 73f77e2af6 switch win async to use Win32 CreateProcess
should fix flaky async startup behavior where watchdog/module exec starts and immediately dies
9 years ago
Toshio Kuratomi bd9e790cfe First set of fixes for uri module to work with py3.
This fix handles changes in the response headers (no longer all
lowercased) and switches from unicode() to to_text().
9 years ago
Jonathan Mainguy 51313e6da8 update maintainer 9 years ago
Timothy Appnel 5a17277bd3 clarifies synchronize module on use of --delayed-updates 9 years ago
Evan Kaufman f8dad7130d Record existing cron file as string property, rather than only recording termination
This seems less hackish, and feels more proper for diff generation
9 years ago
Evan Kaufman f64990df02 Rendering of crontab should reflect actual newline termination, in diff mode 9 years ago
Evan Kaufman b416015634 Ensure trailing newline is written to cron file
Records whether existing cron file (or CRONCMD output) has a terminating newline, and ensures a trailing newline is written as necessary EVEN IF NO CHANGE WAS MADE to the target env/job

Fixes #2316
9 years ago
Evgenii Terechkov da71acf1bf Replace dangerous shell calls with module.run_command 9 years ago
Evgenii Terechkov 8fd4785062 Ensure that we use shell
to run apt-get -y install ... >/dev/null

this commit must fix #2839
9 years ago
Rowan Wookey 914e205eb3 Added work around for Ubuntu Xenial calling php7_module php7.0 9 years ago
Luca Berruti 2bbbf58156 ini_file: return more infos on changes. 9 years ago
Luca Berruti 6d8b140f46 ini_file: diff support. 9 years ago
Luca Berruti 73401182c1 ini_file: add create= option. 9 years ago
Luca Berruti 1a22dde1ac ini_file: fixes #1788, fails --check when file doesn't exist. 9 years ago
Brian Coca fccaf883da refactor stat
make format function 'format only'
added platform dependant info, when it is available
avoid rechecking same info
added comments to each info gathering section

(cherry picked from commit a79acf73d7eb79b76d808ff8a1d6c505dfd9ec82)
9 years ago
Toshio Kuratomi e2fce828f6 Order of return values was reversed 9 years ago
Toshio Kuratomi 9aac87e08c Fix builddep when a source package exists without a binary package
builddep only requires a source package to be in the repos but our code
was checking for a binary package before running buiddep.  Reversing the
order makes it work correctly.

Fixes #4519
9 years ago
Toshio Kuratomi b8279e7447 Only change to short IDs for delete (#5353)
* Only change to short IDs for delete

If the user specifies long IDs, use them for all commands except for
deleting a key.  Need to use short IDs there because of an upstream
apt_key bug.  Fixed in apt_key 1.10 (fix is present in Ubuntu 16.04 but
not Ubuntu 14.0 or some Debians).

Fixes #5237

* Check that apt-key really erased the key

When erasing a key, apt-key does not understand how to process subkeys.
This update explicitly checks that the key_id is no longer present and
throws an error if it is.  It also hints at subkeys being a possible
problem in the error message and the documentation.

Fixes #5119

* Fix apt_key check mode with long ids

apt-key can be given a key id longer than 16 chars to more accurately
define what key to download.  However, we can use a maximum of 16
chars to verify whether a key is installed or not.  So we need to use
different lengths for the id depending on what we're doing with it.

Fixes #2622

Also:

* Some style cleanups
* Use get_bin_path to find the path to apt-key and then use that when
  invoking apt-key
* Return a nice user error message if the key was not found on the
  keyserver
* Make file and keyring parameters type='path' so envars and tilde are
  expanded
9 years ago
Charles Zaffery 4c830400f8 Remove line when 'state: absent' with 'option:' instead of commenting 9 years ago
Adrian Likins 29978344ea Make authorized_key preserve key order (#5339)
* Make authorized_key preserve key order

Track the ordering of keys in the original file (rank)
and try to preserve it when writing out updates.

Fixes #4780
9 years ago
Toshio Kuratomi e7fcfa981e Remove the yaml dep from the git module 9 years ago
Toshio Kuratomi fad760dc7a Fix git for py3
Comparing to the output of run_command() needs to use native strings

Also fix imports: We were relying on them coming from the import of
basic.  A few (like yaml) weren't imported at all.
9 years ago
Robin Roth 5446e6639f Fix git failure for use of depth with version (#5135)
* Fixes #5108
* before module fails with "fatal: A branch named 'STABLE' already
  exists." when depth is used on a fresh clone with a non-HEAD branch
9 years ago
René Moser 3dda38a90f doc: add_host: add example without deprecated vars (#5323)
ansible_ssh_* are deprecated since 2.0
9 years ago
John Baublitz 352b620665 GCE: Add support for 'number' parameter for manually provisioned Google Compute clusters (#4276)
* Add option for number parameter to generate manually provisioned clusters from a base name

* Refactor code to work with starting and stopped when number is specified

* Update docs

* Fix documentation error breaking Travis

* Fixes for async gce operations

* Fix documentation

* base_name from parameter to alias for name and fixes for renaming variables

* Fix breaking change on gce.py

* Fix bugs with name parameter

* Fix comments for Github build checks

* Add logic to set changed appropriately for cluster provisioning
9 years ago
Toshio Kuratomi ff6bac126e On Ubuntu16, virtualenv always tries to use python2 even when python2 is not installed.
Workaround that by mimicing the upstream virtualenv behaviour in code
(use the python version that was used to invoke virtualenv/the ansible
module)
9 years ago
Toshio Kuratomi 9bbe71154c Fix authorized_key module to preserve the order of options
The last fix allowing multiple definitions of the same option key (for
permitopen support) introduced a set() which removed the guaranteed
ordering of the options.

This change restores ordering.  The change is larger than simply
removing the set because we do need to handle the non-dict semantics
around keys not being unique in the data structure.  The new code make
use of __setitem__() and items() to do its work.  Trying to use
getitem() or keys() should be looked upon with suspicion as neither of
those follow dictionary semantics and it is quite possible the coder
doesn't realize this.  The next time we need to touch or enhance the
keydict code it should probably be rewritten to not pretend to extend
the dictionary interface.
9 years ago
Matthew Jones 107a473dd8 Add separate checkout and update parameters (#5306)
* Add separate checkout and update parameters

This brings the svn module in line with the git module for controlling
individual update and checkout functionality based on whether the
directory exists or not.

It also allows specifying `no` for both to pull the remote revision
without performing a checkout

* Update version-added for new parameters
9 years ago
Matthew Jones 97bf5b84e3 Add separate clone parameter (#5307)
* Add separate clone parameter

This brings the hg module in line with the git module for controlling
individual update and checkout functionality based on whether the
directory exists or not.

It also allows specifying `no` for both to pull the remote revision
without performing a checkout

* Reflect the right added ver for the hg clone arg
9 years ago
Ryan S. Brown 422ec08649 Remove unused YAML import from cloudformation 9 years ago
Ryan Brown dfd57942f9 Support native YAML in CloudFormation module (#5327)
Support the new native YAML format in the CloudFormation API. This means
the existing `template_format` parameter is deprecated. This commit also
adds a warning for the deprecated parameter.
9 years ago
John R Barker 96f9992884 Typo in cleanup (#5322) 9 years ago
Filip Hubík 9a2d8337f2 Fix incorrect line wrapping in output from yum check-updates
https://github.com/ansible/ansible-modules-core/issues/4318#issuecomment-251416661
9 years ago
John R Barker 7a3d93b9f6 Run validate-modules from ansible/ansible@devel (#5257)
* Run validate-modules from devel

Use a clean dir for checkout

typo

Correct path

validate-modules requires mock and voluptuous==0.8.8

typo

Ensure script is running

Remove testing debug

Install Ansible only once

Install ansible and validate_modules requirements

Now that we no longer pip install Ansible we need to manually install
it's dependencies

Debug

Dependencies are listed in ansible/ansible

debug

submodules

typo

typo

working

* Matt's feedback

* Use mktemp to checkout and delete directory after running

* Single quotes
9 years ago
Daniel Andrei Minca ca36d232d5 fix unclear documentation for docker container
the docker container module's `exposed_ports` was slightly ambigous.

Use the official Docker documentation to define what an `exposed port`
is.

Resolves: ansible/ansible-modules-core#5303
Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
9 years ago
Michael Scherer ed590257a3 Fix code for python 3
Since dict.keys return a dictkeys under python 3, we hav to cast it
to a list to avoid traceback:

    Traceback (most recent call last):
      File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 496, in <module>
        main()
      File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 490, in main
        results = enforce_state(module, module.params)
      File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 410, in enforce_state
        parsed_new_key = parsekey(module, new_key)
      File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 308, in parsekey
        options = parseoptions(module, options)
      File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 259, in parseoptions
        options_dict[key] = value
      File "/tmp/ansible_sh16ejbd/ansible_module_authorized_key.py", line 164, in __setitem__
        self.itemlist.append(key)
    AttributeError: 'dict_keys' object has no attribute 'append'

Yet another fix for https://github.com/ansible/ansible/pull/18053
9 years ago
Michael Scherer e6b3c0d88a cleanup import for htpassword module
In order to ease future refactoring, we should avoid importing
'*' from ansible.module_utils.basic.
9 years ago
Michael Scherer 2c078dcb97 Cleanup import for authorized_key
Do not import '*', to ease future refactoring and cleanup of
module_utils.
9 years ago
Ryan S. Brown 08b119df33 Fix cloudformation module return parameter documentation
Always return stack outputs, even if only an empty dict
9 years ago
tedder d01bfa6a72 Cloudformation module fix unintentional changed=true
- Don't rewrite the result; this is causing 'changed=true' on update
- Move AWSRetry import to top since it's a decorator, and is needed at definition-time
9 years ago
tedder 763399830d Boto3 rewrite of cloudformation module
- removed star-imports, which wasn't possible in Ansible 1.x
- boto doesn't have any of the modern features (most notably, changesets), so this rewrite goes all-in on boto3.
- tags are updateable, at least in boto3. Fix documentation.
- staying with "ansible yaml to json conversion" because I'm trying to keep this scoped properly. The next PR will have AWS-native yaml support.
- documented the output. Tried to leave it backwards-compatible but the changes to 'events' might break someone's flow. However, the existing data wasn't terribly useful so I don't assume it will hurt.
- split up the code into functions. This should make unit testing possible.
- added forward-facing code: 'six' for iterating, started using AWSRetry, common tag conversion.
- add todo list
- Pass `exception` parameter to fail_json
9 years ago
Michael Scherer 3f43879db8 Cleanup imports of xattr
Since the module use re and os, we need to import them.
And rather than importing '*', we should limit to the
only object/function needed, so we can more easily refactor
later.
9 years ago
Dag Wieers 858d02ac4c Ensure yum failures in with-loop result into a failed task
The implementation is fairly simple, we force the rc= parameter to not be zero so that the check in _executor/task_result.py_ correctly determines that it failed. Without this change Ansible would report the task to be ok (despite failed=True and msg=Some_error_message) although Ansible stops and the summary output reports a failed task.

This fixes #4214, #4384 and also relates to ansible/ansible#12070, ansible/ansible#16006, ansible/ansible##16597, ansible/ansible#17208 and ansible/ansible#17252
9 years ago
Jamie Evans 606ac78a20 verify both tags and commits (#2654)
This fixes a bug where the module fails to verify tags.  I added a conditional statement in `verify_commit_sign()` that checks if `version` argument is a tag, if so, use `git verify-tag` instead.
9 years ago
Brian Coca 720574ef77 added allow_duplicates to include_role docs 9 years ago
Michael Scherer 9ecd220683 Make the code run on python 3
Test suite block on:

    Traceback (most recent call last):
      File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 496, in <module>
        main()
      File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 490, in main
        results = enforce_state(module, module.params)
      File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 410, in enforce_state
        parsed_new_key = parsekey(module, new_key)
      File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 308, in parsekey
        options = parseoptions(module, options)
      File "/tmp/ansible_fhootp1e/ansible_module_authorized_key.py", line 253, in parseoptions
        if options_dict.has_key(key):
    AttributeError: 'keydict' object has no attribute 'has_key'

With keydict being a subclass of dict.
9 years ago
John R Barker 8fe269f836 Group "apt-get update" and "apt-get install" (#5283)
* Group "apt-get update" and "apt-get install"

Should speed up sanity

* Run apt-get install in quiet mode
9 years ago
Michael Scherer 9e3058c323 Make pip module use pip3 on python 3 9 years ago
Michael Scherer f9478c7618 Make subversion module work on python 3
In python 3, filter return a iterator and so result in this traceback:

    Traceback (most recent call last):
      File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 264, in <module>
        main()
      File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 243, in main
        local_mods = svn.has_local_mods()
      File \"/tmp/ansible_kzu72kz5/ansible_module_subversion.py\", line 178, in has_local_mods
        return len(filter(regex.match, lines)) > 0
    TypeError: object of type 'filter' has no len()
9 years ago
Michael Scherer c9da5e98a9 Remove the wide try/expect clause
This doesn't catch anything precise, and none of the methods should
throw a expection for anything. This also hide python 3 errors.
9 years ago
Ryan S. Brown adc56e52d8 Fix `fail_json` invocation in `cloudformation` module 9 years ago
Steven de Vries 054fe53b43 Move job parameter to meet expected requirements (#5151)
closes #5273
9 years ago
Ricardo Carrillo Cruz 10d662ea1b Refactor domain/project handling on os_user module (#5212)
The keys returned by user objects for default domain and
default project are respectively default_domain_id and
default_project_id.
We need to gather those IDs in case the user passed names, so we
can then compare with the user object on the needs_update helper
function.
9 years ago
Alfredo Solano 88d7f0c692 apt: doc: use yaml syntax in examples (#5070) 9 years ago
Michael Scherer a567942405 Fix unarchive on python3
Since handler.files_in_archive is a list of files coming from
various executables output, that's a bytes list, and we use it
with dest who is a str. So we need to convert that to native
type.
9 years ago
Michael Scherer 7a0ef069fa Convert name to bytes to compare it to bools
On python 3, bools is a list of bytes:

    >>> rc,bools = selinux.security_get_boolean_names()
    >>> 'virt_use_nfs' in bools
    False
    >>> bools
    [b'abrt_anon_write', b'abrt_handle_event', ...]
9 years ago
Davis Phillips 37008e1da1 vsphere_guest: Set extra config and powerstate after template deploy (#4266)
* Fixes #1381
* Fixes #2971
* Fixes #3056
9 years ago
Michael Scherer 5e1dfa9485 Do not leak the password in log (#5189) 9 years ago
Michael Scherer 18b0920311 Do not leak the vtp_password in log (#5199) 9 years ago
Michael Scherer 3b2b33bf29 Do not leak the subversion password in log (#5200) 9 years ago
Michael Scherer 996ccca82f Do not leak various passwords in log (#5202) 9 years ago
Michael Scherer 8b7898e4ab Do not leak the password in log (#5203) 9 years ago
Michael Scherer 180977a727 Do not leak api_key or root password in log (#5201) 9 years ago
Peter Sprygada 2127459794 fixes bug introduced in 3670215 in junos_config (#5251)
The previous fix created a new bug that this PR resolves
9 years ago
John R Barker 25b6492d37 Bulk spelling improvement to modules-core (#5225)
* Correct spelling mistakes

* Correct more spelling issues

* merge conflict

* Revert typo in parms
9 years ago
Tom Melendez a4077537e0 Added libcloud guard for Managed Instance Groups. (#4911) 9 years ago
Tom Melendez 72635db94d GCE module examples update. Correct syntax, demonstrate other options and creation of multiple instances. (#5192) 9 years ago
Peter Sprygada 810040be05 fixes issue with collecting all filesystems in ios (#5248)
earlier versions of ios do not provide the all-filesystems argument.  This
fix will now only report on the flash filesystem for ios_facts

fixes #4712
9 years ago
Peter Sprygada f106ff9e77 ios_config will now explicitly disconnect from remote host (#5247)
The ios_config module will now explicitly send a disconnect to the
remote host at the conclusion of the module run

ref #5181
9 years ago
amitsi 522ed054f7 Update pn_vlan (#5223)
removed name from an older file which got left out
9 years ago
Peter Sprygada 43e6206559 removes automated backup of ios to flash due to errors (#5245)
The feature is extremely unstable right now and decision to pull
it out for 2.2.  Workaround is to do the same in the playbook
9 years ago
Peter Sprygada 25d00838a9 fixes issue with pushing config to versions that do not support sessions (#5236)
earlier versions of eos do not support configuration sessions.  this change
will now check if sessions are supported and if not will fallback to
not using config sessions

fixes #4909
9 years ago
John Barker bca8bbe7c2 Correct functional typos 9 years ago
Peter Sprygada 4dc09e19ea fixes bug with junos_config module not properly loading config (#5213)
This fixes two issues.  First, it fixes an issue with the junos_config
module not properly recognizing a file with set commands.  The second
bug would cause the diff_config() function to raise an exception due
to a blank line when splitting the config
9 years ago
Nathaniel Case 5a8ebf5953 nxos module cleanup (#5065)
* Fix imports on nxos_bgp* modules

* Fix imports on nxos_evpn* modules

* Cleanup issues for nxos_facts

* Shuffle imports for nxos_template

* Fix imports on nxos_ospf* modules

* Fix nxos_hsrp

As get_hsrp_groups_in_devices is not actually called anywhere, I presume this
change is reasonable.

* Fix imports on nxos_interface* modules

* Update nxos_static_route imports

* update nxos_vrf

* Update nxos_config imports
9 years ago
jjshoe 706bdbf284 Catch the rare condition where ami creation failed, this is critical when you have a 10-15 minute wait on ami creation. This rarely happens, and is tough to reproduce, but it does happen. (#5106) 9 years ago
Peter Sprygada 3fbae6f10f updates docstring for sros modules (#5197) 9 years ago
adejongh a89992f70f Fixed incorrect usage of user_data variable (#5194) 9 years ago
Bill Nottingham 765269e547 Fix deprecation notices. (#5180) 9 years ago
Elena Washington 91e433594a Make is so that the params param truly isn't required (fix for #3860) 9 years ago
Toshio Kuratomi 0fe99f20d9 Emit an error message if six is not installed.
dopy 0.3.7 makes use of six but doesn't list it as a requirement.  This
means that people installing with pip won't get six installed, leading
to errors.  Upstream released dopy-0.3.7a to address that but pip thinks
that is an alpha release.  pip does not install alpha releases by
default so users aren't helped by that.

This change makes ansible emit a good error message in this case.

Fixes #4613
9 years ago
Toshio Kuratomi 064c381608 Fix exception hierarchy for digital ocean and some cleanups of pep8 style
Fixes #4613
9 years ago
Chris Houseknecht 8e9befa5ba Surface Compose stdout on failure
Signed-off-by: Chris Houseknecht <chouseknecht@ansible.com>
9 years ago
Chris Houseknecht 63b6672ea5 Improved enumeration of actions 9 years ago
Chris Houseknecht 1e4b8c13a3 Improved build and pull error handling 9 years ago
Gabriele f8d2be407d Fixing docstring (#5130) 9 years ago
Peter Sprygada 56120433c9 checks commit comment to make sure it doesn't exceed 60 characters (#5155)
The comment argument can be at most 60 characters per the IOS XR command
line.  If a comment is > 60 characters, the module will now gracefully error
and return a well formed message.

fixes 5146
9 years ago
John R Barker efca39d4d4 Remove reference to parents parameter which doesn't exist (#5143) 9 years ago
John R Barker d12f2d2c72 Remove docs for commit which no longer exists (#5152) 9 years ago
Laurent Godet 336c9f9f35 Fix daemon_reload in systemd module 9 years ago
Toshio Kuratomi 283205d7b3 We've changed run_command to return native_strings
on python3, this means that we don't get bytes back by default.  We
probably do want bytes here so modify our call to run_command so we get
bytes instead of text.
9 years ago
Ryan Brown b091d39baf Handle termination_protection parameter when restarting instances (#5076)
* Restart EC2 instances with multiple network interfaces

A previous bug, #3234, caused instances with multiple ENI's to fail when being
started or stopped because sourceDestCheck is a per-interface attribute, but we
use the boto global access to it (which only works when there's a single ENI).

This patch handles a variant of that bug that only surfaced when restarting an
instance, and catches the same type of exception.

* Default termination_protection to None instead of False

AWS defaults the value of termination_protection to False, so we don't
need to explicitly send `False` when the user hasn't specified a
termination protection level. Before this patch, the below pair of tasks
would:

1. Create an instance (enabling termination_protection)
2. Restart that instance (disabling termination_protection)

Now, the default None value would prevent the restart task from
disabling termination_protection.

```
- name: make an EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    instance_type: t2.micro
    termination_protection: yes
    exact_count: 1
    count_tag:
       Name: TestInstance
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
- name: restart a protected EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    state: restarted
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
```
9 years ago
John R Barker 3333035ef4 Add matching quotes (#5133)
Will fix broken syntax highlighting
9 years ago
Matt Davis e2f66abe73 fixed windows setup to run in check_mode 9 years ago
Toshio Kuratomi 007b5f4c32 Fix assemble module for python3 9 years ago
Peter Sprygada 9c664f424e adds exception handling for adding an invalid condition (#5125)
This change will now handle a problem adding a condition that raises
an AddConditionError and return a well formed error to the user.
9 years ago
Pradeep b405931e8b Typo Fix 9 years ago
Gabriele b4565b6667 Adding more details on DOCSTRING about how to use the module (#5121) 9 years ago
Peter Sprygada 9707ae6490 adds exception handling for AddConditionError (#5124)
AddConditionErrors are now handled by nxos_command and a well formed error
is returned from the module
9 years ago
Peter Sprygada f5e72c6590 adds check for AddConditionError when adding conditional statements (#5123)
The Conditional instance will now raise the AddConditionError and this
change instructs eos_command to catch the error and return a nicely formed
error message
9 years ago
Matt Davis 48b0cb750c (re)add post-watchdog-launch sleep to Windows async_wrapper (#5122)
fixed apparent race where subprocess appears to never start
9 years ago
Gabriele d4c2a13325 Improving nxos_igmp_snooping (#5011) 9 years ago
Gabriele 3c257688bc Fixing nxos_igmp_interface (#5010) 9 years ago
Gabriele b6c07bc9e9 Fixing nxos_hsrp (#5009)
* Fixing nxos_hsrp

* Adding space after =
9 years ago
Senthil Kumar Ganesan 21ae84a04e Remove the dellosX_template module (#5110) 9 years ago
Matt Davis c07a2b49b6 add JSON junk filter to async_wrapper (#5107) 9 years ago
Peter Sprygada d58462949f roll up of unicode fixes in junos modules (#5113)
* fixes junos_template (fixes #3962)
* fixes junos_config
9 years ago
Gabriele 62bf8d0c78 Add ethernet-link-oam mapping to nxos_feature (#4956)
* Add ethernet-link-oam mapping

* Adding port-secutiry mapping

* Fixing command output format
9 years ago
Gabriele 67d6f2c0d6 Fixing nxos_vlan (#5005)
* Fixing nxos_vlan

* Fixing docstring

* Fixing docstring
9 years ago
Gabriele 43632951fe Fixing nxos_aaa_server (#5002)
* Fixing command output formatting

* Fixing cmds
9 years ago
Gabriele 7f861fb9ce Fixing nxos_acl (#5006)
* Fixing nxos_acl

* Fixing nxos_acl
9 years ago
Gabriele 272b20000f Fixing nxos_acl_interface (#5007) 9 years ago
Gabriele 75c4051933 Fixing nxos_interface (#5012) 9 years ago
Gabriele 1be7ca4f70 Fxing nxos_ip_interface (#5013) 9 years ago
Gabriele 6708874f1c Fixing nxos_mtu (#5014) 9 years ago
Gabriele 6934f11e1f Fixing nxos_ntp (#5015) 9 years ago
Gabriele 6201a57d83 Fixing nxos_ntp_auth (#5016) 9 years ago
Gabriele c50324fb08 Fixing nxos_ntp_options (#5017) 9 years ago
Gabriele 4b6ee73f8c Fixing nxos_pim_interface (#5018) 9 years ago
Gabriele 5b96fb1dac Fixing nxos_portchannel (#5019) 9 years ago
Gabriele ebb39a0151 Fixing nxos_smu (#5021) 9 years ago
Gabriele cda65cad18 Fixing nxos_snmp_community (#5022) 9 years ago
Gabriele f74275fc1d Fixing nxos_snmp_contact (#5023) 9 years ago
Gabriele 73d66e28ab Fixing nxos_snmp_host (#5024) 9 years ago
Gabriele 7c7eee94b2 Fixing nxos_snmp_location (#5025) 9 years ago
Gabriele 19769903e6 Fixing nxos_snmp_traps (#5026) 9 years ago
Gabriele bf59e458b1 Fixing nxos_snmp_user (#5027) 9 years ago
Gabriele 04e62346d1 Fixing nxos_udld_interface (#5030) 9 years ago
Gabriele 6bedeb28d8 Fixing nxos_switchport (#5028) 9 years ago
Gabriele 773f1703b7 Fixing nxos_udld (#5029) 9 years ago
Gabriele d61950d48c Fixing nxos_vpc_interface (#5032) 9 years ago
Gabriele 51c37e9f58 Fixing nxos_vrf (#5033) 9 years ago
Gabriele 8f331e01ca Fixing nxos_vpc (#5031) 9 years ago
Gabriele 9ff6070eb8 Fixing nxos_vrf_interface (#5034) 9 years ago
Gabriele e7286ed43c Fixing nxos_vtp_domain (#5036) 9 years ago
Gabriele c19e3b5924 Fixing nxos_vrrp (#5035) 9 years ago
Gabriele f89cb1717c Fixing nxos_vtp_password (#5037) 9 years ago
Gabriele b897b497c1 Fixing nxos_vtp_version (#5038) 9 years ago
Matt Davis 66a1b15f89 remove broken ansible_user_uid fact from Windows setup 9 years ago
Ryan Brown 135b92bf4e Check status of finished spot instance requests (#4990)
Per #3877, the code to wait for spot instance requests to finish would
hang for the full wait time if any spot request failed for any reason.
This commit introduces status checks for spot requests, so if the
request fails, finishes, or is cancelled the task will fail/succeed
accordingly.

One edge case introduced here is tha if a user terminates the instance
associated with the request manually it won't fail the play, under the
presumption that the user *wants* the instance terminated.
9 years ago
Brian Coca 22d29be478 1st draft of include docs 9 years ago
Toshio Kuratomi 132fcc434b Set some hosts privileged so they can perform mount tests (#5087) 9 years ago
Jiri Tyr 2b145a0052 Fixing bind mount pattern in the mount module (#5084) 9 years ago
Peter Sprygada 58a5ec6c51 fixes junos_command module paring of wait_for strings (#5083)
The junos_command module wasn't properly parsing strings to apply
conditionals due to the return value not being converted to json
before the results where handed to the runner.
9 years ago
Peter Sprygada 9ed01d0cfd fixes junos_template ignoring the action directive (#5080)
This updates the junos_template to properly process the action
directive when loading the configuration.
9 years ago
Toshio Kuratomi 9436d013d4 Fix mount default options -- should be defaults, not default 9 years ago
John R Barker 177dcadbc0 deprecated _template network modules: Rename in modules-core (#5072) 9 years ago
Jiri Tyr be1036f461 Ultimate fix of the mount module for Linux (#5055) 9 years ago
John R Barker f7b10720ac typo in module name (#5062) 9 years ago
Kevin Carter e2e7f20e34 apt: fix cache time handling (#1517)
This change is in response to issue #1497 where the apt module would not properly updating the apt cache in some situations and never returned a state change on cache update when the module was used without or without an item to be installed or upgraded.

The change simply allows the apt module to update the cache when update_cache option is used without or without a set cache_valid_time.
If cache_valid_time is set and the on disk mtime for apt cache is ">" the provided amount of seconds, which now has a default of 0, the apt cache will be updated. Additionally if no upgrade, package, or deb is installed or changed but the apt cache is updated the module will return a changed state which will help users to know that the state of the environment has changed due to a task operation, even if it was only an apt cache update.

fixes #1497

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
9 years ago
Peter Sprygada 0a85e64b4a fixes exception raised due to KeyError (#5068)
The vyos_config module would error when looking for a key called `updates`
in module.params.  There is no such key.  This fixes the problem.
9 years ago
Peter Sprygada 73cf85d677 catches exception if conditional cannot be parsed (#5067)
If the conditional cannot be parsed, the module will now catch the exception
and return a well formed failed message.

fixes #5060
9 years ago
Peter Sprygada da4c11241f fixes error when 'delete ...' config command is specified but doesn't exist (#5064)
The junos_config module will generate an exception if a 'delete ...' config
command is attempted to be loaded into a device configuration.  This change
will first check to see if the delete command is valid and filter it out
of the change set if it is not valid.

fixes #5040
9 years ago
Nathaniel Case aa82f48dc8 Network module code cleanup (#5061)
* Fix imports in junos_template

* Python 3 compatibility in eos_command

* Python 3 compatibility for ios_command

* Clean up issues with ios_facts

* Python 3 compatibility for ios_facts

* Import shuffle in ios_template

* Python 3 compatibility for iosxr_command

* Clean up iosxr_facts.py

* Python 3 compatibility for iosxr_facts

* Python 3 compatibility for junos_command

* Python 3 compatibility for ops_command

* Cleanup issues with ops_facts

* Python 3 compatibility for ops_facts

* Cleanup issues with ops_template

* Python 3 compatibility for vyos_command

* Cleanup issues with vyos_facts

* Python 3 compatibility for vyos_facts
9 years ago
Nathaniel Case 6ae0342a0a Fix imports in junos_template (#5059) 9 years ago
David Shrewsbury d0f7af4b09 Fix os_network's create_network() call for older shade versions (#5058)
A value for the project_id parameter to shade's create_network()
call was always being sent, even if no value for 'project' was
supplied. This was breaking folks with older versions of shade
(< 1.6).

Fixes PR https://github.com/ansible/ansible-modules-core/issues/3567
9 years ago
Matt Clay 25d829c8f2 Detect tar type (bsd, gnu) and only use gnu tar. (#4352)
* Detect tar type (bsd, gnu) and only use gnu tar.

* Revert return code checking for TgzArchive.
9 years ago
Nathaniel Case 9b286b1775 eos_facts cleanup (#5057)
* dict.iteritems does not exist in Python 3

Now just dict.items
six.iteritems handles the change

* Addresses point 1

Unsure if this is a good idea or not.

* Addresses point 2

This shouldn't have any particular change, just marks load_comments as abstract

* Remove unused import

Addresses point 3

* Clarify invalid subset error message

Addresses point 4
9 years ago
Chris Houseknecht 0e4b470ee2 Let docker-py handle decoding and JSON parsing of stream data. Fixes #4930. 9 years ago
Chris Houseknecht 9432adfaf7 Put requested devices in correct format to enable config comparison. Fixes #5000. 9 years ago
Peter Sprygada 0ef16b44ca fixes exception being raised when show configuration command issued (#5047)
The junos_command expects commands to be returned as xml by default but
`show configuration [options]` will return text not xml.  This fix
will set the output format for any command that starts with `show
configuration` to text

fixes #4628
9 years ago
Peter Sprygada a5b32fa0d1 fixes return passing output from command through jxmlease in junos_command (#5044)
The return string from the commands was not being passed through the
jxmlease library and therefore being returned as a string instead of a
json data structure.  This also adds back the missing xml key in the
return that includes the raw xml string.

fixes #5001
9 years ago
Aditya Marella c3f815a6f6 Docker module: add support for OomScoreAdj
* docker-py param name oom_score_adj
* translates to OomScoreAdj in the docker remote API
* setting version_added to "2.2"
9 years ago
shaung bcbeed244b Fix #4504 Respect timeout option when starting/stopping/restarting containers. 9 years ago
Denis Tiago c0c5b9a50a fix health instances count when we have more than one lb in asg 9 years ago
Jiri Tyr 5a9f5918d3 Fixing bind mount on Linux (#1942) (#4439)
* Fixing bind mount on Linux

* Fixing broken implementation
9 years ago
Andrew Gaffney 460b0e1ab6 Match existing INI file entry with leading whitespace (fixes #4997) (#4998) 9 years ago
Senthil Kumar Ganesan 4504f2d8c7 Update minimum required version and ssh rate limit (#4995) 9 years ago
Matt Clay efaed0b68d Revert "Set PRIVILEGED=true for Linux integration tests. (#4993)"
This reverts commit fb779bf30c.
9 years ago
Matt Clay 2b33d55442 Set PRIVILEGED=true for Linux integration tests. (#4993)
This should allow test_mount tests to run on Shippable.
9 years ago
Matt Clay 1854337eb1 Fix handling of ansible-doc errors. (#4992) 9 years ago
Toshio Kuratomi 08874e4bf6 Fix #3153 again (#4989) 9 years ago
Peter Sprygada 654a38897f fixes exception raised when nxos_facts uses nxapi transport (#4988)
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.

fixes ansible/ansible#17691
9 years ago
Toshio Kuratomi 27759ee58f Working subset of mount fixes (#4987)
* Fixing bind mount on Linux

* The latest update from jtyr doesn't pass integration tests.

Manually select the changes that are necessary to fix the bug with
unmounting
9 years ago
Peter Sprygada df6b7703bb fixes default value in docstring for http (#4985)
The docstring incorrectly stated the default value for http is yes when
indeed its no.  This fixes the docstring
9 years ago
Peter Sprygada 88b2c7e1f6 fixes bug where setting state=absent in nxos_nxapi is not idempotent (#4984)
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device.  This will
fix that problem.

This also updates the docstring to correctly reflect https as default=no

fixes #4955
depends on ansible/ansible#17728
9 years ago
John R Barker f63e5d078e Force is not a 2.2 feature
9b5e6bbfa1 incorrectly chopped some text around
9 years ago
Matt Clay da8538698b Add shellcheck to sanity checks. (#4976)
Also disable deprecation warnings during module validation.
9 years ago
Trond Hindenes 0da88d4744 win_feature_docs_update (#4421) 9 years ago
Timothy Appnel 6647e8c271 Fixes grammatical error in assert module example (#4972) 9 years ago
Ryan S. Brown 93737f819a Accept JSON type as the content of policy_json parameter on `iam_policy` module 9 years ago
Søren Kröger 61144f4da9 Added single_transaction and quick to db_dump (#3687)
It was missing before, ...
9 years ago
JesseEmond 6ddbc63b1d Unarchive stop passing file mode to tar command (#4179)
Fixes #4063.

Tar does not use this parameter on extraction (-x) or diff (-d)(the
only two cases where it is passed in unarchive). It only uses it on
creation:
https://www.gnu.org/software/tar/manual/html_section/tar_33.html

Providing `unarchive` with a file mode of `0755` (octal) makes it pass
the argument `--mode 493` (493 = 0755 in decimal) to `tar`, which then
fails while verifying it (because it contains an invalid octal char
'9'). Not passing the parameter to tar solves the issue.
9 years ago
Marius Gedminas 9509224768 postgresql_db: fix inverted 'changed' logic when state=absent (#4934)
Fixes #4933.
9 years ago
David Shrewsbury 56211bd7ed Correct reuse_fips param to reuse_ips (#4939)
This new parameter was incorrectly named. Fixing to match the expected
name in the shade library.
9 years ago
Toshio Kuratomi 77975c232b Fix pip freeze workaround with virtualenv (#4951) 9 years ago
Matt Clay d1ef5f947e Remove script previously used by Travis. 9 years ago
Toshio Kuratomi a8fbdcd80d pip list isn't available on pip less than 1.3 so make a fallback (#4947) 9 years ago
Timothy Appnel b18c22f69b Adds docs for msg param in assert modules plus some other clean up (#4926) 9 years ago
Peter Sprygada b06123e986 fixes junos_config to be idempotent when confirming a commit (#4946)
The junos_config module would always return true when confirming a commit
This changes the module to now check first making the feature idempontent
9 years ago
René Moser cb9ec9f802 iam_cert: remove choice list for dup_ok type bool (#4940)
See 8879931f0c
9 years ago
Toshio Kuratomi e2963c0e25 Fix parsing of pip output 9 years ago
Toopy 74be5a40f9 Fix git get_diff TypeError when fetch (#4881) 9 years ago
Lars Engels 8010b7f980 Add support for password aging on Solaris (#4372)
* Add support for password aging on Solaris

* Fix shadow file editing when {MIN,MAX,WARN}WEEKS is not set in /etc/default/passwd

* Un-break with python3

* _Really_ un-break with python3
9 years ago
Chris Houseknecht f33828e753 Cast scale value to int. Fixes #4592. 9 years ago
Rob Cutmore 15b41d2718 Pip: use 'pip list' when available for package list (#4644)
* Pip: handle parsing different pip commands

* Pip: use 'pip list' when available

* Pip: explicitly check which command is used

* Pip: add error checking when fetching packages
9 years ago
Chris Houseknecht b01af0d747 Make project start and stop error handling more resilient, and improve message text. 9 years ago
indispeq ecb05b03d4 Fix openstack security group rule vrrp choice apostrophe error (#4750)
Fixes #4444 that was erroneously closed and thought fixed
9 years ago
Peter Sprygada 868c298968 fixes import statements in junos_package module (#4929)
This fixes the import statement to import NetworkModule from network instead
of from junos
9 years ago
Peter Sprygada 3e577f6312 fix up junos_facts import statements (#4928)
This fixes the junos_facts import statements and removes importing
NetworkModule from the junos shared module.
9 years ago
Peter Sprygada b9cb9d6345 fix import in junos_command module (#4927)
This fixes the import statements in the junos_command module to be
consistent with all junos_* modules
9 years ago
Peter Sprygada 82cf70e0f3 roll up of bug fixes for junos_config module (#4925)
* fixed docstring referencing old arguments
* changed out lxml for xml library to avoid import errors
* fixed issue when trying to confirm a commit will end up a NOOP
* fixed issue for passing replace argument to load_config method
9 years ago
Peter Sprygada 0acab8bd19 bug fixes in junos_netconf module (#4924)
* fixes exception thrown when sending commands to device
* fixes exception thrown when retrieving current resource instance
* fixes issue where netconf would be configured in some instances when state
  was set to absent
* now returns the command string sent to the remote device
* fixes argument name to be netconf_port with alias to listens_on
9 years ago
Josh Lothian 319b2b28cb Fix YAML syntax in NXOS documentation (#4922)
* Fix YAML syntax in NXOS documentation

Use ':' and not '=' to ensure valid YAML
in the EXAMPLES

* Correcting introduced syntax error
9 years ago
Will Thames 10af591da2 Check whether yum file or URL install is an upgrade (#4547)
Rather than just checking whether a package with the right
name is installed, use `local_nvra` to check whether the
version/release/arch differs too.

Remove `local_name` as it is a shortcut too far.

Fixes #3807
Fixes #4529
9 years ago
Matt Clay b2460746d8 Test module docs on Shippable. (#4921) 9 years ago
Matt Clay 6cdcf09984 Remove duplicate keys from module docs. (#4920) 9 years ago
GGabriele c47fd4b3e9 Add feature mappings 9 years ago
Peter Sprygada 25375f1057 adds exception handling to nxos_command for FailedConditionalError
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
9 years ago
Peter Sprygada a8ca526450 bug fix that now catches FailedConditionalError when specifying conditionals
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
9 years ago
Michael Scherer 90378e9168 Fix duplicate required key error
ansible-doc -vvvv -l show this warning:

   [WARNING]: While constructing a mapping from /home/misc/checkout/git/ansible/lib/ansible/modules/core/network/junos/junos_config.py,
   line 88, column 5, found a duplicate dict key (required). Using last defined value only.
9 years ago
Peter Sprygada 0c94d84910 eos_eapi module allows independent configuration of protocol and port
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905.  This changes the behavior to now allow
the port to be configured independently

fixes #4905
9 years ago
GGabriele 6701f038ba Fixed docstring 9 years ago
GGabriele 0eb63cdeaa Fixing nxos_portchannel 9 years ago
Harnek Sidhu 422edfcbd4 Created digital_ocean_block_storage module (#4469) 9 years ago
Senthil Kumar Ganesan 1ee897e988 Addressed review comments, given as part of other reviews (#4904) 9 years ago
nichivo c4f43eb965 Insert missing option line before blank lines (#4747) 9 years ago
Senthil Kumar Ganesan a7242039ad Updated the config module to use the new Parse method for OS6 9 years ago
Senthil Kumar Ganesan 8adc05051c Added support for template module for Dell OS6 devices 9 years ago
Senthil Kumar Ganesan 1a8e0487ff fixing the CI issue, the python interperter line 9 years ago
Senthil Kumar Ganesan 4fd0ad09b3 Updated the copyright 9 years ago
Senthil Kumar Ganesan 89cd8c03c0 Added support for dellos6_facts module 9 years ago
Senthil Kumar Ganesan 1c4efc8b2c dnos* -> dellos* (Rename module & updated copyright) (#4888)
* Renamed the Modules from dnos* -> dellos*, updated copyright, corrected doc issues

* Removed the unwanted module import
9 years ago
Matt Clay f6386a113b Update CI badge. 9 years ago
Matt Clay 62073612d4 Cosmetic fix to test PR and merge hooks. (#4893) 9 years ago
Matt Clay f1be653737 Run same tests on Shippable as on Travis. (#4889)
Run the same tests as used on Travis.
9 years ago
Peter Sprygada 989793483f fix up eos_eapi module
* fixes TypeError: load_config() got an unexpected keyword argument 'session'\n"
* removes qos argument

ref #4869
9 years ago
Matt Clay d75c2ea475 Fix documentation fragment references. (#4890) 9 years ago
Brian Maddy 7ca911d345 typo in stat.executable (was stat.excutable) (#4886)
I didn't actually run this because it's so simple, but it seems correct.
9 years ago
Tom Melendez ea76dedadf Support for GCE Managed Instance Groups. (#4541)
Create, Delete, Resize and Recreate (of instances) supported.  Autoscalers are also supported.
9 years ago
Ryan S. Brown 10e0ec84fb Fix version_added for ec2_asg feature 9 years ago
GGabriele 13e87e3a6c Adding nxos_igmp_snooping 9 years ago
GGabriele 15c07334c7 Adding nxos_aaa_server_host 9 years ago
GGabriele 4b6a59bd13 Adding nxos_udld_interface 9 years ago
GGabriele f1a96986c4 Adding 2.1 and 2.2 support to nxos_switchport 9 years ago
GGabriele e669d3e889 Adding nxos_snmp_user 9 years ago
GGabriele 693f8e623a Improving argument_spec 9 years ago
GGabriele 2f58306564 Adding nxos_pim_interface 9 years ago
GGabriele 48942d6e32 Fixing docstring 9 years ago
GGabriele b42f6da0ce Adding nxos_mtu 9 years ago
GGabriele d8b2b0387b Adding nxos_vtp_version 9 years ago
GGabriele da8aa0dd29 Removing unused function 9 years ago
GGabriele d53b52d528 Fixing module name 9 years ago
GGabriele d435aca86e Adding missing version_added 9 years ago
GGabriele bf2e0ec953 Adding nxos_vtp_domain 9 years ago
GGabriele b1f33ca5a0 Improved function 9 years ago
GGabriele d3de4c160f Adding nxos_vtp_password 9 years ago
GGabriele 29ea186bd7 Adding nxos_udld 9 years ago
GGabriele c45e596159 Adding nxos_ntp_options 9 years ago
GGabriele 77b043dcf3 Fixing conditional format 9 years ago
GGabriele 52dfa697c2 Adding nxos_ntp_auth 9 years ago
GGabriele 6efb79bbeb Adding nxos_aaa_server 9 years ago
GGabriele 821b1606b3 Fixing nxos_interface 9 years ago
GGabriele 095d30ea63 Adding nxos_ntp 9 years ago
GGabriele 5f0060ec41 Fixing argument_spec 9 years ago
GGabriele 57f86c0efc Fixing docstring format 9 years ago
GGabriele 76d7379d73 Adding nxos_snmp_traps 9 years ago
GGabriele 988d6bbb2b Fixing return string 9 years ago
GGabriele 37170dd353 Adding nxos_snmp_location 9 years ago
GGabriele 2c8bc37003 Adding RETURN 9 years ago
GGabriele de8b759df2 Adding nxos_install_os 9 years ago
GGabriele c5ab15443f Adding nxos_gir_profile_management 9 years ago
GGabriele c7ca3654df Adding nxos_gir 9 years ago
GGabriele 58501d3650 Removing indentations 9 years ago
GGabriele 852f5176a1 Removing indentation 9 years ago
GGabriele 4775c257ea Fixing file writing format 9 years ago
GGabriele 2016e5d44a Adding nxos_snapshot 9 years ago
GGabriele 1752082c00 Adding nxos_snmp_host 9 years ago
GGabriele 4a182888b8 Adding nxos_snmp_community 9 years ago
GGabriele 0c4c5467f7 Fixing docstring and more fix 9 years ago
GGabriele 346f83029b Fixing error handling 9 years ago
GGabriele e1fab98061 Fixed module structure 9 years ago
GGabriele 4cbcc1f91d Adding nxos_vxlan_vtep_vni 9 years ago
Shawn Siefkas cff256b057 Adding SNS notification support to ec2_asg module
Addresses #1844
9 years ago
Senthil Kumar Ganesan a757321872 Added support for facts module for Dell Networking OS10 device. (#4879)
* Added support for dnos10_facts module

* Added the missing quotes

* Addressed @privateip comments
9 years ago
Ryan Brown 6dff21bd42 Stop sorting of termination_policies in `ec2_asg` (#4883)
The AWS API requires that any termination policy list that includes
`Default` must end with Default. The attribute sorting caused any list
of attributes to be lexically sorted, so a list like
`["OldestLaunchConfiguration", "Default"]` would be changed to
`["Default", "OldestLaunchConfiguration"]` because default is earlier
alphabetically. This caused calls to fail with BotoServerError per #4069

This commit also adds proper tracebacks to all botoservererror fail_json
calls.

Closes #4069
9 years ago
amitsi 6a1290230b pn_bgp (New Module) (#4738)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block

* fix type for pn_multiprotocol
9 years ago
amitsi 31b3fbf3ba pn_cluster (New Module) (#4727)
*  made changes to make it 2.4 compatible

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi 92877a39b1 pn_ospfarea (New Module) (#4737)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi 5ad8cebef9 pn_trunk (New Module) (#4728)
* Cluster Module

* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi 700c220d6b pn_vlag (New Module) (#4731)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi cdbf08e10c pn_vlan (New Module) (#4732)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi 127a99de30 pn_vrouter (New Module) (#4733)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi e1b07d47be pn_vrouterif (New Module) (#4734)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi 23c171c21b pn_vrouterlbif (New Module) (#4735)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
9 years ago
amitsi f9082b2d8e pn_show (New Module) (#4739)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block and fix typo
9 years ago
amitsi d5d0949958 pn_ospf (New Module) (#4736)
* Add pn_ospf module

* remove type from the options block
9 years ago
Senthil Kumar Ganesan 4ecab1e094 Added support dnos9_facts module (#4873)
* Added support dnos9_facts module

* Addressed @gundalow review comments

* Removing the addtional command, which is already in the default
9 years ago
amitsi 8eaae151fc Empty Init Module as required (#4740)
Add network/netvisor/__init__.py
9 years ago
Tom Melendez 35acdec063 Document ability to disable external IP with 'none' setting. Closes #2562. (#4878) 9 years ago
Monty Taylor 7fe300bb29 Expose the reuse_fips flag on os_server (#4849)
* Expose the reuse_fips flag on os_server

* Remove useless line
9 years ago
mzizzi eaef333215 cloudformation stack events itertools.imap bugfix (#4868) 9 years ago
Senthil Kumar Ganesan 91cc160b43 dnos9_config (New Module) (#4816)
* Added support for dnos9_config module

* Addressed @gundalow comments
9 years ago
Senthil Kumar Ganesan 616af3506c dnos9_template (New Module) (#4819)
* Added support for dnos9_template module

* Addressed @gundalow comments
9 years ago
Senthil Kumar Ganesan 8f14b50b11 dnos6_config (New Module) (#4824)
* Added support for dnos6_config module

* Corrected the documention failure

* Addressed @gundalow comments
9 years ago
Matt Davis 6daa34e1c5 add win_shell/win_command modules + docs (#4827) 9 years ago
Riccardo Murri 6733d1c72c hostname: Support "Scientific Linux CERN" (#4855)
CERN maintains its own fork of "Scientific Linux",
which identifies as "Scientific Linux CERN SLC".
This commit lets Ansible know that this is again
another variant of RHEL.
9 years ago
Matt Clay 49692e98eb Fix python 3 issues with apt* modules. (#4848)
- Use range instead of xrange.
- Use python3-apt package for python 3.
- Eliminate unsupported for/else/raise usage.
- Use list on dict.items when modifying dict.
- Update requirements documentation.

Also made non-intrustive style fixes (adding blank lines).
9 years ago
Brian Coca 21ed52bfe4 fixed incorrect example 9 years ago
John Barker 264bb374b9 RETURNS doesn't support markup, so remove it 9 years ago
Peter Sprygada b1243feac8 rename arugment from default to defaults
This argument_spec incorrectly named an argument default and it should have
been defaults.  This corrects that issue
9 years ago
Peter Sprygada 4327e67a7e rename the argument default to defaults
The argument_spec incorrectly had the argument default and it should have
been defaults.  This corrects the problem.
9 years ago
John Barker 42d5d7b21b Docs improvements to _config 9 years ago
GGabriele e375b4c61c Fixing nxos_feature 9 years ago
Christopher Kotfila f916dae700 Unpack AWS reservations while waiting to terminate (#4012)
Previously calculation of the number of instances that have been
terminated assumed all instances were in the first reservation returned
by AWS.  If this is not the case the calculated number of instances
terminated never reaches the number of instances and the module always
times out. By unpacking the instances we get an accurate number and the
module correctly exits.
9 years ago
Ryan Brown 1a02005b8d Handle EC2 instances with multiple network interfaces (#4766)
Currently instances with multiple ENI's can't be started or stopped
because sourceDestCheck is a per-interface attribute, but we use the
boto global access to it (which only works when there's a single ENI).

This patch handles multiple ENI's and applies the sourcedestcheck across
all interfaces the same way.

Fixes #3234
9 years ago
Peter Sprygada 3a7301bb3b fixes error when calling load_config() with session keyword
The session keyword is no longer needed or supported in the load_config()
method for eos.  This fixes an issue in eos_template where the session
keyword was still being sent.
9 years ago
Toshio Kuratomi ae310d5034 Fix syntax 9 years ago
Senthil Kumar Ganesan fffd7ff44b Addressed review comments from @privateip 9 years ago
Robin Roth 2df69fb5d8 Speedup git module on clone and pull (#4562)
* remove redundant if submodules_updated

* speed up git by reducing remote commands

* run fetch only once
* run ls-remote less
  * don't run ls-remote if one would run fetch anyhow
* remove unnecessary remote_branch check in clone
  * kept if depth and version given

* fix fetch on old git versions
9 years ago
Brian Coca 627da622fe removed chdir / as it breaks tasks
fixes #17466
9 years ago
John Barker c01328b597 Document `backup` options
To make future diffing easier, use consistent ordering
9 years ago
Senthil Kumar Ganesan 9d32e313b7 Added Command module to support Dell Networking OS6 9 years ago
Senthil Kumar Ganesan 253cbc10a6 Added Command module to support Dell Networking OS9 9 years ago
Brian Coca 6030bcdb47 switched to use built in function for validation 9 years ago
Monty Taylor e27b7af1e6 Don't change to root dir in async_wrapper (#4779)
The daemonizing code here is taken from an ActiveState recipe, which
includes changing to / as a general best practice. While that is
normally true to allow for deleting the directory that the daemon
process started in, in this case it is not relevant as this is not
intended to be an actual long-running daemon.

Issue ansible/ansible#17466
9 years ago
Antonio Murdaca b9962d2389 system/systemd: enable systemctl --user (#4208)
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
9 years ago
glovenglaven 289e5f1884 Added Solaris support to core mount module (#4771)
* Added Solaris support to the mount module.

* Added checking so that if a non-standard fstab file is specified it will
still work in Solaris without breaking existing functionality.

* Added a check to avoid writing duplicate vfstab entries on Solaris

* Added "version_added" to new boot option
9 years ago
Dag Wieers 433dfd0c5b Don't add included files as arguments on the command line (#4626)
This means we will have to unarchive the complete archive if a single change is found.
Unfortunately we cannot fix this for `unzip`, the only hope is a pure-python reimplementation.

This fixes problems reported in the comments of #3810
9 years ago
Martin Matuška 3366a95765 Force download if checksums do not match (#4262) 9 years ago
Gregor Giesen b87ef7772f cron: replacement for os.getlogin() (#4777)
os.getlogin() returns the user logged in on the controlling terminal. However
'crontab' only looks for the login name of the process' real user id which
pwd.getpwuid(os.getuid())[0] does provide.

While in most cases there is no difference, the former might fail under certain
circumstances (e.g. a lxc container connected by attachment without login),
throwing the error 'OSError: [Errno 25] Inappropriate ioctl for device'.
9 years ago
nitzmahone 915b59a6d5 Fix win_user issue with disabled accounts/expired passwords
Disabled and password-expired accounts cannot call ValidatePassword successfully

fixed #4369
9 years ago
Peter Sprygada ad707c2724 roll up updates to nxos_config module
* remote 'updates' argument
* clean up functions
* update doc strings
* add required_if dependencies
9 years ago
Peter Sprygada b6748443c7 roll up updates to junos_config module
* remove 'update' argument
* update doc strings
* reorder functions
9 years ago
Peter Sprygada 47bd484b70 roll up updates to ops_config module
* 'before' and 'after' now only apply to 'lines' argument
* add required_if dependencies
* update doc strings
* remove 'update' argument
* clean up functions
9 years ago
Peter Sprygada 18957c4039 roll up updates to sros_config module
* update doc strings
* update message if rollback isn't configured
9 years ago
Peter Sprygada a9557bc12b roll up of updates to vyos_config module
* remove 'udpates' argument
* add required_if dependencies
* clean up functions
* update doc strings
9 years ago
Peter Sprygada 8444b1ed8f roll up of updates to iosxr_config module
* 'before' and 'after' arguments now only apply to 'lines'
* update doc strings
* remove update argument
* clean up warnings
9 years ago
Peter Sprygada 6a0b04d6a7 roll up of updates to ios_config module
* 'before' and 'after' are now only applied to 'lines'
* remove update argument
* update doc strings
* add path argument when performing config difference
9 years ago
Peter Sprygada e5c26150fb roll up of updates to eos_config module
* removes update argument
* adds `config` option to replace argument
* moves session management into shared module
* cleans up doc strings
* `before` and `after` args now only apply to lines
9 years ago
Andrew Gaffney bac0c4595c Fix missing colons in network module examples (#4778) 9 years ago
Peter Sprygada d73fbaaf05 add new module sros_rollback
Provides a configuration resource for managing the rollback feature on
remote devices running Nokia SROS
9 years ago
Chris Houseknecht e95f773d96 Set default log_driver to None to prevent config comparison when a log_driver is not specified. Fixes #4600. 9 years ago
Chris Houseknecht 05303a974d Purge networks using network name rather than ID. Fixes 4596. 9 years ago
Chris Houseknecht 890c2d04e2 Default restart_retries to None rather than 0. Fixes #4534. 9 years ago
Ryan Brown 6ae4e50e47 Fix failure when powering on/off EC2 instances by tag only. (#4767)
If you apply `wait=yes` and use `instance_tags` as your filter for
stopping/starting EC2 instances, this stack trace happens:

```
An exception occurred during task execution. The full traceback is:                                                                          │~
Traceback (most recent call last):                                                                                                           │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module>                                                            │~
    main()                                                                                                                                   │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main                                                                │~
    (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags)                  │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances                                                 │~
    if len(matched_instances) < len(instance_ids):                                                                                           │~
TypeError: object of type 'NoneType' has no len()                                                                                            │~
                                                                                                                                             │~
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~
ack (most recent call last):\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n    main()\n  File \"/tmp/│~
ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n    (changed, instance_dict_array, new_instance_ids) = startstop_instances│~
(module, ec2, instance_ids, state, instance_tags)\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~
nces\n    if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~
MODULE FAILURE", "parsed": false}
```

That's because the `instance_ids` variable is None if not supplied
in the task. That means the instances that result from the instance_tags
query aren't going to be included in the wait loop. To fix this, a list
needs to be kept of instances with matching tags and that list needs to
be added to `instance_ids` before the wait loop.
9 years ago
Dag Wieers 976d876e55 Ensure unicode characters in zip-compressed filenames work correctly (#4702)
* Ensure unicode characters in zip-compressed filenames work correctly

Another corner-case we are fixing hoping it doesn't break anything else.

This fixes:
- The correct encoding of unicode paths internally (so the filenames we scrape from the output and is returned by zipfile match)
- Disable LANG=C for the unzip command (because it breaks the unicode output, unlike on gtar)

* Fix for python3 and other suggestions from @abadger
9 years ago
Peter Sprygada 53bcf18eab minor updates to junos_package module for 2.2 (#4761)
* replaces get_module() with NetworkModule()
* removes old call to package_version()
9 years ago
Peter Sprygada 09b8e220ca update junos_facts module to remove get_module() factory function (#4760)
Replaces get_module() with NetworkModule instance
9 years ago
Peter Sprygada 290a4b5fac adds path kwarg when difference() is called from iosxr_config
Adds the path kwarg to handle use cases with exact and strict matching
9 years ago
Matt Clay e8f70f25df Python 3 fixes for apt_* modules. (#4754) 9 years ago
Peter Sprygada d339004437 minor bug fix to pass path to difference() in ios_config
The ios_config module needs to pass the path kwarg to difference when
specifying match=exact or strict.
9 years ago
afunix f2c324facc Updated get_url module to process FTP results correctly [#3661] (#4601) 9 years ago
Peter Sprygada 6cca2b06fe fixes bug where nxos_config wasn't handling checkpoints correctly 9 years ago
Abhijit Menon-Sen 841ceb808d Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741)
Before this, all spot instance requests would fail because the code
_always_ called module.fail_json when the parameter was set (which it
always was, because the module parameter's default was set to 'stop').

As the comment said, this parameter doesn't make sense for spot
instances at all, so the error message was also misleading.
9 years ago
Florian Dambrine 2adc325ef6 Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243) 9 years ago
Peter Sprygada d6e16ded3f fix bug in ios_template when include_defaults is set to true
Module was ignoring  include_defaults argument.  This fixes the issue
such that the correct configuration is returned
9 years ago
Peter Sprygada 8a87d7ff11 adds path kwarg when performing config diff checks in ios_config 9 years ago
mlewe afa9d30717 Fixes ansible/ansible#15922 (#3793) 9 years ago
Matt Ferrante d88f5f6808 Properly support tag updates on CloudFormation stack-update actions (#3638) 9 years ago
@skg_net eae69a154f dnos10_template module 9 years ago
David J Peacock 14fb0e4136 description expanded for 112, AKA VRRP protocol) (#4645)
* description expanded for 112, AKA VRRP protocol)

* corrected syntax for description for IP protocols
9 years ago
Brian Coca a42cb96b75 added backup_file to module returns (#4723)
fixes #14502
also cleaned up some unused stuff and fixed imports
9 years ago
Peter Sprygada bfdc5098cb minor bug fixes in eos_template
* fixes issue where configuration was not being loaded (#4704)
* fixes issue where defaults were not included when argument was set to True

tested on EOS 4.15.4F
9 years ago
Matt Davis 009ebf619b fix async_wrapper start suspended race (#4718)
Main thread in started-suspended process may not be immediately resumable on slow targets- poll for proper state for awhile before attempting resume
9 years ago
Matt Davis 6099e6d19e Windows async module support (#4710)
Powershell impls of async_wrapper, async_status- associated tests and async action changes are in https://github.com/ansible/ansible/pull/17400.
9 years ago
Brian Coca 909e62b25b updated include_role docs 9 years ago
Dag Wieers 5995097e61 Support DOS file attributes (e.g. archive-bit or hidden-bit) (#4705)
This fixes #4554
9 years ago
GGabriele bc7b093089 Removed newline 9 years ago
GGabriele dfa9904599 Added missing fullstop 9 years ago
Peter Sprygada db49e1e436 fixes issue where the configobjs are not deserialized to a list
When the configuration is compared and the results deserialized, the
dumps() function returns a string.  This cohereces the return to a list
in case before and/or after needs to be applied

fixes 4707
9 years ago
GGabriele 87b839e1f8 Adding missing fullstop 9 years ago
GGabriele d2d1b18ef4 Fixed param value format in docstring 9 years ago
GGabriele 745b504aa1 Fixed module structure and added one new param 9 years ago
GGabriele a71b84853c Fixed config function 9 years ago
GGabriele f577f46ccf fix imports 9 years ago
Peter Sprygada 8eab599ade removes state argument from ops_config module
this removes the state argument from ops_config.  The state argument should
not have been there
9 years ago
Peter Sprygada c071273fbf removes argument from vyos_config module
The state argument should not be in vyos_config.  This commit removes the
state argument
9 years ago
Peter Sprygada 807974f515 updates nxos_config to remove state argument
The state argument should not be in the nxos_config module.  This change
removes the state argument for this release
9 years ago
Peter Sprygada c38a90a2e9 removes state argument from ios_config
The state argument should not be in ios_config.  This change removes the
state argument
9 years ago
Peter Sprygada 51613d4307 roll up of minor fixes in eos_config module
* fixes save argument to be type bool
* now properly sets the changed returned flag based on diff
* updates docstring RETURNS to add backup_path
* removes unneeded state argument

tested on EOS 4.15.4F
9 years ago
GGabriele 7010a66638 Removed tabs 9 years ago
Peter Sprygada 7a234fc7cc update junos_netconf module
Updates the junos_netconf module with changes to load the
NetworkModule instead of the get_module factory method.  This
update is part of the 2.2 refactor of network modules
9 years ago
Peter Sprygada f5e62a0611 update junos_template module
This updates the junos_template module implementing the changes for
Ansible 2.2
9 years ago
GGabriele 174ffde2e9 Adding nxos_igmp_interface 9 years ago
GGabriele 93d816a183 Adding nxos_igmp 9 years ago
Matt Clay 1f6e3326db Python 3 fixes for async_wrapper and async_status. (#4671) 9 years ago
GGabriele 693fc690d7 nxos_vrf_interface support for 2.1 and 2.2 9 years ago
Peter Sprygada 213c8e5a81 update junos_config module
* adds src argument to load configuration from disk
* adds src_format to set the source file format
* adds update argument with choices merge or replace
* deprecates the replace argument in favor of update=replace
9 years ago
GGabriele 0303c813c8 Updating nxos_vrf 9 years ago
GGabriele 7560c6dac2 nxos_vlan support 2.1 and 2.2 9 years ago
Matt Clay cb30558a41 Make async_wrapper ignore '_' as an argsfile. (#4678)
This provides support for passing additional positional parameters to async_wrapper.
Additional parameters will be used by the upcoming async support for Windows.
9 years ago
GGabriele 7391b5ba63 nxos_ping support for 2.1 and 2.2 9 years ago
GGabriele 85e65a7873 nxos_ip_interface support for 2.1 and 2.2 9 years ago
GGabriele 631ee66ed9 Adding nxos_reboot 9 years ago
GGabriele 6d9a63a08b Fix PR 9 years ago
GGabriele 4c3a1e37ff Added python object for 2.1 and 2.2 support 9 years ago
GGabriele 4bcf5797b6 Increase timeout 9 years ago
GGabriele 3c0a1675c0 Adding nxos_rollback 9 years ago
GGabriele 25f9d122aa Adding nxos_vxlan_vtep 9 years ago
GGabriele b3c428e61f Adding nxos_vrf_af 9 years ago
GGabriele 705b61ae7a Adding nxos_portchannel 9 years ago
GGabriele 933a555408 Adding nxos_vpc 9 years ago
GGabriele eb32565b73 Adding nxos_static_route 9 years ago
GGabriele 4ee018e51d Fix error handling 9 years ago
GGabriele 1d393941c0 Adding nxos_smu 9 years ago
GGabriele 751f63c6a2 Adding nxos_pim_rp_address 9 years ago
GGabriele 1327e6bcd4 Adding nxos_pim module 9 years ago
GGabriele 9c254656aa Fixing module description 9 years ago
GGabriele 2b434515d5 Addin nxos_overlay_global 9 years ago
Scott Butler bbf209b071 Added semicolon to invalid operators list redux. 9 years ago
Kenny Woodson 3cb42fc5dd Fix for validate rule. Ensure rule is a dict. (#4640) 9 years ago
Evan Kaufman 77f5472a53 Declare empty diff dict ahead of time (#4646)
Fixes #4634
9 years ago
Kenny Woodson f1db594e9f Getting rid of a None type error when no resource tags are defined. (#4638) 9 years ago
Toshio Kuratomi 69ec272982 Python3 fixes to copy, file, and stat so that the connection integration tests can be run (#4632)
* Python3 fixes to copy, file, and stat so that the connection integration tests can be run

* Forgot to audit the helper functions as well.

* Fix dest to refledt b_dest (found by @mattclay)
9 years ago
GGabriele cba6804824 Adding nxos_interface_ospf 9 years ago
GGabriele 0a8a84a50d Adding nxos_hsrp 9 years ago
GGabriele c902f2da14 Fix typo 9 years ago
GGabriele aabab30a4f Fix try/except 9 years ago
GGabriele e392417232 Adding nxos_file_copy 9 years ago
GGabriele 40e600e901 Adding nxos_evpn_vni 9 years ago
GGabriele 52ed410679 Fixed DOCSTRING 9 years ago
GGabriele 0bedbb6bed Adding nxos_bgp_neighbor_af module 9 years ago
GGabriele bd758e8188 Adding nxos_bgp_neighbor module 9 years ago
GGabriele fdfec51cce Fixing DOCSTRING yaml format 9 years ago
GGabriele b5dbfd70d4 Fixing DOCSTRING 9 years ago
GGabriele e0f4565822 Adding nxos_bgp_af module 9 years ago
GGabriele a6f09215ec Adding python object for 2.1 support 9 years ago
GGabriele 77c247ba3b Adding python objects for 2.1 support 9 years ago
GGabriele d0acaf72e8 Removing delete for bollean, fixing argparse, embedding python object 9 years ago
Peter Sprygada ac1c643cc8 bugfix that adds missing itertools import to ios_facts
fixes #4647
9 years ago
Peter Sprygada 702efda508 add new functionality to junos_command module
* commands argument now accepts a dict arguments
* rpcs argument now accepts a dict argument
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
9 years ago
Michael Scherer 30cd0e8afe Add support for selinux_boolean_sub conversion (#4570)
SELinux since 2012 use a configuration file to
convert boolean names from a old name to a new name,
for preserving backward compatibility.

However, this has to be done explicitely when using the python
bindings, and the module was not doing it.

Openshift ansible script use this construct to detect if
a boolean exist or not:

    - name: Check for existence of virt_sandbox_use_nfs seboolean
      command: getsebool virt_sandbox_use_nfs
      register: virt_sandbox_use_nfs_output
      failed_when: false
      changed_when: false

    - name: Set seboolean to allow nfs storage plugin access from containers(sandbox)
      seboolean:
        name: virt_sandbox_use_nfs
        state: yes
        persistent: yes
      when: virt_sandbox_use_nfs_output.rc == 0

On a system where virt_sandbox_use_nfs do not exist, this work. But
on a system where virt_sandbox_use_nfs is a alias to virt_use_nfs (like
Fedora 24), this fail because the seboolean is not aware of the alias.
9 years ago
Toshio Kuratomi 45846127c5 to_text, to_bytes, and to_native now have surrogate_or_strict error handler (#4630)
On python3, we want to use the surrogateescape error handler if
available for filesystem paths and the like.  On python2, have to use
strict in these circumstances.  Use the new error strategy for to_text,
to_bytes, and to_native that allows this.
9 years ago
John R Barker aa0b93a338 Consistent naming of Arista EOS device (#4616) 9 years ago
Matt Clay 928ef28fc8 Add python3 testing for module PRs. (#4629) 9 years ago
Senthil Kumar Ganesan fed23d2f31 Cleaned up the module imports 9 years ago
Tobias Wolf cda78382b6 Fix database table quoting in privileges_unpack() (#3858)
In Ansible 2.x this module gives `changed = True` for all privileges
that are specified including a table with

    priv: "database.table:GRANT"

Mysql returns escaped names in the format

    `database`.`tables`:GRANT

However in PR #1358, which was intended to support dotted database names
(a crazy idea to begin with), the quotes for the table name were left
out, leading to `curr_priv != new_priv`.

This means that the idempotency comparison between new_priv and
curr_priv is always 'changed'.

This PR re-introduces quoting to the table part of the priv.
9 years ago
Jean Prat ed246a328f if user is empty, it is not converted to tuple when using host_all (#3038) 9 years ago
James Cammarata aa67bb43fe Adding 'end_play' docs to meta module 9 years ago
GGabriele 5277f645e5 Fixing DOC string 9 years ago
GGabriele 0b887cd193 Fixing RETURN string 9 years ago
GGabriele 6590c4677d Adding nxos_ospf_vrf module 9 years ago
GGabriele a678439059 Adding nxos_ospf module 9 years ago
GGabriele c8016946f3 Adding nxos_evpn_global module 9 years ago
GGabriele fb4da92308 Fixing typo 9 years ago
Toshio Kuratomi 5bd9cdad5a We've decided that pythn 3.5 is the minimum python3 version (#4572) 9 years ago
GGabriele a539ea47bc Adding nxos_acl_interface_module 9 years ago
Michael Scherer 25fd3928b6 Make async work on python 3 (#4583)
Since dict no longer have a iteritems method, we have to
use six to support python 2 and 3.
9 years ago
Michael Scherer f4158304ac Port mount.py to python3, need to use six.iteritems (#4581) 9 years ago
Michael Scherer b48e65219b Fix uri to run on python3 (#4580)
Since dict no longer have a method iteritems, we have to use
the six wrapper.
9 years ago
Michael Scherer f59af7d29e Port postgresql module to python3 (#4579)
Iteritems is no longer a dict method in Python3, replace it with
the six wrapper.
9 years ago
Michael Scherer 839d5b6de4 Fix mysql_user for python3 (#4576)
dict no longer have a iteritems method, it was replaced
by items. So we need to use six.

    Traceback (most recent call last):
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 587, in <module>
        main()
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 571, in main
        changed = user_add(cursor, user, host, host_all, password, encrypted, priv, module.check_mode)
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 239, in user_add
        for db_table, priv in new_priv.iteritems():
    AttributeError: 'dict' object has no attribute 'iteritems'
9 years ago
GGabriele 549ca5183d Adding RETURN string 9 years ago
Michael Scherer f2b6c7b6a2 Fix user module under python3 (#4560)
Using something like:

    - name: Create ssh keys
      user:
        name: root
        generate_ssh_key: yes
      register: key

result into this traceback on F24

    Traceback (most recent call last):
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 2170, in <module>
        main()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 2108, in main
        (rc, out, err) = user.modify_user()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 660, in modify_user
        return self.modify_user_usermod()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 417, in modify_user_usermod
        has_append = self._check_usermod_append()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 405, in _check_usermod_append
        lines = helpout.split('\\n')
    TypeError: a bytes-like object is required, not 'str'
9 years ago
Michael Scherer 898cf5b462 Fix traceback on python3 (#4556)
Traceback (most recent call last):
  File "/tmp/ansible_csqv781s/ansible_module_systemd.py", line 374, in <module>
    main()
  File "/tmp/ansible_csqv781s/ansible_module_systemd.py", line 263, in main
    for line in out.split('\\n'): # systemd can have multiline values delimited with {}
9 years ago
GGabriele a4817cff30 Adding nxos_acl module 9 years ago
John R Barker 51aa4e803f Consistent naming of Arista EOS device 9 years ago
GGabriele bc47cf362b Fixing string case 9 years ago
Senthil Kumar Ganesan 8c5b189f8b Incorporated Ansible community feedback 9 years ago
Peter Sprygada 019de090d4 update ops_facts with enhancements
* adds support for default facts subset
* adds support for config facts subset
* maintain legacy facts from ops_facts pre-2.2

Tested on Openswitch 0.4.0
9 years ago
Peter Sprygada 018cdf33a2 update ops_template module using refactored network shared modules
This updates the ops_template module to work with the network shared
modules introduced in Ansible 2.2

Tested with OpenSwitch 0.4.0
9 years ago
Peter Sprygada 54232c3b2d update ops_config module with new enhancements
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead

Note: this module only supports transport=cli

Tested on OpenSwitch 0.4.0
9 years ago
Peter Sprygada ef46627f1f added new functionality to ops_command
* commands argument now accepts a dict arguments
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowed when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

Tested on OpenSwitch 0.4.0
9 years ago
GGabriele 882f201aa0 Fixing DOC 9 years ago
GGabriele 2b2636510d Adding nxos_bgp.py 9 years ago
Senthil Kumar Ganesan c66432bbae Moved the modules to Dell folder 9 years ago
Senthil Kumar Ganesan 90cb4710d7 Added Command and Config modules to support Dell Networking OS10 device 9 years ago
Peter Sprygada 0f4446166b update eos_eapi module with new enhancements
* add support for vrf configurations
* add support for configing the qos value for eapi
* add config argument to specify the device running-config

Tested on EOS 4.15.4F
9 years ago
Peter Sprygada 5e5698dc9e removes output keyword from command in ios_command
IOS devices only support a single command output which is structured
text.  This removes the ability to specify the command output format
when providing complex arguments to the commands
9 years ago
Peter Sprygada 7280b2642a update nxos_nxapi module with minor enhancements (#4573)
* added new config argument
* added states present and absent
* update to use network shared modules

Tested on NXOS 7.3(0)D1(1)
9 years ago
Timothy Appnel 5b00b40c22 Fixes get_url examples in docs and applies native YAML syntax. (#4474) 9 years ago
John R Barker 89529366bf digital_ocean_tag name is a required field
Spotted during final review of https://github.com/ansible/ansible-modules-core/pull/4218/files
Simple to change, so fixing post merge
9 years ago
Victor Volle 6a20e6649d Digitalocean tags (replaces #4209) (#4218)
* Fixes #4117: Add DigitalOcean Tag support

* Add GPLv3 license header and RETURN documentation

* ansible.module_utils.urls instead of "requests"
9 years ago
Arun prasath 7a7ac2ee83 Fixes bug #4546 - Made password optional (#4574) 9 years ago
David J Peacock bcc738bd0d Fix #4412: os_security_group_rule support numbered protocols (#4444) 9 years ago
Ryan Brown c85d854c84 Remove spurious `changed` state on iam_policy module (#4381)
Due to a mixup of the group/role/user and policy names, policies with
the same name as the group/role/user they are attached to would never be
updated after creation. To fix that, we needed two changes to the logic
of policy comparison:

- Compare the new policy name to *all* matching policies, not just the
  first in lexicographical order
- Compare the new policy name to the matching ones, not to the IAM
  object the policy is attached to
9 years ago
James S. Martin 4d75f9b4bc Shows messages for uncaught exceptions from called modules in async_wrapper output. (#4591) 9 years ago
Rick Mendes 503c2b6158 Fixes #3144 (#4305) 9 years ago
Vytis Banaitis 3149fdf158 Fix change status on django_manage collectstatic. (#4239)
Ignore blank lines in collectstatic output.
9 years ago
Guillaume Delpierre 90bf5434d0 gem: add support for --env-shebang (#4377)
* gem: add support for --env-shebang

* fix version added
9 years ago
Levi Morales 0c9d895438 Fixes #2322 fix for missing append check on Darwin systems (#4256) 9 years ago
Evan Kaufman 254df9bcca Implemented file content diff for replace module (#4479) 9 years ago
Matías Pizarro c1dae481e8 Use named parameters in new_droplet method call (#4483)
This mirrors the original method signature and guards against any
change in order parameter
9 years ago
Anton Onufriev f5f1062d72 Remove colors from git-branch output for correct local search (#4545)
We got an error while switching on existent local branch
because git module can not find branch in function get_branches
if we have color.branch=always in git config.
9 years ago
Michael Scherer ee5a48b84d Port the module to run on python 3 (#4496)
One of the usual issue is that run_command return bytes,
so we have to adapt the string to either be bytes too,
or convert to string.

This result into that kind of traceback:

    Traceback (most recent call last):
      File \"/tmp/ansible_ej32yu2w/ansible_module_git.py\", line 1009, in <module>
        main()
      File \"/tmp/ansible_ej32yu2w/ansible_module_git.py\", line 873, in main
        git_version_used = git_version(git_path, module)
      File \"/tmp/ansible_ej32yu2w/ansible_module_git.py\", line 788, in git_version
        rematch = re.search('git version (.*)$', out)
      File \"/usr/lib64/python3.5/re.py\", line 173, in search
        return _compile(pattern, flags).search(string)
    TypeError: cannot use a string pattern on a bytes-like object

Another issue is filter being a object instead of a list.
9 years ago
James Pharaoh 06f5f2e26d fix error in documentation for stat checksum (#4582) 9 years ago
Ilja Bauer 729486809e Replaced use of bare variables with full variable syntax (#4149) 9 years ago
Gennady Trafimenkov 7ea7564bf4 Clarify what checksum algorithm is used by copy modules (#4198) 9 years ago
Ali Ok 1e411f9551 Fix minor syntax error in authorized_key module doc (#4491) 9 years ago
Robin Roth ccddeb8cdc Clarify that refspec is needed to checkout a git hash (#4564)
fixes #1531
9 years ago
Michael Scherer 338a8c8632 Convert command output to native string (#4559)
Without it, the module always return changed on python3,
which is harmless but add noise and can have some side effects.
9 years ago
Peter Sprygada 66b0a1ef2d convert nxos_facts map from dict to frozenset
* key maps are now frozenset instead of dict objects
* FactsBase now includes utility functions for transforming json data structures

Tested on NXOS 7.3(0)D1(1)
9 years ago
chouseknecht 964b7ecffa Fix container labels expected vs actual comparison. 9 years ago
Brian Coca e37f57fc90 added docs for vars_from/defaults_from 9 years ago
Brian Coca 79d970d5b8 updated include_role docs to latest info 9 years ago
Peter Sprygada 4fd4ff8d5c update eos_template for network shared module
This updates the eos_template module to work with the changes introduced
in the network shared module in Ansible 2.2

Tested on EOS 4.15.4F
9 years ago
Peter Sprygada d0a98bc433 update nxos_template module with network shared module changes
This updates the nxos_template module to work with the network shared
modules introduced in Ansible 2.2

Tested on NXOS 7.3(0)D1(1)
9 years ago
Peter Sprygada 8f303981d4 update ios_template module using refactored network shared modules
This updates the ios_template module to work with the network shared
modules introduced in Ansible 2.2

Tested in IOS 15.6(1)T
9 years ago
Peter Sprygada 7eb550aa53 update iosxr_template to use network shared modules
This updates the iosxr_template module to make it work with the new
shared network modules introduced in Ansible 2.2

Tested on IOSXR 6.0.0
9 years ago
Peter Sprygada 0da190abbd add new iosxr_facts module for fact collection from XR devices
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset

Tested on IOS-XR 6.0.0
9 years ago
Jason Edelman 3b83e676e6 removed feature check for nxos_interface 9 years ago
Brian Coca b7d2c62f2b 1st draft of include role docs 9 years ago
Peter Sprygada 751eab187f updates nxos_facts with more fact collections
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset
* maintains backwards capabilitity with 2.1 facts module

Tested on NXOS 7.3(0)D1(1)
9 years ago
Peter Sprygada 733ee349b0 add new eos_facts module for fact collect of EOS nodes
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset

Tested on EOS 4.15.4F
9 years ago
Peter Sprygada d138b94c70 update iosxr_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge, replace or check
* add backup argument to backup current running config to control host
* add comment argument to provide comment to commit
* deprecated force argument, use match=none instead
9 years ago
Toshio Kuratomi c4988262b5 Fixes for lineinfile (#4553)
Lineinfile deals heavily with Unic text files.  Makes some sense to deal
with it all as byte strings.  So there is a lot of work done here to
show that we're dealing with byte strings throughout.
9 years ago
Peter Sprygada 28ab66cef2 update RETURNS doc string in ios_facts
updates the doc string for consistency and completeness
9 years ago
Patrick Marques 697a328124 ssh_public_keys on Azure virtual machine is a list (#4350)
The ssh_public_keys must be a list otherwise will give the error:
"argument ssh_public_keys is of type <type 'dict'> and we were unable to convert to list"
9 years ago
Peter Sprygada 5ebe26e782 initial add of network/sros modules
* adds support for sros_command module for sending arbitrary commands
* adds support for sros_config module for working with sros configurations
9 years ago
Dag Wieers 32e3cc7778 Fix multiple issues with unzip and gtar support (#4131)
* Improve the correct handling of gtar and unzip options

Add the option --show-transformed-names when extra_opts is being used
Ignore bogus warnings related to empty filenames
Properly quote _and_ escape filenames for unzip command
Rewrite gtar options and provide run_command with array, not string

This fixes #2480 and #4109.

* Make check-mode work for zip-files

Check-mode was disabled for zip-files since gtar did not support it.
This change enables check-mode support for zip-files, but does skip the task when used with gtar.
(Best of both worlds)

Also remove unused compress_mode variable.

This replaces PR #4401, the changes overlap somewhat so I merged them
9 years ago
Dag Wieers 02b906d70f Remove redundant code AFAICT (#3908) 9 years ago
Toshio Kuratomi b7522c5a1c Fix hg for python3 (#4528)
* Remove import of unused ConfigParser (ConfigParser has been renamed in py3)
* When retrieving version, normalize to a native string
9 years ago
Peter Sprygada bbcde06e75 added new functionality to vyos_command
* commands argument now accepts a dict arguments
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
9 years ago
Peter Sprygada 003b6da05a add new functionality to iosxr_command module
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.
9 years ago
Peter Sprygada df972feb23 updates to vyos_config module arguments
* arguments for vyos_config for 2.2 are now complete
* adds loading config file from disk (src argument)
* removes unsupported rollback argument
* changes update_config to update with options merge or check
* changes backup_config to backup
* add state argument for state of configuration file
* adds backup argument to backup current configuration
* adds save argument to control if active config is saved to disk
* adds comment argument for setting commit comment
* adds match argument to control configuraiton match

Tested with VyOS 1.7
9 years ago
Gary Rybak e2d55d86e4 Move call to filter_exit out of command execution block to prevent setting 'changed' on a command list that is completely filtered (empty). 9 years ago
Richard Adams b0135fadea Add parameter to `ec2` module to control instance shutdown behavior (stop|terminate) 9 years ago
Toshio Kuratomi 9b7e866964 Cleanups of command.py (#4526)
* Import module_utils at the top
* Fix python3 by marking literals combined with stdout/stderr as byte
  literals
* Mark parameters as type=path where appropriate
9 years ago
Karthik Suresh 4d7d3cdbb1 Removing duplicate name: parameter possible typo (#4525)
Removed name:parameter in documentation. Possible typo.
9 years ago
Matt Clay f804bdad48 Enable CI on Shippable for OS X. (#4515) 9 years ago
chouseknecht 1b4a3dbc86 Fix doc strings. Use of > was breaking HTML generation on docs site module page. 9 years ago
Michael Scherer 1f8b2f3e6e Add support for setting fstab location on Linux too for mount (#3271)
Fix #3153
9 years ago
Michael Scherer 441205feed Add acl freebsd (#3656)
* FreeBSD do not support --omit-header and --absolute-names

* The option for following symlink wth getfacl is different on FreeBSD

* ZFS on Freebsd use nfsv4 acls, who use a slightly different syntax

* FreeBSD do not have a --test flag, so always return 'True'

* FreeBSD do not have the --omit-headers options, so we have to filter by ourself

* Mark Freebsd as working for the acl module
9 years ago
Peter Sprygada c98a906cf0 add new functionality to eos_command module
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
9 years ago
Peter Sprygada 717af59c96 update eos_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge, replace or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or without defaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
9 years ago
Peter Sprygada 12fc073f91 fix example in nxos_command module 9 years ago
codyrat c4d5b13c8f re.match for numeric only for kwargs[key] = int(value) (#4495) 9 years ago
Peter Sprygada 619e3bba7e fixes issue with duplicated commands in CommandRunner
The CommandRunner will not allow duplicate commands to be added to the
command stack.  This fix will now catch the exception and continue if
a duplicate command is attempting to be added to the runner instance.
9 years ago
Peter Sprygada e09cfec2e9 added new functionality to nxos_command
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
9 years ago
Peter Sprygada 543ec0f14e update nxos_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or without defaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
9 years ago
Peter Sprygada 525cd8b947 merge functions from ios into ios_config
* merge changes from ios shared module functions into ios_config.
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
9 years ago
Peter Sprygada aa79cdb7d9 added new functionality to ios_command
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
9 years ago
jctanner c73f9d0492 git: add a umask parameter (#4473)
Sources #10504
Fixes #10279
9 years ago
nishiokay fc79615e38 Add ipv6 paramater to digital_ocean module (#4447) 9 years ago
Toshio Kuratomi 07e79ac683 Refactor stat.py so that it would be more friendly for unittests. (#4462)
* Refactor stat.py so that it would be more friendly for unittests.

* PEP8ify since we're moving most of the lines in the file and there's no open PRs
9 years ago
Jason Edelman 4f09d6065f added a period 9 years ago
Jason Edelman 56d8146495 make aliases a list in the docstring 9 years ago
Jason Edelman 47164d70d3 remove commented out code, add alias, and doc 9 years ago
Jason Edelman b8ff21fb07 updated version_added for new param 9 years ago
Jason Edelman 5d033241af fixed error handling 9 years ago
Jason Edelman 5640711166 fixed docs 9 years ago
Jason Edelman 995083c0d9 improve functionality for vlan trunks based on #4082 9 years ago
Linus Arver 8da17b750d docker_service: fix files/project_files typo
The original decision to rename from `project_files' to `files' was in
3a5dd00076.
9 years ago
chouseknecht fb99277066 Exposing tcp and udp for same port fails. Fixes issue #4354. 9 years ago
Chris Short 8ffe5c3c54 find.py: Editing contains description to say regex (#4452)
find module contains argument appears to accept regex; correcting description accordingly
9 years ago
Alexey Sheplyakov 8d4fe2a767 apt_key: fix spurious failure to import a subkey (#4366)
Importing a (sign only) subkey with apt_key module always fails,
however the actual keyring gets created and contains the correct keys.
Apparently the all_keys function skips the subkeys, hence the problem.

Fixes #4365
9 years ago
PikachuEXE fc87dd9650 Allow specifying human readable value for option `memory_limit` again (#4049) 9 years ago
jctanner 53a0a64bda git: set the file:// protocol if needed and refactor HEAD parser (#4434)
* make HEAD parsing more robust
* Fail the module for any splitter errors
* fix combining depth and version on filepath urls by prepending file://

Addresses #907
9 years ago
Timmo Verlaan 159918a8ef Determine branch name more reliable (#907)
* Made some changes to determine branch name more reliable (it may contain slashes now).

* Determination of branch name more reliable, as per comment on PR #907
9 years ago
jctanner 7e65315d92 git: Use a local copy of unfrackpath to avoid using ansible.lib (#4426)
Fixes #4425
9 years ago
jctanner c60954605b git: If force=yes, apply --force to submodule updates to overwrite local changes (#4415)
Fixes #238
9 years ago
chouseknecht 76260d3aa8 Fix network alias and network link comparison. - Using set based comparison was not working consistently - With != operator worked locally but consistently failed on Travis - With 'not in' operator failed locally and on Travis 9 years ago
Brian Coca 1160c79671 added meta as 'documentation' 9 years ago
chouseknecht 433b5e187f If debug true, include actions and differences in output. 9 years ago
Chris Houseknecht a8111adcd6 Some post merge clean up: (#4406)
- Removed required_if.
  - Fixed doc strings.
  - Removed debug output being appended to actions.
  - Put import of basics at bottom to be consistent with other docker modules
  - Added 'containers' alias to 'connected' param
  - Put facts in ansible_facts.ansible_docker_network
9 years ago
Brian Coca 94486c5c77 doc fix 9 years ago
Rob Cutmore 09b06a601c Git: Determine if remote URL is being changed (#4243)
* Git: Determine if remote URL is being changed

Ansible reported there were no changes when only the remote URL for a
repo was changed. This properly tracks and reports when the remote URL
for a repo changes.

Fixes #4006

* Fix handling of local repo paths

* Git: Use newer method for fetching remote URL

* Git: use ls-remote to fetch remote URL

Using ls-remote to fetch remote URL is supported in earlier versions
of Git compared to using remote command.

* Maintain previous behavior for older Git versions

Previously whether or not the remote URL changed was not factored
into command's changed status. Git versions prior to 1.7.5 lack the
functionality used for fetching a repo's remote URL so these versions
will update the remote URL without affecting the changed status.
9 years ago
Chris Houseknecht af3884f558 Adding docker_network module. (#4404) 9 years ago
jctanner 6c439a4882 user: Cast all arguments to string before passing to run_command (#4398)
Fixes #4397
9 years ago
Matt Clay 0b01e53b16 Only run integration script if it exists. 9 years ago
Matt Clay 033850b14a Update call to generate-tests. 9 years ago
Lucas Costa Beyeler 6aeea1fe7e Fix #4202: Can't unarchive remote files (#4244)
When you try to remote unarchive files with the option copy=no the code always fail, as evidenced in issue #4202. That happens because the conditional to check "if remote_src=no or copy=yes" will always be true since the default value of them is remote_src=no and copy=yes.
My modification is only to change the condition from or to and, that way only if both the vars stay with the default value will be true, otherwise you can unarchive remote files.
9 years ago
Brian Coca 16ccde49ad remove X bit 9 years ago
jctanner 634b1024d6 git: save changed submodules in check and non-check mode (#4392) 9 years ago
Dag Wieers 4ee9cc4b3f Add diff mode support to git module (#3364)
* Add diffmode support to git module

This patch adds missing diffmode support to the git module.

* Remodel get_diff() and calls to it

As proposed by @abadger

* Ensure we fetch the required object before performing a diff

Also we handle the return code ourselves, so don't leave this up to run_command().
9 years ago
Indrajit Raychaudhuri fb255b3607 Improve hostname module to support systemd in more generic way (#4382)
Now that there is general purpose `Fact` helper to detect if systemd
is active, we would be able to rely on that to apply SystemdStrategy.

Detecting presence of systemd at runtime would be more reliable than
distribution version based heuristics. (e.g., Debian, Ubuntu allows
user to change the default init system, Gentoo allows switching as
well, and so on).
9 years ago
Brian Coca ab3a87cc1a improved logic when dealing with init scripts 9 years ago
Brian Coca 3c89a21e0c fixes corner case for systemd services
when both unit file and sysv init script exist
Thanks to @olfway for fix.

fixes #3764
9 years ago
Dag Wieers fe273a4e09 Improve the documentation (#4385)
Improvements to make it more clear that pure compressed files (.gz, .bz2 and .xz) files are not supported.

This improves on #3241.
9 years ago
Sam Doran 4c6cfb9eec Improve regexp for matching file permissions (#4306)
A capital "S" appears when the the setuid or setgid bit are set but have no effect. Likewise, a capital "T" appears when the sticky bit is set but it has no effect.
9 years ago
Roman 7b547e3e0b get_url headers param values parsing (#4245) 9 years ago
Evan 7b66bdc1c4 pip: Fix uninitialized variable during check_mode (#4379)
During check_mode (`--check`), the variable change could be
used uninitialized, yielding this error:

`UnboundLocalError: local variable 'changed' referenced before assignment`

This changeset simply initializes it to False.
9 years ago
Evan Kaufman 3a44d60fbc Fixes #3791 cron always returning changed state for multiline jobs (#4285)
Strip only newlines and carriage returns. Instead of stripping ALL whitespace, which may have unintended side effects
9 years ago
BradLook 766413e79d Allow cron to target remote user (#4270) 9 years ago
René Moser 03022875c4 mysql_db: use new exception handling, fixes build (#4373) 9 years ago
Jan Malte Gerth 9549883e78 reuse already split output for filtering (#4310)
there is no need to call out.split('\n') multiple times (line 275 and 277)
9 years ago
Brian Coca 81e87cefd7 unsafe writes! (#4314)
* unsafe writes!

* moved unsafe_write docs and args to file common

* added unsafe_writes option handling
9 years ago
Saurabh Sharma a5695c8b24 error handling for importing non-existent db. Fixes ##2068 (#3617)
* error handling for importing non-existent db

* creating db on import state and suitable message on deleting db

* handling all possible cases when db exists/not-exists
9 years ago
Toshio Kuratomi c5052f9b01 Be explicit about specifying the ssh port if it was user specified (#4302)
Previously, if the port specified by the user or inventory was 22, then
the ssh client port would be used instead.

Fixes #3895
9 years ago
Zoltán Müllner ac561772ea Revert "Reset all locale environment variables before running svn commands" (#4358)
* Revert "Reset all locale environment variables before running svn commands"

This reverts commit 99456fbc98.

* Reset locale environment variables before running svn commands
9 years ago
Michael Scherer cd3c454917 Add a example with a non service unit (#4355)
Since the documentation focus mostly on service
units, a explicit example may help people realizing
it can be used for socket and timer too.
9 years ago
Alvaro Aleman d9c28454ae Make ios_command example working 9 years ago
muxator 16db1d54d1 typo in the documentation of the "state" parameter (#4353) 9 years ago
John R Barker 1357e7e83a ios & iosxr Documentation improvements (#4321) 9 years ago
Chris Houseknecht 2514ec5056 Add buildargs parameter to support Dockerfile ARG directive. (#4349)
* Add buildargs parameter to support Dockerfile ARG directive.

* Fix doc_strings. Doc string for load_path was completely missing.
9 years ago
chouseknecht f6b126d412 Default repository tag value to tag parameter value or 'latest'. 9 years ago
chouseknecht 3dab1785ba Always returns changed when state present and name includes :tag. 9 years ago
Chris Houseknecht 1cf9d3e68e Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed (#4342)
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
9 years ago
John Barker ecc7e445b5 vyos: Docs fixes 9 years ago
John Barker d76a4e71c2 openswitch: Docs fixes 9 years ago
John Barker 3f8f67e359 NXOS Docs update 9 years ago
chouseknecht 2ea29fee3f Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'. 9 years ago
John Barker d4200b0389 junos: Docs update 9 years ago
Nathaniel Case 36ba105b91 Fix ios_config broken logic 9 years ago
John Barker 6ad7d6b3cd Cumulus - consistent docs formatting 9 years ago
Nathaniel Case 6857cea9e6 Quick fix to nxos_command and minify imports 9 years ago
chouseknecht 0c4da5d3a0 Added implementation of ignore_image, which prevents recreation of containers on image change. 9 years ago
chouseknecht 5992c21c9c Fix #3670 host IP defaults to 0.0.0.0 ignoriing bridge Host IP option. 9 years ago
chouseknecht a6bfeea1c4 Improved documentation for returned actions. 9 years ago
chouseknecht cd7b34547d When build true call docker-compose build, and add nocache option. 9 years ago
chouseknecht df09b4f668 Set version_added 9 years ago
chouseknecht 1670d9b030 Add pull option to pull images prior to evaluating service state. 9 years ago
Kevin Kirsche db03ebdfb9 Fix typo in "ssantaize" typo
ssantaize to santaize
9 years ago
John Barker 2b82389705 General EOS documentation improvements
Typos, formatting, choices.
9 years ago
Shawn Siefkas e9bf046c26 Check mode fixes for ec2_vpc_net module (#2179)
* Check mode fixes for ec2_vpc_net module

Returns VPC object information

Detects state change for VPC, DHCP options, and tags in check mode

* Early exit on VPC creation in check mode
9 years ago
Shawn Siefkas 0b95051039 Fix #2526 (#2527)
Fail on unhandled exception in ec2_asg rather than raise
9 years ago
Shawn Siefkas 66f1f6d537 Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
9 years ago
Michael Scherer 3c2110215c Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
9 years ago
peter.jang b06f3bbb22 fix for rsync protocol (#4211) 9 years ago
John R Barker aa6a7d5789 State runnng v running
Fix typo
9 years ago
Matt Clay c2270a37ff Enable FreeBSD tests on Shippable. (#4296) 9 years ago
Rick Mendes be33879152 Fixes #4227: just changing messaging 9 years ago
Rick Mendes eae75cf727 Fix #3549, failure to reference `module` in `ec2_eip` module 9 years ago
David Chwalisz f979928ecc file module: add clarification on state=absent re files that do not exist. 9 years ago
Christian Schwarz e526b2ad3d system/service.py: fix false-positive service enablement on FreeBSD. (#4283)
sysrc(8) does not exit with non-zero status when encountering a
permission error.

By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.

Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
9 years ago
Lyle Mantooth f57ece661f Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
9 years ago
Julien Vey 7ba3ba2da9 Fix Typo in docker_image_facts module 9 years ago
Monty Taylor f441e2c1a9 Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
9 years ago
Rick Mendes 4fad93561a please remove me as maintainer 9 years ago
Rick Mendes d6cc007380 Fixes #4227 9 years ago
Jasmine Hegman f5c3f4dd6b Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
9 years ago
Matt Clay df5869df4a Enable Windows tests on Shippable. (#4278) 9 years ago
Shaun Brady 7b8d625546 Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
9 years ago
Shaun Brady 3b32b60338 Remove trailing white space 9 years ago
Shaun Brady 04199140c5 Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
9 years ago
Rob Phoenix 6339398e7c various typo corrections to ios network modules 9 years ago
John Baublitz fe09641476 Doc update 9 years ago
John Baublitz c8dc0bf5c9 Fix exception handling to be compatible with Python 3 9 years ago
John Baublitz 4b11312737 Additional error handling for corner cases like deleting networks with active subnetworks 9 years ago
John Baublitz e4697c3780 Documentation 9 years ago
John Baublitz 96599a5963 Logic to allow subnet creation 9 years ago
John Baublitz 5591e6bb0b Add error handling for specifying 'mode' with insufficiently recent libcloud 9 years ago
John Baublitz 9c9b22dc8f Changes to allow 'auto' mode which does not allow IP address specification 9 years ago
John Baublitz 839871d87b Support for newer networking modes in GCE 9 years ago
Brian Coca 7f1e6ca005 updated docs to reflect new feature 9 years ago
Ryan 8b582cceaa fix typo in azure_rm_storageaccount (#4236) 9 years ago
Brian Coca d579dab0a0 deprecated accelerate 9 years ago
chrisweaver 531954e2f6 Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
9 years ago
Toshio Kuratomi 879afebf77 Remove git and synchronize modules from list of commands we want users to use the module for instead. (#4233) 9 years ago
Matthew Martin 4d952d6e6e Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
9 years ago
Michael Baydoun 3818cc2b95 fixes issues where iam_policy incorrected reported changed 9 years ago
John Baublitz 906b457bf1 Collapse boilerplate code into change_instance_state function 9 years ago
John Baublitz eb97165acc Add states for stopping and starting machines 9 years ago
Tom Melendez 067bb6ec01 Added helper function and logic to sort attributes before comparing. 9 years ago
Kai Kousa 4a8a052e2e Improve documentation on security_groups-option 9 years ago
Tom Melendez 8becd9a14d Allow GCE firewall rules to be updated when attributes changes. Fixes #2111.
Previously, when the attributes of a GCE firewall change, they were ignored.  This PR changes that behavior and now updates them.

Note that the "update" also removes attributes that are not specified.

An overview of the firewall rule behavior is as follows:

1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP
2. firewall name in PLAYBOOK, not in GCP: Add to GCP.
3. firewall name in GCP, name not in PLAYBOOK: No change.
4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.
9 years ago
yfried-redhat b1ee47f358 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
9 years ago
Andrei Lukovenko 436ff356e7 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
9 years ago
Brian Coca 544b044129 stop trying to set permissions in check mode
fixes #4195
9 years ago
Brian Coca 498dc61154 documenting behaviour as clear as possible 9 years ago
Toshio Kuratomi 0364831c22 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
9 years ago
Peter Sprygada 42da47813b adds update_config argument to ios_config
New argument controls whether or not configuration is applied to the
remote device.
9 years ago
Peter Sprygada 4611e2b9ad initial add of new module vyos_config
New module for sending configuration commands to remote devices running
the VyOS operating system.
9 years ago
Peter Sprygada cff91c4c3b initial add of new module vyos_facts
* adds collection of default facts
* adds collection of configuration facts
* adds collection of lldp neighbors
9 years ago
Ryan S. Brown 9336e0d070 Indent `unarchive` module documentation to fix parsing error. 9 years ago
tobixx ed1d80b7d8 added read-/write-/executeable flags for invoking user (#4130) 9 years ago