Our CLI shared some data structures, like the pulseaudio connection with the GUI.
This could lead to issues where the UI would break when code on the CLI was changed
because the the GUI must handle things differently, by nature of working differently.
Add more separation between those, so changes on the CLI are less likely to break the GUI.
Previously we had the capability to remove the rlimit on pulseaudio
by calling ourselves via pkexec to elevate privileges.
A while ago we switched to fully using capabilities.
We now remove the old legacy codepath.
Previously we dispatched calls to different drawing function with
a bunch of if statements in the main draw function.
Use a stack of drawing functions instead.
Squashed commit of the following:
commit 19532d64a7f7337da7f844d52198417ceaf60e80
Author: lawl <github@dumbinter.net>
Date: Thu Feb 4 10:40:27 2021 +0100
Fix unloading paClient for UI
commit 66ece81e17589988f92059b44b2659fdca0c4ca1
Merge: 1c97cfe60d06f2
Author: lawl <github@dumbinter.net>
Date: Thu Feb 4 10:36:13 2021 +0100
Merge branch 'fix_cli_unload' of git://github.com/hador/NoiseTorch into hador-fix_cli_unload
commit 60d06f25aa
Author: andreafa <andreafa@amazon.com>
Date: Thu Feb 4 08:51:48 2021 +0000
Fix cli unload (-u).
The findModule method in module.go requires a valid paClient to be
populated in the context object.
Added logging if unloadSupressor fails when called via the -u CLI flag.
In preparation for PipeWire support we required our own implementation anyways.
To have a shared code base and potentially enable some other tighter integration
between the LADSPA module and NoiseTorch, we move to our own implementation.
* moce pa source retrieval to another function
* add commandline flags for unloading/loading supressor without UI
* add threshold flag
* add newlines to new log outputs
* add flag for listing available sources
* add newline for unloading message
* ensure log/console output is redirected to the correct place
* add stderr print for failed initializations
* Cleanup CLI interface
Co-authored-by: lawl <github@dumbinter.net>
lawl