Commit Graph

137 Commits (17650775d2e513745d5bb65129c3e24c1a880fab)

Author SHA1 Message Date
Andrew Dolgov 303f8fb329 properly escape quotes when rendering article data to html attributes via template strings 5 years ago
Andrew Dolgov 7e2fd9bdce Headlines.move: fix move to previous article if scrollTop returns a fractional value for current item 5 years ago
Andrew Dolgov f83836ade9 updateCurrentUnread: don't crash if counter element is not available 5 years ago
Andrew Dolgov 9c0235ab66 show current unread counter on headlines toolbar if sidebar is hidden 5 years ago
Andrew Dolgov 985e11b754 re-enable updates of floating title on scroll, duh 5 years ago
Andrew Dolgov 0e4f67bf2b with previous change, we don't actually need to automatically track active articles now at all in combined mode. 5 years ago
Andrew Dolgov 3993198aa7 when moving next or previous and currently active article is entirely invisible, start moving from first visible one 5 years ago
Andrew Dolgov 7d0bbe9962 only track active article on scroll if auto catchup is enabled 5 years ago
Andrew Dolgov 5b4eb8d7b9 remove unnecessary "== 1" when checking for init params
unsubscribeFeed: check for undefined title correctly
5 years ago
Andrew Dolgov 560346f9d1 Article.cdmScrollToId: disable smooth scrolling on repeated events 5 years ago
Andrew Dolgov dad3d1c7a9 combined mode n/p behavior changes:
1. instead of jumping/scrolling sometimes, always scroll by a constant viewport offset unless moving to next/prev article directly
2. when going up and current article is partially above the viewport, move to its top first instead of directly to a previous one
3. instead of previous marking active logic, on scroll in combined mode track first (partially or otherwise) visible article as active
5 years ago
Andrew Dolgov 44ef447c0f fix fatal error in previous because of event not being passed via Headlines.move()
scrollbypages, etc: make event optional anyway
5 years ago
Andrew Dolgov e7dd634183 exp: auto-disable smooth scrolling for repeat hotkey events 5 years ago
Andrew Dolgov 7a68e4a6f7 pgup/pgdn; increase scroll distance to almost entire viewport height (from 90%) 5 years ago
Andrew Dolgov e1ef122355 force-disable headlines smooth scrolling when switching feeds
enable smooth scrolling for article frame
5 years ago
Andrew Dolgov 1902a7dcb0 pgup/pgdown hotkey normalization:
- pgup/pgdown without modifier scroll headline buffer
- shift+pgup/pgdown work similarly to shift+up/down but operating on pages
5 years ago
Andrew Dolgov d172abb037 scroll handler: also invoke lazy load if last article in buffer is currently active 5 years ago
Andrew Dolgov c35a618b00 lazy load (infinite scrolling) changes:
1. invoke Headlines.loadMore() if last article row is close to becoming visible instead of relying on headlines-spacer offset to viewport

2. allow one final last lazy load request if incomplete buffer was received to permit some flexibility with unread counters possible changing while request was generated / serving remainder of articles
5 years ago
Andrew Dolgov 900cdbbb31 Headlines.click: open original article (and mark as read) on alt click on title 6 years ago
Andrew Dolgov ae9ef7fe84 Headlines.click: fix another small issue with expanded mode (2) 6 years ago
Andrew Dolgov 0b8f3909fe Headlines.click: fix another small issue with expanded mode 6 years ago
Andrew Dolgov 84cf95fe8f Headlines.click: open original article when it makes sense to do so 6 years ago
Andrew Dolgov cf6f867feb getRange: handle start == stop 6 years ago
Andrew Dolgov d876cca22a tweak Headlines.click: ctrl-click toggles selection, shift-click selects range 6 years ago
Andrew Dolgov 70c53257d9 on_catchup_show_next: remove auto-trigger on headlines scroll 6 years ago
Andrew Dolgov 848bb6579c floatingTitle: show collapse button if in expandable mode 6 years ago
Andrew Dolgov 1124c3f00a label display: fix unneeded nested container in headlines, increase overall minimalism, fix label element typo (div1) 6 years ago
Andrew Dolgov 8b26b8629f headlines-frame: set is-vfeed attribute if result is virtual feed 6 years ago
Andrew Dolgov c607b7836e onLoaded: clear this.headlines on first page load 6 years ago
Andrew Dolgov f44c6d01b0 fix previous always disabling infscroll 6 years ago
Andrew Dolgov c66db9bde8 headlines onloaded: when appending, check for duplicate IDs 6 years ago
Andrew Dolgov 8393096947 selectionTogglePublished: fix typo which caused it to mark articles instead 6 years ago
Andrew Dolgov dee210e546 headlines onLoaded: make sure a few more things respect append instead of offset == 0 6 years ago
Andrew Dolgov 8effabd075 append headline buffer if requested, don't just use offset 6 years ago
Andrew Dolgov c3b8b6a2a1 also prevent multiple requests 6 years ago
Andrew Dolgov 54ce930b8d delay counters request on promise completion a bit 6 years ago
Jordan Galby 47b4a262cf fix missing curly brace
Fix the error:
```
SyntaxError: missing } after property list
```
6 years ago
Andrew Dolgov eda4ac2a2b add fallback colors for headline feed titles based on feed name if favicon color is not available 6 years ago
Andrew Dolgov 721f9ad866 requestIdleCallback: remove hard dependency for now 6 years ago
Andrew Dolgov f3c04fc5d8 sync modified scores via mutation observer 6 years ago
Andrew Dolgov 25ca144bb7 score: get correct classes for rows/score icons on the client 6 years ago
Andrew Dolgov fd6f3e7f07 syncModified: request counters once after all xhr promises resolve 6 years ago
Andrew Dolgov 36f3299ddf use window.requestIdleCallback to sync observed modifications 6 years ago
Andrew Dolgov ad5a43bf66 sync article selected status via mutation observer
remove all rchk-related hacks
6 years ago
Andrew Dolgov d9bf0f17c6 sync unread state to server via mutation observer 6 years ago
Andrew Dolgov e5efde26ac sync marked and published states to server via mutation observer 6 years ago
Andrew Dolgov 6616c7cf67 keep track of selected prompt and floating title status using headline row mutation observer 6 years ago
Andrew Dolgov f96cdb7d5d renderAgain flag fixes 6 years ago
Andrew Dolgov 109910424c renderAgain: restore marked/published flags 6 years ago
Andrew Dolgov 54f02a3b31 add Headlines.renderAgain() to switch between combined/expanded modes faster 6 years ago
Andrew Dolgov 95e1038e6d consistency: show author in multipanel headlines row 6 years ago
Andrew Dolgov 42780ddeb3 in grouped mode, don't display feed titles twice 6 years ago
Andrew Dolgov 302cffb1a7 catchupFeedInGroup: better icon 6 years ago
Andrew Dolgov dc84e10ba1 catchupFeedInGroup: overhaul
1. less hacky way to catchup actually unread headlines
2. don't fade rows away because it's inconsistent with different mark-as-read functions
3. fix stuck progress alert
6 years ago
Andrew Dolgov fa538a6c86 implement year-week sorting window if headlines buffer is grouped by feed titles 6 years ago
Andrew Dolgov a0d332326c add PluginHost.HOOK_HEADLINE_RENDERED 6 years ago
Andrew Dolgov bd66a9ef28 render article on the client using headlines data 6 years ago
Andrew Dolgov d1efcb7fc0 cdm: put originally_from into footer 6 years ago
Andrew Dolgov 6e30af755c viewfeed: bring back comments prompt 6 years ago
Andrew Dolgov 76885fc5ad viewfeed: general code cleanup 6 years ago
Andrew Dolgov 8f75b06835 implement feed grouping display, remove unneeded server vgrlf passing 6 years ago
Andrew Dolgov 9d2caaefe7 viewfeed: show originally from... 6 years ago
Andrew Dolgov 20d460296d fix unread hl styling 6 years ago
Andrew Dolgov e075e6141b json-viewfeed updates 6 years ago
Andrew Dolgov 249c93a228 initial for js templates 6 years ago
Andrew Dolgov 7b0f4f1e46 updateFloatingTitle: marginRight correction no longer needed 6 years ago
Andrew Dolgov 7a276f9898 updateFloatingTitle: add safety offset to hide/show because mozilla can't into math 6 years ago
Andrew Dolgov c4b01dd547 updateFloatingTitle: sync row marked/published status 6 years ago
Andrew Dolgov 75666ac7ab Headlines.click: clicking in body of currently active cdm article should mark
it as read, otherwise it's not possible without a kb shortcut or auto catchup
6 years ago
Andrew Dolgov 7805b291b6 update floating title in toggleUnread functions post-xhr 6 years ago
Andrew Dolgov db3c7d2050 remove floating title appear animation for now 6 years ago
Andrew Dolgov f33cd597be selectionToggleUnread: remove loading... prompt (other similar methods don't have it) 6 years ago
Andrew Dolgov e7adc7e471 Merge branch 'master' into material-icons 6 years ago
Andrew Dolgov 7edcf6c45f ctrlclick in combined mode shouldn't open two windows 6 years ago
Andrew Dolgov 2dac797704 floatingTitle-related fixes 6 years ago
Andrew Dolgov b65d8384c2 update headlines to use vector icons 6 years ago
Andrew Dolgov e42d25a361 revert to previous headline ctrl-click behavior (open in new window, mark read) 6 years ago
Andrew Dolgov 05200a3840 rename main toolbar elements to be more consistent 6 years ago
Andrew Dolgov 9814ac608c Headlines.click: do not set article active if it already is
Headlines.onLoaded: reset active article if not called in append mode
6 years ago
Andrew Dolgov 7e7a15136b Headlines.onRowChecked: fix undefined row 6 years ago
Andrew Dolgov 4a0b644f61 Headlines.onRowChecked: fix possible desync in checkbox and row selected state 6 years ago
Andrew Dolgov 84affc7b1d rework dojo singleton modules to better work with phpstorm completion (ugh) - declare() is not needed there anyway
remove event.observe from login form (not needed)
load pluginhost via amd
6 years ago
Andrew Dolgov 5ead558e43 move Utils to AppBase where it belongs 6 years ago
Andrew Dolgov ac8361e6f6 add AppBase as a shared ancestor for main and prefs app objects
remove event.observe stuff from startup, unneeded
6 years ago
Andrew Dolgov 526389b2d3 update notify_* calls to use Notify 6 years ago
Andrew Dolgov f89924f7a1 set use strict on JS modules; remove some mostly useless stuff like get_minified_js() 6 years ago
Andrew Dolgov 807ff07454 split main objects to dojo modules 6 years ago