Commit Graph

988 Commits (93111b3bd7bd211ca05fbe7403b3b3baf465e988)

Author SHA1 Message Date
Aleksander Machniak 32e5a6bbcf Fix bug where folder creation could fail if personal namespace contained more than one entry (#5403)
+ small code improvements
8 years ago
Aleksander Machniak 43f3c5fb2a Implement "one click" attachment upload (#5024) 8 years ago
Aleksander Machniak c65bb121eb Describe Framework requirements, drop some redundant code (since we require mbstring) 8 years ago
Aleksander Machniak 9debc38724 Drop mail_header_delimiter option, since we don't use mail() we don't need it 8 years ago
Aleksander Machniak 184de7735c CS fixes (mostly phpdoc) 8 years ago
Aleksander Machniak 2298ecf7f6 Fix E_DEPRECATED warning when using Auth_SASL::factory() (#5401) 8 years ago
Aleksander Machniak 0836b213db Removed useless 'created' column from 'session' table (#5389) 8 years ago
Aleksander Machniak 94f8ce3334 Make html::parse_attrib_string() more robust
Fixes PHP Error: Expression parse error on: ($app->config->get('preview_pane',rcube_utils::get_boolean('')) == true ? ' checked=checked' : ')
8 years ago
Aleksander Machniak 062d95503e Fix bug where Message-ID domain part was tied to username instead of current identity (#5385) 8 years ago
Aleksander Machniak 55cdf1569e Support contact+group searches in all relevant places (T1360)
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.
8 years ago
DanCld ee00d949c4 Properly set the memcache debug log file name
Properly set the debug log file name ('memcache') as $this->type is undefined
8 years ago
Aleksander Machniak 53b5ccfb0c Fix regression where LDAP results could be counted incorrectly when using VLV
... broken by d08bd0a51f where we added searching in users+groups in one request
8 years ago
Aleksander Machniak dcabc1d814 Merge remote-tracking branch 'upstream/master'
Conflicts:
	tests/Framework/Washtml.php
8 years ago
Aleksander Machniak c3fc072d97 Remove code related to magic_quotes_* and register_globals
...they do not exist in PHP 5.4 which we now require.
8 years ago
Aleksander Machniak 906cf101c3 Better time handling in rcube_utils::clean_datestr() 8 years ago
Aleksander Machniak ec1525a1e6 Remove debug code 8 years ago
Aleksander Machniak ed35267b9b Managesieve: Fix parsing of vacation date-time with non-default date_format (#5372)
Added new method rcube_utils::format_datestr() to convert date_format date
into ISO date format.
8 years ago
Aleksander Machniak 2f2765ab43 Fix regression in resizing JPEG images with Imagick (#5376) 8 years ago
Aleksander Machniak d91bad5975 Fix handling of blockquote tags with mixed case on html2text conversion (#5363) 8 years ago
Aleksander Machniak 7a7a6795f0 Support WEBP images in mail messages (#5362) 8 years ago
Aleksander Machniak 6626328e7c We already require PEAR, so it's not needed to check if PEAR class exists.
Sooner or later it will fail if PEAR does not exist, so better to do this sooner.
8 years ago
Aleksander Machniak edfd9da42a Support MathML in HTML message preview (#5182) 8 years ago
Aleksander Machniak ee895a2c96 Remove PHP mail() support, smtp_server is required now (#5340) 8 years ago
Aleksander Machniak e13deb2e47 Merge branch 'master' of github.com:roundcube/roundcubemail 8 years ago
Aleksander Machniak 930e363e55 Fix handling of 'mailto' and 'error' arguments in message_before_send hook (#5347) 8 years ago
Aleksander Machniak d2d4f867e5 Merge pull request #5350 from demis-palma/fix-encoding
Fixed wrong encoding in currency symbols
8 years ago
Aleksander Machniak dc6cfe1eec Merge pull request #5351 from fliespl/patch-1
Remove use of deprecated method Imagick::flattenImages
8 years ago
Aleksander Machniak 9a2264ba0e Fix regression where messages with no text part (but e.g. application/zip) were not displayed as an attachment (#5357) 8 years ago
fliespl 10c032165b Remove deprecated function flattenImages
flattenImages in imagick is deprecated since php 5.6. 
`PHP Deprecated:  Imagick::flattenImages method is deprecated and it's use should be avoided `


Proposed solution works with imagick 3.1.0+.
11 is used as an alternative to `Imagick::ALPHACHANNEL_REMOVE` which was added in imagick 3.2.0.
8 years ago
Demis Palma 411bd3fe82 Fixed wrong encoding in currency symbols 8 years ago
Aleksander Machniak 997e82d2b2 Merge pull request #5326 from raoulbhatia/autoload
Translate PHP namespaces into directories
8 years ago
dsoares 8e7e22c656 Avoid PHP fatal error
After last change to file `rcube_ldap.php`, my roundcube instance was getting this error:
```
PHP Fatal error:  Cannot use object of type Net_LDAP3_Result as array in ...
```
In
```php
protected function extended_search($count = false)
```
`$result = $this->ldap->search()` returns a LDAP object (whatever package we use).
If the search returns no results (and if `$is_extended_search` is false), then it gets to line 971 trying to do a `usort()` and then a `count()` on an object, instead of an array.
8 years ago
Aleksander Machniak c08ca018d8 Get rid of rcube_imap_generic::strToTime() in favor of rcube_utils::strtotime() 8 years ago
Raoul Bhatia 7122df719d Translate PHP namespaces into directories 9 years ago
Aleksander Machniak d08bd0a51f Searching in both contacts and groups when LDAP addressbook with group_filters option is used 9 years ago
Aleksander Machniak 22241a5d82 CS fixes 9 years ago
Aleksander Machniak 58c036116b Support type=password in rcube_output::get_edit_field() 9 years ago
Aleksander Machniak f2eafda539 Fix bug where microsecond format in logged date didn't work in some cases 9 years ago
Aleksander Machniak 5e1277e971 Trim error message 9 years ago
Aleksander Machniak f840abe6e0 Don't add HTTP response body/headers to the spellchecker error message (it is displayed to the user) 9 years ago
Aleksander Machniak c478536741 Make SQL selects less expensive in memory for some cases where we fetch big data chunks 9 years ago
Aleksander Machniak c76c4ed08b Workaround PHP issue by calling closelog() on script shutdown when using log_driver=syslog (#5289) 9 years ago
Aleksander Machniak d61d33a12a Fix handling of --delete argument in moduserprefs.sh script (#5296) 9 years ago
Aleksander Machniak f466899d8d Simplified code 9 years ago
Aleksander Machniak 7864a98f08 Fix searching by email address in contacts with multiple addresses (#5291) 9 years ago
Aleksander Machniak 6737e293bb Wash position:fixed style in HTML mail for better security (#5264) 9 years ago
Aleksander Machniak 0ce7c493a8 Fix multi-folder search issues in "this and subfolders" scope (#5282, #5259)
- Fix bug where multi-folder search could choose a wrong folder
- Fix bug where multi-folder search didn't work for unsubscribed INBOX
9 years ago
Aleksander Machniak 930a3ceac0 Fix bug where errors could have been not logged when per_user_logging=true 9 years ago
Aleksander Machniak 3d0d5dbd0f Performance improvements in format_flowed() and unfold_flowed() 9 years ago
Aleksander Machniak afd090672c Small performance optimization 9 years ago
Aleksander Machniak 6652367d65 Fix XSS issue in href attribute on area tag (#5240, #5241) 9 years ago
Aleksander Machniak 4921c21cff Optimize SELECT response handling 9 years ago
Aleksander Machniak 344b0af9c6 Indicate that a collapsed thread has flagged children (#5013) 9 years ago
Aleksander Machniak 9796cd2063 Merge branch 'dev-rfc822-preview'
Conflicts:
	CHANGELOG
	program/steps/mail/show.inc
9 years ago
Aleksander Machniak 9634169647 Bump version number to 1.3-beta 9 years ago
Aleksander Machniak 0eece8222b Fix autoloading of 'html' class and improve autoloader performance 9 years ago
Aleksander Machniak 5e406f7b7e Disable links list when converting html2text for spellchecking 9 years ago
Aleksander Machniak 52106ffd39 Fix bug where rcube_contacts::get_record() could return cached result when requested record wasn't found (#5218) 9 years ago
Aleksander Machniak e2e56261b9 Fix handling of long script/style tags when converting to text 9 years ago
Aleksander Machniak a0f38f5fd8 Small code style improvements 9 years ago
Aleksander Machniak e8ab3d96bd Fix converting mail addresses with @www. into mailto links (#5197) 9 years ago
Aleksander Machniak d01c06eded CS fixes 9 years ago
Bostjan Skufca 70a8236cd5 mailbox/listing: Make server response for large mailbox listing faster when using threaded view
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.

Mailbox index view timing:    ~360 ms
Mailbox threaded view timing: ~800 ms

Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.

This optimization is already present in index view handler, but was missing
from threaded view.

Results after optimization
==========================
Both average out around ~360 ms response time.
9 years ago
Bernardo Silva c72446a8fc Allow pattern attribute in input
"pattern" included in the list of allowed attributes in the input tag
9 years ago
Aleksander Machniak 6f2c007d1b CS fixes: Replace use of "bool ? true : false" with just "bool" 9 years ago
Aleksander Machniak 5c253dd59e Fix so SPECIAL-USE assignments are forced only until user sets special folders (#4782)
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
9 years ago
Aleksander Machniak 7462095f60 Small code improvements 9 years ago
Aleksander Machniak e8b6e726f6 Add message menu with viewsource and edit actions in message/rfc822 preview 9 years ago
Aleksander Machniak ce3105c58f Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview 9 years ago
Aleksander Machniak 323fa20bc8 Message/rfc822 attachment preview (#5054) 9 years ago
Aleksander Machniak 05972d7b33 Refer to Github issues instead of Trac 9 years ago
Aleksander Machniak 791ee65d2e Fix so contactlist_fields option can be set via config file 9 years ago
Aleksander Machniak 348ec70f12 Export vCard PHOTO with "ENCODING=b" (instead of "ENCODING=B") as specified in RFC2426 9 years ago
Thomas Bruederli 4a408843b0 Protect download urls against CSRF using unique request tokens (#1490642)
Send X-Frame-Options headers with every HTTP response
9 years ago
Aleksander Machniak d4df3748cf Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix) 9 years ago
Aleksander Machniak ca34ba139e CS fixes 9 years ago
Aleksander Machniak 4c0cb96a48 Enigma: Fix missing html/plain switch on multipart/signed messages (#1490649) 9 years ago
Aleksander Machniak e91c35c534 Fix background color on selected and focused addressbook 9 years ago
Aleksander Machniak 8dc756f319 Fix bug in long recipients list parsing for cases where recipient name contained @-char (#1490653) 9 years ago
Aleksander Machniak 53fa08d8ae Enigma: Code refactoring with better handling of encrypted-inside-encrypted (e.g. forwarded) and signed+ncrypted messages 9 years ago
Aleksander Machniak c9e2ab488e Enigma: Fix handling of encrypted + signed messages (#1490632) 9 years ago
Aleksander Machniak 0e77b6f1b3 Fix regression where xml mode could be used to parse xhtml messages causing empty result 9 years ago
Aleksander Machniak bffca14d96 Exit when imagecreatetruecolor() fails 9 years ago
Aleksander Machniak 22a018d082 Merge branch 'dev-svg' 9 years ago
Aleksander Machniak ed1d212ae2 Improved SVG cleanup code 9 years ago
Aleksander Machniak 023d3eb031 Refactor wash_attribs() - fix regressions 9 years ago
Aleksander Machniak d5f7490b08 Fix PHP Fatal error: Can't use function return value in write context 9 years ago
Thomas B 66d4ef6e31 Merge pull request #316 from namesco/prevent-blank-contactnames
Ensure roundcube doesn't render contact names as blank
9 years ago
Aleksander Machniak a1fdb205f8 Extend rcube_washtml with SVG support 9 years ago
Francis Russell 8f71b164fd Make TLS method for IMAP parameterisable. 9 years ago
Francis Russell 191a6a6805 Enable use of TLSv1.1 and TLSv1.2 for IMAP. 9 years ago
James Buncle fd0244dabf Ensure roundcube doesn't render contact names as blank (when the name is whitespace) 9 years ago
Aleksander Machniak 4e1aa60c16 Make possible to disable authentication via rcube_smtp::connect() arguments (#1490621) 9 years ago
Aleksander Machniak 39137fe292 CS fixes 9 years ago
Aleksander Machniak d72e5afb47 Fix PHP7 warning "session_start(): Session callback expects true/false return value" (#1490624) 9 years ago
Aleksander Machniak 6521c20768 Add INBOX to the list of folders only if no filter and no prefix was specified 9 years ago
Aleksander Machniak cd219a45dd Fix regression where some message attachments could be missing on edit/forward (#1490608) 9 years ago
Aleksander Machniak be346095a0 Fix handling of message/rfc822 attachments on replies and forwards (#1490607) 9 years ago
Aleksander Machniak 3296965f41 Force arg_separator in http_build_query() 9 years ago
Aleksander Machniak 87cb24d873 Don't add redundant URL arguments to logged error messages 9 years ago
Aleksander Machniak cbe701ac4a Fix rcube_utils::words_match() to work with mixed/invalid/binary content (T844) 9 years ago
Aleksander Machniak 7e3298753a Use ternary operator where aplicable 9 years ago
Aleksander Machniak a15d877ba8 Added brute-force attack prevention via login rate limit (#1490566) 9 years ago
Aleksander Machniak 454b0b1ca9 Remove deprecated rcmail and rcube_imap methods 9 years ago
Aleksander Machniak 9234903287 Fix HTML sanitizer to skip <!-- node type X --> in output (#1490583) 9 years ago
Aleksander Machniak eca19d65b5 Optimized some regular expressions 9 years ago
Aleksander Machniak 2ff3385788 Fix warning when enchant_broker_list_dicts() does not return an array 9 years ago
Aleksander Machniak 91dc7fabbc Small improvements in HTML to text conversion.
Better handling of <body> and trailing spaces, and </p><div> or <br><div>.
9 years ago
Aleksander Machniak c8c4cafb1f Add possibility to define date format in write operations for ldap attributes (#1488741) 9 years ago
Aleksander Machniak a03233ceba CS fixes 9 years ago
Aleksander Machniak 354cff8b26 Some more CS fixes 9 years ago
Aleksander Machniak 7fb0aedc9b Fix fetchMIMEHeaders() so it really works with multiple parts, various CS fixes 9 years ago
Aleksander Machniak b813011902 Remove unused property 9 years ago
Aleksander Machniak 85f4209074 Code improvements: CS fixes, improved internal cache cleanup on folder selection, removed redundant cache 9 years ago
Aleksander Machniak aada285660 Simplify change_subscription() code, removed unused vars 9 years ago
Aleksander Machniak 6a94f69bd1 Remove code for Mail_mime<1.9, we already require Mail_mime-1.10 for other reasons 9 years ago
Aleksander Machniak 0ee57208b3 Add possibility to set PDO::ATTR_PREFETCH and PDO::ATTR_TIMEOUT via DSN string 9 years ago
Aleksander Machniak 1b61a48eec Get rid of mb_check_encoding() before mb_convert_encoding() for better performance, CS fixes 9 years ago
Aleksander Machniak 83345af059 Log charset conversion warning only when no function was found, not when the string was invalid 9 years ago
Aleksander Machniak 7d71c48952 s/RCMAIL_VERSION/RCUBE_VERSION/ 9 years ago
Aleksander Machniak 7bbb86f78a Session read handler must return a string in PHP7 9 years ago
Aleksander Machniak b2b9b591ce Fix handling random_bytes() errors in PHP 7.0.0RC3 9 years ago
Aleksander Machniak df0b4f3437 Make sure an email address is valid when replacing it with mailto: link 9 years ago
Thomas Bruederli db390a27fb Do not tokenize search string when querying in strict mode (#1490504) 9 years ago
Aleksander Machniak fef8537adb Improved multi-folder search performance on sort order change or list page change
by proper index serialization and skipped redundant sorting
9 years ago
Thomas Bruederli f7f75ff7d1 Unify detection of pgp/mime message part 9 years ago
Aleksander Machniak e85bbc9e9c random_bytes() can throw an exception in some cases, since PHP 7.0.0rc3 9 years ago
Aleksander Machniak 63e7937d02 Change so rcube_message class does not depend on $_GET parameters 9 years ago
Aleksander Machniak 26086981a2 Improve randomness of security tokens (#1490529) 9 years ago
Aleksander Machniak f75bc5c24b Use random security tokens instead of hashes based on encryption key (#1490404) 9 years ago
Aleksander Machniak e4c66080a8 Improved encrypt/decrypt methods with option to choose the cipher_method (#1489719) 9 years ago
Aleksander Machniak 4c53e78915 Fix printing required ini options values in error message 9 years ago
Aleksander Machniak 427ab2f393 Optimize folder_size() on Cyrus IMAP by using special folder annotation (#1490514) 9 years ago
Aleksander Machniak 5eb9c70b60 Added method to determine IMAP server vendor, for future use 9 years ago
Aleksander Machniak 86b241df63 CS fixes 9 years ago
Aleksander Machniak 4ceff8f353 Make optional hidding of folders with name starting with a dot - imap_skip_hidden_folders (#1490468) 9 years ago
Aleksander Machniak f00e1f5333 CS fixes 9 years ago
Aleksander Machniak 6f249b0e38 Change code so versions of Mail_mime before and after 1.9.0 are supported 9 years ago
Aleksander Machniak 7a42173a16 Simplify rcube_utils::check_ip() 9 years ago
Aleksander Machniak 6b31846c43 Fix IPv6 address validation on PHP with disabled IPv6 support 9 years ago
Aleksander Machniak f4c512336d Fix "washing" of style elements wrapped into many lines 9 years ago
Thomas B. cf69daf896 Merge pull request #288 from ThijsFeryn/fnnonempty
Emptying the display name when the display name is the main e-mail ad…
9 years ago
Aleksander Machniak 559e5d7bd4 Fix unintentional error_reporting change 9 years ago
Aleksander Machniak 36bd93f138 PHP7: Fixed some E_WARNING errors that previously were E_STRICT 9 years ago
Aleksander Machniak a7efdd7c5d Make Mail_mime>=1.9.0 a requirement, fix compat. errors 9 years ago
Aleksander Machniak 1b8ca08e5b Added GSSAPI/Kerberos authentication plugin - krb_authentication 9 years ago
Aleksander Machniak 0868c2e841 Make sure list page is never set to 0 (#1490458)
This should fix the issue where after message move wrong message was
added to the list and the list counter was invalid.
9 years ago
Aleksander Machniak 5ed8ade763 Fix bug where some plugins could be initialized more than one time 9 years ago
Aleksander Machniak 93e64008a6 Small code improvements 9 years ago
Aleksander Machniak c21f95f626 Fix bug where new messages weren't added to the list in search mode 9 years ago