4f5ec65a36
Close SMTP connection ASAP after the message has been sent
...
We should not keep the connection open until the script shuts down.
It may take long time e.g. to save the message in IMAP.
8 years ago
a99e479cb4
Fix variable substitution in ldap host for some use-cases, e.g. new_user_identity ( #5544 )
8 years ago
32b68959b2
Merge branch 'master' of github.com:roundcube/roundcubemail
8 years ago
a1f679adca
Fixed redundancy in sql caching system and compatibility with Galera Cluster ( #5439 )
...
- Removed redundant 'created' column from cache and cache_shared tables
- Removed use of redundant data records
- Added missing primary keys (dictionary, cache, cache_shared tables)
8 years ago
940a27400e
Use GSSAPI only if configured ( #5530 )
8 years ago
5cca1988b6
Fix write_log() return value when using syslog() and it fails
8 years ago
a844db6a27
Merge branch 'dev-layouts'
8 years ago
8a76bf3783
Make sure $prefs property is an array ( #5523 )
8 years ago
e306328340
Fix storing "empty" values in rcube_cache/rcube_cache_shared ( #5519 )
8 years ago
7e90de4ef5
write_record() should return boolean value
8 years ago
68221ed4ae
Improve uppercase/lowercase/ucfirst attrib handling in rcube::gettext()
...
- Make ucfirst mode compatible with UTF-8
- Fix bug which made uppercase=FIRST non-working
- Replace \n with real line-break before converting char case
8 years ago
6e0effa54c
Fix "Illegal string offset" warning in rcube::log_bug() on PHP 7.1 ( #5508 )
8 years ago
e17e8851f1
CS improvements, _xor() method replaced with an anonymous function
8 years ago
556c1725a7
Unify automatic marking as \Seen in preview pane, full-page and extwin views ( #5071 )
...
We now have one 'mail_read_time' option that works for all cases.
Option 'preview_pane_mark_read' has been removed and marked as an alias.
8 years ago
f43f5bf93f
Use JSON_PRETTY_PRINT in devel_mode
...
This effectively makes PHP 5.4 a real requirement
8 years ago
4e0532808d
Fix bug where it wasn't possible to store more that 2MB objects in memcache/apc ( #5452 )
...
Added memcache_max_allowed_packet and apc_max_allowed_packet settings
8 years ago
cf9f0d8829
Fix bug where IMAP password could be exposed via error message ( #5472 )
8 years ago
b8f9ba7d47
Fix bug where deleting folders with subfolders could fail in some cases ( #5466 )
8 years ago
b258b91560
Do not show inline images of unsupported mimetype ( #5463 )
8 years ago
8a51607671
Fix regression where creation of default folders wasn't functioning without prefix ( #5460 )
8 years ago
9e129383a1
Improve randomness of password salts and random hashes ( #5266 )
8 years ago
195dc11855
Support host-specific imap_conn_options/smtp_conn_options/managesieve_conn_options ( #5136 )
8 years ago
8c75dd3aa8
Add convenient method to create new session records
8 years ago
42ddfe5ec9
Simplify mbstring code path in rcube_charset::convert()
8 years ago
c1c0a0d815
Implemented rcube::sleep() method for disconnecting all external connection in long-running/sleeping scripts
8 years ago
f92052fd73
Fix so when moving to Trash we make sure the folder exists ( #5192 )
8 years ago
2999cc38a5
Generate more compact HTML5 code, e.g. use short form of boolean attributes
8 years ago
defdf84bb7
Really fix login form regression
...
Remove 'form' from allowed attributes list of input field. We needed
it only for a moment, now we don't. It's also not supported by IE/Edge
which means there's no way we would need it. Maybe some day...
8 years ago
32e5a6bbcf
Fix bug where folder creation could fail if personal namespace contained more than one entry ( #5403 )
...
+ small code improvements
8 years ago
43f3c5fb2a
Implement "one click" attachment upload ( #5024 )
8 years ago
c65bb121eb
Describe Framework requirements, drop some redundant code (since we require mbstring)
8 years ago
9debc38724
Drop mail_header_delimiter option, since we don't use mail() we don't need it
8 years ago
184de7735c
CS fixes (mostly phpdoc)
8 years ago
2298ecf7f6
Fix E_DEPRECATED warning when using Auth_SASL::factory() ( #5401 )
8 years ago
0836b213db
Removed useless 'created' column from 'session' table ( #5389 )
8 years ago
94f8ce3334
Make html::parse_attrib_string() more robust
...
Fixes PHP Error: Expression parse error on: ($app->config->get('preview_pane',rcube_utils::get_boolean('')) == true ? ' checked=checked' : ')
8 years ago
062d95503e
Fix bug where Message-ID domain part was tied to username instead of current identity ( #5385 )
8 years ago
55cdf1569e
Support contact+group searches in all relevant places (T1360)
...
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.
8 years ago
ee00d949c4
Properly set the memcache debug log file name
...
Properly set the debug log file name ('memcache') as $this->type is undefined
8 years ago
53b5ccfb0c
Fix regression where LDAP results could be counted incorrectly when using VLV
...
... broken by d08bd0a51f
8 years ago
dcabc1d814
Merge remote-tracking branch 'upstream/master'
...
Conflicts:
tests/Framework/Washtml.php
8 years ago
c3fc072d97
Remove code related to magic_quotes_* and register_globals
...
...they do not exist in PHP 5.4 which we now require.
8 years ago
906cf101c3
Better time handling in rcube_utils::clean_datestr()
8 years ago
ec1525a1e6
Remove debug code
8 years ago
ed35267b9b
Managesieve: Fix parsing of vacation date-time with non-default date_format ( #5372 )
...
Added new method rcube_utils::format_datestr() to convert date_format date
into ISO date format.
8 years ago
2f2765ab43
Fix regression in resizing JPEG images with Imagick ( #5376 )
8 years ago
d91bad5975
Fix handling of blockquote tags with mixed case on html2text conversion ( #5363 )
8 years ago
7a7a6795f0
Support WEBP images in mail messages ( #5362 )
8 years ago
6626328e7c
We already require PEAR, so it's not needed to check if PEAR class exists.
...
Sooner or later it will fail if PEAR does not exist, so better to do this sooner.
8 years ago
edfd9da42a
Support MathML in HTML message preview ( #5182 )
8 years ago
ee895a2c96
Remove PHP mail() support, smtp_server is required now ( #5340 )
8 years ago
e13deb2e47
Merge branch 'master' of github.com:roundcube/roundcubemail
8 years ago
930e363e55
Fix handling of 'mailto' and 'error' arguments in message_before_send hook ( #5347 )
8 years ago
d2d4f867e5
Merge pull request #5350 from demis-palma/fix-encoding
...
Fixed wrong encoding in currency symbols
8 years ago
dc6cfe1eec
Merge pull request #5351 from fliespl/patch-1
...
Remove use of deprecated method Imagick::flattenImages
8 years ago
9a2264ba0e
Fix regression where messages with no text part (but e.g. application/zip) were not displayed as an attachment ( #5357 )
8 years ago
10c032165b
Remove deprecated function flattenImages
...
flattenImages in imagick is deprecated since php 5.6.
`PHP Deprecated: Imagick::flattenImages method is deprecated and it's use should be avoided `
Proposed solution works with imagick 3.1.0+.
11 is used as an alternative to `Imagick::ALPHACHANNEL_REMOVE` which was added in imagick 3.2.0.
8 years ago
411bd3fe82
Fixed wrong encoding in currency symbols
9 years ago
997e82d2b2
Merge pull request #5326 from raoulbhatia/autoload
...
Translate PHP namespaces into directories
9 years ago
8e7e22c656
Avoid PHP fatal error
...
After last change to file `rcube_ldap.php`, my roundcube instance was getting this error:
```
PHP Fatal error: Cannot use object of type Net_LDAP3_Result as array in ...
```
In
```php
protected function extended_search($count = false)
```
`$result = $this->ldap->search()` returns a LDAP object (whatever package we use).
If the search returns no results (and if `$is_extended_search` is false), then it gets to line 971 trying to do a `usort()` and then a `count()` on an object, instead of an array.
9 years ago
c08ca018d8
Get rid of rcube_imap_generic::strToTime() in favor of rcube_utils::strtotime()
9 years ago
7122df719d
Translate PHP namespaces into directories
9 years ago
d08bd0a51f
Searching in both contacts and groups when LDAP addressbook with group_filters option is used
9 years ago
22241a5d82
CS fixes
9 years ago
58c036116b
Support type=password in rcube_output::get_edit_field()
9 years ago
f2eafda539
Fix bug where microsecond format in logged date didn't work in some cases
9 years ago
5e1277e971
Trim error message
9 years ago
f840abe6e0
Don't add HTTP response body/headers to the spellchecker error message (it is displayed to the user)
9 years ago
c478536741
Make SQL selects less expensive in memory for some cases where we fetch big data chunks
9 years ago
c76c4ed08b
Workaround PHP issue by calling closelog() on script shutdown when using log_driver=syslog ( #5289 )
9 years ago
d61d33a12a
Fix handling of --delete argument in moduserprefs.sh script ( #5296 )
9 years ago
f466899d8d
Simplified code
9 years ago
7864a98f08
Fix searching by email address in contacts with multiple addresses ( #5291 )
9 years ago
6737e293bb
Wash position:fixed style in HTML mail for better security ( #5264 )
9 years ago
0ce7c493a8
Fix multi-folder search issues in "this and subfolders" scope ( #5282 , #5259 )
...
- Fix bug where multi-folder search could choose a wrong folder
- Fix bug where multi-folder search didn't work for unsubscribed INBOX
9 years ago
930a3ceac0
Fix bug where errors could have been not logged when per_user_logging=true
9 years ago
3a2874c77c
Remove check for multiple dots in local-part
9 years ago
0e809364e7
Support SMTPUTF8, relax email restrictions
...
If the FROM/TO portions of an email use non-ASCII characters,
check that the SMTP server supports the SMTPUTF8 extension.
Additionally, change some rules for parsing email addresses to
allow for more characters. Basically, SMTPUTF8 states that
nearly any printable character is a valid character in an
email address.
9 years ago
3d0d5dbd0f
Performance improvements in format_flowed() and unfold_flowed()
9 years ago
afd090672c
Small performance optimization
9 years ago
6652367d65
Fix XSS issue in href attribute on area tag ( #5240 , #5241 )
9 years ago
4921c21cff
Optimize SELECT response handling
9 years ago
344b0af9c6
Indicate that a collapsed thread has flagged children ( #5013 )
9 years ago
9796cd2063
Merge branch 'dev-rfc822-preview'
...
Conflicts:
CHANGELOG
program/steps/mail/show.inc
9 years ago
9634169647
Bump version number to 1.3-beta
9 years ago
0eece8222b
Fix autoloading of 'html' class and improve autoloader performance
9 years ago
5e406f7b7e
Disable links list when converting html2text for spellchecking
9 years ago
52106ffd39
Fix bug where rcube_contacts::get_record() could return cached result when requested record wasn't found ( #5218 )
9 years ago
e2e56261b9
Fix handling of long script/style tags when converting to text
9 years ago
a0f38f5fd8
Small code style improvements
9 years ago
e8ab3d96bd
Fix converting mail addresses with @www. into mailto links ( #5197 )
9 years ago
d01c06eded
CS fixes
9 years ago
70a8236cd5
mailbox/listing: Make server response for large mailbox listing faster when using threaded view
...
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.
Mailbox index view timing: ~360 ms
Mailbox threaded view timing: ~800 ms
Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.
This optimization is already present in index view handler, but was missing
from threaded view.
Results after optimization
==========================
Both average out around ~360 ms response time.
9 years ago
c72446a8fc
Allow pattern attribute in input
...
"pattern" included in the list of allowed attributes in the input tag
9 years ago
6f2c007d1b
CS fixes: Replace use of "bool ? true : false" with just "bool"
9 years ago
5c253dd59e
Fix so SPECIAL-USE assignments are forced only until user sets special folders ( #4782 )
...
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
9 years ago
7462095f60
Small code improvements
9 years ago
e8b6e726f6
Add message menu with viewsource and edit actions in message/rfc822 preview
9 years ago
ce3105c58f
Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview
9 years ago
323fa20bc8
Message/rfc822 attachment preview ( #5054 )
9 years ago
05972d7b33
Refer to Github issues instead of Trac
9 years ago
791ee65d2e
Fix so contactlist_fields option can be set via config file
9 years ago
348ec70f12
Export vCard PHOTO with "ENCODING=b" (instead of "ENCODING=B") as specified in RFC2426
9 years ago
4a408843b0
Protect download urls against CSRF using unique request tokens ( #1490642 )
...
Send X-Frame-Options headers with every HTTP response
9 years ago
d4df3748cf
Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix)
9 years ago
ca34ba139e
CS fixes
9 years ago
4c0cb96a48
Enigma: Fix missing html/plain switch on multipart/signed messages ( #1490649 )
9 years ago
e91c35c534
Fix background color on selected and focused addressbook
9 years ago
8dc756f319
Fix bug in long recipients list parsing for cases where recipient name contained @-char ( #1490653 )
9 years ago
53fa08d8ae
Enigma: Code refactoring with better handling of encrypted-inside-encrypted (e.g. forwarded) and signed+ncrypted messages
9 years ago
c9e2ab488e
Enigma: Fix handling of encrypted + signed messages ( #1490632 )
9 years ago
0e77b6f1b3
Fix regression where xml mode could be used to parse xhtml messages causing empty result
9 years ago
bffca14d96
Exit when imagecreatetruecolor() fails
9 years ago
22a018d082
Merge branch 'dev-svg'
9 years ago
ed1d212ae2
Improved SVG cleanup code
9 years ago
023d3eb031
Refactor wash_attribs() - fix regressions
9 years ago
d5f7490b08
Fix PHP Fatal error: Can't use function return value in write context
9 years ago
66d4ef6e31
Merge pull request #316 from namesco/prevent-blank-contactnames
...
Ensure roundcube doesn't render contact names as blank
9 years ago
a1fdb205f8
Extend rcube_washtml with SVG support
9 years ago
8f71b164fd
Make TLS method for IMAP parameterisable.
9 years ago
191a6a6805
Enable use of TLSv1.1 and TLSv1.2 for IMAP.
9 years ago
fd0244dabf
Ensure roundcube doesn't render contact names as blank (when the name is whitespace)
9 years ago
4e1aa60c16
Make possible to disable authentication via rcube_smtp::connect() arguments ( #1490621 )
9 years ago
39137fe292
CS fixes
9 years ago
d72e5afb47
Fix PHP7 warning "session_start(): Session callback expects true/false return value" ( #1490624 )
9 years ago
6521c20768
Add INBOX to the list of folders only if no filter and no prefix was specified
9 years ago
cd219a45dd
Fix regression where some message attachments could be missing on edit/forward ( #1490608 )
9 years ago
be346095a0
Fix handling of message/rfc822 attachments on replies and forwards ( #1490607 )
9 years ago
3296965f41
Force arg_separator in http_build_query()
9 years ago
87cb24d873
Don't add redundant URL arguments to logged error messages
9 years ago
cbe701ac4a
Fix rcube_utils::words_match() to work with mixed/invalid/binary content (T844)
9 years ago
7e3298753a
Use ternary operator where aplicable
9 years ago
a15d877ba8
Added brute-force attack prevention via login rate limit ( #1490566 )
9 years ago
454b0b1ca9
Remove deprecated rcmail and rcube_imap methods
9 years ago
9234903287
Fix HTML sanitizer to skip <!-- node type X --> in output ( #1490583 )
9 years ago
eca19d65b5
Optimized some regular expressions
9 years ago
2ff3385788
Fix warning when enchant_broker_list_dicts() does not return an array
9 years ago
91dc7fabbc
Small improvements in HTML to text conversion.
...
Better handling of <body> and trailing spaces, and </p><div> or <br><div>.
9 years ago
c8c4cafb1f
Add possibility to define date format in write operations for ldap attributes ( #1488741 )
9 years ago
a03233ceba
CS fixes
9 years ago
354cff8b26
Some more CS fixes
9 years ago
7fb0aedc9b
Fix fetchMIMEHeaders() so it really works with multiple parts, various CS fixes
9 years ago
b813011902
Remove unused property
9 years ago
85f4209074
Code improvements: CS fixes, improved internal cache cleanup on folder selection, removed redundant cache
9 years ago
aada285660
Simplify change_subscription() code, removed unused vars
9 years ago
6a94f69bd1
Remove code for Mail_mime<1.9, we already require Mail_mime-1.10 for other reasons
9 years ago
0ee57208b3
Add possibility to set PDO::ATTR_PREFETCH and PDO::ATTR_TIMEOUT via DSN string
9 years ago
1b61a48eec
Get rid of mb_check_encoding() before mb_convert_encoding() for better performance, CS fixes
9 years ago
83345af059
Log charset conversion warning only when no function was found, not when the string was invalid
9 years ago
7d71c48952
s/RCMAIL_VERSION/RCUBE_VERSION/
9 years ago
7bbb86f78a
Session read handler must return a string in PHP7
9 years ago
b2b9b591ce
Fix handling random_bytes() errors in PHP 7.0.0RC3
9 years ago
df0b4f3437
Make sure an email address is valid when replacing it with mailto: link
9 years ago
db390a27fb
Do not tokenize search string when querying in strict mode ( #1490504 )
9 years ago
fef8537adb
Improved multi-folder search performance on sort order change or list page change
...
by proper index serialization and skipped redundant sorting
9 years ago
f7f75ff7d1
Unify detection of pgp/mime message part
9 years ago
e85bbc9e9c
random_bytes() can throw an exception in some cases, since PHP 7.0.0rc3
9 years ago
63e7937d02
Change so rcube_message class does not depend on $_GET parameters
9 years ago
26086981a2
Improve randomness of security tokens ( #1490529 )
9 years ago
f75bc5c24b
Use random security tokens instead of hashes based on encryption key ( #1490404 )
9 years ago
e4c66080a8
Improved encrypt/decrypt methods with option to choose the cipher_method ( #1489719 )
9 years ago
4c53e78915
Fix printing required ini options values in error message
9 years ago
427ab2f393
Optimize folder_size() on Cyrus IMAP by using special folder annotation ( #1490514 )
9 years ago
5eb9c70b60
Added method to determine IMAP server vendor, for future use
9 years ago
86b241df63
CS fixes
9 years ago
4ceff8f353
Make optional hidding of folders with name starting with a dot - imap_skip_hidden_folders ( #1490468 )
9 years ago
f00e1f5333
CS fixes
9 years ago
6f249b0e38
Change code so versions of Mail_mime before and after 1.9.0 are supported
9 years ago
7a42173a16
Simplify rcube_utils::check_ip()
9 years ago
6b31846c43
Fix IPv6 address validation on PHP with disabled IPv6 support
9 years ago
f4c512336d
Fix "washing" of style elements wrapped into many lines
9 years ago
cf69daf896
Merge pull request #288 from ThijsFeryn/fnnonempty
...
Emptying the display name when the display name is the main e-mail ad…
9 years ago
559e5d7bd4
Fix unintentional error_reporting change
9 years ago
36bd93f138
PHP7: Fixed some E_WARNING errors that previously were E_STRICT
9 years ago
a7efdd7c5d
Make Mail_mime>=1.9.0 a requirement, fix compat. errors
9 years ago
1b8ca08e5b
Added GSSAPI/Kerberos authentication plugin - krb_authentication
9 years ago
0868c2e841
Make sure list page is never set to 0 ( #1490458 )
...
This should fix the issue where after message move wrong message was
added to the list and the list counter was invalid.
9 years ago
5ed8ade763
Fix bug where some plugins could be initialized more than one time
9 years ago
93e64008a6
Small code improvements
9 years ago
c21f95f626
Fix bug where new messages weren't added to the list in search mode
9 years ago
6c7be218f7
Revert create_folder() behaviour change where the method didn't fail if folder already existed.
...
This should not be the default behaviour. It could likely
become an optional functionality, however we should keep the method simple.
9 years ago
9d78c68cbf
Fix so imap folder attribute comparisons are case-insensitive ( #1490466 )
...
+ make in_array_nocase() much faster for ASCII strings
9 years ago
58f6f19505
Emptying the display name when the display name is the main e-mail address contradicts lines 731 till 734
9 years ago
b71eef6d7d
Don't use private properties of Net_SMTP object
9 years ago
9335f9cede
Reset internal cache index in close()
9 years ago
e2bceaefe6
Support more secure hashing algorithms for auth cookie - configurable by PHP's session.hash_function ( #1490403 )
9 years ago
843643b1bd
Fix multi-folder search result sorting by arrival date ( #1490450 )
9 years ago
212e332cef
Get rid of array_walk() when simple foreach() can be used
10 years ago
d2890372c1
Fix Fatal error after last commit
10 years ago
6a8c4fc73b
Fix issue when first search() argument is not an array
10 years ago
8447bae77c
Require Mbstring and OpenSSL extensions ( #1490415 ) - remove redundant code
10 years ago
f7427f151e
Get rid of Mail_mimeDecode package dependency ( #1490416 )
10 years ago
9aae1b7fc3
Fix so microseconds macro (u) in log_date_format works ( #1490446 )
10 years ago
25c8fe4eeb
Fix handling of non-break spaces in html to text conversion ( #1490436 )
10 years ago
b92a66b3ee
Make has_(html|text)_part and first_(html|text)_part methods consistent in arguments and functionality
10 years ago
36a7f57345
Modify rcube_smtp::send_mail() so it is possible to send message by
...
specifying only the message stream no headers, it's for cases when
the stream already contains a complete message.
10 years ago
ff40683404
Fix so links with href == content aren't added to links list on html to text conversion ( #1490434 )
10 years ago
26a00e76be
Fix race-condition in saving user preferences and loading plugin config ( #1490431 )
10 years ago
a958748947
CS fixes
10 years ago
d375b20225
Suppress E_DEPRECATED errors after change in [ 4ab77dd1]
10 years ago
Aleksander Machniak