52106ffd39
Fix bug where rcube_contacts::get_record() could return cached result when requested record wasn't found ( #5218 )
9 years ago
12756e2297
Autocomplete: store last searched-for string into separate variable for later consumption
...
Reason:
Autocompleting person contacts works as expected - ksearch_value is available and passed to triggerEvent.
But with group autocomplete, ksearch_value is reset (to null) and triggerEvent call lacks necessary data.
9 years ago
f919e8ffa6
Autocomplete: change type from 'contact' to 'person' to sync with what is expected from LDAP.
...
Explanation:
Alternative would be to leave type empty, as it is when contact comes form SQL source.
But this feels overly ambiguous and may cause problems in the future.
9 years ago
1791c3e3d7
Autocomplete/frontend: provide functions that hook into 'autocomplete_insert' actual search and result data
...
Reason:
In order to enable development of sophisticated autocomplete algorithms, they will need
to process all the data relevant to autocomplete - what was the search string and which
result was the correct one.
Example to illustrate the need:
Say we are talking about these two people of interest, who are in the address book, among others:
- person 1: Bostjan Skufca <bostjan@a2o.si>
- person 2: Bostjan SkuBIC <bostjan@otherdomain.com>
Our user is used to think about the first person by the first name, "Bostjan", as he is an old friend.
The second one is a colleague at work where people call themselves mostly by surnames, "Skubic" in this case.
Without this data provided to 'autocomplete_insert', there is no way for RC to learn that when our user
enters "bos" in the To: field he thinks about person #1 (Bostjan SkuFCA), and when he starts typing "sku"
he means person #2 (Bostjan SkuBIC).
9 years ago
05c7d49a37
Autocomplete search: add id and source (addressbook) into resulting contact data array
...
Two reasons:
- provide it to plugin backend functions that use 'contacts_autocomplete_after' hook
- provide it to frontend
Why to frontend?
If plugin JS adds an 'autocomplete_insert' hook we need to provide it with exact
autocomplete data. Providing it with name and email address only, without pinpointing
exact origin of this autocomplete result, will severely limit learning capabilities of
potential future autocomplete implementations.
9 years ago
a15b2d5998
Autocomplete refactoring: replace variable name '$id' with '$abook_id'
...
Reason:
Having genericly named variable $id in nested loops makes code unreadable.
Replacing generic name '$id' with '$ENTITIY_id' format removes all ambiguity.
9 years ago
ed55af4aa9
Autocomplete: trigger "contacts_autocomplete_after" hook processing
...
Provide existing list of contact suggestions as an argument - it might be unclear
now what logic plugin developers decide to implement, but data for that logic
should be provided upfront, and that includes list of suggestions that RC
itself comes up with.
Plugin logic might then replace the list entirely, or just rearrange its entries, or use
part of the list when it runs out of own ideas, or do something entirely different.
9 years ago
865230e420
Autocomplete: fix undefined variable notice if no addressbook is configured for autocomplete
9 years ago
e2e56261b9
Fix handling of long script/style tags when converting to text
9 years ago
a0f38f5fd8
Small code style improvements
9 years ago
e8ab3d96bd
Fix converting mail addresses with @www. into mailto links ( #5197 )
9 years ago
d01c06eded
CS fixes
9 years ago
70a8236cd5
mailbox/listing: Make server response for large mailbox listing faster when using threaded view
...
Symptom
=======
When using roundcube with mailboxes with over 60k messages, list
view was way faster than viewing in threaded view.
Mailbox index view timing: ~360 ms
Mailbox threaded view timing: ~800 ms
Resolution
==========
Use native PHP array manipulation functions instead of rolling custom
string data reversal implementation using strpos() and substr() in a
'while' loop.
This optimization is already present in index view handler, but was missing
from threaded view.
Results after optimization
==========================
Both average out around ~360 ms response time.
9 years ago
4fdcd8c9d1
Remove redundant code
9 years ago
c72446a8fc
Allow pattern attribute in input
...
"pattern" included in the list of allowed attributes in the input tag
9 years ago
6f2c007d1b
CS fixes: Replace use of "bool ? true : false" with just "bool"
9 years ago
5c253dd59e
Fix so SPECIAL-USE assignments are forced only until user sets special folders ( #4782 )
...
The old behaviour where SPECIAL-USE has always a prio can be bringed back
by setting lock_special_folders=false and adding it to dont_override.
9 years ago
aba88576ef
Update localizations
9 years ago
7462095f60
Small code improvements
9 years ago
46f7b70964
Enable reply/reply-all/forward buttons also in preview frame of message/rfc822
9 years ago
e8b6e726f6
Add message menu with viewsource and edit actions in message/rfc822 preview
9 years ago
d125f864ea
Message/rfc822 previewer compatibility with Enigma
9 years ago
640e5e265d
Enigma: Handle encrypted/signed content inside message/rfc822 attachments
9 years ago
4e6f3019f5
Enigma: Handle encrypted/signed content inside message/rfc822 attachments
9 years ago
ce3105c58f
Reply/Reply-All/Forward/Change-format buttons for message/rfc822 preview
9 years ago
323fa20bc8
Message/rfc822 attachment preview ( #5054 )
9 years ago
1db4c05078
Fix: Set long email addresses
...
The changes permit to set long email address up to the maximum permissible length.
9 years ago
05972d7b33
Refer to Github issues instead of Trac
9 years ago
791ee65d2e
Fix so contactlist_fields option can be set via config file
9 years ago
348ec70f12
Export vCard PHOTO with "ENCODING=b" (instead of "ENCODING=B") as specified in RFC2426
9 years ago
3a13b5dab8
CS fixes
9 years ago
0c9e55b0c9
Fix PHP warning when defaults.inc.php is not readable
9 years ago
bf91666621
Revert "Update to jQuery 2.2.1"
...
This reverts commit 940b966fac
9 years ago
4a408843b0
Protect download urls against CSRF using unique request tokens ( #1490642 )
...
Send X-Frame-Options headers with every HTTP response
9 years ago
d4df3748cf
Require Net_Socket >= 1.0.12 (because of timeout=0 bugfix)
9 years ago
ca34ba139e
CS fixes
9 years ago
940b966fac
Update to jQuery 2.2.1
9 years ago
b0a8e36930
Fix handling of body parameter in mail compose request
9 years ago
faeeebdc55
Hide DSN option in Preferences when smtp_server is not used ( #1490666 )
9 years ago
9ae41d906e
Fix unicode-awareness of Base64 encoding implementation in javascript
9 years ago
8bbb454524
Fix list row selection when provided uid is number not a string
9 years ago
a62ff159f0
Performance: Make sure that after contact update we call get_record() only once
9 years ago
d686b57c72
Fix bug where contacts widget in compose could be incorrectly initialized with treelist widget (T998)
...
Fix typo in command name (list-adresses -> list-addresses)
9 years ago
4c0cb96a48
Enigma: Fix missing html/plain switch on multipart/signed messages ( #1490649 )
9 years ago
e91c35c534
Fix background color on selected and focused addressbook
9 years ago
332ffef199
Plugin API: Added addressbook_export hook
9 years ago
8dc756f319
Fix bug in long recipients list parsing for cases where recipient name contained @-char ( #1490653 )
9 years ago
c10eae0884
Fix bug where Archive/Junk buttons were not active after page jump with select=all mode ( #1490647 )
9 years ago
53fa08d8ae
Enigma: Code refactoring with better handling of encrypted-inside-encrypted (e.g. forwarded) and signed+ncrypted messages
9 years ago
c9e2ab488e
Enigma: Fix handling of encrypted + signed messages ( #1490632 )
9 years ago
0e77b6f1b3
Fix regression where xml mode could be used to parse xhtml messages causing empty result
9 years ago
bffca14d96
Exit when imagecreatetruecolor() fails
9 years ago
22a018d082
Merge branch 'dev-svg'
9 years ago
ed1d212ae2
Improved SVG cleanup code
9 years ago
023d3eb031
Refactor wash_attribs() - fix regressions
9 years ago
558a6db27e
Fix headers encoding when using 'valueof' mode
9 years ago
d5f7490b08
Fix PHP Fatal error: Can't use function return value in write context
9 years ago
66d4ef6e31
Merge pull request #316 from namesco/prevent-blank-contactnames
...
Ensure roundcube doesn't render contact names as blank
9 years ago
72c250ca67
Merge pull request #317 from FrancisRussell/imap-tls
...
Enable use of TLSv1.1 and TLSv1.2 for IMAP.
9 years ago
9aaeb23d9d
Fix HTML entities encoding in message headers output
9 years ago
a1fdb205f8
Extend rcube_washtml with SVG support
9 years ago
8f71b164fd
Make TLS method for IMAP parameterisable.
9 years ago
191a6a6805
Enable use of TLSv1.1 and TLSv1.2 for IMAP.
9 years ago
0bde1c2e4d
Fix missing language name in "Add to Dictionary" request in HTML mode ( #1490634 )
9 years ago
fd0244dabf
Ensure roundcube doesn't render contact names as blank (when the name is whitespace)
9 years ago
4e1aa60c16
Make possible to disable authentication via rcube_smtp::connect() arguments ( #1490621 )
9 years ago
40d7342dd9
Fix XSS issue in SVG images handling ( #1490625 )
9 years ago
39137fe292
CS fixes
9 years ago
d72e5afb47
Fix PHP7 warning "session_start(): Session callback expects true/false return value" ( #1490624 )
9 years ago
d08dc5bfc5
Fix so drag-n-drop of text (e.g. recipient addresses) on compose page actually works ( #1490619 )
9 years ago
10e5192a2b
Fix path traversal vulnerability in setting a skin ( #1490620 )
9 years ago
6521c20768
Add INBOX to the list of folders only if no filter and no prefix was specified
9 years ago
3b36bcfb68
Cleanup
9 years ago
0d9fa7f3dc
Remove redundant code
9 years ago
cd219a45dd
Fix regression where some message attachments could be missing on edit/forward ( #1490608 )
9 years ago
c3be175ce7
Fix PDF support detection in Firefox > 19 ( #1490610 )
9 years ago
be346095a0
Fix handling of message/rfc822 attachments on replies and forwards ( #1490607 )
9 years ago
bb6002f1a8
Fix also charset encoding of message/rfc822 part bodies ( #1490606 )
9 years ago
3296965f41
Force arg_separator in http_build_query()
9 years ago
87cb24d873
Don't add redundant URL arguments to logged error messages
9 years ago
f51145572a
Merge branch 'master' of github.com:roundcube/roundcubemail
9 years ago
6463b662ca
Fix regression in displaying contents of message/rfc822 parts ( #1490606 )
9 years ago
97aa984b29
Optionally throw 404 error when contact photo wasn't found
9 years ago
69a1e4f7b1
rcube_parse_host() -> rcube_utils::parse_host()
9 years ago
cbe701ac4a
Fix rcube_utils::words_match() to work with mixed/invalid/binary content (T844)
9 years ago
7476410a04
Add missing deprecation warning
9 years ago
458a6b26e8
Load bc.inc in script startup
9 years ago
32695c333c
Restore bc.inc which now logs a warning when calling deprecated functions
9 years ago
310d4939ba
Tweak recently added encryption functions to not violate ECMASCRIPT3 syntax
9 years ago
8271597836
Use ternary operator where applicable
9 years ago
648963afda
Added Talossan language to index
9 years ago
e257b830a1
Synchronize localizations from Transifex
9 years ago
7e3298753a
Use ternary operator where aplicable
9 years ago
a15d877ba8
Added brute-force attack prevention via login rate limit ( #1490566 )
9 years ago
7caa9f5f50
Fix error on dragging when search in treelist is active
9 years ago
454b0b1ca9
Remove deprecated rcmail and rcube_imap methods
9 years ago
9234903287
Fix HTML sanitizer to skip <!-- node type X --> in output ( #1490583 )
9 years ago
3b0318ca3e
Fix race-condition in setting current page between list and getunread requests
9 years ago
bcd3799954
Fix redundant blank lines when using HTML and top posting ( #1490576 )
9 years ago
2aa9ee56fd
Fix so disabling emoticons plugin really removes emoticons button from HTML editor
9 years ago
eb721e35b2
Update to TinyMCE 4.2
9 years ago
bc3518577d
Fix some more Q -> rcube::Q
9 years ago
234fd19505
Replace deprecated call to Q within array_map()
9 years ago
74ce01efc7
Q() -> rcube::Q()
9 years ago
eca19d65b5
Optimized some regular expressions
9 years ago
8f8beafd56
Use .get_label() consistently (instead of .gettext())
9 years ago
5d84dd6de5
Deduplicate code of http_post() and http_request(), add http_get() alias
9 years ago
2ff3385788
Fix warning when enchant_broker_list_dicts() does not return an array
9 years ago
a5c03db798
Security: Added options to validate username/password on logon ( #1490500 )
9 years ago
c1bbf0d0b6
After failed login wait a second to slow down brute-force attacks ( #1490549 )
9 years ago
fddfd8e6d7
Remove backward compatibility "layer" of bc.php ( #1490534 )
9 years ago
91dc7fabbc
Small improvements in HTML to text conversion.
...
Better handling of <body> and trailing spaces, and </p><div> or <br><div>.
9 years ago
92bcb940d4
Fix bug where HTML messages with invalid/excessive css styles couldn't be displayed ( #1490539 )
...
Technically speaking we remove the whole CSS content when it has more than 5k lines.
9 years ago
fe8ff85d7e
Move skin-specific code for compose encryption button to the skin
9 years ago
f1e7bbd1bd
Fix bug where message preview was unintentionally reset on check-recent action ( #1490563 )
9 years ago
d9ff47b011
Don't use deprecated (soon) jQuery .bind() and .unbind() methods
9 years ago
c8c4cafb1f
Add possibility to define date format in write operations for ldap attributes ( #1488741 )
9 years ago
bb1ed2740d
Display attachment size in compose ( #1484774 )
9 years ago
d560916065
Added possibility to drag-n-drop attachments from mail preview to compose window
9 years ago
5802e08e48
Mail messages searching with predefined date interval (T103)
9 years ago
a03233ceba
CS fixes
9 years ago
1484d5fb7f
Fix resetting search input events when the treelist is re-initialized, some CS improvements
9 years ago
e524680a13
Fix 'last' property of search event
9 years ago
354cff8b26
Some more CS fixes
9 years ago
7fb0aedc9b
Fix fetchMIMEHeaders() so it really works with multiple parts, various CS fixes
9 years ago
b813011902
Remove unused property
9 years ago
85f4209074
Code improvements: CS fixes, improved internal cache cleanup on folder selection, removed redundant cache
9 years ago
aada285660
Simplify change_subscription() code, removed unused vars
9 years ago
6a94f69bd1
Remove code for Mail_mime<1.9, we already require Mail_mime-1.10 for other reasons
9 years ago
2a6cf5bb0e
Fix responses list update issue after response name change ( #1490555 )
9 years ago
0ee57208b3
Add possibility to set PDO::ATTR_PREFETCH and PDO::ATTR_TIMEOUT via DSN string
9 years ago
1b61a48eec
Get rid of mb_check_encoding() before mb_convert_encoding() for better performance, CS fixes
9 years ago
83345af059
Log charset conversion warning only when no function was found, not when the string was invalid
9 years ago
7d71c48952
s/RCMAIL_VERSION/RCUBE_VERSION/
9 years ago
82dcbb7488
Fix various issues in Mailvelope integration ( #1490533 )
9 years ago
7bbb86f78a
Session read handler must return a string in PHP7
9 years ago
b2b9b591ce
Fix handling random_bytes() errors in PHP 7.0.0RC3
9 years ago
b95a6d8f41
Disable some toolbar buttons if Mailvelope editor is active ( #1490533 )
9 years ago
0b6a01380b
Distinguish encryption toolbar buttons (Mailvelope and Enigma)
9 years ago
df0b4f3437
Make sure an email address is valid when replacing it with mailto: link
9 years ago
db390a27fb
Do not tokenize search string when querying in strict mode ( #1490504 )
9 years ago
4cd087ea2e
Fixed mailvelope-generated messages structure (required Mail_Mime-1.10.0)
9 years ago
e250f00d90
Fix PHP warnings when sending mailvelope-encrypted mail
9 years ago
8716fca0d0
Small improvements
9 years ago
fef8537adb
Improved multi-folder search performance on sort order change or list page change
...
by proper index serialization and skipped redundant sorting
9 years ago
f7f75ff7d1
Unify detection of pgp/mime message part
9 years ago
f189d72943
Merged branch 'dev-mailvelope'
9 years ago
91ef2c812a
Small code improvement
9 years ago
e85bbc9e9c
random_bytes() can throw an exception in some cases, since PHP 7.0.0rc3
9 years ago
77be69fa25
Fix issue where Content-Length of some attachments could be set to wrong value causing browser errors ( #1490482 )
9 years ago
63e7937d02
Change so rcube_message class does not depend on $_GET parameters
9 years ago
c49234bd78
Fix bug where clicking date column with 'arrival' sorting would switch to sorting by 'date' ( #1490126 )
9 years ago
dd7db21797
Fix XSS issue in drag-n-drop file uploads ( #1490530 )
9 years ago
26086981a2
Improve randomness of security tokens ( #1490529 )
9 years ago
f75bc5c24b
Use random security tokens instead of hashes based on encryption key ( #1490404 )
9 years ago
e4c66080a8
Improved encrypt/decrypt methods with option to choose the cipher_method ( #1489719 )
9 years ago
fdbb1c95ea
Fix missing HTTP_X_FORWARDED_FOR address in generated Received header
9 years ago
91018f38d4
Fix so In-Reply-To header is set also for MDN receipts ( #1490523 )
9 years ago
4c53e78915
Fix printing required ini options values in error message
9 years ago
e2f605d44d
Fallback to C locale
9 years ago
3c29c7e858
Fix various issues with Turkish (and similar) locales ( #1490519 )
9 years ago
399a2d68b6
Make optional adding of standard signature separator - sig_separator ( #1487768 )
9 years ago
427ab2f393
Optimize folder_size() on Cyrus IMAP by using special folder annotation ( #1490514 )
9 years ago
5eb9c70b60
Added method to determine IMAP server vendor, for future use
9 years ago
4d36da83b2
Fix support for Mozilla-based browsers, e.g. Pale Moon ( #1490517 )
9 years ago
c4daf3f14f
Fix regression in converting signatures to text, fixed PHP warning in html2text() call
9 years ago
86b241df63
CS fixes
9 years ago
4ceff8f353
Make optional hidding of folders with name starting with a dot - imap_skip_hidden_folders ( #1490468 )
9 years ago
6ca1e6add1
Add option to enable HTML editor always, except when replying to plain text messages ( #1489365 )
9 years ago
87d6d214f9
Fix disabled_buttons option
9 years ago
a63f14ec40
Emoticons-related code refactoring
...
- Emoticons: All emoticons-related functionality is handled by the plugin now
- Emoticons: Added option to switch on/off emoticons in compose editor (#1485732 )
- Emoticons: Added option to switch on/off emoticons in plain text messages
- Plugin API: Added disabled_plugins an disabled_buttons options in html_editor hook
- Plugin API: Added html2text hook
9 years ago
3516b02344
Fix so adding CC/BCC recipients from the sidebar unhides compose form fields in Classic skin ( #1490472 )
9 years ago
8297ea1dcf
Fix handling of plus character in mailto: links ( #1490510 )
9 years ago
f00e1f5333
CS fixes
9 years ago
bd82e9551f
Fix so css of one html part does not apply to other text parts on message display ( #1490505 )
9 years ago
7417893c22
Fix closing of nested menus ( #1490443 )
9 years ago
60ab554003
Remove common subject prefixes Re:, Re[x]:, Re-x: on reply ( #1490497 )
9 years ago
6f249b0e38
Change code so versions of Mail_mime before and after 1.9.0 are supported
9 years ago
3fa3f156ca
Don't display not-sent-warning in compose page on save-pref action
9 years ago
c4383b5f3d
Fix selecting a folder on collapse when any subfolder is selected
9 years ago
284aac2883
Really make base64 encoding unicode-aware
9 years ago
c16ac71416
Fix base64.encode/decode for unicode characters - use fallback if btoa/atob functions fail
9 years ago
7a42173a16
Simplify rcube_utils::check_ip()
9 years ago
6b31846c43
Fix IPv6 address validation on PHP with disabled IPv6 support
9 years ago
c360e178c4
Fix so input field (e.g. search box) does not loose focus on list load ( #1490455 )
9 years ago
f4c512336d
Fix "washing" of style elements wrapped into many lines
9 years ago
cf69daf896
Merge pull request #288 from ThijsFeryn/fnnonempty
...
Emptying the display name when the display name is the main e-mail ad…
9 years ago
6c69e3d3ed
Add localization alias for tr => tr_TR
9 years ago
559e5d7bd4
Fix unintentional error_reporting change
9 years ago
36bd93f138
PHP7: Fixed some E_WARNING errors that previously were E_STRICT
9 years ago
a7efdd7c5d
Make Mail_mime>=1.9.0 a requirement, fix compat. errors
9 years ago
1b8ca08e5b
Added GSSAPI/Kerberos authentication plugin - krb_authentication
9 years ago
92649075ec
CS fixes
9 years ago
0868c2e841
Make sure list page is never set to 0 ( #1490458 )
...
This should fix the issue where after message move wrong message was
added to the list and the list counter was invalid.
9 years ago
5ed8ade763
Fix bug where some plugins could be initialized more than one time
9 years ago
93e64008a6
Small code improvements
9 years ago
4f6b660433
Thunderbird (fi_FI) support for csv2vcard
9 years ago
08bb20f261
Don't use deprecated functions/constants (from bc.inc)
9 years ago
9fc6918420
Disable links list generation on html-to-text conversion of identities or composed message ( #1490437 )
9 years ago
8449e936f3
Fix removing signature when switching to identity with an empty sig in HTML mode ( #1490470 )
9 years ago
Aleksander Machniak