Fix file disclosure vulnerability caused by insuficient input validation in relation with attachment plugins (#6026)

pull/6036/head
Aleksander Machniak 7 years ago
parent 0f4f85e097
commit 2a32f51c91

@ -84,6 +84,8 @@ class database_attachments extends filesystem_attachments
if ($args['data'] === false) { if ($args['data'] === false) {
return $args; return $args;
} }
$args['path'] = null;
} }
$data = base64_encode($args['data']); $data = base64_encode($args['data']);
@ -130,10 +132,13 @@ class database_attachments extends filesystem_attachments
$cache = $this->get_cache(); $cache = $this->get_cache();
$data = $cache->read($args['id']); $data = $cache->read($args['id']);
if ($data) { if ($data !== null && $data !== false) {
$args['data'] = base64_decode($data); $args['data'] = base64_decode($data);
$args['status'] = true; $args['status'] = true;
} }
else {
$args['status'] = false;
}
return $args; return $args;
} }

@ -7,12 +7,19 @@
* attachments of messages currently being composed, writing attachments * attachments of messages currently being composed, writing attachments
* to disk when drafts with attachments are re-opened and writing * to disk when drafts with attachments are re-opened and writing
* attachments to disk for inline display in current html compositions. * attachments to disk for inline display in current html compositions.
* It also handles uploaded files for other uses, so not only attachments.
* *
* Developers may wish to extend this class when creating attachment * Developers may wish to extend this class when creating attachment
* handler plugins: * handler plugins:
* require_once('plugins/filesystem_attachments/filesystem_attachments.php'); * require_once('plugins/filesystem_attachments/filesystem_attachments.php');
* class myCustom_attachments extends filesystem_attachments * class myCustom_attachments extends filesystem_attachments
* *
* Note for developers: It is plugin's responsibility to care about security.
* So, e.g. if the plugin is asked about some file path it should check
* if it's really the storage path of the plugin and not e.g. /etc/passwd.
* It is done by setting 'status' flag on every plugin hook it uses.
* Roundcube core will trust the returned path if status=true.
*
* @license GNU GPLv3+ * @license GNU GPLv3+
* @author Ziba Scott <ziba@umich.edu> * @author Ziba Scott <ziba@umich.edu>
* @author Thomas Bruederli <roundcube@gmail.com> * @author Thomas Bruederli <roundcube@gmail.com>
@ -107,7 +114,7 @@ class filesystem_attachments extends rcube_plugin
*/ */
function remove($args) function remove($args)
{ {
$args['status'] = @unlink($args['path']); $args['status'] = $this->verify_path($args['path']) && @unlink($args['path']);
return $args; return $args;
} }
@ -118,7 +125,7 @@ class filesystem_attachments extends rcube_plugin
*/ */
function display($args) function display($args)
{ {
$args['status'] = file_exists($args['path']); $args['status'] = $this->verify_path($args['path']) && file_exists($args['path']);
return $args; return $args;
} }
@ -129,6 +136,10 @@ class filesystem_attachments extends rcube_plugin
*/ */
function get($args) function get($args)
{ {
if (!$this->verify_path($args['path'])) {
$args['path'] = null;
}
return $args; return $args;
} }
@ -147,7 +158,7 @@ class filesystem_attachments extends rcube_plugin
} }
foreach ((array)$files as $filename) { foreach ((array)$files as $filename) {
if(file_exists($filename)) { if (file_exists($filename)) {
unlink($filename); unlink($filename);
} }
} }
@ -182,4 +193,34 @@ class filesystem_attachments extends rcube_plugin
} }
} }
} }
/**
* For security we'll always verify the file path stored in session,
* as session entries can be faked in various ways e.g. #6026.
* We allow only files in Roundcube temp dir
*/
protected function verify_path($path)
{
if (empty($path)) {
return false;
}
$rcmail = rcube::get_instance();
$temp_dir = $rcmail->config->get('temp_dir');
$file_path = pathinfo($path, PATHINFO_DIRNAME);
if ($temp_dir !== $file_path) {
rcube::raise_error(array(
'code' => 403,
'file' => __FILE__,
'line' => __LINE__,
'message' => sprintf("%s can't read %s (not in temp_dir)",
$rcmail->get_user_name(), substr($path, 0, 512))
), true, false);
return false;
}
return true;
}
} }

@ -678,8 +678,9 @@ class rcmail extends rcube
$_SESSION['password'] = $this->encrypt($password); $_SESSION['password'] = $this->encrypt($password);
$_SESSION['login_time'] = time(); $_SESSION['login_time'] = time();
if (isset($_REQUEST['_timezone']) && $_REQUEST['_timezone'] != '_default_') { $timezone = rcube_utils::get_input_value('_timezone', rcube_utils::INPUT_GPC);
$_SESSION['timezone'] = rcube_utils::get_input_value('_timezone', rcube_utils::INPUT_GPC); if ($timezone && is_string($timezone) && $timezone != '_default_') {
$_SESSION['timezone'] = $timezone;
} }
// fix some old settings according to namespace prefix // fix some old settings according to namespace prefix

Loading…
Cancel
Save