Commit Graph

106 Commits (80d30d81e9d99a072872c9a9f0e8f8061486bec1)

Author SHA1 Message Date
David Goodwin b8401e5b48 quotation fix; use double quotes with $ silly (thanks to ksb4ever - #2858717 )
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@719 a1433add-5e2c-0410-b055-b7f2511e0802
15 years ago
David Goodwin dadb8094da try and avoid naming conflicts so put _idx on the end of all postgres indexes
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@667 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 84a5203fe1 list-domain.php:
- replace get_domain_properties() calls with two SQL queries that fetch
  the domain data and count the number of mailboxes and aliases per domain.
  This change speeds up list-domain extremely on setups with lots of domains,
  mailboxes and aliases. The old code took several minutes on my test data
  (that's about 55000 mailboxes and their aliases), the new code only needs
  some seconds.
- $domain_properties now uses the domain name as index key instead of a
  serial number

templates/admin_list-domain.php:
- replace usage of $list_domains with $domain_properties
- change main loop to use the domain name as $domain_properties array key 
  instead of a serial number

upgrade.php:
- upgrade_655(): add index on domain column in mailbox and alias table.
  This speeds up list-domain from 14s to about 1s on my test data in MySQL
  (the 14s were _after_ the changes in list_domain.php)
- added _add_index() function to hide the database specific details in 
  upgrade functions

This commit should fix the performance problems reported on
http://sourceforge.net/forum/forum.php?thread_id=2343349&forum_id=676076



git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@655 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 5ec73b7044 setup.php:
- added form to create setup password hash. It will be displayed if
  a) no setup password is defined yet
  b) the "lost password" link was clicked
- moved checks for empty and too short passwort into check_setup_password()
- added an optional $lostpw_mode parameter to check_setup_password() which
  causes slightly different behaviour (enforces generation of new hash, even
  if the password would match)
- changed check_password_setup() return value to array($error, $message)
- moved displaying $tMessage above the form - it is more useful there.
- removed "see config.inc.php" notice from password field in "create superadmin" 
  form - this hint doesn't help much with the hashed password ;-)
- TODO: The if statements to decide which form to display is quite difficult
  (and will become unreadable in case we need another form ;-)
  We should think about a better way to select the form to display...
  (maybe flash_error / flash_info + redirect?)

upgrade.php:
- added missing <p> tag


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@648 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 84cd5ddfcd upgrade.php: see tdiehl on irc.. perhaps this fixes his problem (i hate mysql)
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@514 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin b6c2be4976 upgrade.php: fix mysql alter table add columns to only take place if hte field does not exist
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@511 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 926a774bbf upgrade.php: add _mysql_field_exists() so we do not add fields that are already there; fix bugs -hopefully fix errors seen by Tom me@tdiehl.org - see postfixadmin-devel mailing list etc
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@510 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 1c8d6e63e6 upgrade.php: this makes it work for me...
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@509 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 8bab8fa689 upgrade.php: Fixes from Thiago Silva - see https://sourceforge.net/forum/forum.php?thread_id=2789651&forum_id=676076
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@508 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 9eb35175d8 upgrade.php: vain attempt to stop stupid upgrade errors
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@507 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 07ea5c537f 1) remove explicit collation settings; 2) remove vacation_notification_pkey drop thing - see https://sourceforge.net/forum/forum.php?thread_id=2789651&forum_id=676076
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@506 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 2f0047f0bd - upgrade_495_mysql: place local_part field between quota and domain
- upgrade_504_mysql: ensure correct charset for local_part


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@505 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 430b75c853 upgrade.php: bug fix (thanks to matt rude for reporting it. no thanks to me for failing to type!) - see also https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2423106&group_id=191583
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@500 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin ac7fb1f6c9 only add hte ssl field to postgresql dbs if it does not already exist
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@498 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin f658e115b3 upgrade.php: first part of adding support for local_part of a mailboxs address - see https://sourceforge.net/forum/forum.php?thread_id=2343775&forum_id=676076
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@495 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 9d6e060518 bug fix reported by johnjdevine - see http://sourceforge.net/forum/forum.php?thread_id=2644846&forum_id=676076
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@493 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 4b4598c78c upgrade.php: syntax error fix
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@491 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 8f965b747f upgrade.php: see bug 2339963
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@490 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin b66b959925 upgrade.php: use dynamic table names more often - should make postgresql more happy with shcmeas etc
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@487 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz aafc99b23a upgrade.php
- upgrade_483_mysql(): change log.data to TEXT (was VARCHAR) - this fixes 
  problems when changing aliases with lots of targets
  https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1980062&group_id=191583


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@483 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 6a5cd59785 fetchmail.php:
- allow superadmin to create fetchmail entry for any mailbox, not only for himself
  https://sourceforge.net/tracker/index.php?func=detail&aid=2147740&group_id=191583&atid=937964

upgrade.php, fetchmail.php, fetchmail.pl:
- rename fetchmail ssl field to usessl - "ssl" is a reserved word in MySQL and 
  therefore causes various problems (we would need to quote the field name 
  everywhere)
  https://sourceforge.net/tracker/index.php?func=detail&aid=2265333&group_id=191583&atid=937964

languages/*.lang:
- renamed strings for fetchmail (use)ssl field



git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@479 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz fe4c30dfb7 upgrade.php
- fix MySQL syntax error in upgrade_473_mysql (pointed out by int on IRC)


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@477 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 80441baa84 upgrade.php:
- alias.goto was accidently changed to varchar(255) in upgrade_469_mysql.
  Make it a text field again.
  https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2221002&group_id=191583
- renamed upgrade_469_mysql to upgrade_473_mysql to ensure the above 
  change is done



git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@473 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 47f025cbf9 upgrade.php:
- upgrade_469_mysql: fix "illegal mix of collations" by explicitely setting 
  the charset for all VARCHAR and TEXT fields.
  http://sourceforge.net/tracker2/?func=detail&aid=1990191&group_id=191583&atid=937964


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@469 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin 21ff7c17c0 upgrade.php: ensure we cope with config table with a prefix; thanks to AldoReset (IRC); see also https://sourceforge.net/tracker/index.php?func=detail&aid=2084937&group_id=191583&atid=937964
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@452 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
David Goodwin f96609b9ac upgrade.php: fix from zl2tod (via IRC)
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@448 a1433add-5e2c-0410-b055-b7f2511e0802
16 years ago
Christian Boltz 77b3627667 Applying the patch from Stefan Breitegger (tuxstef @SF), see
https://sourceforge.net/tracker/index.php?func=detail&aid=1995478&group_id=191583&atid=937966
+ some small changes

fetchmail.php
- add checkbox to allow setting the fetchmail "ssl" option

fetchmail.pl:
- honor ssl option if set

upgrade.php:
- add ssl column to fetchmail table

*.lang:
- added field name and description for fetchmail ssl option


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@439 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz a553f47a4d upgrade.php:
- upgrade_362_*() renamed to upgrade_438_* to make sure it runs after an
  upgrade from 2.2.x


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@438 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 4117c1a728 remove comment as per cboltz's request etc
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@436 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 0bf3f74f9d upgrade.php
- removed upgrade_300_mysql() which contained duplicated code (see 
  upgrade_362_*) and was placed in the middle of another upgrade function
  @GingerDog: Do we need the 'Constraint "alias_domain_pkey"'? (see comment)
- replace hardcoded 'config' table name with table_by_key('config')
- several whitespace fixes
- use common vim: line


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@435 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin e15068af3a make this upgrade conditional on the row not already being there
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@424 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 6b34e374ef upgrade.php: ensure config table has an initial version entry
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@423 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 582074c8b4 update trunk also; this is a merge of r391 from branches/postfixadmin-2.2.1
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@392 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 380dd1e96e upgrade.php:
- only include common.php if POSTFIXADMIN is not define()d
  Avoids a "already defined" warning in setup.php


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@375 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz d0910c1297 upgrade.php
- upgrade_373_mysql: change domain.description and mailbox.name to utf-8
  https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1972703&group_id=191583


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@374 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 370e8fef6c inital merge of lenix's patch for domain aliasing; I think list-virtual.php needs some attention, but I've run out of time right now; upgrade.php has been updated to create the tables correctly (tested on pgsql and mysql); functionality or php scripts not tested yet
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@363 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 40417e9247 upgrade.php: reindent; fix postgresql fetchmail stuff
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@352 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 31963707b2 upgrade.php:
- create fetchmail table (upgrade_344_mysql)
- TODO: create fetchmail table for pgsql (empty function already included ;-)

fetchmail.php:
- removed CREATE TABLE statement - it's now created by upgrade.php


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@344 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 56b39454cf upgrade.php: fix issue of mysql tables not being created on initial install
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@340 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 36109783fa upgrade.php: fix bug in mysql vacation notification table as reported by gabbs on irc (thanks!)
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@339 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin bb62951377 upgrade.php: support creating PG db if it does nto exist; this means DATABASE_PGSQL.TXT is now obsolete
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@324 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz fedca43854 upgrade.php:
- print query (debug mode) _before_ executing it
- upgrade_318_mysql: include CONSTRAINT in CREATE TABLE - otherwise
  dropping it afterwards fails...


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@319 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 8b1ab537fc upgrade.php:
- creation of vacation_notification table moved to upgrade_318_mysql 
  because the query in upgrade_81_mysql was broken (key length vs. utf8
  charset)
- added upgrade_318_mysql which finally creates a working 
  vacation_notification table
  NOTE: Users who used workarounds to create this table before might
        need to drop it manually before upgrade works.

This should fix 
http://sourceforge.net/tracker/index.php?func=detail&aid=1828857&group_id=191583&atid=937964
and probably also 
http://sourceforge.net/tracker/index.php?func=detail&aid=1875897&group_id=191583&atid=937964


additional minor fixes:
- "create table config" for pgsql now uses table_by_key()
- some whitespace changes
- set default charset (latin1) in upgrade_5_mysql (instead of using
  the system default)


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@318 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 79048b0dfe upgrade.php:
- integrated table creation, based on SVN r1 DATABASE_MYSQL.txt
- added some comments about possible errors that can be ignored
  (I'm dreaming of having an error "whitelist" and displaying 
  all other errors - but not for 2.2 ;-)

DATABASE_MYSQL.TXT
- added up-to-date database setup instructions
- disabled all SQL code (will be deleted later)


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@317 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 7279fb2ac5 upgrade.php: needless echo removed; tested on another PostgreSQL database - worked fine
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@286 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 6c758eb4db upgrade.php: fix pgsql isms - i..e check that fields exist before trying to remove them, likewise for tables; minor syntax fixes in upgrade etc; tested and works for me
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@278 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 36657401c7 upgrade.php: should work for postgresql now
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@277 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin 3c2bf37f4a upgrade.php: implemented some of the postgresql functions; have not tested it yet though
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@271 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 3bbc918ca4 upgrade.php:
- change "edit_alias_state" to "edit_alias_active" in log table (was changed in r90)
  https://sourceforge.net/tracker/index.php?func=detail&aid=1830376&group_id=191583&atid=937964


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@231 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz b54e71f235 - rename placeholder {UTF_8} to the more obvious {UTF-8}
This also fixes my last commit ;-)


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@202 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz f35d0bee7e - completed upgrade_81_mysql() (several changes in vacation table)
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@201 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 096a5ffbe6 - upgrade_90(): replace spaces with underscore in log.action
(change was caused by translatable logging)


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@182 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 29e2d63422 - fixed some SQL syntax errors
- debug output now includes the query


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@175 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz 16178cab58 - next try to expand $Revision$ in upgrade.php :-/
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@174 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
Christian Boltz ce2689dd4f upgrade.php:
- create config table at startup (not nice, but works)
- changed _do_upgrade to use "for ($i = $current_version +1; 
  $i <= $target_version; $i++)" loop and function_exists()
- added support for upgrade_<number>>_mysql() and 
  upgrade_<number>_pgsql() functions for database-specific changes
- added function db_query_parsed(), idea taken from serendipity's 
  include/db/*.php serendipity_db_schema_import()
- added function _drop_index() - MySQL and PgSQL syntax differs too 
  much on this
- added pre-2.1 database updates (DOCUMENTS/TABLE_BACKUP_MX.TXT and
  DOCUMENTS/TABLE_CHANGES.TXT)
- added all database changes between 2.1 and current SVN.
  Everything since the move to sourceforge has the revision number in 
  the function name.

(still several TODOs left)


git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@172 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago
David Goodwin aa919e242d upgrade.php: test edition of a db upgrade script, based loosely around what Drupal uses
git-svn-id: https://svn.code.sf.net/p/postfixadmin/code/trunk@170 a1433add-5e2c-0410-b055-b7f2511e0802
17 years ago