fix phpdoc; throw exception on error within phpunit - helps testing

pull/298/head
David Goodwin 5 years ago
parent f7c7e35b34
commit 4081267cb2

@ -494,10 +494,9 @@ function get_domain_properties($domain) {
/** /**
* create_page_browser * create_page_browser
* Action: Get page browser for a long list of mailboxes, aliases etc. * Action: Get page browser for a long list of mailboxes, aliases etc.
* Call: $pagebrowser = create_page_browser('table.field', 'query', 50) # replaces $param = $_GET['param']
* *
* @param string $idxfield - database field name to use as title * @param string $idxfield - database field name to use as title e.g. alias.address
* @param string $querypart - core part of the query (starting at "FROM") * @param string $querypart - core part of the query (starting at "FROM") e.g. FROM alias WHERE address like ...
* @return array * @return array
*/ */
function create_page_browser($idxfield, $querypart, $sql_params = []) { function create_page_browser($idxfield, $querypart, $sql_params = []) {
@ -1729,6 +1728,9 @@ function db_query($sql, array $values = array(), $ignore_errors = false) {
} catch (PDOException $e) { } catch (PDOException $e) {
$error_text = "Invalid query: " . $e->getMessage() . " caused by " . $sql ; $error_text = "Invalid query: " . $e->getMessage() . " caused by " . $sql ;
error_log($error_text); error_log($error_text);
if(defined('PHPUNIT_TEST')) {
throw new Exception("SQL query failed: {{{$sql}}} with " . json_encode($values) . ". Error message: " . $e->getMessage());
}
if (!$ignore_errors) { if (!$ignore_errors) {
throw new Exception("DEBUG INFORMATION: " . $e->getMessage() . "<br/> Check your error_log for the failed query"); throw new Exception("DEBUG INFORMATION: " . $e->getMessage() . "<br/> Check your error_log for the failed query");
} }

Loading…
Cancel
Save