pull out 100 per page into its own const

master
James Glenn 4 years ago
parent e339246b57
commit db1aaea081

@ -1,7 +1,8 @@
function getContributors(page) { function getContributors(page) {
const PER_PAGE = 100
if (window.jQuery) { if (window.jQuery) {
const container = $('#contributors'); const container = $('#contributors');
jQuery.ajax(`https://api.github.com/repos/mikebryant/ac-nh-turnip-prices/contributors?page=${page}&per_page=100`, {}) jQuery.ajax(`https://api.github.com/repos/mikebryant/ac-nh-turnip-prices/contributors?page=${page}&per_page=${PER_PAGE}`, {})
.done(function (data) { .done(function (data) {
const contributorList = []; const contributorList = [];
data.forEach((contributor, idx) => { data.forEach((contributor, idx) => {
@ -15,8 +16,8 @@ function getContributors(page) {
} }
}); });
container.append(contributorList.join('')); container.append(contributorList.join(''));
// If the length of the data is < 100, we know we are processing the last page of data. // If the length of the data is < PER_PAGE, we know we are processing the last page of data.
if (data.length < 100) return; if (data.length < PER_PAGE) return;
getContributors(page + 1); getContributors(page + 1);
}); });
} }

Loading…
Cancel
Save