pukkandan
8e25d624df
[EmbedSubtitle] Continue even if some files are missing
3 years ago
Paul Wrubel
d75201a873
Use `os.replace` where applicable ( #793 )
...
When using
```py
os.remove(encodeFilename(filename))
os.rename(encodeFilename(temp_filename), encodeFilename(filename))
```
the `os.remove` need not be atomic and so can be executed arbitrarily compared to the immediately following rename call. It is better to use `os.replace` instead
Authored by: paulwrubel
3 years ago
pukkandan
330690a214
[downloader/ffmpeg] Allow passing custom arguments before -i
...
Closes #686
3 years ago
pukkandan
37242e56f2
Fix bug during subtitle conversion
3 years ago
pukkandan
a8731fcc1d
minor bugfixes
...
bugs due to be2fc5b212
, e9f4ccd19e
3 years ago
pukkandan
ad3dc496bb
Misc fixes - See desc
...
* Remove unnecessary uses of _list_from_options_callback
* Fix download tests - Bug from 6e84b21559
* Rename ExecAfterDownloadPP to ExecPP and refactor its tests
* Ensure _write_ytdl_file closes file handle on error - Potential fix for #517
3 years ago
pukkandan
8c0ae192a4
[ffmpeg] Fix `--ffmpeg-location` when directory is given
...
Bug introduced in 89efdc15dd
Closes #654
3 years ago
pukkandan
e9f4ccd19e
Add option `--replace-in-metadata`
3 years ago
pukkandan
c681cb5d93
Allow multiple `--exec` and `--exec-before-download`
3 years ago
pukkandan
89efdc15dd
[ffpmeg] Allow `--ffmpeg-location` to be a file with different name
3 years ago
pukkandan
901130bbcf
Expand and escape environment variables correctly in outtmpl
...
Fixes: https://www.reddit.com/r/youtubedl/comments/otfmq3/ytdlp_same_parameters_different_results
3 years ago
pukkandan
5520aa2dc9
Add option `--exec-before-download`
...
Closes #530
3 years ago
pukkandan
501dd1ad55
[metadatafromfield] Do not detect numbers as field names
...
Related: https://github.com/yt-dlp/yt-dlp/issues/486#issuecomment-877820394
3 years ago
pukkandan
00034c146a
[embedthumbnail] Fix `_get_thumbnail_resolution`
3 years ago
pukkandan
7dde84f3c9
[FFmpegMetadata] Add language of each stream
...
and some refactoring
3 years ago
pukkandan
6606817a86
[utils] Add `variadic`
3 years ago
pukkandan
15a4fd53d3
[thumbnailsconvertor] Treat `jpeg` as `jpg`
3 years ago
pukkandan
e36d50c5dd
[websockets] Add `WebSocketFragmentFD` ( #399 )
...
Necessary for #392
Co-authored by: nao20010128nao, pukkandan
3 years ago
pukkandan
f89b3e2d7a
Skip fixup of existing files and add `--fixup force` to force it
3 years ago
pukkandan
fd7cfb6444
[cleanup] Refactor fixup
3 years ago
pukkandan
e858a9d6d3
[EmbedThumbnail] Add compat-option `embed-thumbnail-atomicparsley`
...
to force use of atomicparsley for embedding thumbnails in mp4
Related: #411
3 years ago
pukkandan
7e87e27c52
[postprocessor] Fix `_restrict_to` when a codec is not set
3 years ago
pukkandan
4d85fbbdbb
Fix bug in 8326b00aab
3 years ago
pukkandan
8326b00aab
Allow `images` formats
...
Necessary for #343 .
* They are identified by `vcodec=acodec='none'`
* These formats show as the worst in `-F`
* Any postprocessor that expects audio/video will be skipped
* `b*` and all related selectors will skip such formats
* This commit also does not add any selector for downloading such formats. They have to be explicitly requested by the `format_id`. Implementation of a selector is left for when #389 is resolved
3 years ago
pukkandan
324ad82006
[utils] Generalize `traverse_dict` to `traverse_obj`
4 years ago
pukkandan
752cda3880
Fix and refactor `prepare_outtmpl`
...
The following tests would have failed previously:
%(id)d %(id)r
%(ext)s-%(ext|def)d
%(width|)d
%(id)r %(height)r
%(formats.0)r
%s
4 years ago
pukkandan
337e0c62f8
[embedthumbnail] Correctly escape filename
...
Closes #352
The approach in [1] is faulty as can be seen in the test cases
1. bff857a8af
4 years ago
pukkandan
885cc0b75c
[embedthumbnail] Embed if any thumbnail was downloaded, not just the best
4 years ago
Oliver Freyermuth
f17c702270
[ard] Allow URLs without `-` before id
...
https://github.com/ytdl-org/youtube-dl/pull/29091
Authored by: olifre
4 years ago
pukkandan
acdecdfaef
[embedthumbnail] Embed in `mp4`/`m4a` using mutagen
...
Code from: https://github.com/ytdl-org/youtube-dl/pull/23525
Co-authored by: tripulse , pukkandan
4 years ago
pukkandan
81a23040eb
[cleanup] Refactor ffmpeg convertors
4 years ago
pukkandan
857f63136d
[videoconvertor] Generalize with remuxer and allow conditional recoding
4 years ago
louie-github
a927acb1ec
[ThumbnailsConvertor] Support conversion to `png` and make it the default ( #333 )
...
PNG, being a lossless format, should be a better default here compared to JPG since we won't be compressing to a lossy format and losing some of the original image data
PNG is also supported for embedding in all the formats similar to JPEG
Authored by: louie-github
4 years ago
pukkandan
28b0eb0f65
[cleanup] See desc
...
* Remove struct from `embedthumbnail`
* Use bullet lists in readme where numbered list don't make sense
* Fix error introduced in 9c2b75b561
when `ie_result` is `None`
4 years ago
pukkandan
95131b2176
[embedthumbnail] Add `flac` support and refactor `mutagen` code
...
https://github.com/ytdl-org/youtube-dl/pull/28894 , https://github.com/ytdl-org/youtube-dl/pull/24310
Authored by: tripulse
4 years ago
pukkandan
2412044c90
Add field `name` for subtitles
...
Co-authored by: pukkandan, tpikonen
Based on: #310 , https://github.com/ytdl-org/youtube-dl/pull/26112
4 years ago
pukkandan
0760b0a7e2
Standardize `write_debug`
4 years ago
pukkandan
4171221823
Add compat-option `no-attach-infojson`
4 years ago
pukkandan
e625be0d10
Improve output template internal formatting
...
* Allow slicing lists/strings using `field.start🔚 step`
* A field can also be used as offset like `field1+num+field2`
* A default value can be given using `field|default`
* Capture all format strings and set it to `None` if invalid. This prevents invalid fields from causing errors
4 years ago
pukkandan
4d224a3022
[embedthumbnail] Fix bug where jpeg thumbnails were converted again
...
Closes #297
4 years ago
pukkandan
a3faeb7de4
[MetadataFromField] Improve regex and add tests
4 years ago
pukkandan
c6ce815461
[Exec] Ensure backward compatibility when the command contains `%`
4 years ago
pukkandan
b31fdeedfd
[documentation] Improvements
4 years ago
pukkandan
8fa43c73d8
Add option `--convert-thumbnails`
...
Closes: https://github.com/yt-dlp/yt-dlp/issues/99 https://github.com/yt-dlp/yt-dlp/issues/102
4 years ago
pukkandan
56d868dbb7
Allow running some `postprocessors` before actual download
4 years ago
pukkandan
9de3ea3126
Pass any field to `--exec` using similar syntax to output template
...
Related: https://github.com/ytdl-org/youtube-dl/issues/28642
4 years ago
pukkandan
84601bb72b
Ability to set a specific field in the file's metadata
...
Eg: `--parse-metadata "description:(?s)(?P<meta_comment>.+)"`
sets the "comment" field using `description`
4 years ago
pukkandan
a3affbe6a0
Release 2021.03.24
4 years ago
pukkandan
143db31d48
Parse metadata from multiple fields
...
Closes #196
4 years ago
pukkandan
beb4b92a66
More consistent warning messages ( #173 )
...
Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>
4 years ago
pukkandan
cd9b384cc3
Embed video URL metadata inside MP4 ( #173 )
...
`mp4` has `comment` and `synopsis`; the synopsis is expected to have the long description
So we save the `webpage_url` to `comment` and `description` to `synopsis`
Related: https://github.com/ytdl-org/youtube-dl/issues/28478
Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>
4 years ago
pukkandan
a94bfd6cfe
[splitchapters] Fix for older ffmpeg
...
Older versions of ffmpeg doesn't allow `-to` as an input option
Closes #180
4 years ago
pukkandan
a515a78dd3
fix some typos and linter
4 years ago
pukkandan
dcf64d43e0
[movefiles] Fix bugs and make more robust
4 years ago
pukkandan
d034ab669c
[sponskrub] Pass proxy to sponskrub
...
Needs atleast sponskrub version:
faissaloo/sponskrub 3.7.0
OR yt-dlp/sponskrub 2021.03.15
4 years ago
pukkandan
7275535116
Split video by chapters ( #158 )
...
* New options `--split-chapters` and `--no-split-chapters`
* The output/path of the split files can be given using the key `chapter`
* Additional keys `section_title`, `section_number`, `section_start`, `section_end` are available in the output template
* Alias `--split-tracks` for parity with animelover/youtube-dl
* `--sponskrub-cut` and `--split-chapter` cannot work together
Closes:
https://github.com/blackjack4494/yt-dlc/issues/277
https://github.com/ytdl-org/youtube-dl/issues/28438
https://github.com/ytdl-org/youtube-dl/issues/12907
https://github.com/ytdl-org/youtube-dl/issues/6480
https://github.com/ytdl-org/youtube-dl/pull/25005
Rewritten from the implementation by: femaref and Wattux
https://github.com/Wattux/youtube-dl/tree/split-at-timestamps
https://github.com/ytdl-org/youtube-dl/pull/25005
https://github.com/femaref/youtube-dl/tree/split-track
4 years ago
pukkandan
ca87974543
[embedthumbnail] Set mtime correctly
...
Related: https://github.com/yt-dlp/yt-dlp/issues/67
4 years ago
pukkandan
e92caff5d5
Refactor (See desc)
...
* Create `FFmpegPostProcessor.real_run_ffmpeg` that can accept multiple input/output files along with switches for each
* Rewrite `cli_configuration_args` and related functions
* Create `YoutubeDL._ensure_dir_exists` - this was previously defined in multiple places
4 years ago
pukkandan
0e0040519b
[embedthumbnail] Fix bug with deleting original thumbnail ( Closes #113 )
...
:ci skip dl
4 years ago
Pccode66
7a5c1cfe93
Completely change project name to yt-dlp ( #85 )
...
* All modules and binary names are changed
* All documentation references changed
* yt-dlp no longer loads youtube-dlc config files
* All URLs changed to point to organization account
Co-authored-by: Pccode66
Co-authored-by: pukkandan
4 years ago