[embedthumbnail] Fix bug where jpeg thumbnails were converted again

Closes #297
3 years ago · 4d224a3022
parent f59ae58163
commit 4d224a3022
1 changed files with 1 additions and 1 deletions
--- a/yt_dlp/postprocessor/embedthumbnail.py
+++ b/yt_dlp/postprocessor/embedthumbnail.py
@ -59,7 +59,7 @@ class EmbedThumbnailPP(FFmpegPostProcessor):
        original_thumbnail = thumbnail_filename = info['thumbnails'][-1]['filepath']

        # Convert unsupported thumbnail formats to JPEG (see #25687, #25717)
-        _, thumbnail_ext = os.path.splitext(thumbnail_filename)
+        thumbnail_ext = os.path.splitext(thumbnail_filename)[1][1:]
        if thumbnail_ext not in ('jpg', 'png'):
            thumbnail_filename = convertor.convert_thumbnail(thumbnail_filename, 'jpg')
            thumbnail_ext = 'jpg'