Compare commits

..

No commits in common. 'main' and '14.8.1' have entirely different histories.
main ... 14.8.1

@ -29,7 +29,7 @@ jobs:
uses: actions/setup-java@v5 uses: actions/setup-java@v5
with: with:
distribution: 'temurin' distribution: 'temurin'
java-version: '21' java-version: '17'
- name: Setup Gradle - name: Setup Gradle
uses: gradle/actions/setup-gradle@v4 uses: gradle/actions/setup-gradle@v4
@ -44,7 +44,7 @@ jobs:
GOOGLE_KEY: ${{ secrets.GOOGLE_KEY }} GOOGLE_KEY: ${{ secrets.GOOGLE_KEY }}
run: bundle exec fastlane bundle run: bundle exec fastlane bundle
- name: Upload artifacts - name: Upload artifacts
uses: actions/upload-artifact@v5 uses: actions/upload-artifact@v4
with: with:
name: release name: release
path: | path: |

@ -16,11 +16,11 @@ jobs:
with: with:
bundler-cache: true bundler-cache: true
- name: Set up JDK 21 - name: Set up JDK 17
uses: actions/setup-java@v5 uses: actions/setup-java@v5
with: with:
distribution: 'temurin' distribution: 'temurin'
java-version: '21' java-version: '17'
- name: Setup Gradle - name: Setup Gradle
uses: gradle/actions/setup-gradle@v4 uses: gradle/actions/setup-gradle@v4
@ -29,7 +29,7 @@ jobs:
run: bundle exec fastlane lint run: bundle exec fastlane lint
- name: Archive lint reports - name: Archive lint reports
uses: actions/upload-artifact@v5 uses: actions/upload-artifact@v4
if: ${{ always() }} if: ${{ always() }}
with: with:
name: lint-reports name: lint-reports
@ -45,11 +45,11 @@ jobs:
- name: checkout - name: checkout
uses: actions/checkout@v5 uses: actions/checkout@v5
- name: Set up JDK 21 - name: Set up JDK 17
uses: actions/setup-java@v5 uses: actions/setup-java@v5
with: with:
distribution: 'temurin' distribution: 'temurin'
java-version: '21' java-version: '17'
- name: Setup Gradle - name: Setup Gradle
uses: gradle/actions/setup-gradle@v4 uses: gradle/actions/setup-gradle@v4
@ -89,7 +89,7 @@ jobs:
script: ./gradlew -Pcoverage app:test${{ matrix.flavor }}DebugUnitTest app:connected${{ matrix.flavor }}DebugAndroidTest script: ./gradlew -Pcoverage app:test${{ matrix.flavor }}DebugUnitTest app:connected${{ matrix.flavor }}DebugAndroidTest
- name: Upload test reports - name: Upload test reports
uses: actions/upload-artifact@v5 uses: actions/upload-artifact@v4
if: ${{ always() }} if: ${{ always() }}
with: with:
name: test-reports-${{ matrix.flavor }} name: test-reports-${{ matrix.flavor }}

@ -30,7 +30,7 @@ jobs:
uses: actions/setup-java@v5 uses: actions/setup-java@v5
with: with:
distribution: 'temurin' distribution: 'temurin'
java-version: '21' java-version: '17'
- name: Setup Gradle - name: Setup Gradle
uses: gradle/actions/setup-gradle@v4 uses: gradle/actions/setup-gradle@v4

@ -24,7 +24,7 @@ jobs:
- uses: ruby/setup-ruby@v1 - uses: ruby/setup-ruby@v1
with: with:
bundler-cache: true bundler-cache: true
- uses: actions/download-artifact@v6 - uses: actions/download-artifact@v5
with: with:
name: release name: release
path: . path: .

@ -1 +1 @@
3.4.7 3.4.5

@ -1,39 +1,3 @@
### 14.8.4 (2025-11-09)
* Fix flashing widgets [#3902](https://github.com/tasks/tasks/issues/3902)
* Fix random reminder scheduling
* Fix random reminders firing immediately on recurring tasks [#3904](https://github.com/tasks/tasks/issues/3904)
* Fix deadlock when adding new task
* Fix crash in settings when backup location unavailable [#3989](https://github.com/tasks/tasks/issues/3989)
* Fix Hebrew and Indonesian support [#3928](https://github.com/tasks/tasks/issues/3928)
* Update translations
* Bosnian - @hasak
* Finnish - @pHamala
* Indonesian - @erigmac
* Japanese - @array
* Romanian - @ygorigor
### 14.8.3 (2025-09-16)
* Fix crash on Android 10 and below
### 14.8.2 (2025-09-14)
* Fix blank widgets on Android 16 QPR1 [#3847](https://github.com/tasks/tasks/issues/3847)
* Fix all-day calendar events [#1534](https://github.com/tasks/tasks/issues/1534)
* Fix alarm synchronization [#3859](https://github.com/tasks/tasks/issues/3859)
* Fix sync failure when migrating data from EteSync to CalDAV [#3869](https://github.com/tasks/tasks/issues/3869)
* Fix removing values from Microsoft To Do [#3862](https://github.com/tasks/tasks/issues/3862)
* Fix share invites for Nextcloud [#2386](https://github.com/tasks/tasks/issues/2386)
* Fix failure to delete source data when moving to Google Tasks [#3867](https://github.com/tasks/tasks/issues/3867)
* Fix crash when clearing completed while grouping by lists
* Update translations
* Croatian - @milotype
* Dutch - @fvbommel
* German - @MisterTechnik
* Italian - @glemco
* Serbian - @vale-decem
### 14.8.1 (2025-08-24) ### 14.8.1 (2025-08-24)
* System bar scrim improvements * System bar scrim improvements

@ -15,7 +15,7 @@ Please visit [tasks.org](https://tasks.org) for end user documentation and suppo
[![PayPal donate button](https://img.shields.io/badge/paypal-donate-yellow.svg?logo=paypal)](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=alex@tasks.org) [![PayPal donate button](https://img.shields.io/badge/paypal-donate-yellow.svg?logo=paypal)](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=alex@tasks.org)
[![Liberapay donate button](https://img.shields.io/liberapay/receives/tasks.svg?logo=liberapay)](https://liberapay.com/tasks/donate) [![Liberapay donate button](https://img.shields.io/liberapay/receives/tasks.svg?logo=liberapay)](https://liberapay.com/tasks/donate)
[![build](https://github.com/tasks/tasks/actions/workflows/bundle.yml/badge.svg)](https://github.com/tasks/tasks/actions/workflows/bundle.yml) [![weblate](https://hosted.weblate.org/widgets/tasks/-/android/svg-badge.svg)](https://hosted.weblate.org/engage/tasks/?utm_source=widget) [![build](https://github.com/tasks/tasks/actions/workflows/bundle.yml/badge.svg)](https://github.com/tasks/tasks/actions/workflows/bundle.yml) [![weblate](https://hosted.weblate.org/widgets/tasks/-/android/svg-badge.svg)](https://hosted.weblate.org/engage/tasks/?utm_source=widget) [![codebeat badge](https://codebeat.co/badges/07924fca-2f18-4eff-99a3-120ec5ac2d5f)](https://codebeat.co/projects/github-com-tasks-tasks-main)
### Contributing ### Contributing

@ -349,7 +349,7 @@ class DateUtilitiesTest {
} }
@Test @Test
fun hebrewDateTimeNoYear() = withLocale(Locale.forLanguageTag("he")) { fun hebrewDateTimeNoYear() = withLocale(Locale.forLanguageTag("iw")) {
freezeAt(DateTime(2018, 12, 12)) { freezeAt(DateTime(2018, 12, 12)) {
assertMatches( assertMatches(
"יום ראשון, 14 בינואר( בשעה)? 13:45", "יום ראשון, 14 בינואר( בשעה)? 13:45",
@ -359,7 +359,7 @@ class DateUtilitiesTest {
} }
@Test @Test
fun hebrewDateTimeWithYear() = withLocale(Locale.forLanguageTag("he")) { fun hebrewDateTimeWithYear() = withLocale(Locale.forLanguageTag("iw")) {
freezeAt(DateTime(2017, 12, 12)) { freezeAt(DateTime(2017, 12, 12)) {
assertMatches( assertMatches(
"יום ראשון, 14 בינואר 2018( בשעה)? 13:45", "יום ראשון, 14 בינואר 2018( בשעה)? 13:45",

@ -56,7 +56,7 @@ class TaskMoverTest : InjectingTestCase() {
createTasks(1) createTasks(1)
googleTaskDao.insert(newCaldavTask(with(TASK, 1), with(CALENDAR, "1"))) googleTaskDao.insert(newCaldavTask(with(TASK, 1), with(CALENDAR, "1")))
moveToGoogleTasks("2", 1) moveToGoogleTasks("2", 1)
val deleted = googleTaskDao.getDeletedByTaskId(1, "account1") val deleted = googleTaskDao.getDeletedByTaskId(1)
assertEquals(1, deleted.size.toLong()) assertEquals(1, deleted.size.toLong())
assertEquals(1, deleted[0].task) assertEquals(1, deleted[0].task)
assertTrue(deleted[0].deleted > 0) assertTrue(deleted[0].deleted > 0)
@ -71,7 +71,7 @@ class TaskMoverTest : InjectingTestCase() {
googleTaskDao.insert(newCaldavTask(with(TASK, 1), with(CALENDAR, "1"))) googleTaskDao.insert(newCaldavTask(with(TASK, 1), with(CALENDAR, "1")))
googleTaskDao.insert(newCaldavTask(with(TASK, 2), with(CALENDAR, "1"))) googleTaskDao.insert(newCaldavTask(with(TASK, 2), with(CALENDAR, "1")))
moveToGoogleTasks("2", 1) moveToGoogleTasks("2", 1)
val deleted = googleTaskDao.getDeletedByTaskId(2, "account1") val deleted = googleTaskDao.getDeletedByTaskId(2)
assertEquals(1, deleted.size.toLong()) assertEquals(1, deleted.size.toLong())
assertEquals(2, deleted[0].task) assertEquals(2, deleted[0].task)
assertTrue(deleted[0].deleted > 0) assertTrue(deleted[0].deleted > 0)
@ -249,7 +249,7 @@ class TaskMoverTest : InjectingTestCase() {
createTasks(1) createTasks(1)
googleTaskDao.insert(newCaldavTask(with(TASK, 1), with(CALENDAR, "1"))) googleTaskDao.insert(newCaldavTask(with(TASK, 1), with(CALENDAR, "1")))
moveToGoogleTasks("1", 1) moveToGoogleTasks("1", 1)
assertTrue(googleTaskDao.getDeletedByTaskId(1, "account1").isEmpty()) assertTrue(googleTaskDao.getDeletedByTaskId(1).isEmpty())
assertEquals(1, googleTaskDao.getAllByTaskId(1).size.toLong()) assertEquals(1, googleTaskDao.getAllByTaskId(1).size.toLong())
} }

@ -1,13 +1,13 @@
package org.tasks.caldav package org.tasks.caldav
import org.tasks.data.UUIDHelper
import dagger.hilt.android.testing.HiltAndroidTest import dagger.hilt.android.testing.HiltAndroidTest
import kotlinx.coroutines.runBlocking import kotlinx.coroutines.runBlocking
import org.junit.Assert.assertEquals import org.junit.Assert.assertEquals
import org.junit.Test import org.junit.Test
import org.tasks.data.UUIDHelper
import org.tasks.data.entity.CaldavAccount import org.tasks.data.entity.CaldavAccount
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_NEXTCLOUD
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OPEN_XCHANGE import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OPEN_XCHANGE
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OWNCLOUD
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_SABREDAV import org.tasks.data.entity.CaldavAccount.Companion.SERVER_SABREDAV
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_TASKS import org.tasks.data.entity.CaldavAccount.Companion.SERVER_TASKS
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_UNKNOWN import org.tasks.data.entity.CaldavAccount.Companion.SERVER_UNKNOWN
@ -36,7 +36,7 @@ class ServerDetectionTest : CaldavTest() {
sync() sync()
assertEquals(SERVER_NEXTCLOUD, loadAccount().serverType) assertEquals(SERVER_OWNCLOUD, loadAccount().serverType)
} }
@Test @Test

@ -1,25 +0,0 @@
package org.tasks.data
import dagger.hilt.android.testing.HiltAndroidTest
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.withTimeout
import org.junit.Assert.assertTrue
import org.junit.Test
import org.tasks.data.dao.CaldavDao
import org.tasks.data.entity.CaldavAccount
import org.tasks.injection.InjectingTestCase
import javax.inject.Inject
@HiltAndroidTest
class CaldavDaoExtensionsTest : InjectingTestCase() {
@Inject lateinit var caldavDao: CaldavDao
@Test
fun getLocalListCreatesAccountIfNeeded() = runBlocking {
withTimeout(5000L) {
assertTrue(caldavDao.getAccounts().isEmpty())
caldavDao.getLocalList()
assertTrue(caldavDao.getAccounts(CaldavAccount.TYPE_LOCAL).isNotEmpty())
}
}
}

@ -4,24 +4,27 @@ import android.app.Activity
import android.content.Context import android.content.Context
import com.android.billingclient.api.AcknowledgePurchaseParams import com.android.billingclient.api.AcknowledgePurchaseParams
import com.android.billingclient.api.BillingClient.BillingResponseCode import com.android.billingclient.api.BillingClient.BillingResponseCode
import com.android.billingclient.api.BillingClient.ProductType import com.android.billingclient.api.BillingClient.SkuType
import com.android.billingclient.api.BillingClient.newBuilder import com.android.billingclient.api.BillingClient.newBuilder
import com.android.billingclient.api.BillingClientStateListener import com.android.billingclient.api.BillingClientStateListener
import com.android.billingclient.api.BillingFlowParams import com.android.billingclient.api.BillingFlowParams
import com.android.billingclient.api.BillingFlowParams.ProductDetailsParams import com.android.billingclient.api.BillingFlowParams.ProrationMode
import com.android.billingclient.api.BillingFlowParams.SubscriptionUpdateParams import com.android.billingclient.api.BillingFlowParams.SubscriptionUpdateParams
import com.android.billingclient.api.BillingResult import com.android.billingclient.api.BillingResult
import com.android.billingclient.api.ConsumeParams import com.android.billingclient.api.ConsumeParams
import com.android.billingclient.api.Purchase.PurchaseState import com.android.billingclient.api.Purchase.PurchaseState
import com.android.billingclient.api.PurchasesResult
import com.android.billingclient.api.PurchasesUpdatedListener import com.android.billingclient.api.PurchasesUpdatedListener
import com.android.billingclient.api.QueryProductDetailsParams import com.android.billingclient.api.SkuDetailsParams
import com.android.billingclient.api.QueryPurchasesParams
import com.android.billingclient.api.consumePurchase import com.android.billingclient.api.consumePurchase
import com.android.billingclient.api.queryPurchasesAsync
import com.android.billingclient.api.querySkuDetails
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.NonCancellable import kotlinx.coroutines.NonCancellable
import kotlinx.coroutines.suspendCancellableCoroutine import kotlinx.coroutines.suspendCancellableCoroutine
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import kotlinx.serialization.json.Json
import org.tasks.BuildConfig import org.tasks.BuildConfig
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.jobs.WorkManager import org.tasks.jobs.WorkManager
@ -46,61 +49,32 @@ class BillingClientImpl(
override suspend fun getSkus(skus: List<String>): List<Sku> = override suspend fun getSkus(skus: List<String>): List<Sku> =
executeServiceRequest { executeServiceRequest {
val productList = skus.map { val skuDetailsResult = withContext(Dispatchers.IO) {
QueryProductDetailsParams.Product.newBuilder() billingClient.querySkuDetails(
.setProductId(it) SkuDetailsParams
.setProductType(ProductType.SUBS) .newBuilder()
.build() .setType(SkuType.SUBS)
} .setSkusList(skus)
val params = QueryProductDetailsParams.newBuilder() .build()
.setProductList(productList) )
.build()
val productDetailsResult = withContext(Dispatchers.IO) {
suspendCoroutine { cont ->
billingClient.queryProductDetailsAsync(params) { billingResult, productDetailsList ->
cont.resume(billingResult to productDetailsList)
}
}
} }
skuDetailsResult.billingResult.let {
productDetailsResult.first.let {
if (!it.success) { if (!it.success) {
throw IllegalStateException(it.responseCodeString) throw IllegalStateException(it.responseCodeString)
} }
} }
val json = Json { ignoreUnknownKeys = true }
productDetailsResult.second?.map { productDetails -> skuDetailsResult
Sku( .skuDetailsList
productId = productDetails.productId, ?.map { json.decodeFromString<Sku>(it.originalJson) }
price = productDetails.subscriptionOfferDetails?.firstOrNull()?.pricingPhases?.pricingPhaseList?.firstOrNull()?.formattedPrice ?: emptyList()
?: productDetails.oneTimePurchaseOfferDetails?.formattedPrice
?: ""
)
} ?: emptyList()
} }
override suspend fun queryPurchases(throwError: Boolean) = try { override suspend fun queryPurchases(throwError: Boolean) = try {
executeServiceRequest { executeServiceRequest {
withContext(Dispatchers.IO + NonCancellable) { withContext(Dispatchers.IO + NonCancellable) {
val subsParams = QueryPurchasesParams.newBuilder() val subs = billingClient.queryPurchasesAsync(SkuType.SUBS)
.setProductType(ProductType.SUBS) val iaps = billingClient.queryPurchasesAsync(SkuType.INAPP)
.build()
val iapsParams = QueryPurchasesParams.newBuilder()
.setProductType(ProductType.INAPP)
.build()
val subs = suspendCoroutine { cont ->
billingClient.queryPurchasesAsync(subsParams) { billingResult, purchases ->
cont.resume(PurchasesResult(billingResult, purchases))
}
}
val iaps = suspendCoroutine { cont ->
billingClient.queryPurchasesAsync(iapsParams) { billingResult, purchases ->
cont.resume(PurchasesResult(billingResult, purchases))
}
}
if (subs.success || iaps.success) { if (subs.success || iaps.success) {
withContext(Dispatchers.Main) { withContext(Dispatchers.Main) {
inventory.clear() inventory.clear()
@ -131,7 +105,7 @@ class BillingClientImpl(
purchases?.forEach { purchases?.forEach {
firebase.reportIabResult( firebase.reportIabResult(
result.responseCodeString, result.responseCodeString,
it.products.joinToString(","), it.skus.joinToString(","),
it.purchaseState.purchaseStateString it.purchaseState.purchaseStateString
) )
} }
@ -148,57 +122,31 @@ class BillingClientImpl(
oldPurchase: Purchase? oldPurchase: Purchase?
) { ) {
executeServiceRequest { executeServiceRequest {
val productList = listOf( val skuDetailsResult = withContext(Dispatchers.IO) {
QueryProductDetailsParams.Product.newBuilder() billingClient.querySkuDetails(
.setProductId(sku) SkuDetailsParams.newBuilder().setSkusList(listOf(sku)).setType(skuType)
.setProductType(skuType) .build()
.build() )
)
val queryParams = QueryProductDetailsParams.newBuilder()
.setProductList(productList)
.build()
val productDetailsResult = withContext(Dispatchers.IO) {
suspendCoroutine { cont ->
billingClient.queryProductDetailsAsync(queryParams) { billingResult, productDetailsList ->
cont.resume(billingResult to productDetailsList)
}
}
} }
skuDetailsResult.billingResult.let {
productDetailsResult.first.let {
if (!it.success) { if (!it.success) {
throw IllegalStateException(it.responseCodeString) throw IllegalStateException(it.responseCodeString)
} }
} }
val skuDetails =
val productDetails = productDetailsResult.second?.firstOrNull() skuDetailsResult
?: throw IllegalStateException("Product $sku not found") .skuDetailsList
?.firstOrNull()
val productDetailsParamsBuilder = ProductDetailsParams.newBuilder() ?: throw IllegalStateException("Sku $sku not found")
.setProductDetails(productDetails) val params = BillingFlowParams.newBuilder().setSkuDetails(skuDetails)
// For subscriptions (including legacy subscriptions), we need to provide an offer token
if (skuType == ProductType.SUBS) {
val offerToken = productDetails.subscriptionOfferDetails?.firstOrNull()?.offerToken
?: throw IllegalStateException("No offer token found for subscription $sku")
productDetailsParamsBuilder.setOfferToken(offerToken)
}
val productDetailsParams = productDetailsParamsBuilder.build()
val params = BillingFlowParams.newBuilder()
.setProductDetailsParamsList(listOf(productDetailsParams))
oldPurchase?.let { oldPurchase?.let {
params.setSubscriptionUpdateParams( params.setSubscriptionUpdateParams(
SubscriptionUpdateParams.newBuilder() SubscriptionUpdateParams.newBuilder()
.setOldPurchaseToken(it.purchaseToken) .setOldSkuPurchaseToken(it.purchaseToken)
.setSubscriptionReplacementMode(BillingFlowParams.SubscriptionUpdateParams.ReplacementMode.WITH_TIME_PRORATION) .setReplaceSkusProrationMode(ProrationMode.IMMEDIATE_WITH_TIME_PRORATION)
.build() .build()
) )
} }
if (activity is OnPurchasesUpdated) { if (activity is OnPurchasesUpdated) {
onPurchasesUpdated = activity onPurchasesUpdated = activity
} }
@ -266,28 +214,17 @@ class BillingClientImpl(
ConsumeParams.newBuilder().setPurchaseToken(purchase.purchaseToken).build(), ConsumeParams.newBuilder().setPurchaseToken(purchase.purchaseToken).build(),
) )
Timber.d("consume purchase: ${result.billingResult.responseCodeString}") Timber.d("consume purchase: ${result.billingResult.responseCodeString}")
queryPurchases(throwError = false) queryPurchases()
} }
} }
private data class PurchasesResult(
val billingResult: BillingResult,
val purchasesList: List<com.android.billingclient.api.Purchase>
) {
val success: Boolean
get() = billingResult.responseCode == BillingResponseCode.OK
val responseCodeString: String
get() = billingResult.responseCodeString
val purchases: List<com.android.billingclient.api.Purchase>
get() = purchasesList
}
companion object { companion object {
const val TYPE_SUBS = ProductType.SUBS const val TYPE_SUBS = SkuType.SUBS
const val STATE_PURCHASED = PurchaseState.PURCHASED const val STATE_PURCHASED = PurchaseState.PURCHASED
private val PurchasesResult.success: Boolean
get() = billingResult.responseCode == BillingResponseCode.OK
private val BillingResult.success: Boolean private val BillingResult.success: Boolean
get() = responseCode == BillingResponseCode.OK get() = responseCode == BillingResponseCode.OK
@ -314,5 +251,11 @@ class BillingClientImpl(
PurchaseState.PENDING -> "PENDING" PurchaseState.PENDING -> "PENDING"
else -> this.toString() else -> this.toString()
} }
private val PurchasesResult.responseCodeString: String
get() = billingResult.responseCodeString
private val PurchasesResult.purchases: List<com.android.billingclient.api.Purchase>
get() = purchasesList
} }
} }

@ -31,7 +31,7 @@ class Purchase(private val purchase: Purchase) {
get() = purchase.signature get() = purchase.signature
val sku: String val sku: String
get() = purchase.products.first() get() = purchase.skus.first()
val purchaseToken: String val purchaseToken: String
get() = purchase.purchaseToken get() = purchase.purchaseToken
@ -55,7 +55,7 @@ class Purchase(private val purchase: Purchase) {
get() { get() {
val matcher = PATTERN.matcher(sku) val matcher = PATTERN.matcher(sku)
if (matcher.matches()) { if (matcher.matches()) {
val price = matcher.group(2)?.toInt() val price = matcher.group(2).toInt()
return if (price == 499) 5 else price return if (price == 499) 5 else price
} }
return null return null

@ -387,13 +387,6 @@
android:resource="@xml/file_provider_paths"/> android:resource="@xml/file_provider_paths"/>
</provider> </provider>
<provider
android:name=".widget.WidgetIconProvider"
android:authorities="${applicationId}.widgeticons"
android:exported="true"
android:grantUriPermissions="true"
tools:ignore="ExportedContentProvider" />
<receiver <receiver
android:name="org.dmfs.provider.tasks.TaskProviderBroadcastReceiver" android:name="org.dmfs.provider.tasks.TaskProviderBroadcastReceiver"
tools:node="remove"/> tools:node="remove"/>

@ -91,7 +91,8 @@ class MainActivityViewModel @Inject constructor(
private val refreshReceiver = object : BroadcastReceiver() { private val refreshReceiver = object : BroadcastReceiver() {
override fun onReceive(context: Context?, intent: Intent?) { override fun onReceive(context: Context?, intent: Intent?) {
when (intent?.action) { when (intent?.action) {
LocalBroadcastManager.REFRESH -> _updateFilters.update { currentTimeMillis() } LocalBroadcastManager.REFRESH,
LocalBroadcastManager.REFRESH_LIST -> _updateFilters.update { currentTimeMillis() }
} }
} }
} }
@ -215,12 +216,12 @@ class MainActivityViewModel @Inject constructor(
when (subheader.subheaderType) { when (subheader.subheaderType) {
NavigationDrawerSubheader.SubheaderType.PREFERENCE -> { NavigationDrawerSubheader.SubheaderType.PREFERENCE -> {
tasksPreferences.set(booleanPreferencesKey(subheader.id), collapsed) tasksPreferences.set(booleanPreferencesKey(subheader.id), collapsed)
localBroadcastManager.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
NavigationDrawerSubheader.SubheaderType.CALDAV, NavigationDrawerSubheader.SubheaderType.CALDAV,
NavigationDrawerSubheader.SubheaderType.TASKS -> { NavigationDrawerSubheader.SubheaderType.TASKS -> {
caldavDao.setCollapsed(subheader.id, collapsed) caldavDao.setCollapsed(subheader.id, collapsed)
localBroadcastManager.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
} }
} }

@ -782,12 +782,10 @@ class TaskListFragment : Fragment(), OnRefreshListener, Toolbar.OnMenuItemClickL
colorProvider.getPriorityColor(3)) colorProvider.getPriorityColor(3))
} }
@SuppressLint("NotifyDataSetChanged")
override fun onResume() { override fun onResume() {
super.onResume() super.onResume()
listViewModel.invalidate() listViewModel.invalidate()
localBroadcastManager.registerTaskCompletedReceiver(repeatConfirmationReceiver) localBroadcastManager.registerTaskCompletedReceiver(repeatConfirmationReceiver)
recyclerAdapter?.notifyDataSetChanged() // force rebind to update timestamps (hidden/overdue)
} }
private fun makeSnackbar(@StringRes res: Int, vararg args: Any?): Snackbar? { private fun makeSnackbar(@StringRes res: Int, vararg args: Any?): Snackbar? {

@ -3,8 +3,8 @@ package com.todoroo.astrid.adapter
import com.todoroo.astrid.dao.TaskDao import com.todoroo.astrid.dao.TaskDao
import com.todoroo.astrid.service.TaskMover import com.todoroo.astrid.service.TaskMover
import com.todoroo.astrid.subtasks.SubtasksFilterUpdater import com.todoroo.astrid.subtasks.SubtasksFilterUpdater
import org.tasks.LocalBroadcastManager
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.data.TaskContainer import org.tasks.data.TaskContainer
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.GoogleTaskDao import org.tasks.data.dao.GoogleTaskDao
@ -24,9 +24,9 @@ class AstridTaskAdapter internal constructor(
googleTaskDao: GoogleTaskDao, googleTaskDao: GoogleTaskDao,
caldavDao: CaldavDao, caldavDao: CaldavDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
taskMover: TaskMover, taskMover: TaskMover,
) : TaskAdapter(false, googleTaskDao, caldavDao, taskDao, refreshBroadcaster, taskMover) { ) : TaskAdapter(false, googleTaskDao, caldavDao, taskDao, localBroadcastManager, taskMover) {
private val chainedCompletions = Collections.synchronizedMap(HashMap<String, ArrayList<String>>()) private val chainedCompletions = Collections.synchronizedMap(HashMap<String, ArrayList<String>>())
@ -56,7 +56,7 @@ class AstridTaskAdapter internal constructor(
for (i in 0 until abs(delta)) { for (i in 0 until abs(delta)) {
updater.indent(list, filter, targetTaskId, delta) updater.indent(list, filter, targetTaskId, delta)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} catch (e: Exception) { } catch (e: Exception) {
Timber.e(e) Timber.e(e)
} }

@ -6,7 +6,7 @@ import androidx.appcompat.app.AppCompatActivity
import androidx.datastore.preferences.core.booleanPreferencesKey import androidx.datastore.preferences.core.booleanPreferencesKey
import androidx.lifecycle.lifecycleScope import androidx.lifecycle.lifecycleScope
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.activities.TagSettingsActivity import org.tasks.activities.TagSettingsActivity
import org.tasks.caldav.BaseCaldavCalendarSettingsActivity.Companion.EXTRA_CALDAV_ACCOUNT import org.tasks.caldav.BaseCaldavCalendarSettingsActivity.Companion.EXTRA_CALDAV_ACCOUNT
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
@ -30,7 +30,7 @@ class SubheaderClickHandler @Inject constructor(
private val activity: Activity, private val activity: Activity,
private val tasksPreferences: TasksPreferences, private val tasksPreferences: TasksPreferences,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
): SubheaderViewHolder.ClickHandler { ): SubheaderViewHolder.ClickHandler {
override fun onClick(subheader: NavigationDrawerSubheader) { override fun onClick(subheader: NavigationDrawerSubheader) {
(activity as AppCompatActivity).lifecycleScope.launch { (activity as AppCompatActivity).lifecycleScope.launch {
@ -40,7 +40,7 @@ class SubheaderClickHandler @Inject constructor(
CALDAV, CALDAV,
TASKS -> caldavDao.setCollapsed(subheader.id, collapsed) TASKS -> caldavDao.setCollapsed(subheader.id, collapsed)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
} }

@ -13,7 +13,7 @@ import com.todoroo.astrid.core.SortHelper.SORT_START
import com.todoroo.astrid.dao.TaskDao import com.todoroo.astrid.dao.TaskDao
import com.todoroo.astrid.service.TaskMover import com.todoroo.astrid.service.TaskMover
import org.tasks.BuildConfig import org.tasks.BuildConfig
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.data.TaskContainer import org.tasks.data.TaskContainer
import org.tasks.data.createDueDate import org.tasks.data.createDueDate
import org.tasks.data.createHideUntil import org.tasks.data.createHideUntil
@ -31,7 +31,7 @@ open class TaskAdapter(
private val googleTaskDao: GoogleTaskDao, private val googleTaskDao: GoogleTaskDao,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val taskMover: TaskMover, private val taskMover: TaskMover,
) { ) {
private val selected = HashSet<Long>() private val selected = HashSet<Long>()
@ -296,7 +296,7 @@ open class TaskAdapter(
taskDao.setOrder(task.id, task.task.order) taskDao.setOrder(task.id, task.task.order)
taskDao.setParent(newParentId, listOf(task.id)) taskDao.setParent(newParentId, listOf(task.id))
taskDao.touch(task.id) taskDao.touch(task.id)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
protected suspend fun moveGoogleTask(from: Int, to: Int, indent: Int) { protected suspend fun moveGoogleTask(from: Int, to: Int, indent: Int) {
@ -375,7 +375,7 @@ open class TaskAdapter(
} }
} }
taskDao.touch(task.id) taskDao.touch(task.id)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
if (BuildConfig.DEBUG) { if (BuildConfig.DEBUG) {
googleTaskDao.validateSorting(task.caldav!!) googleTaskDao.validateSorting(task.caldav!!)
} }
@ -407,7 +407,7 @@ open class TaskAdapter(
newPosition = newPosition, newPosition = newPosition,
) )
taskDao.touch(task.id) taskDao.touch(task.id)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private suspend fun changeCaldavParent(task: TaskContainer, indent: Int, to: Int): Long { private suspend fun changeCaldavParent(task: TaskContainer, indent: Int, to: Int): Long {

@ -75,16 +75,10 @@ class AlarmCalculator(
*/ */
private fun calculateNextRandomReminder(random: Random, task: Task, reminderPeriod: Long) = private fun calculateNextRandomReminder(random: Random, task: Task, reminderPeriod: Long) =
if (reminderPeriod > 0) { if (reminderPeriod > 0) {
val baseline = when {
task.reminderLast > 0 -> task.reminderLast
task.isRecurring -> task.modificationDate
else -> task.creationDate
}
val multiplier = 0.85f + 0.3f * random.nextFloat(task.id + baseline)
maxOf( maxOf(
baseline.plus((reminderPeriod * multiplier).toLong()), task.reminderLast
.coerceAtLeast(task.creationDate)
.plus((reminderPeriod * (0.85f + 0.3f * random.nextFloat())).toLong()),
task.hideUntil task.hideUntil
) )
} else { } else {

@ -5,7 +5,7 @@
*/ */
package com.todoroo.astrid.alarms package com.todoroo.astrid.alarms
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.data.dao.AlarmDao import org.tasks.data.dao.AlarmDao
import org.tasks.data.dao.TaskDao import org.tasks.data.dao.TaskDao
import org.tasks.data.db.DbUtils import org.tasks.data.db.DbUtils
@ -28,7 +28,7 @@ import javax.inject.Inject
class AlarmService @Inject constructor( class AlarmService @Inject constructor(
private val alarmDao: AlarmDao, private val alarmDao: AlarmDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val notificationManager: NotificationManager, private val notificationManager: NotificationManager,
private val workManager: WorkManager, private val workManager: WorkManager,
private val alarmCalculator: AlarmCalculator, private val alarmCalculator: AlarmCalculator,
@ -54,7 +54,7 @@ class AlarmService @Inject constructor(
changed = true changed = true
} }
if (changed) { if (changed) {
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
return changed return changed
} }

@ -6,7 +6,7 @@
package com.todoroo.astrid.dao package com.todoroo.astrid.dao
import com.todoroo.astrid.timers.TimerPlugin import com.todoroo.astrid.timers.TimerPlugin
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.data.TaskContainer import org.tasks.data.TaskContainer
import org.tasks.data.count import org.tasks.data.count
import org.tasks.data.dao.TaskDao import org.tasks.data.dao.TaskDao
@ -28,7 +28,7 @@ import javax.inject.Inject
class TaskDao @Inject constructor( class TaskDao @Inject constructor(
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val notificationManager: NotificationManager, private val notificationManager: NotificationManager,
private val geofenceApi: GeofenceApi, private val geofenceApi: GeofenceApi,
private val timerPlugin: TimerPlugin, private val timerPlugin: TimerPlugin,
@ -82,7 +82,7 @@ class TaskDao @Inject constructor(
suspend fun setCollapsed(id: Long, collapsed: Boolean) { suspend fun setCollapsed(id: Long, collapsed: Boolean) {
taskDao.setCollapsed(listOf(id), collapsed) taskDao.setCollapsed(listOf(id), collapsed)
syncAdapters.sync() syncAdapters.sync()
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
suspend fun setCollapsed(preferences: Preferences, filter: Filter, collapsed: Boolean) { suspend fun setCollapsed(preferences: Preferences, filter: Filter, collapsed: Boolean) {
@ -103,7 +103,7 @@ class TaskDao @Inject constructor(
Timber.d("Saved $task") Timber.d("Saved $task")
afterUpdate(task, original) afterUpdate(task, original)
if (!task.isSuppressRefresh()) { if (!task.isSuppressRefresh()) {
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
workManager.triggerNotifications() workManager.triggerNotifications()
workManager.scheduleRefresh() workManager.scheduleRefresh()

@ -11,7 +11,6 @@ import android.content.Context
import android.net.Uri import android.net.Uri
import android.provider.CalendarContract import android.provider.CalendarContract
import android.text.format.Time import android.text.format.Time
import androidx.core.net.toUri
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
@ -20,7 +19,7 @@ import org.tasks.data.dao.TaskDao
import org.tasks.data.entity.Task import org.tasks.data.entity.Task
import org.tasks.preferences.PermissionChecker import org.tasks.preferences.PermissionChecker
import org.tasks.preferences.Preferences import org.tasks.preferences.Preferences
import org.tasks.time.DateTime import org.tasks.time.DateTimeUtils2.currentTimeMillis
import org.tasks.time.ONE_HOUR import org.tasks.time.ONE_HOUR
import timber.log.Timber import timber.log.Timber
import java.util.TimeZone import java.util.TimeZone
@ -31,8 +30,8 @@ class GCalHelper @Inject constructor(
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val preferences: Preferences, private val preferences: Preferences,
private val permissionChecker: PermissionChecker, private val permissionChecker: PermissionChecker,
private val calendarEventProvider: CalendarEventProvider, private val calendarEventProvider: CalendarEventProvider) {
) {
private val cr: ContentResolver = context.contentResolver private val cr: ContentResolver = context.contentResolver
private suspend fun getTaskEventUri(task: Task) = private suspend fun getTaskEventUri(task: Task) =
@ -110,7 +109,7 @@ class GCalHelper @Inject constructor(
}) })
updateValues.put(CalendarContract.Events.DESCRIPTION, task.notes) updateValues.put(CalendarContract.Events.DESCRIPTION, task.notes)
createStartAndEndDate(task, updateValues) createStartAndEndDate(task, updateValues)
cr.update(uri.toUri(), updateValues, null, null) cr.update(Uri.parse(uri), updateValues, null, null)
} catch (e: Exception) { } catch (e: Exception) {
Timber.e(e, "Failed to update calendar: %s [%s]", uri, task) Timber.e(e, "Failed to update calendar: %s [%s]", uri, task)
} }
@ -118,10 +117,10 @@ class GCalHelper @Inject constructor(
suspend fun rescheduleRepeatingTask(task: Task) { suspend fun rescheduleRepeatingTask(task: Task) {
val taskUri = getTaskEventUri(task) val taskUri = getTaskEventUri(task)
if (taskUri.isNullOrBlank()) { if (isNullOrEmpty(taskUri)) {
return return
} }
val eventUri = taskUri.toUri() val eventUri = Uri.parse(taskUri)
val event = calendarEventProvider.getEvent(eventUri) val event = calendarEventProvider.getEvent(eventUri)
if (event == null) { if (event == null) {
task.calendarURI = "" task.calendarURI = ""
@ -135,6 +134,11 @@ class GCalHelper @Inject constructor(
private fun createStartAndEndDate(task: Task, values: ContentValues) { private fun createStartAndEndDate(task: Task, values: ContentValues) {
val dueDate = task.dueDate val dueDate = task.dueDate
val tzCorrectedDueDate = dueDate + TimeZone.getDefault().getOffset(dueDate)
val tzCorrectedDueDateNow = currentTimeMillis() + TimeZone.getDefault().getOffset(
currentTimeMillis()
)
// FIXME: doesn't respect timezones, see story 17443653
if (task.hasDueDate()) { if (task.hasDueDate()) {
if (task.hasDueTime()) { if (task.hasDueTime()) {
var estimatedTime = task.estimatedSeconds * 1000.toLong() var estimatedTime = task.estimatedSeconds * 1000.toLong()
@ -148,19 +152,24 @@ class GCalHelper @Inject constructor(
values.put(CalendarContract.Events.DTSTART, dueDate - estimatedTime) values.put(CalendarContract.Events.DTSTART, dueDate - estimatedTime)
values.put(CalendarContract.Events.DTEND, dueDate) values.put(CalendarContract.Events.DTEND, dueDate)
} }
// setting a duetime to a previously timeless event requires explicitly setting allDay=0
values.put(CalendarContract.Events.ALL_DAY, "0") values.put(CalendarContract.Events.ALL_DAY, "0")
values.put(CalendarContract.Events.EVENT_TIMEZONE, TimeZone.getDefault().id) values.put(CalendarContract.Events.EVENT_TIMEZONE, TimeZone.getDefault().id)
} else { } else {
val utcMidnight = DateTime(dueDate).toUTC().startOfDay() values.put(CalendarContract.Events.DTSTART, tzCorrectedDueDate)
values.put(CalendarContract.Events.DTSTART, utcMidnight.millis) values.put(CalendarContract.Events.DTEND, tzCorrectedDueDate)
values.put(CalendarContract.Events.DTEND, utcMidnight.plusDays(1).millis)
values.put(CalendarContract.Events.ALL_DAY, "1") values.put(CalendarContract.Events.ALL_DAY, "1")
values.put(CalendarContract.Events.EVENT_TIMEZONE, Time.TIMEZONE_UTC)
} }
} else { } else {
Timber.w("Not creating calendar event, task has no due date: %s", task) values.put(CalendarContract.Events.DTSTART, tzCorrectedDueDateNow)
values.put(CalendarContract.Events.DTEND, tzCorrectedDueDateNow)
values.put(CalendarContract.Events.ALL_DAY, "1")
}
if ("1" == values[CalendarContract.Events.ALL_DAY]) {
values.put(CalendarContract.Events.EVENT_TIMEZONE, Time.TIMEZONE_UTC)
} else {
values.put(CalendarContract.Events.EVENT_TIMEZONE, TimeZone.getDefault().id)
} }
} }
companion object { companion object {

@ -7,7 +7,7 @@ package com.todoroo.astrid.gtasks
import com.google.api.services.tasks.model.TaskList import com.google.api.services.tasks.model.TaskList
import com.todoroo.astrid.service.TaskDeleter import com.todoroo.astrid.service.TaskDeleter
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.entity.CaldavAccount import org.tasks.data.entity.CaldavAccount
import org.tasks.data.entity.CaldavCalendar import org.tasks.data.entity.CaldavCalendar
@ -16,7 +16,7 @@ import javax.inject.Inject
class GtasksListService @Inject constructor( class GtasksListService @Inject constructor(
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val taskDeleter: TaskDeleter, private val taskDeleter: TaskDeleter,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
) { ) {
/** /**
@ -55,6 +55,6 @@ class GtasksListService @Inject constructor(
for (listId in previousLists) { for (listId in previousLists) {
taskDeleter.delete(caldavDao.getCalendarById(listId)!!) taskDeleter.delete(caldavDao.getCalendarById(listId)!!)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
} }

@ -7,7 +7,7 @@ import kotlinx.coroutines.NonCancellable
import kotlinx.coroutines.coroutineScope import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.caldav.VtodoCache import org.tasks.caldav.VtodoCache
import org.tasks.data.dao.DeletionDao import org.tasks.data.dao.DeletionDao
import org.tasks.data.dao.LocationDao import org.tasks.data.dao.LocationDao
@ -28,7 +28,7 @@ class TaskDeleter @Inject constructor(
@ApplicationContext private val context: Context, @ApplicationContext private val context: Context,
private val deletionDao: DeletionDao, private val deletionDao: DeletionDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val syncAdapters: SyncAdapters, private val syncAdapters: SyncAdapters,
private val vtodoCache: VtodoCache, private val vtodoCache: VtodoCache,
private val notificationManager: NotificationManager, private val notificationManager: NotificationManager,
@ -50,7 +50,7 @@ class TaskDeleter @Inject constructor(
cleanup = { cleanup(it) } cleanup = { cleanup(it) }
) )
syncAdapters.sync() syncAdapters.sync()
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
taskDao.fetch(ids) taskDao.fetch(ids)
} }
@ -63,7 +63,7 @@ class TaskDeleter @Inject constructor(
ids = tasks, ids = tasks,
cleanup = { cleanup(it) } cleanup = { cleanup(it) }
) )
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
suspend fun delete(list: CaldavCalendar) { suspend fun delete(list: CaldavCalendar) {
@ -72,7 +72,7 @@ class TaskDeleter @Inject constructor(
caldavCalendar = list, caldavCalendar = list,
cleanup = { cleanup(it) } cleanup = { cleanup(it) }
) )
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
suspend fun delete(account: CaldavAccount) { suspend fun delete(account: CaldavAccount) {
@ -81,7 +81,7 @@ class TaskDeleter @Inject constructor(
caldavAccount = account, caldavAccount = account,
cleanup = { cleanup(it) } cleanup = { cleanup(it) }
) )
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
private suspend fun cleanup(tasks: List<Long>) { private suspend fun cleanup(tasks: List<Long>) {

@ -2,7 +2,7 @@ package com.todoroo.astrid.service
import com.todoroo.astrid.dao.TaskDao import com.todoroo.astrid.dao.TaskDao
import com.todoroo.astrid.gcal.GCalHelper import com.todoroo.astrid.gcal.GCalHelper
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.data.dao.AlarmDao import org.tasks.data.dao.AlarmDao
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.GoogleTaskDao import org.tasks.data.dao.GoogleTaskDao
@ -24,7 +24,7 @@ import javax.inject.Inject
class TaskDuplicator @Inject constructor( class TaskDuplicator @Inject constructor(
private val gcalHelper: GCalHelper, private val gcalHelper: GCalHelper,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val tagDao: TagDao, private val tagDao: TagDao,
private val tagDataDao: TagDataDao, private val tagDataDao: TagDataDao,
private val googleTaskDao: GoogleTaskDao, private val googleTaskDao: GoogleTaskDao,
@ -44,7 +44,7 @@ class TaskDuplicator @Inject constructor(
.let { taskDao.fetch(it) } .let { taskDao.fetch(it) }
.filterNot { it.readOnly } .filterNot { it.readOnly }
.map { clone(it, it.parent) } .map { clone(it, it.parent) }
.also { refreshBroadcaster.broadcastRefresh() } .also { localBroadcastManager.broadcastRefresh() }
} }
private suspend fun clone(task: Task, parentId: Long): Task { private suspend fun clone(task: Task, parentId: Long): Task {

@ -1,6 +1,6 @@
package com.todoroo.astrid.service package com.todoroo.astrid.service
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.caldav.VtodoCache import org.tasks.caldav.VtodoCache
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.GoogleTaskDao import org.tasks.data.dao.GoogleTaskDao
@ -22,7 +22,7 @@ class TaskMover @Inject constructor(
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val googleTaskDao: GoogleTaskDao, private val googleTaskDao: GoogleTaskDao,
private val preferences: Preferences, private val preferences: Preferences,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val syncAdapters: SyncAdapters, private val syncAdapters: SyncAdapters,
private val vtodoCache: VtodoCache, private val vtodoCache: VtodoCache,
) { ) {
@ -63,7 +63,7 @@ class TaskMover @Inject constructor(
taskIds.dbchunk().forEach { taskIds.dbchunk().forEach {
taskDao.touch(it) taskDao.touch(it)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
syncAdapters.sync() syncAdapters.sync()
} }

@ -7,14 +7,13 @@ import android.content.IntentFilter
import androidx.localbroadcastmanager.content.LocalBroadcastManager import androidx.localbroadcastmanager.content.LocalBroadcastManager
import com.todoroo.astrid.api.AstridApiConstants import com.todoroo.astrid.api.AstridApiConstants
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.widget.AppWidgetManager import org.tasks.widget.AppWidgetManager
import javax.inject.Inject import javax.inject.Inject
class LocalBroadcastManager @Inject constructor( class LocalBroadcastManager @Inject constructor(
@ApplicationContext context: Context, @ApplicationContext context: Context,
private val appWidgetManager: AppWidgetManager, private val appWidgetManager: AppWidgetManager,
): RefreshBroadcaster { ) {
private val localBroadcastManager = LocalBroadcastManager.getInstance(context) private val localBroadcastManager = LocalBroadcastManager.getInstance(context)
fun registerRefreshReceiver(broadcastReceiver: BroadcastReceiver?) { fun registerRefreshReceiver(broadcastReceiver: BroadcastReceiver?) {
@ -24,6 +23,7 @@ class LocalBroadcastManager @Inject constructor(
fun registerRefreshListReceiver(broadcastReceiver: BroadcastReceiver?) { fun registerRefreshListReceiver(broadcastReceiver: BroadcastReceiver?) {
val intentFilter = IntentFilter() val intentFilter = IntentFilter()
intentFilter.addAction(REFRESH) intentFilter.addAction(REFRESH)
intentFilter.addAction(REFRESH_LIST)
localBroadcastManager.registerReceiver(broadcastReceiver!!, intentFilter) localBroadcastManager.registerReceiver(broadcastReceiver!!, intentFilter)
} }
@ -42,11 +42,15 @@ class LocalBroadcastManager @Inject constructor(
) )
} }
override fun broadcastRefresh() { fun broadcastRefresh() {
localBroadcastManager.sendBroadcast(Intent(REFRESH)) localBroadcastManager.sendBroadcast(Intent(REFRESH))
appWidgetManager.updateWidgets() appWidgetManager.updateWidgets()
} }
fun broadcastRefreshList() {
localBroadcastManager.sendBroadcast(Intent(REFRESH_LIST))
}
fun broadcastPreferenceRefresh() { fun broadcastPreferenceRefresh() {
localBroadcastManager.sendBroadcast(Intent(REFRESH_PREFERENCES)) localBroadcastManager.sendBroadcast(Intent(REFRESH_PREFERENCES))
} }
@ -76,6 +80,7 @@ class LocalBroadcastManager @Inject constructor(
companion object { companion object {
const val REFRESH = "${BuildConfig.APPLICATION_ID}.REFRESH" const val REFRESH = "${BuildConfig.APPLICATION_ID}.REFRESH"
const val REFRESH_LIST = "${BuildConfig.APPLICATION_ID}.REFRESH_LIST"
private const val TASK_COMPLETED = "${BuildConfig.APPLICATION_ID}.REPEAT" private const val TASK_COMPLETED = "${BuildConfig.APPLICATION_ID}.REPEAT"
private const val REFRESH_PURCHASES = "${BuildConfig.APPLICATION_ID}.REFRESH_PURCHASES" private const val REFRESH_PURCHASES = "${BuildConfig.APPLICATION_ID}.REFRESH_PURCHASES"
private const val REFRESH_PREFERENCES = "${BuildConfig.APPLICATION_ID}.REFRESH_PREFERENCES" private const val REFRESH_PREFERENCES = "${BuildConfig.APPLICATION_ID}.REFRESH_PREFERENCES"

@ -6,7 +6,6 @@ import android.app.ApplicationExitInfo
import android.content.BroadcastReceiver import android.content.BroadcastReceiver
import android.content.Context import android.content.Context
import android.content.Intent import android.content.Intent
import android.content.IntentFilter
import android.os.Build import android.os.Build
import android.util.Log import android.util.Log
import androidx.annotation.RequiresApi import androidx.annotation.RequiresApi

@ -28,7 +28,7 @@ import com.todoroo.astrid.api.TextInputCriterion
import com.todoroo.astrid.core.CriterionInstance import com.todoroo.astrid.core.CriterionInstance
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings import org.tasks.Strings
import org.tasks.compose.DeleteButton import org.tasks.compose.DeleteButton
@ -56,7 +56,7 @@ import javax.inject.Inject
class FilterSettingsActivity : BaseListSettingsActivity() { class FilterSettingsActivity : BaseListSettingsActivity() {
@Inject lateinit var filterDao: FilterDao @Inject lateinit var filterDao: FilterDao
@Inject lateinit var filterCriteriaProvider: FilterCriteriaProvider @Inject lateinit var filterCriteriaProvider: FilterCriteriaProvider
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
private val viewModel: FilterSettingsViewModel by viewModels() private val viewModel: FilterSettingsViewModel by viewModels()
@ -128,7 +128,7 @@ class FilterSettingsActivity : BaseListSettingsActivity() {
} else { } else {
filterDao.update(f) filterDao.update(f)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
setResult( setResult(
Activity.RESULT_OK, Activity.RESULT_OK,
Intent(TaskListFragment.ACTION_RELOAD) Intent(TaskListFragment.ACTION_RELOAD)

@ -15,7 +15,7 @@ import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.NonCancellable import kotlinx.coroutines.NonCancellable
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.caldav.BaseCaldavCalendarSettingsActivity.Companion.EXTRA_CALDAV_ACCOUNT import org.tasks.caldav.BaseCaldavCalendarSettingsActivity.Companion.EXTRA_CALDAV_ACCOUNT
@ -35,7 +35,7 @@ import javax.inject.Inject
class GoogleTaskListSettingsActivity : BaseListSettingsActivity() { class GoogleTaskListSettingsActivity : BaseListSettingsActivity() {
@Inject lateinit var caldavDao: CaldavDao @Inject lateinit var caldavDao: CaldavDao
@Inject lateinit var taskDeleter: TaskDeleter @Inject lateinit var taskDeleter: TaskDeleter
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
private val account: CaldavAccount private val account: CaldavAccount
get() = intent.getParcelableExtra(EXTRA_CALDAV_ACCOUNT)!! get() = intent.getParcelableExtra(EXTRA_CALDAV_ACCOUNT)!!
@ -122,7 +122,7 @@ class GoogleTaskListSettingsActivity : BaseListSettingsActivity() {
icon = baseViewModel.icon icon = baseViewModel.icon
) )
) )
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
setResult( setResult(
Activity.RESULT_OK, Activity.RESULT_OK,
Intent(TaskListFragment.ACTION_RELOAD) Intent(TaskListFragment.ACTION_RELOAD)

@ -140,7 +140,7 @@ class NavigationDrawerCustomization : ThemedInjectingAppCompatActivity(), Toolba
private inner class RefreshReceiver : BroadcastReceiver() { private inner class RefreshReceiver : BroadcastReceiver() {
override fun onReceive(context: Context, intent: Intent?) { override fun onReceive(context: Context, intent: Intent?) {
val action = intent?.action val action = intent?.action
if (LocalBroadcastManager.REFRESH == action) { if (LocalBroadcastManager.REFRESH == action || LocalBroadcastManager.REFRESH_LIST == action) {
updateFilters() updateFilters()
} }
} }

@ -27,7 +27,7 @@ import androidx.compose.ui.viewinterop.AndroidView
import com.todoroo.astrid.activity.MainActivity import com.todoroo.astrid.activity.MainActivity
import com.todoroo.astrid.activity.TaskListFragment import com.todoroo.astrid.activity.TaskListFragment
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.compose.Constants import org.tasks.compose.Constants
@ -60,7 +60,7 @@ class PlaceSettingsActivity : BaseListSettingsActivity(),
@Inject lateinit var map: MapFragment @Inject lateinit var map: MapFragment
@Inject lateinit var preferences: Preferences @Inject lateinit var preferences: Preferences
@Inject lateinit var locale: Locale @Inject lateinit var locale: Locale
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
private lateinit var place: Place private lateinit var place: Place
override val defaultIcon = TasksIcons.PLACE override val defaultIcon = TasksIcons.PLACE
@ -172,7 +172,7 @@ class PlaceSettingsActivity : BaseListSettingsActivity(),
radius = sliderPos.floatValue.roundToInt(), radius = sliderPos.floatValue.roundToInt(),
) )
locationDao.update(place) locationDao.update(place)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
setResult( setResult(
Activity.RESULT_OK, Activity.RESULT_OK,
Intent(TaskListFragment.ACTION_RELOAD) Intent(TaskListFragment.ACTION_RELOAD)
@ -190,7 +190,7 @@ class PlaceSettingsActivity : BaseListSettingsActivity(),
locationDao.deleteGeofencesByPlace(place.uid!!) locationDao.deleteGeofencesByPlace(place.uid!!)
locationDao.delete(place) locationDao.delete(place)
setResult(Activity.RESULT_OK, Intent(TaskListFragment.ACTION_DELETED)) setResult(Activity.RESULT_OK, Intent(TaskListFragment.ACTION_DELETED))
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
finish() finish()
} }

@ -12,7 +12,7 @@ import androidx.activity.compose.setContent
import com.todoroo.astrid.activity.MainActivity import com.todoroo.astrid.activity.MainActivity
import com.todoroo.astrid.activity.TaskListFragment import com.todoroo.astrid.activity.TaskListFragment
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.data.dao.TagDao import org.tasks.data.dao.TagDao
@ -28,7 +28,7 @@ import javax.inject.Inject
class TagSettingsActivity : BaseListSettingsActivity() { class TagSettingsActivity : BaseListSettingsActivity() {
@Inject lateinit var tagDataDao: TagDataDao @Inject lateinit var tagDataDao: TagDataDao
@Inject lateinit var tagDao: TagDao @Inject lateinit var tagDao: TagDao
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
private lateinit var tagData: TagData private lateinit var tagData: TagData
private val isNewTag: Boolean private val isNewTag: Boolean
@ -88,7 +88,7 @@ class TagSettingsActivity : BaseListSettingsActivity() {
) )
.let { it.copy(id = tagDataDao.insert(it)) } .let { it.copy(id = tagDataDao.insert(it)) }
.let { .let {
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
setResult( setResult(
Activity.RESULT_OK, Activity.RESULT_OK,
Intent().putExtra(MainActivity.OPEN_FILTER, TagFilter(it)) Intent().putExtra(MainActivity.OPEN_FILTER, TagFilter(it))
@ -104,7 +104,7 @@ class TagSettingsActivity : BaseListSettingsActivity() {
.let { .let {
tagDataDao.update(it) tagDataDao.update(it)
tagDao.rename(it.remoteId!!, newName) tagDao.rename(it.remoteId!!, newName)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
setResult( setResult(
Activity.RESULT_OK, Activity.RESULT_OK,
Intent(TaskListFragment.ACTION_RELOAD) Intent(TaskListFragment.ACTION_RELOAD)

@ -19,7 +19,7 @@ import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import kotlinx.serialization.Serializable import kotlinx.serialization.Serializable
import kotlinx.serialization.json.Json import kotlinx.serialization.json.Json
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.caldav.VtodoCache import org.tasks.caldav.VtodoCache
import org.tasks.data.GoogleTaskAccount import org.tasks.data.GoogleTaskAccount
@ -65,7 +65,7 @@ class TasksJsonImporter @Inject constructor(
private val userActivityDao: UserActivityDao, private val userActivityDao: UserActivityDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val locationDao: LocationDao, private val locationDao: LocationDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val alarmDao: AlarmDao, private val alarmDao: AlarmDao,
private val tagDao: TagDao, private val tagDao: TagDao,
private val filterDao: FilterDao, private val filterDao: FilterDao,
@ -110,7 +110,7 @@ class TasksJsonImporter @Inject constructor(
} catch (e: IOException) { } catch (e: IOException) {
Timber.e(e) Timber.e(e)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
result result
} }

@ -15,6 +15,7 @@ import androidx.compose.runtime.MutableState
import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.saveable.rememberSaveable import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.lifecycle.compose.collectAsStateWithLifecycle import androidx.lifecycle.compose.collectAsStateWithLifecycle
import androidx.lifecycle.lifecycleScope import androidx.lifecycle.lifecycleScope
@ -34,6 +35,7 @@ import org.tasks.data.entity.CaldavAccount.Companion.SERVER_TASKS
import org.tasks.data.entity.CaldavCalendar import org.tasks.data.entity.CaldavCalendar
import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_OWNER import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_OWNER
import org.tasks.themes.TasksTheme import org.tasks.themes.TasksTheme
import org.tasks.themes.colorOn
import javax.inject.Inject import javax.inject.Inject
@AndroidEntryPoint @AndroidEntryPoint
@ -70,7 +72,7 @@ class CaldavCalendarSettingsActivity : BaseCaldavCalendarSettingsActivity() {
val openDialog = rememberSaveable { mutableStateOf(false) } val openDialog = rememberSaveable { mutableStateOf(false) }
ShareInviteDialog( ShareInviteDialog(
openDialog, openDialog,
email = caldavAccount.serverType !in listOf(SERVER_OWNCLOUD, SERVER_NEXTCLOUD), email = caldavAccount.serverType != SERVER_OWNCLOUD
) { input -> ) { input ->
lifecycleScope.launch { lifecycleScope.launch {
share(input) share(input)

@ -12,8 +12,6 @@ import org.tasks.data.UUIDHelper
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.PrincipalDao import org.tasks.data.dao.PrincipalDao
import org.tasks.data.entity.CaldavAccount import org.tasks.data.entity.CaldavAccount
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_NEXTCLOUD
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OWNCLOUD
import org.tasks.data.entity.CaldavCalendar import org.tasks.data.entity.CaldavCalendar
import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_READ_WRITE import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_READ_WRITE
import org.tasks.data.entity.CaldavCalendar.Companion.INVITE_UNKNOWN import org.tasks.data.entity.CaldavCalendar.Companion.INVITE_UNKNOWN
@ -98,10 +96,10 @@ class CaldavCalendarViewModel @Inject constructor(
list: CaldavCalendar, list: CaldavCalendar,
input: String input: String
) = doRequest { ) = doRequest {
val href = when (account.serverType) { val href = if (account.serverType == CaldavAccount.SERVER_OWNCLOUD)
SERVER_OWNCLOUD, SERVER_NEXTCLOUD -> "principal:principals/users/$input" "principal:principals/users/$input"
else -> "mailto:$input" else
} "mailto:$input"
withContext(Dispatchers.IO) { withContext(Dispatchers.IO) {
provider.forAccount(account, list.url!!).share(account, href) provider.forAccount(account, list.url!!).share(account, href)
} }

@ -225,8 +225,8 @@ open class CaldavClient(
href: String, href: String,
) { ) {
when (account.serverType) { when (account.serverType) {
SERVER_TASKS, SERVER_SABREDAV -> shareSabredav(href) SERVER_TASKS, SERVER_SABREDAV, SERVER_NEXTCLOUD -> shareSabredav(href)
SERVER_OWNCLOUD, SERVER_NEXTCLOUD -> shareOwncloud(href) SERVER_OWNCLOUD -> shareOwncloud(href)
else -> throw IllegalArgumentException() else -> throw IllegalArgumentException()
} }
} }
@ -265,8 +265,8 @@ open class CaldavClient(
href: String, href: String,
) { ) {
when (account.serverType) { when (account.serverType) {
SERVER_TASKS, SERVER_SABREDAV -> removeSabrePrincipal(calendar, href) SERVER_TASKS, SERVER_SABREDAV, SERVER_NEXTCLOUD -> removeSabrePrincipal(calendar, href)
SERVER_OWNCLOUD, SERVER_NEXTCLOUD -> removeOwncloudPrincipal(calendar, href) SERVER_OWNCLOUD -> removeOwncloudPrincipal(calendar, href)
else -> throw IllegalArgumentException() else -> throw IllegalArgumentException()
} }
} }

@ -32,11 +32,11 @@ import okhttp3.HttpUrl
import okhttp3.OkHttpClient import okhttp3.OkHttpClient
import okhttp3.RequestBody.Companion.toRequestBody import okhttp3.RequestBody.Companion.toRequestBody
import org.tasks.BuildConfig import org.tasks.BuildConfig
import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.billing.Inventory import org.tasks.billing.Inventory
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.caldav.iCalendar.Companion.fromVtodo import org.tasks.caldav.iCalendar.Companion.fromVtodo
import org.tasks.caldav.property.CalendarIcon import org.tasks.caldav.property.CalendarIcon
import org.tasks.caldav.property.Invite import org.tasks.caldav.property.Invite
@ -56,7 +56,6 @@ import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.PrincipalDao import org.tasks.data.dao.PrincipalDao
import org.tasks.data.entity.CaldavAccount import org.tasks.data.entity.CaldavAccount
import org.tasks.data.entity.CaldavAccount.Companion.ERROR_UNAUTHORIZED import org.tasks.data.entity.CaldavAccount.Companion.ERROR_UNAUTHORIZED
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_NEXTCLOUD
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OPEN_XCHANGE import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OPEN_XCHANGE
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OWNCLOUD import org.tasks.data.entity.CaldavAccount.Companion.SERVER_OWNCLOUD
import org.tasks.data.entity.CaldavAccount.Companion.SERVER_SABREDAV import org.tasks.data.entity.CaldavAccount.Companion.SERVER_SABREDAV
@ -85,7 +84,7 @@ class CaldavSynchronizer @Inject constructor(
@param:ApplicationContext private val context: Context, @param:ApplicationContext private val context: Context,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val taskDeleter: TaskDeleter, private val taskDeleter: TaskDeleter,
private val inventory: Inventory, private val inventory: Inventory,
private val firebase: Firebase, private val firebase: Firebase,
@ -189,7 +188,7 @@ class CaldavSynchronizer @Inject constructor(
icon = icon ?: calendar.icon, icon = icon ?: calendar.icon,
) )
caldavDao.update(calendar) caldavDao.update(calendar)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
resource resource
.principals(account, calendar) .principals(account, calendar)
@ -204,11 +203,7 @@ class CaldavSynchronizer @Inject constructor(
private fun getServerType(account: CaldavAccount, headers: Headers) = when { private fun getServerType(account: CaldavAccount, headers: Headers) = when {
account.isTasksOrg -> SERVER_TASKS account.isTasksOrg -> SERVER_TASKS
headers["DAV"]?.contains("oc-resource-sharing") == true -> headers["DAV"]?.contains("oc-resource-sharing") == true -> SERVER_OWNCLOUD
if (headers["DAV"]?.let { it.contains("nextcloud-") || it.contains("nc-") } == true)
SERVER_NEXTCLOUD
else
SERVER_OWNCLOUD
headers["x-sabre-version"]?.isNotBlank() == true -> SERVER_SABREDAV headers["x-sabre-version"]?.isNotBlank() == true -> SERVER_SABREDAV
headers["server"] == "Openexchange WebDAV" -> SERVER_OPEN_XCHANGE headers["server"] == "Openexchange WebDAV" -> SERVER_OPEN_XCHANGE
else -> SERVER_UNKNOWN else -> SERVER_UNKNOWN
@ -225,7 +220,7 @@ class CaldavSynchronizer @Inject constructor(
} }
account.error = message account.error = message
caldavDao.update(account) caldavDao.update(account)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
if (!isNullOrEmpty(message)) { if (!isNullOrEmpty(message)) {
Timber.e(message) Timber.e(message)
} }
@ -302,7 +297,7 @@ class CaldavSynchronizer @Inject constructor(
caldavDao.update(caldavCalendar) caldavDao.update(caldavCalendar)
Timber.d("Updating parents for ${caldavCalendar.uuid}") Timber.d("Updating parents for ${caldavCalendar.uuid}")
caldavDao.updateParents(caldavCalendar.uuid!!) caldavDao.updateParents(caldavCalendar.uuid!!)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private suspend fun pushLocalChanges( private suspend fun pushLocalChanges(
@ -330,17 +325,9 @@ class CaldavSynchronizer @Inject constructor(
caldavTask: CaldavTask caldavTask: CaldavTask
): Boolean { ): Boolean {
try { try {
val objectId = caldavTask.obj if (!isNullOrEmpty(caldavTask.obj)) {
?: run {
Timber.e("null obj for caldavTask.id=${caldavTask.id} task.id=${caldavTask.task}")
caldavTask.obj = caldavTask.remoteId?.let { "$it.ics" }
caldavTask.obj
}
if (objectId?.isNotBlank() == true) {
val remote = DavResource( val remote = DavResource(
httpClient = httpClient, httpClient, httpUrl.newBuilder().addPathSegment(caldavTask.obj!!).build())
location = httpUrl.newBuilder().addPathSegment(objectId).build(),
)
remote.delete(null) {} remote.delete(null) {}
} }
} catch (e: HttpException) { } catch (e: HttpException) {
@ -364,8 +351,8 @@ class CaldavSynchronizer @Inject constructor(
httpClient: OkHttpClient, httpClient: OkHttpClient,
httpUrl: HttpUrl httpUrl: HttpUrl
) { ) {
Timber.d("pushing %s", task)
val caldavTask = caldavDao.getTask(task.id) ?: return val caldavTask = caldavDao.getTask(task.id) ?: return
Timber.d("pushing caldavTask=$caldavTask task=$task")
if (task.isDeleted) { if (task.isDeleted) {
if (deleteRemoteResource(httpClient, httpUrl, calendar, caldavTask)) { if (deleteRemoteResource(httpClient, httpUrl, calendar, caldavTask)) {
taskDeleter.delete(task) taskDeleter.delete(task)
@ -374,19 +361,9 @@ class CaldavSynchronizer @Inject constructor(
} }
val data = iCal.toVtodo(account, calendar, caldavTask, task) val data = iCal.toVtodo(account, calendar, caldavTask, task)
val requestBody = data.toRequestBody(contentType = MIME_ICALENDAR) val requestBody = data.toRequestBody(contentType = MIME_ICALENDAR)
val objPath = caldavTask.obj
?: run {
Timber.e("null obj for caldavTask.id=${caldavTask.id} task.id=${task.id}")
caldavTask.obj = caldavTask.remoteId?.let { "$it.ics" }
caldavTask.obj
}
?: throw IllegalStateException("Push failed - missing UUID")
try { try {
val remote = DavResource( val remote = DavResource(
httpClient = httpClient, httpClient, httpUrl.newBuilder().addPathSegment(caldavTask.obj!!).build())
location = httpUrl.newBuilder().addPathSegment(objPath).build(),
)
remote.put(requestBody) { remote.put(requestBody) {
if (it.isSuccessful) { if (it.isSuccessful) {
fromResponse(it)?.eTag?.takeIf(String::isNotBlank)?.let { etag -> fromResponse(it)?.eTag?.takeIf(String::isNotBlank)?.let { etag ->

@ -1,13 +1,16 @@
package org.tasks.caldav package org.tasks.caldav
import android.content.Context
import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import java.io.File import java.io.File
import javax.inject.Inject
class FileStorage( class FileStorage @Inject constructor(
rootPath: String @ApplicationContext context: Context
) { ) {
val root = File(rootPath, "vtodo") val root = File(context.filesDir, "vtodo")
@Suppress("NULLABILITY_MISMATCH_BASED_ON_JAVA_ANNOTATIONS") @Suppress("NULLABILITY_MISMATCH_BASED_ON_JAVA_ANNOTATIONS")
fun getFile(vararg segments: String?): File? = fun getFile(vararg segments: String?): File? =

@ -1,15 +1,18 @@
package org.tasks.caldav package org.tasks.caldav
import co.touchlab.kermit.Logger
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.entity.CaldavAccount import org.tasks.data.entity.CaldavAccount
import org.tasks.data.entity.CaldavCalendar import org.tasks.data.entity.CaldavCalendar
import org.tasks.data.entity.CaldavTask import org.tasks.data.entity.CaldavTask
import timber.log.Timber
import java.io.File import java.io.File
import javax.inject.Inject
import javax.inject.Singleton
class VtodoCache( @Singleton
class VtodoCache @Inject constructor(
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val fileStorage: FileStorage, private val fileStorage: FileStorage,
) { ) {
@ -27,7 +30,7 @@ class VtodoCache(
?: return@withContext ?: return@withContext
source.copyTo(target, overwrite = true) source.copyTo(target, overwrite = true)
val deleted = source.delete() val deleted = source.delete()
Logger.d("VtodoCache") { "Moved $source to $target [success=${deleted}]" } Timber.d("Moved $source to $target [success=${deleted}]")
} }
suspend fun getVtodo(caldavTask: CaldavTask?): String? { suspend fun getVtodo(caldavTask: CaldavTask?): String? {
@ -66,28 +69,28 @@ class VtodoCache(
suspend fun delete(calendar: CaldavCalendar, caldavTask: CaldavTask) = withContext(Dispatchers.IO) { suspend fun delete(calendar: CaldavCalendar, caldavTask: CaldavTask) = withContext(Dispatchers.IO) {
fileStorage.getFile(calendar.account, caldavTask.calendar, caldavTask.obj)?.let { fileStorage.getFile(calendar.account, caldavTask.calendar, caldavTask.obj)?.let {
val deleted = it.delete() val deleted = it.delete()
Logger.d("VtodoCache") { "Deleting $it [success=$deleted]" } Timber.d("Deleting $it [success=$deleted]")
} }
} }
suspend fun delete(calendar: CaldavCalendar) = withContext(Dispatchers.IO) { suspend fun delete(calendar: CaldavCalendar) = withContext(Dispatchers.IO) {
fileStorage.getFile(calendar.account, calendar.uuid)?.let { fileStorage.getFile(calendar.account, calendar.uuid)?.let {
val deleted = it.deleteRecursively() val deleted = it.deleteRecursively()
Logger.d("VtodoCache") { "Deleting $it [success=$deleted]" } Timber.d("Deleting $it [success=$deleted]")
} }
} }
suspend fun delete(account: CaldavAccount) = withContext(Dispatchers.IO) { suspend fun delete(account: CaldavAccount) = withContext(Dispatchers.IO) {
fileStorage.getFile(account.uuid)?.let { fileStorage.getFile(account.uuid)?.let {
val deleted = it.deleteRecursively() val deleted = it.deleteRecursively()
Logger.d("VtodoCache") { "Deleting $it [success=$deleted]" } Timber.d("Deleting $it [success=$deleted]")
} }
} }
suspend fun clear() = withContext(Dispatchers.IO) { suspend fun clear() = withContext(Dispatchers.IO) {
fileStorage.getFile()?.let { fileStorage.getFile()?.let {
val deleted = it.deleteRecursively() val deleted = it.deleteRecursively()
Logger.d("VtodoCache") { "Deleting $it [success=$deleted]" } Timber.d("Deleting $it [success=$deleted]")
} }
} }
} }

@ -25,11 +25,10 @@ import androidx.compose.material3.RadioButton
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue import androidx.compose.runtime.MutableState
import androidx.compose.runtime.mutableStateOf import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember import androidx.compose.runtime.remember
import androidx.compose.runtime.saveable.rememberSaveable import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment.Companion.CenterVertically import androidx.compose.ui.Alignment.Companion.CenterVertically
import androidx.compose.ui.ExperimentalComposeUiApi import androidx.compose.ui.ExperimentalComposeUiApi
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
@ -63,99 +62,141 @@ import java.util.concurrent.TimeUnit
@ExperimentalComposeUiApi @ExperimentalComposeUiApi
object AddReminderDialog { object AddReminderDialog {
// Helper functions for converting between Alarm properties and UI state
private fun unitIndexToMillis(unitIndex: Int): Long = when (unitIndex) {
1 -> TimeUnit.HOURS.toMillis(1)
2 -> TimeUnit.DAYS.toMillis(1)
3 -> TimeUnit.DAYS.toMillis(7)
else -> TimeUnit.MINUTES.toMillis(1)
}
private fun timeToAmountAndUnit(time: Long): Pair<Int, Int> {
val absTime = kotlin.math.abs(time)
return when {
absTime == 0L -> 0 to 0 // Default to minutes when time is 0
absTime % TimeUnit.DAYS.toMillis(7) == 0L ->
(absTime / TimeUnit.DAYS.toMillis(7)).toInt() to 3
absTime % TimeUnit.DAYS.toMillis(1) == 0L ->
(absTime / TimeUnit.DAYS.toMillis(1)).toInt() to 2
absTime % TimeUnit.HOURS.toMillis(1) == 0L ->
(absTime / TimeUnit.HOURS.toMillis(1)).toInt() to 1
else ->
(absTime / TimeUnit.MINUTES.toMillis(1)).toInt() to 0
}
}
@Composable @Composable
fun AddRandomReminderDialog( fun AddRandomReminderDialog(
alarm: Alarm?, viewState: ViewState,
updateAlarm: (Alarm) -> Unit, addAlarm: (Alarm) -> Unit,
closeDialog: () -> Unit, closeDialog: () -> Unit,
) { ) {
// Create working copy from alarm or use defaults val time = rememberSaveable { mutableStateOf(15) }
var workingCopy by rememberSaveable { val units = rememberSaveable { mutableStateOf(0) }
mutableStateOf(alarm ?: Alarm(time = 15 * TimeUnit.MINUTES.toMillis(1), type = TYPE_RANDOM)) if (viewState.showRandomDialog) {
AlertDialog(
onDismissRequest = closeDialog,
text = { AddRandomReminder(time, units) },
confirmButton = {
Constants.TextButton(text = R.string.ok, onClick = {
time.value.takeIf { it > 0 }?.let { i ->
addAlarm(Alarm(time = i * units.millis, type = TYPE_RANDOM))
closeDialog()
}
})
},
dismissButton = {
Constants.TextButton(
text = R.string.cancel,
onClick = closeDialog
)
},
)
} else {
time.value = 15
units.value = 0
} }
AlertDialog(
onDismissRequest = closeDialog,
text = {
AddRandomReminder(
alarm = workingCopy,
updateAlarm = { workingCopy = it }
)
},
confirmButton = {
Constants.TextButton(text = R.string.ok, onClick = {
val (amount, _) = timeToAmountAndUnit(workingCopy.time)
if (amount > 0) {
updateAlarm(workingCopy)
closeDialog()
}
})
},
dismissButton = {
Constants.TextButton(
text = R.string.cancel,
onClick = closeDialog
)
},
)
} }
@Composable @Composable
fun AddCustomReminderDialog( fun AddCustomReminderDialog(
alarm: Alarm?, viewState: ViewState,
updateAlarm: (Alarm) -> Unit, addAlarm: (Alarm) -> Unit,
closeDialog: () -> Unit, closeDialog: () -> Unit,
) { ) {
// Create working copy from alarm or use defaults val openDialog = viewState.showCustomDialog
var workingCopy by rememberSaveable { val time = rememberSaveable { mutableStateOf(15) }
mutableStateOf( val units = rememberSaveable { mutableStateOf(0) }
alarm ?: Alarm( val openRecurringDialog = rememberSaveable { mutableStateOf(false) }
time = -1 * 15 * TimeUnit.MINUTES.toMillis(1), val interval = rememberSaveable { mutableStateOf(0) }
type = TYPE_REL_END val recurringUnits = rememberSaveable { mutableStateOf(0) }
val repeat = rememberSaveable { mutableStateOf(0) }
if (openDialog) {
if (!openRecurringDialog.value) {
AlertDialog(
onDismissRequest = closeDialog,
text = {
AddCustomReminder(
time,
units,
interval,
recurringUnits,
repeat,
showRecurring = {
openRecurringDialog.value = true
}
)
},
confirmButton = {
Constants.TextButton(text = R.string.ok, onClick = {
time.value.takeIf { it >= 0 }?.let { i ->
addAlarm(
Alarm(
time = -1 * i * units.millis,
type = TYPE_REL_END,
repeat = repeat.value,
interval = interval.value * recurringUnits.millis
)
)
closeDialog()
}
})
},
dismissButton = {
Constants.TextButton(
text = R.string.cancel,
onClick = closeDialog
)
},
) )
}
AddRepeatReminderDialog(
openDialog = openRecurringDialog,
initialInterval = interval.value,
initialUnits = recurringUnits.value,
initialRepeat = repeat.value,
selected = { i, u, r ->
interval.value = i
recurringUnits.value = u
repeat.value = r
}
) )
} else {
time.value = 15
units.value = 0
interval.value = 0
recurringUnits.value = 0
repeat.value = 0
} }
var showRecurringDialog by rememberSaveable { mutableStateOf(false) } }
if (!showRecurringDialog) { @Composable
fun AddRepeatReminderDialog(
openDialog: MutableState<Boolean>,
initialInterval: Int,
initialUnits: Int,
initialRepeat: Int,
selected: (Int, Int, Int) -> Unit,
) {
val interval = rememberSaveable { mutableStateOf(initialInterval) }
val units = rememberSaveable { mutableStateOf(initialUnits) }
val repeat = rememberSaveable { mutableStateOf(initialRepeat) }
val closeDialog = {
openDialog.value = false
}
if (openDialog.value) {
AlertDialog( AlertDialog(
onDismissRequest = closeDialog, onDismissRequest = closeDialog,
text = { text = {
AddCustomReminder( AddRecurringReminder(
alarm = workingCopy, openDialog.value,
updateAlarm = { workingCopy = it }, interval,
showRecurring = { showRecurringDialog = true } units,
repeat,
) )
}, },
confirmButton = { confirmButton = {
Constants.TextButton(text = R.string.ok, onClick = { Constants.TextButton(text = R.string.ok, onClick = {
val (amount, _) = timeToAmountAndUnit(workingCopy.time) if (interval.value > 0 && repeat.value > 0) {
if (amount >= 0) { selected(interval.value, units.value, repeat.value)
updateAlarm(workingCopy) openDialog.value = false
closeDialog()
} }
}) })
}, },
@ -166,74 +207,19 @@ object AddReminderDialog {
) )
}, },
) )
} else {
interval.value = initialInterval.takeIf { it > 0 } ?: 15
units.value = initialUnits
repeat.value = initialRepeat.takeIf { it > 0 } ?: 4
} }
if (showRecurringDialog) {
AddRepeatReminderDialog(
alarm = workingCopy,
updateAlarm = { workingCopy = it },
closeDialog = { showRecurringDialog = false }
)
}
}
@Composable
fun AddRepeatReminderDialog(
alarm: Alarm,
updateAlarm: (Alarm) -> Unit,
closeDialog: () -> Unit,
) {
// Create working copy with defaults if no recurrence set
var workingCopy by rememberSaveable {
mutableStateOf(
if (alarm.interval == 0L && alarm.repeat == 0) {
// Default to 15 minutes, 4 times
alarm.copy(
interval = 15 * TimeUnit.MINUTES.toMillis(1),
repeat = 4
)
} else {
alarm
}
)
}
AlertDialog(
onDismissRequest = closeDialog,
text = {
AddRecurringReminder(
alarm = workingCopy,
updateAlarm = { workingCopy = it }
)
},
confirmButton = {
Constants.TextButton(text = R.string.ok, onClick = {
val (intervalAmount, _) = timeToAmountAndUnit(workingCopy.interval)
if (intervalAmount > 0 && workingCopy.repeat > 0) {
updateAlarm(workingCopy)
closeDialog()
}
})
},
dismissButton = {
Constants.TextButton(
text = R.string.cancel,
onClick = closeDialog
)
},
)
} }
@Composable @Composable
fun AddRandomReminder( fun AddRandomReminder(
alarm: Alarm, time: MutableState<Int>,
updateAlarm: (Alarm) -> Unit, units: MutableState<Int>,
) { ) {
val (initialAmount, initialUnit) = timeToAmountAndUnit(alarm.time)
var selectedUnit by rememberSaveable { mutableStateOf(initialUnit) }
val amount = if (alarm.time == 0L) 0 else (alarm.time / unitIndexToMillis(selectedUnit)).toInt()
val scrollState = rememberScrollState() val scrollState = rememberScrollState()
Column( Column(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
@ -242,27 +228,14 @@ object AddReminderDialog {
CenteredH6(text = stringResource(id = R.string.randomly_every, "").trim()) CenteredH6(text = stringResource(id = R.string.randomly_every, "").trim())
val focusRequester = remember { FocusRequester() } val focusRequester = remember { FocusRequester() }
OutlinedIntInput( OutlinedIntInput(
value = amount, time,
onValueChange = { newAmount ->
val amt = newAmount ?: 0
updateAlarm(alarm.copy(time = amt * unitIndexToMillis(selectedUnit)))
},
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.focusRequester(focusRequester) .focusRequester(focusRequester)
) )
Spacer(modifier = Modifier.height(16.dp)) Spacer(modifier = Modifier.height(16.dp))
options.forEachIndexed { index, option -> options.forEachIndexed { index, option ->
RadioRow( RadioRow(index, option, time, units)
index = index,
option = option,
timeAmount = amount,
unitIndex = selectedUnit,
onUnitSelected = { newUnit ->
selectedUnit = newUnit
updateAlarm(alarm.copy(time = amount * unitIndexToMillis(newUnit)))
}
)
} }
ShowKeyboard(true, focusRequester) ShowKeyboard(true, focusRequester)
} }
@ -270,19 +243,14 @@ object AddReminderDialog {
@Composable @Composable
fun AddCustomReminder( fun AddCustomReminder(
alarm: Alarm, time: MutableState<Int>,
updateAlarm: (Alarm) -> Unit, units: MutableState<Int>,
interval: MutableState<Int>,
recurringUnits: MutableState<Int>,
repeat: MutableState<Int>,
showRecurring: () -> Unit, showRecurring: () -> Unit,
) { ) {
val (initialAmount, initialUnit) = timeToAmountAndUnit(alarm.time)
var selectedUnit by rememberSaveable { mutableStateOf(initialUnit) }
val amount = if (alarm.time == 0L) 0 else kotlin.math.abs(alarm.time / unitIndexToMillis(selectedUnit)).toInt()
val (initialIntervalAmount, initialIntervalUnit) = timeToAmountAndUnit(alarm.interval)
val intervalAmount = if (alarm.interval == 0L) 0 else (alarm.interval / unitIndexToMillis(initialIntervalUnit)).toInt()
val scrollState = rememberScrollState() val scrollState = rememberScrollState()
Column( Column(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
@ -291,11 +259,7 @@ object AddReminderDialog {
CenteredH6(resId = R.string.custom_notification) CenteredH6(resId = R.string.custom_notification)
val focusRequester = remember { FocusRequester() } val focusRequester = remember { FocusRequester() }
OutlinedIntInput( OutlinedIntInput(
value = amount, time,
onValueChange = { newAmount ->
val amt = newAmount ?: 0
updateAlarm(alarm.copy(time = -1 * amt * unitIndexToMillis(selectedUnit)))
},
minValue = 0, minValue = 0,
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
@ -303,17 +267,7 @@ object AddReminderDialog {
) )
Spacer(modifier = Modifier.height(16.dp)) Spacer(modifier = Modifier.height(16.dp))
options.forEachIndexed { index, option -> options.forEachIndexed { index, option ->
RadioRow( RadioRow(index, option, time, units, R.string.alarm_before_due)
index = index,
option = option,
timeAmount = amount,
unitIndex = selectedUnit,
onUnitSelected = { newUnit ->
selectedUnit = newUnit
updateAlarm(alarm.copy(time = -1 * amount * unitIndexToMillis(newUnit)))
},
formatString = R.string.alarm_before_due
)
} }
Divider(modifier = Modifier.padding(vertical = 4.dp), thickness = 1.dp) Divider(modifier = Modifier.padding(vertical = 4.dp), thickness = 1.dp)
Row(modifier = Modifier Row(modifier = Modifier
@ -334,11 +288,11 @@ object AddReminderDialog {
), ),
) )
} }
val repeating = alarm.repeat > 0 && intervalAmount > 0 val repeating = repeat.value > 0 && interval.value > 0
val text = if (repeating) { val text = if (repeating) {
LocalContext.current.resources.getRepeatString( LocalContext.current.resources.getRepeatString(
alarm.repeat, repeat.value,
alarm.interval interval.value * recurringUnits.millis
) )
} else { } else {
stringResource(id = R.string.repeat_option_does_not_repeat) stringResource(id = R.string.repeat_option_does_not_repeat)
@ -351,9 +305,11 @@ object AddReminderDialog {
.align(CenterVertically) .align(CenterVertically)
) )
if (repeating) { if (repeating) {
ClearButton(onClick = { ClearButton {
updateAlarm(alarm.copy(repeat = 0, interval = 0)) repeat.value = 0
}) interval.value = 0
recurringUnits.value = 0
}
} }
} }
ShowKeyboard(true, focusRequester) ShowKeyboard(true, focusRequester)
@ -362,14 +318,12 @@ object AddReminderDialog {
@Composable @Composable
fun AddRecurringReminder( fun AddRecurringReminder(
alarm: Alarm, openDialog: Boolean,
updateAlarm: (Alarm) -> Unit, interval: MutableState<Int>,
units: MutableState<Int>,
repeat: MutableState<Int>
) { ) {
val (initialIntervalAmount, initialIntervalUnit) = timeToAmountAndUnit(alarm.interval)
var selectedUnit by rememberSaveable { mutableStateOf(initialIntervalUnit) }
val intervalAmount = if (alarm.interval == 0L) 0 else (alarm.interval / unitIndexToMillis(selectedUnit)).toInt()
val scrollState = rememberScrollState() val scrollState = rememberScrollState()
Column( Column(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
@ -378,40 +332,24 @@ object AddReminderDialog {
CenteredH6(text = stringResource(id = R.string.repeats_plural, "").trim()) CenteredH6(text = stringResource(id = R.string.repeats_plural, "").trim())
val focusRequester = remember { FocusRequester() } val focusRequester = remember { FocusRequester() }
OutlinedIntInput( OutlinedIntInput(
value = intervalAmount, time = interval,
onValueChange = { newAmount ->
val amt = newAmount ?: 0
updateAlarm(alarm.copy(interval = amt * unitIndexToMillis(selectedUnit)))
},
modifier = Modifier.focusRequester(focusRequester), modifier = Modifier.focusRequester(focusRequester),
) )
Spacer(modifier = Modifier.height(16.dp)) Spacer(modifier = Modifier.height(16.dp))
options.forEachIndexed { index, option -> options.forEachIndexed { index, option ->
RadioRow( RadioRow(index, option, interval, units)
index = index,
option = option,
timeAmount = intervalAmount,
unitIndex = selectedUnit,
onUnitSelected = { newUnit ->
selectedUnit = newUnit
updateAlarm(alarm.copy(interval = intervalAmount * unitIndexToMillis(newUnit)))
}
)
} }
Divider(modifier = Modifier.padding(vertical = 4.dp), thickness = 1.dp) Divider(modifier = Modifier.padding(vertical = 4.dp), thickness = 1.dp)
Row(modifier = Modifier.fillMaxWidth()) { Row(modifier = Modifier.fillMaxWidth()) {
OutlinedIntInput( OutlinedIntInput(
value = alarm.repeat, time = repeat,
onValueChange = { newRepeat ->
updateAlarm(alarm.copy(repeat = newRepeat ?: 0))
},
modifier = Modifier.weight(0.5f), modifier = Modifier.weight(0.5f),
autoSelect = false, autoSelect = false,
) )
BodyText( BodyText(
text = LocalContext.current.resources.getQuantityString( text = LocalContext.current.resources.getQuantityString(
R.plurals.repeat_times, R.plurals.repeat_times,
alarm.repeat repeat.value
), ),
modifier = Modifier modifier = Modifier
.weight(0.5f) .weight(0.5f)
@ -419,7 +357,7 @@ object AddReminderDialog {
) )
} }
ShowKeyboard(true, focusRequester) ShowKeyboard(openDialog, focusRequester)
} }
} }
@ -429,6 +367,14 @@ object AddReminderDialog {
R.plurals.reminder_days, R.plurals.reminder_days,
R.plurals.reminder_week, R.plurals.reminder_week,
) )
private val MutableState<Int>.millis: Long
get() = when (value) {
1 -> TimeUnit.HOURS.toMillis(1)
2 -> TimeUnit.DAYS.toMillis(1)
3 -> TimeUnit.DAYS.toMillis(7)
else -> TimeUnit.MINUTES.toMillis(1)
}
} }
@ExperimentalComposeUiApi @ExperimentalComposeUiApi
@ -445,48 +391,25 @@ fun ShowKeyboard(visible: Boolean, focusRequester: FocusRequester) {
@Composable @Composable
fun OutlinedIntInput( fun OutlinedIntInput(
value: Int?, time: MutableState<Int>,
onValueChange: (Int?) -> Unit,
modifier: Modifier = Modifier, modifier: Modifier = Modifier,
minValue: Int = 1, minValue: Int = 1,
autoSelect: Boolean = true, autoSelect: Boolean = true,
) { ) {
var textFieldValue by remember { val value = rememberSaveable(stateSaver = TextFieldValue.Saver) {
val text = time.value.toString()
mutableStateOf( mutableStateOf(
TextFieldValue( TextFieldValue(
text = value?.toString() ?: "", text = text,
selection = if (autoSelect) { selection = TextRange(0, if (autoSelect) text.length else 0)
TextRange(0, value?.toString()?.length ?: 0)
} else {
TextRange.Zero
}
) )
) )
} }
// Sync when external value changes, but don't interfere with user editing
LaunchedEffect(value) {
val currentParsedValue = textFieldValue.text.toIntOrNull()
// Only sync if the new value is different from what we currently parse to,
// and don't sync if the text field is empty (user is actively deleting)
if (currentParsedValue != value && textFieldValue.text.isNotEmpty()) {
val newText = value?.toString() ?: ""
textFieldValue = TextFieldValue(
text = newText,
selection = if (autoSelect) {
TextRange(0, newText.length)
} else {
textFieldValue.selection
}
)
}
}
OutlinedTextField( OutlinedTextField(
value = textFieldValue, value = value.value,
onValueChange = { onValueChange = {
textFieldValue = it.copy(text = it.text.filter { t -> t.isDigit() }) value.value = it.copy(text = it.text.filter { t -> t.isDigit() })
onValueChange(textFieldValue.text.toIntOrNull()) time.value = value.value.text.toIntOrNull() ?: 0
}, },
keyboardOptions = KeyboardOptions(keyboardType = KeyboardType.Number), keyboardOptions = KeyboardOptions(keyboardType = KeyboardType.Number),
modifier = modifier.padding(horizontal = 16.dp), modifier = modifier.padding(horizontal = 16.dp),
@ -496,7 +419,7 @@ fun OutlinedIntInput(
focusedBorderColor = MaterialTheme.colorScheme.onSurface, focusedBorderColor = MaterialTheme.colorScheme.onSurface,
unfocusedBorderColor = MaterialTheme.colorScheme.onSurface, unfocusedBorderColor = MaterialTheme.colorScheme.onSurface,
), ),
isError = textFieldValue.text.toIntOrNull()?.let { it < minValue } ?: true, isError = value.value.text.toIntOrNull()?.let { it < minValue } ?: true,
) )
} }
@ -522,24 +445,23 @@ fun CenteredH6(text: String) {
fun RadioRow( fun RadioRow(
index: Int, index: Int,
option: Int, option: Int,
timeAmount: Int, time: MutableState<Int>,
unitIndex: Int, units: MutableState<Int>,
onUnitSelected: (Int) -> Unit,
formatString: Int? = null, formatString: Int? = null,
) { ) {
val optionString = LocalContext.current.resources.getQuantityString(option, timeAmount) val optionString = LocalContext.current.resources.getQuantityString(option, time.value)
Row( Row(
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()
.clickable { onUnitSelected(index) } .clickable { units.value = index }
) { ) {
RadioButton( RadioButton(
selected = index == unitIndex, selected = index == units.value,
onClick = { onUnitSelected(index) }, onClick = { units.value = index },
modifier = Modifier.align(CenterVertically) modifier = Modifier.align(CenterVertically)
) )
BodyText( BodyText(
text = if (index == unitIndex) { text = if (index == units.value) {
formatString formatString
?.let { stringResource(id = formatString, optionString) } ?.let { stringResource(id = formatString, optionString) }
?: optionString ?: optionString
@ -584,14 +506,8 @@ fun AddAlarmDialog(
dismiss() dismiss()
return return
} }
TYPE_REL_END -> { // TODO: if replacing custom alarm show custom picker
if (viewState.replace.time < 0) { // TODO: prepopulate pickers with existing values
// Custom reminder (before due)
addCustom()
dismiss()
return
}
}
} }
} }
CustomDialog(visible = viewState.showAddAlarm, onDismiss = dismiss) { CustomDialog(visible = viewState.showAddAlarm, onDismiss = dismiss) {
@ -639,11 +555,11 @@ fun AddAlarmDialog(
fun AddCustomReminderOne() = fun AddCustomReminderOne() =
TasksTheme { TasksTheme {
AddReminderDialog.AddCustomReminder( AddReminderDialog.AddCustomReminder(
alarm = Alarm( time = remember { mutableStateOf(1) },
time = -1 * TimeUnit.MINUTES.toMillis(1), units = remember { mutableStateOf(0) },
type = TYPE_REL_END interval = remember { mutableStateOf(0) },
), recurringUnits = remember { mutableStateOf(0) },
updateAlarm = {}, repeat = remember { mutableStateOf(0) },
showRecurring = {}, showRecurring = {},
) )
} }
@ -655,11 +571,11 @@ fun AddCustomReminderOne() =
fun AddCustomReminder() = fun AddCustomReminder() =
TasksTheme { TasksTheme {
AddReminderDialog.AddCustomReminder( AddReminderDialog.AddCustomReminder(
alarm = Alarm( time = remember { mutableStateOf(15) },
time = -15 * TimeUnit.HOURS.toMillis(1), units = remember { mutableStateOf(1) },
type = TYPE_REL_END interval = remember { mutableStateOf(0) },
), recurringUnits = remember { mutableStateOf(0) },
updateAlarm = {}, repeat = remember { mutableStateOf(0) },
showRecurring = {}, showRecurring = {},
) )
} }
@ -671,13 +587,10 @@ fun AddCustomReminder() =
fun AddRepeatingReminderOne() = fun AddRepeatingReminderOne() =
TasksTheme { TasksTheme {
AddReminderDialog.AddRecurringReminder( AddReminderDialog.AddRecurringReminder(
alarm = Alarm( openDialog = true,
time = -1 * TimeUnit.MINUTES.toMillis(1), interval = remember { mutableStateOf(1) },
type = TYPE_REL_END, units = remember { mutableStateOf(0) },
interval = TimeUnit.MINUTES.toMillis(1), repeat = remember { mutableStateOf(1) },
repeat = 1
),
updateAlarm = {},
) )
} }
@ -688,13 +601,10 @@ fun AddRepeatingReminderOne() =
fun AddRepeatingReminder() = fun AddRepeatingReminder() =
TasksTheme { TasksTheme {
AddReminderDialog.AddRecurringReminder( AddReminderDialog.AddRecurringReminder(
alarm = Alarm( openDialog = true,
time = -15 * TimeUnit.HOURS.toMillis(1), interval = remember { mutableStateOf(15) },
type = TYPE_REL_END, units = remember { mutableStateOf(1) },
interval = 15 * TimeUnit.HOURS.toMillis(1), repeat = remember { mutableStateOf(4) },
repeat = 4
),
updateAlarm = {},
) )
} }
@ -705,11 +615,8 @@ fun AddRepeatingReminder() =
fun AddRandomReminderOne() = fun AddRandomReminderOne() =
TasksTheme { TasksTheme {
AddReminderDialog.AddRandomReminder( AddReminderDialog.AddRandomReminder(
alarm = Alarm( time = remember { mutableStateOf(1) },
time = TimeUnit.MINUTES.toMillis(1), units = remember { mutableStateOf(0) }
type = TYPE_RANDOM
),
updateAlarm = {}
) )
} }
@ -720,11 +627,8 @@ fun AddRandomReminderOne() =
fun AddRandomReminder() = fun AddRandomReminder() =
TasksTheme { TasksTheme {
AddReminderDialog.AddRandomReminder( AddReminderDialog.AddRandomReminder(
alarm = Alarm( time = remember { mutableStateOf(15) },
time = 15 * TimeUnit.HOURS.toMillis(1), units = remember { mutableStateOf(1) }
type = TYPE_RANDOM
),
updateAlarm = {}
) )
} }

@ -23,7 +23,6 @@ import androidx.compose.foundation.lazy.itemsIndexed
import androidx.compose.foundation.lazy.rememberLazyListState import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.foundation.rememberScrollState import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.RoundedCornerShape import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.foundation.verticalScroll import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.outlined.Abc import androidx.compose.material.icons.outlined.Abc
@ -55,7 +54,6 @@ import androidx.compose.ui.res.colorResource
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.input.KeyboardCapitalization
import androidx.compose.ui.text.style.TextAlign import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.text.style.TextDirection import androidx.compose.ui.text.style.TextDirection
import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.text.style.TextOverflow
@ -386,31 +384,16 @@ object FilterCondition {
Row { Row {
for (index in items.indices) { for (index in items.indices) {
val highlight = (index == selected.intValue) val highlight = (index == selected.intValue)
val color =
if (highlight) MaterialTheme.colorScheme.secondary.copy(alpha = 0.5f)
else MaterialTheme.colorScheme.onBackground.copy(alpha = 0.5f)
OutlinedButton( OutlinedButton(
onClick = { selected.intValue = index }, onClick = { selected.intValue = index },
border = BorderStroke( border = BorderStroke(1.dp, SolidColor(color.copy(alpha = 0.5f))),
width = 1.dp,
brush = SolidColor(
if (highlight) {
MaterialTheme.colorScheme.primary
} else {
MaterialTheme.colorScheme.onBackground.copy(alpha = 0.5f)
}
)
),
colors = ButtonDefaults.outlinedButtonColors( colors = ButtonDefaults.outlinedButtonColors(
containerColor = if (highlight) { containerColor = color.copy(alpha = 0.2f),
MaterialTheme.colorScheme.primary contentColor = MaterialTheme.colorScheme.onBackground),
} else { shape = RoundedCornerShape(Constants.HALF_KEYLINE)
MaterialTheme.colorScheme.onBackground.copy(alpha = 0.2f)
},
contentColor = if (highlight) {
MaterialTheme.colorScheme.onPrimary
} else {
MaterialTheme.colorScheme.onBackground
},
),
shape = RoundedCornerShape(Constants.HALF_KEYLINE),
) { ) {
Text(items[index]) Text(items[index])
} }
@ -501,9 +484,6 @@ object FilterCondition {
contentDescription = null contentDescription = null
) )
}, },
keyboardOptions = KeyboardOptions(
capitalization = KeyboardCapitalization.Sentences
),
textStyle = MaterialTheme.typography.bodyMedium.copy( textStyle = MaterialTheme.typography.bodyMedium.copy(
textDirection = TextDirection.Content textDirection = TextDirection.Content
), ),

@ -106,27 +106,23 @@ fun AlarmRow(
dismiss = { vm.showAddAlarm(visible = false) }, dismiss = { vm.showAddAlarm(visible = false) },
) )
if (viewState.showCustomDialog) { AddReminderDialog.AddCustomReminderDialog(
AddReminderDialog.AddCustomReminderDialog( viewState = viewState,
alarm = viewState.replace, addAlarm = {
updateAlarm = { viewState.replace?.let(deleteAlarm)
viewState.replace?.let(deleteAlarm) addAlarm(it)
addAlarm(it) },
}, closeDialog = { vm.showCustomDialog(visible = false) }
closeDialog = { vm.showCustomDialog(visible = false) } )
)
}
if (viewState.showRandomDialog) { AddReminderDialog.AddRandomReminderDialog(
AddReminderDialog.AddRandomReminderDialog( viewState = viewState,
alarm = viewState.replace, addAlarm = {
updateAlarm = { viewState.replace?.let(deleteAlarm)
viewState.replace?.let(deleteAlarm) addAlarm(it)
addAlarm(it) },
}, closeDialog = { vm.showRandomDialog(visible = false) }
closeDialog = { vm.showRandomDialog(visible = false) } )
)
}
}, },
) )
} }

@ -5,13 +5,10 @@ import androidx.activity.enableEdgeToEdge
import androidx.appcompat.app.AppCompatActivity import androidx.appcompat.app.AppCompatActivity
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.ColumnScope import androidx.compose.foundation.layout.ColumnScope
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.WindowInsetsSides import androidx.compose.foundation.layout.WindowInsetsSides
import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.ime
import androidx.compose.foundation.layout.only import androidx.compose.foundation.layout.only
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.union
import androidx.compose.foundation.rememberScrollState import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons import androidx.compose.material.icons.Icons
@ -20,7 +17,6 @@ import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton import androidx.compose.material3.IconButton
import androidx.compose.material3.Scaffold import androidx.compose.material3.Scaffold
import androidx.compose.material3.ScaffoldDefaults
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.material3.TopAppBar import androidx.compose.material3.TopAppBar
import androidx.compose.material3.TopAppBarDefaults import androidx.compose.material3.TopAppBarDefaults
@ -50,7 +46,6 @@ fun ListSettingsScaffold(
content: @Composable ColumnScope.() -> Unit, content: @Composable ColumnScope.() -> Unit,
) { ) {
Scaffold( Scaffold(
contentWindowInsets = ScaffoldDefaults.contentWindowInsets.union(WindowInsets.ime),
topBar = { topBar = {
Column { Column {
val context = LocalContext.current val context = LocalContext.current

@ -5,7 +5,6 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.text.BasicTextField import androidx.compose.foundation.text.BasicTextField
import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.material3.HorizontalDivider import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.LocalContentColor import androidx.compose.material3.LocalContentColor
import androidx.compose.material3.LocalTextStyle import androidx.compose.material3.LocalTextStyle
@ -25,7 +24,6 @@ import androidx.compose.ui.platform.LocalSoftwareKeyboardController
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.TextStyle import androidx.compose.ui.text.TextStyle
import androidx.compose.ui.text.font.FontWeight import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.input.KeyboardCapitalization
import androidx.compose.ui.text.style.TextDirection import androidx.compose.ui.text.style.TextDirection
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp import androidx.compose.ui.unit.sp
@ -75,9 +73,6 @@ fun TitleInput(
color = LocalContentColor.current color = LocalContentColor.current
), ),
onValueChange = { setText(it) }, onValueChange = { setText(it) },
keyboardOptions = KeyboardOptions(
capitalization = KeyboardCapitalization.Sentences
),
cursorBrush = SolidColor(errorState), // SolidColor(LocalContentColor.current), cursorBrush = SolidColor(errorState), // SolidColor(LocalContentColor.current),
modifier = Modifier modifier = Modifier
.fillMaxWidth() .fillMaxWidth()

@ -3,14 +3,15 @@ package org.tasks.data
import android.content.ContentUris import android.content.ContentUris
import android.database.Cursor import android.database.Cursor
import android.net.Uri import android.net.Uri
import at.bitfire.ical4android.AndroidTask
import at.bitfire.ical4android.BatchOperation import at.bitfire.ical4android.BatchOperation
import at.bitfire.ical4android.BatchOperation.CpoBuilder.Companion.newInsert import at.bitfire.ical4android.BatchOperation.CpoBuilder.Companion.newInsert
import at.bitfire.ical4android.BatchOperation.CpoBuilder.Companion.newUpdate import at.bitfire.ical4android.BatchOperation.CpoBuilder.Companion.newUpdate
import at.bitfire.ical4android.DmfsTask
import at.bitfire.ical4android.ICalendar import at.bitfire.ical4android.ICalendar
import at.bitfire.ical4android.Ical4Android
import at.bitfire.ical4android.Task import at.bitfire.ical4android.Task
import at.bitfire.ical4android.UnknownProperty import at.bitfire.ical4android.UnknownProperty
import at.bitfire.ical4android.util.MiscUtils.toValues import at.bitfire.ical4android.util.MiscUtils.CursorHelper.toValues
import net.fortuna.ical4j.model.Parameter import net.fortuna.ical4j.model.Parameter
import net.fortuna.ical4j.model.parameter.RelType import net.fortuna.ical4j.model.parameter.RelType
import net.fortuna.ical4j.model.parameter.Related import net.fortuna.ical4j.model.parameter.Related
@ -20,7 +21,7 @@ import org.tasks.data.OpenTaskDao.Companion.getLong
import java.util.Locale import java.util.Locale
import java.util.logging.Level import java.util.logging.Level
class MyAndroidTask() : DmfsTask(null) { class MyAndroidTask() : AndroidTask(null) {
constructor(cursor: Cursor) : this() { constructor(cursor: Cursor) : this() {
val values = cursor.toValues() val values = cursor.toValues()
@ -98,7 +99,7 @@ class MyAndroidTask() : DmfsTask(null) {
.withValue(TaskContract.Property.Alarm.MESSAGE, alarm.description?.value ?: alarm.summary) .withValue(TaskContract.Property.Alarm.MESSAGE, alarm.description?.value ?: alarm.summary)
.withValue(TaskContract.Property.Alarm.ALARM_TYPE, alarmType) .withValue(TaskContract.Property.Alarm.ALARM_TYPE, alarmType)
logger.log(Level.FINE, "Inserting alarm", builder.build()) Ical4Android.log.log(Level.FINE, "Inserting alarm", builder.build())
batch.add(builder) batch.add(builder)
} }
} }
@ -109,7 +110,7 @@ class MyAndroidTask() : DmfsTask(null) {
.withTaskId(TaskContract.Property.Category.TASK_ID, idxTask) .withTaskId(TaskContract.Property.Category.TASK_ID, idxTask)
.withValue(TaskContract.Property.Category.MIMETYPE, TaskContract.Property.Category.CONTENT_ITEM_TYPE) .withValue(TaskContract.Property.Category.MIMETYPE, TaskContract.Property.Category.CONTENT_ITEM_TYPE)
.withValue(TaskContract.Property.Category.CATEGORY_NAME, category) .withValue(TaskContract.Property.Category.CATEGORY_NAME, category)
logger.log(Level.FINE, "Inserting category", builder.build()) Ical4Android.log.log(Level.FINE, "Inserting category", builder.build())
batch.add(builder) batch.add(builder)
} }
} }
@ -129,7 +130,7 @@ class MyAndroidTask() : DmfsTask(null) {
.withValue(TaskContract.Property.Relation.MIMETYPE, TaskContract.Property.Relation.CONTENT_ITEM_TYPE) .withValue(TaskContract.Property.Relation.MIMETYPE, TaskContract.Property.Relation.CONTENT_ITEM_TYPE)
.withValue(TaskContract.Property.Relation.RELATED_UID, relatedTo.value) .withValue(TaskContract.Property.Relation.RELATED_UID, relatedTo.value)
.withValue(TaskContract.Property.Relation.RELATED_TYPE, relType) .withValue(TaskContract.Property.Relation.RELATED_TYPE, relType)
logger.log(Level.FINE, "Inserting relation", builder.build()) Ical4Android.log.log(Level.FINE, "Inserting relation", builder.build())
batch.add(builder) batch.add(builder)
} }
} }
@ -137,7 +138,7 @@ class MyAndroidTask() : DmfsTask(null) {
private fun insertUnknownProperties(batch: MutableList<BatchOperation.CpoBuilder>, idxTask: Int?, uri: Uri) { private fun insertUnknownProperties(batch: MutableList<BatchOperation.CpoBuilder>, idxTask: Int?, uri: Uri) {
for (property in requireNotNull(task).unknownProperties) { for (property in requireNotNull(task).unknownProperties) {
if (property.value.length > UnknownProperty.MAX_UNKNOWN_PROPERTY_SIZE) { if (property.value.length > UnknownProperty.MAX_UNKNOWN_PROPERTY_SIZE) {
logger.warning("Ignoring unknown property with ${property.value.length} octets (too long)") Ical4Android.log.warning("Ignoring unknown property with ${property.value.length} octets (too long)")
return return
} }
@ -145,7 +146,7 @@ class MyAndroidTask() : DmfsTask(null) {
.withTaskId(TaskContract.Properties.TASK_ID, idxTask) .withTaskId(TaskContract.Properties.TASK_ID, idxTask)
.withValue(TaskContract.Properties.MIMETYPE, UnknownProperty.CONTENT_ITEM_TYPE) .withValue(TaskContract.Properties.MIMETYPE, UnknownProperty.CONTENT_ITEM_TYPE)
.withValue(UNKNOWN_PROPERTY_DATA, UnknownProperty.toJsonString(property)) .withValue(UNKNOWN_PROPERTY_DATA, UnknownProperty.toJsonString(property))
logger.log(Level.FINE, "Inserting unknown property", builder.build()) Ical4Android.log.log(Level.FINE, "Inserting unknown property", builder.build())
batch.add(builder) batch.add(builder)
} }
} }

@ -86,7 +86,7 @@ class FilterPickerViewModel @Inject constructor(
else -> throw IllegalStateException() else -> throw IllegalStateException()
} }
localBroadcastManager.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
fun getIcon(filter: Filter): String? = filter.getIcon(inventory) fun getIcon(filter: Filter): String? = filter.getIcon(inventory)

@ -8,8 +8,8 @@ import com.etebase.client.Item
import com.etebase.client.ItemMetadata import com.etebase.client.ItemMetadata
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import org.tasks.data.dao.CaldavDao
import org.tasks.data.entity.CaldavCalendar import org.tasks.data.entity.CaldavCalendar
import org.tasks.data.dao.CaldavDao
import org.tasks.data.entity.CaldavTask import org.tasks.data.entity.CaldavTask
import org.tasks.time.DateTimeUtils2.currentTimeMillis import org.tasks.time.DateTimeUtils2.currentTimeMillis
import timber.log.Timber import timber.log.Timber
@ -64,14 +64,7 @@ class EtebaseClient(
suspend fun updateItem(collection: Collection, task: CaldavTask, content: ByteArray): Item { suspend fun updateItem(collection: Collection, task: CaldavTask, content: ByteArray): Item {
val itemManager = etebase.collectionManager.getItemManager(collection) val itemManager = etebase.collectionManager.getItemManager(collection)
val obj = task.obj val item = cache.itemGet(itemManager, collection.uid, task.obj!!)
?: run {
Timber.e("null obj for caldavTask.id=${task.id}")
task.obj = task.remoteId
task.obj
}
?: throw IllegalStateException("Update failed - missing UUID")
val item = cache.itemGet(itemManager, collection.uid, obj)
?: itemManager ?: itemManager
.create(ItemMetadata().apply { name = task.remoteId!! }, "") .create(ItemMetadata().apply { name = task.remoteId!! }, "")
.apply { .apply {
@ -85,14 +78,7 @@ class EtebaseClient(
suspend fun deleteItem(collection: Collection, task: CaldavTask): Item? { suspend fun deleteItem(collection: Collection, task: CaldavTask): Item? {
val itemManager = etebase.collectionManager.getItemManager(collection) val itemManager = etebase.collectionManager.getItemManager(collection)
val objId = task.obj return cache.itemGet(itemManager, collection.uid, task.obj!!)
?: run {
Timber.e("null obj for caldavTask.id=${task.id}")
task.obj = task.remoteId
task.obj
}
?: return null
return cache.itemGet(itemManager, collection.uid, objId)
?.takeIf { !it.isDeleted } ?.takeIf { !it.isDeleted }
?.apply { ?.apply {
meta = updateMtime(meta) meta = updateMtime(meta)

@ -14,7 +14,7 @@ import com.todoroo.astrid.service.TaskDeleter
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import net.fortuna.ical4j.model.property.ProdId import net.fortuna.ical4j.model.property.ProdId
import org.tasks.BuildConfig import org.tasks.BuildConfig
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.billing.Inventory import org.tasks.billing.Inventory
@ -32,7 +32,7 @@ import javax.inject.Inject
class EtebaseSynchronizer @Inject constructor( class EtebaseSynchronizer @Inject constructor(
@param:ApplicationContext private val context: Context, @param:ApplicationContext private val context: Context,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val taskDeleter: TaskDeleter, private val taskDeleter: TaskDeleter,
private val inventory: Inventory, private val inventory: Inventory,
private val clientProvider: EtebaseClientProvider, private val clientProvider: EtebaseClientProvider,
@ -98,7 +98,7 @@ class EtebaseSynchronizer @Inject constructor(
calendar.name = meta.name calendar.name = meta.name
calendar.color = color calendar.color = color
caldavDao.update(calendar) caldavDao.update(calendar)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
fetchChanges(account, client, calendar, collection) fetchChanges(account, client, calendar, collection)
pushLocalChanges(account, client, calendar, collection) pushLocalChanges(account, client, calendar, collection)
@ -112,7 +112,7 @@ class EtebaseSynchronizer @Inject constructor(
private suspend fun setError(account: CaldavAccount, message: String?) { private suspend fun setError(account: CaldavAccount, message: String?) {
account.error = message account.error = message
caldavDao.update(account) caldavDao.update(account)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
if (!isNullOrEmpty(message)) { if (!isNullOrEmpty(message)) {
Timber.e(message) Timber.e(message)
} }
@ -137,7 +137,7 @@ class EtebaseSynchronizer @Inject constructor(
caldavDao.update(caldavCalendar) caldavDao.update(caldavCalendar)
Timber.d("Updating parents for ${caldavCalendar.uuid}") Timber.d("Updating parents for ${caldavCalendar.uuid}")
caldavDao.updateParents(caldavCalendar.uuid!!) caldavDao.updateParents(caldavCalendar.uuid!!)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private suspend fun pushLocalChanges( private suspend fun pushLocalChanges(

@ -16,7 +16,7 @@ import com.todoroo.astrid.service.TaskCreator.Companion.getDefaultAlarms
import com.todoroo.astrid.service.TaskDeleter import com.todoroo.astrid.service.TaskDeleter
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.delay import kotlinx.coroutines.delay
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
@ -56,7 +56,7 @@ class GoogleTaskSynchronizer @Inject constructor(
private val defaultFilterProvider: DefaultFilterProvider, private val defaultFilterProvider: DefaultFilterProvider,
private val permissionChecker: PermissionChecker, private val permissionChecker: PermissionChecker,
private val googleAccountManager: GoogleAccountManager, private val googleAccountManager: GoogleAccountManager,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val taskDeleter: TaskDeleter, private val taskDeleter: TaskDeleter,
private val invokers: InvokerFactory, private val invokers: InvokerFactory,
private val alarmDao: AlarmDao, private val alarmDao: AlarmDao,
@ -94,7 +94,7 @@ class GoogleTaskSynchronizer @Inject constructor(
firebase.reportException(e) firebase.reportException(e)
} finally { } finally {
caldavDao.update(account) caldavDao.update(account)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
Timber.d("%s: end sync", account) Timber.d("%s: end sync", account)
} }
} }
@ -182,7 +182,7 @@ class GoogleTaskSynchronizer @Inject constructor(
private suspend fun pushLocalChanges(account: CaldavAccount, gtasksInvoker: GtasksInvoker): Long? { private suspend fun pushLocalChanges(account: CaldavAccount, gtasksInvoker: GtasksInvoker): Long? {
val tasks = taskDao.getGoogleTasksToPush(account.uuid!!) val tasks = taskDao.getGoogleTasksToPush(account.uuid!!)
for (task in tasks) { for (task in tasks) {
val staleTaskId = pushTask(task, account.uuid!!, gtasksInvoker) val staleTaskId = pushTask(task, gtasksInvoker)
if (staleTaskId != null) { if (staleTaskId != null) {
return staleTaskId return staleTaskId
} }
@ -191,8 +191,8 @@ class GoogleTaskSynchronizer @Inject constructor(
} }
@Throws(IOException::class) @Throws(IOException::class)
private suspend fun pushTask(task: org.tasks.data.entity.Task, account: String, gtasksInvoker: GtasksInvoker): Long? { private suspend fun pushTask(task: org.tasks.data.entity.Task, gtasksInvoker: GtasksInvoker): Long? {
for (deleted in googleTaskDao.getDeletedByTaskId(task.id, account)) { for (deleted in googleTaskDao.getDeletedByTaskId(task.id)) {
deleted.remoteId?.let { deleted.remoteId?.let {
try { try {
gtasksInvoker.deleteGtask(deleted.calendar, it) gtasksInvoker.deleteGtask(deleted.calendar, it)

@ -11,13 +11,10 @@ import dagger.hilt.components.SingletonComponent
import kotlinx.coroutines.CoroutineDispatcher import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.SupervisorJob import kotlinx.coroutines.SupervisorJob
import org.tasks.LocalBroadcastManager
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.billing.BillingClient import org.tasks.billing.BillingClient
import org.tasks.billing.BillingClientImpl import org.tasks.billing.BillingClientImpl
import org.tasks.billing.Inventory import org.tasks.billing.Inventory
import org.tasks.caldav.FileStorage
import org.tasks.caldav.VtodoCache
import org.tasks.compose.drawer.DrawerConfiguration import org.tasks.compose.drawer.DrawerConfiguration
import org.tasks.data.dao.AlarmDao import org.tasks.data.dao.AlarmDao
import org.tasks.data.dao.Astrid2ContentProviderDao import org.tasks.data.dao.Astrid2ContentProviderDao
@ -40,13 +37,9 @@ import org.tasks.jobs.WorkManager
import org.tasks.kmp.createDataStore import org.tasks.kmp.createDataStore
import org.tasks.preferences.Preferences import org.tasks.preferences.Preferences
import org.tasks.preferences.TasksPreferences import org.tasks.preferences.TasksPreferences
import org.tasks.security.AndroidKeyStoreEncryption
import org.tasks.security.KeyStoreEncryption
import java.util.Locale import java.util.Locale
import javax.inject.Singleton import javax.inject.Singleton
import org.tasks.broadcast.RefreshBroadcaster
@Module @Module
@InstallIn(SingletonComponent::class) @InstallIn(SingletonComponent::class)
class ApplicationModule { class ApplicationModule {
@ -174,22 +167,4 @@ class ApplicationModule {
taskDao = taskDao, taskDao = taskDao,
tasksPreferences = tasksPreferences, tasksPreferences = tasksPreferences,
) )
@Provides
@Singleton
fun providesFileStorage(@ApplicationContext context: Context) =
FileStorage(context.filesDir.absolutePath)
@Provides
@Singleton
fun providesVtodoCache(caldavDao: CaldavDao, fileStorage: FileStorage) =
VtodoCache(caldavDao, fileStorage)
@Provides
@Singleton
fun providesKeyStoreEncryption(): KeyStoreEncryption = AndroidKeyStoreEncryption()
@Provides
fun providesBroadcastRefresh(localBroadcastManager: LocalBroadcastManager): RefreshBroadcaster =
localBroadcastManager
} }

@ -5,7 +5,7 @@ import androidx.hilt.work.HiltWorker
import androidx.work.WorkerParameters import androidx.work.WorkerParameters
import dagger.assisted.Assisted import dagger.assisted.Assisted
import dagger.assisted.AssistedInject import dagger.assisted.AssistedInject
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.data.dao.TaskDao import org.tasks.data.dao.TaskDao
import org.tasks.date.DateTimeUtils import org.tasks.date.DateTimeUtils
@ -16,13 +16,13 @@ class RefreshWork @AssistedInject constructor(
@Assisted context: Context, @Assisted context: Context,
@Assisted workerParams: WorkerParameters, @Assisted workerParams: WorkerParameters,
firebase: Firebase, firebase: Firebase,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val workManager: WorkManager, private val workManager: WorkManager,
private val taskDao: TaskDao, private val taskDao: TaskDao,
) : RepeatingWorker(context, workerParams, firebase) { ) : RepeatingWorker(context, workerParams, firebase) {
override suspend fun run(): Result { override suspend fun run(): Result {
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
return Result.success() return Result.success()
} }

@ -6,7 +6,7 @@ import androidx.hilt.work.HiltWorker
import androidx.work.WorkerParameters import androidx.work.WorkerParameters
import dagger.assisted.Assisted import dagger.assisted.Assisted
import dagger.assisted.AssistedInject import dagger.assisted.AssistedInject
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.data.dao.LocationDao import org.tasks.data.dao.LocationDao
import org.tasks.data.entity.Place import org.tasks.data.entity.Place
@ -20,7 +20,7 @@ class ReverseGeocodeWork @AssistedInject constructor(
@Assisted context: Context, @Assisted context: Context,
@Assisted workerParams: WorkerParameters, @Assisted workerParams: WorkerParameters,
firebase: Firebase, firebase: Firebase,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val geocoder: Geocoder, private val geocoder: Geocoder,
private val locationDao: LocationDao private val locationDao: LocationDao
) : BaseWorker(context, workerParams, firebase) { ) : BaseWorker(context, workerParams, firebase) {
@ -51,7 +51,7 @@ class ReverseGeocodeWork @AssistedInject constructor(
url = result.url, url = result.url,
) )
) )
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
Timber.d("found $result") Timber.d("found $result")
Result.success() Result.success()
} catch (e: Exception) { } catch (e: Exception) {

@ -17,7 +17,7 @@ import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.async import kotlinx.coroutines.async
import kotlinx.coroutines.awaitAll import kotlinx.coroutines.awaitAll
import kotlinx.coroutines.coroutineScope import kotlinx.coroutines.coroutineScope
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.billing.Inventory import org.tasks.billing.Inventory
@ -44,7 +44,7 @@ class SyncWork @AssistedInject constructor(
@Assisted context: Context, @Assisted context: Context,
@Assisted workerParams: WorkerParameters, @Assisted workerParams: WorkerParameters,
firebase: Firebase, firebase: Firebase,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val preferences: Preferences, private val preferences: Preferences,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val caldavSynchronizer: Lazy<CaldavSynchronizer>, private val caldavSynchronizer: Lazy<CaldavSynchronizer>,
@ -74,7 +74,7 @@ class SyncWork @AssistedInject constructor(
} }
preferences.setBoolean(syncStatus, true) preferences.setBoolean(syncStatus, true)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
try { try {
doSync() doSync()
preferences.lastSync = currentTimeMillis() preferences.lastSync = currentTimeMillis()
@ -82,7 +82,7 @@ class SyncWork @AssistedInject constructor(
firebase.reportException(e) firebase.reportException(e)
} finally { } finally {
preferences.setBoolean(syncStatus, false) preferences.setBoolean(syncStatus, false)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
return Result.success() return Result.success()
} }

@ -13,7 +13,7 @@ import com.todoroo.astrid.utility.Constants
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.coroutineScope import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.data.dao.LocationDao import org.tasks.data.dao.LocationDao
import org.tasks.data.dao.NotificationDao import org.tasks.data.dao.NotificationDao
@ -45,7 +45,7 @@ class NotificationManager @Inject constructor(
private val notificationDao: NotificationDao, private val notificationDao: NotificationDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val locationDao: LocationDao, private val locationDao: LocationDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val notificationManager: ThrottledNotificationManager, private val notificationManager: ThrottledNotificationManager,
private val markdownProvider: MarkdownProvider, private val markdownProvider: MarkdownProvider,
private val permissionChecker: PermissionChecker, private val permissionChecker: PermissionChecker,
@ -176,7 +176,7 @@ class NotificationManager @Inject constructor(
useGroupKey = false, useGroupKey = false,
) )
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
@SuppressLint("MissingPermission") @SuppressLint("MissingPermission")

@ -7,7 +7,7 @@ import com.todoroo.astrid.service.TaskDeleter
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import org.dmfs.tasks.contract.TaskContract import org.dmfs.tasks.contract.TaskContract
import org.dmfs.tasks.contract.TaskContract.Tasks import org.dmfs.tasks.contract.TaskContract.Tasks
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.analytics.Constants import org.tasks.analytics.Constants
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
@ -36,7 +36,7 @@ class OpenTasksSynchronizer @Inject constructor(
@ApplicationContext private val context: Context, @ApplicationContext private val context: Context,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val taskDeleter: TaskDeleter, private val taskDeleter: TaskDeleter,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val firebase: Firebase, private val firebase: Firebase,
private val iCalendar: iCalendar, private val iCalendar: iCalendar,
@ -111,7 +111,7 @@ class OpenTasksSynchronizer @Inject constructor(
if (local.id == NO_ID) { if (local.id == NO_ID) {
caldavDao.insert(local) caldavDao.insert(local)
Timber.d("Created calendar: $local") Timber.d("Created calendar: $local")
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} else if ( } else if (
local.name != remote.name || local.name != remote.name ||
local.color != remote.color || local.color != remote.color ||
@ -122,7 +122,7 @@ class OpenTasksSynchronizer @Inject constructor(
local.access = remote.access local.access = remote.access
caldavDao.update(local) caldavDao.update(local)
Timber.d("Updated calendar: $local") Timber.d("Updated calendar: $local")
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
return local return local
} }
@ -184,7 +184,7 @@ class OpenTasksSynchronizer @Inject constructor(
caldavDao.update(calendar) caldavDao.update(calendar)
Timber.d("Updating parents for ${calendar.uuid}") Timber.d("Updating parents for ${calendar.uuid}")
caldavDao.updateParents(calendar.uuid!!) caldavDao.updateParents(calendar.uuid!!)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private suspend fun removeDeleted(calendar: String, uids: List<String>) { private suspend fun removeDeleted(calendar: String, uids: List<String>) {
@ -202,7 +202,7 @@ class OpenTasksSynchronizer @Inject constructor(
private suspend fun setError(account: CaldavAccount, message: String?) { private suspend fun setError(account: CaldavAccount, message: String?) {
account.error = message account.error = message
caldavDao.update(account) caldavDao.update(account)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
if (!message.isNullOrBlank()) { if (!message.isNullOrBlank()) {
Timber.e(message) Timber.e(message)
} }

@ -6,10 +6,12 @@ import android.content.Context
import android.content.Intent import android.content.Intent
import android.content.SharedPreferences import android.content.SharedPreferences
import android.content.pm.PackageManager import android.content.pm.PackageManager
import android.media.RingtoneManager
import android.net.Uri import android.net.Uri
import android.os.Binder import android.os.Binder
import androidx.compose.material3.DisplayMode import androidx.compose.material3.DisplayMode
import androidx.compose.material3.ExperimentalMaterial3Api import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.core.app.NotificationCompat
import androidx.core.net.toUri import androidx.core.net.toUri
import androidx.documentfile.provider.DocumentFile import androidx.documentfile.provider.DocumentFile
import androidx.preference.PreferenceManager import androidx.preference.PreferenceManager
@ -28,6 +30,8 @@ import org.tasks.extensions.Context.getResourceUri
import org.tasks.kmp.org.tasks.themes.ColorProvider.BLUE_500 import org.tasks.kmp.org.tasks.themes.ColorProvider.BLUE_500
import org.tasks.themes.ThemeBase import org.tasks.themes.ThemeBase
import org.tasks.time.DateTime import org.tasks.time.DateTime
import org.tasks.time.DateTimeUtils2.currentTimeMillis
import org.tasks.time.ONE_WEEK
import timber.log.Timber import timber.log.Timber
import java.io.File import java.io.File
import java.net.URI import java.net.URI
@ -378,7 +382,7 @@ class Preferences @JvmOverloads constructor(
val backupDirectory: Uri? val backupDirectory: Uri?
get() = getDirectory(R.string.p_backup_dir, "backups") get() = getDirectory(R.string.p_backup_dir, "backups")
val appPrivateStorage: Uri val externalStorage: Uri
get() = root.uri get() = root.uri
val attachmentsDirectory: Uri? val attachmentsDirectory: Uri?
@ -412,12 +416,13 @@ class Preferences @JvmOverloads constructor(
?: getDefaultFileLocation(name)?.let { Uri.fromFile(it) } ?: getDefaultFileLocation(name)?.let { Uri.fromFile(it) }
private val root: DocumentFile private val root: DocumentFile
get() = DocumentFile.fromFile(context.getExternalFilesDir(null) ?: context.filesDir) get() = DocumentFile.fromFile(context.getExternalFilesDir(null)!!)
private fun getDefaultFileLocation(type: String): File? { private fun getDefaultFileLocation(type: String): File? {
val baseDir = context.getExternalFilesDir(null) ?: context.filesDir val externalFilesDir = context.getExternalFilesDir(null) ?: return null
val path = File(baseDir, type) val path = String.format("%s/%s", externalFilesDir.absolutePath, type)
return if (path.isDirectory || path.mkdirs()) path else null val file = File(path)
return if (file.isDirectory || file.mkdirs()) file else null
} }
private fun hasWritePermission(context: Context, uri: Uri): Boolean = private fun hasWritePermission(context: Context, uri: Uri): Boolean =

@ -2,7 +2,6 @@ package org.tasks.preferences
import android.content.ContentResolver import android.content.ContentResolver
import android.content.Context import android.content.Context
import android.net.Uri
import androidx.documentfile.provider.DocumentFile import androidx.documentfile.provider.DocumentFile
import androidx.lifecycle.MutableLiveData import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel import androidx.lifecycle.ViewModel
@ -52,16 +51,8 @@ class PreferencesViewModel @Inject constructor(
get() = isStale(lastDriveBackup.value) && isStale(lastAndroidBackup.value) get() = isStale(lastDriveBackup.value) && isStale(lastAndroidBackup.value)
val usingPrivateStorage: Boolean val usingPrivateStorage: Boolean
get() = preferences.backupDirectory.let { backupDir -> get() = preferences.backupDirectory.let {
val backupDirStr = backupDir?.toString() ?: return true it == null || it.toString().startsWith(preferences.externalStorage.toString())
context
.getExternalFilesDir(null)
?.let {
if (backupDirStr.startsWith(Uri.fromFile(it).toString())) {
return true
}
}
return backupDirStr.startsWith(Uri.fromFile(context.filesDir).toString())
} }
val driveAccount: String? val driveAccount: String?

@ -257,7 +257,7 @@ class Backups : InjectingPreferenceFragment() {
pref.summary = """ pref.summary = """
$location $location
${requireContext().getString(R.string.backup_location_warning, FileHelper.uri2String(preferences.appPrivateStorage))} ${requireContext().getString(R.string.backup_location_warning, FileHelper.uri2String(preferences.externalStorage))}
""".trimIndent() """.trimIndent()
} else { } else {
pref.icon = null pref.icon = null

@ -4,8 +4,8 @@ import android.os.Bundle
import androidx.lifecycle.lifecycleScope import androidx.lifecycle.lifecycleScope
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.compose.FilterSelectionActivity.Companion.launch import org.tasks.compose.FilterSelectionActivity.Companion.launch
import org.tasks.compose.FilterSelectionActivity.Companion.registerForFilterPickerResult import org.tasks.compose.FilterSelectionActivity.Companion.registerForFilterPickerResult
import org.tasks.injection.InjectingPreferenceFragment import org.tasks.injection.InjectingPreferenceFragment
@ -16,14 +16,14 @@ import javax.inject.Inject
class DashClock : InjectingPreferenceFragment() { class DashClock : InjectingPreferenceFragment() {
@Inject lateinit var defaultFilterProvider: DefaultFilterProvider @Inject lateinit var defaultFilterProvider: DefaultFilterProvider
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
private val listPickerLauncher = registerForFilterPickerResult { private val listPickerLauncher = registerForFilterPickerResult {
defaultFilterProvider.dashclockFilter = it defaultFilterProvider.dashclockFilter = it
lifecycleScope.launch { lifecycleScope.launch {
refreshPreferences() refreshPreferences()
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
override fun getPreferenceXml() = R.xml.preferences_dashclock override fun getPreferenceXml() = R.xml.preferences_dashclock

@ -18,10 +18,10 @@ import com.google.android.material.color.DynamicColors
import com.todoroo.andlib.utility.AndroidUtilities.atLeastTiramisu import com.todoroo.andlib.utility.AndroidUtilities.atLeastTiramisu
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.billing.Inventory import org.tasks.billing.Inventory
import org.tasks.billing.PurchaseActivity import org.tasks.billing.PurchaseActivity
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.compose.FilterSelectionActivity.Companion.launch import org.tasks.compose.FilterSelectionActivity.Companion.launch
import org.tasks.compose.FilterSelectionActivity.Companion.registerForFilterPickerResult import org.tasks.compose.FilterSelectionActivity.Companion.registerForFilterPickerResult
import org.tasks.dialogs.ColorPalettePicker import org.tasks.dialogs.ColorPalettePicker
@ -48,7 +48,7 @@ class LookAndFeel : InjectingPreferenceFragment() {
@Inject lateinit var themeBase: ThemeBase @Inject lateinit var themeBase: ThemeBase
@Inject lateinit var themeColor: ThemeColor @Inject lateinit var themeColor: ThemeColor
@Inject lateinit var preferences: Preferences @Inject lateinit var preferences: Preferences
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
@Inject lateinit var defaultFilterProvider: DefaultFilterProvider @Inject lateinit var defaultFilterProvider: DefaultFilterProvider
@Inject lateinit var inventory: Inventory @Inject lateinit var inventory: Inventory
@Inject lateinit var locale: Locale @Inject lateinit var locale: Locale
@ -56,7 +56,7 @@ class LookAndFeel : InjectingPreferenceFragment() {
private val listPickerLauncher = registerForFilterPickerResult { private val listPickerLauncher = registerForFilterPickerResult {
defaultFilterProvider.setDefaultOpenFilter(it) defaultFilterProvider.setDefaultOpenFilter(it)
findPreference(R.string.p_default_open_filter).summary = it.title findPreference(R.string.p_default_open_filter).summary = it.title
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
override fun getPreferenceXml() = R.xml.preferences_look_and_feel override fun getPreferenceXml() = R.xml.preferences_look_and_feel

@ -17,8 +17,8 @@ import com.todoroo.andlib.utility.AndroidUtilities
import com.todoroo.astrid.voice.VoiceOutputAssistant import com.todoroo.astrid.voice.VoiceOutputAssistant
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.compose.FilterSelectionActivity.Companion.launch import org.tasks.compose.FilterSelectionActivity.Companion.launch
import org.tasks.compose.FilterSelectionActivity.Companion.registerForFilterPickerResult import org.tasks.compose.FilterSelectionActivity.Companion.registerForFilterPickerResult
import org.tasks.dialogs.MyTimePickerDialog.Companion.newTimePicker import org.tasks.dialogs.MyTimePickerDialog.Companion.newTimePicker
@ -39,13 +39,13 @@ class Notifications : InjectingPreferenceFragment() {
@Inject lateinit var preferences: Preferences @Inject lateinit var preferences: Preferences
@Inject lateinit var defaultFilterProvider: DefaultFilterProvider @Inject lateinit var defaultFilterProvider: DefaultFilterProvider
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
@Inject lateinit var voiceOutputAssistant: VoiceOutputAssistant @Inject lateinit var voiceOutputAssistant: VoiceOutputAssistant
private val listPickerLauncher = registerForFilterPickerResult { private val listPickerLauncher = registerForFilterPickerResult {
defaultFilterProvider.setBadgeFilter(it) defaultFilterProvider.setBadgeFilter(it)
findPreference(R.string.p_badge_list).summary = it.title findPreference(R.string.p_badge_list).summary = it.title
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
override fun getPreferenceXml() = R.xml.preferences_notifications override fun getPreferenceXml() = R.xml.preferences_notifications

@ -0,0 +1,10 @@
package org.tasks.reminders;
public class Random {
private static final java.util.Random random = new java.util.Random();
public float nextFloat() {
return random.nextFloat();
}
}

@ -1,14 +0,0 @@
package org.tasks.reminders
import java.util.Random
open class Random {
open fun nextFloat(seed: Long): Float {
random.setSeed(seed)
return random.nextFloat()
}
companion object {
private val random = Random()
}
}

@ -0,0 +1,97 @@
package org.tasks.security
import android.annotation.SuppressLint
import android.security.keystore.KeyGenParameterSpec
import android.security.keystore.KeyProperties
import android.util.Base64
import org.tasks.Strings.isNullOrEmpty
import timber.log.Timber
import java.nio.charset.StandardCharsets
import java.security.KeyStore
import java.security.SecureRandom
import java.util.*
import javax.crypto.*
import javax.crypto.spec.GCMParameterSpec
import javax.inject.Inject
import javax.inject.Singleton
@Singleton
class KeyStoreEncryption @Inject constructor() {
private val keyStore: KeyStore = KeyStore.getInstance(ANDROID_KEYSTORE)
fun encrypt(text: String): String? {
val iv = ByteArray(GCM_IV_LENGTH)
SecureRandom().nextBytes(iv)
val cipher = getCipher(Cipher.ENCRYPT_MODE, iv)
return try {
val output = cipher.doFinal(text.toByteArray(ENCODING))
val result = ByteArray(iv.size + output.size)
System.arraycopy(iv, 0, result, 0, iv.size)
System.arraycopy(output, 0, result, iv.size, output.size)
Base64.encodeToString(result, Base64.DEFAULT)
} catch (e: IllegalBlockSizeException) {
Timber.e(e)
null
} catch (e: BadPaddingException) {
Timber.e(e)
null
}
}
fun decrypt(text: String?): String? {
if (isNullOrEmpty(text)) {
return null
}
val decoded = Base64.decode(text, Base64.DEFAULT)
val iv = Arrays.copyOfRange(decoded, 0, GCM_IV_LENGTH)
val cipher = getCipher(Cipher.DECRYPT_MODE, iv)
return try {
val decrypted = cipher.doFinal(decoded, GCM_IV_LENGTH, decoded.size - GCM_IV_LENGTH)
String(decrypted, ENCODING)
} catch (e: IllegalBlockSizeException) {
Timber.e(e)
""
} catch (e: BadPaddingException) {
Timber.e(e)
""
}
}
private fun getCipher(cipherMode: Int, iv: ByteArray): Cipher {
val cipher = Cipher.getInstance("AES/GCM/NoPadding")
cipher.init(cipherMode, secretKey, GCMParameterSpec(GCM_TAG_LENGTH * java.lang.Byte.SIZE, iv))
return cipher
}
private val secretKey: SecretKey
get() {
val entry: KeyStore.Entry? = keyStore.getEntry(ALIAS, null)
return (entry as KeyStore.SecretKeyEntry?)?.secretKey ?: generateNewKey()
}
@SuppressLint("TrulyRandom")
private fun generateNewKey(): SecretKey {
val keyGenerator = KeyGenerator.getInstance(KeyProperties.KEY_ALGORITHM_AES, ANDROID_KEYSTORE)
keyGenerator.init(
KeyGenParameterSpec.Builder(
ALIAS, KeyProperties.PURPOSE_ENCRYPT or KeyProperties.PURPOSE_DECRYPT)
.setBlockModes(KeyProperties.BLOCK_MODE_GCM)
.setRandomizedEncryptionRequired(false)
.setEncryptionPaddings(KeyProperties.ENCRYPTION_PADDING_NONE)
.build())
return keyGenerator.generateKey()
}
init {
keyStore.load(null)
}
companion object {
private const val ANDROID_KEYSTORE = "AndroidKeyStore"
private const val ALIAS = "passwords"
private val ENCODING = StandardCharsets.UTF_8
private const val GCM_IV_LENGTH = 12
private const val GCM_TAG_LENGTH = 16
}
}

@ -5,7 +5,7 @@ import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.asCoroutineDispatcher import kotlinx.coroutines.asCoroutineDispatcher
import kotlinx.coroutines.async import kotlinx.coroutines.async
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.data.OpenTaskDao import org.tasks.data.OpenTaskDao
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
@ -34,7 +34,7 @@ class SyncAdapters @Inject constructor(
private val googleTaskDao: GoogleTaskDao, private val googleTaskDao: GoogleTaskDao,
private val openTaskDao: OpenTaskDao, private val openTaskDao: OpenTaskDao,
private val preferences: Preferences, private val preferences: Preferences,
private val refreshBroadcaster: RefreshBroadcaster private val localBroadcastManager: LocalBroadcastManager
) { ) {
private val scope = CoroutineScope(newSingleThreadExecutor().asCoroutineDispatcher() + SupervisorJob()) private val scope = CoroutineScope(newSingleThreadExecutor().asCoroutineDispatcher() + SupervisorJob())
private val sync = Debouncer(TAG_SYNC) { workManager.sync(it) } private val sync = Debouncer(TAG_SYNC) { workManager.sync(it) }
@ -42,7 +42,7 @@ class SyncAdapters @Inject constructor(
val currentState = preferences.getBoolean(R.string.p_sync_ongoing_android, false) val currentState = preferences.getBoolean(R.string.p_sync_ongoing_android, false)
if (currentState != newState && isOpenTaskSyncEnabled()) { if (currentState != newState && isOpenTaskSyncEnabled()) {
preferences.setBoolean(R.string.p_sync_ongoing_android, newState) preferences.setBoolean(R.string.p_sync_ongoing_android, newState)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
} }

@ -25,15 +25,14 @@ object MicrosoftConverter {
fun Task.applySubtask( fun Task.applySubtask(
parent: Long, parent: Long,
parentCompletionDate: Long,
checklistItem: Tasks.Task.ChecklistItem, checklistItem: Tasks.Task.ChecklistItem,
) { ) {
this.parent = parent this.parent = parent
title = checklistItem.displayName title = checklistItem.displayName
completionDate = if (checklistItem.isChecked) { completionDate = if (checklistItem.isChecked) {
checklistItem.checkedDateTime.parseDateTime() checklistItem.checkedDateTime?.parseDateTime() ?: System.currentTimeMillis()
} else { } else {
parentCompletionDate 0L
} }
creationDate = checklistItem.createdDateTime.parseDateTime() creationDate = checklistItem.createdDateTime.parseDateTime()
} }
@ -121,7 +120,7 @@ object MicrosoftConverter {
} else { } else {
Tasks.Task.Status.notStarted Tasks.Task.Status.notStarted
}, },
categories = tags.map { it.name!! }.takeIf { it.isNotEmpty() } ?: emptyList(), categories = tags.map { it.name!! }.takeIf { it.isNotEmpty() },
dueDateTime = if (hasDueDate()) { dueDateTime = if (hasDueDate()) {
Tasks.Task.DateTime( Tasks.Task.DateTime(
dateTime = DateTime(dueDate).startOfDay().toString(DATE_TIME_FORMAT), dateTime = DateTime(dueDate).startOfDay().toString(DATE_TIME_FORMAT),

@ -11,14 +11,15 @@ import dagger.hilt.android.qualifiers.ApplicationContext
import io.ktor.client.call.body import io.ktor.client.call.body
import io.ktor.http.isSuccess import io.ktor.http.isSuccess
import kotlinx.serialization.json.Json import kotlinx.serialization.json.Json
import org.tasks.LocalBroadcastManager
import org.tasks.Strings.isNullOrEmpty import org.tasks.Strings.isNullOrEmpty
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.broadcast.RefreshBroadcaster
import org.tasks.caldav.VtodoCache import org.tasks.caldav.VtodoCache
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.TagDao import org.tasks.data.dao.TagDao
import org.tasks.data.dao.TagDataDao import org.tasks.data.dao.TagDataDao
import org.tasks.data.entity.CaldavAccount import org.tasks.data.entity.CaldavAccount
import org.tasks.data.entity.CaldavAccount.Companion.ERROR_UNAUTHORIZED
import org.tasks.data.entity.CaldavCalendar import org.tasks.data.entity.CaldavCalendar
import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_OWNER import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_OWNER
import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_READ_WRITE import org.tasks.data.entity.CaldavCalendar.Companion.ACCESS_READ_WRITE
@ -51,7 +52,7 @@ class MicrosoftSynchronizer @Inject constructor(
@param:ApplicationContext private val context: Context, @param:ApplicationContext private val context: Context,
private val caldavDao: CaldavDao, private val caldavDao: CaldavDao,
private val taskDao: TaskDao, private val taskDao: TaskDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
private val taskDeleter: TaskDeleter, private val taskDeleter: TaskDeleter,
private val firebase: Firebase, private val firebase: Firebase,
private val taskCreator: TaskCreator, private val taskCreator: TaskCreator,
@ -129,7 +130,7 @@ class MicrosoftSynchronizer @Inject constructor(
} else if (local.name != remoteName || local.access != access) { } else if (local.name != remoteName || local.access != access) {
remote.applyTo(local) remote.applyTo(local)
caldavDao.update(local) caldavDao.update(local)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
} }
if (local.ctag?.isNotBlank() == true) { if (local.ctag?.isNotBlank() == true) {
deltaSync(account, local, remote, microsoft) deltaSync(account, local, remote, microsoft)
@ -274,7 +275,7 @@ class MicrosoftSynchronizer @Inject constructor(
} }
Timber.d("UPDATE $list") Timber.d("UPDATE $list")
caldavDao.update(list) caldavDao.update(list)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private suspend fun getTaskLists( private suspend fun getTaskLists(
@ -367,7 +368,7 @@ class MicrosoftSynchronizer @Inject constructor(
} }
Timber.d("UPDATE $list") Timber.d("UPDATE $list")
caldavDao.update(list) caldavDao.update(list)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private suspend fun updateTask(list: CaldavCalendar, remote: Tasks.Task) { private suspend fun updateTask(list: CaldavCalendar, remote: Tasks.Task) {
@ -402,7 +403,6 @@ class MicrosoftSynchronizer @Inject constructor(
list = list, list = list,
parentId = task.id, parentId = task.id,
parentRemoteId = caldavTask.remoteId!!, parentRemoteId = caldavTask.remoteId!!,
parentCompletionDate = task.completionDate,
checklistItems = it, checklistItems = it,
) )
} }
@ -421,7 +421,6 @@ class MicrosoftSynchronizer @Inject constructor(
list: CaldavCalendar, list: CaldavCalendar,
parentId: Long, parentId: Long,
parentRemoteId: String, parentRemoteId: String,
parentCompletionDate: Long,
checklistItems: List<Tasks.Task.ChecklistItem>, checklistItems: List<Tasks.Task.ChecklistItem>,
) { ) {
val existingSubtasks: List<CaldavTask> = taskDao.getChildren(parentId).let { caldavDao.getTasks(it) } val existingSubtasks: List<CaldavTask> = taskDao.getChildren(parentId).let { caldavDao.getTasks(it) }
@ -452,7 +451,6 @@ class MicrosoftSynchronizer @Inject constructor(
} else { } else {
task.applySubtask( task.applySubtask(
parent = parentId, parent = parentId,
parentCompletionDate = parentCompletionDate,
checklistItem = item, checklistItem = item,
) )
} }
@ -490,7 +488,7 @@ class MicrosoftSynchronizer @Inject constructor(
private suspend fun setError(account: CaldavAccount, message: String?) { private suspend fun setError(account: CaldavAccount, message: String?) {
account.error = message account.error = message
caldavDao.update(account) caldavDao.update(account)
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefreshList()
if (!isNullOrEmpty(message)) { if (!isNullOrEmpty(message)) {
Timber.e(message) Timber.e(message)
} }

@ -1,5 +1,3 @@
@file:OptIn(ExperimentalSerializationApi::class)
package org.tasks.sync.microsoft package org.tasks.sync.microsoft
import kotlinx.serialization.EncodeDefault import kotlinx.serialization.EncodeDefault
@ -19,18 +17,18 @@ data class Tasks(
@SerialName("@odata.etag") val etag: String? = null, @SerialName("@odata.etag") val etag: String? = null,
val id: String? = null, val id: String? = null,
@Redacted val title: String? = null, @Redacted val title: String? = null,
@EncodeDefault val body: Body? = null, val body: Body? = null,
@EncodeDefault val importance: Importance = Importance.low, @EncodeDefault val importance: Importance = Importance.low,
@EncodeDefault val status: Status = Status.notStarted, @EncodeDefault val status: Status = Status.notStarted,
val categories: List<String>? = null, val categories: List<String>? = null,
val isReminderOn: Boolean = false, val isReminderOn: Boolean = false,
val createdDateTime: String? = null, val createdDateTime: String? = null,
val lastModifiedDateTime: String? = null, val lastModifiedDateTime: String? = null,
@EncodeDefault val completedDateTime: DateTime? = null, val completedDateTime: DateTime? = null,
@EncodeDefault val dueDateTime: DateTime? = null, val dueDateTime: DateTime? = null,
val linkedResources: List<LinkedResource>? = null, val linkedResources: List<LinkedResource>? = null,
@EncodeDefault val recurrence: Recurrence? = null, val recurrence: Recurrence? = null,
@EncodeDefault val reminderDateTime: DateTime? = null, val reminderDateTime: DateTime? = null,
val checklistItems: List<ChecklistItem>? = null, val checklistItems: List<ChecklistItem>? = null,
@SerialName("@removed") val removed: Removed? = null, @SerialName("@removed") val removed: Removed? = null,
) { ) {
@ -108,7 +106,7 @@ data class Tasks(
val displayName: String, val displayName: String,
val createdDateTime: String? = null, val createdDateTime: String? = null,
val isChecked: Boolean, val isChecked: Boolean,
@EncodeDefault val checkedDateTime: String? = null, val checkedDateTime: String? = null,
) )
enum class Importance { enum class Importance {

@ -6,7 +6,7 @@ import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.flow.combine import kotlinx.coroutines.flow.combine
import kotlinx.coroutines.flow.launchIn import kotlinx.coroutines.flow.launchIn
import kotlinx.coroutines.flow.onEach import kotlinx.coroutines.flow.onEach
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.LocalBroadcastManager
import org.tasks.compose.throttleLatest import org.tasks.compose.throttleLatest
import org.tasks.data.dao.CaldavDao import org.tasks.data.dao.CaldavDao
import org.tasks.data.dao.TagDataDao import org.tasks.data.dao.TagDataDao
@ -23,7 +23,7 @@ import javax.inject.Singleton
class ChipListCache @Inject internal constructor( class ChipListCache @Inject internal constructor(
caldavDao: CaldavDao, caldavDao: CaldavDao,
tagDataDao: TagDataDao, tagDataDao: TagDataDao,
private val refreshBroadcaster: RefreshBroadcaster, private val localBroadcastManager: LocalBroadcastManager,
) { ) {
private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO) private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)
private val lists: MutableMap<String?, CaldavFilter> = HashMap() private val lists: MutableMap<String?, CaldavFilter> = HashMap()
@ -42,7 +42,7 @@ class ChipListCache @Inject internal constructor(
lists.clear() lists.clear()
it.associateByTo(lists) { filter -> filter.uuid } it.associateByTo(lists) { filter -> filter.uuid }
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
private fun updateTags(updated: List<TagData>) { private fun updateTags(updated: List<TagData>) {
@ -51,7 +51,7 @@ class ChipListCache @Inject internal constructor(
for (update in updated) { for (update in updated) {
tagDatas[update.remoteId] = TagFilter(update) tagDatas[update.remoteId] = TagFilter(update)
} }
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
} }
fun getCaldavList(caldav: String?): CaldavFilter? = lists[caldav] fun getCaldavList(caldav: String?): CaldavFilter? = lists[caldav]

@ -7,14 +7,9 @@ import android.content.Intent
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.consumeAsFlow
import kotlinx.coroutines.flow.launchIn
import kotlinx.coroutines.flow.onEach
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext import kotlinx.coroutines.withContext
import org.tasks.R import org.tasks.R
import org.tasks.compose.throttleLatest
import org.tasks.injection.ApplicationScope import org.tasks.injection.ApplicationScope
import timber.log.Timber import timber.log.Timber
import javax.inject.Inject import javax.inject.Inject
@ -24,44 +19,29 @@ class AppWidgetManager @Inject constructor(
@ApplicationScope private val scope: CoroutineScope, @ApplicationScope private val scope: CoroutineScope,
) { ) {
private val appWidgetManager: AppWidgetManager? = AppWidgetManager.getInstance(context) private val appWidgetManager: AppWidgetManager? = AppWidgetManager.getInstance(context)
private val updateChannel = Channel<Unit>(Channel.CONFLATED)
init {
updateChannel
.consumeAsFlow()
.throttleLatest(1000)
.onEach {
val appWidgetIds = widgetIds
Timber.d("updateWidgets: ${appWidgetIds.joinToString { it.toString() }}")
notifyAppWidgetViewDataChanged(appWidgetIds)
}
.launchIn(scope)
}
val widgetIds: IntArray val widgetIds: IntArray
get() = appWidgetManager get() = appWidgetManager
?.getAppWidgetIds(ComponentName(context, TasksWidget::class.java)) ?.getAppWidgetIds(ComponentName(context, TasksWidget::class.java))
?: intArrayOf() ?: intArrayOf()
fun reconfigureWidgets(vararg appWidgetIds: Int) = scope.launch { fun reconfigureWidgets(vararg appWidgetIds: Int) = scope.launch(Dispatchers.IO) {
Timber.d("reconfigureWidgets(${appWidgetIds.joinToString()})") Timber.d("reconfigureWidgets(${appWidgetIds.joinToString()})")
val ids = appWidgetIds.takeIf { it.isNotEmpty() } ?: widgetIds
val intent = Intent(context, TasksWidget::class.java) val intent = Intent(context, TasksWidget::class.java)
.putExtra(AppWidgetManager.EXTRA_APPWIDGET_IDS, ids) intent.action = AppWidgetManager.ACTION_APPWIDGET_UPDATE
.apply { action = AppWidgetManager.ACTION_APPWIDGET_UPDATE } intent.putExtra(
AppWidgetManager.EXTRA_APPWIDGET_IDS,
appWidgetIds.takeIf { it.isNotEmpty() } ?: widgetIds)
context.sendBroadcast(intent) context.sendBroadcast(intent)
} }
fun updateWidgets() { fun updateWidgets() = scope.launch(Dispatchers.IO) {
updateChannel.trySend(Unit) val appWidgetIds = widgetIds
Timber.d("updateWidgets: ${appWidgetIds.joinToString()}")
withContext(Dispatchers.Main) {
appWidgetManager?.notifyAppWidgetViewDataChanged(appWidgetIds, R.id.list_view)
}
} }
fun exists(id: Int) = appWidgetManager?.getAppWidgetInfo(id) != null fun exists(id: Int) = appWidgetManager?.getAppWidgetInfo(id) != null
private suspend fun notifyAppWidgetViewDataChanged(appWidgetIds: IntArray) = withContext(Dispatchers.Main) {
appWidgetManager?.notifyAppWidgetViewDataChanged(appWidgetIds, R.id.list_view)
}
} }

@ -5,10 +5,10 @@ import android.appwidget.AppWidgetManager
import android.appwidget.AppWidgetProvider import android.appwidget.AppWidgetProvider
import android.content.Context import android.content.Context
import android.content.Intent import android.content.Intent
import android.net.Uri
import android.os.Bundle import android.os.Bundle
import android.view.View import android.view.View
import android.widget.RemoteViews import android.widget.RemoteViews
import androidx.core.net.toUri
import com.todoroo.andlib.utility.AndroidUtilities.atLeastS import com.todoroo.andlib.utility.AndroidUtilities.atLeastS
import com.todoroo.astrid.activity.MainActivity.Companion.FINISH_AFFINITY import com.todoroo.astrid.activity.MainActivity.Companion.FINISH_AFFINITY
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
@ -35,11 +35,13 @@ class TasksWidget : AppWidgetProvider() {
@Inject @ApplicationContext lateinit var context: Context @Inject @ApplicationContext lateinit var context: Context
override fun onUpdate(context: Context, appWidgetManager: AppWidgetManager, appWidgetIds: IntArray) { override fun onUpdate(context: Context, appWidgetManager: AppWidgetManager, appWidgetIds: IntArray) {
Timber.d("onUpdate appWidgetIds=${appWidgetIds.joinToString { it.toString() }}") appWidgetIds.forEach { appWidgetId ->
appWidgetIds.forEach { id ->
try { try {
val options = appWidgetManager.getAppWidgetOptions(id) val options = appWidgetManager.getAppWidgetOptions(appWidgetId)
appWidgetManager.updateAppWidget(id, createWidget(context, id, options)) appWidgetManager.updateAppWidget(
appWidgetId,
createWidget(context, appWidgetId, options)
)
} catch (e: Exception) { } catch (e: Exception) {
Timber.e(e) Timber.e(e)
} }
@ -52,7 +54,6 @@ class TasksWidget : AppWidgetProvider() {
appWidgetId: Int, appWidgetId: Int,
newOptions: Bundle newOptions: Bundle
) { ) {
Timber.d("onAppWidgetOptionsChanged appWidgetId=$appWidgetId")
appWidgetManager.updateAppWidget( appWidgetManager.updateAppWidget(
appWidgetId, appWidgetId,
createWidget(context, appWidgetId, newOptions) createWidget(context, appWidgetId, newOptions)
@ -68,8 +69,6 @@ class TasksWidget : AppWidgetProvider() {
val filter = runBlocking { val filter = runBlocking {
defaultFilterProvider.getFilterFromPreference(widgetPreferences.filterId) defaultFilterProvider.getFilterFromPreference(widgetPreferences.filterId)
} }
Timber.d("createWidget id=$id filter=$filter")
return RemoteViews(context.packageName, R.layout.scrollable_widget).apply { return RemoteViews(context.packageName, R.layout.scrollable_widget).apply {
if (settings.showHeader) { if (settings.showHeader) {
setViewVisibility(R.id.widget_header, View.VISIBLE) setViewVisibility(R.id.widget_header, View.VISIBLE)
@ -88,7 +87,7 @@ class TasksWidget : AppWidgetProvider() {
opacity = widgetPreferences.footerOpacity, opacity = widgetPreferences.footerOpacity,
) )
setOnClickPendingIntent(R.id.empty_view, getOpenListIntent(context, filter, id)) setOnClickPendingIntent(R.id.empty_view, getOpenListIntent(context, filter, id))
val cacheBuster = "tasks://widget/${currentTimeMillis()}".toUri() val cacheBuster = Uri.parse("tasks://widget/" + currentTimeMillis())
setRemoteAdapter( setRemoteAdapter(
R.id.list_view, R.id.list_view,
Intent(context, TasksWidgetAdapter::class.java) Intent(context, TasksWidgetAdapter::class.java)

@ -13,7 +13,6 @@ import org.tasks.markdown.MarkdownProvider
import org.tasks.preferences.DefaultFilterProvider import org.tasks.preferences.DefaultFilterProvider
import org.tasks.preferences.Preferences import org.tasks.preferences.Preferences
import org.tasks.tasklist.HeaderFormatter import org.tasks.tasklist.HeaderFormatter
import timber.log.Timber
import javax.inject.Inject import javax.inject.Inject
@AndroidEntryPoint @AndroidEntryPoint
@ -33,7 +32,6 @@ class TasksWidgetAdapter : RemoteViewsService() {
val filter = runBlocking { val filter = runBlocking {
defaultFilterProvider.getFilterFromPreference(widgetPreferences.filterId) defaultFilterProvider.getFilterFromPreference(widgetPreferences.filterId)
} }
Timber.d("onGetViewFactory $filter")
return TasksWidgetViewFactory( return TasksWidgetViewFactory(
subtasksHelper, subtasksHelper,
widgetPreferences, widgetPreferences,

@ -51,7 +51,7 @@ internal class TasksWidgetViewFactory(
private val markdown: Markdown, private val markdown: Markdown,
private val headerFormatter: HeaderFormatter, private val headerFormatter: HeaderFormatter,
) : RemoteViewsFactory { ) : RemoteViewsFactory {
private val taskLimit = if (atLeastAndroid16()) 50 + 1 else Int.MAX_VALUE private val taskLimit = if (atLeastAndroid16()) 25 + 1 else Int.MAX_VALUE
private val indentPadding = (20 * context.resources.displayMetrics.density).toInt() private val indentPadding = (20 * context.resources.displayMetrics.density).toInt()
private val settings = widgetPreferences.getWidgetListSettings() private val settings = widgetPreferences.getWidgetListSettings()
private val hPad = context.resources.getDimension(R.dimen.widget_padding).toInt() private val hPad = context.resources.getDimension(R.dimen.widget_padding).toInt()
@ -66,12 +66,9 @@ internal class TasksWidgetViewFactory(
chipProvider.isDark = settings.isDark chipProvider.isDark = settings.isDark
} }
override fun onCreate() { override fun onCreate() {}
Timber.d("onCreate widgetId:$widgetId filter:$filter")
}
override fun onDataSetChanged() { override fun onDataSetChanged() {
Timber.v("onDataSetChanged $filter")
runBlocking { runBlocking {
val collapsed = widgetPreferences.collapsed val collapsed = widgetPreferences.collapsed
tasks = SectionedDataSource( tasks = SectionedDataSource(
@ -90,9 +87,7 @@ internal class TasksWidgetViewFactory(
} }
} }
override fun onDestroy() { override fun onDestroy() {}
Timber.d("onDestroy widgetId:$widgetId")
}
override fun getCount() = tasks.size.coerceAtMost(taskLimit) override fun getCount() = tasks.size.coerceAtMost(taskLimit)
@ -222,7 +217,7 @@ internal class TasksWidgetViewFactory(
R.id.widget_row, R.id.widget_row,
Intent(WidgetClickActivity.EDIT_TASK) Intent(WidgetClickActivity.EDIT_TASK)
.putExtra(WidgetClickActivity.EXTRA_FILTER, filter) .putExtra(WidgetClickActivity.EXTRA_FILTER, filter)
.putExtra(WidgetClickActivity.EXTRA_TASK_ID, task.id) .putExtra(WidgetClickActivity.EXTRA_TASK, task)
) )
if (settings.showCheckboxes) { if (settings.showCheckboxes) {
setViewPadding( setViewPadding(
@ -237,8 +232,7 @@ internal class TasksWidgetViewFactory(
setOnClickFillInIntent( setOnClickFillInIntent(
R.id.widget_complete_box, R.id.widget_complete_box,
Intent(WidgetClickActivity.COMPLETE_TASK) Intent(WidgetClickActivity.COMPLETE_TASK)
.putExtra(WidgetClickActivity.EXTRA_TASK_ID, task.id) .putExtra(WidgetClickActivity.EXTRA_TASK, task)
.putExtra(WidgetClickActivity.EXTRA_COMPLETED, !task.isCompleted)
) )
} else { } else {
setViewPadding(R.id.widget_complete_box, hPad, 0, 0, 0) setViewPadding(R.id.widget_complete_box, hPad, 0, 0, 0)
@ -256,7 +250,7 @@ internal class TasksWidgetViewFactory(
setOnClickFillInIntent( setOnClickFillInIntent(
R.id.chip, R.id.chip,
Intent(WidgetClickActivity.TOGGLE_SUBTASKS) Intent(WidgetClickActivity.TOGGLE_SUBTASKS)
.putExtra(WidgetClickActivity.EXTRA_TASK_ID, task.id) .putExtra(WidgetClickActivity.EXTRA_TASK, task)
.putExtra( .putExtra(
WidgetClickActivity.EXTRA_COLLAPSED, WidgetClickActivity.EXTRA_COLLAPSED,
!taskContainer.isCollapsed !taskContainer.isCollapsed
@ -338,10 +332,11 @@ internal class TasksWidgetViewFactory(
setOnClickFillInIntent( setOnClickFillInIntent(
dueDateRes, dueDateRes,
Intent(WidgetClickActivity.RESCHEDULE_TASK) Intent(WidgetClickActivity.RESCHEDULE_TASK)
.putExtra(WidgetClickActivity.EXTRA_TASK_ID, task.id) .putExtra(WidgetClickActivity.EXTRA_TASK, task.task)
) )
} else { } else {
setViewVisibility(dueDateRes, View.GONE) setViewVisibility(dueDateRes, View.GONE)
} }
} }
} }

@ -3,6 +3,7 @@ package org.tasks.widget
import android.content.Context import android.content.Context
import android.widget.RemoteViews import android.widget.RemoteViews
import androidx.annotation.ColorInt import androidx.annotation.ColorInt
import com.mikepenz.iconics.IconicsDrawable
import dagger.hilt.android.qualifiers.ApplicationContext import dagger.hilt.android.qualifiers.ApplicationContext
import kotlinx.coroutines.runBlocking import kotlinx.coroutines.runBlocking
import org.tasks.BuildConfig import org.tasks.BuildConfig
@ -18,6 +19,7 @@ import org.tasks.filters.Filter
import org.tasks.filters.PlaceFilter import org.tasks.filters.PlaceFilter
import org.tasks.filters.TagFilter import org.tasks.filters.TagFilter
import org.tasks.filters.getIcon import org.tasks.filters.getIcon
import org.tasks.icons.OutlinedGoogleMaterial
import org.tasks.kmp.org.tasks.time.getRelativeDateTime import org.tasks.kmp.org.tasks.time.getRelativeDateTime
import org.tasks.kmp.org.tasks.time.getTimeString import org.tasks.kmp.org.tasks.time.getTimeString
import org.tasks.time.startOfDay import org.tasks.time.startOfDay
@ -113,16 +115,14 @@ class WidgetChipProvider @Inject constructor(
setTextViewText(R.id.chip_text, filter.title) setTextViewText(R.id.chip_text, filter.title)
filter filter
.getIcon(inventory) .getIcon(inventory)
?.let { iconName -> ?.let {
try { try {
val iconUri = WidgetIconProvider.getIconUri( OutlinedGoogleMaterial.getIcon("gmo_$it")
iconName = iconName, } catch (_: IllegalArgumentException) {
) null
setImageViewUri(R.id.chip_icon, iconUri)
} catch (_: Exception) {
setImageViewResource(R.id.chip_icon, defaultIcon)
} }
} }
?.let { setImageViewBitmap(R.id.chip_icon, IconicsDrawable(context, it).toBitmap()) }
?: setImageViewResource(R.id.chip_icon, defaultIcon) ?: setImageViewResource(R.id.chip_icon, defaultIcon)
} }

@ -9,9 +9,10 @@ import com.todoroo.astrid.service.TaskCompleter
import dagger.hilt.android.AndroidEntryPoint import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.NonCancellable import kotlinx.coroutines.NonCancellable
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import org.tasks.LocalBroadcastManager
import org.tasks.R import org.tasks.R
import org.tasks.analytics.Firebase import org.tasks.analytics.Firebase
import org.tasks.broadcast.RefreshBroadcaster import org.tasks.data.entity.Task
import org.tasks.dialogs.BaseDateTimePicker.OnDismissHandler import org.tasks.dialogs.BaseDateTimePicker.OnDismissHandler
import org.tasks.dialogs.DateTimePicker.Companion.newDateTimePicker import org.tasks.dialogs.DateTimePicker.Companion.newDateTimePicker
import org.tasks.filters.Filter import org.tasks.filters.Filter
@ -24,7 +25,7 @@ import javax.inject.Inject
class WidgetClickActivity : AppCompatActivity(), OnDismissHandler { class WidgetClickActivity : AppCompatActivity(), OnDismissHandler {
@Inject lateinit var taskCompleter: TaskCompleter @Inject lateinit var taskCompleter: TaskCompleter
@Inject lateinit var taskDao: TaskDao @Inject lateinit var taskDao: TaskDao
@Inject lateinit var refreshBroadcaster: RefreshBroadcaster @Inject lateinit var localBroadcastManager: LocalBroadcastManager
@Inject lateinit var preferences: Preferences @Inject lateinit var preferences: Preferences
@Inject lateinit var firebase: Firebase @Inject lateinit var firebase: Firebase
@ -33,37 +34,28 @@ class WidgetClickActivity : AppCompatActivity(), OnDismissHandler {
val intent = intent val intent = intent
val action = intent.action val action = intent.action
if (action.isNullOrEmpty()) { if (action.isNullOrEmpty()) {
finish()
return return
} }
when (action) { when (action) {
COMPLETE_TASK -> { COMPLETE_TASK -> {
val taskId = intent.getLongExtra(EXTRA_TASK_ID, 0L) val task = task
val completed = intent.getBooleanExtra(EXTRA_COMPLETED, false) Timber.tag("$action task=$task")
Timber.tag("$action taskId=$taskId completed=$completed") lifecycleScope.launch(NonCancellable) {
if (taskId > 0) { taskCompleter.setComplete(task, !task.isCompleted)
lifecycleScope.launch(NonCancellable) { firebase.completeTask("widget")
taskCompleter.setComplete(taskId, completed)
firebase.completeTask("widget")
}
} }
finish() finish()
} }
EDIT_TASK -> { EDIT_TASK -> {
val filter = intent.getParcelableExtra<Filter?>(EXTRA_FILTER) val filter = intent.getParcelableExtra<Filter?>(EXTRA_FILTER)
val taskId = intent.getLongExtra(EXTRA_TASK_ID, 0L) val task = task
Timber.tag("$action taskId=$taskId filter=$filter") Timber.tag("$action task=$task filter=$filter")
lifecycleScope.launch { startActivity(
if (taskId > 0) { TaskIntents
val task = taskDao.fetch(taskId) .getEditTaskIntent(this, filter, task)
startActivity( .putExtra(FINISH_AFFINITY, true)
TaskIntents )
.getEditTaskIntent(this@WidgetClickActivity, filter, task) finish()
.putExtra(FINISH_AFFINITY, true)
)
}
finish()
}
} }
OPEN_TASK_LIST -> { OPEN_TASK_LIST -> {
val filter = intent.getParcelableExtra<Filter?>(EXTRA_FILTER) val filter = intent.getParcelableExtra<Filter?>(EXTRA_FILTER)
@ -76,36 +68,23 @@ class WidgetClickActivity : AppCompatActivity(), OnDismissHandler {
finish() finish()
} }
TOGGLE_SUBTASKS -> { TOGGLE_SUBTASKS -> {
val taskId = intent.getLongExtra(EXTRA_TASK_ID, 0L) val task = task
val collapsed = intent.getBooleanExtra(EXTRA_COLLAPSED, false) val collapsed = intent.getBooleanExtra(EXTRA_COLLAPSED, false)
Timber.d("$action collapsed=$collapsed taskId=$taskId") Timber.d("$action collapsed=$collapsed task=$task")
if (taskId > 0) { lifecycleScope.launch(NonCancellable) {
lifecycleScope.launch(NonCancellable) { taskDao.setCollapsed(task.id, collapsed)
taskDao.setCollapsed(taskId, collapsed)
}
} }
finish() finish()
} }
RESCHEDULE_TASK -> { RESCHEDULE_TASK -> {
val taskId = intent.getLongExtra(EXTRA_TASK_ID, 0L) val task = task
Timber.d("$action taskId=$taskId") Timber.d("$action task=$task")
val fragmentManager = supportFragmentManager val fragmentManager = supportFragmentManager
if (fragmentManager.findFragmentByTag(FRAG_TAG_DATE_TIME_PICKER) == null) { if (fragmentManager.findFragmentByTag(FRAG_TAG_DATE_TIME_PICKER) == null) {
lifecycleScope.launch { newDateTimePicker(
val task = taskDao.fetch(taskId) preferences.getBoolean(R.string.p_auto_dismiss_datetime_widget, false),
if (task != null) { task)
newDateTimePicker( .show(fragmentManager, FRAG_TAG_DATE_TIME_PICKER)
preferences.getBoolean(
R.string.p_auto_dismiss_datetime_widget,
false
),
task
)
.show(fragmentManager, FRAG_TAG_DATE_TIME_PICKER)
} else {
finish()
}
}
} }
} }
TOGGLE_GROUP -> { TOGGLE_GROUP -> {
@ -122,16 +101,18 @@ class WidgetClickActivity : AppCompatActivity(), OnDismissHandler {
collapsed.remove(group) collapsed.remove(group)
} }
widgetPreferences.collapsed = collapsed widgetPreferences.collapsed = collapsed
refreshBroadcaster.broadcastRefresh() localBroadcastManager.broadcastRefresh()
finish() finish()
} }
else -> { else -> {
Timber.e("Unknown action $action") Timber.e("Unknown action $action")
finish()
} }
} }
} }
val task: Task
get() = intent.getParcelableExtra(EXTRA_TASK)!!
override fun onDismiss() { override fun onDismiss() {
finish() finish()
} }
@ -144,9 +125,8 @@ class WidgetClickActivity : AppCompatActivity(), OnDismissHandler {
const val RESCHEDULE_TASK = "RESCHEDULE_TASK" const val RESCHEDULE_TASK = "RESCHEDULE_TASK"
const val TOGGLE_GROUP = "TOGGLE_GROUP" const val TOGGLE_GROUP = "TOGGLE_GROUP"
const val EXTRA_FILTER = "extra_filter" const val EXTRA_FILTER = "extra_filter"
const val EXTRA_TASK_ID = "extra_task_id" const val EXTRA_TASK = "extra_task" // $NON-NLS-1$
const val EXTRA_COLLAPSED = "extra_collapsed" const val EXTRA_COLLAPSED = "extra_collapsed"
const val EXTRA_COMPLETED = "extra_completed"
const val EXTRA_GROUP = "extra_group" const val EXTRA_GROUP = "extra_group"
const val EXTRA_WIDGET = "extra_widget" const val EXTRA_WIDGET = "extra_widget"
private const val FRAG_TAG_DATE_TIME_PICKER = "frag_tag_date_time_picker" private const val FRAG_TAG_DATE_TIME_PICKER = "frag_tag_date_time_picker"

@ -1,118 +0,0 @@
package org.tasks.widget
import android.content.ContentProvider
import android.content.ContentValues
import android.database.Cursor
import android.graphics.Bitmap
import android.graphics.Canvas
import android.net.Uri
import android.os.ParcelFileDescriptor
import androidx.core.graphics.createBitmap
import androidx.core.net.toUri
import com.mikepenz.iconics.IconicsDrawable
import com.mikepenz.iconics.utils.sizeDp
import org.tasks.BuildConfig
import org.tasks.icons.OutlinedGoogleMaterial
import timber.log.Timber
import java.io.File
import java.io.FileOutputStream
class WidgetIconProvider : ContentProvider() {
override fun onCreate() = true
override fun openFile(uri: Uri, mode: String): ParcelFileDescriptor? {
if (mode != "r") {
throw SecurityException("Only read access allowed")
}
return try {
val segments = uri.pathSegments
if (segments.size != 2) return null
val iconName = segments[1]
if (!iconName.matches(Regex("^[a-zA-Z0-9_]+$"))) return null
val cacheFile = getCacheFile(iconName)
if (!cacheFile.exists()) {
generateIcon(cacheFile, iconName)
}
if (cacheFile.exists()) {
ParcelFileDescriptor.open(cacheFile, ParcelFileDescriptor.MODE_READ_ONLY)
} else {
null
}
} catch (e: Exception) {
Timber.e(e, "Failed to open icon file for URI: $uri")
null
}
}
private fun generateIcon(file: File, iconName: String) {
try {
val icon = OutlinedGoogleMaterial.getIcon("gmo_$iconName")
val context = context ?: return
val drawable = IconicsDrawable(context, icon).apply {
this.sizeDp = 24
}
val bitmap = createBitmap(
drawable.intrinsicWidth.coerceAtLeast(1),
drawable.intrinsicHeight.coerceAtLeast(1)
)
val canvas = Canvas(bitmap)
drawable.setBounds(0, 0, canvas.width, canvas.height)
drawable.draw(canvas)
file.parentFile?.mkdirs()
FileOutputStream(file).use { out ->
bitmap.compress(Bitmap.CompressFormat.PNG, 100, out)
}
bitmap.recycle()
} catch (e: Exception) {
Timber.e(e, "Failed to generate icon: $iconName")
file.delete()
}
}
private fun getCacheFile(iconName: String): File {
val context = context ?: throw IllegalStateException("Context is null")
val cacheDir = File(context.cacheDir, "widget_icons")
cacheDir.mkdirs()
return File(cacheDir, "${iconName}.png")
}
override fun query(
uri: Uri,
projection: Array<out String>?,
selection: String?,
selectionArgs: Array<out String>?,
sortOrder: String?,
): Cursor? = null
override fun insert(uri: Uri, values: ContentValues?): Uri? = null
override fun update(
uri: Uri,
values: ContentValues?,
selection: String?,
selectionArgs: Array<out String>?,
): Int = 0
override fun delete(uri: Uri, selection: String?, selectionArgs: Array<out String>?): Int = 0
override fun getType(uri: Uri): String = "image/png"
companion object {
const val AUTHORITY = "${BuildConfig.APPLICATION_ID}.widgeticons"
fun getIconUri(iconName: String): Uri {
return "content://$AUTHORITY/icon/$iconName".toUri()
}
}
}

@ -109,7 +109,4 @@
<string name="CFC_importance_name">Prioritet…</string> <string name="CFC_importance_name">Prioritet…</string>
<string name="week_before_due">Sedmica prije roka</string> <string name="week_before_due">Sedmica prije roka</string>
<string name="TEA_control_repeat">Ponovi</string> <string name="TEA_control_repeat">Ponovi</string>
<string name="app_settings">Postavke aplikacije</string>
<string name="customize_drawer">Prilagodi meni</string>
<string name="customize_drawer_summary">Povuci i pusti za promjenu rasporeda u meniju</string>
</resources> </resources>

@ -355,8 +355,8 @@
<string name="location_remind_arrival">Bei Ankunft erinnern</string> <string name="location_remind_arrival">Bei Ankunft erinnern</string>
<string name="location_remind_departure">Bei Abreise erinnern</string> <string name="location_remind_departure">Bei Abreise erinnern</string>
<string name="visit_website">Website öffnen</string> <string name="visit_website">Website öffnen</string>
<string name="location_arrived">%s erreicht</string> <string name="location_arrived">Angekommen um %s</string>
<string name="location_departed">%s verlassen</string> <string name="location_departed">Abgereist um %s</string>
<string name="building_notifications">Benachrichtigungen generieren</string> <string name="building_notifications">Benachrichtigungen generieren</string>
<string name="choose_a_location">Ort auswählen</string> <string name="choose_a_location">Ort auswählen</string>
<string name="pick_this_location">Diesen Ort auswählen</string> <string name="pick_this_location">Diesen Ort auswählen</string>

@ -371,7 +371,7 @@
<string name="cannot_access_account">Tiliin ei päästä käsiksi</string> <string name="cannot_access_account">Tiliin ei päästä käsiksi</string>
<string name="logout">Kirjaudu ulos</string> <string name="logout">Kirjaudu ulos</string>
<string name="this_feature_requires_a_subscription">Tämä ominaisuus vaatii tilauksen</string> <string name="this_feature_requires_a_subscription">Tämä ominaisuus vaatii tilauksen</string>
<string name="requires_pro_subscription">Edellyttää pro-tilauksen</string> <string name="requires_pro_subscription">Edellyttää ammattilaistilauksen</string>
<string name="license_summary">Tasks on vapaa avoimen ohjelmakoodin ohjelmisto lisensöity GNU General Public License v3.0 -lisenssillä</string> <string name="license_summary">Tasks on vapaa avoimen ohjelmakoodin ohjelmisto lisensöity GNU General Public License v3.0 -lisenssillä</string>
<string name="about">Tietoja sovelluksesta</string> <string name="about">Tietoja sovelluksesta</string>
<string name="button_unsubscribe">Peruuta tilaus</string> <string name="button_unsubscribe">Peruuta tilaus</string>
@ -696,30 +696,4 @@
<string name="swipe_to_snooze_time_immediately">välittömästi</string> <string name="swipe_to_snooze_time_immediately">välittömästi</string>
<string name="enable_alarms">Saat ilmoituksen oikeaan aikaan</string> <string name="enable_alarms">Saat ilmoituksen oikeaan aikaan</string>
<string name="enable_alarms_description">Varmista, että saat ilmoituksen oikeaan aikaan, myöntämällä lupa asettaa hälytyksiä ja muistutuksia Asetuksissa</string> <string name="enable_alarms_description">Varmista, että saat ilmoituksen oikeaan aikaan, myöntämällä lupa asettaa hälytyksiä ja muistutuksia Asetuksissa</string>
<string name="app_settings">Sovellusasetukset</string>
<string name="delete_comment">kommentti</string>
<string name="comment">Kommentti</string>
<string name="yesterday">Eilen</string>
<string name="continue_without_sync">Jatka ilman synkronointia</string>
<string name="help_me_choose">Auta minua valitsemaan</string>
<string name="delete_tasks_warning">%s poistetaan. Tätä ei voi perua!</string>
<string name="banner_app_updated_title">Sovellus päivitetty</string>
<string name="banner_app_updated_description">Sovellus päivitettiin juuri %s. Haluatko lukea julkaisutiedot?</string>
<string name="subtasks_multilevel_microsoft">Microsoft To Do ei tue monitasoisia alitehtäviä</string>
<string name="price_per_month_with_currency">%s/kuukausi</string>
<string name="price_per_year_with_currency">%s/vuosi</string>
<string name="add_shortcut_to_home_screen">Lisää pikakuvake aloitusnäytölle</string>
<string name="add_widget_to_home_screen">Lisää pienoissovellus aloitusnäytölle</string>
<string name="cost_free">Hinta: Ilmainen</string>
<string name="cost_money">Hinta: $</string>
<string name="cost_more_money">Hinta: $$$</string>
<string name="multiline_title">Salli moniriviset otsikot</string>
<string name="multiline_title_on">Paina Enter-näppäintä lisätäksesi rivinvaihdon</string>
<string name="multiline_title_off">Paina Valmis tallentaaksesi tehtävän</string>
<string name="sync_warning_microsoft_title">Microsoft To Do synkronoinnista</string>
<string name="sync_warning_microsoft">Kaikkia tehtävän tietoja ei voi synkronoida Microsoft To Do:n kanssa.</string>
<string name="sync_warning_google_tasks_title">Google Taskista</string>
<string name="sync_warning_google_tasks">Kaikkia tehtävän tietoja ei voi synkronoida Google Taskin kanssa</string>
<string name="button_learn_more">Lue lisää</string>
<string name="widget_view_more_tasks">Lisää tehtäviä</string>
</resources> </resources>

@ -1,3 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
</resources>

@ -743,5 +743,4 @@
<string name="banner_app_updated_title">Aplikacija je aktualizirana</string> <string name="banner_app_updated_title">Aplikacija je aktualizirana</string>
<string name="banner_app_updated_description">Aplikacija Tasks je upravo aktualizirana na %s. Želiš li vidjeti bilješke o izdanju?</string> <string name="banner_app_updated_description">Aplikacija Tasks je upravo aktualizirana na %s. Želiš li vidjeti bilješke o izdanju?</string>
<string name="multiline_title_off">Pritisni „Gotovo” za spremanje zadatka</string> <string name="multiline_title_off">Pritisni „Gotovo” za spremanje zadatka</string>
<string name="widget_view_more_tasks">Prikaži više zadataka</string>
</resources> </resources>

@ -9,7 +9,7 @@
<string name="import_summary_title">Riepilogo del ripristino</string> <string name="import_summary_title">Riepilogo del ripristino</string>
<string name="import_summary_message">Il file %1$s contiene %2$s. \n \n %3$s importate, \n %4$s già esistenti \n %5$s con errori</string> <string name="import_summary_message">Il file %1$s contiene %2$s. \n \n %3$s importate, \n %4$s già esistenti \n %5$s con errori</string>
<string name="import_progress_read">Lettura attività %d…</string> <string name="import_progress_read">Lettura attività %d…</string>
<string name="read_permission_label">Permessi di Tasks</string> <string name="read_permission_label">accedere a Tasks</string>
<string name="discard_confirmation">Vuoi davvero annullare tutte le modifiche\?</string> <string name="discard_confirmation">Vuoi davvero annullare tutte le modifiche\?</string>
<string name="keep_editing">No, continua la modifica</string> <string name="keep_editing">No, continua la modifica</string>
<string name="DLG_delete_this_task_question">Eliminare questa attività\?</string> <string name="DLG_delete_this_task_question">Eliminare questa attività\?</string>
@ -451,8 +451,8 @@
<string name="location_radius_meters">%s m</string> <string name="location_radius_meters">%s m</string>
<string name="subtasks">Attività secondaria</string> <string name="subtasks">Attività secondaria</string>
<string name="TEA_timer_controls">Timer</string> <string name="TEA_timer_controls">Timer</string>
<string name="chip_appearance">Aspetto Chip</string> <string name="chip_appearance">Aspetto etichetta</string>
<string name="chips">Chip</string> <string name="chips">Smart Chips</string>
<string name="custom_filter_not">NON</string> <string name="custom_filter_not">NON</string>
<string name="custom_filter_or">O</string> <string name="custom_filter_or">O</string>
<string name="custom_filter_and">E</string> <string name="custom_filter_and">E</string>

@ -111,7 +111,7 @@
<string name="ring_once">Een keer bellen</string> <string name="ring_once">Een keer bellen</string>
<string name="ring_five_times">Vijf keer bellen</string> <string name="ring_five_times">Vijf keer bellen</string>
<string name="ring_nonstop">Non-stop bellen</string> <string name="ring_nonstop">Non-stop bellen</string>
<string name="rmd_NoA_done">Voltooid</string> <string name="rmd_NoA_done">Gereed</string>
<string name="rmd_NoA_snooze">Snoozen</string> <string name="rmd_NoA_snooze">Snoozen</string>
<string name="snooze_all">Alles snoozen</string> <string name="snooze_all">Alles snoozen</string>
<string name="rmd_EPr_quiet_hours_start_title">Begin rusttijd</string> <string name="rmd_EPr_quiet_hours_start_title">Begin rusttijd</string>

@ -672,7 +672,7 @@
<string name="enable_reminders">Activează memento-uri</string> <string name="enable_reminders">Activează memento-uri</string>
<string name="enable_reminders_description">Reamintirile sunt dezactivate în Setări Android</string> <string name="enable_reminders_description">Reamintirile sunt dezactivate în Setări Android</string>
<string name="TEA_creation_date">Data creării</string> <string name="TEA_creation_date">Data creării</string>
<string name="default_reminder">Memento implicit</string> <string name="default_reminder">Reamintire implicită</string>
<string name="rmd_time_description">Afișează notificări pentru sarcinile fără termene limită</string> <string name="rmd_time_description">Afișează notificări pentru sarcinile fără termene limită</string>
<string name="consent_agree">De acord</string> <string name="consent_agree">De acord</string>
<string name="consent_deny">Nu acum</string> <string name="consent_deny">Nu acum</string>
@ -748,5 +748,4 @@
<string name="delete_tasks_warning">%s va fi șters. Acest lucru nu poate fi anulat!</string> <string name="delete_tasks_warning">%s va fi șters. Acest lucru nu poate fi anulat!</string>
<string name="banner_app_updated_title">Aplicație actualizată</string> <string name="banner_app_updated_title">Aplicație actualizată</string>
<string name="banner_app_updated_description">Tasks a fost actualizată la versiunea %s. Dorești să vezi modificările făcute?</string> <string name="banner_app_updated_description">Tasks a fost actualizată la versiunea %s. Dorești să vezi modificările făcute?</string>
<string name="widget_view_more_tasks">Vezi mai multe sarcini</string>
</resources> </resources>

@ -1,30 +1,30 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<resources> <resources>
<string name="SSD_sort_auto">Паметно сортирање</string> <string name="SSD_sort_auto">Pametno sortiranje</string>
<string name="SSD_sort_alpha">По наслову</string> <string name="SSD_sort_alpha">Po naslovu</string>
<string name="SSD_sort_due">По датуму доспећа</string> <string name="SSD_sort_due">Po datumu</string>
<string name="SSD_sort_importance">По приоритету</string> <string name="SSD_sort_importance">Po prioritetnosti</string>
<string name="SSD_sort_modified">По датуму модификације</string> <string name="SSD_sort_modified">Po zadnjoj izmeni</string>
<string name="TEA_title_hint">Име задатка</string> <string name="TEA_title_hint">Ime zadatka</string>
<string name="TEA_importance_label">Приоритет</string> <string name="TEA_importance_label">Prioritet</string>
<string name="custom_filter_or">Или</string> <string name="custom_filter_or">ili</string>
<string name="custom_filter_not">Не</string> <string name="custom_filter_not">Ne</string>
<string name="custom_filter_and">Такође</string> <string name="custom_filter_and">takođe</string>
<string name="CFA_button_add">Додај критеријум</string> <string name="CFA_button_add">Dodati kriterijum</string>
<string name="CFC_dueBefore_text">По датуму: ?</string> <string name="CFC_dueBefore_text">Po datumu: ?</string>
<string name="gcal_completed_title">%s (завршено)</string> <string name="gcal_completed_title">%s (završeno)</string>
<string name="rmd_EPr_defaultRemind_title">Насумични подсетници</string> <string name="rmd_EPr_defaultRemind_title">Nasumice posetnik</string>
<string name="delete_task">Обриши задатак</string> <string name="delete_task">Obriši zadatak</string>
<string name="contact_developer">Контактирај развојни тим</string> <string name="contact_developer">Kontaktiraj razvojni tim</string>
<string name="rate_tasks">Оцени апликацију</string> <string name="rate_tasks">Oceni Task</string>
<string name="quiet_hours_summary">Без подсетника у мирним сатима</string> <string name="quiet_hours_summary">Bez podsetnika u mirnim satima</string>
<string name="filter_settings">Подешавања филтера</string> <string name="filter_settings">Подешавања филтера</string>
<string name="import_summary_title">Обнови сажетак</string> <string name="import_summary_title">Обнови сажетак</string>
<string name="export_toast">Копија сачувана од %1$s до %2$s.</string> <string name="export_toast">Копија сачувана од %1$s до %2$s.</string>
<string name="backup_BAc_import">Увези задатке</string> <string name="backup_BAc_import">Увези задатке</string>
<string name="backup_BAc_export">Извези задатке</string> <string name="backup_BAc_export">Извези задатке</string>
<string name="backup_BPr_header">Резервне копије</string> <string name="backup_BPr_header">Резервне копије</string>
<string name="TVA_add_comment">Додај коментар…</string> <string name="TVA_add_comment">Додајте коментар…</string>
<string name="cancel">Откажи</string> <string name="cancel">Откажи</string>
<string name="ok">У реду</string> <string name="ok">У реду</string>
<string name="read_permission_label">Дозволе задатака</string> <string name="read_permission_label">Дозволе задатака</string>
@ -408,7 +408,7 @@
<string name="button_subscribe">Претплати се</string> <string name="button_subscribe">Претплати се</string>
<string name="button_unsubscribe">Откажи претплату</string> <string name="button_unsubscribe">Откажи претплату</string>
<string name="about">О нама</string> <string name="about">О нама</string>
<string name="license_summary">,,Tasks.org\'\' је софтвер отвореног карактера, са лиценцом ,,GNU General Public License v3.0\'\'</string> <string name="license_summary">,,Задаци\'\' је софтвер отвореног карактера, са лиценцом ,,GNU General Public License v3.0\'\'</string>
<string name="requires_pro_subscription">Захтева претплату</string> <string name="requires_pro_subscription">Захтева претплату</string>
<string name="this_feature_requires_a_subscription">Ова функционалност захтева претплату</string> <string name="this_feature_requires_a_subscription">Ова функционалност захтева претплату</string>
<string name="logout">Одјави се</string> <string name="logout">Одјави се</string>
@ -426,7 +426,7 @@
<string name="choose_a_location">Одабери локацију</string> <string name="choose_a_location">Одабери локацију</string>
<string name="pick_this_location">Одабери ову локацију</string> <string name="pick_this_location">Одабери ову локацију</string>
<string name="or_choose_a_location">Или бирај локацију</string> <string name="or_choose_a_location">Или бирај локацију</string>
<string name="background_location_permission_required">,,Tasks.org\'\' скупља податке о локацији како би локационо везани подсетници радили, чак и када је апликација угашена или се не користи.</string> <string name="background_location_permission_required">,,Задаци\'\' скупља податке о локацији како би локационо везани подсетници радили, чак и када је апликација угашена или се не користи.</string>
<string name="location_permission_required_location">Потребна је локациона дозвола за налажење тренутне локације</string> <string name="location_permission_required_location">Потребна је локациона дозвола за налажење тренутне локације</string>
<string name="open_map">Отвори мапу</string> <string name="open_map">Отвори мапу</string>
<string name="choose_new_location">Одабери нову локацију</string> <string name="choose_new_location">Одабери нову локацију</string>
@ -453,7 +453,7 @@
<string name="more_settings">Додатна подешавања</string> <string name="more_settings">Додатна подешавања</string>
<string name="more_notification_settings_summary">Звук звона, вибрација и додатно</string> <string name="more_notification_settings_summary">Звук звона, вибрација и додатно</string>
<string name="invalid_username_or_password">Невалидно корисничко име или шифра</string> <string name="invalid_username_or_password">Невалидно корисничко име или шифра</string>
<string name="upgrade_blurb_1">Здраво! Моје име је Алекс. Ја сам независни развојни инжењер у ,,Tasks.org\'\' апликацији</string> <string name="upgrade_blurb_1">Здраво! Моје име је Алекс. Ја сам независни развојни инжењер у ,,Задаци\'\' апликацији</string>
<string name="upgrade_blurb_2">Провео сам хиљаде часова радећи на апликацији, коју објављујем онлајн бесплатно. Како бисте подржали мој рад, неке функционалности захтевају претплату</string> <string name="upgrade_blurb_2">Провео сам хиљаде часова радећи на апликацији, коју објављујем онлајн бесплатно. Како бисте подржали мој рад, неке функционалности захтевају претплату</string>
<string name="back">Назад</string> <string name="back">Назад</string>
<string name="places">Места</string> <string name="places">Места</string>
@ -743,5 +743,4 @@
<string name="task_defaults">Подразумевано за задатке</string> <string name="task_defaults">Подразумевано за задатке</string>
<string name="CFC_importance_text">Минимум приоритета ?</string> <string name="CFC_importance_text">Минимум приоритета ?</string>
<string name="caldav_home_set_not_found">Сет није пронађен</string> <string name="caldav_home_set_not_found">Сет није пронађен</string>
<string name="widget_view_more_tasks">Погледај још задатака</string>
</resources> </resources>

@ -721,5 +721,4 @@
<string name="help_me_choose">Hjälp mig att välja</string> <string name="help_me_choose">Hjälp mig att välja</string>
<string name="delete_tasks_warning">%s kommer att tas bort. Detta kan inte ångras!</string> <string name="delete_tasks_warning">%s kommer att tas bort. Detta kan inte ångras!</string>
<string name="continue_without_sync">Fortsätt utan synkronisering</string> <string name="continue_without_sync">Fortsätt utan synkronisering</string>
<string name="widget_view_more_tasks">Visa mer uppgifter</string>
</resources> </resources>

@ -29,10 +29,8 @@
<locale android:name="hy" /> <locale android:name="hy" />
<locale android:name="ia" /> <locale android:name="ia" />
<locale android:name="id" /> <locale android:name="id" />
<locale android:name="in" />
<locale android:name="it" /> <locale android:name="it" />
<locale android:name="iw" /> <locale android:name="iw" />
<locale android:name="he" />
<locale android:name="ja" /> <locale android:name="ja" />
<locale android:name="kmr" /> <locale android:name="kmr" />
<locale android:name="kn" /> <locale android:name="kn" />

@ -13,6 +13,6 @@
android:minResizeWidth="110dp" android:minResizeWidth="110dp"
android:minWidth="110dp" android:minWidth="110dp"
android:resizeMode="horizontal|vertical" android:resizeMode="horizontal|vertical"
android:updatePeriodMillis="0" android:updatePeriodMillis="1800000"
android:widgetCategory="keyguard|home_screen" android:widgetCategory="keyguard|home_screen"
tools:ignore="UnusedAttribute"/> tools:ignore="UnusedAttribute"/>

@ -295,7 +295,7 @@ class AlarmCalculatorTest {
@Test @Test
fun scheduleOverdueRandomReminder() { fun scheduleOverdueRandomReminder() {
random.stub = 0.3865f random.seed = 0.3865f
freezeAt(now) { freezeAt(now) {
val alarm = alarmCalculator.toAlarmEntry( val alarm = alarmCalculator.toAlarmEntry(
newTask( newTask(
@ -316,7 +316,7 @@ class AlarmCalculatorTest {
@Test @Test
fun scheduleOverdueRandomReminderForHiddenTask() { fun scheduleOverdueRandomReminderForHiddenTask() {
random.stub = 0.3865f random.seed = 0.3865f
freezeAt(now) { freezeAt(now) {
val task = newTask( val task = newTask(
with(REMINDER_LAST, now.minusDays(14)), with(REMINDER_LAST, now.minusDays(14)),
@ -335,7 +335,7 @@ class AlarmCalculatorTest {
@Test @Test
fun scheduleInitialRandomReminder() { fun scheduleInitialRandomReminder() {
random.stub = 0.3865f random.seed = 0.3865f
freezeAt(now) { freezeAt(now) {
val alarm = alarmCalculator.toAlarmEntry( val alarm = alarmCalculator.toAlarmEntry(
@ -358,7 +358,7 @@ class AlarmCalculatorTest {
@Test @Test
fun scheduleNextRandomReminder() { fun scheduleNextRandomReminder() {
random.stub = 0.3865f random.seed = 0.3865f
freezeAt(now) { freezeAt(now) {
val alarm = alarmCalculator.toAlarmEntry( val alarm = alarmCalculator.toAlarmEntry(
@ -379,28 +379,9 @@ class AlarmCalculatorTest {
} }
} }
@Test
fun randomReminderIsDeterministic() {
val calculator = AlarmCalculator(
isDefaultDueTimeEnabled = true,
random = Random(),
defaultDueTime = TimeUnit.HOURS.toMillis(13).toInt(),
)
freezeAt(now) {
val task = newTask(with(CREATION_TIME, now.minusDays(1)))
val alarm = Alarm(time = ONE_WEEK, type = TYPE_RANDOM)
val first = calculator.toAlarmEntry(task, alarm)
val second = calculator.toAlarmEntry(task, alarm)
assertEquals(first, second)
}
}
internal class RandomStub : Random() { internal class RandomStub : Random() {
var stub = 1.0f var seed = 1.0f
override fun nextFloat(seed: Long) = this.stub override fun nextFloat() = seed
} }
} }

@ -1,19 +1,13 @@
package org.tasks.caldav.extensions package org.tasks.caldav.extensions
import at.bitfire.ical4android.Task.Companion.tasksFromReader
import org.junit.Assert.assertEquals import org.junit.Assert.assertEquals
import org.junit.Test import org.junit.Test
import org.tasks.caldav.iCalendar.Companion.applyLocal
import org.tasks.data.createDueDate
import org.tasks.data.entity.Alarm import org.tasks.data.entity.Alarm
import org.tasks.data.entity.Alarm.Companion.TYPE_DATE_TIME import org.tasks.data.entity.Alarm.Companion.TYPE_DATE_TIME
import org.tasks.data.entity.Alarm.Companion.TYPE_REL_END import org.tasks.data.entity.Alarm.Companion.TYPE_REL_END
import org.tasks.data.entity.Alarm.Companion.TYPE_REL_START import org.tasks.data.entity.Alarm.Companion.TYPE_REL_START
import org.tasks.data.entity.CaldavTask
import org.tasks.data.entity.Task
import org.tasks.time.DateTime import org.tasks.time.DateTime
import org.tasks.time.DateTime.Companion.UTC import org.tasks.time.DateTime.Companion.UTC
import java.io.ByteArrayInputStream
import java.util.concurrent.TimeUnit.HOURS import java.util.concurrent.TimeUnit.HOURS
import java.util.concurrent.TimeUnit.MINUTES import java.util.concurrent.TimeUnit.MINUTES
@ -117,34 +111,4 @@ class VAlarmTests {
) )
assertEquals(alarm, alarm.toVAlarm()?.toAlarm()) assertEquals(alarm, alarm.toVAlarm()?.toAlarm())
} }
@Test
fun serializeAlarms() {
val remoteTask = at.bitfire.ical4android.Task()
remoteTask.applyLocal(
CaldavTask(
calendar = "",
),
Task(
dueDate = createDueDate(
Task.URGENCY_SPECIFIC_DAY_TIME,
DateTime(2025, 9, 4, 18, 0, 0).millis
),
),
)
Alarm(time = 0, type = TYPE_REL_END).toVAlarm()?.let { remoteTask.alarms.add(it) }
val os = java.io.ByteArrayOutputStream()
remoteTask.write(os)
val tasks = tasksFromReader(ByteArrayInputStream(os.toByteArray()).reader())
assertEquals(1, tasks.size)
val task = tasks.first()
assertEquals(1, task.alarms.size)
val alarm = task.alarms.first().toAlarm()
assertEquals(TYPE_REL_END, alarm?.type)
assertEquals(0L, alarm?.time)
}
} }

@ -91,7 +91,7 @@ class ConvertToMicrosoftTests {
@Test @Test
fun noCategories() { fun noCategories() {
val remote = newTask().toRemote() val remote = newTask().toRemote()
assertEquals(true, remote.categories?.isEmpty()) assertNull(remote.categories)
} }
@Test @Test

@ -83,15 +83,8 @@ abstract class GoogleTaskDao {
@Query("SELECT * FROM caldav_tasks WHERE cd_remote_id = :remoteId LIMIT 1") @Query("SELECT * FROM caldav_tasks WHERE cd_remote_id = :remoteId LIMIT 1")
abstract suspend fun getByRemoteId(remoteId: String): CaldavTask? abstract suspend fun getByRemoteId(remoteId: String): CaldavTask?
@Query(""" @Query("SELECT * FROM caldav_tasks WHERE cd_task = :taskId AND cd_deleted > 0")
SELECT caldav_tasks.* abstract suspend fun getDeletedByTaskId(taskId: Long): List<CaldavTask>
FROM caldav_tasks
INNER JOIN caldav_lists ON cdl_uuid = cd_calendar
WHERE cd_task = :taskId
AND cd_deleted > 0
AND cdl_account = :account
""")
abstract suspend fun getDeletedByTaskId(taskId: Long, account: String): List<CaldavTask>
@Query("SELECT * FROM caldav_tasks WHERE cd_task = :taskId") @Query("SELECT * FROM caldav_tasks WHERE cd_task = :taskId")
abstract suspend fun getAllByTaskId(taskId: Long): List<CaldavTask> abstract suspend fun getAllByTaskId(taskId: Long): List<CaldavTask>

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

Some files were not shown because too many files have changed in this diff Show More

Loading…
Cancel
Save