Catch and report exception

Crashing when saving existing task edit fragment during
TaskListActivity.onCreate
pull/384/head
Alex Baker 9 years ago
parent ae2f2b24c4
commit d91da502d0

@ -34,6 +34,7 @@ import com.todoroo.astrid.ui.EditTitleControlSet;
import com.todoroo.astrid.utility.Flags; import com.todoroo.astrid.utility.Flags;
import org.tasks.R; import org.tasks.R;
import org.tasks.analytics.Tracker;
import org.tasks.dialogs.DialogBuilder; import org.tasks.dialogs.DialogBuilder;
import org.tasks.fragments.TaskEditControlSetFragmentManager; import org.tasks.fragments.TaskEditControlSetFragmentManager;
import org.tasks.injection.ForActivity; import org.tasks.injection.ForActivity;
@ -49,6 +50,7 @@ import javax.inject.Inject;
import butterknife.Bind; import butterknife.Bind;
import butterknife.ButterKnife; import butterknife.ButterKnife;
import timber.log.Timber;
import static org.tasks.date.DateTimeUtils.newDateTime; import static org.tasks.date.DateTimeUtils.newDateTime;
@ -80,6 +82,7 @@ public final class TaskEditFragment extends InjectingFragment implements Toolbar
@Inject TaskEditControlSetFragmentManager taskEditControlSetFragmentManager; @Inject TaskEditControlSetFragmentManager taskEditControlSetFragmentManager;
@Inject CommentsController commentsController; @Inject CommentsController commentsController;
@Inject Preferences preferences; @Inject Preferences preferences;
@Inject Tracker tracker;
@Bind(R.id.toolbar) Toolbar toolbar; @Bind(R.id.toolbar) Toolbar toolbar;
@Bind(R.id.comments) LinearLayout comments; @Bind(R.id.comments) LinearLayout comments;
@ -229,11 +232,16 @@ public final class TaskEditFragment extends InjectingFragment implements Toolbar
*/ */
private boolean hasChanges(List<TaskEditControlFragment> fragments) { private boolean hasChanges(List<TaskEditControlFragment> fragments) {
try {
for (TaskEditControlFragment fragment : fragments) { for (TaskEditControlFragment fragment : fragments) {
if (fragment.hasChanges(model)) { if (fragment.hasChanges(model)) {
return true; return true;
} }
} }
} catch(Exception e) {
Timber.e(e, e.getMessage());
tracker.reportException(e);
}
return false; return false;
} }

Loading…
Cancel
Save