Bumped Astrid version to push out an Astrid 3.3 release with cleaner caching logic and no debug statements

astrid/AndroidManifest.xml

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           package="com.timsu.astrid"
-          android:versionName="3.3.2 (bug fix release)" 
-          android:versionCode="157">
+          android:versionName="3.3.3 (bug fix release)" 
+          android:versionCode="158">
           
   <!-- widgets, alarms, and services will break if Astrid is installed on SD card -->
   <!--    android:installLocation="internalOnly"> -->
@@ -212,7 +212,7 @@
     </receiver>    
     
     <!-- gtasks -->
-    <receiver android:name="com.todoroo.astrid.gtasks.GtasksFilterExposer">
+    <!-- receiver android:name="com.todoroo.astrid.gtasks.GtasksFilterExposer">
       <intent-filter>
         <action android:name="com.todoroo.astrid.REQUEST_FILTERS" />
         <category android:name="android.intent.category.DEFAULT" />
@@ -266,7 +266,7 @@
         <action android:name="com.todoroo.astrid.CONTEXT_MENU" />
         <category android:name="android.intent.category.DEFAULT" />
       </intent-filter>
-    </receiver>    
+    </receiver -->    
     
     <!-- tags -->
     <receiver android:name="com.todoroo.astrid.tags.TagsPlugin">

astrid/plugin-src/com/todoroo/astrid/core/CustomFilterActivity.java

@@ -436,7 +436,6 @@ public class CustomFilterActivity extends ListActivity {
             else {
                 String subSql = instance.criterion.sql.replace("?", value);
                 subSql = PermaSql.replacePlaceholders(subSql);
-                System.err.println(subSql);
                 sql.append(Task.ID).append(" IN (").append(subSql).append(") ");
             }
 
@@ -447,7 +446,6 @@ public class CustomFilterActivity extends ListActivity {
                 instance.end = cursor.getInt(0);
                 last = instance.end;
                 max = Math.max(max, last);
-                System.err.println("updated instance to " + last);
             } finally {
                 cursor.close();
             }

astrid/src/com/todoroo/astrid/adapter/TaskAdapter.java

@@ -425,17 +425,18 @@ public class TaskAdapter extends CursorAdapter implements Filterable {
 
                     if(detailsAreRecentAndUpToDate(task)) {
                         // even if we are up to date, randomly load a fraction
-                        if(random.nextFloat() < 0.2) {
+                        if(random.nextFloat() < 0.1) {
                             taskDetailLoader.put(task.getId(),
                                     new StringBuilder(task.getValue(Task.DETAILS)));
                             requestNewDetails(task);
-                            System.err.println("Refreshing details: " + task.getId());
+                            if(Constants.DEBUG)
+                                System.err.println("Refreshing details: " + task.getId()); //$NON-NLS-1$
                         }
                         continue;
-                    } else {
-                        System.err.println("Forced loading of details: " + task.getId() +
-                        		"\n  details: " + new Date(task.getValue(Task.DETAILS_DATE)) +
-                        		"\n  modified: " + new Date(task.getValue(Task.MODIFICATION_DATE)));
+                    } else if(Constants.DEBUG) {
+                        System.err.println("Forced loading of details: " + task.getId() + //$NON-NLS-1$
+                        		"\n  details: " + new Date(task.getValue(Task.DETAILS_DATE)) + //$NON-NLS-1$
+                        		"\n  modified: " + new Date(task.getValue(Task.MODIFICATION_DATE))); //$NON-NLS-1$
                     }
                     addTaskToLoadingArray(task);
 
@@ -451,8 +452,7 @@ public class TaskAdapter extends CursorAdapter implements Filterable {
         }
 
         private boolean detailsAreRecentAndUpToDate(Task task) {
-            return task.getValue(Task.DETAILS_DATE) > DateUtilities.now() - 3 * DateUtilities.ONE_DAY &&
-                task.getValue(Task.DETAILS_DATE) >= task.getValue(Task.MODIFICATION_DATE) &&
+            return task.getValue(Task.DETAILS_DATE) >= task.getValue(Task.MODIFICATION_DATE) &&
                 !TextUtils.isEmpty(task.getValue(Task.DETAILS));
         }
 
@@ -487,7 +487,6 @@ public class TaskAdapter extends CursorAdapter implements Filterable {
             details.append(detail);
             Task task = new Task();
             task.setId(id);
-            System.err.println("task " + id + " - '" + details.toString() + "' (" + detail + ")");
             task.setValue(Task.DETAILS, details.toString());
             task.setValue(Task.DETAILS_DATE, DateUtilities.now());
             taskService.save(task);

astrid/src/com/todoroo/astrid/dao/TaskDao.java

@@ -215,7 +215,6 @@ public class TaskDao extends DatabaseDao<Task> {
             item.setValue(Task.DETAILS, null);
             item.setValue(Task.MODIFICATION_DATE, DateUtilities.now());
         }
-        System.err.println(">> SAVE EXISTING: " + item.getSetValues());
         return super.saveExisting(item);
     }
 

astrid/src/com/todoroo/astrid/utility/Constants.java

@@ -30,7 +30,7 @@ public final class Constants {
     /**
      * Whether to turn on debugging logging and UI
      */
-    public static final boolean DEBUG = true;
+    public static final boolean DEBUG = false;
 
     /**
      * Upgrade time