Fixed some warnings, moved translations into sync file, fixed an issue with leaking reciever

astrid/plugin-src/com/todoroo/astrid/tags/TagDetailExposer.java

@@ -25,7 +25,7 @@ public class TagDetailExposer extends BroadcastReceiver {
             return;
 
         boolean extended = intent.getBooleanExtra(AstridApiConstants.EXTRAS_EXTENDED, false);
-        String taskDetail = getTaskDetails(context, taskId, extended);
+        String taskDetail = getTaskDetails(taskId, extended);
         if(taskDetail == null)
             return;
 
@@ -38,7 +38,7 @@ public class TagDetailExposer extends BroadcastReceiver {
         context.sendBroadcast(broadcastIntent, AstridApiConstants.PERMISSION_READ);
     }
 
-    public String getTaskDetails(Context context, long id, boolean extended) {
+    public String getTaskDetails(long id, boolean extended) {
         if(extended)
             return null;
 

astrid/res/values/strings-core.xml

@@ -517,17 +517,6 @@ to the plugin creator for fastest service.
   <!-- Add-on Activity - menu item to visit android market -->
   <string name="AOA_visit_market">Android Market</string>
   
-  <!-- ========================================== SynchronizationProvider == -->
-          
-  <!-- Sync Notification: message when sync service active -->
-  <string name="SyP_progress">Synchronizing your tasks...</string>
-  
-  <!-- Sync Notification: toast when sync activated from activity -->
-  <string name="SyP_progress_toast">Synchronizing...</string>
-  
-  <!-- Sync Label: used in menu to denote synchronization -->
-  <string name="SyP_label">Synchronization</string>
-  
   <!-- ====================================================== TasksWidget == -->
 
   <!-- Widget text when loading tasks -->

astrid/res/values/strings-sync.xml

@@ -2,6 +2,17 @@
 <!-- See the file "LICENSE" for the full license governing this code. -->
 <resources xmlns:android="http://schemas.android.com/apk/res/android">
 
+  <!-- ========================================== SynchronizationProvider == -->
+          
+  <!-- Sync Notification: message when sync service active -->
+  <string name="SyP_progress">Synchronizing your tasks...</string>
+  
+  <!-- Sync Notification: toast when sync activated from activity -->
+  <string name="SyP_progress_toast">Synchronizing...</string>
+  
+  <!-- Sync Label: used in menu to denote synchronization -->
+  <string name="SyP_label">Synchronization</string>  
+
   <!-- ======================== SyncPreferences ========================== -->
   
   <!-- Status Group Label -->    

astrid/src/com/todoroo/astrid/activity/TaskListActivity.java

@@ -448,6 +448,7 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
         super.onPause();
         unregisterReceiver(detailReceiver);
         unregisterReceiver(refreshReceiver);
+        unregisterReceiver(syncActionReceiver);
         backgroundTimer.cancel();
     }
 

astrid/src/com/todoroo/astrid/adapter/TaskAdapter.java

@@ -48,9 +48,6 @@ import com.todoroo.astrid.api.AstridApiConstants;
 import com.todoroo.astrid.api.TaskAction;
 import com.todoroo.astrid.api.TaskDecoration;
 import com.todoroo.astrid.model.Task;
-import com.todoroo.astrid.notes.NoteDetailExposer;
-import com.todoroo.astrid.producteev.ProducteevDetailExposer;
-import com.todoroo.astrid.repeats.RepeatDetailExposer;
 import com.todoroo.astrid.service.AddOnService;
 import com.todoroo.astrid.service.TaskService;
 import com.todoroo.astrid.utility.Constants;

astrid/src/com/todoroo/astrid/service/AddOnService.java

@@ -234,9 +234,9 @@ public class AddOnService {
                 Constants.PACKAGE, "http://www.producteev.com",
                 ((BitmapDrawable)r.getDrawable(R.drawable.icon_producteev)).getBitmap());
 
-        list[3] = new AddOn(true, true, "Remember the Milk", null,
+        list[3] = new AddOn(true, false, "Remember the Milk", null,
                 "Synchronize with Remember The Milk service.",
-                Constants.PACKAGE, "http://www.rmilk.com",
+                "org.weloveastrid.rmilk", "http://www.rmilk.com",
                 ((BitmapDrawable)r.getDrawable(R.drawable.ic_menu_refresh)).getBitmap());
 
         return list;