Fixed a crash that could occur when processing update messages

astrid/src/com/todoroo/astrid/service/UpdateMessageService.java

@@ -109,23 +109,25 @@ public class UpdateMessageService {
         }
     }
 
-    protected void displayUpdateDialog(Pair<String, Spannable> message) {
+    protected void displayUpdateDialog(final Pair<String, Spannable> message) {
         if(activity == null)
             return;
 
         final DialogShower ds;
         if (message.getRight() != null) {
-            final View view = activity.getLayoutInflater().inflate(R.layout.update_message_link, null);
+            ds = new DialogShower() {
+                @Override
+                public void showDialog(Activity a) {
+                    try {
+                        View view = activity.getLayoutInflater().inflate(R.layout.update_message_link, null);
                         TextView messageView = (TextView) view.findViewById(R.id.update_message);
                         messageView.setText(message.getLeft());
                         messageView.setTextColor(activity.getResources().getColor(ThemeService.getDialogTextColor()));
 
-            final TextView linkView = (TextView) view.findViewById(R.id.update_link);
+                        TextView linkView = (TextView) view.findViewById(R.id.update_link);
                         linkView.setMovementMethod(LinkMovementMethod.getInstance());
                         linkView.setText(message.getRight());
-            ds = new DialogShower() {
-                @Override
-                public void showDialog(Activity a) {
+
                         final Dialog d = new AlertDialog.Builder(a)
                         .setTitle(R.string.UpS_updates_title)
                         .setView(view)
@@ -138,6 +140,9 @@ public class UpdateMessageService {
                             }
                         });
                         d.show();
+                    } catch (Exception e) {
+                        // This should never ever crash
+                    }
                 }
             };
         } else {