Minor Kotlin improvements

pull/1264/head
Alex Baker 5 years ago
parent 1108322054
commit c36392fac9

@ -184,12 +184,11 @@ class CaldavSynchronizer @Inject constructor(
} }
} }
val changed = members.filter { vCard: Response -> val changed = members.filter { vCard: Response ->
val eTag = vCard[GetETag::class.java] val eTag = vCard[GetETag::class.java]?.eTag
if (eTag == null || isNullOrEmpty(eTag.eTag)) { if (eTag.isNullOrBlank()) {
return@filter false return@filter false
} }
val caldavTask = caldavDao.getTask(caldavCalendar.uuid!!, vCard.hrefName()) eTag != caldavDao.getTask(caldavCalendar.uuid!!, vCard.hrefName())?.etag
caldavTask == null || eTag.eTag != caldavTask.etag
} }
for (items in changed.chunked(30)) { for (items in changed.chunked(30)) {
val urls = items.map { it.href } val urls = items.map { it.href }
@ -201,24 +200,23 @@ class CaldavSynchronizer @Inject constructor(
} }
Timber.d("MULTI %s", urls) Timber.d("MULTI %s", urls)
for (vCard in responses) { for (vCard in responses) {
val eTag = vCard[GetETag::class.java] val eTag = vCard[GetETag::class.java]?.eTag
val url = vCard.href val url = vCard.href
if (eTag == null || isNullOrEmpty(eTag.eTag)) { if (eTag.isNullOrBlank()) {
throw DavException("Received CalDAV GET response without ETag for $url") throw DavException("Received CalDAV GET response without ETag for $url")
} }
val calendarData = vCard[CalendarData::class.java] val vtodo = vCard[CalendarData::class.java]?.iCalendar
if (calendarData == null || isNullOrEmpty(calendarData.iCalendar)) { if (vtodo.isNullOrBlank()) {
throw DavException("Received CalDAV GET response without CalendarData for $url") throw DavException("Received CalDAV GET response without CalendarData for $url")
} }
val fileName = vCard.hrefName() val fileName = vCard.hrefName()
val vtodo = calendarData.iCalendar val remote = fromVtodo(vtodo)
val remote = fromVtodo(vtodo!!)
if (remote == null) { if (remote == null) {
Timber.e("Invalid VCALENDAR: %s", fileName) Timber.e("Invalid VCALENDAR: %s", fileName)
return return
} }
val caldavTask = caldavDao.getTask(caldavCalendar.uuid!!, fileName) val caldavTask = caldavDao.getTask(caldavCalendar.uuid!!, fileName)
iCal.fromVtodo(caldavCalendar, caldavTask, remote, vtodo, fileName, eTag.eTag) iCal.fromVtodo(caldavCalendar, caldavTask, remote, vtodo, fileName, eTag)
} }
} }
caldavDao caldavDao

Loading…
Cancel
Save