Remove unused extras

pull/281/head
Alex Baker 9 years ago
parent f99bea58a9
commit b6223335e6

@ -12,13 +12,9 @@ import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import com.todoroo.andlib.sql.QueryTemplate;
import com.todoroo.andlib.utility.AndroidUtilities;
import com.todoroo.astrid.api.Filter;
import com.todoroo.astrid.api.FilterWithCustomIntent;
import com.todoroo.astrid.data.Task;
import org.tasks.R;
import java.util.Map.Entry;
import java.util.Set;
@ -34,19 +30,12 @@ public class ShortcutActivity extends Activity {
// --- constants
/** token for passing a task id through extras for viewing a single task */
public static final String TOKEN_SINGLE_TASK = "id"; //$NON-NLS-1$
/** token for passing a {@link Filter}'s title through extras */
public static final String TOKEN_FILTER_TITLE = "title"; //$NON-NLS-1$
/** token for passing a {@link Filter}'s sql through extras */
public static final String TOKEN_FILTER_SQL = "sql"; //$NON-NLS-1$
/** token for passing a {@link Filter}'s values for new tasks through extras as string */
@Deprecated
public static final String TOKEN_FILTER_VALUES = "v4nt"; //$NON-NLS-1$
/** token for passing a {@link Filter}'s values for new tasks through extras as exploded ContentValues */
public static final String TOKEN_FILTER_VALUES_ITEM = "v4ntp_"; //$NON-NLS-1$
@ -55,10 +44,8 @@ public class ShortcutActivity extends Activity {
/** List of the above constants for searching */
private static final String[] CUSTOM_EXTRAS = {
TOKEN_SINGLE_TASK,
TOKEN_FILTER_TITLE,
TOKEN_FILTER_SQL,
TOKEN_FILTER_VALUES,
TOKEN_FILTER_VALUES_ITEM,
TOKEN_CUSTOM_CLASS
};
@ -93,31 +80,26 @@ public class ShortcutActivity extends Activity {
String title = extras.getString(TOKEN_FILTER_TITLE);
String sql = extras.getString(TOKEN_FILTER_SQL);
sql = sql.replace("tasks.userId=0", "1"); // TODO: replace dirty hack for missing column
ContentValues values;
if(extras.containsKey(TOKEN_FILTER_VALUES)) {
values = AndroidUtilities.contentValuesFromString(extras.getString(TOKEN_FILTER_VALUES));
} else {
values = new ContentValues();
for(String key : extras.keySet()) {
if(!key.startsWith(TOKEN_FILTER_VALUES_ITEM)) {
continue;
}
ContentValues values = new ContentValues();
for(String key : extras.keySet()) {
if(!key.startsWith(TOKEN_FILTER_VALUES_ITEM)) {
continue;
}
Object value = extras.get(key);
key = key.substring(TOKEN_FILTER_VALUES_ITEM.length());
// assume one of the big 4...
if(value instanceof String) {
values.put(key, (String) value);
} else if(value instanceof Integer) {
values.put(key, (Integer) value);
} else if(value instanceof Double) {
values.put(key, (Double) value);
} else if(value instanceof Long) {
values.put(key, (Long) value);
} else {
throw new IllegalStateException("Unsupported bundle type " + value.getClass()); //$NON-NLS-1$
}
Object value = extras.get(key);
key = key.substring(TOKEN_FILTER_VALUES_ITEM.length());
// assume one of the big 4...
if(value instanceof String) {
values.put(key, (String) value);
} else if(value instanceof Integer) {
values.put(key, (Integer) value);
} else if(value instanceof Double) {
values.put(key, (Double) value);
} else if(value instanceof Long) {
values.put(key, (Long) value);
} else {
throw new IllegalStateException("Unsupported bundle type " + value.getClass()); //$NON-NLS-1$
}
}
@ -138,13 +120,6 @@ public class ShortcutActivity extends Activity {
filter = new Filter(title, sql, values);
}
taskListIntent.putExtra(TaskListFragment.TOKEN_FILTER, filter);
} else if(extras != null && extras.containsKey(TOKEN_SINGLE_TASK)) {
Filter filter = new Filter(getString(R.string.TLA_custom),
new QueryTemplate().where(Task.ID.eq(extras.getLong(TOKEN_SINGLE_TASK, -1))), null);
taskListIntent.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
taskListIntent.putExtra(TaskListFragment.TOKEN_FILTER, filter);
startActivity(taskListIntent);
}
startActivity(taskListIntent);

@ -39,7 +39,6 @@
<string name="TLA_menu_sort">Сортирай</string>
<string name="TLA_menu_search">Търсене</string>
<string name="TLA_menu_settings">Настройки</string>
<string name="TLA_custom">Други</string>
<string name="TAd_hiddenFormat">%s [скрито]</string>
<string name="TAd_deletedFormat">%s [изтрити]</string>
<string name="TAd_completed">Приключена\n%s</string>

@ -34,7 +34,6 @@
<string name="TLA_menu_sort">Ordenació i subtasques</string>
<string name="TLA_menu_search">Cerca</string>
<string name="TLA_menu_settings">Paràmetres</string>
<string name="TLA_custom">Personalitzat</string>
<string name="TAd_hiddenFormat">%s [ocult]</string>
<string name="TAd_deletedFormat">%s [eliminat]</string>
<string name="TAd_completed">Acabat fa\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Třídit</string>
<string name="TLA_menu_search">Hledat</string>
<string name="TLA_menu_settings">Nastavení</string>
<string name="TLA_custom">Vlastní</string>
<string name="TAd_hiddenFormat">%s [skrytý]</string>
<string name="TAd_deletedFormat">%s [smazán]</string>
<string name="TAd_completed">Dokončeno\n%s</string>

@ -33,7 +33,6 @@
<string name="WID_dateButtonUnset">Tryk for at indstille</string>
<string name="TLA_menu_sort">Sorter &amp; skjulte</string>
<string name="TLA_menu_settings">Opsætning</string>
<string name="TLA_custom">Tilpasset</string>
<string name="TAd_hiddenFormat">%s [skjult]</string>
<string name="TAd_deletedFormat">%s [slettet]</string>
<string name="TAd_actionEditTask">Rediger</string>

@ -35,7 +35,6 @@
<string name="TLA_menu_sort">Sortieren</string>
<string name="TLA_menu_search">Suchen</string>
<string name="TLA_menu_settings">Einstellungen</string>
<string name="TLA_custom">Benutzerdefiniert</string>
<string name="TAd_hiddenFormat">%s [versteckt]</string>
<string name="TAd_deletedFormat">%s [gelöscht]</string>
<string name="TAd_completed">Abgeschlossen\n%s</string>

@ -38,7 +38,6 @@
<string name="TLA_menu_sort">Ταξινόμηση</string>
<string name="TLA_menu_search">Αναζήτηση</string>
<string name="TLA_menu_settings">Ρυθμίσεις</string>
<string name="TLA_custom">Προσαρμοσμένο</string>
<string name="TAd_hiddenFormat">%s [κρυφό]</string>
<string name="TAd_deletedFormat">%s [διαγράφηκε]</string>
<string name="TAd_actionEditTask">Επεξεργασία</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Ordenar</string>
<string name="TLA_menu_search">Buscar</string>
<string name="TLA_menu_settings">Configuración</string>
<string name="TLA_custom">Personalizar</string>
<string name="TAd_hiddenFormat">%s [oculto]</string>
<string name="TAd_deletedFormat">%s [borrado]</string>
<string name="TAd_completed">Terminado\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Trier</string>
<string name="TLA_menu_search">Rechercher</string>
<string name="TLA_menu_settings">Paramètres</string>
<string name="TLA_custom">Personnalisé</string>
<string name="TAd_hiddenFormat">%s [masqué(e)]</string>
<string name="TAd_deletedFormat">%s [supprimé(e)]</string>
<string name="TAd_completed">Accomplie\n%s</string>

@ -35,7 +35,6 @@
<string name="TLA_no_items">Nessuna Attività!</string>
<string name="TLA_menu_search">Cerca</string>
<string name="TLA_menu_settings">Impostazioni</string>
<string name="TLA_custom">Personalizzato</string>
<string name="TAd_hiddenFormat">%s [Nascosto]</string>
<string name="TAd_deletedFormat">%s [eliminato]</string>
<string name="TAd_completed">Terminata\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">מיון</string>
<string name="TLA_menu_search">חיפוש</string>
<string name="TLA_menu_settings">הגדרות</string>
<string name="TLA_custom">מותאם אישית</string>
<string name="TAd_hiddenFormat">%s [מוסתרת]</string>
<string name="TAd_deletedFormat">%s [נמחקה]</string>
<string name="TAd_completed">הסתיימה\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">ソート</string>
<string name="TLA_menu_search">検索</string>
<string name="TLA_menu_settings">設定</string>
<string name="TLA_custom">カスタムフィルタ</string>
<string name="TAd_hiddenFormat">%s [非表示]</string>
<string name="TAd_deletedFormat">%s [削除済]</string>
<string name="TAd_completed">%s\nに完了</string>

@ -39,7 +39,6 @@
<string name="TLA_menu_sort">정렬</string>
<string name="TLA_menu_search">검색</string>
<string name="TLA_menu_settings">설정</string>
<string name="TLA_custom">사용자 설정</string>
<string name="TAd_hiddenFormat">%s [숨김]</string>
<string name="TAd_deletedFormat">%s [지움]</string>
<string name="TAd_completed">일정 완료\n%s</string>

@ -28,7 +28,6 @@
<string name="WID_dateButtonUnset">Klikk for å sette</string>
<string name="TLA_menu_sort">Sorter &amp; Skjult</string>
<string name="TLA_menu_settings">Innstillinger</string>
<string name="TLA_custom">Egendefinert</string>
<string name="TAd_hiddenFormat">%s [skjult]</string>
<string name="TAd_deletedFormat">%s [slettet]</string>
<string name="TAd_actionEditTask">Rediger</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Sorteren</string>
<string name="TLA_menu_search">Zoek</string>
<string name="TLA_menu_settings">Instellingen</string>
<string name="TLA_custom">Aangepast</string>
<string name="TAd_hiddenFormat">%s [verborgen]</string>
<string name="TAd_deletedFormat">%s [verwijderd]</string>
<string name="TAd_completed">Afgerond\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Sortowanie</string>
<string name="TLA_menu_search">Szukaj</string>
<string name="TLA_menu_settings">Ustawienia</string>
<string name="TLA_custom">Własny filtr</string>
<string name="TAd_hiddenFormat">%s [ukryte]</string>
<string name="TAd_deletedFormat">%s [usunięte]</string>
<string name="TAd_completed">Ukończono\n%s</string>

@ -35,7 +35,6 @@
<string name="TLA_menu_sort">Ordenar</string>
<string name="TLA_menu_search">Buscar</string>
<string name="TLA_menu_settings">Configurações</string>
<string name="TLA_custom">Personalizar</string>
<string name="TAd_hiddenFormat">%s [oculta]</string>
<string name="TAd_deletedFormat">%s [excluída]</string>
<string name="TAd_completed">Concluída\n%s</string>

@ -38,7 +38,6 @@
<string name="TLA_menu_sort">Ordenação</string>
<string name="TLA_menu_search">Procura</string>
<string name="TLA_menu_settings">Definições</string>
<string name="TLA_custom">Personalizado</string>
<string name="TAd_hiddenFormat">%s [oculta]</string>
<string name="TAd_deletedFormat">%s [eliminada]</string>
<string name="TAd_completed">Terminada\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Сортировка</string>
<string name="TLA_menu_search">Поиск</string>
<string name="TLA_menu_settings">Настройки</string>
<string name="TLA_custom">Другой</string>
<string name="TAd_hiddenFormat">%s [скрыта]</string>
<string name="TAd_deletedFormat">%s [удалена]</string>
<string name="TAd_completed">Завершена\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Triediť</string>
<string name="TLA_menu_search">Hľadať</string>
<string name="TLA_menu_settings">Nastavenia</string>
<string name="TLA_custom">Vlastné</string>
<string name="TAd_hiddenFormat">%s [skryté]</string>
<string name="TAd_deletedFormat">%s [vymazané]</string>
<string name="TAd_completed">Dokončené\n%s</string>

@ -39,7 +39,6 @@
<string name="TLA_menu_sort">Razvrsti</string>
<string name="TLA_menu_search">Iskanje</string>
<string name="TLA_menu_settings">Nastavitve</string>
<string name="TLA_custom">Po meri</string>
<string name="TAd_hiddenFormat">%s [skrit]</string>
<string name="TAd_deletedFormat">%s [zbrisan]</string>
<string name="TAd_completed">Opravljen\n%s</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">Sortera</string>
<string name="TLA_menu_search">Sök</string>
<string name="TLA_menu_settings">Inställningar</string>
<string name="TLA_custom">Egendefinierad</string>
<string name="TAd_hiddenFormat">%s [dold]</string>
<string name="TAd_deletedFormat">%s [raderad]</string>
<string name="TAd_completed">Avslutad\n%s</string>

@ -21,7 +21,6 @@
<string name="WID_dateButtonUnset">คลิก เพื่อตั้งค่า</string>
<string name="TLA_no_items">ไม่มีแผนงานใดๆ !</string>
<string name="TLA_menu_sort">Sort &amp; Hidden</string>
<string name="TLA_custom">ปรับแต่ง</string>
<string name="TAd_actionEditTask">แก้ไข</string>
<string name="TAd_contextUndeleteTask">แผนงานที่ลบไม่ได้</string>
<string name="SSD_completed">แสดงแผนงานที่เสร็จแล้ว</string>

@ -35,7 +35,6 @@
<string name="TLA_no_items">Hiç göreviniz yok! \n Bir şeyler eklemek nasıl olur?</string>
<string name="TLA_menu_search">Ara</string>
<string name="TLA_menu_settings">Ayarlar</string>
<string name="TLA_custom">Özel</string>
<string name="TAd_hiddenFormat">%s [gizli]</string>
<string name="TAd_deletedFormat">%s [silinmiş]</string>
<string name="TAd_completed">Bitti\n%s</string>

@ -39,7 +39,6 @@
<string name="TLA_menu_sort">Сортувати</string>
<string name="TLA_menu_search">Пошук</string>
<string name="TLA_menu_settings">Налаштування</string>
<string name="TLA_custom">Користувальницький</string>
<string name="TAd_hiddenFormat">%s [приховано]</string>
<string name="TAd_deletedFormat">%s [видалено]</string>
<string name="TAd_completed">Завершено\n%s</string>

@ -35,7 +35,6 @@
<string name="TLA_no_items">你没有任务</string>
<string name="TLA_menu_search">搜索</string>
<string name="TLA_menu_settings">设置</string>
<string name="TLA_custom">自定义</string>
<string name="TAd_hiddenFormat">%s [已隐藏]</string>
<string name="TAd_deletedFormat">%s [已删除]</string>
<string name="TAd_completed">完成\n%s 项</string>

@ -36,7 +36,6 @@
<string name="TLA_menu_sort">排序</string>
<string name="TLA_menu_search">搜索</string>
<string name="TLA_menu_settings">設定</string>
<string name="TLA_custom">自訂</string>
<string name="TAd_hiddenFormat">%s [隱藏]</string>
<string name="TAd_deletedFormat">%s [刪除]</string>
<string name="TAd_completed">%s\n完成</string>

@ -49,9 +49,6 @@
<!-- Menu: Settings -->
<string name="TLA_menu_settings">Settings</string>
<!-- Window title for displaying Custom Filter -->
<string name="TLA_custom">Custom</string>
<!-- ====================================================== TaskAdapter == -->
<!-- Format string to indicate task is hidden (%s => task name) -->

Loading…
Cancel
Save