archive
/
tasks
mirror of https://github.com/tasks/tasks
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix warnings

Browse Source
pull/14/head
Tim Su 15 years ago
parent bb815e145a
commit b4df3c325d
6 changed files with 104 additions and 102 deletions
Show Stats Download Patch File Download Diff File

9
astrid/common-src/com/localytics/android/DatapointHelper.java
Unescape Escape View File

@ -21,18 +21,19 @@ import java.util.TimeZone;
import android.content.Context;
import android.content.pm.PackageManager;
import android.net.wifi.WifiManager;
import android.provider.Settings.System;
import android.telephony.TelephonyManager;
import android.util.Log;
import android.provider.Settings.System;
/**
* Provides a number of static functions to aid in the collection and formatting
* of datapoints.
* @author Localytics
*/
@SuppressWarnings("nls")
public final class DatapointHelper
{
// This class should never be instantiated
private DatapointHelper() { }
private DatapointHelper() { /**/ }
private static final String LOG_PREFIX = "(DatapointHelper) ";
private static final String DROID2_ANDROID_ID = "9774d56d682e549c";
@ -231,7 +232,7 @@ public final class DatapointHelper
return "wifi";
}
}
catch (Exception e) { }
catch (Exception e) { /**/ }
switch (telephonyManager.getNetworkType())
{
@ -289,7 +290,7 @@ public final class DatapointHelper
int startRead = 0; // Index to start reading at
int stopRead = 0; // Index characters get read from and where the substring ends
int bufferLength = rawString.length();
int bufferLength = rawString == null ? 0 : rawString.length();
if (rawString == null)
{

20
astrid/common-src/com/localytics/android/LocalyticsSession.java
Unescape Escape View File

@ -11,26 +11,25 @@
package com.localytics.android;
import android.content.Context;
import android.telephony.TelephonyManager;
import android.util.Log;
import android.os.Build;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileOutputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.FilenameFilter;
import java.io.IOException;
import java.io.OutputStream;
import java.util.Arrays;
import java.util.Iterator;
import java.util.Locale;
import java.util.Map;
import java.util.UUID;
import java.util.Arrays;
import android.content.Context;
import android.os.Build;
import android.telephony.TelephonyManager;
import android.util.Log;
/**
* The class which manages creating, collecting, & uploading a Localytics session.
@ -70,6 +69,7 @@ import java.util.Arrays;
* @author Localytics
* @version 1.5
*/
@SuppressWarnings("nls")
public final class LocalyticsSession
{
////////////////////////////////////////
@ -217,7 +217,7 @@ public final class LocalyticsSession
{
fp.createNewFile();
}
catch (IOException e) { }
catch (IOException e) { /**/ }
createOptEvent(false);
}
@ -932,7 +932,7 @@ public final class LocalyticsSession
* Runnable which gets passed to the uploader thread so it can
* notify the library when uploads are complete.
*/
private Runnable uploadComplete = new Runnable()
private final Runnable uploadComplete = new Runnable()
{
public void run()
{

13
astrid/common-src/com/localytics/android/UploaderThread.java
Unescape Escape View File

@ -16,7 +16,6 @@ import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.FileReader;
import java.io.FilenameFilter;
import java.io.IOException;
import java.io.InputStream;
@ -37,13 +36,14 @@ import android.util.Log;
* The thread which handles uploading Localytics data.
* @author Localytics
*/
@SuppressWarnings("nls")
public class UploaderThread extends Thread
{
private Runnable _completeCallback;
private File _localyticsDir;
private String _sessionFilePrefix;
private String _uploaderFilePrefix;
private String _closeFilePrefix;
private final Runnable _completeCallback;
private final File _localyticsDir;
private final String _sessionFilePrefix;
private final String _uploaderFilePrefix;
private final String _closeFilePrefix;
// The Tag used in logging.
private final static String LOG_TAG = "Localytics_uploader";
@ -85,6 +85,7 @@ public class UploaderThread extends Thread
* Renames all the session files (so that other threads can keep writing
* datapoints without affecting the upload. And then uploads them.
*/
@Override
public void run()
{
int numFilesToUpload = 0;

2
astrid/plugin-src/com/todoroo/astrid/actfm/sync/ActFmSyncService.java
Unescape Escape View File

@ -819,7 +819,7 @@ public final class ActFmSyncService {
model.setValue(Task.TITLE, json.getString("title"));
model.setValue(Task.IMPORTANCE, json.getInt("importance"));
model.setValue(Task.DUE_DATE,
model.createDueDate(Task.URGENCY_SPECIFIC_DAY, readDate(json, "due")));
Task.createDueDate(Task.URGENCY_SPECIFIC_DAY, readDate(json, "due")));
model.setValue(Task.COMPLETION_DATE, readDate(json, "completed_at"));
model.setValue(Task.CREATION_DATE, readDate(json, "created_at"));
model.setValue(Task.DELETION_DATE, readDate(json, "deleted_at"));

4
astrid/plugin-src/com/todoroo/astrid/producteev/sync/ProducteevSyncProvider.java
Unescape Escape View File

@ -365,9 +365,9 @@ public class ProducteevSyncProvider extends SyncProvider<ProducteevTaskContainer
long dueDate = ApiUtilities.producteevToUnixTime(remoteTask.getString("deadline"), 0);
if(remoteTask.optInt("all_day", 0) == 1)
task.setValue(Task.DUE_DATE, task.createDueDate(Task.URGENCY_SPECIFIC_DAY, dueDate));
task.setValue(Task.DUE_DATE, Task.createDueDate(Task.URGENCY_SPECIFIC_DAY, dueDate));
else
task.setValue(Task.DUE_DATE, task.createDueDate(Task.URGENCY_SPECIFIC_DAY_TIME, dueDate));
task.setValue(Task.DUE_DATE, Task.createDueDate(Task.URGENCY_SPECIFIC_DAY_TIME, dueDate));
task.setValue(Task.IMPORTANCE, 5 - remoteTask.getInt("star"));
JSONArray labels = remoteTask.getJSONArray("labels");

2
astrid/src/com/todoroo/astrid/dao/TaskDao.java
Unescape Escape View File

@ -191,7 +191,7 @@ public class TaskDao extends DatabaseDao<Task> {
if(!item.containsValue(Task.DUE_DATE)) {
int setting = Preferences.getIntegerFromString(R.string.p_default_urgency_key,
Task.URGENCY_NONE);
item.setValue(Task.DUE_DATE, item.createDueDate(setting, 0));
item.setValue(Task.DUE_DATE, Task.createDueDate(setting, 0));
}
if(!item.containsValue(Task.HIDE_UNTIL)) {
int setting = Preferences.getIntegerFromString(R.string.p_default_hideUntil_key,

Write Preview
Loading…
Cancel
Save