Fix clearing task fragments

app/src/main/java/com/todoroo/astrid/activity/MainActivity.kt

@@ -356,9 +356,7 @@ class MainActivity : InjectingAppCompatActivity(), TaskListFragmentCallbackHandl
         if (task == null) {
             return
         }
-        taskEditFragment?.let {
+        taskEditFragment?.save(remove = false)
-            it.save()
-        }
         clearUi()
         coroutineScope {
             val freshTask = async { if (task.isNew) task else taskDao.fetch(task.id) ?: task }

app/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.kt

@@ -326,7 +326,7 @@ class TaskEditFragment : Fragment(), Toolbar.OnMenuItemClickListener {
         return model
     }
 
-    suspend fun save() = editViewModel.save()
+    suspend fun save(remove: Boolean = true) = editViewModel.save(remove)
 
     /*
    * ======================================================================

app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.kt

@@ -673,7 +673,7 @@ class TaskListFragment : Fragment(), OnRefreshListener, Toolbar.OnMenuItemClickL
         return onOptionsItemSelected(item)
     }
 
-    fun onTaskListItemClicked(task: Task?) = lifecycleScope.launch {
+    private fun onTaskListItemClicked(task: Task?) = lifecycleScope.launch {
         callbacks.onTaskListItemClicked(task)
     }
 

app/src/main/java/org/tasks/ui/TaskEditViewModel.kt

@@ -319,15 +319,15 @@ class TaskEditViewModel @Inject constructor(
                 originalAlarms.toHashSet() != selectedAlarms.value.toHashSet()
 
     @MainThread
-    suspend fun save(): Boolean = withContext(NonCancellable) {
+    suspend fun save(remove: Boolean = true): Boolean = withContext(NonCancellable) {
         if (cleared) {
             return@withContext false
         }
         if (!hasChanges()) {
-            discard()
+            discard(remove)
             return@withContext false
         }
-        clear()
+        clear(remove)
         task.title = if (title.isNullOrBlank()) context.getString(R.string.no_title) else title
         task.dueDate = dueDate!!
         task.priority = priority!!
@@ -468,17 +468,20 @@ class TaskEditViewModel @Inject constructor(
         discard()
     }
 
-    suspend fun discard() {
+    suspend fun discard(remove: Boolean = true) {
         if (task.isNew) {
             timerPlugin.stopTimer(task)
         }
-        clear()
+        clear(remove)
     }
 
     @MainThread
-    suspend fun clear() {
+    suspend fun clear(remove: Boolean = true) {
-        if (!cleared) {
+        if (cleared) {
+            return
+        }
         cleared = true
+        if (remove) {
             mainActivityEvents.emit(MainActivityEvent.ClearTaskEditFragment)
         }
     }
@@ -486,7 +489,7 @@ class TaskEditViewModel @Inject constructor(
     override fun onCleared() {
         if (!cleared) {
             runBlocking {
-                save()
+                save(remove = false)
             }
         }
     }